{"action":"created","comment":{"url":"https://api.github.com/repos/serokell/blockchain-util/pulls/comments/232172245","pull_request_review_id":173306871,"id":232172245,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjE3MjI0NQ==","diff_hunk":"@@ -24,42 +24,21 @@ import           Snowdrop.Block.Types (Block (..), BlockRef, BlockUndo,\n --  (including tip block, currently adopted \"best\" chain),\n --  while state contains actual blockchain state\n --  as result of application of currently adopted \"best\" chain on initial blockchain state.\n-data BlkStateConfiguration blkType m = BlkStateConfiguration\n-    { bscApplyPayload :: Payload blkType -> m (BlockUndo blkType)\n-    -- ^ Apply block payload to state. Note, that this method encapsulates validation of\n-    -- payload (and inidividual transactions contained in it) as well as actual application\n-    -- of payload to state.\n-    -- Payload application produces an undo object, which may further be used to revert\n-    -- the changes of payload application.\n-\n-    , bscExpand       :: RawBlk blkType -> m (Block (BlockHeader blkType) (Payload blkType))\n-    -- ^ Expand raw block\n-\n-    , bscApplyUndo    :: BlockUndo blkType -> m ()\n-    -- ^ Apply undo: revert changes made by application of block,\n-    -- which produced the passed undo object.\n-\n-    , bscRemoveBlund  :: BlockRef blkType -> m ()\n-    -- ^ Remove block from block storage\n-\n-    , bscStoreBlund   :: RawBlund blkType -> m ()\n-    -- ^ Store block along with undo in block storage\n-\n-    , bscGetBlund     :: BlockRef blkType\n-                      -> m (Maybe (RawBlund blkType))\n-    -- ^ Retrieve block along with undo from block storage\n-\n-    , bscBlockExists  :: BlockRef blkType -> m Bool\n-    -- ^ Check on whether block with given reference exists in block storage\n-\n-    , bscGetTip       :: m (Maybe (BlockRef blkType))\n-    -- ^ Retrieve tip block reference\n-    -- (`Nothing` in case of empty chain being a currently adopted \"best\" chain)\n-\n-    , bscSetTip       :: Maybe (BlockRef blkType) -> m ()\n-    -- ^ Update tip block reference for new adopted \"best\" chain\n-    -- (`Nothing` in case of empty chain)\n-    \n-    , bscConfig       :: BlkConfiguration blkType\n-    -- ^ Configuration for block sequence validation\n+data BlkStateConfiguration chgAccum blkType m = BlkStateConfiguration\n+    { bscExpandHeaders   :: chgAccum -> [ RawBlk blkType ] -> m ( OldestFirst [] (BlockHeader blkType) )\n+    -- ^ Required for step 1","path":"snowdrop-block/src/Snowdrop/Block/StateConfiguration.hs","position":55,"original_position":55,"commit_id":"d6d947903b245095262448998a20db08158cdd01","original_commit_id":"fd94805650a36f1744d247a4d48010d30d5fab26","user":{"login":"georgeee","id":1295394,"node_id":"MDQ6VXNlcjEyOTUzOTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1295394?v=4","gravatar_id":"","url":"https://api.github.com/users/georgeee","html_url":"https://github.com/georgeee","followers_url":"https://api.github.com/users/georgeee/followers","following_url":"https://api.github.com/users/georgeee/following{/other_user}","gists_url":"https://api.github.com/users/georgeee/gists{/gist_id}","starred_url":"https://api.github.com/users/georgeee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgeee/subscriptions","organizations_url":"https://api.github.com/users/georgeee/orgs","repos_url":"https://api.github.com/users/georgeee/repos","events_url":"https://api.github.com/users/georgeee/events{/privacy}","received_events_url":"https://api.github.com/users/georgeee/received_events","type":"User","site_admin":false},"body":"As in haddock steps are not mentioned, the Haddock shall be rewritten. Either add all steps to the Haddock for the type or inline short descriptions of steps into Haddocks for the fields. Perhaps, both will be beneficial.","created_at":"2018-11-09T08:26:30Z","updated_at":"2018-11-09T08:57:33Z","html_url":"https://github.com/serokell/blockchain-util/pull/44#discussion_r232172245","pull_request_url":"https://api.github.com/repos/serokell/blockchain-util/pulls/44","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/serokell/blockchain-util/pulls/comments/232172245"},"html":{"href":"https://github.com/serokell/blockchain-util/pull/44#discussion_r232172245"},"pull_request":{"href":"https://api.github.com/repos/serokell/blockchain-util/pulls/44"}}},"pull_request":{"url":"https://api.github.com/repos/serokell/blockchain-util/pulls/44","id":229533125,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NTMzMTI1","html_url":"https://github.com/serokell/blockchain-util/pull/44","diff_url":"https://github.com/serokell/blockchain-util/pull/44.diff","patch_url":"https://github.com/serokell/blockchain-util/pull/44.patch","issue_url":"https://api.github.com/repos/serokell/blockchain-util/issues/44","number":44,"state":"open","locked":false,"title":"SD-175 Change block configuration data type","user":{"login":"VlachJosef","id":5246747,"node_id":"MDQ6VXNlcjUyNDY3NDc=","avatar_url":"https://avatars3.githubusercontent.com/u/5246747?v=4","gravatar_id":"","url":"https://api.github.com/users/VlachJosef","html_url":"https://github.com/VlachJosef","followers_url":"https://api.github.com/users/VlachJosef/followers","following_url":"https://api.github.com/users/VlachJosef/following{/other_user}","gists_url":"https://api.github.com/users/VlachJosef/gists{/gist_id}","starred_url":"https://api.github.com/users/VlachJosef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VlachJosef/subscriptions","organizations_url":"https://api.github.com/users/VlachJosef/orgs","repos_url":"https://api.github.com/users/VlachJosef/repos","events_url":"https://api.github.com/users/VlachJosef/events{/privacy}","received_events_url":"https://api.github.com/users/VlachJosef/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-08T22:44:08Z","updated_at":"2018-11-09T08:57:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec178c920a66ae33e6867bf01b8c783b81749974","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/serokell/blockchain-util/pulls/44/commits","review_comments_url":"https://api.github.com/repos/serokell/blockchain-util/pulls/44/comments","review_comment_url":"https://api.github.com/repos/serokell/blockchain-util/pulls/comments{/number}","comments_url":"https://api.github.com/repos/serokell/blockchain-util/issues/44/comments","statuses_url":"https://api.github.com/repos/serokell/blockchain-util/statuses/d6d947903b245095262448998a20db08158cdd01","head":{"label":"serokell:jv/sd-175","ref":"jv/sd-175","sha":"d6d947903b245095262448998a20db08158cdd01","user":{"login":"serokell","id":13840520,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODQwNTIw","avatar_url":"https://avatars2.githubusercontent.com/u/13840520?v=4","gravatar_id":"","url":"https://api.github.com/users/serokell","html_url":"https://github.com/serokell","followers_url":"https://api.github.com/users/serokell/followers","following_url":"https://api.github.com/users/serokell/following{/other_user}","gists_url":"https://api.github.com/users/serokell/gists{/gist_id}","starred_url":"https://api.github.com/users/serokell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serokell/subscriptions","organizations_url":"https://api.github.com/users/serokell/orgs","repos_url":"https://api.github.com/users/serokell/repos","events_url":"https://api.github.com/users/serokell/events{/privacy}","received_events_url":"https://api.github.com/users/serokell/received_events","type":"Organization","site_admin":false},"repo":{"id":145829074,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU4MjkwNzQ=","name":"blockchain-util","full_name":"serokell/blockchain-util","private":false,"owner":{"login":"serokell","id":13840520,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODQwNTIw","avatar_url":"https://avatars2.githubusercontent.com/u/13840520?v=4","gravatar_id":"","url":"https://api.github.com/users/serokell","html_url":"https://github.com/serokell","followers_url":"https://api.github.com/users/serokell/followers","following_url":"https://api.github.com/users/serokell/following{/other_user}","gists_url":"https://api.github.com/users/serokell/gists{/gist_id}","starred_url":"https://api.github.com/users/serokell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serokell/subscriptions","organizations_url":"https://api.github.com/users/serokell/orgs","repos_url":"https://api.github.com/users/serokell/repos","events_url":"https://api.github.com/users/serokell/events{/privacy}","received_events_url":"https://api.github.com/users/serokell/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/serokell/blockchain-util","description":null,"fork":false,"url":"https://api.github.com/repos/serokell/blockchain-util","forks_url":"https://api.github.com/repos/serokell/blockchain-util/forks","keys_url":"https://api.github.com/repos/serokell/blockchain-util/keys{/key_id}","collaborators_url":"https://api.github.com/repos/serokell/blockchain-util/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/serokell/blockchain-util/teams","hooks_url":"https://api.github.com/repos/serokell/blockchain-util/hooks","issue_events_url":"https://api.github.com/repos/serokell/blockchain-util/issues/events{/number}","events_url":"https://api.github.com/repos/serokell/blockchain-util/events","assignees_url":"https://api.github.com/repos/serokell/blockchain-util/assignees{/user}","branches_url":"https://api.github.com/repos/serokell/blockchain-util/branches{/branch}","tags_url":"https://api.github.com/repos/serokell/blockchain-util/tags","blobs_url":"https://api.github.com/repos/serokell/blockchain-util/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/serokell/blockchain-util/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/serokell/blockchain-util/git/refs{/sha}","trees_url":"https://api.github.com/repos/serokell/blockchain-util/git/trees{/sha}","statuses_url":"https://api.github.com/repos/serokell/blockchain-util/statuses/{sha}","languages_url":"https://api.github.com/repos/serokell/blockchain-util/languages","stargazers_url":"https://api.github.com/repos/serokell/blockchain-util/stargazers","contributors_url":"https://api.github.com/repos/serokell/blockchain-util/contributors","subscribers_url":"https://api.github.com/repos/serokell/blockchain-util/subscribers","subscription_url":"https://api.github.com/repos/serokell/blockchain-util/subscription","commits_url":"https://api.github.com/repos/serokell/blockchain-util/commits{/sha}","git_commits_url":"https://api.github.com/repos/serokell/blockchain-util/git/commits{/sha}","comments_url":"https://api.github.com/repos/serokell/blockchain-util/comments{/number}","issue_comment_url":"https://api.github.com/repos/serokell/blockchain-util/issues/comments{/number}","contents_url":"https://api.github.com/repos/serokell/blockchain-util/contents/{+path}","compare_url":"https://api.github.com/repos/serokell/blockchain-util/compare/{base}...{head}","merges_url":"https://api.github.com/repos/serokell/blockchain-util/merges","archive_url":"https://api.github.com/repos/serokell/blockchain-util/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/serokell/blockchain-util/downloads","issues_url":"https://api.github.com/repos/serokell/blockchain-util/issues{/number}","pulls_url":"https://api.github.com/repos/serokell/blockchain-util/pulls{/number}","milestones_url":"https://api.github.com/repos/serokell/blockchain-util/milestones{/number}","notifications_url":"https://api.github.com/repos/serokell/blockchain-util/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/serokell/blockchain-util/labels{/name}","releases_url":"https://api.github.com/repos/serokell/blockchain-util/releases{/id}","deployments_url":"https://api.github.com/repos/serokell/blockchain-util/deployments","created_at":"2018-08-23T09:07:29Z","updated_at":"2018-10-29T08:26:45Z","pushed_at":"2018-11-09T08:06:17Z","git_url":"git://github.com/serokell/blockchain-util.git","ssh_url":"git@github.com:serokell/blockchain-util.git","clone_url":"https://github.com/serokell/blockchain-util.git","svn_url":"https://github.com/serokell/blockchain-util","homepage":null,"size":457,"stargazers_count":3,"watchers_count":3,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":0,"open_issues":6,"watchers":3,"default_branch":"master"}},"base":{"label":"serokell:master","ref":"master","sha":"023b1423bcb4f4d0694c7845f700df954083d4e1","user":{"login":"serokell","id":13840520,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODQwNTIw","avatar_url":"https://avatars2.githubusercontent.com/u/13840520?v=4","gravatar_id":"","url":"https://api.github.com/users/serokell","html_url":"https://github.com/serokell","followers_url":"https://api.github.com/users/serokell/followers","following_url":"https://api.github.com/users/serokell/following{/other_user}","gists_url":"https://api.github.com/users/serokell/gists{/gist_id}","starred_url":"https://api.github.com/users/serokell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serokell/subscriptions","organizations_url":"https://api.github.com/users/serokell/orgs","repos_url":"https://api.github.com/users/serokell/repos","events_url":"https://api.github.com/users/serokell/events{/privacy}","received_events_url":"https://api.github.com/users/serokell/received_events","type":"Organization","site_admin":false},"repo":{"id":145829074,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU4MjkwNzQ=","name":"blockchain-util","full_name":"serokell/blockchain-util","private":false,"owner":{"login":"serokell","id":13840520,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODQwNTIw","avatar_url":"https://avatars2.githubusercontent.com/u/13840520?v=4","gravatar_id":"","url":"https://api.github.com/users/serokell","html_url":"https://github.com/serokell","followers_url":"https://api.github.com/users/serokell/followers","following_url":"https://api.github.com/users/serokell/following{/other_user}","gists_url":"https://api.github.com/users/serokell/gists{/gist_id}","starred_url":"https://api.github.com/users/serokell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/serokell/subscriptions","organizations_url":"https://api.github.com/users/serokell/orgs","repos_url":"https://api.github.com/users/serokell/repos","events_url":"https://api.github.com/users/serokell/events{/privacy}","received_events_url":"https://api.github.com/users/serokell/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/serokell/blockchain-util","description":null,"fork":false,"url":"https://api.github.com/repos/serokell/blockchain-util","forks_url":"https://api.github.com/repos/serokell/blockchain-util/forks","keys_url":"https://api.github.com/repos/serokell/blockchain-util/keys{/key_id}","collaborators_url":"https://api.github.com/repos/serokell/blockchain-util/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/serokell/blockchain-util/teams","hooks_url":"https://api.github.com/repos/serokell/blockchain-util/hooks","issue_events_url":"https://api.github.com/repos/serokell/blockchain-util/issues/events{/number}","events_url":"https://api.github.com/repos/serokell/blockchain-util/events","assignees_url":"https://api.github.com/repos/serokell/blockchain-util/assignees{/user}","branches_url":"https://api.github.com/repos/serokell/blockchain-util/branches{/branch}","tags_url":"https://api.github.com/repos/serokell/blockchain-util/tags","blobs_url":"https://api.github.com/repos/serokell/blockchain-util/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/serokell/blockchain-util/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/serokell/blockchain-util/git/refs{/sha}","trees_url":"https://api.github.com/repos/serokell/blockchain-util/git/trees{/sha}","statuses_url":"https://api.github.com/repos/serokell/blockchain-util/statuses/{sha}","languages_url":"https://api.github.com/repos/serokell/blockchain-util/languages","stargazers_url":"https://api.github.com/repos/serokell/blockchain-util/stargazers","contributors_url":"https://api.github.com/repos/serokell/blockchain-util/contributors","subscribers_url":"https://api.github.com/repos/serokell/blockchain-util/subscribers","subscription_url":"https://api.github.com/repos/serokell/blockchain-util/subscription","commits_url":"https://api.github.com/repos/serokell/blockchain-util/commits{/sha}","git_commits_url":"https://api.github.com/repos/serokell/blockchain-util/git/commits{/sha}","comments_url":"https://api.github.com/repos/serokell/blockchain-util/comments{/number}","issue_comment_url":"https://api.github.com/repos/serokell/blockchain-util/issues/comments{/number}","contents_url":"https://api.github.com/repos/serokell/blockchain-util/contents/{+path}","compare_url":"https://api.github.com/repos/serokell/blockchain-util/compare/{base}...{head}","merges_url":"https://api.github.com/repos/serokell/blockchain-util/merges","archive_url":"https://api.github.com/repos/serokell/blockchain-util/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/serokell/blockchain-util/downloads","issues_url":"https://api.github.com/repos/serokell/blockchain-util/issues{/number}","pulls_url":"https://api.github.com/repos/serokell/blockchain-util/pulls{/number}","milestones_url":"https://api.github.com/repos/serokell/blockchain-util/milestones{/number}","notifications_url":"https://api.github.com/repos/serokell/blockchain-util/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/serokell/blockchain-util/labels{/name}","releases_url":"https://api.github.com/repos/serokell/blockchain-util/releases{/id}","deployments_url":"https://api.github.com/repos/serokell/blockchain-util/deployments","created_at":"2018-08-23T09:07:29Z","updated_at":"2018-10-29T08:26:45Z","pushed_at":"2018-11-09T08:06:17Z","git_url":"git://github.com/serokell/blockchain-util.git","ssh_url":"git@github.com:serokell/blockchain-util.git","clone_url":"https://github.com/serokell/blockchain-util.git","svn_url":"https://github.com/serokell/blockchain-util","homepage":null,"size":457,"stargazers_count":3,"watchers_count":3,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":0,"open_issues":6,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/serokell/blockchain-util/pulls/44"},"html":{"href":"https://github.com/serokell/blockchain-util/pull/44"},"issue":{"href":"https://api.github.com/repos/serokell/blockchain-util/issues/44"},"comments":{"href":"https://api.github.com/repos/serokell/blockchain-util/issues/44/comments"},"review_comments":{"href":"https://api.github.com/repos/serokell/blockchain-util/pulls/44/comments"},"review_comment":{"href":"https://api.github.com/repos/serokell/blockchain-util/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/serokell/blockchain-util/pulls/44/commits"},"statuses":{"href":"https://api.github.com/repos/serokell/blockchain-util/statuses/d6d947903b245095262448998a20db08158cdd01"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"georgeee"}}