{"action":"created","comment":{"url":"https://api.github.com/repos/robmaz/distmap/pulls/comments/170118453","pull_request_review_id":98758025,"id":170118453,"diff_hunk":"@@ -774,22 +767,23 @@ OBSOLETE: picard is distributed in a single file now. Use --picard instead.\n \n =item B<--only-trim>\n \n-This option does nothing. Trimming is now done on upload to the HDFS.\n+OBSOLETE: This option does nothing. Trimming is now done on upload to the HDFS.\n \n \n =item B<--no-trim>","path":"bin/distmap","position":112,"original_position":112,"commit_id":"c55297d9905a385309dc15c0978b4ef3df658c17","original_commit_id":"c55297d9905a385309dc15c0978b4ef3df658c17","user":{"login":"magicDGS","id":7352559,"avatar_url":"https://avatars0.githubusercontent.com/u/7352559?v=4","gravatar_id":"","url":"https://api.github.com/users/magicDGS","html_url":"https://github.com/magicDGS","followers_url":"https://api.github.com/users/magicDGS/followers","following_url":"https://api.github.com/users/magicDGS/following{/other_user}","gists_url":"https://api.github.com/users/magicDGS/gists{/gist_id}","starred_url":"https://api.github.com/users/magicDGS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magicDGS/subscriptions","organizations_url":"https://api.github.com/users/magicDGS/orgs","repos_url":"https://api.github.com/users/magicDGS/repos","events_url":"https://api.github.com/users/magicDGS/events{/privacy}","received_events_url":"https://api.github.com/users/magicDGS/received_events","type":"User","site_admin":false},"body":"I just made it obsolete, but the behavior is still the same... should I really remove all obsolete behavior? In that case, it'll be a breaking change... ","created_at":"2018-02-22T22:49:18Z","updated_at":"2018-02-22T22:49:18Z","html_url":"https://github.com/robmaz/distmap/pull/63#discussion_r170118453","pull_request_url":"https://api.github.com/repos/robmaz/distmap/pulls/63","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/robmaz/distmap/pulls/comments/170118453"},"html":{"href":"https://github.com/robmaz/distmap/pull/63#discussion_r170118453"},"pull_request":{"href":"https://api.github.com/repos/robmaz/distmap/pulls/63"}},"in_reply_to_id":169948182},"pull_request":{"url":"https://api.github.com/repos/robmaz/distmap/pulls/63","id":170726271,"html_url":"https://github.com/robmaz/distmap/pull/63","diff_url":"https://github.com/robmaz/distmap/pull/63.diff","patch_url":"https://github.com/robmaz/distmap/pull/63.patch","issue_url":"https://api.github.com/repos/robmaz/distmap/issues/63","number":63,"state":"open","locked":false,"title":"Extract ReadToolsUtils for version and trimming","user":{"login":"magicDGS","id":7352559,"avatar_url":"https://avatars0.githubusercontent.com/u/7352559?v=4","gravatar_id":"","url":"https://api.github.com/users/magicDGS","html_url":"https://github.com/magicDGS","followers_url":"https://api.github.com/users/magicDGS/followers","following_url":"https://api.github.com/users/magicDGS/following{/other_user}","gists_url":"https://api.github.com/users/magicDGS/gists{/gist_id}","starred_url":"https://api.github.com/users/magicDGS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magicDGS/subscriptions","organizations_url":"https://api.github.com/users/magicDGS/orgs","repos_url":"https://api.github.com/users/magicDGS/repos","events_url":"https://api.github.com/users/magicDGS/events{/privacy}","received_events_url":"https://api.github.com/users/magicDGS/received_events","type":"User","site_admin":false},"body":"Includes:\r\n- Version constant\r\n- Extract method for handle JAVA_OPTS using jar files\r\n- Extract method to get correct arguments for ReadsToDistmap\r\n- Refactor related bin/distmap codepaths\r\n- Update distmap help with obsolete arguments and example with new syntax\r\n\r\nCloses #53 \r\nRelated with #33  ","created_at":"2018-02-22T11:37:48Z","updated_at":"2018-02-22T22:49:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c928e5181e269c4e7974330789a013bb0a3a3244","assignee":{"login":"robmaz","id":31442300,"avatar_url":"https://avatars2.githubusercontent.com/u/31442300?v=4","gravatar_id":"","url":"https://api.github.com/users/robmaz","html_url":"https://github.com/robmaz","followers_url":"https://api.github.com/users/robmaz/followers","following_url":"https://api.github.com/users/robmaz/following{/other_user}","gists_url":"https://api.github.com/users/robmaz/gists{/gist_id}","starred_url":"https://api.github.com/users/robmaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robmaz/subscriptions","organizations_url":"https://api.github.com/users/robmaz/orgs","repos_url":"https://api.github.com/users/robmaz/repos","events_url":"https://api.github.com/users/robmaz/events{/privacy}","received_events_url":"https://api.github.com/users/robmaz/received_events","type":"User","site_admin":false},"assignees":[{"login":"robmaz","id":31442300,"avatar_url":"https://avatars2.githubusercontent.com/u/31442300?v=4","gravatar_id":"","url":"https://api.github.com/users/robmaz","html_url":"https://github.com/robmaz","followers_url":"https://api.github.com/users/robmaz/followers","following_url":"https://api.github.com/users/robmaz/following{/other_user}","gists_url":"https://api.github.com/users/robmaz/gists{/gist_id}","starred_url":"https://api.github.com/users/robmaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robmaz/subscriptions","organizations_url":"https://api.github.com/users/robmaz/orgs","repos_url":"https://api.github.com/users/robmaz/repos","events_url":"https://api.github.com/users/robmaz/events{/privacy}","received_events_url":"https://api.github.com/users/robmaz/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/robmaz/distmap/pulls/63/commits","review_comments_url":"https://api.github.com/repos/robmaz/distmap/pulls/63/comments","review_comment_url":"https://api.github.com/repos/robmaz/distmap/pulls/comments{/number}","comments_url":"https://api.github.com/repos/robmaz/distmap/issues/63/comments","statuses_url":"https://api.github.com/repos/robmaz/distmap/statuses/c55297d9905a385309dc15c0978b4ef3df658c17","head":{"label":"robmaz:dgs_ReadTools_helper_package","ref":"dgs_ReadTools_helper_package","sha":"c55297d9905a385309dc15c0978b4ef3df658c17","user":{"login":"robmaz","id":31442300,"avatar_url":"https://avatars2.githubusercontent.com/u/31442300?v=4","gravatar_id":"","url":"https://api.github.com/users/robmaz","html_url":"https://github.com/robmaz","followers_url":"https://api.github.com/users/robmaz/followers","following_url":"https://api.github.com/users/robmaz/following{/other_user}","gists_url":"https://api.github.com/users/robmaz/gists{/gist_id}","starred_url":"https://api.github.com/users/robmaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robmaz/subscriptions","organizations_url":"https://api.github.com/users/robmaz/orgs","repos_url":"https://api.github.com/users/robmaz/repos","events_url":"https://api.github.com/users/robmaz/events{/privacy}","received_events_url":"https://api.github.com/users/robmaz/received_events","type":"User","site_admin":false},"repo":{"id":109965421,"name":"distmap","full_name":"robmaz/distmap","owner":{"login":"robmaz","id":31442300,"avatar_url":"https://avatars2.githubusercontent.com/u/31442300?v=4","gravatar_id":"","url":"https://api.github.com/users/robmaz","html_url":"https://github.com/robmaz","followers_url":"https://api.github.com/users/robmaz/followers","following_url":"https://api.github.com/users/robmaz/following{/other_user}","gists_url":"https://api.github.com/users/robmaz/gists{/gist_id}","starred_url":"https://api.github.com/users/robmaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robmaz/subscriptions","organizations_url":"https://api.github.com/users/robmaz/orgs","repos_url":"https://api.github.com/users/robmaz/repos","events_url":"https://api.github.com/users/robmaz/events{/privacy}","received_events_url":"https://api.github.com/users/robmaz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/robmaz/distmap","description":null,"fork":false,"url":"https://api.github.com/repos/robmaz/distmap","forks_url":"https://api.github.com/repos/robmaz/distmap/forks","keys_url":"https://api.github.com/repos/robmaz/distmap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robmaz/distmap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robmaz/distmap/teams","hooks_url":"https://api.github.com/repos/robmaz/distmap/hooks","issue_events_url":"https://api.github.com/repos/robmaz/distmap/issues/events{/number}","events_url":"https://api.github.com/repos/robmaz/distmap/events","assignees_url":"https://api.github.com/repos/robmaz/distmap/assignees{/user}","branches_url":"https://api.github.com/repos/robmaz/distmap/branches{/branch}","tags_url":"https://api.github.com/repos/robmaz/distmap/tags","blobs_url":"https://api.github.com/repos/robmaz/distmap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robmaz/distmap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robmaz/distmap/git/refs{/sha}","trees_url":"https://api.github.com/repos/robmaz/distmap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robmaz/distmap/statuses/{sha}","languages_url":"https://api.github.com/repos/robmaz/distmap/languages","stargazers_url":"https://api.github.com/repos/robmaz/distmap/stargazers","contributors_url":"https://api.github.com/repos/robmaz/distmap/contributors","subscribers_url":"https://api.github.com/repos/robmaz/distmap/subscribers","subscription_url":"https://api.github.com/repos/robmaz/distmap/subscription","commits_url":"https://api.github.com/repos/robmaz/distmap/commits{/sha}","git_commits_url":"https://api.github.com/repos/robmaz/distmap/git/commits{/sha}","comments_url":"https://api.github.com/repos/robmaz/distmap/comments{/number}","issue_comment_url":"https://api.github.com/repos/robmaz/distmap/issues/comments{/number}","contents_url":"https://api.github.com/repos/robmaz/distmap/contents/{+path}","compare_url":"https://api.github.com/repos/robmaz/distmap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robmaz/distmap/merges","archive_url":"https://api.github.com/repos/robmaz/distmap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robmaz/distmap/downloads","issues_url":"https://api.github.com/repos/robmaz/distmap/issues{/number}","pulls_url":"https://api.github.com/repos/robmaz/distmap/pulls{/number}","milestones_url":"https://api.github.com/repos/robmaz/distmap/milestones{/number}","notifications_url":"https://api.github.com/repos/robmaz/distmap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robmaz/distmap/labels{/name}","releases_url":"https://api.github.com/repos/robmaz/distmap/releases{/id}","deployments_url":"https://api.github.com/repos/robmaz/distmap/deployments","created_at":"2017-11-08T11:10:42Z","updated_at":"2018-02-21T10:08:29Z","pushed_at":"2018-02-22T12:55:33Z","git_url":"git://github.com/robmaz/distmap.git","ssh_url":"git@github.com:robmaz/distmap.git","clone_url":"https://github.com/robmaz/distmap.git","svn_url":"https://github.com/robmaz/distmap","homepage":null,"size":225776,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":23,"license":null,"forks":0,"open_issues":23,"watchers":0,"default_branch":"master"}},"base":{"label":"robmaz:master","ref":"master","sha":"38e978f3c44e8d915da0b1d330a4985ee32de2bb","user":{"login":"robmaz","id":31442300,"avatar_url":"https://avatars2.githubusercontent.com/u/31442300?v=4","gravatar_id":"","url":"https://api.github.com/users/robmaz","html_url":"https://github.com/robmaz","followers_url":"https://api.github.com/users/robmaz/followers","following_url":"https://api.github.com/users/robmaz/following{/other_user}","gists_url":"https://api.github.com/users/robmaz/gists{/gist_id}","starred_url":"https://api.github.com/users/robmaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robmaz/subscriptions","organizations_url":"https://api.github.com/users/robmaz/orgs","repos_url":"https://api.github.com/users/robmaz/repos","events_url":"https://api.github.com/users/robmaz/events{/privacy}","received_events_url":"https://api.github.com/users/robmaz/received_events","type":"User","site_admin":false},"repo":{"id":109965421,"name":"distmap","full_name":"robmaz/distmap","owner":{"login":"robmaz","id":31442300,"avatar_url":"https://avatars2.githubusercontent.com/u/31442300?v=4","gravatar_id":"","url":"https://api.github.com/users/robmaz","html_url":"https://github.com/robmaz","followers_url":"https://api.github.com/users/robmaz/followers","following_url":"https://api.github.com/users/robmaz/following{/other_user}","gists_url":"https://api.github.com/users/robmaz/gists{/gist_id}","starred_url":"https://api.github.com/users/robmaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robmaz/subscriptions","organizations_url":"https://api.github.com/users/robmaz/orgs","repos_url":"https://api.github.com/users/robmaz/repos","events_url":"https://api.github.com/users/robmaz/events{/privacy}","received_events_url":"https://api.github.com/users/robmaz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/robmaz/distmap","description":null,"fork":false,"url":"https://api.github.com/repos/robmaz/distmap","forks_url":"https://api.github.com/repos/robmaz/distmap/forks","keys_url":"https://api.github.com/repos/robmaz/distmap/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robmaz/distmap/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robmaz/distmap/teams","hooks_url":"https://api.github.com/repos/robmaz/distmap/hooks","issue_events_url":"https://api.github.com/repos/robmaz/distmap/issues/events{/number}","events_url":"https://api.github.com/repos/robmaz/distmap/events","assignees_url":"https://api.github.com/repos/robmaz/distmap/assignees{/user}","branches_url":"https://api.github.com/repos/robmaz/distmap/branches{/branch}","tags_url":"https://api.github.com/repos/robmaz/distmap/tags","blobs_url":"https://api.github.com/repos/robmaz/distmap/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robmaz/distmap/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robmaz/distmap/git/refs{/sha}","trees_url":"https://api.github.com/repos/robmaz/distmap/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robmaz/distmap/statuses/{sha}","languages_url":"https://api.github.com/repos/robmaz/distmap/languages","stargazers_url":"https://api.github.com/repos/robmaz/distmap/stargazers","contributors_url":"https://api.github.com/repos/robmaz/distmap/contributors","subscribers_url":"https://api.github.com/repos/robmaz/distmap/subscribers","subscription_url":"https://api.github.com/repos/robmaz/distmap/subscription","commits_url":"https://api.github.com/repos/robmaz/distmap/commits{/sha}","git_commits_url":"https://api.github.com/repos/robmaz/distmap/git/commits{/sha}","comments_url":"https://api.github.com/repos/robmaz/distmap/comments{/number}","issue_comment_url":"https://api.github.com/repos/robmaz/distmap/issues/comments{/number}","contents_url":"https://api.github.com/repos/robmaz/distmap/contents/{+path}","compare_url":"https://api.github.com/repos/robmaz/distmap/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robmaz/distmap/merges","archive_url":"https://api.github.com/repos/robmaz/distmap/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robmaz/distmap/downloads","issues_url":"https://api.github.com/repos/robmaz/distmap/issues{/number}","pulls_url":"https://api.github.com/repos/robmaz/distmap/pulls{/number}","milestones_url":"https://api.github.com/repos/robmaz/distmap/milestones{/number}","notifications_url":"https://api.github.com/repos/robmaz/distmap/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robmaz/distmap/labels{/name}","releases_url":"https://api.github.com/repos/robmaz/distmap/releases{/id}","deployments_url":"https://api.github.com/repos/robmaz/distmap/deployments","created_at":"2017-11-08T11:10:42Z","updated_at":"2018-02-21T10:08:29Z","pushed_at":"2018-02-22T12:55:33Z","git_url":"git://github.com/robmaz/distmap.git","ssh_url":"git@github.com:robmaz/distmap.git","clone_url":"https://github.com/robmaz/distmap.git","svn_url":"https://github.com/robmaz/distmap","homepage":null,"size":225776,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":23,"license":null,"forks":0,"open_issues":23,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/robmaz/distmap/pulls/63"},"html":{"href":"https://github.com/robmaz/distmap/pull/63"},"issue":{"href":"https://api.github.com/repos/robmaz/distmap/issues/63"},"comments":{"href":"https://api.github.com/repos/robmaz/distmap/issues/63/comments"},"review_comments":{"href":"https://api.github.com/repos/robmaz/distmap/pulls/63/comments"},"review_comment":{"href":"https://api.github.com/repos/robmaz/distmap/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/robmaz/distmap/pulls/63/commits"},"statuses":{"href":"https://api.github.com/repos/robmaz/distmap/statuses/c55297d9905a385309dc15c0978b4ef3df658c17"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"magicDGS"}}