{"action":"created","comment":{"url":"https://api.github.com/repos/prysmaticlabs/prysm/pulls/comments/242360813","pull_request_review_id":185852600,"id":242360813,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjM2MDgxMw==","diff_hunk":"@@ -14,10 +15,8 @@ import (\n \t\"github.com/prysmaticlabs/prysm/shared/params\"\n )\n \n-// IsValidBlock verifies a block is valid according to the ETH 2.0 specification for\n-// validity conditions taking into consideration attestation processing and more.\n-// TODO(#781): Refactor with the new spec validity conditions.\n-func IsValidBlock(\n+// IsValidBlockOld will be DEPRECATED soon.","path":"beacon-chain/core/state/validity_conditions.go","position":16,"original_position":16,"commit_id":"36abc16e7dbbb2e255dd8b2a16d71a5b5b23e9c4","original_commit_id":"eba5bc3331de576ba615cd9f801cb6d54fb2ce64","user":{"login":"prestonvanloon","id":7246818,"node_id":"MDQ6VXNlcjcyNDY4MTg=","avatar_url":"https://avatars1.githubusercontent.com/u/7246818?v=4","gravatar_id":"","url":"https://api.github.com/users/prestonvanloon","html_url":"https://github.com/prestonvanloon","followers_url":"https://api.github.com/users/prestonvanloon/followers","following_url":"https://api.github.com/users/prestonvanloon/following{/other_user}","gists_url":"https://api.github.com/users/prestonvanloon/gists{/gist_id}","starred_url":"https://api.github.com/users/prestonvanloon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestonvanloon/subscriptions","organizations_url":"https://api.github.com/users/prestonvanloon/orgs","repos_url":"https://api.github.com/users/prestonvanloon/repos","events_url":"https://api.github.com/users/prestonvanloon/events{/privacy}","received_events_url":"https://api.github.com/users/prestonvanloon/received_events","type":"User","site_admin":false},"body":"Add another line in that case, please ","created_at":"2018-12-17T23:50:11Z","updated_at":"2018-12-17T23:50:12Z","html_url":"https://github.com/prysmaticlabs/prysm/pull/1083#discussion_r242360813","pull_request_url":"https://api.github.com/repos/prysmaticlabs/prysm/pulls/1083","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/prysmaticlabs/prysm/pulls/comments/242360813"},"html":{"href":"https://github.com/prysmaticlabs/prysm/pull/1083#discussion_r242360813"},"pull_request":{"href":"https://api.github.com/repos/prysmaticlabs/prysm/pulls/1083"}},"in_reply_to_id":242163517},"pull_request":{"url":"https://api.github.com/repos/prysmaticlabs/prysm/pulls/1083","id":237899663,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3ODk5NjYz","html_url":"https://github.com/prysmaticlabs/prysm/pull/1083","diff_url":"https://github.com/prysmaticlabs/prysm/pull/1083.diff","patch_url":"https://github.com/prysmaticlabs/prysm/pull/1083.patch","issue_url":"https://api.github.com/repos/prysmaticlabs/prysm/issues/1083","number":1083,"state":"open","locked":false,"title":"Implement Slot Processing Routine","user":{"login":"nisdas","id":33201827,"node_id":"MDQ6VXNlcjMzMjAxODI3","avatar_url":"https://avatars2.githubusercontent.com/u/33201827?v=4","gravatar_id":"","url":"https://api.github.com/users/nisdas","html_url":"https://github.com/nisdas","followers_url":"https://api.github.com/users/nisdas/followers","following_url":"https://api.github.com/users/nisdas/following{/other_user}","gists_url":"https://api.github.com/users/nisdas/gists{/gist_id}","starred_url":"https://api.github.com/users/nisdas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nisdas/subscriptions","organizations_url":"https://api.github.com/users/nisdas/orgs","repos_url":"https://api.github.com/users/nisdas/repos","events_url":"https://api.github.com/users/nisdas/events{/privacy}","received_events_url":"https://api.github.com/users/nisdas/received_events","type":"User","site_admin":false},"body":"Part of #1077  \r\n\r\n- [x] This will implement a slot processing routine which will supersede block processing in \r\nthe future.\r\n- [x] Add in Tests\r\n\r\nThis PR will not go into slot transitions, which will be covered in the next PR. Also a lot of deprecated routines have been left as they are so as not to break the beacon client, they will only be removed once we have refactored the other parts of the core package such as block operations and changes to attestations. We can then test the client at runtime to determine if it is still functional","created_at":"2018-12-12T03:17:04Z","updated_at":"2018-12-17T23:50:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c2097d6b9fdb1aac5e948f0388463c42dbb79957","assignee":{"login":"nisdas","id":33201827,"node_id":"MDQ6VXNlcjMzMjAxODI3","avatar_url":"https://avatars2.githubusercontent.com/u/33201827?v=4","gravatar_id":"","url":"https://api.github.com/users/nisdas","html_url":"https://github.com/nisdas","followers_url":"https://api.github.com/users/nisdas/followers","following_url":"https://api.github.com/users/nisdas/following{/other_user}","gists_url":"https://api.github.com/users/nisdas/gists{/gist_id}","starred_url":"https://api.github.com/users/nisdas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nisdas/subscriptions","organizations_url":"https://api.github.com/users/nisdas/orgs","repos_url":"https://api.github.com/users/nisdas/repos","events_url":"https://api.github.com/users/nisdas/events{/privacy}","received_events_url":"https://api.github.com/users/nisdas/received_events","type":"User","site_admin":false},"assignees":[{"login":"nisdas","id":33201827,"node_id":"MDQ6VXNlcjMzMjAxODI3","avatar_url":"https://avatars2.githubusercontent.com/u/33201827?v=4","gravatar_id":"","url":"https://api.github.com/users/nisdas","html_url":"https://github.com/nisdas","followers_url":"https://api.github.com/users/nisdas/followers","following_url":"https://api.github.com/users/nisdas/following{/other_user}","gists_url":"https://api.github.com/users/nisdas/gists{/gist_id}","starred_url":"https://api.github.com/users/nisdas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nisdas/subscriptions","organizations_url":"https://api.github.com/users/nisdas/orgs","repos_url":"https://api.github.com/users/nisdas/repos","events_url":"https://api.github.com/users/nisdas/events{/privacy}","received_events_url":"https://api.github.com/users/nisdas/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1085357069,"node_id":"MDU6TGFiZWwxMDg1MzU3MDY5","url":"https://api.github.com/repos/prysmaticlabs/prysm/labels/Priority:%20High","name":"Priority: High","color":"f7ea26","default":false},{"id":1039139798,"node_id":"MDU6TGFiZWwxMDM5MTM5Nzk4","url":"https://api.github.com/repos/prysmaticlabs/prysm/labels/Ready%20For%20Review","name":"Ready For Review","color":"f4ad6b","default":false}],"milestone":{"url":"https://api.github.com/repos/prysmaticlabs/prysm/milestones/5","html_url":"https://github.com/prysmaticlabs/prysm/milestone/5","labels_url":"https://api.github.com/repos/prysmaticlabs/prysm/milestones/5/labels","id":3723731,"node_id":"MDk6TWlsZXN0b25lMzcyMzczMQ==","number":5,"title":"Ruby - v0.1","description":"","creator":{"login":"prestonvanloon","id":7246818,"node_id":"MDQ6VXNlcjcyNDY4MTg=","avatar_url":"https://avatars1.githubusercontent.com/u/7246818?v=4","gravatar_id":"","url":"https://api.github.com/users/prestonvanloon","html_url":"https://github.com/prestonvanloon","followers_url":"https://api.github.com/users/prestonvanloon/followers","following_url":"https://api.github.com/users/prestonvanloon/following{/other_user}","gists_url":"https://api.github.com/users/prestonvanloon/gists{/gist_id}","starred_url":"https://api.github.com/users/prestonvanloon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prestonvanloon/subscriptions","organizations_url":"https://api.github.com/users/prestonvanloon/orgs","repos_url":"https://api.github.com/users/prestonvanloon/repos","events_url":"https://api.github.com/users/prestonvanloon/events{/privacy}","received_events_url":"https://api.github.com/users/prestonvanloon/received_events","type":"User","site_admin":false},"open_issues":13,"closed_issues":61,"state":"open","created_at":"2018-10-09T10:37:13Z","updated_at":"2018-12-17T23:07:56Z","due_on":"2018-12-31T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/prysmaticlabs/prysm/pulls/1083/commits","review_comments_url":"https://api.github.com/repos/prysmaticlabs/prysm/pulls/1083/comments","review_comment_url":"https://api.github.com/repos/prysmaticlabs/prysm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/prysmaticlabs/prysm/issues/1083/comments","statuses_url":"https://api.github.com/repos/prysmaticlabs/prysm/statuses/36abc16e7dbbb2e255dd8b2a16d71a5b5b23e9c4","head":{"label":"nisdas:slotProcessing","ref":"slotProcessing","sha":"36abc16e7dbbb2e255dd8b2a16d71a5b5b23e9c4","user":{"login":"nisdas","id":33201827,"node_id":"MDQ6VXNlcjMzMjAxODI3","avatar_url":"https://avatars2.githubusercontent.com/u/33201827?v=4","gravatar_id":"","url":"https://api.github.com/users/nisdas","html_url":"https://github.com/nisdas","followers_url":"https://api.github.com/users/nisdas/followers","following_url":"https://api.github.com/users/nisdas/following{/other_user}","gists_url":"https://api.github.com/users/nisdas/gists{/gist_id}","starred_url":"https://api.github.com/users/nisdas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nisdas/subscriptions","organizations_url":"https://api.github.com/users/nisdas/orgs","repos_url":"https://api.github.com/users/nisdas/repos","events_url":"https://api.github.com/users/nisdas/events{/privacy}","received_events_url":"https://api.github.com/users/nisdas/received_events","type":"User","site_admin":false},"repo":{"id":117609311,"node_id":"MDEwOlJlcG9zaXRvcnkxMTc2MDkzMTE=","name":"geth-sharding","full_name":"nisdas/geth-sharding","private":false,"owner":{"login":"nisdas","id":33201827,"node_id":"MDQ6VXNlcjMzMjAxODI3","avatar_url":"https://avatars2.githubusercontent.com/u/33201827?v=4","gravatar_id":"","url":"https://api.github.com/users/nisdas","html_url":"https://github.com/nisdas","followers_url":"https://api.github.com/users/nisdas/followers","following_url":"https://api.github.com/users/nisdas/following{/other_user}","gists_url":"https://api.github.com/users/nisdas/gists{/gist_id}","starred_url":"https://api.github.com/users/nisdas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nisdas/subscriptions","organizations_url":"https://api.github.com/users/nisdas/orgs","repos_url":"https://api.github.com/users/nisdas/repos","events_url":"https://api.github.com/users/nisdas/events{/privacy}","received_events_url":"https://api.github.com/users/nisdas/received_events","type":"User","site_admin":false},"html_url":"https://github.com/nisdas/geth-sharding","description":"Go implementation of the Ethereum sharding specification and stateless client","fork":true,"url":"https://api.github.com/repos/nisdas/geth-sharding","forks_url":"https://api.github.com/repos/nisdas/geth-sharding/forks","keys_url":"https://api.github.com/repos/nisdas/geth-sharding/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nisdas/geth-sharding/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nisdas/geth-sharding/teams","hooks_url":"https://api.github.com/repos/nisdas/geth-sharding/hooks","issue_events_url":"https://api.github.com/repos/nisdas/geth-sharding/issues/events{/number}","events_url":"https://api.github.com/repos/nisdas/geth-sharding/events","assignees_url":"https://api.github.com/repos/nisdas/geth-sharding/assignees{/user}","branches_url":"https://api.github.com/repos/nisdas/geth-sharding/branches{/branch}","tags_url":"https://api.github.com/repos/nisdas/geth-sharding/tags","blobs_url":"https://api.github.com/repos/nisdas/geth-sharding/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nisdas/geth-sharding/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nisdas/geth-sharding/git/refs{/sha}","trees_url":"https://api.github.com/repos/nisdas/geth-sharding/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nisdas/geth-sharding/statuses/{sha}","languages_url":"https://api.github.com/repos/nisdas/geth-sharding/languages","stargazers_url":"https://api.github.com/repos/nisdas/geth-sharding/stargazers","contributors_url":"https://api.github.com/repos/nisdas/geth-sharding/contributors","subscribers_url":"https://api.github.com/repos/nisdas/geth-sharding/subscribers","subscription_url":"https://api.github.com/repos/nisdas/geth-sharding/subscription","commits_url":"https://api.github.com/repos/nisdas/geth-sharding/commits{/sha}","git_commits_url":"https://api.github.com/repos/nisdas/geth-sharding/git/commits{/sha}","comments_url":"https://api.github.com/repos/nisdas/geth-sharding/comments{/number}","issue_comment_url":"https://api.github.com/repos/nisdas/geth-sharding/issues/comments{/number}","contents_url":"https://api.github.com/repos/nisdas/geth-sharding/contents/{+path}","compare_url":"https://api.github.com/repos/nisdas/geth-sharding/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nisdas/geth-sharding/merges","archive_url":"https://api.github.com/repos/nisdas/geth-sharding/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nisdas/geth-sharding/downloads","issues_url":"https://api.github.com/repos/nisdas/geth-sharding/issues{/number}","pulls_url":"https://api.github.com/repos/nisdas/geth-sharding/pulls{/number}","milestones_url":"https://api.github.com/repos/nisdas/geth-sharding/milestones{/number}","notifications_url":"https://api.github.com/repos/nisdas/geth-sharding/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nisdas/geth-sharding/labels{/name}","releases_url":"https://api.github.com/repos/nisdas/geth-sharding/releases{/id}","deployments_url":"https://api.github.com/repos/nisdas/geth-sharding/deployments","created_at":"2018-01-16T00:11:47Z","updated_at":"2018-12-04T08:57:25Z","pushed_at":"2018-12-17T21:20:13Z","git_url":"git://github.com/nisdas/geth-sharding.git","ssh_url":"git@github.com:nisdas/geth-sharding.git","clone_url":"https://github.com/nisdas/geth-sharding.git","svn_url":"https://github.com/nisdas/geth-sharding","homepage":"","size":104442,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"prysmaticlabs:master","ref":"master","sha":"03017d195811252ca965b8ed18ca7e1821c4406f","user":{"login":"prysmaticlabs","id":35349758,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MzQ5NzU4","avatar_url":"https://avatars2.githubusercontent.com/u/35349758?v=4","gravatar_id":"","url":"https://api.github.com/users/prysmaticlabs","html_url":"https://github.com/prysmaticlabs","followers_url":"https://api.github.com/users/prysmaticlabs/followers","following_url":"https://api.github.com/users/prysmaticlabs/following{/other_user}","gists_url":"https://api.github.com/users/prysmaticlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/prysmaticlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prysmaticlabs/subscriptions","organizations_url":"https://api.github.com/users/prysmaticlabs/orgs","repos_url":"https://api.github.com/users/prysmaticlabs/repos","events_url":"https://api.github.com/users/prysmaticlabs/events{/privacy}","received_events_url":"https://api.github.com/users/prysmaticlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":117156031,"node_id":"MDEwOlJlcG9zaXRvcnkxMTcxNTYwMzE=","name":"prysm","full_name":"prysmaticlabs/prysm","private":false,"owner":{"login":"prysmaticlabs","id":35349758,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1MzQ5NzU4","avatar_url":"https://avatars2.githubusercontent.com/u/35349758?v=4","gravatar_id":"","url":"https://api.github.com/users/prysmaticlabs","html_url":"https://github.com/prysmaticlabs","followers_url":"https://api.github.com/users/prysmaticlabs/followers","following_url":"https://api.github.com/users/prysmaticlabs/following{/other_user}","gists_url":"https://api.github.com/users/prysmaticlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/prysmaticlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prysmaticlabs/subscriptions","organizations_url":"https://api.github.com/users/prysmaticlabs/orgs","repos_url":"https://api.github.com/users/prysmaticlabs/repos","events_url":"https://api.github.com/users/prysmaticlabs/events{/privacy}","received_events_url":"https://api.github.com/users/prysmaticlabs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/prysmaticlabs/prysm","description":"Go implementation of Ethereum 2.0 - casper & sharding","fork":false,"url":"https://api.github.com/repos/prysmaticlabs/prysm","forks_url":"https://api.github.com/repos/prysmaticlabs/prysm/forks","keys_url":"https://api.github.com/repos/prysmaticlabs/prysm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/prysmaticlabs/prysm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/prysmaticlabs/prysm/teams","hooks_url":"https://api.github.com/repos/prysmaticlabs/prysm/hooks","issue_events_url":"https://api.github.com/repos/prysmaticlabs/prysm/issues/events{/number}","events_url":"https://api.github.com/repos/prysmaticlabs/prysm/events","assignees_url":"https://api.github.com/repos/prysmaticlabs/prysm/assignees{/user}","branches_url":"https://api.github.com/repos/prysmaticlabs/prysm/branches{/branch}","tags_url":"https://api.github.com/repos/prysmaticlabs/prysm/tags","blobs_url":"https://api.github.com/repos/prysmaticlabs/prysm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/prysmaticlabs/prysm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/prysmaticlabs/prysm/git/refs{/sha}","trees_url":"https://api.github.com/repos/prysmaticlabs/prysm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/prysmaticlabs/prysm/statuses/{sha}","languages_url":"https://api.github.com/repos/prysmaticlabs/prysm/languages","stargazers_url":"https://api.github.com/repos/prysmaticlabs/prysm/stargazers","contributors_url":"https://api.github.com/repos/prysmaticlabs/prysm/contributors","subscribers_url":"https://api.github.com/repos/prysmaticlabs/prysm/subscribers","subscription_url":"https://api.github.com/repos/prysmaticlabs/prysm/subscription","commits_url":"https://api.github.com/repos/prysmaticlabs/prysm/commits{/sha}","git_commits_url":"https://api.github.com/repos/prysmaticlabs/prysm/git/commits{/sha}","comments_url":"https://api.github.com/repos/prysmaticlabs/prysm/comments{/number}","issue_comment_url":"https://api.github.com/repos/prysmaticlabs/prysm/issues/comments{/number}","contents_url":"https://api.github.com/repos/prysmaticlabs/prysm/contents/{+path}","compare_url":"https://api.github.com/repos/prysmaticlabs/prysm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/prysmaticlabs/prysm/merges","archive_url":"https://api.github.com/repos/prysmaticlabs/prysm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/prysmaticlabs/prysm/downloads","issues_url":"https://api.github.com/repos/prysmaticlabs/prysm/issues{/number}","pulls_url":"https://api.github.com/repos/prysmaticlabs/prysm/pulls{/number}","milestones_url":"https://api.github.com/repos/prysmaticlabs/prysm/milestones{/number}","notifications_url":"https://api.github.com/repos/prysmaticlabs/prysm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/prysmaticlabs/prysm/labels{/name}","releases_url":"https://api.github.com/repos/prysmaticlabs/prysm/releases{/id}","deployments_url":"https://api.github.com/repos/prysmaticlabs/prysm/deployments","created_at":"2018-01-11T21:31:33Z","updated_at":"2018-12-17T19:22:48Z","pushed_at":"2018-12-17T23:44:57Z","git_url":"git://github.com/prysmaticlabs/prysm.git","ssh_url":"git@github.com:prysmaticlabs/prysm.git","clone_url":"https://github.com/prysmaticlabs/prysm.git","svn_url":"https://github.com/prysmaticlabs/prysm","homepage":"https://prysmaticlabs.com/","size":86102,"stargazers_count":422,"watchers_count":422,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":88,"mirror_url":null,"archived":false,"open_issues_count":50,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":88,"open_issues":50,"watchers":422,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/prysmaticlabs/prysm/pulls/1083"},"html":{"href":"https://github.com/prysmaticlabs/prysm/pull/1083"},"issue":{"href":"https://api.github.com/repos/prysmaticlabs/prysm/issues/1083"},"comments":{"href":"https://api.github.com/repos/prysmaticlabs/prysm/issues/1083/comments"},"review_comments":{"href":"https://api.github.com/repos/prysmaticlabs/prysm/pulls/1083/comments"},"review_comment":{"href":"https://api.github.com/repos/prysmaticlabs/prysm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/prysmaticlabs/prysm/pulls/1083/commits"},"statuses":{"href":"https://api.github.com/repos/prysmaticlabs/prysm/statuses/36abc16e7dbbb2e255dd8b2a16d71a5b5b23e9c4"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"prestonvanloon"}}