{"action":"created","comment":{"url":"https://api.github.com/repos/basecamp/marginalia/pulls/comments/229735716","pull_request_review_id":170305045,"id":229735716,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTczNTcxNg==","diff_hunk":"@@ -12,7 +12,8 @@\n   if RUBY_VERSION < \"2.4\"\n     installer.install \"mysql\", \">=0\"\n   end\n-rescue\n+rescue StandardError => e\n+  puts(e)","path":"ext/mkrf_conf.rb","position":6,"original_position":6,"commit_id":"efaa62aa26072eb2edf09cc3345ec4e5301d0a13","original_commit_id":"efaa62aa26072eb2edf09cc3345ec4e5301d0a13","user":{"login":"arthurnn","id":833383,"node_id":"MDQ6VXNlcjgzMzM4Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/833383?v=4","gravatar_id":"","url":"https://api.github.com/users/arthurnn","html_url":"https://github.com/arthurnn","followers_url":"https://api.github.com/users/arthurnn/followers","following_url":"https://api.github.com/users/arthurnn/following{/other_user}","gists_url":"https://api.github.com/users/arthurnn/gists{/gist_id}","starred_url":"https://api.github.com/users/arthurnn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arthurnn/subscriptions","organizations_url":"https://api.github.com/users/arthurnn/orgs","repos_url":"https://api.github.com/users/arthurnn/repos","events_url":"https://api.github.com/users/arthurnn/events{/privacy}","received_events_url":"https://api.github.com/users/arthurnn/received_events","type":"User","site_admin":true},"body":"Lets instead remove mysql gem","created_at":"2018-10-31T15:08:46Z","updated_at":"2018-10-31T15:08:46Z","html_url":"https://github.com/basecamp/marginalia/pull/77#discussion_r229735716","pull_request_url":"https://api.github.com/repos/basecamp/marginalia/pulls/77","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/basecamp/marginalia/pulls/comments/229735716"},"html":{"href":"https://github.com/basecamp/marginalia/pull/77#discussion_r229735716"},"pull_request":{"href":"https://api.github.com/repos/basecamp/marginalia/pulls/77"}}},"pull_request":{"url":"https://api.github.com/repos/basecamp/marginalia/pulls/77","id":226342325,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MzQyMzI1","html_url":"https://github.com/basecamp/marginalia/pull/77","diff_url":"https://github.com/basecamp/marginalia/pull/77.diff","patch_url":"https://github.com/basecamp/marginalia/pull/77.patch","issue_url":"https://api.github.com/repos/basecamp/marginalia/issues/77","number":77,"state":"open","locked":false,"title":"Fail loudly if mysql fails to compile","user":{"login":"viraptor","id":188063,"node_id":"MDQ6VXNlcjE4ODA2Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/188063?v=4","gravatar_id":"","url":"https://api.github.com/users/viraptor","html_url":"https://github.com/viraptor","followers_url":"https://api.github.com/users/viraptor/followers","following_url":"https://api.github.com/users/viraptor/following{/other_user}","gists_url":"https://api.github.com/users/viraptor/gists{/gist_id}","starred_url":"https://api.github.com/users/viraptor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viraptor/subscriptions","organizations_url":"https://api.github.com/users/viraptor/orgs","repos_url":"https://api.github.com/users/viraptor/repos","events_url":"https://api.github.com/users/viraptor/events{/privacy}","received_events_url":"https://api.github.com/users/viraptor/received_events","type":"User","site_admin":false},"body":"If the build process exits with error code 1, it should also provide the\r\noutput from the failing build. Otherwise, it's hard to debug the issue\r\nit's running into.","created_at":"2018-10-28T04:33:39Z","updated_at":"2018-10-31T15:08:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d2af8da523184a4459b1fbb135fa1f0e55c17e8d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/basecamp/marginalia/pulls/77/commits","review_comments_url":"https://api.github.com/repos/basecamp/marginalia/pulls/77/comments","review_comment_url":"https://api.github.com/repos/basecamp/marginalia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/basecamp/marginalia/issues/77/comments","statuses_url":"https://api.github.com/repos/basecamp/marginalia/statuses/efaa62aa26072eb2edf09cc3345ec4e5301d0a13","head":{"label":"viraptor:print-installer-issues","ref":"print-installer-issues","sha":"efaa62aa26072eb2edf09cc3345ec4e5301d0a13","user":{"login":"viraptor","id":188063,"node_id":"MDQ6VXNlcjE4ODA2Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/188063?v=4","gravatar_id":"","url":"https://api.github.com/users/viraptor","html_url":"https://github.com/viraptor","followers_url":"https://api.github.com/users/viraptor/followers","following_url":"https://api.github.com/users/viraptor/following{/other_user}","gists_url":"https://api.github.com/users/viraptor/gists{/gist_id}","starred_url":"https://api.github.com/users/viraptor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viraptor/subscriptions","organizations_url":"https://api.github.com/users/viraptor/orgs","repos_url":"https://api.github.com/users/viraptor/repos","events_url":"https://api.github.com/users/viraptor/events{/privacy}","received_events_url":"https://api.github.com/users/viraptor/received_events","type":"User","site_admin":false},"repo":{"id":95066045,"node_id":"MDEwOlJlcG9zaXRvcnk5NTA2NjA0NQ==","name":"marginalia","full_name":"viraptor/marginalia","private":false,"owner":{"login":"viraptor","id":188063,"node_id":"MDQ6VXNlcjE4ODA2Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/188063?v=4","gravatar_id":"","url":"https://api.github.com/users/viraptor","html_url":"https://github.com/viraptor","followers_url":"https://api.github.com/users/viraptor/followers","following_url":"https://api.github.com/users/viraptor/following{/other_user}","gists_url":"https://api.github.com/users/viraptor/gists{/gist_id}","starred_url":"https://api.github.com/users/viraptor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viraptor/subscriptions","organizations_url":"https://api.github.com/users/viraptor/orgs","repos_url":"https://api.github.com/users/viraptor/repos","events_url":"https://api.github.com/users/viraptor/events{/privacy}","received_events_url":"https://api.github.com/users/viraptor/received_events","type":"User","site_admin":false},"html_url":"https://github.com/viraptor/marginalia","description":"Attach comments to ActiveRecord's SQL queries","fork":true,"url":"https://api.github.com/repos/viraptor/marginalia","forks_url":"https://api.github.com/repos/viraptor/marginalia/forks","keys_url":"https://api.github.com/repos/viraptor/marginalia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/viraptor/marginalia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/viraptor/marginalia/teams","hooks_url":"https://api.github.com/repos/viraptor/marginalia/hooks","issue_events_url":"https://api.github.com/repos/viraptor/marginalia/issues/events{/number}","events_url":"https://api.github.com/repos/viraptor/marginalia/events","assignees_url":"https://api.github.com/repos/viraptor/marginalia/assignees{/user}","branches_url":"https://api.github.com/repos/viraptor/marginalia/branches{/branch}","tags_url":"https://api.github.com/repos/viraptor/marginalia/tags","blobs_url":"https://api.github.com/repos/viraptor/marginalia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/viraptor/marginalia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/viraptor/marginalia/git/refs{/sha}","trees_url":"https://api.github.com/repos/viraptor/marginalia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/viraptor/marginalia/statuses/{sha}","languages_url":"https://api.github.com/repos/viraptor/marginalia/languages","stargazers_url":"https://api.github.com/repos/viraptor/marginalia/stargazers","contributors_url":"https://api.github.com/repos/viraptor/marginalia/contributors","subscribers_url":"https://api.github.com/repos/viraptor/marginalia/subscribers","subscription_url":"https://api.github.com/repos/viraptor/marginalia/subscription","commits_url":"https://api.github.com/repos/viraptor/marginalia/commits{/sha}","git_commits_url":"https://api.github.com/repos/viraptor/marginalia/git/commits{/sha}","comments_url":"https://api.github.com/repos/viraptor/marginalia/comments{/number}","issue_comment_url":"https://api.github.com/repos/viraptor/marginalia/issues/comments{/number}","contents_url":"https://api.github.com/repos/viraptor/marginalia/contents/{+path}","compare_url":"https://api.github.com/repos/viraptor/marginalia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/viraptor/marginalia/merges","archive_url":"https://api.github.com/repos/viraptor/marginalia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/viraptor/marginalia/downloads","issues_url":"https://api.github.com/repos/viraptor/marginalia/issues{/number}","pulls_url":"https://api.github.com/repos/viraptor/marginalia/pulls{/number}","milestones_url":"https://api.github.com/repos/viraptor/marginalia/milestones{/number}","notifications_url":"https://api.github.com/repos/viraptor/marginalia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/viraptor/marginalia/labels{/name}","releases_url":"https://api.github.com/repos/viraptor/marginalia/releases{/id}","deployments_url":"https://api.github.com/repos/viraptor/marginalia/deployments","created_at":"2017-06-22T02:26:42Z","updated_at":"2017-06-22T02:26:44Z","pushed_at":"2018-10-28T04:33:29Z","git_url":"git://github.com/viraptor/marginalia.git","ssh_url":"git@github.com:viraptor/marginalia.git","clone_url":"https://github.com/viraptor/marginalia.git","svn_url":"https://github.com/viraptor/marginalia","homepage":"","size":135,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"basecamp:master","ref":"master","sha":"5fae25d0ab09736ba067ce767f48f4614d50f469","user":{"login":"basecamp","id":13131,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTMx","avatar_url":"https://avatars0.githubusercontent.com/u/13131?v=4","gravatar_id":"","url":"https://api.github.com/users/basecamp","html_url":"https://github.com/basecamp","followers_url":"https://api.github.com/users/basecamp/followers","following_url":"https://api.github.com/users/basecamp/following{/other_user}","gists_url":"https://api.github.com/users/basecamp/gists{/gist_id}","starred_url":"https://api.github.com/users/basecamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basecamp/subscriptions","organizations_url":"https://api.github.com/users/basecamp/orgs","repos_url":"https://api.github.com/users/basecamp/repos","events_url":"https://api.github.com/users/basecamp/events{/privacy}","received_events_url":"https://api.github.com/users/basecamp/received_events","type":"Organization","site_admin":false},"repo":{"id":3689879,"node_id":"MDEwOlJlcG9zaXRvcnkzNjg5ODc5","name":"marginalia","full_name":"basecamp/marginalia","private":false,"owner":{"login":"basecamp","id":13131,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTMx","avatar_url":"https://avatars0.githubusercontent.com/u/13131?v=4","gravatar_id":"","url":"https://api.github.com/users/basecamp","html_url":"https://github.com/basecamp","followers_url":"https://api.github.com/users/basecamp/followers","following_url":"https://api.github.com/users/basecamp/following{/other_user}","gists_url":"https://api.github.com/users/basecamp/gists{/gist_id}","starred_url":"https://api.github.com/users/basecamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basecamp/subscriptions","organizations_url":"https://api.github.com/users/basecamp/orgs","repos_url":"https://api.github.com/users/basecamp/repos","events_url":"https://api.github.com/users/basecamp/events{/privacy}","received_events_url":"https://api.github.com/users/basecamp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/basecamp/marginalia","description":"Attach comments to ActiveRecord's SQL queries","fork":false,"url":"https://api.github.com/repos/basecamp/marginalia","forks_url":"https://api.github.com/repos/basecamp/marginalia/forks","keys_url":"https://api.github.com/repos/basecamp/marginalia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/basecamp/marginalia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/basecamp/marginalia/teams","hooks_url":"https://api.github.com/repos/basecamp/marginalia/hooks","issue_events_url":"https://api.github.com/repos/basecamp/marginalia/issues/events{/number}","events_url":"https://api.github.com/repos/basecamp/marginalia/events","assignees_url":"https://api.github.com/repos/basecamp/marginalia/assignees{/user}","branches_url":"https://api.github.com/repos/basecamp/marginalia/branches{/branch}","tags_url":"https://api.github.com/repos/basecamp/marginalia/tags","blobs_url":"https://api.github.com/repos/basecamp/marginalia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/basecamp/marginalia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/basecamp/marginalia/git/refs{/sha}","trees_url":"https://api.github.com/repos/basecamp/marginalia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/basecamp/marginalia/statuses/{sha}","languages_url":"https://api.github.com/repos/basecamp/marginalia/languages","stargazers_url":"https://api.github.com/repos/basecamp/marginalia/stargazers","contributors_url":"https://api.github.com/repos/basecamp/marginalia/contributors","subscribers_url":"https://api.github.com/repos/basecamp/marginalia/subscribers","subscription_url":"https://api.github.com/repos/basecamp/marginalia/subscription","commits_url":"https://api.github.com/repos/basecamp/marginalia/commits{/sha}","git_commits_url":"https://api.github.com/repos/basecamp/marginalia/git/commits{/sha}","comments_url":"https://api.github.com/repos/basecamp/marginalia/comments{/number}","issue_comment_url":"https://api.github.com/repos/basecamp/marginalia/issues/comments{/number}","contents_url":"https://api.github.com/repos/basecamp/marginalia/contents/{+path}","compare_url":"https://api.github.com/repos/basecamp/marginalia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/basecamp/marginalia/merges","archive_url":"https://api.github.com/repos/basecamp/marginalia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/basecamp/marginalia/downloads","issues_url":"https://api.github.com/repos/basecamp/marginalia/issues{/number}","pulls_url":"https://api.github.com/repos/basecamp/marginalia/pulls{/number}","milestones_url":"https://api.github.com/repos/basecamp/marginalia/milestones{/number}","notifications_url":"https://api.github.com/repos/basecamp/marginalia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/basecamp/marginalia/labels{/name}","releases_url":"https://api.github.com/repos/basecamp/marginalia/releases{/id}","deployments_url":"https://api.github.com/repos/basecamp/marginalia/deployments","created_at":"2012-03-11T21:35:11Z","updated_at":"2018-10-30T16:49:31Z","pushed_at":"2018-10-29T05:53:13Z","git_url":"git://github.com/basecamp/marginalia.git","ssh_url":"git@github.com:basecamp/marginalia.git","clone_url":"https://github.com/basecamp/marginalia.git","svn_url":"https://github.com/basecamp/marginalia","homepage":"","size":139,"stargazers_count":1088,"watchers_count":1088,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":92,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":92,"open_issues":14,"watchers":1088,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/basecamp/marginalia/pulls/77"},"html":{"href":"https://github.com/basecamp/marginalia/pull/77"},"issue":{"href":"https://api.github.com/repos/basecamp/marginalia/issues/77"},"comments":{"href":"https://api.github.com/repos/basecamp/marginalia/issues/77/comments"},"review_comments":{"href":"https://api.github.com/repos/basecamp/marginalia/pulls/77/comments"},"review_comment":{"href":"https://api.github.com/repos/basecamp/marginalia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/basecamp/marginalia/pulls/77/commits"},"statuses":{"href":"https://api.github.com/repos/basecamp/marginalia/statuses/efaa62aa26072eb2edf09cc3345ec4e5301d0a13"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"arthurnn"}}