{"action":"created","comment":{"url":"https://api.github.com/repos/mlpack/mlpack/pulls/comments/200381659","pull_request_review_id":134686406,"id":200381659,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDM4MTY1OQ==","diff_hunk":"@@ -107,28 +107,49 @@ double LMNNFunction<MetricType>::Evaluate(const arma::mat& transformation)\n         // Calculate cost due to {data point, target neighbors, impostors}\n         // triplets.\n         double eval = 0;\n-        if ((iteration - 1 % range == 0) && (iteration - 1 != 0))\n+        if (transformationOld.n_elem != 0)\n         {\n-          eval = metric.Evaluate(transformedDataset.col(i),\n-                    transformedDataset.col(targetNeighbors(j, i))) -\n-                 distance(l, i);\n+          eval = evalOld + arma::norm(transformation - transformationOld) *\n+              (norm(targetNeighbors(j, i)) + norm(impostors(l, i)) +\n+              2 * norm(i));\n+          if (eval > -1)\n+          {\n+            // Calculate exact eval.","path":"src/mlpack/methods/lmnn/lmnn_function_impl.hpp","position":15,"original_position":15,"commit_id":"35af7935bcee88f50c157cfd0b1b42d2025164b5","original_commit_id":"35af7935bcee88f50c157cfd0b1b42d2025164b5","user":{"login":"rcurtin","id":1845039,"node_id":"MDQ6VXNlcjE4NDUwMzk=","avatar_url":"https://avatars0.githubusercontent.com/u/1845039?v=4","gravatar_id":"","url":"https://api.github.com/users/rcurtin","html_url":"https://github.com/rcurtin","followers_url":"https://api.github.com/users/rcurtin/followers","following_url":"https://api.github.com/users/rcurtin/following{/other_user}","gists_url":"https://api.github.com/users/rcurtin/gists{/gist_id}","starred_url":"https://api.github.com/users/rcurtin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcurtin/subscriptions","organizations_url":"https://api.github.com/users/rcurtin/orgs","repos_url":"https://api.github.com/users/rcurtin/repos","events_url":"https://api.github.com/users/rcurtin/events{/privacy}","received_events_url":"https://api.github.com/users/rcurtin/received_events","type":"User","site_admin":false},"body":"I'm virtually certain your simulations were correct---so, under that assumption, what's different between what you did there and what's implemented here?","created_at":"2018-07-05T14:50:51Z","updated_at":"2018-07-05T14:50:52Z","html_url":"https://github.com/mlpack/mlpack/pull/1461#discussion_r200381659","pull_request_url":"https://api.github.com/repos/mlpack/mlpack/pulls/1461","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mlpack/mlpack/pulls/comments/200381659"},"html":{"href":"https://github.com/mlpack/mlpack/pull/1461#discussion_r200381659"},"pull_request":{"href":"https://api.github.com/repos/mlpack/mlpack/pulls/1461"}},"in_reply_to_id":200365493},"pull_request":{"url":"https://api.github.com/repos/mlpack/mlpack/pulls/1461","id":199299086,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5Mjk5MDg2","html_url":"https://github.com/mlpack/mlpack/pull/1461","diff_url":"https://github.com/mlpack/mlpack/pull/1461.diff","patch_url":"https://github.com/mlpack/mlpack/pull/1461.patch","issue_url":"https://api.github.com/repos/mlpack/mlpack/issues/1461","number":1461,"state":"open","locked":false,"title":"LMNN: Bounds for slack term","user":{"login":"manish7294","id":17105412,"node_id":"MDQ6VXNlcjE3MTA1NDEy","avatar_url":"https://avatars0.githubusercontent.com/u/17105412?v=4","gravatar_id":"","url":"https://api.github.com/users/manish7294","html_url":"https://github.com/manish7294","followers_url":"https://api.github.com/users/manish7294/followers","following_url":"https://api.github.com/users/manish7294/following{/other_user}","gists_url":"https://api.github.com/users/manish7294/gists{/gist_id}","starred_url":"https://api.github.com/users/manish7294/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manish7294/subscriptions","organizations_url":"https://api.github.com/users/manish7294/orgs","repos_url":"https://api.github.com/users/manish7294/repos","events_url":"https://api.github.com/users/manish7294/events{/privacy}","received_events_url":"https://api.github.com/users/manish7294/received_events","type":"User","site_admin":false},"body":"See #1449 ","created_at":"2018-07-04T17:13:12Z","updated_at":"2018-07-05T14:50:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"95e7f786f1a222126da356a5557e3971c9c923e0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mlpack/mlpack/pulls/1461/commits","review_comments_url":"https://api.github.com/repos/mlpack/mlpack/pulls/1461/comments","review_comment_url":"https://api.github.com/repos/mlpack/mlpack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mlpack/mlpack/issues/1461/comments","statuses_url":"https://api.github.com/repos/mlpack/mlpack/statuses/35af7935bcee88f50c157cfd0b1b42d2025164b5","head":{"label":"manish7294:evalBounds","ref":"evalBounds","sha":"35af7935bcee88f50c157cfd0b1b42d2025164b5","user":{"login":"manish7294","id":17105412,"node_id":"MDQ6VXNlcjE3MTA1NDEy","avatar_url":"https://avatars0.githubusercontent.com/u/17105412?v=4","gravatar_id":"","url":"https://api.github.com/users/manish7294","html_url":"https://github.com/manish7294","followers_url":"https://api.github.com/users/manish7294/followers","following_url":"https://api.github.com/users/manish7294/following{/other_user}","gists_url":"https://api.github.com/users/manish7294/gists{/gist_id}","starred_url":"https://api.github.com/users/manish7294/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manish7294/subscriptions","organizations_url":"https://api.github.com/users/manish7294/orgs","repos_url":"https://api.github.com/users/manish7294/repos","events_url":"https://api.github.com/users/manish7294/events{/privacy}","received_events_url":"https://api.github.com/users/manish7294/received_events","type":"User","site_admin":false},"repo":{"id":117234183,"node_id":"MDEwOlJlcG9zaXRvcnkxMTcyMzQxODM=","name":"mlpack","full_name":"manish7294/mlpack","owner":{"login":"manish7294","id":17105412,"node_id":"MDQ6VXNlcjE3MTA1NDEy","avatar_url":"https://avatars0.githubusercontent.com/u/17105412?v=4","gravatar_id":"","url":"https://api.github.com/users/manish7294","html_url":"https://github.com/manish7294","followers_url":"https://api.github.com/users/manish7294/followers","following_url":"https://api.github.com/users/manish7294/following{/other_user}","gists_url":"https://api.github.com/users/manish7294/gists{/gist_id}","starred_url":"https://api.github.com/users/manish7294/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manish7294/subscriptions","organizations_url":"https://api.github.com/users/manish7294/orgs","repos_url":"https://api.github.com/users/manish7294/repos","events_url":"https://api.github.com/users/manish7294/events{/privacy}","received_events_url":"https://api.github.com/users/manish7294/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/manish7294/mlpack","description":"mlpack: a scalable C++ machine learning library -- ","fork":true,"url":"https://api.github.com/repos/manish7294/mlpack","forks_url":"https://api.github.com/repos/manish7294/mlpack/forks","keys_url":"https://api.github.com/repos/manish7294/mlpack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/manish7294/mlpack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/manish7294/mlpack/teams","hooks_url":"https://api.github.com/repos/manish7294/mlpack/hooks","issue_events_url":"https://api.github.com/repos/manish7294/mlpack/issues/events{/number}","events_url":"https://api.github.com/repos/manish7294/mlpack/events","assignees_url":"https://api.github.com/repos/manish7294/mlpack/assignees{/user}","branches_url":"https://api.github.com/repos/manish7294/mlpack/branches{/branch}","tags_url":"https://api.github.com/repos/manish7294/mlpack/tags","blobs_url":"https://api.github.com/repos/manish7294/mlpack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/manish7294/mlpack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/manish7294/mlpack/git/refs{/sha}","trees_url":"https://api.github.com/repos/manish7294/mlpack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/manish7294/mlpack/statuses/{sha}","languages_url":"https://api.github.com/repos/manish7294/mlpack/languages","stargazers_url":"https://api.github.com/repos/manish7294/mlpack/stargazers","contributors_url":"https://api.github.com/repos/manish7294/mlpack/contributors","subscribers_url":"https://api.github.com/repos/manish7294/mlpack/subscribers","subscription_url":"https://api.github.com/repos/manish7294/mlpack/subscription","commits_url":"https://api.github.com/repos/manish7294/mlpack/commits{/sha}","git_commits_url":"https://api.github.com/repos/manish7294/mlpack/git/commits{/sha}","comments_url":"https://api.github.com/repos/manish7294/mlpack/comments{/number}","issue_comment_url":"https://api.github.com/repos/manish7294/mlpack/issues/comments{/number}","contents_url":"https://api.github.com/repos/manish7294/mlpack/contents/{+path}","compare_url":"https://api.github.com/repos/manish7294/mlpack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/manish7294/mlpack/merges","archive_url":"https://api.github.com/repos/manish7294/mlpack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/manish7294/mlpack/downloads","issues_url":"https://api.github.com/repos/manish7294/mlpack/issues{/number}","pulls_url":"https://api.github.com/repos/manish7294/mlpack/pulls{/number}","milestones_url":"https://api.github.com/repos/manish7294/mlpack/milestones{/number}","notifications_url":"https://api.github.com/repos/manish7294/mlpack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/manish7294/mlpack/labels{/name}","releases_url":"https://api.github.com/repos/manish7294/mlpack/releases{/id}","deployments_url":"https://api.github.com/repos/manish7294/mlpack/deployments","created_at":"2018-01-12T11:38:29Z","updated_at":"2018-06-14T03:45:20Z","pushed_at":"2018-07-05T11:47:39Z","git_url":"git://github.com/manish7294/mlpack.git","ssh_url":"git@github.com:manish7294/mlpack.git","clone_url":"https://github.com/manish7294/mlpack.git","svn_url":"https://github.com/manish7294/mlpack","homepage":"http://www.mlpack.org/","size":244307,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mlpack:master","ref":"master","sha":"fd59d030ca31f51cc9a4864eb8f892266bfd1807","user":{"login":"mlpack","id":10216045,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMjE2MDQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10216045?v=4","gravatar_id":"","url":"https://api.github.com/users/mlpack","html_url":"https://github.com/mlpack","followers_url":"https://api.github.com/users/mlpack/followers","following_url":"https://api.github.com/users/mlpack/following{/other_user}","gists_url":"https://api.github.com/users/mlpack/gists{/gist_id}","starred_url":"https://api.github.com/users/mlpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlpack/subscriptions","organizations_url":"https://api.github.com/users/mlpack/orgs","repos_url":"https://api.github.com/users/mlpack/repos","events_url":"https://api.github.com/users/mlpack/events{/privacy}","received_events_url":"https://api.github.com/users/mlpack/received_events","type":"Organization","site_admin":false},"repo":{"id":28149409,"node_id":"MDEwOlJlcG9zaXRvcnkyODE0OTQwOQ==","name":"mlpack","full_name":"mlpack/mlpack","owner":{"login":"mlpack","id":10216045,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMjE2MDQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10216045?v=4","gravatar_id":"","url":"https://api.github.com/users/mlpack","html_url":"https://github.com/mlpack","followers_url":"https://api.github.com/users/mlpack/followers","following_url":"https://api.github.com/users/mlpack/following{/other_user}","gists_url":"https://api.github.com/users/mlpack/gists{/gist_id}","starred_url":"https://api.github.com/users/mlpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlpack/subscriptions","organizations_url":"https://api.github.com/users/mlpack/orgs","repos_url":"https://api.github.com/users/mlpack/repos","events_url":"https://api.github.com/users/mlpack/events{/privacy}","received_events_url":"https://api.github.com/users/mlpack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mlpack/mlpack","description":"mlpack: a scalable C++ machine learning library -- ","fork":false,"url":"https://api.github.com/repos/mlpack/mlpack","forks_url":"https://api.github.com/repos/mlpack/mlpack/forks","keys_url":"https://api.github.com/repos/mlpack/mlpack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mlpack/mlpack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mlpack/mlpack/teams","hooks_url":"https://api.github.com/repos/mlpack/mlpack/hooks","issue_events_url":"https://api.github.com/repos/mlpack/mlpack/issues/events{/number}","events_url":"https://api.github.com/repos/mlpack/mlpack/events","assignees_url":"https://api.github.com/repos/mlpack/mlpack/assignees{/user}","branches_url":"https://api.github.com/repos/mlpack/mlpack/branches{/branch}","tags_url":"https://api.github.com/repos/mlpack/mlpack/tags","blobs_url":"https://api.github.com/repos/mlpack/mlpack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mlpack/mlpack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mlpack/mlpack/git/refs{/sha}","trees_url":"https://api.github.com/repos/mlpack/mlpack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mlpack/mlpack/statuses/{sha}","languages_url":"https://api.github.com/repos/mlpack/mlpack/languages","stargazers_url":"https://api.github.com/repos/mlpack/mlpack/stargazers","contributors_url":"https://api.github.com/repos/mlpack/mlpack/contributors","subscribers_url":"https://api.github.com/repos/mlpack/mlpack/subscribers","subscription_url":"https://api.github.com/repos/mlpack/mlpack/subscription","commits_url":"https://api.github.com/repos/mlpack/mlpack/commits{/sha}","git_commits_url":"https://api.github.com/repos/mlpack/mlpack/git/commits{/sha}","comments_url":"https://api.github.com/repos/mlpack/mlpack/comments{/number}","issue_comment_url":"https://api.github.com/repos/mlpack/mlpack/issues/comments{/number}","contents_url":"https://api.github.com/repos/mlpack/mlpack/contents/{+path}","compare_url":"https://api.github.com/repos/mlpack/mlpack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mlpack/mlpack/merges","archive_url":"https://api.github.com/repos/mlpack/mlpack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mlpack/mlpack/downloads","issues_url":"https://api.github.com/repos/mlpack/mlpack/issues{/number}","pulls_url":"https://api.github.com/repos/mlpack/mlpack/pulls{/number}","milestones_url":"https://api.github.com/repos/mlpack/mlpack/milestones{/number}","notifications_url":"https://api.github.com/repos/mlpack/mlpack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mlpack/mlpack/labels{/name}","releases_url":"https://api.github.com/repos/mlpack/mlpack/releases{/id}","deployments_url":"https://api.github.com/repos/mlpack/mlpack/deployments","created_at":"2014-12-17T18:16:59Z","updated_at":"2018-07-05T14:28:04Z","pushed_at":"2018-07-05T13:51:24Z","git_url":"git://github.com/mlpack/mlpack.git","ssh_url":"git@github.com:mlpack/mlpack.git","clone_url":"https://github.com/mlpack/mlpack.git","svn_url":"https://github.com/mlpack/mlpack","homepage":"http://www.mlpack.org/","size":244340,"stargazers_count":2251,"watchers_count":2251,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":817,"mirror_url":null,"archived":false,"open_issues_count":110,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":817,"open_issues":110,"watchers":2251,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mlpack/mlpack/pulls/1461"},"html":{"href":"https://github.com/mlpack/mlpack/pull/1461"},"issue":{"href":"https://api.github.com/repos/mlpack/mlpack/issues/1461"},"comments":{"href":"https://api.github.com/repos/mlpack/mlpack/issues/1461/comments"},"review_comments":{"href":"https://api.github.com/repos/mlpack/mlpack/pulls/1461/comments"},"review_comment":{"href":"https://api.github.com/repos/mlpack/mlpack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mlpack/mlpack/pulls/1461/commits"},"statuses":{"href":"https://api.github.com/repos/mlpack/mlpack/statuses/35af7935bcee88f50c157cfd0b1b42d2025164b5"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"rcurtin"}}