{"action":"created","issue":{"url":"https://api.github.com/repos/swig/swig/issues/1223","repository_url":"https://api.github.com/repos/swig/swig","labels_url":"https://api.github.com/repos/swig/swig/issues/1223/labels{/name}","comments_url":"https://api.github.com/repos/swig/swig/issues/1223/comments","events_url":"https://api.github.com/repos/swig/swig/issues/1223/events","html_url":"https://github.com/swig/swig/pull/1223","id":312782017,"number":1223,"title":"python.cxx: Insert some additional newlines to suppress some PEP8 warnings","user":{"login":"bje-","id":4327840,"avatar_url":"https://avatars0.githubusercontent.com/u/4327840?v=4","gravatar_id":"","url":"https://api.github.com/users/bje-","html_url":"https://github.com/bje-","followers_url":"https://api.github.com/users/bje-/followers","following_url":"https://api.github.com/users/bje-/following{/other_user}","gists_url":"https://api.github.com/users/bje-/gists{/gist_id}","starred_url":"https://api.github.com/users/bje-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bje-/subscriptions","organizations_url":"https://api.github.com/users/bje-/orgs","repos_url":"https://api.github.com/users/bje-/repos","events_url":"https://api.github.com/users/bje-/events{/privacy}","received_events_url":"https://api.github.com/users/bje-/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-04-10T05:53:48Z","updated_at":"2018-04-10T20:49:04Z","closed_at":"2018-04-10T08:49:58Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/swig/swig/pulls/1223","html_url":"https://github.com/swig/swig/pull/1223","diff_url":"https://github.com/swig/swig/pull/1223.diff","patch_url":"https://github.com/swig/swig/pull/1223.patch"},"body":"This overcomes a couple of easily rectified warnings from the `example.i` file:\r\n\r\n```\r\nexample.py:51:1: E302 expected 2 blank lines, found 1\r\nexample.py:90:1: E305 expected 2 blank lines after class or function definition, found 1\r\n```"},"comment":{"url":"https://api.github.com/repos/swig/swig/issues/comments/380241800","html_url":"https://github.com/swig/swig/pull/1223#issuecomment-380241800","issue_url":"https://api.github.com/repos/swig/swig/issues/1223","id":380241800,"user":{"login":"ojwb","id":164061,"avatar_url":"https://avatars0.githubusercontent.com/u/164061?v=4","gravatar_id":"","url":"https://api.github.com/users/ojwb","html_url":"https://github.com/ojwb","followers_url":"https://api.github.com/users/ojwb/followers","following_url":"https://api.github.com/users/ojwb/following{/other_user}","gists_url":"https://api.github.com/users/ojwb/gists{/gist_id}","starred_url":"https://api.github.com/users/ojwb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ojwb/subscriptions","organizations_url":"https://api.github.com/users/ojwb/orgs","repos_url":"https://api.github.com/users/ojwb/repos","events_url":"https://api.github.com/users/ojwb/events{/privacy}","received_events_url":"https://api.github.com/users/ojwb/received_events","type":"User","site_admin":false},"created_at":"2018-04-10T20:49:04Z","updated_at":"2018-04-10T20:49:04Z","author_association":"MEMBER","body":"FWIW, we already do PEP8 checks in the testsuite by running `pycodestyle` (if installed) with options `--ignore=E402,E501,E30,W291,W391`, so we are checking for many such things already (and that's run from CI).\r\n\r\nIt looks like `E30` in that list means `E30*` (I don't see this in the man page, but if I remove it I get a flood of `E301`, `E302` and `E305`), so it seems these pep8 violations are actually deliberately being allowed currently.\r\n\r\nI'd lean towards fixing the blank lines to match pep8 myself, especially as the noise from that change is easy to filter out (`diff -B`) so the downside seems small.  And generally we accept patches to fix compiler warnings in the generated code, which seems a fairly similar situation.\r\n\r\nIf we do we should drop `E30` from that list though, to make sure that the change does what it's meant to and doesn't regress in future."}}
{"actor":{"display_login":"ojwb"}}