{"action":"created","comment":{"url":"https://api.github.com/repos/tensorflow/models/pulls/comments/171084216","pull_request_review_id":99875899,"id":171084216,"diff_hunk":"@@ -144,6 +143,12 @@ def input_fn(is_training, data_dir, batch_size, num_epochs=1,\n   # Convert to individual records\n   dataset = dataset.flat_map(tf.data.TFRecordDataset)\n \n+  # Currently, if we are using multiple GPUs, we can't pass in uneven batches.\n+  # This ensures that we cut off the uneven images at the end of each epoch\n+  # (there are fifteen leftovers), rather than trying and failing to split","path":"official/resnet/imagenet_main.py","position":19,"original_position":19,"commit_id":"028e6a477d5c99dfc7e057225246b711dd686cae","original_commit_id":"954425b67cc2d527a6e9f74884edeea71f6e04d8","user":{"login":"asimshankar","id":16018,"avatar_url":"https://avatars2.githubusercontent.com/u/16018?v=4","gravatar_id":"","url":"https://api.github.com/users/asimshankar","html_url":"https://github.com/asimshankar","followers_url":"https://api.github.com/users/asimshankar/followers","following_url":"https://api.github.com/users/asimshankar/following{/other_user}","gists_url":"https://api.github.com/users/asimshankar/gists{/gist_id}","starred_url":"https://api.github.com/users/asimshankar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asimshankar/subscriptions","organizations_url":"https://api.github.com/users/asimshankar/orgs","repos_url":"https://api.github.com/users/asimshankar/repos","events_url":"https://api.github.com/users/asimshankar/events{/privacy}","received_events_url":"https://api.github.com/users/asimshankar/received_events","type":"User","site_admin":false},"body":"2. sounds good.\r\n\r\nThanks for the details. (Perhaps worth capturing this in a comment? Your call)","created_at":"2018-02-27T22:11:55Z","updated_at":"2018-02-27T22:13:04Z","html_url":"https://github.com/tensorflow/models/pull/3472#discussion_r171084216","pull_request_url":"https://api.github.com/repos/tensorflow/models/pulls/3472","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/tensorflow/models/pulls/comments/171084216"},"html":{"href":"https://github.com/tensorflow/models/pull/3472#discussion_r171084216"},"pull_request":{"href":"https://api.github.com/repos/tensorflow/models/pulls/3472"}},"in_reply_to_id":170847865},"pull_request":{"url":"https://api.github.com/repos/tensorflow/models/pulls/3472","id":171476901,"html_url":"https://github.com/tensorflow/models/pull/3472","diff_url":"https://github.com/tensorflow/models/pull/3472.diff","patch_url":"https://github.com/tensorflow/models/pull/3472.patch","issue_url":"https://api.github.com/repos/tensorflow/models/issues/3472","number":3472,"state":"open","locked":false,"title":"Multi-GPU Resnet","user":{"login":"karmel","id":667809,"avatar_url":"https://avatars1.githubusercontent.com/u/667809?v=4","gravatar_id":"","url":"https://api.github.com/users/karmel","html_url":"https://github.com/karmel","followers_url":"https://api.github.com/users/karmel/followers","following_url":"https://api.github.com/users/karmel/following{/other_user}","gists_url":"https://api.github.com/users/karmel/gists{/gist_id}","starred_url":"https://api.github.com/users/karmel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karmel/subscriptions","organizations_url":"https://api.github.com/users/karmel/orgs","repos_url":"https://api.github.com/users/karmel/repos","events_url":"https://api.github.com/users/karmel/events{/privacy}","received_events_url":"https://api.github.com/users/karmel/received_events","type":"User","site_admin":false},"body":"Performance on this is still less than expected, but I want to push this in to unblock several other changes. \r\n\r\nNotes:\r\n* I removed the image conversion to a float in the range [0, 1) because it did not affect convergence, but negatively impacted performance. \r\n* The num_gpus flag is included for @tfboyd's use currently; if we decide there is a better way for his testing purposes, that can be removed (in a follow-up if timing requires).\r\n* This duplicates some of the code in MNIST; we will handle that in follow-up PRs as we introduce some shared functions.\r\n\r\nCC @isaprykin @reedwm @tfboyd ","created_at":"2018-02-26T20:02:17Z","updated_at":"2018-02-27T22:13:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6003f66c3eb81cadfb25c41572d32b883e6b0b79","assignee":null,"assignees":[],"requested_reviewers":[{"login":"nealwu","id":726075,"avatar_url":"https://avatars3.githubusercontent.com/u/726075?v=4","gravatar_id":"","url":"https://api.github.com/users/nealwu","html_url":"https://github.com/nealwu","followers_url":"https://api.github.com/users/nealwu/followers","following_url":"https://api.github.com/users/nealwu/following{/other_user}","gists_url":"https://api.github.com/users/nealwu/gists{/gist_id}","starred_url":"https://api.github.com/users/nealwu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nealwu/subscriptions","organizations_url":"https://api.github.com/users/nealwu/orgs","repos_url":"https://api.github.com/users/nealwu/repos","events_url":"https://api.github.com/users/nealwu/events{/privacy}","received_events_url":"https://api.github.com/users/nealwu/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":337864321,"url":"https://api.github.com/repos/tensorflow/models/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/tensorflow/models/pulls/3472/commits","review_comments_url":"https://api.github.com/repos/tensorflow/models/pulls/3472/comments","review_comment_url":"https://api.github.com/repos/tensorflow/models/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tensorflow/models/issues/3472/comments","statuses_url":"https://api.github.com/repos/tensorflow/models/statuses/028e6a477d5c99dfc7e057225246b711dd686cae","head":{"label":"tensorflow:feat/multi-gpu-resnet","ref":"feat/multi-gpu-resnet","sha":"028e6a477d5c99dfc7e057225246b711dd686cae","user":{"login":"tensorflow","id":15658638,"avatar_url":"https://avatars1.githubusercontent.com/u/15658638?v=4","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"repo":{"id":51117837,"name":"models","full_name":"tensorflow/models","owner":{"login":"tensorflow","id":15658638,"avatar_url":"https://avatars1.githubusercontent.com/u/15658638?v=4","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tensorflow/models","description":"Models and examples built with TensorFlow","fork":false,"url":"https://api.github.com/repos/tensorflow/models","forks_url":"https://api.github.com/repos/tensorflow/models/forks","keys_url":"https://api.github.com/repos/tensorflow/models/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tensorflow/models/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tensorflow/models/teams","hooks_url":"https://api.github.com/repos/tensorflow/models/hooks","issue_events_url":"https://api.github.com/repos/tensorflow/models/issues/events{/number}","events_url":"https://api.github.com/repos/tensorflow/models/events","assignees_url":"https://api.github.com/repos/tensorflow/models/assignees{/user}","branches_url":"https://api.github.com/repos/tensorflow/models/branches{/branch}","tags_url":"https://api.github.com/repos/tensorflow/models/tags","blobs_url":"https://api.github.com/repos/tensorflow/models/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tensorflow/models/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tensorflow/models/git/refs{/sha}","trees_url":"https://api.github.com/repos/tensorflow/models/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tensorflow/models/statuses/{sha}","languages_url":"https://api.github.com/repos/tensorflow/models/languages","stargazers_url":"https://api.github.com/repos/tensorflow/models/stargazers","contributors_url":"https://api.github.com/repos/tensorflow/models/contributors","subscribers_url":"https://api.github.com/repos/tensorflow/models/subscribers","subscription_url":"https://api.github.com/repos/tensorflow/models/subscription","commits_url":"https://api.github.com/repos/tensorflow/models/commits{/sha}","git_commits_url":"https://api.github.com/repos/tensorflow/models/git/commits{/sha}","comments_url":"https://api.github.com/repos/tensorflow/models/comments{/number}","issue_comment_url":"https://api.github.com/repos/tensorflow/models/issues/comments{/number}","contents_url":"https://api.github.com/repos/tensorflow/models/contents/{+path}","compare_url":"https://api.github.com/repos/tensorflow/models/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tensorflow/models/merges","archive_url":"https://api.github.com/repos/tensorflow/models/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tensorflow/models/downloads","issues_url":"https://api.github.com/repos/tensorflow/models/issues{/number}","pulls_url":"https://api.github.com/repos/tensorflow/models/pulls{/number}","milestones_url":"https://api.github.com/repos/tensorflow/models/milestones{/number}","notifications_url":"https://api.github.com/repos/tensorflow/models/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tensorflow/models/labels{/name}","releases_url":"https://api.github.com/repos/tensorflow/models/releases{/id}","deployments_url":"https://api.github.com/repos/tensorflow/models/deployments","created_at":"2016-02-05T01:15:20Z","updated_at":"2018-02-27T22:01:28Z","pushed_at":"2018-02-27T21:20:55Z","git_url":"git://github.com/tensorflow/models.git","ssh_url":"git@github.com:tensorflow/models.git","clone_url":"https://github.com/tensorflow/models.git","svn_url":"https://github.com/tensorflow/models","homepage":"","size":420284,"stargazers_count":28832,"watchers_count":28832,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15930,"mirror_url":null,"archived":false,"open_issues_count":615,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":15930,"open_issues":615,"watchers":28832,"default_branch":"master"}},"base":{"label":"tensorflow:master","ref":"master","sha":"4b92df8976b2b3372778561cca89198b96dc3c93","user":{"login":"tensorflow","id":15658638,"avatar_url":"https://avatars1.githubusercontent.com/u/15658638?v=4","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"repo":{"id":51117837,"name":"models","full_name":"tensorflow/models","owner":{"login":"tensorflow","id":15658638,"avatar_url":"https://avatars1.githubusercontent.com/u/15658638?v=4","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tensorflow/models","description":"Models and examples built with TensorFlow","fork":false,"url":"https://api.github.com/repos/tensorflow/models","forks_url":"https://api.github.com/repos/tensorflow/models/forks","keys_url":"https://api.github.com/repos/tensorflow/models/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tensorflow/models/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tensorflow/models/teams","hooks_url":"https://api.github.com/repos/tensorflow/models/hooks","issue_events_url":"https://api.github.com/repos/tensorflow/models/issues/events{/number}","events_url":"https://api.github.com/repos/tensorflow/models/events","assignees_url":"https://api.github.com/repos/tensorflow/models/assignees{/user}","branches_url":"https://api.github.com/repos/tensorflow/models/branches{/branch}","tags_url":"https://api.github.com/repos/tensorflow/models/tags","blobs_url":"https://api.github.com/repos/tensorflow/models/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tensorflow/models/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tensorflow/models/git/refs{/sha}","trees_url":"https://api.github.com/repos/tensorflow/models/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tensorflow/models/statuses/{sha}","languages_url":"https://api.github.com/repos/tensorflow/models/languages","stargazers_url":"https://api.github.com/repos/tensorflow/models/stargazers","contributors_url":"https://api.github.com/repos/tensorflow/models/contributors","subscribers_url":"https://api.github.com/repos/tensorflow/models/subscribers","subscription_url":"https://api.github.com/repos/tensorflow/models/subscription","commits_url":"https://api.github.com/repos/tensorflow/models/commits{/sha}","git_commits_url":"https://api.github.com/repos/tensorflow/models/git/commits{/sha}","comments_url":"https://api.github.com/repos/tensorflow/models/comments{/number}","issue_comment_url":"https://api.github.com/repos/tensorflow/models/issues/comments{/number}","contents_url":"https://api.github.com/repos/tensorflow/models/contents/{+path}","compare_url":"https://api.github.com/repos/tensorflow/models/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tensorflow/models/merges","archive_url":"https://api.github.com/repos/tensorflow/models/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tensorflow/models/downloads","issues_url":"https://api.github.com/repos/tensorflow/models/issues{/number}","pulls_url":"https://api.github.com/repos/tensorflow/models/pulls{/number}","milestones_url":"https://api.github.com/repos/tensorflow/models/milestones{/number}","notifications_url":"https://api.github.com/repos/tensorflow/models/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tensorflow/models/labels{/name}","releases_url":"https://api.github.com/repos/tensorflow/models/releases{/id}","deployments_url":"https://api.github.com/repos/tensorflow/models/deployments","created_at":"2016-02-05T01:15:20Z","updated_at":"2018-02-27T22:01:28Z","pushed_at":"2018-02-27T21:20:55Z","git_url":"git://github.com/tensorflow/models.git","ssh_url":"git@github.com:tensorflow/models.git","clone_url":"https://github.com/tensorflow/models.git","svn_url":"https://github.com/tensorflow/models","homepage":"","size":420284,"stargazers_count":28832,"watchers_count":28832,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15930,"mirror_url":null,"archived":false,"open_issues_count":615,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":15930,"open_issues":615,"watchers":28832,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tensorflow/models/pulls/3472"},"html":{"href":"https://github.com/tensorflow/models/pull/3472"},"issue":{"href":"https://api.github.com/repos/tensorflow/models/issues/3472"},"comments":{"href":"https://api.github.com/repos/tensorflow/models/issues/3472/comments"},"review_comments":{"href":"https://api.github.com/repos/tensorflow/models/pulls/3472/comments"},"review_comment":{"href":"https://api.github.com/repos/tensorflow/models/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tensorflow/models/pulls/3472/commits"},"statuses":{"href":"https://api.github.com/repos/tensorflow/models/statuses/028e6a477d5c99dfc7e057225246b711dd686cae"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"asimshankar"}}