{"action":"created","comment":{"url":"https://api.github.com/repos/faustbrian/ARK-PHP/pulls/comments/165835886","pull_request_review_id":93837301,"id":165835886,"diff_hunk":"@@ -68,14 +68,19 @@ public function wif(string $secret, int $wif = 0xaa): string\n         return Base58::encodeCheck($seed);\n     }\n \n+    public static function setNetworkAddress(string $networkAddress)\n+    {\n+        self::$network = NetworkFactory::create($networkAddress, '00', '00');","path":"src/Utils/Crypto.php","position":null,"original_position":6,"commit_id":"28b34c93038926a6c71431a9f5baba578589d4df","original_commit_id":"07dd22371928b0a0d582a502547b5801cf242c64","user":{"login":"faustbrian","id":22145591,"avatar_url":"https://avatars3.githubusercontent.com/u/22145591?v=4","gravatar_id":"","url":"https://api.github.com/users/faustbrian","html_url":"https://github.com/faustbrian","followers_url":"https://api.github.com/users/faustbrian/followers","following_url":"https://api.github.com/users/faustbrian/following{/other_user}","gists_url":"https://api.github.com/users/faustbrian/gists{/gist_id}","starred_url":"https://api.github.com/users/faustbrian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faustbrian/subscriptions","organizations_url":"https://api.github.com/users/faustbrian/orgs","repos_url":"https://api.github.com/users/faustbrian/repos","events_url":"https://api.github.com/users/faustbrian/events{/privacy}","received_events_url":"https://api.github.com/users/faustbrian/received_events","type":"User","site_admin":false},"body":"Seems to work on mainnet using the following code so all good.\r\n\r\n```\r\n$client = new BrianFaust\\Ark\\Client(\r\n    'explorer.ark.io', 8443, '6e84d08bd299ed97c212c886c98a57e36545c8f5d645ca7eeae63a8bd62d8988', '1.0.3', 17\r\n);\r\n```\r\n\r\nhttps://explorer.ark.io/tx/b291f607b09b68c947b8586fdaa0c20bac9396890e3e1c9d31515d9425c52e03","created_at":"2018-02-04T07:30:35Z","updated_at":"2018-02-04T07:30:35Z","html_url":"https://github.com/faustbrian/ARK-PHP/pull/2#discussion_r165835886","pull_request_url":"https://api.github.com/repos/faustbrian/ARK-PHP/pulls/2","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/faustbrian/ARK-PHP/pulls/comments/165835886"},"html":{"href":"https://github.com/faustbrian/ARK-PHP/pull/2#discussion_r165835886"},"pull_request":{"href":"https://api.github.com/repos/faustbrian/ARK-PHP/pulls/2"}},"in_reply_to_id":165834849},"pull_request":{"url":"https://api.github.com/repos/faustbrian/ARK-PHP/pulls/2","id":166990537,"html_url":"https://github.com/faustbrian/ARK-PHP/pull/2","diff_url":"https://github.com/faustbrian/ARK-PHP/pull/2.diff","patch_url":"https://github.com/faustbrian/ARK-PHP/pull/2.patch","issue_url":"https://api.github.com/repos/faustbrian/ARK-PHP/issues/2","number":2,"state":"open","locked":false,"title":"Remove arkjs dependency in favor of bitwasp/bitcoin","user":{"login":"christopherjwang","id":4838266,"avatar_url":"https://avatars1.githubusercontent.com/u/4838266?v=4","gravatar_id":"","url":"https://api.github.com/users/christopherjwang","html_url":"https://github.com/christopherjwang","followers_url":"https://api.github.com/users/christopherjwang/followers","following_url":"https://api.github.com/users/christopherjwang/following{/other_user}","gists_url":"https://api.github.com/users/christopherjwang/gists{/gist_id}","starred_url":"https://api.github.com/users/christopherjwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christopherjwang/subscriptions","organizations_url":"https://api.github.com/users/christopherjwang/orgs","repos_url":"https://api.github.com/users/christopherjwang/repos","events_url":"https://api.github.com/users/christopherjwang/events{/privacy}","received_events_url":"https://api.github.com/users/christopherjwang/received_events","type":"User","site_admin":false},"body":"Tested on devnet:\r\n\r\n## single signature\r\ntransaction testing: 459b516e3f2adca3af69da24c3af12a9e45eee8e51b327d1a0ddb465f71a47fe\r\nvoting: e44f4730d4a0863314775cb8733707757c8bf10afe1d6b6d94ddc112c2a9af6e\r\nunvoting: 9f2f96d65b98a13e65d8433eb1904bf3a2927beab2395a24dadc508e11a19984\r\ncreating delegate: dccb0fd1a920a73a42e83e7e37ec1d45ad7a2ce0c7255b7595f209e4efedb982\r\n\r\nadding second signature: bd4d7d6fa4bc59ac2ef7443a5da517e74c3cdf30b9932729a0c0d3ca9f5e1f37\r\n\r\n\r\n## with second signature\r\n\r\ntransaction testing: 14d4f63da2644a81ce8bfe4db8ef9cab45a98eaddf1c498055fa82a350c02509\r\nvoting: c65c32968386d2262d7c18aae8af393ebe5ba2961d9b43474e1385b6f1bfdb82\r\nunvoting: 4de39acd1d9670dd597bc36dabb1fb4c54474244981f59ebec2e3c2d5e47a747\r\ncreating delegate: ba43378cb7e21adca2e1c1f31d71e74f6f1d0bc110cfdc435a483e7454f5bc13\r\n\r\n## comments\r\n\r\nI'm using bitwasp/bitcoin because I do not think sodium has the proper utilities to accomplish this task.\r\n\r\nI decided to maintain backwards compatibility with the previous API so this PR does not introduce breaking changes, but that resulted in a bunch of static methods and `transaction` objects being `stdClass` objects being passed around everywhere.\r\n\r\nI'd be interested in moving towards actual objects (like other official clients) instead of behaving like an HTTP client and returning various responses, but I'd like to have that discussion before moving in that direction.\r\n\r\nI should also move the fees and whatnot into a constants file, and there is potential to DRY up the fake transaction model and signing.","created_at":"2018-02-04T02:00:49Z","updated_at":"2018-02-04T07:30:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d9d10262c2b9b61271b222915c73d32d02ed75e1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/faustbrian/ARK-PHP/pulls/2/commits","review_comments_url":"https://api.github.com/repos/faustbrian/ARK-PHP/pulls/2/comments","review_comment_url":"https://api.github.com/repos/faustbrian/ARK-PHP/pulls/comments{/number}","comments_url":"https://api.github.com/repos/faustbrian/ARK-PHP/issues/2/comments","statuses_url":"https://api.github.com/repos/faustbrian/ARK-PHP/statuses/28b34c93038926a6c71431a9f5baba578589d4df","head":{"label":"christopherjwang:christopherjwang/remove_arkjs","ref":"christopherjwang/remove_arkjs","sha":"28b34c93038926a6c71431a9f5baba578589d4df","user":{"login":"christopherjwang","id":4838266,"avatar_url":"https://avatars1.githubusercontent.com/u/4838266?v=4","gravatar_id":"","url":"https://api.github.com/users/christopherjwang","html_url":"https://github.com/christopherjwang","followers_url":"https://api.github.com/users/christopherjwang/followers","following_url":"https://api.github.com/users/christopherjwang/following{/other_user}","gists_url":"https://api.github.com/users/christopherjwang/gists{/gist_id}","starred_url":"https://api.github.com/users/christopherjwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christopherjwang/subscriptions","organizations_url":"https://api.github.com/users/christopherjwang/orgs","repos_url":"https://api.github.com/users/christopherjwang/repos","events_url":"https://api.github.com/users/christopherjwang/events{/privacy}","received_events_url":"https://api.github.com/users/christopherjwang/received_events","type":"User","site_admin":false},"repo":{"id":120143336,"name":"ARK-PHP","full_name":"christopherjwang/ARK-PHP","owner":{"login":"christopherjwang","id":4838266,"avatar_url":"https://avatars1.githubusercontent.com/u/4838266?v=4","gravatar_id":"","url":"https://api.github.com/users/christopherjwang","html_url":"https://github.com/christopherjwang","followers_url":"https://api.github.com/users/christopherjwang/followers","following_url":"https://api.github.com/users/christopherjwang/following{/other_user}","gists_url":"https://api.github.com/users/christopherjwang/gists{/gist_id}","starred_url":"https://api.github.com/users/christopherjwang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christopherjwang/subscriptions","organizations_url":"https://api.github.com/users/christopherjwang/orgs","repos_url":"https://api.github.com/users/christopherjwang/repos","events_url":"https://api.github.com/users/christopherjwang/events{/privacy}","received_events_url":"https://api.github.com/users/christopherjwang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/christopherjwang/ARK-PHP","description":null,"fork":true,"url":"https://api.github.com/repos/christopherjwang/ARK-PHP","forks_url":"https://api.github.com/repos/christopherjwang/ARK-PHP/forks","keys_url":"https://api.github.com/repos/christopherjwang/ARK-PHP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/christopherjwang/ARK-PHP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/christopherjwang/ARK-PHP/teams","hooks_url":"https://api.github.com/repos/christopherjwang/ARK-PHP/hooks","issue_events_url":"https://api.github.com/repos/christopherjwang/ARK-PHP/issues/events{/number}","events_url":"https://api.github.com/repos/christopherjwang/ARK-PHP/events","assignees_url":"https://api.github.com/repos/christopherjwang/ARK-PHP/assignees{/user}","branches_url":"https://api.github.com/repos/christopherjwang/ARK-PHP/branches{/branch}","tags_url":"https://api.github.com/repos/christopherjwang/ARK-PHP/tags","blobs_url":"https://api.github.com/repos/christopherjwang/ARK-PHP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/christopherjwang/ARK-PHP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/christopherjwang/ARK-PHP/git/refs{/sha}","trees_url":"https://api.github.com/repos/christopherjwang/ARK-PHP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/christopherjwang/ARK-PHP/statuses/{sha}","languages_url":"https://api.github.com/repos/christopherjwang/ARK-PHP/languages","stargazers_url":"https://api.github.com/repos/christopherjwang/ARK-PHP/stargazers","contributors_url":"https://api.github.com/repos/christopherjwang/ARK-PHP/contributors","subscribers_url":"https://api.github.com/repos/christopherjwang/ARK-PHP/subscribers","subscription_url":"https://api.github.com/repos/christopherjwang/ARK-PHP/subscription","commits_url":"https://api.github.com/repos/christopherjwang/ARK-PHP/commits{/sha}","git_commits_url":"https://api.github.com/repos/christopherjwang/ARK-PHP/git/commits{/sha}","comments_url":"https://api.github.com/repos/christopherjwang/ARK-PHP/comments{/number}","issue_comment_url":"https://api.github.com/repos/christopherjwang/ARK-PHP/issues/comments{/number}","contents_url":"https://api.github.com/repos/christopherjwang/ARK-PHP/contents/{+path}","compare_url":"https://api.github.com/repos/christopherjwang/ARK-PHP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/christopherjwang/ARK-PHP/merges","archive_url":"https://api.github.com/repos/christopherjwang/ARK-PHP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/christopherjwang/ARK-PHP/downloads","issues_url":"https://api.github.com/repos/christopherjwang/ARK-PHP/issues{/number}","pulls_url":"https://api.github.com/repos/christopherjwang/ARK-PHP/pulls{/number}","milestones_url":"https://api.github.com/repos/christopherjwang/ARK-PHP/milestones{/number}","notifications_url":"https://api.github.com/repos/christopherjwang/ARK-PHP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/christopherjwang/ARK-PHP/labels{/name}","releases_url":"https://api.github.com/repos/christopherjwang/ARK-PHP/releases{/id}","deployments_url":"https://api.github.com/repos/christopherjwang/ARK-PHP/deployments","created_at":"2018-02-04T00:49:06Z","updated_at":"2018-02-04T00:49:07Z","pushed_at":"2018-02-04T06:55:35Z","git_url":"git://github.com/christopherjwang/ARK-PHP.git","ssh_url":"git@github.com:christopherjwang/ARK-PHP.git","clone_url":"https://github.com/christopherjwang/ARK-PHP.git","svn_url":"https://github.com/christopherjwang/ARK-PHP","homepage":null,"size":172,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"faustbrian:master","ref":"master","sha":"66267062200fa76ac99994f7fa29040590c6f1a8","user":{"login":"faustbrian","id":22145591,"avatar_url":"https://avatars3.githubusercontent.com/u/22145591?v=4","gravatar_id":"","url":"https://api.github.com/users/faustbrian","html_url":"https://github.com/faustbrian","followers_url":"https://api.github.com/users/faustbrian/followers","following_url":"https://api.github.com/users/faustbrian/following{/other_user}","gists_url":"https://api.github.com/users/faustbrian/gists{/gist_id}","starred_url":"https://api.github.com/users/faustbrian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faustbrian/subscriptions","organizations_url":"https://api.github.com/users/faustbrian/orgs","repos_url":"https://api.github.com/users/faustbrian/repos","events_url":"https://api.github.com/users/faustbrian/events{/privacy}","received_events_url":"https://api.github.com/users/faustbrian/received_events","type":"User","site_admin":false},"repo":{"id":113013419,"name":"ARK-PHP","full_name":"faustbrian/ARK-PHP","owner":{"login":"faustbrian","id":22145591,"avatar_url":"https://avatars3.githubusercontent.com/u/22145591?v=4","gravatar_id":"","url":"https://api.github.com/users/faustbrian","html_url":"https://github.com/faustbrian","followers_url":"https://api.github.com/users/faustbrian/followers","following_url":"https://api.github.com/users/faustbrian/following{/other_user}","gists_url":"https://api.github.com/users/faustbrian/gists{/gist_id}","starred_url":"https://api.github.com/users/faustbrian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faustbrian/subscriptions","organizations_url":"https://api.github.com/users/faustbrian/orgs","repos_url":"https://api.github.com/users/faustbrian/repos","events_url":"https://api.github.com/users/faustbrian/events{/privacy}","received_events_url":"https://api.github.com/users/faustbrian/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/faustbrian/ARK-PHP","description":null,"fork":false,"url":"https://api.github.com/repos/faustbrian/ARK-PHP","forks_url":"https://api.github.com/repos/faustbrian/ARK-PHP/forks","keys_url":"https://api.github.com/repos/faustbrian/ARK-PHP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/faustbrian/ARK-PHP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/faustbrian/ARK-PHP/teams","hooks_url":"https://api.github.com/repos/faustbrian/ARK-PHP/hooks","issue_events_url":"https://api.github.com/repos/faustbrian/ARK-PHP/issues/events{/number}","events_url":"https://api.github.com/repos/faustbrian/ARK-PHP/events","assignees_url":"https://api.github.com/repos/faustbrian/ARK-PHP/assignees{/user}","branches_url":"https://api.github.com/repos/faustbrian/ARK-PHP/branches{/branch}","tags_url":"https://api.github.com/repos/faustbrian/ARK-PHP/tags","blobs_url":"https://api.github.com/repos/faustbrian/ARK-PHP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/faustbrian/ARK-PHP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/faustbrian/ARK-PHP/git/refs{/sha}","trees_url":"https://api.github.com/repos/faustbrian/ARK-PHP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/faustbrian/ARK-PHP/statuses/{sha}","languages_url":"https://api.github.com/repos/faustbrian/ARK-PHP/languages","stargazers_url":"https://api.github.com/repos/faustbrian/ARK-PHP/stargazers","contributors_url":"https://api.github.com/repos/faustbrian/ARK-PHP/contributors","subscribers_url":"https://api.github.com/repos/faustbrian/ARK-PHP/subscribers","subscription_url":"https://api.github.com/repos/faustbrian/ARK-PHP/subscription","commits_url":"https://api.github.com/repos/faustbrian/ARK-PHP/commits{/sha}","git_commits_url":"https://api.github.com/repos/faustbrian/ARK-PHP/git/commits{/sha}","comments_url":"https://api.github.com/repos/faustbrian/ARK-PHP/comments{/number}","issue_comment_url":"https://api.github.com/repos/faustbrian/ARK-PHP/issues/comments{/number}","contents_url":"https://api.github.com/repos/faustbrian/ARK-PHP/contents/{+path}","compare_url":"https://api.github.com/repos/faustbrian/ARK-PHP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/faustbrian/ARK-PHP/merges","archive_url":"https://api.github.com/repos/faustbrian/ARK-PHP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/faustbrian/ARK-PHP/downloads","issues_url":"https://api.github.com/repos/faustbrian/ARK-PHP/issues{/number}","pulls_url":"https://api.github.com/repos/faustbrian/ARK-PHP/pulls{/number}","milestones_url":"https://api.github.com/repos/faustbrian/ARK-PHP/milestones{/number}","notifications_url":"https://api.github.com/repos/faustbrian/ARK-PHP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/faustbrian/ARK-PHP/labels{/name}","releases_url":"https://api.github.com/repos/faustbrian/ARK-PHP/releases{/id}","deployments_url":"https://api.github.com/repos/faustbrian/ARK-PHP/deployments","created_at":"2017-12-04T08:04:04Z","updated_at":"2018-02-02T09:38:12Z","pushed_at":"2018-02-04T06:55:36Z","git_url":"git://github.com/faustbrian/ARK-PHP.git","ssh_url":"git@github.com:faustbrian/ARK-PHP.git","clone_url":"https://github.com/faustbrian/ARK-PHP.git","svn_url":"https://github.com/faustbrian/ARK-PHP","homepage":null,"size":160,"stargazers_count":7,"watchers_count":7,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":4,"open_issues":1,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/faustbrian/ARK-PHP/pulls/2"},"html":{"href":"https://github.com/faustbrian/ARK-PHP/pull/2"},"issue":{"href":"https://api.github.com/repos/faustbrian/ARK-PHP/issues/2"},"comments":{"href":"https://api.github.com/repos/faustbrian/ARK-PHP/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/faustbrian/ARK-PHP/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/faustbrian/ARK-PHP/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/faustbrian/ARK-PHP/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/faustbrian/ARK-PHP/statuses/28b34c93038926a6c71431a9f5baba578589d4df"}},"author_association":"NONE"}}
{"actor":{"display_login":"faustbrian"}}