{"action":"created","comment":{"url":"https://api.github.com/repos/census-instrumentation/opencensus-specs/pulls/comments/213246958","pull_request_review_id":150041315,"id":213246958,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzI0Njk1OA==","diff_hunk":"@@ -0,0 +1,137 @@\n+# Resource API Overview\n+The resource library primarily defines a type that captures information about the entity\n+for which stats or traces are recorded. It further provides a framework for detection of\n+resource information from the environment and progressive population as signals propagate\n+from the core instrumentation library to a backend's exporter.\n+\n+## Resource type\n+A `Resource` describes the entity for which a signal was collected through two fields:\n+* `type`: a string which describes a well-known type of entity. It SHOULD be namespaced\n+to avoid collisions across different environment, e.g. `k8s.io/container`,\n+`cloud.google.com/gce/instance`. \n+* `labels`: a dictionary of labels with string keys and values that provide information\n+about the entity.\n+\n+Type strings and label keys MAY start with a domain name and MAY be further namespaced through\n+single slashes. All other characters MUST be alphanumeric. Label values MAY contain any valid\n+unicode character.\n+\n+Implementations MAY define a `Resource` data type, constructed from the parameters above.\n+`Resource` MUST have getters for retrieving all the information used in `Resource` definition.\n+\n+Example in Go:\n+```go\n+type Resource {\n+\tType   string\n+\tLabels map[string]string\n+}\n+```\n+\n+## Populating resources\n+Resource information MAY be populated at any point between startup of the instrumented\n+application and passing it to a backend-specific exporter. This explicitly includes\n+the path through future OpenCensus components such as agents or services.\n+\n+For example, process-identifying information may be populated through the library while\n+an agent attaches further labels about the underlying VM, the cluster, or geo-location.\n+","path":"resource/Resource.md","position":37,"original_position":37,"commit_id":"2d85eb8376fe8838a0c6113e1ff9b75c0103dcbc","original_commit_id":"2d85eb8376fe8838a0c6113e1ff9b75c0103dcbc","user":{"login":"fabxc","id":4948210,"node_id":"MDQ6VXNlcjQ5NDgyMTA=","avatar_url":"https://avatars2.githubusercontent.com/u/4948210?v=4","gravatar_id":"","url":"https://api.github.com/users/fabxc","html_url":"https://github.com/fabxc","followers_url":"https://api.github.com/users/fabxc/followers","following_url":"https://api.github.com/users/fabxc/following{/other_user}","gists_url":"https://api.github.com/users/fabxc/gists{/gist_id}","starred_url":"https://api.github.com/users/fabxc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabxc/subscriptions","organizations_url":"https://api.github.com/users/fabxc/orgs","repos_url":"https://api.github.com/users/fabxc/repos","events_url":"https://api.github.com/users/fabxc/events{/privacy}","received_events_url":"https://api.github.com/users/fabxc/received_events","type":"User","site_admin":false},"body":"Mh, what do you mean specifically? Like when a resource is just passed around via internal OC APIs?","created_at":"2018-08-28T09:39:39Z","updated_at":"2018-08-28T09:46:53Z","html_url":"https://github.com/census-instrumentation/opencensus-specs/pull/162#discussion_r213246958","pull_request_url":"https://api.github.com/repos/census-instrumentation/opencensus-specs/pulls/162","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-specs/pulls/comments/213246958"},"html":{"href":"https://github.com/census-instrumentation/opencensus-specs/pull/162#discussion_r213246958"},"pull_request":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-specs/pulls/162"}},"in_reply_to_id":213007927},"pull_request":{"url":"https://api.github.com/repos/census-instrumentation/opencensus-specs/pulls/162","id":210439446,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNDM5NDQ2","html_url":"https://github.com/census-instrumentation/opencensus-specs/pull/162","diff_url":"https://github.com/census-instrumentation/opencensus-specs/pull/162.diff","patch_url":"https://github.com/census-instrumentation/opencensus-specs/pull/162.patch","issue_url":"https://api.github.com/repos/census-instrumentation/opencensus-specs/issues/162","number":162,"state":"open","locked":false,"title":"Add resource specs","user":{"login":"fabxc","id":4948210,"node_id":"MDQ6VXNlcjQ5NDgyMTA=","avatar_url":"https://avatars2.githubusercontent.com/u/4948210?v=4","gravatar_id":"","url":"https://api.github.com/users/fabxc","html_url":"https://github.com/fabxc","followers_url":"https://api.github.com/users/fabxc/followers","following_url":"https://api.github.com/users/fabxc/following{/other_user}","gists_url":"https://api.github.com/users/fabxc/gists{/gist_id}","starred_url":"https://api.github.com/users/fabxc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabxc/subscriptions","organizations_url":"https://api.github.com/users/fabxc/orgs","repos_url":"https://api.github.com/users/fabxc/repos","events_url":"https://api.github.com/users/fabxc/events{/privacy}","received_events_url":"https://api.github.com/users/fabxc/received_events","type":"User","site_admin":false},"body":"This spec aims to cover my proposal for a resource package in the core library ([Go reference implementation](census-instrumentation/opencensus-go#878)).\r\nI dropped the existing spec that was covering specific cloud vendor auto-detection since part of the proposal is that those live independently in `census-ecosystem` or entirely elsewhere.\r\n\r\nI took my best guesses on MAY vs. SHOULD vs. MUST based on existing specs but don't feel strongly in most cases. Any guidance is appreciated.\r\n","created_at":"2018-08-23T12:59:24Z","updated_at":"2018-08-28T09:46:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"183bbfb37128c577bcceaccbb5241195c7faa37f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ramonza","id":349160,"node_id":"MDQ6VXNlcjM0OTE2MA==","avatar_url":"https://avatars2.githubusercontent.com/u/349160?v=4","gravatar_id":"","url":"https://api.github.com/users/ramonza","html_url":"https://github.com/ramonza","followers_url":"https://api.github.com/users/ramonza/followers","following_url":"https://api.github.com/users/ramonza/following{/other_user}","gists_url":"https://api.github.com/users/ramonza/gists{/gist_id}","starred_url":"https://api.github.com/users/ramonza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramonza/subscriptions","organizations_url":"https://api.github.com/users/ramonza/orgs","repos_url":"https://api.github.com/users/ramonza/repos","events_url":"https://api.github.com/users/ramonza/events{/privacy}","received_events_url":"https://api.github.com/users/ramonza/received_events","type":"User","site_admin":false},{"login":"bogdandrutu","id":1373887,"node_id":"MDQ6VXNlcjEzNzM4ODc=","avatar_url":"https://avatars0.githubusercontent.com/u/1373887?v=4","gravatar_id":"","url":"https://api.github.com/users/bogdandrutu","html_url":"https://github.com/bogdandrutu","followers_url":"https://api.github.com/users/bogdandrutu/followers","following_url":"https://api.github.com/users/bogdandrutu/following{/other_user}","gists_url":"https://api.github.com/users/bogdandrutu/gists{/gist_id}","starred_url":"https://api.github.com/users/bogdandrutu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bogdandrutu/subscriptions","organizations_url":"https://api.github.com/users/bogdandrutu/orgs","repos_url":"https://api.github.com/users/bogdandrutu/repos","events_url":"https://api.github.com/users/bogdandrutu/events{/privacy}","received_events_url":"https://api.github.com/users/bogdandrutu/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/census-instrumentation/opencensus-specs/pulls/162/commits","review_comments_url":"https://api.github.com/repos/census-instrumentation/opencensus-specs/pulls/162/comments","review_comment_url":"https://api.github.com/repos/census-instrumentation/opencensus-specs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/census-instrumentation/opencensus-specs/issues/162/comments","statuses_url":"https://api.github.com/repos/census-instrumentation/opencensus-specs/statuses/2d85eb8376fe8838a0c6113e1ff9b75c0103dcbc","head":{"label":"fabxc:resource","ref":"resource","sha":"2d85eb8376fe8838a0c6113e1ff9b75c0103dcbc","user":{"login":"fabxc","id":4948210,"node_id":"MDQ6VXNlcjQ5NDgyMTA=","avatar_url":"https://avatars2.githubusercontent.com/u/4948210?v=4","gravatar_id":"","url":"https://api.github.com/users/fabxc","html_url":"https://github.com/fabxc","followers_url":"https://api.github.com/users/fabxc/followers","following_url":"https://api.github.com/users/fabxc/following{/other_user}","gists_url":"https://api.github.com/users/fabxc/gists{/gist_id}","starred_url":"https://api.github.com/users/fabxc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabxc/subscriptions","organizations_url":"https://api.github.com/users/fabxc/orgs","repos_url":"https://api.github.com/users/fabxc/repos","events_url":"https://api.github.com/users/fabxc/events{/privacy}","received_events_url":"https://api.github.com/users/fabxc/received_events","type":"User","site_admin":false},"repo":{"id":145840035,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU4NDAwMzU=","name":"opencensus-specs","full_name":"fabxc/opencensus-specs","owner":{"login":"fabxc","id":4948210,"node_id":"MDQ6VXNlcjQ5NDgyMTA=","avatar_url":"https://avatars2.githubusercontent.com/u/4948210?v=4","gravatar_id":"","url":"https://api.github.com/users/fabxc","html_url":"https://github.com/fabxc","followers_url":"https://api.github.com/users/fabxc/followers","following_url":"https://api.github.com/users/fabxc/following{/other_user}","gists_url":"https://api.github.com/users/fabxc/gists{/gist_id}","starred_url":"https://api.github.com/users/fabxc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fabxc/subscriptions","organizations_url":"https://api.github.com/users/fabxc/orgs","repos_url":"https://api.github.com/users/fabxc/repos","events_url":"https://api.github.com/users/fabxc/events{/privacy}","received_events_url":"https://api.github.com/users/fabxc/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fabxc/opencensus-specs","description":null,"fork":true,"url":"https://api.github.com/repos/fabxc/opencensus-specs","forks_url":"https://api.github.com/repos/fabxc/opencensus-specs/forks","keys_url":"https://api.github.com/repos/fabxc/opencensus-specs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fabxc/opencensus-specs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fabxc/opencensus-specs/teams","hooks_url":"https://api.github.com/repos/fabxc/opencensus-specs/hooks","issue_events_url":"https://api.github.com/repos/fabxc/opencensus-specs/issues/events{/number}","events_url":"https://api.github.com/repos/fabxc/opencensus-specs/events","assignees_url":"https://api.github.com/repos/fabxc/opencensus-specs/assignees{/user}","branches_url":"https://api.github.com/repos/fabxc/opencensus-specs/branches{/branch}","tags_url":"https://api.github.com/repos/fabxc/opencensus-specs/tags","blobs_url":"https://api.github.com/repos/fabxc/opencensus-specs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fabxc/opencensus-specs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fabxc/opencensus-specs/git/refs{/sha}","trees_url":"https://api.github.com/repos/fabxc/opencensus-specs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fabxc/opencensus-specs/statuses/{sha}","languages_url":"https://api.github.com/repos/fabxc/opencensus-specs/languages","stargazers_url":"https://api.github.com/repos/fabxc/opencensus-specs/stargazers","contributors_url":"https://api.github.com/repos/fabxc/opencensus-specs/contributors","subscribers_url":"https://api.github.com/repos/fabxc/opencensus-specs/subscribers","subscription_url":"https://api.github.com/repos/fabxc/opencensus-specs/subscription","commits_url":"https://api.github.com/repos/fabxc/opencensus-specs/commits{/sha}","git_commits_url":"https://api.github.com/repos/fabxc/opencensus-specs/git/commits{/sha}","comments_url":"https://api.github.com/repos/fabxc/opencensus-specs/comments{/number}","issue_comment_url":"https://api.github.com/repos/fabxc/opencensus-specs/issues/comments{/number}","contents_url":"https://api.github.com/repos/fabxc/opencensus-specs/contents/{+path}","compare_url":"https://api.github.com/repos/fabxc/opencensus-specs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fabxc/opencensus-specs/merges","archive_url":"https://api.github.com/repos/fabxc/opencensus-specs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fabxc/opencensus-specs/downloads","issues_url":"https://api.github.com/repos/fabxc/opencensus-specs/issues{/number}","pulls_url":"https://api.github.com/repos/fabxc/opencensus-specs/pulls{/number}","milestones_url":"https://api.github.com/repos/fabxc/opencensus-specs/milestones{/number}","notifications_url":"https://api.github.com/repos/fabxc/opencensus-specs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fabxc/opencensus-specs/labels{/name}","releases_url":"https://api.github.com/repos/fabxc/opencensus-specs/releases{/id}","deployments_url":"https://api.github.com/repos/fabxc/opencensus-specs/deployments","created_at":"2018-08-23T10:46:08Z","updated_at":"2018-08-23T10:46:10Z","pushed_at":"2018-08-27T13:37:16Z","git_url":"git://github.com/fabxc/opencensus-specs.git","ssh_url":"git@github.com:fabxc/opencensus-specs.git","clone_url":"https://github.com/fabxc/opencensus-specs.git","svn_url":"https://github.com/fabxc/opencensus-specs","homepage":null,"size":251,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"census-instrumentation:master","ref":"master","sha":"4457606f1c8c80312850e229d28cd3260b7f9c67","user":{"login":"census-instrumentation","id":26944525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2OTQ0NTI1","avatar_url":"https://avatars0.githubusercontent.com/u/26944525?v=4","gravatar_id":"","url":"https://api.github.com/users/census-instrumentation","html_url":"https://github.com/census-instrumentation","followers_url":"https://api.github.com/users/census-instrumentation/followers","following_url":"https://api.github.com/users/census-instrumentation/following{/other_user}","gists_url":"https://api.github.com/users/census-instrumentation/gists{/gist_id}","starred_url":"https://api.github.com/users/census-instrumentation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/census-instrumentation/subscriptions","organizations_url":"https://api.github.com/users/census-instrumentation/orgs","repos_url":"https://api.github.com/users/census-instrumentation/repos","events_url":"https://api.github.com/users/census-instrumentation/events{/privacy}","received_events_url":"https://api.github.com/users/census-instrumentation/received_events","type":"Organization","site_admin":false},"repo":{"id":101325823,"node_id":"MDEwOlJlcG9zaXRvcnkxMDEzMjU4MjM=","name":"opencensus-specs","full_name":"census-instrumentation/opencensus-specs","owner":{"login":"census-instrumentation","id":26944525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2OTQ0NTI1","avatar_url":"https://avatars0.githubusercontent.com/u/26944525?v=4","gravatar_id":"","url":"https://api.github.com/users/census-instrumentation","html_url":"https://github.com/census-instrumentation","followers_url":"https://api.github.com/users/census-instrumentation/followers","following_url":"https://api.github.com/users/census-instrumentation/following{/other_user}","gists_url":"https://api.github.com/users/census-instrumentation/gists{/gist_id}","starred_url":"https://api.github.com/users/census-instrumentation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/census-instrumentation/subscriptions","organizations_url":"https://api.github.com/users/census-instrumentation/orgs","repos_url":"https://api.github.com/users/census-instrumentation/repos","events_url":"https://api.github.com/users/census-instrumentation/events{/privacy}","received_events_url":"https://api.github.com/users/census-instrumentation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/census-instrumentation/opencensus-specs","description":null,"fork":false,"url":"https://api.github.com/repos/census-instrumentation/opencensus-specs","forks_url":"https://api.github.com/repos/census-instrumentation/opencensus-specs/forks","keys_url":"https://api.github.com/repos/census-instrumentation/opencensus-specs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/census-instrumentation/opencensus-specs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/census-instrumentation/opencensus-specs/teams","hooks_url":"https://api.github.com/repos/census-instrumentation/opencensus-specs/hooks","issue_events_url":"https://api.github.com/repos/census-instrumentation/opencensus-specs/issues/events{/number}","events_url":"https://api.github.com/repos/census-instrumentation/opencensus-specs/events","assignees_url":"https://api.github.com/repos/census-instrumentation/opencensus-specs/assignees{/user}","branches_url":"https://api.github.com/repos/census-instrumentation/opencensus-specs/branches{/branch}","tags_url":"https://api.github.com/repos/census-instrumentation/opencensus-specs/tags","blobs_url":"https://api.github.com/repos/census-instrumentation/opencensus-specs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/census-instrumentation/opencensus-specs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/census-instrumentation/opencensus-specs/git/refs{/sha}","trees_url":"https://api.github.com/repos/census-instrumentation/opencensus-specs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/census-instrumentation/opencensus-specs/statuses/{sha}","languages_url":"https://api.github.com/repos/census-instrumentation/opencensus-specs/languages","stargazers_url":"https://api.github.com/repos/census-instrumentation/opencensus-specs/stargazers","contributors_url":"https://api.github.com/repos/census-instrumentation/opencensus-specs/contributors","subscribers_url":"https://api.github.com/repos/census-instrumentation/opencensus-specs/subscribers","subscription_url":"https://api.github.com/repos/census-instrumentation/opencensus-specs/subscription","commits_url":"https://api.github.com/repos/census-instrumentation/opencensus-specs/commits{/sha}","git_commits_url":"https://api.github.com/repos/census-instrumentation/opencensus-specs/git/commits{/sha}","comments_url":"https://api.github.com/repos/census-instrumentation/opencensus-specs/comments{/number}","issue_comment_url":"https://api.github.com/repos/census-instrumentation/opencensus-specs/issues/comments{/number}","contents_url":"https://api.github.com/repos/census-instrumentation/opencensus-specs/contents/{+path}","compare_url":"https://api.github.com/repos/census-instrumentation/opencensus-specs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/census-instrumentation/opencensus-specs/merges","archive_url":"https://api.github.com/repos/census-instrumentation/opencensus-specs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/census-instrumentation/opencensus-specs/downloads","issues_url":"https://api.github.com/repos/census-instrumentation/opencensus-specs/issues{/number}","pulls_url":"https://api.github.com/repos/census-instrumentation/opencensus-specs/pulls{/number}","milestones_url":"https://api.github.com/repos/census-instrumentation/opencensus-specs/milestones{/number}","notifications_url":"https://api.github.com/repos/census-instrumentation/opencensus-specs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/census-instrumentation/opencensus-specs/labels{/name}","releases_url":"https://api.github.com/repos/census-instrumentation/opencensus-specs/releases{/id}","deployments_url":"https://api.github.com/repos/census-instrumentation/opencensus-specs/deployments","created_at":"2017-08-24T18:30:09Z","updated_at":"2018-08-28T09:40:20Z","pushed_at":"2018-08-28T09:40:18Z","git_url":"git://github.com/census-instrumentation/opencensus-specs.git","ssh_url":"git@github.com:census-instrumentation/opencensus-specs.git","clone_url":"https://github.com/census-instrumentation/opencensus-specs.git","svn_url":"https://github.com/census-instrumentation/opencensus-specs","homepage":null,"size":253,"stargazers_count":106,"watchers_count":106,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":65,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":24,"open_issues":65,"watchers":106,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-specs/pulls/162"},"html":{"href":"https://github.com/census-instrumentation/opencensus-specs/pull/162"},"issue":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-specs/issues/162"},"comments":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-specs/issues/162/comments"},"review_comments":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-specs/pulls/162/comments"},"review_comment":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-specs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-specs/pulls/162/commits"},"statuses":{"href":"https://api.github.com/repos/census-instrumentation/opencensus-specs/statuses/2d85eb8376fe8838a0c6113e1ff9b75c0103dcbc"}},"author_association":"NONE"}}
{"actor":{"display_login":"fabxc"}}