{"action":"created","issue":{"url":"https://api.github.com/repos/pvlib/pvlib-python/issues/583","repository_url":"https://api.github.com/repos/pvlib/pvlib-python","labels_url":"https://api.github.com/repos/pvlib/pvlib-python/issues/583/labels{/name}","comments_url":"https://api.github.com/repos/pvlib/pvlib-python/issues/583/comments","events_url":"https://api.github.com/repos/pvlib/pvlib-python/issues/583/events","html_url":"https://github.com/pvlib/pvlib-python/pull/583","id":361963706,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2ODA0NjY2","number":583,"title":"add analytical methods from Frank Vignola's book for sunrise, sunset,…","user":{"login":"mikofski","id":1385621,"node_id":"MDQ6VXNlcjEzODU2MjE=","avatar_url":"https://avatars1.githubusercontent.com/u/1385621?v=4","gravatar_id":"","url":"https://api.github.com/users/mikofski","html_url":"https://github.com/mikofski","followers_url":"https://api.github.com/users/mikofski/followers","following_url":"https://api.github.com/users/mikofski/following{/other_user}","gists_url":"https://api.github.com/users/mikofski/gists{/gist_id}","starred_url":"https://api.github.com/users/mikofski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikofski/subscriptions","organizations_url":"https://api.github.com/users/mikofski/orgs","repos_url":"https://api.github.com/users/mikofski/repos","events_url":"https://api.github.com/users/mikofski/events{/privacy}","received_events_url":"https://api.github.com/users/mikofski/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-09-19T23:25:33Z","updated_at":"2018-09-24T18:18:22Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/pvlib/pvlib-python/pulls/583","html_url":"https://github.com/pvlib/pvlib-python/pull/583","diff_url":"https://github.com/pvlib/pvlib-python/pull/583.diff","patch_url":"https://github.com/pvlib/pvlib-python/pull/583.patch"},"body":"… and sun transit times\r\n\r\npvlib python pull request guidelines\r\n====================================\r\n\r\nThank you for your contribution to pvlib python! You may delete all of these instructions except for the list below.\r\n\r\nYou may submit a pull request with your code at any stage of completion.\r\n\r\nThe following items must be addressed before the code can be merged. Please don't hesitate to ask for help if you're unsure of how to accomplish any of the items below:\r\n\r\n - [x] Closes issue #114\r\n - [x] I am familiar with the [contributing guidelines](http://pvlib-python.readthedocs.io/en/latest/contributing.html).\r\n - [x] Fully tested. Added and/or modified tests to ensure correct behavior for all reasonable inputs. Tests (usually) must pass on the TravisCI and Appveyor testing services.\r\n - [ ] Updates entries to `docs/sphinx/source/api.rst` for API changes.\r\n - [ ] Adds description and name entries in the appropriate `docs/sphinx/source/whatsnew` file for all changes.\r\n - [ ] Code quality and style is sufficient. Passes LGTM and SticklerCI checks.\r\n - [x] New code is fully documented. Includes sphinx/numpydoc compliant docstrings and comments in the code where necessary.\r\n - [x] Pull request is nearly complete and ready for detailed review.\r\n\r\nBrief description of the problem and proposed solution (if not already fully described in the issue linked to above):\r\n"},"comment":{"url":"https://api.github.com/repos/pvlib/pvlib-python/issues/comments/424073878","html_url":"https://github.com/pvlib/pvlib-python/pull/583#issuecomment-424073878","issue_url":"https://api.github.com/repos/pvlib/pvlib-python/issues/583","id":424073878,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNDA3Mzg3OA==","user":{"login":"wholmgren","id":4383303,"node_id":"MDQ6VXNlcjQzODMzMDM=","avatar_url":"https://avatars0.githubusercontent.com/u/4383303?v=4","gravatar_id":"","url":"https://api.github.com/users/wholmgren","html_url":"https://github.com/wholmgren","followers_url":"https://api.github.com/users/wholmgren/followers","following_url":"https://api.github.com/users/wholmgren/following{/other_user}","gists_url":"https://api.github.com/users/wholmgren/gists{/gist_id}","starred_url":"https://api.github.com/users/wholmgren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wholmgren/subscriptions","organizations_url":"https://api.github.com/users/wholmgren/orgs","repos_url":"https://api.github.com/users/wholmgren/repos","events_url":"https://api.github.com/users/wholmgren/events{/privacy}","received_events_url":"https://api.github.com/users/wholmgren/received_events","type":"User","site_admin":false},"created_at":"2018-09-24T18:18:22Z","updated_at":"2018-09-24T18:18:22Z","author_association":"MEMBER","body":"> Since there are so many API changes in v0.6 can we consider maybe updating some of the minimum requirements now? Pandas is currently v0.23.4 and NumPy is at 1.15, keeping really old requirements seems limiting to me a little.\r\n\r\nI am all in favor of raising the minimums if there is a reason to do so. But I take these incompatibilities as sign that the approach might be too complicated and will be difficult to maintain in the future. Let's think about if this is really the implementation that we want.\r\n\r\nSomewhere you commented something to the effect of the spec'ed minimum numpy/pandas versions are incompatible -- is it that they are incompatible or that Continuum doesn't supply pre-built binaries for them?\r\n\r\n> Also, can we maybe consider dropping support for Python-3.4?\r\n\r\nWe can consider this too but not in this pull request."}}
{"actor":{"display_login":"wholmgren"}}