{"action":"created","issue":{"url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/3260","repository_url":"https://api.github.com/repos/MovingBlocks/Terasology","labels_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/3260/labels{/name}","comments_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/3260/comments","events_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/3260/events","html_url":"https://github.com/MovingBlocks/Terasology/pull/3260","id":297264729,"number":3260,"title":"Automatically follow HTTP/HTTPS redirects for identity storage service","user":{"login":"gianluca-nitti","id":15270303,"avatar_url":"https://avatars0.githubusercontent.com/u/15270303?v=4","gravatar_id":"","url":"https://api.github.com/users/gianluca-nitti","html_url":"https://github.com/gianluca-nitti","followers_url":"https://api.github.com/users/gianluca-nitti/followers","following_url":"https://api.github.com/users/gianluca-nitti/following{/other_user}","gists_url":"https://api.github.com/users/gianluca-nitti/gists{/gist_id}","starred_url":"https://api.github.com/users/gianluca-nitti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gianluca-nitti/subscriptions","organizations_url":"https://api.github.com/users/gianluca-nitti/orgs","repos_url":"https://api.github.com/users/gianluca-nitti/repos","events_url":"https://api.github.com/users/gianluca-nitti/events{/privacy}","received_events_url":"https://api.github.com/users/gianluca-nitti/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-02-14T22:14:43Z","updated_at":"2018-03-04T02:46:38Z","closed_at":"2018-03-04T02:42:58Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/MovingBlocks/Terasology/pulls/3260","html_url":"https://github.com/MovingBlocks/Terasology/pull/3260","diff_url":"https://github.com/MovingBlocks/Terasology/pull/3260.diff","patch_url":"https://github.com/MovingBlocks/Terasology/pull/3260.patch"},"body":"<!-- Thanks for submitting a pull request for Terasology! :-)\r\nPlease fill in some brief details below about the PR.\r\nIf it contains source code please make sure to run Checkstyle on it first\r\nIf you add unit tests we'll love you forever! -->\r\n\r\n### Contains\r\n\r\nThe identity storage service client now correctly follows HTTP redirects (301/302). Particularly useful if the server forces HTTP requests to move to HTTPS through 301/302 redirects, like the official server (http://utility.terasology.org) is now doing thanks to @qwc.\r\n\r\n### How to test\r\n\r\nTry to use the identity storage service on the official server (http://utility.terasology.org), by clicking (from the main menu) Settings > Player > Login. On the current master/develop branches, it will only work if you enter the HTTPS URL (https://utility.terasology.org); the login will fail if you put the plain HTTP URL (http://utility.terasology.org), because it redirects to the HTTPS one but the client does not follow this redirect.\r\nOn this branch, both the HTTP and HTTPS URLs work (HTTP can be a bit slower due to the larger number of requests involved) because when entering the HTTP one the redirect to the HTTPS one is correctly followed.\r\n\r\n### Outstanding before merging\r\n\r\nNot sure how much it's related but maybe we could populate by default the \"Service URL\" field in the login dialog with https://utility.terasology.org if this can help new users. Obviously, one would still be allowed to modify the field to use an alternative server if they want, anyway I'm not sure if populating it by default with our server is appropriate, just dropping it here as an idea."},"comment":{"url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/comments/370197352","html_url":"https://github.com/MovingBlocks/Terasology/pull/3260#issuecomment-370197352","issue_url":"https://api.github.com/repos/MovingBlocks/Terasology/issues/3260","id":370197352,"user":{"login":"Cervator","id":1063833,"avatar_url":"https://avatars3.githubusercontent.com/u/1063833?v=4","gravatar_id":"","url":"https://api.github.com/users/Cervator","html_url":"https://github.com/Cervator","followers_url":"https://api.github.com/users/Cervator/followers","following_url":"https://api.github.com/users/Cervator/following{/other_user}","gists_url":"https://api.github.com/users/Cervator/gists{/gist_id}","starred_url":"https://api.github.com/users/Cervator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cervator/subscriptions","organizations_url":"https://api.github.com/users/Cervator/orgs","repos_url":"https://api.github.com/users/Cervator/repos","events_url":"https://api.github.com/users/Cervator/events{/privacy}","received_events_url":"https://api.github.com/users/Cervator/received_events","type":"User","site_admin":false},"created_at":"2018-03-04T02:46:38Z","updated_at":"2018-03-04T02:46:38Z","author_association":"OWNER","body":"Thanks for that - tested out well :-)\r\n\r\nAlthough, I tried signing up for a new account and after several minutes don't have the confirmation email so I can't actually log in. Was able to still validate it anyway. I have a bad feeling one or more of our servers are stuck in an IP group that got used for spamming and blacklisted recently. Getting lots of email bounces for emails sent by the forum :/\r\n\r\nI don't know if there is a return email for the confirmation emails, to indicate a failure to send? Wonder how we can improve that setup.\r\n\r\nI added in `https://utility.terasology.org` as default text for the URL, that seems perfectly fair and a good convenience. Also reminded me how badly we need the UI tabbing support #483 :D"}}
{"actor":{"display_login":"Cervator"}}