{"action":"created","comment":{"url":"https://api.github.com/repos/reactos/reactos/pulls/comments/240038346","pull_request_review_id":182979953,"id":240038346,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDAzODM0Ng==","diff_hunk":"@@ -3,5 +3,5 @@ file(GLOB osk_rc_deps res/*.*)\n add_rc_deps(rsrc.rc ${osk_rc_deps})\n add_executable(osk main.c settings.c rsrc.rc)\n set_module_type(osk win32gui UNICODE)\n-add_importlibs(osk comdlg32 shell32 user32 gdi32 advapi32 comctl32 msvcrt kernel32)\n+add_importlibs(osk comdlg32 shell32 user32 gdi32 advapi32 comctl32 msvcrt kernel32 ntdll)","path":"base/applications/osk/CMakeLists.txt","position":5,"original_position":5,"commit_id":"8bcea982e39f827c0b6ca8825f31384bc6174502","original_commit_id":"8bcea982e39f827c0b6ca8825f31384bc6174502","user":{"login":"HBelusca","id":1969829,"node_id":"MDQ6VXNlcjE5Njk4Mjk=","avatar_url":"https://avatars1.githubusercontent.com/u/1969829?v=4","gravatar_id":"","url":"https://api.github.com/users/HBelusca","html_url":"https://github.com/HBelusca","followers_url":"https://api.github.com/users/HBelusca/followers","following_url":"https://api.github.com/users/HBelusca/following{/other_user}","gists_url":"https://api.github.com/users/HBelusca/gists{/gist_id}","starred_url":"https://api.github.com/users/HBelusca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HBelusca/subscriptions","organizations_url":"https://api.github.com/users/HBelusca/orgs","repos_url":"https://api.github.com/users/HBelusca/repos","events_url":"https://api.github.com/users/HBelusca/events{/privacy}","received_events_url":"https://api.github.com/users/HBelusca/received_events","type":"User","site_admin":false},"body":"Unneeded.","created_at":"2018-12-09T14:09:21Z","updated_at":"2018-12-09T14:09:21Z","html_url":"https://github.com/reactos/reactos/pull/1105#discussion_r240038346","pull_request_url":"https://api.github.com/repos/reactos/reactos/pulls/1105","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/reactos/reactos/pulls/comments/240038346"},"html":{"href":"https://github.com/reactos/reactos/pull/1105#discussion_r240038346"},"pull_request":{"href":"https://api.github.com/repos/reactos/reactos/pulls/1105"}}},"pull_request":{"url":"https://api.github.com/repos/reactos/reactos/pulls/1105","id":237118748,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3MTE4NzQ4","html_url":"https://github.com/reactos/reactos/pull/1105","diff_url":"https://github.com/reactos/reactos/pull/1105.diff","patch_url":"https://github.com/reactos/reactos/pull/1105.patch","issue_url":"https://api.github.com/repos/reactos/reactos/issues/1105","number":1105,"state":"open","locked":false,"title":"[OSK] Display the correct icon of the application","user":{"login":"Fraizeraust","id":34916900,"node_id":"MDQ6VXNlcjM0OTE2OTAw","avatar_url":"https://avatars3.githubusercontent.com/u/34916900?v=4","gravatar_id":"","url":"https://api.github.com/users/Fraizeraust","html_url":"https://github.com/Fraizeraust","followers_url":"https://api.github.com/users/Fraizeraust/followers","following_url":"https://api.github.com/users/Fraizeraust/following{/other_user}","gists_url":"https://api.github.com/users/Fraizeraust/gists{/gist_id}","starred_url":"https://api.github.com/users/Fraizeraust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fraizeraust/subscriptions","organizations_url":"https://api.github.com/users/Fraizeraust/orgs","repos_url":"https://api.github.com/users/Fraizeraust/repos","events_url":"https://api.github.com/users/Fraizeraust/events{/privacy}","received_events_url":"https://api.github.com/users/Fraizeraust/received_events","type":"User","site_admin":false},"body":"## Purpose\r\nAs requested by Hermes Belusca (on #1102), this patch fixes the issue which it couldn't display the original On-Screen Keyboard icon.\r\n## Proposed Changes\r\n- Implement `OSK_SetImageApp()`\r\n- Call the function on `WM_INITDIALOG` when the message is sent","created_at":"2018-12-09T09:22:02Z","updated_at":"2018-12-09T14:09:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bb36589961439d7d763da007cf219cfc9a817e86","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/reactos/reactos/pulls/1105/commits","review_comments_url":"https://api.github.com/repos/reactos/reactos/pulls/1105/comments","review_comment_url":"https://api.github.com/repos/reactos/reactos/pulls/comments{/number}","comments_url":"https://api.github.com/repos/reactos/reactos/issues/1105/comments","statuses_url":"https://api.github.com/repos/reactos/reactos/statuses/8bcea982e39f827c0b6ca8825f31384bc6174502","head":{"label":"Fraizeraust:icon-fix","ref":"icon-fix","sha":"8bcea982e39f827c0b6ca8825f31384bc6174502","user":{"login":"Fraizeraust","id":34916900,"node_id":"MDQ6VXNlcjM0OTE2OTAw","avatar_url":"https://avatars3.githubusercontent.com/u/34916900?v=4","gravatar_id":"","url":"https://api.github.com/users/Fraizeraust","html_url":"https://github.com/Fraizeraust","followers_url":"https://api.github.com/users/Fraizeraust/followers","following_url":"https://api.github.com/users/Fraizeraust/following{/other_user}","gists_url":"https://api.github.com/users/Fraizeraust/gists{/gist_id}","starred_url":"https://api.github.com/users/Fraizeraust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fraizeraust/subscriptions","organizations_url":"https://api.github.com/users/Fraizeraust/orgs","repos_url":"https://api.github.com/users/Fraizeraust/repos","events_url":"https://api.github.com/users/Fraizeraust/events{/privacy}","received_events_url":"https://api.github.com/users/Fraizeraust/received_events","type":"User","site_admin":false},"repo":{"id":127411645,"node_id":"MDEwOlJlcG9zaXRvcnkxMjc0MTE2NDU=","name":"reactos","full_name":"Fraizeraust/reactos","private":false,"owner":{"login":"Fraizeraust","id":34916900,"node_id":"MDQ6VXNlcjM0OTE2OTAw","avatar_url":"https://avatars3.githubusercontent.com/u/34916900?v=4","gravatar_id":"","url":"https://api.github.com/users/Fraizeraust","html_url":"https://github.com/Fraizeraust","followers_url":"https://api.github.com/users/Fraizeraust/followers","following_url":"https://api.github.com/users/Fraizeraust/following{/other_user}","gists_url":"https://api.github.com/users/Fraizeraust/gists{/gist_id}","starred_url":"https://api.github.com/users/Fraizeraust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fraizeraust/subscriptions","organizations_url":"https://api.github.com/users/Fraizeraust/orgs","repos_url":"https://api.github.com/users/Fraizeraust/repos","events_url":"https://api.github.com/users/Fraizeraust/events{/privacy}","received_events_url":"https://api.github.com/users/Fraizeraust/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Fraizeraust/reactos","description":"A free Windows-compatible Operating System","fork":true,"url":"https://api.github.com/repos/Fraizeraust/reactos","forks_url":"https://api.github.com/repos/Fraizeraust/reactos/forks","keys_url":"https://api.github.com/repos/Fraizeraust/reactos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Fraizeraust/reactos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Fraizeraust/reactos/teams","hooks_url":"https://api.github.com/repos/Fraizeraust/reactos/hooks","issue_events_url":"https://api.github.com/repos/Fraizeraust/reactos/issues/events{/number}","events_url":"https://api.github.com/repos/Fraizeraust/reactos/events","assignees_url":"https://api.github.com/repos/Fraizeraust/reactos/assignees{/user}","branches_url":"https://api.github.com/repos/Fraizeraust/reactos/branches{/branch}","tags_url":"https://api.github.com/repos/Fraizeraust/reactos/tags","blobs_url":"https://api.github.com/repos/Fraizeraust/reactos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Fraizeraust/reactos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Fraizeraust/reactos/git/refs{/sha}","trees_url":"https://api.github.com/repos/Fraizeraust/reactos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Fraizeraust/reactos/statuses/{sha}","languages_url":"https://api.github.com/repos/Fraizeraust/reactos/languages","stargazers_url":"https://api.github.com/repos/Fraizeraust/reactos/stargazers","contributors_url":"https://api.github.com/repos/Fraizeraust/reactos/contributors","subscribers_url":"https://api.github.com/repos/Fraizeraust/reactos/subscribers","subscription_url":"https://api.github.com/repos/Fraizeraust/reactos/subscription","commits_url":"https://api.github.com/repos/Fraizeraust/reactos/commits{/sha}","git_commits_url":"https://api.github.com/repos/Fraizeraust/reactos/git/commits{/sha}","comments_url":"https://api.github.com/repos/Fraizeraust/reactos/comments{/number}","issue_comment_url":"https://api.github.com/repos/Fraizeraust/reactos/issues/comments{/number}","contents_url":"https://api.github.com/repos/Fraizeraust/reactos/contents/{+path}","compare_url":"https://api.github.com/repos/Fraizeraust/reactos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Fraizeraust/reactos/merges","archive_url":"https://api.github.com/repos/Fraizeraust/reactos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Fraizeraust/reactos/downloads","issues_url":"https://api.github.com/repos/Fraizeraust/reactos/issues{/number}","pulls_url":"https://api.github.com/repos/Fraizeraust/reactos/pulls{/number}","milestones_url":"https://api.github.com/repos/Fraizeraust/reactos/milestones{/number}","notifications_url":"https://api.github.com/repos/Fraizeraust/reactos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Fraizeraust/reactos/labels{/name}","releases_url":"https://api.github.com/repos/Fraizeraust/reactos/releases{/id}","deployments_url":"https://api.github.com/repos/Fraizeraust/reactos/deployments","created_at":"2018-03-30T09:49:13Z","updated_at":"2018-12-09T08:39:32Z","pushed_at":"2018-12-09T13:00:10Z","git_url":"git://github.com/Fraizeraust/reactos.git","ssh_url":"git@github.com:Fraizeraust/reactos.git","clone_url":"https://github.com/Fraizeraust/reactos.git","svn_url":"https://github.com/Fraizeraust/reactos","homepage":null,"size":464823,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"reactos:master","ref":"master","sha":"de7c959c4e5f287c81e61c7e369a5f0ae2c33398","user":{"login":"reactos","id":1056157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTYxNTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1056157?v=4","gravatar_id":"","url":"https://api.github.com/users/reactos","html_url":"https://github.com/reactos","followers_url":"https://api.github.com/users/reactos/followers","following_url":"https://api.github.com/users/reactos/following{/other_user}","gists_url":"https://api.github.com/users/reactos/gists{/gist_id}","starred_url":"https://api.github.com/users/reactos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactos/subscriptions","organizations_url":"https://api.github.com/users/reactos/orgs","repos_url":"https://api.github.com/users/reactos/repos","events_url":"https://api.github.com/users/reactos/events{/privacy}","received_events_url":"https://api.github.com/users/reactos/received_events","type":"Organization","site_admin":false},"repo":{"id":105627846,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU2Mjc4NDY=","name":"reactos","full_name":"reactos/reactos","private":false,"owner":{"login":"reactos","id":1056157,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTYxNTc=","avatar_url":"https://avatars0.githubusercontent.com/u/1056157?v=4","gravatar_id":"","url":"https://api.github.com/users/reactos","html_url":"https://github.com/reactos","followers_url":"https://api.github.com/users/reactos/followers","following_url":"https://api.github.com/users/reactos/following{/other_user}","gists_url":"https://api.github.com/users/reactos/gists{/gist_id}","starred_url":"https://api.github.com/users/reactos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reactos/subscriptions","organizations_url":"https://api.github.com/users/reactos/orgs","repos_url":"https://api.github.com/users/reactos/repos","events_url":"https://api.github.com/users/reactos/events{/privacy}","received_events_url":"https://api.github.com/users/reactos/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/reactos/reactos","description":"A free Windows-compatible Operating System","fork":false,"url":"https://api.github.com/repos/reactos/reactos","forks_url":"https://api.github.com/repos/reactos/reactos/forks","keys_url":"https://api.github.com/repos/reactos/reactos/keys{/key_id}","collaborators_url":"https://api.github.com/repos/reactos/reactos/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/reactos/reactos/teams","hooks_url":"https://api.github.com/repos/reactos/reactos/hooks","issue_events_url":"https://api.github.com/repos/reactos/reactos/issues/events{/number}","events_url":"https://api.github.com/repos/reactos/reactos/events","assignees_url":"https://api.github.com/repos/reactos/reactos/assignees{/user}","branches_url":"https://api.github.com/repos/reactos/reactos/branches{/branch}","tags_url":"https://api.github.com/repos/reactos/reactos/tags","blobs_url":"https://api.github.com/repos/reactos/reactos/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/reactos/reactos/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/reactos/reactos/git/refs{/sha}","trees_url":"https://api.github.com/repos/reactos/reactos/git/trees{/sha}","statuses_url":"https://api.github.com/repos/reactos/reactos/statuses/{sha}","languages_url":"https://api.github.com/repos/reactos/reactos/languages","stargazers_url":"https://api.github.com/repos/reactos/reactos/stargazers","contributors_url":"https://api.github.com/repos/reactos/reactos/contributors","subscribers_url":"https://api.github.com/repos/reactos/reactos/subscribers","subscription_url":"https://api.github.com/repos/reactos/reactos/subscription","commits_url":"https://api.github.com/repos/reactos/reactos/commits{/sha}","git_commits_url":"https://api.github.com/repos/reactos/reactos/git/commits{/sha}","comments_url":"https://api.github.com/repos/reactos/reactos/comments{/number}","issue_comment_url":"https://api.github.com/repos/reactos/reactos/issues/comments{/number}","contents_url":"https://api.github.com/repos/reactos/reactos/contents/{+path}","compare_url":"https://api.github.com/repos/reactos/reactos/compare/{base}...{head}","merges_url":"https://api.github.com/repos/reactos/reactos/merges","archive_url":"https://api.github.com/repos/reactos/reactos/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/reactos/reactos/downloads","issues_url":"https://api.github.com/repos/reactos/reactos/issues{/number}","pulls_url":"https://api.github.com/repos/reactos/reactos/pulls{/number}","milestones_url":"https://api.github.com/repos/reactos/reactos/milestones{/number}","notifications_url":"https://api.github.com/repos/reactos/reactos/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/reactos/reactos/labels{/name}","releases_url":"https://api.github.com/repos/reactos/reactos/releases{/id}","deployments_url":"https://api.github.com/repos/reactos/reactos/deployments","created_at":"2017-10-03T08:04:52Z","updated_at":"2018-12-09T13:08:03Z","pushed_at":"2018-12-09T14:08:25Z","git_url":"git://github.com/reactos/reactos.git","ssh_url":"git@github.com:reactos/reactos.git","clone_url":"https://github.com/reactos/reactos.git","svn_url":"https://github.com/reactos/reactos","homepage":null,"size":464813,"stargazers_count":5606,"watchers_count":5606,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":494,"mirror_url":null,"archived":false,"open_issues_count":82,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":494,"open_issues":82,"watchers":5606,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/reactos/reactos/pulls/1105"},"html":{"href":"https://github.com/reactos/reactos/pull/1105"},"issue":{"href":"https://api.github.com/repos/reactos/reactos/issues/1105"},"comments":{"href":"https://api.github.com/repos/reactos/reactos/issues/1105/comments"},"review_comments":{"href":"https://api.github.com/repos/reactos/reactos/pulls/1105/comments"},"review_comment":{"href":"https://api.github.com/repos/reactos/reactos/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/reactos/reactos/pulls/1105/commits"},"statuses":{"href":"https://api.github.com/repos/reactos/reactos/statuses/8bcea982e39f827c0b6ca8825f31384bc6174502"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"HBelusca"}}