{"action":"created","issue":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues/3196","repository_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java","labels_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues/3196/labels{/name}","comments_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues/3196/comments","events_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues/3196/events","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-java/pull/3196","id":318120309,"number":3196,"title":"[Storage] KMS integration","user":{"login":"frankyn","id":1907648,"avatar_url":"https://avatars1.githubusercontent.com/u/1907648?v=4","gravatar_id":"","url":"https://api.github.com/users/frankyn","html_url":"https://github.com/frankyn","followers_url":"https://api.github.com/users/frankyn/followers","following_url":"https://api.github.com/users/frankyn/following{/other_user}","gists_url":"https://api.github.com/users/frankyn/gists{/gist_id}","starred_url":"https://api.github.com/users/frankyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frankyn/subscriptions","organizations_url":"https://api.github.com/users/frankyn/orgs","repos_url":"https://api.github.com/users/frankyn/repos","events_url":"https://api.github.com/users/frankyn/events{/privacy}","received_events_url":"https://api.github.com/users/frankyn/received_events","type":"User","site_admin":false},"labels":[{"id":175662188,"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/labels/cla:%20yes","name":"cla: yes","color":"c2e0c6","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-04-26T17:09:27Z","updated_at":"2018-05-16T21:18:17Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/pulls/3196","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-java/pull/3196","diff_url":"https://github.com/GoogleCloudPlatform/google-cloud-java/pull/3196.diff","patch_url":"https://github.com/GoogleCloudPlatform/google-cloud-java/pull/3196.patch"},"body":"Original author: @rossjudson\r\ncc: @danoscarmike @rossjudson\r\n\r\nGeneral pending actions:\r\n- [x] Define KMS keyring for integration tests\r\n- [x] Allow configuration of default_kms_key_name in bucket\r\n- [x] Allow specification of kms_key_name on object insert\r\n- [x] Allow specification of kms_key_name on object rewrite\r\n- [x] **Test**: Ensure kms_key_name is visible in object listings.\r\n- [x] **Test**: Insert an object with a Cloud KMS key then fetch the object and verify contents and metadata (should include kms_key_name).\r\n- [x] **Test**: Create a bucket with a default Cloud KMS key, insert an object, then fetch the object and verify its contents and metadata (should include kms_key_name).\r\n- [x] **Test**: Update the default_kms_key_name of a bucket to a different key name.\r\n- [x] **Test**: Update the bucket to remove default_kms_key_name encryption.\r\n- [x] **Test**: Migrate CSEK to Cloud KMS key, download object and verify contents are decrypted.\r\n- [x] **Test**: Test defaultKMSKeyName can be selected using `BucketField.ENCRYPTION`.\r\n- [x] **Test**: Test kmsKeyName can be selected using `BlobField.KMS_KEY_NAME`.\r\n- [x] **Test**: Write unit tests for BlobWriteOption and BlobTargetOption.\r\n- [x] Nit: Remove Alpha and Beta annotations for GA features (Bucket level IAM and Requester Pays).\r\n- [x] Add Beta annotations to KMS integration methods.\r\n- [ ] Code Review "},"comment":{"url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues/comments/389668961","html_url":"https://github.com/GoogleCloudPlatform/google-cloud-java/pull/3196#issuecomment-389668961","issue_url":"https://api.github.com/repos/GoogleCloudPlatform/google-cloud-java/issues/3196","id":389668961,"user":{"login":"pongad","id":1617025,"avatar_url":"https://avatars1.githubusercontent.com/u/1617025?v=4","gravatar_id":"","url":"https://api.github.com/users/pongad","html_url":"https://github.com/pongad","followers_url":"https://api.github.com/users/pongad/followers","following_url":"https://api.github.com/users/pongad/following{/other_user}","gists_url":"https://api.github.com/users/pongad/gists{/gist_id}","starred_url":"https://api.github.com/users/pongad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pongad/subscriptions","organizations_url":"https://api.github.com/users/pongad/orgs","repos_url":"https://api.github.com/users/pongad/repos","events_url":"https://api.github.com/users/pongad/events{/privacy}","received_events_url":"https://api.github.com/users/pongad/received_events","type":"User","site_admin":false},"created_at":"2018-05-16T21:18:17Z","updated_at":"2018-05-16T21:18:17Z","author_association":"CONTRIBUTOR","body":"Oh dear I'm sorry I dropped the ball on this. We moved a bunch of files. Could you merge from master?\r\n\r\nThere are some lint warnings that are worth fixing, but I'm fine fixing those in a separate PR."}}
{"actor":{"display_login":"pongad"}}