{"action":"closed","number":2,"pull_request":{"url":"https://api.github.com/repos/ned14/status-code/pulls/2","id":208007354,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MDA3MzU0","html_url":"https://github.com/ned14/status-code/pull/2","diff_url":"https://github.com/ned14/status-code/pull/2.diff","patch_url":"https://github.com/ned14/status-code/pull/2.patch","issue_url":"https://api.github.com/repos/ned14/status-code/issues/2","number":2,"state":"closed","locked":false,"title":"atomic_refcounted_string_ref bug fixes  & improvements","user":{"login":"jwtowner","id":3145125,"node_id":"MDQ6VXNlcjMxNDUxMjU=","avatar_url":"https://avatars3.githubusercontent.com/u/3145125?v=4","gravatar_id":"","url":"https://api.github.com/users/jwtowner","html_url":"https://github.com/jwtowner","followers_url":"https://api.github.com/users/jwtowner/followers","following_url":"https://api.github.com/users/jwtowner/following{/other_user}","gists_url":"https://api.github.com/users/jwtowner/gists{/gist_id}","starred_url":"https://api.github.com/users/jwtowner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwtowner/subscriptions","organizations_url":"https://api.github.com/users/jwtowner/orgs","repos_url":"https://api.github.com/users/jwtowner/repos","events_url":"https://api.github.com/users/jwtowner/events{/privacy}","received_events_url":"https://api.github.com/users/jwtowner/received_events","type":"User","site_admin":false},"body":"This PR includes the following bug fixes and improvements:\r\n\r\n- pass in _refcounted_string_thunk to string_ref base class constructor, otherwise it incorrectly uses the default _checking_string_thunk\r\n- use nothrow operator new instead of calloc to allocate shared count, in part to fix mismatch with operator delete and also for compatibility with debug or locking based atomic implementations that require the atomic object to be properly constructed before use\r\n- optimization: use acquire-release fence for shared count, with deferred acquire fence on final release ( see https://www.boost.org/doc/libs/1_67_0/doc/html/atomic/usage_examples.html#boost_atomic.usage_examples.example_reference_counters )\r\n- optimization: implement move operation with actual move semantics in _refcounted_string_thunk","created_at":"2018-08-13T15:01:59Z","updated_at":"2018-08-21T19:26:01Z","closed_at":"2018-08-21T19:26:01Z","merged_at":"2018-08-21T19:26:01Z","merge_commit_sha":"9be62a772268e0f5d1c8bbdc39219850aa6bcc10","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ned14/status-code/pulls/2/commits","review_comments_url":"https://api.github.com/repos/ned14/status-code/pulls/2/comments","review_comment_url":"https://api.github.com/repos/ned14/status-code/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ned14/status-code/issues/2/comments","statuses_url":"https://api.github.com/repos/ned14/status-code/statuses/9be62a772268e0f5d1c8bbdc39219850aa6bcc10","head":{"label":"jwtowner:devel","ref":"devel","sha":"9be62a772268e0f5d1c8bbdc39219850aa6bcc10","user":{"login":"jwtowner","id":3145125,"node_id":"MDQ6VXNlcjMxNDUxMjU=","avatar_url":"https://avatars3.githubusercontent.com/u/3145125?v=4","gravatar_id":"","url":"https://api.github.com/users/jwtowner","html_url":"https://github.com/jwtowner","followers_url":"https://api.github.com/users/jwtowner/followers","following_url":"https://api.github.com/users/jwtowner/following{/other_user}","gists_url":"https://api.github.com/users/jwtowner/gists{/gist_id}","starred_url":"https://api.github.com/users/jwtowner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwtowner/subscriptions","organizations_url":"https://api.github.com/users/jwtowner/orgs","repos_url":"https://api.github.com/users/jwtowner/repos","events_url":"https://api.github.com/users/jwtowner/events{/privacy}","received_events_url":"https://api.github.com/users/jwtowner/received_events","type":"User","site_admin":false},"repo":{"id":137703158,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc3MDMxNTg=","name":"status-code","full_name":"jwtowner/status-code","owner":{"login":"jwtowner","id":3145125,"node_id":"MDQ6VXNlcjMxNDUxMjU=","avatar_url":"https://avatars3.githubusercontent.com/u/3145125?v=4","gravatar_id":"","url":"https://api.github.com/users/jwtowner","html_url":"https://github.com/jwtowner","followers_url":"https://api.github.com/users/jwtowner/followers","following_url":"https://api.github.com/users/jwtowner/following{/other_user}","gists_url":"https://api.github.com/users/jwtowner/gists{/gist_id}","starred_url":"https://api.github.com/users/jwtowner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwtowner/subscriptions","organizations_url":"https://api.github.com/users/jwtowner/orgs","repos_url":"https://api.github.com/users/jwtowner/repos","events_url":"https://api.github.com/users/jwtowner/events{/privacy}","received_events_url":"https://api.github.com/users/jwtowner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jwtowner/status-code","description":"Proposed SG14 status_code for the C++ standard","fork":true,"url":"https://api.github.com/repos/jwtowner/status-code","forks_url":"https://api.github.com/repos/jwtowner/status-code/forks","keys_url":"https://api.github.com/repos/jwtowner/status-code/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jwtowner/status-code/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jwtowner/status-code/teams","hooks_url":"https://api.github.com/repos/jwtowner/status-code/hooks","issue_events_url":"https://api.github.com/repos/jwtowner/status-code/issues/events{/number}","events_url":"https://api.github.com/repos/jwtowner/status-code/events","assignees_url":"https://api.github.com/repos/jwtowner/status-code/assignees{/user}","branches_url":"https://api.github.com/repos/jwtowner/status-code/branches{/branch}","tags_url":"https://api.github.com/repos/jwtowner/status-code/tags","blobs_url":"https://api.github.com/repos/jwtowner/status-code/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jwtowner/status-code/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jwtowner/status-code/git/refs{/sha}","trees_url":"https://api.github.com/repos/jwtowner/status-code/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jwtowner/status-code/statuses/{sha}","languages_url":"https://api.github.com/repos/jwtowner/status-code/languages","stargazers_url":"https://api.github.com/repos/jwtowner/status-code/stargazers","contributors_url":"https://api.github.com/repos/jwtowner/status-code/contributors","subscribers_url":"https://api.github.com/repos/jwtowner/status-code/subscribers","subscription_url":"https://api.github.com/repos/jwtowner/status-code/subscription","commits_url":"https://api.github.com/repos/jwtowner/status-code/commits{/sha}","git_commits_url":"https://api.github.com/repos/jwtowner/status-code/git/commits{/sha}","comments_url":"https://api.github.com/repos/jwtowner/status-code/comments{/number}","issue_comment_url":"https://api.github.com/repos/jwtowner/status-code/issues/comments{/number}","contents_url":"https://api.github.com/repos/jwtowner/status-code/contents/{+path}","compare_url":"https://api.github.com/repos/jwtowner/status-code/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jwtowner/status-code/merges","archive_url":"https://api.github.com/repos/jwtowner/status-code/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jwtowner/status-code/downloads","issues_url":"https://api.github.com/repos/jwtowner/status-code/issues{/number}","pulls_url":"https://api.github.com/repos/jwtowner/status-code/pulls{/number}","milestones_url":"https://api.github.com/repos/jwtowner/status-code/milestones{/number}","notifications_url":"https://api.github.com/repos/jwtowner/status-code/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jwtowner/status-code/labels{/name}","releases_url":"https://api.github.com/repos/jwtowner/status-code/releases{/id}","deployments_url":"https://api.github.com/repos/jwtowner/status-code/deployments","created_at":"2018-06-18T02:33:59Z","updated_at":"2018-08-13T12:19:05Z","pushed_at":"2018-08-15T06:35:39Z","git_url":"git://github.com/jwtowner/status-code.git","ssh_url":"git@github.com:jwtowner/status-code.git","clone_url":"https://github.com/jwtowner/status-code.git","svn_url":"https://github.com/jwtowner/status-code","homepage":null,"size":295,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ned14:master","ref":"master","sha":"b60373f76972bbd1b2ae17210a60f286deae9503","user":{"login":"ned14","id":230408,"node_id":"MDQ6VXNlcjIzMDQwOA==","avatar_url":"https://avatars1.githubusercontent.com/u/230408?v=4","gravatar_id":"","url":"https://api.github.com/users/ned14","html_url":"https://github.com/ned14","followers_url":"https://api.github.com/users/ned14/followers","following_url":"https://api.github.com/users/ned14/following{/other_user}","gists_url":"https://api.github.com/users/ned14/gists{/gist_id}","starred_url":"https://api.github.com/users/ned14/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ned14/subscriptions","organizations_url":"https://api.github.com/users/ned14/orgs","repos_url":"https://api.github.com/users/ned14/repos","events_url":"https://api.github.com/users/ned14/events{/privacy}","received_events_url":"https://api.github.com/users/ned14/received_events","type":"User","site_admin":false},"repo":{"id":121296767,"node_id":"MDEwOlJlcG9zaXRvcnkxMjEyOTY3Njc=","name":"status-code","full_name":"ned14/status-code","owner":{"login":"ned14","id":230408,"node_id":"MDQ6VXNlcjIzMDQwOA==","avatar_url":"https://avatars1.githubusercontent.com/u/230408?v=4","gravatar_id":"","url":"https://api.github.com/users/ned14","html_url":"https://github.com/ned14","followers_url":"https://api.github.com/users/ned14/followers","following_url":"https://api.github.com/users/ned14/following{/other_user}","gists_url":"https://api.github.com/users/ned14/gists{/gist_id}","starred_url":"https://api.github.com/users/ned14/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ned14/subscriptions","organizations_url":"https://api.github.com/users/ned14/orgs","repos_url":"https://api.github.com/users/ned14/repos","events_url":"https://api.github.com/users/ned14/events{/privacy}","received_events_url":"https://api.github.com/users/ned14/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ned14/status-code","description":"Proposed SG14 status_code for the C++ standard","fork":false,"url":"https://api.github.com/repos/ned14/status-code","forks_url":"https://api.github.com/repos/ned14/status-code/forks","keys_url":"https://api.github.com/repos/ned14/status-code/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ned14/status-code/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ned14/status-code/teams","hooks_url":"https://api.github.com/repos/ned14/status-code/hooks","issue_events_url":"https://api.github.com/repos/ned14/status-code/issues/events{/number}","events_url":"https://api.github.com/repos/ned14/status-code/events","assignees_url":"https://api.github.com/repos/ned14/status-code/assignees{/user}","branches_url":"https://api.github.com/repos/ned14/status-code/branches{/branch}","tags_url":"https://api.github.com/repos/ned14/status-code/tags","blobs_url":"https://api.github.com/repos/ned14/status-code/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ned14/status-code/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ned14/status-code/git/refs{/sha}","trees_url":"https://api.github.com/repos/ned14/status-code/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ned14/status-code/statuses/{sha}","languages_url":"https://api.github.com/repos/ned14/status-code/languages","stargazers_url":"https://api.github.com/repos/ned14/status-code/stargazers","contributors_url":"https://api.github.com/repos/ned14/status-code/contributors","subscribers_url":"https://api.github.com/repos/ned14/status-code/subscribers","subscription_url":"https://api.github.com/repos/ned14/status-code/subscription","commits_url":"https://api.github.com/repos/ned14/status-code/commits{/sha}","git_commits_url":"https://api.github.com/repos/ned14/status-code/git/commits{/sha}","comments_url":"https://api.github.com/repos/ned14/status-code/comments{/number}","issue_comment_url":"https://api.github.com/repos/ned14/status-code/issues/comments{/number}","contents_url":"https://api.github.com/repos/ned14/status-code/contents/{+path}","compare_url":"https://api.github.com/repos/ned14/status-code/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ned14/status-code/merges","archive_url":"https://api.github.com/repos/ned14/status-code/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ned14/status-code/downloads","issues_url":"https://api.github.com/repos/ned14/status-code/issues{/number}","pulls_url":"https://api.github.com/repos/ned14/status-code/pulls{/number}","milestones_url":"https://api.github.com/repos/ned14/status-code/milestones{/number}","notifications_url":"https://api.github.com/repos/ned14/status-code/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ned14/status-code/labels{/name}","releases_url":"https://api.github.com/repos/ned14/status-code/releases{/id}","deployments_url":"https://api.github.com/repos/ned14/status-code/deployments","created_at":"2018-02-12T20:17:37Z","updated_at":"2018-08-15T20:06:24Z","pushed_at":"2018-08-21T19:26:01Z","git_url":"git://github.com/ned14/status-code.git","ssh_url":"git@github.com:ned14/status-code.git","clone_url":"https://github.com/ned14/status-code.git","svn_url":"https://github.com/ned14/status-code","homepage":null,"size":290,"stargazers_count":8,"watchers_count":8,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":1,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ned14/status-code/pulls/2"},"html":{"href":"https://github.com/ned14/status-code/pull/2"},"issue":{"href":"https://api.github.com/repos/ned14/status-code/issues/2"},"comments":{"href":"https://api.github.com/repos/ned14/status-code/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/ned14/status-code/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/ned14/status-code/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ned14/status-code/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/ned14/status-code/statuses/9be62a772268e0f5d1c8bbdc39219850aa6bcc10"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ned14","id":230408,"node_id":"MDQ6VXNlcjIzMDQwOA==","avatar_url":"https://avatars1.githubusercontent.com/u/230408?v=4","gravatar_id":"","url":"https://api.github.com/users/ned14","html_url":"https://github.com/ned14","followers_url":"https://api.github.com/users/ned14/followers","following_url":"https://api.github.com/users/ned14/following{/other_user}","gists_url":"https://api.github.com/users/ned14/gists{/gist_id}","starred_url":"https://api.github.com/users/ned14/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ned14/subscriptions","organizations_url":"https://api.github.com/users/ned14/orgs","repos_url":"https://api.github.com/users/ned14/repos","events_url":"https://api.github.com/users/ned14/events{/privacy}","received_events_url":"https://api.github.com/users/ned14/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":44,"deletions":12,"changed_files":2}}
{"actor":{"display_login":"ned14"}}