{"action":"created","comment":{"url":"https://api.github.com/repos/ros/robot_state_publisher/pulls/comments/170972334","pull_request_review_id":99739822,"id":170972334,"diff_hunk":"@@ -37,9 +37,10 @@\n #ifndef ROBOT_STATE_PUBLISHER_H\n #define ROBOT_STATE_PUBLISHER_H\n \n+#include <map>\n+#include <string>\n+\n #include <ros/ros.h>\n-#include <boost/scoped_ptr.hpp>\n-#include <tf/tf.h>","path":"include/robot_state_publisher/robot_state_publisher.h","position":9,"original_position":9,"commit_id":"81bd692ef7518dd1eb79d229b98df87ec6fcdf26","original_commit_id":"81bd692ef7518dd1eb79d229b98df87ec6fcdf26","user":{"login":"sloretz","id":4175662,"avatar_url":"https://avatars1.githubusercontent.com/u/4175662?v=4","gravatar_id":"","url":"https://api.github.com/users/sloretz","html_url":"https://github.com/sloretz","followers_url":"https://api.github.com/users/sloretz/followers","following_url":"https://api.github.com/users/sloretz/following{/other_user}","gists_url":"https://api.github.com/users/sloretz/gists{/gist_id}","starred_url":"https://api.github.com/users/sloretz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sloretz/subscriptions","organizations_url":"https://api.github.com/users/sloretz/orgs","repos_url":"https://api.github.com/users/sloretz/repos","events_url":"https://api.github.com/users/sloretz/events{/privacy}","received_events_url":"https://api.github.com/users/sloretz/received_events","type":"User","site_admin":false},"body":"Removing `<tf/tf.h>` in #82 on `melodic-devel` required ros-naoqi/naoqi_driver#103 . Maybe it should be left in place to avoid breaking source builds of other kinetic/lunar packages?","created_at":"2018-02-27T16:01:28Z","updated_at":"2018-02-27T16:13:11Z","html_url":"https://github.com/ros/robot_state_publisher/pull/87#discussion_r170972334","pull_request_url":"https://api.github.com/repos/ros/robot_state_publisher/pulls/87","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ros/robot_state_publisher/pulls/comments/170972334"},"html":{"href":"https://github.com/ros/robot_state_publisher/pull/87#discussion_r170972334"},"pull_request":{"href":"https://api.github.com/repos/ros/robot_state_publisher/pulls/87"}}},"pull_request":{"url":"https://api.github.com/repos/ros/robot_state_publisher/pulls/87","id":171469456,"html_url":"https://github.com/ros/robot_state_publisher/pull/87","diff_url":"https://github.com/ros/robot_state_publisher/pull/87.diff","patch_url":"https://github.com/ros/robot_state_publisher/pull/87.patch","issue_url":"https://api.github.com/repos/ros/robot_state_publisher/issues/87","number":87,"state":"open","locked":false,"title":"Add in a public default constructor","user":{"login":"clalancette","id":163000,"avatar_url":"https://avatars0.githubusercontent.com/u/163000?v=4","gravatar_id":"","url":"https://api.github.com/users/clalancette","html_url":"https://github.com/clalancette","followers_url":"https://api.github.com/users/clalancette/followers","following_url":"https://api.github.com/users/clalancette/following{/other_user}","gists_url":"https://api.github.com/users/clalancette/gists{/gist_id}","starred_url":"https://api.github.com/users/clalancette/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clalancette/subscriptions","organizations_url":"https://api.github.com/users/clalancette/orgs","repos_url":"https://api.github.com/users/clalancette/repos","events_url":"https://api.github.com/users/clalancette/events{/privacy}","received_events_url":"https://api.github.com/users/clalancette/received_events","type":"User","site_admin":false},"body":"This should fix #23, and obsoletes #43 .  This PR does a number of things:\r\n\r\n1.  It pushes the remaining TF dependency as deeply as possible.  To completely get rid of TF would mean we would have to get rid of the `tf_prefix` functionality.\r\n1.  It moves the include of `boost::shared_ptr` over to the one place it is needed.  We basically can't get rid of this use of boost, since it is what is returned in the callback.\r\n1.  It does some cleanup of namespaces.\r\n1.  It switches the package to package format 2.\r\n1.  It removes the deprecated name of `robot_state_publisher` (`state_publisher`).  That's been deprecated since a commit in 2012, so it is probably safe to remove.\r\n1.  It splits the `main` out from the `joint_state_listener.cpp` file and into its own file.  This makes it so that `JointStateListener` could be used as a library on its own now.\r\n1.  It adds in public default constructors for both `RobotStatePublisher` and `JointStateListener`.\r\n\r\nIt is easiest to review this PR on a commit-by-commit basis, since the individual commits all make sense.  Let me know if you'd prefer me to split this up into separate PRs.","created_at":"2018-02-26T19:31:25Z","updated_at":"2018-02-27T16:13:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4bfb92b6a3f9cda76850680094c34a4644a5615f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ros/robot_state_publisher/pulls/87/commits","review_comments_url":"https://api.github.com/repos/ros/robot_state_publisher/pulls/87/comments","review_comment_url":"https://api.github.com/repos/ros/robot_state_publisher/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ros/robot_state_publisher/issues/87/comments","statuses_url":"https://api.github.com/repos/ros/robot_state_publisher/statuses/81bd692ef7518dd1eb79d229b98df87ec6fcdf26","head":{"label":"ros:pub-def-constructor","ref":"pub-def-constructor","sha":"81bd692ef7518dd1eb79d229b98df87ec6fcdf26","user":{"login":"ros","id":547448,"avatar_url":"https://avatars2.githubusercontent.com/u/547448?v=4","gravatar_id":"","url":"https://api.github.com/users/ros","html_url":"https://github.com/ros","followers_url":"https://api.github.com/users/ros/followers","following_url":"https://api.github.com/users/ros/following{/other_user}","gists_url":"https://api.github.com/users/ros/gists{/gist_id}","starred_url":"https://api.github.com/users/ros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros/subscriptions","organizations_url":"https://api.github.com/users/ros/orgs","repos_url":"https://api.github.com/users/ros/repos","events_url":"https://api.github.com/users/ros/events{/privacy}","received_events_url":"https://api.github.com/users/ros/received_events","type":"Organization","site_admin":false},"repo":{"id":7792592,"name":"robot_state_publisher","full_name":"ros/robot_state_publisher","owner":{"login":"ros","id":547448,"avatar_url":"https://avatars2.githubusercontent.com/u/547448?v=4","gravatar_id":"","url":"https://api.github.com/users/ros","html_url":"https://github.com/ros","followers_url":"https://api.github.com/users/ros/followers","following_url":"https://api.github.com/users/ros/following{/other_user}","gists_url":"https://api.github.com/users/ros/gists{/gist_id}","starred_url":"https://api.github.com/users/ros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros/subscriptions","organizations_url":"https://api.github.com/users/ros/orgs","repos_url":"https://api.github.com/users/ros/repos","events_url":"https://api.github.com/users/ros/events{/privacy}","received_events_url":"https://api.github.com/users/ros/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros/robot_state_publisher","description":"Allows you to publish the state of a robot (i.e the position of its base and all joints) via the \"tf\" transform library","fork":false,"url":"https://api.github.com/repos/ros/robot_state_publisher","forks_url":"https://api.github.com/repos/ros/robot_state_publisher/forks","keys_url":"https://api.github.com/repos/ros/robot_state_publisher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros/robot_state_publisher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros/robot_state_publisher/teams","hooks_url":"https://api.github.com/repos/ros/robot_state_publisher/hooks","issue_events_url":"https://api.github.com/repos/ros/robot_state_publisher/issues/events{/number}","events_url":"https://api.github.com/repos/ros/robot_state_publisher/events","assignees_url":"https://api.github.com/repos/ros/robot_state_publisher/assignees{/user}","branches_url":"https://api.github.com/repos/ros/robot_state_publisher/branches{/branch}","tags_url":"https://api.github.com/repos/ros/robot_state_publisher/tags","blobs_url":"https://api.github.com/repos/ros/robot_state_publisher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros/robot_state_publisher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros/robot_state_publisher/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros/robot_state_publisher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros/robot_state_publisher/statuses/{sha}","languages_url":"https://api.github.com/repos/ros/robot_state_publisher/languages","stargazers_url":"https://api.github.com/repos/ros/robot_state_publisher/stargazers","contributors_url":"https://api.github.com/repos/ros/robot_state_publisher/contributors","subscribers_url":"https://api.github.com/repos/ros/robot_state_publisher/subscribers","subscription_url":"https://api.github.com/repos/ros/robot_state_publisher/subscription","commits_url":"https://api.github.com/repos/ros/robot_state_publisher/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros/robot_state_publisher/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros/robot_state_publisher/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros/robot_state_publisher/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros/robot_state_publisher/contents/{+path}","compare_url":"https://api.github.com/repos/ros/robot_state_publisher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros/robot_state_publisher/merges","archive_url":"https://api.github.com/repos/ros/robot_state_publisher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros/robot_state_publisher/downloads","issues_url":"https://api.github.com/repos/ros/robot_state_publisher/issues{/number}","pulls_url":"https://api.github.com/repos/ros/robot_state_publisher/pulls{/number}","milestones_url":"https://api.github.com/repos/ros/robot_state_publisher/milestones{/number}","notifications_url":"https://api.github.com/repos/ros/robot_state_publisher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros/robot_state_publisher/labels{/name}","releases_url":"https://api.github.com/repos/ros/robot_state_publisher/releases{/id}","deployments_url":"https://api.github.com/repos/ros/robot_state_publisher/deployments","created_at":"2013-01-24T06:57:20Z","updated_at":"2017-02-15T17:29:23Z","pushed_at":"2018-02-26T20:02:53Z","git_url":"git://github.com/ros/robot_state_publisher.git","ssh_url":"git@github.com:ros/robot_state_publisher.git","clone_url":"https://github.com/ros/robot_state_publisher.git","svn_url":"https://github.com/ros/robot_state_publisher","homepage":"http://www.ros.org/wiki/robot_state_publisher","size":152,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":58,"mirror_url":null,"archived":false,"open_issues_count":10,"license":null,"forks":58,"open_issues":10,"watchers":5,"default_branch":"kinetic-devel"}},"base":{"label":"ros:kinetic-devel","ref":"kinetic-devel","sha":"658ab348cafd3a4b09f1d36fa3cd3cea89fa7a11","user":{"login":"ros","id":547448,"avatar_url":"https://avatars2.githubusercontent.com/u/547448?v=4","gravatar_id":"","url":"https://api.github.com/users/ros","html_url":"https://github.com/ros","followers_url":"https://api.github.com/users/ros/followers","following_url":"https://api.github.com/users/ros/following{/other_user}","gists_url":"https://api.github.com/users/ros/gists{/gist_id}","starred_url":"https://api.github.com/users/ros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros/subscriptions","organizations_url":"https://api.github.com/users/ros/orgs","repos_url":"https://api.github.com/users/ros/repos","events_url":"https://api.github.com/users/ros/events{/privacy}","received_events_url":"https://api.github.com/users/ros/received_events","type":"Organization","site_admin":false},"repo":{"id":7792592,"name":"robot_state_publisher","full_name":"ros/robot_state_publisher","owner":{"login":"ros","id":547448,"avatar_url":"https://avatars2.githubusercontent.com/u/547448?v=4","gravatar_id":"","url":"https://api.github.com/users/ros","html_url":"https://github.com/ros","followers_url":"https://api.github.com/users/ros/followers","following_url":"https://api.github.com/users/ros/following{/other_user}","gists_url":"https://api.github.com/users/ros/gists{/gist_id}","starred_url":"https://api.github.com/users/ros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ros/subscriptions","organizations_url":"https://api.github.com/users/ros/orgs","repos_url":"https://api.github.com/users/ros/repos","events_url":"https://api.github.com/users/ros/events{/privacy}","received_events_url":"https://api.github.com/users/ros/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ros/robot_state_publisher","description":"Allows you to publish the state of a robot (i.e the position of its base and all joints) via the \"tf\" transform library","fork":false,"url":"https://api.github.com/repos/ros/robot_state_publisher","forks_url":"https://api.github.com/repos/ros/robot_state_publisher/forks","keys_url":"https://api.github.com/repos/ros/robot_state_publisher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ros/robot_state_publisher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ros/robot_state_publisher/teams","hooks_url":"https://api.github.com/repos/ros/robot_state_publisher/hooks","issue_events_url":"https://api.github.com/repos/ros/robot_state_publisher/issues/events{/number}","events_url":"https://api.github.com/repos/ros/robot_state_publisher/events","assignees_url":"https://api.github.com/repos/ros/robot_state_publisher/assignees{/user}","branches_url":"https://api.github.com/repos/ros/robot_state_publisher/branches{/branch}","tags_url":"https://api.github.com/repos/ros/robot_state_publisher/tags","blobs_url":"https://api.github.com/repos/ros/robot_state_publisher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ros/robot_state_publisher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ros/robot_state_publisher/git/refs{/sha}","trees_url":"https://api.github.com/repos/ros/robot_state_publisher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ros/robot_state_publisher/statuses/{sha}","languages_url":"https://api.github.com/repos/ros/robot_state_publisher/languages","stargazers_url":"https://api.github.com/repos/ros/robot_state_publisher/stargazers","contributors_url":"https://api.github.com/repos/ros/robot_state_publisher/contributors","subscribers_url":"https://api.github.com/repos/ros/robot_state_publisher/subscribers","subscription_url":"https://api.github.com/repos/ros/robot_state_publisher/subscription","commits_url":"https://api.github.com/repos/ros/robot_state_publisher/commits{/sha}","git_commits_url":"https://api.github.com/repos/ros/robot_state_publisher/git/commits{/sha}","comments_url":"https://api.github.com/repos/ros/robot_state_publisher/comments{/number}","issue_comment_url":"https://api.github.com/repos/ros/robot_state_publisher/issues/comments{/number}","contents_url":"https://api.github.com/repos/ros/robot_state_publisher/contents/{+path}","compare_url":"https://api.github.com/repos/ros/robot_state_publisher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ros/robot_state_publisher/merges","archive_url":"https://api.github.com/repos/ros/robot_state_publisher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ros/robot_state_publisher/downloads","issues_url":"https://api.github.com/repos/ros/robot_state_publisher/issues{/number}","pulls_url":"https://api.github.com/repos/ros/robot_state_publisher/pulls{/number}","milestones_url":"https://api.github.com/repos/ros/robot_state_publisher/milestones{/number}","notifications_url":"https://api.github.com/repos/ros/robot_state_publisher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ros/robot_state_publisher/labels{/name}","releases_url":"https://api.github.com/repos/ros/robot_state_publisher/releases{/id}","deployments_url":"https://api.github.com/repos/ros/robot_state_publisher/deployments","created_at":"2013-01-24T06:57:20Z","updated_at":"2017-02-15T17:29:23Z","pushed_at":"2018-02-26T20:02:53Z","git_url":"git://github.com/ros/robot_state_publisher.git","ssh_url":"git@github.com:ros/robot_state_publisher.git","clone_url":"https://github.com/ros/robot_state_publisher.git","svn_url":"https://github.com/ros/robot_state_publisher","homepage":"http://www.ros.org/wiki/robot_state_publisher","size":152,"stargazers_count":5,"watchers_count":5,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":58,"mirror_url":null,"archived":false,"open_issues_count":10,"license":null,"forks":58,"open_issues":10,"watchers":5,"default_branch":"kinetic-devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ros/robot_state_publisher/pulls/87"},"html":{"href":"https://github.com/ros/robot_state_publisher/pull/87"},"issue":{"href":"https://api.github.com/repos/ros/robot_state_publisher/issues/87"},"comments":{"href":"https://api.github.com/repos/ros/robot_state_publisher/issues/87/comments"},"review_comments":{"href":"https://api.github.com/repos/ros/robot_state_publisher/pulls/87/comments"},"review_comment":{"href":"https://api.github.com/repos/ros/robot_state_publisher/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ros/robot_state_publisher/pulls/87/commits"},"statuses":{"href":"https://api.github.com/repos/ros/robot_state_publisher/statuses/81bd692ef7518dd1eb79d229b98df87ec6fcdf26"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sloretz"}}