{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/clrmd/pulls/comments/243566321","pull_request_review_id":187373059,"id":243566321,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzU2NjMyMQ==","diff_hunk":"@@ -33,21 +32,15 @@ internal ClrInfo(DataTarget dt, ClrFlavor flavor, ModuleInfo module, DacInfo dac\n         /// </summary>\n         public ClrFlavor Flavor { get; }\n \n-        /// <summary>\n-        /// Returns module information about the Dac needed create a ClrRuntime instance for this runtime.\n-        /// </summary>\n-        public DacInfo DacInfo { get; }","path":"src/Microsoft.Diagnostics.Runtime/src/DataTargets/ClrInfo.cs","position":30,"original_position":30,"commit_id":"ce9d6b8de1f45db0f6569c3a7437b44a8f79b130","original_commit_id":"ce9d6b8de1f45db0f6569c3a7437b44a8f79b130","user":{"login":"isakiev","id":4499455,"node_id":"MDQ6VXNlcjQ0OTk0NTU=","avatar_url":"https://avatars3.githubusercontent.com/u/4499455?v=4","gravatar_id":"","url":"https://api.github.com/users/isakiev","html_url":"https://github.com/isakiev","followers_url":"https://api.github.com/users/isakiev/followers","following_url":"https://api.github.com/users/isakiev/following{/other_user}","gists_url":"https://api.github.com/users/isakiev/gists{/gist_id}","starred_url":"https://api.github.com/users/isakiev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isakiev/subscriptions","organizations_url":"https://api.github.com/users/isakiev/orgs","repos_url":"https://api.github.com/users/isakiev/repos","events_url":"https://api.github.com/users/isakiev/events{/privacy}","received_events_url":"https://api.github.com/users/isakiev/received_events","type":"User","site_admin":false},"body":"thanks for the details, it was intended to inline DacInfo into ClrInfo, but I'll restore this as requested","created_at":"2018-12-21T12:15:34Z","updated_at":"2018-12-21T12:15:34Z","html_url":"https://github.com/Microsoft/clrmd/pull/182#discussion_r243566321","pull_request_url":"https://api.github.com/repos/Microsoft/clrmd/pulls/182","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/clrmd/pulls/comments/243566321"},"html":{"href":"https://github.com/Microsoft/clrmd/pull/182#discussion_r243566321"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/clrmd/pulls/182"}},"in_reply_to_id":242223136},"pull_request":{"url":"https://api.github.com/repos/Microsoft/clrmd/pulls/182","id":238756833,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4NzU2ODMz","html_url":"https://github.com/Microsoft/clrmd/pull/182","diff_url":"https://github.com/Microsoft/clrmd/pull/182.diff","patch_url":"https://github.com/Microsoft/clrmd/pull/182.patch","issue_url":"https://api.github.com/repos/Microsoft/clrmd/issues/182","number":182,"state":"open","locked":false,"title":"simplify dac location logic","user":{"login":"isakiev","id":4499455,"node_id":"MDQ6VXNlcjQ0OTk0NTU=","avatar_url":"https://avatars3.githubusercontent.com/u/4499455?v=4","gravatar_id":"","url":"https://api.github.com/users/isakiev","html_url":"https://github.com/isakiev","followers_url":"https://api.github.com/users/isakiev/followers","following_url":"https://api.github.com/users/isakiev/following{/other_user}","gists_url":"https://api.github.com/users/isakiev/gists{/gist_id}","starred_url":"https://api.github.com/users/isakiev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isakiev/subscriptions","organizations_url":"https://api.github.com/users/isakiev/orgs","repos_url":"https://api.github.com/users/isakiev/repos","events_url":"https://api.github.com/users/isakiev/events{/privacy}","received_events_url":"https://api.github.com/users/isakiev/received_events","type":"User","site_admin":false},"body":"follow-up for #174\r\n\r\nAll dac location logic is put into one place.\r\nThe PR is an intermediate step for possible further improvements.","created_at":"2018-12-14T15:30:03Z","updated_at":"2018-12-21T12:15:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"547a17a7b0ba2bb7e93942974d50507438c0b848","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/clrmd/pulls/182/commits","review_comments_url":"https://api.github.com/repos/Microsoft/clrmd/pulls/182/comments","review_comment_url":"https://api.github.com/repos/Microsoft/clrmd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/clrmd/issues/182/comments","statuses_url":"https://api.github.com/repos/Microsoft/clrmd/statuses/ce9d6b8de1f45db0f6569c3a7437b44a8f79b130","head":{"label":"isakiev:simplified-dac-location","ref":"simplified-dac-location","sha":"ce9d6b8de1f45db0f6569c3a7437b44a8f79b130","user":{"login":"isakiev","id":4499455,"node_id":"MDQ6VXNlcjQ0OTk0NTU=","avatar_url":"https://avatars3.githubusercontent.com/u/4499455?v=4","gravatar_id":"","url":"https://api.github.com/users/isakiev","html_url":"https://github.com/isakiev","followers_url":"https://api.github.com/users/isakiev/followers","following_url":"https://api.github.com/users/isakiev/following{/other_user}","gists_url":"https://api.github.com/users/isakiev/gists{/gist_id}","starred_url":"https://api.github.com/users/isakiev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isakiev/subscriptions","organizations_url":"https://api.github.com/users/isakiev/orgs","repos_url":"https://api.github.com/users/isakiev/repos","events_url":"https://api.github.com/users/isakiev/events{/privacy}","received_events_url":"https://api.github.com/users/isakiev/received_events","type":"User","site_admin":false},"repo":{"id":133047225,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMwNDcyMjU=","name":"clrmd","full_name":"isakiev/clrmd","private":false,"owner":{"login":"isakiev","id":4499455,"node_id":"MDQ6VXNlcjQ0OTk0NTU=","avatar_url":"https://avatars3.githubusercontent.com/u/4499455?v=4","gravatar_id":"","url":"https://api.github.com/users/isakiev","html_url":"https://github.com/isakiev","followers_url":"https://api.github.com/users/isakiev/followers","following_url":"https://api.github.com/users/isakiev/following{/other_user}","gists_url":"https://api.github.com/users/isakiev/gists{/gist_id}","starred_url":"https://api.github.com/users/isakiev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isakiev/subscriptions","organizations_url":"https://api.github.com/users/isakiev/orgs","repos_url":"https://api.github.com/users/isakiev/repos","events_url":"https://api.github.com/users/isakiev/events{/privacy}","received_events_url":"https://api.github.com/users/isakiev/received_events","type":"User","site_admin":false},"html_url":"https://github.com/isakiev/clrmd","description":"Microsoft.Diagnostics.Runtime is a set of APIs for introspecting processes and dumps.","fork":true,"url":"https://api.github.com/repos/isakiev/clrmd","forks_url":"https://api.github.com/repos/isakiev/clrmd/forks","keys_url":"https://api.github.com/repos/isakiev/clrmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/isakiev/clrmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/isakiev/clrmd/teams","hooks_url":"https://api.github.com/repos/isakiev/clrmd/hooks","issue_events_url":"https://api.github.com/repos/isakiev/clrmd/issues/events{/number}","events_url":"https://api.github.com/repos/isakiev/clrmd/events","assignees_url":"https://api.github.com/repos/isakiev/clrmd/assignees{/user}","branches_url":"https://api.github.com/repos/isakiev/clrmd/branches{/branch}","tags_url":"https://api.github.com/repos/isakiev/clrmd/tags","blobs_url":"https://api.github.com/repos/isakiev/clrmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/isakiev/clrmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/isakiev/clrmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/isakiev/clrmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/isakiev/clrmd/statuses/{sha}","languages_url":"https://api.github.com/repos/isakiev/clrmd/languages","stargazers_url":"https://api.github.com/repos/isakiev/clrmd/stargazers","contributors_url":"https://api.github.com/repos/isakiev/clrmd/contributors","subscribers_url":"https://api.github.com/repos/isakiev/clrmd/subscribers","subscription_url":"https://api.github.com/repos/isakiev/clrmd/subscription","commits_url":"https://api.github.com/repos/isakiev/clrmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/isakiev/clrmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/isakiev/clrmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/isakiev/clrmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/isakiev/clrmd/contents/{+path}","compare_url":"https://api.github.com/repos/isakiev/clrmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/isakiev/clrmd/merges","archive_url":"https://api.github.com/repos/isakiev/clrmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/isakiev/clrmd/downloads","issues_url":"https://api.github.com/repos/isakiev/clrmd/issues{/number}","pulls_url":"https://api.github.com/repos/isakiev/clrmd/pulls{/number}","milestones_url":"https://api.github.com/repos/isakiev/clrmd/milestones{/number}","notifications_url":"https://api.github.com/repos/isakiev/clrmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/isakiev/clrmd/labels{/name}","releases_url":"https://api.github.com/repos/isakiev/clrmd/releases{/id}","deployments_url":"https://api.github.com/repos/isakiev/clrmd/deployments","created_at":"2018-05-11T14:02:45Z","updated_at":"2018-12-20T07:11:00Z","pushed_at":"2018-12-20T11:35:49Z","git_url":"git://github.com/isakiev/clrmd.git","ssh_url":"git@github.com:isakiev/clrmd.git","clone_url":"https://github.com/isakiev/clrmd.git","svn_url":"https://github.com/isakiev/clrmd","homepage":"https://github.com/Microsoft/clrmd/blob/master/Documentation/ClrRuntime.md","size":3985,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"2dd46c9c4c5bf1a58dde69bf495f34eae9014355","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":42606220,"node_id":"MDEwOlJlcG9zaXRvcnk0MjYwNjIyMA==","name":"clrmd","full_name":"Microsoft/clrmd","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/clrmd","description":"Microsoft.Diagnostics.Runtime is a set of APIs for introspecting processes and dumps.","fork":false,"url":"https://api.github.com/repos/Microsoft/clrmd","forks_url":"https://api.github.com/repos/Microsoft/clrmd/forks","keys_url":"https://api.github.com/repos/Microsoft/clrmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/clrmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/clrmd/teams","hooks_url":"https://api.github.com/repos/Microsoft/clrmd/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/clrmd/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/clrmd/events","assignees_url":"https://api.github.com/repos/Microsoft/clrmd/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/clrmd/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/clrmd/tags","blobs_url":"https://api.github.com/repos/Microsoft/clrmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/clrmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/clrmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/clrmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/clrmd/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/clrmd/languages","stargazers_url":"https://api.github.com/repos/Microsoft/clrmd/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/clrmd/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/clrmd/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/clrmd/subscription","commits_url":"https://api.github.com/repos/Microsoft/clrmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/clrmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/clrmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/clrmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/clrmd/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/clrmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/clrmd/merges","archive_url":"https://api.github.com/repos/Microsoft/clrmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/clrmd/downloads","issues_url":"https://api.github.com/repos/Microsoft/clrmd/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/clrmd/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/clrmd/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/clrmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/clrmd/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/clrmd/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/clrmd/deployments","created_at":"2015-09-16T18:37:49Z","updated_at":"2018-12-20T17:43:16Z","pushed_at":"2018-12-20T17:43:13Z","git_url":"git://github.com/Microsoft/clrmd.git","ssh_url":"git@github.com:Microsoft/clrmd.git","clone_url":"https://github.com/Microsoft/clrmd.git","svn_url":"https://github.com/Microsoft/clrmd","homepage":"https://github.com/Microsoft/clrmd/blob/master/Documentation/ClrRuntime.md","size":3117,"stargazers_count":456,"watchers_count":456,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":113,"mirror_url":null,"archived":false,"open_issues_count":38,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":113,"open_issues":38,"watchers":456,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/clrmd/pulls/182"},"html":{"href":"https://github.com/Microsoft/clrmd/pull/182"},"issue":{"href":"https://api.github.com/repos/Microsoft/clrmd/issues/182"},"comments":{"href":"https://api.github.com/repos/Microsoft/clrmd/issues/182/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/clrmd/pulls/182/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/clrmd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/clrmd/pulls/182/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/clrmd/statuses/ce9d6b8de1f45db0f6569c3a7437b44a8f79b130"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"isakiev"}}