{"action":"closed","number":155,"pull_request":{"url":"https://api.github.com/repos/dbudwin/RoboHome-Web/pulls/155","id":222626099,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNjI2MDk5","html_url":"https://github.com/dbudwin/RoboHome-Web/pull/155","diff_url":"https://github.com/dbudwin/RoboHome-Web/pull/155.diff","patch_url":"https://github.com/dbudwin/RoboHome-Web/pull/155.patch","issue_url":"https://api.github.com/repos/dbudwin/RoboHome-Web/issues/155","number":155,"state":"closed","locked":false,"title":"Add confirmation after clicking delete","user":{"login":"kailichiang","id":6218405,"node_id":"MDQ6VXNlcjYyMTg0MDU=","avatar_url":"https://avatars0.githubusercontent.com/u/6218405?v=4","gravatar_id":"","url":"https://api.github.com/users/kailichiang","html_url":"https://github.com/kailichiang","followers_url":"https://api.github.com/users/kailichiang/followers","following_url":"https://api.github.com/users/kailichiang/following{/other_user}","gists_url":"https://api.github.com/users/kailichiang/gists{/gist_id}","starred_url":"https://api.github.com/users/kailichiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kailichiang/subscriptions","organizations_url":"https://api.github.com/users/kailichiang/orgs","repos_url":"https://api.github.com/users/kailichiang/repos","events_url":"https://api.github.com/users/kailichiang/events{/privacy}","received_events_url":"https://api.github.com/users/kailichiang/received_events","type":"User","site_admin":false},"body":"Resolve #152\r\n\r\n- Add confirmation javascript code\r\n- Modify the test case for deletion\r\n- Add a test case for canceling deletion\r\n\r\n## Description\r\nAdd confirmation javascript code. This can be ubiquitous for any confirmation needs by adding class=\"confirmation\".\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\nConfirmation before any un-redoable action is great.\r\n<!--- If it fixes an open issue, please link to the issue here. -->\r\n[Add confirmation after clicking \"Delete\" button](https://github.com/dbudwin/RoboHome-Web/issues/152)\r\n\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\nThe change causes a js confirmation dialog before actual action. Add dialog check in test cases.\r\n<!--- Include details of your testing environment, and the tests you ran to see how your change affects other areas of the code, etc. -->\r\ntest by laravel dusk `php artisan dusk`\r\n\r\n## Screenshots (if appropriate):\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [ ] Enhancement/Security (non-breaking change which is not noticeable to end users)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] I created a feature branch and did not open a pull request from my `master` branch.\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires an update to the README and I have updated it accordingly.\r\n- [x] I have read the **CONTRIBUTING** document.\r\n- [x] I have added tests to cover my changes.\r\n- [x] This is a complete change and doesn't leave the project in a bad state.\r\n- [x] All new and existing tests pass.\r\n","created_at":"2018-10-13T04:07:36Z","updated_at":"2018-10-16T00:34:22Z","closed_at":"2018-10-16T00:34:22Z","merged_at":"2018-10-16T00:34:22Z","merge_commit_sha":"5f3743655c7a449ff465b85eed0c36c3f3fdecb3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dbudwin/RoboHome-Web/pulls/155/commits","review_comments_url":"https://api.github.com/repos/dbudwin/RoboHome-Web/pulls/155/comments","review_comment_url":"https://api.github.com/repos/dbudwin/RoboHome-Web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dbudwin/RoboHome-Web/issues/155/comments","statuses_url":"https://api.github.com/repos/dbudwin/RoboHome-Web/statuses/5f3743655c7a449ff465b85eed0c36c3f3fdecb3","head":{"label":"kailichiang:master","ref":"master","sha":"5f3743655c7a449ff465b85eed0c36c3f3fdecb3","user":{"login":"kailichiang","id":6218405,"node_id":"MDQ6VXNlcjYyMTg0MDU=","avatar_url":"https://avatars0.githubusercontent.com/u/6218405?v=4","gravatar_id":"","url":"https://api.github.com/users/kailichiang","html_url":"https://github.com/kailichiang","followers_url":"https://api.github.com/users/kailichiang/followers","following_url":"https://api.github.com/users/kailichiang/following{/other_user}","gists_url":"https://api.github.com/users/kailichiang/gists{/gist_id}","starred_url":"https://api.github.com/users/kailichiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kailichiang/subscriptions","organizations_url":"https://api.github.com/users/kailichiang/orgs","repos_url":"https://api.github.com/users/kailichiang/repos","events_url":"https://api.github.com/users/kailichiang/events{/privacy}","received_events_url":"https://api.github.com/users/kailichiang/received_events","type":"User","site_admin":false},"repo":{"id":152832286,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI4MzIyODY=","name":"RoboHome-Web","full_name":"kailichiang/RoboHome-Web","private":false,"owner":{"login":"kailichiang","id":6218405,"node_id":"MDQ6VXNlcjYyMTg0MDU=","avatar_url":"https://avatars0.githubusercontent.com/u/6218405?v=4","gravatar_id":"","url":"https://api.github.com/users/kailichiang","html_url":"https://github.com/kailichiang","followers_url":"https://api.github.com/users/kailichiang/followers","following_url":"https://api.github.com/users/kailichiang/following{/other_user}","gists_url":"https://api.github.com/users/kailichiang/gists{/gist_id}","starred_url":"https://api.github.com/users/kailichiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kailichiang/subscriptions","organizations_url":"https://api.github.com/users/kailichiang/orgs","repos_url":"https://api.github.com/users/kailichiang/repos","events_url":"https://api.github.com/users/kailichiang/events{/privacy}","received_events_url":"https://api.github.com/users/kailichiang/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kailichiang/RoboHome-Web","description":"RoboHome-Web is the codebase that represents the frontend of the RoboHome project. The web interface provides a way to create users, add and manage devices, and an additional way to control devices. :robot: :house_with_garden:","fork":true,"url":"https://api.github.com/repos/kailichiang/RoboHome-Web","forks_url":"https://api.github.com/repos/kailichiang/RoboHome-Web/forks","keys_url":"https://api.github.com/repos/kailichiang/RoboHome-Web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kailichiang/RoboHome-Web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kailichiang/RoboHome-Web/teams","hooks_url":"https://api.github.com/repos/kailichiang/RoboHome-Web/hooks","issue_events_url":"https://api.github.com/repos/kailichiang/RoboHome-Web/issues/events{/number}","events_url":"https://api.github.com/repos/kailichiang/RoboHome-Web/events","assignees_url":"https://api.github.com/repos/kailichiang/RoboHome-Web/assignees{/user}","branches_url":"https://api.github.com/repos/kailichiang/RoboHome-Web/branches{/branch}","tags_url":"https://api.github.com/repos/kailichiang/RoboHome-Web/tags","blobs_url":"https://api.github.com/repos/kailichiang/RoboHome-Web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kailichiang/RoboHome-Web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kailichiang/RoboHome-Web/git/refs{/sha}","trees_url":"https://api.github.com/repos/kailichiang/RoboHome-Web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kailichiang/RoboHome-Web/statuses/{sha}","languages_url":"https://api.github.com/repos/kailichiang/RoboHome-Web/languages","stargazers_url":"https://api.github.com/repos/kailichiang/RoboHome-Web/stargazers","contributors_url":"https://api.github.com/repos/kailichiang/RoboHome-Web/contributors","subscribers_url":"https://api.github.com/repos/kailichiang/RoboHome-Web/subscribers","subscription_url":"https://api.github.com/repos/kailichiang/RoboHome-Web/subscription","commits_url":"https://api.github.com/repos/kailichiang/RoboHome-Web/commits{/sha}","git_commits_url":"https://api.github.com/repos/kailichiang/RoboHome-Web/git/commits{/sha}","comments_url":"https://api.github.com/repos/kailichiang/RoboHome-Web/comments{/number}","issue_comment_url":"https://api.github.com/repos/kailichiang/RoboHome-Web/issues/comments{/number}","contents_url":"https://api.github.com/repos/kailichiang/RoboHome-Web/contents/{+path}","compare_url":"https://api.github.com/repos/kailichiang/RoboHome-Web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kailichiang/RoboHome-Web/merges","archive_url":"https://api.github.com/repos/kailichiang/RoboHome-Web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kailichiang/RoboHome-Web/downloads","issues_url":"https://api.github.com/repos/kailichiang/RoboHome-Web/issues{/number}","pulls_url":"https://api.github.com/repos/kailichiang/RoboHome-Web/pulls{/number}","milestones_url":"https://api.github.com/repos/kailichiang/RoboHome-Web/milestones{/number}","notifications_url":"https://api.github.com/repos/kailichiang/RoboHome-Web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kailichiang/RoboHome-Web/labels{/name}","releases_url":"https://api.github.com/repos/kailichiang/RoboHome-Web/releases{/id}","deployments_url":"https://api.github.com/repos/kailichiang/RoboHome-Web/deployments","created_at":"2018-10-13T03:43:35Z","updated_at":"2018-10-15T16:23:52Z","pushed_at":"2018-10-15T16:23:50Z","git_url":"git://github.com/kailichiang/RoboHome-Web.git","ssh_url":"git@github.com:kailichiang/RoboHome-Web.git","clone_url":"https://github.com/kailichiang/RoboHome-Web.git","svn_url":"https://github.com/kailichiang/RoboHome-Web","homepage":"","size":1048,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dbudwin:master","ref":"master","sha":"0b1731e2ccd45a55d990d5bde3efdd60bbc9f2f7","user":{"login":"dbudwin","id":15161181,"node_id":"MDQ6VXNlcjE1MTYxMTgx","avatar_url":"https://avatars2.githubusercontent.com/u/15161181?v=4","gravatar_id":"","url":"https://api.github.com/users/dbudwin","html_url":"https://github.com/dbudwin","followers_url":"https://api.github.com/users/dbudwin/followers","following_url":"https://api.github.com/users/dbudwin/following{/other_user}","gists_url":"https://api.github.com/users/dbudwin/gists{/gist_id}","starred_url":"https://api.github.com/users/dbudwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbudwin/subscriptions","organizations_url":"https://api.github.com/users/dbudwin/orgs","repos_url":"https://api.github.com/users/dbudwin/repos","events_url":"https://api.github.com/users/dbudwin/events{/privacy}","received_events_url":"https://api.github.com/users/dbudwin/received_events","type":"User","site_admin":false},"repo":{"id":68420221,"node_id":"MDEwOlJlcG9zaXRvcnk2ODQyMDIyMQ==","name":"RoboHome-Web","full_name":"dbudwin/RoboHome-Web","private":false,"owner":{"login":"dbudwin","id":15161181,"node_id":"MDQ6VXNlcjE1MTYxMTgx","avatar_url":"https://avatars2.githubusercontent.com/u/15161181?v=4","gravatar_id":"","url":"https://api.github.com/users/dbudwin","html_url":"https://github.com/dbudwin","followers_url":"https://api.github.com/users/dbudwin/followers","following_url":"https://api.github.com/users/dbudwin/following{/other_user}","gists_url":"https://api.github.com/users/dbudwin/gists{/gist_id}","starred_url":"https://api.github.com/users/dbudwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbudwin/subscriptions","organizations_url":"https://api.github.com/users/dbudwin/orgs","repos_url":"https://api.github.com/users/dbudwin/repos","events_url":"https://api.github.com/users/dbudwin/events{/privacy}","received_events_url":"https://api.github.com/users/dbudwin/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dbudwin/RoboHome-Web","description":"RoboHome-Web is the codebase that represents the frontend of the RoboHome project. The web interface provides a way to create users, add and manage devices, and an additional way to control devices. :robot: :house_with_garden:","fork":false,"url":"https://api.github.com/repos/dbudwin/RoboHome-Web","forks_url":"https://api.github.com/repos/dbudwin/RoboHome-Web/forks","keys_url":"https://api.github.com/repos/dbudwin/RoboHome-Web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dbudwin/RoboHome-Web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dbudwin/RoboHome-Web/teams","hooks_url":"https://api.github.com/repos/dbudwin/RoboHome-Web/hooks","issue_events_url":"https://api.github.com/repos/dbudwin/RoboHome-Web/issues/events{/number}","events_url":"https://api.github.com/repos/dbudwin/RoboHome-Web/events","assignees_url":"https://api.github.com/repos/dbudwin/RoboHome-Web/assignees{/user}","branches_url":"https://api.github.com/repos/dbudwin/RoboHome-Web/branches{/branch}","tags_url":"https://api.github.com/repos/dbudwin/RoboHome-Web/tags","blobs_url":"https://api.github.com/repos/dbudwin/RoboHome-Web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dbudwin/RoboHome-Web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dbudwin/RoboHome-Web/git/refs{/sha}","trees_url":"https://api.github.com/repos/dbudwin/RoboHome-Web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dbudwin/RoboHome-Web/statuses/{sha}","languages_url":"https://api.github.com/repos/dbudwin/RoboHome-Web/languages","stargazers_url":"https://api.github.com/repos/dbudwin/RoboHome-Web/stargazers","contributors_url":"https://api.github.com/repos/dbudwin/RoboHome-Web/contributors","subscribers_url":"https://api.github.com/repos/dbudwin/RoboHome-Web/subscribers","subscription_url":"https://api.github.com/repos/dbudwin/RoboHome-Web/subscription","commits_url":"https://api.github.com/repos/dbudwin/RoboHome-Web/commits{/sha}","git_commits_url":"https://api.github.com/repos/dbudwin/RoboHome-Web/git/commits{/sha}","comments_url":"https://api.github.com/repos/dbudwin/RoboHome-Web/comments{/number}","issue_comment_url":"https://api.github.com/repos/dbudwin/RoboHome-Web/issues/comments{/number}","contents_url":"https://api.github.com/repos/dbudwin/RoboHome-Web/contents/{+path}","compare_url":"https://api.github.com/repos/dbudwin/RoboHome-Web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dbudwin/RoboHome-Web/merges","archive_url":"https://api.github.com/repos/dbudwin/RoboHome-Web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dbudwin/RoboHome-Web/downloads","issues_url":"https://api.github.com/repos/dbudwin/RoboHome-Web/issues{/number}","pulls_url":"https://api.github.com/repos/dbudwin/RoboHome-Web/pulls{/number}","milestones_url":"https://api.github.com/repos/dbudwin/RoboHome-Web/milestones{/number}","notifications_url":"https://api.github.com/repos/dbudwin/RoboHome-Web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dbudwin/RoboHome-Web/labels{/name}","releases_url":"https://api.github.com/repos/dbudwin/RoboHome-Web/releases{/id}","deployments_url":"https://api.github.com/repos/dbudwin/RoboHome-Web/deployments","created_at":"2016-09-16T23:06:37Z","updated_at":"2018-10-15T21:51:41Z","pushed_at":"2018-10-16T00:34:21Z","git_url":"git://github.com/dbudwin/RoboHome-Web.git","ssh_url":"git@github.com:dbudwin/RoboHome-Web.git","clone_url":"https://github.com/dbudwin/RoboHome-Web.git","svn_url":"https://github.com/dbudwin/RoboHome-Web","homepage":"","size":1039,"stargazers_count":9,"watchers_count":9,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":20,"open_issues":16,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dbudwin/RoboHome-Web/pulls/155"},"html":{"href":"https://github.com/dbudwin/RoboHome-Web/pull/155"},"issue":{"href":"https://api.github.com/repos/dbudwin/RoboHome-Web/issues/155"},"comments":{"href":"https://api.github.com/repos/dbudwin/RoboHome-Web/issues/155/comments"},"review_comments":{"href":"https://api.github.com/repos/dbudwin/RoboHome-Web/pulls/155/comments"},"review_comment":{"href":"https://api.github.com/repos/dbudwin/RoboHome-Web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dbudwin/RoboHome-Web/pulls/155/commits"},"statuses":{"href":"https://api.github.com/repos/dbudwin/RoboHome-Web/statuses/5f3743655c7a449ff465b85eed0c36c3f3fdecb3"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"dbudwin","id":15161181,"node_id":"MDQ6VXNlcjE1MTYxMTgx","avatar_url":"https://avatars2.githubusercontent.com/u/15161181?v=4","gravatar_id":"","url":"https://api.github.com/users/dbudwin","html_url":"https://github.com/dbudwin","followers_url":"https://api.github.com/users/dbudwin/followers","following_url":"https://api.github.com/users/dbudwin/following{/other_user}","gists_url":"https://api.github.com/users/dbudwin/gists{/gist_id}","starred_url":"https://api.github.com/users/dbudwin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbudwin/subscriptions","organizations_url":"https://api.github.com/users/dbudwin/orgs","repos_url":"https://api.github.com/users/dbudwin/repos","events_url":"https://api.github.com/users/dbudwin/events{/privacy}","received_events_url":"https://api.github.com/users/dbudwin/received_events","type":"User","site_admin":false},"comments":3,"review_comments":4,"maintainer_can_modify":false,"commits":3,"additions":39,"deletions":1,"changed_files":2}}
{"actor":{"display_login":"dbudwin"}}