{"action":"created","issue":{"url":"https://api.github.com/repos/kubevirt/kubevirt/issues/1567","repository_url":"https://api.github.com/repos/kubevirt/kubevirt","labels_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/1567/labels{/name}","comments_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/1567/comments","events_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/1567/events","html_url":"https://github.com/kubevirt/kubevirt/pull/1567","id":365224920,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MjA1MDk3","number":1567,"title":"Support vhost-net backend","user":{"login":"lkpdn","id":17020294,"node_id":"MDQ6VXNlcjE3MDIwMjk0","avatar_url":"https://avatars3.githubusercontent.com/u/17020294?v=4","gravatar_id":"","url":"https://api.github.com/users/lkpdn","html_url":"https://github.com/lkpdn","followers_url":"https://api.github.com/users/lkpdn/followers","following_url":"https://api.github.com/users/lkpdn/following{/other_user}","gists_url":"https://api.github.com/users/lkpdn/gists{/gist_id}","starred_url":"https://api.github.com/users/lkpdn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lkpdn/subscriptions","organizations_url":"https://api.github.com/users/lkpdn/orgs","repos_url":"https://api.github.com/users/lkpdn/repos","events_url":"https://api.github.com/users/lkpdn/events{/privacy}","received_events_url":"https://api.github.com/users/lkpdn/received_events","type":"User","site_admin":false},"labels":[{"id":685000214,"node_id":"MDU6TGFiZWw2ODUwMDAyMTQ=","url":"https://api.github.com/repos/kubevirt/kubevirt/labels/do-not-merge/release-note-label-needed","name":"do-not-merge/release-note-label-needed","color":"e11d21","default":false},{"id":583175137,"node_id":"MDU6TGFiZWw1ODMxNzUxMzc=","url":"https://api.github.com/repos/kubevirt/kubevirt/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-09-30T13:31:10Z","updated_at":"2018-10-02T08:08:12Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/1567","html_url":"https://github.com/kubevirt/kubevirt/pull/1567","diff_url":"https://github.com/kubevirt/kubevirt/pull/1567.diff","patch_url":"https://github.com/kubevirt/kubevirt/pull/1567.patch"},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. Follow the instructions for writing a release note from k8s: https://git.k8s.io/community/contributors/guide/release-notes.md\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n\r\nFor performance reasons, some want to get vhost-net to work for VMI.\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #\r\n\r\n**Special notes for your reviewer**:\r\n\r\nI'd like some early feedback with opening this PR. If opening an Issue is more appropriate, please let me know.\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\n\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubevirt/kubevirt/issues/comments/426186191","html_url":"https://github.com/kubevirt/kubevirt/pull/1567#issuecomment-426186191","issue_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/1567","id":426186191,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNjE4NjE5MQ==","user":{"login":"rmohr","id":4534621,"node_id":"MDQ6VXNlcjQ1MzQ2MjE=","avatar_url":"https://avatars3.githubusercontent.com/u/4534621?v=4","gravatar_id":"","url":"https://api.github.com/users/rmohr","html_url":"https://github.com/rmohr","followers_url":"https://api.github.com/users/rmohr/followers","following_url":"https://api.github.com/users/rmohr/following{/other_user}","gists_url":"https://api.github.com/users/rmohr/gists{/gist_id}","starred_url":"https://api.github.com/users/rmohr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmohr/subscriptions","organizations_url":"https://api.github.com/users/rmohr/orgs","repos_url":"https://api.github.com/users/rmohr/repos","events_url":"https://api.github.com/users/rmohr/events{/privacy}","received_events_url":"https://api.github.com/users/rmohr/received_events","type":"User","site_admin":false},"created_at":"2018-10-02T08:08:12Z","updated_at":"2018-10-02T08:08:12Z","author_association":"MEMBER","body":"> ok.. so many failures, though I guess most of these are not relevant to this one, as far as I see in recent results for kubevirt_kubevirt_standard-check-pr, right?\r\n\r\nYes they are unrelated.\r\n\r\n> \r\n> If noone has time to deal with these, I'm happy to do that. Or, is there some reason not to tackle these?\r\n> E.g. about `Tests Suite.Configurations VirtualMachineInstance definition with namespace memory limits above VMI required memory should failed to start the VMI`, I guess we have to make a trade-off between introducing dirty polling(*1) in the test code and just ignoring the failure with its test code cleanness being kept, and the latter has been chosen for now. Just guessing. If I missed relevant discussion in the past, sorry about that.\r\n\r\nThat would be great. Others are looking into other tests already but that one should also be taken care of. I think that we should retry creating the VMI like you suggested. Retrying 5 times with one second delay should be good enough. If it then still fails we can be sure that there is an  issue in the cluster, because the informers should update *almost* immediately. It should normally always succeed on the second poll at last. \r\n> \r\n> (*1): to get expected result, we have to wait for limitrange to be filled in in the indexer on virt-api side, so to keep the code abstraction clean, IMHO there are no other choice than `wait.Poll(...` with its timeout set to say 30 seconds.\r\n\r\n"}}
{"actor":{"display_login":"rmohr"}}