{"action":"created","comment":{"url":"https://api.github.com/repos/grafana/grafana/pulls/comments/244585579","pull_request_review_id":188497364,"id":244585579,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDU4NTU3OQ==","diff_hunk":"@@ -1,2 +1,16 @@\n <datasource-http-settings current=\"ctrl.current\" no-direct-access=\"true\">\n-</datasource-http-settings>\n\\ No newline at end of file\n+</datasource-http-settings>\n+\n+<div class=\"gf-form-group\">\n+  <div class=\"gf-form-inline\">\n+    <div class=\"gf-form\">\n+      <span class=\"gf-form-label width-8\">Line limit</span>\n+      <input type=\"text\" class=\"gf-form-input width-8\" ng-model=\"ctrl.current.jsonData.queryLimit\" spellcheck='false' placeholder=\"1000\"></input>","path":"public/app/plugins/datasource/loki/partials/config.html","position":10,"original_position":10,"commit_id":"26a5e077373ad41fa308f4850ad7fac60aedb942","original_commit_id":"26a5e077373ad41fa308f4850ad7fac60aedb942","user":{"login":"torkelo","id":10999,"node_id":"MDQ6VXNlcjEwOTk5","avatar_url":"https://avatars3.githubusercontent.com/u/10999?v=4","gravatar_id":"","url":"https://api.github.com/users/torkelo","html_url":"https://github.com/torkelo","followers_url":"https://api.github.com/users/torkelo/followers","following_url":"https://api.github.com/users/torkelo/following{/other_user}","gists_url":"https://api.github.com/users/torkelo/gists{/gist_id}","starred_url":"https://api.github.com/users/torkelo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/torkelo/subscriptions","organizations_url":"https://api.github.com/users/torkelo/orgs","repos_url":"https://api.github.com/users/torkelo/repos","events_url":"https://api.github.com/users/torkelo/events{/privacy}","received_events_url":"https://api.github.com/users/torkelo/received_events","type":"User","site_admin":false},"body":"not sure query limit (property name) is the best here as it indicates a limit to number of queries. Maybe\r\n* maxLines\r\n* maxLineCount\r\n* lineCountLimit \r\n* lineLimit\r\n\r\netc","created_at":"2018-12-31T13:40:16Z","updated_at":"2018-12-31T13:40:16Z","html_url":"https://github.com/grafana/grafana/pull/14689#discussion_r244585579","pull_request_url":"https://api.github.com/repos/grafana/grafana/pulls/14689","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/grafana/grafana/pulls/comments/244585579"},"html":{"href":"https://github.com/grafana/grafana/pull/14689#discussion_r244585579"},"pull_request":{"href":"https://api.github.com/repos/grafana/grafana/pulls/14689"}}},"pull_request":{"url":"https://api.github.com/repos/grafana/grafana/pulls/14689","id":241554021,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNTU0MDIx","html_url":"https://github.com/grafana/grafana/pull/14689","diff_url":"https://github.com/grafana/grafana/pull/14689.diff","patch_url":"https://github.com/grafana/grafana/pull/14689.patch","issue_url":"https://api.github.com/repos/grafana/grafana/issues/14689","number":14689,"state":"open","locked":false,"title":"Loki: query limit configurable in datasource","user":{"login":"davkal","id":859729,"node_id":"MDQ6VXNlcjg1OTcyOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/859729?v=4","gravatar_id":"","url":"https://api.github.com/users/davkal","html_url":"https://github.com/davkal","followers_url":"https://api.github.com/users/davkal/followers","following_url":"https://api.github.com/users/davkal/following{/other_user}","gists_url":"https://api.github.com/users/davkal/gists{/gist_id}","starred_url":"https://api.github.com/users/davkal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davkal/subscriptions","organizations_url":"https://api.github.com/users/davkal/orgs","repos_url":"https://api.github.com/users/davkal/repos","events_url":"https://api.github.com/users/davkal/events{/privacy}","received_events_url":"https://api.github.com/users/davkal/received_events","type":"User","site_admin":false},"body":"- Loki queries must contain a limit\r\n- this change makes this limit configurable in the datasource\r\n- keep default at 1000, add tooltip on why inc/dec makes sense\r\n- added tests\r\n\r\nFixes #14687","created_at":"2018-12-31T11:28:05Z","updated_at":"2018-12-31T13:40:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"db45f866292ecbe42f69bec3055e48442f771419","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/grafana/grafana/pulls/14689/commits","review_comments_url":"https://api.github.com/repos/grafana/grafana/pulls/14689/comments","review_comment_url":"https://api.github.com/repos/grafana/grafana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/grafana/grafana/issues/14689/comments","statuses_url":"https://api.github.com/repos/grafana/grafana/statuses/26a5e077373ad41fa308f4850ad7fac60aedb942","head":{"label":"grafana:davkal/loki-limit","ref":"davkal/loki-limit","sha":"26a5e077373ad41fa308f4850ad7fac60aedb942","user":{"login":"grafana","id":7195757,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcxOTU3NTc=","avatar_url":"https://avatars0.githubusercontent.com/u/7195757?v=4","gravatar_id":"","url":"https://api.github.com/users/grafana","html_url":"https://github.com/grafana","followers_url":"https://api.github.com/users/grafana/followers","following_url":"https://api.github.com/users/grafana/following{/other_user}","gists_url":"https://api.github.com/users/grafana/gists{/gist_id}","starred_url":"https://api.github.com/users/grafana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grafana/subscriptions","organizations_url":"https://api.github.com/users/grafana/orgs","repos_url":"https://api.github.com/users/grafana/repos","events_url":"https://api.github.com/users/grafana/events{/privacy}","received_events_url":"https://api.github.com/users/grafana/received_events","type":"Organization","site_admin":false},"repo":{"id":15111821,"node_id":"MDEwOlJlcG9zaXRvcnkxNTExMTgyMQ==","name":"grafana","full_name":"grafana/grafana","private":false,"owner":{"login":"grafana","id":7195757,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcxOTU3NTc=","avatar_url":"https://avatars0.githubusercontent.com/u/7195757?v=4","gravatar_id":"","url":"https://api.github.com/users/grafana","html_url":"https://github.com/grafana","followers_url":"https://api.github.com/users/grafana/followers","following_url":"https://api.github.com/users/grafana/following{/other_user}","gists_url":"https://api.github.com/users/grafana/gists{/gist_id}","starred_url":"https://api.github.com/users/grafana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grafana/subscriptions","organizations_url":"https://api.github.com/users/grafana/orgs","repos_url":"https://api.github.com/users/grafana/repos","events_url":"https://api.github.com/users/grafana/events{/privacy}","received_events_url":"https://api.github.com/users/grafana/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/grafana/grafana","description":"The tool for beautiful monitoring and metric analytics & dashboards for Graphite, InfluxDB & Prometheus & More","fork":false,"url":"https://api.github.com/repos/grafana/grafana","forks_url":"https://api.github.com/repos/grafana/grafana/forks","keys_url":"https://api.github.com/repos/grafana/grafana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grafana/grafana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grafana/grafana/teams","hooks_url":"https://api.github.com/repos/grafana/grafana/hooks","issue_events_url":"https://api.github.com/repos/grafana/grafana/issues/events{/number}","events_url":"https://api.github.com/repos/grafana/grafana/events","assignees_url":"https://api.github.com/repos/grafana/grafana/assignees{/user}","branches_url":"https://api.github.com/repos/grafana/grafana/branches{/branch}","tags_url":"https://api.github.com/repos/grafana/grafana/tags","blobs_url":"https://api.github.com/repos/grafana/grafana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grafana/grafana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grafana/grafana/git/refs{/sha}","trees_url":"https://api.github.com/repos/grafana/grafana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grafana/grafana/statuses/{sha}","languages_url":"https://api.github.com/repos/grafana/grafana/languages","stargazers_url":"https://api.github.com/repos/grafana/grafana/stargazers","contributors_url":"https://api.github.com/repos/grafana/grafana/contributors","subscribers_url":"https://api.github.com/repos/grafana/grafana/subscribers","subscription_url":"https://api.github.com/repos/grafana/grafana/subscription","commits_url":"https://api.github.com/repos/grafana/grafana/commits{/sha}","git_commits_url":"https://api.github.com/repos/grafana/grafana/git/commits{/sha}","comments_url":"https://api.github.com/repos/grafana/grafana/comments{/number}","issue_comment_url":"https://api.github.com/repos/grafana/grafana/issues/comments{/number}","contents_url":"https://api.github.com/repos/grafana/grafana/contents/{+path}","compare_url":"https://api.github.com/repos/grafana/grafana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grafana/grafana/merges","archive_url":"https://api.github.com/repos/grafana/grafana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grafana/grafana/downloads","issues_url":"https://api.github.com/repos/grafana/grafana/issues{/number}","pulls_url":"https://api.github.com/repos/grafana/grafana/pulls{/number}","milestones_url":"https://api.github.com/repos/grafana/grafana/milestones{/number}","notifications_url":"https://api.github.com/repos/grafana/grafana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grafana/grafana/labels{/name}","releases_url":"https://api.github.com/repos/grafana/grafana/releases{/id}","deployments_url":"https://api.github.com/repos/grafana/grafana/deployments","created_at":"2013-12-11T15:59:56Z","updated_at":"2018-12-31T13:34:31Z","pushed_at":"2018-12-31T13:34:24Z","git_url":"git://github.com/grafana/grafana.git","ssh_url":"git@github.com:grafana/grafana.git","clone_url":"https://github.com/grafana/grafana.git","svn_url":"https://github.com/grafana/grafana","homepage":"https://grafana.com","size":194098,"stargazers_count":25868,"watchers_count":25868,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4766,"mirror_url":null,"archived":false,"open_issues_count":1592,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4766,"open_issues":1592,"watchers":25868,"default_branch":"master"}},"base":{"label":"grafana:master","ref":"master","sha":"6f998541c8c99ced36fadf748703dc7bca563902","user":{"login":"grafana","id":7195757,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcxOTU3NTc=","avatar_url":"https://avatars0.githubusercontent.com/u/7195757?v=4","gravatar_id":"","url":"https://api.github.com/users/grafana","html_url":"https://github.com/grafana","followers_url":"https://api.github.com/users/grafana/followers","following_url":"https://api.github.com/users/grafana/following{/other_user}","gists_url":"https://api.github.com/users/grafana/gists{/gist_id}","starred_url":"https://api.github.com/users/grafana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grafana/subscriptions","organizations_url":"https://api.github.com/users/grafana/orgs","repos_url":"https://api.github.com/users/grafana/repos","events_url":"https://api.github.com/users/grafana/events{/privacy}","received_events_url":"https://api.github.com/users/grafana/received_events","type":"Organization","site_admin":false},"repo":{"id":15111821,"node_id":"MDEwOlJlcG9zaXRvcnkxNTExMTgyMQ==","name":"grafana","full_name":"grafana/grafana","private":false,"owner":{"login":"grafana","id":7195757,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcxOTU3NTc=","avatar_url":"https://avatars0.githubusercontent.com/u/7195757?v=4","gravatar_id":"","url":"https://api.github.com/users/grafana","html_url":"https://github.com/grafana","followers_url":"https://api.github.com/users/grafana/followers","following_url":"https://api.github.com/users/grafana/following{/other_user}","gists_url":"https://api.github.com/users/grafana/gists{/gist_id}","starred_url":"https://api.github.com/users/grafana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grafana/subscriptions","organizations_url":"https://api.github.com/users/grafana/orgs","repos_url":"https://api.github.com/users/grafana/repos","events_url":"https://api.github.com/users/grafana/events{/privacy}","received_events_url":"https://api.github.com/users/grafana/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/grafana/grafana","description":"The tool for beautiful monitoring and metric analytics & dashboards for Graphite, InfluxDB & Prometheus & More","fork":false,"url":"https://api.github.com/repos/grafana/grafana","forks_url":"https://api.github.com/repos/grafana/grafana/forks","keys_url":"https://api.github.com/repos/grafana/grafana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grafana/grafana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grafana/grafana/teams","hooks_url":"https://api.github.com/repos/grafana/grafana/hooks","issue_events_url":"https://api.github.com/repos/grafana/grafana/issues/events{/number}","events_url":"https://api.github.com/repos/grafana/grafana/events","assignees_url":"https://api.github.com/repos/grafana/grafana/assignees{/user}","branches_url":"https://api.github.com/repos/grafana/grafana/branches{/branch}","tags_url":"https://api.github.com/repos/grafana/grafana/tags","blobs_url":"https://api.github.com/repos/grafana/grafana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grafana/grafana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grafana/grafana/git/refs{/sha}","trees_url":"https://api.github.com/repos/grafana/grafana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grafana/grafana/statuses/{sha}","languages_url":"https://api.github.com/repos/grafana/grafana/languages","stargazers_url":"https://api.github.com/repos/grafana/grafana/stargazers","contributors_url":"https://api.github.com/repos/grafana/grafana/contributors","subscribers_url":"https://api.github.com/repos/grafana/grafana/subscribers","subscription_url":"https://api.github.com/repos/grafana/grafana/subscription","commits_url":"https://api.github.com/repos/grafana/grafana/commits{/sha}","git_commits_url":"https://api.github.com/repos/grafana/grafana/git/commits{/sha}","comments_url":"https://api.github.com/repos/grafana/grafana/comments{/number}","issue_comment_url":"https://api.github.com/repos/grafana/grafana/issues/comments{/number}","contents_url":"https://api.github.com/repos/grafana/grafana/contents/{+path}","compare_url":"https://api.github.com/repos/grafana/grafana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grafana/grafana/merges","archive_url":"https://api.github.com/repos/grafana/grafana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grafana/grafana/downloads","issues_url":"https://api.github.com/repos/grafana/grafana/issues{/number}","pulls_url":"https://api.github.com/repos/grafana/grafana/pulls{/number}","milestones_url":"https://api.github.com/repos/grafana/grafana/milestones{/number}","notifications_url":"https://api.github.com/repos/grafana/grafana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grafana/grafana/labels{/name}","releases_url":"https://api.github.com/repos/grafana/grafana/releases{/id}","deployments_url":"https://api.github.com/repos/grafana/grafana/deployments","created_at":"2013-12-11T15:59:56Z","updated_at":"2018-12-31T13:34:31Z","pushed_at":"2018-12-31T13:34:24Z","git_url":"git://github.com/grafana/grafana.git","ssh_url":"git@github.com:grafana/grafana.git","clone_url":"https://github.com/grafana/grafana.git","svn_url":"https://github.com/grafana/grafana","homepage":"https://grafana.com","size":194098,"stargazers_count":25868,"watchers_count":25868,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4766,"mirror_url":null,"archived":false,"open_issues_count":1592,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4766,"open_issues":1592,"watchers":25868,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/grafana/grafana/pulls/14689"},"html":{"href":"https://github.com/grafana/grafana/pull/14689"},"issue":{"href":"https://api.github.com/repos/grafana/grafana/issues/14689"},"comments":{"href":"https://api.github.com/repos/grafana/grafana/issues/14689/comments"},"review_comments":{"href":"https://api.github.com/repos/grafana/grafana/pulls/14689/comments"},"review_comment":{"href":"https://api.github.com/repos/grafana/grafana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/grafana/grafana/pulls/14689/commits"},"statuses":{"href":"https://api.github.com/repos/grafana/grafana/statuses/26a5e077373ad41fa308f4850ad7fac60aedb942"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"torkelo"}}