{"action":"created","issue":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/26123","repository_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA","labels_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/26123/labels{/name}","comments_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/26123/comments","events_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/26123/events","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/26123","id":367647158,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxMDA5NjQ0","number":26123,"title":"Vehicle armor tiers","user":{"login":"NotFuji","id":38316883,"node_id":"MDQ6VXNlcjM4MzE2ODgz","avatar_url":"https://avatars0.githubusercontent.com/u/38316883?v=4","gravatar_id":"","url":"https://api.github.com/users/NotFuji","html_url":"https://github.com/NotFuji","followers_url":"https://api.github.com/users/NotFuji/followers","following_url":"https://api.github.com/users/NotFuji/following{/other_user}","gists_url":"https://api.github.com/users/NotFuji/gists{/gist_id}","starred_url":"https://api.github.com/users/NotFuji/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NotFuji/subscriptions","organizations_url":"https://api.github.com/users/NotFuji/orgs","repos_url":"https://api.github.com/users/NotFuji/repos","events_url":"https://api.github.com/users/NotFuji/events{/privacy}","received_events_url":"https://api.github.com/users/NotFuji/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-10-08T05:56:05Z","updated_at":"2018-10-08T16:53:38Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/pulls/26123","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/26123","diff_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/26123.diff","patch_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/26123.patch"},"body":"#### Summary\r\n```SUMMARY: Content \"Adds vehicle armor tiers (wood and metal)\"```\r\n\r\n#### Purpose of change\r\nSimple armor tiers aren't diverse enough to simulate different vehicle types accurately, resulting in vehicles that behave differently than expected.\r\n\r\nMultiple armor tiers solves this issue by bringing more flexibility to armor ratings.\r\n\r\n#### Describe the solution\r\nArmor plate tiers made of multiple plates of a similar type can be crafted\r\n\r\n**T1:** Standard plate, no change\r\n\r\n**T2:** \"reinforced armor\"\r\n - 2x plates\r\n - 1.5x DR\r\n - 1.5x Durability\r\n\r\n**T3:** \"slab armor\"\r\n - 3x plates\r\n - skill + 1\r\n - 2x DR\r\n - 2x Durability\r\n\r\n**T4:** \"reinforced slab armor\"\r\n - 4x plates\r\n - skill + 1\r\n - 2.5x DR\r\n - 2.5x Durability\r\n\r\n**T5:** \"heavy slab armor\"\r\n - 5x plates\r\n - skill + 2\r\n - 3x DR\r\n - 3x Durability\r\n\r\n_Weight, volume, and price scale with number of plates_\r\n\r\nAs an example of how the numbers pan out:\r\nT5 Military Composite armor ends up being just barely able to fully withstand a sledgehammer hit, is unaffected by all but the strongest zombies, and can take 3-4 HEDP rockets before being completely destroyed.\r\n\r\n#### Describe alternatives you've considered\r\nBiological armors and vehicle types are still unchanged.\r\n\r\nTerrain interactions are still far too destructive to vehicles.  Even with absurd DR values, trees will quickly obliterate any vehicle.\r\n\r\nMilitary composites should be reserved for heavy vehicles only.  Tanks, APCs, MRAPs\r\nLighter military vehicles like Humvees can now use heavier steel platings"},"comment":{"url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/comments/427905887","html_url":"https://github.com/CleverRaven/Cataclysm-DDA/pull/26123#issuecomment-427905887","issue_url":"https://api.github.com/repos/CleverRaven/Cataclysm-DDA/issues/26123","id":427905887,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzkwNTg4Nw==","user":{"login":"kevingranade","id":860276,"node_id":"MDQ6VXNlcjg2MDI3Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/860276?v=4","gravatar_id":"","url":"https://api.github.com/users/kevingranade","html_url":"https://github.com/kevingranade","followers_url":"https://api.github.com/users/kevingranade/followers","following_url":"https://api.github.com/users/kevingranade/following{/other_user}","gists_url":"https://api.github.com/users/kevingranade/gists{/gist_id}","starred_url":"https://api.github.com/users/kevingranade/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevingranade/subscriptions","organizations_url":"https://api.github.com/users/kevingranade/orgs","repos_url":"https://api.github.com/users/kevingranade/repos","events_url":"https://api.github.com/users/kevingranade/events{/privacy}","received_events_url":"https://api.github.com/users/kevingranade/received_events","type":"User","site_admin":false},"created_at":"2018-10-08T16:53:38Z","updated_at":"2018-10-08T16:53:38Z","author_association":"MEMBER","body":"Rather than focusing on raw numbers, what are the real goals for how tough these armor varieties are?\r\nExamples(not in any meaningful order):\r\n50/50 chance of stopping ordinary pistol round\r\nCan stop ordinary pistol round\r\nCan stop ordinary pistol round with no damage\r\n(Repeat for meaningful differences in firearms)\r\nCan survive a 30MPh collision with a tree\r\nNot damaged by a punch\r\nNot damaged by a 30mph collision with a large creature\r\n\r\nYou can probably guess where this is going, write some test cases that test these assertions."}}
{"actor":{"display_login":"kevingranade"}}