{"action":"created","issue":{"url":"https://api.github.com/repos/istio/istio/issues/8423","repository_url":"https://api.github.com/repos/istio/istio","labels_url":"https://api.github.com/repos/istio/istio/issues/8423/labels{/name}","comments_url":"https://api.github.com/repos/istio/istio/issues/8423/comments","events_url":"https://api.github.com/repos/istio/istio/issues/8423/events","html_url":"https://github.com/istio/istio/pull/8423","id":356206673,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNTQ5MTg5","number":8423,"title":"Fix racetest failures in TestAdsReconnectWithNonce","user":{"login":"ymesika","id":26809068,"node_id":"MDQ6VXNlcjI2ODA5MDY4","avatar_url":"https://avatars3.githubusercontent.com/u/26809068?v=4","gravatar_id":"","url":"https://api.github.com/users/ymesika","html_url":"https://github.com/ymesika","followers_url":"https://api.github.com/users/ymesika/followers","following_url":"https://api.github.com/users/ymesika/following{/other_user}","gists_url":"https://api.github.com/users/ymesika/gists{/gist_id}","starred_url":"https://api.github.com/users/ymesika/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ymesika/subscriptions","organizations_url":"https://api.github.com/users/ymesika/orgs","repos_url":"https://api.github.com/users/ymesika/repos","events_url":"https://api.github.com/users/ymesika/events{/privacy}","received_events_url":"https://api.github.com/users/ymesika/received_events","type":"User","site_admin":false},"labels":[{"id":491318011,"node_id":"MDU6TGFiZWw0OTEzMTgwMTE=","url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-09-01T14:29:59Z","updated_at":"2018-09-01T17:44:05Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/8423","html_url":"https://github.com/istio/istio/pull/8423","diff_url":"https://github.com/istio/istio/pull/8423.diff","patch_url":"https://github.com/istio/istio/pull/8423.patch"},"body":"A fix for the `TestAdsReconnectWithNonce` which constantly fails in the recent weeks. The root cause is that the Monitor is doing `deepEqual` (read) of the old config while the PushContext tries to modify its short hostnames.\r\n\r\nThe fix is adding a _RWMutex_ to the config and calling the _Lock()/RLock()_ in the critical data racing blocks.\r\n\r\nThis is an alternative way to the deep copy approach in #8097.\r\nFixes #7808 "},"comment":{"url":"https://api.github.com/repos/istio/istio/issues/comments/417875885","html_url":"https://github.com/istio/istio/pull/8423#issuecomment-417875885","issue_url":"https://api.github.com/repos/istio/istio/issues/8423","id":417875885,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNzg3NTg4NQ==","user":{"login":"istio-testing","id":25311884,"node_id":"MDQ6VXNlcjI1MzExODg0","avatar_url":"https://avatars1.githubusercontent.com/u/25311884?v=4","gravatar_id":"","url":"https://api.github.com/users/istio-testing","html_url":"https://github.com/istio-testing","followers_url":"https://api.github.com/users/istio-testing/followers","following_url":"https://api.github.com/users/istio-testing/following{/other_user}","gists_url":"https://api.github.com/users/istio-testing/gists{/gist_id}","starred_url":"https://api.github.com/users/istio-testing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio-testing/subscriptions","organizations_url":"https://api.github.com/users/istio-testing/orgs","repos_url":"https://api.github.com/users/istio-testing/repos","events_url":"https://api.github.com/users/istio-testing/events{/privacy}","received_events_url":"https://api.github.com/users/istio-testing/received_events","type":"User","site_admin":false},"created_at":"2018-09-01T17:44:05Z","updated_at":"2018-09-01T17:44:05Z","author_association":"COLLABORATOR","body":"@ymesika: The following test **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\nprow/e2e-mixer-no_auth.sh | 6e9d022761d3d320a61647a4859096a59bc5e551 | [link](https://k8s-gubernator.appspot.com/build/istio-prow/pull/istio_istio/8423/e2e-mixer-no_auth/3711/) | `/test e2e-mixer-no_auth`\n\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"istio-testing"}}