{"action":"closed","issue":{"url":"https://api.github.com/repos/GolosChain/golos/issues/671","repository_url":"https://api.github.com/repos/GolosChain/golos","labels_url":"https://api.github.com/repos/GolosChain/golos/issues/671/labels{/name}","comments_url":"https://api.github.com/repos/GolosChain/golos/issues/671/comments","events_url":"https://api.github.com/repos/GolosChain/golos/issues/671/events","html_url":"https://github.com/GolosChain/golos/issues/671","id":325672967,"number":671,"title":"Foreign key approval prevents proposal from apply","user":{"login":"zxcat","id":550974,"avatar_url":"https://avatars3.githubusercontent.com/u/550974?v=4","gravatar_id":"","url":"https://api.github.com/users/zxcat","html_url":"https://github.com/zxcat","followers_url":"https://api.github.com/users/zxcat/followers","following_url":"https://api.github.com/users/zxcat/following{/other_user}","gists_url":"https://api.github.com/users/zxcat/gists{/gist_id}","starred_url":"https://api.github.com/users/zxcat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zxcat/subscriptions","organizations_url":"https://api.github.com/users/zxcat/orgs","repos_url":"https://api.github.com/users/zxcat/repos","events_url":"https://api.github.com/users/zxcat/events{/privacy}","received_events_url":"https://api.github.com/users/zxcat/received_events","type":"User","site_admin":false},"labels":[{"id":419483124,"url":"https://api.github.com/repos/GolosChain/golos/labels/bug","name":"bug","color":"ee0701","default":true},{"id":524164824,"url":"https://api.github.com/repos/GolosChain/golos/labels/core","name":"core","color":"e99695","default":false},{"id":579105509,"url":"https://api.github.com/repos/GolosChain/golos/labels/hardfork","name":"hardfork","color":"d93f0b","default":false},{"id":863349444,"url":"https://api.github.com/repos/GolosChain/golos/labels/low","name":"low","color":"19bc10","default":false}],"state":"closed","locked":false,"assignee":{"login":"afalaleev","id":27198658,"avatar_url":"https://avatars0.githubusercontent.com/u/27198658?v=4","gravatar_id":"","url":"https://api.github.com/users/afalaleev","html_url":"https://github.com/afalaleev","followers_url":"https://api.github.com/users/afalaleev/followers","following_url":"https://api.github.com/users/afalaleev/following{/other_user}","gists_url":"https://api.github.com/users/afalaleev/gists{/gist_id}","starred_url":"https://api.github.com/users/afalaleev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afalaleev/subscriptions","organizations_url":"https://api.github.com/users/afalaleev/orgs","repos_url":"https://api.github.com/users/afalaleev/repos","events_url":"https://api.github.com/users/afalaleev/events{/privacy}","received_events_url":"https://api.github.com/users/afalaleev/received_events","type":"User","site_admin":false},"assignees":[{"login":"afalaleev","id":27198658,"avatar_url":"https://avatars0.githubusercontent.com/u/27198658?v=4","gravatar_id":"","url":"https://api.github.com/users/afalaleev","html_url":"https://github.com/afalaleev","followers_url":"https://api.github.com/users/afalaleev/followers","following_url":"https://api.github.com/users/afalaleev/following{/other_user}","gists_url":"https://api.github.com/users/afalaleev/gists{/gist_id}","starred_url":"https://api.github.com/users/afalaleev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afalaleev/subscriptions","organizations_url":"https://api.github.com/users/afalaleev/orgs","repos_url":"https://api.github.com/users/afalaleev/repos","events_url":"https://api.github.com/users/afalaleev/events{/privacy}","received_events_url":"https://api.github.com/users/afalaleev/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/GolosChain/golos/milestones/16","html_url":"https://github.com/GolosChain/golos/milestone/16","labels_url":"https://api.github.com/repos/GolosChain/golos/milestones/16/labels","id":3257227,"number":16,"title":"0.18.0","description":"","creator":{"login":"marijadia","id":30824714,"avatar_url":"https://avatars3.githubusercontent.com/u/30824714?v=4","gravatar_id":"","url":"https://api.github.com/users/marijadia","html_url":"https://github.com/marijadia","followers_url":"https://api.github.com/users/marijadia/followers","following_url":"https://api.github.com/users/marijadia/following{/other_user}","gists_url":"https://api.github.com/users/marijadia/gists{/gist_id}","starred_url":"https://api.github.com/users/marijadia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marijadia/subscriptions","organizations_url":"https://api.github.com/users/marijadia/orgs","repos_url":"https://api.github.com/users/marijadia/repos","events_url":"https://api.github.com/users/marijadia/events{/privacy}","received_events_url":"https://api.github.com/users/marijadia/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":89,"state":"open","created_at":"2018-04-10T21:02:17Z","updated_at":"2018-05-29T10:51:44Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2018-05-23T11:58:59Z","updated_at":"2018-05-29T10:51:44Z","closed_at":"2018-05-29T10:51:44Z","author_association":"NONE","body":"**Adding foreign (not required to sign) key approval makes proposal impossible to apply until that key approval removed**\r\n\r\n```\r\nbegin_builder_transaction\r\nadd_operation_to_builder_transaction 0 [\"transfer\", {\"from\":\"alice\", \"to\":\"bob\", \"amount\":\"1.000 GOLOS\", \"memo\":\"to bob\"}]\r\nadd_operation_to_builder_transaction 0 [\"transfer\", {\"from\":\"bob\", \"to\":\"alice\", \"amount\":\"1.000 GOLOS\", \"memo\":\"to alice\"}]\r\npropose_builder_transaction 0 alice test671 \"\" \"2018-05-23T15:50:00\" \"1970-01-01T00:00:00\" true\r\nget_proposed_transactions alice 0 10\r\n```\r\nHere `required_active_approvals` field contains `[\"alice\", \"bob\"]`.\r\nLet's add alice's approval and public key of initminer:\r\n```\r\napprove_proposal alice test671 {\"active_approvals_to_add\":[\"alice\"], \"key_approvals_to_add\":[\"GLS58g5rWYS3XFTuGDSxLVwiBiPLoAyCZgn6aB9Ueh8Hj5qwQA3r6\"]} true\r\nget_proposed_transactions alice 0 10\r\n```\r\nAnd add required bob's approval:\r\n```\r\napprove_proposal alice test671 {\"active_approvals_to_add\":[\"bob\"]} true\r\nget_proposed_transactions alice 0 10\r\n```\r\n\r\n**Expected result:** proposal applied successfully.\r\n\r\n**Actual result:** proposal still exists and waiting approvals, ignoring that\r\n`\"required_active_approvals\": [\"bob\",\"alice\"],`, `\"available_active_approvals\": [\"bob\",\"alice\"]`\r\n\r\n***\r\n*Note: Proposal will be applied on initminer public key remove:  \r\n`approve_proposal alice test671 {\"key_approvals_to_remove\":[\"GLS58g5rWYS3XFTuGDSxLVwiBiPLoAyCZgn6aB9Ueh8Hj5qwQA3r6\"]} true`*\r\n***\r\n\r\nRef: #542, #633 \r\n"}}
{"actor":{"display_login":"afalaleev"}}