{"action":"created","comment":{"url":"https://api.github.com/repos/flang-compiler/f18/pulls/comments/207684152","pull_request_review_id":143354923,"id":207684152,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzY4NDE1Mg==","diff_hunk":"@@ -471,7 +472,13 @@ template<int KIND>\n auto RealExpr<KIND>::IntPower::FoldScalar(FoldingContext &context,","path":"lib/evaluate/expression.cc","position":181,"original_position":9,"commit_id":"34e07d6fa90fbf364accdafeee341dee6de19b40","original_commit_id":"5311a892b5af3523770e9c74fcc6272600aa5732","user":{"login":"klausler","id":35819229,"node_id":"MDQ6VXNlcjM1ODE5MjI5","avatar_url":"https://avatars1.githubusercontent.com/u/35819229?v=4","gravatar_id":"","url":"https://api.github.com/users/klausler","html_url":"https://github.com/klausler","followers_url":"https://api.github.com/users/klausler/followers","following_url":"https://api.github.com/users/klausler/following{/other_user}","gists_url":"https://api.github.com/users/klausler/gists{/gist_id}","starred_url":"https://api.github.com/users/klausler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klausler/subscriptions","organizations_url":"https://api.github.com/users/klausler/orgs","repos_url":"https://api.github.com/users/klausler/repos","events_url":"https://api.github.com/users/klausler/events{/privacy}","received_events_url":"https://api.github.com/users/klausler/received_events","type":"User","site_admin":false},"body":"This is an outlined member function definition whose result type uses the name of a type declared in the class.  Written without `auto`, the result type would have to be something like `std::optional<typename RealExpr<KIND>::Scalar>`.  This is exactly the situation in which the \"unless...\" exceptional language in the style guide is meant to apply.","created_at":"2018-08-03T22:47:17Z","updated_at":"2018-08-03T22:47:17Z","html_url":"https://github.com/flang-compiler/f18/pull/162#discussion_r207684152","pull_request_url":"https://api.github.com/repos/flang-compiler/f18/pulls/162","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/flang-compiler/f18/pulls/comments/207684152"},"html":{"href":"https://github.com/flang-compiler/f18/pull/162#discussion_r207684152"},"pull_request":{"href":"https://api.github.com/repos/flang-compiler/f18/pulls/162"}},"in_reply_to_id":207681520},"pull_request":{"url":"https://api.github.com/repos/flang-compiler/f18/pulls/162","id":206143243,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MTQzMjQz","html_url":"https://github.com/flang-compiler/f18/pull/162","diff_url":"https://github.com/flang-compiler/f18/pull/162.diff","patch_url":"https://github.com/flang-compiler/f18/pull/162.patch","issue_url":"https://api.github.com/repos/flang-compiler/f18/issues/162","number":162,"state":"open","locked":false,"title":"Roll up work on folding, descriptors, runtime, RESHAPE","user":{"login":"klausler","id":35819229,"node_id":"MDQ6VXNlcjM1ODE5MjI5","avatar_url":"https://avatars1.githubusercontent.com/u/35819229?v=4","gravatar_id":"","url":"https://api.github.com/users/klausler","html_url":"https://github.com/klausler","followers_url":"https://api.github.com/users/klausler/followers","following_url":"https://api.github.com/users/klausler/following{/other_user}","gists_url":"https://api.github.com/users/klausler/gists{/gist_id}","starred_url":"https://api.github.com/users/klausler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klausler/subscriptions","organizations_url":"https://api.github.com/users/klausler/orgs","repos_url":"https://api.github.com/users/klausler/repos","events_url":"https://api.github.com/users/klausler/events{/privacy}","received_events_url":"https://api.github.com/users/klausler/received_events","type":"User","site_admin":false},"body":"Some disconnected changes here related to evaluation and execution.  The C++ interface to the ISO standard descriptor is now is much better shape, and can serve to implement a working RESHAPE intrinsic.  More to come, but it was past time to checkpoint and merge this work area.\r\n\r\nAs a readability improvement (I think), I've replaced many instances of `return {};` with `return std::nullopt;` in contexts where the function's type is an instantiation of `std::optional<>`.\r\n\r\nAlso, a GNU C++ compiler bug workaround in `lib/parser/basic-parsers.h` is no longer needed with GNU 8.2.0, and the conditional compilation tests were adjusted accordingly.","created_at":"2018-08-03T21:29:31Z","updated_at":"2018-08-03T22:47:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0757cd33b4f9d2b22a971ce98a66e57ee839b80c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sscalpone","id":504306,"node_id":"MDQ6VXNlcjUwNDMwNg==","avatar_url":"https://avatars0.githubusercontent.com/u/504306?v=4","gravatar_id":"","url":"https://api.github.com/users/sscalpone","html_url":"https://github.com/sscalpone","followers_url":"https://api.github.com/users/sscalpone/followers","following_url":"https://api.github.com/users/sscalpone/following{/other_user}","gists_url":"https://api.github.com/users/sscalpone/gists{/gist_id}","starred_url":"https://api.github.com/users/sscalpone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sscalpone/subscriptions","organizations_url":"https://api.github.com/users/sscalpone/orgs","repos_url":"https://api.github.com/users/sscalpone/repos","events_url":"https://api.github.com/users/sscalpone/events{/privacy}","received_events_url":"https://api.github.com/users/sscalpone/received_events","type":"User","site_admin":false},{"login":"schweitzpgi","id":22080509,"node_id":"MDQ6VXNlcjIyMDgwNTA5","avatar_url":"https://avatars0.githubusercontent.com/u/22080509?v=4","gravatar_id":"","url":"https://api.github.com/users/schweitzpgi","html_url":"https://github.com/schweitzpgi","followers_url":"https://api.github.com/users/schweitzpgi/followers","following_url":"https://api.github.com/users/schweitzpgi/following{/other_user}","gists_url":"https://api.github.com/users/schweitzpgi/gists{/gist_id}","starred_url":"https://api.github.com/users/schweitzpgi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schweitzpgi/subscriptions","organizations_url":"https://api.github.com/users/schweitzpgi/orgs","repos_url":"https://api.github.com/users/schweitzpgi/repos","events_url":"https://api.github.com/users/schweitzpgi/events{/privacy}","received_events_url":"https://api.github.com/users/schweitzpgi/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/flang-compiler/f18/pulls/162/commits","review_comments_url":"https://api.github.com/repos/flang-compiler/f18/pulls/162/comments","review_comment_url":"https://api.github.com/repos/flang-compiler/f18/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flang-compiler/f18/issues/162/comments","statuses_url":"https://api.github.com/repos/flang-compiler/f18/statuses/34e07d6fa90fbf364accdafeee341dee6de19b40","head":{"label":"flang-compiler:pmk0","ref":"pmk0","sha":"34e07d6fa90fbf364accdafeee341dee6de19b40","user":{"login":"flang-compiler","id":27519978,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NTE5OTc4","avatar_url":"https://avatars2.githubusercontent.com/u/27519978?v=4","gravatar_id":"","url":"https://api.github.com/users/flang-compiler","html_url":"https://github.com/flang-compiler","followers_url":"https://api.github.com/users/flang-compiler/followers","following_url":"https://api.github.com/users/flang-compiler/following{/other_user}","gists_url":"https://api.github.com/users/flang-compiler/gists{/gist_id}","starred_url":"https://api.github.com/users/flang-compiler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flang-compiler/subscriptions","organizations_url":"https://api.github.com/users/flang-compiler/orgs","repos_url":"https://api.github.com/users/flang-compiler/repos","events_url":"https://api.github.com/users/flang-compiler/events{/privacy}","received_events_url":"https://api.github.com/users/flang-compiler/received_events","type":"Organization","site_admin":false},"repo":{"id":118970343,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg5NzAzNDM=","name":"f18","full_name":"flang-compiler/f18","owner":{"login":"flang-compiler","id":27519978,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NTE5OTc4","avatar_url":"https://avatars2.githubusercontent.com/u/27519978?v=4","gravatar_id":"","url":"https://api.github.com/users/flang-compiler","html_url":"https://github.com/flang-compiler","followers_url":"https://api.github.com/users/flang-compiler/followers","following_url":"https://api.github.com/users/flang-compiler/following{/other_user}","gists_url":"https://api.github.com/users/flang-compiler/gists{/gist_id}","starred_url":"https://api.github.com/users/flang-compiler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flang-compiler/subscriptions","organizations_url":"https://api.github.com/users/flang-compiler/orgs","repos_url":"https://api.github.com/users/flang-compiler/repos","events_url":"https://api.github.com/users/flang-compiler/events{/privacy}","received_events_url":"https://api.github.com/users/flang-compiler/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flang-compiler/f18","description":"F18 is a front-end for Fortran intended to replace the existing front-end in the Flang compiler","fork":false,"url":"https://api.github.com/repos/flang-compiler/f18","forks_url":"https://api.github.com/repos/flang-compiler/f18/forks","keys_url":"https://api.github.com/repos/flang-compiler/f18/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flang-compiler/f18/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flang-compiler/f18/teams","hooks_url":"https://api.github.com/repos/flang-compiler/f18/hooks","issue_events_url":"https://api.github.com/repos/flang-compiler/f18/issues/events{/number}","events_url":"https://api.github.com/repos/flang-compiler/f18/events","assignees_url":"https://api.github.com/repos/flang-compiler/f18/assignees{/user}","branches_url":"https://api.github.com/repos/flang-compiler/f18/branches{/branch}","tags_url":"https://api.github.com/repos/flang-compiler/f18/tags","blobs_url":"https://api.github.com/repos/flang-compiler/f18/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flang-compiler/f18/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flang-compiler/f18/git/refs{/sha}","trees_url":"https://api.github.com/repos/flang-compiler/f18/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flang-compiler/f18/statuses/{sha}","languages_url":"https://api.github.com/repos/flang-compiler/f18/languages","stargazers_url":"https://api.github.com/repos/flang-compiler/f18/stargazers","contributors_url":"https://api.github.com/repos/flang-compiler/f18/contributors","subscribers_url":"https://api.github.com/repos/flang-compiler/f18/subscribers","subscription_url":"https://api.github.com/repos/flang-compiler/f18/subscription","commits_url":"https://api.github.com/repos/flang-compiler/f18/commits{/sha}","git_commits_url":"https://api.github.com/repos/flang-compiler/f18/git/commits{/sha}","comments_url":"https://api.github.com/repos/flang-compiler/f18/comments{/number}","issue_comment_url":"https://api.github.com/repos/flang-compiler/f18/issues/comments{/number}","contents_url":"https://api.github.com/repos/flang-compiler/f18/contents/{+path}","compare_url":"https://api.github.com/repos/flang-compiler/f18/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flang-compiler/f18/merges","archive_url":"https://api.github.com/repos/flang-compiler/f18/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flang-compiler/f18/downloads","issues_url":"https://api.github.com/repos/flang-compiler/f18/issues{/number}","pulls_url":"https://api.github.com/repos/flang-compiler/f18/pulls{/number}","milestones_url":"https://api.github.com/repos/flang-compiler/f18/milestones{/number}","notifications_url":"https://api.github.com/repos/flang-compiler/f18/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flang-compiler/f18/labels{/name}","releases_url":"https://api.github.com/repos/flang-compiler/f18/releases{/id}","deployments_url":"https://api.github.com/repos/flang-compiler/f18/deployments","created_at":"2018-01-25T21:34:19Z","updated_at":"2018-08-03T22:29:15Z","pushed_at":"2018-08-03T22:41:34Z","git_url":"git://github.com/flang-compiler/f18.git","ssh_url":"git@github.com:flang-compiler/f18.git","clone_url":"https://github.com/flang-compiler/f18.git","svn_url":"https://github.com/flang-compiler/f18","homepage":"","size":1924,"stargazers_count":33,"watchers_count":33,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":8,"watchers":33,"default_branch":"master"}},"base":{"label":"flang-compiler:master","ref":"master","sha":"5aedd0d72c5f6352fc40f1a1993f822b4a5f8627","user":{"login":"flang-compiler","id":27519978,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NTE5OTc4","avatar_url":"https://avatars2.githubusercontent.com/u/27519978?v=4","gravatar_id":"","url":"https://api.github.com/users/flang-compiler","html_url":"https://github.com/flang-compiler","followers_url":"https://api.github.com/users/flang-compiler/followers","following_url":"https://api.github.com/users/flang-compiler/following{/other_user}","gists_url":"https://api.github.com/users/flang-compiler/gists{/gist_id}","starred_url":"https://api.github.com/users/flang-compiler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flang-compiler/subscriptions","organizations_url":"https://api.github.com/users/flang-compiler/orgs","repos_url":"https://api.github.com/users/flang-compiler/repos","events_url":"https://api.github.com/users/flang-compiler/events{/privacy}","received_events_url":"https://api.github.com/users/flang-compiler/received_events","type":"Organization","site_admin":false},"repo":{"id":118970343,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg5NzAzNDM=","name":"f18","full_name":"flang-compiler/f18","owner":{"login":"flang-compiler","id":27519978,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NTE5OTc4","avatar_url":"https://avatars2.githubusercontent.com/u/27519978?v=4","gravatar_id":"","url":"https://api.github.com/users/flang-compiler","html_url":"https://github.com/flang-compiler","followers_url":"https://api.github.com/users/flang-compiler/followers","following_url":"https://api.github.com/users/flang-compiler/following{/other_user}","gists_url":"https://api.github.com/users/flang-compiler/gists{/gist_id}","starred_url":"https://api.github.com/users/flang-compiler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flang-compiler/subscriptions","organizations_url":"https://api.github.com/users/flang-compiler/orgs","repos_url":"https://api.github.com/users/flang-compiler/repos","events_url":"https://api.github.com/users/flang-compiler/events{/privacy}","received_events_url":"https://api.github.com/users/flang-compiler/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flang-compiler/f18","description":"F18 is a front-end for Fortran intended to replace the existing front-end in the Flang compiler","fork":false,"url":"https://api.github.com/repos/flang-compiler/f18","forks_url":"https://api.github.com/repos/flang-compiler/f18/forks","keys_url":"https://api.github.com/repos/flang-compiler/f18/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flang-compiler/f18/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flang-compiler/f18/teams","hooks_url":"https://api.github.com/repos/flang-compiler/f18/hooks","issue_events_url":"https://api.github.com/repos/flang-compiler/f18/issues/events{/number}","events_url":"https://api.github.com/repos/flang-compiler/f18/events","assignees_url":"https://api.github.com/repos/flang-compiler/f18/assignees{/user}","branches_url":"https://api.github.com/repos/flang-compiler/f18/branches{/branch}","tags_url":"https://api.github.com/repos/flang-compiler/f18/tags","blobs_url":"https://api.github.com/repos/flang-compiler/f18/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flang-compiler/f18/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flang-compiler/f18/git/refs{/sha}","trees_url":"https://api.github.com/repos/flang-compiler/f18/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flang-compiler/f18/statuses/{sha}","languages_url":"https://api.github.com/repos/flang-compiler/f18/languages","stargazers_url":"https://api.github.com/repos/flang-compiler/f18/stargazers","contributors_url":"https://api.github.com/repos/flang-compiler/f18/contributors","subscribers_url":"https://api.github.com/repos/flang-compiler/f18/subscribers","subscription_url":"https://api.github.com/repos/flang-compiler/f18/subscription","commits_url":"https://api.github.com/repos/flang-compiler/f18/commits{/sha}","git_commits_url":"https://api.github.com/repos/flang-compiler/f18/git/commits{/sha}","comments_url":"https://api.github.com/repos/flang-compiler/f18/comments{/number}","issue_comment_url":"https://api.github.com/repos/flang-compiler/f18/issues/comments{/number}","contents_url":"https://api.github.com/repos/flang-compiler/f18/contents/{+path}","compare_url":"https://api.github.com/repos/flang-compiler/f18/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flang-compiler/f18/merges","archive_url":"https://api.github.com/repos/flang-compiler/f18/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flang-compiler/f18/downloads","issues_url":"https://api.github.com/repos/flang-compiler/f18/issues{/number}","pulls_url":"https://api.github.com/repos/flang-compiler/f18/pulls{/number}","milestones_url":"https://api.github.com/repos/flang-compiler/f18/milestones{/number}","notifications_url":"https://api.github.com/repos/flang-compiler/f18/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flang-compiler/f18/labels{/name}","releases_url":"https://api.github.com/repos/flang-compiler/f18/releases{/id}","deployments_url":"https://api.github.com/repos/flang-compiler/f18/deployments","created_at":"2018-01-25T21:34:19Z","updated_at":"2018-08-03T22:29:15Z","pushed_at":"2018-08-03T22:41:34Z","git_url":"git://github.com/flang-compiler/f18.git","ssh_url":"git@github.com:flang-compiler/f18.git","clone_url":"https://github.com/flang-compiler/f18.git","svn_url":"https://github.com/flang-compiler/f18","homepage":"","size":1924,"stargazers_count":33,"watchers_count":33,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":8,"watchers":33,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flang-compiler/f18/pulls/162"},"html":{"href":"https://github.com/flang-compiler/f18/pull/162"},"issue":{"href":"https://api.github.com/repos/flang-compiler/f18/issues/162"},"comments":{"href":"https://api.github.com/repos/flang-compiler/f18/issues/162/comments"},"review_comments":{"href":"https://api.github.com/repos/flang-compiler/f18/pulls/162/comments"},"review_comment":{"href":"https://api.github.com/repos/flang-compiler/f18/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flang-compiler/f18/pulls/162/commits"},"statuses":{"href":"https://api.github.com/repos/flang-compiler/f18/statuses/34e07d6fa90fbf364accdafeee341dee6de19b40"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"klausler"}}