{"action":"created","comment":{"url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments/196081565","pull_request_review_id":129566518,"id":196081565,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjA4MTU2NQ==","diff_hunk":"@@ -11,7 +11,7 @@ include mk/config.mk\n include core/arch/$(ARCH)/$(ARCH).mk\n \n PLATFORM_$(PLATFORM) := y\n-PLATFORM_FLAVOR_$(PLATFORM_FLAVOR) := y\n+PLATFORM_FLAVOR_$(subst -,_,$(PLATFORM_FLAVOR)):= y","path":"core/core.mk","position":5,"original_position":5,"commit_id":"7480b65548ba861526cb21be6e1491c0a1d3a169","original_commit_id":"e16a8a14c22103d874fd2942f787624511ceef1d","user":{"login":"etienne-lms","id":19990310,"node_id":"MDQ6VXNlcjE5OTkwMzEw","avatar_url":"https://avatars3.githubusercontent.com/u/19990310?v=4","gravatar_id":"","url":"https://api.github.com/users/etienne-lms","html_url":"https://github.com/etienne-lms","followers_url":"https://api.github.com/users/etienne-lms/followers","following_url":"https://api.github.com/users/etienne-lms/following{/other_user}","gists_url":"https://api.github.com/users/etienne-lms/gists{/gist_id}","starred_url":"https://api.github.com/users/etienne-lms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etienne-lms/subscriptions","organizations_url":"https://api.github.com/users/etienne-lms/orgs","repos_url":"https://api.github.com/users/etienne-lms/repos","events_url":"https://api.github.com/users/etienne-lms/events{/privacy}","received_events_url":"https://api.github.com/users/etienne-lms/received_events","type":"User","site_admin":false},"body":"Ok, let's keep it simple.\r\nI will discard my change.","created_at":"2018-06-18T13:42:49Z","updated_at":"2018-06-18T13:43:03Z","html_url":"https://github.com/OP-TEE/optee_os/pull/2400#discussion_r196081565","pull_request_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/2400","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments/196081565"},"html":{"href":"https://github.com/OP-TEE/optee_os/pull/2400#discussion_r196081565"},"pull_request":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/2400"}},"in_reply_to_id":196004609},"pull_request":{"url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/2400","id":195447425,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1NDQ3NDI1","html_url":"https://github.com/OP-TEE/optee_os/pull/2400","diff_url":"https://github.com/OP-TEE/optee_os/pull/2400.diff","patch_url":"https://github.com/OP-TEE/optee_os/pull/2400.patch","issue_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/2400","number":2400,"state":"open","locked":false,"title":"introduce platform stm32mp1","user":{"login":"etienne-lms","id":19990310,"node_id":"MDQ6VXNlcjE5OTkwMzEw","avatar_url":"https://avatars3.githubusercontent.com/u/19990310?v=4","gravatar_id":"","url":"https://api.github.com/users/etienne-lms","html_url":"https://github.com/etienne-lms","followers_url":"https://api.github.com/users/etienne-lms/followers","following_url":"https://api.github.com/users/etienne-lms/following{/other_user}","gists_url":"https://api.github.com/users/etienne-lms/gists{/gist_id}","starred_url":"https://api.github.com/users/etienne-lms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etienne-lms/subscriptions","organizations_url":"https://api.github.com/users/etienne-lms/orgs","repos_url":"https://api.github.com/users/etienne-lms/repos","events_url":"https://api.github.com/users/etienne-lms/events{/privacy}","received_events_url":"https://api.github.com/users/etienne-lms/received_events","type":"User","site_admin":false},"body":"Introduce platform stm32mp1 with board stm32mp1-stm32mp157c-ev1 based on stm32mp1 SoC family integrating Arm Cortex-A7 technology. In its default configuration, stm32mp1 OP-TEE core operates in a 256kB secure RAM with pager support enabled.\r\n\r\nPlatform flavor identifiers for the stm32mp1 do contain a hyphen, as the default stm32mp1-stm32mp157c-ev1. For optee_os to support hyphens inside platform flavor, the P-R includes a change in the core make script.","created_at":"2018-06-18T08:01:32Z","updated_at":"2018-06-18T13:43:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb1d313e8048730ff82bb751092802068320bce9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/2400/commits","review_comments_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/2400/comments","review_comment_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/2400/comments","statuses_url":"https://api.github.com/repos/OP-TEE/optee_os/statuses/7480b65548ba861526cb21be6e1491c0a1d3a169","head":{"label":"etienne-lms:stm","ref":"stm","sha":"7480b65548ba861526cb21be6e1491c0a1d3a169","user":{"login":"etienne-lms","id":19990310,"node_id":"MDQ6VXNlcjE5OTkwMzEw","avatar_url":"https://avatars3.githubusercontent.com/u/19990310?v=4","gravatar_id":"","url":"https://api.github.com/users/etienne-lms","html_url":"https://github.com/etienne-lms","followers_url":"https://api.github.com/users/etienne-lms/followers","following_url":"https://api.github.com/users/etienne-lms/following{/other_user}","gists_url":"https://api.github.com/users/etienne-lms/gists{/gist_id}","starred_url":"https://api.github.com/users/etienne-lms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etienne-lms/subscriptions","organizations_url":"https://api.github.com/users/etienne-lms/orgs","repos_url":"https://api.github.com/users/etienne-lms/repos","events_url":"https://api.github.com/users/etienne-lms/events{/privacy}","received_events_url":"https://api.github.com/users/etienne-lms/received_events","type":"User","site_admin":false},"repo":{"id":62886797,"node_id":"MDEwOlJlcG9zaXRvcnk2Mjg4Njc5Nw==","name":"optee_os","full_name":"etienne-lms/optee_os","owner":{"login":"etienne-lms","id":19990310,"node_id":"MDQ6VXNlcjE5OTkwMzEw","avatar_url":"https://avatars3.githubusercontent.com/u/19990310?v=4","gravatar_id":"","url":"https://api.github.com/users/etienne-lms","html_url":"https://github.com/etienne-lms","followers_url":"https://api.github.com/users/etienne-lms/followers","following_url":"https://api.github.com/users/etienne-lms/following{/other_user}","gists_url":"https://api.github.com/users/etienne-lms/gists{/gist_id}","starred_url":"https://api.github.com/users/etienne-lms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etienne-lms/subscriptions","organizations_url":"https://api.github.com/users/etienne-lms/orgs","repos_url":"https://api.github.com/users/etienne-lms/repos","events_url":"https://api.github.com/users/etienne-lms/events{/privacy}","received_events_url":"https://api.github.com/users/etienne-lms/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/etienne-lms/optee_os","description":"Trusted side of the TEE","fork":true,"url":"https://api.github.com/repos/etienne-lms/optee_os","forks_url":"https://api.github.com/repos/etienne-lms/optee_os/forks","keys_url":"https://api.github.com/repos/etienne-lms/optee_os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/etienne-lms/optee_os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/etienne-lms/optee_os/teams","hooks_url":"https://api.github.com/repos/etienne-lms/optee_os/hooks","issue_events_url":"https://api.github.com/repos/etienne-lms/optee_os/issues/events{/number}","events_url":"https://api.github.com/repos/etienne-lms/optee_os/events","assignees_url":"https://api.github.com/repos/etienne-lms/optee_os/assignees{/user}","branches_url":"https://api.github.com/repos/etienne-lms/optee_os/branches{/branch}","tags_url":"https://api.github.com/repos/etienne-lms/optee_os/tags","blobs_url":"https://api.github.com/repos/etienne-lms/optee_os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/etienne-lms/optee_os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/etienne-lms/optee_os/git/refs{/sha}","trees_url":"https://api.github.com/repos/etienne-lms/optee_os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/etienne-lms/optee_os/statuses/{sha}","languages_url":"https://api.github.com/repos/etienne-lms/optee_os/languages","stargazers_url":"https://api.github.com/repos/etienne-lms/optee_os/stargazers","contributors_url":"https://api.github.com/repos/etienne-lms/optee_os/contributors","subscribers_url":"https://api.github.com/repos/etienne-lms/optee_os/subscribers","subscription_url":"https://api.github.com/repos/etienne-lms/optee_os/subscription","commits_url":"https://api.github.com/repos/etienne-lms/optee_os/commits{/sha}","git_commits_url":"https://api.github.com/repos/etienne-lms/optee_os/git/commits{/sha}","comments_url":"https://api.github.com/repos/etienne-lms/optee_os/comments{/number}","issue_comment_url":"https://api.github.com/repos/etienne-lms/optee_os/issues/comments{/number}","contents_url":"https://api.github.com/repos/etienne-lms/optee_os/contents/{+path}","compare_url":"https://api.github.com/repos/etienne-lms/optee_os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/etienne-lms/optee_os/merges","archive_url":"https://api.github.com/repos/etienne-lms/optee_os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/etienne-lms/optee_os/downloads","issues_url":"https://api.github.com/repos/etienne-lms/optee_os/issues{/number}","pulls_url":"https://api.github.com/repos/etienne-lms/optee_os/pulls{/number}","milestones_url":"https://api.github.com/repos/etienne-lms/optee_os/milestones{/number}","notifications_url":"https://api.github.com/repos/etienne-lms/optee_os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/etienne-lms/optee_os/labels{/name}","releases_url":"https://api.github.com/repos/etienne-lms/optee_os/releases{/id}","deployments_url":"https://api.github.com/repos/etienne-lms/optee_os/deployments","created_at":"2016-07-08T12:24:05Z","updated_at":"2018-04-27T15:20:12Z","pushed_at":"2018-06-18T10:02:59Z","git_url":"git://github.com/etienne-lms/optee_os.git","ssh_url":"git@github.com:etienne-lms/optee_os.git","clone_url":"https://github.com/etienne-lms/optee_os.git","svn_url":"https://github.com/etienne-lms/optee_os","homepage":null,"size":14233,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"OP-TEE:master","ref":"master","sha":"ea6cd9133a2627a0973855fa4c94bb02079e967e","user":{"login":"OP-TEE","id":7488961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0ODg5NjE=","avatar_url":"https://avatars1.githubusercontent.com/u/7488961?v=4","gravatar_id":"","url":"https://api.github.com/users/OP-TEE","html_url":"https://github.com/OP-TEE","followers_url":"https://api.github.com/users/OP-TEE/followers","following_url":"https://api.github.com/users/OP-TEE/following{/other_user}","gists_url":"https://api.github.com/users/OP-TEE/gists{/gist_id}","starred_url":"https://api.github.com/users/OP-TEE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OP-TEE/subscriptions","organizations_url":"https://api.github.com/users/OP-TEE/orgs","repos_url":"https://api.github.com/users/OP-TEE/repos","events_url":"https://api.github.com/users/OP-TEE/events{/privacy}","received_events_url":"https://api.github.com/users/OP-TEE/received_events","type":"Organization","site_admin":false},"repo":{"id":20193261,"node_id":"MDEwOlJlcG9zaXRvcnkyMDE5MzI2MQ==","name":"optee_os","full_name":"OP-TEE/optee_os","owner":{"login":"OP-TEE","id":7488961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc0ODg5NjE=","avatar_url":"https://avatars1.githubusercontent.com/u/7488961?v=4","gravatar_id":"","url":"https://api.github.com/users/OP-TEE","html_url":"https://github.com/OP-TEE","followers_url":"https://api.github.com/users/OP-TEE/followers","following_url":"https://api.github.com/users/OP-TEE/following{/other_user}","gists_url":"https://api.github.com/users/OP-TEE/gists{/gist_id}","starred_url":"https://api.github.com/users/OP-TEE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OP-TEE/subscriptions","organizations_url":"https://api.github.com/users/OP-TEE/orgs","repos_url":"https://api.github.com/users/OP-TEE/repos","events_url":"https://api.github.com/users/OP-TEE/events{/privacy}","received_events_url":"https://api.github.com/users/OP-TEE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OP-TEE/optee_os","description":"Trusted side of the TEE","fork":false,"url":"https://api.github.com/repos/OP-TEE/optee_os","forks_url":"https://api.github.com/repos/OP-TEE/optee_os/forks","keys_url":"https://api.github.com/repos/OP-TEE/optee_os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OP-TEE/optee_os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OP-TEE/optee_os/teams","hooks_url":"https://api.github.com/repos/OP-TEE/optee_os/hooks","issue_events_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/events{/number}","events_url":"https://api.github.com/repos/OP-TEE/optee_os/events","assignees_url":"https://api.github.com/repos/OP-TEE/optee_os/assignees{/user}","branches_url":"https://api.github.com/repos/OP-TEE/optee_os/branches{/branch}","tags_url":"https://api.github.com/repos/OP-TEE/optee_os/tags","blobs_url":"https://api.github.com/repos/OP-TEE/optee_os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OP-TEE/optee_os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OP-TEE/optee_os/git/refs{/sha}","trees_url":"https://api.github.com/repos/OP-TEE/optee_os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OP-TEE/optee_os/statuses/{sha}","languages_url":"https://api.github.com/repos/OP-TEE/optee_os/languages","stargazers_url":"https://api.github.com/repos/OP-TEE/optee_os/stargazers","contributors_url":"https://api.github.com/repos/OP-TEE/optee_os/contributors","subscribers_url":"https://api.github.com/repos/OP-TEE/optee_os/subscribers","subscription_url":"https://api.github.com/repos/OP-TEE/optee_os/subscription","commits_url":"https://api.github.com/repos/OP-TEE/optee_os/commits{/sha}","git_commits_url":"https://api.github.com/repos/OP-TEE/optee_os/git/commits{/sha}","comments_url":"https://api.github.com/repos/OP-TEE/optee_os/comments{/number}","issue_comment_url":"https://api.github.com/repos/OP-TEE/optee_os/issues/comments{/number}","contents_url":"https://api.github.com/repos/OP-TEE/optee_os/contents/{+path}","compare_url":"https://api.github.com/repos/OP-TEE/optee_os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OP-TEE/optee_os/merges","archive_url":"https://api.github.com/repos/OP-TEE/optee_os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OP-TEE/optee_os/downloads","issues_url":"https://api.github.com/repos/OP-TEE/optee_os/issues{/number}","pulls_url":"https://api.github.com/repos/OP-TEE/optee_os/pulls{/number}","milestones_url":"https://api.github.com/repos/OP-TEE/optee_os/milestones{/number}","notifications_url":"https://api.github.com/repos/OP-TEE/optee_os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OP-TEE/optee_os/labels{/name}","releases_url":"https://api.github.com/repos/OP-TEE/optee_os/releases{/id}","deployments_url":"https://api.github.com/repos/OP-TEE/optee_os/deployments","created_at":"2014-05-26T17:18:57Z","updated_at":"2018-06-18T08:01:20Z","pushed_at":"2018-06-18T10:03:01Z","git_url":"git://github.com/OP-TEE/optee_os.git","ssh_url":"git@github.com:OP-TEE/optee_os.git","clone_url":"https://github.com/OP-TEE/optee_os.git","svn_url":"https://github.com/OP-TEE/optee_os","homepage":null,"size":13894,"stargazers_count":414,"watchers_count":414,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":351,"mirror_url":null,"archived":false,"open_issues_count":193,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":351,"open_issues":193,"watchers":414,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/2400"},"html":{"href":"https://github.com/OP-TEE/optee_os/pull/2400"},"issue":{"href":"https://api.github.com/repos/OP-TEE/optee_os/issues/2400"},"comments":{"href":"https://api.github.com/repos/OP-TEE/optee_os/issues/2400/comments"},"review_comments":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/2400/comments"},"review_comment":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OP-TEE/optee_os/pulls/2400/commits"},"statuses":{"href":"https://api.github.com/repos/OP-TEE/optee_os/statuses/7480b65548ba861526cb21be6e1491c0a1d3a169"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"etienne-lms"}}