{"action":"created","comment":{"url":"https://api.github.com/repos/ding2/ding2/pulls/comments/223673471","pull_request_review_id":162796467,"id":223673471,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzY3MzQ3MQ==","diff_hunk":"@@ -95,21 +96,28 @@ function template_preprocess_ding_sharer(&$variables) {\n  */\n function theme_ding_sharer($variables) {\n   $out = '';\n+  $anchor_class = '';\n \n-  if (!empty($variables['label'])) {\n+  if (!empty($variables['label']) && $variables['type'] == 'normal') {\n     $out .= '<div class=\"label\">' . $variables['label'] . '</div>';\n   }\n \n   $out .= '<div class=\"share-buttons\">';\n   foreach ($variables['communities'] as $community => $text) {\n-    $out .= l(\n-      $text,\n-      '#',\n-      array(\n-        'attributes' => array('class' => array($community . '-share')),\n-        'external' => TRUE,\n-      )\n-    );\n+    if ($text !== '0') {","path":"modules/p2/ding_sharer/ding_sharer.module","position":29,"original_position":29,"commit_id":"9444088b70a133f4d8410979cdce6dbdebcaff80","original_commit_id":"9444088b70a133f4d8410979cdce6dbdebcaff80","user":{"login":"kasperg","id":73966,"node_id":"MDQ6VXNlcjczOTY2","avatar_url":"https://avatars2.githubusercontent.com/u/73966?v=4","gravatar_id":"","url":"https://api.github.com/users/kasperg","html_url":"https://github.com/kasperg","followers_url":"https://api.github.com/users/kasperg/followers","following_url":"https://api.github.com/users/kasperg/following{/other_user}","gists_url":"https://api.github.com/users/kasperg/gists{/gist_id}","starred_url":"https://api.github.com/users/kasperg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kasperg/subscriptions","organizations_url":"https://api.github.com/users/kasperg/orgs","repos_url":"https://api.github.com/users/kasperg/repos","events_url":"https://api.github.com/users/kasperg/events{/privacy}","received_events_url":"https://api.github.com/users/kasperg/received_events","type":"User","site_admin":false},"body":"Again this comparison with the string `0`. Please avoid this by irrelevant communities beforehand.","created_at":"2018-10-09T12:12:50Z","updated_at":"2018-10-09T12:33:14Z","html_url":"https://github.com/ding2/ding2/pull/1213#discussion_r223673471","pull_request_url":"https://api.github.com/repos/ding2/ding2/pulls/1213","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ding2/ding2/pulls/comments/223673471"},"html":{"href":"https://github.com/ding2/ding2/pull/1213#discussion_r223673471"},"pull_request":{"href":"https://api.github.com/repos/ding2/ding2/pulls/1213"}}},"pull_request":{"url":"https://api.github.com/repos/ding2/ding2/pulls/1213","id":221117624,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxMTE3NjI0","html_url":"https://github.com/ding2/ding2/pull/1213","diff_url":"https://github.com/ding2/ding2/pull/1213.diff","patch_url":"https://github.com/ding2/ding2/pull/1213.patch","issue_url":"https://api.github.com/repos/ding2/ding2/issues/1213","number":1213,"state":"open","locked":false,"title":"2697: Remake ding lists","user":{"login":"b14sha","id":30495061,"node_id":"MDQ6VXNlcjMwNDk1MDYx","avatar_url":"https://avatars0.githubusercontent.com/u/30495061?v=4","gravatar_id":"","url":"https://api.github.com/users/b14sha","html_url":"https://github.com/b14sha","followers_url":"https://api.github.com/users/b14sha/followers","following_url":"https://api.github.com/users/b14sha/following{/other_user}","gists_url":"https://api.github.com/users/b14sha/gists{/gist_id}","starred_url":"https://api.github.com/users/b14sha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b14sha/subscriptions","organizations_url":"https://api.github.com/users/b14sha/orgs","repos_url":"https://api.github.com/users/b14sha/repos","events_url":"https://api.github.com/users/b14sha/events{/privacy}","received_events_url":"https://api.github.com/users/b14sha/received_events","type":"User","site_admin":false},"body":"https://platform.dandigbib.org/issues/2697","created_at":"2018-10-08T13:28:44Z","updated_at":"2018-10-09T12:33:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"906f68e3e444d98c6c147b13ea4758cd77a16a1b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ding2/ding2/pulls/1213/commits","review_comments_url":"https://api.github.com/repos/ding2/ding2/pulls/1213/comments","review_comment_url":"https://api.github.com/repos/ding2/ding2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ding2/ding2/issues/1213/comments","statuses_url":"https://api.github.com/repos/ding2/ding2/statuses/9444088b70a133f4d8410979cdce6dbdebcaff80","head":{"label":"b14:b2697v4","ref":"b2697v4","sha":"9444088b70a133f4d8410979cdce6dbdebcaff80","user":{"login":"b14","id":2855819,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NTU4MTk=","avatar_url":"https://avatars2.githubusercontent.com/u/2855819?v=4","gravatar_id":"","url":"https://api.github.com/users/b14","html_url":"https://github.com/b14","followers_url":"https://api.github.com/users/b14/followers","following_url":"https://api.github.com/users/b14/following{/other_user}","gists_url":"https://api.github.com/users/b14/gists{/gist_id}","starred_url":"https://api.github.com/users/b14/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b14/subscriptions","organizations_url":"https://api.github.com/users/b14/orgs","repos_url":"https://api.github.com/users/b14/repos","events_url":"https://api.github.com/users/b14/events{/privacy}","received_events_url":"https://api.github.com/users/b14/received_events","type":"Organization","site_admin":false},"repo":{"id":55677883,"node_id":"MDEwOlJlcG9zaXRvcnk1NTY3Nzg4Mw==","name":"ding2","full_name":"b14/ding2","private":false,"owner":{"login":"b14","id":2855819,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NTU4MTk=","avatar_url":"https://avatars2.githubusercontent.com/u/2855819?v=4","gravatar_id":"","url":"https://api.github.com/users/b14","html_url":"https://github.com/b14","followers_url":"https://api.github.com/users/b14/followers","following_url":"https://api.github.com/users/b14/following{/other_user}","gists_url":"https://api.github.com/users/b14/gists{/gist_id}","starred_url":"https://api.github.com/users/b14/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b14/subscriptions","organizations_url":"https://api.github.com/users/b14/orgs","repos_url":"https://api.github.com/users/b14/repos","events_url":"https://api.github.com/users/b14/events{/privacy}","received_events_url":"https://api.github.com/users/b14/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/b14/ding2","description":"Ding install profile","fork":true,"url":"https://api.github.com/repos/b14/ding2","forks_url":"https://api.github.com/repos/b14/ding2/forks","keys_url":"https://api.github.com/repos/b14/ding2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/b14/ding2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/b14/ding2/teams","hooks_url":"https://api.github.com/repos/b14/ding2/hooks","issue_events_url":"https://api.github.com/repos/b14/ding2/issues/events{/number}","events_url":"https://api.github.com/repos/b14/ding2/events","assignees_url":"https://api.github.com/repos/b14/ding2/assignees{/user}","branches_url":"https://api.github.com/repos/b14/ding2/branches{/branch}","tags_url":"https://api.github.com/repos/b14/ding2/tags","blobs_url":"https://api.github.com/repos/b14/ding2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/b14/ding2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/b14/ding2/git/refs{/sha}","trees_url":"https://api.github.com/repos/b14/ding2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/b14/ding2/statuses/{sha}","languages_url":"https://api.github.com/repos/b14/ding2/languages","stargazers_url":"https://api.github.com/repos/b14/ding2/stargazers","contributors_url":"https://api.github.com/repos/b14/ding2/contributors","subscribers_url":"https://api.github.com/repos/b14/ding2/subscribers","subscription_url":"https://api.github.com/repos/b14/ding2/subscription","commits_url":"https://api.github.com/repos/b14/ding2/commits{/sha}","git_commits_url":"https://api.github.com/repos/b14/ding2/git/commits{/sha}","comments_url":"https://api.github.com/repos/b14/ding2/comments{/number}","issue_comment_url":"https://api.github.com/repos/b14/ding2/issues/comments{/number}","contents_url":"https://api.github.com/repos/b14/ding2/contents/{+path}","compare_url":"https://api.github.com/repos/b14/ding2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/b14/ding2/merges","archive_url":"https://api.github.com/repos/b14/ding2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/b14/ding2/downloads","issues_url":"https://api.github.com/repos/b14/ding2/issues{/number}","pulls_url":"https://api.github.com/repos/b14/ding2/pulls{/number}","milestones_url":"https://api.github.com/repos/b14/ding2/milestones{/number}","notifications_url":"https://api.github.com/repos/b14/ding2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/b14/ding2/labels{/name}","releases_url":"https://api.github.com/repos/b14/ding2/releases{/id}","deployments_url":"https://api.github.com/repos/b14/ding2/deployments","created_at":"2016-04-07T08:34:26Z","updated_at":"2016-05-26T14:27:47Z","pushed_at":"2018-10-09T07:38:33Z","git_url":"git://github.com/b14/ding2.git","ssh_url":"git@github.com:b14/ding2.git","clone_url":"https://github.com/b14/ding2.git","svn_url":"https://github.com/b14/ding2","homepage":"","size":96233,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"ding2:master","ref":"master","sha":"250a8259ec533b2568f668f26a44268c9adde90e","user":{"login":"ding2","id":564698,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NDY5OA==","avatar_url":"https://avatars0.githubusercontent.com/u/564698?v=4","gravatar_id":"","url":"https://api.github.com/users/ding2","html_url":"https://github.com/ding2","followers_url":"https://api.github.com/users/ding2/followers","following_url":"https://api.github.com/users/ding2/following{/other_user}","gists_url":"https://api.github.com/users/ding2/gists{/gist_id}","starred_url":"https://api.github.com/users/ding2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ding2/subscriptions","organizations_url":"https://api.github.com/users/ding2/orgs","repos_url":"https://api.github.com/users/ding2/repos","events_url":"https://api.github.com/users/ding2/events{/privacy}","received_events_url":"https://api.github.com/users/ding2/received_events","type":"Organization","site_admin":false},"repo":{"id":1266749,"node_id":"MDEwOlJlcG9zaXRvcnkxMjY2NzQ5","name":"ding2","full_name":"ding2/ding2","private":false,"owner":{"login":"ding2","id":564698,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NDY5OA==","avatar_url":"https://avatars0.githubusercontent.com/u/564698?v=4","gravatar_id":"","url":"https://api.github.com/users/ding2","html_url":"https://github.com/ding2","followers_url":"https://api.github.com/users/ding2/followers","following_url":"https://api.github.com/users/ding2/following{/other_user}","gists_url":"https://api.github.com/users/ding2/gists{/gist_id}","starred_url":"https://api.github.com/users/ding2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ding2/subscriptions","organizations_url":"https://api.github.com/users/ding2/orgs","repos_url":"https://api.github.com/users/ding2/repos","events_url":"https://api.github.com/users/ding2/events{/privacy}","received_events_url":"https://api.github.com/users/ding2/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ding2/ding2","description":"Ding install profile","fork":false,"url":"https://api.github.com/repos/ding2/ding2","forks_url":"https://api.github.com/repos/ding2/ding2/forks","keys_url":"https://api.github.com/repos/ding2/ding2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ding2/ding2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ding2/ding2/teams","hooks_url":"https://api.github.com/repos/ding2/ding2/hooks","issue_events_url":"https://api.github.com/repos/ding2/ding2/issues/events{/number}","events_url":"https://api.github.com/repos/ding2/ding2/events","assignees_url":"https://api.github.com/repos/ding2/ding2/assignees{/user}","branches_url":"https://api.github.com/repos/ding2/ding2/branches{/branch}","tags_url":"https://api.github.com/repos/ding2/ding2/tags","blobs_url":"https://api.github.com/repos/ding2/ding2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ding2/ding2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ding2/ding2/git/refs{/sha}","trees_url":"https://api.github.com/repos/ding2/ding2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ding2/ding2/statuses/{sha}","languages_url":"https://api.github.com/repos/ding2/ding2/languages","stargazers_url":"https://api.github.com/repos/ding2/ding2/stargazers","contributors_url":"https://api.github.com/repos/ding2/ding2/contributors","subscribers_url":"https://api.github.com/repos/ding2/ding2/subscribers","subscription_url":"https://api.github.com/repos/ding2/ding2/subscription","commits_url":"https://api.github.com/repos/ding2/ding2/commits{/sha}","git_commits_url":"https://api.github.com/repos/ding2/ding2/git/commits{/sha}","comments_url":"https://api.github.com/repos/ding2/ding2/comments{/number}","issue_comment_url":"https://api.github.com/repos/ding2/ding2/issues/comments{/number}","contents_url":"https://api.github.com/repos/ding2/ding2/contents/{+path}","compare_url":"https://api.github.com/repos/ding2/ding2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ding2/ding2/merges","archive_url":"https://api.github.com/repos/ding2/ding2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ding2/ding2/downloads","issues_url":"https://api.github.com/repos/ding2/ding2/issues{/number}","pulls_url":"https://api.github.com/repos/ding2/ding2/pulls{/number}","milestones_url":"https://api.github.com/repos/ding2/ding2/milestones{/number}","notifications_url":"https://api.github.com/repos/ding2/ding2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ding2/ding2/labels{/name}","releases_url":"https://api.github.com/repos/ding2/ding2/releases{/id}","deployments_url":"https://api.github.com/repos/ding2/ding2/deployments","created_at":"2011-01-18T10:54:00Z","updated_at":"2018-10-09T10:13:46Z","pushed_at":"2018-10-09T11:53:00Z","git_url":"git://github.com/ding2/ding2.git","ssh_url":"git@github.com:ding2/ding2.git","clone_url":"https://github.com/ding2/ding2.git","svn_url":"https://github.com/ding2/ding2","homepage":"","size":95899,"stargazers_count":13,"watchers_count":13,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":48,"mirror_url":null,"archived":false,"open_issues_count":162,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":48,"open_issues":162,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ding2/ding2/pulls/1213"},"html":{"href":"https://github.com/ding2/ding2/pull/1213"},"issue":{"href":"https://api.github.com/repos/ding2/ding2/issues/1213"},"comments":{"href":"https://api.github.com/repos/ding2/ding2/issues/1213/comments"},"review_comments":{"href":"https://api.github.com/repos/ding2/ding2/pulls/1213/comments"},"review_comment":{"href":"https://api.github.com/repos/ding2/ding2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ding2/ding2/pulls/1213/commits"},"statuses":{"href":"https://api.github.com/repos/ding2/ding2/statuses/9444088b70a133f4d8410979cdce6dbdebcaff80"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kasperg"}}