{"action":"created","issue":{"url":"https://api.github.com/repos/walkerke/tidycensus/issues/124","repository_url":"https://api.github.com/repos/walkerke/tidycensus","labels_url":"https://api.github.com/repos/walkerke/tidycensus/issues/124/labels{/name}","comments_url":"https://api.github.com/repos/walkerke/tidycensus/issues/124/comments","events_url":"https://api.github.com/repos/walkerke/tidycensus/issues/124/events","html_url":"https://github.com/walkerke/tidycensus/issues/124","id":369728745,"node_id":"MDU6SXNzdWUzNjk3Mjg3NDU=","number":124,"title":"?get_acs state parameter","user":{"login":"arilamstein","id":50784,"node_id":"MDQ6VXNlcjUwNzg0","avatar_url":"https://avatars2.githubusercontent.com/u/50784?v=4","gravatar_id":"","url":"https://api.github.com/users/arilamstein","html_url":"https://github.com/arilamstein","followers_url":"https://api.github.com/users/arilamstein/followers","following_url":"https://api.github.com/users/arilamstein/following{/other_user}","gists_url":"https://api.github.com/users/arilamstein/gists{/gist_id}","starred_url":"https://api.github.com/users/arilamstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arilamstein/subscriptions","organizations_url":"https://api.github.com/users/arilamstein/orgs","repos_url":"https://api.github.com/users/arilamstein/repos","events_url":"https://api.github.com/users/arilamstein/events{/privacy}","received_events_url":"https://api.github.com/users/arilamstein/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-12T22:19:30Z","updated_at":"2018-10-13T19:18:02Z","closed_at":"2018-10-12T23:50:27Z","author_association":"NONE","body":"I have a case where I need to get data for multiple states. The documentation (and the fact that the parameter is singular) makes it sound like the the function can only get data for one state at a time. Here's the documentation for the `state` parameter for `?get_acs`:\r\n\r\n``\r\nThe state for which you are requesting data. State names, postal codes, and FIPS codes are accepted. Defaults to NULL.\r\n``\r\n\r\nHowever, the parameter can indeed handle a vector of states:\r\n\r\n```\r\nget_acs(geography = \"county\", \r\n         state     = c(\"michigan\", \"illinois\"), \r\n         table     = \"B01001\")\r\nGetting data from the 2012-2016 5-year ACS\r\nUsing FIPS code '26' for state 'Michigan'\r\nUsing FIPS code '17' for state 'Illinois'\r\n```\r\n\r\nI wonder if it makes sense to change the parameter name to `states`. If I hadn't decided to test this myself I would have written this in multiple calls."},"comment":{"url":"https://api.github.com/repos/walkerke/tidycensus/issues/comments/429568125","html_url":"https://github.com/walkerke/tidycensus/issues/124#issuecomment-429568125","issue_url":"https://api.github.com/repos/walkerke/tidycensus/issues/124","id":429568125,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTU2ODEyNQ==","user":{"login":"arilamstein","id":50784,"node_id":"MDQ6VXNlcjUwNzg0","avatar_url":"https://avatars2.githubusercontent.com/u/50784?v=4","gravatar_id":"","url":"https://api.github.com/users/arilamstein","html_url":"https://github.com/arilamstein","followers_url":"https://api.github.com/users/arilamstein/followers","following_url":"https://api.github.com/users/arilamstein/following{/other_user}","gists_url":"https://api.github.com/users/arilamstein/gists{/gist_id}","starred_url":"https://api.github.com/users/arilamstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arilamstein/subscriptions","organizations_url":"https://api.github.com/users/arilamstein/orgs","repos_url":"https://api.github.com/users/arilamstein/repos","events_url":"https://api.github.com/users/arilamstein/events{/privacy}","received_events_url":"https://api.github.com/users/arilamstein/received_events","type":"User","site_admin":false},"created_at":"2018-10-13T19:18:02Z","updated_at":"2018-10-13T19:18:02Z","author_association":"NONE","body":"Done.\r\n\r\nNow that I'm looking at the documentation more closely, there might be room for other changes. For example, the `state` parameter says: \"Defaults to NULL.\" While this is accurate, it also doesn't tell me what it means to have the variable be NULL. If it means \"all states\", then it might be useful to change the last sentence to be something like \"If NULL, then get data for all states\"."}}
{"actor":{"display_login":"arilamstein"}}