{"action":"closed","issue":{"url":"https://api.github.com/repos/bekeplar/iReporter/issues/22","repository_url":"https://api.github.com/repos/bekeplar/iReporter","labels_url":"https://api.github.com/repos/bekeplar/iReporter/issues/22/labels{/name}","comments_url":"https://api.github.com/repos/bekeplar/iReporter/issues/22/comments","events_url":"https://api.github.com/repos/bekeplar/iReporter/issues/22/events","html_url":"https://github.com/bekeplar/iReporter/issues/22","id":396008384,"node_id":"MDU6SXNzdWUzOTYwMDgzODQ=","number":22,"title":"Some programming logic issues","user":{"login":"kalsmic","id":24764476,"node_id":"MDQ6VXNlcjI0NzY0NDc2","avatar_url":"https://avatars3.githubusercontent.com/u/24764476?v=4","gravatar_id":"","url":"https://api.github.com/users/kalsmic","html_url":"https://github.com/kalsmic","followers_url":"https://api.github.com/users/kalsmic/followers","following_url":"https://api.github.com/users/kalsmic/following{/other_user}","gists_url":"https://api.github.com/users/kalsmic/gists{/gist_id}","starred_url":"https://api.github.com/users/kalsmic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalsmic/subscriptions","organizations_url":"https://api.github.com/users/kalsmic/orgs","repos_url":"https://api.github.com/users/kalsmic/repos","events_url":"https://api.github.com/users/kalsmic/events{/privacy}","received_events_url":"https://api.github.com/users/kalsmic/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2019-01-04T17:37:55Z","updated_at":"2019-01-05T11:53:04Z","closed_at":"2019-01-05T11:53:04Z","author_association":"NONE","body":"Why did you create two validation functions and not one instead?\r\nhttps://github.com/bekeplar/iReporter/blob/887c8a7fb6cc39170330e9606b0fb19810ab66a9/api/validator.py#L26-L52\r\nWhat's the essence of validate_input and validate_inputs? Why not have one continuous function?\r\n\r\n\r\nhttps://github.com/bekeplar/iReporter/blob/887c8a7fb6cc39170330e9606b0fb19810ab66a9/api/Helpers.py#L17-L21\r\nWhat does this function do? I do not understand the logic. ` if user.username == None:`\r\n\r\nIf your target is to avoid adding a duplicate user then you would loop through a list of user objects while comparing the username or email or both and if there is a match then user already exists."}}
{"actor":{"display_login":"bekeplar"}}