{"action":"created","comment":{"url":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/comments/173776533","pull_request_review_id":103013053,"id":173776533,"diff_hunk":"@@ -50,17 +51,15 @@\n ecalEndcapReadoutName = \"EMECPhiEta\"\n ecalFwdReadoutName = \"EMFwdPhiEta\"\n # HCAL readouts\n-hcalReadoutName = \"BarHCal_Readout\"\n-newHcalReadoutName = hcalReadoutName + \"_phieta\"\n-extHcalReadoutName = \"ExtBarHCal_Readout\"\n-newExtHcalReadoutName = extHcalReadoutName + \"_phieta\"\n+hcalReadoutName = \"HCalBarrelReadout\"\n+extHcalReadoutName = \"HCalExtBarrelReadout\"\n hcalEndcapReadoutName = \"HECPhiEta\"\n hcalFwdReadoutName = \"HFwdPhiEta\"\n+# Tail Catcher readout\n+tailCatcherReadoutName = \"Muons_Readout\"\n # layers to be merged in endcaps & forward calo\n-ecalEndcapNumberOfLayersToMerge = [26]*5+[27]\n-ecalFwdNumberOfLayersToMerge = [7]*5+[8]\n-hcalEndcapNumberOfLayersToMerge = [13]+[14]*5\n-hcalFwdNumberOfLayersToMerge = [8]+[9]*5\n+ecalEndcapNumberOfLayersToMerge = [2] + [2] + [4]*38","path":"Reconstruction/RecCalorimeter/tests/options/runFullCaloSystem_SimAndDigitisation.py","position":29,"original_position":29,"commit_id":"2aa0dec0653e3a127a73e75ae0d3ef65f2d7fbad","original_commit_id":"2aa0dec0653e3a127a73e75ae0d3ef65f2d7fbad","user":{"login":"zaborowska","id":8872723,"avatar_url":"https://avatars3.githubusercontent.com/u/8872723?v=4","gravatar_id":"","url":"https://api.github.com/users/zaborowska","html_url":"https://github.com/zaborowska","followers_url":"https://api.github.com/users/zaborowska/followers","following_url":"https://api.github.com/users/zaborowska/following{/other_user}","gists_url":"https://api.github.com/users/zaborowska/gists{/gist_id}","starred_url":"https://api.github.com/users/zaborowska/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zaborowska/subscriptions","organizations_url":"https://api.github.com/users/zaborowska/orgs","repos_url":"https://api.github.com/users/zaborowska/repos","events_url":"https://api.github.com/users/zaborowska/events{/privacy}","received_events_url":"https://api.github.com/users/zaborowska/received_events","type":"User","site_admin":false},"body":"old numbers should remain for testing purposes","created_at":"2018-03-12T12:19:36Z","updated_at":"2018-03-12T12:23:22Z","html_url":"https://github.com/HEP-FCC/FCCSW/pull/298#discussion_r173776533","pull_request_url":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/298","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/comments/173776533"},"html":{"href":"https://github.com/HEP-FCC/FCCSW/pull/298#discussion_r173776533"},"pull_request":{"href":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/298"}}},"pull_request":{"url":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/298","id":173966710,"html_url":"https://github.com/HEP-FCC/FCCSW/pull/298","diff_url":"https://github.com/HEP-FCC/FCCSW/pull/298.diff","patch_url":"https://github.com/HEP-FCC/FCCSW/pull/298.patch","issue_url":"https://api.github.com/repos/HEP-FCC/FCCSW/issues/298","number":298,"state":"open","locked":false,"title":"updates in the TileCal geometry to replace the phi segmentation","user":{"login":"CoralieNeubueser","id":24434468,"avatar_url":"https://avatars3.githubusercontent.com/u/24434468?v=4","gravatar_id":"","url":"https://api.github.com/users/CoralieNeubueser","html_url":"https://github.com/CoralieNeubueser","followers_url":"https://api.github.com/users/CoralieNeubueser/followers","following_url":"https://api.github.com/users/CoralieNeubueser/following{/other_user}","gists_url":"https://api.github.com/users/CoralieNeubueser/gists{/gist_id}","starred_url":"https://api.github.com/users/CoralieNeubueser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CoralieNeubueser/subscriptions","organizations_url":"https://api.github.com/users/CoralieNeubueser/orgs","repos_url":"https://api.github.com/users/CoralieNeubueser/repos","events_url":"https://api.github.com/users/CoralieNeubueser/events{/privacy}","received_events_url":"https://api.github.com/users/CoralieNeubueser/received_events","type":"User","site_admin":false},"body":"… the readout changed as well\r\n\r\n\r\nChanges proposed in this pull-request:\r\n\r\n- increased the number of modules in phi by 2, to replace the added dd4hep segmentation\r\n- this is implemented in the HCal Barrel and extended Barrel\r\n- additionally, naming in the EB are changed \r\n","created_at":"2018-03-09T10:14:42Z","updated_at":"2018-03-12T12:23:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6302479a2c6f73b2e144670ce0f958bae49c2a42","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/298/commits","review_comments_url":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/298/comments","review_comment_url":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HEP-FCC/FCCSW/issues/298/comments","statuses_url":"https://api.github.com/repos/HEP-FCC/FCCSW/statuses/2aa0dec0653e3a127a73e75ae0d3ef65f2d7fbad","head":{"label":"CoralieNeubueser:hcalGeoUpdate","ref":"hcalGeoUpdate","sha":"2aa0dec0653e3a127a73e75ae0d3ef65f2d7fbad","user":{"login":"CoralieNeubueser","id":24434468,"avatar_url":"https://avatars3.githubusercontent.com/u/24434468?v=4","gravatar_id":"","url":"https://api.github.com/users/CoralieNeubueser","html_url":"https://github.com/CoralieNeubueser","followers_url":"https://api.github.com/users/CoralieNeubueser/followers","following_url":"https://api.github.com/users/CoralieNeubueser/following{/other_user}","gists_url":"https://api.github.com/users/CoralieNeubueser/gists{/gist_id}","starred_url":"https://api.github.com/users/CoralieNeubueser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CoralieNeubueser/subscriptions","organizations_url":"https://api.github.com/users/CoralieNeubueser/orgs","repos_url":"https://api.github.com/users/CoralieNeubueser/repos","events_url":"https://api.github.com/users/CoralieNeubueser/events{/privacy}","received_events_url":"https://api.github.com/users/CoralieNeubueser/received_events","type":"User","site_admin":false},"repo":{"id":75837937,"name":"FCCSW","full_name":"CoralieNeubueser/FCCSW","owner":{"login":"CoralieNeubueser","id":24434468,"avatar_url":"https://avatars3.githubusercontent.com/u/24434468?v=4","gravatar_id":"","url":"https://api.github.com/users/CoralieNeubueser","html_url":"https://github.com/CoralieNeubueser","followers_url":"https://api.github.com/users/CoralieNeubueser/followers","following_url":"https://api.github.com/users/CoralieNeubueser/following{/other_user}","gists_url":"https://api.github.com/users/CoralieNeubueser/gists{/gist_id}","starred_url":"https://api.github.com/users/CoralieNeubueser/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CoralieNeubueser/subscriptions","organizations_url":"https://api.github.com/users/CoralieNeubueser/orgs","repos_url":"https://api.github.com/users/CoralieNeubueser/repos","events_url":"https://api.github.com/users/CoralieNeubueser/events{/privacy}","received_events_url":"https://api.github.com/users/CoralieNeubueser/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/CoralieNeubueser/FCCSW","description":"FCC software, common to FCC-hh, -ee, and -eh.","fork":true,"url":"https://api.github.com/repos/CoralieNeubueser/FCCSW","forks_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/forks","keys_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/teams","hooks_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/hooks","issue_events_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/issues/events{/number}","events_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/events","assignees_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/assignees{/user}","branches_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/branches{/branch}","tags_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/tags","blobs_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/git/refs{/sha}","trees_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/statuses/{sha}","languages_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/languages","stargazers_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/stargazers","contributors_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/contributors","subscribers_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/subscribers","subscription_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/subscription","commits_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/commits{/sha}","git_commits_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/git/commits{/sha}","comments_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/comments{/number}","issue_comment_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/issues/comments{/number}","contents_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/contents/{+path}","compare_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/merges","archive_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/downloads","issues_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/issues{/number}","pulls_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/pulls{/number}","milestones_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/milestones{/number}","notifications_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/labels{/name}","releases_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/releases{/id}","deployments_url":"https://api.github.com/repos/CoralieNeubueser/FCCSW/deployments","created_at":"2016-12-07T13:21:20Z","updated_at":"2016-12-07T13:21:22Z","pushed_at":"2018-03-12T10:18:01Z","git_url":"git://github.com/CoralieNeubueser/FCCSW.git","ssh_url":"git@github.com:CoralieNeubueser/FCCSW.git","clone_url":"https://github.com/CoralieNeubueser/FCCSW.git","svn_url":"https://github.com/CoralieNeubueser/FCCSW","homepage":"http://fccsw.web.cern.ch","size":176514,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"HEP-FCC:master","ref":"master","sha":"e359b6e518620a310e493711a1f677c52843a733","user":{"login":"HEP-FCC","id":8003187,"avatar_url":"https://avatars0.githubusercontent.com/u/8003187?v=4","gravatar_id":"","url":"https://api.github.com/users/HEP-FCC","html_url":"https://github.com/HEP-FCC","followers_url":"https://api.github.com/users/HEP-FCC/followers","following_url":"https://api.github.com/users/HEP-FCC/following{/other_user}","gists_url":"https://api.github.com/users/HEP-FCC/gists{/gist_id}","starred_url":"https://api.github.com/users/HEP-FCC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HEP-FCC/subscriptions","organizations_url":"https://api.github.com/users/HEP-FCC/orgs","repos_url":"https://api.github.com/users/HEP-FCC/repos","events_url":"https://api.github.com/users/HEP-FCC/events{/privacy}","received_events_url":"https://api.github.com/users/HEP-FCC/received_events","type":"Organization","site_admin":false},"repo":{"id":21388221,"name":"FCCSW","full_name":"HEP-FCC/FCCSW","owner":{"login":"HEP-FCC","id":8003187,"avatar_url":"https://avatars0.githubusercontent.com/u/8003187?v=4","gravatar_id":"","url":"https://api.github.com/users/HEP-FCC","html_url":"https://github.com/HEP-FCC","followers_url":"https://api.github.com/users/HEP-FCC/followers","following_url":"https://api.github.com/users/HEP-FCC/following{/other_user}","gists_url":"https://api.github.com/users/HEP-FCC/gists{/gist_id}","starred_url":"https://api.github.com/users/HEP-FCC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HEP-FCC/subscriptions","organizations_url":"https://api.github.com/users/HEP-FCC/orgs","repos_url":"https://api.github.com/users/HEP-FCC/repos","events_url":"https://api.github.com/users/HEP-FCC/events{/privacy}","received_events_url":"https://api.github.com/users/HEP-FCC/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HEP-FCC/FCCSW","description":"FCC software, common to FCC-hh, -ee, and -eh.","fork":false,"url":"https://api.github.com/repos/HEP-FCC/FCCSW","forks_url":"https://api.github.com/repos/HEP-FCC/FCCSW/forks","keys_url":"https://api.github.com/repos/HEP-FCC/FCCSW/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HEP-FCC/FCCSW/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HEP-FCC/FCCSW/teams","hooks_url":"https://api.github.com/repos/HEP-FCC/FCCSW/hooks","issue_events_url":"https://api.github.com/repos/HEP-FCC/FCCSW/issues/events{/number}","events_url":"https://api.github.com/repos/HEP-FCC/FCCSW/events","assignees_url":"https://api.github.com/repos/HEP-FCC/FCCSW/assignees{/user}","branches_url":"https://api.github.com/repos/HEP-FCC/FCCSW/branches{/branch}","tags_url":"https://api.github.com/repos/HEP-FCC/FCCSW/tags","blobs_url":"https://api.github.com/repos/HEP-FCC/FCCSW/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HEP-FCC/FCCSW/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HEP-FCC/FCCSW/git/refs{/sha}","trees_url":"https://api.github.com/repos/HEP-FCC/FCCSW/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HEP-FCC/FCCSW/statuses/{sha}","languages_url":"https://api.github.com/repos/HEP-FCC/FCCSW/languages","stargazers_url":"https://api.github.com/repos/HEP-FCC/FCCSW/stargazers","contributors_url":"https://api.github.com/repos/HEP-FCC/FCCSW/contributors","subscribers_url":"https://api.github.com/repos/HEP-FCC/FCCSW/subscribers","subscription_url":"https://api.github.com/repos/HEP-FCC/FCCSW/subscription","commits_url":"https://api.github.com/repos/HEP-FCC/FCCSW/commits{/sha}","git_commits_url":"https://api.github.com/repos/HEP-FCC/FCCSW/git/commits{/sha}","comments_url":"https://api.github.com/repos/HEP-FCC/FCCSW/comments{/number}","issue_comment_url":"https://api.github.com/repos/HEP-FCC/FCCSW/issues/comments{/number}","contents_url":"https://api.github.com/repos/HEP-FCC/FCCSW/contents/{+path}","compare_url":"https://api.github.com/repos/HEP-FCC/FCCSW/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HEP-FCC/FCCSW/merges","archive_url":"https://api.github.com/repos/HEP-FCC/FCCSW/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HEP-FCC/FCCSW/downloads","issues_url":"https://api.github.com/repos/HEP-FCC/FCCSW/issues{/number}","pulls_url":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls{/number}","milestones_url":"https://api.github.com/repos/HEP-FCC/FCCSW/milestones{/number}","notifications_url":"https://api.github.com/repos/HEP-FCC/FCCSW/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HEP-FCC/FCCSW/labels{/name}","releases_url":"https://api.github.com/repos/HEP-FCC/FCCSW/releases{/id}","deployments_url":"https://api.github.com/repos/HEP-FCC/FCCSW/deployments","created_at":"2014-07-01T13:16:22Z","updated_at":"2017-10-20T14:57:34Z","pushed_at":"2018-03-12T10:18:02Z","git_url":"git://github.com/HEP-FCC/FCCSW.git","ssh_url":"git@github.com:HEP-FCC/FCCSW.git","clone_url":"https://github.com/HEP-FCC/FCCSW.git","svn_url":"https://github.com/HEP-FCC/FCCSW","homepage":"http://fccsw.web.cern.ch","size":175979,"stargazers_count":7,"watchers_count":7,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":82,"mirror_url":null,"archived":false,"open_issues_count":30,"license":null,"forks":82,"open_issues":30,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/298"},"html":{"href":"https://github.com/HEP-FCC/FCCSW/pull/298"},"issue":{"href":"https://api.github.com/repos/HEP-FCC/FCCSW/issues/298"},"comments":{"href":"https://api.github.com/repos/HEP-FCC/FCCSW/issues/298/comments"},"review_comments":{"href":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/298/comments"},"review_comment":{"href":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HEP-FCC/FCCSW/pulls/298/commits"},"statuses":{"href":"https://api.github.com/repos/HEP-FCC/FCCSW/statuses/2aa0dec0653e3a127a73e75ae0d3ef65f2d7fbad"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"zaborowska"}}