{"action":"created","issue":{"url":"https://api.github.com/repos/aws-amplify/aws-sdk-ios/issues/1117","repository_url":"https://api.github.com/repos/aws-amplify/aws-sdk-ios","labels_url":"https://api.github.com/repos/aws-amplify/aws-sdk-ios/issues/1117/labels{/name}","comments_url":"https://api.github.com/repos/aws-amplify/aws-sdk-ios/issues/1117/comments","events_url":"https://api.github.com/repos/aws-amplify/aws-sdk-ios/issues/1117/events","html_url":"https://github.com/aws-amplify/aws-sdk-ios/issues/1117","id":382953367,"node_id":"MDU6SXNzdWUzODI5NTMzNjc=","number":1117,"title":"AWSCognitoAuth doesn't called completion handler when \"Done\" button pressed.","user":{"login":"johnflanagan-spok","id":36447853,"node_id":"MDQ6VXNlcjM2NDQ3ODUz","avatar_url":"https://avatars0.githubusercontent.com/u/36447853?v=4","gravatar_id":"","url":"https://api.github.com/users/johnflanagan-spok","html_url":"https://github.com/johnflanagan-spok","followers_url":"https://api.github.com/users/johnflanagan-spok/followers","following_url":"https://api.github.com/users/johnflanagan-spok/following{/other_user}","gists_url":"https://api.github.com/users/johnflanagan-spok/gists{/gist_id}","starred_url":"https://api.github.com/users/johnflanagan-spok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnflanagan-spok/subscriptions","organizations_url":"https://api.github.com/users/johnflanagan-spok/orgs","repos_url":"https://api.github.com/users/johnflanagan-spok/repos","events_url":"https://api.github.com/users/johnflanagan-spok/events{/privacy}","received_events_url":"https://api.github.com/users/johnflanagan-spok/received_events","type":"User","site_admin":false},"labels":[{"id":690768198,"node_id":"MDU6TGFiZWw2OTA3NjgxOTg=","url":"https://api.github.com/repos/aws-amplify/aws-sdk-ios/labels/Cognito","name":"Cognito","color":"d4c5f9","default":false},{"id":106258122,"node_id":"MDU6TGFiZWwxMDYyNTgxMjI=","url":"https://api.github.com/repos/aws-amplify/aws-sdk-ios/labels/bug","name":"bug","color":"fc2929","default":true},{"id":110936561,"node_id":"MDU6TGFiZWwxMTA5MzY1NjE=","url":"https://api.github.com/repos/aws-amplify/aws-sdk-ios/labels/requesting%20feedback","name":"requesting feedback","color":"32c11f","default":false}],"state":"open","locked":false,"assignee":{"login":"rohandubal","id":7157240,"node_id":"MDQ6VXNlcjcxNTcyNDA=","avatar_url":"https://avatars3.githubusercontent.com/u/7157240?v=4","gravatar_id":"","url":"https://api.github.com/users/rohandubal","html_url":"https://github.com/rohandubal","followers_url":"https://api.github.com/users/rohandubal/followers","following_url":"https://api.github.com/users/rohandubal/following{/other_user}","gists_url":"https://api.github.com/users/rohandubal/gists{/gist_id}","starred_url":"https://api.github.com/users/rohandubal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rohandubal/subscriptions","organizations_url":"https://api.github.com/users/rohandubal/orgs","repos_url":"https://api.github.com/users/rohandubal/repos","events_url":"https://api.github.com/users/rohandubal/events{/privacy}","received_events_url":"https://api.github.com/users/rohandubal/received_events","type":"User","site_admin":false},"assignees":[{"login":"rohandubal","id":7157240,"node_id":"MDQ6VXNlcjcxNTcyNDA=","avatar_url":"https://avatars3.githubusercontent.com/u/7157240?v=4","gravatar_id":"","url":"https://api.github.com/users/rohandubal","html_url":"https://github.com/rohandubal","followers_url":"https://api.github.com/users/rohandubal/followers","following_url":"https://api.github.com/users/rohandubal/following{/other_user}","gists_url":"https://api.github.com/users/rohandubal/gists{/gist_id}","starred_url":"https://api.github.com/users/rohandubal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rohandubal/subscriptions","organizations_url":"https://api.github.com/users/rohandubal/orgs","repos_url":"https://api.github.com/users/rohandubal/repos","events_url":"https://api.github.com/users/rohandubal/events{/privacy}","received_events_url":"https://api.github.com/users/rohandubal/received_events","type":"User","site_admin":false}],"milestone":null,"comments":10,"created_at":"2018-11-21T04:43:15Z","updated_at":"2019-01-04T18:41:24Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"**Describe the bug**\r\nWhen attempting to sign in with `AWSCognitoAuth` if the user taps the `Done` button on the `SFSafariViewController` the `getSessionBlock` is not called.\r\n\r\n**To Reproduce**\r\nSteps to reproduce the behavior:\r\n1. Start user authentication by calling `AWSCognitoAuth.getSession:completion:`\r\n2. Click `Done` on the `SFSafariViewController` presented by the SDK\r\n3. Observe that the completion handler is not called\r\n\r\n**Which AWS service(s) are affected?**\r\nAWSCognitoAuth\r\n\r\n**Expected behavior**\r\nThe completion handler should be called with a `AWSCognitoAuthClientErrorUserCanceledOperation` error.\r\n\r\n**Environment(please complete the following information):**\r\n - SDK Version: 2.7.3\r\n - Dependency Manager: Cocoapods\r\n - Swift Version : 4.0\r\n\r\n**Device Information (please complete the following information):**\r\n - Device: Tested on iPhone X and Simulator\r\n - iOS Version: iOS 12.1\r\n - Specific to simulators: No\r\n\r\n**Additional context**\r\nI suspect the issue is that https://github.com/aws-amplify/aws-sdk-ios/blob/6ea656a78050a9092da16f380cbbdd920584a357/AWSCognitoAuth/AWSCognitoAuth.m#L688 is never calling its completion handler because the done button has already started dismissing the `SFSafariViewController`."},"comment":{"url":"https://api.github.com/repos/aws-amplify/aws-sdk-ios/issues/comments/451530890","html_url":"https://github.com/aws-amplify/aws-sdk-ios/issues/1117#issuecomment-451530890","issue_url":"https://api.github.com/repos/aws-amplify/aws-sdk-ios/issues/1117","id":451530890,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MTUzMDg5MA==","user":{"login":"johnflanagan-spok","id":36447853,"node_id":"MDQ6VXNlcjM2NDQ3ODUz","avatar_url":"https://avatars0.githubusercontent.com/u/36447853?v=4","gravatar_id":"","url":"https://api.github.com/users/johnflanagan-spok","html_url":"https://github.com/johnflanagan-spok","followers_url":"https://api.github.com/users/johnflanagan-spok/followers","following_url":"https://api.github.com/users/johnflanagan-spok/following{/other_user}","gists_url":"https://api.github.com/users/johnflanagan-spok/gists{/gist_id}","starred_url":"https://api.github.com/users/johnflanagan-spok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnflanagan-spok/subscriptions","organizations_url":"https://api.github.com/users/johnflanagan-spok/orgs","repos_url":"https://api.github.com/users/johnflanagan-spok/repos","events_url":"https://api.github.com/users/johnflanagan-spok/events{/privacy}","received_events_url":"https://api.github.com/users/johnflanagan-spok/received_events","type":"User","site_admin":false},"created_at":"2019-01-04T18:41:24Z","updated_at":"2019-01-04T18:41:24Z","author_association":"CONTRIBUTOR","body":"@minbi ,\r\n\r\nLooks good to me. Thanks!"}}
{"actor":{"display_login":"johnflanagan-spok"}}