{"action":"created","issue":{"url":"https://api.github.com/repos/UPBGE/blender/issues/754","repository_url":"https://api.github.com/repos/UPBGE/blender","labels_url":"https://api.github.com/repos/UPBGE/blender/issues/754/labels{/name}","comments_url":"https://api.github.com/repos/UPBGE/blender/issues/754/comments","events_url":"https://api.github.com/repos/UPBGE/blender/issues/754/events","html_url":"https://github.com/UPBGE/blender/pull/754","id":342478328,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMzY5MjI1","number":754,"title":"UPBGE: Fix python component conversion from async libload.","user":{"login":"panzergame","id":8046004,"node_id":"MDQ6VXNlcjgwNDYwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/8046004?v=4","gravatar_id":"","url":"https://api.github.com/users/panzergame","html_url":"https://github.com/panzergame","followers_url":"https://api.github.com/users/panzergame/followers","following_url":"https://api.github.com/users/panzergame/following{/other_user}","gists_url":"https://api.github.com/users/panzergame/gists{/gist_id}","starred_url":"https://api.github.com/users/panzergame/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/panzergame/subscriptions","organizations_url":"https://api.github.com/users/panzergame/orgs","repos_url":"https://api.github.com/users/panzergame/repos","events_url":"https://api.github.com/users/panzergame/events{/privacy}","received_events_url":"https://api.github.com/users/panzergame/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-07-18T20:23:34Z","updated_at":"2018-07-26T04:04:52Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/UPBGE/blender/pulls/754","html_url":"https://github.com/UPBGE/blender/pull/754","diff_url":"https://github.com/UPBGE/blender/pull/754.diff","patch_url":"https://github.com/UPBGE/blender/pull/754.patch"},"body":"Previously the async thread dedicated for the libload was directly calling\r\npython function without ensuring the GIL and this caused issue, no conversion\r\nor memory error.\r\n\r\nTo fix this issue Py_X_ALLOW_THREADS and Py_X_THREADS macro are used, they\r\nintent on ensuring and locking the python GIL so that any python API calls\r\nare proceeded sequentially.\r\n\r\nFix issue #751."},"comment":{"url":"https://api.github.com/repos/UPBGE/blender/issues/comments/407969876","html_url":"https://github.com/UPBGE/blender/pull/754#issuecomment-407969876","issue_url":"https://api.github.com/repos/UPBGE/blender/issues/754","id":407969876,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNzk2OTg3Ng==","user":{"login":"youle31","id":10052509,"node_id":"MDQ6VXNlcjEwMDUyNTA5","avatar_url":"https://avatars3.githubusercontent.com/u/10052509?v=4","gravatar_id":"","url":"https://api.github.com/users/youle31","html_url":"https://github.com/youle31","followers_url":"https://api.github.com/users/youle31/followers","following_url":"https://api.github.com/users/youle31/following{/other_user}","gists_url":"https://api.github.com/users/youle31/gists{/gist_id}","starred_url":"https://api.github.com/users/youle31/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/youle31/subscriptions","organizations_url":"https://api.github.com/users/youle31/orgs","repos_url":"https://api.github.com/users/youle31/repos","events_url":"https://api.github.com/users/youle31/events{/privacy}","received_events_url":"https://api.github.com/users/youle31/received_events","type":"User","site_admin":false},"created_at":"2018-07-26T04:04:52Z","updated_at":"2018-07-26T04:04:52Z","author_association":"COLLABORATOR","body":"@panzergame : hello, your lasts commits seems to have fix the bug I was mentionning in my previous post. I tested only with Cotaks file named: libload_crashes_2.zip .\r\n\r\nElse I can't reproduce the crash in master or elsewhere.\r\n\r\nSo everything works fine for me in the new ge_bug_fix_751 with this test file.\r\n\r\n(offtopic: armatures ~work in eeveeInBge/upbge if you are interested)"}}
{"actor":{"display_login":"youle31"}}