{"action":"created","issue":{"url":"https://api.github.com/repos/justeat/JustSaying/issues/458","repository_url":"https://api.github.com/repos/justeat/JustSaying","labels_url":"https://api.github.com/repos/justeat/JustSaying/issues/458/labels{/name}","comments_url":"https://api.github.com/repos/justeat/JustSaying/issues/458/comments","events_url":"https://api.github.com/repos/justeat/JustSaying/issues/458/events","html_url":"https://github.com/justeat/JustSaying/issues/458","id":384470599,"node_id":"MDU6SXNzdWUzODQ0NzA1OTk=","number":458,"title":"Remove IMessageLock","user":{"login":"martincostello","id":1439341,"node_id":"MDQ6VXNlcjE0MzkzNDE=","avatar_url":"https://avatars0.githubusercontent.com/u/1439341?v=4","gravatar_id":"","url":"https://api.github.com/users/martincostello","html_url":"https://github.com/martincostello","followers_url":"https://api.github.com/users/martincostello/followers","following_url":"https://api.github.com/users/martincostello/following{/other_user}","gists_url":"https://api.github.com/users/martincostello/gists{/gist_id}","starred_url":"https://api.github.com/users/martincostello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martincostello/subscriptions","organizations_url":"https://api.github.com/users/martincostello/orgs","repos_url":"https://api.github.com/users/martincostello/repos","events_url":"https://api.github.com/users/martincostello/events{/privacy}","received_events_url":"https://api.github.com/users/martincostello/received_events","type":"User","site_admin":false},"labels":[{"id":90921240,"node_id":"MDU6TGFiZWw5MDkyMTI0MA==","url":"https://api.github.com/repos/justeat/JustSaying/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/justeat/JustSaying/milestones/2","html_url":"https://github.com/justeat/JustSaying/milestone/2","labels_url":"https://api.github.com/repos/justeat/JustSaying/milestones/2/labels","id":3560855,"node_id":"MDk6TWlsZXN0b25lMzU2MDg1NQ==","number":2,"title":"v7.0.0","description":"JustSaying v7.0.0.","creator":{"login":"martincostello","id":1439341,"node_id":"MDQ6VXNlcjE0MzkzNDE=","avatar_url":"https://avatars0.githubusercontent.com/u/1439341?v=4","gravatar_id":"","url":"https://api.github.com/users/martincostello","html_url":"https://github.com/martincostello","followers_url":"https://api.github.com/users/martincostello/followers","following_url":"https://api.github.com/users/martincostello/following{/other_user}","gists_url":"https://api.github.com/users/martincostello/gists{/gist_id}","starred_url":"https://api.github.com/users/martincostello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martincostello/subscriptions","organizations_url":"https://api.github.com/users/martincostello/orgs","repos_url":"https://api.github.com/users/martincostello/repos","events_url":"https://api.github.com/users/martincostello/events{/privacy}","received_events_url":"https://api.github.com/users/martincostello/received_events","type":"User","site_admin":false},"open_issues":15,"closed_issues":49,"state":"open","created_at":"2018-08-10T13:20:55Z","updated_at":"2018-11-27T14:57:59Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2018-11-26T19:12:44Z","updated_at":"2018-11-27T14:59:41Z","closed_at":null,"author_association":"MEMBER","body":"In JustSaying we have two interfaces, `IMessageLock` and `IMessageLockAsync`.\r\n\r\nWe provide an implementation of `IMessageLockAsync` which just delegates to an inner `IMessageLock`, but we don't provide a built-in implementation of `IMessageLock` at all.\r\n\r\nTo simplify things as everything's async now anyway, we should just provide `IMessageLockAsync` (and drop the `Async` suffix?), and leave any \"it's not really async\" implementation to anyone who wants to use the interface as JustSaying consumes it all in an async way anyway."},"comment":{"url":"https://api.github.com/repos/justeat/JustSaying/issues/comments/442088921","html_url":"https://github.com/justeat/JustSaying/issues/458#issuecomment-442088921","issue_url":"https://api.github.com/repos/justeat/JustSaying/issues/458","id":442088921,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MjA4ODkyMQ==","user":{"login":"slang25","id":1341446,"node_id":"MDQ6VXNlcjEzNDE0NDY=","avatar_url":"https://avatars3.githubusercontent.com/u/1341446?v=4","gravatar_id":"","url":"https://api.github.com/users/slang25","html_url":"https://github.com/slang25","followers_url":"https://api.github.com/users/slang25/followers","following_url":"https://api.github.com/users/slang25/following{/other_user}","gists_url":"https://api.github.com/users/slang25/gists{/gist_id}","starred_url":"https://api.github.com/users/slang25/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slang25/subscriptions","organizations_url":"https://api.github.com/users/slang25/orgs","repos_url":"https://api.github.com/users/slang25/repos","events_url":"https://api.github.com/users/slang25/events{/privacy}","received_events_url":"https://api.github.com/users/slang25/received_events","type":"User","site_admin":false},"created_at":"2018-11-27T14:59:41Z","updated_at":"2018-11-27T14:59:41Z","author_association":"COLLABORATOR","body":"Just to give a little background here, `IMessageLock` was the existing interface, and a commonly used implementation exists inside JustEats codebase (could be open sources) that uses dynamodb.\r\n`IMessageLockAsync` was added specifically to support the async nature of the dynamodb calls, and  `BlockingMessageLock` was added as a backward compatibility shim."}}
{"actor":{"display_login":"slang25"}}