{"action":"created","comment":{"url":"https://api.github.com/repos/codice/ddf/pulls/comments/232386712","pull_request_review_id":173581804,"id":232386712,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjM4NjcxMg==","diff_hunk":"@@ -67,6 +70,8 @@\n \n   public static final String DEFAULT_NAME = \"Default\";\n \n+  private static final Gson GSON = GsonFactory.createStandardBuilder().create();","path":"platform/admin/core/admin-core-impl/src/main/java/org/codice/ddf/admin/core/impl/GuestClaimsHandlerExt.java","position":35,"original_position":35,"commit_id":"53a7bc0b758195b3fda6a113c1bfea232fc57245","original_commit_id":"08d9bd458124e2af3bff754bcd997b253c60cc97","user":{"login":"coyotesqrl","id":1469860,"node_id":"MDQ6VXNlcjE0Njk4NjA=","avatar_url":"https://avatars2.githubusercontent.com/u/1469860?v=4","gravatar_id":"","url":"https://api.github.com/users/coyotesqrl","html_url":"https://github.com/coyotesqrl","followers_url":"https://api.github.com/users/coyotesqrl/followers","following_url":"https://api.github.com/users/coyotesqrl/following{/other_user}","gists_url":"https://api.github.com/users/coyotesqrl/gists{/gist_id}","starred_url":"https://api.github.com/users/coyotesqrl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coyotesqrl/subscriptions","organizations_url":"https://api.github.com/users/coyotesqrl/orgs","repos_url":"https://api.github.com/users/coyotesqrl/repos","events_url":"https://api.github.com/users/coyotesqrl/events{/privacy}","received_events_url":"https://api.github.com/users/coyotesqrl/received_events","type":"User","site_admin":false},"body":"Correct.","created_at":"2018-11-09T20:38:23Z","updated_at":"2018-11-09T20:38:23Z","html_url":"https://github.com/codice/ddf/pull/3986#discussion_r232386712","pull_request_url":"https://api.github.com/repos/codice/ddf/pulls/3986","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/codice/ddf/pulls/comments/232386712"},"html":{"href":"https://github.com/codice/ddf/pull/3986#discussion_r232386712"},"pull_request":{"href":"https://api.github.com/repos/codice/ddf/pulls/3986"}},"in_reply_to_id":232282728},"pull_request":{"url":"https://api.github.com/repos/codice/ddf/pulls/3986","id":227794506,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3Nzk0NTA2","html_url":"https://github.com/codice/ddf/pull/3986","diff_url":"https://github.com/codice/ddf/pull/3986.diff","patch_url":"https://github.com/codice/ddf/pull/3986.patch","issue_url":"https://api.github.com/repos/codice/ddf/issues/3986","number":3986,"state":"open","locked":false,"title":"DDF-4295 Removes boon from DDF","user":{"login":"coyotesqrl","id":1469860,"node_id":"MDQ6VXNlcjE0Njk4NjA=","avatar_url":"https://avatars2.githubusercontent.com/u/1469860?v=4","gravatar_id":"","url":"https://api.github.com/users/coyotesqrl","html_url":"https://github.com/coyotesqrl","followers_url":"https://api.github.com/users/coyotesqrl/followers","following_url":"https://api.github.com/users/coyotesqrl/following{/other_user}","gists_url":"https://api.github.com/users/coyotesqrl/gists{/gist_id}","starred_url":"https://api.github.com/users/coyotesqrl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coyotesqrl/subscriptions","organizations_url":"https://api.github.com/users/coyotesqrl/orgs","repos_url":"https://api.github.com/users/coyotesqrl/repos","events_url":"https://api.github.com/users/coyotesqrl/events{/privacy}","received_events_url":"https://api.github.com/users/coyotesqrl/received_events","type":"User","site_admin":false},"body":"#### What does this PR do?\r\nRemoves Boon and replaces it with Gson in preparation for Java 11.\r\n\r\nThe PR has been structured with multiple, logical commits. Some are quite simple - the feature file commit for example just ensures that the gson library is added as a requirement to bundles where it is needed and that boon has been removed. Others include more changes. Of particular note are changes for \r\n\r\n- `ValidationParser`: The internals of that class have been reworked considerably to simplify processing - no more reading JSON in order to write out JSON to be re-parsed, for example.\r\n- `catalog-ui-search` module: this module had significant changes, particularly to the \"pojo\" classes.\r\n\r\nCareful review and testing will be required in these and other areas.\r\n\r\nA larger than usual number of reviewers and committers have been tagged such that area experts can be involved in review and testing.\r\n\r\n#### Who is reviewing it? \r\n@paouelle @brjeter @jrnorth @troymohl @Lambeaux \r\n\r\n<!--(please choose AT LEAST two reviewers that need to approve the PR before it can get merged)-->\r\n#### Select relevant component teams: \r\n@codice/security \r\n@codice/ui \r\n\r\n#### Ask 2 committers to review/merge the PR and tag them here.\r\n@clockard\r\n@djblue\r\n@pklinef\r\n@rzwiefel\r\n@stustison\r\n@tbatie\r\n\r\n#### How should this be tested?\r\n<!--(List steps with links to updated documentation)-->\r\n#### Any background context you want to provide?\r\n#### What are the relevant tickets?\r\n[](https://codice.atlassian.net/browse/)\r\n#### Screenshots\r\n<!--(if appropriate)-->\r\n#### Checklist:\r\n- [ ] Documentation Updated\r\n- [ ] Update / Add Unit Tests\r\n- [ ] Update / Add Integration Tests\r\n\r\n#### Notes on Review Process\r\nPlease see [Notes on Review Process](https://codice.atlassian.net/wiki/spaces/DDF/pages/71946981/Pull+Request+Guidelines) for further guidance on requirements for merging and abbreviated reviews. \r\n\r\n#### Review Comment Legend:\r\n- ✏️ (Pencil) This comment is a nitpick or style suggestion, no action required for approval. This comment should provide a suggestion either as an in line code snippet or a gist. \r\n- ❓ (Question Mark) This comment is to gain a clearer understanding of design or code choices, clarification is required but action may not be necessary for approval.\r\n- ❗ (Exclamation Mark) This comment is critical and requires clarification or action before approval.\r\n","created_at":"2018-11-01T23:55:41Z","updated_at":"2018-11-09T20:38:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4ea02f532af06555288d30cdba3d3711877a77cc","assignee":null,"assignees":[],"requested_reviewers":[{"login":"stustison","id":4391679,"node_id":"MDQ6VXNlcjQzOTE2Nzk=","avatar_url":"https://avatars0.githubusercontent.com/u/4391679?v=4","gravatar_id":"","url":"https://api.github.com/users/stustison","html_url":"https://github.com/stustison","followers_url":"https://api.github.com/users/stustison/followers","following_url":"https://api.github.com/users/stustison/following{/other_user}","gists_url":"https://api.github.com/users/stustison/gists{/gist_id}","starred_url":"https://api.github.com/users/stustison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stustison/subscriptions","organizations_url":"https://api.github.com/users/stustison/orgs","repos_url":"https://api.github.com/users/stustison/repos","events_url":"https://api.github.com/users/stustison/events{/privacy}","received_events_url":"https://api.github.com/users/stustison/received_events","type":"User","site_admin":false},{"login":"rzwiefel","id":9013416,"node_id":"MDQ6VXNlcjkwMTM0MTY=","avatar_url":"https://avatars0.githubusercontent.com/u/9013416?v=4","gravatar_id":"","url":"https://api.github.com/users/rzwiefel","html_url":"https://github.com/rzwiefel","followers_url":"https://api.github.com/users/rzwiefel/followers","following_url":"https://api.github.com/users/rzwiefel/following{/other_user}","gists_url":"https://api.github.com/users/rzwiefel/gists{/gist_id}","starred_url":"https://api.github.com/users/rzwiefel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rzwiefel/subscriptions","organizations_url":"https://api.github.com/users/rzwiefel/orgs","repos_url":"https://api.github.com/users/rzwiefel/repos","events_url":"https://api.github.com/users/rzwiefel/events{/privacy}","received_events_url":"https://api.github.com/users/rzwiefel/received_events","type":"User","site_admin":false},{"login":"andrewkfiedler","id":11984853,"node_id":"MDQ6VXNlcjExOTg0ODUz","avatar_url":"https://avatars3.githubusercontent.com/u/11984853?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewkfiedler","html_url":"https://github.com/andrewkfiedler","followers_url":"https://api.github.com/users/andrewkfiedler/followers","following_url":"https://api.github.com/users/andrewkfiedler/following{/other_user}","gists_url":"https://api.github.com/users/andrewkfiedler/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewkfiedler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewkfiedler/subscriptions","organizations_url":"https://api.github.com/users/andrewkfiedler/orgs","repos_url":"https://api.github.com/users/andrewkfiedler/repos","events_url":"https://api.github.com/users/andrewkfiedler/events{/privacy}","received_events_url":"https://api.github.com/users/andrewkfiedler/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1089005428,"node_id":"MDU6TGFiZWwxMDg5MDA1NDI4","url":"https://api.github.com/repos/codice/ddf/labels/J11%20Upgrade","name":"J11 Upgrade","color":"7bfc97","default":false},{"id":1117155983,"node_id":"MDU6TGFiZWwxMTE3MTU1OTgz","url":"https://api.github.com/repos/codice/ddf/labels/%F0%9F%94%A8Refactor","name":"🔨Refactor","color":"8480fc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/codice/ddf/pulls/3986/commits","review_comments_url":"https://api.github.com/repos/codice/ddf/pulls/3986/comments","review_comment_url":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codice/ddf/issues/3986/comments","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/53a7bc0b758195b3fda6a113c1bfea232fc57245","head":{"label":"coyotesqrl:remove_boon","ref":"remove_boon","sha":"53a7bc0b758195b3fda6a113c1bfea232fc57245","user":{"login":"coyotesqrl","id":1469860,"node_id":"MDQ6VXNlcjE0Njk4NjA=","avatar_url":"https://avatars2.githubusercontent.com/u/1469860?v=4","gravatar_id":"","url":"https://api.github.com/users/coyotesqrl","html_url":"https://github.com/coyotesqrl","followers_url":"https://api.github.com/users/coyotesqrl/followers","following_url":"https://api.github.com/users/coyotesqrl/following{/other_user}","gists_url":"https://api.github.com/users/coyotesqrl/gists{/gist_id}","starred_url":"https://api.github.com/users/coyotesqrl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coyotesqrl/subscriptions","organizations_url":"https://api.github.com/users/coyotesqrl/orgs","repos_url":"https://api.github.com/users/coyotesqrl/repos","events_url":"https://api.github.com/users/coyotesqrl/events{/privacy}","received_events_url":"https://api.github.com/users/coyotesqrl/received_events","type":"User","site_admin":false},"repo":{"id":64254932,"node_id":"MDEwOlJlcG9zaXRvcnk2NDI1NDkzMg==","name":"ddf","full_name":"coyotesqrl/ddf","private":false,"owner":{"login":"coyotesqrl","id":1469860,"node_id":"MDQ6VXNlcjE0Njk4NjA=","avatar_url":"https://avatars2.githubusercontent.com/u/1469860?v=4","gravatar_id":"","url":"https://api.github.com/users/coyotesqrl","html_url":"https://github.com/coyotesqrl","followers_url":"https://api.github.com/users/coyotesqrl/followers","following_url":"https://api.github.com/users/coyotesqrl/following{/other_user}","gists_url":"https://api.github.com/users/coyotesqrl/gists{/gist_id}","starred_url":"https://api.github.com/users/coyotesqrl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coyotesqrl/subscriptions","organizations_url":"https://api.github.com/users/coyotesqrl/orgs","repos_url":"https://api.github.com/users/coyotesqrl/repos","events_url":"https://api.github.com/users/coyotesqrl/events{/privacy}","received_events_url":"https://api.github.com/users/coyotesqrl/received_events","type":"User","site_admin":false},"html_url":"https://github.com/coyotesqrl/ddf","description":"Distributed Data Framework - an open source, modular integration framework.","fork":true,"url":"https://api.github.com/repos/coyotesqrl/ddf","forks_url":"https://api.github.com/repos/coyotesqrl/ddf/forks","keys_url":"https://api.github.com/repos/coyotesqrl/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coyotesqrl/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coyotesqrl/ddf/teams","hooks_url":"https://api.github.com/repos/coyotesqrl/ddf/hooks","issue_events_url":"https://api.github.com/repos/coyotesqrl/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/coyotesqrl/ddf/events","assignees_url":"https://api.github.com/repos/coyotesqrl/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/coyotesqrl/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/coyotesqrl/ddf/tags","blobs_url":"https://api.github.com/repos/coyotesqrl/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coyotesqrl/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coyotesqrl/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/coyotesqrl/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coyotesqrl/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/coyotesqrl/ddf/languages","stargazers_url":"https://api.github.com/repos/coyotesqrl/ddf/stargazers","contributors_url":"https://api.github.com/repos/coyotesqrl/ddf/contributors","subscribers_url":"https://api.github.com/repos/coyotesqrl/ddf/subscribers","subscription_url":"https://api.github.com/repos/coyotesqrl/ddf/subscription","commits_url":"https://api.github.com/repos/coyotesqrl/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/coyotesqrl/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/coyotesqrl/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/coyotesqrl/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/coyotesqrl/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/coyotesqrl/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coyotesqrl/ddf/merges","archive_url":"https://api.github.com/repos/coyotesqrl/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coyotesqrl/ddf/downloads","issues_url":"https://api.github.com/repos/coyotesqrl/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/coyotesqrl/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/coyotesqrl/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/coyotesqrl/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coyotesqrl/ddf/labels{/name}","releases_url":"https://api.github.com/repos/coyotesqrl/ddf/releases{/id}","deployments_url":"https://api.github.com/repos/coyotesqrl/ddf/deployments","created_at":"2016-07-26T21:09:49Z","updated_at":"2016-07-26T21:10:03Z","pushed_at":"2018-11-09T16:05:01Z","git_url":"git://github.com/coyotesqrl/ddf.git","ssh_url":"git@github.com:coyotesqrl/ddf.git","clone_url":"https://github.com/coyotesqrl/ddf.git","svn_url":"https://github.com/coyotesqrl/ddf","homepage":"http://ddf.codice.org","size":337716,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"codice:master","ref":"master","sha":"3121ca78db74b48d3ff087a8a6fcff8fe2e75bcf","user":{"login":"codice","id":2386734,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzODY3MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2386734?v=4","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"repo":{"id":15173563,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE3MzU2Mw==","name":"ddf","full_name":"codice/ddf","private":false,"owner":{"login":"codice","id":2386734,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzODY3MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2386734?v=4","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/codice/ddf","description":"DDF Distributed Data Framework - an open source, modular integration framework.","fork":false,"url":"https://api.github.com/repos/codice/ddf","forks_url":"https://api.github.com/repos/codice/ddf/forks","keys_url":"https://api.github.com/repos/codice/ddf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codice/ddf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codice/ddf/teams","hooks_url":"https://api.github.com/repos/codice/ddf/hooks","issue_events_url":"https://api.github.com/repos/codice/ddf/issues/events{/number}","events_url":"https://api.github.com/repos/codice/ddf/events","assignees_url":"https://api.github.com/repos/codice/ddf/assignees{/user}","branches_url":"https://api.github.com/repos/codice/ddf/branches{/branch}","tags_url":"https://api.github.com/repos/codice/ddf/tags","blobs_url":"https://api.github.com/repos/codice/ddf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codice/ddf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codice/ddf/git/refs{/sha}","trees_url":"https://api.github.com/repos/codice/ddf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codice/ddf/statuses/{sha}","languages_url":"https://api.github.com/repos/codice/ddf/languages","stargazers_url":"https://api.github.com/repos/codice/ddf/stargazers","contributors_url":"https://api.github.com/repos/codice/ddf/contributors","subscribers_url":"https://api.github.com/repos/codice/ddf/subscribers","subscription_url":"https://api.github.com/repos/codice/ddf/subscription","commits_url":"https://api.github.com/repos/codice/ddf/commits{/sha}","git_commits_url":"https://api.github.com/repos/codice/ddf/git/commits{/sha}","comments_url":"https://api.github.com/repos/codice/ddf/comments{/number}","issue_comment_url":"https://api.github.com/repos/codice/ddf/issues/comments{/number}","contents_url":"https://api.github.com/repos/codice/ddf/contents/{+path}","compare_url":"https://api.github.com/repos/codice/ddf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codice/ddf/merges","archive_url":"https://api.github.com/repos/codice/ddf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codice/ddf/downloads","issues_url":"https://api.github.com/repos/codice/ddf/issues{/number}","pulls_url":"https://api.github.com/repos/codice/ddf/pulls{/number}","milestones_url":"https://api.github.com/repos/codice/ddf/milestones{/number}","notifications_url":"https://api.github.com/repos/codice/ddf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codice/ddf/labels{/name}","releases_url":"https://api.github.com/repos/codice/ddf/releases{/id}","deployments_url":"https://api.github.com/repos/codice/ddf/deployments","created_at":"2013-12-13T20:38:28Z","updated_at":"2018-11-08T23:33:20Z","pushed_at":"2018-11-09T20:16:08Z","git_url":"git://github.com/codice/ddf.git","ssh_url":"git@github.com:codice/ddf.git","clone_url":"https://github.com/codice/ddf.git","svn_url":"https://github.com/codice/ddf","homepage":"http://ddf.codice.org","size":413123,"stargazers_count":92,"watchers_count":92,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":156,"mirror_url":null,"archived":false,"open_issues_count":47,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":156,"open_issues":47,"watchers":92,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codice/ddf/pulls/3986"},"html":{"href":"https://github.com/codice/ddf/pull/3986"},"issue":{"href":"https://api.github.com/repos/codice/ddf/issues/3986"},"comments":{"href":"https://api.github.com/repos/codice/ddf/issues/3986/comments"},"review_comments":{"href":"https://api.github.com/repos/codice/ddf/pulls/3986/comments"},"review_comment":{"href":"https://api.github.com/repos/codice/ddf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codice/ddf/pulls/3986/commits"},"statuses":{"href":"https://api.github.com/repos/codice/ddf/statuses/53a7bc0b758195b3fda6a113c1bfea232fc57245"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"coyotesqrl"}}