{"action":"created","comment":{"url":"https://api.github.com/repos/arviz-devs/arviz/pulls/comments/224233877","pull_request_review_id":163551284,"id":224233877,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDIzMzg3Nw==","diff_hunk":"@@ -53,59 +61,70 @@ def plot_compare(comp_df, insample_dev=True, plot_standard_error=True, plot_ic_d\n     yticks_pos, step = np.linspace(0, -1, (comp_df.shape[0] * 2) - 1, retstep=True)\n     yticks_pos[1::2] = yticks_pos[1::2] + step / 2\n \n-    yticks_labels = [''] * len(yticks_pos)\n+    yticks_labels = [\"\"] * len(yticks_pos)\n \n-    information_criterion = 'waic'\n+    information_criterion = \"waic\"\n     if information_criterion not in comp_df.columns:\n-        information_criterion = 'loo'\n+        information_criterion = \"loo\"\n \n     if plot_ic_diff:\n         yticks_labels[0] = comp_df.index[0]\n         yticks_labels[2::2] = comp_df.index[1:]\n         ax.set_yticks(yticks_pos)\n-        ax.errorbar(x=comp_df[information_criterion].iloc[1:],\n-                    y=yticks_pos[1::2],\n-                    xerr=comp_df.dse[1:],\n-                    color=plot_kwargs.get('color_dse', 'grey'),\n-                    fmt=plot_kwargs.get('marker_dse', '^'),\n-                    mew=linewidth,\n-                    elinewidth=linewidth)\n+        ax.errorbar(\n+            x=comp_df[information_criterion].iloc[1:],\n+            y=yticks_pos[1::2],\n+            xerr=comp_df.dse[1:],\n+            color=plot_kwargs.get(\"color_dse\", \"grey\"),\n+            fmt=plot_kwargs.get(\"marker_dse\", \"^\"),\n+            mew=linewidth,\n+            elinewidth=linewidth,\n+        )","path":"arviz/plots/compareplot.py","position":51,"original_position":51,"commit_id":"1f10d8f445616bf082d66b1d0cc28cab367fd328","original_commit_id":"1f10d8f445616bf082d66b1d0cc28cab367fd328","user":{"login":"canyon289","id":7213793,"node_id":"MDQ6VXNlcjcyMTM3OTM=","avatar_url":"https://avatars3.githubusercontent.com/u/7213793?v=4","gravatar_id":"","url":"https://api.github.com/users/canyon289","html_url":"https://github.com/canyon289","followers_url":"https://api.github.com/users/canyon289/followers","following_url":"https://api.github.com/users/canyon289/following{/other_user}","gists_url":"https://api.github.com/users/canyon289/gists{/gist_id}","starred_url":"https://api.github.com/users/canyon289/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canyon289/subscriptions","organizations_url":"https://api.github.com/users/canyon289/orgs","repos_url":"https://api.github.com/users/canyon289/repos","events_url":"https://api.github.com/users/canyon289/events{/privacy}","received_events_url":"https://api.github.com/users/canyon289/received_events","type":"User","site_admin":false},"body":"@aloctavodia You and black are not going to be friends on the placement of parentheses either :(","created_at":"2018-10-10T20:40:36Z","updated_at":"2018-10-10T20:40:36Z","html_url":"https://github.com/arviz-devs/arviz/pull/358#discussion_r224233877","pull_request_url":"https://api.github.com/repos/arviz-devs/arviz/pulls/358","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/arviz-devs/arviz/pulls/comments/224233877"},"html":{"href":"https://github.com/arviz-devs/arviz/pull/358#discussion_r224233877"},"pull_request":{"href":"https://api.github.com/repos/arviz-devs/arviz/pulls/358"}}},"pull_request":{"url":"https://api.github.com/repos/arviz-devs/arviz/pulls/358","id":221925254,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxOTI1MjU0","html_url":"https://github.com/arviz-devs/arviz/pull/358","diff_url":"https://github.com/arviz-devs/arviz/pull/358.diff","patch_url":"https://github.com/arviz-devs/arviz/pull/358.patch","issue_url":"https://api.github.com/repos/arviz-devs/arviz/issues/358","number":358,"state":"open","locked":false,"title":"[WIP] Black formatting","user":{"login":"canyon289","id":7213793,"node_id":"MDQ6VXNlcjcyMTM3OTM=","avatar_url":"https://avatars3.githubusercontent.com/u/7213793?v=4","gravatar_id":"","url":"https://api.github.com/users/canyon289","html_url":"https://github.com/canyon289","followers_url":"https://api.github.com/users/canyon289/followers","following_url":"https://api.github.com/users/canyon289/following{/other_user}","gists_url":"https://api.github.com/users/canyon289/gists{/gist_id}","starred_url":"https://api.github.com/users/canyon289/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canyon289/subscriptions","organizations_url":"https://api.github.com/users/canyon289/orgs","repos_url":"https://api.github.com/users/canyon289/repos","events_url":"https://api.github.com/users/canyon289/events{/privacy}","received_events_url":"https://api.github.com/users/canyon289/received_events","type":"User","site_admin":false},"body":"Major changes\r\n* Black formatting on arviz directory\r\n* Increase line length to 120\r\n* Ignore pydocstyle warnings on empty line warning on methods with internal methods\r\n* Ignore bad continuation in pylint\r\n\r\nContinuous Integration notes\r\nBlack supports a `--check` flag so we just need to add that to the 3.6 pipeline to ensure the code has been run through black. We also could remove pylint entirely, we should keep pydocstyle though\r\n\r\nSubjective notes\r\nRunning black is super easy. Its a lot nicer than having to manually fix things, lint, and repeat. For the most part its good but I dislike some of the styling though, for instance putting each argument on its own line for the plot methods. That being said I value the consistency and removal of subjective formatting.","created_at":"2018-10-10T20:38:17Z","updated_at":"2018-10-10T20:40:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a674596b33fdc3e56f09091f2ef9f13469b84858","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/arviz-devs/arviz/pulls/358/commits","review_comments_url":"https://api.github.com/repos/arviz-devs/arviz/pulls/358/comments","review_comment_url":"https://api.github.com/repos/arviz-devs/arviz/pulls/comments{/number}","comments_url":"https://api.github.com/repos/arviz-devs/arviz/issues/358/comments","statuses_url":"https://api.github.com/repos/arviz-devs/arviz/statuses/1f10d8f445616bf082d66b1d0cc28cab367fd328","head":{"label":"canyon289:black","ref":"black","sha":"1f10d8f445616bf082d66b1d0cc28cab367fd328","user":{"login":"canyon289","id":7213793,"node_id":"MDQ6VXNlcjcyMTM3OTM=","avatar_url":"https://avatars3.githubusercontent.com/u/7213793?v=4","gravatar_id":"","url":"https://api.github.com/users/canyon289","html_url":"https://github.com/canyon289","followers_url":"https://api.github.com/users/canyon289/followers","following_url":"https://api.github.com/users/canyon289/following{/other_user}","gists_url":"https://api.github.com/users/canyon289/gists{/gist_id}","starred_url":"https://api.github.com/users/canyon289/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canyon289/subscriptions","organizations_url":"https://api.github.com/users/canyon289/orgs","repos_url":"https://api.github.com/users/canyon289/repos","events_url":"https://api.github.com/users/canyon289/events{/privacy}","received_events_url":"https://api.github.com/users/canyon289/received_events","type":"User","site_admin":false},"repo":{"id":142735059,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI3MzUwNTk=","name":"arviz","full_name":"canyon289/arviz","private":false,"owner":{"login":"canyon289","id":7213793,"node_id":"MDQ6VXNlcjcyMTM3OTM=","avatar_url":"https://avatars3.githubusercontent.com/u/7213793?v=4","gravatar_id":"","url":"https://api.github.com/users/canyon289","html_url":"https://github.com/canyon289","followers_url":"https://api.github.com/users/canyon289/followers","following_url":"https://api.github.com/users/canyon289/following{/other_user}","gists_url":"https://api.github.com/users/canyon289/gists{/gist_id}","starred_url":"https://api.github.com/users/canyon289/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canyon289/subscriptions","organizations_url":"https://api.github.com/users/canyon289/orgs","repos_url":"https://api.github.com/users/canyon289/repos","events_url":"https://api.github.com/users/canyon289/events{/privacy}","received_events_url":"https://api.github.com/users/canyon289/received_events","type":"User","site_admin":false},"html_url":"https://github.com/canyon289/arviz","description":"Python package to plot and analyse samples from probabilistic models","fork":true,"url":"https://api.github.com/repos/canyon289/arviz","forks_url":"https://api.github.com/repos/canyon289/arviz/forks","keys_url":"https://api.github.com/repos/canyon289/arviz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/canyon289/arviz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/canyon289/arviz/teams","hooks_url":"https://api.github.com/repos/canyon289/arviz/hooks","issue_events_url":"https://api.github.com/repos/canyon289/arviz/issues/events{/number}","events_url":"https://api.github.com/repos/canyon289/arviz/events","assignees_url":"https://api.github.com/repos/canyon289/arviz/assignees{/user}","branches_url":"https://api.github.com/repos/canyon289/arviz/branches{/branch}","tags_url":"https://api.github.com/repos/canyon289/arviz/tags","blobs_url":"https://api.github.com/repos/canyon289/arviz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/canyon289/arviz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/canyon289/arviz/git/refs{/sha}","trees_url":"https://api.github.com/repos/canyon289/arviz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/canyon289/arviz/statuses/{sha}","languages_url":"https://api.github.com/repos/canyon289/arviz/languages","stargazers_url":"https://api.github.com/repos/canyon289/arviz/stargazers","contributors_url":"https://api.github.com/repos/canyon289/arviz/contributors","subscribers_url":"https://api.github.com/repos/canyon289/arviz/subscribers","subscription_url":"https://api.github.com/repos/canyon289/arviz/subscription","commits_url":"https://api.github.com/repos/canyon289/arviz/commits{/sha}","git_commits_url":"https://api.github.com/repos/canyon289/arviz/git/commits{/sha}","comments_url":"https://api.github.com/repos/canyon289/arviz/comments{/number}","issue_comment_url":"https://api.github.com/repos/canyon289/arviz/issues/comments{/number}","contents_url":"https://api.github.com/repos/canyon289/arviz/contents/{+path}","compare_url":"https://api.github.com/repos/canyon289/arviz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/canyon289/arviz/merges","archive_url":"https://api.github.com/repos/canyon289/arviz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/canyon289/arviz/downloads","issues_url":"https://api.github.com/repos/canyon289/arviz/issues{/number}","pulls_url":"https://api.github.com/repos/canyon289/arviz/pulls{/number}","milestones_url":"https://api.github.com/repos/canyon289/arviz/milestones{/number}","notifications_url":"https://api.github.com/repos/canyon289/arviz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/canyon289/arviz/labels{/name}","releases_url":"https://api.github.com/repos/canyon289/arviz/releases{/id}","deployments_url":"https://api.github.com/repos/canyon289/arviz/deployments","created_at":"2018-07-29T05:58:49Z","updated_at":"2018-10-10T20:18:22Z","pushed_at":"2018-10-10T20:35:13Z","git_url":"git://github.com/canyon289/arviz.git","ssh_url":"git@github.com:canyon289/arviz.git","clone_url":"https://github.com/canyon289/arviz.git","svn_url":"https://github.com/canyon289/arviz","homepage":"http://arviz-devs.github.io/arviz/","size":12595,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"arviz-devs:master","ref":"master","sha":"8481002f71c3d51d4550841d49a02d85062aabc4","user":{"login":"arviz-devs","id":13554846,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNTU0ODQ2","avatar_url":"https://avatars2.githubusercontent.com/u/13554846?v=4","gravatar_id":"","url":"https://api.github.com/users/arviz-devs","html_url":"https://github.com/arviz-devs","followers_url":"https://api.github.com/users/arviz-devs/followers","following_url":"https://api.github.com/users/arviz-devs/following{/other_user}","gists_url":"https://api.github.com/users/arviz-devs/gists{/gist_id}","starred_url":"https://api.github.com/users/arviz-devs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arviz-devs/subscriptions","organizations_url":"https://api.github.com/users/arviz-devs/orgs","repos_url":"https://api.github.com/users/arviz-devs/repos","events_url":"https://api.github.com/users/arviz-devs/events{/privacy}","received_events_url":"https://api.github.com/users/arviz-devs/received_events","type":"Organization","site_admin":false},"repo":{"id":39890704,"node_id":"MDEwOlJlcG9zaXRvcnkzOTg5MDcwNA==","name":"arviz","full_name":"arviz-devs/arviz","private":false,"owner":{"login":"arviz-devs","id":13554846,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNTU0ODQ2","avatar_url":"https://avatars2.githubusercontent.com/u/13554846?v=4","gravatar_id":"","url":"https://api.github.com/users/arviz-devs","html_url":"https://github.com/arviz-devs","followers_url":"https://api.github.com/users/arviz-devs/followers","following_url":"https://api.github.com/users/arviz-devs/following{/other_user}","gists_url":"https://api.github.com/users/arviz-devs/gists{/gist_id}","starred_url":"https://api.github.com/users/arviz-devs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arviz-devs/subscriptions","organizations_url":"https://api.github.com/users/arviz-devs/orgs","repos_url":"https://api.github.com/users/arviz-devs/repos","events_url":"https://api.github.com/users/arviz-devs/events{/privacy}","received_events_url":"https://api.github.com/users/arviz-devs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/arviz-devs/arviz","description":"Python package to plot and analyse samples from probabilistic models","fork":false,"url":"https://api.github.com/repos/arviz-devs/arviz","forks_url":"https://api.github.com/repos/arviz-devs/arviz/forks","keys_url":"https://api.github.com/repos/arviz-devs/arviz/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arviz-devs/arviz/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arviz-devs/arviz/teams","hooks_url":"https://api.github.com/repos/arviz-devs/arviz/hooks","issue_events_url":"https://api.github.com/repos/arviz-devs/arviz/issues/events{/number}","events_url":"https://api.github.com/repos/arviz-devs/arviz/events","assignees_url":"https://api.github.com/repos/arviz-devs/arviz/assignees{/user}","branches_url":"https://api.github.com/repos/arviz-devs/arviz/branches{/branch}","tags_url":"https://api.github.com/repos/arviz-devs/arviz/tags","blobs_url":"https://api.github.com/repos/arviz-devs/arviz/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arviz-devs/arviz/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arviz-devs/arviz/git/refs{/sha}","trees_url":"https://api.github.com/repos/arviz-devs/arviz/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arviz-devs/arviz/statuses/{sha}","languages_url":"https://api.github.com/repos/arviz-devs/arviz/languages","stargazers_url":"https://api.github.com/repos/arviz-devs/arviz/stargazers","contributors_url":"https://api.github.com/repos/arviz-devs/arviz/contributors","subscribers_url":"https://api.github.com/repos/arviz-devs/arviz/subscribers","subscription_url":"https://api.github.com/repos/arviz-devs/arviz/subscription","commits_url":"https://api.github.com/repos/arviz-devs/arviz/commits{/sha}","git_commits_url":"https://api.github.com/repos/arviz-devs/arviz/git/commits{/sha}","comments_url":"https://api.github.com/repos/arviz-devs/arviz/comments{/number}","issue_comment_url":"https://api.github.com/repos/arviz-devs/arviz/issues/comments{/number}","contents_url":"https://api.github.com/repos/arviz-devs/arviz/contents/{+path}","compare_url":"https://api.github.com/repos/arviz-devs/arviz/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arviz-devs/arviz/merges","archive_url":"https://api.github.com/repos/arviz-devs/arviz/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arviz-devs/arviz/downloads","issues_url":"https://api.github.com/repos/arviz-devs/arviz/issues{/number}","pulls_url":"https://api.github.com/repos/arviz-devs/arviz/pulls{/number}","milestones_url":"https://api.github.com/repos/arviz-devs/arviz/milestones{/number}","notifications_url":"https://api.github.com/repos/arviz-devs/arviz/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arviz-devs/arviz/labels{/name}","releases_url":"https://api.github.com/repos/arviz-devs/arviz/releases{/id}","deployments_url":"https://api.github.com/repos/arviz-devs/arviz/deployments","created_at":"2015-07-29T11:51:10Z","updated_at":"2018-10-10T20:34:29Z","pushed_at":"2018-10-10T20:38:18Z","git_url":"git://github.com/arviz-devs/arviz.git","ssh_url":"git@github.com:arviz-devs/arviz.git","clone_url":"https://github.com/arviz-devs/arviz.git","svn_url":"https://github.com/arviz-devs/arviz","homepage":"https://arviz-devs.github.io/arviz/","size":17374,"stargazers_count":271,"watchers_count":271,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":35,"mirror_url":null,"archived":false,"open_issues_count":40,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":35,"open_issues":40,"watchers":271,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/arviz-devs/arviz/pulls/358"},"html":{"href":"https://github.com/arviz-devs/arviz/pull/358"},"issue":{"href":"https://api.github.com/repos/arviz-devs/arviz/issues/358"},"comments":{"href":"https://api.github.com/repos/arviz-devs/arviz/issues/358/comments"},"review_comments":{"href":"https://api.github.com/repos/arviz-devs/arviz/pulls/358/comments"},"review_comment":{"href":"https://api.github.com/repos/arviz-devs/arviz/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/arviz-devs/arviz/pulls/358/commits"},"statuses":{"href":"https://api.github.com/repos/arviz-devs/arviz/statuses/1f10d8f445616bf082d66b1d0cc28cab367fd328"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"canyon289"}}