{"action":"closed","number":12,"pull_request":{"url":"https://api.github.com/repos/go-log/log/pulls/12","id":230028772,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMDI4Nzcy","html_url":"https://github.com/go-log/log/pull/12","diff_url":"https://github.com/go-log/log/pull/12.diff","patch_url":"https://github.com/go-log/log/pull/12.patch","issue_url":"https://api.github.com/repos/go-log/log/issues/12","number":12,"state":"closed","locked":false,"title":"nest: Add PreNest marker (and other cleanups)","user":{"login":"wking","id":209920,"node_id":"MDQ6VXNlcjIwOTkyMA==","avatar_url":"https://avatars1.githubusercontent.com/u/209920?v=4","gravatar_id":"","url":"https://api.github.com/users/wking","html_url":"https://github.com/wking","followers_url":"https://api.github.com/users/wking/followers","following_url":"https://api.github.com/users/wking/following{/other_user}","gists_url":"https://api.github.com/users/wking/gists{/gist_id}","starred_url":"https://api.github.com/users/wking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wking/subscriptions","organizations_url":"https://api.github.com/users/wking/orgs","repos_url":"https://api.github.com/users/wking/repos","events_url":"https://api.github.com/users/wking/events{/privacy}","received_events_url":"https://api.github.com/users/wking/received_events","type":"User","site_admin":false},"body":"The `PreNest` marker allows us to drop the empty-string delimiters from library callers and still get readable output from `fmt.Print`-style renderers.  I've added a new unit test showing that log implementations that want to detect `Marker`s should use `reflect.DeepEqual` or something else that is stricter than `==`.\n\nI've also adjusted the expected order of keys in the unit-test map.  Currently this output is unstable, but [this][1] (golang/go@a440cc0d702e15c19bcc984f7a8f5c10f83726ab, golang/go#21095) will have the order stabilized in future Go releases.  The change here sets us up for compatibility with that new logic.\n\nI've also made the `Newf` and `Logf` implementations more compact by turning them into wrappers around `New` and `Log` respectively.\n\nI think this stabilizes around the library-consumer API we want here.  There's probably still room for improvement in the parent-facing API (e.g. storing wrapping-call-site in the marker so parents can toggle logger display on a per-package basis?), but stabilizing that API is less important.\n\n[1]: https://go-review.googlesource.com/c/go/+/142737/","created_at":"2018-11-12T06:18:16Z","updated_at":"2018-11-12T07:33:10Z","closed_at":"2018-11-12T07:33:10Z","merged_at":"2018-11-12T07:33:10Z","merge_commit_sha":"d779b9eab01a0fb47f4d742d0e85c63995f772da","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/go-log/log/pulls/12/commits","review_comments_url":"https://api.github.com/repos/go-log/log/pulls/12/comments","review_comment_url":"https://api.github.com/repos/go-log/log/pulls/comments{/number}","comments_url":"https://api.github.com/repos/go-log/log/issues/12/comments","statuses_url":"https://api.github.com/repos/go-log/log/statuses/0049de3daca7a009b1c6aded1b0a8862dd3cdb76","head":{"label":"wking:nest-cleanups","ref":"nest-cleanups","sha":"0049de3daca7a009b1c6aded1b0a8862dd3cdb76","user":{"login":"wking","id":209920,"node_id":"MDQ6VXNlcjIwOTkyMA==","avatar_url":"https://avatars1.githubusercontent.com/u/209920?v=4","gravatar_id":"","url":"https://api.github.com/users/wking","html_url":"https://github.com/wking","followers_url":"https://api.github.com/users/wking/followers","following_url":"https://api.github.com/users/wking/following{/other_user}","gists_url":"https://api.github.com/users/wking/gists{/gist_id}","starred_url":"https://api.github.com/users/wking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wking/subscriptions","organizations_url":"https://api.github.com/users/wking/orgs","repos_url":"https://api.github.com/users/wking/repos","events_url":"https://api.github.com/users/wking/events{/privacy}","received_events_url":"https://api.github.com/users/wking/received_events","type":"User","site_admin":false},"repo":{"id":141357882,"node_id":"MDEwOlJlcG9zaXRvcnkxNDEzNTc4ODI=","name":"go-log","full_name":"wking/go-log","private":false,"owner":{"login":"wking","id":209920,"node_id":"MDQ6VXNlcjIwOTkyMA==","avatar_url":"https://avatars1.githubusercontent.com/u/209920?v=4","gravatar_id":"","url":"https://api.github.com/users/wking","html_url":"https://github.com/wking","followers_url":"https://api.github.com/users/wking/followers","following_url":"https://api.github.com/users/wking/following{/other_user}","gists_url":"https://api.github.com/users/wking/gists{/gist_id}","starred_url":"https://api.github.com/users/wking/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wking/subscriptions","organizations_url":"https://api.github.com/users/wking/orgs","repos_url":"https://api.github.com/users/wking/repos","events_url":"https://api.github.com/users/wking/events{/privacy}","received_events_url":"https://api.github.com/users/wking/received_events","type":"User","site_admin":false},"html_url":"https://github.com/wking/go-log","description":"A universal log interface","fork":true,"url":"https://api.github.com/repos/wking/go-log","forks_url":"https://api.github.com/repos/wking/go-log/forks","keys_url":"https://api.github.com/repos/wking/go-log/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wking/go-log/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wking/go-log/teams","hooks_url":"https://api.github.com/repos/wking/go-log/hooks","issue_events_url":"https://api.github.com/repos/wking/go-log/issues/events{/number}","events_url":"https://api.github.com/repos/wking/go-log/events","assignees_url":"https://api.github.com/repos/wking/go-log/assignees{/user}","branches_url":"https://api.github.com/repos/wking/go-log/branches{/branch}","tags_url":"https://api.github.com/repos/wking/go-log/tags","blobs_url":"https://api.github.com/repos/wking/go-log/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wking/go-log/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wking/go-log/git/refs{/sha}","trees_url":"https://api.github.com/repos/wking/go-log/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wking/go-log/statuses/{sha}","languages_url":"https://api.github.com/repos/wking/go-log/languages","stargazers_url":"https://api.github.com/repos/wking/go-log/stargazers","contributors_url":"https://api.github.com/repos/wking/go-log/contributors","subscribers_url":"https://api.github.com/repos/wking/go-log/subscribers","subscription_url":"https://api.github.com/repos/wking/go-log/subscription","commits_url":"https://api.github.com/repos/wking/go-log/commits{/sha}","git_commits_url":"https://api.github.com/repos/wking/go-log/git/commits{/sha}","comments_url":"https://api.github.com/repos/wking/go-log/comments{/number}","issue_comment_url":"https://api.github.com/repos/wking/go-log/issues/comments{/number}","contents_url":"https://api.github.com/repos/wking/go-log/contents/{+path}","compare_url":"https://api.github.com/repos/wking/go-log/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wking/go-log/merges","archive_url":"https://api.github.com/repos/wking/go-log/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wking/go-log/downloads","issues_url":"https://api.github.com/repos/wking/go-log/issues{/number}","pulls_url":"https://api.github.com/repos/wking/go-log/pulls{/number}","milestones_url":"https://api.github.com/repos/wking/go-log/milestones{/number}","notifications_url":"https://api.github.com/repos/wking/go-log/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wking/go-log/labels{/name}","releases_url":"https://api.github.com/repos/wking/go-log/releases{/id}","deployments_url":"https://api.github.com/repos/wking/go-log/deployments","created_at":"2018-07-17T23:52:11Z","updated_at":"2018-11-11T23:32:30Z","pushed_at":"2018-11-12T06:11:17Z","git_url":"git://github.com/wking/go-log.git","ssh_url":"git@github.com:wking/go-log.git","clone_url":"https://github.com/wking/go-log.git","svn_url":"https://github.com/wking/go-log","homepage":"","size":27,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"go-log:master","ref":"master","sha":"86a9864745107cc2002bb01e368bf1c080a721a6","user":{"login":"go-log","id":28350529,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MzUwNTI5","avatar_url":"https://avatars3.githubusercontent.com/u/28350529?v=4","gravatar_id":"","url":"https://api.github.com/users/go-log","html_url":"https://github.com/go-log","followers_url":"https://api.github.com/users/go-log/followers","following_url":"https://api.github.com/users/go-log/following{/other_user}","gists_url":"https://api.github.com/users/go-log/gists{/gist_id}","starred_url":"https://api.github.com/users/go-log/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-log/subscriptions","organizations_url":"https://api.github.com/users/go-log/orgs","repos_url":"https://api.github.com/users/go-log/repos","events_url":"https://api.github.com/users/go-log/events{/privacy}","received_events_url":"https://api.github.com/users/go-log/received_events","type":"Organization","site_admin":false},"repo":{"id":90150034,"node_id":"MDEwOlJlcG9zaXRvcnk5MDE1MDAzNA==","name":"log","full_name":"go-log/log","private":false,"owner":{"login":"go-log","id":28350529,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MzUwNTI5","avatar_url":"https://avatars3.githubusercontent.com/u/28350529?v=4","gravatar_id":"","url":"https://api.github.com/users/go-log","html_url":"https://github.com/go-log","followers_url":"https://api.github.com/users/go-log/followers","following_url":"https://api.github.com/users/go-log/following{/other_user}","gists_url":"https://api.github.com/users/go-log/gists{/gist_id}","starred_url":"https://api.github.com/users/go-log/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/go-log/subscriptions","organizations_url":"https://api.github.com/users/go-log/orgs","repos_url":"https://api.github.com/users/go-log/repos","events_url":"https://api.github.com/users/go-log/events{/privacy}","received_events_url":"https://api.github.com/users/go-log/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/go-log/log","description":"A universal log interface","fork":false,"url":"https://api.github.com/repos/go-log/log","forks_url":"https://api.github.com/repos/go-log/log/forks","keys_url":"https://api.github.com/repos/go-log/log/keys{/key_id}","collaborators_url":"https://api.github.com/repos/go-log/log/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/go-log/log/teams","hooks_url":"https://api.github.com/repos/go-log/log/hooks","issue_events_url":"https://api.github.com/repos/go-log/log/issues/events{/number}","events_url":"https://api.github.com/repos/go-log/log/events","assignees_url":"https://api.github.com/repos/go-log/log/assignees{/user}","branches_url":"https://api.github.com/repos/go-log/log/branches{/branch}","tags_url":"https://api.github.com/repos/go-log/log/tags","blobs_url":"https://api.github.com/repos/go-log/log/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/go-log/log/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/go-log/log/git/refs{/sha}","trees_url":"https://api.github.com/repos/go-log/log/git/trees{/sha}","statuses_url":"https://api.github.com/repos/go-log/log/statuses/{sha}","languages_url":"https://api.github.com/repos/go-log/log/languages","stargazers_url":"https://api.github.com/repos/go-log/log/stargazers","contributors_url":"https://api.github.com/repos/go-log/log/contributors","subscribers_url":"https://api.github.com/repos/go-log/log/subscribers","subscription_url":"https://api.github.com/repos/go-log/log/subscription","commits_url":"https://api.github.com/repos/go-log/log/commits{/sha}","git_commits_url":"https://api.github.com/repos/go-log/log/git/commits{/sha}","comments_url":"https://api.github.com/repos/go-log/log/comments{/number}","issue_comment_url":"https://api.github.com/repos/go-log/log/issues/comments{/number}","contents_url":"https://api.github.com/repos/go-log/log/contents/{+path}","compare_url":"https://api.github.com/repos/go-log/log/compare/{base}...{head}","merges_url":"https://api.github.com/repos/go-log/log/merges","archive_url":"https://api.github.com/repos/go-log/log/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/go-log/log/downloads","issues_url":"https://api.github.com/repos/go-log/log/issues{/number}","pulls_url":"https://api.github.com/repos/go-log/log/pulls{/number}","milestones_url":"https://api.github.com/repos/go-log/log/milestones{/number}","notifications_url":"https://api.github.com/repos/go-log/log/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/go-log/log/labels{/name}","releases_url":"https://api.github.com/repos/go-log/log/releases{/id}","deployments_url":"https://api.github.com/repos/go-log/log/deployments","created_at":"2017-05-03T13:07:03Z","updated_at":"2018-11-12T01:36:26Z","pushed_at":"2018-11-12T07:33:10Z","git_url":"git://github.com/go-log/log.git","ssh_url":"git@github.com:go-log/log.git","clone_url":"https://github.com/go-log/log.git","svn_url":"https://github.com/go-log/log","homepage":"","size":24,"stargazers_count":42,"watchers_count":42,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":4,"open_issues":1,"watchers":42,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/go-log/log/pulls/12"},"html":{"href":"https://github.com/go-log/log/pull/12"},"issue":{"href":"https://api.github.com/repos/go-log/log/issues/12"},"comments":{"href":"https://api.github.com/repos/go-log/log/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/go-log/log/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/go-log/log/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/go-log/log/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/go-log/log/statuses/0049de3daca7a009b1c6aded1b0a8862dd3cdb76"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"asim","id":17530,"node_id":"MDQ6VXNlcjE3NTMw","avatar_url":"https://avatars1.githubusercontent.com/u/17530?v=4","gravatar_id":"","url":"https://api.github.com/users/asim","html_url":"https://github.com/asim","followers_url":"https://api.github.com/users/asim/followers","following_url":"https://api.github.com/users/asim/following{/other_user}","gists_url":"https://api.github.com/users/asim/gists{/gist_id}","starred_url":"https://api.github.com/users/asim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asim/subscriptions","organizations_url":"https://api.github.com/users/asim/orgs","repos_url":"https://api.github.com/users/asim/repos","events_url":"https://api.github.com/users/asim/events{/privacy}","received_events_url":"https://api.github.com/users/asim/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":45,"deletions":9,"changed_files":2}}
{"actor":{"display_login":"asim"}}