{"action":"created","issue":{"url":"https://api.github.com/repos/apache/kafka/issues/3849","repository_url":"https://api.github.com/repos/apache/kafka","labels_url":"https://api.github.com/repos/apache/kafka/issues/3849/labels{/name}","comments_url":"https://api.github.com/repos/apache/kafka/issues/3849/comments","events_url":"https://api.github.com/repos/apache/kafka/issues/3849/events","html_url":"https://github.com/apache/kafka/pull/3849","id":257463182,"node_id":"MDExOlB1bGxSZXF1ZXN0MTQwODg3NjM5","number":3849,"title":"KAFKA-5886: Implement KIP-91 delivery.timeout.ms","user":{"login":"sutambe","id":1181418,"node_id":"MDQ6VXNlcjExODE0MTg=","avatar_url":"https://avatars0.githubusercontent.com/u/1181418?v=4","gravatar_id":"","url":"https://api.github.com/users/sutambe","html_url":"https://github.com/sutambe","followers_url":"https://api.github.com/users/sutambe/followers","following_url":"https://api.github.com/users/sutambe/following{/other_user}","gists_url":"https://api.github.com/users/sutambe/gists{/gist_id}","starred_url":"https://api.github.com/users/sutambe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sutambe/subscriptions","organizations_url":"https://api.github.com/users/sutambe/orgs","repos_url":"https://api.github.com/users/sutambe/repos","events_url":"https://api.github.com/users/sutambe/events{/privacy}","received_events_url":"https://api.github.com/users/sutambe/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":65,"created_at":"2017-09-13T17:40:32Z","updated_at":"2018-06-01T05:18:09Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/kafka/pulls/3849","html_url":"https://github.com/apache/kafka/pull/3849","diff_url":"https://github.com/apache/kafka/pull/3849.diff","patch_url":"https://github.com/apache/kafka/pull/3849.patch"},"body":"First shot at implementing kip-91 `delivery.timeout.ms`. Summary\r\n\r\n1. Added `delivery.timeout.ms` config. Default 120,000\r\n2. Changed `retries` to `MAX_INT`.\r\n3. batches may expire whether they are inflight or not. So muted is no longer used in `RecordAccumulator.expiredBatches`.\r\n4. In some rare situations batch.done may be called twice. Attempted transitions from failed to succeeded are logged. Successful to successful is an error (exception as before). Other transitions (failed-->aborted, aborted-->failed) are ignored.\r\n5. The old test from `RecordAccumulatorTest` is removed. It has three additional tests. `testExpiredBatchSingle`, `testExpiredBatchesSize`, `testExpiredBatchesRetry`. All of them test that expiry is independent of muted."},"comment":{"url":"https://api.github.com/repos/apache/kafka/issues/comments/393760744","html_url":"https://github.com/apache/kafka/pull/3849#issuecomment-393760744","issue_url":"https://api.github.com/repos/apache/kafka/issues/3849","id":393760744,"node_id":"MDEyOklzc3VlQ29tbWVudDM5Mzc2MDc0NA==","user":{"login":"yuyang08","id":1988004,"node_id":"MDQ6VXNlcjE5ODgwMDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1988004?v=4","gravatar_id":"","url":"https://api.github.com/users/yuyang08","html_url":"https://github.com/yuyang08","followers_url":"https://api.github.com/users/yuyang08/followers","following_url":"https://api.github.com/users/yuyang08/following{/other_user}","gists_url":"https://api.github.com/users/yuyang08/gists{/gist_id}","starred_url":"https://api.github.com/users/yuyang08/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuyang08/subscriptions","organizations_url":"https://api.github.com/users/yuyang08/orgs","repos_url":"https://api.github.com/users/yuyang08/repos","events_url":"https://api.github.com/users/yuyang08/events{/privacy}","received_events_url":"https://api.github.com/users/yuyang08/received_events","type":"User","site_admin":false},"created_at":"2018-06-01T05:18:09Z","updated_at":"2018-06-01T05:18:09Z","author_association":"NONE","body":"@guozhangwang  sure.  will create a separate pull request "}}
{"actor":{"display_login":"yuyang08"}}