{"action":"created","comment":{"url":"https://api.github.com/repos/helm/charts/pulls/comments/228715015","pull_request_review_id":169057734,"id":228715015,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODcxNTAxNQ==","diff_hunk":"@@ -39,13 +39,11 @@ data:\n         ping.unicast.hosts: ${DISCOVERY_SERVICE:}\n         minimum_master_nodes: ${MINIMUM_MASTER_NODES:2}\n \n-{{- if .Values.cluster.xpackEnable }}","path":"stable/elasticsearch/templates/configmap.yaml","position":4,"original_position":4,"commit_id":"cde346e3ffee24e0916b3c8ebfaa69da218f2a78","original_commit_id":"8812aca2dcb834eef243fdf7b739117bcf7bed98","user":{"login":"rendhalver","id":1026337,"node_id":"MDQ6VXNlcjEwMjYzMzc=","avatar_url":"https://avatars1.githubusercontent.com/u/1026337?v=4","gravatar_id":"","url":"https://api.github.com/users/rendhalver","html_url":"https://github.com/rendhalver","followers_url":"https://api.github.com/users/rendhalver/followers","following_url":"https://api.github.com/users/rendhalver/following{/other_user}","gists_url":"https://api.github.com/users/rendhalver/gists{/gist_id}","starred_url":"https://api.github.com/users/rendhalver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rendhalver/subscriptions","organizations_url":"https://api.github.com/users/rendhalver/orgs","repos_url":"https://api.github.com/users/rendhalver/repos","events_url":"https://api.github.com/users/rendhalver/events{/privacy}","received_events_url":"https://api.github.com/users/rendhalver/received_events","type":"User","site_admin":false},"body":"The default in the chart is the `elasticsearch-oss` container which does not have xpack so this will break clusters using that.\r\nIf you aren't using the default image you need to maintain the xpack setup yourself.","created_at":"2018-10-27T14:39:31Z","updated_at":"2018-10-27T14:39:31Z","html_url":"https://github.com/helm/charts/pull/8685#discussion_r228715015","pull_request_url":"https://api.github.com/repos/helm/charts/pulls/8685","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/helm/charts/pulls/comments/228715015"},"html":{"href":"https://github.com/helm/charts/pull/8685#discussion_r228715015"},"pull_request":{"href":"https://api.github.com/repos/helm/charts/pulls/8685"}},"in_reply_to_id":227751950},"pull_request":{"url":"https://api.github.com/repos/helm/charts/pulls/8685","id":225323019,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1MzIzMDE5","html_url":"https://github.com/helm/charts/pull/8685","diff_url":"https://github.com/helm/charts/pull/8685.diff","patch_url":"https://github.com/helm/charts/pull/8685.patch","issue_url":"https://api.github.com/repos/helm/charts/issues/8685","number":8685,"state":"open","locked":false,"title":"[Elasticsearch] Fix xpack check on configMap","user":{"login":"RTodorov","id":3506845,"node_id":"MDQ6VXNlcjM1MDY4NDU=","avatar_url":"https://avatars0.githubusercontent.com/u/3506845?v=4","gravatar_id":"","url":"https://api.github.com/users/RTodorov","html_url":"https://github.com/RTodorov","followers_url":"https://api.github.com/users/RTodorov/followers","following_url":"https://api.github.com/users/RTodorov/following{/other_user}","gists_url":"https://api.github.com/users/RTodorov/gists{/gist_id}","starred_url":"https://api.github.com/users/RTodorov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RTodorov/subscriptions","organizations_url":"https://api.github.com/users/RTodorov/orgs","repos_url":"https://api.github.com/users/RTodorov/repos","events_url":"https://api.github.com/users/RTodorov/events{/privacy}","received_events_url":"https://api.github.com/users/RTodorov/received_events","type":"User","site_admin":false},"body":"#### What this PR does / why we need it:\r\nfixes #6971. \r\n\r\n> The official ES5 image ships with x-pack installed and enabled, which means authentication is also enabled. This results in the readinessProbe getting a 401, thus not registering the nodes as ready, which means they won't be registered with the headless service.\r\n\r\nBy simply removing the if statement, we force the xpack configuration to either the env vars or the defaults, which fixes this behavior from ES5.\r\n\r\n#### Checklist\r\n- [x] [DCO](https://www.helm.sh/blog/helm-dco/index.html) signed\r\n- [x] Chart Version bumped\r\n","created_at":"2018-10-24T09:11:46Z","updated_at":"2018-10-27T14:39:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bf45c5ca5ad79f91bb085c891a87e41af996bf2c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"icereval","id":3111541,"node_id":"MDQ6VXNlcjMxMTE1NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/3111541?v=4","gravatar_id":"","url":"https://api.github.com/users/icereval","html_url":"https://github.com/icereval","followers_url":"https://api.github.com/users/icereval/followers","following_url":"https://api.github.com/users/icereval/following{/other_user}","gists_url":"https://api.github.com/users/icereval/gists{/gist_id}","starred_url":"https://api.github.com/users/icereval/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/icereval/subscriptions","organizations_url":"https://api.github.com/users/icereval/orgs","repos_url":"https://api.github.com/users/icereval/repos","events_url":"https://api.github.com/users/icereval/events{/privacy}","received_events_url":"https://api.github.com/users/icereval/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1037076588,"node_id":"MDU6TGFiZWwxMDM3MDc2NTg4","url":"https://api.github.com/repos/helm/charts/labels/Contribution%20Allowed","name":"Contribution Allowed","color":"3df47d","default":false},{"id":582594847,"node_id":"MDU6TGFiZWw1ODI1OTQ4NDc=","url":"https://api.github.com/repos/helm/charts/labels/needs-ok-to-test","name":"needs-ok-to-test","color":"b60205","default":false},{"id":676475149,"node_id":"MDU6TGFiZWw2NzY0NzUxNDk=","url":"https://api.github.com/repos/helm/charts/labels/size/XS","name":"size/XS","color":"009900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/helm/charts/pulls/8685/commits","review_comments_url":"https://api.github.com/repos/helm/charts/pulls/8685/comments","review_comment_url":"https://api.github.com/repos/helm/charts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/helm/charts/issues/8685/comments","statuses_url":"https://api.github.com/repos/helm/charts/statuses/cde346e3ffee24e0916b3c8ebfaa69da218f2a78","head":{"label":"RTodorov:hotfix/elasticsearch-fix-xpack","ref":"hotfix/elasticsearch-fix-xpack","sha":"cde346e3ffee24e0916b3c8ebfaa69da218f2a78","user":{"login":"RTodorov","id":3506845,"node_id":"MDQ6VXNlcjM1MDY4NDU=","avatar_url":"https://avatars0.githubusercontent.com/u/3506845?v=4","gravatar_id":"","url":"https://api.github.com/users/RTodorov","html_url":"https://github.com/RTodorov","followers_url":"https://api.github.com/users/RTodorov/followers","following_url":"https://api.github.com/users/RTodorov/following{/other_user}","gists_url":"https://api.github.com/users/RTodorov/gists{/gist_id}","starred_url":"https://api.github.com/users/RTodorov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RTodorov/subscriptions","organizations_url":"https://api.github.com/users/RTodorov/orgs","repos_url":"https://api.github.com/users/RTodorov/repos","events_url":"https://api.github.com/users/RTodorov/events{/privacy}","received_events_url":"https://api.github.com/users/RTodorov/received_events","type":"User","site_admin":false},"repo":{"id":153431719,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM0MzE3MTk=","name":"charts","full_name":"RTodorov/charts","private":false,"owner":{"login":"RTodorov","id":3506845,"node_id":"MDQ6VXNlcjM1MDY4NDU=","avatar_url":"https://avatars0.githubusercontent.com/u/3506845?v=4","gravatar_id":"","url":"https://api.github.com/users/RTodorov","html_url":"https://github.com/RTodorov","followers_url":"https://api.github.com/users/RTodorov/followers","following_url":"https://api.github.com/users/RTodorov/following{/other_user}","gists_url":"https://api.github.com/users/RTodorov/gists{/gist_id}","starred_url":"https://api.github.com/users/RTodorov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RTodorov/subscriptions","organizations_url":"https://api.github.com/users/RTodorov/orgs","repos_url":"https://api.github.com/users/RTodorov/repos","events_url":"https://api.github.com/users/RTodorov/events{/privacy}","received_events_url":"https://api.github.com/users/RTodorov/received_events","type":"User","site_admin":false},"html_url":"https://github.com/RTodorov/charts","description":"Curated applications for Kubernetes","fork":true,"url":"https://api.github.com/repos/RTodorov/charts","forks_url":"https://api.github.com/repos/RTodorov/charts/forks","keys_url":"https://api.github.com/repos/RTodorov/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RTodorov/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RTodorov/charts/teams","hooks_url":"https://api.github.com/repos/RTodorov/charts/hooks","issue_events_url":"https://api.github.com/repos/RTodorov/charts/issues/events{/number}","events_url":"https://api.github.com/repos/RTodorov/charts/events","assignees_url":"https://api.github.com/repos/RTodorov/charts/assignees{/user}","branches_url":"https://api.github.com/repos/RTodorov/charts/branches{/branch}","tags_url":"https://api.github.com/repos/RTodorov/charts/tags","blobs_url":"https://api.github.com/repos/RTodorov/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RTodorov/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RTodorov/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/RTodorov/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RTodorov/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/RTodorov/charts/languages","stargazers_url":"https://api.github.com/repos/RTodorov/charts/stargazers","contributors_url":"https://api.github.com/repos/RTodorov/charts/contributors","subscribers_url":"https://api.github.com/repos/RTodorov/charts/subscribers","subscription_url":"https://api.github.com/repos/RTodorov/charts/subscription","commits_url":"https://api.github.com/repos/RTodorov/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/RTodorov/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/RTodorov/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/RTodorov/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/RTodorov/charts/contents/{+path}","compare_url":"https://api.github.com/repos/RTodorov/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RTodorov/charts/merges","archive_url":"https://api.github.com/repos/RTodorov/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RTodorov/charts/downloads","issues_url":"https://api.github.com/repos/RTodorov/charts/issues{/number}","pulls_url":"https://api.github.com/repos/RTodorov/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/RTodorov/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/RTodorov/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RTodorov/charts/labels{/name}","releases_url":"https://api.github.com/repos/RTodorov/charts/releases{/id}","deployments_url":"https://api.github.com/repos/RTodorov/charts/deployments","created_at":"2018-10-17T09:35:08Z","updated_at":"2018-10-17T09:35:14Z","pushed_at":"2018-10-24T17:25:16Z","git_url":"git://github.com/RTodorov/charts.git","ssh_url":"git@github.com:RTodorov/charts.git","clone_url":"https://github.com/RTodorov/charts.git","svn_url":"https://github.com/RTodorov/charts","homepage":"","size":13527,"stargazers_count":0,"watchers_count":0,"language":"Smarty","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"helm:master","ref":"master","sha":"9cc624867e3e1035c616e1574d821cf02d3775f2","user":{"login":"helm","id":15859888,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1ODU5ODg4","avatar_url":"https://avatars2.githubusercontent.com/u/15859888?v=4","gravatar_id":"","url":"https://api.github.com/users/helm","html_url":"https://github.com/helm","followers_url":"https://api.github.com/users/helm/followers","following_url":"https://api.github.com/users/helm/following{/other_user}","gists_url":"https://api.github.com/users/helm/gists{/gist_id}","starred_url":"https://api.github.com/users/helm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helm/subscriptions","organizations_url":"https://api.github.com/users/helm/orgs","repos_url":"https://api.github.com/users/helm/repos","events_url":"https://api.github.com/users/helm/events{/privacy}","received_events_url":"https://api.github.com/users/helm/received_events","type":"Organization","site_admin":false},"repo":{"id":46806184,"node_id":"MDEwOlJlcG9zaXRvcnk0NjgwNjE4NA==","name":"charts","full_name":"helm/charts","private":false,"owner":{"login":"helm","id":15859888,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1ODU5ODg4","avatar_url":"https://avatars2.githubusercontent.com/u/15859888?v=4","gravatar_id":"","url":"https://api.github.com/users/helm","html_url":"https://github.com/helm","followers_url":"https://api.github.com/users/helm/followers","following_url":"https://api.github.com/users/helm/following{/other_user}","gists_url":"https://api.github.com/users/helm/gists{/gist_id}","starred_url":"https://api.github.com/users/helm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helm/subscriptions","organizations_url":"https://api.github.com/users/helm/orgs","repos_url":"https://api.github.com/users/helm/repos","events_url":"https://api.github.com/users/helm/events{/privacy}","received_events_url":"https://api.github.com/users/helm/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/helm/charts","description":"Curated applications for Kubernetes","fork":false,"url":"https://api.github.com/repos/helm/charts","forks_url":"https://api.github.com/repos/helm/charts/forks","keys_url":"https://api.github.com/repos/helm/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/helm/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/helm/charts/teams","hooks_url":"https://api.github.com/repos/helm/charts/hooks","issue_events_url":"https://api.github.com/repos/helm/charts/issues/events{/number}","events_url":"https://api.github.com/repos/helm/charts/events","assignees_url":"https://api.github.com/repos/helm/charts/assignees{/user}","branches_url":"https://api.github.com/repos/helm/charts/branches{/branch}","tags_url":"https://api.github.com/repos/helm/charts/tags","blobs_url":"https://api.github.com/repos/helm/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/helm/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/helm/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/helm/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/helm/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/helm/charts/languages","stargazers_url":"https://api.github.com/repos/helm/charts/stargazers","contributors_url":"https://api.github.com/repos/helm/charts/contributors","subscribers_url":"https://api.github.com/repos/helm/charts/subscribers","subscription_url":"https://api.github.com/repos/helm/charts/subscription","commits_url":"https://api.github.com/repos/helm/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/helm/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/helm/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/helm/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/helm/charts/contents/{+path}","compare_url":"https://api.github.com/repos/helm/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/helm/charts/merges","archive_url":"https://api.github.com/repos/helm/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/helm/charts/downloads","issues_url":"https://api.github.com/repos/helm/charts/issues{/number}","pulls_url":"https://api.github.com/repos/helm/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/helm/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/helm/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/helm/charts/labels{/name}","releases_url":"https://api.github.com/repos/helm/charts/releases{/id}","deployments_url":"https://api.github.com/repos/helm/charts/deployments","created_at":"2015-11-24T17:05:28Z","updated_at":"2018-10-27T13:31:28Z","pushed_at":"2018-10-27T12:17:01Z","git_url":"git://github.com/helm/charts.git","ssh_url":"git@github.com:helm/charts.git","clone_url":"https://github.com/helm/charts.git","svn_url":"https://github.com/helm/charts","homepage":"","size":13666,"stargazers_count":5304,"watchers_count":5304,"language":"Smarty","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4706,"mirror_url":null,"archived":false,"open_issues_count":596,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4706,"open_issues":596,"watchers":5304,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/helm/charts/pulls/8685"},"html":{"href":"https://github.com/helm/charts/pull/8685"},"issue":{"href":"https://api.github.com/repos/helm/charts/issues/8685"},"comments":{"href":"https://api.github.com/repos/helm/charts/issues/8685/comments"},"review_comments":{"href":"https://api.github.com/repos/helm/charts/pulls/8685/comments"},"review_comment":{"href":"https://api.github.com/repos/helm/charts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/helm/charts/pulls/8685/commits"},"statuses":{"href":"https://api.github.com/repos/helm/charts/statuses/cde346e3ffee24e0916b3c8ebfaa69da218f2a78"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rendhalver"}}