{"push_id":2489404495,"size":28,"distinct_size":28,"ref":"refs/heads/master","head":"acd5ba79dadbc30e1f9170e0365868f275667f38","before":"a2eca4878638db0577c7a1e8616cc5de1fc8acea","commits":[{"sha":"8decca1b88b8ff1e7353e82f826359c08c1b91ee","author":{"name":"mijiturka","email":"0be97cd8472a64d0e116656bfa0fb8cd7810c07c@tuta.io"},"message":"Merge remote-tracking branch 'upstream/master' into persist-origin-options-1706","distinct":true,"url":"https://api.github.com/repos/EFForg/privacybadger/commits/8decca1b88b8ff1e7353e82f826359c08c1b91ee"},{"sha":"89b6e45eb84593658daa4a4dfcd588e47f46a5df","author":{"name":"mijiturka","email":"0be97cd8472a64d0e116656bfa0fb8cd7810c07c@tuta.io"},"message":"Simple refactoring for updateOrigin()\n\nAdd comments and slightly reorder for better flow (I think).\nAdded this because it helps me understand the codebase,\ncommitting it because of the refactoring TODO at the top of options.js","distinct":true,"url":"https://api.github.com/repos/EFForg/privacybadger/commits/89b6e45eb84593658daa4a4dfcd588e47f46a5df"},{"sha":"67bb1d5b25dab93836f54d80760ee67d710c2328","author":{"name":"mijiturka","email":"0be97cd8472a64d0e116656bfa0fb8cd7810c07c@tuta.io"},"message":"Rename refreshFilterPage to reloadTrackingDomainsTab\n\nIt took me a while to understand that what is called a \"filter page\" is an options tab.\nIs that just me?\n\nSeems to be an artifact from Adblock Plus:\nhttps://github.com/EFForg/privacybadger/blame/d2b5553711de3d4ff6614eecf573eb5c2e744544/src/js/options.js#L124\nIt uses the word \"filters\" to refer to what is in Privacy Badger called \"origins\", \"domains\" or\n\"tracking domains\".\n\nAdditonally, now that there are actual filters in the Tracking Domains tab, this FilterPage gets\neven more confusing.","distinct":true,"url":"https://api.github.com/repos/EFForg/privacybadger/commits/67bb1d5b25dab93836f54d80760ee67d710c2328"},{"sha":"6f45ad4d5a57988796e725667504c630621c840d","author":{"name":"mijiturka","email":"0be97cd8472a64d0e116656bfa0fb8cd7810c07c@tuta.io"},"message":"Register handlers for domain switch toggles generated on scroll\n\nThis keeps the behaviour of reloading the options tab on change,\nbut it also does it for the domains generated on scroll (all of the\nones after the first 50) - so user changes are persisted.","distinct":true,"url":"https://api.github.com/repos/EFForg/privacybadger/commits/6f45ad4d5a57988796e725667504c630621c840d"},{"sha":"b5e4d6ce596be2cc3f8c1d95e192656b09dc5884","author":{"name":"mijiturka","email":"0be97cd8472a64d0e116656bfa0fb8cd7810c07c@tuta.io"},"message":"Merge remote-tracking branch 'upstream/master' into persist-origin-options-1706","distinct":true,"url":"https://api.github.com/repos/EFForg/privacybadger/commits/b5e4d6ce596be2cc3f8c1d95e192656b09dc5884"},{"sha":"a2e7819074a1ece10f055e6194b0a11c62992cf3","author":{"name":"mijiturka","email":"0be97cd8472a64d0e116656bfa0fb8cd7810c07c@tuta.io"},"message":"Add intital test for persisting user overwrite on options page\n\nBlock a domain and check that it's still blocked after refreshing\nthe options page","distinct":true,"url":"https://api.github.com/repos/EFForg/privacybadger/commits/a2e7819074a1ece10f055e6194b0a11c62992cf3"},{"sha":"a06cbf3896ff68c1c2738e5225626b63afb294db","author":{"name":"mijiturka","email":"0be97cd8472a64d0e116656bfa0fb8cd7810c07c@tuta.io"},"message":"User preferences change tests for each transition\n\nThese are separate tests because of the unrelated issue which\nsometimes resets unrelated origins when there are multiple\npresent (#1863)","distinct":true,"url":"https://api.github.com/repos/EFForg/privacybadger/commits/a06cbf3896ff68c1c2738e5225626b63afb294db"},{"sha":"e99859518c80e9e5ef8a85fdbe02c52e60f0ab2c","author":{"name":"mijiturka","email":"0be97cd8472a64d0e116656bfa0fb8cd7810c07c@tuta.io"},"message":"Scroll test initial attempt","distinct":true,"url":"https://api.github.com/repos/EFForg/privacybadger/commits/e99859518c80e9e5ef8a85fdbe02c52e60f0ab2c"},{"sha":"edd295839c31952014ac2359e71efe646de26b39","author":{"name":"mijiturka","email":"0be97cd8472a64d0e116656bfa0fb8cd7810c07c@tuta.io"},"message":"Add test for origins generated on scroll\n\nBy generating 51 elements in alphabetical order, getting the last\nlast one (the first to be generated on scroll), overwriting its\nblocking preference, and checking changes have been persisted\nafter options page refresh.","distinct":true,"url":"https://api.github.com/repos/EFForg/privacybadger/commits/edd295839c31952014ac2359e71efe646de26b39"},{"sha":"9b15b7f3842d420dbbebfce9a4eadad11162731a","author":{"name":"mijiturka","email":"0be97cd8472a64d0e116656bfa0fb8cd7810c07c@tuta.io"},"message":"Clean up","distinct":true,"url":"https://api.github.com/repos/EFForg/privacybadger/commits/9b15b7f3842d420dbbebfce9a4eadad11162731a"},{"sha":"e6ed528b7e37c10ff7d55e181c69bb2c8ed8e663","author":{"name":"mijiturka","email":"0be97cd8472a64d0e116656bfa0fb8cd7810c07c@tuta.io"},"message":"Merge remote-tracking branch 'upstream/master' into persist-origin-options-1706","distinct":true,"url":"https://api.github.com/repos/EFForg/privacybadger/commits/e6ed528b7e37c10ff7d55e181c69bb2c8ed8e663"},{"sha":"9da32c3d9a95b5c2675531c88fe29d2f9185e08a","author":{"name":"mijiturka","email":"0be97cd8472a64d0e116656bfa0fb8cd7810c07c@tuta.io"},"message":"Merge remote-tracking branch 'upstream/master' into persist-origin-options-1706","distinct":true,"url":"https://api.github.com/repos/EFForg/privacybadger/commits/9da32c3d9a95b5c2675531c88fe29d2f9185e08a"},{"sha":"ebb9ac697740d575c327c367bda9ad9b9cc33dd8","author":{"name":"mijiturka","email":"0be97cd8472a64d0e116656bfa0fb8cd7810c07c@tuta.io"},"message":"Merge branch 'persist-origin-options-1706' of https://github.com/mijiturka/privacybadger into persist-origin-options-1706","distinct":true,"url":"https://api.github.com/repos/EFForg/privacybadger/commits/ebb9ac697740d575c327c367bda9ad9b9cc33dd8"},{"sha":"064ded1dba62b696cb79f2107f6e7e10109193f7","author":{"name":"mijiturka","email":"0be97cd8472a64d0e116656bfa0fb8cd7810c07c@tuta.io"},"message":"Fix Chromium tests\n\nAs it throws ElementNotVisibleException instead of ElementNotInteractableException","distinct":true,"url":"https://api.github.com/repos/EFForg/privacybadger/commits/064ded1dba62b696cb79f2107f6e7e10109193f7"},{"sha":"bee0ba44b0af2ac5941c66720c25b084d2e437fa","author":{"name":"mijiturka","email":"0be97cd8472a64d0e116656bfa0fb8cd7810c07c@tuta.io"},"message":"Avoid double slider handler registration + PR comments\n\n* Ensure sliders are not registered twice on scroll\n* Remove redundant exception when handling tracking domains checkbox\n* Remove redundant cast of jQuery object to jQuery object\n* Improve comments\n* Add a temporary sleep to track Travis test failures","distinct":true,"url":"https://api.github.com/repos/EFForg/privacybadger/commits/bee0ba44b0af2ac5941c66720c25b084d2e437fa"},{"sha":"5a0f025b073e6735f9306983aadee9000ad7db75","author":{"name":"mijiturka","email":"0be97cd8472a64d0e116656bfa0fb8cd7810c07c@tuta.io"},"message":"Fix merge conflict / Merge remote-tracking branch 'upstream/master' into persist-origin-options-1706","distinct":true,"url":"https://api.github.com/repos/EFForg/privacybadger/commits/5a0f025b073e6735f9306983aadee9000ad7db75"},{"sha":"a1380a0dc3d077fef6e7de5e42e0b9d6c2079635","author":{"name":"mijiturka","email":"0be97cd8472a64d0e116656bfa0fb8cd7810c07c@tuta.io"},"message":"Fix slider handler margins\n\nNeed to use \"this\" inside the create callback because the slider child\nof the switch toggle doesn't exist yet.\nWe add the margin to have the slider handle positioned at the beginning\nof the red/yellow/green slider element rather than its center.\nSince this is positioned inside the wider slider handle, the absolute position\nneeds to be calculated according to the blocked/cookieblocked/allowed value in JS.\nIt might be possible to avoid this 1) if the handler can work with its handler in\nthe center or 2) in CSS if the slider handle was made in a different way.\n\nThe this in the stop callback is also different, but it doesn't matter\nbecause it is used to find a parent of both the switch toggle and slider handler.\n\nAdded comments popup.js too to avoid future confusion.","distinct":true,"url":"https://api.github.com/repos/EFForg/privacybadger/commits/a1380a0dc3d077fef6e7de5e42e0b9d6c2079635"},{"sha":"074eb120f6e724cfbe83d2f02c425b8ce112e3ac","author":{"name":"mijiturka","email":"0be97cd8472a64d0e116656bfa0fb8cd7810c07c@tuta.io"},"message":"Fix test for origins generated on scroll in options page\n\nSeveral scrolls to the bottom of blockedResourcesInner are needed\nto actually scroll to the bottom of the \"endless\" scroll, since\neach one creates a new origin and alters the height of the scrollable\nbox.","distinct":true,"url":"https://api.github.com/repos/EFForg/privacybadger/commits/074eb120f6e724cfbe83d2f02c425b8ce112e3ac"},{"sha":"a3c7942957ba5dcc23bf8218457a94a3f03917f8","author":{"name":"mijiturka","email":"0be97cd8472a64d0e116656bfa0fb8cd7810c07c@tuta.io"},"message":"Scroll twice everywhere in options scroll test","distinct":true,"url":"https://api.github.com/repos/EFForg/privacybadger/commits/a3c7942957ba5dcc23bf8218457a94a3f03917f8"},{"sha":"b95cd45e9936c98694c97935d38cb62e0e3ed139","author":{"name":"mijiturka","email":"0be97cd8472a64d0e116656bfa0fb8cd7810c07c@tuta.io"},"message":"Scroll twice everywhere in options scroll test","distinct":true,"url":"https://api.github.com/repos/EFForg/privacybadger/commits/b95cd45e9936c98694c97935d38cb62e0e3ed139"}]}
{"actor":{"display_login":"ghostwords"}}