{"action":"created","issue":{"url":"https://api.github.com/repos/theolampert/react-flickity-component/issues/29","repository_url":"https://api.github.com/repos/theolampert/react-flickity-component","labels_url":"https://api.github.com/repos/theolampert/react-flickity-component/issues/29/labels{/name}","comments_url":"https://api.github.com/repos/theolampert/react-flickity-component/issues/29/comments","events_url":"https://api.github.com/repos/theolampert/react-flickity-component/issues/29/events","html_url":"https://github.com/theolampert/react-flickity-component/pull/29","id":315941492,"node_id":"MDExOlB1bGxSZXF1ZXN0MTgyODI0Mjc5","number":29,"title":"Adds option to destroy on unmount, fixes #28","user":{"login":"danielmahon","id":1088089,"node_id":"MDQ6VXNlcjEwODgwODk=","avatar_url":"https://avatars2.githubusercontent.com/u/1088089?v=4","gravatar_id":"","url":"https://api.github.com/users/danielmahon","html_url":"https://github.com/danielmahon","followers_url":"https://api.github.com/users/danielmahon/followers","following_url":"https://api.github.com/users/danielmahon/following{/other_user}","gists_url":"https://api.github.com/users/danielmahon/gists{/gist_id}","starred_url":"https://api.github.com/users/danielmahon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielmahon/subscriptions","organizations_url":"https://api.github.com/users/danielmahon/orgs","repos_url":"https://api.github.com/users/danielmahon/repos","events_url":"https://api.github.com/users/danielmahon/events{/privacy}","received_events_url":"https://api.github.com/users/danielmahon/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2018-04-19T16:00:58Z","updated_at":"2018-07-09T13:41:49Z","closed_at":"2018-04-20T12:53:01Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/theolampert/react-flickity-component/pulls/29","html_url":"https://github.com/theolampert/react-flickity-component/pull/29","diff_url":"https://github.com/theolampert/react-flickity-component/pull/29.diff","patch_url":"https://github.com/theolampert/react-flickity-component/pull/29.patch"},"body":"I \"think\" this is correct solution, but I could be wrong.\r\n\r\nAdds option to destroy flickity on unmount, because if you are conditionally rendering Flickity, `this.flkty.destroy();` will try to access a dom element that isn't there, causing swallowed exceptions when doing things like navigating via `react-router`. So in this case you would want to skip the destroy method and let react handle it.\r\n\r\nSigned-off-by: Daniel Mahon <danielmahon@users.noreply.github.com>"},"comment":{"url":"https://api.github.com/repos/theolampert/react-flickity-component/issues/comments/403483134","html_url":"https://github.com/theolampert/react-flickity-component/pull/29#issuecomment-403483134","issue_url":"https://api.github.com/repos/theolampert/react-flickity-component/issues/29","id":403483134,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMzQ4MzEzNA==","user":{"login":"yaodingyd","id":11392695,"node_id":"MDQ6VXNlcjExMzkyNjk1","avatar_url":"https://avatars0.githubusercontent.com/u/11392695?v=4","gravatar_id":"","url":"https://api.github.com/users/yaodingyd","html_url":"https://github.com/yaodingyd","followers_url":"https://api.github.com/users/yaodingyd/followers","following_url":"https://api.github.com/users/yaodingyd/following{/other_user}","gists_url":"https://api.github.com/users/yaodingyd/gists{/gist_id}","starred_url":"https://api.github.com/users/yaodingyd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yaodingyd/subscriptions","organizations_url":"https://api.github.com/users/yaodingyd/orgs","repos_url":"https://api.github.com/users/yaodingyd/repos","events_url":"https://api.github.com/users/yaodingyd/events{/privacy}","received_events_url":"https://api.github.com/users/yaodingyd/received_events","type":"User","site_admin":false},"created_at":"2018-07-09T13:41:49Z","updated_at":"2018-07-09T13:41:49Z","author_association":"COLLABORATOR","body":"@nikosolihin could you open a new issue with a sandbox of your problem?"}}
{"actor":{"display_login":"yaodingyd"}}