{"action":"created","issue":{"url":"https://api.github.com/repos/zurb/foundation-sites/issues/10949","repository_url":"https://api.github.com/repos/zurb/foundation-sites","labels_url":"https://api.github.com/repos/zurb/foundation-sites/issues/10949/labels{/name}","comments_url":"https://api.github.com/repos/zurb/foundation-sites/issues/10949/comments","events_url":"https://api.github.com/repos/zurb/foundation-sites/issues/10949/events","html_url":"https://github.com/zurb/foundation-sites/pull/10949","id":298005146,"number":10949,"title":"fix: consistent event name triggering in components (offcanvas)","user":{"login":"DanielRuf","id":827205,"avatar_url":"https://avatars1.githubusercontent.com/u/827205?v=4","gravatar_id":"","url":"https://api.github.com/users/DanielRuf","html_url":"https://github.com/DanielRuf","followers_url":"https://api.github.com/users/DanielRuf/followers","following_url":"https://api.github.com/users/DanielRuf/following{/other_user}","gists_url":"https://api.github.com/users/DanielRuf/gists{/gist_id}","starred_url":"https://api.github.com/users/DanielRuf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanielRuf/subscriptions","organizations_url":"https://api.github.com/users/DanielRuf/orgs","repos_url":"https://api.github.com/users/DanielRuf/repos","events_url":"https://api.github.com/users/DanielRuf/events{/privacy}","received_events_url":"https://api.github.com/users/DanielRuf/received_events","type":"User","site_admin":false},"labels":[{"id":425264255,"url":"https://api.github.com/repos/zurb/foundation-sites/labels/Off-Canvas","name":"Off-Canvas","color":"1197eb","default":false},{"id":820929536,"url":"https://api.github.com/repos/zurb/foundation-sites/labels/events","name":"events","color":"fced7e","default":false}],"state":"open","locked":false,"assignee":{"login":"ncoden","id":9939075,"avatar_url":"https://avatars2.githubusercontent.com/u/9939075?v=4","gravatar_id":"","url":"https://api.github.com/users/ncoden","html_url":"https://github.com/ncoden","followers_url":"https://api.github.com/users/ncoden/followers","following_url":"https://api.github.com/users/ncoden/following{/other_user}","gists_url":"https://api.github.com/users/ncoden/gists{/gist_id}","starred_url":"https://api.github.com/users/ncoden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncoden/subscriptions","organizations_url":"https://api.github.com/users/ncoden/orgs","repos_url":"https://api.github.com/users/ncoden/repos","events_url":"https://api.github.com/users/ncoden/events{/privacy}","received_events_url":"https://api.github.com/users/ncoden/received_events","type":"User","site_admin":false},"assignees":[{"login":"ncoden","id":9939075,"avatar_url":"https://avatars2.githubusercontent.com/u/9939075?v=4","gravatar_id":"","url":"https://api.github.com/users/ncoden","html_url":"https://github.com/ncoden","followers_url":"https://api.github.com/users/ncoden/followers","following_url":"https://api.github.com/users/ncoden/following{/other_user}","gists_url":"https://api.github.com/users/ncoden/gists{/gist_id}","starred_url":"https://api.github.com/users/ncoden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncoden/subscriptions","organizations_url":"https://api.github.com/users/ncoden/orgs","repos_url":"https://api.github.com/users/ncoden/repos","events_url":"https://api.github.com/users/ncoden/events{/privacy}","received_events_url":"https://api.github.com/users/ncoden/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/zurb/foundation-sites/milestones/35","html_url":"https://github.com/zurb/foundation-sites/milestone/35","labels_url":"https://api.github.com/repos/zurb/foundation-sites/milestones/35/labels","id":2555028,"number":35,"title":"6.5.0","description":"","creator":{"login":"kball","id":44007,"avatar_url":"https://avatars0.githubusercontent.com/u/44007?v=4","gravatar_id":"","url":"https://api.github.com/users/kball","html_url":"https://github.com/kball","followers_url":"https://api.github.com/users/kball/followers","following_url":"https://api.github.com/users/kball/following{/other_user}","gists_url":"https://api.github.com/users/kball/gists{/gist_id}","starred_url":"https://api.github.com/users/kball/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kball/subscriptions","organizations_url":"https://api.github.com/users/kball/orgs","repos_url":"https://api.github.com/users/kball/repos","events_url":"https://api.github.com/users/kball/events{/privacy}","received_events_url":"https://api.github.com/users/kball/received_events","type":"User","site_admin":false},"open_issues":16,"closed_issues":7,"state":"open","created_at":"2017-05-31T23:22:34Z","updated_at":"2018-02-18T15:29:01Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2018-02-17T13:33:33Z","updated_at":"2018-02-19T13:40:50Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/zurb/foundation-sites/pulls/10949","html_url":"https://github.com/zurb/foundation-sites/pull/10949","diff_url":"https://github.com/zurb/foundation-sites/pull/10949.diff","patch_url":"https://github.com/zurb/foundation-sites/pull/10949.patch"},"body":"## offcanvas\r\n* rename closed.zf.offcanvas to close.zf.offcanvas\r\n* trigger closed.zf.offcanvas when the transition has ended\r\n* tests: change test for close.zf.offcanvas, add test for closed.zf.off\r\n\r\nSee #8727\r\n\r\n- [x] update / add unit test\r\n- [x] update docs"},"comment":{"url":"https://api.github.com/repos/zurb/foundation-sites/issues/comments/366695985","html_url":"https://github.com/zurb/foundation-sites/pull/10949#issuecomment-366695985","issue_url":"https://api.github.com/repos/zurb/foundation-sites/issues/10949","id":366695985,"user":{"login":"ncoden","id":9939075,"avatar_url":"https://avatars2.githubusercontent.com/u/9939075?v=4","gravatar_id":"","url":"https://api.github.com/users/ncoden","html_url":"https://github.com/ncoden","followers_url":"https://api.github.com/users/ncoden/followers","following_url":"https://api.github.com/users/ncoden/following{/other_user}","gists_url":"https://api.github.com/users/ncoden/gists{/gist_id}","starred_url":"https://api.github.com/users/ncoden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncoden/subscriptions","organizations_url":"https://api.github.com/users/ncoden/orgs","repos_url":"https://api.github.com/users/ncoden/repos","events_url":"https://api.github.com/users/ncoden/events{/privacy}","received_events_url":"https://api.github.com/users/ncoden/received_events","type":"User","site_admin":false},"created_at":"2018-02-19T13:40:50Z","updated_at":"2018-02-19T13:40:50Z","author_association":"MEMBER","body":"@SassNinja I don't think, because the problem would be that they _assume_ that the `closed.zf.offcanvas` event is triggered before the transition, and we do not know what makes them assuming that.\r\n\r\nSo everything we can do is a clear migration note in the release."}}
{"actor":{"display_login":"ncoden"}}