{"action":"created","comment":{"url":"https://api.github.com/repos/ccxt/ccxt/pulls/comments/245442223","pull_request_review_id":189556358,"id":245442223,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTQ0MjIyMw==","diff_hunk":"@@ -784,6 +785,15 @@ module.exports = class binance extends Exchange {\n         else\n             request['orderId'] = parseInt (id);\n         let response = await this.privateGetOrder (this.extend (request, params));\n+        if(response['fills'] === undefined && this.options['loadTradesForOrder']) {\n+            let requestTrades = {\n+                'symbol': market['id'],\n+                'startTime': request['transactTime'],\n+            };\n+            let trades = await this.privateGetMyTrades (requestTrades); // temporary slow workaround todo implement caching layer","path":"js/binance.js","position":17,"original_position":17,"commit_id":"b5659d22b888ef103ac0e81103f7f6f3a9d20cf7","original_commit_id":"b5659d22b888ef103ac0e81103f7f6f3a9d20cf7","user":{"login":"kroitor","id":1294454,"node_id":"MDQ6VXNlcjEyOTQ0NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1294454?v=4","gravatar_id":"","url":"https://api.github.com/users/kroitor","html_url":"https://github.com/kroitor","followers_url":"https://api.github.com/users/kroitor/followers","following_url":"https://api.github.com/users/kroitor/following{/other_user}","gists_url":"https://api.github.com/users/kroitor/gists{/gist_id}","starred_url":"https://api.github.com/users/kroitor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kroitor/subscriptions","organizations_url":"https://api.github.com/users/kroitor/orgs","repos_url":"https://api.github.com/users/kroitor/repos","events_url":"https://api.github.com/users/kroitor/events{/privacy}","received_events_url":"https://api.github.com/users/kroitor/received_events","type":"User","site_admin":false},"body":"> all your \"not written and fixed design decisions\" \r\n\r\nThose are actually written here: https://github.com/ccxt/ccxt/blob/master/CONTRIBUTING.md#derived-exchange-classes\r\n\r\n![contributing](https://user-images.githubusercontent.com/1294454/50714880-981c4980-108b-11e9-982e-ecf3efad9120.jpg)\r\n\r\n> I wonder why someone is putting so much effort in an \"pre-version\" library instead (as you called it in the end) instead of doing it right from the beginning.\r\n\r\nBecause we're doing it right from the very beginning. You see?) We just have different views on what is right and what is wrong to do from the very beginning. We believe it is right to reach a unified state by making progress gradually – fundamentals first, more complex things and more data abstraction second.\r\n\r\nI'd close this at this point, if you don't mind. We will still be happy to hear from you in the future and to see more contributions from you.","created_at":"2019-01-04T22:50:27Z","updated_at":"2019-01-04T22:50:27Z","html_url":"https://github.com/ccxt/ccxt/pull/4431#discussion_r245442223","pull_request_url":"https://api.github.com/repos/ccxt/ccxt/pulls/4431","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ccxt/ccxt/pulls/comments/245442223"},"html":{"href":"https://github.com/ccxt/ccxt/pull/4431#discussion_r245442223"},"pull_request":{"href":"https://api.github.com/repos/ccxt/ccxt/pulls/4431"}},"in_reply_to_id":245393022},"pull_request":{"url":"https://api.github.com/repos/ccxt/ccxt/pulls/4431","id":242330278,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQyMzMwMjc4","html_url":"https://github.com/ccxt/ccxt/pull/4431","diff_url":"https://github.com/ccxt/ccxt/pull/4431.diff","patch_url":"https://github.com/ccxt/ccxt/pull/4431.patch","issue_url":"https://api.github.com/repos/ccxt/ccxt/issues/4431","number":4431,"state":"open","locked":false,"title":"Binance: Add option to fill trades for fetch order","user":{"login":"TechupBusiness","id":38460054,"node_id":"MDQ6VXNlcjM4NDYwMDU0","avatar_url":"https://avatars2.githubusercontent.com/u/38460054?v=4","gravatar_id":"","url":"https://api.github.com/users/TechupBusiness","html_url":"https://github.com/TechupBusiness","followers_url":"https://api.github.com/users/TechupBusiness/followers","following_url":"https://api.github.com/users/TechupBusiness/following{/other_user}","gists_url":"https://api.github.com/users/TechupBusiness/gists{/gist_id}","starred_url":"https://api.github.com/users/TechupBusiness/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TechupBusiness/subscriptions","organizations_url":"https://api.github.com/users/TechupBusiness/orgs","repos_url":"https://api.github.com/users/TechupBusiness/repos","events_url":"https://api.github.com/users/TechupBusiness/events{/privacy}","received_events_url":"https://api.github.com/users/TechupBusiness/received_events","type":"User","site_admin":false},"body":"Hi @kroitor, while trying to solve the issue, this is a first fix. I would set the option to true by default as it enables a \"unified object\" for binance (of course this should be also added to other exchanges later on). It's not an ideal solution (it's just returning the trades of a specific time period according to my tests, so there could be trades missing for old orders).\r\n\r\nIssue started in https://github.com/ccxt/ccxt/issues/4390, please see my last comment there.\r\n\r\nBut I would like to discuss in general the caching mechanism as this would save tons of request and speed up everything (performance and development of third party apps based on ccxt), if used properly. I sent you an email.","created_at":"2019-01-04T17:53:19Z","updated_at":"2019-01-04T22:50:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3a5de987bae91dd9b3401e1f486691f55a379e2f","assignee":{"login":"kroitor","id":1294454,"node_id":"MDQ6VXNlcjEyOTQ0NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1294454?v=4","gravatar_id":"","url":"https://api.github.com/users/kroitor","html_url":"https://github.com/kroitor","followers_url":"https://api.github.com/users/kroitor/followers","following_url":"https://api.github.com/users/kroitor/following{/other_user}","gists_url":"https://api.github.com/users/kroitor/gists{/gist_id}","starred_url":"https://api.github.com/users/kroitor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kroitor/subscriptions","organizations_url":"https://api.github.com/users/kroitor/orgs","repos_url":"https://api.github.com/users/kroitor/repos","events_url":"https://api.github.com/users/kroitor/events{/privacy}","received_events_url":"https://api.github.com/users/kroitor/received_events","type":"User","site_admin":false},"assignees":[{"login":"kroitor","id":1294454,"node_id":"MDQ6VXNlcjEyOTQ0NTQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1294454?v=4","gravatar_id":"","url":"https://api.github.com/users/kroitor","html_url":"https://github.com/kroitor","followers_url":"https://api.github.com/users/kroitor/followers","following_url":"https://api.github.com/users/kroitor/following{/other_user}","gists_url":"https://api.github.com/users/kroitor/gists{/gist_id}","starred_url":"https://api.github.com/users/kroitor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kroitor/subscriptions","organizations_url":"https://api.github.com/users/kroitor/orgs","repos_url":"https://api.github.com/users/kroitor/repos","events_url":"https://api.github.com/users/kroitor/events{/privacy}","received_events_url":"https://api.github.com/users/kroitor/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ccxt/ccxt/pulls/4431/commits","review_comments_url":"https://api.github.com/repos/ccxt/ccxt/pulls/4431/comments","review_comment_url":"https://api.github.com/repos/ccxt/ccxt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ccxt/ccxt/issues/4431/comments","statuses_url":"https://api.github.com/repos/ccxt/ccxt/statuses/b5659d22b888ef103ac0e81103f7f6f3a9d20cf7","head":{"label":"TechupBusiness:add-trades-to-binance","ref":"add-trades-to-binance","sha":"b5659d22b888ef103ac0e81103f7f6f3a9d20cf7","user":{"login":"TechupBusiness","id":38460054,"node_id":"MDQ6VXNlcjM4NDYwMDU0","avatar_url":"https://avatars2.githubusercontent.com/u/38460054?v=4","gravatar_id":"","url":"https://api.github.com/users/TechupBusiness","html_url":"https://github.com/TechupBusiness","followers_url":"https://api.github.com/users/TechupBusiness/followers","following_url":"https://api.github.com/users/TechupBusiness/following{/other_user}","gists_url":"https://api.github.com/users/TechupBusiness/gists{/gist_id}","starred_url":"https://api.github.com/users/TechupBusiness/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TechupBusiness/subscriptions","organizations_url":"https://api.github.com/users/TechupBusiness/orgs","repos_url":"https://api.github.com/users/TechupBusiness/repos","events_url":"https://api.github.com/users/TechupBusiness/events{/privacy}","received_events_url":"https://api.github.com/users/TechupBusiness/received_events","type":"User","site_admin":false},"repo":{"id":138831516,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg4MzE1MTY=","name":"ccxt","full_name":"TechupBusiness/ccxt","private":false,"owner":{"login":"TechupBusiness","id":38460054,"node_id":"MDQ6VXNlcjM4NDYwMDU0","avatar_url":"https://avatars2.githubusercontent.com/u/38460054?v=4","gravatar_id":"","url":"https://api.github.com/users/TechupBusiness","html_url":"https://github.com/TechupBusiness","followers_url":"https://api.github.com/users/TechupBusiness/followers","following_url":"https://api.github.com/users/TechupBusiness/following{/other_user}","gists_url":"https://api.github.com/users/TechupBusiness/gists{/gist_id}","starred_url":"https://api.github.com/users/TechupBusiness/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TechupBusiness/subscriptions","organizations_url":"https://api.github.com/users/TechupBusiness/orgs","repos_url":"https://api.github.com/users/TechupBusiness/repos","events_url":"https://api.github.com/users/TechupBusiness/events{/privacy}","received_events_url":"https://api.github.com/users/TechupBusiness/received_events","type":"User","site_admin":false},"html_url":"https://github.com/TechupBusiness/ccxt","description":"A JavaScript / Python / PHP cryptocurrency trading library with support for more than 100 bitcoin/altcoin exchanges","fork":true,"url":"https://api.github.com/repos/TechupBusiness/ccxt","forks_url":"https://api.github.com/repos/TechupBusiness/ccxt/forks","keys_url":"https://api.github.com/repos/TechupBusiness/ccxt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TechupBusiness/ccxt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TechupBusiness/ccxt/teams","hooks_url":"https://api.github.com/repos/TechupBusiness/ccxt/hooks","issue_events_url":"https://api.github.com/repos/TechupBusiness/ccxt/issues/events{/number}","events_url":"https://api.github.com/repos/TechupBusiness/ccxt/events","assignees_url":"https://api.github.com/repos/TechupBusiness/ccxt/assignees{/user}","branches_url":"https://api.github.com/repos/TechupBusiness/ccxt/branches{/branch}","tags_url":"https://api.github.com/repos/TechupBusiness/ccxt/tags","blobs_url":"https://api.github.com/repos/TechupBusiness/ccxt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TechupBusiness/ccxt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TechupBusiness/ccxt/git/refs{/sha}","trees_url":"https://api.github.com/repos/TechupBusiness/ccxt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TechupBusiness/ccxt/statuses/{sha}","languages_url":"https://api.github.com/repos/TechupBusiness/ccxt/languages","stargazers_url":"https://api.github.com/repos/TechupBusiness/ccxt/stargazers","contributors_url":"https://api.github.com/repos/TechupBusiness/ccxt/contributors","subscribers_url":"https://api.github.com/repos/TechupBusiness/ccxt/subscribers","subscription_url":"https://api.github.com/repos/TechupBusiness/ccxt/subscription","commits_url":"https://api.github.com/repos/TechupBusiness/ccxt/commits{/sha}","git_commits_url":"https://api.github.com/repos/TechupBusiness/ccxt/git/commits{/sha}","comments_url":"https://api.github.com/repos/TechupBusiness/ccxt/comments{/number}","issue_comment_url":"https://api.github.com/repos/TechupBusiness/ccxt/issues/comments{/number}","contents_url":"https://api.github.com/repos/TechupBusiness/ccxt/contents/{+path}","compare_url":"https://api.github.com/repos/TechupBusiness/ccxt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TechupBusiness/ccxt/merges","archive_url":"https://api.github.com/repos/TechupBusiness/ccxt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TechupBusiness/ccxt/downloads","issues_url":"https://api.github.com/repos/TechupBusiness/ccxt/issues{/number}","pulls_url":"https://api.github.com/repos/TechupBusiness/ccxt/pulls{/number}","milestones_url":"https://api.github.com/repos/TechupBusiness/ccxt/milestones{/number}","notifications_url":"https://api.github.com/repos/TechupBusiness/ccxt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TechupBusiness/ccxt/labels{/name}","releases_url":"https://api.github.com/repos/TechupBusiness/ccxt/releases{/id}","deployments_url":"https://api.github.com/repos/TechupBusiness/ccxt/deployments","created_at":"2018-06-27T04:57:51Z","updated_at":"2018-11-25T00:18:35Z","pushed_at":"2019-01-04T18:05:02Z","git_url":"git://github.com/TechupBusiness/ccxt.git","ssh_url":"git@github.com:TechupBusiness/ccxt.git","clone_url":"https://github.com/TechupBusiness/ccxt.git","svn_url":"https://github.com/TechupBusiness/ccxt","homepage":"","size":764292,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ccxt:master","ref":"master","sha":"aca9fc6d159191494ab8cb333add661b4d0e5473","user":{"login":"ccxt","id":31901609,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTAxNjA5","avatar_url":"https://avatars3.githubusercontent.com/u/31901609?v=4","gravatar_id":"","url":"https://api.github.com/users/ccxt","html_url":"https://github.com/ccxt","followers_url":"https://api.github.com/users/ccxt/followers","following_url":"https://api.github.com/users/ccxt/following{/other_user}","gists_url":"https://api.github.com/users/ccxt/gists{/gist_id}","starred_url":"https://api.github.com/users/ccxt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccxt/subscriptions","organizations_url":"https://api.github.com/users/ccxt/orgs","repos_url":"https://api.github.com/users/ccxt/repos","events_url":"https://api.github.com/users/ccxt/events{/privacy}","received_events_url":"https://api.github.com/users/ccxt/received_events","type":"Organization","site_admin":false},"repo":{"id":91253698,"node_id":"MDEwOlJlcG9zaXRvcnk5MTI1MzY5OA==","name":"ccxt","full_name":"ccxt/ccxt","private":false,"owner":{"login":"ccxt","id":31901609,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTAxNjA5","avatar_url":"https://avatars3.githubusercontent.com/u/31901609?v=4","gravatar_id":"","url":"https://api.github.com/users/ccxt","html_url":"https://github.com/ccxt","followers_url":"https://api.github.com/users/ccxt/followers","following_url":"https://api.github.com/users/ccxt/following{/other_user}","gists_url":"https://api.github.com/users/ccxt/gists{/gist_id}","starred_url":"https://api.github.com/users/ccxt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccxt/subscriptions","organizations_url":"https://api.github.com/users/ccxt/orgs","repos_url":"https://api.github.com/users/ccxt/repos","events_url":"https://api.github.com/users/ccxt/events{/privacy}","received_events_url":"https://api.github.com/users/ccxt/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ccxt/ccxt","description":"A JavaScript / Python / PHP cryptocurrency trading library with support for more than 130 bitcoin/altcoin exchanges","fork":false,"url":"https://api.github.com/repos/ccxt/ccxt","forks_url":"https://api.github.com/repos/ccxt/ccxt/forks","keys_url":"https://api.github.com/repos/ccxt/ccxt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ccxt/ccxt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ccxt/ccxt/teams","hooks_url":"https://api.github.com/repos/ccxt/ccxt/hooks","issue_events_url":"https://api.github.com/repos/ccxt/ccxt/issues/events{/number}","events_url":"https://api.github.com/repos/ccxt/ccxt/events","assignees_url":"https://api.github.com/repos/ccxt/ccxt/assignees{/user}","branches_url":"https://api.github.com/repos/ccxt/ccxt/branches{/branch}","tags_url":"https://api.github.com/repos/ccxt/ccxt/tags","blobs_url":"https://api.github.com/repos/ccxt/ccxt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ccxt/ccxt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ccxt/ccxt/git/refs{/sha}","trees_url":"https://api.github.com/repos/ccxt/ccxt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ccxt/ccxt/statuses/{sha}","languages_url":"https://api.github.com/repos/ccxt/ccxt/languages","stargazers_url":"https://api.github.com/repos/ccxt/ccxt/stargazers","contributors_url":"https://api.github.com/repos/ccxt/ccxt/contributors","subscribers_url":"https://api.github.com/repos/ccxt/ccxt/subscribers","subscription_url":"https://api.github.com/repos/ccxt/ccxt/subscription","commits_url":"https://api.github.com/repos/ccxt/ccxt/commits{/sha}","git_commits_url":"https://api.github.com/repos/ccxt/ccxt/git/commits{/sha}","comments_url":"https://api.github.com/repos/ccxt/ccxt/comments{/number}","issue_comment_url":"https://api.github.com/repos/ccxt/ccxt/issues/comments{/number}","contents_url":"https://api.github.com/repos/ccxt/ccxt/contents/{+path}","compare_url":"https://api.github.com/repos/ccxt/ccxt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ccxt/ccxt/merges","archive_url":"https://api.github.com/repos/ccxt/ccxt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ccxt/ccxt/downloads","issues_url":"https://api.github.com/repos/ccxt/ccxt/issues{/number}","pulls_url":"https://api.github.com/repos/ccxt/ccxt/pulls{/number}","milestones_url":"https://api.github.com/repos/ccxt/ccxt/milestones{/number}","notifications_url":"https://api.github.com/repos/ccxt/ccxt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ccxt/ccxt/labels{/name}","releases_url":"https://api.github.com/repos/ccxt/ccxt/releases{/id}","deployments_url":"https://api.github.com/repos/ccxt/ccxt/deployments","created_at":"2017-05-14T15:41:56Z","updated_at":"2019-01-04T20:21:30Z","pushed_at":"2019-01-04T18:05:05Z","git_url":"git://github.com/ccxt/ccxt.git","ssh_url":"git@github.com:ccxt/ccxt.git","clone_url":"https://github.com/ccxt/ccxt.git","svn_url":"https://github.com/ccxt/ccxt","homepage":"","size":764495,"stargazers_count":9669,"watchers_count":9669,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":2579,"mirror_url":null,"archived":false,"open_issues_count":302,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2579,"open_issues":302,"watchers":9669,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ccxt/ccxt/pulls/4431"},"html":{"href":"https://github.com/ccxt/ccxt/pull/4431"},"issue":{"href":"https://api.github.com/repos/ccxt/ccxt/issues/4431"},"comments":{"href":"https://api.github.com/repos/ccxt/ccxt/issues/4431/comments"},"review_comments":{"href":"https://api.github.com/repos/ccxt/ccxt/pulls/4431/comments"},"review_comment":{"href":"https://api.github.com/repos/ccxt/ccxt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ccxt/ccxt/pulls/4431/commits"},"statuses":{"href":"https://api.github.com/repos/ccxt/ccxt/statuses/b5659d22b888ef103ac0e81103f7f6f3a9d20cf7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kroitor"}}