{"action":"created","issue":{"url":"https://api.github.com/repos/greasemonkey/greasemonkey/issues/2830","repository_url":"https://api.github.com/repos/greasemonkey/greasemonkey","labels_url":"https://api.github.com/repos/greasemonkey/greasemonkey/issues/2830/labels{/name}","comments_url":"https://api.github.com/repos/greasemonkey/greasemonkey/issues/2830/comments","events_url":"https://api.github.com/repos/greasemonkey/greasemonkey/issues/2830/events","html_url":"https://github.com/greasemonkey/greasemonkey/pull/2830","id":294274352,"number":2830,"title":"Move async script install and update to dedicated objects","user":{"login":"Sxderp","id":6609453,"avatar_url":"https://avatars0.githubusercontent.com/u/6609453?v=4","gravatar_id":"","url":"https://api.github.com/users/Sxderp","html_url":"https://github.com/Sxderp","followers_url":"https://api.github.com/users/Sxderp/followers","following_url":"https://api.github.com/users/Sxderp/following{/other_user}","gists_url":"https://api.github.com/users/Sxderp/gists{/gist_id}","starred_url":"https://api.github.com/users/Sxderp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sxderp/subscriptions","organizations_url":"https://api.github.com/users/Sxderp/orgs","repos_url":"https://api.github.com/users/Sxderp/repos","events_url":"https://api.github.com/users/Sxderp/events{/privacy}","received_events_url":"https://api.github.com/users/Sxderp/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/greasemonkey/greasemonkey/milestones/85","html_url":"https://github.com/greasemonkey/greasemonkey/milestone/85","labels_url":"https://api.github.com/repos/greasemonkey/greasemonkey/milestones/85/labels","id":3048980,"number":85,"title":"4.4","description":"","creator":{"login":"arantius","id":84729,"avatar_url":"https://avatars0.githubusercontent.com/u/84729?v=4","gravatar_id":"","url":"https://api.github.com/users/arantius","html_url":"https://github.com/arantius","followers_url":"https://api.github.com/users/arantius/followers","following_url":"https://api.github.com/users/arantius/following{/other_user}","gists_url":"https://api.github.com/users/arantius/gists{/gist_id}","starred_url":"https://api.github.com/users/arantius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arantius/subscriptions","organizations_url":"https://api.github.com/users/arantius/orgs","repos_url":"https://api.github.com/users/arantius/repos","events_url":"https://api.github.com/users/arantius/events{/privacy}","received_events_url":"https://api.github.com/users/arantius/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":1,"state":"open","created_at":"2018-01-19T16:25:20Z","updated_at":"2018-02-16T19:52:33Z","due_on":null,"closed_at":null},"comments":10,"created_at":"2018-02-05T05:01:42Z","updated_at":"2018-02-18T03:17:16Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/greasemonkey/greasemonkey/pulls/2830","html_url":"https://github.com/greasemonkey/greasemonkey/pull/2830","diff_url":"https://github.com/greasemonkey/greasemonkey/pull/2830.diff","patch_url":"https://github.com/greasemonkey/greasemonkey/pull/2830.patch"},"body":"I've alluded to this branch for a while now (Ex. #2823). I feel like I've finally got it to a point where I can put it up as a PR. I expect there to be questions and concerns.\r\n\r\nThe two main things that this refactor accomplishes is:\r\n1. Using the original Firefox request for script content (no second XHR for body). #2823 \r\n2. Preemptive downloading of resources.\r\n\r\nIt took some work but I got those things to work with the progress bar on the install dialog. Although, once you press 'Install' the box can be safely closed without incident. The install / save will continue. A notification will alert you of failure or success. If you keep the window open then the errors (if there are any) will be displayed.\r\n\r\nI don't expect this to make it for 4.3 or even 4.4, but hopefully somewhere around 4.5 some of this can be added in."},"comment":{"url":"https://api.github.com/repos/greasemonkey/greasemonkey/issues/comments/366489436","html_url":"https://github.com/greasemonkey/greasemonkey/pull/2830#issuecomment-366489436","issue_url":"https://api.github.com/repos/greasemonkey/greasemonkey/issues/2830","id":366489436,"user":{"login":"Sxderp","id":6609453,"avatar_url":"https://avatars0.githubusercontent.com/u/6609453?v=4","gravatar_id":"","url":"https://api.github.com/users/Sxderp","html_url":"https://github.com/Sxderp","followers_url":"https://api.github.com/users/Sxderp/followers","following_url":"https://api.github.com/users/Sxderp/following{/other_user}","gists_url":"https://api.github.com/users/Sxderp/gists{/gist_id}","starred_url":"https://api.github.com/users/Sxderp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sxderp/subscriptions","organizations_url":"https://api.github.com/users/Sxderp/orgs","repos_url":"https://api.github.com/users/Sxderp/repos","events_url":"https://api.github.com/users/Sxderp/events{/privacy}","received_events_url":"https://api.github.com/users/Sxderp/received_events","type":"User","site_admin":false},"created_at":"2018-02-18T03:17:16Z","updated_at":"2018-02-18T03:17:16Z","author_association":"CONTRIBUTOR","body":"@arantius, I noticed you were working on some install-dialog stuff. However, I also noticed that you're in the middle of adjusting script downloading. In an effort to reduce duplicate work, I'd like to point out that this PR should be generic enough to work with pretty much any \"detection / initial install / update\" mechanism.\r\n\r\nOnce a decent way to interrupt the navigation is found and you restart the request (through XHR or whatever), you should be able to pass the content (through a promise) into the objects in this PR."}}
{"actor":{"display_login":"Sxderp"}}