{"push_id":2755378602,"size":3,"distinct_size":3,"ref":"refs/heads/master","head":"5a28691a44fd409f37ff66b3fe095dd8ad8c0905","before":"f6ec754d12dcc3817a7608a88e5e40ad8b965ac2","commits":[{"sha":"088eec67ec9d36d678a232c6dc88f3a335b42c95","author":{"name":"Olaoluwa Osuntokun","email":"8f4a394d9ed23c1204a697b6e111221ca5254fba@gmail.com"},"message":"peer: ensure the version negotiation goroutine will always exit\n\nIn this commit, we patch a goroutine leak within the peer struct. This\ngoroutine leak can happen, if the remote side fails to actually finish\nnegotiation the protocol before our timeout ticker ticks. In this case,\nthe goroutine will be blocked on a send, as the channel is unfired. An\nexample trace from a btcd node I had on testnet showed:\n```\n3183 @ 0x42e78a 0x42e83e 0x40540b 0x4051a5 0x872f76 0x45bfc1\n```\n\nSo, all instances of the goroutine failing to exit due to the remote\npeer not finishing the p2p version negotiation handshake.\n\nOur fix is simple: make the `negotiateErr' channel unbuffered. With this\nsimple change, we ensure that the goroutine will always exit even in the\ncase that the parent goroutine exists due to a timeout.  # Please enter\nthe commit message for your changes. Lines starting","distinct":true,"url":"https://api.github.com/repos/wakiyamap/monad/commits/088eec67ec9d36d678a232c6dc88f3a335b42c95"},{"sha":"9a2f9524024889e129a5422aca2cff73cb3eabf6","author":{"name":"Olaoluwa Osuntokun","email":"8f4a394d9ed23c1204a697b6e111221ca5254fba@gmail.com"},"message":"Merge pull request #1228 from Roasbeef/fix-peer-goroutine-leak\n\npeer: ensure the version negotiation goroutine will always exit","distinct":true,"url":"https://api.github.com/repos/wakiyamap/monad/commits/9a2f9524024889e129a5422aca2cff73cb3eabf6"},{"sha":"5a28691a44fd409f37ff66b3fe095dd8ad8c0905","author":{"name":"wakiyamap","email":"62e09be0ad23dfa3bbea9da365a41e37d72811aa@gmail.com"},"message":"Merge remote-tracking branch 'upstream/master'","distinct":true,"url":"https://api.github.com/repos/wakiyamap/monad/commits/5a28691a44fd409f37ff66b3fe095dd8ad8c0905"}]}
{"actor":{"display_login":"wakiyamap"}}