{"action":"closed","number":8658,"pull_request":{"url":"https://api.github.com/repos/dlang/dmd/pulls/8658","id":213021315,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzMDIxMzE1","html_url":"https://github.com/dlang/dmd/pull/8658","diff_url":"https://github.com/dlang/dmd/pull/8658.diff","patch_url":"https://github.com/dlang/dmd/pull/8658.patch","issue_url":"https://api.github.com/repos/dlang/dmd/issues/8658","number":8658,"state":"closed","locked":false,"title":"[C++]  Include globals.h instead of mars.h ","user":{"login":"ibuclaw","id":397929,"node_id":"MDQ6VXNlcjM5NzkyOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/397929?v=4","gravatar_id":"","url":"https://api.github.com/users/ibuclaw","html_url":"https://github.com/ibuclaw","followers_url":"https://api.github.com/users/ibuclaw/followers","following_url":"https://api.github.com/users/ibuclaw/following{/other_user}","gists_url":"https://api.github.com/users/ibuclaw/gists{/gist_id}","starred_url":"https://api.github.com/users/ibuclaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibuclaw/subscriptions","organizations_url":"https://api.github.com/users/ibuclaw/orgs","repos_url":"https://api.github.com/users/ibuclaw/repos","events_url":"https://api.github.com/users/ibuclaw/events{/privacy}","received_events_url":"https://api.github.com/users/ibuclaw/received_events","type":"User","site_admin":false},"body":"The mars header doesn't need to be included everywhere any more.  Interfacing C++ programs should explicitly include the header if they want access to anything that is declared there.","created_at":"2018-09-04T15:41:02Z","updated_at":"2018-09-05T09:34:00Z","closed_at":"2018-09-05T09:33:59Z","merged_at":null,"merge_commit_sha":"2438d9136118ff9b3c423e22b7629d49b154a36f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":174532985,"node_id":"MDU6TGFiZWwxNzQ1MzI5ODU=","url":"https://api.github.com/repos/dlang/dmd/labels/GDC","name":"GDC","color":"d4c5f9","default":false},{"id":263298662,"node_id":"MDU6TGFiZWwyNjMyOTg2NjI=","url":"https://api.github.com/repos/dlang/dmd/labels/Trivial","name":"Trivial","color":"0e8a16","default":false},{"id":502721241,"node_id":"MDU6TGFiZWw1MDI3MjEyNDE=","url":"https://api.github.com/repos/dlang/dmd/labels/auto-merge","name":"auto-merge","color":"d3d3d3","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dlang/dmd/pulls/8658/commits","review_comments_url":"https://api.github.com/repos/dlang/dmd/pulls/8658/comments","review_comment_url":"https://api.github.com/repos/dlang/dmd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dlang/dmd/issues/8658/comments","statuses_url":"https://api.github.com/repos/dlang/dmd/statuses/f7d692afb52c5581b671b4ff1a20cd7f62e504f2","head":{"label":"ibuclaw:hdrcleanup","ref":"hdrcleanup","sha":"f7d692afb52c5581b671b4ff1a20cd7f62e504f2","user":{"login":"ibuclaw","id":397929,"node_id":"MDQ6VXNlcjM5NzkyOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/397929?v=4","gravatar_id":"","url":"https://api.github.com/users/ibuclaw","html_url":"https://github.com/ibuclaw","followers_url":"https://api.github.com/users/ibuclaw/followers","following_url":"https://api.github.com/users/ibuclaw/following{/other_user}","gists_url":"https://api.github.com/users/ibuclaw/gists{/gist_id}","starred_url":"https://api.github.com/users/ibuclaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibuclaw/subscriptions","organizations_url":"https://api.github.com/users/ibuclaw/orgs","repos_url":"https://api.github.com/users/ibuclaw/repos","events_url":"https://api.github.com/users/ibuclaw/events{/privacy}","received_events_url":"https://api.github.com/users/ibuclaw/received_events","type":"User","site_admin":false},"repo":{"id":1653829,"node_id":"MDEwOlJlcG9zaXRvcnkxNjUzODI5","name":"dmd","full_name":"ibuclaw/dmd","owner":{"login":"ibuclaw","id":397929,"node_id":"MDQ6VXNlcjM5NzkyOQ==","avatar_url":"https://avatars3.githubusercontent.com/u/397929?v=4","gravatar_id":"","url":"https://api.github.com/users/ibuclaw","html_url":"https://github.com/ibuclaw","followers_url":"https://api.github.com/users/ibuclaw/followers","following_url":"https://api.github.com/users/ibuclaw/following{/other_user}","gists_url":"https://api.github.com/users/ibuclaw/gists{/gist_id}","starred_url":"https://api.github.com/users/ibuclaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ibuclaw/subscriptions","organizations_url":"https://api.github.com/users/ibuclaw/orgs","repos_url":"https://api.github.com/users/ibuclaw/repos","events_url":"https://api.github.com/users/ibuclaw/events{/privacy}","received_events_url":"https://api.github.com/users/ibuclaw/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ibuclaw/dmd","description":"dmd D Programming Language compiler","fork":true,"url":"https://api.github.com/repos/ibuclaw/dmd","forks_url":"https://api.github.com/repos/ibuclaw/dmd/forks","keys_url":"https://api.github.com/repos/ibuclaw/dmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ibuclaw/dmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ibuclaw/dmd/teams","hooks_url":"https://api.github.com/repos/ibuclaw/dmd/hooks","issue_events_url":"https://api.github.com/repos/ibuclaw/dmd/issues/events{/number}","events_url":"https://api.github.com/repos/ibuclaw/dmd/events","assignees_url":"https://api.github.com/repos/ibuclaw/dmd/assignees{/user}","branches_url":"https://api.github.com/repos/ibuclaw/dmd/branches{/branch}","tags_url":"https://api.github.com/repos/ibuclaw/dmd/tags","blobs_url":"https://api.github.com/repos/ibuclaw/dmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ibuclaw/dmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ibuclaw/dmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/ibuclaw/dmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ibuclaw/dmd/statuses/{sha}","languages_url":"https://api.github.com/repos/ibuclaw/dmd/languages","stargazers_url":"https://api.github.com/repos/ibuclaw/dmd/stargazers","contributors_url":"https://api.github.com/repos/ibuclaw/dmd/contributors","subscribers_url":"https://api.github.com/repos/ibuclaw/dmd/subscribers","subscription_url":"https://api.github.com/repos/ibuclaw/dmd/subscription","commits_url":"https://api.github.com/repos/ibuclaw/dmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/ibuclaw/dmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/ibuclaw/dmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/ibuclaw/dmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/ibuclaw/dmd/contents/{+path}","compare_url":"https://api.github.com/repos/ibuclaw/dmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ibuclaw/dmd/merges","archive_url":"https://api.github.com/repos/ibuclaw/dmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ibuclaw/dmd/downloads","issues_url":"https://api.github.com/repos/ibuclaw/dmd/issues{/number}","pulls_url":"https://api.github.com/repos/ibuclaw/dmd/pulls{/number}","milestones_url":"https://api.github.com/repos/ibuclaw/dmd/milestones{/number}","notifications_url":"https://api.github.com/repos/ibuclaw/dmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ibuclaw/dmd/labels{/name}","releases_url":"https://api.github.com/repos/ibuclaw/dmd/releases{/id}","deployments_url":"https://api.github.com/repos/ibuclaw/dmd/deployments","created_at":"2011-04-23T15:21:22Z","updated_at":"2018-09-03T23:02:28Z","pushed_at":"2018-09-04T21:55:08Z","git_url":"git://github.com/ibuclaw/dmd.git","ssh_url":"git@github.com:ibuclaw/dmd.git","clone_url":"https://github.com/ibuclaw/dmd.git","svn_url":"https://github.com/ibuclaw/dmd","homepage":"d-programming-language.org","size":88242,"stargazers_count":2,"watchers_count":2,"language":"D","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsl-1.0","name":"Boost Software License 1.0","spdx_id":"BSL-1.0","url":"https://api.github.com/licenses/bsl-1.0","node_id":"MDc6TGljZW5zZTI4"},"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"dlang:master","ref":"master","sha":"3eaf73cfc8b1bb240ffb18ad278e2518047bbda9","user":{"login":"dlang","id":565913,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NTkxMw==","avatar_url":"https://avatars3.githubusercontent.com/u/565913?v=4","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"repo":{"id":1257070,"node_id":"MDEwOlJlcG9zaXRvcnkxMjU3MDcw","name":"dmd","full_name":"dlang/dmd","owner":{"login":"dlang","id":565913,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2NTkxMw==","avatar_url":"https://avatars3.githubusercontent.com/u/565913?v=4","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dlang/dmd","description":"dmd D Programming Language compiler","fork":false,"url":"https://api.github.com/repos/dlang/dmd","forks_url":"https://api.github.com/repos/dlang/dmd/forks","keys_url":"https://api.github.com/repos/dlang/dmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dlang/dmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dlang/dmd/teams","hooks_url":"https://api.github.com/repos/dlang/dmd/hooks","issue_events_url":"https://api.github.com/repos/dlang/dmd/issues/events{/number}","events_url":"https://api.github.com/repos/dlang/dmd/events","assignees_url":"https://api.github.com/repos/dlang/dmd/assignees{/user}","branches_url":"https://api.github.com/repos/dlang/dmd/branches{/branch}","tags_url":"https://api.github.com/repos/dlang/dmd/tags","blobs_url":"https://api.github.com/repos/dlang/dmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dlang/dmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dlang/dmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/dlang/dmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dlang/dmd/statuses/{sha}","languages_url":"https://api.github.com/repos/dlang/dmd/languages","stargazers_url":"https://api.github.com/repos/dlang/dmd/stargazers","contributors_url":"https://api.github.com/repos/dlang/dmd/contributors","subscribers_url":"https://api.github.com/repos/dlang/dmd/subscribers","subscription_url":"https://api.github.com/repos/dlang/dmd/subscription","commits_url":"https://api.github.com/repos/dlang/dmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/dlang/dmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/dlang/dmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/dlang/dmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/dlang/dmd/contents/{+path}","compare_url":"https://api.github.com/repos/dlang/dmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dlang/dmd/merges","archive_url":"https://api.github.com/repos/dlang/dmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dlang/dmd/downloads","issues_url":"https://api.github.com/repos/dlang/dmd/issues{/number}","pulls_url":"https://api.github.com/repos/dlang/dmd/pulls{/number}","milestones_url":"https://api.github.com/repos/dlang/dmd/milestones{/number}","notifications_url":"https://api.github.com/repos/dlang/dmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dlang/dmd/labels{/name}","releases_url":"https://api.github.com/repos/dlang/dmd/releases{/id}","deployments_url":"https://api.github.com/repos/dlang/dmd/deployments","created_at":"2011-01-15T06:53:53Z","updated_at":"2018-09-05T07:53:33Z","pushed_at":"2018-09-05T09:24:20Z","git_url":"git://github.com/dlang/dmd.git","ssh_url":"git@github.com:dlang/dmd.git","clone_url":"https://github.com/dlang/dmd.git","svn_url":"https://github.com/dlang/dmd","homepage":"dlang.org","size":93044,"stargazers_count":1834,"watchers_count":1834,"language":"D","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":459,"mirror_url":null,"archived":false,"open_issues_count":163,"license":{"key":"bsl-1.0","name":"Boost Software License 1.0","spdx_id":"BSL-1.0","url":"https://api.github.com/licenses/bsl-1.0","node_id":"MDc6TGljZW5zZTI4"},"forks":459,"open_issues":163,"watchers":1834,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dlang/dmd/pulls/8658"},"html":{"href":"https://github.com/dlang/dmd/pull/8658"},"issue":{"href":"https://api.github.com/repos/dlang/dmd/issues/8658"},"comments":{"href":"https://api.github.com/repos/dlang/dmd/issues/8658/comments"},"review_comments":{"href":"https://api.github.com/repos/dlang/dmd/pulls/8658/comments"},"review_comment":{"href":"https://api.github.com/repos/dlang/dmd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dlang/dmd/pulls/8658/commits"},"statuses":{"href":"https://api.github.com/repos/dlang/dmd/statuses/f7d692afb52c5581b671b4ff1a20cd7f62e504f2"}},"author_association":"MEMBER","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":9,"deletions":9,"changed_files":8}}
{"actor":{"display_login":"Geod24"}}