{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/pulls/comments/216712674","pull_request_review_id":154259073,"id":216712674,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjcxMjY3NA==","diff_hunk":"@@ -0,0 +1,44 @@\n+\n+# Initiate the Windows Update operation.\n+\n+$ErrorActionPreference = 'Stop'\n+\n+. C:\\Packer\\Scripts\\windows-env.ps1\n+\n+Write-Output \"Setting up Windows Update\"\n+\n+# Important Pre-requisite right across the packer  including Windows Update.","path":"templates/win/common/scripts/provisioners/initiate-windows-update.ps1","position":10,"original_position":10,"commit_id":"4f5e35e0608a613b2b706fd23215a68e1a76c619","original_commit_id":"4f5e35e0608a613b2b706fd23215a68e1a76c619","user":{"login":"jcoconnor","id":13116231,"node_id":"MDQ6VXNlcjEzMTE2MjMx","avatar_url":"https://avatars3.githubusercontent.com/u/13116231?v=4","gravatar_id":"","url":"https://api.github.com/users/jcoconnor","html_url":"https://github.com/jcoconnor","followers_url":"https://api.github.com/users/jcoconnor/followers","following_url":"https://api.github.com/users/jcoconnor/following{/other_user}","gists_url":"https://api.github.com/users/jcoconnor/gists{/gist_id}","starred_url":"https://api.github.com/users/jcoconnor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcoconnor/subscriptions","organizations_url":"https://api.github.com/users/jcoconnor/orgs","repos_url":"https://api.github.com/users/jcoconnor/repos","events_url":"https://api.github.com/users/jcoconnor/events{/privacy}","received_events_url":"https://api.github.com/users/jcoconnor/received_events","type":"User","site_admin":false},"body":"ok","created_at":"2018-09-11T15:27:35Z","updated_at":"2018-09-11T15:27:35Z","html_url":"https://github.com/puppetlabs/puppetlabs-packer/pull/363#discussion_r216712674","pull_request_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/pulls/363","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/pulls/comments/216712674"},"html":{"href":"https://github.com/puppetlabs/puppetlabs-packer/pull/363#discussion_r216712674"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/pulls/363"}},"in_reply_to_id":216707195},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/pulls/363","id":213879105,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzODc5MTA1","html_url":"https://github.com/puppetlabs/puppetlabs-packer/pull/363","diff_url":"https://github.com/puppetlabs/puppetlabs-packer/pull/363.diff","patch_url":"https://github.com/puppetlabs/puppetlabs-packer/pull/363.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/issues/363","number":363,"state":"open","locked":false,"title":"(WIP) (IMAGES-917) Seperate the bootstrap stage from win update","user":{"login":"jcoconnor","id":13116231,"node_id":"MDQ6VXNlcjEzMTE2MjMx","avatar_url":"https://avatars3.githubusercontent.com/u/13116231?v=4","gravatar_id":"","url":"https://api.github.com/users/jcoconnor","html_url":"https://github.com/jcoconnor","followers_url":"https://api.github.com/users/jcoconnor/followers","following_url":"https://api.github.com/users/jcoconnor/following{/other_user}","gists_url":"https://api.github.com/users/jcoconnor/gists{/gist_id}","starred_url":"https://api.github.com/users/jcoconnor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcoconnor/subscriptions","organizations_url":"https://api.github.com/users/jcoconnor/orgs","repos_url":"https://api.github.com/users/jcoconnor/repos","events_url":"https://api.github.com/users/jcoconnor/events{/privacy}","received_events_url":"https://api.github.com/users/jcoconnor/received_events","type":"User","site_admin":false},"body":"If a failure happens in the bootstrap phase, it won't get notified until\r\nafter a very long timeout period (several hours). So minimise the bootstrap\r\nphase to just installing the hypervisor tools/drivers and any other minimal\r\nnetwork operations so that WinRM can be enabled and control passed back to\r\npacker.\r\n\r\nThe Windows update phase is initiated later in a seperate phase using the\r\ntechnique successfully used with the Appveyor build, where WinRm is disabled\r\njust before a packer-reboot provider to allow a further reboot cycle. This\r\ncycle is ended by re-enabling WinRM - thus allowing Windows Update to use as\r\nmany reboots as needed.\r\n\r\nAlso - have changed the startup/reboot sequence to use a Scheduled Task on\r\nStartup to continue the sequence across multiple reboots. This has the\r\nadded advantage of being able to run the script elevated, thus getting\r\nround the restriction that WSUS cannot be used across WinRM sessions.\r\n\r\nIt has also allowed the removal of the $PROFILE Core edition workaround.\r\n\r\nThis gives a more immediate experience to the jenkins log that the boot sequence\r\nhas completed at least.","created_at":"2018-09-07T10:06:09Z","updated_at":"2018-09-11T15:27:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d8a9b53c6a256d0cd018e00b2bfc3125b5b31d71","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":298516995,"node_id":"MDU6TGFiZWwyOTg1MTY5OTU=","url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/labels/don't%20merge","name":"don't merge","color":"e11d21","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/pulls/363/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/pulls/363/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/issues/363/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/statuses/4f5e35e0608a613b2b706fd23215a68e1a76c619","head":{"label":"jcoconnor:IMAGES-917-Seperate-Bootstrap","ref":"IMAGES-917-Seperate-Bootstrap","sha":"4f5e35e0608a613b2b706fd23215a68e1a76c619","user":{"login":"jcoconnor","id":13116231,"node_id":"MDQ6VXNlcjEzMTE2MjMx","avatar_url":"https://avatars3.githubusercontent.com/u/13116231?v=4","gravatar_id":"","url":"https://api.github.com/users/jcoconnor","html_url":"https://github.com/jcoconnor","followers_url":"https://api.github.com/users/jcoconnor/followers","following_url":"https://api.github.com/users/jcoconnor/following{/other_user}","gists_url":"https://api.github.com/users/jcoconnor/gists{/gist_id}","starred_url":"https://api.github.com/users/jcoconnor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcoconnor/subscriptions","organizations_url":"https://api.github.com/users/jcoconnor/orgs","repos_url":"https://api.github.com/users/jcoconnor/repos","events_url":"https://api.github.com/users/jcoconnor/events{/privacy}","received_events_url":"https://api.github.com/users/jcoconnor/received_events","type":"User","site_admin":false},"repo":{"id":38872547,"node_id":"MDEwOlJlcG9zaXRvcnkzODg3MjU0Nw==","name":"puppetlabs-packer","full_name":"jcoconnor/puppetlabs-packer","owner":{"login":"jcoconnor","id":13116231,"node_id":"MDQ6VXNlcjEzMTE2MjMx","avatar_url":"https://avatars3.githubusercontent.com/u/13116231?v=4","gravatar_id":"","url":"https://api.github.com/users/jcoconnor","html_url":"https://github.com/jcoconnor","followers_url":"https://api.github.com/users/jcoconnor/followers","following_url":"https://api.github.com/users/jcoconnor/following{/other_user}","gists_url":"https://api.github.com/users/jcoconnor/gists{/gist_id}","starred_url":"https://api.github.com/users/jcoconnor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jcoconnor/subscriptions","organizations_url":"https://api.github.com/users/jcoconnor/orgs","repos_url":"https://api.github.com/users/jcoconnor/repos","events_url":"https://api.github.com/users/jcoconnor/events{/privacy}","received_events_url":"https://api.github.com/users/jcoconnor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jcoconnor/puppetlabs-packer","description":null,"fork":true,"url":"https://api.github.com/repos/jcoconnor/puppetlabs-packer","forks_url":"https://api.github.com/repos/jcoconnor/puppetlabs-packer/forks","keys_url":"https://api.github.com/repos/jcoconnor/puppetlabs-packer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jcoconnor/puppetlabs-packer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jcoconnor/puppetlabs-packer/teams","hooks_url":"https://api.github.com/repos/jcoconnor/puppetlabs-packer/hooks","issue_events_url":"https://api.github.com/repos/jcoconnor/puppetlabs-packer/issues/events{/number}","events_url":"https://api.github.com/repos/jcoconnor/puppetlabs-packer/events","assignees_url":"https://api.github.com/repos/jcoconnor/puppetlabs-packer/assignees{/user}","branches_url":"https://api.github.com/repos/jcoconnor/puppetlabs-packer/branches{/branch}","tags_url":"https://api.github.com/repos/jcoconnor/puppetlabs-packer/tags","blobs_url":"https://api.github.com/repos/jcoconnor/puppetlabs-packer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jcoconnor/puppetlabs-packer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jcoconnor/puppetlabs-packer/git/refs{/sha}","trees_url":"https://api.github.com/repos/jcoconnor/puppetlabs-packer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jcoconnor/puppetlabs-packer/statuses/{sha}","languages_url":"https://api.github.com/repos/jcoconnor/puppetlabs-packer/languages","stargazers_url":"https://api.github.com/repos/jcoconnor/puppetlabs-packer/stargazers","contributors_url":"https://api.github.com/repos/jcoconnor/puppetlabs-packer/contributors","subscribers_url":"https://api.github.com/repos/jcoconnor/puppetlabs-packer/subscribers","subscription_url":"https://api.github.com/repos/jcoconnor/puppetlabs-packer/subscription","commits_url":"https://api.github.com/repos/jcoconnor/puppetlabs-packer/commits{/sha}","git_commits_url":"https://api.github.com/repos/jcoconnor/puppetlabs-packer/git/commits{/sha}","comments_url":"https://api.github.com/repos/jcoconnor/puppetlabs-packer/comments{/number}","issue_comment_url":"https://api.github.com/repos/jcoconnor/puppetlabs-packer/issues/comments{/number}","contents_url":"https://api.github.com/repos/jcoconnor/puppetlabs-packer/contents/{+path}","compare_url":"https://api.github.com/repos/jcoconnor/puppetlabs-packer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jcoconnor/puppetlabs-packer/merges","archive_url":"https://api.github.com/repos/jcoconnor/puppetlabs-packer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jcoconnor/puppetlabs-packer/downloads","issues_url":"https://api.github.com/repos/jcoconnor/puppetlabs-packer/issues{/number}","pulls_url":"https://api.github.com/repos/jcoconnor/puppetlabs-packer/pulls{/number}","milestones_url":"https://api.github.com/repos/jcoconnor/puppetlabs-packer/milestones{/number}","notifications_url":"https://api.github.com/repos/jcoconnor/puppetlabs-packer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jcoconnor/puppetlabs-packer/labels{/name}","releases_url":"https://api.github.com/repos/jcoconnor/puppetlabs-packer/releases{/id}","deployments_url":"https://api.github.com/repos/jcoconnor/puppetlabs-packer/deployments","created_at":"2015-07-10T09:28:31Z","updated_at":"2018-09-05T16:59:19Z","pushed_at":"2018-09-11T13:24:26Z","git_url":"git://github.com/jcoconnor/puppetlabs-packer.git","ssh_url":"git@github.com:jcoconnor/puppetlabs-packer.git","clone_url":"https://github.com/jcoconnor/puppetlabs-packer.git","svn_url":"https://github.com/jcoconnor/puppetlabs-packer","homepage":null,"size":1608,"stargazers_count":0,"watchers_count":0,"language":"PowerShell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"876160c3d65dd51fd04894b9847fc2908592f1bc","user":{"login":"puppetlabs","id":234268,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDI2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/234268?v=4","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":21011440,"node_id":"MDEwOlJlcG9zaXRvcnkyMTAxMTQ0MA==","name":"puppetlabs-packer","full_name":"puppetlabs/puppetlabs-packer","owner":{"login":"puppetlabs","id":234268,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDI2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/234268?v=4","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppetlabs-packer","description":"Packer templates to build images for vSphere","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer","forks_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/deployments","created_at":"2014-06-19T18:43:51Z","updated_at":"2018-09-10T13:41:42Z","pushed_at":"2018-09-11T13:24:27Z","git_url":"git://github.com/puppetlabs/puppetlabs-packer.git","ssh_url":"git@github.com:puppetlabs/puppetlabs-packer.git","clone_url":"https://github.com/puppetlabs/puppetlabs-packer.git","svn_url":"https://github.com/puppetlabs/puppetlabs-packer","homepage":"","size":1638,"stargazers_count":83,"watchers_count":83,"language":"PowerShell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":67,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":67,"open_issues":5,"watchers":83,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/pulls/363"},"html":{"href":"https://github.com/puppetlabs/puppetlabs-packer/pull/363"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/issues/363"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/issues/363/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/pulls/363/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/pulls/363/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-packer/statuses/4f5e35e0608a613b2b706fd23215a68e1a76c619"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jcoconnor"}}