{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/22632","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/22632/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/22632/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/22632/events","html_url":"https://github.com/nodejs/node/pull/22632","id":356099894,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNDc1Njgw","number":22632,"title":"Bug creating node executable in OpenBSD","user":{"login":"sylkat","id":4473147,"node_id":"MDQ6VXNlcjQ0NzMxNDc=","avatar_url":"https://avatars3.githubusercontent.com/u/4473147?v=4","gravatar_id":"","url":"https://api.github.com/users/sylkat","html_url":"https://github.com/sylkat","followers_url":"https://api.github.com/users/sylkat/followers","following_url":"https://api.github.com/users/sylkat/following{/other_user}","gists_url":"https://api.github.com/users/sylkat/gists{/gist_id}","starred_url":"https://api.github.com/users/sylkat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sylkat/subscriptions","organizations_url":"https://api.github.com/users/sylkat/orgs","repos_url":"https://api.github.com/users/sylkat/repos","events_url":"https://api.github.com/users/sylkat/events{/privacy}","received_events_url":"https://api.github.com/users/sylkat/received_events","type":"User","site_admin":false},"labels":[{"id":171787391,"node_id":"MDU6TGFiZWwxNzE3ODczOTE=","url":"https://api.github.com/repos/nodejs/node/labels/build","name":"build","color":"eb6420","default":false},{"id":155267517,"node_id":"MDU6TGFiZWwxNTUyNjc1MTc=","url":"https://api.github.com/repos/nodejs/node/labels/doc","name":"doc","color":"006b75","default":false},{"id":191447057,"node_id":"MDU6TGFiZWwxOTE0NDcwNTc=","url":"https://api.github.com/repos/nodejs/node/labels/meta","name":"meta","color":"fef2c0","default":false},{"id":237979054,"node_id":"MDU6TGFiZWwyMzc5NzkwNTQ=","url":"https://api.github.com/repos/nodejs/node/labels/tools","name":"tools","color":"d4c5f9","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-31T19:31:51Z","updated_at":"2018-08-31T19:36:04Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/22632","html_url":"https://github.com/nodejs/node/pull/22632","diff_url":"https://github.com/nodejs/node/pull/22632.diff","patch_url":"https://github.com/nodejs/node/pull/22632.patch"},"body":"<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\nThere is an error in the generation of the final executable node in OpenBsd 6.3.\r\n\r\nThe internal library is calling a method in FS module which doesn't exist, just removing the native method fix the problem\r\nI add a patch to fix the issue by kryzoxy@gmail.com\r\n```\r\nindex 6b7ac04..d058863 100644\r\n--- a/bootstrap_node.js\r\n+++ b/bootstrap_node.js_patched\r\n@@ -75,7 +75,7 @@\r\n     // get the full path before process.execPath is used.\r\n     if (process.platform === 'openbsd') {\r\n       const { realpathSync } = NativeModule.require('fs');\r\n-      process.execPath = realpathSync.native(process.execPath);\r\n+      process.execPath = realpathSync(process.execPath);\r\n     }\r\n \r\n     Object.defineProperty(process, 'argv0', {\r\n```\r\n- [x ] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/417768876","html_url":"https://github.com/nodejs/node/pull/22632#issuecomment-417768876","issue_url":"https://api.github.com/repos/nodejs/node/issues/22632","id":417768876,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNzc2ODg3Ng==","user":{"login":"addaleax","id":899444,"node_id":"MDQ6VXNlcjg5OTQ0NA==","avatar_url":"https://avatars2.githubusercontent.com/u/899444?v=4","gravatar_id":"","url":"https://api.github.com/users/addaleax","html_url":"https://github.com/addaleax","followers_url":"https://api.github.com/users/addaleax/followers","following_url":"https://api.github.com/users/addaleax/following{/other_user}","gists_url":"https://api.github.com/users/addaleax/gists{/gist_id}","starred_url":"https://api.github.com/users/addaleax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/addaleax/subscriptions","organizations_url":"https://api.github.com/users/addaleax/orgs","repos_url":"https://api.github.com/users/addaleax/repos","events_url":"https://api.github.com/users/addaleax/events{/privacy}","received_events_url":"https://api.github.com/users/addaleax/received_events","type":"User","site_admin":false},"created_at":"2018-08-31T19:36:04Z","updated_at":"2018-08-31T19:36:04Z","author_association":"MEMBER","body":"@sylkat Creating a pull request usually involves creating a “fork” of the project here on github, then making changes there – maybe you find [this](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md) helpful?\r\n\r\nYou can also, if you don’t want to go through the whole process, fork the project, then switch to the `v8.x-staging` branch, select the relevant file and make edits directly in the GitHub user interface before opening a pull request."}}
{"actor":{"display_login":"addaleax"}}