{"action":"created","issue":{"url":"https://api.github.com/repos/DirectXMan12/k8s-prometheus-adapter/issues/79","repository_url":"https://api.github.com/repos/DirectXMan12/k8s-prometheus-adapter","labels_url":"https://api.github.com/repos/DirectXMan12/k8s-prometheus-adapter/issues/79/labels{/name}","comments_url":"https://api.github.com/repos/DirectXMan12/k8s-prometheus-adapter/issues/79/comments","events_url":"https://api.github.com/repos/DirectXMan12/k8s-prometheus-adapter/issues/79/events","html_url":"https://github.com/DirectXMan12/k8s-prometheus-adapter/pull/79","id":336399487,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3ODYzMTk2","number":79,"title":"INCOMPLETE: External Metrics","user":{"login":"antoinne85","id":182187,"node_id":"MDQ6VXNlcjE4MjE4Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/182187?v=4","gravatar_id":"","url":"https://api.github.com/users/antoinne85","html_url":"https://github.com/antoinne85","followers_url":"https://api.github.com/users/antoinne85/followers","following_url":"https://api.github.com/users/antoinne85/following{/other_user}","gists_url":"https://api.github.com/users/antoinne85/gists{/gist_id}","starred_url":"https://api.github.com/users/antoinne85/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antoinne85/subscriptions","organizations_url":"https://api.github.com/users/antoinne85/orgs","repos_url":"https://api.github.com/users/antoinne85/repos","events_url":"https://api.github.com/users/antoinne85/events{/privacy}","received_events_url":"https://api.github.com/users/antoinne85/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-06-27T21:49:25Z","updated_at":"2018-07-14T00:17:50Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/DirectXMan12/k8s-prometheus-adapter/pulls/79","html_url":"https://github.com/DirectXMan12/k8s-prometheus-adapter/pull/79","diff_url":"https://github.com/DirectXMan12/k8s-prometheus-adapter/pull/79.diff","patch_url":"https://github.com/DirectXMan12/k8s-prometheus-adapter/pull/79.patch"},"body":"This PR is a replacement for PR #78 . I'm not sure what I did, but I absolutely ruined that branch.\r\n\r\nIt's targeted at Issue #65 .\r\n\r\nThe changes include:\r\n* I've renamed the `prometheusProvider` type to `customPrometheusProvider` provider to distinguish it from the newly created `externalPrometheusProvider`.\r\n* I created an `externalPrometheusProvider` to implement the `ExternalMetricsProvider` interface.\r\n* I stubbed out some rudimentary work in the `externalPrometheusProvider` type littered with incomplete work and `//TODO`s.\r\n\r\nI said it in the previous PR, but I'll restate it here for the sake of completeness.\r\n\r\nThis PR is 100% not complete or ready to be merged. I'm not a golang developer (yet), so the included code may not be idiomatic Go code.  If I can get some feedback on the direction things are headed I'm happy to apply some more time to this to finish and bring the code up to an acceptable standard.\r\n\r\nI've taken some steps here that, because I'm not familiar with go conventions, might be the wrong approach. So please feel free to provide any suggestions or criticisms around naming, folder structure, code reuse or whatever other feedback you might have.\r\n\r\nLastly, I'm not sure why `dep` decided that _this_ repository is one of the dependencies. I assume it's safe to completely remove that section from `Gopkg.lock` and things will be fine?"},"comment":{"url":"https://api.github.com/repos/DirectXMan12/k8s-prometheus-adapter/issues/comments/404983872","html_url":"https://github.com/DirectXMan12/k8s-prometheus-adapter/pull/79#issuecomment-404983872","issue_url":"https://api.github.com/repos/DirectXMan12/k8s-prometheus-adapter/issues/79","id":404983872,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNDk4Mzg3Mg==","user":{"login":"DirectXMan12","id":119737,"node_id":"MDQ6VXNlcjExOTczNw==","avatar_url":"https://avatars1.githubusercontent.com/u/119737?v=4","gravatar_id":"","url":"https://api.github.com/users/DirectXMan12","html_url":"https://github.com/DirectXMan12","followers_url":"https://api.github.com/users/DirectXMan12/followers","following_url":"https://api.github.com/users/DirectXMan12/following{/other_user}","gists_url":"https://api.github.com/users/DirectXMan12/gists{/gist_id}","starred_url":"https://api.github.com/users/DirectXMan12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DirectXMan12/subscriptions","organizations_url":"https://api.github.com/users/DirectXMan12/orgs","repos_url":"https://api.github.com/users/DirectXMan12/repos","events_url":"https://api.github.com/users/DirectXMan12/events{/privacy}","received_events_url":"https://api.github.com/users/DirectXMan12/received_events","type":"User","site_admin":false},"created_at":"2018-07-14T00:17:50Z","updated_at":"2018-07-14T00:17:50Z","author_association":"OWNER","body":"For metrics, I've got a couple of pretty simple Go apps that serve up interesting prometheus metrics.\r\n\r\nFor the adapter: I've got a little script that rebuilds the image and deletes the running pod to launch it again (since the build was done locally, it's decently quick).  I occasionally run outside of a container, but it's often more work than it's worth.\r\n\r\nFor running prometheus queries to check what the adapter is making: I `ssh -L` (ssh port-forwarding) into one of my nodes so that I can connect to the Prometheus service in my cluster VM.\r\n\r\nIs that what you were looking for?"}}
{"actor":{"display_login":"DirectXMan12"}}