{"action":"created","comment":{"url":"https://api.github.com/repos/ansible/ansible/pulls/comments/229338670","pull_request_review_id":169815136,"id":229338670,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTMzODY3MA==","diff_hunk":"@@ -187,20 +213,23 @@ def main():\n \n     module = AnsibleModule(argument_spec,\n                            required_if=required_if,\n-                           supports_check_mode=True)\n-\n-    if not HAS_PURESTORAGE:\n-        module.fail_json(msg='purestorage sdk is required for this module in volume')\n+                           supports_check_mode=False)\n \n     if module.params['suffix'] is None:\n         suffix = \"snap-\" + str((datetime.utcnow() - datetime(1970, 1, 1, 0, 0, 0, 0)).total_seconds())\n         module.params['suffix'] = suffix.replace(\".\", \"\")\n \n+    if not module.params['target'] and module.params['restore']:\n+        module.params['target'] = module.params['restore']\n+\n     state = module.params['state']\n     array = get_system(module)\n     pgroup = get_pgroup(module, array)\n     pgsnap = get_pgsnapshot(module, array)\n-    rvolume = get_pgroupvolume(module, array)","path":"lib/ansible/modules/storage/purestorage/purefa_pgsnap.py","position":206,"original_position":205,"commit_id":"a1f212801a820302aefa2030ff8748bee382640b","original_commit_id":"144068c30f45040ce598f0d7e786776a57441323","user":{"login":"sdodsley","id":14582466,"node_id":"MDQ6VXNlcjE0NTgyNDY2","avatar_url":"https://avatars2.githubusercontent.com/u/14582466?v=4","gravatar_id":"","url":"https://api.github.com/users/sdodsley","html_url":"https://github.com/sdodsley","followers_url":"https://api.github.com/users/sdodsley/followers","following_url":"https://api.github.com/users/sdodsley/following{/other_user}","gists_url":"https://api.github.com/users/sdodsley/gists{/gist_id}","starred_url":"https://api.github.com/users/sdodsley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdodsley/subscriptions","organizations_url":"https://api.github.com/users/sdodsley/orgs","repos_url":"https://api.github.com/users/sdodsley/repos","events_url":"https://api.github.com/users/sdodsley/events{/privacy}","received_events_url":"https://api.github.com/users/sdodsley/received_events","type":"User","site_admin":false},"body":"There is a need as there is an edge case where this suggestion can fail","created_at":"2018-10-30T14:50:07Z","updated_at":"2018-10-30T14:50:07Z","html_url":"https://github.com/ansible/ansible/pull/47086#discussion_r229338670","pull_request_url":"https://api.github.com/repos/ansible/ansible/pulls/47086","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments/229338670"},"html":{"href":"https://github.com/ansible/ansible/pull/47086#discussion_r229338670"},"pull_request":{"href":"https://api.github.com/repos/ansible/ansible/pulls/47086"}},"in_reply_to_id":229022607},"pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/47086","id":223039196,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzMDM5MTk2","html_url":"https://github.com/ansible/ansible/pull/47086","diff_url":"https://github.com/ansible/ansible/pull/47086.diff","patch_url":"https://github.com/ansible/ansible/pull/47086.patch","issue_url":"https://api.github.com/repos/ansible/ansible/issues/47086","number":47086,"state":"open","locked":false,"title":"Update Pure Storage purefa_pgsnap module","user":{"login":"sdodsley","id":14582466,"node_id":"MDQ6VXNlcjE0NTgyNDY2","avatar_url":"https://avatars2.githubusercontent.com/u/14582466?v=4","gravatar_id":"","url":"https://api.github.com/users/sdodsley","html_url":"https://github.com/sdodsley","followers_url":"https://api.github.com/users/sdodsley/followers","following_url":"https://api.github.com/users/sdodsley/following{/other_user}","gists_url":"https://api.github.com/users/sdodsley/gists{/gist_id}","starred_url":"https://api.github.com/users/sdodsley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdodsley/subscriptions","organizations_url":"https://api.github.com/users/sdodsley/orgs","repos_url":"https://api.github.com/users/sdodsley/repos","events_url":"https://api.github.com/users/sdodsley/events{/privacy}","received_events_url":"https://api.github.com/users/sdodsley/received_events","type":"User","site_admin":false},"body":"##### SUMMARY\r\nUpdate Pure Storage purefa_pgsnap module remote replication snapshots to a local disk.\r\nAdd target and overwrite as options to enable local snapshot recovery to different volume names.\r\nRemove check_mode as Pure modules don't support this\r\n\r\n##### ISSUE TYPE\r\n- Feature Pull Request\r\n\r\n##### COMPONENT NAME\r\nstorage/purestorage/purefa_pgsnap.py\r\n\r\n##### ANSIBLE VERSION\r\n```\r\nansible 2.8.0.dev0\r\n  config file = None\r\n  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']\r\n  ansible python module location = /usr/lib/python2.7/site-packages/ansible-2.8.0.dev0-py2.7.egg/ansible\r\n  executable location = /usr/bin/ansible\r\n  python version = 2.7.5 (default, May  3 2017, 07:55:04) [GCC 4.8.5 20150623 (Red Hat 4.8.5-14)]\r\n```","created_at":"2018-10-15T20:51:50Z","updated_at":"2018-10-30T14:50:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"893b409c841a06274f35404f2e7b6ebfb4d9ab44","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1043397454,"node_id":"MDU6TGFiZWwxMDQzMzk3NDU0","url":"https://api.github.com/repos/ansible/ansible/labels/affects_2.8","name":"affects_2.8","color":"ededed","default":false},{"id":501518759,"node_id":"MDU6TGFiZWw1MDE1MTg3NTk=","url":"https://api.github.com/repos/ansible/ansible/labels/community_review","name":"community_review","color":"f9d0c4","default":false},{"id":852590921,"node_id":"MDU6TGFiZWw4NTI1OTA5MjE=","url":"https://api.github.com/repos/ansible/ansible/labels/feature","name":"feature","color":"006b75","default":false},{"id":496359346,"node_id":"MDU6TGFiZWw0OTYzNTkzNDY=","url":"https://api.github.com/repos/ansible/ansible/labels/module","name":"module","color":"1d76db","default":false},{"id":499433698,"node_id":"MDU6TGFiZWw0OTk0MzM2OTg=","url":"https://api.github.com/repos/ansible/ansible/labels/owner_pr","name":"owner_pr","color":"0e8a16","default":false},{"id":1072660430,"node_id":"MDU6TGFiZWwxMDcyNjYwNDMw","url":"https://api.github.com/repos/ansible/ansible/labels/pure_storage","name":"pure_storage","color":"c7defe","default":false},{"id":581543918,"node_id":"MDU6TGFiZWw1ODE1NDM5MTg=","url":"https://api.github.com/repos/ansible/ansible/labels/stale_ci","name":"stale_ci","color":"fef2c0","default":false},{"id":957771756,"node_id":"MDU6TGFiZWw5NTc3NzE3NTY=","url":"https://api.github.com/repos/ansible/ansible/labels/storage","name":"storage","color":"aa0d10","default":false},{"id":636327968,"node_id":"MDU6TGFiZWw2MzYzMjc5Njg=","url":"https://api.github.com/repos/ansible/ansible/labels/support:community","name":"support:community","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ansible/ansible/pulls/47086/commits","review_comments_url":"https://api.github.com/repos/ansible/ansible/pulls/47086/comments","review_comment_url":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/47086/comments","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/a1f212801a820302aefa2030ff8748bee382640b","head":{"label":"sdodsley:purefa_pgrecvoer","ref":"purefa_pgrecvoer","sha":"a1f212801a820302aefa2030ff8748bee382640b","user":{"login":"sdodsley","id":14582466,"node_id":"MDQ6VXNlcjE0NTgyNDY2","avatar_url":"https://avatars2.githubusercontent.com/u/14582466?v=4","gravatar_id":"","url":"https://api.github.com/users/sdodsley","html_url":"https://github.com/sdodsley","followers_url":"https://api.github.com/users/sdodsley/followers","following_url":"https://api.github.com/users/sdodsley/following{/other_user}","gists_url":"https://api.github.com/users/sdodsley/gists{/gist_id}","starred_url":"https://api.github.com/users/sdodsley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdodsley/subscriptions","organizations_url":"https://api.github.com/users/sdodsley/orgs","repos_url":"https://api.github.com/users/sdodsley/repos","events_url":"https://api.github.com/users/sdodsley/events{/privacy}","received_events_url":"https://api.github.com/users/sdodsley/received_events","type":"User","site_admin":false},"repo":{"id":108272349,"node_id":"MDEwOlJlcG9zaXRvcnkxMDgyNzIzNDk=","name":"ansible","full_name":"sdodsley/ansible","private":false,"owner":{"login":"sdodsley","id":14582466,"node_id":"MDQ6VXNlcjE0NTgyNDY2","avatar_url":"https://avatars2.githubusercontent.com/u/14582466?v=4","gravatar_id":"","url":"https://api.github.com/users/sdodsley","html_url":"https://github.com/sdodsley","followers_url":"https://api.github.com/users/sdodsley/followers","following_url":"https://api.github.com/users/sdodsley/following{/other_user}","gists_url":"https://api.github.com/users/sdodsley/gists{/gist_id}","starred_url":"https://api.github.com/users/sdodsley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdodsley/subscriptions","organizations_url":"https://api.github.com/users/sdodsley/orgs","repos_url":"https://api.github.com/users/sdodsley/repos","events_url":"https://api.github.com/users/sdodsley/events{/privacy}","received_events_url":"https://api.github.com/users/sdodsley/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sdodsley/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications— automate in a language that approaches plain English, using SSH, with no agents to install on remote systems.","fork":true,"url":"https://api.github.com/repos/sdodsley/ansible","forks_url":"https://api.github.com/repos/sdodsley/ansible/forks","keys_url":"https://api.github.com/repos/sdodsley/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sdodsley/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sdodsley/ansible/teams","hooks_url":"https://api.github.com/repos/sdodsley/ansible/hooks","issue_events_url":"https://api.github.com/repos/sdodsley/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/sdodsley/ansible/events","assignees_url":"https://api.github.com/repos/sdodsley/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/sdodsley/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/sdodsley/ansible/tags","blobs_url":"https://api.github.com/repos/sdodsley/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sdodsley/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sdodsley/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/sdodsley/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sdodsley/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/sdodsley/ansible/languages","stargazers_url":"https://api.github.com/repos/sdodsley/ansible/stargazers","contributors_url":"https://api.github.com/repos/sdodsley/ansible/contributors","subscribers_url":"https://api.github.com/repos/sdodsley/ansible/subscribers","subscription_url":"https://api.github.com/repos/sdodsley/ansible/subscription","commits_url":"https://api.github.com/repos/sdodsley/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/sdodsley/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/sdodsley/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/sdodsley/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/sdodsley/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/sdodsley/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sdodsley/ansible/merges","archive_url":"https://api.github.com/repos/sdodsley/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sdodsley/ansible/downloads","issues_url":"https://api.github.com/repos/sdodsley/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/sdodsley/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/sdodsley/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/sdodsley/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sdodsley/ansible/labels{/name}","releases_url":"https://api.github.com/repos/sdodsley/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/sdodsley/ansible/deployments","created_at":"2017-10-25T13:13:55Z","updated_at":"2018-10-30T14:35:23Z","pushed_at":"2018-10-30T14:47:42Z","git_url":"git://github.com/sdodsley/ansible.git","ssh_url":"git@github.com:sdodsley/ansible.git","clone_url":"https://github.com/sdodsley/ansible.git","svn_url":"https://github.com/sdodsley/ansible","homepage":"https://www.ansible.com/","size":131204,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"devel"}},"base":{"label":"ansible:devel","ref":"devel","sha":"a24700d12094051de43d464a22c047a4c42624df","user":{"login":"ansible","id":1507452,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDc0NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"repo":{"id":3638964,"node_id":"MDEwOlJlcG9zaXRvcnkzNjM4OTY0","name":"ansible","full_name":"ansible/ansible","private":false,"owner":{"login":"ansible","id":1507452,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MDc0NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1507452?v=4","gravatar_id":"","url":"https://api.github.com/users/ansible","html_url":"https://github.com/ansible","followers_url":"https://api.github.com/users/ansible/followers","following_url":"https://api.github.com/users/ansible/following{/other_user}","gists_url":"https://api.github.com/users/ansible/gists{/gist_id}","starred_url":"https://api.github.com/users/ansible/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansible/subscriptions","organizations_url":"https://api.github.com/users/ansible/orgs","repos_url":"https://api.github.com/users/ansible/repos","events_url":"https://api.github.com/users/ansible/events{/privacy}","received_events_url":"https://api.github.com/users/ansible/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ansible/ansible","description":"Ansible is a radically simple IT automation platform that makes your applications and systems easier to deploy. Avoid writing scripts or custom code to deploy and update your applications — automate in a language that approaches plain English, using SSH, with no agents to install on remote systems. https://docs.ansible.com/ansible/","fork":false,"url":"https://api.github.com/repos/ansible/ansible","forks_url":"https://api.github.com/repos/ansible/ansible/forks","keys_url":"https://api.github.com/repos/ansible/ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ansible/ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ansible/ansible/teams","hooks_url":"https://api.github.com/repos/ansible/ansible/hooks","issue_events_url":"https://api.github.com/repos/ansible/ansible/issues/events{/number}","events_url":"https://api.github.com/repos/ansible/ansible/events","assignees_url":"https://api.github.com/repos/ansible/ansible/assignees{/user}","branches_url":"https://api.github.com/repos/ansible/ansible/branches{/branch}","tags_url":"https://api.github.com/repos/ansible/ansible/tags","blobs_url":"https://api.github.com/repos/ansible/ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ansible/ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ansible/ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/ansible/ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ansible/ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/ansible/ansible/languages","stargazers_url":"https://api.github.com/repos/ansible/ansible/stargazers","contributors_url":"https://api.github.com/repos/ansible/ansible/contributors","subscribers_url":"https://api.github.com/repos/ansible/ansible/subscribers","subscription_url":"https://api.github.com/repos/ansible/ansible/subscription","commits_url":"https://api.github.com/repos/ansible/ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/ansible/ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/ansible/ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/ansible/ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/ansible/ansible/contents/{+path}","compare_url":"https://api.github.com/repos/ansible/ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ansible/ansible/merges","archive_url":"https://api.github.com/repos/ansible/ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ansible/ansible/downloads","issues_url":"https://api.github.com/repos/ansible/ansible/issues{/number}","pulls_url":"https://api.github.com/repos/ansible/ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/ansible/ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/ansible/ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ansible/ansible/labels{/name}","releases_url":"https://api.github.com/repos/ansible/ansible/releases{/id}","deployments_url":"https://api.github.com/repos/ansible/ansible/deployments","created_at":"2012-03-06T14:58:02Z","updated_at":"2018-10-30T14:33:46Z","pushed_at":"2018-10-30T14:48:05Z","git_url":"git://github.com/ansible/ansible.git","ssh_url":"git@github.com:ansible/ansible.git","clone_url":"https://github.com/ansible/ansible.git","svn_url":"https://github.com/ansible/ansible","homepage":"https://www.ansible.com/","size":144758,"stargazers_count":33461,"watchers_count":33461,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13313,"mirror_url":null,"archived":false,"open_issues_count":5623,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":13313,"open_issues":5623,"watchers":33461,"default_branch":"devel"}},"_links":{"self":{"href":"https://api.github.com/repos/ansible/ansible/pulls/47086"},"html":{"href":"https://github.com/ansible/ansible/pull/47086"},"issue":{"href":"https://api.github.com/repos/ansible/ansible/issues/47086"},"comments":{"href":"https://api.github.com/repos/ansible/ansible/issues/47086/comments"},"review_comments":{"href":"https://api.github.com/repos/ansible/ansible/pulls/47086/comments"},"review_comment":{"href":"https://api.github.com/repos/ansible/ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ansible/ansible/pulls/47086/commits"},"statuses":{"href":"https://api.github.com/repos/ansible/ansible/statuses/a1f212801a820302aefa2030ff8748bee382640b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sdodsley"}}