{"action":"created","comment":{"url":"https://api.github.com/repos/lbryio/lbry/pulls/comments/219240234","pull_request_review_id":157369396,"id":219240234,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTI0MDIzNA==","diff_hunk":"@@ -523,21 +526,30 @@ def load_conf_file_settings(self):\n         if conf_file:\n             path = conf_file\n         else:\n-            path = self.get_conf_filename()\n+            path = self.get_conf_filename(default=None)\n+\n+            # if conf file does not exist\n+            if not path:\n+                self.initialize_post_conf_load()\n+                return\n+\n         ext = os.path.splitext(path)[1]\n         decoder = settings_decoders.get(ext, False)\n-        assert decoder is not False, 'Unknown settings format %s' % ext\n+\n+        if not decoder:\n+            raise ValueError('Unknown settings format %s' % ext)\n+\n         try:\n             with open(path, 'r') as settings_file:\n                 data = settings_file.read()\n             decoded = self._fix_old_conf_file_settings(decoder(data))\n             log.info('Loaded settings file: %s', path)\n             self._validate_settings(decoded)\n             self._data[TYPE_PERSISTED].update(self._convert_conf_file_lists(decoded))\n-        except (IOError, OSError) as err:\n-            log.info('%s: Failed to update settings from %s', err, path)\n+        except FileNotFoundError as err:\n+            raise FileNotFoundError('Error while reading settings file \\'{}\\': {}'.format(os.path.abspath(path), err.strerror))","path":"lbrynet/conf.py","position":41,"original_position":41,"commit_id":"be93f51cbcab96dfd3cf355a0f94de0bd6224a66","original_commit_id":"be93f51cbcab96dfd3cf355a0f94de0bd6224a66","user":{"login":"eukreign","id":69960,"node_id":"MDQ6VXNlcjY5OTYw","avatar_url":"https://avatars1.githubusercontent.com/u/69960?v=4","gravatar_id":"","url":"https://api.github.com/users/eukreign","html_url":"https://github.com/eukreign","followers_url":"https://api.github.com/users/eukreign/followers","following_url":"https://api.github.com/users/eukreign/following{/other_user}","gists_url":"https://api.github.com/users/eukreign/gists{/gist_id}","starred_url":"https://api.github.com/users/eukreign/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eukreign/subscriptions","organizations_url":"https://api.github.com/users/eukreign/orgs","repos_url":"https://api.github.com/users/eukreign/repos","events_url":"https://api.github.com/users/eukreign/events{/privacy}","received_events_url":"https://api.github.com/users/eukreign/received_events","type":"User","site_admin":false},"body":"For now just propagate the original exception.","created_at":"2018-09-20T16:52:44Z","updated_at":"2018-09-20T16:52:45Z","html_url":"https://github.com/lbryio/lbry/pull/1455#discussion_r219240234","pull_request_url":"https://api.github.com/repos/lbryio/lbry/pulls/1455","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/lbryio/lbry/pulls/comments/219240234"},"html":{"href":"https://github.com/lbryio/lbry/pull/1455#discussion_r219240234"},"pull_request":{"href":"https://api.github.com/repos/lbryio/lbry/pulls/1455"}},"in_reply_to_id":218879515},"pull_request":{"url":"https://api.github.com/repos/lbryio/lbry/pulls/1455","id":216637173,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2NjM3MTcz","html_url":"https://github.com/lbryio/lbry/pull/1455","diff_url":"https://github.com/lbryio/lbry/pull/1455.diff","patch_url":"https://github.com/lbryio/lbry/pull/1455.patch","issue_url":"https://api.github.com/repos/lbryio/lbry/issues/1455","number":1455,"state":"open","locked":false,"title":"--conf option improvements","user":{"login":"ttkopec","id":12926777,"node_id":"MDQ6VXNlcjEyOTI2Nzc3","avatar_url":"https://avatars3.githubusercontent.com/u/12926777?v=4","gravatar_id":"","url":"https://api.github.com/users/ttkopec","html_url":"https://github.com/ttkopec","followers_url":"https://api.github.com/users/ttkopec/followers","following_url":"https://api.github.com/users/ttkopec/following{/other_user}","gists_url":"https://api.github.com/users/ttkopec/gists{/gist_id}","starred_url":"https://api.github.com/users/ttkopec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ttkopec/subscriptions","organizations_url":"https://api.github.com/users/ttkopec/orgs","repos_url":"https://api.github.com/users/ttkopec/repos","events_url":"https://api.github.com/users/ttkopec/events{/privacy}","received_events_url":"https://api.github.com/users/ttkopec/received_events","type":"User","site_admin":false},"body":"Fix for [#1302](https://github.com/lbryio/lbry/issues/1302)\r\nChanges:\r\n- if provided config file does not exist, throw descriptive error with absolute path of a file\r\n- throw ValueError, not AssertionError if provided config file has unsupported extension\r\n- simple test for loading file","created_at":"2018-09-19T13:21:07Z","updated_at":"2018-09-20T16:52:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb818130d5b9bfaf62e48576add62950bbf36902","assignee":{"login":"eukreign","id":69960,"node_id":"MDQ6VXNlcjY5OTYw","avatar_url":"https://avatars1.githubusercontent.com/u/69960?v=4","gravatar_id":"","url":"https://api.github.com/users/eukreign","html_url":"https://github.com/eukreign","followers_url":"https://api.github.com/users/eukreign/followers","following_url":"https://api.github.com/users/eukreign/following{/other_user}","gists_url":"https://api.github.com/users/eukreign/gists{/gist_id}","starred_url":"https://api.github.com/users/eukreign/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eukreign/subscriptions","organizations_url":"https://api.github.com/users/eukreign/orgs","repos_url":"https://api.github.com/users/eukreign/repos","events_url":"https://api.github.com/users/eukreign/events{/privacy}","received_events_url":"https://api.github.com/users/eukreign/received_events","type":"User","site_admin":false},"assignees":[{"login":"eukreign","id":69960,"node_id":"MDQ6VXNlcjY5OTYw","avatar_url":"https://avatars1.githubusercontent.com/u/69960?v=4","gravatar_id":"","url":"https://api.github.com/users/eukreign","html_url":"https://github.com/eukreign","followers_url":"https://api.github.com/users/eukreign/followers","following_url":"https://api.github.com/users/eukreign/following{/other_user}","gists_url":"https://api.github.com/users/eukreign/gists{/gist_id}","starred_url":"https://api.github.com/users/eukreign/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eukreign/subscriptions","organizations_url":"https://api.github.com/users/eukreign/orgs","repos_url":"https://api.github.com/users/eukreign/repos","events_url":"https://api.github.com/users/eukreign/events{/privacy}","received_events_url":"https://api.github.com/users/eukreign/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/lbryio/lbry/pulls/1455/commits","review_comments_url":"https://api.github.com/repos/lbryio/lbry/pulls/1455/comments","review_comment_url":"https://api.github.com/repos/lbryio/lbry/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lbryio/lbry/issues/1455/comments","statuses_url":"https://api.github.com/repos/lbryio/lbry/statuses/be93f51cbcab96dfd3cf355a0f94de0bd6224a66","head":{"label":"ttkopec:fix-config-file","ref":"fix-config-file","sha":"be93f51cbcab96dfd3cf355a0f94de0bd6224a66","user":{"login":"ttkopec","id":12926777,"node_id":"MDQ6VXNlcjEyOTI2Nzc3","avatar_url":"https://avatars3.githubusercontent.com/u/12926777?v=4","gravatar_id":"","url":"https://api.github.com/users/ttkopec","html_url":"https://github.com/ttkopec","followers_url":"https://api.github.com/users/ttkopec/followers","following_url":"https://api.github.com/users/ttkopec/following{/other_user}","gists_url":"https://api.github.com/users/ttkopec/gists{/gist_id}","starred_url":"https://api.github.com/users/ttkopec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ttkopec/subscriptions","organizations_url":"https://api.github.com/users/ttkopec/orgs","repos_url":"https://api.github.com/users/ttkopec/repos","events_url":"https://api.github.com/users/ttkopec/events{/privacy}","received_events_url":"https://api.github.com/users/ttkopec/received_events","type":"User","site_admin":false},"repo":{"id":149440532,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk0NDA1MzI=","name":"lbry","full_name":"ttkopec/lbry","private":false,"owner":{"login":"ttkopec","id":12926777,"node_id":"MDQ6VXNlcjEyOTI2Nzc3","avatar_url":"https://avatars3.githubusercontent.com/u/12926777?v=4","gravatar_id":"","url":"https://api.github.com/users/ttkopec","html_url":"https://github.com/ttkopec","followers_url":"https://api.github.com/users/ttkopec/followers","following_url":"https://api.github.com/users/ttkopec/following{/other_user}","gists_url":"https://api.github.com/users/ttkopec/gists{/gist_id}","starred_url":"https://api.github.com/users/ttkopec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ttkopec/subscriptions","organizations_url":"https://api.github.com/users/ttkopec/orgs","repos_url":"https://api.github.com/users/ttkopec/repos","events_url":"https://api.github.com/users/ttkopec/events{/privacy}","received_events_url":"https://api.github.com/users/ttkopec/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ttkopec/lbry","description":"A fully decentralized network for distributing data","fork":true,"url":"https://api.github.com/repos/ttkopec/lbry","forks_url":"https://api.github.com/repos/ttkopec/lbry/forks","keys_url":"https://api.github.com/repos/ttkopec/lbry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ttkopec/lbry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ttkopec/lbry/teams","hooks_url":"https://api.github.com/repos/ttkopec/lbry/hooks","issue_events_url":"https://api.github.com/repos/ttkopec/lbry/issues/events{/number}","events_url":"https://api.github.com/repos/ttkopec/lbry/events","assignees_url":"https://api.github.com/repos/ttkopec/lbry/assignees{/user}","branches_url":"https://api.github.com/repos/ttkopec/lbry/branches{/branch}","tags_url":"https://api.github.com/repos/ttkopec/lbry/tags","blobs_url":"https://api.github.com/repos/ttkopec/lbry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ttkopec/lbry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ttkopec/lbry/git/refs{/sha}","trees_url":"https://api.github.com/repos/ttkopec/lbry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ttkopec/lbry/statuses/{sha}","languages_url":"https://api.github.com/repos/ttkopec/lbry/languages","stargazers_url":"https://api.github.com/repos/ttkopec/lbry/stargazers","contributors_url":"https://api.github.com/repos/ttkopec/lbry/contributors","subscribers_url":"https://api.github.com/repos/ttkopec/lbry/subscribers","subscription_url":"https://api.github.com/repos/ttkopec/lbry/subscription","commits_url":"https://api.github.com/repos/ttkopec/lbry/commits{/sha}","git_commits_url":"https://api.github.com/repos/ttkopec/lbry/git/commits{/sha}","comments_url":"https://api.github.com/repos/ttkopec/lbry/comments{/number}","issue_comment_url":"https://api.github.com/repos/ttkopec/lbry/issues/comments{/number}","contents_url":"https://api.github.com/repos/ttkopec/lbry/contents/{+path}","compare_url":"https://api.github.com/repos/ttkopec/lbry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ttkopec/lbry/merges","archive_url":"https://api.github.com/repos/ttkopec/lbry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ttkopec/lbry/downloads","issues_url":"https://api.github.com/repos/ttkopec/lbry/issues{/number}","pulls_url":"https://api.github.com/repos/ttkopec/lbry/pulls{/number}","milestones_url":"https://api.github.com/repos/ttkopec/lbry/milestones{/number}","notifications_url":"https://api.github.com/repos/ttkopec/lbry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ttkopec/lbry/labels{/name}","releases_url":"https://api.github.com/repos/ttkopec/lbry/releases{/id}","deployments_url":"https://api.github.com/repos/ttkopec/lbry/deployments","created_at":"2018-09-19T11:30:25Z","updated_at":"2018-09-19T11:30:28Z","pushed_at":"2018-09-19T13:09:26Z","git_url":"git://github.com/ttkopec/lbry.git","ssh_url":"git@github.com:ttkopec/lbry.git","clone_url":"https://github.com/ttkopec/lbry.git","svn_url":"https://github.com/ttkopec/lbry","homepage":"https://lbry.io","size":9597,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"lbryio:master","ref":"master","sha":"03415415ed397730e6f691f527f51b429a834ed5","user":{"login":"lbryio","id":13889222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODg5MjIy","avatar_url":"https://avatars3.githubusercontent.com/u/13889222?v=4","gravatar_id":"","url":"https://api.github.com/users/lbryio","html_url":"https://github.com/lbryio","followers_url":"https://api.github.com/users/lbryio/followers","following_url":"https://api.github.com/users/lbryio/following{/other_user}","gists_url":"https://api.github.com/users/lbryio/gists{/gist_id}","starred_url":"https://api.github.com/users/lbryio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbryio/subscriptions","organizations_url":"https://api.github.com/users/lbryio/orgs","repos_url":"https://api.github.com/users/lbryio/repos","events_url":"https://api.github.com/users/lbryio/events{/privacy}","received_events_url":"https://api.github.com/users/lbryio/received_events","type":"Organization","site_admin":false},"repo":{"id":41103286,"node_id":"MDEwOlJlcG9zaXRvcnk0MTEwMzI4Ng==","name":"lbry","full_name":"lbryio/lbry","private":false,"owner":{"login":"lbryio","id":13889222,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODg5MjIy","avatar_url":"https://avatars3.githubusercontent.com/u/13889222?v=4","gravatar_id":"","url":"https://api.github.com/users/lbryio","html_url":"https://github.com/lbryio","followers_url":"https://api.github.com/users/lbryio/followers","following_url":"https://api.github.com/users/lbryio/following{/other_user}","gists_url":"https://api.github.com/users/lbryio/gists{/gist_id}","starred_url":"https://api.github.com/users/lbryio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lbryio/subscriptions","organizations_url":"https://api.github.com/users/lbryio/orgs","repos_url":"https://api.github.com/users/lbryio/repos","events_url":"https://api.github.com/users/lbryio/events{/privacy}","received_events_url":"https://api.github.com/users/lbryio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/lbryio/lbry","description":"A fully decentralized network for distributing data","fork":false,"url":"https://api.github.com/repos/lbryio/lbry","forks_url":"https://api.github.com/repos/lbryio/lbry/forks","keys_url":"https://api.github.com/repos/lbryio/lbry/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lbryio/lbry/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lbryio/lbry/teams","hooks_url":"https://api.github.com/repos/lbryio/lbry/hooks","issue_events_url":"https://api.github.com/repos/lbryio/lbry/issues/events{/number}","events_url":"https://api.github.com/repos/lbryio/lbry/events","assignees_url":"https://api.github.com/repos/lbryio/lbry/assignees{/user}","branches_url":"https://api.github.com/repos/lbryio/lbry/branches{/branch}","tags_url":"https://api.github.com/repos/lbryio/lbry/tags","blobs_url":"https://api.github.com/repos/lbryio/lbry/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lbryio/lbry/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lbryio/lbry/git/refs{/sha}","trees_url":"https://api.github.com/repos/lbryio/lbry/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lbryio/lbry/statuses/{sha}","languages_url":"https://api.github.com/repos/lbryio/lbry/languages","stargazers_url":"https://api.github.com/repos/lbryio/lbry/stargazers","contributors_url":"https://api.github.com/repos/lbryio/lbry/contributors","subscribers_url":"https://api.github.com/repos/lbryio/lbry/subscribers","subscription_url":"https://api.github.com/repos/lbryio/lbry/subscription","commits_url":"https://api.github.com/repos/lbryio/lbry/commits{/sha}","git_commits_url":"https://api.github.com/repos/lbryio/lbry/git/commits{/sha}","comments_url":"https://api.github.com/repos/lbryio/lbry/comments{/number}","issue_comment_url":"https://api.github.com/repos/lbryio/lbry/issues/comments{/number}","contents_url":"https://api.github.com/repos/lbryio/lbry/contents/{+path}","compare_url":"https://api.github.com/repos/lbryio/lbry/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lbryio/lbry/merges","archive_url":"https://api.github.com/repos/lbryio/lbry/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lbryio/lbry/downloads","issues_url":"https://api.github.com/repos/lbryio/lbry/issues{/number}","pulls_url":"https://api.github.com/repos/lbryio/lbry/pulls{/number}","milestones_url":"https://api.github.com/repos/lbryio/lbry/milestones{/number}","notifications_url":"https://api.github.com/repos/lbryio/lbry/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lbryio/lbry/labels{/name}","releases_url":"https://api.github.com/repos/lbryio/lbry/releases{/id}","deployments_url":"https://api.github.com/repos/lbryio/lbry/deployments","created_at":"2015-08-20T15:24:10Z","updated_at":"2018-09-20T16:49:05Z","pushed_at":"2018-09-20T16:49:08Z","git_url":"git://github.com/lbryio/lbry.git","ssh_url":"git@github.com:lbryio/lbry.git","clone_url":"https://github.com/lbryio/lbry.git","svn_url":"https://github.com/lbryio/lbry","homepage":"https://lbry.io","size":9576,"stargazers_count":4040,"watchers_count":4040,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":248,"mirror_url":null,"archived":false,"open_issues_count":167,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":248,"open_issues":167,"watchers":4040,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lbryio/lbry/pulls/1455"},"html":{"href":"https://github.com/lbryio/lbry/pull/1455"},"issue":{"href":"https://api.github.com/repos/lbryio/lbry/issues/1455"},"comments":{"href":"https://api.github.com/repos/lbryio/lbry/issues/1455/comments"},"review_comments":{"href":"https://api.github.com/repos/lbryio/lbry/pulls/1455/comments"},"review_comment":{"href":"https://api.github.com/repos/lbryio/lbry/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lbryio/lbry/pulls/1455/commits"},"statuses":{"href":"https://api.github.com/repos/lbryio/lbry/statuses/be93f51cbcab96dfd3cf355a0f94de0bd6224a66"}},"author_association":"NONE"}}
{"actor":{"display_login":"eukreign"}}