{"action":"created","comment":{"url":"https://api.github.com/repos/Ocramius/ProxyManager/pulls/comments/186817201","pull_request_review_id":118471465,"id":186817201,"diff_hunk":"@@ -6,6 +6,20 @@ title: Tuning the ProxyManager for production\n \n By default, all proxy factories generate the required proxy classes at runtime.\n \n+To generate proxies and store them as files, you need to use `FileWriterGeneratorStrategy` by passing it to the configuration before setting up other factories:\n+\n+```php\n+    \n+$config = new \\ProxyManager\\Configuration();\n+\n+$fileLocator = new \\ProxyManager\\FileLocator\\FileLocator(__DIR__.'/my/generated/classes/cache/dir');\n+$config->setGeneratorStrategy(new \\ProxyManager\\GeneratorStrategy\\FileWriterGeneratorStrategy($fileLocator));\n+\n+// pass the configuration to proxymanager factory\n+$factory = new ProxyManager\\Factory\\LazyLoadingValueHolderFactory($config);\n+```\n+This will write the generated proxies in a directory which can be used directly instead of generating them again and again.","path":"docs/tuning-for-production.md","position":16,"original_position":16,"commit_id":"5cf80471caeeb44765af9398e3f509dd16854fa6","original_commit_id":"5cf80471caeeb44765af9398e3f509dd16854fa6","user":{"login":"Ocramius","id":154256,"avatar_url":"https://avatars2.githubusercontent.com/u/154256?v=4","gravatar_id":"","url":"https://api.github.com/users/Ocramius","html_url":"https://github.com/Ocramius","followers_url":"https://api.github.com/users/Ocramius/followers","following_url":"https://api.github.com/users/Ocramius/following{/other_user}","gists_url":"https://api.github.com/users/Ocramius/gists{/gist_id}","starred_url":"https://api.github.com/users/Ocramius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ocramius/subscriptions","organizations_url":"https://api.github.com/users/Ocramius/orgs","repos_url":"https://api.github.com/users/Ocramius/repos","events_url":"https://api.github.com/users/Ocramius/events{/privacy}","received_events_url":"https://api.github.com/users/Ocramius/received_events","type":"User","site_admin":false},"body":" > in a directory which can be used directly instead of generating them again and again.\r\n\r\nThe `FileWriterGeneratorStrategy` writes files regardless. What we are achieving here is that the files are being written at all, which is needed for us to make them part of our deployable. Can you try adjusting the wording according to that?","created_at":"2018-05-08T18:05:13Z","updated_at":"2018-05-08T18:06:29Z","html_url":"https://github.com/Ocramius/ProxyManager/pull/413#discussion_r186817201","pull_request_url":"https://api.github.com/repos/Ocramius/ProxyManager/pulls/413","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/Ocramius/ProxyManager/pulls/comments/186817201"},"html":{"href":"https://github.com/Ocramius/ProxyManager/pull/413#discussion_r186817201"},"pull_request":{"href":"https://api.github.com/repos/Ocramius/ProxyManager/pulls/413"}}},"pull_request":{"url":"https://api.github.com/repos/Ocramius/ProxyManager/pulls/413","id":186711188,"html_url":"https://github.com/Ocramius/ProxyManager/pull/413","diff_url":"https://github.com/Ocramius/ProxyManager/pull/413.diff","patch_url":"https://github.com/Ocramius/ProxyManager/pull/413.patch","issue_url":"https://api.github.com/repos/Ocramius/ProxyManager/issues/413","number":413,"state":"open","locked":false,"title":"Document writing generating proxies to files","user":{"login":"2Dsharp","id":30053071,"avatar_url":"https://avatars0.githubusercontent.com/u/30053071?v=4","gravatar_id":"","url":"https://api.github.com/users/2Dsharp","html_url":"https://github.com/2Dsharp","followers_url":"https://api.github.com/users/2Dsharp/followers","following_url":"https://api.github.com/users/2Dsharp/following{/other_user}","gists_url":"https://api.github.com/users/2Dsharp/gists{/gist_id}","starred_url":"https://api.github.com/users/2Dsharp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/2Dsharp/subscriptions","organizations_url":"https://api.github.com/users/2Dsharp/orgs","repos_url":"https://api.github.com/users/2Dsharp/repos","events_url":"https://api.github.com/users/2Dsharp/events{/privacy}","received_events_url":"https://api.github.com/users/2Dsharp/received_events","type":"User","site_admin":false},"body":"Added documentation about generating the proxies and storing them as files before trying to autoload them from the cache directory. ","created_at":"2018-05-08T18:01:36Z","updated_at":"2018-05-08T18:06:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fc0db80adedc367e9c5325fb44abaa051660eb32","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Ocramius/ProxyManager/pulls/413/commits","review_comments_url":"https://api.github.com/repos/Ocramius/ProxyManager/pulls/413/comments","review_comment_url":"https://api.github.com/repos/Ocramius/ProxyManager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Ocramius/ProxyManager/issues/413/comments","statuses_url":"https://api.github.com/repos/Ocramius/ProxyManager/statuses/5cf80471caeeb44765af9398e3f509dd16854fa6","head":{"label":"2Dsharp:hotfix/doc-update","ref":"hotfix/doc-update","sha":"5cf80471caeeb44765af9398e3f509dd16854fa6","user":{"login":"2Dsharp","id":30053071,"avatar_url":"https://avatars0.githubusercontent.com/u/30053071?v=4","gravatar_id":"","url":"https://api.github.com/users/2Dsharp","html_url":"https://github.com/2Dsharp","followers_url":"https://api.github.com/users/2Dsharp/followers","following_url":"https://api.github.com/users/2Dsharp/following{/other_user}","gists_url":"https://api.github.com/users/2Dsharp/gists{/gist_id}","starred_url":"https://api.github.com/users/2Dsharp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/2Dsharp/subscriptions","organizations_url":"https://api.github.com/users/2Dsharp/orgs","repos_url":"https://api.github.com/users/2Dsharp/repos","events_url":"https://api.github.com/users/2Dsharp/events{/privacy}","received_events_url":"https://api.github.com/users/2Dsharp/received_events","type":"User","site_admin":false},"repo":{"id":132644716,"name":"ProxyManager","full_name":"2Dsharp/ProxyManager","owner":{"login":"2Dsharp","id":30053071,"avatar_url":"https://avatars0.githubusercontent.com/u/30053071?v=4","gravatar_id":"","url":"https://api.github.com/users/2Dsharp","html_url":"https://github.com/2Dsharp","followers_url":"https://api.github.com/users/2Dsharp/followers","following_url":"https://api.github.com/users/2Dsharp/following{/other_user}","gists_url":"https://api.github.com/users/2Dsharp/gists{/gist_id}","starred_url":"https://api.github.com/users/2Dsharp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/2Dsharp/subscriptions","organizations_url":"https://api.github.com/users/2Dsharp/orgs","repos_url":"https://api.github.com/users/2Dsharp/repos","events_url":"https://api.github.com/users/2Dsharp/events{/privacy}","received_events_url":"https://api.github.com/users/2Dsharp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/2Dsharp/ProxyManager","description":":rainbow: OOP Proxy wrappers utilities - generates and manages proxies of your objects","fork":true,"url":"https://api.github.com/repos/2Dsharp/ProxyManager","forks_url":"https://api.github.com/repos/2Dsharp/ProxyManager/forks","keys_url":"https://api.github.com/repos/2Dsharp/ProxyManager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/2Dsharp/ProxyManager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/2Dsharp/ProxyManager/teams","hooks_url":"https://api.github.com/repos/2Dsharp/ProxyManager/hooks","issue_events_url":"https://api.github.com/repos/2Dsharp/ProxyManager/issues/events{/number}","events_url":"https://api.github.com/repos/2Dsharp/ProxyManager/events","assignees_url":"https://api.github.com/repos/2Dsharp/ProxyManager/assignees{/user}","branches_url":"https://api.github.com/repos/2Dsharp/ProxyManager/branches{/branch}","tags_url":"https://api.github.com/repos/2Dsharp/ProxyManager/tags","blobs_url":"https://api.github.com/repos/2Dsharp/ProxyManager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/2Dsharp/ProxyManager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/2Dsharp/ProxyManager/git/refs{/sha}","trees_url":"https://api.github.com/repos/2Dsharp/ProxyManager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/2Dsharp/ProxyManager/statuses/{sha}","languages_url":"https://api.github.com/repos/2Dsharp/ProxyManager/languages","stargazers_url":"https://api.github.com/repos/2Dsharp/ProxyManager/stargazers","contributors_url":"https://api.github.com/repos/2Dsharp/ProxyManager/contributors","subscribers_url":"https://api.github.com/repos/2Dsharp/ProxyManager/subscribers","subscription_url":"https://api.github.com/repos/2Dsharp/ProxyManager/subscription","commits_url":"https://api.github.com/repos/2Dsharp/ProxyManager/commits{/sha}","git_commits_url":"https://api.github.com/repos/2Dsharp/ProxyManager/git/commits{/sha}","comments_url":"https://api.github.com/repos/2Dsharp/ProxyManager/comments{/number}","issue_comment_url":"https://api.github.com/repos/2Dsharp/ProxyManager/issues/comments{/number}","contents_url":"https://api.github.com/repos/2Dsharp/ProxyManager/contents/{+path}","compare_url":"https://api.github.com/repos/2Dsharp/ProxyManager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/2Dsharp/ProxyManager/merges","archive_url":"https://api.github.com/repos/2Dsharp/ProxyManager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/2Dsharp/ProxyManager/downloads","issues_url":"https://api.github.com/repos/2Dsharp/ProxyManager/issues{/number}","pulls_url":"https://api.github.com/repos/2Dsharp/ProxyManager/pulls{/number}","milestones_url":"https://api.github.com/repos/2Dsharp/ProxyManager/milestones{/number}","notifications_url":"https://api.github.com/repos/2Dsharp/ProxyManager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/2Dsharp/ProxyManager/labels{/name}","releases_url":"https://api.github.com/repos/2Dsharp/ProxyManager/releases{/id}","deployments_url":"https://api.github.com/repos/2Dsharp/ProxyManager/deployments","created_at":"2018-05-08T17:48:32Z","updated_at":"2018-05-08T17:48:34Z","pushed_at":"2018-05-08T17:56:17Z","git_url":"git://github.com/2Dsharp/ProxyManager.git","ssh_url":"git@github.com:2Dsharp/ProxyManager.git","clone_url":"https://github.com/2Dsharp/ProxyManager.git","svn_url":"https://github.com/2Dsharp/ProxyManager","homepage":"http://ocramius.github.io/ProxyManager/","size":3218,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Ocramius:master","ref":"master","sha":"81d53b2878f1d1c40ad27270e64b51798485dfc5","user":{"login":"Ocramius","id":154256,"avatar_url":"https://avatars2.githubusercontent.com/u/154256?v=4","gravatar_id":"","url":"https://api.github.com/users/Ocramius","html_url":"https://github.com/Ocramius","followers_url":"https://api.github.com/users/Ocramius/followers","following_url":"https://api.github.com/users/Ocramius/following{/other_user}","gists_url":"https://api.github.com/users/Ocramius/gists{/gist_id}","starred_url":"https://api.github.com/users/Ocramius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ocramius/subscriptions","organizations_url":"https://api.github.com/users/Ocramius/orgs","repos_url":"https://api.github.com/users/Ocramius/repos","events_url":"https://api.github.com/users/Ocramius/events{/privacy}","received_events_url":"https://api.github.com/users/Ocramius/received_events","type":"User","site_admin":false},"repo":{"id":8875190,"name":"ProxyManager","full_name":"Ocramius/ProxyManager","owner":{"login":"Ocramius","id":154256,"avatar_url":"https://avatars2.githubusercontent.com/u/154256?v=4","gravatar_id":"","url":"https://api.github.com/users/Ocramius","html_url":"https://github.com/Ocramius","followers_url":"https://api.github.com/users/Ocramius/followers","following_url":"https://api.github.com/users/Ocramius/following{/other_user}","gists_url":"https://api.github.com/users/Ocramius/gists{/gist_id}","starred_url":"https://api.github.com/users/Ocramius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ocramius/subscriptions","organizations_url":"https://api.github.com/users/Ocramius/orgs","repos_url":"https://api.github.com/users/Ocramius/repos","events_url":"https://api.github.com/users/Ocramius/events{/privacy}","received_events_url":"https://api.github.com/users/Ocramius/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ocramius/ProxyManager","description":":rainbow: OOP Proxy wrappers utilities - generates and manages proxies of your objects","fork":false,"url":"https://api.github.com/repos/Ocramius/ProxyManager","forks_url":"https://api.github.com/repos/Ocramius/ProxyManager/forks","keys_url":"https://api.github.com/repos/Ocramius/ProxyManager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ocramius/ProxyManager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ocramius/ProxyManager/teams","hooks_url":"https://api.github.com/repos/Ocramius/ProxyManager/hooks","issue_events_url":"https://api.github.com/repos/Ocramius/ProxyManager/issues/events{/number}","events_url":"https://api.github.com/repos/Ocramius/ProxyManager/events","assignees_url":"https://api.github.com/repos/Ocramius/ProxyManager/assignees{/user}","branches_url":"https://api.github.com/repos/Ocramius/ProxyManager/branches{/branch}","tags_url":"https://api.github.com/repos/Ocramius/ProxyManager/tags","blobs_url":"https://api.github.com/repos/Ocramius/ProxyManager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ocramius/ProxyManager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ocramius/ProxyManager/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ocramius/ProxyManager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ocramius/ProxyManager/statuses/{sha}","languages_url":"https://api.github.com/repos/Ocramius/ProxyManager/languages","stargazers_url":"https://api.github.com/repos/Ocramius/ProxyManager/stargazers","contributors_url":"https://api.github.com/repos/Ocramius/ProxyManager/contributors","subscribers_url":"https://api.github.com/repos/Ocramius/ProxyManager/subscribers","subscription_url":"https://api.github.com/repos/Ocramius/ProxyManager/subscription","commits_url":"https://api.github.com/repos/Ocramius/ProxyManager/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ocramius/ProxyManager/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ocramius/ProxyManager/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ocramius/ProxyManager/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ocramius/ProxyManager/contents/{+path}","compare_url":"https://api.github.com/repos/Ocramius/ProxyManager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ocramius/ProxyManager/merges","archive_url":"https://api.github.com/repos/Ocramius/ProxyManager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ocramius/ProxyManager/downloads","issues_url":"https://api.github.com/repos/Ocramius/ProxyManager/issues{/number}","pulls_url":"https://api.github.com/repos/Ocramius/ProxyManager/pulls{/number}","milestones_url":"https://api.github.com/repos/Ocramius/ProxyManager/milestones{/number}","notifications_url":"https://api.github.com/repos/Ocramius/ProxyManager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ocramius/ProxyManager/labels{/name}","releases_url":"https://api.github.com/repos/Ocramius/ProxyManager/releases{/id}","deployments_url":"https://api.github.com/repos/Ocramius/ProxyManager/deployments","created_at":"2013-03-19T09:43:22Z","updated_at":"2018-05-08T13:31:06Z","pushed_at":"2018-05-08T18:01:36Z","git_url":"git://github.com/Ocramius/ProxyManager.git","ssh_url":"git@github.com:Ocramius/ProxyManager.git","clone_url":"https://github.com/Ocramius/ProxyManager.git","svn_url":"https://github.com/Ocramius/ProxyManager","homepage":"http://ocramius.github.io/ProxyManager/","size":3218,"stargazers_count":1436,"watchers_count":1436,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":115,"mirror_url":null,"archived":false,"open_issues_count":44,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":115,"open_issues":44,"watchers":1436,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Ocramius/ProxyManager/pulls/413"},"html":{"href":"https://github.com/Ocramius/ProxyManager/pull/413"},"issue":{"href":"https://api.github.com/repos/Ocramius/ProxyManager/issues/413"},"comments":{"href":"https://api.github.com/repos/Ocramius/ProxyManager/issues/413/comments"},"review_comments":{"href":"https://api.github.com/repos/Ocramius/ProxyManager/pulls/413/comments"},"review_comment":{"href":"https://api.github.com/repos/Ocramius/ProxyManager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Ocramius/ProxyManager/pulls/413/commits"},"statuses":{"href":"https://api.github.com/repos/Ocramius/ProxyManager/statuses/5cf80471caeeb44765af9398e3f509dd16854fa6"}},"author_association":"NONE"}}
{"actor":{"display_login":"Ocramius"}}