{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/68406","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/68406/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/68406/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/68406/events","html_url":"https://github.com/kubernetes/kubernetes/pull/68406","id":358025710,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzODk1NTEw","number":68406,"title":"Attach Detach Controller CRD validations","user":{"login":"hoegaarden","id":1401333,"node_id":"MDQ6VXNlcjE0MDEzMzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1401333?v=4","gravatar_id":"","url":"https://api.github.com/users/hoegaarden","html_url":"https://github.com/hoegaarden","followers_url":"https://api.github.com/users/hoegaarden/followers","following_url":"https://api.github.com/users/hoegaarden/following{/other_user}","gists_url":"https://api.github.com/users/hoegaarden/gists{/gist_id}","starred_url":"https://api.github.com/users/hoegaarden/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hoegaarden/subscriptions","organizations_url":"https://api.github.com/users/hoegaarden/orgs","repos_url":"https://api.github.com/users/hoegaarden/repos","events_url":"https://api.github.com/users/hoegaarden/events{/privacy}","received_events_url":"https://api.github.com/users/hoegaarden/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":105146071,"node_id":"MDU6TGFiZWwxMDUxNDYwNzE=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/bug","name":"kind/bug","color":"e11d21","default":false},{"id":114528068,"node_id":"MDU6TGFiZWwxMTQ1MjgwNjg=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/priority/critical-urgent","name":"priority/critical-urgent","color":"e11d21","default":false},{"id":200149833,"node_id":"MDU6TGFiZWwyMDAxNDk4MzM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":173493835,"node_id":"MDU6TGFiZWwxNzM0OTM4MzU=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/api-machinery","name":"sig/api-machinery","color":"d2b48c","default":false},{"id":169428334,"node_id":"MDU6TGFiZWwxNjk0MjgzMzQ=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/storage","name":"sig/storage","color":"d2b48c","default":false},{"id":253450978,"node_id":"MDU6TGFiZWwyNTM0NTA5Nzg=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":{"login":"lavalamp","id":647318,"node_id":"MDQ6VXNlcjY0NzMxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/647318?v=4","gravatar_id":"","url":"https://api.github.com/users/lavalamp","html_url":"https://github.com/lavalamp","followers_url":"https://api.github.com/users/lavalamp/followers","following_url":"https://api.github.com/users/lavalamp/following{/other_user}","gists_url":"https://api.github.com/users/lavalamp/gists{/gist_id}","starred_url":"https://api.github.com/users/lavalamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavalamp/subscriptions","organizations_url":"https://api.github.com/users/lavalamp/orgs","repos_url":"https://api.github.com/users/lavalamp/repos","events_url":"https://api.github.com/users/lavalamp/events{/privacy}","received_events_url":"https://api.github.com/users/lavalamp/received_events","type":"User","site_admin":false},"assignees":[{"login":"lavalamp","id":647318,"node_id":"MDQ6VXNlcjY0NzMxOA==","avatar_url":"https://avatars0.githubusercontent.com/u/647318?v=4","gravatar_id":"","url":"https://api.github.com/users/lavalamp","html_url":"https://github.com/lavalamp","followers_url":"https://api.github.com/users/lavalamp/followers","following_url":"https://api.github.com/users/lavalamp/following{/other_user}","gists_url":"https://api.github.com/users/lavalamp/gists{/gist_id}","starred_url":"https://api.github.com/users/lavalamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lavalamp/subscriptions","organizations_url":"https://api.github.com/users/lavalamp/orgs","repos_url":"https://api.github.com/users/lavalamp/repos","events_url":"https://api.github.com/users/lavalamp/events{/privacy}","received_events_url":"https://api.github.com/users/lavalamp/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/39","html_url":"https://github.com/kubernetes/kubernetes/milestone/39","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones/39/labels","id":2913712,"node_id":"MDk6TWlsZXN0b25lMjkxMzcxMg==","number":39,"title":"v1.12","description":"","creator":{"login":"thockin","id":5595220,"node_id":"MDQ6VXNlcjU1OTUyMjA=","avatar_url":"https://avatars0.githubusercontent.com/u/5595220?v=4","gravatar_id":"","url":"https://api.github.com/users/thockin","html_url":"https://github.com/thockin","followers_url":"https://api.github.com/users/thockin/followers","following_url":"https://api.github.com/users/thockin/following{/other_user}","gists_url":"https://api.github.com/users/thockin/gists{/gist_id}","starred_url":"https://api.github.com/users/thockin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thockin/subscriptions","organizations_url":"https://api.github.com/users/thockin/orgs","repos_url":"https://api.github.com/users/thockin/repos","events_url":"https://api.github.com/users/thockin/events{/privacy}","received_events_url":"https://api.github.com/users/thockin/received_events","type":"User","site_admin":false},"open_issues":42,"closed_issues":263,"state":"open","created_at":"2017-11-15T06:32:51Z","updated_at":"2018-09-11T08:49:52Z","due_on":null,"closed_at":null},"comments":13,"created_at":"2018-09-07T11:13:01Z","updated_at":"2018-09-11T10:03:09Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/68406","html_url":"https://github.com/kubernetes/kubernetes/pull/68406","diff_url":"https://github.com/kubernetes/kubernetes/pull/68406.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/68406.patch"},"body":"**What this PR does / why we need it**:\r\n\r\n> @liggitt pointed out lack of validation may cause issues with watchers and listers. So we validation should be added.\r\n\r\n**Which issue(s) this PR fixes**:\r\nFixes #68260\r\n\r\n**Special notes for your reviewer**:\r\n\r\nWe are not sure if those validations are narrow enough -- we don't set any of the fields as mandatory, we do no specify any REs, min/max lengths, ...\r\n\r\n**Release note**:\r\n```release-note\r\nAdd validations to Attach Detach CRDs\r\n```\r\n\r\n/assign @kubernetes/sig-storage-pr-reviews \r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/420218872","html_url":"https://github.com/kubernetes/kubernetes/pull/68406#issuecomment-420218872","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/68406","id":420218872,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMDIxODg3Mg==","user":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-09-11T10:03:09Z","updated_at":"2018-09-11T10:03:09Z","author_association":"CONTRIBUTOR","body":"@hoegaarden: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubernetes-verify | 0c16c215b3810892569c4cb7d0d36eaeeae76541 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/68406/pull-kubernetes-verify/106075/) | `/test pull-kubernetes-verify`\npull-kubernetes-bazel-build | 2ff33c5154388fe56219eaf95aa60f385ef20ef8 | [link](https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/pr-logs/pull/68406/pull-kubernetes-bazel-build/57728/) | `/test pull-kubernetes-bazel-build`\n\n[Full PR test history](https://k8s-gubernator.appspot.com/pr/68406). [Your PR dashboard](https://k8s-gubernator.appspot.com/pr/hoegaarden). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}