{"action":"opened","number":49,"pull_request":{"url":"https://api.github.com/repos/DanKatzuv/BaseBot/pulls/49","id":236896912,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2ODk2OTEy","html_url":"https://github.com/DanKatzuv/BaseBot/pull/49","diff_url":"https://github.com/DanKatzuv/BaseBot/pull/49.diff","patch_url":"https://github.com/DanKatzuv/BaseBot/pull/49.patch","issue_url":"https://api.github.com/repos/DanKatzuv/BaseBot/issues/49","number":49,"state":"open","locked":false,"title":"Rewrite and fix to real time aspect of the Pure pursue algorithm","user":{"login":"pauloalbert","id":8577984,"node_id":"MDQ6VXNlcjg1Nzc5ODQ=","avatar_url":"https://avatars0.githubusercontent.com/u/8577984?v=4","gravatar_id":"","url":"https://api.github.com/users/pauloalbert","html_url":"https://github.com/pauloalbert","followers_url":"https://api.github.com/users/pauloalbert/followers","following_url":"https://api.github.com/users/pauloalbert/following{/other_user}","gists_url":"https://api.github.com/users/pauloalbert/gists{/gist_id}","starred_url":"https://api.github.com/users/pauloalbert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pauloalbert/subscriptions","organizations_url":"https://api.github.com/users/pauloalbert/orgs","repos_url":"https://api.github.com/users/pauloalbert/repos","events_url":"https://api.github.com/users/pauloalbert/events{/privacy}","received_events_url":"https://api.github.com/users/pauloalbert/received_events","type":"User","site_admin":false},"body":"This pull request fixes and tweaks many of the issues in our pure pursue calculations, aswell as several tweaks on the way. This pull request has been tested (more than several times) and has been proven to work, although this code still doesn't have optimizations like _limit rate_, which improve the robots accuracy and speed on the path (see the _enhancement_ tag for more examples).\r\n\r\n\r\n**Changelog:**\r\n\r\n- Fix lookaheadXDistance method in PurePursue\r\n- Fix calculateCurvature method in PurePursue\r\n- Fix findNearPath method in PurePursue\r\n- Flip X and Y axis \r\n- Rotate robotAngle in PurePursue\r\n- Refactored names:\r\n- - drive -> drivetrain\r\n- - TRACK_WIDTH -> ROBOT_WIDTH\r\n- - PULSE_PER_DISTANCE -> DISTANCE_PER_PULSE\r\n- Flip Joystick inputs to make the robot drive forward\r\n- Fix major Errors (pulled from pull request #48):\r\n- - Remove copy of waypointRotate method in Waypoint\r\n- - Fix type error in toArray() crashing the code on compile\r\n- - Fix out of bounds error in getWaypoint() when inputting a negative index\r\n- Add java documentation\r\n- Add Prints and Networktable prints for debugging\r\n","created_at":"2018-12-07T15:06:27Z","updated_at":"2018-12-07T15:06:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/DanKatzuv/BaseBot/pulls/49/commits","review_comments_url":"https://api.github.com/repos/DanKatzuv/BaseBot/pulls/49/comments","review_comment_url":"https://api.github.com/repos/DanKatzuv/BaseBot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DanKatzuv/BaseBot/issues/49/comments","statuses_url":"https://api.github.com/repos/DanKatzuv/BaseBot/statuses/4ba6d8f28d8a8eccb5440b34f46fd5def1914f07","head":{"label":"DanKatzuv:new-test-backtrack","ref":"new-test-backtrack","sha":"4ba6d8f28d8a8eccb5440b34f46fd5def1914f07","user":{"login":"DanKatzuv","id":31829093,"node_id":"MDQ6VXNlcjMxODI5MDkz","avatar_url":"https://avatars1.githubusercontent.com/u/31829093?v=4","gravatar_id":"","url":"https://api.github.com/users/DanKatzuv","html_url":"https://github.com/DanKatzuv","followers_url":"https://api.github.com/users/DanKatzuv/followers","following_url":"https://api.github.com/users/DanKatzuv/following{/other_user}","gists_url":"https://api.github.com/users/DanKatzuv/gists{/gist_id}","starred_url":"https://api.github.com/users/DanKatzuv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanKatzuv/subscriptions","organizations_url":"https://api.github.com/users/DanKatzuv/orgs","repos_url":"https://api.github.com/users/DanKatzuv/repos","events_url":"https://api.github.com/users/DanKatzuv/events{/privacy}","received_events_url":"https://api.github.com/users/DanKatzuv/received_events","type":"User","site_admin":false},"repo":{"id":153307612,"node_id":"MDEwOlJlcG9zaXRvcnkxNTMzMDc2MTI=","name":"BaseBot","full_name":"DanKatzuv/BaseBot","private":false,"owner":{"login":"DanKatzuv","id":31829093,"node_id":"MDQ6VXNlcjMxODI5MDkz","avatar_url":"https://avatars1.githubusercontent.com/u/31829093?v=4","gravatar_id":"","url":"https://api.github.com/users/DanKatzuv","html_url":"https://github.com/DanKatzuv","followers_url":"https://api.github.com/users/DanKatzuv/followers","following_url":"https://api.github.com/users/DanKatzuv/following{/other_user}","gists_url":"https://api.github.com/users/DanKatzuv/gists{/gist_id}","starred_url":"https://api.github.com/users/DanKatzuv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanKatzuv/subscriptions","organizations_url":"https://api.github.com/users/DanKatzuv/orgs","repos_url":"https://api.github.com/users/DanKatzuv/repos","events_url":"https://api.github.com/users/DanKatzuv/events{/privacy}","received_events_url":"https://api.github.com/users/DanKatzuv/received_events","type":"User","site_admin":false},"html_url":"https://github.com/DanKatzuv/BaseBot","description":"Base robot code","fork":true,"url":"https://api.github.com/repos/DanKatzuv/BaseBot","forks_url":"https://api.github.com/repos/DanKatzuv/BaseBot/forks","keys_url":"https://api.github.com/repos/DanKatzuv/BaseBot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DanKatzuv/BaseBot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DanKatzuv/BaseBot/teams","hooks_url":"https://api.github.com/repos/DanKatzuv/BaseBot/hooks","issue_events_url":"https://api.github.com/repos/DanKatzuv/BaseBot/issues/events{/number}","events_url":"https://api.github.com/repos/DanKatzuv/BaseBot/events","assignees_url":"https://api.github.com/repos/DanKatzuv/BaseBot/assignees{/user}","branches_url":"https://api.github.com/repos/DanKatzuv/BaseBot/branches{/branch}","tags_url":"https://api.github.com/repos/DanKatzuv/BaseBot/tags","blobs_url":"https://api.github.com/repos/DanKatzuv/BaseBot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DanKatzuv/BaseBot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DanKatzuv/BaseBot/git/refs{/sha}","trees_url":"https://api.github.com/repos/DanKatzuv/BaseBot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DanKatzuv/BaseBot/statuses/{sha}","languages_url":"https://api.github.com/repos/DanKatzuv/BaseBot/languages","stargazers_url":"https://api.github.com/repos/DanKatzuv/BaseBot/stargazers","contributors_url":"https://api.github.com/repos/DanKatzuv/BaseBot/contributors","subscribers_url":"https://api.github.com/repos/DanKatzuv/BaseBot/subscribers","subscription_url":"https://api.github.com/repos/DanKatzuv/BaseBot/subscription","commits_url":"https://api.github.com/repos/DanKatzuv/BaseBot/commits{/sha}","git_commits_url":"https://api.github.com/repos/DanKatzuv/BaseBot/git/commits{/sha}","comments_url":"https://api.github.com/repos/DanKatzuv/BaseBot/comments{/number}","issue_comment_url":"https://api.github.com/repos/DanKatzuv/BaseBot/issues/comments{/number}","contents_url":"https://api.github.com/repos/DanKatzuv/BaseBot/contents/{+path}","compare_url":"https://api.github.com/repos/DanKatzuv/BaseBot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DanKatzuv/BaseBot/merges","archive_url":"https://api.github.com/repos/DanKatzuv/BaseBot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DanKatzuv/BaseBot/downloads","issues_url":"https://api.github.com/repos/DanKatzuv/BaseBot/issues{/number}","pulls_url":"https://api.github.com/repos/DanKatzuv/BaseBot/pulls{/number}","milestones_url":"https://api.github.com/repos/DanKatzuv/BaseBot/milestones{/number}","notifications_url":"https://api.github.com/repos/DanKatzuv/BaseBot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DanKatzuv/BaseBot/labels{/name}","releases_url":"https://api.github.com/repos/DanKatzuv/BaseBot/releases{/id}","deployments_url":"https://api.github.com/repos/DanKatzuv/BaseBot/deployments","created_at":"2018-10-16T15:16:44Z","updated_at":"2018-12-07T09:03:13Z","pushed_at":"2018-12-07T14:59:51Z","git_url":"git://github.com/DanKatzuv/BaseBot.git","ssh_url":"git@github.com:DanKatzuv/BaseBot.git","clone_url":"https://github.com/DanKatzuv/BaseBot.git","svn_url":"https://github.com/DanKatzuv/BaseBot","homepage":null,"size":683,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":9,"license":null,"forks":0,"open_issues":9,"watchers":0,"default_branch":"master"}},"base":{"label":"DanKatzuv:master","ref":"master","sha":"1abee736e13d66888fef6942645760931855c6cd","user":{"login":"DanKatzuv","id":31829093,"node_id":"MDQ6VXNlcjMxODI5MDkz","avatar_url":"https://avatars1.githubusercontent.com/u/31829093?v=4","gravatar_id":"","url":"https://api.github.com/users/DanKatzuv","html_url":"https://github.com/DanKatzuv","followers_url":"https://api.github.com/users/DanKatzuv/followers","following_url":"https://api.github.com/users/DanKatzuv/following{/other_user}","gists_url":"https://api.github.com/users/DanKatzuv/gists{/gist_id}","starred_url":"https://api.github.com/users/DanKatzuv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanKatzuv/subscriptions","organizations_url":"https://api.github.com/users/DanKatzuv/orgs","repos_url":"https://api.github.com/users/DanKatzuv/repos","events_url":"https://api.github.com/users/DanKatzuv/events{/privacy}","received_events_url":"https://api.github.com/users/DanKatzuv/received_events","type":"User","site_admin":false},"repo":{"id":153307612,"node_id":"MDEwOlJlcG9zaXRvcnkxNTMzMDc2MTI=","name":"BaseBot","full_name":"DanKatzuv/BaseBot","private":false,"owner":{"login":"DanKatzuv","id":31829093,"node_id":"MDQ6VXNlcjMxODI5MDkz","avatar_url":"https://avatars1.githubusercontent.com/u/31829093?v=4","gravatar_id":"","url":"https://api.github.com/users/DanKatzuv","html_url":"https://github.com/DanKatzuv","followers_url":"https://api.github.com/users/DanKatzuv/followers","following_url":"https://api.github.com/users/DanKatzuv/following{/other_user}","gists_url":"https://api.github.com/users/DanKatzuv/gists{/gist_id}","starred_url":"https://api.github.com/users/DanKatzuv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanKatzuv/subscriptions","organizations_url":"https://api.github.com/users/DanKatzuv/orgs","repos_url":"https://api.github.com/users/DanKatzuv/repos","events_url":"https://api.github.com/users/DanKatzuv/events{/privacy}","received_events_url":"https://api.github.com/users/DanKatzuv/received_events","type":"User","site_admin":false},"html_url":"https://github.com/DanKatzuv/BaseBot","description":"Base robot code","fork":true,"url":"https://api.github.com/repos/DanKatzuv/BaseBot","forks_url":"https://api.github.com/repos/DanKatzuv/BaseBot/forks","keys_url":"https://api.github.com/repos/DanKatzuv/BaseBot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DanKatzuv/BaseBot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DanKatzuv/BaseBot/teams","hooks_url":"https://api.github.com/repos/DanKatzuv/BaseBot/hooks","issue_events_url":"https://api.github.com/repos/DanKatzuv/BaseBot/issues/events{/number}","events_url":"https://api.github.com/repos/DanKatzuv/BaseBot/events","assignees_url":"https://api.github.com/repos/DanKatzuv/BaseBot/assignees{/user}","branches_url":"https://api.github.com/repos/DanKatzuv/BaseBot/branches{/branch}","tags_url":"https://api.github.com/repos/DanKatzuv/BaseBot/tags","blobs_url":"https://api.github.com/repos/DanKatzuv/BaseBot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DanKatzuv/BaseBot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DanKatzuv/BaseBot/git/refs{/sha}","trees_url":"https://api.github.com/repos/DanKatzuv/BaseBot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DanKatzuv/BaseBot/statuses/{sha}","languages_url":"https://api.github.com/repos/DanKatzuv/BaseBot/languages","stargazers_url":"https://api.github.com/repos/DanKatzuv/BaseBot/stargazers","contributors_url":"https://api.github.com/repos/DanKatzuv/BaseBot/contributors","subscribers_url":"https://api.github.com/repos/DanKatzuv/BaseBot/subscribers","subscription_url":"https://api.github.com/repos/DanKatzuv/BaseBot/subscription","commits_url":"https://api.github.com/repos/DanKatzuv/BaseBot/commits{/sha}","git_commits_url":"https://api.github.com/repos/DanKatzuv/BaseBot/git/commits{/sha}","comments_url":"https://api.github.com/repos/DanKatzuv/BaseBot/comments{/number}","issue_comment_url":"https://api.github.com/repos/DanKatzuv/BaseBot/issues/comments{/number}","contents_url":"https://api.github.com/repos/DanKatzuv/BaseBot/contents/{+path}","compare_url":"https://api.github.com/repos/DanKatzuv/BaseBot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DanKatzuv/BaseBot/merges","archive_url":"https://api.github.com/repos/DanKatzuv/BaseBot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DanKatzuv/BaseBot/downloads","issues_url":"https://api.github.com/repos/DanKatzuv/BaseBot/issues{/number}","pulls_url":"https://api.github.com/repos/DanKatzuv/BaseBot/pulls{/number}","milestones_url":"https://api.github.com/repos/DanKatzuv/BaseBot/milestones{/number}","notifications_url":"https://api.github.com/repos/DanKatzuv/BaseBot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DanKatzuv/BaseBot/labels{/name}","releases_url":"https://api.github.com/repos/DanKatzuv/BaseBot/releases{/id}","deployments_url":"https://api.github.com/repos/DanKatzuv/BaseBot/deployments","created_at":"2018-10-16T15:16:44Z","updated_at":"2018-12-07T09:03:13Z","pushed_at":"2018-12-07T14:59:51Z","git_url":"git://github.com/DanKatzuv/BaseBot.git","ssh_url":"git@github.com:DanKatzuv/BaseBot.git","clone_url":"https://github.com/DanKatzuv/BaseBot.git","svn_url":"https://github.com/DanKatzuv/BaseBot","homepage":null,"size":683,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":9,"license":null,"forks":0,"open_issues":9,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DanKatzuv/BaseBot/pulls/49"},"html":{"href":"https://github.com/DanKatzuv/BaseBot/pull/49"},"issue":{"href":"https://api.github.com/repos/DanKatzuv/BaseBot/issues/49"},"comments":{"href":"https://api.github.com/repos/DanKatzuv/BaseBot/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/DanKatzuv/BaseBot/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/DanKatzuv/BaseBot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DanKatzuv/BaseBot/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/DanKatzuv/BaseBot/statuses/4ba6d8f28d8a8eccb5440b34f46fd5def1914f07"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":81,"additions":369,"deletions":203,"changed_files":11}}
{"actor":{"display_login":"pauloalbert"}}