{"action":"created","comment":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/242359215","pull_request_review_id":185850645,"id":242359215,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjM1OTIxNQ==","diff_hunk":"@@ -174,24 +180,24 @@ def color_name_to_rgb(color_name: str) -> Tuple[int, int, int]:\n \n \n # pylint: disable=invalid-name\n-def color_RGB_to_xy(iR: int, iG: int, iB: int) -> Tuple[float, float]:\n+def color_RGB_to_xy(iR: int, iG: int, iB: int, Gamut: Optional[GAMUT_TYPE] = None) -> Tuple[float, float]:","path":"homeassistant/util/color.py","position":27,"original_position":27,"commit_id":"ee0a805804cb24074dbfe7b687cbc6f148126ea3","original_commit_id":"ee0a805804cb24074dbfe7b687cbc6f148126ea3","user":{"login":"houndci-bot","id":6697940,"node_id":"MDQ6VXNlcjY2OTc5NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"line too long (106 > 79 characters)","created_at":"2018-12-17T23:42:04Z","updated_at":"2018-12-17T23:42:05Z","html_url":"https://github.com/home-assistant/home-assistant/pull/19123#discussion_r242359215","pull_request_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/19123","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/242359215"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/19123#discussion_r242359215"},"pull_request":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/19123"}}},"pull_request":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/19123","id":237070033,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3MDcwMDMz","html_url":"https://github.com/home-assistant/home-assistant/pull/19123","diff_url":"https://github.com/home-assistant/home-assistant/pull/19123.diff","patch_url":"https://github.com/home-assistant/home-assistant/pull/19123.patch","issue_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/19123","number":19123,"state":"open","locked":false,"title":"Improve Philips Hue color conversion","user":{"login":"starkillerOG","id":14811189,"node_id":"MDQ6VXNlcjE0ODExMTg5","avatar_url":"https://avatars0.githubusercontent.com/u/14811189?v=4","gravatar_id":"","url":"https://api.github.com/users/starkillerOG","html_url":"https://github.com/starkillerOG","followers_url":"https://api.github.com/users/starkillerOG/followers","following_url":"https://api.github.com/users/starkillerOG/following{/other_user}","gists_url":"https://api.github.com/users/starkillerOG/gists{/gist_id}","starred_url":"https://api.github.com/users/starkillerOG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/starkillerOG/subscriptions","organizations_url":"https://api.github.com/users/starkillerOG/orgs","repos_url":"https://api.github.com/users/starkillerOG/repos","events_url":"https://api.github.com/users/starkillerOG/events{/privacy}","received_events_url":"https://api.github.com/users/starkillerOG/received_events","type":"User","site_admin":false},"body":"## Description:\r\nThe Philips Hue lights do not support the ordinarry color gammut, theirfore when a color is selected that the philips hue light cannot produce, the closest color that can be produced needs to be found.\r\nUsing a rgb to hs conversion that was made specifically for the philips hue lights, much closer colors can be produced.\r\nThis is most obvious when selecting pure blue: RGB:[0,0,255].\r\nThis PR theirfore improves color selection when selecting collors with high saturation (HSV with S=100%).\r\ncolors within the capability of the Hue lights are not changed by this PR, they will still be identical.\r\n\r\n**Related issue (if applicable):** fixes #<home-assistant issue number goes here>\r\n\r\n**Pull request in [home-assistant.io](https://github.com/home-assistant/home-assistant.io) with documentation (if applicable):** home-assistant/home-assistant.io#<home-assistant.io PR number goes here>\r\n\r\n## Example entry for `configuration.yaml` (if applicable):\r\n```yaml\r\n\r\n```\r\n\r\n## Checklist:\r\n  - [x] The code change is tested and works locally.\r\n  - [x] Local tests pass with `tox`. **Your PR cannot be merged unless tests pass**\r\n  - [x] There is no commented out code in this PR.\r\n\r\nIf user exposed functionality or configuration variables are added/changed:\r\n  - [x] Documentation added/updated in [home-assistant.io](https://github.com/home-assistant/home-assistant.io)\r\n\r\nIf the code communicates with devices, web services, or third-party tools:\r\n  - [x] New dependencies have been added to the `REQUIREMENTS` variable ([example][ex-requir]).\r\n  - [x] New dependencies are only imported inside functions that use them ([example][ex-import]).\r\n  - [x] New or updated dependencies have been added to `requirements_all.txt` by running `script/gen_requirements_all.py`.\r\n  - [x] New files were added to `.coveragerc`.\r\n\r\nIf the code does not interact with devices:\r\n  - [x] Tests have been added to verify that the new code works.\r\n\r\n[ex-requir]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L14\r\n[ex-import]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L54\r\n","created_at":"2018-12-08T14:09:07Z","updated_at":"2018-12-17T23:42:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bd90094e9f56b98f14016d5292910ba1f463b930","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[{"name":"Core","id":2410391,"node_id":"MDQ6VGVhbTI0MTAzOTE=","slug":"core","description":"Developers with knowledge of the Home Assistant core","privacy":"closed","url":"https://api.github.com/teams/2410391","members_url":"https://api.github.com/teams/2410391/members{/member}","repositories_url":"https://api.github.com/teams/2410391/repos","permission":"pull"}],"labels":[{"id":527871105,"node_id":"MDU6TGFiZWw1Mjc4NzExMDU=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/cla-signed","name":"cla-signed","color":"008000","default":false},{"id":955422305,"node_id":"MDU6TGFiZWw5NTU0MjIzMDU=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/in%20progress","name":"in progress","color":"ededed","default":false},{"id":528094595,"node_id":"MDU6TGFiZWw1MjgwOTQ1OTU=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/platform:%20light.hue","name":"platform: light.hue","color":"ededed","default":false},{"id":832964196,"node_id":"MDU6TGFiZWw4MzI5NjQxOTY=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/small-pr","name":"small-pr","color":"e5bd7e","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/19123/commits","review_comments_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/19123/comments","review_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/19123/comments","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/ee0a805804cb24074dbfe7b687cbc6f148126ea3","head":{"label":"starkillerOG:patch-10","ref":"patch-10","sha":"ee0a805804cb24074dbfe7b687cbc6f148126ea3","user":{"login":"starkillerOG","id":14811189,"node_id":"MDQ6VXNlcjE0ODExMTg5","avatar_url":"https://avatars0.githubusercontent.com/u/14811189?v=4","gravatar_id":"","url":"https://api.github.com/users/starkillerOG","html_url":"https://github.com/starkillerOG","followers_url":"https://api.github.com/users/starkillerOG/followers","following_url":"https://api.github.com/users/starkillerOG/following{/other_user}","gists_url":"https://api.github.com/users/starkillerOG/gists{/gist_id}","starred_url":"https://api.github.com/users/starkillerOG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/starkillerOG/subscriptions","organizations_url":"https://api.github.com/users/starkillerOG/orgs","repos_url":"https://api.github.com/users/starkillerOG/repos","events_url":"https://api.github.com/users/starkillerOG/events{/privacy}","received_events_url":"https://api.github.com/users/starkillerOG/received_events","type":"User","site_admin":false},"repo":{"id":116702701,"node_id":"MDEwOlJlcG9zaXRvcnkxMTY3MDI3MDE=","name":"home-assistant","full_name":"starkillerOG/home-assistant","private":false,"owner":{"login":"starkillerOG","id":14811189,"node_id":"MDQ6VXNlcjE0ODExMTg5","avatar_url":"https://avatars0.githubusercontent.com/u/14811189?v=4","gravatar_id":"","url":"https://api.github.com/users/starkillerOG","html_url":"https://github.com/starkillerOG","followers_url":"https://api.github.com/users/starkillerOG/followers","following_url":"https://api.github.com/users/starkillerOG/following{/other_user}","gists_url":"https://api.github.com/users/starkillerOG/gists{/gist_id}","starred_url":"https://api.github.com/users/starkillerOG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/starkillerOG/subscriptions","organizations_url":"https://api.github.com/users/starkillerOG/orgs","repos_url":"https://api.github.com/users/starkillerOG/repos","events_url":"https://api.github.com/users/starkillerOG/events{/privacy}","received_events_url":"https://api.github.com/users/starkillerOG/received_events","type":"User","site_admin":false},"html_url":"https://github.com/starkillerOG/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":true,"url":"https://api.github.com/repos/starkillerOG/home-assistant","forks_url":"https://api.github.com/repos/starkillerOG/home-assistant/forks","keys_url":"https://api.github.com/repos/starkillerOG/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/starkillerOG/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/starkillerOG/home-assistant/teams","hooks_url":"https://api.github.com/repos/starkillerOG/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/starkillerOG/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/starkillerOG/home-assistant/events","assignees_url":"https://api.github.com/repos/starkillerOG/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/starkillerOG/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/starkillerOG/home-assistant/tags","blobs_url":"https://api.github.com/repos/starkillerOG/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/starkillerOG/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/starkillerOG/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/starkillerOG/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/starkillerOG/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/starkillerOG/home-assistant/languages","stargazers_url":"https://api.github.com/repos/starkillerOG/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/starkillerOG/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/starkillerOG/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/starkillerOG/home-assistant/subscription","commits_url":"https://api.github.com/repos/starkillerOG/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/starkillerOG/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/starkillerOG/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/starkillerOG/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/starkillerOG/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/starkillerOG/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/starkillerOG/home-assistant/merges","archive_url":"https://api.github.com/repos/starkillerOG/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/starkillerOG/home-assistant/downloads","issues_url":"https://api.github.com/repos/starkillerOG/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/starkillerOG/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/starkillerOG/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/starkillerOG/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/starkillerOG/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/starkillerOG/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/starkillerOG/home-assistant/deployments","created_at":"2018-01-08T16:47:09Z","updated_at":"2018-01-08T16:47:17Z","pushed_at":"2018-12-17T23:41:26Z","git_url":"git://github.com/starkillerOG/home-assistant.git","ssh_url":"git@github.com:starkillerOG/home-assistant.git","clone_url":"https://github.com/starkillerOG/home-assistant.git","svn_url":"https://github.com/starkillerOG/home-assistant","homepage":"https://home-assistant.io","size":95759,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"home-assistant:dev","ref":"dev","sha":"2134331e2ba597c5a0de098130105e0df82cf0f1","user":{"login":"home-assistant","id":13844975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODQ0OTc1","avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"repo":{"id":12888993,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg4ODk5Mw==","name":"home-assistant","full_name":"home-assistant/home-assistant","private":false,"owner":{"login":"home-assistant","id":13844975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODQ0OTc1","avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/home-assistant/home-assistant","description":":house_with_garden: Open source home automation that puts local control and privacy first","fork":false,"url":"https://api.github.com/repos/home-assistant/home-assistant","forks_url":"https://api.github.com/repos/home-assistant/home-assistant/forks","keys_url":"https://api.github.com/repos/home-assistant/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/home-assistant/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/home-assistant/home-assistant/teams","hooks_url":"https://api.github.com/repos/home-assistant/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/home-assistant/home-assistant/events","assignees_url":"https://api.github.com/repos/home-assistant/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/home-assistant/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/home-assistant/home-assistant/tags","blobs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/home-assistant/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/home-assistant/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/home-assistant/home-assistant/languages","stargazers_url":"https://api.github.com/repos/home-assistant/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/home-assistant/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/home-assistant/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/home-assistant/home-assistant/subscription","commits_url":"https://api.github.com/repos/home-assistant/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/home-assistant/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/home-assistant/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/home-assistant/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/home-assistant/home-assistant/merges","archive_url":"https://api.github.com/repos/home-assistant/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/home-assistant/home-assistant/downloads","issues_url":"https://api.github.com/repos/home-assistant/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/home-assistant/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/home-assistant/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/home-assistant/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/home-assistant/home-assistant/deployments","created_at":"2013-09-17T07:29:48Z","updated_at":"2018-12-17T23:31:41Z","pushed_at":"2018-12-17T23:41:29Z","git_url":"git://github.com/home-assistant/home-assistant.git","ssh_url":"git@github.com:home-assistant/home-assistant.git","clone_url":"https://github.com/home-assistant/home-assistant.git","svn_url":"https://github.com/home-assistant/home-assistant","homepage":"https://www.home-assistant.io","size":95963,"stargazers_count":19362,"watchers_count":19362,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5690,"mirror_url":null,"archived":false,"open_issues_count":901,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5690,"open_issues":901,"watchers":19362,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/19123"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/19123"},"issue":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/19123"},"comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/19123/comments"},"review_comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/19123/comments"},"review_comment":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/19123/commits"},"statuses":{"href":"https://api.github.com/repos/home-assistant/home-assistant/statuses/ee0a805804cb24074dbfe7b687cbc6f148126ea3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"houndci-bot"}}