{"action":"created","comment":{"url":"https://api.github.com/repos/istio/istio/pulls/comments/238037428","pull_request_review_id":180467289,"id":238037428,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODAzNzQyOA==","diff_hunk":"@@ -613,6 +609,51 @@ func (s *DiscoveryServer) StreamAggregatedResources(stream ads.AggregatedDiscove\n \t}\n }\n \n+// update the node associated with the connection, after receiving a a packet from envoy.\n+func (s *DiscoveryServer) initConnectionNode(discReq *xdsapi.DiscoveryRequest, con *XdsConnection) error {\n+\tcon.mu.RLock()\n+\tif con.modelNode != nil {\n+\t\tcon.mu.RUnlock()\n+\t\treturn nil // only need to init the node on first request in the stream\n+\t}\n+\tcon.mu.RUnlock()","path":"pilot/pkg/proxy/envoy/v2/ads.go","position":61,"original_position":95,"commit_id":"650dc69681cfe2a21791433a68d78ae92801f1c4","original_commit_id":"a3a0f14ea3e35e0b77a623fd3684238eade1d8f7","user":{"login":"costinm","id":84202,"node_id":"MDQ6VXNlcjg0MjAy","avatar_url":"https://avatars1.githubusercontent.com/u/84202?v=4","gravatar_id":"","url":"https://api.github.com/users/costinm","html_url":"https://github.com/costinm","followers_url":"https://api.github.com/users/costinm/followers","following_url":"https://api.github.com/users/costinm/following{/other_user}","gists_url":"https://api.github.com/users/costinm/gists{/gist_id}","starred_url":"https://api.github.com/users/costinm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/costinm/subscriptions","organizations_url":"https://api.github.com/users/costinm/orgs","repos_url":"https://api.github.com/users/costinm/repos","events_url":"https://api.github.com/users/costinm/events{/privacy}","received_events_url":"https://api.github.com/users/costinm/received_events","type":"User","site_admin":false},"body":"AFAIK access to a pointer is not atomic - it needs to be synced if another goroutine may modify the pointer while it is read.  In this case it may not be needed ( since con.modelNode is set at connect ), but I would rather have it.\r\n\r\n ","created_at":"2018-12-01T00:02:40Z","updated_at":"2018-12-01T00:09:19Z","html_url":"https://github.com/istio/istio/pull/9361#discussion_r238037428","pull_request_url":"https://api.github.com/repos/istio/istio/pulls/9361","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/comments/238037428"},"html":{"href":"https://github.com/istio/istio/pull/9361#discussion_r238037428"},"pull_request":{"href":"https://api.github.com/repos/istio/istio/pulls/9361"}},"in_reply_to_id":237719802},"pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/9361","id":223356615,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzMzU2NjE1","html_url":"https://github.com/istio/istio/pull/9361","diff_url":"https://github.com/istio/istio/pull/9361.diff","patch_url":"https://github.com/istio/istio/pull/9361.patch","issue_url":"https://api.github.com/repos/istio/istio/issues/9361","number":9361,"state":"open","locked":false,"title":"Initial code for NetworkScope - filter outbound listener/routes ","user":{"login":"costinm","id":84202,"node_id":"MDQ6VXNlcjg0MjAy","avatar_url":"https://avatars1.githubusercontent.com/u/84202?v=4","gravatar_id":"","url":"https://api.github.com/users/costinm","html_url":"https://github.com/costinm","followers_url":"https://api.github.com/users/costinm/followers","following_url":"https://api.github.com/users/costinm/following{/other_user}","gists_url":"https://api.github.com/users/costinm/gists{/gist_id}","starred_url":"https://api.github.com/users/costinm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/costinm/subscriptions","organizations_url":"https://api.github.com/users/costinm/orgs","repos_url":"https://api.github.com/users/costinm/repos","events_url":"https://api.github.com/users/costinm/events{/privacy}","received_events_url":"https://api.github.com/users/costinm/received_events","type":"User","site_admin":false},"body":"Enable namespace isolation - the services used in generating outbound listeners and routes will\r\ninclude only local namespace and explicitly defined imports.\r\n\r\nThis seems the simplest approach for the current code - we can optimize it further. \r\n\r\nSeparate PRs will add the import, once  the API is finalized - but this setting can already be \r\nused on larger clusters if most namespaces only receive requests from gateways.\r\nFor Clusters/EDS we'll build a list based on Listeners/Routes - in a separate PR. ","created_at":"2018-10-16T18:45:24Z","updated_at":"2018-12-01T00:09:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"da4a9debe9fa77187b01e73f3fde52030105b19f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ZackButcher","id":1923135,"node_id":"MDQ6VXNlcjE5MjMxMzU=","avatar_url":"https://avatars2.githubusercontent.com/u/1923135?v=4","gravatar_id":"","url":"https://api.github.com/users/ZackButcher","html_url":"https://github.com/ZackButcher","followers_url":"https://api.github.com/users/ZackButcher/followers","following_url":"https://api.github.com/users/ZackButcher/following{/other_user}","gists_url":"https://api.github.com/users/ZackButcher/gists{/gist_id}","starred_url":"https://api.github.com/users/ZackButcher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZackButcher/subscriptions","organizations_url":"https://api.github.com/users/ZackButcher/orgs","repos_url":"https://api.github.com/users/ZackButcher/repos","events_url":"https://api.github.com/users/ZackButcher/events{/privacy}","received_events_url":"https://api.github.com/users/ZackButcher/received_events","type":"User","site_admin":false},{"login":"louiscryan","id":9046588,"node_id":"MDQ6VXNlcjkwNDY1ODg=","avatar_url":"https://avatars2.githubusercontent.com/u/9046588?v=4","gravatar_id":"","url":"https://api.github.com/users/louiscryan","html_url":"https://github.com/louiscryan","followers_url":"https://api.github.com/users/louiscryan/followers","following_url":"https://api.github.com/users/louiscryan/following{/other_user}","gists_url":"https://api.github.com/users/louiscryan/gists{/gist_id}","starred_url":"https://api.github.com/users/louiscryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/louiscryan/subscriptions","organizations_url":"https://api.github.com/users/louiscryan/orgs","repos_url":"https://api.github.com/users/louiscryan/repos","events_url":"https://api.github.com/users/louiscryan/events{/privacy}","received_events_url":"https://api.github.com/users/louiscryan/received_events","type":"User","site_admin":false},{"login":"andraxylia","id":10883640,"node_id":"MDQ6VXNlcjEwODgzNjQw","avatar_url":"https://avatars0.githubusercontent.com/u/10883640?v=4","gravatar_id":"","url":"https://api.github.com/users/andraxylia","html_url":"https://github.com/andraxylia","followers_url":"https://api.github.com/users/andraxylia/followers","following_url":"https://api.github.com/users/andraxylia/following{/other_user}","gists_url":"https://api.github.com/users/andraxylia/gists{/gist_id}","starred_url":"https://api.github.com/users/andraxylia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andraxylia/subscriptions","organizations_url":"https://api.github.com/users/andraxylia/orgs","repos_url":"https://api.github.com/users/andraxylia/repos","events_url":"https://api.github.com/users/andraxylia/events{/privacy}","received_events_url":"https://api.github.com/users/andraxylia/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":659652351,"node_id":"MDU6TGFiZWw2NTk2NTIzNTE=","url":"https://api.github.com/repos/istio/istio/labels/approved","name":"approved","color":"bfdadc","default":false},{"id":491318011,"node_id":"MDU6TGFiZWw0OTEzMTgwMTE=","url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/istio/istio/pulls/9361/commits","review_comments_url":"https://api.github.com/repos/istio/istio/pulls/9361/comments","review_comment_url":"https://api.github.com/repos/istio/istio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/istio/issues/9361/comments","statuses_url":"https://api.github.com/repos/istio/istio/statuses/650dc69681cfe2a21791433a68d78ae92801f1c4","head":{"label":"costinm:11-graph","ref":"11-graph","sha":"650dc69681cfe2a21791433a68d78ae92801f1c4","user":{"login":"costinm","id":84202,"node_id":"MDQ6VXNlcjg0MjAy","avatar_url":"https://avatars1.githubusercontent.com/u/84202?v=4","gravatar_id":"","url":"https://api.github.com/users/costinm","html_url":"https://github.com/costinm","followers_url":"https://api.github.com/users/costinm/followers","following_url":"https://api.github.com/users/costinm/following{/other_user}","gists_url":"https://api.github.com/users/costinm/gists{/gist_id}","starred_url":"https://api.github.com/users/costinm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/costinm/subscriptions","organizations_url":"https://api.github.com/users/costinm/orgs","repos_url":"https://api.github.com/users/costinm/repos","events_url":"https://api.github.com/users/costinm/events{/privacy}","received_events_url":"https://api.github.com/users/costinm/received_events","type":"User","site_admin":false},"repo":{"id":100538352,"node_id":"MDEwOlJlcG9zaXRvcnkxMDA1MzgzNTI=","name":"istio","full_name":"costinm/istio","private":false,"owner":{"login":"costinm","id":84202,"node_id":"MDQ6VXNlcjg0MjAy","avatar_url":"https://avatars1.githubusercontent.com/u/84202?v=4","gravatar_id":"","url":"https://api.github.com/users/costinm","html_url":"https://github.com/costinm","followers_url":"https://api.github.com/users/costinm/followers","following_url":"https://api.github.com/users/costinm/following{/other_user}","gists_url":"https://api.github.com/users/costinm/gists{/gist_id}","starred_url":"https://api.github.com/users/costinm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/costinm/subscriptions","organizations_url":"https://api.github.com/users/costinm/orgs","repos_url":"https://api.github.com/users/costinm/repos","events_url":"https://api.github.com/users/costinm/events{/privacy}","received_events_url":"https://api.github.com/users/costinm/received_events","type":"User","site_admin":false},"html_url":"https://github.com/costinm/istio","description":"Sample code, build and tests and governance material for the Istio project.","fork":true,"url":"https://api.github.com/repos/costinm/istio","forks_url":"https://api.github.com/repos/costinm/istio/forks","keys_url":"https://api.github.com/repos/costinm/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/costinm/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/costinm/istio/teams","hooks_url":"https://api.github.com/repos/costinm/istio/hooks","issue_events_url":"https://api.github.com/repos/costinm/istio/issues/events{/number}","events_url":"https://api.github.com/repos/costinm/istio/events","assignees_url":"https://api.github.com/repos/costinm/istio/assignees{/user}","branches_url":"https://api.github.com/repos/costinm/istio/branches{/branch}","tags_url":"https://api.github.com/repos/costinm/istio/tags","blobs_url":"https://api.github.com/repos/costinm/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/costinm/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/costinm/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/costinm/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/costinm/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/costinm/istio/languages","stargazers_url":"https://api.github.com/repos/costinm/istio/stargazers","contributors_url":"https://api.github.com/repos/costinm/istio/contributors","subscribers_url":"https://api.github.com/repos/costinm/istio/subscribers","subscription_url":"https://api.github.com/repos/costinm/istio/subscription","commits_url":"https://api.github.com/repos/costinm/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/costinm/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/costinm/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/costinm/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/costinm/istio/contents/{+path}","compare_url":"https://api.github.com/repos/costinm/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/costinm/istio/merges","archive_url":"https://api.github.com/repos/costinm/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/costinm/istio/downloads","issues_url":"https://api.github.com/repos/costinm/istio/issues{/number}","pulls_url":"https://api.github.com/repos/costinm/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/costinm/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/costinm/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/costinm/istio/labels{/name}","releases_url":"https://api.github.com/repos/costinm/istio/releases{/id}","deployments_url":"https://api.github.com/repos/costinm/istio/deployments","created_at":"2017-08-16T22:38:24Z","updated_at":"2018-04-27T23:29:00Z","pushed_at":"2018-12-01T00:09:18Z","git_url":"git://github.com/costinm/istio.git","ssh_url":"git@github.com:costinm/istio.git","clone_url":"https://github.com/costinm/istio.git","svn_url":"https://github.com/costinm/istio","homepage":"https://istio.io","size":136925,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:release-1.1","ref":"release-1.1","sha":"78c38576f2c23d2cc0bb8e47ccedd4bc97fd34ce","user":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":74175805,"node_id":"MDEwOlJlcG9zaXRvcnk3NDE3NTgwNQ==","name":"istio","full_name":"istio/istio","private":false,"owner":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/istio/istio","description":"Connect, secure, control, and observe services.","fork":false,"url":"https://api.github.com/repos/istio/istio","forks_url":"https://api.github.com/repos/istio/istio/forks","keys_url":"https://api.github.com/repos/istio/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/istio/teams","hooks_url":"https://api.github.com/repos/istio/istio/hooks","issue_events_url":"https://api.github.com/repos/istio/istio/issues/events{/number}","events_url":"https://api.github.com/repos/istio/istio/events","assignees_url":"https://api.github.com/repos/istio/istio/assignees{/user}","branches_url":"https://api.github.com/repos/istio/istio/branches{/branch}","tags_url":"https://api.github.com/repos/istio/istio/tags","blobs_url":"https://api.github.com/repos/istio/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/istio/languages","stargazers_url":"https://api.github.com/repos/istio/istio/stargazers","contributors_url":"https://api.github.com/repos/istio/istio/contributors","subscribers_url":"https://api.github.com/repos/istio/istio/subscribers","subscription_url":"https://api.github.com/repos/istio/istio/subscription","commits_url":"https://api.github.com/repos/istio/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/istio/contents/{+path}","compare_url":"https://api.github.com/repos/istio/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/istio/merges","archive_url":"https://api.github.com/repos/istio/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/istio/downloads","issues_url":"https://api.github.com/repos/istio/istio/issues{/number}","pulls_url":"https://api.github.com/repos/istio/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/istio/labels{/name}","releases_url":"https://api.github.com/repos/istio/istio/releases{/id}","deployments_url":"https://api.github.com/repos/istio/istio/deployments","created_at":"2016-11-18T23:57:21Z","updated_at":"2018-11-30T23:38:09Z","pushed_at":"2018-11-30T23:58:18Z","git_url":"git://github.com/istio/istio.git","ssh_url":"git@github.com:istio/istio.git","clone_url":"https://github.com/istio/istio.git","svn_url":"https://github.com/istio/istio","homepage":"https://istio.io","size":55147,"stargazers_count":13494,"watchers_count":13494,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2058,"mirror_url":null,"archived":false,"open_issues_count":1018,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2058,"open_issues":1018,"watchers":13494,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/9361"},"html":{"href":"https://github.com/istio/istio/pull/9361"},"issue":{"href":"https://api.github.com/repos/istio/istio/issues/9361"},"comments":{"href":"https://api.github.com/repos/istio/istio/issues/9361/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/istio/pulls/9361/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/istio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/istio/pulls/9361/commits"},"statuses":{"href":"https://api.github.com/repos/istio/istio/statuses/650dc69681cfe2a21791433a68d78ae92801f1c4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"costinm"}}