{"push_id":2941593549,"size":125,"distinct_size":1,"ref":"refs/heads/connection-switching","head":"86b876f527d5711b5df5aeb41365e50032f9d86b","before":"274ed5cf42e1b8198b015ebce81c77573c2aa36b","commits":[{"sha":"e385e4678fc64be6e176c3bdac6641db9fe48d85","author":{"name":"Ilkka Oksanen","email":"d41be4f616b5f89e38122e6d2d52cd7074f22e3a@iki.fi"},"message":"Don't handle params option in a special way in url_for helper","distinct":false,"url":"https://api.github.com/repos/eileencodes/rails/commits/e385e4678fc64be6e176c3bdac6641db9fe48d85"},{"sha":"a725539de677adbea0ced19d65647e975dbd3f84","author":{"name":"Bruno Casali","email":"085314d743da61554f59185bdc7c8a00900f224a@gmail.com"},"message":"Remove \"include FileUtils\" sentence in setup/update bin files\n\nAccording with rubocop style guide \"Style/MixinUsage\" is good to use only in\nclass/module not directly in file.","distinct":false,"url":"https://api.github.com/repos/eileencodes/rails/commits/a725539de677adbea0ced19d65647e975dbd3f84"},{"sha":"6da99b4e99c90c63015f0d1cb4bf10983ea26a36","author":{"name":"schneems","email":"a7a532ca64eb4cf510aab174cdabcc084c29a395@gmail.com"},"message":"Decrease memory allocations in cache.rb\n\nThe `merged_options` method is private and the output is never mutated.\nUsing this info we can get rid of the `dup` behavior. We can also\neliminate the `merge` call in the case where all the options being merged are the same.\n\nReturned results are frozen as an extra layer of protection against\nmutation.\n\nBefore\n\n```\nTotal allocated: 741749 bytes (6642 objects)\n```\n\nAfter\n\n```\nTotal allocated: 734039 bytes (6648 objects)\n```\n\nDiff\n\n```\n(741749 - 734039) / 741749.0 => ~ 1.0 %\n```\n\nIf you don't feel comfortable modifying this method, we could rename it\nand only use it internally.","distinct":false,"url":"https://api.github.com/repos/eileencodes/rails/commits/6da99b4e99c90c63015f0d1cb4bf10983ea26a36"},{"sha":"5e4c22dfbb6dad676f74ded50b8c2536834a46a7","author":{"name":"Mehmet Emin INAC","email":"e6fe9b428cbd844027679efe8ffd169eb501ceab@gmail.com"},"message":"Index option added for change_table migrations\n\nIn case if we want to add a column into the existing table\nwith index on it, we have to add column and index in two\nseperate lines.\nWith this feature we don't need to write an extra line to\nadd index for column. We can just use `index` option.\n\nOld behaviour in action:\n```\n  change_table(:languages) do |t|\n    t.string :country_code\n    t.index: :country_code\n  end\n```\n\nNew behaviour in action:\n```\n  change_table(:languages) do |t|\n    t.string :country_code, index: true\n  end\n```\n\nExactly same behaviour is already exist for `create_table` migrations.","distinct":false,"url":"https://api.github.com/repos/eileencodes/rails/commits/5e4c22dfbb6dad676f74ded50b8c2536834a46a7"},{"sha":"b1059f3cf008dbf459d9772f1ae30bf8b336476b","author":{"name":"Graham Turner","email":"0c632e75309a817a72b55f158bddf42805e67340@gmail.com"},"message":"Updates expires_in docs\n\nPreviously the documentation for expires_in suggested that the option\nwas available for all cache stores. This clarifies that the behavior can\nbe supported, but is not always supported.","distinct":false,"url":"https://api.github.com/repos/eileencodes/rails/commits/b1059f3cf008dbf459d9772f1ae30bf8b336476b"},{"sha":"4775d3d051af1a506b63a7e4069c94e49c82177d","author":{"name":"Gannon McGibbon","email":"d615127a300a651d0c875f1e1fc814463278489b@gmail.com"},"message":"Refactor migrations_path command option to database","distinct":false,"url":"https://api.github.com/repos/eileencodes/rails/commits/4775d3d051af1a506b63a7e4069c94e49c82177d"},{"sha":"ec9a89cb8be037cde2466a5347ea5c4ec648a4c3","author":{"name":"Gannon McGibbon","email":"d615127a300a651d0c875f1e1fc814463278489b@gmail.com"},"message":"Add deprecation warning when String#first and String#last receive negative integers\n\n[Gannon McGibbon + Eric Turner]","distinct":false,"url":"https://api.github.com/repos/eileencodes/rails/commits/ec9a89cb8be037cde2466a5347ea5c4ec648a4c3"},{"sha":"7bc343b3a9ef7581e665a9f70f00d494f7a3b62c","author":{"name":"Eileen M. Uchitelle","email":"7a0559213618bb59f33e95efd260811728549345@users.noreply.github.com"},"message":"Merge pull request #34021 from gmcgibbon/change_migrations_paths_command_option_to_db\n\nRefactor migrations_path command option to database","distinct":false,"url":"https://api.github.com/repos/eileencodes/rails/commits/7bc343b3a9ef7581e665a9f70f00d494f7a3b62c"},{"sha":"3727215591dfe1320233d3800b16a7fa455595ae","author":{"name":"Yuji Yaginuma","email":"16356534c1589fe78070f5640bedf8614007153c@gmail.com"},"message":"Merge pull request #34020 from tgturner/update-cache-docs\n\nUpdates expires_in docs","distinct":false,"url":"https://api.github.com/repos/eileencodes/rails/commits/3727215591dfe1320233d3800b16a7fa455595ae"},{"sha":"445a74e1a953c0b0bddf51b69865d43cce6ea859","author":{"name":"yuuji.yaginuma","email":"16356534c1589fe78070f5640bedf8614007153c@gmail.com"},"message":"Reset `ActiveRecord::Base.configurations` to the value before","distinct":false,"url":"https://api.github.com/repos/eileencodes/rails/commits/445a74e1a953c0b0bddf51b69865d43cce6ea859"},{"sha":"aa3dcabd874a3e82e455e85a1c94a7abaac2900a","author":{"name":"Yasuo Honda","email":"815806a5fcba2cb411d0f70b662adf0091c5dee5@gmail.com"},"message":"Add `Style/RedundantFreeze` to remove redudant `.freeze`\n\nSince Rails 6.0 will support Ruby 2.4.1 or higher\n`# frozen_string_literal: true` magic comment is enough to make string object frozen.\nThis magic comment is enabled by `Style/FrozenStringLiteralComment` cop.\n\n* Exclude these files not to auto correct false positive `Regexp#freeze`\n - 'actionpack/lib/action_dispatch/journey/router/utils.rb'\n - 'activerecord/lib/active_record/connection_adapters/sqlite3_adapter.rb'\n\nIt has been fixed by https://github.com/rubocop-hq/rubocop/pull/6333\nOnce the newer version of RuboCop released and available at Code Climate these exclude entries should be removed.\n\n* Replace `String#freeze` with `String#-@` manually if explicit frozen string objects are required\n\n - 'actionpack/test/controller/test_case_test.rb'\n - 'activemodel/test/cases/type/string_test.rb'\n - 'activesupport/lib/active_support/core_ext/string/strip.rb'\n - 'activesupport/test/core_ext/string_ext_test.rb'\n - 'railties/test/generators/actions_test.rb'","distinct":false,"url":"https://api.github.com/repos/eileencodes/rails/commits/aa3dcabd874a3e82e455e85a1c94a7abaac2900a"},{"sha":"7ea546b5c661b18067ebec9d0badbd3c393964d2","author":{"name":"yuuji.yaginuma","email":"16356534c1589fe78070f5640bedf8614007153c@gmail.com"},"message":"Make `test_initialize_with_invalid_attribute` work correctly\n\nOriginally specified attributes were only normal values, and\n`ActiveRecord::MultiparameterAssignmentErrors` did not occur.\n\nIn addition, an assertion is performed only on rescue, even if an\nexception does not occur, the test passes. To avoid this use `assert_raise`.","distinct":false,"url":"https://api.github.com/repos/eileencodes/rails/commits/7ea546b5c661b18067ebec9d0badbd3c393964d2"},{"sha":"8bc0a43a2471f353f957bd422bffafa510a44282","author":{"name":"Ryuta Kamizono","email":"bca6f4261a19f75277fe4325de3272d15492eb61@gmail.com"},"message":"Remove `visit_Fixnum` and `visit_Bignum`\n\nFollow up ae406cd633dab2cafbc0d1bb5922d1ca40056ea0.","distinct":false,"url":"https://api.github.com/repos/eileencodes/rails/commits/8bc0a43a2471f353f957bd422bffafa510a44282"},{"sha":"09de7c91707b83a6c6ff8ab1a176cc1bf92ebb4d","author":{"name":"Ryuta Kamizono","email":"bca6f4261a19f75277fe4325de3272d15492eb61@gmail.com"},"message":"Use private attr_reader in Arel\n\nNo longer needed workaround for Ruby 2.2 \"private attribute?\" warning.\n\nRelated 6d63b5e49a399fe246afcebad45c3c962de268fa.","distinct":false,"url":"https://api.github.com/repos/eileencodes/rails/commits/09de7c91707b83a6c6ff8ab1a176cc1bf92ebb4d"},{"sha":"683a0b5042262d841bfed687a4c56125364cf7a7","author":{"name":"Ryuta Kamizono","email":"bca6f4261a19f75277fe4325de3272d15492eb61@gmail.com"},"message":"`visitor.accept` doesn't handle `&block`","distinct":false,"url":"https://api.github.com/repos/eileencodes/rails/commits/683a0b5042262d841bfed687a4c56125364cf7a7"},{"sha":"298629cefd845caf2cea28eb9cee2b538accc4ee","author":{"name":"Ryuta Kamizono","email":"bca6f4261a19f75277fe4325de3272d15492eb61@gmail.com"},"message":"`SQLString#compile` is no longer used since 53521a9e39b9d8af4165d7703c36dc905f1f8f67","distinct":false,"url":"https://api.github.com/repos/eileencodes/rails/commits/298629cefd845caf2cea28eb9cee2b538accc4ee"},{"sha":"859fba7c4bf7d33b4f9655914ed4bdc85380552e","author":{"name":"Ryuta Kamizono","email":"bca6f4261a19f75277fe4325de3272d15492eb61@gmail.com"},"message":"Handle DELETE with LIMIT in Arel\n\nMySQL supports DELETE with LIMIT and ORDER BY.\n\nhttps://dev.mysql.com/doc/refman/8.0/en/delete.html\n\nBefore:\n\n```\n  Post Destroy (1.0ms)  DELETE FROM `posts` WHERE `posts`.`id` IN (SELECT `id` FROM (SELECT `posts`.`id` FROM `posts` WHERE `posts`.`author_id` = ? ORDER BY `posts`.`id` ASC LIMIT ?) __active_record_temp)  [[\"author_id\", 1], [\"LIMIT\", 1]]\n```\n\nAfter:\n\n```\n  Post Destroy (0.4ms)  DELETE FROM `posts` WHERE `posts`.`author_id` = ? ORDER BY `posts`.`id` ASC LIMIT ?  [[\"author_id\", 1], [\"LIMIT\", 1]]\n```","distinct":false,"url":"https://api.github.com/repos/eileencodes/rails/commits/859fba7c4bf7d33b4f9655914ed4bdc85380552e"},{"sha":"df9c972afe88e3c9c65bfcd96eddca927a42b5e3","author":{"name":"Ryuta Kamizono","email":"bca6f4261a19f75277fe4325de3272d15492eb61@gmail.com"},"message":"Place `PartialQuery` and `PartialQueryCollector` in the same file","distinct":false,"url":"https://api.github.com/repos/eileencodes/rails/commits/df9c972afe88e3c9c65bfcd96eddca927a42b5e3"},{"sha":"5f6a906094641a8830d35dcc5e79cafa8c1db872","author":{"name":"Lachlan Sylvester","email":"ef4261e56dd60f493eb2aacead578dc6cf4232df@hypothetical.com.au"},"message":"Require the except hash extension before trying to alias it","distinct":false,"url":"https://api.github.com/repos/eileencodes/rails/commits/5f6a906094641a8830d35dcc5e79cafa8c1db872"},{"sha":"09f92a1b9883927dbeda23a0cc145a2a62a9df60","author":{"name":"Yuji Yaginuma","email":"16356534c1589fe78070f5640bedf8614007153c@gmail.com"},"message":"Merge pull request #34031 from lsylvester/require-except-before-aliasing-it\n\nRequire the except hash extension before trying to alias it","distinct":false,"url":"https://api.github.com/repos/eileencodes/rails/commits/09f92a1b9883927dbeda23a0cc145a2a62a9df60"}]}
{"actor":{"display_login":"eileencodes"}}