{"action":"created","comment":{"url":"https://api.github.com/repos/jupyter/notebook/pulls/comments/189688862","pull_request_review_id":121917123,"id":189688862,"diff_hunk":"@@ -0,0 +1,13 @@\n+# selenium test version for 'empty_arrow_keys.js'\n+\n+\n+def remove_cells(notebook):\n+    for i in notebook.cells:\n+        notebook.delete_cell(notebook.index(i))\n+    return True\n+\n+def test_empty_arrows_keys(notebook):\n+    # delete all the cells\n+    notebook.trigger_keydown('up')\n+    notebook.trigger_keydown('down')\n+    assert remove_cells(notebook);","path":"notebook/tests/selenium/test_empty_arrows_keys.py","position":13,"original_position":13,"commit_id":"70ce8fac3320ec14510526ed982cc0ff0a92b9b8","original_commit_id":"70ce8fac3320ec14510526ed982cc0ff0a92b9b8","user":{"login":"arovit","id":4410397,"avatar_url":"https://avatars1.githubusercontent.com/u/4410397?v=4","gravatar_id":"","url":"https://api.github.com/users/arovit","html_url":"https://github.com/arovit","followers_url":"https://api.github.com/users/arovit/followers","following_url":"https://api.github.com/users/arovit/following{/other_user}","gists_url":"https://api.github.com/users/arovit/gists{/gist_id}","starred_url":"https://api.github.com/users/arovit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arovit/subscriptions","organizations_url":"https://api.github.com/users/arovit/orgs","repos_url":"https://api.github.com/users/arovit/repos","events_url":"https://api.github.com/users/arovit/events{/privacy}","received_events_url":"https://api.github.com/users/arovit/received_events","type":"User","site_admin":false},"body":"Hmm, I agree that test was testing minimal behavior. Yes, Sure, I can add do this check.","created_at":"2018-05-21T19:25:52Z","updated_at":"2018-05-21T19:25:52Z","html_url":"https://github.com/jupyter/notebook/pull/3601#discussion_r189688862","pull_request_url":"https://api.github.com/repos/jupyter/notebook/pulls/3601","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/jupyter/notebook/pulls/comments/189688862"},"html":{"href":"https://github.com/jupyter/notebook/pull/3601#discussion_r189688862"},"pull_request":{"href":"https://api.github.com/repos/jupyter/notebook/pulls/3601"}},"in_reply_to_id":189668687},"pull_request":{"url":"https://api.github.com/repos/jupyter/notebook/pulls/3601","id":186417134,"html_url":"https://github.com/jupyter/notebook/pull/3601","diff_url":"https://github.com/jupyter/notebook/pull/3601.diff","patch_url":"https://github.com/jupyter/notebook/pull/3601.patch","issue_url":"https://api.github.com/repos/jupyter/notebook/issues/3601","number":3601,"state":"open","locked":false,"title":"[WIP] [3335] Convert JS tests to Selenium","user":{"login":"arovit","id":4410397,"avatar_url":"https://avatars1.githubusercontent.com/u/4410397?v=4","gravatar_id":"","url":"https://api.github.com/users/arovit","html_url":"https://github.com/arovit","followers_url":"https://api.github.com/users/arovit/followers","following_url":"https://api.github.com/users/arovit/following{/other_user}","gists_url":"https://api.github.com/users/arovit/gists{/gist_id}","starred_url":"https://api.github.com/users/arovit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arovit/subscriptions","organizations_url":"https://api.github.com/users/arovit/orgs","repos_url":"https://api.github.com/users/arovit/repos","events_url":"https://api.github.com/users/arovit/events{/privacy}","received_events_url":"https://api.github.com/users/arovit/received_events","type":"User","site_admin":false},"body":"  1. Converting 'empty_arrows_keys.js' into selenium based testcase\r\n  2. Moved \"delete_cell\" method to utils.py and modified references to use it from there\r\n  3. Added a generalized method \"trigger_keystrokes\" to send keystrokes to browser\r\n","created_at":"2018-05-07T17:48:20Z","updated_at":"2018-05-21T19:25:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"853550bee25dc5b1f6969adeac7b8dc0b1c7e6d9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jupyter/notebook/pulls/3601/commits","review_comments_url":"https://api.github.com/repos/jupyter/notebook/pulls/3601/comments","review_comment_url":"https://api.github.com/repos/jupyter/notebook/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jupyter/notebook/issues/3601/comments","statuses_url":"https://api.github.com/repos/jupyter/notebook/statuses/70ce8fac3320ec14510526ed982cc0ff0a92b9b8","head":{"label":"arovit:test_empty_arrows","ref":"test_empty_arrows","sha":"70ce8fac3320ec14510526ed982cc0ff0a92b9b8","user":{"login":"arovit","id":4410397,"avatar_url":"https://avatars1.githubusercontent.com/u/4410397?v=4","gravatar_id":"","url":"https://api.github.com/users/arovit","html_url":"https://github.com/arovit","followers_url":"https://api.github.com/users/arovit/followers","following_url":"https://api.github.com/users/arovit/following{/other_user}","gists_url":"https://api.github.com/users/arovit/gists{/gist_id}","starred_url":"https://api.github.com/users/arovit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arovit/subscriptions","organizations_url":"https://api.github.com/users/arovit/orgs","repos_url":"https://api.github.com/users/arovit/repos","events_url":"https://api.github.com/users/arovit/events{/privacy}","received_events_url":"https://api.github.com/users/arovit/received_events","type":"User","site_admin":false},"repo":{"id":125556119,"name":"notebook","full_name":"arovit/notebook","owner":{"login":"arovit","id":4410397,"avatar_url":"https://avatars1.githubusercontent.com/u/4410397?v=4","gravatar_id":"","url":"https://api.github.com/users/arovit","html_url":"https://github.com/arovit","followers_url":"https://api.github.com/users/arovit/followers","following_url":"https://api.github.com/users/arovit/following{/other_user}","gists_url":"https://api.github.com/users/arovit/gists{/gist_id}","starred_url":"https://api.github.com/users/arovit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arovit/subscriptions","organizations_url":"https://api.github.com/users/arovit/orgs","repos_url":"https://api.github.com/users/arovit/repos","events_url":"https://api.github.com/users/arovit/events{/privacy}","received_events_url":"https://api.github.com/users/arovit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/arovit/notebook","description":"Jupyter Interactive Notebook","fork":true,"url":"https://api.github.com/repos/arovit/notebook","forks_url":"https://api.github.com/repos/arovit/notebook/forks","keys_url":"https://api.github.com/repos/arovit/notebook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/arovit/notebook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/arovit/notebook/teams","hooks_url":"https://api.github.com/repos/arovit/notebook/hooks","issue_events_url":"https://api.github.com/repos/arovit/notebook/issues/events{/number}","events_url":"https://api.github.com/repos/arovit/notebook/events","assignees_url":"https://api.github.com/repos/arovit/notebook/assignees{/user}","branches_url":"https://api.github.com/repos/arovit/notebook/branches{/branch}","tags_url":"https://api.github.com/repos/arovit/notebook/tags","blobs_url":"https://api.github.com/repos/arovit/notebook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/arovit/notebook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/arovit/notebook/git/refs{/sha}","trees_url":"https://api.github.com/repos/arovit/notebook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/arovit/notebook/statuses/{sha}","languages_url":"https://api.github.com/repos/arovit/notebook/languages","stargazers_url":"https://api.github.com/repos/arovit/notebook/stargazers","contributors_url":"https://api.github.com/repos/arovit/notebook/contributors","subscribers_url":"https://api.github.com/repos/arovit/notebook/subscribers","subscription_url":"https://api.github.com/repos/arovit/notebook/subscription","commits_url":"https://api.github.com/repos/arovit/notebook/commits{/sha}","git_commits_url":"https://api.github.com/repos/arovit/notebook/git/commits{/sha}","comments_url":"https://api.github.com/repos/arovit/notebook/comments{/number}","issue_comment_url":"https://api.github.com/repos/arovit/notebook/issues/comments{/number}","contents_url":"https://api.github.com/repos/arovit/notebook/contents/{+path}","compare_url":"https://api.github.com/repos/arovit/notebook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/arovit/notebook/merges","archive_url":"https://api.github.com/repos/arovit/notebook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/arovit/notebook/downloads","issues_url":"https://api.github.com/repos/arovit/notebook/issues{/number}","pulls_url":"https://api.github.com/repos/arovit/notebook/pulls{/number}","milestones_url":"https://api.github.com/repos/arovit/notebook/milestones{/number}","notifications_url":"https://api.github.com/repos/arovit/notebook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/arovit/notebook/labels{/name}","releases_url":"https://api.github.com/repos/arovit/notebook/releases{/id}","deployments_url":"https://api.github.com/repos/arovit/notebook/deployments","created_at":"2018-03-16T18:38:40Z","updated_at":"2018-05-18T23:01:32Z","pushed_at":"2018-05-18T23:01:29Z","git_url":"git://github.com/arovit/notebook.git","ssh_url":"git@github.com:arovit/notebook.git","clone_url":"https://github.com/arovit/notebook.git","svn_url":"https://github.com/arovit/notebook","homepage":"https://jupyter-notebook.readthedocs.io/","size":22614,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jupyter:master","ref":"master","sha":"11743f1865f151fe66d188d7feb51c0560f67f53","user":{"login":"jupyter","id":7388996,"avatar_url":"https://avatars1.githubusercontent.com/u/7388996?v=4","gravatar_id":"","url":"https://api.github.com/users/jupyter","html_url":"https://github.com/jupyter","followers_url":"https://api.github.com/users/jupyter/followers","following_url":"https://api.github.com/users/jupyter/following{/other_user}","gists_url":"https://api.github.com/users/jupyter/gists{/gist_id}","starred_url":"https://api.github.com/users/jupyter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jupyter/subscriptions","organizations_url":"https://api.github.com/users/jupyter/orgs","repos_url":"https://api.github.com/users/jupyter/repos","events_url":"https://api.github.com/users/jupyter/events{/privacy}","received_events_url":"https://api.github.com/users/jupyter/received_events","type":"Organization","site_admin":false},"repo":{"id":33653601,"name":"notebook","full_name":"jupyter/notebook","owner":{"login":"jupyter","id":7388996,"avatar_url":"https://avatars1.githubusercontent.com/u/7388996?v=4","gravatar_id":"","url":"https://api.github.com/users/jupyter","html_url":"https://github.com/jupyter","followers_url":"https://api.github.com/users/jupyter/followers","following_url":"https://api.github.com/users/jupyter/following{/other_user}","gists_url":"https://api.github.com/users/jupyter/gists{/gist_id}","starred_url":"https://api.github.com/users/jupyter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jupyter/subscriptions","organizations_url":"https://api.github.com/users/jupyter/orgs","repos_url":"https://api.github.com/users/jupyter/repos","events_url":"https://api.github.com/users/jupyter/events{/privacy}","received_events_url":"https://api.github.com/users/jupyter/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jupyter/notebook","description":"Jupyter Interactive Notebook","fork":false,"url":"https://api.github.com/repos/jupyter/notebook","forks_url":"https://api.github.com/repos/jupyter/notebook/forks","keys_url":"https://api.github.com/repos/jupyter/notebook/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jupyter/notebook/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jupyter/notebook/teams","hooks_url":"https://api.github.com/repos/jupyter/notebook/hooks","issue_events_url":"https://api.github.com/repos/jupyter/notebook/issues/events{/number}","events_url":"https://api.github.com/repos/jupyter/notebook/events","assignees_url":"https://api.github.com/repos/jupyter/notebook/assignees{/user}","branches_url":"https://api.github.com/repos/jupyter/notebook/branches{/branch}","tags_url":"https://api.github.com/repos/jupyter/notebook/tags","blobs_url":"https://api.github.com/repos/jupyter/notebook/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jupyter/notebook/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jupyter/notebook/git/refs{/sha}","trees_url":"https://api.github.com/repos/jupyter/notebook/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jupyter/notebook/statuses/{sha}","languages_url":"https://api.github.com/repos/jupyter/notebook/languages","stargazers_url":"https://api.github.com/repos/jupyter/notebook/stargazers","contributors_url":"https://api.github.com/repos/jupyter/notebook/contributors","subscribers_url":"https://api.github.com/repos/jupyter/notebook/subscribers","subscription_url":"https://api.github.com/repos/jupyter/notebook/subscription","commits_url":"https://api.github.com/repos/jupyter/notebook/commits{/sha}","git_commits_url":"https://api.github.com/repos/jupyter/notebook/git/commits{/sha}","comments_url":"https://api.github.com/repos/jupyter/notebook/comments{/number}","issue_comment_url":"https://api.github.com/repos/jupyter/notebook/issues/comments{/number}","contents_url":"https://api.github.com/repos/jupyter/notebook/contents/{+path}","compare_url":"https://api.github.com/repos/jupyter/notebook/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jupyter/notebook/merges","archive_url":"https://api.github.com/repos/jupyter/notebook/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jupyter/notebook/downloads","issues_url":"https://api.github.com/repos/jupyter/notebook/issues{/number}","pulls_url":"https://api.github.com/repos/jupyter/notebook/pulls{/number}","milestones_url":"https://api.github.com/repos/jupyter/notebook/milestones{/number}","notifications_url":"https://api.github.com/repos/jupyter/notebook/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jupyter/notebook/labels{/name}","releases_url":"https://api.github.com/repos/jupyter/notebook/releases{/id}","deployments_url":"https://api.github.com/repos/jupyter/notebook/deployments","created_at":"2015-04-09T06:58:03Z","updated_at":"2018-05-21T11:05:18Z","pushed_at":"2018-05-21T17:44:14Z","git_url":"git://github.com/jupyter/notebook.git","ssh_url":"git@github.com:jupyter/notebook.git","clone_url":"https://github.com/jupyter/notebook.git","svn_url":"https://github.com/jupyter/notebook","homepage":"https://jupyter-notebook.readthedocs.io/","size":22605,"stargazers_count":4158,"watchers_count":4158,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1591,"mirror_url":null,"archived":false,"open_issues_count":922,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1591,"open_issues":922,"watchers":4158,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jupyter/notebook/pulls/3601"},"html":{"href":"https://github.com/jupyter/notebook/pull/3601"},"issue":{"href":"https://api.github.com/repos/jupyter/notebook/issues/3601"},"comments":{"href":"https://api.github.com/repos/jupyter/notebook/issues/3601/comments"},"review_comments":{"href":"https://api.github.com/repos/jupyter/notebook/pulls/3601/comments"},"review_comment":{"href":"https://api.github.com/repos/jupyter/notebook/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jupyter/notebook/pulls/3601/commits"},"statuses":{"href":"https://api.github.com/repos/jupyter/notebook/statuses/70ce8fac3320ec14510526ed982cc0ff0a92b9b8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"arovit"}}