{"action":"created","comment":{"url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments/179931596","pull_request_review_id":110270798,"id":179931596,"diff_hunk":"@@ -1265,21 +1265,21 @@ def subplots(self, nrows=1, ncols=1, sharex=False, sharey=False,\n                 - 'col': each subplot column will share an x- or y-axis.\n \n             When subplots have a shared x-axis along a column, only the x tick\n-            labels of the bottom subplot are visible.  Similarly, when\n-            subplots have a shared y-axis along a row, only the y tick labels\n-            of the first column subplot are visible.\n+            labels of the bottom subplot are created. Similarly, when subplots\n+            have a shared y-axis along a row, only the y tick labels of the\n+            first column subplot are created. To later turn other subplots'\n+            ticklabels on, use :meth:`~matplotlib.axis.Axis.set_tick_params`.\n \n-        squeeze : bool, default: True\n-            - If True, extra dimensions are squeezed out from the returned\n-              axis object:\n+        squeeze : bool, optional, default: True\n+            - If True, extra dimensions are squeezed out from the returned Axes\n+              object:","path":"lib/matplotlib/figure.py","position":17,"original_position":17,"commit_id":"72d20b065890911a5de677e4df33dcaa2e465677","original_commit_id":"72d20b065890911a5de677e4df33dcaa2e465677","user":{"login":"efiring","id":85125,"avatar_url":"https://avatars1.githubusercontent.com/u/85125?v=4","gravatar_id":"","url":"https://api.github.com/users/efiring","html_url":"https://github.com/efiring","followers_url":"https://api.github.com/users/efiring/followers","following_url":"https://api.github.com/users/efiring/following{/other_user}","gists_url":"https://api.github.com/users/efiring/gists{/gist_id}","starred_url":"https://api.github.com/users/efiring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/efiring/subscriptions","organizations_url":"https://api.github.com/users/efiring/orgs","repos_url":"https://api.github.com/users/efiring/repos","events_url":"https://api.github.com/users/efiring/events{/privacy}","received_events_url":"https://api.github.com/users/efiring/received_events","type":"User","site_admin":false},"body":"Actually, dimensions are squeezed out of the ndarray of Axes objects, not out of any such object.","created_at":"2018-04-08T00:39:35Z","updated_at":"2018-04-08T00:44:23Z","html_url":"https://github.com/matplotlib/matplotlib/pull/10981#discussion_r179931596","pull_request_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/10981","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments/179931596"},"html":{"href":"https://github.com/matplotlib/matplotlib/pull/10981#discussion_r179931596"},"pull_request":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/10981"}}},"pull_request":{"url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/10981","id":180129391,"html_url":"https://github.com/matplotlib/matplotlib/pull/10981","diff_url":"https://github.com/matplotlib/matplotlib/pull/10981.diff","patch_url":"https://github.com/matplotlib/matplotlib/pull/10981.patch","issue_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/10981","number":10981,"state":"open","locked":false,"title":"Document change of label visibility on shared axes ","user":{"login":"ImportanceOfBeingErnest","id":23121882,"avatar_url":"https://avatars2.githubusercontent.com/u/23121882?v=4","gravatar_id":"","url":"https://api.github.com/users/ImportanceOfBeingErnest","html_url":"https://github.com/ImportanceOfBeingErnest","followers_url":"https://api.github.com/users/ImportanceOfBeingErnest/followers","following_url":"https://api.github.com/users/ImportanceOfBeingErnest/following{/other_user}","gists_url":"https://api.github.com/users/ImportanceOfBeingErnest/gists{/gist_id}","starred_url":"https://api.github.com/users/ImportanceOfBeingErnest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ImportanceOfBeingErnest/subscriptions","organizations_url":"https://api.github.com/users/ImportanceOfBeingErnest/orgs","repos_url":"https://api.github.com/users/ImportanceOfBeingErnest/repos","events_url":"https://api.github.com/users/ImportanceOfBeingErnest/events{/privacy}","received_events_url":"https://api.github.com/users/ImportanceOfBeingErnest/received_events","type":"User","site_admin":false},"body":"## PR Summary\r\n\r\nIn #8678 internal use of `Axis.set_tick_params` has been introduced to some methods previously using the ticklabels properties themselves. This change has led to the labels of shared axes not be turned invisible, but instead not being created at all. Previously working ways to turn the labels visible again are therefore failing, see [Get ticklabels back on shared axis #10911](https://github.com/matplotlib/matplotlib/issues/10911). \r\n\r\nThis PR partially fixes #10911 in the sense of creating a what's new entry for this change and updating the documentation of `sharex`. \r\n\r\nIf possible it should be backported to 2.1.0 where this change was silently introduced.\r\n\r\n\r\nNote that further actions might be required to fully introduce `set_tick_params` as viable alternative to setting individual artist properties. Those go beyond the scope of this PR and should probably be introduced as new features.\r\n\r\n## PR Checklist\r\n\r\n- [x] Code is PEP 8 compliant\r\n- [x] New features are documented, with examples if plot related\r\n- [x] Documentation is sphinx and numpydoc compliant\r\n- [x] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)\r\n- [x] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way\r\n\r\n<!--\r\nThank you so much for your PR!  To help us review your contribution, please\r\nconsider the following points:\r\n\r\n- A development guide is available at https://matplotlib.org/devdocs/devel/index.html.\r\n\r\n- Help with git and github is available at\r\n  https://matplotlib.org/devel/gitwash/development_workflow.html.\r\n\r\n- Do not create the PR out of master, but out of a separate branch.\r\n\r\n- The PR title should summarize the changes, for example \"Raise ValueError on\r\n  non-numeric input to set_xlim\".  Avoid non-descriptive titles such as\r\n  \"Addresses issue #8576\".\r\n\r\n- The summary should provide at least 1-2 sentences describing the pull request\r\n  in detail (Why is this change required?  What problem does it solve?) and\r\n  link to any relevant issues.\r\n\r\n- If you are contributing fixes to docstrings, please pay attention to\r\n  http://matplotlib.org/devel/documenting_mpl.html#formatting.  In particular,\r\n  note the difference between using single backquotes, double backquotes, and\r\n  asterisks in the markup.\r\n\r\nWe understand that PRs can sometimes be overwhelming, especially as the\r\nreviews start coming in.  Please let us know if the reviews are unclear or\r\nthe recommended next step seems overly demanding, if you would like help in\r\naddressing a reviewer's comments, or if you have been waiting too long to hear\r\nback on your PR.\r\n-->\r\n","created_at":"2018-04-07T23:02:57Z","updated_at":"2018-04-08T00:44:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6b38ffd02dc70e357e1b9cff805ee40b26514e92","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":77884,"url":"https://api.github.com/repos/matplotlib/matplotlib/labels/Documentation","name":"Documentation","color":"0015ff","default":false}],"milestone":{"url":"https://api.github.com/repos/matplotlib/matplotlib/milestones/33","html_url":"https://github.com/matplotlib/matplotlib/milestone/33","labels_url":"https://api.github.com/repos/matplotlib/matplotlib/milestones/33/labels","id":3106573,"number":33,"title":"v2.2-doc","description":"Tracker for documentation updates to 2.2 docs.\r\n\r\non-merge: backport to v2.2.2-doc","creator":{"login":"tacaswell","id":199813,"avatar_url":"https://avatars3.githubusercontent.com/u/199813?v=4","gravatar_id":"","url":"https://api.github.com/users/tacaswell","html_url":"https://github.com/tacaswell","followers_url":"https://api.github.com/users/tacaswell/followers","following_url":"https://api.github.com/users/tacaswell/following{/other_user}","gists_url":"https://api.github.com/users/tacaswell/gists{/gist_id}","starred_url":"https://api.github.com/users/tacaswell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tacaswell/subscriptions","organizations_url":"https://api.github.com/users/tacaswell/orgs","repos_url":"https://api.github.com/users/tacaswell/repos","events_url":"https://api.github.com/users/tacaswell/events{/privacy}","received_events_url":"https://api.github.com/users/tacaswell/received_events","type":"User","site_admin":false},"open_issues":14,"closed_issues":32,"state":"open","created_at":"2018-02-12T03:23:06Z","updated_at":"2018-04-08T00:36:29Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/10981/commits","review_comments_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/10981/comments","review_comment_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/10981/comments","statuses_url":"https://api.github.com/repos/matplotlib/matplotlib/statuses/72d20b065890911a5de677e4df33dcaa2e465677","head":{"label":"ImportanceOfBeingErnest:doc-labelvisibility-on-shared-axes","ref":"doc-labelvisibility-on-shared-axes","sha":"72d20b065890911a5de677e4df33dcaa2e465677","user":{"login":"ImportanceOfBeingErnest","id":23121882,"avatar_url":"https://avatars2.githubusercontent.com/u/23121882?v=4","gravatar_id":"","url":"https://api.github.com/users/ImportanceOfBeingErnest","html_url":"https://github.com/ImportanceOfBeingErnest","followers_url":"https://api.github.com/users/ImportanceOfBeingErnest/followers","following_url":"https://api.github.com/users/ImportanceOfBeingErnest/following{/other_user}","gists_url":"https://api.github.com/users/ImportanceOfBeingErnest/gists{/gist_id}","starred_url":"https://api.github.com/users/ImportanceOfBeingErnest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ImportanceOfBeingErnest/subscriptions","organizations_url":"https://api.github.com/users/ImportanceOfBeingErnest/orgs","repos_url":"https://api.github.com/users/ImportanceOfBeingErnest/repos","events_url":"https://api.github.com/users/ImportanceOfBeingErnest/events{/privacy}","received_events_url":"https://api.github.com/users/ImportanceOfBeingErnest/received_events","type":"User","site_admin":false},"repo":{"id":100939689,"name":"matplotlib","full_name":"ImportanceOfBeingErnest/matplotlib","owner":{"login":"ImportanceOfBeingErnest","id":23121882,"avatar_url":"https://avatars2.githubusercontent.com/u/23121882?v=4","gravatar_id":"","url":"https://api.github.com/users/ImportanceOfBeingErnest","html_url":"https://github.com/ImportanceOfBeingErnest","followers_url":"https://api.github.com/users/ImportanceOfBeingErnest/followers","following_url":"https://api.github.com/users/ImportanceOfBeingErnest/following{/other_user}","gists_url":"https://api.github.com/users/ImportanceOfBeingErnest/gists{/gist_id}","starred_url":"https://api.github.com/users/ImportanceOfBeingErnest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ImportanceOfBeingErnest/subscriptions","organizations_url":"https://api.github.com/users/ImportanceOfBeingErnest/orgs","repos_url":"https://api.github.com/users/ImportanceOfBeingErnest/repos","events_url":"https://api.github.com/users/ImportanceOfBeingErnest/events{/privacy}","received_events_url":"https://api.github.com/users/ImportanceOfBeingErnest/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ImportanceOfBeingErnest/matplotlib","description":"matplotlib: plotting with Python","fork":true,"url":"https://api.github.com/repos/ImportanceOfBeingErnest/matplotlib","forks_url":"https://api.github.com/repos/ImportanceOfBeingErnest/matplotlib/forks","keys_url":"https://api.github.com/repos/ImportanceOfBeingErnest/matplotlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ImportanceOfBeingErnest/matplotlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ImportanceOfBeingErnest/matplotlib/teams","hooks_url":"https://api.github.com/repos/ImportanceOfBeingErnest/matplotlib/hooks","issue_events_url":"https://api.github.com/repos/ImportanceOfBeingErnest/matplotlib/issues/events{/number}","events_url":"https://api.github.com/repos/ImportanceOfBeingErnest/matplotlib/events","assignees_url":"https://api.github.com/repos/ImportanceOfBeingErnest/matplotlib/assignees{/user}","branches_url":"https://api.github.com/repos/ImportanceOfBeingErnest/matplotlib/branches{/branch}","tags_url":"https://api.github.com/repos/ImportanceOfBeingErnest/matplotlib/tags","blobs_url":"https://api.github.com/repos/ImportanceOfBeingErnest/matplotlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ImportanceOfBeingErnest/matplotlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ImportanceOfBeingErnest/matplotlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/ImportanceOfBeingErnest/matplotlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ImportanceOfBeingErnest/matplotlib/statuses/{sha}","languages_url":"https://api.github.com/repos/ImportanceOfBeingErnest/matplotlib/languages","stargazers_url":"https://api.github.com/repos/ImportanceOfBeingErnest/matplotlib/stargazers","contributors_url":"https://api.github.com/repos/ImportanceOfBeingErnest/matplotlib/contributors","subscribers_url":"https://api.github.com/repos/ImportanceOfBeingErnest/matplotlib/subscribers","subscription_url":"https://api.github.com/repos/ImportanceOfBeingErnest/matplotlib/subscription","commits_url":"https://api.github.com/repos/ImportanceOfBeingErnest/matplotlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/ImportanceOfBeingErnest/matplotlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/ImportanceOfBeingErnest/matplotlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/ImportanceOfBeingErnest/matplotlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/ImportanceOfBeingErnest/matplotlib/contents/{+path}","compare_url":"https://api.github.com/repos/ImportanceOfBeingErnest/matplotlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ImportanceOfBeingErnest/matplotlib/merges","archive_url":"https://api.github.com/repos/ImportanceOfBeingErnest/matplotlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ImportanceOfBeingErnest/matplotlib/downloads","issues_url":"https://api.github.com/repos/ImportanceOfBeingErnest/matplotlib/issues{/number}","pulls_url":"https://api.github.com/repos/ImportanceOfBeingErnest/matplotlib/pulls{/number}","milestones_url":"https://api.github.com/repos/ImportanceOfBeingErnest/matplotlib/milestones{/number}","notifications_url":"https://api.github.com/repos/ImportanceOfBeingErnest/matplotlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ImportanceOfBeingErnest/matplotlib/labels{/name}","releases_url":"https://api.github.com/repos/ImportanceOfBeingErnest/matplotlib/releases{/id}","deployments_url":"https://api.github.com/repos/ImportanceOfBeingErnest/matplotlib/deployments","created_at":"2017-08-21T10:07:39Z","updated_at":"2017-08-21T10:07:49Z","pushed_at":"2018-04-07T23:32:24Z","git_url":"git://github.com/ImportanceOfBeingErnest/matplotlib.git","ssh_url":"git@github.com:ImportanceOfBeingErnest/matplotlib.git","clone_url":"https://github.com/ImportanceOfBeingErnest/matplotlib.git","svn_url":"https://github.com/ImportanceOfBeingErnest/matplotlib","homepage":"http://matplotlib.org/","size":325845,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"matplotlib:master","ref":"master","sha":"e2a081383786c1072694f63ca14552a34ab79cdc","user":{"login":"matplotlib","id":215947,"avatar_url":"https://avatars0.githubusercontent.com/u/215947?v=4","gravatar_id":"","url":"https://api.github.com/users/matplotlib","html_url":"https://github.com/matplotlib","followers_url":"https://api.github.com/users/matplotlib/followers","following_url":"https://api.github.com/users/matplotlib/following{/other_user}","gists_url":"https://api.github.com/users/matplotlib/gists{/gist_id}","starred_url":"https://api.github.com/users/matplotlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matplotlib/subscriptions","organizations_url":"https://api.github.com/users/matplotlib/orgs","repos_url":"https://api.github.com/users/matplotlib/repos","events_url":"https://api.github.com/users/matplotlib/events{/privacy}","received_events_url":"https://api.github.com/users/matplotlib/received_events","type":"Organization","site_admin":false},"repo":{"id":1385122,"name":"matplotlib","full_name":"matplotlib/matplotlib","owner":{"login":"matplotlib","id":215947,"avatar_url":"https://avatars0.githubusercontent.com/u/215947?v=4","gravatar_id":"","url":"https://api.github.com/users/matplotlib","html_url":"https://github.com/matplotlib","followers_url":"https://api.github.com/users/matplotlib/followers","following_url":"https://api.github.com/users/matplotlib/following{/other_user}","gists_url":"https://api.github.com/users/matplotlib/gists{/gist_id}","starred_url":"https://api.github.com/users/matplotlib/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matplotlib/subscriptions","organizations_url":"https://api.github.com/users/matplotlib/orgs","repos_url":"https://api.github.com/users/matplotlib/repos","events_url":"https://api.github.com/users/matplotlib/events{/privacy}","received_events_url":"https://api.github.com/users/matplotlib/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/matplotlib/matplotlib","description":"matplotlib: plotting with Python","fork":false,"url":"https://api.github.com/repos/matplotlib/matplotlib","forks_url":"https://api.github.com/repos/matplotlib/matplotlib/forks","keys_url":"https://api.github.com/repos/matplotlib/matplotlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matplotlib/matplotlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matplotlib/matplotlib/teams","hooks_url":"https://api.github.com/repos/matplotlib/matplotlib/hooks","issue_events_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/events{/number}","events_url":"https://api.github.com/repos/matplotlib/matplotlib/events","assignees_url":"https://api.github.com/repos/matplotlib/matplotlib/assignees{/user}","branches_url":"https://api.github.com/repos/matplotlib/matplotlib/branches{/branch}","tags_url":"https://api.github.com/repos/matplotlib/matplotlib/tags","blobs_url":"https://api.github.com/repos/matplotlib/matplotlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matplotlib/matplotlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matplotlib/matplotlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/matplotlib/matplotlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matplotlib/matplotlib/statuses/{sha}","languages_url":"https://api.github.com/repos/matplotlib/matplotlib/languages","stargazers_url":"https://api.github.com/repos/matplotlib/matplotlib/stargazers","contributors_url":"https://api.github.com/repos/matplotlib/matplotlib/contributors","subscribers_url":"https://api.github.com/repos/matplotlib/matplotlib/subscribers","subscription_url":"https://api.github.com/repos/matplotlib/matplotlib/subscription","commits_url":"https://api.github.com/repos/matplotlib/matplotlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/matplotlib/matplotlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/matplotlib/matplotlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/matplotlib/matplotlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/matplotlib/matplotlib/contents/{+path}","compare_url":"https://api.github.com/repos/matplotlib/matplotlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matplotlib/matplotlib/merges","archive_url":"https://api.github.com/repos/matplotlib/matplotlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matplotlib/matplotlib/downloads","issues_url":"https://api.github.com/repos/matplotlib/matplotlib/issues{/number}","pulls_url":"https://api.github.com/repos/matplotlib/matplotlib/pulls{/number}","milestones_url":"https://api.github.com/repos/matplotlib/matplotlib/milestones{/number}","notifications_url":"https://api.github.com/repos/matplotlib/matplotlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matplotlib/matplotlib/labels{/name}","releases_url":"https://api.github.com/repos/matplotlib/matplotlib/releases{/id}","deployments_url":"https://api.github.com/repos/matplotlib/matplotlib/deployments","created_at":"2011-02-19T03:17:12Z","updated_at":"2018-04-08T00:22:06Z","pushed_at":"2018-04-08T00:43:05Z","git_url":"git://github.com/matplotlib/matplotlib.git","ssh_url":"git@github.com:matplotlib/matplotlib.git","clone_url":"https://github.com/matplotlib/matplotlib.git","svn_url":"https://github.com/matplotlib/matplotlib","homepage":"http://matplotlib.org/","size":325869,"stargazers_count":7059,"watchers_count":7059,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3317,"mirror_url":null,"archived":false,"open_issues_count":1338,"license":null,"forks":3317,"open_issues":1338,"watchers":7059,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/10981"},"html":{"href":"https://github.com/matplotlib/matplotlib/pull/10981"},"issue":{"href":"https://api.github.com/repos/matplotlib/matplotlib/issues/10981"},"comments":{"href":"https://api.github.com/repos/matplotlib/matplotlib/issues/10981/comments"},"review_comments":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/10981/comments"},"review_comment":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/matplotlib/matplotlib/pulls/10981/commits"},"statuses":{"href":"https://api.github.com/repos/matplotlib/matplotlib/statuses/72d20b065890911a5de677e4df33dcaa2e465677"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"efiring"}}