{"action":"created","comment":{"url":"https://api.github.com/repos/opensim-org/opensim-core/pulls/comments/230223013","pull_request_review_id":170910834,"id":230223013,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDIyMzAxMw==","diff_hunk":"@@ -94,6 +94,22 @@ void updatePre40KinematicsFilesFor40MotionType(const Model& model,\n         const std::vector<std::string>& filePaths,\n         std::string suffix=\"_updated\");\n \n+/** This function attempts to update the connectee path for any Socket anywhere\n+ * in the model whose connectee path does not point to an existing component.\n+ * The paths are updated by searching the model for a component with the\n+ * correct name. For example, a connectee path like\n+ * `../../some/invalid/path/to/foo` will be updated to `/bodyset/foo` if a Body\n+ * named `foo` exists in the Model's BodySet.\n+ *\n+ * This function does not update the connectee paths for Inputs.\n+ *\n+ * This function is mainly for use with models loaded from files with XML","path":"OpenSim/Simulation/SimulationUtilities.h","position":13,"original_position":13,"commit_id":"a89a3eadbd639add551055c53c40f2e28d9a9375","original_commit_id":"a89a3eadbd639add551055c53c40f2e28d9a9375","user":{"login":"tkuchida","id":4203505,"node_id":"MDQ6VXNlcjQyMDM1MDU=","avatar_url":"https://avatars0.githubusercontent.com/u/4203505?v=4","gravatar_id":"","url":"https://api.github.com/users/tkuchida","html_url":"https://github.com/tkuchida","followers_url":"https://api.github.com/users/tkuchida/followers","following_url":"https://api.github.com/users/tkuchida/following{/other_user}","gists_url":"https://api.github.com/users/tkuchida/gists{/gist_id}","starred_url":"https://api.github.com/users/tkuchida/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkuchida/subscriptions","organizations_url":"https://api.github.com/users/tkuchida/orgs","repos_url":"https://api.github.com/users/tkuchida/repos","events_url":"https://api.github.com/users/tkuchida/events{/privacy}","received_events_url":"https://api.github.com/users/tkuchida/received_events","type":"User","site_admin":false},"body":"\"mainly for use with\" doesn't really specify what I can/should do. Perhaps something like \"This method is intended for use with models loaded from version-30516 XML files to bring them up to date with the 4.0 API\". I would prefer to see a report after execution saying either \"No Sockets needed updating; Model was not changed\" or \"x Sockets were updated\".","created_at":"2018-11-01T22:40:47Z","updated_at":"2018-11-01T22:48:20Z","html_url":"https://github.com/opensim-org/opensim-core/pull/2333#discussion_r230223013","pull_request_url":"https://api.github.com/repos/opensim-org/opensim-core/pulls/2333","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/opensim-org/opensim-core/pulls/comments/230223013"},"html":{"href":"https://github.com/opensim-org/opensim-core/pull/2333#discussion_r230223013"},"pull_request":{"href":"https://api.github.com/repos/opensim-org/opensim-core/pulls/2333"}}},"pull_request":{"url":"https://api.github.com/repos/opensim-org/opensim-core/pulls/2333","id":225970222,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1OTcwMjIy","html_url":"https://github.com/opensim-org/opensim-core/pull/2333","diff_url":"https://github.com/opensim-org/opensim-core/pull/2333.diff","patch_url":"https://github.com/opensim-org/opensim-core/pull/2333.patch","issue_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/2333","number":2333,"state":"open","locked":false,"title":"Add OpenSim::updateConnecteesBySearch().","user":{"login":"chrisdembia","id":846001,"node_id":"MDQ6VXNlcjg0NjAwMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/846001?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisdembia","html_url":"https://github.com/chrisdembia","followers_url":"https://api.github.com/users/chrisdembia/followers","following_url":"https://api.github.com/users/chrisdembia/following{/other_user}","gists_url":"https://api.github.com/users/chrisdembia/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisdembia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisdembia/subscriptions","organizations_url":"https://api.github.com/users/chrisdembia/orgs","repos_url":"https://api.github.com/users/chrisdembia/repos","events_url":"https://api.github.com/users/chrisdembia/events{/privacy}","received_events_url":"https://api.github.com/users/chrisdembia/received_events","type":"User","site_admin":false},"body":"Add utility function to fix conectee paths from intermediate model files (e.g., 30516).\r\n\r\nI created this utility to update the jumper model from WCB2018, which was at version 30516, for use in the 4.0 webinar.\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/opensim-org/opensim-core/2333)\r\n<!-- Reviewable:end -->\r\n","created_at":"2018-10-26T04:04:53Z","updated_at":"2018-11-01T22:48:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bd8f6595c42899c4b2baafe5398fcdecf661b76a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/opensim-org/opensim-core/pulls/2333/commits","review_comments_url":"https://api.github.com/repos/opensim-org/opensim-core/pulls/2333/comments","review_comment_url":"https://api.github.com/repos/opensim-org/opensim-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/2333/comments","statuses_url":"https://api.github.com/repos/opensim-org/opensim-core/statuses/a89a3eadbd639add551055c53c40f2e28d9a9375","head":{"label":"opensim-org:updateConnecteesBySearch","ref":"updateConnecteesBySearch","sha":"a89a3eadbd639add551055c53c40f2e28d9a9375","user":{"login":"opensim-org","id":4370782,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNzA3ODI=","avatar_url":"https://avatars0.githubusercontent.com/u/4370782?v=4","gravatar_id":"","url":"https://api.github.com/users/opensim-org","html_url":"https://github.com/opensim-org","followers_url":"https://api.github.com/users/opensim-org/followers","following_url":"https://api.github.com/users/opensim-org/following{/other_user}","gists_url":"https://api.github.com/users/opensim-org/gists{/gist_id}","starred_url":"https://api.github.com/users/opensim-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opensim-org/subscriptions","organizations_url":"https://api.github.com/users/opensim-org/orgs","repos_url":"https://api.github.com/users/opensim-org/repos","events_url":"https://api.github.com/users/opensim-org/events{/privacy}","received_events_url":"https://api.github.com/users/opensim-org/received_events","type":"Organization","site_admin":false},"repo":{"id":20775600,"node_id":"MDEwOlJlcG9zaXRvcnkyMDc3NTYwMA==","name":"opensim-core","full_name":"opensim-org/opensim-core","private":false,"owner":{"login":"opensim-org","id":4370782,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNzA3ODI=","avatar_url":"https://avatars0.githubusercontent.com/u/4370782?v=4","gravatar_id":"","url":"https://api.github.com/users/opensim-org","html_url":"https://github.com/opensim-org","followers_url":"https://api.github.com/users/opensim-org/followers","following_url":"https://api.github.com/users/opensim-org/following{/other_user}","gists_url":"https://api.github.com/users/opensim-org/gists{/gist_id}","starred_url":"https://api.github.com/users/opensim-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opensim-org/subscriptions","organizations_url":"https://api.github.com/users/opensim-org/orgs","repos_url":"https://api.github.com/users/opensim-org/repos","events_url":"https://api.github.com/users/opensim-org/events{/privacy}","received_events_url":"https://api.github.com/users/opensim-org/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/opensim-org/opensim-core","description":"SimTK OpenSim 4.0 C++ libraries and command-line applications, and Java/Python wrapping.","fork":false,"url":"https://api.github.com/repos/opensim-org/opensim-core","forks_url":"https://api.github.com/repos/opensim-org/opensim-core/forks","keys_url":"https://api.github.com/repos/opensim-org/opensim-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opensim-org/opensim-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opensim-org/opensim-core/teams","hooks_url":"https://api.github.com/repos/opensim-org/opensim-core/hooks","issue_events_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/events{/number}","events_url":"https://api.github.com/repos/opensim-org/opensim-core/events","assignees_url":"https://api.github.com/repos/opensim-org/opensim-core/assignees{/user}","branches_url":"https://api.github.com/repos/opensim-org/opensim-core/branches{/branch}","tags_url":"https://api.github.com/repos/opensim-org/opensim-core/tags","blobs_url":"https://api.github.com/repos/opensim-org/opensim-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opensim-org/opensim-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opensim-org/opensim-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/opensim-org/opensim-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opensim-org/opensim-core/statuses/{sha}","languages_url":"https://api.github.com/repos/opensim-org/opensim-core/languages","stargazers_url":"https://api.github.com/repos/opensim-org/opensim-core/stargazers","contributors_url":"https://api.github.com/repos/opensim-org/opensim-core/contributors","subscribers_url":"https://api.github.com/repos/opensim-org/opensim-core/subscribers","subscription_url":"https://api.github.com/repos/opensim-org/opensim-core/subscription","commits_url":"https://api.github.com/repos/opensim-org/opensim-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/opensim-org/opensim-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/opensim-org/opensim-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/opensim-org/opensim-core/contents/{+path}","compare_url":"https://api.github.com/repos/opensim-org/opensim-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opensim-org/opensim-core/merges","archive_url":"https://api.github.com/repos/opensim-org/opensim-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opensim-org/opensim-core/downloads","issues_url":"https://api.github.com/repos/opensim-org/opensim-core/issues{/number}","pulls_url":"https://api.github.com/repos/opensim-org/opensim-core/pulls{/number}","milestones_url":"https://api.github.com/repos/opensim-org/opensim-core/milestones{/number}","notifications_url":"https://api.github.com/repos/opensim-org/opensim-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opensim-org/opensim-core/labels{/name}","releases_url":"https://api.github.com/repos/opensim-org/opensim-core/releases{/id}","deployments_url":"https://api.github.com/repos/opensim-org/opensim-core/deployments","created_at":"2014-06-12T16:57:56Z","updated_at":"2018-11-01T22:14:19Z","pushed_at":"2018-11-01T22:14:15Z","git_url":"git://github.com/opensim-org/opensim-core.git","ssh_url":"git@github.com:opensim-org/opensim-core.git","clone_url":"https://github.com/opensim-org/opensim-core.git","svn_url":"https://github.com/opensim-org/opensim-core","homepage":"https://opensim.stanford.edu","size":147786,"stargazers_count":178,"watchers_count":178,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":113,"mirror_url":null,"archived":false,"open_issues_count":528,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":113,"open_issues":528,"watchers":178,"default_branch":"master"}},"base":{"label":"opensim-org:master","ref":"master","sha":"defd589d5a3824ddf212943c3851d6ea6187b1ba","user":{"login":"opensim-org","id":4370782,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNzA3ODI=","avatar_url":"https://avatars0.githubusercontent.com/u/4370782?v=4","gravatar_id":"","url":"https://api.github.com/users/opensim-org","html_url":"https://github.com/opensim-org","followers_url":"https://api.github.com/users/opensim-org/followers","following_url":"https://api.github.com/users/opensim-org/following{/other_user}","gists_url":"https://api.github.com/users/opensim-org/gists{/gist_id}","starred_url":"https://api.github.com/users/opensim-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opensim-org/subscriptions","organizations_url":"https://api.github.com/users/opensim-org/orgs","repos_url":"https://api.github.com/users/opensim-org/repos","events_url":"https://api.github.com/users/opensim-org/events{/privacy}","received_events_url":"https://api.github.com/users/opensim-org/received_events","type":"Organization","site_admin":false},"repo":{"id":20775600,"node_id":"MDEwOlJlcG9zaXRvcnkyMDc3NTYwMA==","name":"opensim-core","full_name":"opensim-org/opensim-core","private":false,"owner":{"login":"opensim-org","id":4370782,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQzNzA3ODI=","avatar_url":"https://avatars0.githubusercontent.com/u/4370782?v=4","gravatar_id":"","url":"https://api.github.com/users/opensim-org","html_url":"https://github.com/opensim-org","followers_url":"https://api.github.com/users/opensim-org/followers","following_url":"https://api.github.com/users/opensim-org/following{/other_user}","gists_url":"https://api.github.com/users/opensim-org/gists{/gist_id}","starred_url":"https://api.github.com/users/opensim-org/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opensim-org/subscriptions","organizations_url":"https://api.github.com/users/opensim-org/orgs","repos_url":"https://api.github.com/users/opensim-org/repos","events_url":"https://api.github.com/users/opensim-org/events{/privacy}","received_events_url":"https://api.github.com/users/opensim-org/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/opensim-org/opensim-core","description":"SimTK OpenSim 4.0 C++ libraries and command-line applications, and Java/Python wrapping.","fork":false,"url":"https://api.github.com/repos/opensim-org/opensim-core","forks_url":"https://api.github.com/repos/opensim-org/opensim-core/forks","keys_url":"https://api.github.com/repos/opensim-org/opensim-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opensim-org/opensim-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opensim-org/opensim-core/teams","hooks_url":"https://api.github.com/repos/opensim-org/opensim-core/hooks","issue_events_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/events{/number}","events_url":"https://api.github.com/repos/opensim-org/opensim-core/events","assignees_url":"https://api.github.com/repos/opensim-org/opensim-core/assignees{/user}","branches_url":"https://api.github.com/repos/opensim-org/opensim-core/branches{/branch}","tags_url":"https://api.github.com/repos/opensim-org/opensim-core/tags","blobs_url":"https://api.github.com/repos/opensim-org/opensim-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opensim-org/opensim-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opensim-org/opensim-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/opensim-org/opensim-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opensim-org/opensim-core/statuses/{sha}","languages_url":"https://api.github.com/repos/opensim-org/opensim-core/languages","stargazers_url":"https://api.github.com/repos/opensim-org/opensim-core/stargazers","contributors_url":"https://api.github.com/repos/opensim-org/opensim-core/contributors","subscribers_url":"https://api.github.com/repos/opensim-org/opensim-core/subscribers","subscription_url":"https://api.github.com/repos/opensim-org/opensim-core/subscription","commits_url":"https://api.github.com/repos/opensim-org/opensim-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/opensim-org/opensim-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/opensim-org/opensim-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/opensim-org/opensim-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/opensim-org/opensim-core/contents/{+path}","compare_url":"https://api.github.com/repos/opensim-org/opensim-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opensim-org/opensim-core/merges","archive_url":"https://api.github.com/repos/opensim-org/opensim-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opensim-org/opensim-core/downloads","issues_url":"https://api.github.com/repos/opensim-org/opensim-core/issues{/number}","pulls_url":"https://api.github.com/repos/opensim-org/opensim-core/pulls{/number}","milestones_url":"https://api.github.com/repos/opensim-org/opensim-core/milestones{/number}","notifications_url":"https://api.github.com/repos/opensim-org/opensim-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opensim-org/opensim-core/labels{/name}","releases_url":"https://api.github.com/repos/opensim-org/opensim-core/releases{/id}","deployments_url":"https://api.github.com/repos/opensim-org/opensim-core/deployments","created_at":"2014-06-12T16:57:56Z","updated_at":"2018-11-01T22:14:19Z","pushed_at":"2018-11-01T22:14:15Z","git_url":"git://github.com/opensim-org/opensim-core.git","ssh_url":"git@github.com:opensim-org/opensim-core.git","clone_url":"https://github.com/opensim-org/opensim-core.git","svn_url":"https://github.com/opensim-org/opensim-core","homepage":"https://opensim.stanford.edu","size":147786,"stargazers_count":178,"watchers_count":178,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":113,"mirror_url":null,"archived":false,"open_issues_count":528,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":113,"open_issues":528,"watchers":178,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opensim-org/opensim-core/pulls/2333"},"html":{"href":"https://github.com/opensim-org/opensim-core/pull/2333"},"issue":{"href":"https://api.github.com/repos/opensim-org/opensim-core/issues/2333"},"comments":{"href":"https://api.github.com/repos/opensim-org/opensim-core/issues/2333/comments"},"review_comments":{"href":"https://api.github.com/repos/opensim-org/opensim-core/pulls/2333/comments"},"review_comment":{"href":"https://api.github.com/repos/opensim-org/opensim-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opensim-org/opensim-core/pulls/2333/commits"},"statuses":{"href":"https://api.github.com/repos/opensim-org/opensim-core/statuses/a89a3eadbd639add551055c53c40f2e28d9a9375"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"tkuchida"}}