{"action":"created","comment":{"url":"https://api.github.com/repos/LPCIC/coq-elpi/pulls/comments/243169754","pull_request_review_id":186866034,"id":243169754,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzE2OTc1NA==","diff_hunk":"@@ -76,13 +78,15 @@ let univin, isuniv, univout, univ =\n   } in\n   cin, isc, cout, univ\n ;;\n+let sprop  = E.Constants.from_string \"sprop\"","path":"src/coq_elpi_HOAS.ml","position":13,"original_position":13,"commit_id":"72a0d6e115dd624505a4aa40cedb603198c88433","original_commit_id":"72a0d6e115dd624505a4aa40cedb603198c88433","user":{"login":"gares","id":1013846,"node_id":"MDQ6VXNlcjEwMTM4NDY=","avatar_url":"https://avatars2.githubusercontent.com/u/1013846?v=4","gravatar_id":"","url":"https://api.github.com/users/gares","html_url":"https://github.com/gares","followers_url":"https://api.github.com/users/gares/followers","following_url":"https://api.github.com/users/gares/following{/other_user}","gists_url":"https://api.github.com/users/gares/gists{/gist_id}","starred_url":"https://api.github.com/users/gares/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gares/subscriptions","organizations_url":"https://api.github.com/users/gares/orgs","repos_url":"https://api.github.com/users/gares/repos","events_url":"https://api.github.com/users/gares/events{/privacy}","received_events_url":"https://api.github.com/users/gares/received_events","type":"User","site_admin":false},"body":"This change should be also in coq-hoas.elpi","created_at":"2018-12-20T06:48:47Z","updated_at":"2018-12-20T06:51:31Z","html_url":"https://github.com/LPCIC/coq-elpi/pull/45#discussion_r243169754","pull_request_url":"https://api.github.com/repos/LPCIC/coq-elpi/pulls/45","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/LPCIC/coq-elpi/pulls/comments/243169754"},"html":{"href":"https://github.com/LPCIC/coq-elpi/pull/45#discussion_r243169754"},"pull_request":{"href":"https://api.github.com/repos/LPCIC/coq-elpi/pulls/45"}}},"pull_request":{"url":"https://api.github.com/repos/LPCIC/coq-elpi/pulls/45","id":239869591,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5ODY5NTkx","html_url":"https://github.com/LPCIC/coq-elpi/pull/45","diff_url":"https://github.com/LPCIC/coq-elpi/pull/45.diff","patch_url":"https://github.com/LPCIC/coq-elpi/pull/45.patch","issue_url":"https://api.github.com/repos/LPCIC/coq-elpi/issues/45","number":45,"state":"open","locked":false,"title":"Adapt to coq/coq#8817 (SProp)","user":{"login":"SkySkimmer","id":2461932,"node_id":"MDQ6VXNlcjI0NjE5MzI=","avatar_url":"https://avatars1.githubusercontent.com/u/2461932?v=4","gravatar_id":"","url":"https://api.github.com/users/SkySkimmer","html_url":"https://github.com/SkySkimmer","followers_url":"https://api.github.com/users/SkySkimmer/followers","following_url":"https://api.github.com/users/SkySkimmer/following{/other_user}","gists_url":"https://api.github.com/users/SkySkimmer/gists{/gist_id}","starred_url":"https://api.github.com/users/SkySkimmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SkySkimmer/subscriptions","organizations_url":"https://api.github.com/users/SkySkimmer/orgs","repos_url":"https://api.github.com/users/SkySkimmer/repos","events_url":"https://api.github.com/users/SkySkimmer/events{/privacy}","received_events_url":"https://api.github.com/users/SkySkimmer/received_events","type":"User","site_admin":false},"body":"EDIT: after a rebase of sprop now it works (https://gitlab.com/coq/coq/-/jobs/136854724), no clue what changed but OK.\r\n\r\nOUTDATED:\r\nThis doesn't actually work but I can't tell why. In test_API.v \r\n~~~coq\r\n\r\nElpi Query \"\r\n do! [\r\n   coq.env.begin-module-type \"\"TA\"\",\r\n     coq.env.add-const \"\"z\"\" hole {{nat}} _ _,\r\n     coq.env.add-const \"\"i\"\" hole {{Type}} _ _,\r\n   coq.env.end-module-type MP_TA,\r\n   coq.env.begin-module \"\"A\"\" MP_TA,\r\n     coq.env.add-const \"\"x\"\" {{3}} hole _ _,\r\n       coq.env.begin-module \"\"B\"\" _NoGivenModType,\r\n         coq.env.add-const \"\"y\"\" {{3}} hole _ GRy,\r\n       coq.env.end-module _,\r\n     coq.env.add-const \"\"z\"\" GRy hole _ _,\r\n     coq.env.add-indt (inductive \"\"i1\"\" 0 {{Type}} i\\ []) I,\r\n     coq.env.add-const \"\"i\"\" I hole _ _, % silly limitation in Coq\r\n   coq.env.end-module MP,\r\n   coq.env.module MP L\r\n   %coq.env.module-type MP_TA [TAz,TAi] % @name is broken wrt =, don't use it!\r\n ]\r\n\".\r\n(* Error:\r\nSyntax error: \r\nnear: …uctive \"i1\" 0 {{Type}} i\\ []) I,      coq.env.add-const \"i\" I hole _ _, % silly limitation in Coq   ….\r\n*)\r\n~~~\r\nAny ideas?","created_at":"2018-12-19T15:10:22Z","updated_at":"2018-12-20T06:51:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ac941a0b4c3d60fc75ea8d88deb858b28f803ac7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/LPCIC/coq-elpi/pulls/45/commits","review_comments_url":"https://api.github.com/repos/LPCIC/coq-elpi/pulls/45/comments","review_comment_url":"https://api.github.com/repos/LPCIC/coq-elpi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LPCIC/coq-elpi/issues/45/comments","statuses_url":"https://api.github.com/repos/LPCIC/coq-elpi/statuses/72a0d6e115dd624505a4aa40cedb603198c88433","head":{"label":"SkySkimmer:sprop","ref":"sprop","sha":"72a0d6e115dd624505a4aa40cedb603198c88433","user":{"login":"SkySkimmer","id":2461932,"node_id":"MDQ6VXNlcjI0NjE5MzI=","avatar_url":"https://avatars1.githubusercontent.com/u/2461932?v=4","gravatar_id":"","url":"https://api.github.com/users/SkySkimmer","html_url":"https://github.com/SkySkimmer","followers_url":"https://api.github.com/users/SkySkimmer/followers","following_url":"https://api.github.com/users/SkySkimmer/following{/other_user}","gists_url":"https://api.github.com/users/SkySkimmer/gists{/gist_id}","starred_url":"https://api.github.com/users/SkySkimmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SkySkimmer/subscriptions","organizations_url":"https://api.github.com/users/SkySkimmer/orgs","repos_url":"https://api.github.com/users/SkySkimmer/repos","events_url":"https://api.github.com/users/SkySkimmer/events{/privacy}","received_events_url":"https://api.github.com/users/SkySkimmer/received_events","type":"User","site_admin":false},"repo":{"id":124543368,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQ1NDMzNjg=","name":"coq-elpi","full_name":"SkySkimmer/coq-elpi","private":false,"owner":{"login":"SkySkimmer","id":2461932,"node_id":"MDQ6VXNlcjI0NjE5MzI=","avatar_url":"https://avatars1.githubusercontent.com/u/2461932?v=4","gravatar_id":"","url":"https://api.github.com/users/SkySkimmer","html_url":"https://github.com/SkySkimmer","followers_url":"https://api.github.com/users/SkySkimmer/followers","following_url":"https://api.github.com/users/SkySkimmer/following{/other_user}","gists_url":"https://api.github.com/users/SkySkimmer/gists{/gist_id}","starred_url":"https://api.github.com/users/SkySkimmer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SkySkimmer/subscriptions","organizations_url":"https://api.github.com/users/SkySkimmer/orgs","repos_url":"https://api.github.com/users/SkySkimmer/repos","events_url":"https://api.github.com/users/SkySkimmer/events{/privacy}","received_events_url":"https://api.github.com/users/SkySkimmer/received_events","type":"User","site_admin":false},"html_url":"https://github.com/SkySkimmer/coq-elpi","description":"Coq plugin embedding elpi","fork":true,"url":"https://api.github.com/repos/SkySkimmer/coq-elpi","forks_url":"https://api.github.com/repos/SkySkimmer/coq-elpi/forks","keys_url":"https://api.github.com/repos/SkySkimmer/coq-elpi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SkySkimmer/coq-elpi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SkySkimmer/coq-elpi/teams","hooks_url":"https://api.github.com/repos/SkySkimmer/coq-elpi/hooks","issue_events_url":"https://api.github.com/repos/SkySkimmer/coq-elpi/issues/events{/number}","events_url":"https://api.github.com/repos/SkySkimmer/coq-elpi/events","assignees_url":"https://api.github.com/repos/SkySkimmer/coq-elpi/assignees{/user}","branches_url":"https://api.github.com/repos/SkySkimmer/coq-elpi/branches{/branch}","tags_url":"https://api.github.com/repos/SkySkimmer/coq-elpi/tags","blobs_url":"https://api.github.com/repos/SkySkimmer/coq-elpi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SkySkimmer/coq-elpi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SkySkimmer/coq-elpi/git/refs{/sha}","trees_url":"https://api.github.com/repos/SkySkimmer/coq-elpi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SkySkimmer/coq-elpi/statuses/{sha}","languages_url":"https://api.github.com/repos/SkySkimmer/coq-elpi/languages","stargazers_url":"https://api.github.com/repos/SkySkimmer/coq-elpi/stargazers","contributors_url":"https://api.github.com/repos/SkySkimmer/coq-elpi/contributors","subscribers_url":"https://api.github.com/repos/SkySkimmer/coq-elpi/subscribers","subscription_url":"https://api.github.com/repos/SkySkimmer/coq-elpi/subscription","commits_url":"https://api.github.com/repos/SkySkimmer/coq-elpi/commits{/sha}","git_commits_url":"https://api.github.com/repos/SkySkimmer/coq-elpi/git/commits{/sha}","comments_url":"https://api.github.com/repos/SkySkimmer/coq-elpi/comments{/number}","issue_comment_url":"https://api.github.com/repos/SkySkimmer/coq-elpi/issues/comments{/number}","contents_url":"https://api.github.com/repos/SkySkimmer/coq-elpi/contents/{+path}","compare_url":"https://api.github.com/repos/SkySkimmer/coq-elpi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SkySkimmer/coq-elpi/merges","archive_url":"https://api.github.com/repos/SkySkimmer/coq-elpi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SkySkimmer/coq-elpi/downloads","issues_url":"https://api.github.com/repos/SkySkimmer/coq-elpi/issues{/number}","pulls_url":"https://api.github.com/repos/SkySkimmer/coq-elpi/pulls{/number}","milestones_url":"https://api.github.com/repos/SkySkimmer/coq-elpi/milestones{/number}","notifications_url":"https://api.github.com/repos/SkySkimmer/coq-elpi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SkySkimmer/coq-elpi/labels{/name}","releases_url":"https://api.github.com/repos/SkySkimmer/coq-elpi/releases{/id}","deployments_url":"https://api.github.com/repos/SkySkimmer/coq-elpi/deployments","created_at":"2018-03-09T13:21:30Z","updated_at":"2018-06-25T11:25:51Z","pushed_at":"2018-12-19T15:09:36Z","git_url":"git://github.com/SkySkimmer/coq-elpi.git","ssh_url":"git@github.com:SkySkimmer/coq-elpi.git","clone_url":"https://github.com/SkySkimmer/coq-elpi.git","svn_url":"https://github.com/SkySkimmer/coq-elpi","homepage":null,"size":1058,"stargazers_count":0,"watchers_count":0,"language":"Prolog","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"LPCIC:coq-master","ref":"coq-master","sha":"04ba774071a271665fc14e9e3456345fc4b5e5d9","user":{"login":"LPCIC","id":26541233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2NTQxMjMz","avatar_url":"https://avatars1.githubusercontent.com/u/26541233?v=4","gravatar_id":"","url":"https://api.github.com/users/LPCIC","html_url":"https://github.com/LPCIC","followers_url":"https://api.github.com/users/LPCIC/followers","following_url":"https://api.github.com/users/LPCIC/following{/other_user}","gists_url":"https://api.github.com/users/LPCIC/gists{/gist_id}","starred_url":"https://api.github.com/users/LPCIC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LPCIC/subscriptions","organizations_url":"https://api.github.com/users/LPCIC/orgs","repos_url":"https://api.github.com/users/LPCIC/repos","events_url":"https://api.github.com/users/LPCIC/events{/privacy}","received_events_url":"https://api.github.com/users/LPCIC/received_events","type":"Organization","site_admin":false},"repo":{"id":85685354,"node_id":"MDEwOlJlcG9zaXRvcnk4NTY4NTM1NA==","name":"coq-elpi","full_name":"LPCIC/coq-elpi","private":false,"owner":{"login":"LPCIC","id":26541233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2NTQxMjMz","avatar_url":"https://avatars1.githubusercontent.com/u/26541233?v=4","gravatar_id":"","url":"https://api.github.com/users/LPCIC","html_url":"https://github.com/LPCIC","followers_url":"https://api.github.com/users/LPCIC/followers","following_url":"https://api.github.com/users/LPCIC/following{/other_user}","gists_url":"https://api.github.com/users/LPCIC/gists{/gist_id}","starred_url":"https://api.github.com/users/LPCIC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LPCIC/subscriptions","organizations_url":"https://api.github.com/users/LPCIC/orgs","repos_url":"https://api.github.com/users/LPCIC/repos","events_url":"https://api.github.com/users/LPCIC/events{/privacy}","received_events_url":"https://api.github.com/users/LPCIC/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/LPCIC/coq-elpi","description":"Coq plugin embedding elpi","fork":false,"url":"https://api.github.com/repos/LPCIC/coq-elpi","forks_url":"https://api.github.com/repos/LPCIC/coq-elpi/forks","keys_url":"https://api.github.com/repos/LPCIC/coq-elpi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LPCIC/coq-elpi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LPCIC/coq-elpi/teams","hooks_url":"https://api.github.com/repos/LPCIC/coq-elpi/hooks","issue_events_url":"https://api.github.com/repos/LPCIC/coq-elpi/issues/events{/number}","events_url":"https://api.github.com/repos/LPCIC/coq-elpi/events","assignees_url":"https://api.github.com/repos/LPCIC/coq-elpi/assignees{/user}","branches_url":"https://api.github.com/repos/LPCIC/coq-elpi/branches{/branch}","tags_url":"https://api.github.com/repos/LPCIC/coq-elpi/tags","blobs_url":"https://api.github.com/repos/LPCIC/coq-elpi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LPCIC/coq-elpi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LPCIC/coq-elpi/git/refs{/sha}","trees_url":"https://api.github.com/repos/LPCIC/coq-elpi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LPCIC/coq-elpi/statuses/{sha}","languages_url":"https://api.github.com/repos/LPCIC/coq-elpi/languages","stargazers_url":"https://api.github.com/repos/LPCIC/coq-elpi/stargazers","contributors_url":"https://api.github.com/repos/LPCIC/coq-elpi/contributors","subscribers_url":"https://api.github.com/repos/LPCIC/coq-elpi/subscribers","subscription_url":"https://api.github.com/repos/LPCIC/coq-elpi/subscription","commits_url":"https://api.github.com/repos/LPCIC/coq-elpi/commits{/sha}","git_commits_url":"https://api.github.com/repos/LPCIC/coq-elpi/git/commits{/sha}","comments_url":"https://api.github.com/repos/LPCIC/coq-elpi/comments{/number}","issue_comment_url":"https://api.github.com/repos/LPCIC/coq-elpi/issues/comments{/number}","contents_url":"https://api.github.com/repos/LPCIC/coq-elpi/contents/{+path}","compare_url":"https://api.github.com/repos/LPCIC/coq-elpi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LPCIC/coq-elpi/merges","archive_url":"https://api.github.com/repos/LPCIC/coq-elpi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LPCIC/coq-elpi/downloads","issues_url":"https://api.github.com/repos/LPCIC/coq-elpi/issues{/number}","pulls_url":"https://api.github.com/repos/LPCIC/coq-elpi/pulls{/number}","milestones_url":"https://api.github.com/repos/LPCIC/coq-elpi/milestones{/number}","notifications_url":"https://api.github.com/repos/LPCIC/coq-elpi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LPCIC/coq-elpi/labels{/name}","releases_url":"https://api.github.com/repos/LPCIC/coq-elpi/releases{/id}","deployments_url":"https://api.github.com/repos/LPCIC/coq-elpi/deployments","created_at":"2017-03-21T09:53:39Z","updated_at":"2018-11-28T01:08:55Z","pushed_at":"2018-12-19T15:10:23Z","git_url":"git://github.com/LPCIC/coq-elpi.git","ssh_url":"git@github.com:LPCIC/coq-elpi.git","clone_url":"https://github.com/LPCIC/coq-elpi.git","svn_url":"https://github.com/LPCIC/coq-elpi","homepage":null,"size":1064,"stargazers_count":13,"watchers_count":13,"language":"Prolog","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":8,"open_issues":9,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LPCIC/coq-elpi/pulls/45"},"html":{"href":"https://github.com/LPCIC/coq-elpi/pull/45"},"issue":{"href":"https://api.github.com/repos/LPCIC/coq-elpi/issues/45"},"comments":{"href":"https://api.github.com/repos/LPCIC/coq-elpi/issues/45/comments"},"review_comments":{"href":"https://api.github.com/repos/LPCIC/coq-elpi/pulls/45/comments"},"review_comment":{"href":"https://api.github.com/repos/LPCIC/coq-elpi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LPCIC/coq-elpi/pulls/45/commits"},"statuses":{"href":"https://api.github.com/repos/LPCIC/coq-elpi/statuses/72a0d6e115dd624505a4aa40cedb603198c88433"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"gares"}}