{"action":"created","comment":{"url":"https://api.github.com/repos/material-components/material-components-ios/pulls/comments/218898166","pull_request_review_id":156940214,"id":218898166,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODg5ODE2Ng==","diff_hunk":"@@ -204,4 +218,142 @@ - (void)testSetNilTitleAndMessageColor {\n                         [UIColor.blackColor colorWithAlphaComponent:0.6f]);\n }\n \n+#pragma mark - Opening height\n+\n+- (void)addActions:(NSUInteger)actions {\n+  for (NSUInteger i = 0; i < actions; ++i) {","path":"components/ActionSheet/tests/unit/MDCActionSheetTest.m","position":46,"original_position":46,"commit_id":"e46b0d354ef3a898893c374bfc4b148e4602536e","original_commit_id":"e46b0d354ef3a898893c374bfc4b148e4602536e","user":{"login":"codeman7","id":7131294,"node_id":"MDQ6VXNlcjcxMzEyOTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/7131294?v=4","gravatar_id":"","url":"https://api.github.com/users/codeman7","html_url":"https://github.com/codeman7","followers_url":"https://api.github.com/users/codeman7/followers","following_url":"https://api.github.com/users/codeman7/following{/other_user}","gists_url":"https://api.github.com/users/codeman7/gists{/gist_id}","starred_url":"https://api.github.com/users/codeman7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codeman7/subscriptions","organizations_url":"https://api.github.com/users/codeman7/orgs","repos_url":"https://api.github.com/users/codeman7/repos","events_url":"https://api.github.com/users/codeman7/events{/privacy}","received_events_url":"https://api.github.com/users/codeman7/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2018-09-19T17:40:09Z","updated_at":"2018-09-19T17:40:09Z","html_url":"https://github.com/material-components/material-components-ios/pull/5175#discussion_r218898166","pull_request_url":"https://api.github.com/repos/material-components/material-components-ios/pulls/5175","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/comments/218898166"},"html":{"href":"https://github.com/material-components/material-components-ios/pull/5175#discussion_r218898166"},"pull_request":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/5175"}},"in_reply_to_id":218883165},"pull_request":{"url":"https://api.github.com/repos/material-components/material-components-ios/pulls/5175","id":216700291,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2NzAwMjkx","html_url":"https://github.com/material-components/material-components-ios/pull/5175","diff_url":"https://github.com/material-components/material-components-ios/pull/5175.diff","patch_url":"https://github.com/material-components/material-components-ios/pull/5175.patch","issue_url":"https://api.github.com/repos/material-components/material-components-ios/issues/5175","number":5175,"state":"open","locked":false,"title":"[ActionSheet] Open to the correct height","user":{"login":"codeman7","id":7131294,"node_id":"MDQ6VXNlcjcxMzEyOTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/7131294?v=4","gravatar_id":"","url":"https://api.github.com/users/codeman7","html_url":"https://github.com/codeman7","followers_url":"https://api.github.com/users/codeman7/followers","following_url":"https://api.github.com/users/codeman7/following{/other_user}","gists_url":"https://api.github.com/users/codeman7/gists{/gist_id}","starred_url":"https://api.github.com/users/codeman7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codeman7/subscriptions","organizations_url":"https://api.github.com/users/codeman7/orgs","repos_url":"https://api.github.com/users/codeman7/repos","events_url":"https://api.github.com/users/codeman7/events{/privacy}","received_events_url":"https://api.github.com/users/codeman7/received_events","type":"User","site_admin":false},"body":"This will for bleeding if there are too many options to show on screen at once.\r\n\r\n_Bleeding_\r\nMy understanding after speaking to design is, list with scrollable content within a bottom sheet should open up to half of the screen height minus half of a list item or to the list height. The initial height should be the smaller of those two values. Half of the height of the view is correct. But, if there are more options that will fit on half of the height (of the view) and the list height is a factor of the super view's height then a user may not be aware it is scrollable content. This new behavior is correct and makes for a better user experience in my opinion. The term bleeding was told to be by design, my understanding is the list item bleeds onto the view.\r\n\r\nPrevious discussions at #5024 \r\nCloses #4945 & #5038 \r\n\r\n\r\n| Before | After |\r\n| ------- | ------- |\r\n|![simulator screen shot - iphone 8 - 2018-09-05 at 15 30 55](https://user-images.githubusercontent.com/7131294/45116429-b21b3f00-b120-11e8-960e-d8e46111e3d0.png)|![simulator screen shot - iphone 8 - 2018-09-05 at 15 28 49](https://user-images.githubusercontent.com/7131294/45116395-8c8e3580-b120-11e8-9d12-2c46d9086294.png)|","created_at":"2018-09-19T16:23:38Z","updated_at":"2018-09-19T17:40:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb204414072f68ba5765faf5fc2f3b4650f8f542","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1004918311,"node_id":"MDU6TGFiZWwxMDA0OTE4MzEx","url":"https://api.github.com/repos/material-components/material-components-ios/labels/[ActionSheet]","name":"[ActionSheet]","color":"eeeeee","default":false},{"id":273191333,"node_id":"MDU6TGFiZWwyNzMxOTEzMzM=","url":"https://api.github.com/repos/material-components/material-components-ios/labels/cla:%20yes","name":"cla: yes","color":"c2e0c6","default":false},{"id":385370633,"node_id":"MDU6TGFiZWwzODUzNzA2MzM=","url":"https://api.github.com/repos/material-components/material-components-ios/labels/type:Test","name":"type:Test","color":"c5def5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/material-components/material-components-ios/pulls/5175/commits","review_comments_url":"https://api.github.com/repos/material-components/material-components-ios/pulls/5175/comments","review_comment_url":"https://api.github.com/repos/material-components/material-components-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/material-components/material-components-ios/issues/5175/comments","statuses_url":"https://api.github.com/repos/material-components/material-components-ios/statuses/e46b0d354ef3a898893c374bfc4b148e4602536e","head":{"label":"codeman7:action-open-x-height-x","ref":"action-open-x-height-x","sha":"e46b0d354ef3a898893c374bfc4b148e4602536e","user":{"login":"codeman7","id":7131294,"node_id":"MDQ6VXNlcjcxMzEyOTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/7131294?v=4","gravatar_id":"","url":"https://api.github.com/users/codeman7","html_url":"https://github.com/codeman7","followers_url":"https://api.github.com/users/codeman7/followers","following_url":"https://api.github.com/users/codeman7/following{/other_user}","gists_url":"https://api.github.com/users/codeman7/gists{/gist_id}","starred_url":"https://api.github.com/users/codeman7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codeman7/subscriptions","organizations_url":"https://api.github.com/users/codeman7/orgs","repos_url":"https://api.github.com/users/codeman7/repos","events_url":"https://api.github.com/users/codeman7/events{/privacy}","received_events_url":"https://api.github.com/users/codeman7/received_events","type":"User","site_admin":false},"repo":{"id":137519177,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc1MTkxNzc=","name":"material-components-ios","full_name":"codeman7/material-components-ios","private":false,"owner":{"login":"codeman7","id":7131294,"node_id":"MDQ6VXNlcjcxMzEyOTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/7131294?v=4","gravatar_id":"","url":"https://api.github.com/users/codeman7","html_url":"https://github.com/codeman7","followers_url":"https://api.github.com/users/codeman7/followers","following_url":"https://api.github.com/users/codeman7/following{/other_user}","gists_url":"https://api.github.com/users/codeman7/gists{/gist_id}","starred_url":"https://api.github.com/users/codeman7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codeman7/subscriptions","organizations_url":"https://api.github.com/users/codeman7/orgs","repos_url":"https://api.github.com/users/codeman7/repos","events_url":"https://api.github.com/users/codeman7/events{/privacy}","received_events_url":"https://api.github.com/users/codeman7/received_events","type":"User","site_admin":false},"html_url":"https://github.com/codeman7/material-components-ios","description":"Modular and customizable Material Design UI components for iOS","fork":true,"url":"https://api.github.com/repos/codeman7/material-components-ios","forks_url":"https://api.github.com/repos/codeman7/material-components-ios/forks","keys_url":"https://api.github.com/repos/codeman7/material-components-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codeman7/material-components-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codeman7/material-components-ios/teams","hooks_url":"https://api.github.com/repos/codeman7/material-components-ios/hooks","issue_events_url":"https://api.github.com/repos/codeman7/material-components-ios/issues/events{/number}","events_url":"https://api.github.com/repos/codeman7/material-components-ios/events","assignees_url":"https://api.github.com/repos/codeman7/material-components-ios/assignees{/user}","branches_url":"https://api.github.com/repos/codeman7/material-components-ios/branches{/branch}","tags_url":"https://api.github.com/repos/codeman7/material-components-ios/tags","blobs_url":"https://api.github.com/repos/codeman7/material-components-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codeman7/material-components-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codeman7/material-components-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/codeman7/material-components-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codeman7/material-components-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/codeman7/material-components-ios/languages","stargazers_url":"https://api.github.com/repos/codeman7/material-components-ios/stargazers","contributors_url":"https://api.github.com/repos/codeman7/material-components-ios/contributors","subscribers_url":"https://api.github.com/repos/codeman7/material-components-ios/subscribers","subscription_url":"https://api.github.com/repos/codeman7/material-components-ios/subscription","commits_url":"https://api.github.com/repos/codeman7/material-components-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/codeman7/material-components-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/codeman7/material-components-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/codeman7/material-components-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/codeman7/material-components-ios/contents/{+path}","compare_url":"https://api.github.com/repos/codeman7/material-components-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codeman7/material-components-ios/merges","archive_url":"https://api.github.com/repos/codeman7/material-components-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codeman7/material-components-ios/downloads","issues_url":"https://api.github.com/repos/codeman7/material-components-ios/issues{/number}","pulls_url":"https://api.github.com/repos/codeman7/material-components-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/codeman7/material-components-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/codeman7/material-components-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codeman7/material-components-ios/labels{/name}","releases_url":"https://api.github.com/repos/codeman7/material-components-ios/releases{/id}","deployments_url":"https://api.github.com/repos/codeman7/material-components-ios/deployments","created_at":"2018-06-15T18:16:12Z","updated_at":"2018-09-14T11:34:44Z","pushed_at":"2018-09-19T16:41:53Z","git_url":"git://github.com/codeman7/material-components-ios.git","ssh_url":"git@github.com:codeman7/material-components-ios.git","clone_url":"https://github.com/codeman7/material-components-ios.git","svn_url":"https://github.com/codeman7/material-components-ios","homepage":"","size":123070,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"material-components:develop","ref":"develop","sha":"3ea86babf14323eef6e886252eb4e2ce51314635","user":{"login":"material-components","id":19478152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc4MTUy","avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"repo":{"id":43820219,"node_id":"MDEwOlJlcG9zaXRvcnk0MzgyMDIxOQ==","name":"material-components-ios","full_name":"material-components/material-components-ios","private":false,"owner":{"login":"material-components","id":19478152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5NDc4MTUy","avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/material-components/material-components-ios","description":"Modular and customizable Material Design UI components for iOS","fork":false,"url":"https://api.github.com/repos/material-components/material-components-ios","forks_url":"https://api.github.com/repos/material-components/material-components-ios/forks","keys_url":"https://api.github.com/repos/material-components/material-components-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/material-components/material-components-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/material-components/material-components-ios/teams","hooks_url":"https://api.github.com/repos/material-components/material-components-ios/hooks","issue_events_url":"https://api.github.com/repos/material-components/material-components-ios/issues/events{/number}","events_url":"https://api.github.com/repos/material-components/material-components-ios/events","assignees_url":"https://api.github.com/repos/material-components/material-components-ios/assignees{/user}","branches_url":"https://api.github.com/repos/material-components/material-components-ios/branches{/branch}","tags_url":"https://api.github.com/repos/material-components/material-components-ios/tags","blobs_url":"https://api.github.com/repos/material-components/material-components-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/material-components/material-components-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/material-components/material-components-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/material-components/material-components-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/material-components/material-components-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/material-components/material-components-ios/languages","stargazers_url":"https://api.github.com/repos/material-components/material-components-ios/stargazers","contributors_url":"https://api.github.com/repos/material-components/material-components-ios/contributors","subscribers_url":"https://api.github.com/repos/material-components/material-components-ios/subscribers","subscription_url":"https://api.github.com/repos/material-components/material-components-ios/subscription","commits_url":"https://api.github.com/repos/material-components/material-components-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/material-components/material-components-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/material-components/material-components-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/material-components/material-components-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/material-components/material-components-ios/contents/{+path}","compare_url":"https://api.github.com/repos/material-components/material-components-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/material-components/material-components-ios/merges","archive_url":"https://api.github.com/repos/material-components/material-components-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/material-components/material-components-ios/downloads","issues_url":"https://api.github.com/repos/material-components/material-components-ios/issues{/number}","pulls_url":"https://api.github.com/repos/material-components/material-components-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/material-components/material-components-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/material-components/material-components-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/material-components/material-components-ios/labels{/name}","releases_url":"https://api.github.com/repos/material-components/material-components-ios/releases{/id}","deployments_url":"https://api.github.com/repos/material-components/material-components-ios/deployments","created_at":"2015-10-07T14:12:39Z","updated_at":"2018-09-19T17:22:05Z","pushed_at":"2018-09-19T17:22:01Z","git_url":"git://github.com/material-components/material-components-ios.git","ssh_url":"git@github.com:material-components/material-components-ios.git","clone_url":"https://github.com/material-components/material-components-ios.git","svn_url":"https://github.com/material-components/material-components-ios","homepage":"","size":121120,"stargazers_count":2772,"watchers_count":2772,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":414,"mirror_url":null,"archived":false,"open_issues_count":732,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":414,"open_issues":732,"watchers":2772,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/5175"},"html":{"href":"https://github.com/material-components/material-components-ios/pull/5175"},"issue":{"href":"https://api.github.com/repos/material-components/material-components-ios/issues/5175"},"comments":{"href":"https://api.github.com/repos/material-components/material-components-ios/issues/5175/comments"},"review_comments":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/5175/comments"},"review_comment":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/5175/commits"},"statuses":{"href":"https://api.github.com/repos/material-components/material-components-ios/statuses/e46b0d354ef3a898893c374bfc4b148e4602536e"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"codeman7"}}