{"action":"created","issue":{"url":"https://api.github.com/repos/qtile/qtile/issues/1241","repository_url":"https://api.github.com/repos/qtile/qtile","labels_url":"https://api.github.com/repos/qtile/qtile/issues/1241/labels{/name}","comments_url":"https://api.github.com/repos/qtile/qtile/issues/1241/comments","events_url":"https://api.github.com/repos/qtile/qtile/issues/1241/events","html_url":"https://github.com/qtile/qtile/pull/1241","id":386587334,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1Mjc2OTA1","number":1241,"title":"Initialise fake_screens and add documentation","user":{"login":"Melkor333","id":6412377,"node_id":"MDQ6VXNlcjY0MTIzNzc=","avatar_url":"https://avatars1.githubusercontent.com/u/6412377?v=4","gravatar_id":"","url":"https://api.github.com/users/Melkor333","html_url":"https://github.com/Melkor333","followers_url":"https://api.github.com/users/Melkor333/followers","following_url":"https://api.github.com/users/Melkor333/following{/other_user}","gists_url":"https://api.github.com/users/Melkor333/gists{/gist_id}","starred_url":"https://api.github.com/users/Melkor333/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Melkor333/subscriptions","organizations_url":"https://api.github.com/users/Melkor333/orgs","repos_url":"https://api.github.com/users/Melkor333/repos","events_url":"https://api.github.com/users/Melkor333/events{/privacy}","received_events_url":"https://api.github.com/users/Melkor333/received_events","type":"User","site_admin":false},"labels":[{"id":8857172,"node_id":"MDU6TGFiZWw4ODU3MTcy","url":"https://api.github.com/repos/qtile/qtile/labels/bug","name":"bug","color":"e10c02","default":true},{"id":8857186,"node_id":"MDU6TGFiZWw4ODU3MTg2","url":"https://api.github.com/repos/qtile/qtile/labels/docs","name":"docs","color":"bfd4f2","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-12-02T18:48:31Z","updated_at":"2018-12-21T02:00:54Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/qtile/qtile/pulls/1241","html_url":"https://github.com/qtile/qtile/pull/1241","diff_url":"https://github.com/qtile/qtile/pull/1241.diff","patch_url":"https://github.com/qtile/qtile/pull/1241.patch"},"body":"closes #1238  and as a replacement of #1192:\r\n\r\nInitialize fake_screens if they exist plus some documentation.\r\n\r\n\r\nI literally just copied the documentation from the file [test/test_fakescreen.py](https://github.com/qtile/qtile/blob/develop/test/test_fakescreen.py) and trimmed it a bit. I also added a short oneline explanation. I hope this is enough :)"},"comment":{"url":"https://api.github.com/repos/qtile/qtile/issues/comments/449214052","html_url":"https://github.com/qtile/qtile/pull/1241#issuecomment-449214052","issue_url":"https://api.github.com/repos/qtile/qtile/issues/1241","id":449214052,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0OTIxNDA1Mg==","user":{"login":"flacjacket","id":681093,"node_id":"MDQ6VXNlcjY4MTA5Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/681093?v=4","gravatar_id":"","url":"https://api.github.com/users/flacjacket","html_url":"https://github.com/flacjacket","followers_url":"https://api.github.com/users/flacjacket/followers","following_url":"https://api.github.com/users/flacjacket/following{/other_user}","gists_url":"https://api.github.com/users/flacjacket/gists{/gist_id}","starred_url":"https://api.github.com/users/flacjacket/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flacjacket/subscriptions","organizations_url":"https://api.github.com/users/flacjacket/orgs","repos_url":"https://api.github.com/users/flacjacket/repos","events_url":"https://api.github.com/users/flacjacket/events{/privacy}","received_events_url":"https://api.github.com/users/flacjacket/received_events","type":"User","site_admin":false},"created_at":"2018-12-21T02:00:54Z","updated_at":"2018-12-21T02:00:54Z","author_association":"MEMBER","body":"So you need to add `fake_screens` to the default config. I also noticed that I can't launch qtile with an empty fake_screens, as it triggers the fake_screens portion of the manager, even just to have it set. I tried this:\r\n```\r\ndiff --git a/libqtile/manager.py b/libqtile/manager.py\r\nindex 6ad3a3e6..cd4f4bf2 100644\r\n--- a/libqtile/manager.py\r\n+++ b/libqtile/manager.py\r\n@@ -369,7 +369,7 @@ class Qtile(command.CommandObject):\r\n             self.screens.append(s)\r\n\r\n     def _process_screens(self):\r\n-        if hasattr(self.config, 'fake_screens'):\r\n+        if self.config.fake_screens is not None:\r\n             self._process_fake_screens()\r\n             return\r\n\r\ndiff --git a/libqtile/resources/default_config.py b/libqtile/resources/default_config.py\r\nindex 4f694cf9..b80bc0a3 100644\r\n--- a/libqtile/resources/default_config.py\r\n+++ b/libqtile/resources/default_config.py\r\n@@ -104,6 +104,7 @@ screens = [\r\n         ),\r\n     ),\r\n ]\r\n+fake_screens = None\r\n\r\n # Drag floating layouts.\r\n mouse = [\r\n```\r\nwhich gets qtile working for me locally, but it causes all of the tests to timeout. If you can fix that, I'd say we can merge this."}}
{"actor":{"display_login":"flacjacket"}}