{"action":"closed","number":618,"pull_request":{"url":"https://api.github.com/repos/freebsd/poudriere/pulls/618","id":195351040,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MzUxMDQw","html_url":"https://github.com/freebsd/poudriere/pull/618","diff_url":"https://github.com/freebsd/poudriere/pull/618.diff","patch_url":"https://github.com/freebsd/poudriere/pull/618.patch","issue_url":"https://api.github.com/repos/freebsd/poudriere/issues/618","number":618,"state":"closed","locked":false,"title":"Add option to allow ZFS dataset access and extra parameters for builder jails","user":{"login":"AndiDog","id":1376043,"node_id":"MDQ6VXNlcjEzNzYwNDM=","avatar_url":"https://avatars0.githubusercontent.com/u/1376043?v=4","gravatar_id":"","url":"https://api.github.com/users/AndiDog","html_url":"https://github.com/AndiDog","followers_url":"https://api.github.com/users/AndiDog/followers","following_url":"https://api.github.com/users/AndiDog/following{/other_user}","gists_url":"https://api.github.com/users/AndiDog/gists{/gist_id}","starred_url":"https://api.github.com/users/AndiDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndiDog/subscriptions","organizations_url":"https://api.github.com/users/AndiDog/orgs","repos_url":"https://api.github.com/users/AndiDog/repos","events_url":"https://api.github.com/users/AndiDog/events{/privacy}","received_events_url":"https://api.github.com/users/AndiDog/received_events","type":"User","site_admin":false},"body":"This is the preparation for a use case I'm developing with @grembo and @xgarcias at our company PPRO. Namely, we want to package whole application jails (FreeBSD base + package dependencies + application) into a package for use in a new deployment mechanism. The presentation is proposed as talk \"Joker: safe and automated deployments using FreeBSD jails\" for EuroBSDcon 2018, and we would like to get the necessary patch ready so people could try the solution right after the talk instead of having to wait for a poudriere release. *I believe this patch is generally useful*, but also we are very sure to use this feature for our purposes (not a hobby project).\r\n\r\nI can provide a sample port Makefile showing how it's used, but the basic idea is simple: instead of building a *software* port, we package a filesystem snapshot: `zfs create parentdataset/myappjail`, install FreeBSD release and packages in it, then ~ `zfs snapshot parentdataset/myappjail@export && zfs send parentdataset/myappjail@export | xz -c >zfs-image.txz`. We end up with a package containing that compressed ZFS dataset image which we can use in the port's post-install script to extract and make the jail ready once the package gets installed. The deployment mechanism then leverages safe switching between old and new jail whenever an application deployment needs to happen. If you want more info on this use case, let me know.\r\n\r\nOr in summary: allow port builds to fiddle with a restricted list of ZFS datasets\r\n\r\n-----------\r\n\r\nTested with 3.2.6, and then applied the patch cleanly to master branch.","created_at":"2018-06-16T22:05:57Z","updated_at":"2018-06-19T07:47:30Z","closed_at":"2018-06-19T07:47:29Z","merged_at":null,"merge_commit_sha":"0f297caef52477d3b8c268c9de35ff379939ba31","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/freebsd/poudriere/pulls/618/commits","review_comments_url":"https://api.github.com/repos/freebsd/poudriere/pulls/618/comments","review_comment_url":"https://api.github.com/repos/freebsd/poudriere/pulls/comments{/number}","comments_url":"https://api.github.com/repos/freebsd/poudriere/issues/618/comments","statuses_url":"https://api.github.com/repos/freebsd/poudriere/statuses/76661b1f2ff346ea5e7012f63c01c8c502799617","head":{"label":"AndiDog:feature/zfs-dataset-access","ref":"feature/zfs-dataset-access","sha":"76661b1f2ff346ea5e7012f63c01c8c502799617","user":{"login":"AndiDog","id":1376043,"node_id":"MDQ6VXNlcjEzNzYwNDM=","avatar_url":"https://avatars0.githubusercontent.com/u/1376043?v=4","gravatar_id":"","url":"https://api.github.com/users/AndiDog","html_url":"https://github.com/AndiDog","followers_url":"https://api.github.com/users/AndiDog/followers","following_url":"https://api.github.com/users/AndiDog/following{/other_user}","gists_url":"https://api.github.com/users/AndiDog/gists{/gist_id}","starred_url":"https://api.github.com/users/AndiDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndiDog/subscriptions","organizations_url":"https://api.github.com/users/AndiDog/orgs","repos_url":"https://api.github.com/users/AndiDog/repos","events_url":"https://api.github.com/users/AndiDog/events{/privacy}","received_events_url":"https://api.github.com/users/AndiDog/received_events","type":"User","site_admin":false},"repo":{"id":137612603,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc2MTI2MDM=","name":"poudriere","full_name":"AndiDog/poudriere","owner":{"login":"AndiDog","id":1376043,"node_id":"MDQ6VXNlcjEzNzYwNDM=","avatar_url":"https://avatars0.githubusercontent.com/u/1376043?v=4","gravatar_id":"","url":"https://api.github.com/users/AndiDog","html_url":"https://github.com/AndiDog","followers_url":"https://api.github.com/users/AndiDog/followers","following_url":"https://api.github.com/users/AndiDog/following{/other_user}","gists_url":"https://api.github.com/users/AndiDog/gists{/gist_id}","starred_url":"https://api.github.com/users/AndiDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndiDog/subscriptions","organizations_url":"https://api.github.com/users/AndiDog/orgs","repos_url":"https://api.github.com/users/AndiDog/repos","events_url":"https://api.github.com/users/AndiDog/events{/privacy}","received_events_url":"https://api.github.com/users/AndiDog/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AndiDog/poudriere","description":"Port/Package build and test system","fork":true,"url":"https://api.github.com/repos/AndiDog/poudriere","forks_url":"https://api.github.com/repos/AndiDog/poudriere/forks","keys_url":"https://api.github.com/repos/AndiDog/poudriere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AndiDog/poudriere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AndiDog/poudriere/teams","hooks_url":"https://api.github.com/repos/AndiDog/poudriere/hooks","issue_events_url":"https://api.github.com/repos/AndiDog/poudriere/issues/events{/number}","events_url":"https://api.github.com/repos/AndiDog/poudriere/events","assignees_url":"https://api.github.com/repos/AndiDog/poudriere/assignees{/user}","branches_url":"https://api.github.com/repos/AndiDog/poudriere/branches{/branch}","tags_url":"https://api.github.com/repos/AndiDog/poudriere/tags","blobs_url":"https://api.github.com/repos/AndiDog/poudriere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AndiDog/poudriere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AndiDog/poudriere/git/refs{/sha}","trees_url":"https://api.github.com/repos/AndiDog/poudriere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AndiDog/poudriere/statuses/{sha}","languages_url":"https://api.github.com/repos/AndiDog/poudriere/languages","stargazers_url":"https://api.github.com/repos/AndiDog/poudriere/stargazers","contributors_url":"https://api.github.com/repos/AndiDog/poudriere/contributors","subscribers_url":"https://api.github.com/repos/AndiDog/poudriere/subscribers","subscription_url":"https://api.github.com/repos/AndiDog/poudriere/subscription","commits_url":"https://api.github.com/repos/AndiDog/poudriere/commits{/sha}","git_commits_url":"https://api.github.com/repos/AndiDog/poudriere/git/commits{/sha}","comments_url":"https://api.github.com/repos/AndiDog/poudriere/comments{/number}","issue_comment_url":"https://api.github.com/repos/AndiDog/poudriere/issues/comments{/number}","contents_url":"https://api.github.com/repos/AndiDog/poudriere/contents/{+path}","compare_url":"https://api.github.com/repos/AndiDog/poudriere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AndiDog/poudriere/merges","archive_url":"https://api.github.com/repos/AndiDog/poudriere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AndiDog/poudriere/downloads","issues_url":"https://api.github.com/repos/AndiDog/poudriere/issues{/number}","pulls_url":"https://api.github.com/repos/AndiDog/poudriere/pulls{/number}","milestones_url":"https://api.github.com/repos/AndiDog/poudriere/milestones{/number}","notifications_url":"https://api.github.com/repos/AndiDog/poudriere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AndiDog/poudriere/labels{/name}","releases_url":"https://api.github.com/repos/AndiDog/poudriere/releases{/id}","deployments_url":"https://api.github.com/repos/AndiDog/poudriere/deployments","created_at":"2018-06-16T21:52:16Z","updated_at":"2018-06-16T21:52:20Z","pushed_at":"2018-06-16T21:53:49Z","git_url":"git://github.com/AndiDog/poudriere.git","ssh_url":"git@github.com:AndiDog/poudriere.git","clone_url":"https://github.com/AndiDog/poudriere.git","svn_url":"https://github.com/AndiDog/poudriere","homepage":"https://github.com/freebsd/poudriere/wiki","size":13310,"stargazers_count":0,"watchers_count":0,"language":"Makefile","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"freebsd:master","ref":"master","sha":"a79ff60104401c5732e15005822942efb8df9065","user":{"login":"freebsd","id":811839,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgxMTgzOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/811839?v=4","gravatar_id":"","url":"https://api.github.com/users/freebsd","html_url":"https://github.com/freebsd","followers_url":"https://api.github.com/users/freebsd/followers","following_url":"https://api.github.com/users/freebsd/following{/other_user}","gists_url":"https://api.github.com/users/freebsd/gists{/gist_id}","starred_url":"https://api.github.com/users/freebsd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freebsd/subscriptions","organizations_url":"https://api.github.com/users/freebsd/orgs","repos_url":"https://api.github.com/users/freebsd/repos","events_url":"https://api.github.com/users/freebsd/events{/privacy}","received_events_url":"https://api.github.com/users/freebsd/received_events","type":"Organization","site_admin":false},"repo":{"id":24193962,"node_id":"MDEwOlJlcG9zaXRvcnkyNDE5Mzk2Mg==","name":"poudriere","full_name":"freebsd/poudriere","owner":{"login":"freebsd","id":811839,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgxMTgzOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/811839?v=4","gravatar_id":"","url":"https://api.github.com/users/freebsd","html_url":"https://github.com/freebsd","followers_url":"https://api.github.com/users/freebsd/followers","following_url":"https://api.github.com/users/freebsd/following{/other_user}","gists_url":"https://api.github.com/users/freebsd/gists{/gist_id}","starred_url":"https://api.github.com/users/freebsd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freebsd/subscriptions","organizations_url":"https://api.github.com/users/freebsd/orgs","repos_url":"https://api.github.com/users/freebsd/repos","events_url":"https://api.github.com/users/freebsd/events{/privacy}","received_events_url":"https://api.github.com/users/freebsd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/freebsd/poudriere","description":"Port/Package build and test system","fork":false,"url":"https://api.github.com/repos/freebsd/poudriere","forks_url":"https://api.github.com/repos/freebsd/poudriere/forks","keys_url":"https://api.github.com/repos/freebsd/poudriere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/freebsd/poudriere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/freebsd/poudriere/teams","hooks_url":"https://api.github.com/repos/freebsd/poudriere/hooks","issue_events_url":"https://api.github.com/repos/freebsd/poudriere/issues/events{/number}","events_url":"https://api.github.com/repos/freebsd/poudriere/events","assignees_url":"https://api.github.com/repos/freebsd/poudriere/assignees{/user}","branches_url":"https://api.github.com/repos/freebsd/poudriere/branches{/branch}","tags_url":"https://api.github.com/repos/freebsd/poudriere/tags","blobs_url":"https://api.github.com/repos/freebsd/poudriere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/freebsd/poudriere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/freebsd/poudriere/git/refs{/sha}","trees_url":"https://api.github.com/repos/freebsd/poudriere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/freebsd/poudriere/statuses/{sha}","languages_url":"https://api.github.com/repos/freebsd/poudriere/languages","stargazers_url":"https://api.github.com/repos/freebsd/poudriere/stargazers","contributors_url":"https://api.github.com/repos/freebsd/poudriere/contributors","subscribers_url":"https://api.github.com/repos/freebsd/poudriere/subscribers","subscription_url":"https://api.github.com/repos/freebsd/poudriere/subscription","commits_url":"https://api.github.com/repos/freebsd/poudriere/commits{/sha}","git_commits_url":"https://api.github.com/repos/freebsd/poudriere/git/commits{/sha}","comments_url":"https://api.github.com/repos/freebsd/poudriere/comments{/number}","issue_comment_url":"https://api.github.com/repos/freebsd/poudriere/issues/comments{/number}","contents_url":"https://api.github.com/repos/freebsd/poudriere/contents/{+path}","compare_url":"https://api.github.com/repos/freebsd/poudriere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/freebsd/poudriere/merges","archive_url":"https://api.github.com/repos/freebsd/poudriere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/freebsd/poudriere/downloads","issues_url":"https://api.github.com/repos/freebsd/poudriere/issues{/number}","pulls_url":"https://api.github.com/repos/freebsd/poudriere/pulls{/number}","milestones_url":"https://api.github.com/repos/freebsd/poudriere/milestones{/number}","notifications_url":"https://api.github.com/repos/freebsd/poudriere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/freebsd/poudriere/labels{/name}","releases_url":"https://api.github.com/repos/freebsd/poudriere/releases{/id}","deployments_url":"https://api.github.com/repos/freebsd/poudriere/deployments","created_at":"2014-09-18T15:36:37Z","updated_at":"2018-06-07T14:57:08Z","pushed_at":"2018-06-19T00:38:11Z","git_url":"git://github.com/freebsd/poudriere.git","ssh_url":"git@github.com:freebsd/poudriere.git","clone_url":"https://github.com/freebsd/poudriere.git","svn_url":"https://github.com/freebsd/poudriere","homepage":"https://github.com/freebsd/poudriere/wiki","size":13309,"stargazers_count":174,"watchers_count":174,"language":"Makefile","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":77,"mirror_url":null,"archived":false,"open_issues_count":146,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":77,"open_issues":146,"watchers":174,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/freebsd/poudriere/pulls/618"},"html":{"href":"https://github.com/freebsd/poudriere/pull/618"},"issue":{"href":"https://api.github.com/repos/freebsd/poudriere/issues/618"},"comments":{"href":"https://api.github.com/repos/freebsd/poudriere/issues/618/comments"},"review_comments":{"href":"https://api.github.com/repos/freebsd/poudriere/pulls/618/comments"},"review_comment":{"href":"https://api.github.com/repos/freebsd/poudriere/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/freebsd/poudriere/pulls/618/commits"},"statuses":{"href":"https://api.github.com/repos/freebsd/poudriere/statuses/76661b1f2ff346ea5e7012f63c01c8c502799617"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":39,"deletions":6,"changed_files":2}}
{"actor":{"display_login":"AndiDog"}}