{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/210650734","pull_request_review_id":146911269,"id":210650734,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDY1MDczNA==","diff_hunk":"@@ -0,0 +1,20 @@\n+﻿<?xml version=\"1.0\" encoding=\"utf-8\"?>\n+<!-- Copyright (c)  Microsoft.  All Rights Reserved.  Licensed under the Apache License, Version 2.0.  See License.txt in the project root for license information. -->\n+<Project Sdk=\"Microsoft.NET.Sdk\">\n+\n+  <PropertyGroup>\n+    <OutputType>Exe</OutputType>\n+    <TargetFramework>netcoreapp2.0</TargetFramework>\n+    <RuntimeIdentifiers>$(RoslynPortableRuntimeIdentifiers)</RuntimeIdentifiers>\n+    <IsShipping>false</IsShipping>\n+  </PropertyGroup>\n+\n+  <ItemGroup>\n+    <ProjectReference Include=\"..\\..\\Compilers\\CSharp\\Test\\Emit\\Microsoft.CodeAnalysis.CSharp.Emit.UnitTests.csproj\" />","path":"src/Tools/CompilerBenchmarks/CompilerBenchmarks.csproj","position":13,"original_position":13,"commit_id":"48159af60a32be564c44187f9416200f3d8af7f1","original_commit_id":"48159af60a32be564c44187f9416200f3d8af7f1","user":{"login":"jaredpar","id":146967,"node_id":"MDQ6VXNlcjE0Njk2Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/146967?v=4","gravatar_id":"","url":"https://api.github.com/users/jaredpar","html_url":"https://github.com/jaredpar","followers_url":"https://api.github.com/users/jaredpar/followers","following_url":"https://api.github.com/users/jaredpar/following{/other_user}","gists_url":"https://api.github.com/users/jaredpar/gists{/gist_id}","starred_url":"https://api.github.com/users/jaredpar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaredpar/subscriptions","organizations_url":"https://api.github.com/users/jaredpar/orgs","repos_url":"https://api.github.com/users/jaredpar/repos","events_url":"https://api.github.com/users/jaredpar/events{/privacy}","received_events_url":"https://api.github.com/users/jaredpar/received_events","type":"User","site_admin":false},"body":"Imagine that we hadn't artificially divided our unit test assemblies and there was just a single assembly for C# and VB respectively. How would you want to define benchmarks in that world? I'm a bit curious why we'd want to merge them with our normal tests given they take two different harnesses to run. \r\n\r\n---\r\nIn reply to: [210435918](https://github.com/dotnet/roslyn/pull/29323#discussion_r210435918) [](ancestors = 210435918)","created_at":"2018-08-16T15:55:22Z","updated_at":"2018-08-16T15:55:22Z","html_url":"https://github.com/dotnet/roslyn/pull/29323#discussion_r210650734","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/29323","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/210650734"},"html":{"href":"https://github.com/dotnet/roslyn/pull/29323#discussion_r210650734"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/29323"}},"in_reply_to_id":210433758},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/29323","id":208678010,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4Njc4MDEw","html_url":"https://github.com/dotnet/roslyn/pull/29323","diff_url":"https://github.com/dotnet/roslyn/pull/29323.diff","patch_url":"https://github.com/dotnet/roslyn/pull/29323.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/29323","number":29323,"state":"open","locked":false,"title":"Add a perf benchmark for the compiler Emit phase","user":{"login":"agocke","id":515774,"node_id":"MDQ6VXNlcjUxNTc3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/515774?v=4","gravatar_id":"","url":"https://api.github.com/users/agocke","html_url":"https://github.com/agocke","followers_url":"https://api.github.com/users/agocke/followers","following_url":"https://api.github.com/users/agocke/following{/other_user}","gists_url":"https://api.github.com/users/agocke/gists{/gist_id}","starred_url":"https://api.github.com/users/agocke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agocke/subscriptions","organizations_url":"https://api.github.com/users/agocke/orgs","repos_url":"https://api.github.com/users/agocke/repos","events_url":"https://api.github.com/users/agocke/events{/privacy}","received_events_url":"https://api.github.com/users/agocke/received_events","type":"User","site_admin":false},"body":"There's also a simple run-perf.ps1 script to run the benchmark.","created_at":"2018-08-15T20:51:54Z","updated_at":"2018-08-16T15:55:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"43cd9887b0531e5007958ffaf094a78e5d95194f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[{"name":"roslyn-infrastructure","id":1823403,"node_id":"MDQ6VGVhbTE4MjM0MDM=","slug":"roslyn-infrastructure","description":"Permanent and temporary Roslyn infrastructure swat team members","privacy":"closed","url":"https://api.github.com/teams/1823403","members_url":"https://api.github.com/teams/1823403/members{/member}","repositories_url":"https://api.github.com/teams/1823403/repos","permission":"pull"}],"labels":[{"id":166673288,"node_id":"MDU6TGFiZWwxNjY2NzMyODg=","url":"https://api.github.com/repos/dotnet/roslyn/labels/Area-Compilers","name":"Area-Compilers","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/29323/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/29323/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/29323/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/48159af60a32be564c44187f9416200f3d8af7f1","head":{"label":"agocke:compiler-micro-bench","ref":"compiler-micro-bench","sha":"48159af60a32be564c44187f9416200f3d8af7f1","user":{"login":"agocke","id":515774,"node_id":"MDQ6VXNlcjUxNTc3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/515774?v=4","gravatar_id":"","url":"https://api.github.com/users/agocke","html_url":"https://github.com/agocke","followers_url":"https://api.github.com/users/agocke/followers","following_url":"https://api.github.com/users/agocke/following{/other_user}","gists_url":"https://api.github.com/users/agocke/gists{/gist_id}","starred_url":"https://api.github.com/users/agocke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agocke/subscriptions","organizations_url":"https://api.github.com/users/agocke/orgs","repos_url":"https://api.github.com/users/agocke/repos","events_url":"https://api.github.com/users/agocke/events{/privacy}","received_events_url":"https://api.github.com/users/agocke/received_events","type":"User","site_admin":false},"repo":{"id":30560754,"node_id":"MDEwOlJlcG9zaXRvcnkzMDU2MDc1NA==","name":"roslyn","full_name":"agocke/roslyn","owner":{"login":"agocke","id":515774,"node_id":"MDQ6VXNlcjUxNTc3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/515774?v=4","gravatar_id":"","url":"https://api.github.com/users/agocke","html_url":"https://github.com/agocke","followers_url":"https://api.github.com/users/agocke/followers","following_url":"https://api.github.com/users/agocke/following{/other_user}","gists_url":"https://api.github.com/users/agocke/gists{/gist_id}","starred_url":"https://api.github.com/users/agocke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agocke/subscriptions","organizations_url":"https://api.github.com/users/agocke/orgs","repos_url":"https://api.github.com/users/agocke/repos","events_url":"https://api.github.com/users/agocke/events{/privacy}","received_events_url":"https://api.github.com/users/agocke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/agocke/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/agocke/roslyn","forks_url":"https://api.github.com/repos/agocke/roslyn/forks","keys_url":"https://api.github.com/repos/agocke/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/agocke/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/agocke/roslyn/teams","hooks_url":"https://api.github.com/repos/agocke/roslyn/hooks","issue_events_url":"https://api.github.com/repos/agocke/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/agocke/roslyn/events","assignees_url":"https://api.github.com/repos/agocke/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/agocke/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/agocke/roslyn/tags","blobs_url":"https://api.github.com/repos/agocke/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/agocke/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/agocke/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/agocke/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/agocke/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/agocke/roslyn/languages","stargazers_url":"https://api.github.com/repos/agocke/roslyn/stargazers","contributors_url":"https://api.github.com/repos/agocke/roslyn/contributors","subscribers_url":"https://api.github.com/repos/agocke/roslyn/subscribers","subscription_url":"https://api.github.com/repos/agocke/roslyn/subscription","commits_url":"https://api.github.com/repos/agocke/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/agocke/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/agocke/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/agocke/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/agocke/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/agocke/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/agocke/roslyn/merges","archive_url":"https://api.github.com/repos/agocke/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/agocke/roslyn/downloads","issues_url":"https://api.github.com/repos/agocke/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/agocke/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/agocke/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/agocke/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/agocke/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/agocke/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/agocke/roslyn/deployments","created_at":"2015-02-09T21:57:03Z","updated_at":"2018-08-10T01:25:32Z","pushed_at":"2018-08-15T22:19:07Z","git_url":"git://github.com/agocke/roslyn.git","ssh_url":"git@github.com:agocke/roslyn.git","clone_url":"https://github.com/agocke/roslyn.git","svn_url":"https://github.com/agocke/roslyn","homepage":"","size":353597,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"88ae26e2bf619c54d6fbcda035b5fa7e537c4322","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"node_id":"MDEwOlJlcG9zaXRvcnkyOTA3ODk5Nw==","name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/roslyn/deployments","created_at":"2015-01-11T02:39:03Z","updated_at":"2018-08-16T15:16:50Z","pushed_at":"2018-08-16T13:30:17Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":434547,"stargazers_count":9709,"watchers_count":9709,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2310,"mirror_url":null,"archived":false,"open_issues_count":5053,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2310,"open_issues":5053,"watchers":9709,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/29323"},"html":{"href":"https://github.com/dotnet/roslyn/pull/29323"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/29323"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/29323/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/29323/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/29323/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/48159af60a32be564c44187f9416200f3d8af7f1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jaredpar"}}