{"action":"created","comment":{"url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/pulls/comments/192376244","pull_request_review_id":125142812,"id":192376244,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjM3NjI0NA==","diff_hunk":"@@ -0,0 +1,22 @@\n+provider \"aws\" {\n+  region = \"eu-west-1\"\n+}\n+\n+module \"example_team_s3\" {\n+  source = \"../\"","path":"example/main.tf","position":6,"original_position":6,"commit_id":"2dde83f5faac2e34cdeddb2b8da88e640a107b4c","original_commit_id":"2dde83f5faac2e34cdeddb2b8da88e640a107b4c","user":{"login":"jojuolape","id":29627552,"node_id":"MDQ6VXNlcjI5NjI3NTUy","avatar_url":"https://avatars2.githubusercontent.com/u/29627552?v=4","gravatar_id":"","url":"https://api.github.com/users/jojuolape","html_url":"https://github.com/jojuolape","followers_url":"https://api.github.com/users/jojuolape/followers","following_url":"https://api.github.com/users/jojuolape/following{/other_user}","gists_url":"https://api.github.com/users/jojuolape/gists{/gist_id}","starred_url":"https://api.github.com/users/jojuolape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jojuolape/subscriptions","organizations_url":"https://api.github.com/users/jojuolape/orgs","repos_url":"https://api.github.com/users/jojuolape/repos","events_url":"https://api.github.com/users/jojuolape/events{/privacy}","received_events_url":"https://api.github.com/users/jojuolape/received_events","type":"User","site_admin":false},"body":"done","created_at":"2018-06-01T12:10:36Z","updated_at":"2018-06-01T12:10:36Z","html_url":"https://github.com/ministryofjustice/cloud-platform-terraform-s3-bucket/pull/2#discussion_r192376244","pull_request_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/pulls/2","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/pulls/comments/192376244"},"html":{"href":"https://github.com/ministryofjustice/cloud-platform-terraform-s3-bucket/pull/2#discussion_r192376244"},"pull_request":{"href":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/pulls/2"}},"in_reply_to_id":192165174},"pull_request":{"url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/pulls/2","id":191759915,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNzU5OTE1","html_url":"https://github.com/ministryofjustice/cloud-platform-terraform-s3-bucket/pull/2","diff_url":"https://github.com/ministryofjustice/cloud-platform-terraform-s3-bucket/pull/2.diff","patch_url":"https://github.com/ministryofjustice/cloud-platform-terraform-s3-bucket/pull/2.patch","issue_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/issues/2","number":2,"state":"open","locked":false,"title":"added readme/ added example module.","user":{"login":"jojuolape","id":29627552,"node_id":"MDQ6VXNlcjI5NjI3NTUy","avatar_url":"https://avatars2.githubusercontent.com/u/29627552?v=4","gravatar_id":"","url":"https://api.github.com/users/jojuolape","html_url":"https://github.com/jojuolape","followers_url":"https://api.github.com/users/jojuolape/followers","following_url":"https://api.github.com/users/jojuolape/following{/other_user}","gists_url":"https://api.github.com/users/jojuolape/gists{/gist_id}","starred_url":"https://api.github.com/users/jojuolape/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jojuolape/subscriptions","organizations_url":"https://api.github.com/users/jojuolape/orgs","repos_url":"https://api.github.com/users/jojuolape/repos","events_url":"https://api.github.com/users/jojuolape/events{/privacy}","received_events_url":"https://api.github.com/users/jojuolape/received_events","type":"User","site_admin":false},"body":"I have added an example module as a reference to any end users who may use this module.\r\nThe module creates a example s3 bucket, which has public-read access and versioning.\r\n\r\nAdded outputs for this example module.\r\n\r\nAdded Readme with description of terraform repo with instructions on how to apply the module. Descriptions of the inputs user needs to use and outputs they will get once they have applied the module.\r\n\r\nVariable tf - changed variable from bucket_name to bucket_identifier to stop any confusion as the bucket name will be $team_name-$bucket_identifier, do not want to confuse end users thinking that the bucket name will just be the input.","created_at":"2018-05-31T13:49:07Z","updated_at":"2018-06-01T12:10:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"54be60211d78c6e1d29ce2df663155fad1d5a61b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kalbir","id":3952074,"node_id":"MDQ6VXNlcjM5NTIwNzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/3952074?v=4","gravatar_id":"","url":"https://api.github.com/users/kalbir","html_url":"https://github.com/kalbir","followers_url":"https://api.github.com/users/kalbir/followers","following_url":"https://api.github.com/users/kalbir/following{/other_user}","gists_url":"https://api.github.com/users/kalbir/gists{/gist_id}","starred_url":"https://api.github.com/users/kalbir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalbir/subscriptions","organizations_url":"https://api.github.com/users/kalbir/orgs","repos_url":"https://api.github.com/users/kalbir/repos","events_url":"https://api.github.com/users/kalbir/events{/privacy}","received_events_url":"https://api.github.com/users/kalbir/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/pulls/2/commits","review_comments_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/pulls/2/comments","review_comment_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/issues/2/comments","statuses_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/statuses/2dde83f5faac2e34cdeddb2b8da88e640a107b4c","head":{"label":"ministryofjustice:add/terraform","ref":"add/terraform","sha":"2dde83f5faac2e34cdeddb2b8da88e640a107b4c","user":{"login":"ministryofjustice","id":2203574,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDM1NzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2203574?v=4","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"repo":{"id":135275826,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUyNzU4MjY=","name":"cloud-platform-terraform-s3-bucket","full_name":"ministryofjustice/cloud-platform-terraform-s3-bucket","owner":{"login":"ministryofjustice","id":2203574,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDM1NzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2203574?v=4","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ministryofjustice/cloud-platform-terraform-s3-bucket","description":null,"fork":false,"url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket","forks_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/forks","keys_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/teams","hooks_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/hooks","issue_events_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/issues/events{/number}","events_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/events","assignees_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/assignees{/user}","branches_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/branches{/branch}","tags_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/tags","blobs_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/git/refs{/sha}","trees_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/statuses/{sha}","languages_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/languages","stargazers_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/stargazers","contributors_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/contributors","subscribers_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/subscribers","subscription_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/subscription","commits_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/commits{/sha}","git_commits_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/git/commits{/sha}","comments_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/comments{/number}","issue_comment_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/issues/comments{/number}","contents_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/contents/{+path}","compare_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/merges","archive_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/downloads","issues_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/issues{/number}","pulls_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/pulls{/number}","milestones_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/milestones{/number}","notifications_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/labels{/name}","releases_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/releases{/id}","deployments_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/deployments","created_at":"2018-05-29T09:51:31Z","updated_at":"2018-05-31T12:07:52Z","pushed_at":"2018-05-31T15:49:27Z","git_url":"git://github.com/ministryofjustice/cloud-platform-terraform-s3-bucket.git","ssh_url":"git@github.com:ministryofjustice/cloud-platform-terraform-s3-bucket.git","clone_url":"https://github.com/ministryofjustice/cloud-platform-terraform-s3-bucket.git","svn_url":"https://github.com/ministryofjustice/cloud-platform-terraform-s3-bucket","homepage":null,"size":11,"stargazers_count":0,"watchers_count":0,"language":"HCL","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"ministryofjustice:master","ref":"master","sha":"f9a233286967300ae776f78201ca574142306daf","user":{"login":"ministryofjustice","id":2203574,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDM1NzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2203574?v=4","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"repo":{"id":135275826,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUyNzU4MjY=","name":"cloud-platform-terraform-s3-bucket","full_name":"ministryofjustice/cloud-platform-terraform-s3-bucket","owner":{"login":"ministryofjustice","id":2203574,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDM1NzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2203574?v=4","gravatar_id":"","url":"https://api.github.com/users/ministryofjustice","html_url":"https://github.com/ministryofjustice","followers_url":"https://api.github.com/users/ministryofjustice/followers","following_url":"https://api.github.com/users/ministryofjustice/following{/other_user}","gists_url":"https://api.github.com/users/ministryofjustice/gists{/gist_id}","starred_url":"https://api.github.com/users/ministryofjustice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ministryofjustice/subscriptions","organizations_url":"https://api.github.com/users/ministryofjustice/orgs","repos_url":"https://api.github.com/users/ministryofjustice/repos","events_url":"https://api.github.com/users/ministryofjustice/events{/privacy}","received_events_url":"https://api.github.com/users/ministryofjustice/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ministryofjustice/cloud-platform-terraform-s3-bucket","description":null,"fork":false,"url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket","forks_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/forks","keys_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/teams","hooks_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/hooks","issue_events_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/issues/events{/number}","events_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/events","assignees_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/assignees{/user}","branches_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/branches{/branch}","tags_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/tags","blobs_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/git/refs{/sha}","trees_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/statuses/{sha}","languages_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/languages","stargazers_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/stargazers","contributors_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/contributors","subscribers_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/subscribers","subscription_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/subscription","commits_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/commits{/sha}","git_commits_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/git/commits{/sha}","comments_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/comments{/number}","issue_comment_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/issues/comments{/number}","contents_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/contents/{+path}","compare_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/merges","archive_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/downloads","issues_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/issues{/number}","pulls_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/pulls{/number}","milestones_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/milestones{/number}","notifications_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/labels{/name}","releases_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/releases{/id}","deployments_url":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/deployments","created_at":"2018-05-29T09:51:31Z","updated_at":"2018-05-31T12:07:52Z","pushed_at":"2018-05-31T15:49:27Z","git_url":"git://github.com/ministryofjustice/cloud-platform-terraform-s3-bucket.git","ssh_url":"git@github.com:ministryofjustice/cloud-platform-terraform-s3-bucket.git","clone_url":"https://github.com/ministryofjustice/cloud-platform-terraform-s3-bucket.git","svn_url":"https://github.com/ministryofjustice/cloud-platform-terraform-s3-bucket","homepage":null,"size":11,"stargazers_count":0,"watchers_count":0,"language":"HCL","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/pulls/2"},"html":{"href":"https://github.com/ministryofjustice/cloud-platform-terraform-s3-bucket/pull/2"},"issue":{"href":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/issues/2"},"comments":{"href":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/ministryofjustice/cloud-platform-terraform-s3-bucket/statuses/2dde83f5faac2e34cdeddb2b8da88e640a107b4c"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"jojuolape"}}