{"action":"created","comment":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/212571777","pull_request_review_id":149234485,"id":212571777,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjU3MTc3Nw==","diff_hunk":"@@ -1,14 +1,16 @@\n import * as React from 'react';\n+import { Omit } from 'react-bootstrap';\n import { DropdownBaseProps } from './Dropdown';\n \n declare namespace NavDropdown {\n     export interface NavDropdownBaseProps extends DropdownBaseProps {\n         active?: boolean;\n         noCaret?: boolean;\n         eventKey?: any;\n+        title: React.ReactNode;\n     }\n \n-    export type NavDropdownProps = NavDropdownBaseProps & React.HTMLProps<NavDropdown>;\n+  export type NavDropdownProps = NavDropdownBaseProps & Omit<React.HTMLProps<NavDropdown>, 'title'>;","path":"types/react-bootstrap/lib/NavDropdown.d.ts","position":14,"original_position":14,"commit_id":"402a9299d4763f75109fad9228e6263398433455","original_commit_id":"402a9299d4763f75109fad9228e6263398433455","user":{"login":"r3nya","id":209313,"node_id":"MDQ6VXNlcjIwOTMxMw==","avatar_url":"https://avatars1.githubusercontent.com/u/209313?v=4","gravatar_id":"","url":"https://api.github.com/users/r3nya","html_url":"https://github.com/r3nya","followers_url":"https://api.github.com/users/r3nya/followers","following_url":"https://api.github.com/users/r3nya/following{/other_user}","gists_url":"https://api.github.com/users/r3nya/gists{/gist_id}","starred_url":"https://api.github.com/users/r3nya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r3nya/subscriptions","organizations_url":"https://api.github.com/users/r3nya/orgs","repos_url":"https://api.github.com/users/r3nya/repos","events_url":"https://api.github.com/users/r3nya/events{/privacy}","received_events_url":"https://api.github.com/users/r3nya/received_events","type":"User","site_admin":false},"body":"It won't work without `Omit`, right?","created_at":"2018-08-24T09:29:28Z","updated_at":"2018-08-24T09:29:34Z","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/28350#discussion_r212571777","pull_request_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/28350","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments/212571777"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/28350#discussion_r212571777"},"pull_request":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/28350"}}},"pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/28350","id":210666432,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNjY2NDMy","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/28350","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/28350.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/28350.patch","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/28350","number":28350,"state":"open","locked":false,"title":"[react-bootstrap] update nav dropdown title definition","user":{"login":"t49tran","id":2223362,"node_id":"MDQ6VXNlcjIyMjMzNjI=","avatar_url":"https://avatars2.githubusercontent.com/u/2223362?v=4","gravatar_id":"","url":"https://api.github.com/users/t49tran","html_url":"https://github.com/t49tran","followers_url":"https://api.github.com/users/t49tran/followers","following_url":"https://api.github.com/users/t49tran/following{/other_user}","gists_url":"https://api.github.com/users/t49tran/gists{/gist_id}","starred_url":"https://api.github.com/users/t49tran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/t49tran/subscriptions","organizations_url":"https://api.github.com/users/t49tran/orgs","repos_url":"https://api.github.com/users/t49tran/repos","events_url":"https://api.github.com/users/t49tran/events{/privacy}","received_events_url":"https://api.github.com/users/t49tran/received_events","type":"User","site_admin":false},"body":"Please fill in this template.\r\n\r\n- [ v] Use a meaningful title for the pull request. Include the name of the package modified.\r\n- [ v] Test the change in your own code. (Compile and run.)\r\n- [ v] Add or edit tests to reflect the change. (Run with `npm test`.)\r\n- [ v] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#make-a-pull-request).\r\n- [ v] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#common-mistakes).\r\n- [ v] Run `npm run lint package-name` (or `tsc` if no `tslint.json` is present).\r\n\r\nSelect one of these and delete the others:\r\n\r\nIf changing an existing definition:\r\n- [ v] Provide a URL to documentation or source code which provides context for the suggested changes: <<https://github.com/react-bootstrap/react-bootstrap/blob/master/src/NavDropdown.js>>\r\n- [ v] Increase the version number in the header if appropriate.\r\n- [ v] If you are making substantial changes, consider adding a `tslint.json` containing `{ \"extends\": \"dtslint/dt.json\" }`.\r\n\r\n","created_at":"2018-08-24T07:57:43Z","updated_at":"2018-08-24T09:29:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f97f54ce9cb11a078fd7ef6e556ca4be8ae508f2","assignee":null,"assignees":[],"requested_reviewers":[{"login":"octatone","id":492289,"node_id":"MDQ6VXNlcjQ5MjI4OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/492289?v=4","gravatar_id":"","url":"https://api.github.com/users/octatone","html_url":"https://github.com/octatone","followers_url":"https://api.github.com/users/octatone/followers","following_url":"https://api.github.com/users/octatone/following{/other_user}","gists_url":"https://api.github.com/users/octatone/gists{/gist_id}","starred_url":"https://api.github.com/users/octatone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/octatone/subscriptions","organizations_url":"https://api.github.com/users/octatone/orgs","repos_url":"https://api.github.com/users/octatone/repos","events_url":"https://api.github.com/users/octatone/events{/privacy}","received_events_url":"https://api.github.com/users/octatone/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":397523192,"node_id":"MDU6TGFiZWwzOTc1MjMxOTI=","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Awaiting%20reviewer%20feedback","name":"Awaiting reviewer feedback","color":"0052cc","default":false},{"id":684321576,"node_id":"MDU6TGFiZWw2ODQzMjE1NzY=","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Popular%20package","name":"Popular package","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/28350/commits","review_comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/28350/comments","review_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/28350/comments","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/402a9299d4763f75109fad9228e6263398433455","head":{"label":"t49tran:react-bootstrap/update-nav-dropdown-definition","ref":"react-bootstrap/update-nav-dropdown-definition","sha":"402a9299d4763f75109fad9228e6263398433455","user":{"login":"t49tran","id":2223362,"node_id":"MDQ6VXNlcjIyMjMzNjI=","avatar_url":"https://avatars2.githubusercontent.com/u/2223362?v=4","gravatar_id":"","url":"https://api.github.com/users/t49tran","html_url":"https://github.com/t49tran","followers_url":"https://api.github.com/users/t49tran/followers","following_url":"https://api.github.com/users/t49tran/following{/other_user}","gists_url":"https://api.github.com/users/t49tran/gists{/gist_id}","starred_url":"https://api.github.com/users/t49tran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/t49tran/subscriptions","organizations_url":"https://api.github.com/users/t49tran/orgs","repos_url":"https://api.github.com/users/t49tran/repos","events_url":"https://api.github.com/users/t49tran/events{/privacy}","received_events_url":"https://api.github.com/users/t49tran/received_events","type":"User","site_admin":false},"repo":{"id":137172133,"node_id":"MDEwOlJlcG9zaXRvcnkxMzcxNzIxMzM=","name":"DefinitelyTyped","full_name":"t49tran/DefinitelyTyped","owner":{"login":"t49tran","id":2223362,"node_id":"MDQ6VXNlcjIyMjMzNjI=","avatar_url":"https://avatars2.githubusercontent.com/u/2223362?v=4","gravatar_id":"","url":"https://api.github.com/users/t49tran","html_url":"https://github.com/t49tran","followers_url":"https://api.github.com/users/t49tran/followers","following_url":"https://api.github.com/users/t49tran/following{/other_user}","gists_url":"https://api.github.com/users/t49tran/gists{/gist_id}","starred_url":"https://api.github.com/users/t49tran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/t49tran/subscriptions","organizations_url":"https://api.github.com/users/t49tran/orgs","repos_url":"https://api.github.com/users/t49tran/repos","events_url":"https://api.github.com/users/t49tran/events{/privacy}","received_events_url":"https://api.github.com/users/t49tran/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/t49tran/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":true,"url":"https://api.github.com/repos/t49tran/DefinitelyTyped","forks_url":"https://api.github.com/repos/t49tran/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/t49tran/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/t49tran/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/t49tran/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/t49tran/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/t49tran/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/t49tran/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/t49tran/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/t49tran/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/t49tran/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/t49tran/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/t49tran/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/t49tran/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/t49tran/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/t49tran/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/t49tran/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/t49tran/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/t49tran/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/t49tran/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/t49tran/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/t49tran/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/t49tran/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/t49tran/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/t49tran/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/t49tran/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/t49tran/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/t49tran/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/t49tran/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/t49tran/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/t49tran/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/t49tran/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/t49tran/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/t49tran/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/t49tran/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/t49tran/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/t49tran/DefinitelyTyped/deployments","created_at":"2018-06-13T06:29:28Z","updated_at":"2018-08-24T07:17:19Z","pushed_at":"2018-08-24T07:56:56Z","git_url":"git://github.com/t49tran/DefinitelyTyped.git","ssh_url":"git@github.com:t49tran/DefinitelyTyped.git","clone_url":"https://github.com/t49tran/DefinitelyTyped.git","svn_url":"https://github.com/t49tran/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":349761,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DefinitelyTyped:master","ref":"master","sha":"37926fac895ea1998b70dc11e61a909f42570d24","user":{"login":"DefinitelyTyped","id":3637556,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2Mzc1NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"repo":{"id":6093316,"node_id":"MDEwOlJlcG9zaXRvcnk2MDkzMzE2","name":"DefinitelyTyped","full_name":"DefinitelyTyped/DefinitelyTyped","owner":{"login":"DefinitelyTyped","id":3637556,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2Mzc1NTY=","avatar_url":"https://avatars1.githubusercontent.com/u/3637556?v=4","gravatar_id":"","url":"https://api.github.com/users/DefinitelyTyped","html_url":"https://github.com/DefinitelyTyped","followers_url":"https://api.github.com/users/DefinitelyTyped/followers","following_url":"https://api.github.com/users/DefinitelyTyped/following{/other_user}","gists_url":"https://api.github.com/users/DefinitelyTyped/gists{/gist_id}","starred_url":"https://api.github.com/users/DefinitelyTyped/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DefinitelyTyped/subscriptions","organizations_url":"https://api.github.com/users/DefinitelyTyped/orgs","repos_url":"https://api.github.com/users/DefinitelyTyped/repos","events_url":"https://api.github.com/users/DefinitelyTyped/events{/privacy}","received_events_url":"https://api.github.com/users/DefinitelyTyped/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","description":"The repository for high quality TypeScript type definitions.","fork":false,"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","forks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/forks","keys_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/teams","hooks_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/hooks","issue_events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/events{/number}","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/events","assignees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/assignees{/user}","branches_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/branches{/branch}","tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/tags","blobs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/refs{/sha}","trees_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/{sha}","languages_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/languages","stargazers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/stargazers","contributors_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contributors","subscribers_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscribers","subscription_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/subscription","commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/commits{/sha}","git_commits_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/git/commits{/sha}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/comments{/number}","issue_comment_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments{/number}","contents_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/contents/{+path}","compare_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/merges","archive_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/downloads","issues_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues{/number}","pulls_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls{/number}","milestones_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/milestones{/number}","notifications_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels{/name}","releases_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/releases{/id}","deployments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/deployments","created_at":"2012-10-05T16:39:45Z","updated_at":"2018-08-24T09:19:21Z","pushed_at":"2018-08-24T09:22:07Z","git_url":"git://github.com/DefinitelyTyped/DefinitelyTyped.git","ssh_url":"git@github.com:DefinitelyTyped/DefinitelyTyped.git","clone_url":"https://github.com/DefinitelyTyped/DefinitelyTyped.git","svn_url":"https://github.com/DefinitelyTyped/DefinitelyTyped","homepage":"http://definitelytyped.org/","size":349772,"stargazers_count":17066,"watchers_count":17066,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14259,"mirror_url":null,"archived":false,"open_issues_count":2375,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":14259,"open_issues":2375,"watchers":17066,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/28350"},"html":{"href":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/28350"},"issue":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/28350"},"comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/28350/comments"},"review_comments":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/28350/comments"},"review_comment":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/28350/commits"},"statuses":{"href":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/statuses/402a9299d4763f75109fad9228e6263398433455"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"r3nya"}}