{"action":"created","issue":{"url":"https://api.github.com/repos/palantir/http-remoting/issues/671","repository_url":"https://api.github.com/repos/palantir/http-remoting","labels_url":"https://api.github.com/repos/palantir/http-remoting/issues/671/labels{/name}","comments_url":"https://api.github.com/repos/palantir/http-remoting/issues/671/comments","events_url":"https://api.github.com/repos/palantir/http-remoting/issues/671/events","html_url":"https://github.com/palantir/http-remoting/pull/671","id":297182975,"number":671,"title":"Fix JaxRs RemoteException stack traces to include the call site","user":{"login":"iamdanfox","id":3473798,"avatar_url":"https://avatars1.githubusercontent.com/u/3473798?v=4","gravatar_id":"","url":"https://api.github.com/users/iamdanfox","html_url":"https://github.com/iamdanfox","followers_url":"https://api.github.com/users/iamdanfox/followers","following_url":"https://api.github.com/users/iamdanfox/following{/other_user}","gists_url":"https://api.github.com/users/iamdanfox/gists{/gist_id}","starred_url":"https://api.github.com/users/iamdanfox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iamdanfox/subscriptions","organizations_url":"https://api.github.com/users/iamdanfox/orgs","repos_url":"https://api.github.com/users/iamdanfox/repos","events_url":"https://api.github.com/users/iamdanfox/events{/privacy}","received_events_url":"https://api.github.com/users/iamdanfox/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-02-14T17:34:29Z","updated_at":"2018-02-14T17:54:01Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/palantir/http-remoting/pulls/671","html_url":"https://github.com/palantir/http-remoting/pull/671","diff_url":"https://github.com/palantir/http-remoting/pull/671.diff","patch_url":"https://github.com/palantir/http-remoting/pull/671.patch"},"body":"fixes https://github.com/palantir/http-remoting/issues/670\r\n\r\nOn the RemoteException codepath, we now never throw _any_ information away, so you get nice clear stack traces like this:\r\n\r\n```diff\r\n com.palantir.remoting.api.errors.RemoteException: RemoteException: INTERNAL (Default:Internal) with instance ID 605b5f20-a83a-46c9-a207-cf60764b7975\r\n \tat com.palantir.remoting3.okhttp.RemotingOkHttpCall.execute(RemotingOkHttpCall.java:117)\r\n \tat feign.okhttp.OkHttpClient.execute(OkHttpClient.java:155)\r\n \tat feign.SynchronousMethodHandler.executeAndDecode(SynchronousMethodHandler.java:97)\r\n \tat feign.SynchronousMethodHandler.invoke(SynchronousMethodHandler.java:76)\r\n \tat feign.ReflectiveFeign$FeignInvocationHandler.invoke(ReflectiveFeign.java:103)\r\n \tat com.sun.proxy.$Proxy14.string(Unknown Source)\r\n+\tat com.palantir.remoting3.jaxrs.JaxRsClientStackTraceTest.stack_trace_from_remote_exception_should_include_call_site(JaxRsClientStackTraceTest.java:68)\r\n \tat sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)\r\n \tat sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)\r\n \tat sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)\r\n \tat java.lang.reflect.Method.invoke(Method.java:497)\r\n \tat org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)\r\n \tat org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)\r\n \t...\r\n Caused by: java.util.concurrent.ExecutionException: com.palantir.remoting3.okhttp.IoRemoteException\r\n \tat com.google.common.util.concurrent.AbstractFuture.getDoneValue(AbstractFuture.java:500)\r\n \tat com.google.common.util.concurrent.AbstractFuture.get(AbstractFuture.java:401)\r\n \tat com.google.common.util.concurrent.AbstractFuture$TrustedFuture.get(AbstractFuture.java:83)\r\n \tat com.palantir.remoting3.okhttp.RemotingOkHttpCall.execute(RemotingOkHttpCall.java:106)\r\n \t... 39 more\r\n Caused by: com.palantir.remoting3.okhttp.IoRemoteException\r\n \tat com.palantir.remoting3.okhttp.RemotingOkHttpCall$2.onResponse(RemotingOkHttpCall.java:198)\r\n \tat okhttp3.RealCall$AsyncCall.execute(RealCall.java:153)\r\n \tat okhttp3.internal.NamedRunnable.run(NamedRunnable.java:32)\r\n \tat java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)\r\n \tat com.palantir.remoting3.tracing.Tracers$TracingAwareCallable$$Lambda$55/695883542.call(Unknown Source)\r\n \tat com.palantir.remoting3.tracing.DeferredTracer.withTrace(DeferredTracer.java:43)\r\n \tat com.palantir.remoting3.tracing.Tracers$TracingAwareCallable.call(Tracers.java:182)\r\n \tat com.palantir.remoting3.tracing.WrappingExecutorService.lambda$wrapTask$6(WrappingExecutorService.java:70)\r\n \tat com.palantir.remoting3.tracing.WrappingExecutorService$$Lambda$54/1276709283.run(Unknown Source)\r\n \tat java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)\r\n \tat java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)\r\n \tat java.lang.Thread.run(Thread.java:745)\r\n```"},"comment":{"url":"https://api.github.com/repos/palantir/http-remoting/issues/comments/365690381","html_url":"https://github.com/palantir/http-remoting/pull/671#issuecomment-365690381","issue_url":"https://api.github.com/repos/palantir/http-remoting/issues/671","id":365690381,"user":{"login":"ellisjoe","id":1103080,"avatar_url":"https://avatars3.githubusercontent.com/u/1103080?v=4","gravatar_id":"","url":"https://api.github.com/users/ellisjoe","html_url":"https://github.com/ellisjoe","followers_url":"https://api.github.com/users/ellisjoe/followers","following_url":"https://api.github.com/users/ellisjoe/following{/other_user}","gists_url":"https://api.github.com/users/ellisjoe/gists{/gist_id}","starred_url":"https://api.github.com/users/ellisjoe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ellisjoe/subscriptions","organizations_url":"https://api.github.com/users/ellisjoe/orgs","repos_url":"https://api.github.com/users/ellisjoe/repos","events_url":"https://api.github.com/users/ellisjoe/events{/privacy}","received_events_url":"https://api.github.com/users/ellisjoe/received_events","type":"User","site_admin":false},"created_at":"2018-02-14T17:54:01Z","updated_at":"2018-02-14T17:54:01Z","author_association":"COLLABORATOR","body":"sweet"}}
{"actor":{"display_login":"ellisjoe"}}