{"action":"created","comment":{"url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/pulls/comments/214411274","pull_request_review_id":151469817,"id":214411274,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNDQxMTI3NA==","diff_hunk":"@@ -63,9 +63,12 @@\n                             org.apache.poi.ss.usermodel;version=\"[2.0,4)\",  <!-- using a wider version range for forward compatibility -->\n                             org.apache.poi.ss.util;version=\"[2.0,4)\",\n                             org.apache.poi.xssf.usermodel;version=\"[2.0,4)\",\n+                            org.bouncycastle.jce;resolution:=optional,  <!-- jjwt -->","path":"bundle/pom.xml","position":null,"original_position":4,"commit_id":"84ec82b4b1a57a2634d4dbd6a2a2445ed0a6318b","original_commit_id":"4d8c8fd9c9f168b1936355e6369d9d51736b6f92","user":{"login":"heervisscher","id":1647181,"node_id":"MDQ6VXNlcjE2NDcxODE=","avatar_url":"https://avatars0.githubusercontent.com/u/1647181?v=4","gravatar_id":"","url":"https://api.github.com/users/heervisscher","html_url":"https://github.com/heervisscher","followers_url":"https://api.github.com/users/heervisscher/followers","following_url":"https://api.github.com/users/heervisscher/following{/other_user}","gists_url":"https://api.github.com/users/heervisscher/gists{/gist_id}","starred_url":"https://api.github.com/users/heervisscher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heervisscher/subscriptions","organizations_url":"https://api.github.com/users/heervisscher/orgs","repos_url":"https://api.github.com/users/heervisscher/repos","events_url":"https://api.github.com/users/heervisscher/events{/privacy}","received_events_url":"https://api.github.com/users/heervisscher/received_events","type":"User","site_admin":false},"body":"right, got it. I applied it like this","created_at":"2018-08-31T16:40:38Z","updated_at":"2018-08-31T16:40:38Z","html_url":"https://github.com/Adobe-Consulting-Services/acs-aem-commons/pull/1460#discussion_r214411274","pull_request_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/pulls/1460","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/pulls/comments/214411274"},"html":{"href":"https://github.com/Adobe-Consulting-Services/acs-aem-commons/pull/1460#discussion_r214411274"},"pull_request":{"href":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/pulls/1460"}},"in_reply_to_id":214342007},"pull_request":{"url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/pulls/1460","id":209134456,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MTM0NDU2","html_url":"https://github.com/Adobe-Consulting-Services/acs-aem-commons/pull/1460","diff_url":"https://github.com/Adobe-Consulting-Services/acs-aem-commons/pull/1460.diff","patch_url":"https://github.com/Adobe-Consulting-Services/acs-aem-commons/pull/1460.patch","issue_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/issues/1460","number":1460,"state":"open","locked":false,"title":"Feature/adobe io integration in acs","user":{"login":"komay","id":41366701,"node_id":"MDQ6VXNlcjQxMzY2NzAx","avatar_url":"https://avatars3.githubusercontent.com/u/41366701?v=4","gravatar_id":"","url":"https://api.github.com/users/komay","html_url":"https://github.com/komay","followers_url":"https://api.github.com/users/komay/followers","following_url":"https://api.github.com/users/komay/following{/other_user}","gists_url":"https://api.github.com/users/komay/gists{/gist_id}","starred_url":"https://api.github.com/users/komay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/komay/subscriptions","organizations_url":"https://api.github.com/users/komay/orgs","repos_url":"https://api.github.com/users/komay/repos","events_url":"https://api.github.com/users/komay/events{/privacy}","received_events_url":"https://api.github.com/users/komay/received_events","type":"User","site_admin":false},"body":"Adobe io donation to acs commons.\r\n\r\nMoving Code from Emmerging tech repo to acs commons\r\n* Code moving from emerging tech repo\r\n* Upgrade of pom parent and core\r\n\r\n\r\nMaking the OSGI configuration more generique\r\n* Initial configuration was dedicated to campaign.\r\n* Remove all Campaign references\r\n\r\nCode refactoring\r\n* Adding ACS AEM Commons prefix in configuration label\r\n* Remove redundant field Tenant Service\r\n* Removing config used for test purpose\r\n* Change HTTP method field to make it select field\r\n* Fix dependencies and banned dependencies\r\n* Remove sample code and unused code","created_at":"2018-08-17T12:34:38Z","updated_at":"2018-08-31T16:40:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"43c828e6dad3b25212b6fa5d236583962ad9c85e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/pulls/1460/commits","review_comments_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/pulls/1460/comments","review_comment_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/issues/1460/comments","statuses_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/statuses/84ec82b4b1a57a2634d4dbd6a2a2445ed0a6318b","head":{"label":"komay:feature/adobe-io-integration-in-acs","ref":"feature/adobe-io-integration-in-acs","sha":"84ec82b4b1a57a2634d4dbd6a2a2445ed0a6318b","user":{"login":"komay","id":41366701,"node_id":"MDQ6VXNlcjQxMzY2NzAx","avatar_url":"https://avatars3.githubusercontent.com/u/41366701?v=4","gravatar_id":"","url":"https://api.github.com/users/komay","html_url":"https://github.com/komay","followers_url":"https://api.github.com/users/komay/followers","following_url":"https://api.github.com/users/komay/following{/other_user}","gists_url":"https://api.github.com/users/komay/gists{/gist_id}","starred_url":"https://api.github.com/users/komay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/komay/subscriptions","organizations_url":"https://api.github.com/users/komay/orgs","repos_url":"https://api.github.com/users/komay/repos","events_url":"https://api.github.com/users/komay/events{/privacy}","received_events_url":"https://api.github.com/users/komay/received_events","type":"User","site_admin":false},"repo":{"id":141414657,"node_id":"MDEwOlJlcG9zaXRvcnkxNDE0MTQ2NTc=","name":"acs-aem-commons","full_name":"komay/acs-aem-commons","owner":{"login":"komay","id":41366701,"node_id":"MDQ6VXNlcjQxMzY2NzAx","avatar_url":"https://avatars3.githubusercontent.com/u/41366701?v=4","gravatar_id":"","url":"https://api.github.com/users/komay","html_url":"https://github.com/komay","followers_url":"https://api.github.com/users/komay/followers","following_url":"https://api.github.com/users/komay/following{/other_user}","gists_url":"https://api.github.com/users/komay/gists{/gist_id}","starred_url":"https://api.github.com/users/komay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/komay/subscriptions","organizations_url":"https://api.github.com/users/komay/orgs","repos_url":"https://api.github.com/users/komay/repos","events_url":"https://api.github.com/users/komay/events{/privacy}","received_events_url":"https://api.github.com/users/komay/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/komay/acs-aem-commons","description":null,"fork":true,"url":"https://api.github.com/repos/komay/acs-aem-commons","forks_url":"https://api.github.com/repos/komay/acs-aem-commons/forks","keys_url":"https://api.github.com/repos/komay/acs-aem-commons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/komay/acs-aem-commons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/komay/acs-aem-commons/teams","hooks_url":"https://api.github.com/repos/komay/acs-aem-commons/hooks","issue_events_url":"https://api.github.com/repos/komay/acs-aem-commons/issues/events{/number}","events_url":"https://api.github.com/repos/komay/acs-aem-commons/events","assignees_url":"https://api.github.com/repos/komay/acs-aem-commons/assignees{/user}","branches_url":"https://api.github.com/repos/komay/acs-aem-commons/branches{/branch}","tags_url":"https://api.github.com/repos/komay/acs-aem-commons/tags","blobs_url":"https://api.github.com/repos/komay/acs-aem-commons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/komay/acs-aem-commons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/komay/acs-aem-commons/git/refs{/sha}","trees_url":"https://api.github.com/repos/komay/acs-aem-commons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/komay/acs-aem-commons/statuses/{sha}","languages_url":"https://api.github.com/repos/komay/acs-aem-commons/languages","stargazers_url":"https://api.github.com/repos/komay/acs-aem-commons/stargazers","contributors_url":"https://api.github.com/repos/komay/acs-aem-commons/contributors","subscribers_url":"https://api.github.com/repos/komay/acs-aem-commons/subscribers","subscription_url":"https://api.github.com/repos/komay/acs-aem-commons/subscription","commits_url":"https://api.github.com/repos/komay/acs-aem-commons/commits{/sha}","git_commits_url":"https://api.github.com/repos/komay/acs-aem-commons/git/commits{/sha}","comments_url":"https://api.github.com/repos/komay/acs-aem-commons/comments{/number}","issue_comment_url":"https://api.github.com/repos/komay/acs-aem-commons/issues/comments{/number}","contents_url":"https://api.github.com/repos/komay/acs-aem-commons/contents/{+path}","compare_url":"https://api.github.com/repos/komay/acs-aem-commons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/komay/acs-aem-commons/merges","archive_url":"https://api.github.com/repos/komay/acs-aem-commons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/komay/acs-aem-commons/downloads","issues_url":"https://api.github.com/repos/komay/acs-aem-commons/issues{/number}","pulls_url":"https://api.github.com/repos/komay/acs-aem-commons/pulls{/number}","milestones_url":"https://api.github.com/repos/komay/acs-aem-commons/milestones{/number}","notifications_url":"https://api.github.com/repos/komay/acs-aem-commons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/komay/acs-aem-commons/labels{/name}","releases_url":"https://api.github.com/repos/komay/acs-aem-commons/releases{/id}","deployments_url":"https://api.github.com/repos/komay/acs-aem-commons/deployments","created_at":"2018-07-18T09:44:49Z","updated_at":"2018-07-18T09:44:56Z","pushed_at":"2018-08-31T16:38:44Z","git_url":"git://github.com/komay/acs-aem-commons.git","ssh_url":"git@github.com:komay/acs-aem-commons.git","clone_url":"https://github.com/komay/acs-aem-commons.git","svn_url":"https://github.com/komay/acs-aem-commons","homepage":"http://adobe-consulting-services.github.io/acs-aem-commons/","size":15611,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Adobe-Consulting-Services:master","ref":"master","sha":"7034199d7a59736ef76a8ae6e46e72e00c070713","user":{"login":"Adobe-Consulting-Services","id":5420974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MjA5NzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5420974?v=4","gravatar_id":"","url":"https://api.github.com/users/Adobe-Consulting-Services","html_url":"https://github.com/Adobe-Consulting-Services","followers_url":"https://api.github.com/users/Adobe-Consulting-Services/followers","following_url":"https://api.github.com/users/Adobe-Consulting-Services/following{/other_user}","gists_url":"https://api.github.com/users/Adobe-Consulting-Services/gists{/gist_id}","starred_url":"https://api.github.com/users/Adobe-Consulting-Services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Adobe-Consulting-Services/subscriptions","organizations_url":"https://api.github.com/users/Adobe-Consulting-Services/orgs","repos_url":"https://api.github.com/users/Adobe-Consulting-Services/repos","events_url":"https://api.github.com/users/Adobe-Consulting-Services/events{/privacy}","received_events_url":"https://api.github.com/users/Adobe-Consulting-Services/received_events","type":"Organization","site_admin":false},"repo":{"id":13325401,"node_id":"MDEwOlJlcG9zaXRvcnkxMzMyNTQwMQ==","name":"acs-aem-commons","full_name":"Adobe-Consulting-Services/acs-aem-commons","owner":{"login":"Adobe-Consulting-Services","id":5420974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MjA5NzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5420974?v=4","gravatar_id":"","url":"https://api.github.com/users/Adobe-Consulting-Services","html_url":"https://github.com/Adobe-Consulting-Services","followers_url":"https://api.github.com/users/Adobe-Consulting-Services/followers","following_url":"https://api.github.com/users/Adobe-Consulting-Services/following{/other_user}","gists_url":"https://api.github.com/users/Adobe-Consulting-Services/gists{/gist_id}","starred_url":"https://api.github.com/users/Adobe-Consulting-Services/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Adobe-Consulting-Services/subscriptions","organizations_url":"https://api.github.com/users/Adobe-Consulting-Services/orgs","repos_url":"https://api.github.com/users/Adobe-Consulting-Services/repos","events_url":"https://api.github.com/users/Adobe-Consulting-Services/events{/privacy}","received_events_url":"https://api.github.com/users/Adobe-Consulting-Services/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Adobe-Consulting-Services/acs-aem-commons","description":null,"fork":false,"url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons","forks_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/forks","keys_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/teams","hooks_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/hooks","issue_events_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/issues/events{/number}","events_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/events","assignees_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/assignees{/user}","branches_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/branches{/branch}","tags_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/tags","blobs_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/git/refs{/sha}","trees_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/statuses/{sha}","languages_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/languages","stargazers_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/stargazers","contributors_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/contributors","subscribers_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/subscribers","subscription_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/subscription","commits_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/commits{/sha}","git_commits_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/git/commits{/sha}","comments_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/comments{/number}","issue_comment_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/issues/comments{/number}","contents_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/contents/{+path}","compare_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/merges","archive_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/downloads","issues_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/issues{/number}","pulls_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/pulls{/number}","milestones_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/milestones{/number}","notifications_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/labels{/name}","releases_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/releases{/id}","deployments_url":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/deployments","created_at":"2013-10-04T13:50:05Z","updated_at":"2018-08-30T15:07:20Z","pushed_at":"2018-08-31T16:38:47Z","git_url":"git://github.com/Adobe-Consulting-Services/acs-aem-commons.git","ssh_url":"git@github.com:Adobe-Consulting-Services/acs-aem-commons.git","clone_url":"https://github.com/Adobe-Consulting-Services/acs-aem-commons.git","svn_url":"https://github.com/Adobe-Consulting-Services/acs-aem-commons","homepage":"http://adobe-consulting-services.github.io/acs-aem-commons/","size":15418,"stargazers_count":274,"watchers_count":274,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":359,"mirror_url":null,"archived":false,"open_issues_count":41,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":359,"open_issues":41,"watchers":274,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/pulls/1460"},"html":{"href":"https://github.com/Adobe-Consulting-Services/acs-aem-commons/pull/1460"},"issue":{"href":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/issues/1460"},"comments":{"href":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/issues/1460/comments"},"review_comments":{"href":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/pulls/1460/comments"},"review_comment":{"href":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/pulls/1460/commits"},"statuses":{"href":"https://api.github.com/repos/Adobe-Consulting-Services/acs-aem-commons/statuses/84ec82b4b1a57a2634d4dbd6a2a2445ed0a6318b"}},"author_association":"NONE"}}
{"actor":{"display_login":"heervisscher"}}