{"action":"opened","number":4,"pull_request":{"url":"https://api.github.com/repos/geoschem/geos-chem/pulls/4","id":206820027,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2ODIwMDI3","html_url":"https://github.com/geoschem/geos-chem/pull/4","diff_url":"https://github.com/geoschem/geos-chem/pull/4.diff","patch_url":"https://github.com/geoschem/geos-chem/pull/4.patch","issue_url":"https://api.github.com/repos/geoschem/geos-chem/issues/4","number":4,"state":"open","locked":false,"title":"Unify GeosCore module initializations to accept the same arguments","user":{"login":"jimmielin","id":123603,"node_id":"MDQ6VXNlcjEyMzYwMw==","avatar_url":"https://avatars2.githubusercontent.com/u/123603?v=4","gravatar_id":"","url":"https://api.github.com/users/jimmielin","html_url":"https://github.com/jimmielin","followers_url":"https://api.github.com/users/jimmielin/followers","following_url":"https://api.github.com/users/jimmielin/following{/other_user}","gists_url":"https://api.github.com/users/jimmielin/gists{/gist_id}","starred_url":"https://api.github.com/users/jimmielin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimmielin/subscriptions","organizations_url":"https://api.github.com/users/jimmielin/orgs","repos_url":"https://api.github.com/users/jimmielin/repos","events_url":"https://api.github.com/users/jimmielin/events{/privacy}","received_events_url":"https://api.github.com/users/jimmielin/received_events","type":"User","site_admin":false},"body":"This commit unifies all modules in `GeosCore` to accept the same set of arguments - `(am_I_Root, Input_Opt, State_Chm, State_Diag, RC)`\r\n\r\nThis is done in preparation for moving USE-associated arrays that are dependent on grid sizing (i.e. `(IIPAR, JJPAR, LLPAR)`) in these modules\r\nto `State_Chm`, permitting multi-domain GC-WRF coupling and, in a broader sense, running simultaneous instances of GEOS-Chem modules in the same CPU.\r\n\r\n**Important Note: GCHP Code Update Necessary**\r\nThis commit changes the entry point for `Init_TOMS` which is being called in GCHP by `gigc_chunk_mod.F90`, breaking compilation for GCHP. \r\n\r\n**Solution:** That entry point should be *removed* - please refer to the following code context taken from `gigc_chunk_mod`, around lines 305:\r\n\r\n```fortran\r\n    ! Initialize other GEOS-Chem modules\r\n    CALL GC_Init_Extra( am_I_Root, HistoryConfig%DiagList, Input_Opt,    &\r\n                        State_Chm, State_Diag, RC ) \r\n    ASSERT_(RC==GC_SUCCESS)\r\n\r\n    ! ...\r\n\r\n    ! Allocate array of overhead O3 columns for TOMS if chemistry is on\r\n    IF ( Input_Opt%LCHEM ) THEN\r\n       CALL Init_TOMS( am_I_Root, Input_Opt, RC )\r\n       ASSERT_(RC==GC_SUCCESS)\r\n    ENDIF\r\n```\r\n\r\nWithin `GC_Init_Extra` (from `GC_Environment_Mod`), the following already exists:\r\n\r\n```fortran\r\n    !-----------------------------------------------------------------\r\n    ! Initialize \"toms_mod.F\"\r\n    !-----------------------------------------------------------------\r\n    CALL Init_Toms( am_I_Root, Input_Opt, State_Chm, State_Diag, RC )\r\n    IF ( RC /= GC_SUCCESS ) THEN\r\n       ErrMsg = 'Error encountered in \"Init_Toms\"!'\r\n       CALL GC_Error( ErrMsg, RC, ThisLoc )\r\n       RETURN\r\n    ENDIF\r\n```\r\n\r\nWhich runs independent of `Input_Opt%LCHEM` selection. Therefore I believe that in the GCHP source, the `Init_TOMS` code is redundant and should be removed. It does not throw a duplicate allocation error, because there are `ALLOCATED` sanity checks within `Init_TOMS` code.\r\n\r\n\r\nSigned-off-by: Haipeng Lin <linhaipeng@pku.edu.cn>","created_at":"2018-08-07T20:39:48Z","updated_at":"2018-08-07T20:39:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/geoschem/geos-chem/pulls/4/commits","review_comments_url":"https://api.github.com/repos/geoschem/geos-chem/pulls/4/comments","review_comment_url":"https://api.github.com/repos/geoschem/geos-chem/pulls/comments{/number}","comments_url":"https://api.github.com/repos/geoschem/geos-chem/issues/4/comments","statuses_url":"https://api.github.com/repos/geoschem/geos-chem/statuses/ab6a0c5c848891f7b540a78567876fa2d543d7b6","head":{"label":"jimmielin:devel-unify-init","ref":"devel-unify-init","sha":"ab6a0c5c848891f7b540a78567876fa2d543d7b6","user":{"login":"jimmielin","id":123603,"node_id":"MDQ6VXNlcjEyMzYwMw==","avatar_url":"https://avatars2.githubusercontent.com/u/123603?v=4","gravatar_id":"","url":"https://api.github.com/users/jimmielin","html_url":"https://github.com/jimmielin","followers_url":"https://api.github.com/users/jimmielin/followers","following_url":"https://api.github.com/users/jimmielin/following{/other_user}","gists_url":"https://api.github.com/users/jimmielin/gists{/gist_id}","starred_url":"https://api.github.com/users/jimmielin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimmielin/subscriptions","organizations_url":"https://api.github.com/users/jimmielin/orgs","repos_url":"https://api.github.com/users/jimmielin/repos","events_url":"https://api.github.com/users/jimmielin/events{/privacy}","received_events_url":"https://api.github.com/users/jimmielin/received_events","type":"User","site_admin":false},"repo":{"id":143307953,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMzMDc5NTM=","name":"geos-chem","full_name":"jimmielin/geos-chem","owner":{"login":"jimmielin","id":123603,"node_id":"MDQ6VXNlcjEyMzYwMw==","avatar_url":"https://avatars2.githubusercontent.com/u/123603?v=4","gravatar_id":"","url":"https://api.github.com/users/jimmielin","html_url":"https://github.com/jimmielin","followers_url":"https://api.github.com/users/jimmielin/followers","following_url":"https://api.github.com/users/jimmielin/following{/other_user}","gists_url":"https://api.github.com/users/jimmielin/gists{/gist_id}","starred_url":"https://api.github.com/users/jimmielin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jimmielin/subscriptions","organizations_url":"https://api.github.com/users/jimmielin/orgs","repos_url":"https://api.github.com/users/jimmielin/repos","events_url":"https://api.github.com/users/jimmielin/events{/privacy}","received_events_url":"https://api.github.com/users/jimmielin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jimmielin/geos-chem","description":"Source code repository for the GEOS-Chem model of atmospheric chemistry and composition.","fork":true,"url":"https://api.github.com/repos/jimmielin/geos-chem","forks_url":"https://api.github.com/repos/jimmielin/geos-chem/forks","keys_url":"https://api.github.com/repos/jimmielin/geos-chem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jimmielin/geos-chem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jimmielin/geos-chem/teams","hooks_url":"https://api.github.com/repos/jimmielin/geos-chem/hooks","issue_events_url":"https://api.github.com/repos/jimmielin/geos-chem/issues/events{/number}","events_url":"https://api.github.com/repos/jimmielin/geos-chem/events","assignees_url":"https://api.github.com/repos/jimmielin/geos-chem/assignees{/user}","branches_url":"https://api.github.com/repos/jimmielin/geos-chem/branches{/branch}","tags_url":"https://api.github.com/repos/jimmielin/geos-chem/tags","blobs_url":"https://api.github.com/repos/jimmielin/geos-chem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jimmielin/geos-chem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jimmielin/geos-chem/git/refs{/sha}","trees_url":"https://api.github.com/repos/jimmielin/geos-chem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jimmielin/geos-chem/statuses/{sha}","languages_url":"https://api.github.com/repos/jimmielin/geos-chem/languages","stargazers_url":"https://api.github.com/repos/jimmielin/geos-chem/stargazers","contributors_url":"https://api.github.com/repos/jimmielin/geos-chem/contributors","subscribers_url":"https://api.github.com/repos/jimmielin/geos-chem/subscribers","subscription_url":"https://api.github.com/repos/jimmielin/geos-chem/subscription","commits_url":"https://api.github.com/repos/jimmielin/geos-chem/commits{/sha}","git_commits_url":"https://api.github.com/repos/jimmielin/geos-chem/git/commits{/sha}","comments_url":"https://api.github.com/repos/jimmielin/geos-chem/comments{/number}","issue_comment_url":"https://api.github.com/repos/jimmielin/geos-chem/issues/comments{/number}","contents_url":"https://api.github.com/repos/jimmielin/geos-chem/contents/{+path}","compare_url":"https://api.github.com/repos/jimmielin/geos-chem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jimmielin/geos-chem/merges","archive_url":"https://api.github.com/repos/jimmielin/geos-chem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jimmielin/geos-chem/downloads","issues_url":"https://api.github.com/repos/jimmielin/geos-chem/issues{/number}","pulls_url":"https://api.github.com/repos/jimmielin/geos-chem/pulls{/number}","milestones_url":"https://api.github.com/repos/jimmielin/geos-chem/milestones{/number}","notifications_url":"https://api.github.com/repos/jimmielin/geos-chem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jimmielin/geos-chem/labels{/name}","releases_url":"https://api.github.com/repos/jimmielin/geos-chem/releases{/id}","deployments_url":"https://api.github.com/repos/jimmielin/geos-chem/deployments","created_at":"2018-08-02T14:46:41Z","updated_at":"2018-08-02T15:21:18Z","pushed_at":"2018-08-07T20:16:24Z","git_url":"git://github.com/jimmielin/geos-chem.git","ssh_url":"git@github.com:jimmielin/geos-chem.git","clone_url":"https://github.com/jimmielin/geos-chem.git","svn_url":"https://github.com/jimmielin/geos-chem","homepage":null,"size":53911,"stargazers_count":0,"watchers_count":0,"language":"Fortran","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"geoschem:Dev","ref":"Dev","sha":"592d206ed42b568ae871bbf9773ee31d4adf043c","user":{"login":"geoschem","id":8321017,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgzMjEwMTc=","avatar_url":"https://avatars0.githubusercontent.com/u/8321017?v=4","gravatar_id":"","url":"https://api.github.com/users/geoschem","html_url":"https://github.com/geoschem","followers_url":"https://api.github.com/users/geoschem/followers","following_url":"https://api.github.com/users/geoschem/following{/other_user}","gists_url":"https://api.github.com/users/geoschem/gists{/gist_id}","starred_url":"https://api.github.com/users/geoschem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoschem/subscriptions","organizations_url":"https://api.github.com/users/geoschem/orgs","repos_url":"https://api.github.com/users/geoschem/repos","events_url":"https://api.github.com/users/geoschem/events{/privacy}","received_events_url":"https://api.github.com/users/geoschem/received_events","type":"Organization","site_admin":false},"repo":{"id":137920321,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc5MjAzMjE=","name":"geos-chem","full_name":"geoschem/geos-chem","owner":{"login":"geoschem","id":8321017,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgzMjEwMTc=","avatar_url":"https://avatars0.githubusercontent.com/u/8321017?v=4","gravatar_id":"","url":"https://api.github.com/users/geoschem","html_url":"https://github.com/geoschem","followers_url":"https://api.github.com/users/geoschem/followers","following_url":"https://api.github.com/users/geoschem/following{/other_user}","gists_url":"https://api.github.com/users/geoschem/gists{/gist_id}","starred_url":"https://api.github.com/users/geoschem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geoschem/subscriptions","organizations_url":"https://api.github.com/users/geoschem/orgs","repos_url":"https://api.github.com/users/geoschem/repos","events_url":"https://api.github.com/users/geoschem/events{/privacy}","received_events_url":"https://api.github.com/users/geoschem/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/geoschem/geos-chem","description":"Source code repository for the GEOS-Chem model of atmospheric chemistry and composition.","fork":false,"url":"https://api.github.com/repos/geoschem/geos-chem","forks_url":"https://api.github.com/repos/geoschem/geos-chem/forks","keys_url":"https://api.github.com/repos/geoschem/geos-chem/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geoschem/geos-chem/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geoschem/geos-chem/teams","hooks_url":"https://api.github.com/repos/geoschem/geos-chem/hooks","issue_events_url":"https://api.github.com/repos/geoschem/geos-chem/issues/events{/number}","events_url":"https://api.github.com/repos/geoschem/geos-chem/events","assignees_url":"https://api.github.com/repos/geoschem/geos-chem/assignees{/user}","branches_url":"https://api.github.com/repos/geoschem/geos-chem/branches{/branch}","tags_url":"https://api.github.com/repos/geoschem/geos-chem/tags","blobs_url":"https://api.github.com/repos/geoschem/geos-chem/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geoschem/geos-chem/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geoschem/geos-chem/git/refs{/sha}","trees_url":"https://api.github.com/repos/geoschem/geos-chem/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geoschem/geos-chem/statuses/{sha}","languages_url":"https://api.github.com/repos/geoschem/geos-chem/languages","stargazers_url":"https://api.github.com/repos/geoschem/geos-chem/stargazers","contributors_url":"https://api.github.com/repos/geoschem/geos-chem/contributors","subscribers_url":"https://api.github.com/repos/geoschem/geos-chem/subscribers","subscription_url":"https://api.github.com/repos/geoschem/geos-chem/subscription","commits_url":"https://api.github.com/repos/geoschem/geos-chem/commits{/sha}","git_commits_url":"https://api.github.com/repos/geoschem/geos-chem/git/commits{/sha}","comments_url":"https://api.github.com/repos/geoschem/geos-chem/comments{/number}","issue_comment_url":"https://api.github.com/repos/geoschem/geos-chem/issues/comments{/number}","contents_url":"https://api.github.com/repos/geoschem/geos-chem/contents/{+path}","compare_url":"https://api.github.com/repos/geoschem/geos-chem/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geoschem/geos-chem/merges","archive_url":"https://api.github.com/repos/geoschem/geos-chem/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geoschem/geos-chem/downloads","issues_url":"https://api.github.com/repos/geoschem/geos-chem/issues{/number}","pulls_url":"https://api.github.com/repos/geoschem/geos-chem/pulls{/number}","milestones_url":"https://api.github.com/repos/geoschem/geos-chem/milestones{/number}","notifications_url":"https://api.github.com/repos/geoschem/geos-chem/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geoschem/geos-chem/labels{/name}","releases_url":"https://api.github.com/repos/geoschem/geos-chem/releases{/id}","deployments_url":"https://api.github.com/repos/geoschem/geos-chem/deployments","created_at":"2018-06-19T16:55:12Z","updated_at":"2018-08-07T15:37:16Z","pushed_at":"2018-08-07T20:35:46Z","git_url":"git://github.com/geoschem/geos-chem.git","ssh_url":"git@github.com:geoschem/geos-chem.git","clone_url":"https://github.com/geoschem/geos-chem.git","svn_url":"https://github.com/geoschem/geos-chem","homepage":null,"size":53911,"stargazers_count":11,"watchers_count":11,"language":"Fortran","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3,"open_issues":1,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/geoschem/geos-chem/pulls/4"},"html":{"href":"https://github.com/geoschem/geos-chem/pull/4"},"issue":{"href":"https://api.github.com/repos/geoschem/geos-chem/issues/4"},"comments":{"href":"https://api.github.com/repos/geoschem/geos-chem/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/geoschem/geos-chem/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/geoschem/geos-chem/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/geoschem/geos-chem/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/geoschem/geos-chem/statuses/ab6a0c5c848891f7b540a78567876fa2d543d7b6"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":61,"deletions":26,"changed_files":7}}
{"actor":{"display_login":"jimmielin"}}