{"action":"created","comment":{"url":"https://api.github.com/repos/metoppv/improver/pulls/comments/197840361","pull_request_review_id":131662142,"id":197840361,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Nzg0MDM2MQ==","diff_hunk":"@@ -103,90 +103,130 @@ def setUp(self):\n                                              [1.0, np.nan, 2.0],\n                                              [1.0, 2.0, np.nan]])\n         self.orog = np.ones((3, 3))\n-        self.land_sea = np.ones((3, 3))\n         self.highest_wb_int = np.ones((3, 3))\n         self.highest_height = 300.0\n \n     def test_basic(self):\n-        \"\"\"Test method returns an array with correct data\"\"\"\n+        \"\"\"Test fills in missing data with orography + highest height\"\"\"\n         plugin = FallingSnowLevel()\n+        self.highest_wb_int[1, 1] = 100.0\n         expected = np.array([[1.0, 1.0, 2.0],\n-                             [1.0, 1.5, 2.0],\n+                             [1.0, 301.0, 2.0],\n                              [1.0, 2.0, 2.0]])\n-        result = plugin.fill_in_missing_data(self.snow_level_data,\n-                                             self.orog, self.land_sea,\n-                                             self.highest_wb_int,\n-                                             self.highest_height)\n-        self.assertIsInstance(result, np.ndarray)\n-        self.assertArrayEqual(result, expected)\n-\n-    def test_freezing_sealevel_point(self):\n-        \"\"\"Test sea point with integral below threshold sets snow level to 0\"\"\"\n+        plugin.fill_in_high_snow_falling_levels(\n+            self.snow_level_data, self.orog, self.highest_wb_int,\n+            self.highest_height)\n+        self.assertArrayEqual(self.snow_level_data, expected)\n+\n+    def test_no_fill_if_conditions_not_met(self):\n+        \"\"\"Test it doesn't fill in NaN if the heighest wet bulb integral value\n+           is less the than theshold.\"\"\"","path":"lib/improver/tests/psychrometric_calculations/psychrometric_calculations/test_FallingSnowLevel.py","position":null,"original_position":45,"commit_id":"281fb0aa9b588b47a56d68545e0a8cb7b5882eec","original_commit_id":"82d12437411695797ded7dd197c600c31ee2a497","user":{"login":"fionaRust","id":16209648,"node_id":"MDQ6VXNlcjE2MjA5NjQ4","avatar_url":"https://avatars3.githubusercontent.com/u/16209648?v=4","gravatar_id":"","url":"https://api.github.com/users/fionaRust","html_url":"https://github.com/fionaRust","followers_url":"https://api.github.com/users/fionaRust/followers","following_url":"https://api.github.com/users/fionaRust/following{/other_user}","gists_url":"https://api.github.com/users/fionaRust/gists{/gist_id}","starred_url":"https://api.github.com/users/fionaRust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fionaRust/subscriptions","organizations_url":"https://api.github.com/users/fionaRust/orgs","repos_url":"https://api.github.com/users/fionaRust/repos","events_url":"https://api.github.com/users/fionaRust/events{/privacy}","received_events_url":"https://api.github.com/users/fionaRust/received_events","type":"User","site_admin":false},"body":"Fixed :)","created_at":"2018-06-25T15:30:45Z","updated_at":"2018-06-25T15:30:45Z","html_url":"https://github.com/metoppv/improver/pull/587#discussion_r197840361","pull_request_url":"https://api.github.com/repos/metoppv/improver/pulls/587","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/metoppv/improver/pulls/comments/197840361"},"html":{"href":"https://github.com/metoppv/improver/pull/587#discussion_r197840361"},"pull_request":{"href":"https://api.github.com/repos/metoppv/improver/pulls/587"}},"in_reply_to_id":197797602},"pull_request":{"url":"https://api.github.com/repos/metoppv/improver/pulls/587","id":197055345,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3MDU1MzQ1","html_url":"https://github.com/metoppv/improver/pull/587","diff_url":"https://github.com/metoppv/improver/pull/587.diff","patch_url":"https://github.com/metoppv/improver/pull/587.patch","issue_url":"https://api.github.com/repos/metoppv/improver/issues/587","number":587,"state":"open","locked":false,"title":"Refactored to allow for separate filling functions","user":{"login":"fionaRust","id":16209648,"node_id":"MDQ6VXNlcjE2MjA5NjQ4","avatar_url":"https://avatars3.githubusercontent.com/u/16209648?v=4","gravatar_id":"","url":"https://api.github.com/users/fionaRust","html_url":"https://github.com/fionaRust","followers_url":"https://api.github.com/users/fionaRust/followers","following_url":"https://api.github.com/users/fionaRust/following{/other_user}","gists_url":"https://api.github.com/users/fionaRust/gists{/gist_id}","starred_url":"https://api.github.com/users/fionaRust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fionaRust/subscriptions","organizations_url":"https://api.github.com/users/fionaRust/orgs","repos_url":"https://api.github.com/users/fionaRust/repos","events_url":"https://api.github.com/users/fionaRust/events{/privacy}","received_events_url":"https://api.github.com/users/fionaRust/received_events","type":"User","site_admin":false},"body":"Addresses #586 \r\n\r\nRefactors the filling function into separate steps so each one can be modified separately. This change doesn't add any new functionality.\r\nThe .process unit tests are unchanged, as is the CLI test data.\r\n\r\nTesting:\r\n - [ ] Ran tests and they passed OK\r\n - [ ] Added new tests for the new feature(s)\r\n\r\nCLA\r\n - [ ] If a new developer, signed up to CLA\r\n","created_at":"2018-06-25T09:39:14Z","updated_at":"2018-06-25T15:30:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"176059fd65f1585b1114b905c4459919228b83aa","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/metoppv/improver/pulls/587/commits","review_comments_url":"https://api.github.com/repos/metoppv/improver/pulls/587/comments","review_comment_url":"https://api.github.com/repos/metoppv/improver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/metoppv/improver/issues/587/comments","statuses_url":"https://api.github.com/repos/metoppv/improver/statuses/281fb0aa9b588b47a56d68545e0a8cb7b5882eec","head":{"label":"fionaRust:IMPRO-621_snow_refactor","ref":"IMPRO-621_snow_refactor","sha":"281fb0aa9b588b47a56d68545e0a8cb7b5882eec","user":{"login":"fionaRust","id":16209648,"node_id":"MDQ6VXNlcjE2MjA5NjQ4","avatar_url":"https://avatars3.githubusercontent.com/u/16209648?v=4","gravatar_id":"","url":"https://api.github.com/users/fionaRust","html_url":"https://github.com/fionaRust","followers_url":"https://api.github.com/users/fionaRust/followers","following_url":"https://api.github.com/users/fionaRust/following{/other_user}","gists_url":"https://api.github.com/users/fionaRust/gists{/gist_id}","starred_url":"https://api.github.com/users/fionaRust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fionaRust/subscriptions","organizations_url":"https://api.github.com/users/fionaRust/orgs","repos_url":"https://api.github.com/users/fionaRust/repos","events_url":"https://api.github.com/users/fionaRust/events{/privacy}","received_events_url":"https://api.github.com/users/fionaRust/received_events","type":"User","site_admin":false},"repo":{"id":89597531,"node_id":"MDEwOlJlcG9zaXRvcnk4OTU5NzUzMQ==","name":"improver","full_name":"fionaRust/improver","owner":{"login":"fionaRust","id":16209648,"node_id":"MDQ6VXNlcjE2MjA5NjQ4","avatar_url":"https://avatars3.githubusercontent.com/u/16209648?v=4","gravatar_id":"","url":"https://api.github.com/users/fionaRust","html_url":"https://github.com/fionaRust","followers_url":"https://api.github.com/users/fionaRust/followers","following_url":"https://api.github.com/users/fionaRust/following{/other_user}","gists_url":"https://api.github.com/users/fionaRust/gists{/gist_id}","starred_url":"https://api.github.com/users/fionaRust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fionaRust/subscriptions","organizations_url":"https://api.github.com/users/fionaRust/orgs","repos_url":"https://api.github.com/users/fionaRust/repos","events_url":"https://api.github.com/users/fionaRust/events{/privacy}","received_events_url":"https://api.github.com/users/fionaRust/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fionaRust/improver","description":"IMPROVER","fork":true,"url":"https://api.github.com/repos/fionaRust/improver","forks_url":"https://api.github.com/repos/fionaRust/improver/forks","keys_url":"https://api.github.com/repos/fionaRust/improver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fionaRust/improver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fionaRust/improver/teams","hooks_url":"https://api.github.com/repos/fionaRust/improver/hooks","issue_events_url":"https://api.github.com/repos/fionaRust/improver/issues/events{/number}","events_url":"https://api.github.com/repos/fionaRust/improver/events","assignees_url":"https://api.github.com/repos/fionaRust/improver/assignees{/user}","branches_url":"https://api.github.com/repos/fionaRust/improver/branches{/branch}","tags_url":"https://api.github.com/repos/fionaRust/improver/tags","blobs_url":"https://api.github.com/repos/fionaRust/improver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fionaRust/improver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fionaRust/improver/git/refs{/sha}","trees_url":"https://api.github.com/repos/fionaRust/improver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fionaRust/improver/statuses/{sha}","languages_url":"https://api.github.com/repos/fionaRust/improver/languages","stargazers_url":"https://api.github.com/repos/fionaRust/improver/stargazers","contributors_url":"https://api.github.com/repos/fionaRust/improver/contributors","subscribers_url":"https://api.github.com/repos/fionaRust/improver/subscribers","subscription_url":"https://api.github.com/repos/fionaRust/improver/subscription","commits_url":"https://api.github.com/repos/fionaRust/improver/commits{/sha}","git_commits_url":"https://api.github.com/repos/fionaRust/improver/git/commits{/sha}","comments_url":"https://api.github.com/repos/fionaRust/improver/comments{/number}","issue_comment_url":"https://api.github.com/repos/fionaRust/improver/issues/comments{/number}","contents_url":"https://api.github.com/repos/fionaRust/improver/contents/{+path}","compare_url":"https://api.github.com/repos/fionaRust/improver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fionaRust/improver/merges","archive_url":"https://api.github.com/repos/fionaRust/improver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fionaRust/improver/downloads","issues_url":"https://api.github.com/repos/fionaRust/improver/issues{/number}","pulls_url":"https://api.github.com/repos/fionaRust/improver/pulls{/number}","milestones_url":"https://api.github.com/repos/fionaRust/improver/milestones{/number}","notifications_url":"https://api.github.com/repos/fionaRust/improver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fionaRust/improver/labels{/name}","releases_url":"https://api.github.com/repos/fionaRust/improver/releases{/id}","deployments_url":"https://api.github.com/repos/fionaRust/improver/deployments","created_at":"2017-04-27T12:57:44Z","updated_at":"2018-05-23T13:19:24Z","pushed_at":"2018-06-25T15:30:26Z","git_url":"git://github.com/fionaRust/improver.git","ssh_url":"git@github.com:fionaRust/improver.git","clone_url":"https://github.com/fionaRust/improver.git","svn_url":"https://github.com/fionaRust/improver","homepage":null,"size":3589,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"metoppv:master","ref":"master","sha":"6bba5c64c324c00c13f593e8e2191af79efbd169","user":{"login":"metoppv","id":26465485,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2NDY1NDg1","avatar_url":"https://avatars2.githubusercontent.com/u/26465485?v=4","gravatar_id":"","url":"https://api.github.com/users/metoppv","html_url":"https://github.com/metoppv","followers_url":"https://api.github.com/users/metoppv/followers","following_url":"https://api.github.com/users/metoppv/following{/other_user}","gists_url":"https://api.github.com/users/metoppv/gists{/gist_id}","starred_url":"https://api.github.com/users/metoppv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metoppv/subscriptions","organizations_url":"https://api.github.com/users/metoppv/orgs","repos_url":"https://api.github.com/users/metoppv/repos","events_url":"https://api.github.com/users/metoppv/events{/privacy}","received_events_url":"https://api.github.com/users/metoppv/received_events","type":"Organization","site_admin":false},"repo":{"id":85334761,"node_id":"MDEwOlJlcG9zaXRvcnk4NTMzNDc2MQ==","name":"improver","full_name":"metoppv/improver","owner":{"login":"metoppv","id":26465485,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2NDY1NDg1","avatar_url":"https://avatars2.githubusercontent.com/u/26465485?v=4","gravatar_id":"","url":"https://api.github.com/users/metoppv","html_url":"https://github.com/metoppv","followers_url":"https://api.github.com/users/metoppv/followers","following_url":"https://api.github.com/users/metoppv/following{/other_user}","gists_url":"https://api.github.com/users/metoppv/gists{/gist_id}","starred_url":"https://api.github.com/users/metoppv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metoppv/subscriptions","organizations_url":"https://api.github.com/users/metoppv/orgs","repos_url":"https://api.github.com/users/metoppv/repos","events_url":"https://api.github.com/users/metoppv/events{/privacy}","received_events_url":"https://api.github.com/users/metoppv/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/metoppv/improver","description":"IMPROVER is a library of algorithms for meteorological post-processing and verification.","fork":false,"url":"https://api.github.com/repos/metoppv/improver","forks_url":"https://api.github.com/repos/metoppv/improver/forks","keys_url":"https://api.github.com/repos/metoppv/improver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/metoppv/improver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/metoppv/improver/teams","hooks_url":"https://api.github.com/repos/metoppv/improver/hooks","issue_events_url":"https://api.github.com/repos/metoppv/improver/issues/events{/number}","events_url":"https://api.github.com/repos/metoppv/improver/events","assignees_url":"https://api.github.com/repos/metoppv/improver/assignees{/user}","branches_url":"https://api.github.com/repos/metoppv/improver/branches{/branch}","tags_url":"https://api.github.com/repos/metoppv/improver/tags","blobs_url":"https://api.github.com/repos/metoppv/improver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/metoppv/improver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/metoppv/improver/git/refs{/sha}","trees_url":"https://api.github.com/repos/metoppv/improver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/metoppv/improver/statuses/{sha}","languages_url":"https://api.github.com/repos/metoppv/improver/languages","stargazers_url":"https://api.github.com/repos/metoppv/improver/stargazers","contributors_url":"https://api.github.com/repos/metoppv/improver/contributors","subscribers_url":"https://api.github.com/repos/metoppv/improver/subscribers","subscription_url":"https://api.github.com/repos/metoppv/improver/subscription","commits_url":"https://api.github.com/repos/metoppv/improver/commits{/sha}","git_commits_url":"https://api.github.com/repos/metoppv/improver/git/commits{/sha}","comments_url":"https://api.github.com/repos/metoppv/improver/comments{/number}","issue_comment_url":"https://api.github.com/repos/metoppv/improver/issues/comments{/number}","contents_url":"https://api.github.com/repos/metoppv/improver/contents/{+path}","compare_url":"https://api.github.com/repos/metoppv/improver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/metoppv/improver/merges","archive_url":"https://api.github.com/repos/metoppv/improver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/metoppv/improver/downloads","issues_url":"https://api.github.com/repos/metoppv/improver/issues{/number}","pulls_url":"https://api.github.com/repos/metoppv/improver/pulls{/number}","milestones_url":"https://api.github.com/repos/metoppv/improver/milestones{/number}","notifications_url":"https://api.github.com/repos/metoppv/improver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/metoppv/improver/labels{/name}","releases_url":"https://api.github.com/repos/metoppv/improver/releases{/id}","deployments_url":"https://api.github.com/repos/metoppv/improver/deployments","created_at":"2017-03-17T16:51:29Z","updated_at":"2018-06-25T14:51:38Z","pushed_at":"2018-06-25T15:30:28Z","git_url":"git://github.com/metoppv/improver.git","ssh_url":"git@github.com:metoppv/improver.git","clone_url":"https://github.com/metoppv/improver.git","svn_url":"https://github.com/metoppv/improver","homepage":"http://improver.readthedocs.io/en/latest/","size":3533,"stargazers_count":17,"watchers_count":17,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":111,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":28,"open_issues":111,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/metoppv/improver/pulls/587"},"html":{"href":"https://github.com/metoppv/improver/pull/587"},"issue":{"href":"https://api.github.com/repos/metoppv/improver/issues/587"},"comments":{"href":"https://api.github.com/repos/metoppv/improver/issues/587/comments"},"review_comments":{"href":"https://api.github.com/repos/metoppv/improver/pulls/587/comments"},"review_comment":{"href":"https://api.github.com/repos/metoppv/improver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/metoppv/improver/pulls/587/commits"},"statuses":{"href":"https://api.github.com/repos/metoppv/improver/statuses/281fb0aa9b588b47a56d68545e0a8cb7b5882eec"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"fionaRust"}}