{"action":"created","issue":{"url":"https://api.github.com/repos/jupyter/notebook/issues/3942","repository_url":"https://api.github.com/repos/jupyter/notebook","labels_url":"https://api.github.com/repos/jupyter/notebook/issues/3942/labels{/name}","comments_url":"https://api.github.com/repos/jupyter/notebook/issues/3942/comments","events_url":"https://api.github.com/repos/jupyter/notebook/issues/3942/events","html_url":"https://github.com/jupyter/notebook/pull/3942","id":361787375,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2NjY5Mjkx","number":3942,"title":"[WIP] use Accept-Language header in jinja templates","user":{"login":"minrk","id":151929,"node_id":"MDQ6VXNlcjE1MTkyOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/151929?v=4","gravatar_id":"","url":"https://api.github.com/users/minrk","html_url":"https://github.com/minrk","followers_url":"https://api.github.com/users/minrk/followers","following_url":"https://api.github.com/users/minrk/following{/other_user}","gists_url":"https://api.github.com/users/minrk/gists{/gist_id}","starred_url":"https://api.github.com/users/minrk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minrk/subscriptions","organizations_url":"https://api.github.com/users/minrk/orgs","repos_url":"https://api.github.com/users/minrk/repos","events_url":"https://api.github.com/users/minrk/events{/privacy}","received_events_url":"https://api.github.com/users/minrk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-19T14:52:24Z","updated_at":"2018-11-07T13:12:56Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/jupyter/notebook/pulls/3942","html_url":"https://github.com/jupyter/notebook/pull/3942","diff_url":"https://github.com/jupyter/notebook/pull/3942.diff","patch_url":"https://github.com/jupyter/notebook/pull/3942.patch"},"body":"solves translation issue where jinja used server-side LANG environment and javascript used browser configuration via the Accept-Language header, which could result in multiple languages on the page. Now, all browser messages should be consistent with the browser settings.\n\nIntroduces caching of gettext translation objects to ensure that we don't keep loading the translation config on every request.\n\ncc @JCEmmons\n\nTODO:\n\n- selenium test with Accept-Language header to verify that it's loading the right thing (verified manually, but we should have a real test)"},"comment":{"url":"https://api.github.com/repos/jupyter/notebook/issues/comments/436618101","html_url":"https://github.com/jupyter/notebook/pull/3942#issuecomment-436618101","issue_url":"https://api.github.com/repos/jupyter/notebook/issues/3942","id":436618101,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNjYxODEwMQ==","user":{"login":"takluyver","id":327925,"node_id":"MDQ6VXNlcjMyNzkyNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/327925?v=4","gravatar_id":"","url":"https://api.github.com/users/takluyver","html_url":"https://github.com/takluyver","followers_url":"https://api.github.com/users/takluyver/followers","following_url":"https://api.github.com/users/takluyver/following{/other_user}","gists_url":"https://api.github.com/users/takluyver/gists{/gist_id}","starred_url":"https://api.github.com/users/takluyver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/takluyver/subscriptions","organizations_url":"https://api.github.com/users/takluyver/orgs","repos_url":"https://api.github.com/users/takluyver/repos","events_url":"https://api.github.com/users/takluyver/events{/privacy}","received_events_url":"https://api.github.com/users/takluyver/received_events","type":"User","site_admin":false},"created_at":"2018-11-07T13:12:56Z","updated_at":"2018-11-07T13:12:56Z","author_association":"MEMBER","body":"This has a merge conflict now, if you have time to rebase it."}}
{"actor":{"display_login":"takluyver"}}