{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/30448","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/30448/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/30448/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/30448/events","html_url":"https://github.com/cockroachdb/cockroach/pull/30448","id":362005122,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2ODM0ODQ5","number":30448,"title":"kv: assorted client optimizations","user":{"login":"andreimatei","id":377201,"node_id":"MDQ6VXNlcjM3NzIwMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/377201?v=4","gravatar_id":"","url":"https://api.github.com/users/andreimatei","html_url":"https://github.com/andreimatei","followers_url":"https://api.github.com/users/andreimatei/followers","following_url":"https://api.github.com/users/andreimatei/following{/other_user}","gists_url":"https://api.github.com/users/andreimatei/gists{/gist_id}","starred_url":"https://api.github.com/users/andreimatei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreimatei/subscriptions","organizations_url":"https://api.github.com/users/andreimatei/orgs","repos_url":"https://api.github.com/users/andreimatei/repos","events_url":"https://api.github.com/users/andreimatei/events{/privacy}","received_events_url":"https://api.github.com/users/andreimatei/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"nvanbenschoten","id":5438456,"node_id":"MDQ6VXNlcjU0Mzg0NTY=","avatar_url":"https://avatars3.githubusercontent.com/u/5438456?v=4","gravatar_id":"","url":"https://api.github.com/users/nvanbenschoten","html_url":"https://github.com/nvanbenschoten","followers_url":"https://api.github.com/users/nvanbenschoten/followers","following_url":"https://api.github.com/users/nvanbenschoten/following{/other_user}","gists_url":"https://api.github.com/users/nvanbenschoten/gists{/gist_id}","starred_url":"https://api.github.com/users/nvanbenschoten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvanbenschoten/subscriptions","organizations_url":"https://api.github.com/users/nvanbenschoten/orgs","repos_url":"https://api.github.com/users/nvanbenschoten/repos","events_url":"https://api.github.com/users/nvanbenschoten/events{/privacy}","received_events_url":"https://api.github.com/users/nvanbenschoten/received_events","type":"User","site_admin":false},"assignees":[{"login":"nvanbenschoten","id":5438456,"node_id":"MDQ6VXNlcjU0Mzg0NTY=","avatar_url":"https://avatars3.githubusercontent.com/u/5438456?v=4","gravatar_id":"","url":"https://api.github.com/users/nvanbenschoten","html_url":"https://github.com/nvanbenschoten","followers_url":"https://api.github.com/users/nvanbenschoten/followers","following_url":"https://api.github.com/users/nvanbenschoten/following{/other_user}","gists_url":"https://api.github.com/users/nvanbenschoten/gists{/gist_id}","starred_url":"https://api.github.com/users/nvanbenschoten/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvanbenschoten/subscriptions","organizations_url":"https://api.github.com/users/nvanbenschoten/orgs","repos_url":"https://api.github.com/users/nvanbenschoten/repos","events_url":"https://api.github.com/users/nvanbenschoten/events{/privacy}","received_events_url":"https://api.github.com/users/nvanbenschoten/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-09-20T03:30:41Z","updated_at":"2018-09-20T03:31:08Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/30448","html_url":"https://github.com/cockroachdb/cockroach/pull/30448","diff_url":"https://github.com/cockroachdb/cockroach/pull/30448.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/30448.patch"},"body":"See individual commits.\r\n\r\nThis PR increases throughput on a single node kv-95 workload as follows (measured on a 96-core GCE machine and running the client with concurrency=48).\r\n```\r\n_elapsed___errors_____ops(total)___ops/sec(cum)__avg(ms)__p50(ms)__p95(ms)__p99(ms)_pMax(ms)__total\r\n  100.0s        0        1257869        12578.5      2.8      3.3      5.5      7.1     48.2  read\r\n  100.0s        0          66469          664.7     19.5     19.9     31.5     35.7     60.8  write\r\n```\r\nto\r\n```\r\n_elapsed___errors_____ops(total)___ops/sec(cum)__avg(ms)__p50(ms)__p95(ms)__p99(ms)_pMax(ms)__total\r\n  100.0s        0        1369178        13691.4      2.5      2.8      5.2      6.8    503.3  read\r\n  100.0s        0          71850          718.5     18.3     18.9     28.3     33.6    520.1  write\r\n```\r\n\r\nThe PR also takes away about 3/4 of the performance regression introduced in #28185. See #30208 for more."},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/423028800","html_url":"https://github.com/cockroachdb/cockroach/pull/30448#issuecomment-423028800","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/30448","id":423028800,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMzAyODgwMA==","user":{"login":"andreimatei","id":377201,"node_id":"MDQ6VXNlcjM3NzIwMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/377201?v=4","gravatar_id":"","url":"https://api.github.com/users/andreimatei","html_url":"https://github.com/andreimatei","followers_url":"https://api.github.com/users/andreimatei/followers","following_url":"https://api.github.com/users/andreimatei/following{/other_user}","gists_url":"https://api.github.com/users/andreimatei/gists{/gist_id}","starred_url":"https://api.github.com/users/andreimatei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreimatei/subscriptions","organizations_url":"https://api.github.com/users/andreimatei/orgs","repos_url":"https://api.github.com/users/andreimatei/repos","events_url":"https://api.github.com/users/andreimatei/events{/privacy}","received_events_url":"https://api.github.com/users/andreimatei/received_events","type":"User","site_admin":false},"created_at":"2018-09-20T03:31:08Z","updated_at":"2018-09-20T03:31:08Z","author_association":"MEMBER","body":"cc @jordanlewis "}}
{"actor":{"display_login":"andreimatei"}}