{"action":"created","comment":{"url":"https://api.github.com/repos/apache/geode/pulls/comments/165234943","pull_request_review_id":93139537,"id":165234943,"diff_hunk":"@@ -38,6 +38,9 @@ public ProtobufSerializationService() {}\n   @Override\n   public BasicTypes.EncodedValue encode(Object value) throws EncodingException {\n     BasicTypes.EncodedValue.Builder builder = BasicTypes.EncodedValue.newBuilder();\n+    if (value == null) {\n+      return builder.build();","path":"geode-protobuf/src/main/java/org/apache/geode/internal/protocol/protobuf/v1/ProtobufSerializationService.java","position":5,"original_position":5,"commit_id":"291efe610e69dd5efbd2b0275a49fe8b4caee00e","original_commit_id":"67946a37925102745a3cb412a8863244d7658c3b","user":{"login":"galen-pivotal","id":22917714,"avatar_url":"https://avatars1.githubusercontent.com/u/22917714?v=4","gravatar_id":"","url":"https://api.github.com/users/galen-pivotal","html_url":"https://github.com/galen-pivotal","followers_url":"https://api.github.com/users/galen-pivotal/followers","following_url":"https://api.github.com/users/galen-pivotal/following{/other_user}","gists_url":"https://api.github.com/users/galen-pivotal/gists{/gist_id}","starred_url":"https://api.github.com/users/galen-pivotal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galen-pivotal/subscriptions","organizations_url":"https://api.github.com/users/galen-pivotal/orgs","repos_url":"https://api.github.com/users/galen-pivotal/repos","events_url":"https://api.github.com/users/galen-pivotal/events{/privacy}","received_events_url":"https://api.github.com/users/galen-pivotal/received_events","type":"User","site_admin":false},"body":"good idea.","created_at":"2018-02-01T01:04:41Z","updated_at":"2018-02-01T01:04:41Z","html_url":"https://github.com/apache/geode/pull/1357#discussion_r165234943","pull_request_url":"https://api.github.com/repos/apache/geode/pulls/1357","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/geode/pulls/comments/165234943"},"html":{"href":"https://github.com/apache/geode/pull/1357#discussion_r165234943"},"pull_request":{"href":"https://api.github.com/repos/apache/geode/pulls/1357"}},"in_reply_to_id":165154568},"pull_request":{"url":"https://api.github.com/repos/apache/geode/pulls/1357","id":165836853,"html_url":"https://github.com/apache/geode/pull/1357","diff_url":"https://github.com/apache/geode/pull/1357.diff","patch_url":"https://github.com/apache/geode/pull/1357.patch","issue_url":"https://api.github.com/repos/apache/geode/issues/1357","number":1357,"state":"open","locked":false,"title":"GEODE-3127: add function execution to new client protocol.","user":{"login":"galen-pivotal","id":22917714,"avatar_url":"https://avatars1.githubusercontent.com/u/22917714?v=4","gravatar_id":"","url":"https://api.github.com/users/galen-pivotal","html_url":"https://github.com/galen-pivotal","followers_url":"https://api.github.com/users/galen-pivotal/followers","following_url":"https://api.github.com/users/galen-pivotal/following{/other_user}","gists_url":"https://api.github.com/users/galen-pivotal/gists{/gist_id}","starred_url":"https://api.github.com/users/galen-pivotal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galen-pivotal/subscriptions","organizations_url":"https://api.github.com/users/galen-pivotal/orgs","repos_url":"https://api.github.com/users/galen-pivotal/repos","events_url":"https://api.github.com/users/galen-pivotal/events{/privacy}","received_events_url":"https://api.github.com/users/galen-pivotal/received_events","type":"User","site_admin":false},"body":"This only supports function execution on a region so far. It assumes the\r\ndefault result collector, which returns a list of results.\r\n\r\n* MessageExecutionContext uses InternalCache instead of Cache\r\n* Remove super.setUp calls from operation handlers because the\r\n  @Before annotation already ensures these are called before the\r\n  @Before methods of child classes.\r\n\r\nFor review, I'm particularly interested in what edge cases I may have missed.","created_at":"2018-01-29T22:32:19Z","updated_at":"2018-02-01T01:04:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"58ecf5984df2e1c5d1149a3608ff66cd7651313c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jhuynh1","id":5750994,"avatar_url":"https://avatars0.githubusercontent.com/u/5750994?v=4","gravatar_id":"","url":"https://api.github.com/users/jhuynh1","html_url":"https://github.com/jhuynh1","followers_url":"https://api.github.com/users/jhuynh1/followers","following_url":"https://api.github.com/users/jhuynh1/following{/other_user}","gists_url":"https://api.github.com/users/jhuynh1/gists{/gist_id}","starred_url":"https://api.github.com/users/jhuynh1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhuynh1/subscriptions","organizations_url":"https://api.github.com/users/jhuynh1/orgs","repos_url":"https://api.github.com/users/jhuynh1/repos","events_url":"https://api.github.com/users/jhuynh1/events{/privacy}","received_events_url":"https://api.github.com/users/jhuynh1/received_events","type":"User","site_admin":false},{"login":"bschuchardt","id":7441204,"avatar_url":"https://avatars1.githubusercontent.com/u/7441204?v=4","gravatar_id":"","url":"https://api.github.com/users/bschuchardt","html_url":"https://github.com/bschuchardt","followers_url":"https://api.github.com/users/bschuchardt/followers","following_url":"https://api.github.com/users/bschuchardt/following{/other_user}","gists_url":"https://api.github.com/users/bschuchardt/gists{/gist_id}","starred_url":"https://api.github.com/users/bschuchardt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bschuchardt/subscriptions","organizations_url":"https://api.github.com/users/bschuchardt/orgs","repos_url":"https://api.github.com/users/bschuchardt/repos","events_url":"https://api.github.com/users/bschuchardt/events{/privacy}","received_events_url":"https://api.github.com/users/bschuchardt/received_events","type":"User","site_admin":false}],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/geode/pulls/1357/commits","review_comments_url":"https://api.github.com/repos/apache/geode/pulls/1357/comments","review_comment_url":"https://api.github.com/repos/apache/geode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/geode/issues/1357/comments","statuses_url":"https://api.github.com/repos/apache/geode/statuses/291efe610e69dd5efbd2b0275a49fe8b4caee00e","head":{"label":"galen-pivotal:feature/GEODE-3127","ref":"feature/GEODE-3127","sha":"291efe610e69dd5efbd2b0275a49fe8b4caee00e","user":{"login":"galen-pivotal","id":22917714,"avatar_url":"https://avatars1.githubusercontent.com/u/22917714?v=4","gravatar_id":"","url":"https://api.github.com/users/galen-pivotal","html_url":"https://github.com/galen-pivotal","followers_url":"https://api.github.com/users/galen-pivotal/followers","following_url":"https://api.github.com/users/galen-pivotal/following{/other_user}","gists_url":"https://api.github.com/users/galen-pivotal/gists{/gist_id}","starred_url":"https://api.github.com/users/galen-pivotal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galen-pivotal/subscriptions","organizations_url":"https://api.github.com/users/galen-pivotal/orgs","repos_url":"https://api.github.com/users/galen-pivotal/repos","events_url":"https://api.github.com/users/galen-pivotal/events{/privacy}","received_events_url":"https://api.github.com/users/galen-pivotal/received_events","type":"User","site_admin":false},"repo":{"id":75438678,"name":"geode","full_name":"galen-pivotal/geode","owner":{"login":"galen-pivotal","id":22917714,"avatar_url":"https://avatars1.githubusercontent.com/u/22917714?v=4","gravatar_id":"","url":"https://api.github.com/users/galen-pivotal","html_url":"https://github.com/galen-pivotal","followers_url":"https://api.github.com/users/galen-pivotal/followers","following_url":"https://api.github.com/users/galen-pivotal/following{/other_user}","gists_url":"https://api.github.com/users/galen-pivotal/gists{/gist_id}","starred_url":"https://api.github.com/users/galen-pivotal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galen-pivotal/subscriptions","organizations_url":"https://api.github.com/users/galen-pivotal/orgs","repos_url":"https://api.github.com/users/galen-pivotal/repos","events_url":"https://api.github.com/users/galen-pivotal/events{/privacy}","received_events_url":"https://api.github.com/users/galen-pivotal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/galen-pivotal/geode","description":"Mirror of Apache Geode","fork":true,"url":"https://api.github.com/repos/galen-pivotal/geode","forks_url":"https://api.github.com/repos/galen-pivotal/geode/forks","keys_url":"https://api.github.com/repos/galen-pivotal/geode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/galen-pivotal/geode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/galen-pivotal/geode/teams","hooks_url":"https://api.github.com/repos/galen-pivotal/geode/hooks","issue_events_url":"https://api.github.com/repos/galen-pivotal/geode/issues/events{/number}","events_url":"https://api.github.com/repos/galen-pivotal/geode/events","assignees_url":"https://api.github.com/repos/galen-pivotal/geode/assignees{/user}","branches_url":"https://api.github.com/repos/galen-pivotal/geode/branches{/branch}","tags_url":"https://api.github.com/repos/galen-pivotal/geode/tags","blobs_url":"https://api.github.com/repos/galen-pivotal/geode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/galen-pivotal/geode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/galen-pivotal/geode/git/refs{/sha}","trees_url":"https://api.github.com/repos/galen-pivotal/geode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/galen-pivotal/geode/statuses/{sha}","languages_url":"https://api.github.com/repos/galen-pivotal/geode/languages","stargazers_url":"https://api.github.com/repos/galen-pivotal/geode/stargazers","contributors_url":"https://api.github.com/repos/galen-pivotal/geode/contributors","subscribers_url":"https://api.github.com/repos/galen-pivotal/geode/subscribers","subscription_url":"https://api.github.com/repos/galen-pivotal/geode/subscription","commits_url":"https://api.github.com/repos/galen-pivotal/geode/commits{/sha}","git_commits_url":"https://api.github.com/repos/galen-pivotal/geode/git/commits{/sha}","comments_url":"https://api.github.com/repos/galen-pivotal/geode/comments{/number}","issue_comment_url":"https://api.github.com/repos/galen-pivotal/geode/issues/comments{/number}","contents_url":"https://api.github.com/repos/galen-pivotal/geode/contents/{+path}","compare_url":"https://api.github.com/repos/galen-pivotal/geode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/galen-pivotal/geode/merges","archive_url":"https://api.github.com/repos/galen-pivotal/geode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/galen-pivotal/geode/downloads","issues_url":"https://api.github.com/repos/galen-pivotal/geode/issues{/number}","pulls_url":"https://api.github.com/repos/galen-pivotal/geode/pulls{/number}","milestones_url":"https://api.github.com/repos/galen-pivotal/geode/milestones{/number}","notifications_url":"https://api.github.com/repos/galen-pivotal/geode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/galen-pivotal/geode/labels{/name}","releases_url":"https://api.github.com/repos/galen-pivotal/geode/releases{/id}","deployments_url":"https://api.github.com/repos/galen-pivotal/geode/deployments","created_at":"2016-12-02T23:21:54Z","updated_at":"2017-09-05T16:45:44Z","pushed_at":"2018-02-01T00:37:10Z","git_url":"git://github.com/galen-pivotal/geode.git","ssh_url":"git@github.com:galen-pivotal/geode.git","clone_url":"https://github.com/galen-pivotal/geode.git","svn_url":"https://github.com/galen-pivotal/geode","homepage":"","size":149274,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":1,"default_branch":"develop"}},"base":{"label":"apache:develop","ref":"develop","sha":"4a7514883515ed804b6c5e905e11627395036db9","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":34839383,"name":"geode","full_name":"apache/geode","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/geode","description":"Apache Geode","fork":false,"url":"https://api.github.com/repos/apache/geode","forks_url":"https://api.github.com/repos/apache/geode/forks","keys_url":"https://api.github.com/repos/apache/geode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/geode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/geode/teams","hooks_url":"https://api.github.com/repos/apache/geode/hooks","issue_events_url":"https://api.github.com/repos/apache/geode/issues/events{/number}","events_url":"https://api.github.com/repos/apache/geode/events","assignees_url":"https://api.github.com/repos/apache/geode/assignees{/user}","branches_url":"https://api.github.com/repos/apache/geode/branches{/branch}","tags_url":"https://api.github.com/repos/apache/geode/tags","blobs_url":"https://api.github.com/repos/apache/geode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/geode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/geode/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/geode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/geode/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/geode/languages","stargazers_url":"https://api.github.com/repos/apache/geode/stargazers","contributors_url":"https://api.github.com/repos/apache/geode/contributors","subscribers_url":"https://api.github.com/repos/apache/geode/subscribers","subscription_url":"https://api.github.com/repos/apache/geode/subscription","commits_url":"https://api.github.com/repos/apache/geode/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/geode/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/geode/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/geode/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/geode/contents/{+path}","compare_url":"https://api.github.com/repos/apache/geode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/geode/merges","archive_url":"https://api.github.com/repos/apache/geode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/geode/downloads","issues_url":"https://api.github.com/repos/apache/geode/issues{/number}","pulls_url":"https://api.github.com/repos/apache/geode/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/geode/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/geode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/geode/labels{/name}","releases_url":"https://api.github.com/repos/apache/geode/releases{/id}","deployments_url":"https://api.github.com/repos/apache/geode/deployments","created_at":"2015-04-30T07:00:05Z","updated_at":"2018-01-31T12:47:01Z","pushed_at":"2018-02-01T00:43:14Z","git_url":"git://github.com/apache/geode.git","ssh_url":"git@github.com:apache/geode.git","clone_url":"https://github.com/apache/geode.git","svn_url":"https://github.com/apache/geode","homepage":"","size":146690,"stargazers_count":1140,"watchers_count":1140,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":413,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":413,"open_issues":15,"watchers":1140,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/geode/pulls/1357"},"html":{"href":"https://github.com/apache/geode/pull/1357"},"issue":{"href":"https://api.github.com/repos/apache/geode/issues/1357"},"comments":{"href":"https://api.github.com/repos/apache/geode/issues/1357/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/geode/pulls/1357/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/geode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/geode/pulls/1357/commits"},"statuses":{"href":"https://api.github.com/repos/apache/geode/statuses/291efe610e69dd5efbd2b0275a49fe8b4caee00e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"galen-pivotal"}}