{"action":"created","comment":{"url":"https://api.github.com/repos/OData/WebApi/pulls/comments/203178270","pull_request_review_id":138018224,"id":203178270,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzE3ODI3MA==","diff_hunk":"@@ -598,6 +598,11 @@ private static void AddCoreVocabularyAnnotations(this EdmModel model, IEnumerabl\n \n             IEnumerable<StructuralPropertyConfiguration> concurrencyPropertyies =\n                 entityTypeConfig.Properties.OfType<StructuralPropertyConfiguration>().Where(property => property.ConcurrencyToken);\n+            foreach (var baseType in entityTypeConfig.BaseTypes())\n+            {\n+                concurrencyPropertyies = concurrencyPropertyies.Concat(","path":"src/Microsoft.AspNet.OData.Shared/Builder/EdmModelHelperMethods.cs","position":null,"original_position":6,"commit_id":"1a240d4d7c0589ab4b1a5d1580d9f012e195ff06","original_commit_id":"22a1b97c02650c9ac281682bc2fe323221300d5d","user":{"login":"xuzhg","id":9426627,"node_id":"MDQ6VXNlcjk0MjY2Mjc=","avatar_url":"https://avatars0.githubusercontent.com/u/9426627?v=4","gravatar_id":"","url":"https://api.github.com/users/xuzhg","html_url":"https://github.com/xuzhg","followers_url":"https://api.github.com/users/xuzhg/followers","following_url":"https://api.github.com/users/xuzhg/following{/other_user}","gists_url":"https://api.github.com/users/xuzhg/gists{/gist_id}","starred_url":"https://api.github.com/users/xuzhg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xuzhg/subscriptions","organizations_url":"https://api.github.com/users/xuzhg/orgs","repos_url":"https://api.github.com/users/xuzhg/repos","events_url":"https://api.github.com/users/xuzhg/events{/privacy}","received_events_url":"https://api.github.com/users/xuzhg/received_events","type":"User","site_admin":false},"body":"#fixed.","created_at":"2018-07-17T21:04:51Z","updated_at":"2018-07-17T21:04:51Z","html_url":"https://github.com/OData/WebApi/pull/1537#discussion_r203178270","pull_request_url":"https://api.github.com/repos/OData/WebApi/pulls/1537","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/OData/WebApi/pulls/comments/203178270"},"html":{"href":"https://github.com/OData/WebApi/pull/1537#discussion_r203178270"},"pull_request":{"href":"https://api.github.com/repos/OData/WebApi/pulls/1537"}},"in_reply_to_id":203135144},"pull_request":{"url":"https://api.github.com/repos/OData/WebApi/pulls/1537","id":201795214,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNzk1MjE0","html_url":"https://github.com/OData/WebApi/pull/1537","diff_url":"https://github.com/OData/WebApi/pull/1537.diff","patch_url":"https://github.com/OData/WebApi/pull/1537.patch","issue_url":"https://api.github.com/repos/OData/WebApi/issues/1537","number":1537,"state":"open","locked":false,"title":"Fix issue #1529: ETag missing on derived entity set","user":{"login":"xuzhg","id":9426627,"node_id":"MDQ6VXNlcjk0MjY2Mjc=","avatar_url":"https://avatars0.githubusercontent.com/u/9426627?v=4","gravatar_id":"","url":"https://api.github.com/users/xuzhg","html_url":"https://github.com/xuzhg","followers_url":"https://api.github.com/users/xuzhg/followers","following_url":"https://api.github.com/users/xuzhg/following{/other_user}","gists_url":"https://api.github.com/users/xuzhg/gists{/gist_id}","starred_url":"https://api.github.com/users/xuzhg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xuzhg/subscriptions","organizations_url":"https://api.github.com/users/xuzhg/orgs","repos_url":"https://api.github.com/users/xuzhg/repos","events_url":"https://api.github.com/users/xuzhg/events{/privacy}","received_events_url":"https://api.github.com/users/xuzhg/received_events","type":"User","site_admin":false},"body":"<!-- markdownlint-disable MD002 MD041 -->\r\n\r\n### Issues\r\n\r\n* #1529 .*\r\n\r\n### Description\r\n\r\n* When customer defined entity set on derived type, while the concurrency property defined on base type, the etag can't present on the payload. See detail in the #1529.\r\n\r\n### Checklist (Uncheck if it is not completed)\r\n\r\n- [x] *Test cases added*\r\n- [x] *Build and test with one-click build and test script passed*\r\n\r\n### Additional work necessary\r\n\r\n*If documentation update is needed, please add \"Docs Needed\" label to the issue and provide details about the required document change in the issue.*\r\n","created_at":"2018-07-17T00:33:47Z","updated_at":"2018-07-17T21:04:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e7ffe57ed0a5e18c23ad6841af9181e865764c5a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"raheph","id":1559051,"node_id":"MDQ6VXNlcjE1NTkwNTE=","avatar_url":"https://avatars0.githubusercontent.com/u/1559051?v=4","gravatar_id":"","url":"https://api.github.com/users/raheph","html_url":"https://github.com/raheph","followers_url":"https://api.github.com/users/raheph/followers","following_url":"https://api.github.com/users/raheph/following{/other_user}","gists_url":"https://api.github.com/users/raheph/gists{/gist_id}","starred_url":"https://api.github.com/users/raheph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raheph/subscriptions","organizations_url":"https://api.github.com/users/raheph/orgs","repos_url":"https://api.github.com/users/raheph/repos","events_url":"https://api.github.com/users/raheph/events{/privacy}","received_events_url":"https://api.github.com/users/raheph/received_events","type":"User","site_admin":false},{"login":"mikepizzo","id":8660830,"node_id":"MDQ6VXNlcjg2NjA4MzA=","avatar_url":"https://avatars2.githubusercontent.com/u/8660830?v=4","gravatar_id":"","url":"https://api.github.com/users/mikepizzo","html_url":"https://github.com/mikepizzo","followers_url":"https://api.github.com/users/mikepizzo/followers","following_url":"https://api.github.com/users/mikepizzo/following{/other_user}","gists_url":"https://api.github.com/users/mikepizzo/gists{/gist_id}","starred_url":"https://api.github.com/users/mikepizzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikepizzo/subscriptions","organizations_url":"https://api.github.com/users/mikepizzo/orgs","repos_url":"https://api.github.com/users/mikepizzo/repos","events_url":"https://api.github.com/users/mikepizzo/events{/privacy}","received_events_url":"https://api.github.com/users/mikepizzo/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OData/WebApi/pulls/1537/commits","review_comments_url":"https://api.github.com/repos/OData/WebApi/pulls/1537/comments","review_comment_url":"https://api.github.com/repos/OData/WebApi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OData/WebApi/issues/1537/comments","statuses_url":"https://api.github.com/repos/OData/WebApi/statuses/1a240d4d7c0589ab4b1a5d1580d9f012e195ff06","head":{"label":"xuzhg:fixIssue1529","ref":"fixIssue1529","sha":"1a240d4d7c0589ab4b1a5d1580d9f012e195ff06","user":{"login":"xuzhg","id":9426627,"node_id":"MDQ6VXNlcjk0MjY2Mjc=","avatar_url":"https://avatars0.githubusercontent.com/u/9426627?v=4","gravatar_id":"","url":"https://api.github.com/users/xuzhg","html_url":"https://github.com/xuzhg","followers_url":"https://api.github.com/users/xuzhg/followers","following_url":"https://api.github.com/users/xuzhg/following{/other_user}","gists_url":"https://api.github.com/users/xuzhg/gists{/gist_id}","starred_url":"https://api.github.com/users/xuzhg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xuzhg/subscriptions","organizations_url":"https://api.github.com/users/xuzhg/orgs","repos_url":"https://api.github.com/users/xuzhg/repos","events_url":"https://api.github.com/users/xuzhg/events{/privacy}","received_events_url":"https://api.github.com/users/xuzhg/received_events","type":"User","site_admin":false},"repo":{"id":32921856,"node_id":"MDEwOlJlcG9zaXRvcnkzMjkyMTg1Ng==","name":"WebApi","full_name":"xuzhg/WebApi","owner":{"login":"xuzhg","id":9426627,"node_id":"MDQ6VXNlcjk0MjY2Mjc=","avatar_url":"https://avatars0.githubusercontent.com/u/9426627?v=4","gravatar_id":"","url":"https://api.github.com/users/xuzhg","html_url":"https://github.com/xuzhg","followers_url":"https://api.github.com/users/xuzhg/followers","following_url":"https://api.github.com/users/xuzhg/following{/other_user}","gists_url":"https://api.github.com/users/xuzhg/gists{/gist_id}","starred_url":"https://api.github.com/users/xuzhg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xuzhg/subscriptions","organizations_url":"https://api.github.com/users/xuzhg/orgs","repos_url":"https://api.github.com/users/xuzhg/repos","events_url":"https://api.github.com/users/xuzhg/events{/privacy}","received_events_url":"https://api.github.com/users/xuzhg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xuzhg/WebApi","description":"OData Web API: A server library built upon ODataLib and WebApi","fork":true,"url":"https://api.github.com/repos/xuzhg/WebApi","forks_url":"https://api.github.com/repos/xuzhg/WebApi/forks","keys_url":"https://api.github.com/repos/xuzhg/WebApi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xuzhg/WebApi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xuzhg/WebApi/teams","hooks_url":"https://api.github.com/repos/xuzhg/WebApi/hooks","issue_events_url":"https://api.github.com/repos/xuzhg/WebApi/issues/events{/number}","events_url":"https://api.github.com/repos/xuzhg/WebApi/events","assignees_url":"https://api.github.com/repos/xuzhg/WebApi/assignees{/user}","branches_url":"https://api.github.com/repos/xuzhg/WebApi/branches{/branch}","tags_url":"https://api.github.com/repos/xuzhg/WebApi/tags","blobs_url":"https://api.github.com/repos/xuzhg/WebApi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xuzhg/WebApi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xuzhg/WebApi/git/refs{/sha}","trees_url":"https://api.github.com/repos/xuzhg/WebApi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xuzhg/WebApi/statuses/{sha}","languages_url":"https://api.github.com/repos/xuzhg/WebApi/languages","stargazers_url":"https://api.github.com/repos/xuzhg/WebApi/stargazers","contributors_url":"https://api.github.com/repos/xuzhg/WebApi/contributors","subscribers_url":"https://api.github.com/repos/xuzhg/WebApi/subscribers","subscription_url":"https://api.github.com/repos/xuzhg/WebApi/subscription","commits_url":"https://api.github.com/repos/xuzhg/WebApi/commits{/sha}","git_commits_url":"https://api.github.com/repos/xuzhg/WebApi/git/commits{/sha}","comments_url":"https://api.github.com/repos/xuzhg/WebApi/comments{/number}","issue_comment_url":"https://api.github.com/repos/xuzhg/WebApi/issues/comments{/number}","contents_url":"https://api.github.com/repos/xuzhg/WebApi/contents/{+path}","compare_url":"https://api.github.com/repos/xuzhg/WebApi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xuzhg/WebApi/merges","archive_url":"https://api.github.com/repos/xuzhg/WebApi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xuzhg/WebApi/downloads","issues_url":"https://api.github.com/repos/xuzhg/WebApi/issues{/number}","pulls_url":"https://api.github.com/repos/xuzhg/WebApi/pulls{/number}","milestones_url":"https://api.github.com/repos/xuzhg/WebApi/milestones{/number}","notifications_url":"https://api.github.com/repos/xuzhg/WebApi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xuzhg/WebApi/labels{/name}","releases_url":"https://api.github.com/repos/xuzhg/WebApi/releases{/id}","deployments_url":"https://api.github.com/repos/xuzhg/WebApi/deployments","created_at":"2015-03-26T10:49:38Z","updated_at":"2018-07-06T17:57:05Z","pushed_at":"2018-07-17T21:02:03Z","git_url":"git://github.com/xuzhg/WebApi.git","ssh_url":"git@github.com:xuzhg/WebApi.git","clone_url":"https://github.com/xuzhg/WebApi.git","svn_url":"https://github.com/xuzhg/WebApi","homepage":"","size":22376,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"OData:master","ref":"master","sha":"82e801abf2a1c8d596702ed78dd6863e4317392c","user":{"login":"OData","id":916520,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNjUyMA==","avatar_url":"https://avatars1.githubusercontent.com/u/916520?v=4","gravatar_id":"","url":"https://api.github.com/users/OData","html_url":"https://github.com/OData","followers_url":"https://api.github.com/users/OData/followers","following_url":"https://api.github.com/users/OData/following{/other_user}","gists_url":"https://api.github.com/users/OData/gists{/gist_id}","starred_url":"https://api.github.com/users/OData/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OData/subscriptions","organizations_url":"https://api.github.com/users/OData/orgs","repos_url":"https://api.github.com/users/OData/repos","events_url":"https://api.github.com/users/OData/events{/privacy}","received_events_url":"https://api.github.com/users/OData/received_events","type":"Organization","site_admin":false},"repo":{"id":28804670,"node_id":"MDEwOlJlcG9zaXRvcnkyODgwNDY3MA==","name":"WebApi","full_name":"OData/WebApi","owner":{"login":"OData","id":916520,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNjUyMA==","avatar_url":"https://avatars1.githubusercontent.com/u/916520?v=4","gravatar_id":"","url":"https://api.github.com/users/OData","html_url":"https://github.com/OData","followers_url":"https://api.github.com/users/OData/followers","following_url":"https://api.github.com/users/OData/following{/other_user}","gists_url":"https://api.github.com/users/OData/gists{/gist_id}","starred_url":"https://api.github.com/users/OData/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OData/subscriptions","organizations_url":"https://api.github.com/users/OData/orgs","repos_url":"https://api.github.com/users/OData/repos","events_url":"https://api.github.com/users/OData/events{/privacy}","received_events_url":"https://api.github.com/users/OData/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/OData/WebApi","description":"OData Web API: A server library built upon ODataLib and WebApi","fork":false,"url":"https://api.github.com/repos/OData/WebApi","forks_url":"https://api.github.com/repos/OData/WebApi/forks","keys_url":"https://api.github.com/repos/OData/WebApi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OData/WebApi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OData/WebApi/teams","hooks_url":"https://api.github.com/repos/OData/WebApi/hooks","issue_events_url":"https://api.github.com/repos/OData/WebApi/issues/events{/number}","events_url":"https://api.github.com/repos/OData/WebApi/events","assignees_url":"https://api.github.com/repos/OData/WebApi/assignees{/user}","branches_url":"https://api.github.com/repos/OData/WebApi/branches{/branch}","tags_url":"https://api.github.com/repos/OData/WebApi/tags","blobs_url":"https://api.github.com/repos/OData/WebApi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OData/WebApi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OData/WebApi/git/refs{/sha}","trees_url":"https://api.github.com/repos/OData/WebApi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OData/WebApi/statuses/{sha}","languages_url":"https://api.github.com/repos/OData/WebApi/languages","stargazers_url":"https://api.github.com/repos/OData/WebApi/stargazers","contributors_url":"https://api.github.com/repos/OData/WebApi/contributors","subscribers_url":"https://api.github.com/repos/OData/WebApi/subscribers","subscription_url":"https://api.github.com/repos/OData/WebApi/subscription","commits_url":"https://api.github.com/repos/OData/WebApi/commits{/sha}","git_commits_url":"https://api.github.com/repos/OData/WebApi/git/commits{/sha}","comments_url":"https://api.github.com/repos/OData/WebApi/comments{/number}","issue_comment_url":"https://api.github.com/repos/OData/WebApi/issues/comments{/number}","contents_url":"https://api.github.com/repos/OData/WebApi/contents/{+path}","compare_url":"https://api.github.com/repos/OData/WebApi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OData/WebApi/merges","archive_url":"https://api.github.com/repos/OData/WebApi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OData/WebApi/downloads","issues_url":"https://api.github.com/repos/OData/WebApi/issues{/number}","pulls_url":"https://api.github.com/repos/OData/WebApi/pulls{/number}","milestones_url":"https://api.github.com/repos/OData/WebApi/milestones{/number}","notifications_url":"https://api.github.com/repos/OData/WebApi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OData/WebApi/labels{/name}","releases_url":"https://api.github.com/repos/OData/WebApi/releases{/id}","deployments_url":"https://api.github.com/repos/OData/WebApi/deployments","created_at":"2015-01-05T08:50:51Z","updated_at":"2018-07-16T23:09:52Z","pushed_at":"2018-07-17T21:02:05Z","git_url":"git://github.com/OData/WebApi.git","ssh_url":"git@github.com:OData/WebApi.git","clone_url":"https://github.com/OData/WebApi.git","svn_url":"https://github.com/OData/WebApi","homepage":"http://odata.github.io/WebApi","size":22325,"stargazers_count":519,"watchers_count":519,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":336,"mirror_url":null,"archived":false,"open_issues_count":289,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":336,"open_issues":289,"watchers":519,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/OData/WebApi/pulls/1537"},"html":{"href":"https://github.com/OData/WebApi/pull/1537"},"issue":{"href":"https://api.github.com/repos/OData/WebApi/issues/1537"},"comments":{"href":"https://api.github.com/repos/OData/WebApi/issues/1537/comments"},"review_comments":{"href":"https://api.github.com/repos/OData/WebApi/pulls/1537/comments"},"review_comment":{"href":"https://api.github.com/repos/OData/WebApi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OData/WebApi/pulls/1537/commits"},"statuses":{"href":"https://api.github.com/repos/OData/WebApi/statuses/1a240d4d7c0589ab4b1a5d1580d9f012e195ff06"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"xuzhg"}}