{"action":"created","comment":{"url":"https://api.github.com/repos/mattermost/mattermost-webapp/pulls/comments/181363365","pull_request_review_id":111977307,"id":181363365,"diff_hunk":"@@ -154,32 +141,6 @@ export default class SystemUsers extends React.Component {\n         }\n     }\n \n-    updateUsersFromStore(teamId = this.state.teamId, term = this.state.term) {","path":"components/admin_console/system_users/system_users.jsx","position":71,"original_position":71,"commit_id":"87383fdbeb6ebfc29bb69c28c717774fef344df2","original_commit_id":"87383fdbeb6ebfc29bb69c28c717774fef344df2","user":{"login":"saturninoabril","id":5334504,"avatar_url":"https://avatars2.githubusercontent.com/u/5334504?v=4","gravatar_id":"","url":"https://api.github.com/users/saturninoabril","html_url":"https://github.com/saturninoabril","followers_url":"https://api.github.com/users/saturninoabril/followers","following_url":"https://api.github.com/users/saturninoabril/following{/other_user}","gists_url":"https://api.github.com/users/saturninoabril/gists{/gist_id}","starred_url":"https://api.github.com/users/saturninoabril/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saturninoabril/subscriptions","organizations_url":"https://api.github.com/users/saturninoabril/orgs","repos_url":"https://api.github.com/users/saturninoabril/repos","events_url":"https://api.github.com/users/saturninoabril/events{/privacy}","received_events_url":"https://api.github.com/users/saturninoabril/received_events","type":"User","site_admin":false},"body":"Might be too much to ask but it might worth extending this refactor effort to migrate this component into using redux (and eliminate those use of `...Store`)? ","created_at":"2018-04-13T11:46:36Z","updated_at":"2018-04-13T11:46:49Z","html_url":"https://github.com/mattermost/mattermost-webapp/pull/1090#discussion_r181363365","pull_request_url":"https://api.github.com/repos/mattermost/mattermost-webapp/pulls/1090","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mattermost/mattermost-webapp/pulls/comments/181363365"},"html":{"href":"https://github.com/mattermost/mattermost-webapp/pull/1090#discussion_r181363365"},"pull_request":{"href":"https://api.github.com/repos/mattermost/mattermost-webapp/pulls/1090"}}},"pull_request":{"url":"https://api.github.com/repos/mattermost/mattermost-webapp/pulls/1090","id":181227286,"html_url":"https://github.com/mattermost/mattermost-webapp/pull/1090","diff_url":"https://github.com/mattermost/mattermost-webapp/pull/1090.diff","patch_url":"https://github.com/mattermost/mattermost-webapp/pull/1090.patch","issue_url":"https://api.github.com/repos/mattermost/mattermost-webapp/issues/1090","number":1090,"state":"open","locked":false,"title":"Mm 9831 expunge get state in admin console","user":{"login":"lieut-data","id":1023171,"avatar_url":"https://avatars2.githubusercontent.com/u/1023171?v=4","gravatar_id":"","url":"https://api.github.com/users/lieut-data","html_url":"https://github.com/lieut-data","followers_url":"https://api.github.com/users/lieut-data/followers","following_url":"https://api.github.com/users/lieut-data/following{/other_user}","gists_url":"https://api.github.com/users/lieut-data/gists{/gist_id}","starred_url":"https://api.github.com/users/lieut-data/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lieut-data/subscriptions","organizations_url":"https://api.github.com/users/lieut-data/orgs","repos_url":"https://api.github.com/users/lieut-data/repos","events_url":"https://api.github.com/users/lieut-data/events{/privacy}","received_events_url":"https://api.github.com/users/lieut-data/received_events","type":"User","site_admin":false},"body":"#### Summary\r\nThis is one of a series of JIRAs to resolve the use of `getState` in components outside of the Redux connector flow. The problem with using `getState` like this is that changes to the store do not automatically reflect into the component unless something else changes to trigger re-render. While the config is no longer accessed via `window.mm_config`, this usage is effectively just as \"global\", and is hampering our attempts to eliminate the refresh on a config change.\r\n\r\nThe crux of this particular change is to move the computation of the users to be shown in the system console users page out of the component and into the connector. This is done by passing down the parameters (e.g. selected team, search term) into the system users list, whose connector intercepts and selects the requisite subset of data to pass into the list component.\r\n\r\n#### Ticket Link\r\nhttps://mattermost.atlassian.net/browse/MM-9831\r\n\r\n#### Checklist\r\n- [x] Ran `make check-style` to check for style errors (required for all pull requests)\r\n- [x] Ran `make test` to ensure unit and component tests passed","created_at":"2018-04-12T14:43:53Z","updated_at":"2018-04-13T11:46:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"755965163a972ca7f76c8e4d33c50aeadb905010","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":685999255,"url":"https://api.github.com/repos/mattermost/mattermost-webapp/labels/2:%20Dev%20Review","name":"2: Dev Review","color":"eb6420","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mattermost/mattermost-webapp/pulls/1090/commits","review_comments_url":"https://api.github.com/repos/mattermost/mattermost-webapp/pulls/1090/comments","review_comment_url":"https://api.github.com/repos/mattermost/mattermost-webapp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mattermost/mattermost-webapp/issues/1090/comments","statuses_url":"https://api.github.com/repos/mattermost/mattermost-webapp/statuses/87383fdbeb6ebfc29bb69c28c717774fef344df2","head":{"label":"mattermost:MM-9831-expunge-getState-in-admin-console","ref":"MM-9831-expunge-getState-in-admin-console","sha":"87383fdbeb6ebfc29bb69c28c717774fef344df2","user":{"login":"mattermost","id":9828093,"avatar_url":"https://avatars1.githubusercontent.com/u/9828093?v=4","gravatar_id":"","url":"https://api.github.com/users/mattermost","html_url":"https://github.com/mattermost","followers_url":"https://api.github.com/users/mattermost/followers","following_url":"https://api.github.com/users/mattermost/following{/other_user}","gists_url":"https://api.github.com/users/mattermost/gists{/gist_id}","starred_url":"https://api.github.com/users/mattermost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattermost/subscriptions","organizations_url":"https://api.github.com/users/mattermost/orgs","repos_url":"https://api.github.com/users/mattermost/repos","events_url":"https://api.github.com/users/mattermost/events{/privacy}","received_events_url":"https://api.github.com/users/mattermost/received_events","type":"Organization","site_admin":false},"repo":{"id":102689445,"name":"mattermost-webapp","full_name":"mattermost/mattermost-webapp","owner":{"login":"mattermost","id":9828093,"avatar_url":"https://avatars1.githubusercontent.com/u/9828093?v=4","gravatar_id":"","url":"https://api.github.com/users/mattermost","html_url":"https://github.com/mattermost","followers_url":"https://api.github.com/users/mattermost/followers","following_url":"https://api.github.com/users/mattermost/following{/other_user}","gists_url":"https://api.github.com/users/mattermost/gists{/gist_id}","starred_url":"https://api.github.com/users/mattermost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattermost/subscriptions","organizations_url":"https://api.github.com/users/mattermost/orgs","repos_url":"https://api.github.com/users/mattermost/repos","events_url":"https://api.github.com/users/mattermost/events{/privacy}","received_events_url":"https://api.github.com/users/mattermost/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mattermost/mattermost-webapp","description":"Webapp of Mattermost server: https://github.com/mattermost/mattermost-server","fork":false,"url":"https://api.github.com/repos/mattermost/mattermost-webapp","forks_url":"https://api.github.com/repos/mattermost/mattermost-webapp/forks","keys_url":"https://api.github.com/repos/mattermost/mattermost-webapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattermost/mattermost-webapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattermost/mattermost-webapp/teams","hooks_url":"https://api.github.com/repos/mattermost/mattermost-webapp/hooks","issue_events_url":"https://api.github.com/repos/mattermost/mattermost-webapp/issues/events{/number}","events_url":"https://api.github.com/repos/mattermost/mattermost-webapp/events","assignees_url":"https://api.github.com/repos/mattermost/mattermost-webapp/assignees{/user}","branches_url":"https://api.github.com/repos/mattermost/mattermost-webapp/branches{/branch}","tags_url":"https://api.github.com/repos/mattermost/mattermost-webapp/tags","blobs_url":"https://api.github.com/repos/mattermost/mattermost-webapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattermost/mattermost-webapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattermost/mattermost-webapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattermost/mattermost-webapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattermost/mattermost-webapp/statuses/{sha}","languages_url":"https://api.github.com/repos/mattermost/mattermost-webapp/languages","stargazers_url":"https://api.github.com/repos/mattermost/mattermost-webapp/stargazers","contributors_url":"https://api.github.com/repos/mattermost/mattermost-webapp/contributors","subscribers_url":"https://api.github.com/repos/mattermost/mattermost-webapp/subscribers","subscription_url":"https://api.github.com/repos/mattermost/mattermost-webapp/subscription","commits_url":"https://api.github.com/repos/mattermost/mattermost-webapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattermost/mattermost-webapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattermost/mattermost-webapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattermost/mattermost-webapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattermost/mattermost-webapp/contents/{+path}","compare_url":"https://api.github.com/repos/mattermost/mattermost-webapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattermost/mattermost-webapp/merges","archive_url":"https://api.github.com/repos/mattermost/mattermost-webapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattermost/mattermost-webapp/downloads","issues_url":"https://api.github.com/repos/mattermost/mattermost-webapp/issues{/number}","pulls_url":"https://api.github.com/repos/mattermost/mattermost-webapp/pulls{/number}","milestones_url":"https://api.github.com/repos/mattermost/mattermost-webapp/milestones{/number}","notifications_url":"https://api.github.com/repos/mattermost/mattermost-webapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattermost/mattermost-webapp/labels{/name}","releases_url":"https://api.github.com/repos/mattermost/mattermost-webapp/releases{/id}","deployments_url":"https://api.github.com/repos/mattermost/mattermost-webapp/deployments","created_at":"2017-09-07T04:00:02Z","updated_at":"2018-04-12T15:35:56Z","pushed_at":"2018-04-13T06:43:12Z","git_url":"git://github.com/mattermost/mattermost-webapp.git","ssh_url":"git@github.com:mattermost/mattermost-webapp.git","clone_url":"https://github.com/mattermost/mattermost-webapp.git","svn_url":"https://github.com/mattermost/mattermost-webapp","homepage":null,"size":99506,"stargazers_count":168,"watchers_count":168,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":335,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":335,"open_issues":22,"watchers":168,"default_branch":"master"}},"base":{"label":"mattermost:master","ref":"master","sha":"65c850b6b39348c1030cff62103d28e12fa94660","user":{"login":"mattermost","id":9828093,"avatar_url":"https://avatars1.githubusercontent.com/u/9828093?v=4","gravatar_id":"","url":"https://api.github.com/users/mattermost","html_url":"https://github.com/mattermost","followers_url":"https://api.github.com/users/mattermost/followers","following_url":"https://api.github.com/users/mattermost/following{/other_user}","gists_url":"https://api.github.com/users/mattermost/gists{/gist_id}","starred_url":"https://api.github.com/users/mattermost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattermost/subscriptions","organizations_url":"https://api.github.com/users/mattermost/orgs","repos_url":"https://api.github.com/users/mattermost/repos","events_url":"https://api.github.com/users/mattermost/events{/privacy}","received_events_url":"https://api.github.com/users/mattermost/received_events","type":"Organization","site_admin":false},"repo":{"id":102689445,"name":"mattermost-webapp","full_name":"mattermost/mattermost-webapp","owner":{"login":"mattermost","id":9828093,"avatar_url":"https://avatars1.githubusercontent.com/u/9828093?v=4","gravatar_id":"","url":"https://api.github.com/users/mattermost","html_url":"https://github.com/mattermost","followers_url":"https://api.github.com/users/mattermost/followers","following_url":"https://api.github.com/users/mattermost/following{/other_user}","gists_url":"https://api.github.com/users/mattermost/gists{/gist_id}","starred_url":"https://api.github.com/users/mattermost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattermost/subscriptions","organizations_url":"https://api.github.com/users/mattermost/orgs","repos_url":"https://api.github.com/users/mattermost/repos","events_url":"https://api.github.com/users/mattermost/events{/privacy}","received_events_url":"https://api.github.com/users/mattermost/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mattermost/mattermost-webapp","description":"Webapp of Mattermost server: https://github.com/mattermost/mattermost-server","fork":false,"url":"https://api.github.com/repos/mattermost/mattermost-webapp","forks_url":"https://api.github.com/repos/mattermost/mattermost-webapp/forks","keys_url":"https://api.github.com/repos/mattermost/mattermost-webapp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattermost/mattermost-webapp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattermost/mattermost-webapp/teams","hooks_url":"https://api.github.com/repos/mattermost/mattermost-webapp/hooks","issue_events_url":"https://api.github.com/repos/mattermost/mattermost-webapp/issues/events{/number}","events_url":"https://api.github.com/repos/mattermost/mattermost-webapp/events","assignees_url":"https://api.github.com/repos/mattermost/mattermost-webapp/assignees{/user}","branches_url":"https://api.github.com/repos/mattermost/mattermost-webapp/branches{/branch}","tags_url":"https://api.github.com/repos/mattermost/mattermost-webapp/tags","blobs_url":"https://api.github.com/repos/mattermost/mattermost-webapp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattermost/mattermost-webapp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattermost/mattermost-webapp/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattermost/mattermost-webapp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattermost/mattermost-webapp/statuses/{sha}","languages_url":"https://api.github.com/repos/mattermost/mattermost-webapp/languages","stargazers_url":"https://api.github.com/repos/mattermost/mattermost-webapp/stargazers","contributors_url":"https://api.github.com/repos/mattermost/mattermost-webapp/contributors","subscribers_url":"https://api.github.com/repos/mattermost/mattermost-webapp/subscribers","subscription_url":"https://api.github.com/repos/mattermost/mattermost-webapp/subscription","commits_url":"https://api.github.com/repos/mattermost/mattermost-webapp/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattermost/mattermost-webapp/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattermost/mattermost-webapp/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattermost/mattermost-webapp/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattermost/mattermost-webapp/contents/{+path}","compare_url":"https://api.github.com/repos/mattermost/mattermost-webapp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattermost/mattermost-webapp/merges","archive_url":"https://api.github.com/repos/mattermost/mattermost-webapp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattermost/mattermost-webapp/downloads","issues_url":"https://api.github.com/repos/mattermost/mattermost-webapp/issues{/number}","pulls_url":"https://api.github.com/repos/mattermost/mattermost-webapp/pulls{/number}","milestones_url":"https://api.github.com/repos/mattermost/mattermost-webapp/milestones{/number}","notifications_url":"https://api.github.com/repos/mattermost/mattermost-webapp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattermost/mattermost-webapp/labels{/name}","releases_url":"https://api.github.com/repos/mattermost/mattermost-webapp/releases{/id}","deployments_url":"https://api.github.com/repos/mattermost/mattermost-webapp/deployments","created_at":"2017-09-07T04:00:02Z","updated_at":"2018-04-12T15:35:56Z","pushed_at":"2018-04-13T06:43:12Z","git_url":"git://github.com/mattermost/mattermost-webapp.git","ssh_url":"git@github.com:mattermost/mattermost-webapp.git","clone_url":"https://github.com/mattermost/mattermost-webapp.git","svn_url":"https://github.com/mattermost/mattermost-webapp","homepage":null,"size":99506,"stargazers_count":168,"watchers_count":168,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":335,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":335,"open_issues":22,"watchers":168,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mattermost/mattermost-webapp/pulls/1090"},"html":{"href":"https://github.com/mattermost/mattermost-webapp/pull/1090"},"issue":{"href":"https://api.github.com/repos/mattermost/mattermost-webapp/issues/1090"},"comments":{"href":"https://api.github.com/repos/mattermost/mattermost-webapp/issues/1090/comments"},"review_comments":{"href":"https://api.github.com/repos/mattermost/mattermost-webapp/pulls/1090/comments"},"review_comment":{"href":"https://api.github.com/repos/mattermost/mattermost-webapp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mattermost/mattermost-webapp/pulls/1090/commits"},"statuses":{"href":"https://api.github.com/repos/mattermost/mattermost-webapp/statuses/87383fdbeb6ebfc29bb69c28c717774fef344df2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"saturninoabril"}}