{"action":"created","issue":{"url":"https://api.github.com/repos/home-assistant/home-assistant/issues/13125","repository_url":"https://api.github.com/repos/home-assistant/home-assistant","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/13125/labels{/name}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/13125/comments","events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/13125/events","html_url":"https://github.com/home-assistant/home-assistant/pull/13125","id":304359317,"number":13125,"title":"[WIP] Enable pylint for tests v2","user":{"login":"OttoWinter","id":6833237,"avatar_url":"https://avatars1.githubusercontent.com/u/6833237?v=4","gravatar_id":"","url":"https://api.github.com/users/OttoWinter","html_url":"https://github.com/OttoWinter","followers_url":"https://api.github.com/users/OttoWinter/followers","following_url":"https://api.github.com/users/OttoWinter/following{/other_user}","gists_url":"https://api.github.com/users/OttoWinter/gists{/gist_id}","starred_url":"https://api.github.com/users/OttoWinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OttoWinter/subscriptions","organizations_url":"https://api.github.com/users/OttoWinter/orgs","repos_url":"https://api.github.com/users/OttoWinter/repos","events_url":"https://api.github.com/users/OttoWinter/events{/privacy}","received_events_url":"https://api.github.com/users/OttoWinter/received_events","type":"User","site_admin":false},"labels":[{"id":527871105,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/cla-signed","name":"cla-signed","color":"008000","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-03-12T12:53:25Z","updated_at":"2018-03-13T19:31:10Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/13125","html_url":"https://github.com/home-assistant/home-assistant/pull/13125","diff_url":"https://github.com/home-assistant/home-assistant/pull/13125.diff","patch_url":"https://github.com/home-assistant/home-assistant/pull/13125.patch"},"body":"## Description:\r\n\r\nSee #13101; I've accidentally made the changes on my dev branch and don't really want to deal with reverts/merge conflicts with that PR, so I made this into a separate PR\r\n\r\n- [x] Disable specific pylint lints for `tests/` (I think creating a separate `tests/pylintrc` is the correct way here)\r\n- [x] Remove existing `# pylint: disable=*` where appropriate\r\n- [x] Skip test files that don't pass (using the excellent script by @armills in #13101 👍)\r\n- [x] Update tox.ini\r\n- [ ] Update lazytox\r\n- [ ] Benchmark pylint travis slowdown.\r\n- [ ] Fix merge conflicts (if any)\r\n- [ ] Warn other PRs about conflicts\r\n\r\n## Checklist:\r\n  - [ ] The code change is tested and works locally.\r\n  - [ ] Local tests pass with `tox`. **Your PR cannot be merged unless tests pass**\r\n\r\nIf user exposed functionality or configuration variables are added/changed:\r\n  - [ ] Documentation added/updated in [home-assistant.github.io](https://github.com/home-assistant/home-assistant.github.io)\r\n\r\n[ex-requir]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L14\r\n[ex-import]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L54\r\n"},"comment":{"url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments/372790309","html_url":"https://github.com/home-assistant/home-assistant/pull/13125#issuecomment-372790309","issue_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/13125","id":372790309,"user":{"login":"armills","id":1386547,"avatar_url":"https://avatars2.githubusercontent.com/u/1386547?v=4","gravatar_id":"","url":"https://api.github.com/users/armills","html_url":"https://github.com/armills","followers_url":"https://api.github.com/users/armills/followers","following_url":"https://api.github.com/users/armills/following{/other_user}","gists_url":"https://api.github.com/users/armills/gists{/gist_id}","starred_url":"https://api.github.com/users/armills/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/armills/subscriptions","organizations_url":"https://api.github.com/users/armills/orgs","repos_url":"https://api.github.com/users/armills/repos","events_url":"https://api.github.com/users/armills/events{/privacy}","received_events_url":"https://api.github.com/users/armills/received_events","type":"User","site_admin":false},"created_at":"2018-03-13T19:31:10Z","updated_at":"2018-03-13T19:31:10Z","author_association":"MEMBER","body":"I guess what I'm trying to get across is that these scripts should only be shortcuts to quickly run through the tests that would happen on CI. We should never enable tests here that aren't enabled in CI, because then we're subjecting contributors to fixing existing problems.\r\n\r\nI'd love to get pylint enabled in some fashion for our tests, but it needs to be on for both or off for both."}}
{"actor":{"display_login":"armills"}}