{"action":"created","comment":{"url":"https://api.github.com/repos/spack/spack/pulls/comments/224598672","pull_request_review_id":164007915,"id":224598672,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDU5ODY3Mg==","diff_hunk":"@@ -44,12 +44,21 @@ class PySpyder(PythonPackage):\n     depends_on('py-qtconsole@4.2.0:', type=('build', 'run'))\n     depends_on('py-nbconvert',        type=('build', 'run'))\n     depends_on('py-sphinx',           type=('build', 'run'))\n-    depends_on('py-pycodestyle',      type=('build', 'run'))\n+    # The pycodestyle dependency is split in two, because internally it\n+    # changes its name from pep8 to pycodestyle, and spyder does not cope\n+    # with this change until @3.2.0\n+    # https://github.com/PyCQA/pycodestyle/issues/466\n+    # https://github.com/spyder-ide/spyder/blob/master/CHANGELOG.md#version-32-2017-07-24\n+    depends_on('py-pycodestyle@:1.7.1', when='@:3.1.99', type=('build', 'run'))\n+    depends_on('py-pycodestyle@2.1.0:', when='@3.2.0:',  type=('build', 'run'))\n     depends_on('py-pylint',           type=('build', 'run'))\n     depends_on('py-psutil',           type=('build', 'run'))\n     depends_on('py-qtawesome@0.4.1:', type=('build', 'run'))\n     depends_on('py-qtpy@1.1.0:',      type=('build', 'run'))\n-    depends_on('py-zmq',              type=('build', 'run'))\n-    depends_on('py-chardet@2:',       type=('build', 'run'))\n+    # not sure whether this should be here or whether it should be declared","path":"var/spack/repos/builtin/packages/py-spyder/package.py","position":27,"original_position":27,"commit_id":"aaef32bb342caa871eb64e9f32530ce72066e00e","original_commit_id":"aaef32bb342caa871eb64e9f32530ce72066e00e","user":{"login":"neilflood","id":24580585,"node_id":"MDQ6VXNlcjI0NTgwNTg1","avatar_url":"https://avatars3.githubusercontent.com/u/24580585?v=4","gravatar_id":"","url":"https://api.github.com/users/neilflood","html_url":"https://github.com/neilflood","followers_url":"https://api.github.com/users/neilflood/followers","following_url":"https://api.github.com/users/neilflood/following{/other_user}","gists_url":"https://api.github.com/users/neilflood/gists{/gist_id}","starred_url":"https://api.github.com/users/neilflood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neilflood/subscriptions","organizations_url":"https://api.github.com/users/neilflood/orgs","repos_url":"https://api.github.com/users/neilflood/repos","events_url":"https://api.github.com/users/neilflood/events{/privacy}","received_events_url":"https://api.github.com/users/neilflood/received_events","type":"User","site_admin":false},"body":"Just noting a detail - it is py-pyqt which was relevant, rather than py-qtpy. And no, I don't know what the difference is either......\r\n\r\nAs far as I can figure, py-pyqt included the Python bindings for the webkit libs if they were present in the Qt installation, and did not attempt it if they were not present. ","created_at":"2018-10-11T20:46:04Z","updated_at":"2018-10-11T20:46:05Z","html_url":"https://github.com/spack/spack/pull/9207#discussion_r224598672","pull_request_url":"https://api.github.com/repos/spack/spack/pulls/9207","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/spack/spack/pulls/comments/224598672"},"html":{"href":"https://github.com/spack/spack/pull/9207#discussion_r224598672"},"pull_request":{"href":"https://api.github.com/repos/spack/spack/pulls/9207"}},"in_reply_to_id":224555084},"pull_request":{"url":"https://api.github.com/repos/spack/spack/pulls/9207","id":214548304,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0NTQ4MzA0","html_url":"https://github.com/spack/spack/pull/9207","diff_url":"https://github.com/spack/spack/pull/9207.diff","patch_url":"https://github.com/spack/spack/pull/9207.patch","issue_url":"https://api.github.com/repos/spack/spack/issues/9207","number":9207,"state":"open","locked":false,"title":"remove py-setuptools dependency from py-spyder","user":{"login":"healther","id":4048699,"node_id":"MDQ6VXNlcjQwNDg2OTk=","avatar_url":"https://avatars3.githubusercontent.com/u/4048699?v=4","gravatar_id":"","url":"https://api.github.com/users/healther","html_url":"https://github.com/healther","followers_url":"https://api.github.com/users/healther/followers","following_url":"https://api.github.com/users/healther/following{/other_user}","gists_url":"https://api.github.com/users/healther/gists{/gist_id}","starred_url":"https://api.github.com/users/healther/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/healther/subscriptions","organizations_url":"https://api.github.com/users/healther/orgs","repos_url":"https://api.github.com/users/healther/repos","events_url":"https://api.github.com/users/healther/events{/privacy}","received_events_url":"https://api.github.com/users/healther/received_events","type":"User","site_admin":false},"body":"closes #9205\r\n\r\nreordered dependencies to confirm to the ordering in setup.py","created_at":"2018-09-11T08:15:20Z","updated_at":"2018-10-11T20:46:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2674be55f0dc14bc95d7b4bea6b97d03c7e09715","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":446630669,"node_id":"MDU6TGFiZWw0NDY2MzA2Njk=","url":"https://api.github.com/repos/spack/spack/labels/dependencies","name":"dependencies","color":"c2e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/spack/spack/pulls/9207/commits","review_comments_url":"https://api.github.com/repos/spack/spack/pulls/9207/comments","review_comment_url":"https://api.github.com/repos/spack/spack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spack/spack/issues/9207/comments","statuses_url":"https://api.github.com/repos/spack/spack/statuses/aaef32bb342caa871eb64e9f32530ce72066e00e","head":{"label":"electronicvisions:PR/pyspider","ref":"PR/pyspider","sha":"aaef32bb342caa871eb64e9f32530ce72066e00e","user":{"login":"electronicvisions","id":8694914,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2OTQ5MTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/8694914?v=4","gravatar_id":"","url":"https://api.github.com/users/electronicvisions","html_url":"https://github.com/electronicvisions","followers_url":"https://api.github.com/users/electronicvisions/followers","following_url":"https://api.github.com/users/electronicvisions/following{/other_user}","gists_url":"https://api.github.com/users/electronicvisions/gists{/gist_id}","starred_url":"https://api.github.com/users/electronicvisions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electronicvisions/subscriptions","organizations_url":"https://api.github.com/users/electronicvisions/orgs","repos_url":"https://api.github.com/users/electronicvisions/repos","events_url":"https://api.github.com/users/electronicvisions/events{/privacy}","received_events_url":"https://api.github.com/users/electronicvisions/received_events","type":"Organization","site_admin":false},"repo":{"id":68591383,"node_id":"MDEwOlJlcG9zaXRvcnk2ODU5MTM4Mw==","name":"spack","full_name":"electronicvisions/spack","private":false,"owner":{"login":"electronicvisions","id":8694914,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg2OTQ5MTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/8694914?v=4","gravatar_id":"","url":"https://api.github.com/users/electronicvisions","html_url":"https://github.com/electronicvisions","followers_url":"https://api.github.com/users/electronicvisions/followers","following_url":"https://api.github.com/users/electronicvisions/following{/other_user}","gists_url":"https://api.github.com/users/electronicvisions/gists{/gist_id}","starred_url":"https://api.github.com/users/electronicvisions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/electronicvisions/subscriptions","organizations_url":"https://api.github.com/users/electronicvisions/orgs","repos_url":"https://api.github.com/users/electronicvisions/repos","events_url":"https://api.github.com/users/electronicvisions/events{/privacy}","received_events_url":"https://api.github.com/users/electronicvisions/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/electronicvisions/spack","description":"A flexible package manager designed to support multiple versions, configurations, platforms, and compilers.","fork":true,"url":"https://api.github.com/repos/electronicvisions/spack","forks_url":"https://api.github.com/repos/electronicvisions/spack/forks","keys_url":"https://api.github.com/repos/electronicvisions/spack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/electronicvisions/spack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/electronicvisions/spack/teams","hooks_url":"https://api.github.com/repos/electronicvisions/spack/hooks","issue_events_url":"https://api.github.com/repos/electronicvisions/spack/issues/events{/number}","events_url":"https://api.github.com/repos/electronicvisions/spack/events","assignees_url":"https://api.github.com/repos/electronicvisions/spack/assignees{/user}","branches_url":"https://api.github.com/repos/electronicvisions/spack/branches{/branch}","tags_url":"https://api.github.com/repos/electronicvisions/spack/tags","blobs_url":"https://api.github.com/repos/electronicvisions/spack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/electronicvisions/spack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/electronicvisions/spack/git/refs{/sha}","trees_url":"https://api.github.com/repos/electronicvisions/spack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/electronicvisions/spack/statuses/{sha}","languages_url":"https://api.github.com/repos/electronicvisions/spack/languages","stargazers_url":"https://api.github.com/repos/electronicvisions/spack/stargazers","contributors_url":"https://api.github.com/repos/electronicvisions/spack/contributors","subscribers_url":"https://api.github.com/repos/electronicvisions/spack/subscribers","subscription_url":"https://api.github.com/repos/electronicvisions/spack/subscription","commits_url":"https://api.github.com/repos/electronicvisions/spack/commits{/sha}","git_commits_url":"https://api.github.com/repos/electronicvisions/spack/git/commits{/sha}","comments_url":"https://api.github.com/repos/electronicvisions/spack/comments{/number}","issue_comment_url":"https://api.github.com/repos/electronicvisions/spack/issues/comments{/number}","contents_url":"https://api.github.com/repos/electronicvisions/spack/contents/{+path}","compare_url":"https://api.github.com/repos/electronicvisions/spack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/electronicvisions/spack/merges","archive_url":"https://api.github.com/repos/electronicvisions/spack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/electronicvisions/spack/downloads","issues_url":"https://api.github.com/repos/electronicvisions/spack/issues{/number}","pulls_url":"https://api.github.com/repos/electronicvisions/spack/pulls{/number}","milestones_url":"https://api.github.com/repos/electronicvisions/spack/milestones{/number}","notifications_url":"https://api.github.com/repos/electronicvisions/spack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/electronicvisions/spack/labels{/name}","releases_url":"https://api.github.com/repos/electronicvisions/spack/releases{/id}","deployments_url":"https://api.github.com/repos/electronicvisions/spack/deployments","created_at":"2016-09-19T09:39:12Z","updated_at":"2018-06-29T08:31:23Z","pushed_at":"2018-10-11T14:28:10Z","git_url":"git://github.com/electronicvisions/spack.git","ssh_url":"git@github.com:electronicvisions/spack.git","clone_url":"https://github.com/electronicvisions/spack.git","svn_url":"https://github.com/electronicvisions/spack","homepage":"http://software.llnl.gov/spack","size":44558,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"spack:develop","ref":"develop","sha":"ccbff6e0cdc1e4e045656a784e28225f416a8ed4","user":{"login":"spack","id":25539161,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NTM5MTYx","avatar_url":"https://avatars2.githubusercontent.com/u/25539161?v=4","gravatar_id":"","url":"https://api.github.com/users/spack","html_url":"https://github.com/spack","followers_url":"https://api.github.com/users/spack/followers","following_url":"https://api.github.com/users/spack/following{/other_user}","gists_url":"https://api.github.com/users/spack/gists{/gist_id}","starred_url":"https://api.github.com/users/spack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spack/subscriptions","organizations_url":"https://api.github.com/users/spack/orgs","repos_url":"https://api.github.com/users/spack/repos","events_url":"https://api.github.com/users/spack/events{/privacy}","received_events_url":"https://api.github.com/users/spack/received_events","type":"Organization","site_admin":false},"repo":{"id":15730865,"node_id":"MDEwOlJlcG9zaXRvcnkxNTczMDg2NQ==","name":"spack","full_name":"spack/spack","private":false,"owner":{"login":"spack","id":25539161,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NTM5MTYx","avatar_url":"https://avatars2.githubusercontent.com/u/25539161?v=4","gravatar_id":"","url":"https://api.github.com/users/spack","html_url":"https://github.com/spack","followers_url":"https://api.github.com/users/spack/followers","following_url":"https://api.github.com/users/spack/following{/other_user}","gists_url":"https://api.github.com/users/spack/gists{/gist_id}","starred_url":"https://api.github.com/users/spack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spack/subscriptions","organizations_url":"https://api.github.com/users/spack/orgs","repos_url":"https://api.github.com/users/spack/repos","events_url":"https://api.github.com/users/spack/events{/privacy}","received_events_url":"https://api.github.com/users/spack/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/spack/spack","description":"A flexible package manager that supports multiple versions, configurations, platforms, and compilers.","fork":false,"url":"https://api.github.com/repos/spack/spack","forks_url":"https://api.github.com/repos/spack/spack/forks","keys_url":"https://api.github.com/repos/spack/spack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spack/spack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spack/spack/teams","hooks_url":"https://api.github.com/repos/spack/spack/hooks","issue_events_url":"https://api.github.com/repos/spack/spack/issues/events{/number}","events_url":"https://api.github.com/repos/spack/spack/events","assignees_url":"https://api.github.com/repos/spack/spack/assignees{/user}","branches_url":"https://api.github.com/repos/spack/spack/branches{/branch}","tags_url":"https://api.github.com/repos/spack/spack/tags","blobs_url":"https://api.github.com/repos/spack/spack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spack/spack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spack/spack/git/refs{/sha}","trees_url":"https://api.github.com/repos/spack/spack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spack/spack/statuses/{sha}","languages_url":"https://api.github.com/repos/spack/spack/languages","stargazers_url":"https://api.github.com/repos/spack/spack/stargazers","contributors_url":"https://api.github.com/repos/spack/spack/contributors","subscribers_url":"https://api.github.com/repos/spack/spack/subscribers","subscription_url":"https://api.github.com/repos/spack/spack/subscription","commits_url":"https://api.github.com/repos/spack/spack/commits{/sha}","git_commits_url":"https://api.github.com/repos/spack/spack/git/commits{/sha}","comments_url":"https://api.github.com/repos/spack/spack/comments{/number}","issue_comment_url":"https://api.github.com/repos/spack/spack/issues/comments{/number}","contents_url":"https://api.github.com/repos/spack/spack/contents/{+path}","compare_url":"https://api.github.com/repos/spack/spack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spack/spack/merges","archive_url":"https://api.github.com/repos/spack/spack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spack/spack/downloads","issues_url":"https://api.github.com/repos/spack/spack/issues{/number}","pulls_url":"https://api.github.com/repos/spack/spack/pulls{/number}","milestones_url":"https://api.github.com/repos/spack/spack/milestones{/number}","notifications_url":"https://api.github.com/repos/spack/spack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spack/spack/labels{/name}","releases_url":"https://api.github.com/repos/spack/spack/releases{/id}","deployments_url":"https://api.github.com/repos/spack/spack/deployments","created_at":"2014-01-08T09:22:12Z","updated_at":"2018-10-11T17:48:14Z","pushed_at":"2018-10-11T20:33:43Z","git_url":"git://github.com/spack/spack.git","ssh_url":"git@github.com:spack/spack.git","clone_url":"https://github.com/spack/spack.git","svn_url":"https://github.com/spack/spack","homepage":"https://spack.io","size":47033,"stargazers_count":677,"watchers_count":677,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":521,"mirror_url":null,"archived":false,"open_issues_count":1075,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":521,"open_issues":1075,"watchers":677,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/spack/spack/pulls/9207"},"html":{"href":"https://github.com/spack/spack/pull/9207"},"issue":{"href":"https://api.github.com/repos/spack/spack/issues/9207"},"comments":{"href":"https://api.github.com/repos/spack/spack/issues/9207/comments"},"review_comments":{"href":"https://api.github.com/repos/spack/spack/pulls/9207/comments"},"review_comment":{"href":"https://api.github.com/repos/spack/spack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spack/spack/pulls/9207/commits"},"statuses":{"href":"https://api.github.com/repos/spack/spack/statuses/aaef32bb342caa871eb64e9f32530ce72066e00e"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"neilflood"}}