{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/acs-engine/pulls/comments/206953177","pull_request_review_id":142466955,"id":206953177,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjk1MzE3Nw==","diff_hunk":"@@ -0,0 +1,47 @@\n+{\r\n+  \"apiVersion\": \"vlabs\",\r\n+  \"properties\": {\r\n+    \"orchestratorProfile\": {\r\n+      \"orchestratorType\": \"Kubernetes\",\r\n+      \"orchestratorRelease\": \"1.10\",\r\n+      \"kubernetesConfig\": {\r\n+          \"clusterSubnet\": \"172.16.3.0/24\",\r\n+          \"privateCluster\": {\r\n+              \"enabled\": true\r\n+          }\r\n+      }\r\n+    },\r\n+    \"masterProfile\": {\r\n+      \"count\": 1,\r\n+      \"dnsPrefix\": \"newprivatecluster\",\r\n+      \"vmSize\": \"Standard_D2_v2\",\r\n+      \"vnetSubnetId\": \"/subscriptions/931980ec-6458-48c2-9668-354453011dac/resourceGroups/RG-NAME/providers/Microsoft.Network/virtualNetworks/VNET-NAME/subnets/SUBNET-NAME\",\r","path":"examples/vnet/kubernetesvnet-vmss.json","position":18,"original_position":18,"commit_id":"c84f5c1b10a30d9e1d2699688e63bac2f09b7c67","original_commit_id":"c84f5c1b10a30d9e1d2699688e63bac2f09b7c67","user":{"login":"CecileRobertMichon","id":8650424,"node_id":"MDQ6VXNlcjg2NTA0MjQ=","avatar_url":"https://avatars2.githubusercontent.com/u/8650424?v=4","gravatar_id":"","url":"https://api.github.com/users/CecileRobertMichon","html_url":"https://github.com/CecileRobertMichon","followers_url":"https://api.github.com/users/CecileRobertMichon/followers","following_url":"https://api.github.com/users/CecileRobertMichon/following{/other_user}","gists_url":"https://api.github.com/users/CecileRobertMichon/gists{/gist_id}","starred_url":"https://api.github.com/users/CecileRobertMichon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CecileRobertMichon/subscriptions","organizations_url":"https://api.github.com/users/CecileRobertMichon/orgs","repos_url":"https://api.github.com/users/CecileRobertMichon/repos","events_url":"https://api.github.com/users/CecileRobertMichon/events{/privacy}","received_events_url":"https://api.github.com/users/CecileRobertMichon/received_events","type":"User","site_admin":false},"body":"Let's make the vnetSubnetId `\"/subscriptions/SUB_ID/resourceGroups/RG_NAME/providers/Microsoft.Network/virtualNetworks/VNET_NAME/subnets/SUBNET_NAME\"` to be consistent with other example files (and remove the hardcoded sub ID)","created_at":"2018-08-01T16:48:16Z","updated_at":"2018-08-01T16:48:17Z","html_url":"https://github.com/Azure/acs-engine/pull/3597#discussion_r206953177","pull_request_url":"https://api.github.com/repos/Azure/acs-engine/pulls/3597","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/comments/206953177"},"html":{"href":"https://github.com/Azure/acs-engine/pull/3597#discussion_r206953177"},"pull_request":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/3597"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/acs-engine/pulls/3597","id":205316430,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MzE2NDMw","html_url":"https://github.com/Azure/acs-engine/pull/3597","diff_url":"https://github.com/Azure/acs-engine/pull/3597.diff","patch_url":"https://github.com/Azure/acs-engine/pull/3597.patch","issue_url":"https://api.github.com/repos/Azure/acs-engine/issues/3597","number":3597,"state":"open","locked":false,"title":"custom vNet and VMSS","user":{"login":"shayshahak","id":18166141,"node_id":"MDQ6VXNlcjE4MTY2MTQx","avatar_url":"https://avatars3.githubusercontent.com/u/18166141?v=4","gravatar_id":"","url":"https://api.github.com/users/shayshahak","html_url":"https://github.com/shayshahak","followers_url":"https://api.github.com/users/shayshahak/followers","following_url":"https://api.github.com/users/shayshahak/following{/other_user}","gists_url":"https://api.github.com/users/shayshahak/gists{/gist_id}","starred_url":"https://api.github.com/users/shayshahak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shayshahak/subscriptions","organizations_url":"https://api.github.com/users/shayshahak/orgs","repos_url":"https://api.github.com/users/shayshahak/repos","events_url":"https://api.github.com/users/shayshahak/events{/privacy}","received_events_url":"https://api.github.com/users/shayshahak/received_events","type":"User","site_admin":false},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If you want *faster* PR reviews, read how: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**If applicable**:\r\n- [ ] documentation\r\n- [ ] unit tests\r\n- [ ] tested backward compatibility (ie. deploy with previous version, upgrade with this branch)\r\n\r\n**Release note**:\r\n<!--  Steps to write your release note:\r\n1. Use the release-note-* labels to set the release note state (if you have access)\r\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`.\r\n-->\r\n```release-note\r\n```\r\n","created_at":"2018-08-01T05:58:26Z","updated_at":"2018-08-01T16:48:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"baba4926b10a582e91f1eff4fdeb6bd6711d792a","assignee":{"login":"jackfrancis","id":1494193,"node_id":"MDQ6VXNlcjE0OTQxOTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1494193?v=4","gravatar_id":"","url":"https://api.github.com/users/jackfrancis","html_url":"https://github.com/jackfrancis","followers_url":"https://api.github.com/users/jackfrancis/followers","following_url":"https://api.github.com/users/jackfrancis/following{/other_user}","gists_url":"https://api.github.com/users/jackfrancis/gists{/gist_id}","starred_url":"https://api.github.com/users/jackfrancis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackfrancis/subscriptions","organizations_url":"https://api.github.com/users/jackfrancis/orgs","repos_url":"https://api.github.com/users/jackfrancis/repos","events_url":"https://api.github.com/users/jackfrancis/events{/privacy}","received_events_url":"https://api.github.com/users/jackfrancis/received_events","type":"User","site_admin":false},"assignees":[{"login":"jackfrancis","id":1494193,"node_id":"MDQ6VXNlcjE0OTQxOTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1494193?v=4","gravatar_id":"","url":"https://api.github.com/users/jackfrancis","html_url":"https://github.com/jackfrancis","followers_url":"https://api.github.com/users/jackfrancis/followers","following_url":"https://api.github.com/users/jackfrancis/following{/other_user}","gists_url":"https://api.github.com/users/jackfrancis/gists{/gist_id}","starred_url":"https://api.github.com/users/jackfrancis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackfrancis/subscriptions","organizations_url":"https://api.github.com/users/jackfrancis/orgs","repos_url":"https://api.github.com/users/jackfrancis/repos","events_url":"https://api.github.com/users/jackfrancis/events{/privacy}","received_events_url":"https://api.github.com/users/jackfrancis/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":936790424,"node_id":"MDU6TGFiZWw5MzY3OTA0MjQ=","url":"https://api.github.com/repos/Azure/acs-engine/labels/size/M","name":"size/M","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/acs-engine/pulls/3597/commits","review_comments_url":"https://api.github.com/repos/Azure/acs-engine/pulls/3597/comments","review_comment_url":"https://api.github.com/repos/Azure/acs-engine/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/acs-engine/issues/3597/comments","statuses_url":"https://api.github.com/repos/Azure/acs-engine/statuses/c84f5c1b10a30d9e1d2699688e63bac2f09b7c67","head":{"label":"shayshahak:master","ref":"master","sha":"c84f5c1b10a30d9e1d2699688e63bac2f09b7c67","user":{"login":"shayshahak","id":18166141,"node_id":"MDQ6VXNlcjE4MTY2MTQx","avatar_url":"https://avatars3.githubusercontent.com/u/18166141?v=4","gravatar_id":"","url":"https://api.github.com/users/shayshahak","html_url":"https://github.com/shayshahak","followers_url":"https://api.github.com/users/shayshahak/followers","following_url":"https://api.github.com/users/shayshahak/following{/other_user}","gists_url":"https://api.github.com/users/shayshahak/gists{/gist_id}","starred_url":"https://api.github.com/users/shayshahak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shayshahak/subscriptions","organizations_url":"https://api.github.com/users/shayshahak/orgs","repos_url":"https://api.github.com/users/shayshahak/repos","events_url":"https://api.github.com/users/shayshahak/events{/privacy}","received_events_url":"https://api.github.com/users/shayshahak/received_events","type":"User","site_admin":false},"repo":{"id":143109841,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMxMDk4NDE=","name":"acs-engine","full_name":"shayshahak/acs-engine","owner":{"login":"shayshahak","id":18166141,"node_id":"MDQ6VXNlcjE4MTY2MTQx","avatar_url":"https://avatars3.githubusercontent.com/u/18166141?v=4","gravatar_id":"","url":"https://api.github.com/users/shayshahak","html_url":"https://github.com/shayshahak","followers_url":"https://api.github.com/users/shayshahak/followers","following_url":"https://api.github.com/users/shayshahak/following{/other_user}","gists_url":"https://api.github.com/users/shayshahak/gists{/gist_id}","starred_url":"https://api.github.com/users/shayshahak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shayshahak/subscriptions","organizations_url":"https://api.github.com/users/shayshahak/orgs","repos_url":"https://api.github.com/users/shayshahak/repos","events_url":"https://api.github.com/users/shayshahak/events{/privacy}","received_events_url":"https://api.github.com/users/shayshahak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shayshahak/acs-engine","description":"Azure Container Service Engine - provision and deploy container orchestrators on Azure: Kubernetes, DC/OS, and Docker Swarm.","fork":true,"url":"https://api.github.com/repos/shayshahak/acs-engine","forks_url":"https://api.github.com/repos/shayshahak/acs-engine/forks","keys_url":"https://api.github.com/repos/shayshahak/acs-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shayshahak/acs-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shayshahak/acs-engine/teams","hooks_url":"https://api.github.com/repos/shayshahak/acs-engine/hooks","issue_events_url":"https://api.github.com/repos/shayshahak/acs-engine/issues/events{/number}","events_url":"https://api.github.com/repos/shayshahak/acs-engine/events","assignees_url":"https://api.github.com/repos/shayshahak/acs-engine/assignees{/user}","branches_url":"https://api.github.com/repos/shayshahak/acs-engine/branches{/branch}","tags_url":"https://api.github.com/repos/shayshahak/acs-engine/tags","blobs_url":"https://api.github.com/repos/shayshahak/acs-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shayshahak/acs-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shayshahak/acs-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/shayshahak/acs-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shayshahak/acs-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/shayshahak/acs-engine/languages","stargazers_url":"https://api.github.com/repos/shayshahak/acs-engine/stargazers","contributors_url":"https://api.github.com/repos/shayshahak/acs-engine/contributors","subscribers_url":"https://api.github.com/repos/shayshahak/acs-engine/subscribers","subscription_url":"https://api.github.com/repos/shayshahak/acs-engine/subscription","commits_url":"https://api.github.com/repos/shayshahak/acs-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/shayshahak/acs-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/shayshahak/acs-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/shayshahak/acs-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/shayshahak/acs-engine/contents/{+path}","compare_url":"https://api.github.com/repos/shayshahak/acs-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shayshahak/acs-engine/merges","archive_url":"https://api.github.com/repos/shayshahak/acs-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shayshahak/acs-engine/downloads","issues_url":"https://api.github.com/repos/shayshahak/acs-engine/issues{/number}","pulls_url":"https://api.github.com/repos/shayshahak/acs-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/shayshahak/acs-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/shayshahak/acs-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shayshahak/acs-engine/labels{/name}","releases_url":"https://api.github.com/repos/shayshahak/acs-engine/releases{/id}","deployments_url":"https://api.github.com/repos/shayshahak/acs-engine/deployments","created_at":"2018-08-01T05:52:17Z","updated_at":"2018-08-01T05:56:00Z","pushed_at":"2018-08-01T05:55:58Z","git_url":"git://github.com/shayshahak/acs-engine.git","ssh_url":"git@github.com:shayshahak/acs-engine.git","clone_url":"https://github.com/shayshahak/acs-engine.git","svn_url":"https://github.com/shayshahak/acs-engine","homepage":"","size":77993,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"0b3b9d193d772a093e1670695733ae2cee8c1a73","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":66011370,"node_id":"MDEwOlJlcG9zaXRvcnk2NjAxMTM3MA==","name":"acs-engine","full_name":"Azure/acs-engine","owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/acs-engine","description":"Azure Container Service Engine - provision and deploy container orchestrators on Azure: Kubernetes, DC/OS, and Docker Swarm.","fork":false,"url":"https://api.github.com/repos/Azure/acs-engine","forks_url":"https://api.github.com/repos/Azure/acs-engine/forks","keys_url":"https://api.github.com/repos/Azure/acs-engine/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/acs-engine/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/acs-engine/teams","hooks_url":"https://api.github.com/repos/Azure/acs-engine/hooks","issue_events_url":"https://api.github.com/repos/Azure/acs-engine/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/acs-engine/events","assignees_url":"https://api.github.com/repos/Azure/acs-engine/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/acs-engine/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/acs-engine/tags","blobs_url":"https://api.github.com/repos/Azure/acs-engine/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/acs-engine/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/acs-engine/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/acs-engine/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/acs-engine/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/acs-engine/languages","stargazers_url":"https://api.github.com/repos/Azure/acs-engine/stargazers","contributors_url":"https://api.github.com/repos/Azure/acs-engine/contributors","subscribers_url":"https://api.github.com/repos/Azure/acs-engine/subscribers","subscription_url":"https://api.github.com/repos/Azure/acs-engine/subscription","commits_url":"https://api.github.com/repos/Azure/acs-engine/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/acs-engine/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/acs-engine/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/acs-engine/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/acs-engine/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/acs-engine/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/acs-engine/merges","archive_url":"https://api.github.com/repos/Azure/acs-engine/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/acs-engine/downloads","issues_url":"https://api.github.com/repos/Azure/acs-engine/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/acs-engine/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/acs-engine/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/acs-engine/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/acs-engine/labels{/name}","releases_url":"https://api.github.com/repos/Azure/acs-engine/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/acs-engine/deployments","created_at":"2016-08-18T16:05:16Z","updated_at":"2018-08-01T03:26:23Z","pushed_at":"2018-08-01T16:41:33Z","git_url":"git://github.com/Azure/acs-engine.git","ssh_url":"git@github.com:Azure/acs-engine.git","clone_url":"https://github.com/Azure/acs-engine.git","svn_url":"https://github.com/Azure/acs-engine","homepage":"","size":88133,"stargazers_count":897,"watchers_count":897,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":558,"mirror_url":null,"archived":false,"open_issues_count":563,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":558,"open_issues":563,"watchers":897,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/3597"},"html":{"href":"https://github.com/Azure/acs-engine/pull/3597"},"issue":{"href":"https://api.github.com/repos/Azure/acs-engine/issues/3597"},"comments":{"href":"https://api.github.com/repos/Azure/acs-engine/issues/3597/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/3597/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/acs-engine/pulls/3597/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/acs-engine/statuses/c84f5c1b10a30d9e1d2699688e63bac2f09b7c67"}},"author_association":"NONE"}}
{"actor":{"display_login":"CecileRobertMichon"}}