{"push_id":3030097230,"size":12,"distinct_size":0,"ref":"refs/heads/lkgr-android-internal","head":"1c12500afbae9a30809e34b5ad0113eda5f606b1","before":"d9207bf9a8c1f0266bad4050586e63ab34364988","commits":[{"sha":"2d5d35d8aa91dd959ba9bf5bf9be30d89137332d","author":{"name":"Kevin Marshall","email":"1d61c612a47f305bb35d411a53dfa8ad0544a552@chromium.org"},"message":"Fuchsia: Include SSH keys in zircon.zbi, eliminate FVM creation.\n\nFuchsia's SDK FVM file now includes its own minfs partition which\ncollides with the minfs partition that we create in our runner scripts.\nWe relied on the partition to supply client public keys to sshd on the\ndevice.\n\nThis change adds the keys directly to the Zircon boot image at runtime\nand boots using the modified image.\n\nRolls SDK to 9853d7bcb5f3944a9f3e599dbd4ec6ee1ce95852.\n\nBug: 902908\nChange-Id: I5bb15756039d1b3b58a4f3989b13a5b88496d1fd\nReviewed-on: https://chromium-review.googlesource.com/c/1324234\nCommit-Queue: Kevin Marshall <kmarshall@chromium.org>\nReviewed-by: Sergey Ulanov <sergeyu@chromium.org>\nCr-Commit-Position: refs/heads/master@{#606302}","distinct":false,"url":"https://api.github.com/repos/chromium/chromium/commits/2d5d35d8aa91dd959ba9bf5bf9be30d89137332d"},{"sha":"3fb63360f23c7ba71c3b595e935f99a62a01835c","author":{"name":"Bo Liu","email":"bc579652988c4c89a85c01792240e330d2e727f7@chromium.org"},"message":"android: Throw if WebContentsImpl is used after destroy\n\nRight now the trend is to just add a null check every time there is a\ncrash in native code. I'm going to reverse this by putting all remaining\nWebContentsImpl native calls behind an IllegalStateException check. Then\nwe'll know exactly what code is causing these exceptions, and fix the\nclient code accordingly.\n\nInspired by crbug.com/901130 although this is not directly relevant.\n\nChange-Id: I444b912db01567925b6f662d2c11267d60e54624\nReviewed-on: https://chromium-review.googlesource.com/c/1324992\nReviewed-by: Ted Choc <tedchoc@chromium.org>\nCommit-Queue: Bo <boliu@chromium.org>\nCr-Commit-Position: refs/heads/master@{#606303}","distinct":false,"url":"https://api.github.com/repos/chromium/chromium/commits/3fb63360f23c7ba71c3b595e935f99a62a01835c"},{"sha":"29602085f18375313160d9d6bcbd1a5a21ec7cc3","author":{"name":"Christopher Lam","email":"18e52e3935d9575f2c5abdd40bd31ebab23f0f3e@chromium.org"},"message":"[Mojo WebUI] Modify testing framework to support Mojo Lite WebUIs.\n\nThis CL adds support to js2gtest for Mojo Lite WebUI Browser\nTests. This involves adding an extra mojo_lite_webui test type, and\nadding the lite bindings to the page when a test is run.\n\nBug: 849993\nChange-Id: Idadb098fb4c4a67535f59c80c8b4781a635da59b\nReviewed-on: https://chromium-review.googlesource.com/c/1309556\nReviewed-by: David Tseng <dtseng@chromium.org>\nReviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>\nCommit-Queue: calamity <calamity@chromium.org>\nCr-Commit-Position: refs/heads/master@{#606304}","distinct":false,"url":"https://api.github.com/repos/chromium/chromium/commits/29602085f18375313160d9d6bcbd1a5a21ec7cc3"},{"sha":"2cc5b2b802b49f95b70f2e2483a021ad066ba50c","author":{"name":"Regan Hsu","email":"06d0d891e19b596b8377ed5655ee64285620b570@chromium.org"},"message":"[CrOS MultiDevice] Metrics for MultiDevice.SetupNotification.Dismissed\n\nAn enumerated histogram with 3 buckets:\n1) “New user, potential host exists”,\n2) “Existing user, host switched”, and\n3) “Existing user, new Chromebook added”.\n\nTracks if users are actively dismissing our notifications.\n\nBug: 870138\nChange-Id: If46245c1be7528d63a92d51607c63bded8b391d2\nReviewed-on: https://chromium-review.googlesource.com/c/1316446\nReviewed-by: James Cook <jamescook@chromium.org>\nReviewed-by: Steven Holte <holte@chromium.org>\nReviewed-by: Kyle Horimoto <khorimoto@chromium.org>\nReviewed-by: Ryan Hansberry <hansberry@chromium.org>\nCommit-Queue: Regan Hsu <hsuregan@chromium.org>\nCr-Commit-Position: refs/heads/master@{#606305}","distinct":false,"url":"https://api.github.com/repos/chromium/chromium/commits/2cc5b2b802b49f95b70f2e2483a021ad066ba50c"},{"sha":"891636646c163b2ad0ff84704fa12bbf26acf984","author":{"name":"Etienne Pierre-doray","email":"5dcbd5f90bfc9ce5b5b151185e16104a967918d1@chromium.org"},"message":"[TaskScheudler]: Migrate off of ScopedAllowWait in /content/browser/gpu\n\nbase::ThreadRestrictions::ScopedAllowWait is deprecated in favor of its more\nexplicit counterpart.\n\nIt should have been replaced by :\n * base::ScopedAllowBaseSyncPrimitivesForTesting in test files.\n * base::ScopedAllowSyncPrimitives in non-test files\n * base::ScopedAllowSyncPrimitivesOutsideBlockingScope when it's used on threads\n   that don't allow blocking\nThe last one is strongly frowned upon but this CL aims to document existing\nbehavior rather than address it. Owners are encouraged to follow-up by fixing\nunnecessary waits and more particularly unnecessary waits\noutside-blocking-scope.\n\nNote: The non-for-testing versions require friend'ing in thread_restrictions.h\nbut care was taken to add these friends ahead of git cl split (since it wasn't\npossible to do a line-by-line associated CL split).\nRefer to the top-level CL if necessary :\nhttps://chromium-review.googlesource.com/c/chromium/src/+/1288533\n\nPlease CQ if LGTY!\n\nThis CL was uploaded by git cl split.\n\nR=backer@chromium.org\n\nBug: 766678\nChange-Id: I91a476bd46437c98a53cfdb2ac5c438dde1e495c\nReviewed-on: https://chromium-review.googlesource.com/c/1325193\nReviewed-by: Antoine Labour <piman@chromium.org>\nCommit-Queue: Antoine Labour <piman@chromium.org>\nCr-Commit-Position: refs/heads/master@{#606306}","distinct":false,"url":"https://api.github.com/repos/chromium/chromium/commits/891636646c163b2ad0ff84704fa12bbf26acf984"},{"sha":"b4186454ed32ad6d9f2a41378a87e1d599fe9c18","author":{"name":"chromium-autoroll","email":"a3680534fa21f849f725bea9c9fb3f7f637bcd8d@skia-public.iam.gserviceaccount.com"},"message":"Roll src/third_party/depot_tools 49c8eafcd54c..75fa8552337b (1 commits)\n\nhttps://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/49c8eafcd54c..75fa8552337b\n\n\ngit log 49c8eafcd54c..75fa8552337b --date=short --no-merges --format='%ad %ae %s'\n2018-11-07 kylixrd@chromium.org Quote the full path to ninja.exe.\n\n\nCreated with:\n  gclient setdep -r src/third_party/depot_tools@75fa8552337b\n\nThe AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll\n\nDocumentation for the AutoRoller is here:\nhttps://skia.googlesource.com/buildbot/+/master/autoroll/README.md\n\nIf the roll is causing failures, please contact the current sheriff, who should\nbe CC'd on the roll, and stop the roller if necessary.\n\n\n\nBUG=chromium:902930\nTBR=agable@chromium.org\n\nChange-Id: I1b849e997ef8e1b4a02affbd5dc8575bfb3b8664\nReviewed-on: https://chromium-review.googlesource.com/c/1324856\nReviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>\nCommit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>\nCr-Commit-Position: refs/heads/master@{#606307}","distinct":false,"url":"https://api.github.com/repos/chromium/chromium/commits/b4186454ed32ad6d9f2a41378a87e1d599fe9c18"},{"sha":"c972056412f05ea6253d8c678cd0c789f9396244","author":{"name":"Oystein Eftevaag","email":"8d7f732fa4b6826c6c0eeb84e0f59560c57cc941@chromium.org"},"message":"Reland \"Perfetto: Optimization to avoid string table lookup for _END events\"\n\nThis reverts commit 7acd0b524621d76fbaefdf397fdb37662bd8bf66.\n\nReason for revert: Re-landing with crashfix\n\nOriginal change's description:\n> Revert \"Perfetto: Optimization to avoid string table lookup for _END events\"\n> \n> This reverts commit a7afe430785635f9608a2c0889295d698547a87b.\n> \n> Reason for revert: I suspect this may have caused crashes on https://ci.chromium.org/p/chrome/builders/luci.chrome.ci/linux-perf-fyi#\n> \n> Original change's description:\n> > Perfetto: Optimization to avoid string table lookup for _END events\n> > \n> > If we're emitting an _END trace event, we know that the string\n> > table entries for the name and the categories have already been\n> > emitted and so we don't need to check the string table in this\n> > case.\n> > \n> > R=​primiano@chromium.org,skyostil@chromium.org\n> > \n> > Change-Id: I9107bffb0b48f7b71d0a42961a78a3861ffcb76f\n> > Reviewed-on: https://chromium-review.googlesource.com/c/1258043\n> > Commit-Queue: oysteine <oysteine@chromium.org>\n> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>\n> > Cr-Commit-Position: refs/heads/master@{#600183}\n> \n> TBR=primiano@chromium.org,oysteine@chromium.org,skyostil@chromium.org\n> \n> # Not skipping CQ checks because original CL landed > 1 day ago.\n> \n> Change-Id: Ia460750fcaf338c4bf24ee7317d58b7aeede9520\n> Reviewed-on: https://chromium-review.googlesource.com/c/1293612\n> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>\n> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>\n> Cr-Commit-Position: refs/heads/master@{#601586}\n\nTBR=cbiesinger@chromium.org,primiano@chromium.org,oysteine@chromium.org,skyostil@chromium.org\n\n# Not skipping CQ checks because original CL landed > 1 day ago.\n\nChange-Id: I8f3b5c21494d66fe9e6c25363627ec156f5abf12\nReviewed-on: https://chromium-review.googlesource.com/c/1325077\nCommit-Queue: oysteine <oysteine@chromium.org>\nReviewed-by: oysteine <oysteine@chromium.org>\nCr-Commit-Position: refs/heads/master@{#606308}","distinct":false,"url":"https://api.github.com/repos/chromium/chromium/commits/c972056412f05ea6253d8c678cd0c789f9396244"},{"sha":"c162a12d439022ab10f8fd3ddca62e1d71606869","author":{"name":"Daniel Rubery","email":"669c4a0d80114c1cf702df408d1c1e77f5adc601@chromium.org"},"message":"Add pyo and pyd as tracked file types\n\nExtensions can download and execute a pyo or pyd with no user gestures,\nallowing for remote code execution. By marking pyo and pyd as\nALLOW_ON_USER_GESTURE and DANGEROUS, respectively, we prevent this\nbehavior.\n\nBug: 902234\nChange-Id: I295cdd2906ebe779670afb55196cea7715dc88f4\nReviewed-on: https://chromium-review.googlesource.com/c/1324419\nCommit-Queue: Daniel Rubery <drubery@chromium.org>\nReviewed-by: Nathan Parker <nparker@chromium.org>\nCr-Commit-Position: refs/heads/master@{#606309}","distinct":false,"url":"https://api.github.com/repos/chromium/chromium/commits/c162a12d439022ab10f8fd3ddca62e1d71606869"},{"sha":"053d52a2f1a3d443da56875b4631d8ba1b4acb1b","author":{"name":"Kent Tamura","email":"e0e84ce4a33dcc115f06c0609c8bb50720a44e41@chromium.org"},"message":"html: Fix an issue of type-change-state.html about selectionDirection=\"none\"\n\ntype-change-state.html contains assertions for the following operation in [1]:\n> ..., and set its selection direction to \"none\".\n\nHowever it had an issue that the assertions checked if\ninput.selectionDirection was \"none\". According to [2],\ninput.selectionDirection can be \"forward\" on specific platforms.\n\n> update the element's selection direction to the given direction, unless\n> the direction is \"none\" and the platform does not support that direction;\n> in that case, update the element's selection direction to \"forward\".\n\n[1] https://html.spec.whatwg.org/multipage/input.html#the-input-element:set-the-selection-direction\n[2] https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#set-the-selection-direction\n\nChange-Id: Idc1a97fbb2036e351a788a1f758b3239308d8c71\nReviewed-on: https://chromium-review.googlesource.com/c/1322264\nReviewed-by: Rakina Zata Amni <rakina@chromium.org>\nCommit-Queue: Kent Tamura <tkent@chromium.org>\nCr-Commit-Position: refs/heads/master@{#606310}","distinct":false,"url":"https://api.github.com/repos/chromium/chromium/commits/053d52a2f1a3d443da56875b4631d8ba1b4acb1b"},{"sha":"7b104eccb81d860641246c2780416186a5267d07","author":{"name":"Steven Bennetts","email":"d2bc269fbc7f1691ea11e20b3ea986cb219ed714@chromium.org"},"message":"Add Show/HideKeyboard methods to keybaord_controller.mojom\n\nThis CL:\n* Introduces ShowKeyboard, HideKeyboard, and IsKeyboardVisible\n  to keyboard_controller.mojom.\n* Includes HideReason for HideKeyboard (User or System).\n* Introduces keyboard::mojom::KeyboardEnableFlag::kTemporarilyEnabled\n  for temporarily enabling the keyboard and showing it.\n* Renames keyboard::mojom::ReloadKeyboard() -> RebuildKeyboardIfEnabled().\n* Introduces keyboard::mojom::ReloadKeyboardIfNeeded() which calls\n  KeyboardUI::ReloadKeyboardIfNeeded() which updates the keyboard URL if\n  it has changed and otherwise does nothing.\n* Replaces direct calls to KeyboardController from most of src/chrome\n  Notable exception: ChromeVirtualKeyboardDelegate which will be\n  transitioned in a follow up CL.\n\nBug: 843332\nChange-Id: I2faf000c8233ee0253b799a6e4780020ba3bbe1f\nReviewed-on: https://chromium-review.googlesource.com/c/1309215\nCommit-Queue: Steven Bennetts <stevenjb@chromium.org>\nReviewed-by: James Cook <jamescook@chromium.org>\nReviewed-by: Darren Shen <shend@chromium.org>\nReviewed-by: Scott Violet <sky@chromium.org>\nReviewed-by: Tom Sepez <tsepez@chromium.org>\nReviewed-by: Shu Chen <shuchen@chromium.org>\nCr-Commit-Position: refs/heads/master@{#606311}","distinct":false,"url":"https://api.github.com/repos/chromium/chromium/commits/7b104eccb81d860641246c2780416186a5267d07"},{"sha":"eec86ff6c03b228b426a4553c89724d04e0a0f56","author":{"name":"Sunny Sachanandani","email":"bebb08c8c2eff8f32c2eb603b2b1c4827c778be6@chromium.org"},"message":"Reenable direct composition without video layers\n\nReenable direct composition surface on devices without hardware overlays\nsince it enables other power improvements like flip mode swap chain and\ndisabling DWM redirection surface.\n\nTo mitigate the original concerns about direct composition, this change\nmakes DCLayerTree lazy initialize the video context and processor when\na video layer is first used.  On devices that don't support hardware\noverlays, the video context and processor will never be initialized.\n\nBug: 894675, 900702\nChange-Id: I8c9d5b78718de2620ca177410d4916390e7cb219\nReviewed-on: https://chromium-review.googlesource.com/c/1318808\nCommit-Queue: Sunny Sachanandani <sunnyps@chromium.org>\nReviewed-by: Zhenyao Mo <zmo@chromium.org>\nReviewed-by: Daniel Cheng <dcheng@chromium.org>\nReviewed-by: Antoine Labour <piman@chromium.org>\nCr-Commit-Position: refs/heads/master@{#606312}","distinct":false,"url":"https://api.github.com/repos/chromium/chromium/commits/eec86ff6c03b228b426a4553c89724d04e0a0f56"},{"sha":"1c12500afbae9a30809e34b5ad0113eda5f606b1","author":{"name":"Xiaocheng Hu","email":"59a3fcd17837bbbb682c8b6364c42a7a2ab279cb@chromium.org"},"message":"Convert fast/inline/dirtyLinesForInline.html with W3C testharness\n\nThis patch converts the layout test with W3C testharness so that\nit doesn't rely on text dump comparison.\n\nThis is also a preparation for using element.innerText as text\ndump; otherwise, this test generates different innerText dumps on\ndifferent platforms (crrev.com/c/1318149), which is undesired.\n\nBug: 887148\nChange-Id: Ic279b9362ff054eb13f847e111baef37d0ef79e3\nReviewed-on: https://chromium-review.googlesource.com/c/1323890\nReviewed-by: Kent Tamura <tkent@chromium.org>\nReviewed-by: Yoshifumi Inoue <yosin@chromium.org>\nCommit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>\nCr-Commit-Position: refs/heads/master@{#606313}","distinct":false,"url":"https://api.github.com/repos/chromium/chromium/commits/1c12500afbae9a30809e34b5ad0113eda5f606b1"}]}
{"actor":{"display_login":"aarongable"}}