{"action":"created","issue":{"url":"https://api.github.com/repos/vaadin/vaadin-button-flow/issues/75","repository_url":"https://api.github.com/repos/vaadin/vaadin-button-flow","labels_url":"https://api.github.com/repos/vaadin/vaadin-button-flow/issues/75/labels{/name}","comments_url":"https://api.github.com/repos/vaadin/vaadin-button-flow/issues/75/comments","events_url":"https://api.github.com/repos/vaadin/vaadin-button-flow/issues/75/events","html_url":"https://github.com/vaadin/vaadin-button-flow/pull/75","id":341116201,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMzY2MjM2","number":75,"title":"Depend on all WebJars explicitly to avoid version ranges in resulting jars.","user":{"login":"SomeoneToIgnore","id":2690773,"node_id":"MDQ6VXNlcjI2OTA3NzM=","avatar_url":"https://avatars0.githubusercontent.com/u/2690773?v=4","gravatar_id":"","url":"https://api.github.com/users/SomeoneToIgnore","html_url":"https://github.com/SomeoneToIgnore","followers_url":"https://api.github.com/users/SomeoneToIgnore/followers","following_url":"https://api.github.com/users/SomeoneToIgnore/following{/other_user}","gists_url":"https://api.github.com/users/SomeoneToIgnore/gists{/gist_id}","starred_url":"https://api.github.com/users/SomeoneToIgnore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SomeoneToIgnore/subscriptions","organizations_url":"https://api.github.com/users/SomeoneToIgnore/orgs","repos_url":"https://api.github.com/users/SomeoneToIgnore/repos","events_url":"https://api.github.com/users/SomeoneToIgnore/events{/privacy}","received_events_url":"https://api.github.com/users/SomeoneToIgnore/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-07-13T18:25:48Z","updated_at":"2018-07-15T17:15:10Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/vaadin/vaadin-button-flow/pulls/75","html_url":"https://github.com/vaadin/vaadin-button-flow/pull/75","diff_url":"https://github.com/vaadin/vaadin-button-flow/pull/75.diff","patch_url":"https://github.com/vaadin/vaadin-button-flow/pull/75.patch"},"body":"<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/vaadin/vaadin-button-flow/75)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/vaadin/vaadin-button-flow/issues/comments/405104884","html_url":"https://github.com/vaadin/vaadin-button-flow/pull/75#issuecomment-405104884","issue_url":"https://api.github.com/repos/vaadin/vaadin-button-flow/issues/75","id":405104884,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTEwNDg4NA==","user":{"login":"SomeoneToIgnore","id":2690773,"node_id":"MDQ6VXNlcjI2OTA3NzM=","avatar_url":"https://avatars0.githubusercontent.com/u/2690773?v=4","gravatar_id":"","url":"https://api.github.com/users/SomeoneToIgnore","html_url":"https://github.com/SomeoneToIgnore","followers_url":"https://api.github.com/users/SomeoneToIgnore/followers","following_url":"https://api.github.com/users/SomeoneToIgnore/following{/other_user}","gists_url":"https://api.github.com/users/SomeoneToIgnore/gists{/gist_id}","starred_url":"https://api.github.com/users/SomeoneToIgnore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SomeoneToIgnore/subscriptions","organizations_url":"https://api.github.com/users/SomeoneToIgnore/orgs","repos_url":"https://api.github.com/users/SomeoneToIgnore/repos","events_url":"https://api.github.com/users/SomeoneToIgnore/events{/privacy}","received_events_url":"https://api.github.com/users/SomeoneToIgnore/received_events","type":"User","site_admin":false},"created_at":"2018-07-15T17:15:10Z","updated_at":"2018-07-15T17:15:10Z","author_association":"NONE","body":"\n\n\n\n___\n*[pom.xml, line 75 at r1](https://reviewable.io/reviews/vaadin/vaadin-button-flow/75#-LHMcd474UZUreWjvK7J:-LHTuhT22W5L5J307j1Y:bafzbyj) ([raw file](https://github.com/vaadin/vaadin-button-flow/blob/255ddf74d155eb5e093c468c221332d13c584d5c/pom.xml#L75)):*\n<details><summary><i>Previously, denis-anisimov (Denis) wrote…</i></summary><blockquote>\n\nYes. That's the issue.\nWhen building this for the release this `WARNING` becomes `ERROR` and release fails.\nI don't remember which step it is. I'm not familiar with the release process in details.\nI remember that we have been releasing 4 days because of this error.\n\nSo I'm pretty sure it will arise one more time.\nMay be you can try do disable the very last step `deploy` (may be) in the TC release build and try to build and see.\nIt might be that this error happens also only on staging server which is used to build before release.\nAs I said: I don't remember details. You may ask Zhe. May be he recalls all issues related to that.\n\nBut I recommend revert exclusion back. It shouldn't be a big issue and should be safe for the release.\n</blockquote></details>\n\nOk, done, but done in `flow-component-base` `dependencyManagement` section.\nSince every WebJar is mentioned there, it works.\nI've checked with `mvn dependency:tree` that the dependency does not occur in any of the component wrappers if not explicitly included in the pom.\n\nAlso to note: in each of the component wrapper projects you have `flow-component-demo-helpers ` dependency\nhttps://github.com/vaadin/vaadin-button-flow/blob/master/pom.xml#L62 \nwhich has `vaadin-lumo-theme` dependency: \nhttps://github.com/vaadin/flow/blob/master/flow-components-parent/flow-component-demo-helpers/pom.xml#L48\nthat brings in `iron-flex-layout` transitive dependency.\n\nThis means that exclusions from test dependencies like\nhttps://github.com/vaadin/vaadin-button-flow/blob/master/pom.xml#L73\nare pretty much redundant.\n\n\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"SomeoneToIgnore"}}