{"action":"created","issue":{"url":"https://api.github.com/repos/ChasakisD/XFExpandableListView/issues/2","repository_url":"https://api.github.com/repos/ChasakisD/XFExpandableListView","labels_url":"https://api.github.com/repos/ChasakisD/XFExpandableListView/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/ChasakisD/XFExpandableListView/issues/2/comments","events_url":"https://api.github.com/repos/ChasakisD/XFExpandableListView/issues/2/events","html_url":"https://github.com/ChasakisD/XFExpandableListView/pull/2","id":360963347,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2MDUzNzE2","number":2,"title":"More than one group is crashing on iOS","user":{"login":"GregoryMaks","id":447927,"node_id":"MDQ6VXNlcjQ0NzkyNw==","avatar_url":"https://avatars0.githubusercontent.com/u/447927?v=4","gravatar_id":"","url":"https://api.github.com/users/GregoryMaks","html_url":"https://github.com/GregoryMaks","followers_url":"https://api.github.com/users/GregoryMaks/followers","following_url":"https://api.github.com/users/GregoryMaks/following{/other_user}","gists_url":"https://api.github.com/users/GregoryMaks/gists{/gist_id}","starred_url":"https://api.github.com/users/GregoryMaks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GregoryMaks/subscriptions","organizations_url":"https://api.github.com/users/GregoryMaks/orgs","repos_url":"https://api.github.com/users/GregoryMaks/repos","events_url":"https://api.github.com/users/GregoryMaks/events{/privacy}","received_events_url":"https://api.github.com/users/GregoryMaks/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-09-17T17:15:15Z","updated_at":"2018-09-22T10:37:18Z","closed_at":"2018-09-21T21:28:17Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ChasakisD/XFExpandableListView/pulls/2","html_url":"https://github.com/ChasakisD/XFExpandableListView/pull/2","diff_url":"https://github.com/ChasakisD/XFExpandableListView/pull/2.diff","patch_url":"https://github.com/ChasakisD/XFExpandableListView/pull/2.patch"},"body":"Hi Dionysis,\r\n\r\nFound your repo being very useful for the task of expanding groups. But it was crashing on iOS when I tried to run it there. So here is a small fix.\r\n\r\nBasically the issue was in `UpdateExpandedItems()` when groups were dynamically updated right inside ListView. This is ok for Android but on iOS the implementation is such that it makes all the operations being run in item update cycle. When combined with initial item set it leads to the following error:\r\n\r\n```Objective-C exception thrown.  Name: NSInternalInconsistencyException Reason: Invalid update: invalid number of rows in section 1.  The number of rows contained in an existing section after the update (2) must be equal to the number of rows contained in that section before the update (0), plus or minus the number of rows inserted or deleted from that section (0 inserted, 0 deleted) and plus or minus the number of rows moved into or out of that section (0 moved in, 0 moved out).```\r\n\r\nI made the update work in the manner that items are set at the end of normalization of their state. That fixes the issue. Maybe it'll make sense to add iOS project to the example. If you want, I can do it in next PR.\r\n\r\nThanks for the hard work you've done!"},"comment":{"url":"https://api.github.com/repos/ChasakisD/XFExpandableListView/issues/comments/423734557","html_url":"https://github.com/ChasakisD/XFExpandableListView/pull/2#issuecomment-423734557","issue_url":"https://api.github.com/repos/ChasakisD/XFExpandableListView/issues/2","id":423734557,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMzczNDU1Nw==","user":{"login":"ChasakisD","id":23040695,"node_id":"MDQ6VXNlcjIzMDQwNjk1","avatar_url":"https://avatars0.githubusercontent.com/u/23040695?v=4","gravatar_id":"","url":"https://api.github.com/users/ChasakisD","html_url":"https://github.com/ChasakisD","followers_url":"https://api.github.com/users/ChasakisD/followers","following_url":"https://api.github.com/users/ChasakisD/following{/other_user}","gists_url":"https://api.github.com/users/ChasakisD/gists{/gist_id}","starred_url":"https://api.github.com/users/ChasakisD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChasakisD/subscriptions","organizations_url":"https://api.github.com/users/ChasakisD/orgs","repos_url":"https://api.github.com/users/ChasakisD/repos","events_url":"https://api.github.com/users/ChasakisD/events{/privacy}","received_events_url":"https://api.github.com/users/ChasakisD/received_events","type":"User","site_admin":false},"created_at":"2018-09-22T10:37:18Z","updated_at":"2018-09-22T10:37:18Z","author_association":"OWNER","body":"@GregoryMaks Actually I am using Resharper, it's a VS Extension for Windows that adds a ton of intellisense and improvements to the IDE (And also so much XAML Intellisense). So that's why i do use the ```private```. In resharper it is not grayed out 😃\r\n\r\nI also noticed some bugs in the ```ExpandableViewCell``` on the tap gesture command. I will make an issue asap, so we can push the iOS project into this merge 🙂!"}}
{"actor":{"display_login":"ChasakisD"}}