{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/170378390","pull_request_review_id":99065199,"id":170378390,"diff_hunk":"@@ -6,16 +6,18 @@\n \n namespace Microsoft.CodeAnalysis.Editor.GoToDefinition\n {\n+    // Ctrl+Click (GoToSymbol)\n     internal abstract class AbstractGoToSymbolService : ForegroundThreadAffinitizedObject, IGoToSymbolService\n     {\n         public async Task GetSymbolsAsync(GoToSymbolContext context)\n         {\n             var document = context.Document;\n             var position = context.Position;\n             var cancellationToken = context.CancellationToken;\n-\n             var service = document.GetLanguageService<IGoToDefinitionSymbolService>();\n-            var (symbol, span) = await service.GetSymbolAndBoundSpanAsync(document, position, cancellationToken).ConfigureAwait(false);\n+\n+            // includeType: if the token has no aliased, referenced or declared symbols (mostly literals) we want to disable Ctrl+Click on them","path":"src/EditorFeatures/Core/GoToDefinition/AbstractGoToSymbolService.cs","position":16,"original_position":16,"commit_id":"01c18e0fd8a60cbefc75e73bf5336af20014617c","original_commit_id":"01c18e0fd8a60cbefc75e73bf5336af20014617c","user":{"login":"isc30","id":10807051,"avatar_url":"https://avatars1.githubusercontent.com/u/10807051?v=4","gravatar_id":"","url":"https://api.github.com/users/isc30","html_url":"https://github.com/isc30","followers_url":"https://api.github.com/users/isc30/followers","following_url":"https://api.github.com/users/isc30/following{/other_user}","gists_url":"https://api.github.com/users/isc30/gists{/gist_id}","starred_url":"https://api.github.com/users/isc30/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isc30/subscriptions","organizations_url":"https://api.github.com/users/isc30/orgs","repos_url":"https://api.github.com/users/isc30/repos","events_url":"https://api.github.com/users/isc30/events{/privacy}","received_events_url":"https://api.github.com/users/isc30/received_events","type":"User","site_admin":false},"body":"what's your suggestion for the full message?","created_at":"2018-02-23T21:57:00Z","updated_at":"2018-02-23T21:57:01Z","html_url":"https://github.com/dotnet/roslyn/pull/24910#discussion_r170378390","pull_request_url":"https://api.github.com/repos/dotnet/roslyn/pulls/24910","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments/170378390"},"html":{"href":"https://github.com/dotnet/roslyn/pull/24910#discussion_r170378390"},"pull_request":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/24910"}},"in_reply_to_id":170377563},"pull_request":{"url":"https://api.github.com/repos/dotnet/roslyn/pulls/24910","id":169767924,"html_url":"https://github.com/dotnet/roslyn/pull/24910","diff_url":"https://github.com/dotnet/roslyn/pull/24910.diff","patch_url":"https://github.com/dotnet/roslyn/pull/24910.patch","issue_url":"https://api.github.com/repos/dotnet/roslyn/issues/24910","number":24910,"state":"open","locked":false,"title":"[#23030] Disable literal Ctrl+Click navigation","user":{"login":"isc30","id":10807051,"avatar_url":"https://avatars1.githubusercontent.com/u/10807051?v=4","gravatar_id":"","url":"https://api.github.com/users/isc30","html_url":"https://github.com/isc30","followers_url":"https://api.github.com/users/isc30/followers","following_url":"https://api.github.com/users/isc30/following{/other_user}","gists_url":"https://api.github.com/users/isc30/gists{/gist_id}","starred_url":"https://api.github.com/users/isc30/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isc30/subscriptions","organizations_url":"https://api.github.com/users/isc30/orgs","repos_url":"https://api.github.com/users/isc30/repos","events_url":"https://api.github.com/users/isc30/events{/privacy}","received_events_url":"https://api.github.com/users/isc30/received_events","type":"User","site_admin":false},"body":"#### WARNING: some of the tests introduced by this PR are not passing, I need some assistance to detect why\r\n\r\n* TestCSharpLiteralGoToDefinition\r\n* TestCSharpStringLiteralGoToDefinition\r\n* TestVisualBasicLiteralGoToDefinition\r\n* TestVisualBasicStringLiteralGoToDefinition\r\n\r\n### Bugs this fixes\r\n\r\nhttps://github.com/dotnet/roslyn/issues/23030\r\n\r\n### Root cause analysis\r\n\r\nAdded tests for both C# and VB covering SymbolNavigation and GoToDefinition for literals","created_at":"2018-02-17T04:30:23Z","updated_at":"2018-02-23T21:57:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"db37a488ad5cbbfde1fca5284769c0db501b50e1","assignee":{"login":"JieCarolHu","id":17056651,"avatar_url":"https://avatars1.githubusercontent.com/u/17056651?v=4","gravatar_id":"","url":"https://api.github.com/users/JieCarolHu","html_url":"https://github.com/JieCarolHu","followers_url":"https://api.github.com/users/JieCarolHu/followers","following_url":"https://api.github.com/users/JieCarolHu/following{/other_user}","gists_url":"https://api.github.com/users/JieCarolHu/gists{/gist_id}","starred_url":"https://api.github.com/users/JieCarolHu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JieCarolHu/subscriptions","organizations_url":"https://api.github.com/users/JieCarolHu/orgs","repos_url":"https://api.github.com/users/JieCarolHu/repos","events_url":"https://api.github.com/users/JieCarolHu/events{/privacy}","received_events_url":"https://api.github.com/users/JieCarolHu/received_events","type":"User","site_admin":false},"assignees":[{"login":"JieCarolHu","id":17056651,"avatar_url":"https://avatars1.githubusercontent.com/u/17056651?v=4","gravatar_id":"","url":"https://api.github.com/users/JieCarolHu","html_url":"https://github.com/JieCarolHu","followers_url":"https://api.github.com/users/JieCarolHu/followers","following_url":"https://api.github.com/users/JieCarolHu/following{/other_user}","gists_url":"https://api.github.com/users/JieCarolHu/gists{/gist_id}","starred_url":"https://api.github.com/users/JieCarolHu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JieCarolHu/subscriptions","organizations_url":"https://api.github.com/users/JieCarolHu/orgs","repos_url":"https://api.github.com/users/JieCarolHu/repos","events_url":"https://api.github.com/users/JieCarolHu/events{/privacy}","received_events_url":"https://api.github.com/users/JieCarolHu/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":288147422,"url":"https://api.github.com/repos/dotnet/roslyn/labels/Community","name":"Community","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/roslyn/pulls/24910/commits","review_comments_url":"https://api.github.com/repos/dotnet/roslyn/pulls/24910/comments","review_comment_url":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/roslyn/issues/24910/comments","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/01c18e0fd8a60cbefc75e73bf5336af20014617c","head":{"label":"isc30:23030-DisableLiteralCtrlClickNavigation","ref":"23030-DisableLiteralCtrlClickNavigation","sha":"01c18e0fd8a60cbefc75e73bf5336af20014617c","user":{"login":"isc30","id":10807051,"avatar_url":"https://avatars1.githubusercontent.com/u/10807051?v=4","gravatar_id":"","url":"https://api.github.com/users/isc30","html_url":"https://github.com/isc30","followers_url":"https://api.github.com/users/isc30/followers","following_url":"https://api.github.com/users/isc30/following{/other_user}","gists_url":"https://api.github.com/users/isc30/gists{/gist_id}","starred_url":"https://api.github.com/users/isc30/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isc30/subscriptions","organizations_url":"https://api.github.com/users/isc30/orgs","repos_url":"https://api.github.com/users/isc30/repos","events_url":"https://api.github.com/users/isc30/events{/privacy}","received_events_url":"https://api.github.com/users/isc30/received_events","type":"User","site_admin":false},"repo":{"id":120913891,"name":"roslyn","full_name":"isc30/roslyn","owner":{"login":"isc30","id":10807051,"avatar_url":"https://avatars1.githubusercontent.com/u/10807051?v=4","gravatar_id":"","url":"https://api.github.com/users/isc30","html_url":"https://github.com/isc30","followers_url":"https://api.github.com/users/isc30/followers","following_url":"https://api.github.com/users/isc30/following{/other_user}","gists_url":"https://api.github.com/users/isc30/gists{/gist_id}","starred_url":"https://api.github.com/users/isc30/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isc30/subscriptions","organizations_url":"https://api.github.com/users/isc30/orgs","repos_url":"https://api.github.com/users/isc30/repos","events_url":"https://api.github.com/users/isc30/events{/privacy}","received_events_url":"https://api.github.com/users/isc30/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/isc30/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":true,"url":"https://api.github.com/repos/isc30/roslyn","forks_url":"https://api.github.com/repos/isc30/roslyn/forks","keys_url":"https://api.github.com/repos/isc30/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/isc30/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/isc30/roslyn/teams","hooks_url":"https://api.github.com/repos/isc30/roslyn/hooks","issue_events_url":"https://api.github.com/repos/isc30/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/isc30/roslyn/events","assignees_url":"https://api.github.com/repos/isc30/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/isc30/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/isc30/roslyn/tags","blobs_url":"https://api.github.com/repos/isc30/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/isc30/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/isc30/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/isc30/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/isc30/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/isc30/roslyn/languages","stargazers_url":"https://api.github.com/repos/isc30/roslyn/stargazers","contributors_url":"https://api.github.com/repos/isc30/roslyn/contributors","subscribers_url":"https://api.github.com/repos/isc30/roslyn/subscribers","subscription_url":"https://api.github.com/repos/isc30/roslyn/subscription","commits_url":"https://api.github.com/repos/isc30/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/isc30/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/isc30/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/isc30/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/isc30/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/isc30/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/isc30/roslyn/merges","archive_url":"https://api.github.com/repos/isc30/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/isc30/roslyn/downloads","issues_url":"https://api.github.com/repos/isc30/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/isc30/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/isc30/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/isc30/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/isc30/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/isc30/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/isc30/roslyn/deployments","created_at":"2018-02-09T14:14:30Z","updated_at":"2018-02-09T14:15:15Z","pushed_at":"2018-02-23T21:49:05Z","git_url":"git://github.com/isc30/roslyn.git","ssh_url":"git@github.com:isc30/roslyn.git","clone_url":"https://github.com/isc30/roslyn.git","svn_url":"https://github.com/isc30/roslyn","homepage":"","size":284741,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"467c216fa6e49b85c2bff58721115b0263f5f402","user":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":29078997,"name":"roslyn","full_name":"dotnet/roslyn","owner":{"login":"dotnet","id":9141961,"avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dotnet/roslyn","description":"The .NET Compiler Platform (\"Roslyn\") provides open-source C# and Visual Basic compilers with rich code analysis APIs.","fork":false,"url":"https://api.github.com/repos/dotnet/roslyn","forks_url":"https://api.github.com/repos/dotnet/roslyn/forks","keys_url":"https://api.github.com/repos/dotnet/roslyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/roslyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/roslyn/teams","hooks_url":"https://api.github.com/repos/dotnet/roslyn/hooks","issue_events_url":"https://api.github.com/repos/dotnet/roslyn/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/roslyn/events","assignees_url":"https://api.github.com/repos/dotnet/roslyn/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/roslyn/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/roslyn/tags","blobs_url":"https://api.github.com/repos/dotnet/roslyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/roslyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/roslyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/roslyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/roslyn/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/roslyn/languages","stargazers_url":"https://api.github.com/repos/dotnet/roslyn/stargazers","contributors_url":"https://api.github.com/repos/dotnet/roslyn/contributors","subscribers_url":"https://api.github.com/repos/dotnet/roslyn/subscribers","subscription_url":"https://api.github.com/repos/dotnet/roslyn/subscription","commits_url":"https://api.github.com/repos/dotnet/roslyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/roslyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/roslyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/roslyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/roslyn/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/roslyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/roslyn/merges","archive_url":"https://api.github.com/repos/dotnet/roslyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/roslyn/downloads","issues_url":"https://api.github.com/repos/dotnet/roslyn/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/roslyn/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/roslyn/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/roslyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/roslyn/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/roslyn/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/roslyn/deployments","created_at":"2015-01-11T02:39:03Z","updated_at":"2018-02-23T18:55:16Z","pushed_at":"2018-02-23T21:49:08Z","git_url":"git://github.com/dotnet/roslyn.git","ssh_url":"git@github.com:dotnet/roslyn.git","clone_url":"https://github.com/dotnet/roslyn.git","svn_url":"https://github.com/dotnet/roslyn","homepage":"","size":294855,"stargazers_count":8895,"watchers_count":8895,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2147,"mirror_url":null,"archived":false,"open_issues_count":4437,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2147,"open_issues":4437,"watchers":8895,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/24910"},"html":{"href":"https://github.com/dotnet/roslyn/pull/24910"},"issue":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/24910"},"comments":{"href":"https://api.github.com/repos/dotnet/roslyn/issues/24910/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/24910/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/roslyn/pulls/24910/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/roslyn/statuses/01c18e0fd8a60cbefc75e73bf5336af20014617c"}},"author_association":"NONE"}}
{"actor":{"display_login":"isc30"}}