{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/187451901","pull_request_review_id":119237328,"id":187451901,"diff_hunk":"@@ -188,8 +188,9 @@ class FileSpecificDiagnosticConsumer : public DiagnosticConsumer {\n   /// None if diagnostic is to be distributed to every consumer,\n   /// a particular consumer if diagnostic goes there.\n   ///\n-  /// (For Xcode compatibility, batch mode must suppress diagnostics to\n-  /// non-primaries.)\n+  /// (If batch mode failed to suppress diagnostics for non-primary files, it\n+  /// would end up writing each of those diagnostics in each primary file's\n+  /// serialized diagnostic file.)","path":"include/swift/AST/DiagnosticConsumer.h","position":null,"original_position":8,"commit_id":"2126f722bb1f5ba9a82e02b4ead83ccc80b75862","original_commit_id":"2126f722bb1f5ba9a82e02b4ead83ccc80b75862","user":{"login":"davidungar","id":461264,"avatar_url":"https://avatars1.githubusercontent.com/u/461264?v=4","gravatar_id":"","url":"https://api.github.com/users/davidungar","html_url":"https://github.com/davidungar","followers_url":"https://api.github.com/users/davidungar/followers","following_url":"https://api.github.com/users/davidungar/following{/other_user}","gists_url":"https://api.github.com/users/davidungar/gists{/gist_id}","starred_url":"https://api.github.com/users/davidungar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidungar/subscriptions","organizations_url":"https://api.github.com/users/davidungar/orgs","repos_url":"https://api.github.com/users/davidungar/repos","events_url":"https://api.github.com/users/davidungar/events{/privacy}","received_events_url":"https://api.github.com/users/davidungar/received_events","type":"User","site_admin":false},"body":"Thanks, that's easy: Comment deleted.","created_at":"2018-05-10T20:35:08Z","updated_at":"2018-05-10T20:35:08Z","html_url":"https://github.com/apple/swift/pull/16485#discussion_r187451901","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/16485","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/187451901"},"html":{"href":"https://github.com/apple/swift/pull/16485#discussion_r187451901"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/16485"}},"in_reply_to_id":187451200},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/16485","id":187074897,"html_url":"https://github.com/apple/swift/pull/16485","diff_url":"https://github.com/apple/swift/pull/16485.diff","patch_url":"https://github.com/apple/swift/pull/16485.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/16485","number":16485,"state":"open","locked":false,"title":"[Batch Mode] Suppressing diagnostics for non-primaries - rdar://40032762","user":{"login":"davidungar","id":461264,"avatar_url":"https://avatars1.githubusercontent.com/u/461264?v=4","gravatar_id":"","url":"https://api.github.com/users/davidungar","html_url":"https://github.com/davidungar","followers_url":"https://api.github.com/users/davidungar/followers","following_url":"https://api.github.com/users/davidungar/following{/other_user}","gists_url":"https://api.github.com/users/davidungar/gists{/gist_id}","starred_url":"https://api.github.com/users/davidungar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidungar/subscriptions","organizations_url":"https://api.github.com/users/davidungar/orgs","repos_url":"https://api.github.com/users/davidungar/repos","events_url":"https://api.github.com/users/davidungar/events{/privacy}","received_events_url":"https://api.github.com/users/davidungar/received_events","type":"User","site_admin":false},"body":"<!-- What's in this pull request? -->\r\nWhen in batch mode, swallow diagnostics for non-primary files.\r\nrdar://40032762\r\n\r\n<!-- If this pull request resolves any bugs in the Swift bug tracker, provide a link: -->\r\n\r\n<!--\r\nBefore merging this pull request, you must run the Swift continuous integration tests.\r\nFor information about triggering CI builds via @swift-ci, see:\r\nhttps://github.com/apple/swift/blob/master/docs/ContinuousIntegration.md#swift-ci\r\n\r\nThank you for your contribution to Swift!\r\n-->","created_at":"2018-05-10T00:42:26Z","updated_at":"2018-05-10T20:35:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fb3a98c1ae25a7fdd2f52c77c7942e4ff64d7745","assignee":null,"assignees":[],"requested_reviewers":[{"login":"graydon","id":14097,"avatar_url":"https://avatars3.githubusercontent.com/u/14097?v=4","gravatar_id":"","url":"https://api.github.com/users/graydon","html_url":"https://github.com/graydon","followers_url":"https://api.github.com/users/graydon/followers","following_url":"https://api.github.com/users/graydon/following{/other_user}","gists_url":"https://api.github.com/users/graydon/gists{/gist_id}","starred_url":"https://api.github.com/users/graydon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graydon/subscriptions","organizations_url":"https://api.github.com/users/graydon/orgs","repos_url":"https://api.github.com/users/graydon/repos","events_url":"https://api.github.com/users/graydon/events{/privacy}","received_events_url":"https://api.github.com/users/graydon/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/16485/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/16485/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/16485/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/2126f722bb1f5ba9a82e02b4ead83ccc80b75862","head":{"label":"davidungar:oddball-diags","ref":"oddball-diags","sha":"2126f722bb1f5ba9a82e02b4ead83ccc80b75862","user":{"login":"davidungar","id":461264,"avatar_url":"https://avatars1.githubusercontent.com/u/461264?v=4","gravatar_id":"","url":"https://api.github.com/users/davidungar","html_url":"https://github.com/davidungar","followers_url":"https://api.github.com/users/davidungar/followers","following_url":"https://api.github.com/users/davidungar/following{/other_user}","gists_url":"https://api.github.com/users/davidungar/gists{/gist_id}","starred_url":"https://api.github.com/users/davidungar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidungar/subscriptions","organizations_url":"https://api.github.com/users/davidungar/orgs","repos_url":"https://api.github.com/users/davidungar/repos","events_url":"https://api.github.com/users/davidungar/events{/privacy}","received_events_url":"https://api.github.com/users/davidungar/received_events","type":"User","site_admin":false},"repo":{"id":100639829,"name":"swift","full_name":"davidungar/swift","owner":{"login":"davidungar","id":461264,"avatar_url":"https://avatars1.githubusercontent.com/u/461264?v=4","gravatar_id":"","url":"https://api.github.com/users/davidungar","html_url":"https://github.com/davidungar","followers_url":"https://api.github.com/users/davidungar/followers","following_url":"https://api.github.com/users/davidungar/following{/other_user}","gists_url":"https://api.github.com/users/davidungar/gists{/gist_id}","starred_url":"https://api.github.com/users/davidungar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidungar/subscriptions","organizations_url":"https://api.github.com/users/davidungar/orgs","repos_url":"https://api.github.com/users/davidungar/repos","events_url":"https://api.github.com/users/davidungar/events{/privacy}","received_events_url":"https://api.github.com/users/davidungar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/davidungar/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/davidungar/swift","forks_url":"https://api.github.com/repos/davidungar/swift/forks","keys_url":"https://api.github.com/repos/davidungar/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/davidungar/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/davidungar/swift/teams","hooks_url":"https://api.github.com/repos/davidungar/swift/hooks","issue_events_url":"https://api.github.com/repos/davidungar/swift/issues/events{/number}","events_url":"https://api.github.com/repos/davidungar/swift/events","assignees_url":"https://api.github.com/repos/davidungar/swift/assignees{/user}","branches_url":"https://api.github.com/repos/davidungar/swift/branches{/branch}","tags_url":"https://api.github.com/repos/davidungar/swift/tags","blobs_url":"https://api.github.com/repos/davidungar/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/davidungar/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/davidungar/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/davidungar/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/davidungar/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/davidungar/swift/languages","stargazers_url":"https://api.github.com/repos/davidungar/swift/stargazers","contributors_url":"https://api.github.com/repos/davidungar/swift/contributors","subscribers_url":"https://api.github.com/repos/davidungar/swift/subscribers","subscription_url":"https://api.github.com/repos/davidungar/swift/subscription","commits_url":"https://api.github.com/repos/davidungar/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/davidungar/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/davidungar/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/davidungar/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/davidungar/swift/contents/{+path}","compare_url":"https://api.github.com/repos/davidungar/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/davidungar/swift/merges","archive_url":"https://api.github.com/repos/davidungar/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/davidungar/swift/downloads","issues_url":"https://api.github.com/repos/davidungar/swift/issues{/number}","pulls_url":"https://api.github.com/repos/davidungar/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/davidungar/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/davidungar/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/davidungar/swift/labels{/name}","releases_url":"https://api.github.com/repos/davidungar/swift/releases{/id}","deployments_url":"https://api.github.com/repos/davidungar/swift/deployments","created_at":"2017-08-17T19:50:47Z","updated_at":"2017-08-17T19:51:19Z","pushed_at":"2018-05-10T17:52:16Z","git_url":"git://github.com/davidungar/swift.git","ssh_url":"git@github.com:davidungar/swift.git","clone_url":"https://github.com/davidungar/swift.git","svn_url":"https://github.com/davidungar/swift","homepage":"https://swift.org/","size":281902,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"0eb51316699a7b35bf7fbefc0a9dae1feb5e2331","user":{"login":"apple","id":10639145,"avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2018-05-10T20:14:06Z","pushed_at":"2018-05-10T20:29:21Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":287407,"stargazers_count":43756,"watchers_count":43756,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6887,"mirror_url":null,"archived":false,"open_issues_count":325,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":6887,"open_issues":325,"watchers":43756,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/16485"},"html":{"href":"https://github.com/apple/swift/pull/16485"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/16485"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/16485/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/16485/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/16485/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/2126f722bb1f5ba9a82e02b4ead83ccc80b75862"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"davidungar"}}