{"action":"closed","number":834,"pull_request":{"url":"https://api.github.com/repos/angular/tsickle/pulls/834","id":195075239,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MDc1MjM5","html_url":"https://github.com/angular/tsickle/pull/834","diff_url":"https://github.com/angular/tsickle/pull/834.diff","patch_url":"https://github.com/angular/tsickle/pull/834.patch","issue_url":"https://api.github.com/repos/angular/tsickle/issues/834","number":834,"state":"closed","locked":false,"title":"Only emit forwardDeclares for exported modules.","user":{"login":"mprobst","id":7208,"node_id":"MDQ6VXNlcjcyMDg=","avatar_url":"https://avatars0.githubusercontent.com/u/7208?v=4","gravatar_id":"","url":"https://api.github.com/users/mprobst","html_url":"https://github.com/mprobst","followers_url":"https://api.github.com/users/mprobst/followers","following_url":"https://api.github.com/users/mprobst/following{/other_user}","gists_url":"https://api.github.com/users/mprobst/gists{/gist_id}","starred_url":"https://api.github.com/users/mprobst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mprobst/subscriptions","organizations_url":"https://api.github.com/users/mprobst/orgs","repos_url":"https://api.github.com/users/mprobst/repos","events_url":"https://api.github.com/users/mprobst/events{/privacy}","received_events_url":"https://api.github.com/users/mprobst/received_events","type":"User","site_admin":false},"body":"Previously, tsickle would emit a forwardDeclare even if it did not emit\r\nan export statement for the referenced module. That'd cause a module\r\nto be forward declared that was never imported, which then breaks the\r\nbuild on the Closure side, as the forward declare is never satisfied.","created_at":"2018-06-15T04:30:23Z","updated_at":"2018-06-16T08:28:36Z","closed_at":"2018-06-16T08:28:36Z","merged_at":"2018-06-16T08:28:36Z","merge_commit_sha":"e399e28ec2c3e735de311477bb1028fa9b8c5580","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":308083292,"node_id":"MDU6TGFiZWwzMDgwODMyOTI=","url":"https://api.github.com/repos/angular/tsickle/labels/cla:%20yes","name":"cla: yes","color":"207de5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/angular/tsickle/pulls/834/commits","review_comments_url":"https://api.github.com/repos/angular/tsickle/pulls/834/comments","review_comment_url":"https://api.github.com/repos/angular/tsickle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/tsickle/issues/834/comments","statuses_url":"https://api.github.com/repos/angular/tsickle/statuses/e399e28ec2c3e735de311477bb1028fa9b8c5580","head":{"label":"angular:resolve-fwd-decls","ref":"resolve-fwd-decls","sha":"e399e28ec2c3e735de311477bb1028fa9b8c5580","user":{"login":"angular","id":139426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":43722735,"node_id":"MDEwOlJlcG9zaXRvcnk0MzcyMjczNQ==","name":"tsickle","full_name":"angular/tsickle","owner":{"login":"angular","id":139426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/tsickle","description":"Tsickle — TypeScript to Closure Translator","fork":false,"url":"https://api.github.com/repos/angular/tsickle","forks_url":"https://api.github.com/repos/angular/tsickle/forks","keys_url":"https://api.github.com/repos/angular/tsickle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/tsickle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/tsickle/teams","hooks_url":"https://api.github.com/repos/angular/tsickle/hooks","issue_events_url":"https://api.github.com/repos/angular/tsickle/issues/events{/number}","events_url":"https://api.github.com/repos/angular/tsickle/events","assignees_url":"https://api.github.com/repos/angular/tsickle/assignees{/user}","branches_url":"https://api.github.com/repos/angular/tsickle/branches{/branch}","tags_url":"https://api.github.com/repos/angular/tsickle/tags","blobs_url":"https://api.github.com/repos/angular/tsickle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/tsickle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/tsickle/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/tsickle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/tsickle/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/tsickle/languages","stargazers_url":"https://api.github.com/repos/angular/tsickle/stargazers","contributors_url":"https://api.github.com/repos/angular/tsickle/contributors","subscribers_url":"https://api.github.com/repos/angular/tsickle/subscribers","subscription_url":"https://api.github.com/repos/angular/tsickle/subscription","commits_url":"https://api.github.com/repos/angular/tsickle/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/tsickle/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/tsickle/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/tsickle/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/tsickle/contents/{+path}","compare_url":"https://api.github.com/repos/angular/tsickle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/tsickle/merges","archive_url":"https://api.github.com/repos/angular/tsickle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/tsickle/downloads","issues_url":"https://api.github.com/repos/angular/tsickle/issues{/number}","pulls_url":"https://api.github.com/repos/angular/tsickle/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/tsickle/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/tsickle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/tsickle/labels{/name}","releases_url":"https://api.github.com/repos/angular/tsickle/releases{/id}","deployments_url":"https://api.github.com/repos/angular/tsickle/deployments","created_at":"2015-10-06T00:55:40Z","updated_at":"2018-06-15T20:29:09Z","pushed_at":"2018-06-16T08:28:34Z","git_url":"git://github.com/angular/tsickle.git","ssh_url":"git@github.com:angular/tsickle.git","clone_url":"https://github.com/angular/tsickle.git","svn_url":"https://github.com/angular/tsickle","homepage":"","size":2785,"stargazers_count":447,"watchers_count":447,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":69,"mirror_url":null,"archived":false,"open_issues_count":139,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":69,"open_issues":139,"watchers":447,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"eeeb17ec1b53484a761801198ab21ff475cefa47","user":{"login":"angular","id":139426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":43722735,"node_id":"MDEwOlJlcG9zaXRvcnk0MzcyMjczNQ==","name":"tsickle","full_name":"angular/tsickle","owner":{"login":"angular","id":139426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/tsickle","description":"Tsickle — TypeScript to Closure Translator","fork":false,"url":"https://api.github.com/repos/angular/tsickle","forks_url":"https://api.github.com/repos/angular/tsickle/forks","keys_url":"https://api.github.com/repos/angular/tsickle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/tsickle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/tsickle/teams","hooks_url":"https://api.github.com/repos/angular/tsickle/hooks","issue_events_url":"https://api.github.com/repos/angular/tsickle/issues/events{/number}","events_url":"https://api.github.com/repos/angular/tsickle/events","assignees_url":"https://api.github.com/repos/angular/tsickle/assignees{/user}","branches_url":"https://api.github.com/repos/angular/tsickle/branches{/branch}","tags_url":"https://api.github.com/repos/angular/tsickle/tags","blobs_url":"https://api.github.com/repos/angular/tsickle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/tsickle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/tsickle/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/tsickle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/tsickle/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/tsickle/languages","stargazers_url":"https://api.github.com/repos/angular/tsickle/stargazers","contributors_url":"https://api.github.com/repos/angular/tsickle/contributors","subscribers_url":"https://api.github.com/repos/angular/tsickle/subscribers","subscription_url":"https://api.github.com/repos/angular/tsickle/subscription","commits_url":"https://api.github.com/repos/angular/tsickle/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/tsickle/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/tsickle/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/tsickle/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/tsickle/contents/{+path}","compare_url":"https://api.github.com/repos/angular/tsickle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/tsickle/merges","archive_url":"https://api.github.com/repos/angular/tsickle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/tsickle/downloads","issues_url":"https://api.github.com/repos/angular/tsickle/issues{/number}","pulls_url":"https://api.github.com/repos/angular/tsickle/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/tsickle/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/tsickle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/tsickle/labels{/name}","releases_url":"https://api.github.com/repos/angular/tsickle/releases{/id}","deployments_url":"https://api.github.com/repos/angular/tsickle/deployments","created_at":"2015-10-06T00:55:40Z","updated_at":"2018-06-15T20:29:09Z","pushed_at":"2018-06-16T08:28:34Z","git_url":"git://github.com/angular/tsickle.git","ssh_url":"git@github.com:angular/tsickle.git","clone_url":"https://github.com/angular/tsickle.git","svn_url":"https://github.com/angular/tsickle","homepage":"","size":2785,"stargazers_count":447,"watchers_count":447,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":69,"mirror_url":null,"archived":false,"open_issues_count":139,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":69,"open_issues":139,"watchers":447,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/tsickle/pulls/834"},"html":{"href":"https://github.com/angular/tsickle/pull/834"},"issue":{"href":"https://api.github.com/repos/angular/tsickle/issues/834"},"comments":{"href":"https://api.github.com/repos/angular/tsickle/issues/834/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/tsickle/pulls/834/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/tsickle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/tsickle/pulls/834/commits"},"statuses":{"href":"https://api.github.com/repos/angular/tsickle/statuses/e399e28ec2c3e735de311477bb1028fa9b8c5580"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"mprobst","id":7208,"node_id":"MDQ6VXNlcjcyMDg=","avatar_url":"https://avatars0.githubusercontent.com/u/7208?v=4","gravatar_id":"","url":"https://api.github.com/users/mprobst","html_url":"https://github.com/mprobst","followers_url":"https://api.github.com/users/mprobst/followers","following_url":"https://api.github.com/users/mprobst/following{/other_user}","gists_url":"https://api.github.com/users/mprobst/gists{/gist_id}","starred_url":"https://api.github.com/users/mprobst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mprobst/subscriptions","organizations_url":"https://api.github.com/users/mprobst/orgs","repos_url":"https://api.github.com/users/mprobst/repos","events_url":"https://api.github.com/users/mprobst/events{/privacy}","received_events_url":"https://api.github.com/users/mprobst/received_events","type":"User","site_admin":false},"comments":0,"review_comments":1,"maintainer_can_modify":false,"commits":1,"additions":15,"deletions":11,"changed_files":4}}
{"actor":{"display_login":"mprobst"}}