{"action":"created","comment":{"url":"https://api.github.com/repos/knative/build-pipeline/pulls/comments/224595406","pull_request_review_id":163999996,"id":224595406,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDU5NTQwNg==","diff_hunk":"@@ -103,10 +104,17 @@ func NewController(\n \t// \tDeleteFunc: impl.Enqueue,\n \t// })\n \n-\tc.tracker = tracker.New(impl.EnqueueKey, 30*time.Minute)\n+\tc.tracker = tracker.New(impl.EnqueueKey, 30*time.Second)\n \tbuildInformer.Informer().AddEventHandler(cache.ResourceEventHandlerFuncs{\n+\t\tAddFunc:    c.tracker.OnChanged,\n \t\tUpdateFunc: controller.PassNew(c.tracker.OnChanged),\n \t})\n+\n+\tresourceInformer.Informer().AddEventHandler(cache.ResourceEventHandlerFuncs{","path":"pkg/reconciler/v1alpha1/taskrun/taskrun.go","position":58,"original_position":58,"commit_id":"052c91fe53e4b948fe0f43f11f60b7298499ab09","original_commit_id":"c91a3800cbefd143cae8aa9a0bd7fe72238dff3b","user":{"login":"bobcatfish","id":432502,"node_id":"MDQ6VXNlcjQzMjUwMg==","avatar_url":"https://avatars2.githubusercontent.com/u/432502?v=4","gravatar_id":"","url":"https://api.github.com/users/bobcatfish","html_url":"https://github.com/bobcatfish","followers_url":"https://api.github.com/users/bobcatfish/followers","following_url":"https://api.github.com/users/bobcatfish/following{/other_user}","gists_url":"https://api.github.com/users/bobcatfish/gists{/gist_id}","starred_url":"https://api.github.com/users/bobcatfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bobcatfish/subscriptions","organizations_url":"https://api.github.com/users/bobcatfish/orgs","repos_url":"https://api.github.com/users/bobcatfish/repos","events_url":"https://api.github.com/users/bobcatfish/events{/privacy}","received_events_url":"https://api.github.com/users/bobcatfish/received_events","type":"User","site_admin":false},"body":"> I added the resourceInformer to be able to Get the Resource as part of adding the AddInputResource call. \r\n\r\nI'm a bit confused by this too - could you still have the Lister without adding an event handler to the resource informer?\r\n\r\n> If we do that, would the reconcile method be called when a resource is updated or added? We should probably support looking resources if that is the case.\r\n\r\nI think this would only be the case if Reconcile actually modified Resources, but I don't think it does? (might have missed it tho)","created_at":"2018-10-11T20:35:37Z","updated_at":"2018-10-11T20:55:57Z","html_url":"https://github.com/knative/build-pipeline/pull/120#discussion_r224595406","pull_request_url":"https://api.github.com/repos/knative/build-pipeline/pulls/120","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/knative/build-pipeline/pulls/comments/224595406"},"html":{"href":"https://github.com/knative/build-pipeline/pull/120#discussion_r224595406"},"pull_request":{"href":"https://api.github.com/repos/knative/build-pipeline/pulls/120"}},"in_reply_to_id":224522398},"pull_request":{"url":"https://api.github.com/repos/knative/build-pipeline/pulls/120","id":221582310,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxNTgyMzEw","html_url":"https://github.com/knative/build-pipeline/pull/120","diff_url":"https://github.com/knative/build-pipeline/pull/120.diff","patch_url":"https://github.com/knative/build-pipeline/pull/120.patch","issue_url":"https://api.github.com/repos/knative/build-pipeline/issues/120","number":120,"state":"open","locked":false,"title":"Implement working kaniko build Task #62","user":{"login":"pivotal-nader-ziada","id":8159867,"node_id":"MDQ6VXNlcjgxNTk4Njc=","avatar_url":"https://avatars2.githubusercontent.com/u/8159867?v=4","gravatar_id":"","url":"https://api.github.com/users/pivotal-nader-ziada","html_url":"https://github.com/pivotal-nader-ziada","followers_url":"https://api.github.com/users/pivotal-nader-ziada/followers","following_url":"https://api.github.com/users/pivotal-nader-ziada/following{/other_user}","gists_url":"https://api.github.com/users/pivotal-nader-ziada/gists{/gist_id}","starred_url":"https://api.github.com/users/pivotal-nader-ziada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pivotal-nader-ziada/subscriptions","organizations_url":"https://api.github.com/users/pivotal-nader-ziada/orgs","repos_url":"https://api.github.com/users/pivotal-nader-ziada/repos","events_url":"https://api.github.com/users/pivotal-nader-ziada/events{/privacy}","received_events_url":"https://api.github.com/users/pivotal-nader-ziada/received_events","type":"User","site_admin":false},"body":"Fixes #62  \r\n\r\n# Proposed changes\r\n * Change the CRD of PipelineResource to make the Kind with the same\r\n name, the word resource makes the cluster roles rbac not work\r\n * add resource Lister in taskrun controller\r\n * move tracking of build after its created,\r\n * update build obejct with input git resources\r\n * add PipelineResource to webhook validation","created_at":"2018-10-09T20:54:36Z","updated_at":"2018-10-11T20:55:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"604a4fe8ac6bd3574fd59245345df27329b0f183","assignee":null,"assignees":[],"requested_reviewers":[{"login":"dlorenc","id":1714486,"node_id":"MDQ6VXNlcjE3MTQ0ODY=","avatar_url":"https://avatars1.githubusercontent.com/u/1714486?v=4","gravatar_id":"","url":"https://api.github.com/users/dlorenc","html_url":"https://github.com/dlorenc","followers_url":"https://api.github.com/users/dlorenc/followers","following_url":"https://api.github.com/users/dlorenc/following{/other_user}","gists_url":"https://api.github.com/users/dlorenc/gists{/gist_id}","starred_url":"https://api.github.com/users/dlorenc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlorenc/subscriptions","organizations_url":"https://api.github.com/users/dlorenc/orgs","repos_url":"https://api.github.com/users/dlorenc/repos","events_url":"https://api.github.com/users/dlorenc/events{/privacy}","received_events_url":"https://api.github.com/users/dlorenc/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1053663328,"node_id":"MDU6TGFiZWwxMDUzNjYzMzI4","url":"https://api.github.com/repos/knative/build-pipeline/labels/approved","name":"approved","color":"abea59","default":false},{"id":1060218475,"node_id":"MDU6TGFiZWwxMDYwMjE4NDc1","url":"https://api.github.com/repos/knative/build-pipeline/labels/size/L","name":"size/L","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/knative/build-pipeline/pulls/120/commits","review_comments_url":"https://api.github.com/repos/knative/build-pipeline/pulls/120/comments","review_comment_url":"https://api.github.com/repos/knative/build-pipeline/pulls/comments{/number}","comments_url":"https://api.github.com/repos/knative/build-pipeline/issues/120/comments","statuses_url":"https://api.github.com/repos/knative/build-pipeline/statuses/052c91fe53e4b948fe0f43f11f60b7298499ab09","head":{"label":"pivotal-nader-ziada:issue62","ref":"issue62","sha":"052c91fe53e4b948fe0f43f11f60b7298499ab09","user":{"login":"pivotal-nader-ziada","id":8159867,"node_id":"MDQ6VXNlcjgxNTk4Njc=","avatar_url":"https://avatars2.githubusercontent.com/u/8159867?v=4","gravatar_id":"","url":"https://api.github.com/users/pivotal-nader-ziada","html_url":"https://github.com/pivotal-nader-ziada","followers_url":"https://api.github.com/users/pivotal-nader-ziada/followers","following_url":"https://api.github.com/users/pivotal-nader-ziada/following{/other_user}","gists_url":"https://api.github.com/users/pivotal-nader-ziada/gists{/gist_id}","starred_url":"https://api.github.com/users/pivotal-nader-ziada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pivotal-nader-ziada/subscriptions","organizations_url":"https://api.github.com/users/pivotal-nader-ziada/orgs","repos_url":"https://api.github.com/users/pivotal-nader-ziada/repos","events_url":"https://api.github.com/users/pivotal-nader-ziada/events{/privacy}","received_events_url":"https://api.github.com/users/pivotal-nader-ziada/received_events","type":"User","site_admin":false},"repo":{"id":148160881,"node_id":"MDEwOlJlcG9zaXRvcnkxNDgxNjA4ODE=","name":"build-pipeline","full_name":"pivotal-nader-ziada/build-pipeline","private":false,"owner":{"login":"pivotal-nader-ziada","id":8159867,"node_id":"MDQ6VXNlcjgxNTk4Njc=","avatar_url":"https://avatars2.githubusercontent.com/u/8159867?v=4","gravatar_id":"","url":"https://api.github.com/users/pivotal-nader-ziada","html_url":"https://github.com/pivotal-nader-ziada","followers_url":"https://api.github.com/users/pivotal-nader-ziada/followers","following_url":"https://api.github.com/users/pivotal-nader-ziada/following{/other_user}","gists_url":"https://api.github.com/users/pivotal-nader-ziada/gists{/gist_id}","starred_url":"https://api.github.com/users/pivotal-nader-ziada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pivotal-nader-ziada/subscriptions","organizations_url":"https://api.github.com/users/pivotal-nader-ziada/orgs","repos_url":"https://api.github.com/users/pivotal-nader-ziada/repos","events_url":"https://api.github.com/users/pivotal-nader-ziada/events{/privacy}","received_events_url":"https://api.github.com/users/pivotal-nader-ziada/received_events","type":"User","site_admin":false},"html_url":"https://github.com/pivotal-nader-ziada/build-pipeline","description":"A K8s-native Pipeline resource.","fork":true,"url":"https://api.github.com/repos/pivotal-nader-ziada/build-pipeline","forks_url":"https://api.github.com/repos/pivotal-nader-ziada/build-pipeline/forks","keys_url":"https://api.github.com/repos/pivotal-nader-ziada/build-pipeline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pivotal-nader-ziada/build-pipeline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pivotal-nader-ziada/build-pipeline/teams","hooks_url":"https://api.github.com/repos/pivotal-nader-ziada/build-pipeline/hooks","issue_events_url":"https://api.github.com/repos/pivotal-nader-ziada/build-pipeline/issues/events{/number}","events_url":"https://api.github.com/repos/pivotal-nader-ziada/build-pipeline/events","assignees_url":"https://api.github.com/repos/pivotal-nader-ziada/build-pipeline/assignees{/user}","branches_url":"https://api.github.com/repos/pivotal-nader-ziada/build-pipeline/branches{/branch}","tags_url":"https://api.github.com/repos/pivotal-nader-ziada/build-pipeline/tags","blobs_url":"https://api.github.com/repos/pivotal-nader-ziada/build-pipeline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pivotal-nader-ziada/build-pipeline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pivotal-nader-ziada/build-pipeline/git/refs{/sha}","trees_url":"https://api.github.com/repos/pivotal-nader-ziada/build-pipeline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pivotal-nader-ziada/build-pipeline/statuses/{sha}","languages_url":"https://api.github.com/repos/pivotal-nader-ziada/build-pipeline/languages","stargazers_url":"https://api.github.com/repos/pivotal-nader-ziada/build-pipeline/stargazers","contributors_url":"https://api.github.com/repos/pivotal-nader-ziada/build-pipeline/contributors","subscribers_url":"https://api.github.com/repos/pivotal-nader-ziada/build-pipeline/subscribers","subscription_url":"https://api.github.com/repos/pivotal-nader-ziada/build-pipeline/subscription","commits_url":"https://api.github.com/repos/pivotal-nader-ziada/build-pipeline/commits{/sha}","git_commits_url":"https://api.github.com/repos/pivotal-nader-ziada/build-pipeline/git/commits{/sha}","comments_url":"https://api.github.com/repos/pivotal-nader-ziada/build-pipeline/comments{/number}","issue_comment_url":"https://api.github.com/repos/pivotal-nader-ziada/build-pipeline/issues/comments{/number}","contents_url":"https://api.github.com/repos/pivotal-nader-ziada/build-pipeline/contents/{+path}","compare_url":"https://api.github.com/repos/pivotal-nader-ziada/build-pipeline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pivotal-nader-ziada/build-pipeline/merges","archive_url":"https://api.github.com/repos/pivotal-nader-ziada/build-pipeline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pivotal-nader-ziada/build-pipeline/downloads","issues_url":"https://api.github.com/repos/pivotal-nader-ziada/build-pipeline/issues{/number}","pulls_url":"https://api.github.com/repos/pivotal-nader-ziada/build-pipeline/pulls{/number}","milestones_url":"https://api.github.com/repos/pivotal-nader-ziada/build-pipeline/milestones{/number}","notifications_url":"https://api.github.com/repos/pivotal-nader-ziada/build-pipeline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pivotal-nader-ziada/build-pipeline/labels{/name}","releases_url":"https://api.github.com/repos/pivotal-nader-ziada/build-pipeline/releases{/id}","deployments_url":"https://api.github.com/repos/pivotal-nader-ziada/build-pipeline/deployments","created_at":"2018-09-10T13:37:17Z","updated_at":"2018-10-11T20:25:47Z","pushed_at":"2018-10-11T20:27:55Z","git_url":"git://github.com/pivotal-nader-ziada/build-pipeline.git","ssh_url":"git@github.com:pivotal-nader-ziada/build-pipeline.git","clone_url":"https://github.com/pivotal-nader-ziada/build-pipeline.git","svn_url":"https://github.com/pivotal-nader-ziada/build-pipeline","homepage":"","size":48449,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"knative:master","ref":"master","sha":"59845a5746b9f1879073066ba520f4451004b522","user":{"login":"knative","id":35583233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NTgzMjMz","avatar_url":"https://avatars2.githubusercontent.com/u/35583233?v=4","gravatar_id":"","url":"https://api.github.com/users/knative","html_url":"https://github.com/knative","followers_url":"https://api.github.com/users/knative/followers","following_url":"https://api.github.com/users/knative/following{/other_user}","gists_url":"https://api.github.com/users/knative/gists{/gist_id}","starred_url":"https://api.github.com/users/knative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knative/subscriptions","organizations_url":"https://api.github.com/users/knative/orgs","repos_url":"https://api.github.com/users/knative/repos","events_url":"https://api.github.com/users/knative/events{/privacy}","received_events_url":"https://api.github.com/users/knative/received_events","type":"Organization","site_admin":false},"repo":{"id":146641150,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY2NDExNTA=","name":"build-pipeline","full_name":"knative/build-pipeline","private":false,"owner":{"login":"knative","id":35583233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NTgzMjMz","avatar_url":"https://avatars2.githubusercontent.com/u/35583233?v=4","gravatar_id":"","url":"https://api.github.com/users/knative","html_url":"https://github.com/knative","followers_url":"https://api.github.com/users/knative/followers","following_url":"https://api.github.com/users/knative/following{/other_user}","gists_url":"https://api.github.com/users/knative/gists{/gist_id}","starred_url":"https://api.github.com/users/knative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knative/subscriptions","organizations_url":"https://api.github.com/users/knative/orgs","repos_url":"https://api.github.com/users/knative/repos","events_url":"https://api.github.com/users/knative/events{/privacy}","received_events_url":"https://api.github.com/users/knative/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/knative/build-pipeline","description":"A K8s-native Pipeline resource.","fork":false,"url":"https://api.github.com/repos/knative/build-pipeline","forks_url":"https://api.github.com/repos/knative/build-pipeline/forks","keys_url":"https://api.github.com/repos/knative/build-pipeline/keys{/key_id}","collaborators_url":"https://api.github.com/repos/knative/build-pipeline/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/knative/build-pipeline/teams","hooks_url":"https://api.github.com/repos/knative/build-pipeline/hooks","issue_events_url":"https://api.github.com/repos/knative/build-pipeline/issues/events{/number}","events_url":"https://api.github.com/repos/knative/build-pipeline/events","assignees_url":"https://api.github.com/repos/knative/build-pipeline/assignees{/user}","branches_url":"https://api.github.com/repos/knative/build-pipeline/branches{/branch}","tags_url":"https://api.github.com/repos/knative/build-pipeline/tags","blobs_url":"https://api.github.com/repos/knative/build-pipeline/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/knative/build-pipeline/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/knative/build-pipeline/git/refs{/sha}","trees_url":"https://api.github.com/repos/knative/build-pipeline/git/trees{/sha}","statuses_url":"https://api.github.com/repos/knative/build-pipeline/statuses/{sha}","languages_url":"https://api.github.com/repos/knative/build-pipeline/languages","stargazers_url":"https://api.github.com/repos/knative/build-pipeline/stargazers","contributors_url":"https://api.github.com/repos/knative/build-pipeline/contributors","subscribers_url":"https://api.github.com/repos/knative/build-pipeline/subscribers","subscription_url":"https://api.github.com/repos/knative/build-pipeline/subscription","commits_url":"https://api.github.com/repos/knative/build-pipeline/commits{/sha}","git_commits_url":"https://api.github.com/repos/knative/build-pipeline/git/commits{/sha}","comments_url":"https://api.github.com/repos/knative/build-pipeline/comments{/number}","issue_comment_url":"https://api.github.com/repos/knative/build-pipeline/issues/comments{/number}","contents_url":"https://api.github.com/repos/knative/build-pipeline/contents/{+path}","compare_url":"https://api.github.com/repos/knative/build-pipeline/compare/{base}...{head}","merges_url":"https://api.github.com/repos/knative/build-pipeline/merges","archive_url":"https://api.github.com/repos/knative/build-pipeline/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/knative/build-pipeline/downloads","issues_url":"https://api.github.com/repos/knative/build-pipeline/issues{/number}","pulls_url":"https://api.github.com/repos/knative/build-pipeline/pulls{/number}","milestones_url":"https://api.github.com/repos/knative/build-pipeline/milestones{/number}","notifications_url":"https://api.github.com/repos/knative/build-pipeline/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/knative/build-pipeline/labels{/name}","releases_url":"https://api.github.com/repos/knative/build-pipeline/releases{/id}","deployments_url":"https://api.github.com/repos/knative/build-pipeline/deployments","created_at":"2018-08-29T18:21:55Z","updated_at":"2018-10-11T20:23:31Z","pushed_at":"2018-10-11T20:51:55Z","git_url":"git://github.com/knative/build-pipeline.git","ssh_url":"git@github.com:knative/build-pipeline.git","clone_url":"https://github.com/knative/build-pipeline.git","svn_url":"https://github.com/knative/build-pipeline","homepage":"","size":48413,"stargazers_count":53,"watchers_count":53,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":44,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":13,"open_issues":44,"watchers":53,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/knative/build-pipeline/pulls/120"},"html":{"href":"https://github.com/knative/build-pipeline/pull/120"},"issue":{"href":"https://api.github.com/repos/knative/build-pipeline/issues/120"},"comments":{"href":"https://api.github.com/repos/knative/build-pipeline/issues/120/comments"},"review_comments":{"href":"https://api.github.com/repos/knative/build-pipeline/pulls/120/comments"},"review_comment":{"href":"https://api.github.com/repos/knative/build-pipeline/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/knative/build-pipeline/pulls/120/commits"},"statuses":{"href":"https://api.github.com/repos/knative/build-pipeline/statuses/052c91fe53e4b948fe0f43f11f60b7298499ab09"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bobcatfish"}}