{"action":"created","comment":{"url":"https://api.github.com/repos/juju/juju/pulls/comments/212651760","pull_request_review_id":149332778,"id":212651760,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjY1MTc2MA==","diff_hunk":"@@ -268,6 +268,18 @@ func (w *upgradeSeriesWorker) handleCompleteStarted() error {\n \treturn nil\n }\n \n+// handleCompleted givens the worker a chance to perform any final operations\n+// before returning control to the server (controller) which will then perform its own\n+// post upgrade routine.\n+func (w *upgradeSeriesWorker) handleCompleted() error {","path":"worker/upgradeseries/worker.go","position":16,"original_position":7,"commit_id":"833e6ff5e6be0abb20e7e5b722f4488c753bfeff","original_commit_id":"7b7c50c6d7e878dd1ace6e0dd976e8fcda24f960","user":{"login":"manadart","id":562661,"node_id":"MDQ6VXNlcjU2MjY2MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/562661?v=4","gravatar_id":"","url":"https://api.github.com/users/manadart","html_url":"https://github.com/manadart","followers_url":"https://api.github.com/users/manadart/followers","following_url":"https://api.github.com/users/manadart/following{/other_user}","gists_url":"https://api.github.com/users/manadart/gists{/gist_id}","starred_url":"https://api.github.com/users/manadart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manadart/subscriptions","organizations_url":"https://api.github.com/users/manadart/orgs","repos_url":"https://api.github.com/users/manadart/repos","events_url":"https://api.github.com/users/manadart/events{/privacy}","received_events_url":"https://api.github.com/users/manadart/received_events","type":"User","site_admin":false},"body":"Yes, we don't need to check the unit status, because we know machine could not be complete without that.","created_at":"2018-08-24T14:43:04Z","updated_at":"2018-08-24T14:43:04Z","html_url":"https://github.com/juju/juju/pull/9106#discussion_r212651760","pull_request_url":"https://api.github.com/repos/juju/juju/pulls/9106","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/comments/212651760"},"html":{"href":"https://github.com/juju/juju/pull/9106#discussion_r212651760"},"pull_request":{"href":"https://api.github.com/repos/juju/juju/pulls/9106"}},"in_reply_to_id":212592010},"pull_request":{"url":"https://api.github.com/repos/juju/juju/pulls/9106","id":210510440,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNTEwNDQw","html_url":"https://github.com/juju/juju/pull/9106","diff_url":"https://github.com/juju/juju/pull/9106.diff","patch_url":"https://github.com/juju/juju/pull/9106.patch","issue_url":"https://api.github.com/repos/juju/juju/issues/9106","number":9106,"state":"open","locked":false,"title":"Remove lock and removal related cleanups.","user":{"login":"ExternalReality","id":1026081,"node_id":"MDQ6VXNlcjEwMjYwODE=","avatar_url":"https://avatars3.githubusercontent.com/u/1026081?v=4","gravatar_id":"","url":"https://api.github.com/users/ExternalReality","html_url":"https://github.com/ExternalReality","followers_url":"https://api.github.com/users/ExternalReality/followers","following_url":"https://api.github.com/users/ExternalReality/following{/other_user}","gists_url":"https://api.github.com/users/ExternalReality/gists{/gist_id}","starred_url":"https://api.github.com/users/ExternalReality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ExternalReality/subscriptions","organizations_url":"https://api.github.com/users/ExternalReality/orgs","repos_url":"https://api.github.com/users/ExternalReality/repos","events_url":"https://api.github.com/users/ExternalReality/events{/privacy}","received_events_url":"https://api.github.com/users/ExternalReality/received_events","type":"User","site_admin":false},"body":"Lock should be cleaned up after all is said and done.\r\n","created_at":"2018-08-23T16:45:48Z","updated_at":"2018-08-24T14:43:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8aad08eb2b416ab468d42fe64fe26b15e642085d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/juju/juju/pulls/9106/commits","review_comments_url":"https://api.github.com/repos/juju/juju/pulls/9106/comments","review_comment_url":"https://api.github.com/repos/juju/juju/pulls/comments{/number}","comments_url":"https://api.github.com/repos/juju/juju/issues/9106/comments","statuses_url":"https://api.github.com/repos/juju/juju/statuses/833e6ff5e6be0abb20e7e5b722f4488c753bfeff","head":{"label":"ExternalReality:remove_upgrade_series_lock","ref":"remove_upgrade_series_lock","sha":"833e6ff5e6be0abb20e7e5b722f4488c753bfeff","user":{"login":"ExternalReality","id":1026081,"node_id":"MDQ6VXNlcjEwMjYwODE=","avatar_url":"https://avatars3.githubusercontent.com/u/1026081?v=4","gravatar_id":"","url":"https://api.github.com/users/ExternalReality","html_url":"https://github.com/ExternalReality","followers_url":"https://api.github.com/users/ExternalReality/followers","following_url":"https://api.github.com/users/ExternalReality/following{/other_user}","gists_url":"https://api.github.com/users/ExternalReality/gists{/gist_id}","starred_url":"https://api.github.com/users/ExternalReality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ExternalReality/subscriptions","organizations_url":"https://api.github.com/users/ExternalReality/orgs","repos_url":"https://api.github.com/users/ExternalReality/repos","events_url":"https://api.github.com/users/ExternalReality/events{/privacy}","received_events_url":"https://api.github.com/users/ExternalReality/received_events","type":"User","site_admin":false},"repo":{"id":82218532,"node_id":"MDEwOlJlcG9zaXRvcnk4MjIxODUzMg==","name":"juju","full_name":"ExternalReality/juju","owner":{"login":"ExternalReality","id":1026081,"node_id":"MDQ6VXNlcjEwMjYwODE=","avatar_url":"https://avatars3.githubusercontent.com/u/1026081?v=4","gravatar_id":"","url":"https://api.github.com/users/ExternalReality","html_url":"https://github.com/ExternalReality","followers_url":"https://api.github.com/users/ExternalReality/followers","following_url":"https://api.github.com/users/ExternalReality/following{/other_user}","gists_url":"https://api.github.com/users/ExternalReality/gists{/gist_id}","starred_url":"https://api.github.com/users/ExternalReality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ExternalReality/subscriptions","organizations_url":"https://api.github.com/users/ExternalReality/orgs","repos_url":"https://api.github.com/users/ExternalReality/repos","events_url":"https://api.github.com/users/ExternalReality/events{/privacy}","received_events_url":"https://api.github.com/users/ExternalReality/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ExternalReality/juju","description":"juju is devops distilled","fork":true,"url":"https://api.github.com/repos/ExternalReality/juju","forks_url":"https://api.github.com/repos/ExternalReality/juju/forks","keys_url":"https://api.github.com/repos/ExternalReality/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ExternalReality/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ExternalReality/juju/teams","hooks_url":"https://api.github.com/repos/ExternalReality/juju/hooks","issue_events_url":"https://api.github.com/repos/ExternalReality/juju/issues/events{/number}","events_url":"https://api.github.com/repos/ExternalReality/juju/events","assignees_url":"https://api.github.com/repos/ExternalReality/juju/assignees{/user}","branches_url":"https://api.github.com/repos/ExternalReality/juju/branches{/branch}","tags_url":"https://api.github.com/repos/ExternalReality/juju/tags","blobs_url":"https://api.github.com/repos/ExternalReality/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ExternalReality/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ExternalReality/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/ExternalReality/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ExternalReality/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/ExternalReality/juju/languages","stargazers_url":"https://api.github.com/repos/ExternalReality/juju/stargazers","contributors_url":"https://api.github.com/repos/ExternalReality/juju/contributors","subscribers_url":"https://api.github.com/repos/ExternalReality/juju/subscribers","subscription_url":"https://api.github.com/repos/ExternalReality/juju/subscription","commits_url":"https://api.github.com/repos/ExternalReality/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/ExternalReality/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/ExternalReality/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/ExternalReality/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/ExternalReality/juju/contents/{+path}","compare_url":"https://api.github.com/repos/ExternalReality/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ExternalReality/juju/merges","archive_url":"https://api.github.com/repos/ExternalReality/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ExternalReality/juju/downloads","issues_url":"https://api.github.com/repos/ExternalReality/juju/issues{/number}","pulls_url":"https://api.github.com/repos/ExternalReality/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/ExternalReality/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/ExternalReality/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ExternalReality/juju/labels{/name}","releases_url":"https://api.github.com/repos/ExternalReality/juju/releases{/id}","deployments_url":"https://api.github.com/repos/ExternalReality/juju/deployments","created_at":"2017-02-16T19:36:01Z","updated_at":"2017-02-16T19:36:14Z","pushed_at":"2018-08-24T14:35:24Z","git_url":"git://github.com/ExternalReality/juju.git","ssh_url":"git@github.com:ExternalReality/juju.git","clone_url":"https://github.com/ExternalReality/juju.git","svn_url":"https://github.com/ExternalReality/juju","homepage":"juju.ubuntu.com","size":227397,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"staging"}},"base":{"label":"juju:develop","ref":"develop","sha":"22c009f5f8bdd700ee5948a73d681067f080077a","user":{"login":"juju","id":4604548,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MDQ1NDg=","avatar_url":"https://avatars0.githubusercontent.com/u/4604548?v=4","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"repo":{"id":20445947,"node_id":"MDEwOlJlcG9zaXRvcnkyMDQ0NTk0Nw==","name":"juju","full_name":"juju/juju","owner":{"login":"juju","id":4604548,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2MDQ1NDg=","avatar_url":"https://avatars0.githubusercontent.com/u/4604548?v=4","gravatar_id":"","url":"https://api.github.com/users/juju","html_url":"https://github.com/juju","followers_url":"https://api.github.com/users/juju/followers","following_url":"https://api.github.com/users/juju/following{/other_user}","gists_url":"https://api.github.com/users/juju/gists{/gist_id}","starred_url":"https://api.github.com/users/juju/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juju/subscriptions","organizations_url":"https://api.github.com/users/juju/orgs","repos_url":"https://api.github.com/users/juju/repos","events_url":"https://api.github.com/users/juju/events{/privacy}","received_events_url":"https://api.github.com/users/juju/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/juju/juju","description":"juju is devops distilled","fork":false,"url":"https://api.github.com/repos/juju/juju","forks_url":"https://api.github.com/repos/juju/juju/forks","keys_url":"https://api.github.com/repos/juju/juju/keys{/key_id}","collaborators_url":"https://api.github.com/repos/juju/juju/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/juju/juju/teams","hooks_url":"https://api.github.com/repos/juju/juju/hooks","issue_events_url":"https://api.github.com/repos/juju/juju/issues/events{/number}","events_url":"https://api.github.com/repos/juju/juju/events","assignees_url":"https://api.github.com/repos/juju/juju/assignees{/user}","branches_url":"https://api.github.com/repos/juju/juju/branches{/branch}","tags_url":"https://api.github.com/repos/juju/juju/tags","blobs_url":"https://api.github.com/repos/juju/juju/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/juju/juju/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/juju/juju/git/refs{/sha}","trees_url":"https://api.github.com/repos/juju/juju/git/trees{/sha}","statuses_url":"https://api.github.com/repos/juju/juju/statuses/{sha}","languages_url":"https://api.github.com/repos/juju/juju/languages","stargazers_url":"https://api.github.com/repos/juju/juju/stargazers","contributors_url":"https://api.github.com/repos/juju/juju/contributors","subscribers_url":"https://api.github.com/repos/juju/juju/subscribers","subscription_url":"https://api.github.com/repos/juju/juju/subscription","commits_url":"https://api.github.com/repos/juju/juju/commits{/sha}","git_commits_url":"https://api.github.com/repos/juju/juju/git/commits{/sha}","comments_url":"https://api.github.com/repos/juju/juju/comments{/number}","issue_comment_url":"https://api.github.com/repos/juju/juju/issues/comments{/number}","contents_url":"https://api.github.com/repos/juju/juju/contents/{+path}","compare_url":"https://api.github.com/repos/juju/juju/compare/{base}...{head}","merges_url":"https://api.github.com/repos/juju/juju/merges","archive_url":"https://api.github.com/repos/juju/juju/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/juju/juju/downloads","issues_url":"https://api.github.com/repos/juju/juju/issues{/number}","pulls_url":"https://api.github.com/repos/juju/juju/pulls{/number}","milestones_url":"https://api.github.com/repos/juju/juju/milestones{/number}","notifications_url":"https://api.github.com/repos/juju/juju/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/juju/juju/labels{/name}","releases_url":"https://api.github.com/repos/juju/juju/releases{/id}","deployments_url":"https://api.github.com/repos/juju/juju/deployments","created_at":"2014-06-03T14:28:10Z","updated_at":"2018-08-24T09:01:33Z","pushed_at":"2018-08-24T14:41:17Z","git_url":"git://github.com/juju/juju.git","ssh_url":"git@github.com:juju/juju.git","clone_url":"https://github.com/juju/juju.git","svn_url":"https://github.com/juju/juju","homepage":"juju.ubuntu.com","size":227331,"stargazers_count":1209,"watchers_count":1209,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":279,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":279,"open_issues":15,"watchers":1209,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/juju/juju/pulls/9106"},"html":{"href":"https://github.com/juju/juju/pull/9106"},"issue":{"href":"https://api.github.com/repos/juju/juju/issues/9106"},"comments":{"href":"https://api.github.com/repos/juju/juju/issues/9106/comments"},"review_comments":{"href":"https://api.github.com/repos/juju/juju/pulls/9106/comments"},"review_comment":{"href":"https://api.github.com/repos/juju/juju/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/juju/juju/pulls/9106/commits"},"statuses":{"href":"https://api.github.com/repos/juju/juju/statuses/833e6ff5e6be0abb20e7e5b722f4488c753bfeff"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"manadart"}}