{"action":"closed","number":28,"pull_request":{"url":"https://api.github.com/repos/team-quizki/quizki-frontend/pulls/28","id":235918649,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1OTE4NjQ5","html_url":"https://github.com/team-quizki/quizki-frontend/pull/28","diff_url":"https://github.com/team-quizki/quizki-frontend/pull/28.diff","patch_url":"https://github.com/team-quizki/quizki-frontend/pull/28.patch","issue_url":"https://api.github.com/repos/team-quizki/quizki-frontend/issues/28","number":28,"state":"closed","locked":false,"title":"Update to angular7","user":{"login":"FrauDeborah","id":23142096,"node_id":"MDQ6VXNlcjIzMTQyMDk2","avatar_url":"https://avatars1.githubusercontent.com/u/23142096?v=4","gravatar_id":"","url":"https://api.github.com/users/FrauDeborah","html_url":"https://github.com/FrauDeborah","followers_url":"https://api.github.com/users/FrauDeborah/followers","following_url":"https://api.github.com/users/FrauDeborah/following{/other_user}","gists_url":"https://api.github.com/users/FrauDeborah/gists{/gist_id}","starred_url":"https://api.github.com/users/FrauDeborah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FrauDeborah/subscriptions","organizations_url":"https://api.github.com/users/FrauDeborah/orgs","repos_url":"https://api.github.com/users/FrauDeborah/repos","events_url":"https://api.github.com/users/FrauDeborah/events{/privacy}","received_events_url":"https://api.github.com/users/FrauDeborah/received_events","type":"User","site_admin":false},"body":"Hi Johnathan (@haxwell),\r\n\r\n1) I created a branch off my quizkiRegistrationLogin branch called updateToAngular7 to update my local to Angular 7. After the upgrade on the branch, I found and fixed one error in the login.component. Strange I had already added comment to that line of code thinking it wasn't written properly, but had left it since it appeared to work. Yet it didn't pass the \"ng test\" or compile after the upgrade.\r\n\r\n2) Anyway, for the first time I ran \"ng lint\" OMG, I have mega lines of code flagged as non-compliant to the Angular code standards. No issue, I can fix them all. Yet many of the errors were on the Questions work done by Jim before we ramp'ed up in July. I don't believe that either Brian  or Devon are using the code in those files. I recommend deleting the code from the current project. That would reduce the total number of errors generated by \"ng lint\". Here are the directories and files to which I'm referring:\r\n\r\n![questiondata and questions directories](https://user-images.githubusercontent.com/23142096/49464363-ebaf2500-f7b7-11e8-9a48-8a9450e5fb50.PNG)\r\n\r\n3) I updated my global Angular/CLI, typescript, and Node. The entire team would need to upgrade their global Angular/CLI at the minimum. I update Node because I was at node v6.x and Angular now supports node v10.x.\r\n\r\nWhat are your thoughts about removing the directories listed above. The team could always add them back in if they are using or I could ask in chat. Although, response time in chat lately approaches infinity (smiling).\r\n\r\nDeborah\r\n\r\nPS. I upgraded, because this month I want to experiment with building an Angular 7 project using the new schematics. It's easier for me to generalize if I reduce the differences.  Your choice to merge or not. Just know I branched of my existing quizkiRegistrationLogin. If you merge into team-quziki/dev, it will likely merge both branches.\r\n\r\nPSS Happy Holidays!!!","created_at":"2018-12-04T18:46:31Z","updated_at":"2018-12-17T14:32:04Z","closed_at":"2018-12-17T14:32:04Z","merged_at":"2018-12-17T14:32:04Z","merge_commit_sha":"8a10b7bfe7efa71b23e5777d16b9ed0a5247ba36","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/team-quizki/quizki-frontend/pulls/28/commits","review_comments_url":"https://api.github.com/repos/team-quizki/quizki-frontend/pulls/28/comments","review_comment_url":"https://api.github.com/repos/team-quizki/quizki-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/team-quizki/quizki-frontend/issues/28/comments","statuses_url":"https://api.github.com/repos/team-quizki/quizki-frontend/statuses/8a10b7bfe7efa71b23e5777d16b9ed0a5247ba36","head":{"label":"FrauDeborah:updateToAngular7","ref":"updateToAngular7","sha":"8a10b7bfe7efa71b23e5777d16b9ed0a5247ba36","user":{"login":"FrauDeborah","id":23142096,"node_id":"MDQ6VXNlcjIzMTQyMDk2","avatar_url":"https://avatars1.githubusercontent.com/u/23142096?v=4","gravatar_id":"","url":"https://api.github.com/users/FrauDeborah","html_url":"https://github.com/FrauDeborah","followers_url":"https://api.github.com/users/FrauDeborah/followers","following_url":"https://api.github.com/users/FrauDeborah/following{/other_user}","gists_url":"https://api.github.com/users/FrauDeborah/gists{/gist_id}","starred_url":"https://api.github.com/users/FrauDeborah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FrauDeborah/subscriptions","organizations_url":"https://api.github.com/users/FrauDeborah/orgs","repos_url":"https://api.github.com/users/FrauDeborah/repos","events_url":"https://api.github.com/users/FrauDeborah/events{/privacy}","received_events_url":"https://api.github.com/users/FrauDeborah/received_events","type":"User","site_admin":false},"repo":{"id":141067002,"node_id":"MDEwOlJlcG9zaXRvcnkxNDEwNjcwMDI=","name":"quizki-frontend","full_name":"FrauDeborah/quizki-frontend","private":false,"owner":{"login":"FrauDeborah","id":23142096,"node_id":"MDQ6VXNlcjIzMTQyMDk2","avatar_url":"https://avatars1.githubusercontent.com/u/23142096?v=4","gravatar_id":"","url":"https://api.github.com/users/FrauDeborah","html_url":"https://github.com/FrauDeborah","followers_url":"https://api.github.com/users/FrauDeborah/followers","following_url":"https://api.github.com/users/FrauDeborah/following{/other_user}","gists_url":"https://api.github.com/users/FrauDeborah/gists{/gist_id}","starred_url":"https://api.github.com/users/FrauDeborah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FrauDeborah/subscriptions","organizations_url":"https://api.github.com/users/FrauDeborah/orgs","repos_url":"https://api.github.com/users/FrauDeborah/repos","events_url":"https://api.github.com/users/FrauDeborah/events{/privacy}","received_events_url":"https://api.github.com/users/FrauDeborah/received_events","type":"User","site_admin":false},"html_url":"https://github.com/FrauDeborah/quizki-frontend","description":"Quizki is a question and answer database which generates exams.","fork":true,"url":"https://api.github.com/repos/FrauDeborah/quizki-frontend","forks_url":"https://api.github.com/repos/FrauDeborah/quizki-frontend/forks","keys_url":"https://api.github.com/repos/FrauDeborah/quizki-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FrauDeborah/quizki-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FrauDeborah/quizki-frontend/teams","hooks_url":"https://api.github.com/repos/FrauDeborah/quizki-frontend/hooks","issue_events_url":"https://api.github.com/repos/FrauDeborah/quizki-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/FrauDeborah/quizki-frontend/events","assignees_url":"https://api.github.com/repos/FrauDeborah/quizki-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/FrauDeborah/quizki-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/FrauDeborah/quizki-frontend/tags","blobs_url":"https://api.github.com/repos/FrauDeborah/quizki-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FrauDeborah/quizki-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FrauDeborah/quizki-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/FrauDeborah/quizki-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FrauDeborah/quizki-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/FrauDeborah/quizki-frontend/languages","stargazers_url":"https://api.github.com/repos/FrauDeborah/quizki-frontend/stargazers","contributors_url":"https://api.github.com/repos/FrauDeborah/quizki-frontend/contributors","subscribers_url":"https://api.github.com/repos/FrauDeborah/quizki-frontend/subscribers","subscription_url":"https://api.github.com/repos/FrauDeborah/quizki-frontend/subscription","commits_url":"https://api.github.com/repos/FrauDeborah/quizki-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/FrauDeborah/quizki-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/FrauDeborah/quizki-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/FrauDeborah/quizki-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/FrauDeborah/quizki-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/FrauDeborah/quizki-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FrauDeborah/quizki-frontend/merges","archive_url":"https://api.github.com/repos/FrauDeborah/quizki-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FrauDeborah/quizki-frontend/downloads","issues_url":"https://api.github.com/repos/FrauDeborah/quizki-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/FrauDeborah/quizki-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/FrauDeborah/quizki-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/FrauDeborah/quizki-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FrauDeborah/quizki-frontend/labels{/name}","releases_url":"https://api.github.com/repos/FrauDeborah/quizki-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/FrauDeborah/quizki-frontend/deployments","created_at":"2018-07-16T00:02:01Z","updated_at":"2018-10-07T12:04:16Z","pushed_at":"2018-12-17T01:16:59Z","git_url":"git://github.com/FrauDeborah/quizki-frontend.git","ssh_url":"git@github.com:FrauDeborah/quizki-frontend.git","clone_url":"https://github.com/FrauDeborah/quizki-frontend.git","svn_url":"https://github.com/FrauDeborah/quizki-frontend","homepage":null,"size":343,"stargazers_count":1,"watchers_count":1,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"team-quizki:dev","ref":"dev","sha":"76ebd6144ab9d2084e15862c2650e2dcd428ccf7","user":{"login":"team-quizki","id":40303925,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwMzAzOTI1","avatar_url":"https://avatars3.githubusercontent.com/u/40303925?v=4","gravatar_id":"","url":"https://api.github.com/users/team-quizki","html_url":"https://github.com/team-quizki","followers_url":"https://api.github.com/users/team-quizki/followers","following_url":"https://api.github.com/users/team-quizki/following{/other_user}","gists_url":"https://api.github.com/users/team-quizki/gists{/gist_id}","starred_url":"https://api.github.com/users/team-quizki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/team-quizki/subscriptions","organizations_url":"https://api.github.com/users/team-quizki/orgs","repos_url":"https://api.github.com/users/team-quizki/repos","events_url":"https://api.github.com/users/team-quizki/events{/privacy}","received_events_url":"https://api.github.com/users/team-quizki/received_events","type":"Organization","site_admin":false},"repo":{"id":137519921,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc1MTk5MjE=","name":"quizki-frontend","full_name":"team-quizki/quizki-frontend","private":false,"owner":{"login":"team-quizki","id":40303925,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwMzAzOTI1","avatar_url":"https://avatars3.githubusercontent.com/u/40303925?v=4","gravatar_id":"","url":"https://api.github.com/users/team-quizki","html_url":"https://github.com/team-quizki","followers_url":"https://api.github.com/users/team-quizki/followers","following_url":"https://api.github.com/users/team-quizki/following{/other_user}","gists_url":"https://api.github.com/users/team-quizki/gists{/gist_id}","starred_url":"https://api.github.com/users/team-quizki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/team-quizki/subscriptions","organizations_url":"https://api.github.com/users/team-quizki/orgs","repos_url":"https://api.github.com/users/team-quizki/repos","events_url":"https://api.github.com/users/team-quizki/events{/privacy}","received_events_url":"https://api.github.com/users/team-quizki/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/team-quizki/quizki-frontend","description":"Quizki is a question and answer database which generates exams.","fork":false,"url":"https://api.github.com/repos/team-quizki/quizki-frontend","forks_url":"https://api.github.com/repos/team-quizki/quizki-frontend/forks","keys_url":"https://api.github.com/repos/team-quizki/quizki-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/team-quizki/quizki-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/team-quizki/quizki-frontend/teams","hooks_url":"https://api.github.com/repos/team-quizki/quizki-frontend/hooks","issue_events_url":"https://api.github.com/repos/team-quizki/quizki-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/team-quizki/quizki-frontend/events","assignees_url":"https://api.github.com/repos/team-quizki/quizki-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/team-quizki/quizki-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/team-quizki/quizki-frontend/tags","blobs_url":"https://api.github.com/repos/team-quizki/quizki-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/team-quizki/quizki-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/team-quizki/quizki-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/team-quizki/quizki-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/team-quizki/quizki-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/team-quizki/quizki-frontend/languages","stargazers_url":"https://api.github.com/repos/team-quizki/quizki-frontend/stargazers","contributors_url":"https://api.github.com/repos/team-quizki/quizki-frontend/contributors","subscribers_url":"https://api.github.com/repos/team-quizki/quizki-frontend/subscribers","subscription_url":"https://api.github.com/repos/team-quizki/quizki-frontend/subscription","commits_url":"https://api.github.com/repos/team-quizki/quizki-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/team-quizki/quizki-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/team-quizki/quizki-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/team-quizki/quizki-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/team-quizki/quizki-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/team-quizki/quizki-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/team-quizki/quizki-frontend/merges","archive_url":"https://api.github.com/repos/team-quizki/quizki-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/team-quizki/quizki-frontend/downloads","issues_url":"https://api.github.com/repos/team-quizki/quizki-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/team-quizki/quizki-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/team-quizki/quizki-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/team-quizki/quizki-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/team-quizki/quizki-frontend/labels{/name}","releases_url":"https://api.github.com/repos/team-quizki/quizki-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/team-quizki/quizki-frontend/deployments","created_at":"2018-06-15T18:26:01Z","updated_at":"2018-12-05T02:08:04Z","pushed_at":"2018-12-17T14:32:03Z","git_url":"git://github.com/team-quizki/quizki-frontend.git","ssh_url":"git@github.com:team-quizki/quizki-frontend.git","clone_url":"https://github.com/team-quizki/quizki-frontend.git","svn_url":"https://github.com/team-quizki/quizki-frontend","homepage":null,"size":332,"stargazers_count":2,"watchers_count":2,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":13,"license":null,"forks":14,"open_issues":13,"watchers":2,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/team-quizki/quizki-frontend/pulls/28"},"html":{"href":"https://github.com/team-quizki/quizki-frontend/pull/28"},"issue":{"href":"https://api.github.com/repos/team-quizki/quizki-frontend/issues/28"},"comments":{"href":"https://api.github.com/repos/team-quizki/quizki-frontend/issues/28/comments"},"review_comments":{"href":"https://api.github.com/repos/team-quizki/quizki-frontend/pulls/28/comments"},"review_comment":{"href":"https://api.github.com/repos/team-quizki/quizki-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/team-quizki/quizki-frontend/pulls/28/commits"},"statuses":{"href":"https://api.github.com/repos/team-quizki/quizki-frontend/statuses/8a10b7bfe7efa71b23e5777d16b9ed0a5247ba36"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"haxwell","id":3296972,"node_id":"MDQ6VXNlcjMyOTY5NzI=","avatar_url":"https://avatars0.githubusercontent.com/u/3296972?v=4","gravatar_id":"","url":"https://api.github.com/users/haxwell","html_url":"https://github.com/haxwell","followers_url":"https://api.github.com/users/haxwell/followers","following_url":"https://api.github.com/users/haxwell/following{/other_user}","gists_url":"https://api.github.com/users/haxwell/gists{/gist_id}","starred_url":"https://api.github.com/users/haxwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/haxwell/subscriptions","organizations_url":"https://api.github.com/users/haxwell/orgs","repos_url":"https://api.github.com/users/haxwell/repos","events_url":"https://api.github.com/users/haxwell/events{/privacy}","received_events_url":"https://api.github.com/users/haxwell/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":5,"additions":114,"deletions":90,"changed_files":10}}
{"actor":{"display_login":"haxwell"}}