{"action":"created","comment":{"url":"https://api.github.com/repos/ice/framework/pulls/comments/221684520","pull_request_review_id":160393313,"id":221684520,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTY4NDUyMA==","diff_hunk":"@@ -29,7 +29,7 @@ public function create($fields = [], Validation $extra = null)\n     {\n         $model = $this;\n \n-        $this->di->hook('model.before.create', function ($model) {\n+        $this->di->hook('model.before.create.' . get_called_class(), function ($model) {","path":"tests/App/Models/Users.php","position":5,"original_position":5,"commit_id":"4f6909ff27a63ec683780142dd664ba30e384c15","original_commit_id":"4f6909ff27a63ec683780142dd664ba30e384c15","user":{"login":"mruz","id":2629882,"node_id":"MDQ6VXNlcjI2Mjk4ODI=","avatar_url":"https://avatars2.githubusercontent.com/u/2629882?v=4","gravatar_id":"","url":"https://api.github.com/users/mruz","html_url":"https://github.com/mruz","followers_url":"https://api.github.com/users/mruz/followers","following_url":"https://api.github.com/users/mruz/following{/other_user}","gists_url":"https://api.github.com/users/mruz/gists{/gist_id}","starred_url":"https://api.github.com/users/mruz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mruz/subscriptions","organizations_url":"https://api.github.com/users/mruz/orgs","repos_url":"https://api.github.com/users/mruz/repos","events_url":"https://api.github.com/users/mruz/events{/privacy}","received_events_url":"https://api.github.com/users/mruz/received_events","type":"User","site_admin":false},"body":"Could you remove clearHooks too? https://github.com/ice/framework/pull/209/files#diff-5507e26bff1e1fbfec725771c7a56f84R39 ","created_at":"2018-10-01T17:04:13Z","updated_at":"2018-10-01T17:04:13Z","html_url":"https://github.com/ice/framework/pull/209#discussion_r221684520","pull_request_url":"https://api.github.com/repos/ice/framework/pulls/209","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ice/framework/pulls/comments/221684520"},"html":{"href":"https://github.com/ice/framework/pull/209#discussion_r221684520"},"pull_request":{"href":"https://api.github.com/repos/ice/framework/pulls/209"}}},"pull_request":{"url":"https://api.github.com/repos/ice/framework/pulls/209","id":219411408,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NDExNDA4","html_url":"https://github.com/ice/framework/pull/209","diff_url":"https://github.com/ice/framework/pull/209.diff","patch_url":"https://github.com/ice/framework/pull/209.patch","issue_url":"https://api.github.com/repos/ice/framework/issues/209","number":209,"state":"open","locked":false,"title":"Model, hook bug fixed #208","user":{"login":"Yahasana","id":97450,"node_id":"MDQ6VXNlcjk3NDUw","avatar_url":"https://avatars0.githubusercontent.com/u/97450?v=4","gravatar_id":"","url":"https://api.github.com/users/Yahasana","html_url":"https://github.com/Yahasana","followers_url":"https://api.github.com/users/Yahasana/followers","following_url":"https://api.github.com/users/Yahasana/following{/other_user}","gists_url":"https://api.github.com/users/Yahasana/gists{/gist_id}","starred_url":"https://api.github.com/users/Yahasana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yahasana/subscriptions","organizations_url":"https://api.github.com/users/Yahasana/orgs","repos_url":"https://api.github.com/users/Yahasana/repos","events_url":"https://api.github.com/users/Yahasana/events{/privacy}","received_events_url":"https://api.github.com/users/Yahasana/received_events","type":"User","site_admin":false},"body":"add model hooks will has to append current classname as prefix now.\r\nprevious\r\n```php\r\n$this->di->hook(\"model.after.update\", function(){ });\r\n```\r\nnow\r\n```php\r\n$this->di->hook(\"model.after.update.\" . static::class, function(){ });","created_at":"2018-10-01T15:08:30Z","updated_at":"2018-10-01T17:04:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8d7e7827e1b4fbe13a44dfe1cd8e5380e637868c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ice/framework/pulls/209/commits","review_comments_url":"https://api.github.com/repos/ice/framework/pulls/209/comments","review_comment_url":"https://api.github.com/repos/ice/framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ice/framework/issues/209/comments","statuses_url":"https://api.github.com/repos/ice/framework/statuses/4f6909ff27a63ec683780142dd664ba30e384c15","head":{"label":"Yahasana:patch-34","ref":"patch-34","sha":"4f6909ff27a63ec683780142dd664ba30e384c15","user":{"login":"Yahasana","id":97450,"node_id":"MDQ6VXNlcjk3NDUw","avatar_url":"https://avatars0.githubusercontent.com/u/97450?v=4","gravatar_id":"","url":"https://api.github.com/users/Yahasana","html_url":"https://github.com/Yahasana","followers_url":"https://api.github.com/users/Yahasana/followers","following_url":"https://api.github.com/users/Yahasana/following{/other_user}","gists_url":"https://api.github.com/users/Yahasana/gists{/gist_id}","starred_url":"https://api.github.com/users/Yahasana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yahasana/subscriptions","organizations_url":"https://api.github.com/users/Yahasana/orgs","repos_url":"https://api.github.com/users/Yahasana/repos","events_url":"https://api.github.com/users/Yahasana/events{/privacy}","received_events_url":"https://api.github.com/users/Yahasana/received_events","type":"User","site_admin":false},"repo":{"id":147678850,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc2Nzg4NTA=","name":"ice-framework","full_name":"Yahasana/ice-framework","private":false,"owner":{"login":"Yahasana","id":97450,"node_id":"MDQ6VXNlcjk3NDUw","avatar_url":"https://avatars0.githubusercontent.com/u/97450?v=4","gravatar_id":"","url":"https://api.github.com/users/Yahasana","html_url":"https://github.com/Yahasana","followers_url":"https://api.github.com/users/Yahasana/followers","following_url":"https://api.github.com/users/Yahasana/following{/other_user}","gists_url":"https://api.github.com/users/Yahasana/gists{/gist_id}","starred_url":"https://api.github.com/users/Yahasana/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Yahasana/subscriptions","organizations_url":"https://api.github.com/users/Yahasana/orgs","repos_url":"https://api.github.com/users/Yahasana/repos","events_url":"https://api.github.com/users/Yahasana/events{/privacy}","received_events_url":"https://api.github.com/users/Yahasana/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Yahasana/ice-framework","description":"Source code of Ice framework","fork":true,"url":"https://api.github.com/repos/Yahasana/ice-framework","forks_url":"https://api.github.com/repos/Yahasana/ice-framework/forks","keys_url":"https://api.github.com/repos/Yahasana/ice-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Yahasana/ice-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Yahasana/ice-framework/teams","hooks_url":"https://api.github.com/repos/Yahasana/ice-framework/hooks","issue_events_url":"https://api.github.com/repos/Yahasana/ice-framework/issues/events{/number}","events_url":"https://api.github.com/repos/Yahasana/ice-framework/events","assignees_url":"https://api.github.com/repos/Yahasana/ice-framework/assignees{/user}","branches_url":"https://api.github.com/repos/Yahasana/ice-framework/branches{/branch}","tags_url":"https://api.github.com/repos/Yahasana/ice-framework/tags","blobs_url":"https://api.github.com/repos/Yahasana/ice-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Yahasana/ice-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Yahasana/ice-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/Yahasana/ice-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Yahasana/ice-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/Yahasana/ice-framework/languages","stargazers_url":"https://api.github.com/repos/Yahasana/ice-framework/stargazers","contributors_url":"https://api.github.com/repos/Yahasana/ice-framework/contributors","subscribers_url":"https://api.github.com/repos/Yahasana/ice-framework/subscribers","subscription_url":"https://api.github.com/repos/Yahasana/ice-framework/subscription","commits_url":"https://api.github.com/repos/Yahasana/ice-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/Yahasana/ice-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/Yahasana/ice-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/Yahasana/ice-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/Yahasana/ice-framework/contents/{+path}","compare_url":"https://api.github.com/repos/Yahasana/ice-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Yahasana/ice-framework/merges","archive_url":"https://api.github.com/repos/Yahasana/ice-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Yahasana/ice-framework/downloads","issues_url":"https://api.github.com/repos/Yahasana/ice-framework/issues{/number}","pulls_url":"https://api.github.com/repos/Yahasana/ice-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/Yahasana/ice-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/Yahasana/ice-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Yahasana/ice-framework/labels{/name}","releases_url":"https://api.github.com/repos/Yahasana/ice-framework/releases{/id}","deployments_url":"https://api.github.com/repos/Yahasana/ice-framework/deployments","created_at":"2018-09-06T13:36:56Z","updated_at":"2018-09-10T10:49:27Z","pushed_at":"2018-10-01T15:51:47Z","git_url":"git://github.com/Yahasana/ice-framework.git","ssh_url":"git@github.com:Yahasana/ice-framework.git","clone_url":"https://github.com/Yahasana/ice-framework.git","svn_url":"https://github.com/Yahasana/ice-framework","homepage":"http://www.iceframework.org/","size":4167,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"ice:dev","ref":"dev","sha":"5652a639155fb8ee84971888ac48babcc5877400","user":{"login":"ice","id":240471,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0MDQ3MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/240471?v=4","gravatar_id":"","url":"https://api.github.com/users/ice","html_url":"https://github.com/ice","followers_url":"https://api.github.com/users/ice/followers","following_url":"https://api.github.com/users/ice/following{/other_user}","gists_url":"https://api.github.com/users/ice/gists{/gist_id}","starred_url":"https://api.github.com/users/ice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ice/subscriptions","organizations_url":"https://api.github.com/users/ice/orgs","repos_url":"https://api.github.com/users/ice/repos","events_url":"https://api.github.com/users/ice/events{/privacy}","received_events_url":"https://api.github.com/users/ice/received_events","type":"Organization","site_admin":false},"repo":{"id":26318874,"node_id":"MDEwOlJlcG9zaXRvcnkyNjMxODg3NA==","name":"framework","full_name":"ice/framework","private":false,"owner":{"login":"ice","id":240471,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0MDQ3MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/240471?v=4","gravatar_id":"","url":"https://api.github.com/users/ice","html_url":"https://github.com/ice","followers_url":"https://api.github.com/users/ice/followers","following_url":"https://api.github.com/users/ice/following{/other_user}","gists_url":"https://api.github.com/users/ice/gists{/gist_id}","starred_url":"https://api.github.com/users/ice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ice/subscriptions","organizations_url":"https://api.github.com/users/ice/orgs","repos_url":"https://api.github.com/users/ice/repos","events_url":"https://api.github.com/users/ice/events{/privacy}","received_events_url":"https://api.github.com/users/ice/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ice/framework","description":"Source code of Ice framework","fork":false,"url":"https://api.github.com/repos/ice/framework","forks_url":"https://api.github.com/repos/ice/framework/forks","keys_url":"https://api.github.com/repos/ice/framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ice/framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ice/framework/teams","hooks_url":"https://api.github.com/repos/ice/framework/hooks","issue_events_url":"https://api.github.com/repos/ice/framework/issues/events{/number}","events_url":"https://api.github.com/repos/ice/framework/events","assignees_url":"https://api.github.com/repos/ice/framework/assignees{/user}","branches_url":"https://api.github.com/repos/ice/framework/branches{/branch}","tags_url":"https://api.github.com/repos/ice/framework/tags","blobs_url":"https://api.github.com/repos/ice/framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ice/framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ice/framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/ice/framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ice/framework/statuses/{sha}","languages_url":"https://api.github.com/repos/ice/framework/languages","stargazers_url":"https://api.github.com/repos/ice/framework/stargazers","contributors_url":"https://api.github.com/repos/ice/framework/contributors","subscribers_url":"https://api.github.com/repos/ice/framework/subscribers","subscription_url":"https://api.github.com/repos/ice/framework/subscription","commits_url":"https://api.github.com/repos/ice/framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/ice/framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/ice/framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/ice/framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/ice/framework/contents/{+path}","compare_url":"https://api.github.com/repos/ice/framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ice/framework/merges","archive_url":"https://api.github.com/repos/ice/framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ice/framework/downloads","issues_url":"https://api.github.com/repos/ice/framework/issues{/number}","pulls_url":"https://api.github.com/repos/ice/framework/pulls{/number}","milestones_url":"https://api.github.com/repos/ice/framework/milestones{/number}","notifications_url":"https://api.github.com/repos/ice/framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ice/framework/labels{/name}","releases_url":"https://api.github.com/repos/ice/framework/releases{/id}","deployments_url":"https://api.github.com/repos/ice/framework/deployments","created_at":"2014-11-07T12:29:15Z","updated_at":"2018-10-01T14:03:14Z","pushed_at":"2018-10-01T15:51:49Z","git_url":"git://github.com/ice/framework.git","ssh_url":"git@github.com:ice/framework.git","clone_url":"https://github.com/ice/framework.git","svn_url":"https://github.com/ice/framework","homepage":"https://www.iceframework.org","size":4097,"stargazers_count":267,"watchers_count":267,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":39,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":39,"open_issues":18,"watchers":267,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/ice/framework/pulls/209"},"html":{"href":"https://github.com/ice/framework/pull/209"},"issue":{"href":"https://api.github.com/repos/ice/framework/issues/209"},"comments":{"href":"https://api.github.com/repos/ice/framework/issues/209/comments"},"review_comments":{"href":"https://api.github.com/repos/ice/framework/pulls/209/comments"},"review_comment":{"href":"https://api.github.com/repos/ice/framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ice/framework/pulls/209/commits"},"statuses":{"href":"https://api.github.com/repos/ice/framework/statuses/4f6909ff27a63ec683780142dd664ba30e384c15"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mruz"}}