{"action":"created","comment":{"url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/pulls/comments/199682553","pull_request_review_id":133847576,"id":199682553,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTY4MjU1Mw==","diff_hunk":"@@ -0,0 +1,96 @@\n+/*\n+    Copyright 2018 Set Labs Inc.\n+\n+    Licensed under the Apache License, Version 2.0 (the \"License\");\n+    you may not use this file except in compliance with the License.\n+    You may obtain a copy of the License at\n+\n+    http://www.apache.org/licenses/LICENSE-2.0\n+\n+    Unless required by applicable law or agreed to in writing, software\n+    distributed under the License is distributed on an \"AS IS\" BASIS,\n+    WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+    See the License for the specific language governing permissions and\n+    limitations under the License.\n+*/\n+\n+pragma solidity 0.4.24;\n+pragma experimental \"ABIEncoderV2\";\n+\n+import { SafeMath } from \"zeppelin-solidity/contracts/math/SafeMath.sol\";\n+import { LibBytes } from \"../../external/LibBytes.sol\";\n+import { ZeroExOrderDataHandler as ZeroEx } from \"./lib/ZeroExOrderDataHandler.sol\";\n+\n+/**\n+ * @title ZeroExExchangeWrapper\n+ * @author Set Protocol\n+ *\n+ * The ZeroExExchangeWrapper contract wrapper to interface with 0x V2\n+ */\n+contract ZeroExExchangeWrapper\n+{\n+    using SafeMath for uint256;\n+    using LibBytes for bytes;\n+\n+    /* ============ Constants ============ */\n+\n+\n+\n+    /* ============ Structs ============ */\n+\n+\n+    /* ============ State Variables ============ */\n+    address public ZERO_EX_EXCHANGE;\n+    address public ZERO_EX_PROXY;\n+\n+\n+    /* ============ Modifiers ============ */\n+\n+\n+    /* ============ Constructor ============ */\n+    constructor(\n+        // address _zeroExExchange,\n+        // address _zeroExProxy,\n+    )\n+        public\n+    {\n+        // ZERO_EX_EXCHANGE = _zeroExExchange;\n+        // ZERO_EX_PROXY = _zeroExProxy;\n+    }\n+\n+\n+    /* ============ Public Functions ============ */\n+    function exchange(","path":"contracts/core/external/ZeroExExchangeWrapper.sol","position":63,"original_position":63,"commit_id":"b667789db966665fab2ebe884167f04cf3f73f4d","original_commit_id":"b667789db966665fab2ebe884167f04cf3f73f4d","user":{"login":"asoong","id":3453571,"node_id":"MDQ6VXNlcjM0NTM1NzE=","avatar_url":"https://avatars3.githubusercontent.com/u/3453571?v=4","gravatar_id":"","url":"https://api.github.com/users/asoong","html_url":"https://github.com/asoong","followers_url":"https://api.github.com/users/asoong/followers","following_url":"https://api.github.com/users/asoong/following{/other_user}","gists_url":"https://api.github.com/users/asoong/gists{/gist_id}","starred_url":"https://api.github.com/users/asoong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asoong/subscriptions","organizations_url":"https://api.github.com/users/asoong/orgs","repos_url":"https://api.github.com/users/asoong/repos","events_url":"https://api.github.com/users/asoong/events{/privacy}","received_events_url":"https://api.github.com/users/asoong/received_events","type":"User","site_admin":false},"body":"nit: add blank space","created_at":"2018-07-03T04:46:22Z","updated_at":"2018-07-03T05:01:45Z","html_url":"https://github.com/SetProtocol/set-protocol-contracts/pull/83#discussion_r199682553","pull_request_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/pulls/83","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/pulls/comments/199682553"},"html":{"href":"https://github.com/SetProtocol/set-protocol-contracts/pull/83#discussion_r199682553"},"pull_request":{"href":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/pulls/83"}}},"pull_request":{"url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/pulls/83","id":198848531,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4ODQ4NTMx","html_url":"https://github.com/SetProtocol/set-protocol-contracts/pull/83","diff_url":"https://github.com/SetProtocol/set-protocol-contracts/pull/83.diff","patch_url":"https://github.com/SetProtocol/set-protocol-contracts/pull/83.patch","issue_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/issues/83","number":83,"state":"open","locked":false,"title":"Parse 0x Order in ExchangeWrapper","user":{"login":"felix2feng","id":17420728,"node_id":"MDQ6VXNlcjE3NDIwNzI4","avatar_url":"https://avatars0.githubusercontent.com/u/17420728?v=4","gravatar_id":"","url":"https://api.github.com/users/felix2feng","html_url":"https://github.com/felix2feng","followers_url":"https://api.github.com/users/felix2feng/followers","following_url":"https://api.github.com/users/felix2feng/following{/other_user}","gists_url":"https://api.github.com/users/felix2feng/gists{/gist_id}","starred_url":"https://api.github.com/users/felix2feng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/felix2feng/subscriptions","organizations_url":"https://api.github.com/users/felix2feng/orgs","repos_url":"https://api.github.com/users/felix2feng/repos","events_url":"https://api.github.com/users/felix2feng/events{/privacy}","received_events_url":"https://api.github.com/users/felix2feng/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-03T04:44:49Z","updated_at":"2018-07-03T05:01:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bbc40345af01771f0c000f632f7a511728dc8438","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/pulls/83/commits","review_comments_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/pulls/83/comments","review_comment_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/issues/83/comments","statuses_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/statuses/b667789db966665fab2ebe884167f04cf3f73f4d","head":{"label":"SetProtocol:felix/0x-exchange-wrapper-4","ref":"felix/0x-exchange-wrapper-4","sha":"b667789db966665fab2ebe884167f04cf3f73f4d","user":{"login":"SetProtocol","id":33144695,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMTQ0Njk1","avatar_url":"https://avatars3.githubusercontent.com/u/33144695?v=4","gravatar_id":"","url":"https://api.github.com/users/SetProtocol","html_url":"https://github.com/SetProtocol","followers_url":"https://api.github.com/users/SetProtocol/followers","following_url":"https://api.github.com/users/SetProtocol/following{/other_user}","gists_url":"https://api.github.com/users/SetProtocol/gists{/gist_id}","starred_url":"https://api.github.com/users/SetProtocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SetProtocol/subscriptions","organizations_url":"https://api.github.com/users/SetProtocol/orgs","repos_url":"https://api.github.com/users/SetProtocol/repos","events_url":"https://api.github.com/users/SetProtocol/events{/privacy}","received_events_url":"https://api.github.com/users/SetProtocol/received_events","type":"Organization","site_admin":false},"repo":{"id":108693025,"node_id":"MDEwOlJlcG9zaXRvcnkxMDg2OTMwMjU=","name":"set-protocol-contracts","full_name":"SetProtocol/set-protocol-contracts","owner":{"login":"SetProtocol","id":33144695,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMTQ0Njk1","avatar_url":"https://avatars3.githubusercontent.com/u/33144695?v=4","gravatar_id":"","url":"https://api.github.com/users/SetProtocol","html_url":"https://github.com/SetProtocol","followers_url":"https://api.github.com/users/SetProtocol/followers","following_url":"https://api.github.com/users/SetProtocol/following{/other_user}","gists_url":"https://api.github.com/users/SetProtocol/gists{/gist_id}","starred_url":"https://api.github.com/users/SetProtocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SetProtocol/subscriptions","organizations_url":"https://api.github.com/users/SetProtocol/orgs","repos_url":"https://api.github.com/users/SetProtocol/repos","events_url":"https://api.github.com/users/SetProtocol/events{/privacy}","received_events_url":"https://api.github.com/users/SetProtocol/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SetProtocol/set-protocol-contracts","description":"{Set} Protocol Smart Contracts","fork":false,"url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts","forks_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/forks","keys_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/teams","hooks_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/hooks","issue_events_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/issues/events{/number}","events_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/events","assignees_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/assignees{/user}","branches_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/branches{/branch}","tags_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/tags","blobs_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/git/refs{/sha}","trees_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/statuses/{sha}","languages_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/languages","stargazers_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/stargazers","contributors_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/contributors","subscribers_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/subscribers","subscription_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/subscription","commits_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/commits{/sha}","git_commits_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/git/commits{/sha}","comments_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/comments{/number}","issue_comment_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/issues/comments{/number}","contents_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/contents/{+path}","compare_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/merges","archive_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/downloads","issues_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/issues{/number}","pulls_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/pulls{/number}","milestones_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/milestones{/number}","notifications_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/labels{/name}","releases_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/releases{/id}","deployments_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/deployments","created_at":"2017-10-29T00:06:34Z","updated_at":"2018-07-03T04:17:27Z","pushed_at":"2018-07-03T04:44:50Z","git_url":"git://github.com/SetProtocol/set-protocol-contracts.git","ssh_url":"git@github.com:SetProtocol/set-protocol-contracts.git","clone_url":"https://github.com/SetProtocol/set-protocol-contracts.git","svn_url":"https://github.com/SetProtocol/set-protocol-contracts","homepage":"","size":1525,"stargazers_count":56,"watchers_count":56,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":11,"open_issues":4,"watchers":56,"default_branch":"master"}},"base":{"label":"SetProtocol:master","ref":"master","sha":"016bf6453e9db0cd46bbd2d860dfa7c2e3b7fd8b","user":{"login":"SetProtocol","id":33144695,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMTQ0Njk1","avatar_url":"https://avatars3.githubusercontent.com/u/33144695?v=4","gravatar_id":"","url":"https://api.github.com/users/SetProtocol","html_url":"https://github.com/SetProtocol","followers_url":"https://api.github.com/users/SetProtocol/followers","following_url":"https://api.github.com/users/SetProtocol/following{/other_user}","gists_url":"https://api.github.com/users/SetProtocol/gists{/gist_id}","starred_url":"https://api.github.com/users/SetProtocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SetProtocol/subscriptions","organizations_url":"https://api.github.com/users/SetProtocol/orgs","repos_url":"https://api.github.com/users/SetProtocol/repos","events_url":"https://api.github.com/users/SetProtocol/events{/privacy}","received_events_url":"https://api.github.com/users/SetProtocol/received_events","type":"Organization","site_admin":false},"repo":{"id":108693025,"node_id":"MDEwOlJlcG9zaXRvcnkxMDg2OTMwMjU=","name":"set-protocol-contracts","full_name":"SetProtocol/set-protocol-contracts","owner":{"login":"SetProtocol","id":33144695,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMTQ0Njk1","avatar_url":"https://avatars3.githubusercontent.com/u/33144695?v=4","gravatar_id":"","url":"https://api.github.com/users/SetProtocol","html_url":"https://github.com/SetProtocol","followers_url":"https://api.github.com/users/SetProtocol/followers","following_url":"https://api.github.com/users/SetProtocol/following{/other_user}","gists_url":"https://api.github.com/users/SetProtocol/gists{/gist_id}","starred_url":"https://api.github.com/users/SetProtocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SetProtocol/subscriptions","organizations_url":"https://api.github.com/users/SetProtocol/orgs","repos_url":"https://api.github.com/users/SetProtocol/repos","events_url":"https://api.github.com/users/SetProtocol/events{/privacy}","received_events_url":"https://api.github.com/users/SetProtocol/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SetProtocol/set-protocol-contracts","description":"{Set} Protocol Smart Contracts","fork":false,"url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts","forks_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/forks","keys_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/teams","hooks_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/hooks","issue_events_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/issues/events{/number}","events_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/events","assignees_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/assignees{/user}","branches_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/branches{/branch}","tags_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/tags","blobs_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/git/refs{/sha}","trees_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/statuses/{sha}","languages_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/languages","stargazers_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/stargazers","contributors_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/contributors","subscribers_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/subscribers","subscription_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/subscription","commits_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/commits{/sha}","git_commits_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/git/commits{/sha}","comments_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/comments{/number}","issue_comment_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/issues/comments{/number}","contents_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/contents/{+path}","compare_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/merges","archive_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/downloads","issues_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/issues{/number}","pulls_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/pulls{/number}","milestones_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/milestones{/number}","notifications_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/labels{/name}","releases_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/releases{/id}","deployments_url":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/deployments","created_at":"2017-10-29T00:06:34Z","updated_at":"2018-07-03T04:17:27Z","pushed_at":"2018-07-03T04:44:50Z","git_url":"git://github.com/SetProtocol/set-protocol-contracts.git","ssh_url":"git@github.com:SetProtocol/set-protocol-contracts.git","clone_url":"https://github.com/SetProtocol/set-protocol-contracts.git","svn_url":"https://github.com/SetProtocol/set-protocol-contracts","homepage":"","size":1525,"stargazers_count":56,"watchers_count":56,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":11,"open_issues":4,"watchers":56,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/pulls/83"},"html":{"href":"https://github.com/SetProtocol/set-protocol-contracts/pull/83"},"issue":{"href":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/issues/83"},"comments":{"href":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/issues/83/comments"},"review_comments":{"href":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/pulls/83/comments"},"review_comment":{"href":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/pulls/83/commits"},"statuses":{"href":"https://api.github.com/repos/SetProtocol/set-protocol-contracts/statuses/b667789db966665fab2ebe884167f04cf3f73f4d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"asoong"}}