{"action":"created","comment":{"url":"https://api.github.com/repos/QMCPACK/qmcpack/pulls/comments/235570394","pull_request_review_id":177466774,"id":235570394,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTU3MDM5NA==","diff_hunk":"@@ -10,10 +10,6 @@ FUNCTION( ADD_QE_TEST TESTNAME PROCS TEST_BINARY NPOOL WORKDIR TEST_INPUT)\n     ENDIF()\n     SET_TESTS_PROPERTIES( ${TESTNAME} PROPERTIES ENVIRONMENT OMP_NUM_THREADS=1 PROCESSORS ${PROCS} PROCESSOR_AFFINITY TRUE WORKING_DIRECTORY ${WORKDIR} )\n     SET_PROPERTY( TEST ${TESTNAME} APPEND PROPERTY LABELS \"converter\" )\n-    \n-    SET(TEST_LABELS \"\")\n-    ADD_TEST_LABELS( ${TESTNAME} TEST_LABELS )\n-    \n ENDFUNCTION()","path":"CMake/run_qe.cmake","position":8,"original_position":8,"commit_id":"d43a651b43c26031dd0324419764b8da2c360eba","original_commit_id":"d43a651b43c26031dd0324419764b8da2c360eba","user":{"login":"ye-luo","id":1454251,"node_id":"MDQ6VXNlcjE0NTQyNTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1454251?v=4","gravatar_id":"","url":"https://api.github.com/users/ye-luo","html_url":"https://github.com/ye-luo","followers_url":"https://api.github.com/users/ye-luo/followers","following_url":"https://api.github.com/users/ye-luo/following{/other_user}","gists_url":"https://api.github.com/users/ye-luo/gists{/gist_id}","starred_url":"https://api.github.com/users/ye-luo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ye-luo/subscriptions","organizations_url":"https://api.github.com/users/ye-luo/orgs","repos_url":"https://api.github.com/users/ye-luo/repos","events_url":"https://api.github.com/users/ye-luo/events{/privacy}","received_events_url":"https://api.github.com/users/ye-luo/received_events","type":"User","site_admin":false},"body":"The QE tests needs to be under the converter track only. QE tests take three steps pwscf, softlink, qmc. The qmc part picks up other labels because it shares the same generation function as other integration tests. I can't modify it. Before the PR change, labels are applied on pwscf and qmc parts but not the softlink one. It is not consistent and tests should fail because of the missing softlink. So I just want to keep it simple and remove the labels on the pwscf part.","created_at":"2018-11-22T00:03:30Z","updated_at":"2018-11-22T00:03:31Z","html_url":"https://github.com/QMCPACK/qmcpack/pull/1165#discussion_r235570394","pull_request_url":"https://api.github.com/repos/QMCPACK/qmcpack/pulls/1165","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/QMCPACK/qmcpack/pulls/comments/235570394"},"html":{"href":"https://github.com/QMCPACK/qmcpack/pull/1165#discussion_r235570394"},"pull_request":{"href":"https://api.github.com/repos/QMCPACK/qmcpack/pulls/1165"}},"in_reply_to_id":235566665},"pull_request":{"url":"https://api.github.com/repos/QMCPACK/qmcpack/pulls/1165","id":232138451,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyMTM4NDUx","html_url":"https://github.com/QMCPACK/qmcpack/pull/1165","diff_url":"https://github.com/QMCPACK/qmcpack/pull/1165.diff","patch_url":"https://github.com/QMCPACK/qmcpack/pull/1165.patch","issue_url":"https://api.github.com/repos/QMCPACK/qmcpack/issues/1165","number":1165,"state":"closed","locked":false,"title":"Improve test labeling and ctest script","user":{"login":"ye-luo","id":1454251,"node_id":"MDQ6VXNlcjE0NTQyNTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1454251?v=4","gravatar_id":"","url":"https://api.github.com/users/ye-luo","html_url":"https://github.com/ye-luo","followers_url":"https://api.github.com/users/ye-luo/followers","following_url":"https://api.github.com/users/ye-luo/following{/other_user}","gists_url":"https://api.github.com/users/ye-luo/gists{/gist_id}","starred_url":"https://api.github.com/users/ye-luo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ye-luo/subscriptions","organizations_url":"https://api.github.com/users/ye-luo/orgs","repos_url":"https://api.github.com/users/ye-luo/repos","events_url":"https://api.github.com/users/ye-luo/events{/privacy}","received_events_url":"https://api.github.com/users/ye-luo/received_events","type":"User","site_admin":false},"body":"Label all the QE workflow tests as \"converter\".\r\n\r\nThis also fixed the default track in ctest_script.cmake. If this is not specified, the last portion of test results are submitted to the last track which is \"Unstable\" and it explains why most of the tests are under the Unstable track. With this change, tests without labels \"unit|performance|converter|unstable\" will go back to the Nightly track.\r\nWe will rearrange these tracks later if needed.","created_at":"2018-11-19T22:55:06Z","updated_at":"2018-11-22T00:03:31Z","closed_at":"2018-11-19T23:31:30Z","merged_at":"2018-11-19T23:31:30Z","merge_commit_sha":"d61569ad4c1c05a95163a49b76ce1b93d99a8051","assignee":{"login":"ye-luo","id":1454251,"node_id":"MDQ6VXNlcjE0NTQyNTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1454251?v=4","gravatar_id":"","url":"https://api.github.com/users/ye-luo","html_url":"https://github.com/ye-luo","followers_url":"https://api.github.com/users/ye-luo/followers","following_url":"https://api.github.com/users/ye-luo/following{/other_user}","gists_url":"https://api.github.com/users/ye-luo/gists{/gist_id}","starred_url":"https://api.github.com/users/ye-luo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ye-luo/subscriptions","organizations_url":"https://api.github.com/users/ye-luo/orgs","repos_url":"https://api.github.com/users/ye-luo/repos","events_url":"https://api.github.com/users/ye-luo/events{/privacy}","received_events_url":"https://api.github.com/users/ye-luo/received_events","type":"User","site_admin":false},"assignees":[{"login":"ye-luo","id":1454251,"node_id":"MDQ6VXNlcjE0NTQyNTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1454251?v=4","gravatar_id":"","url":"https://api.github.com/users/ye-luo","html_url":"https://github.com/ye-luo","followers_url":"https://api.github.com/users/ye-luo/followers","following_url":"https://api.github.com/users/ye-luo/following{/other_user}","gists_url":"https://api.github.com/users/ye-luo/gists{/gist_id}","starred_url":"https://api.github.com/users/ye-luo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ye-luo/subscriptions","organizations_url":"https://api.github.com/users/ye-luo/orgs","repos_url":"https://api.github.com/users/ye-luo/repos","events_url":"https://api.github.com/users/ye-luo/events{/privacy}","received_events_url":"https://api.github.com/users/ye-luo/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/QMCPACK/qmcpack/pulls/1165/commits","review_comments_url":"https://api.github.com/repos/QMCPACK/qmcpack/pulls/1165/comments","review_comment_url":"https://api.github.com/repos/QMCPACK/qmcpack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/QMCPACK/qmcpack/issues/1165/comments","statuses_url":"https://api.github.com/repos/QMCPACK/qmcpack/statuses/d43a651b43c26031dd0324419764b8da2c360eba","head":{"label":"ye-luo:fix-tests-default-track","ref":"fix-tests-default-track","sha":"d43a651b43c26031dd0324419764b8da2c360eba","user":{"login":"ye-luo","id":1454251,"node_id":"MDQ6VXNlcjE0NTQyNTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1454251?v=4","gravatar_id":"","url":"https://api.github.com/users/ye-luo","html_url":"https://github.com/ye-luo","followers_url":"https://api.github.com/users/ye-luo/followers","following_url":"https://api.github.com/users/ye-luo/following{/other_user}","gists_url":"https://api.github.com/users/ye-luo/gists{/gist_id}","starred_url":"https://api.github.com/users/ye-luo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ye-luo/subscriptions","organizations_url":"https://api.github.com/users/ye-luo/orgs","repos_url":"https://api.github.com/users/ye-luo/repos","events_url":"https://api.github.com/users/ye-luo/events{/privacy}","received_events_url":"https://api.github.com/users/ye-luo/received_events","type":"User","site_admin":false},"repo":{"id":78910422,"node_id":"MDEwOlJlcG9zaXRvcnk3ODkxMDQyMg==","name":"qmcpack","full_name":"ye-luo/qmcpack","private":false,"owner":{"login":"ye-luo","id":1454251,"node_id":"MDQ6VXNlcjE0NTQyNTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1454251?v=4","gravatar_id":"","url":"https://api.github.com/users/ye-luo","html_url":"https://github.com/ye-luo","followers_url":"https://api.github.com/users/ye-luo/followers","following_url":"https://api.github.com/users/ye-luo/following{/other_user}","gists_url":"https://api.github.com/users/ye-luo/gists{/gist_id}","starred_url":"https://api.github.com/users/ye-luo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ye-luo/subscriptions","organizations_url":"https://api.github.com/users/ye-luo/orgs","repos_url":"https://api.github.com/users/ye-luo/repos","events_url":"https://api.github.com/users/ye-luo/events{/privacy}","received_events_url":"https://api.github.com/users/ye-luo/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ye-luo/qmcpack","description":"QMCPACK is an open-source production level many-body ab initio Quantum Monte Carlo code for computing the electronic structure of atoms, molecules, and solids.","fork":true,"url":"https://api.github.com/repos/ye-luo/qmcpack","forks_url":"https://api.github.com/repos/ye-luo/qmcpack/forks","keys_url":"https://api.github.com/repos/ye-luo/qmcpack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ye-luo/qmcpack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ye-luo/qmcpack/teams","hooks_url":"https://api.github.com/repos/ye-luo/qmcpack/hooks","issue_events_url":"https://api.github.com/repos/ye-luo/qmcpack/issues/events{/number}","events_url":"https://api.github.com/repos/ye-luo/qmcpack/events","assignees_url":"https://api.github.com/repos/ye-luo/qmcpack/assignees{/user}","branches_url":"https://api.github.com/repos/ye-luo/qmcpack/branches{/branch}","tags_url":"https://api.github.com/repos/ye-luo/qmcpack/tags","blobs_url":"https://api.github.com/repos/ye-luo/qmcpack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ye-luo/qmcpack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ye-luo/qmcpack/git/refs{/sha}","trees_url":"https://api.github.com/repos/ye-luo/qmcpack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ye-luo/qmcpack/statuses/{sha}","languages_url":"https://api.github.com/repos/ye-luo/qmcpack/languages","stargazers_url":"https://api.github.com/repos/ye-luo/qmcpack/stargazers","contributors_url":"https://api.github.com/repos/ye-luo/qmcpack/contributors","subscribers_url":"https://api.github.com/repos/ye-luo/qmcpack/subscribers","subscription_url":"https://api.github.com/repos/ye-luo/qmcpack/subscription","commits_url":"https://api.github.com/repos/ye-luo/qmcpack/commits{/sha}","git_commits_url":"https://api.github.com/repos/ye-luo/qmcpack/git/commits{/sha}","comments_url":"https://api.github.com/repos/ye-luo/qmcpack/comments{/number}","issue_comment_url":"https://api.github.com/repos/ye-luo/qmcpack/issues/comments{/number}","contents_url":"https://api.github.com/repos/ye-luo/qmcpack/contents/{+path}","compare_url":"https://api.github.com/repos/ye-luo/qmcpack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ye-luo/qmcpack/merges","archive_url":"https://api.github.com/repos/ye-luo/qmcpack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ye-luo/qmcpack/downloads","issues_url":"https://api.github.com/repos/ye-luo/qmcpack/issues{/number}","pulls_url":"https://api.github.com/repos/ye-luo/qmcpack/pulls{/number}","milestones_url":"https://api.github.com/repos/ye-luo/qmcpack/milestones{/number}","notifications_url":"https://api.github.com/repos/ye-luo/qmcpack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ye-luo/qmcpack/labels{/name}","releases_url":"https://api.github.com/repos/ye-luo/qmcpack/releases{/id}","deployments_url":"https://api.github.com/repos/ye-luo/qmcpack/deployments","created_at":"2017-01-14T03:52:14Z","updated_at":"2018-10-18T19:40:21Z","pushed_at":"2018-11-19T22:50:31Z","git_url":"git://github.com/ye-luo/qmcpack.git","ssh_url":"git@github.com:ye-luo/qmcpack.git","clone_url":"https://github.com/ye-luo/qmcpack.git","svn_url":"https://github.com/ye-luo/qmcpack","homepage":null,"size":171365,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"QMCPACK:develop","ref":"develop","sha":"2351347c9387b4d4fdb83d5595628d46e29bd5dc","user":{"login":"QMCPACK","id":22754046,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNzU0MDQ2","avatar_url":"https://avatars0.githubusercontent.com/u/22754046?v=4","gravatar_id":"","url":"https://api.github.com/users/QMCPACK","html_url":"https://github.com/QMCPACK","followers_url":"https://api.github.com/users/QMCPACK/followers","following_url":"https://api.github.com/users/QMCPACK/following{/other_user}","gists_url":"https://api.github.com/users/QMCPACK/gists{/gist_id}","starred_url":"https://api.github.com/users/QMCPACK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QMCPACK/subscriptions","organizations_url":"https://api.github.com/users/QMCPACK/orgs","repos_url":"https://api.github.com/users/QMCPACK/repos","events_url":"https://api.github.com/users/QMCPACK/events{/privacy}","received_events_url":"https://api.github.com/users/QMCPACK/received_events","type":"Organization","site_admin":false},"repo":{"id":78669859,"node_id":"MDEwOlJlcG9zaXRvcnk3ODY2OTg1OQ==","name":"qmcpack","full_name":"QMCPACK/qmcpack","private":false,"owner":{"login":"QMCPACK","id":22754046,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNzU0MDQ2","avatar_url":"https://avatars0.githubusercontent.com/u/22754046?v=4","gravatar_id":"","url":"https://api.github.com/users/QMCPACK","html_url":"https://github.com/QMCPACK","followers_url":"https://api.github.com/users/QMCPACK/followers","following_url":"https://api.github.com/users/QMCPACK/following{/other_user}","gists_url":"https://api.github.com/users/QMCPACK/gists{/gist_id}","starred_url":"https://api.github.com/users/QMCPACK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/QMCPACK/subscriptions","organizations_url":"https://api.github.com/users/QMCPACK/orgs","repos_url":"https://api.github.com/users/QMCPACK/repos","events_url":"https://api.github.com/users/QMCPACK/events{/privacy}","received_events_url":"https://api.github.com/users/QMCPACK/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/QMCPACK/qmcpack","description":"Main repository for QMCPACK, an open-source production level many-body ab initio Quantum Monte Carlo code for computing the electronic structure of atoms, molecules, and solids.","fork":false,"url":"https://api.github.com/repos/QMCPACK/qmcpack","forks_url":"https://api.github.com/repos/QMCPACK/qmcpack/forks","keys_url":"https://api.github.com/repos/QMCPACK/qmcpack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/QMCPACK/qmcpack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/QMCPACK/qmcpack/teams","hooks_url":"https://api.github.com/repos/QMCPACK/qmcpack/hooks","issue_events_url":"https://api.github.com/repos/QMCPACK/qmcpack/issues/events{/number}","events_url":"https://api.github.com/repos/QMCPACK/qmcpack/events","assignees_url":"https://api.github.com/repos/QMCPACK/qmcpack/assignees{/user}","branches_url":"https://api.github.com/repos/QMCPACK/qmcpack/branches{/branch}","tags_url":"https://api.github.com/repos/QMCPACK/qmcpack/tags","blobs_url":"https://api.github.com/repos/QMCPACK/qmcpack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/QMCPACK/qmcpack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/QMCPACK/qmcpack/git/refs{/sha}","trees_url":"https://api.github.com/repos/QMCPACK/qmcpack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/QMCPACK/qmcpack/statuses/{sha}","languages_url":"https://api.github.com/repos/QMCPACK/qmcpack/languages","stargazers_url":"https://api.github.com/repos/QMCPACK/qmcpack/stargazers","contributors_url":"https://api.github.com/repos/QMCPACK/qmcpack/contributors","subscribers_url":"https://api.github.com/repos/QMCPACK/qmcpack/subscribers","subscription_url":"https://api.github.com/repos/QMCPACK/qmcpack/subscription","commits_url":"https://api.github.com/repos/QMCPACK/qmcpack/commits{/sha}","git_commits_url":"https://api.github.com/repos/QMCPACK/qmcpack/git/commits{/sha}","comments_url":"https://api.github.com/repos/QMCPACK/qmcpack/comments{/number}","issue_comment_url":"https://api.github.com/repos/QMCPACK/qmcpack/issues/comments{/number}","contents_url":"https://api.github.com/repos/QMCPACK/qmcpack/contents/{+path}","compare_url":"https://api.github.com/repos/QMCPACK/qmcpack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/QMCPACK/qmcpack/merges","archive_url":"https://api.github.com/repos/QMCPACK/qmcpack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/QMCPACK/qmcpack/downloads","issues_url":"https://api.github.com/repos/QMCPACK/qmcpack/issues{/number}","pulls_url":"https://api.github.com/repos/QMCPACK/qmcpack/pulls{/number}","milestones_url":"https://api.github.com/repos/QMCPACK/qmcpack/milestones{/number}","notifications_url":"https://api.github.com/repos/QMCPACK/qmcpack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/QMCPACK/qmcpack/labels{/name}","releases_url":"https://api.github.com/repos/QMCPACK/qmcpack/releases{/id}","deployments_url":"https://api.github.com/repos/QMCPACK/qmcpack/deployments","created_at":"2017-01-11T19:02:29Z","updated_at":"2018-11-21T04:18:00Z","pushed_at":"2018-11-21T04:17:53Z","git_url":"git://github.com/QMCPACK/qmcpack.git","ssh_url":"git@github.com:QMCPACK/qmcpack.git","clone_url":"https://github.com/QMCPACK/qmcpack.git","svn_url":"https://github.com/QMCPACK/qmcpack","homepage":"http://www.qmcpack.org","size":171337,"stargazers_count":67,"watchers_count":67,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":50,"mirror_url":null,"archived":false,"open_issues_count":194,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":50,"open_issues":194,"watchers":67,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/QMCPACK/qmcpack/pulls/1165"},"html":{"href":"https://github.com/QMCPACK/qmcpack/pull/1165"},"issue":{"href":"https://api.github.com/repos/QMCPACK/qmcpack/issues/1165"},"comments":{"href":"https://api.github.com/repos/QMCPACK/qmcpack/issues/1165/comments"},"review_comments":{"href":"https://api.github.com/repos/QMCPACK/qmcpack/pulls/1165/comments"},"review_comment":{"href":"https://api.github.com/repos/QMCPACK/qmcpack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/QMCPACK/qmcpack/pulls/1165/commits"},"statuses":{"href":"https://api.github.com/repos/QMCPACK/qmcpack/statuses/d43a651b43c26031dd0324419764b8da2c360eba"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ye-luo"}}