{"action":"created","issue":{"url":"https://api.github.com/repos/ucsdlib/damspas/issues/467","repository_url":"https://api.github.com/repos/ucsdlib/damspas","labels_url":"https://api.github.com/repos/ucsdlib/damspas/issues/467/labels{/name}","comments_url":"https://api.github.com/repos/ucsdlib/damspas/issues/467/comments","events_url":"https://api.github.com/repos/ucsdlib/damspas/issues/467/events","html_url":"https://github.com/ucsdlib/damspas/issues/467","id":334206865,"node_id":"MDU6SXNzdWUzMzQyMDY4NjU=","number":467,"title":"Fix access controls for downloading mp3 and mp4 files","user":{"login":"gamontoya","id":4314914,"node_id":"MDQ6VXNlcjQzMTQ5MTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/4314914?v=4","gravatar_id":"","url":"https://api.github.com/users/gamontoya","html_url":"https://github.com/gamontoya","followers_url":"https://api.github.com/users/gamontoya/followers","following_url":"https://api.github.com/users/gamontoya/following{/other_user}","gists_url":"https://api.github.com/users/gamontoya/gists{/gist_id}","starred_url":"https://api.github.com/users/gamontoya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gamontoya/subscriptions","organizations_url":"https://api.github.com/users/gamontoya/orgs","repos_url":"https://api.github.com/users/gamontoya/repos","events_url":"https://api.github.com/users/gamontoya/events{/privacy}","received_events_url":"https://api.github.com/users/gamontoya/received_events","type":"User","site_admin":false},"labels":[{"id":873746440,"node_id":"MDU6TGFiZWw4NzM3NDY0NDA=","url":"https://api.github.com/repos/ucsdlib/damspas/labels/dams%204.0","name":"dams 4.0","color":"aaf7a3","default":false}],"state":"open","locked":false,"assignee":{"login":"lsitu","id":2430784,"node_id":"MDQ6VXNlcjI0MzA3ODQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2430784?v=4","gravatar_id":"","url":"https://api.github.com/users/lsitu","html_url":"https://github.com/lsitu","followers_url":"https://api.github.com/users/lsitu/followers","following_url":"https://api.github.com/users/lsitu/following{/other_user}","gists_url":"https://api.github.com/users/lsitu/gists{/gist_id}","starred_url":"https://api.github.com/users/lsitu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsitu/subscriptions","organizations_url":"https://api.github.com/users/lsitu/orgs","repos_url":"https://api.github.com/users/lsitu/repos","events_url":"https://api.github.com/users/lsitu/events{/privacy}","received_events_url":"https://api.github.com/users/lsitu/received_events","type":"User","site_admin":false},"assignees":[{"login":"lsitu","id":2430784,"node_id":"MDQ6VXNlcjI0MzA3ODQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2430784?v=4","gravatar_id":"","url":"https://api.github.com/users/lsitu","html_url":"https://github.com/lsitu","followers_url":"https://api.github.com/users/lsitu/followers","following_url":"https://api.github.com/users/lsitu/following{/other_user}","gists_url":"https://api.github.com/users/lsitu/gists{/gist_id}","starred_url":"https://api.github.com/users/lsitu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsitu/subscriptions","organizations_url":"https://api.github.com/users/lsitu/orgs","repos_url":"https://api.github.com/users/lsitu/repos","events_url":"https://api.github.com/users/lsitu/events{/privacy}","received_events_url":"https://api.github.com/users/lsitu/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2018-06-20T18:54:08Z","updated_at":"2018-06-20T21:17:33Z","closed_at":null,"author_association":"NONE","body":"### Descriptive summary\r\n\r\nUsers are able to download mp3 or mp4 files if they know the full URL path.\r\n\r\n- /_2.mp3\r\n- /_2.mp3?download\r\n\r\n### Expected behavior\r\n\r\nUpdate access controls for downloading of both mp3, mp4, others?"},"comment":{"url":"https://api.github.com/repos/ucsdlib/damspas/issues/comments/398900030","html_url":"https://github.com/ucsdlib/damspas/issues/467#issuecomment-398900030","issue_url":"https://api.github.com/repos/ucsdlib/damspas/issues/467","id":398900030,"node_id":"MDEyOklzc3VlQ29tbWVudDM5ODkwMDAzMA==","user":{"login":"mcritchlow","id":67506,"node_id":"MDQ6VXNlcjY3NTA2","avatar_url":"https://avatars2.githubusercontent.com/u/67506?v=4","gravatar_id":"","url":"https://api.github.com/users/mcritchlow","html_url":"https://github.com/mcritchlow","followers_url":"https://api.github.com/users/mcritchlow/followers","following_url":"https://api.github.com/users/mcritchlow/following{/other_user}","gists_url":"https://api.github.com/users/mcritchlow/gists{/gist_id}","starred_url":"https://api.github.com/users/mcritchlow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcritchlow/subscriptions","organizations_url":"https://api.github.com/users/mcritchlow/orgs","repos_url":"https://api.github.com/users/mcritchlow/repos","events_url":"https://api.github.com/users/mcritchlow/events{/privacy}","received_events_url":"https://api.github.com/users/mcritchlow/received_events","type":"User","site_admin":false},"created_at":"2018-06-20T21:17:33Z","updated_at":"2018-06-20T21:17:33Z","author_association":"MEMBER","body":"@GregReser - Thanks, very interesting. A global policy like that for mp3s seems a bit odd to me if it doesn't also apply to videos since they're both file formats we stream.. It makes me wonder if that was just based on the mp3 content we had at the time, as opposed to an overarching policy.\r\n\r\nEither way, as you said, maybe clarifying the policy on both formats, since they're both streamed, would help.\r\n\r\nThe current code essentially says if you can see the Solr record/show page, you can download a derivative. Master files are blocked to curators. So if there needs to be more nuance/granularity there we'll need to know what metadata to check to decide whether a file is downloadable. Which is sounds like you're saying would be called out by either of these? Is that true for all files?\r\n\r\n```\r\nOtherRights\\permission\\Permission\\type = \"localDisplay\"\r\nLicense\\permission\\Permission\\type = \"localDisplay\"\r\n```"}}
{"actor":{"display_login":"mcritchlow"}}