{"action":"created","comment":{"url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/comments/224991301","pull_request_review_id":164497104,"id":224991301,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDk5MTMwMQ==","diff_hunk":"@@ -80,6 +80,7 @@\n  * CHACHA20  3                  0x0051-0x0055\n  * POLY1305  3                  0x0057-0x005B\n  * CHACHAPOLY 2 0x0054-0x0056\n+ * PLATFORM  1  0x0080-0x0080","path":"include/mbedtls/error.h","position":4,"original_position":4,"commit_id":"54a7c620bbd7222950594b27f70814e10f877af4","original_commit_id":"54a7c620bbd7222950594b27f70814e10f877af4","user":{"login":"RonEld","id":22030476,"node_id":"MDQ6VXNlcjIyMDMwNDc2","avatar_url":"https://avatars0.githubusercontent.com/u/22030476?v=4","gravatar_id":"","url":"https://api.github.com/users/RonEld","html_url":"https://github.com/RonEld","followers_url":"https://api.github.com/users/RonEld/followers","following_url":"https://api.github.com/users/RonEld/following{/other_user}","gists_url":"https://api.github.com/users/RonEld/gists{/gist_id}","starred_url":"https://api.github.com/users/RonEld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RonEld/subscriptions","organizations_url":"https://api.github.com/users/RonEld/orgs","repos_url":"https://api.github.com/users/RonEld/repos","events_url":"https://api.github.com/users/RonEld/events{/privacy}","received_events_url":"https://api.github.com/users/RonEld/received_events","type":"User","site_admin":false},"body":"The low level error codes are limited up to `0x7f`\r\nThis causes `mbedtls_strerror()` not to recognize `0x80, as it is as a low level error code, but the value belongs to a high level error code.\r\nThe valuse should be changed, but it is already merged in [Mbed OS](https://github.com/ARMmbed/mbed-os/blob/master/features/mbedtls/platform/inc/platform_mbed.h#L28)\r\n@sbutcher-arm  Should we change the value, causing possible ABI issues if users have specifically expect this error code or should we change the limit of the low level error code?","created_at":"2018-10-14T12:40:04Z","updated_at":"2018-10-14T12:40:32Z","html_url":"https://github.com/ARMmbed/mbedtls/pull/1993#discussion_r224991301","pull_request_url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1993","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/comments/224991301"},"html":{"href":"https://github.com/ARMmbed/mbedtls/pull/1993#discussion_r224991301"},"pull_request":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1993"}}},"pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1993","id":211804911,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExODA0OTEx","html_url":"https://github.com/ARMmbed/mbedtls/pull/1993","diff_url":"https://github.com/ARMmbed/mbedtls/pull/1993.diff","patch_url":"https://github.com/ARMmbed/mbedtls/pull/1993.patch","issue_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/1993","number":1993,"state":"open","locked":false,"title":"Add platform error codes","user":{"login":"RonEld","id":22030476,"node_id":"MDQ6VXNlcjIyMDMwNDc2","avatar_url":"https://avatars0.githubusercontent.com/u/22030476?v=4","gravatar_id":"","url":"https://api.github.com/users/RonEld","html_url":"https://github.com/RonEld","followers_url":"https://api.github.com/users/RonEld/followers","following_url":"https://api.github.com/users/RonEld/following{/other_user}","gists_url":"https://api.github.com/users/RonEld/gists{/gist_id}","starred_url":"https://api.github.com/users/RonEld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RonEld/subscriptions","organizations_url":"https://api.github.com/users/RonEld/orgs","repos_url":"https://api.github.com/users/RonEld/repos","events_url":"https://api.github.com/users/RonEld/events{/privacy}","received_events_url":"https://api.github.com/users/RonEld/received_events","type":"User","site_admin":false},"body":"## Description\r\nAdd error codes for the platform module, to be used by\r\nthe setup \\ terminate API, as suggested in https://github.com/ARMmbed/mbed-os/pull/7099#discussion_r192698898\r\n\r\n\r\n\r\n## Status\r\n**READY**\r\n\r\n## Requires Backporting\r\nNO  \r\n\r\n","created_at":"2018-08-29T15:56:33Z","updated_at":"2018-10-14T12:40:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bdd480a8089f36d8f10647230abb32f5cb492a6e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":937149694,"node_id":"MDU6TGFiZWw5MzcxNDk2OTQ=","url":"https://api.github.com/repos/ARMmbed/mbedtls/labels/component:%20Platform","name":"component: Platform","color":"F6CED8","default":false},{"id":19280386,"node_id":"MDU6TGFiZWwxOTI4MDM4Ng==","url":"https://api.github.com/repos/ARMmbed/mbedtls/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":408190313,"node_id":"MDU6TGFiZWw0MDgxOTAzMTM=","url":"https://api.github.com/repos/ARMmbed/mbedtls/labels/mbed%20TLS%20team","name":"mbed TLS team","color":"66e0ff","default":false},{"id":338455182,"node_id":"MDU6TGFiZWwzMzg0NTUxODI=","url":"https://api.github.com/repos/ARMmbed/mbedtls/labels/ready%20for%20merge","name":"ready for merge","color":"10b410","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1993/commits","review_comments_url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1993/comments","review_comment_url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/1993/comments","statuses_url":"https://api.github.com/repos/ARMmbed/mbedtls/statuses/54a7c620bbd7222950594b27f70814e10f877af4","head":{"label":"RonEld:platform_errors","ref":"platform_errors","sha":"54a7c620bbd7222950594b27f70814e10f877af4","user":{"login":"RonEld","id":22030476,"node_id":"MDQ6VXNlcjIyMDMwNDc2","avatar_url":"https://avatars0.githubusercontent.com/u/22030476?v=4","gravatar_id":"","url":"https://api.github.com/users/RonEld","html_url":"https://github.com/RonEld","followers_url":"https://api.github.com/users/RonEld/followers","following_url":"https://api.github.com/users/RonEld/following{/other_user}","gists_url":"https://api.github.com/users/RonEld/gists{/gist_id}","starred_url":"https://api.github.com/users/RonEld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RonEld/subscriptions","organizations_url":"https://api.github.com/users/RonEld/orgs","repos_url":"https://api.github.com/users/RonEld/repos","events_url":"https://api.github.com/users/RonEld/events{/privacy}","received_events_url":"https://api.github.com/users/RonEld/received_events","type":"User","site_admin":false},"repo":{"id":76245223,"node_id":"MDEwOlJlcG9zaXRvcnk3NjI0NTIyMw==","name":"mbedtls","full_name":"RonEld/mbedtls","private":false,"owner":{"login":"RonEld","id":22030476,"node_id":"MDQ6VXNlcjIyMDMwNDc2","avatar_url":"https://avatars0.githubusercontent.com/u/22030476?v=4","gravatar_id":"","url":"https://api.github.com/users/RonEld","html_url":"https://github.com/RonEld","followers_url":"https://api.github.com/users/RonEld/followers","following_url":"https://api.github.com/users/RonEld/following{/other_user}","gists_url":"https://api.github.com/users/RonEld/gists{/gist_id}","starred_url":"https://api.github.com/users/RonEld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RonEld/subscriptions","organizations_url":"https://api.github.com/users/RonEld/orgs","repos_url":"https://api.github.com/users/RonEld/repos","events_url":"https://api.github.com/users/RonEld/events{/privacy}","received_events_url":"https://api.github.com/users/RonEld/received_events","type":"User","site_admin":false},"html_url":"https://github.com/RonEld/mbedtls","description":"An open source, portable, easy to use, readable and flexible SSL library","fork":true,"url":"https://api.github.com/repos/RonEld/mbedtls","forks_url":"https://api.github.com/repos/RonEld/mbedtls/forks","keys_url":"https://api.github.com/repos/RonEld/mbedtls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RonEld/mbedtls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RonEld/mbedtls/teams","hooks_url":"https://api.github.com/repos/RonEld/mbedtls/hooks","issue_events_url":"https://api.github.com/repos/RonEld/mbedtls/issues/events{/number}","events_url":"https://api.github.com/repos/RonEld/mbedtls/events","assignees_url":"https://api.github.com/repos/RonEld/mbedtls/assignees{/user}","branches_url":"https://api.github.com/repos/RonEld/mbedtls/branches{/branch}","tags_url":"https://api.github.com/repos/RonEld/mbedtls/tags","blobs_url":"https://api.github.com/repos/RonEld/mbedtls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RonEld/mbedtls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RonEld/mbedtls/git/refs{/sha}","trees_url":"https://api.github.com/repos/RonEld/mbedtls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RonEld/mbedtls/statuses/{sha}","languages_url":"https://api.github.com/repos/RonEld/mbedtls/languages","stargazers_url":"https://api.github.com/repos/RonEld/mbedtls/stargazers","contributors_url":"https://api.github.com/repos/RonEld/mbedtls/contributors","subscribers_url":"https://api.github.com/repos/RonEld/mbedtls/subscribers","subscription_url":"https://api.github.com/repos/RonEld/mbedtls/subscription","commits_url":"https://api.github.com/repos/RonEld/mbedtls/commits{/sha}","git_commits_url":"https://api.github.com/repos/RonEld/mbedtls/git/commits{/sha}","comments_url":"https://api.github.com/repos/RonEld/mbedtls/comments{/number}","issue_comment_url":"https://api.github.com/repos/RonEld/mbedtls/issues/comments{/number}","contents_url":"https://api.github.com/repos/RonEld/mbedtls/contents/{+path}","compare_url":"https://api.github.com/repos/RonEld/mbedtls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RonEld/mbedtls/merges","archive_url":"https://api.github.com/repos/RonEld/mbedtls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RonEld/mbedtls/downloads","issues_url":"https://api.github.com/repos/RonEld/mbedtls/issues{/number}","pulls_url":"https://api.github.com/repos/RonEld/mbedtls/pulls{/number}","milestones_url":"https://api.github.com/repos/RonEld/mbedtls/milestones{/number}","notifications_url":"https://api.github.com/repos/RonEld/mbedtls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RonEld/mbedtls/labels{/name}","releases_url":"https://api.github.com/repos/RonEld/mbedtls/releases{/id}","deployments_url":"https://api.github.com/repos/RonEld/mbedtls/deployments","created_at":"2016-12-12T10:14:13Z","updated_at":"2018-07-12T07:45:33Z","pushed_at":"2018-10-14T07:03:07Z","git_url":"git://github.com/RonEld/mbedtls.git","ssh_url":"git@github.com:RonEld/mbedtls.git","clone_url":"https://github.com/RonEld/mbedtls.git","svn_url":"https://github.com/RonEld/mbedtls","homepage":"https://tls.mbed.org","size":29821,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"development"}},"base":{"label":"ARMmbed:development","ref":"development","sha":"d22c1b2445a6e87853868acc67ae2b02ad031716","user":{"login":"ARMmbed","id":8916057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MTYwNTc=","avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":6687936,"node_id":"MDEwOlJlcG9zaXRvcnk2Njg3OTM2","name":"mbedtls","full_name":"ARMmbed/mbedtls","private":false,"owner":{"login":"ARMmbed","id":8916057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MTYwNTc=","avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ARMmbed/mbedtls","description":"An open source, portable, easy to use, readable and flexible SSL library","fork":false,"url":"https://api.github.com/repos/ARMmbed/mbedtls","forks_url":"https://api.github.com/repos/ARMmbed/mbedtls/forks","keys_url":"https://api.github.com/repos/ARMmbed/mbedtls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/mbedtls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/mbedtls/teams","hooks_url":"https://api.github.com/repos/ARMmbed/mbedtls/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/mbedtls/events","assignees_url":"https://api.github.com/repos/ARMmbed/mbedtls/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/mbedtls/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/mbedtls/tags","blobs_url":"https://api.github.com/repos/ARMmbed/mbedtls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/mbedtls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/mbedtls/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/mbedtls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/mbedtls/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/mbedtls/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/mbedtls/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/mbedtls/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/mbedtls/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/mbedtls/subscription","commits_url":"https://api.github.com/repos/ARMmbed/mbedtls/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/mbedtls/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/mbedtls/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/mbedtls/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/mbedtls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/mbedtls/merges","archive_url":"https://api.github.com/repos/ARMmbed/mbedtls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/mbedtls/downloads","issues_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/mbedtls/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/mbedtls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/mbedtls/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/mbedtls/releases{/id}","deployments_url":"https://api.github.com/repos/ARMmbed/mbedtls/deployments","created_at":"2012-11-14T13:13:13Z","updated_at":"2018-10-14T09:57:48Z","pushed_at":"2018-10-14T07:03:10Z","git_url":"git://github.com/ARMmbed/mbedtls.git","ssh_url":"git@github.com:ARMmbed/mbedtls.git","clone_url":"https://github.com/ARMmbed/mbedtls.git","svn_url":"https://github.com/ARMmbed/mbedtls","homepage":"https://tls.mbed.org","size":31009,"stargazers_count":1583,"watchers_count":1583,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":936,"mirror_url":null,"archived":false,"open_issues_count":565,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":936,"open_issues":565,"watchers":1583,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1993"},"html":{"href":"https://github.com/ARMmbed/mbedtls/pull/1993"},"issue":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/issues/1993"},"comments":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/issues/1993/comments"},"review_comments":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1993/comments"},"review_comment":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/1993/commits"},"statuses":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/statuses/54a7c620bbd7222950594b27f70814e10f877af4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"RonEld"}}