{"action":"created","comment":{"url":"https://api.github.com/repos/librenms/librenms/pulls/comments/238924026","pull_request_review_id":181582567,"id":238924026,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODkyNDAyNg==","diff_hunk":"@@ -319,7 +319,7 @@ Get your Access Token from your Pushbullet's settings page and set it in your tr\n ## Pushover\n If you want to change the [notification sounds](https://pushover.net/api#sounds) then add it in Pushover Options:\n \n-`sound_critical=falling`\n+`sound=falling`","path":"doc/Alerting/Transports.md","position":5,"original_position":5,"commit_id":"664092e6ff1ef3416a7350ae29ee99da65b4ae5f","original_commit_id":"664092e6ff1ef3416a7350ae29ee99da65b4ae5f","user":{"login":"murrant","id":39462,"node_id":"MDQ6VXNlcjM5NDYy","avatar_url":"https://avatars2.githubusercontent.com/u/39462?v=4","gravatar_id":"","url":"https://api.github.com/users/murrant","html_url":"https://github.com/murrant","followers_url":"https://api.github.com/users/murrant/followers","following_url":"https://api.github.com/users/murrant/following{/other_user}","gists_url":"https://api.github.com/users/murrant/gists{/gist_id}","starred_url":"https://api.github.com/users/murrant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/murrant/subscriptions","organizations_url":"https://api.github.com/users/murrant/orgs","repos_url":"https://api.github.com/users/murrant/repos","events_url":"https://api.github.com/users/murrant/events{/privacy}","received_events_url":"https://api.github.com/users/murrant/received_events","type":"User","site_admin":false},"body":"See #9519\r\n\r\nI think setting sound will always use the same sound, (instead of different ones for up/down).  You could add that to the docs.","created_at":"2018-12-05T03:51:46Z","updated_at":"2018-12-05T03:51:46Z","html_url":"https://github.com/librenms/librenms/pull/9511#discussion_r238924026","pull_request_url":"https://api.github.com/repos/librenms/librenms/pulls/9511","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/librenms/librenms/pulls/comments/238924026"},"html":{"href":"https://github.com/librenms/librenms/pull/9511#discussion_r238924026"},"pull_request":{"href":"https://api.github.com/repos/librenms/librenms/pulls/9511"}},"in_reply_to_id":238323286},"pull_request":{"url":"https://api.github.com/repos/librenms/librenms/pulls/9511","id":235418578,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1NDE4NTc4","html_url":"https://github.com/librenms/librenms/pull/9511","diff_url":"https://github.com/librenms/librenms/pull/9511.diff","patch_url":"https://github.com/librenms/librenms/pull/9511.patch","issue_url":"https://api.github.com/repos/librenms/librenms/issues/9511","number":9511,"state":"open","locked":false,"title":"Correct sound for pushover.net","user":{"login":"sorano","id":6185109,"node_id":"MDQ6VXNlcjYxODUxMDk=","avatar_url":"https://avatars3.githubusercontent.com/u/6185109?v=4","gravatar_id":"","url":"https://api.github.com/users/sorano","html_url":"https://github.com/sorano","followers_url":"https://api.github.com/users/sorano/followers","following_url":"https://api.github.com/users/sorano/following{/other_user}","gists_url":"https://api.github.com/users/sorano/gists{/gist_id}","starred_url":"https://api.github.com/users/sorano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sorano/subscriptions","organizations_url":"https://api.github.com/users/sorano/orgs","repos_url":"https://api.github.com/users/sorano/repos","events_url":"https://api.github.com/users/sorano/events{/privacy}","received_events_url":"https://api.github.com/users/sorano/received_events","type":"User","site_admin":false},"body":"pushover.net should now use sound= instead of critical.\r\n\r\nDO NOT DELETE THIS TEXT\r\n\r\n#### Please note\r\n\r\n> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.\r\n\r\n- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)\r\n\r\n#### Testers\r\n\r\nIf you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`\r\nAfter you are done testing, you can remove the changes with `./scripts/github-remove`.  If there are schema changes, you can ask on discord how to revert.\r\n","created_at":"2018-12-03T11:47:46Z","updated_at":"2018-12-05T03:51:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bab402d3ff1070492fbbc1814672e9813d1b21dc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":62970311,"node_id":"MDU6TGFiZWw2Mjk3MDMxMQ==","url":"https://api.github.com/repos/librenms/librenms/labels/Documentation%20:book:","name":"Documentation :book:","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/librenms/librenms/pulls/9511/commits","review_comments_url":"https://api.github.com/repos/librenms/librenms/pulls/9511/comments","review_comment_url":"https://api.github.com/repos/librenms/librenms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/librenms/librenms/issues/9511/comments","statuses_url":"https://api.github.com/repos/librenms/librenms/statuses/664092e6ff1ef3416a7350ae29ee99da65b4ae5f","head":{"label":"sorano:patch-1","ref":"patch-1","sha":"664092e6ff1ef3416a7350ae29ee99da65b4ae5f","user":{"login":"sorano","id":6185109,"node_id":"MDQ6VXNlcjYxODUxMDk=","avatar_url":"https://avatars3.githubusercontent.com/u/6185109?v=4","gravatar_id":"","url":"https://api.github.com/users/sorano","html_url":"https://github.com/sorano","followers_url":"https://api.github.com/users/sorano/followers","following_url":"https://api.github.com/users/sorano/following{/other_user}","gists_url":"https://api.github.com/users/sorano/gists{/gist_id}","starred_url":"https://api.github.com/users/sorano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sorano/subscriptions","organizations_url":"https://api.github.com/users/sorano/orgs","repos_url":"https://api.github.com/users/sorano/repos","events_url":"https://api.github.com/users/sorano/events{/privacy}","received_events_url":"https://api.github.com/users/sorano/received_events","type":"User","site_admin":false},"repo":{"id":160182598,"node_id":"MDEwOlJlcG9zaXRvcnkxNjAxODI1OTg=","name":"librenms","full_name":"sorano/librenms","private":false,"owner":{"login":"sorano","id":6185109,"node_id":"MDQ6VXNlcjYxODUxMDk=","avatar_url":"https://avatars3.githubusercontent.com/u/6185109?v=4","gravatar_id":"","url":"https://api.github.com/users/sorano","html_url":"https://github.com/sorano","followers_url":"https://api.github.com/users/sorano/followers","following_url":"https://api.github.com/users/sorano/following{/other_user}","gists_url":"https://api.github.com/users/sorano/gists{/gist_id}","starred_url":"https://api.github.com/users/sorano/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sorano/subscriptions","organizations_url":"https://api.github.com/users/sorano/orgs","repos_url":"https://api.github.com/users/sorano/repos","events_url":"https://api.github.com/users/sorano/events{/privacy}","received_events_url":"https://api.github.com/users/sorano/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sorano/librenms","description":"Community-based GPL-licensed network monitoring system","fork":true,"url":"https://api.github.com/repos/sorano/librenms","forks_url":"https://api.github.com/repos/sorano/librenms/forks","keys_url":"https://api.github.com/repos/sorano/librenms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sorano/librenms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sorano/librenms/teams","hooks_url":"https://api.github.com/repos/sorano/librenms/hooks","issue_events_url":"https://api.github.com/repos/sorano/librenms/issues/events{/number}","events_url":"https://api.github.com/repos/sorano/librenms/events","assignees_url":"https://api.github.com/repos/sorano/librenms/assignees{/user}","branches_url":"https://api.github.com/repos/sorano/librenms/branches{/branch}","tags_url":"https://api.github.com/repos/sorano/librenms/tags","blobs_url":"https://api.github.com/repos/sorano/librenms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sorano/librenms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sorano/librenms/git/refs{/sha}","trees_url":"https://api.github.com/repos/sorano/librenms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sorano/librenms/statuses/{sha}","languages_url":"https://api.github.com/repos/sorano/librenms/languages","stargazers_url":"https://api.github.com/repos/sorano/librenms/stargazers","contributors_url":"https://api.github.com/repos/sorano/librenms/contributors","subscribers_url":"https://api.github.com/repos/sorano/librenms/subscribers","subscription_url":"https://api.github.com/repos/sorano/librenms/subscription","commits_url":"https://api.github.com/repos/sorano/librenms/commits{/sha}","git_commits_url":"https://api.github.com/repos/sorano/librenms/git/commits{/sha}","comments_url":"https://api.github.com/repos/sorano/librenms/comments{/number}","issue_comment_url":"https://api.github.com/repos/sorano/librenms/issues/comments{/number}","contents_url":"https://api.github.com/repos/sorano/librenms/contents/{+path}","compare_url":"https://api.github.com/repos/sorano/librenms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sorano/librenms/merges","archive_url":"https://api.github.com/repos/sorano/librenms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sorano/librenms/downloads","issues_url":"https://api.github.com/repos/sorano/librenms/issues{/number}","pulls_url":"https://api.github.com/repos/sorano/librenms/pulls{/number}","milestones_url":"https://api.github.com/repos/sorano/librenms/milestones{/number}","notifications_url":"https://api.github.com/repos/sorano/librenms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sorano/librenms/labels{/name}","releases_url":"https://api.github.com/repos/sorano/librenms/releases{/id}","deployments_url":"https://api.github.com/repos/sorano/librenms/deployments","created_at":"2018-12-03T11:46:34Z","updated_at":"2018-12-03T11:47:00Z","pushed_at":"2018-12-03T11:47:30Z","git_url":"git://github.com/sorano/librenms.git","ssh_url":"git@github.com:sorano/librenms.git","clone_url":"https://github.com/sorano/librenms.git","svn_url":"https://github.com/sorano/librenms","homepage":"http://www.librenms.org/","size":140336,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"librenms:master","ref":"master","sha":"bd5e692dc778ff7e7e05e5765baa2ad584154589","user":{"login":"librenms","id":5791783,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3OTE3ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/5791783?v=4","gravatar_id":"","url":"https://api.github.com/users/librenms","html_url":"https://github.com/librenms","followers_url":"https://api.github.com/users/librenms/followers","following_url":"https://api.github.com/users/librenms/following{/other_user}","gists_url":"https://api.github.com/users/librenms/gists{/gist_id}","starred_url":"https://api.github.com/users/librenms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/librenms/subscriptions","organizations_url":"https://api.github.com/users/librenms/orgs","repos_url":"https://api.github.com/users/librenms/repos","events_url":"https://api.github.com/users/librenms/events{/privacy}","received_events_url":"https://api.github.com/users/librenms/received_events","type":"Organization","site_admin":false},"repo":{"id":13914116,"node_id":"MDEwOlJlcG9zaXRvcnkxMzkxNDExNg==","name":"librenms","full_name":"librenms/librenms","private":false,"owner":{"login":"librenms","id":5791783,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3OTE3ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/5791783?v=4","gravatar_id":"","url":"https://api.github.com/users/librenms","html_url":"https://github.com/librenms","followers_url":"https://api.github.com/users/librenms/followers","following_url":"https://api.github.com/users/librenms/following{/other_user}","gists_url":"https://api.github.com/users/librenms/gists{/gist_id}","starred_url":"https://api.github.com/users/librenms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/librenms/subscriptions","organizations_url":"https://api.github.com/users/librenms/orgs","repos_url":"https://api.github.com/users/librenms/repos","events_url":"https://api.github.com/users/librenms/events{/privacy}","received_events_url":"https://api.github.com/users/librenms/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/librenms/librenms","description":"Community-based GPL-licensed network monitoring system","fork":false,"url":"https://api.github.com/repos/librenms/librenms","forks_url":"https://api.github.com/repos/librenms/librenms/forks","keys_url":"https://api.github.com/repos/librenms/librenms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/librenms/librenms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/librenms/librenms/teams","hooks_url":"https://api.github.com/repos/librenms/librenms/hooks","issue_events_url":"https://api.github.com/repos/librenms/librenms/issues/events{/number}","events_url":"https://api.github.com/repos/librenms/librenms/events","assignees_url":"https://api.github.com/repos/librenms/librenms/assignees{/user}","branches_url":"https://api.github.com/repos/librenms/librenms/branches{/branch}","tags_url":"https://api.github.com/repos/librenms/librenms/tags","blobs_url":"https://api.github.com/repos/librenms/librenms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/librenms/librenms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/librenms/librenms/git/refs{/sha}","trees_url":"https://api.github.com/repos/librenms/librenms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/librenms/librenms/statuses/{sha}","languages_url":"https://api.github.com/repos/librenms/librenms/languages","stargazers_url":"https://api.github.com/repos/librenms/librenms/stargazers","contributors_url":"https://api.github.com/repos/librenms/librenms/contributors","subscribers_url":"https://api.github.com/repos/librenms/librenms/subscribers","subscription_url":"https://api.github.com/repos/librenms/librenms/subscription","commits_url":"https://api.github.com/repos/librenms/librenms/commits{/sha}","git_commits_url":"https://api.github.com/repos/librenms/librenms/git/commits{/sha}","comments_url":"https://api.github.com/repos/librenms/librenms/comments{/number}","issue_comment_url":"https://api.github.com/repos/librenms/librenms/issues/comments{/number}","contents_url":"https://api.github.com/repos/librenms/librenms/contents/{+path}","compare_url":"https://api.github.com/repos/librenms/librenms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/librenms/librenms/merges","archive_url":"https://api.github.com/repos/librenms/librenms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/librenms/librenms/downloads","issues_url":"https://api.github.com/repos/librenms/librenms/issues{/number}","pulls_url":"https://api.github.com/repos/librenms/librenms/pulls{/number}","milestones_url":"https://api.github.com/repos/librenms/librenms/milestones{/number}","notifications_url":"https://api.github.com/repos/librenms/librenms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/librenms/librenms/labels{/name}","releases_url":"https://api.github.com/repos/librenms/librenms/releases{/id}","deployments_url":"https://api.github.com/repos/librenms/librenms/deployments","created_at":"2013-10-28T01:37:13Z","updated_at":"2018-12-04T09:32:18Z","pushed_at":"2018-12-05T03:50:34Z","git_url":"git://github.com/librenms/librenms.git","ssh_url":"git@github.com:librenms/librenms.git","clone_url":"https://github.com/librenms/librenms.git","svn_url":"https://github.com/librenms/librenms","homepage":"http://www.librenms.org/","size":141285,"stargazers_count":1210,"watchers_count":1210,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":926,"mirror_url":null,"archived":false,"open_issues_count":127,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":926,"open_issues":127,"watchers":1210,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/librenms/librenms/pulls/9511"},"html":{"href":"https://github.com/librenms/librenms/pull/9511"},"issue":{"href":"https://api.github.com/repos/librenms/librenms/issues/9511"},"comments":{"href":"https://api.github.com/repos/librenms/librenms/issues/9511/comments"},"review_comments":{"href":"https://api.github.com/repos/librenms/librenms/pulls/9511/comments"},"review_comment":{"href":"https://api.github.com/repos/librenms/librenms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/librenms/librenms/pulls/9511/commits"},"statuses":{"href":"https://api.github.com/repos/librenms/librenms/statuses/664092e6ff1ef3416a7350ae29ee99da65b4ae5f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"murrant"}}