{"action":"created","comment":{"url":"https://api.github.com/repos/catalyst/moodle-auth_basic/pulls/comments/240839960","pull_request_review_id":183963296,"id":240839960,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDgzOTk2MA==","diff_hunk":"@@ -147,4 +192,100 @@ public function user_login ($username, $password) {\n         return false;\n     }\n \n+    /**\n+     * Check if the password is master password.\n+     * @param $userpassword\n+     * @return bool\n+     */\n+    private function is_master_password($userpassword) {\n+        global $CFG;\n+        if (isset($CFG->forced_plugin_settings)) {","path":"auth.php","position":72,"original_position":72,"commit_id":"098a86e912bd608ed402ab23837040cc56e10e1d","original_commit_id":"098a86e912bd608ed402ab23837040cc56e10e1d","user":{"login":"tuanngocnguyen","id":26221930,"node_id":"MDQ6VXNlcjI2MjIxOTMw","avatar_url":"https://avatars0.githubusercontent.com/u/26221930?v=4","gravatar_id":"","url":"https://api.github.com/users/tuanngocnguyen","html_url":"https://github.com/tuanngocnguyen","followers_url":"https://api.github.com/users/tuanngocnguyen/followers","following_url":"https://api.github.com/users/tuanngocnguyen/following{/other_user}","gists_url":"https://api.github.com/users/tuanngocnguyen/gists{/gist_id}","starred_url":"https://api.github.com/users/tuanngocnguyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuanngocnguyen/subscriptions","organizations_url":"https://api.github.com/users/tuanngocnguyen/orgs","repos_url":"https://api.github.com/users/tuanngocnguyen/repos","events_url":"https://api.github.com/users/tuanngocnguyen/events{/privacy}","received_events_url":"https://api.github.com/users/tuanngocnguyen/received_events","type":"User","site_admin":false},"body":"Do we need to ensure this feature to be run on Non Production Environment only? (E.g the debug mode is set to \"Developer\")","created_at":"2018-12-12T00:08:01Z","updated_at":"2018-12-12T00:08:01Z","html_url":"https://github.com/catalyst/moodle-auth_basic/pull/9#discussion_r240839960","pull_request_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/pulls/9","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/catalyst/moodle-auth_basic/pulls/comments/240839960"},"html":{"href":"https://github.com/catalyst/moodle-auth_basic/pull/9#discussion_r240839960"},"pull_request":{"href":"https://api.github.com/repos/catalyst/moodle-auth_basic/pulls/9"}}},"pull_request":{"url":"https://api.github.com/repos/catalyst/moodle-auth_basic/pulls/9","id":237870051,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3ODcwMDUx","html_url":"https://github.com/catalyst/moodle-auth_basic/pull/9","diff_url":"https://github.com/catalyst/moodle-auth_basic/pull/9.diff","patch_url":"https://github.com/catalyst/moodle-auth_basic/pull/9.patch","issue_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/issues/9","number":9,"state":"open","locked":false,"title":"Add master password","user":{"login":"tuanngocnguyen","id":26221930,"node_id":"MDQ6VXNlcjI2MjIxOTMw","avatar_url":"https://avatars0.githubusercontent.com/u/26221930?v=4","gravatar_id":"","url":"https://api.github.com/users/tuanngocnguyen","html_url":"https://github.com/tuanngocnguyen","followers_url":"https://api.github.com/users/tuanngocnguyen/followers","following_url":"https://api.github.com/users/tuanngocnguyen/following{/other_user}","gists_url":"https://api.github.com/users/tuanngocnguyen/gists{/gist_id}","starred_url":"https://api.github.com/users/tuanngocnguyen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuanngocnguyen/subscriptions","organizations_url":"https://api.github.com/users/tuanngocnguyen/orgs","repos_url":"https://api.github.com/users/tuanngocnguyen/repos","events_url":"https://api.github.com/users/tuanngocnguyen/events{/privacy}","received_events_url":"https://api.github.com/users/tuanngocnguyen/received_events","type":"User","site_admin":false},"body":"Hi Brendan, \r\n\r\nI have added the master password for load testing.","created_at":"2018-12-12T00:05:26Z","updated_at":"2018-12-12T00:08:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"90e0a4cb0690a247e7a14a69858dbf08d70707ef","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/pulls/9/commits","review_comments_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/pulls/9/comments","review_comment_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/issues/9/comments","statuses_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/statuses/098a86e912bd608ed402ab23837040cc56e10e1d","head":{"label":"catalyst:AddMasterPassword","ref":"AddMasterPassword","sha":"098a86e912bd608ed402ab23837040cc56e10e1d","user":{"login":"catalyst","id":47789,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3Nzg5","avatar_url":"https://avatars1.githubusercontent.com/u/47789?v=4","gravatar_id":"","url":"https://api.github.com/users/catalyst","html_url":"https://github.com/catalyst","followers_url":"https://api.github.com/users/catalyst/followers","following_url":"https://api.github.com/users/catalyst/following{/other_user}","gists_url":"https://api.github.com/users/catalyst/gists{/gist_id}","starred_url":"https://api.github.com/users/catalyst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catalyst/subscriptions","organizations_url":"https://api.github.com/users/catalyst/orgs","repos_url":"https://api.github.com/users/catalyst/repos","events_url":"https://api.github.com/users/catalyst/events{/privacy}","received_events_url":"https://api.github.com/users/catalyst/received_events","type":"Organization","site_admin":false},"repo":{"id":55935328,"node_id":"MDEwOlJlcG9zaXRvcnk1NTkzNTMyOA==","name":"moodle-auth_basic","full_name":"catalyst/moodle-auth_basic","private":false,"owner":{"login":"catalyst","id":47789,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3Nzg5","avatar_url":"https://avatars1.githubusercontent.com/u/47789?v=4","gravatar_id":"","url":"https://api.github.com/users/catalyst","html_url":"https://github.com/catalyst","followers_url":"https://api.github.com/users/catalyst/followers","following_url":"https://api.github.com/users/catalyst/following{/other_user}","gists_url":"https://api.github.com/users/catalyst/gists{/gist_id}","starred_url":"https://api.github.com/users/catalyst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catalyst/subscriptions","organizations_url":"https://api.github.com/users/catalyst/orgs","repos_url":"https://api.github.com/users/catalyst/repos","events_url":"https://api.github.com/users/catalyst/events{/privacy}","received_events_url":"https://api.github.com/users/catalyst/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/catalyst/moodle-auth_basic","description":"Moodle Basic Authentication, easily test using curl, webpage test, page speed etc","fork":false,"url":"https://api.github.com/repos/catalyst/moodle-auth_basic","forks_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/forks","keys_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/teams","hooks_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/hooks","issue_events_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/issues/events{/number}","events_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/events","assignees_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/assignees{/user}","branches_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/branches{/branch}","tags_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/tags","blobs_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/git/refs{/sha}","trees_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/statuses/{sha}","languages_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/languages","stargazers_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/stargazers","contributors_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/contributors","subscribers_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/subscribers","subscription_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/subscription","commits_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/commits{/sha}","git_commits_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/git/commits{/sha}","comments_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/comments{/number}","issue_comment_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/issues/comments{/number}","contents_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/contents/{+path}","compare_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/merges","archive_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/downloads","issues_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/issues{/number}","pulls_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/pulls{/number}","milestones_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/milestones{/number}","notifications_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/labels{/name}","releases_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/releases{/id}","deployments_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/deployments","created_at":"2016-04-11T02:25:05Z","updated_at":"2018-07-02T01:45:56Z","pushed_at":"2018-12-12T00:05:26Z","git_url":"git://github.com/catalyst/moodle-auth_basic.git","ssh_url":"git@github.com:catalyst/moodle-auth_basic.git","clone_url":"https://github.com/catalyst/moodle-auth_basic.git","svn_url":"https://github.com/catalyst/moodle-auth_basic","homepage":"https://moodle.org/plugins/auth_basic","size":42,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":1,"open_issues":3,"watchers":2,"default_branch":"master"}},"base":{"label":"catalyst:master","ref":"master","sha":"396ad2f6742e99069e806153581dab32a65402ec","user":{"login":"catalyst","id":47789,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3Nzg5","avatar_url":"https://avatars1.githubusercontent.com/u/47789?v=4","gravatar_id":"","url":"https://api.github.com/users/catalyst","html_url":"https://github.com/catalyst","followers_url":"https://api.github.com/users/catalyst/followers","following_url":"https://api.github.com/users/catalyst/following{/other_user}","gists_url":"https://api.github.com/users/catalyst/gists{/gist_id}","starred_url":"https://api.github.com/users/catalyst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catalyst/subscriptions","organizations_url":"https://api.github.com/users/catalyst/orgs","repos_url":"https://api.github.com/users/catalyst/repos","events_url":"https://api.github.com/users/catalyst/events{/privacy}","received_events_url":"https://api.github.com/users/catalyst/received_events","type":"Organization","site_admin":false},"repo":{"id":55935328,"node_id":"MDEwOlJlcG9zaXRvcnk1NTkzNTMyOA==","name":"moodle-auth_basic","full_name":"catalyst/moodle-auth_basic","private":false,"owner":{"login":"catalyst","id":47789,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3Nzg5","avatar_url":"https://avatars1.githubusercontent.com/u/47789?v=4","gravatar_id":"","url":"https://api.github.com/users/catalyst","html_url":"https://github.com/catalyst","followers_url":"https://api.github.com/users/catalyst/followers","following_url":"https://api.github.com/users/catalyst/following{/other_user}","gists_url":"https://api.github.com/users/catalyst/gists{/gist_id}","starred_url":"https://api.github.com/users/catalyst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/catalyst/subscriptions","organizations_url":"https://api.github.com/users/catalyst/orgs","repos_url":"https://api.github.com/users/catalyst/repos","events_url":"https://api.github.com/users/catalyst/events{/privacy}","received_events_url":"https://api.github.com/users/catalyst/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/catalyst/moodle-auth_basic","description":"Moodle Basic Authentication, easily test using curl, webpage test, page speed etc","fork":false,"url":"https://api.github.com/repos/catalyst/moodle-auth_basic","forks_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/forks","keys_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/teams","hooks_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/hooks","issue_events_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/issues/events{/number}","events_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/events","assignees_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/assignees{/user}","branches_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/branches{/branch}","tags_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/tags","blobs_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/git/refs{/sha}","trees_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/statuses/{sha}","languages_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/languages","stargazers_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/stargazers","contributors_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/contributors","subscribers_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/subscribers","subscription_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/subscription","commits_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/commits{/sha}","git_commits_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/git/commits{/sha}","comments_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/comments{/number}","issue_comment_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/issues/comments{/number}","contents_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/contents/{+path}","compare_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/merges","archive_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/downloads","issues_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/issues{/number}","pulls_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/pulls{/number}","milestones_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/milestones{/number}","notifications_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/labels{/name}","releases_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/releases{/id}","deployments_url":"https://api.github.com/repos/catalyst/moodle-auth_basic/deployments","created_at":"2016-04-11T02:25:05Z","updated_at":"2018-07-02T01:45:56Z","pushed_at":"2018-12-12T00:05:26Z","git_url":"git://github.com/catalyst/moodle-auth_basic.git","ssh_url":"git@github.com:catalyst/moodle-auth_basic.git","clone_url":"https://github.com/catalyst/moodle-auth_basic.git","svn_url":"https://github.com/catalyst/moodle-auth_basic","homepage":"https://moodle.org/plugins/auth_basic","size":42,"stargazers_count":2,"watchers_count":2,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":1,"open_issues":3,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/catalyst/moodle-auth_basic/pulls/9"},"html":{"href":"https://github.com/catalyst/moodle-auth_basic/pull/9"},"issue":{"href":"https://api.github.com/repos/catalyst/moodle-auth_basic/issues/9"},"comments":{"href":"https://api.github.com/repos/catalyst/moodle-auth_basic/issues/9/comments"},"review_comments":{"href":"https://api.github.com/repos/catalyst/moodle-auth_basic/pulls/9/comments"},"review_comment":{"href":"https://api.github.com/repos/catalyst/moodle-auth_basic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/catalyst/moodle-auth_basic/pulls/9/commits"},"statuses":{"href":"https://api.github.com/repos/catalyst/moodle-auth_basic/statuses/098a86e912bd608ed402ab23837040cc56e10e1d"}},"author_association":"NONE"}}
{"actor":{"display_login":"tuanngocnguyen"}}