{"action":"opened","number":5,"pull_request":{"url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/pulls/5","id":210908381,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwOTA4Mzgx","html_url":"https://github.com/adamconnelly/WindsorAppConfigFacility/pull/5","diff_url":"https://github.com/adamconnelly/WindsorAppConfigFacility/pull/5.diff","patch_url":"https://github.com/adamconnelly/WindsorAppConfigFacility/pull/5.patch","issue_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/issues/5","number":5,"state":"open","locked":false,"title":"Tweaks to ConversionManager changes","user":{"login":"adamconnelly","id":1884632,"node_id":"MDQ6VXNlcjE4ODQ2MzI=","avatar_url":"https://avatars1.githubusercontent.com/u/1884632?v=4","gravatar_id":"","url":"https://api.github.com/users/adamconnelly","html_url":"https://github.com/adamconnelly","followers_url":"https://api.github.com/users/adamconnelly/followers","following_url":"https://api.github.com/users/adamconnelly/following{/other_user}","gists_url":"https://api.github.com/users/adamconnelly/gists{/gist_id}","starred_url":"https://api.github.com/users/adamconnelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamconnelly/subscriptions","organizations_url":"https://api.github.com/users/adamconnelly/orgs","repos_url":"https://api.github.com/users/adamconnelly/repos","events_url":"https://api.github.com/users/adamconnelly/events{/privacy}","received_events_url":"https://api.github.com/users/adamconnelly/received_events","type":"User","site_admin":false},"body":"This is a slightly altered version of the PR in #4. I've rebased to merge some of the intermediate commits together, and I've also altered the code so that the `IConversionManager` gets passed into the settings providers directly instead of passing in the kernel. This meant I could remove the code to create a Windsor container from the unit tests.","created_at":"2018-08-25T15:45:15Z","updated_at":"2018-08-25T15:45:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/pulls/5/commits","review_comments_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/pulls/5/comments","review_comment_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/pulls/comments{/number}","comments_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/issues/5/comments","statuses_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/statuses/8f5355d84d58a85e01675b52886528fcdf7a9b44","head":{"label":"adamconnelly:dvdwouwe-master","ref":"dvdwouwe-master","sha":"8f5355d84d58a85e01675b52886528fcdf7a9b44","user":{"login":"adamconnelly","id":1884632,"node_id":"MDQ6VXNlcjE4ODQ2MzI=","avatar_url":"https://avatars1.githubusercontent.com/u/1884632?v=4","gravatar_id":"","url":"https://api.github.com/users/adamconnelly","html_url":"https://github.com/adamconnelly","followers_url":"https://api.github.com/users/adamconnelly/followers","following_url":"https://api.github.com/users/adamconnelly/following{/other_user}","gists_url":"https://api.github.com/users/adamconnelly/gists{/gist_id}","starred_url":"https://api.github.com/users/adamconnelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamconnelly/subscriptions","organizations_url":"https://api.github.com/users/adamconnelly/orgs","repos_url":"https://api.github.com/users/adamconnelly/repos","events_url":"https://api.github.com/users/adamconnelly/events{/privacy}","received_events_url":"https://api.github.com/users/adamconnelly/received_events","type":"User","site_admin":false},"repo":{"id":24988816,"node_id":"MDEwOlJlcG9zaXRvcnkyNDk4ODgxNg==","name":"WindsorAppConfigFacility","full_name":"adamconnelly/WindsorAppConfigFacility","owner":{"login":"adamconnelly","id":1884632,"node_id":"MDQ6VXNlcjE4ODQ2MzI=","avatar_url":"https://avatars1.githubusercontent.com/u/1884632?v=4","gravatar_id":"","url":"https://api.github.com/users/adamconnelly","html_url":"https://github.com/adamconnelly","followers_url":"https://api.github.com/users/adamconnelly/followers","following_url":"https://api.github.com/users/adamconnelly/following{/other_user}","gists_url":"https://api.github.com/users/adamconnelly/gists{/gist_id}","starred_url":"https://api.github.com/users/adamconnelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamconnelly/subscriptions","organizations_url":"https://api.github.com/users/adamconnelly/orgs","repos_url":"https://api.github.com/users/adamconnelly/repos","events_url":"https://api.github.com/users/adamconnelly/events{/privacy}","received_events_url":"https://api.github.com/users/adamconnelly/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adamconnelly/WindsorAppConfigFacility","description":"A Windsor facility for creating interfaces for accessing app settings","fork":false,"url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility","forks_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/forks","keys_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/teams","hooks_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/hooks","issue_events_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/issues/events{/number}","events_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/events","assignees_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/assignees{/user}","branches_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/branches{/branch}","tags_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/tags","blobs_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/git/refs{/sha}","trees_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/statuses/{sha}","languages_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/languages","stargazers_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/stargazers","contributors_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/contributors","subscribers_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/subscribers","subscription_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/subscription","commits_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/commits{/sha}","git_commits_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/git/commits{/sha}","comments_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/comments{/number}","issue_comment_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/issues/comments{/number}","contents_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/contents/{+path}","compare_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/merges","archive_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/downloads","issues_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/issues{/number}","pulls_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/pulls{/number}","milestones_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/milestones{/number}","notifications_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/labels{/name}","releases_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/releases{/id}","deployments_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/deployments","created_at":"2014-10-09T12:47:39Z","updated_at":"2018-03-08T07:29:12Z","pushed_at":"2018-08-25T15:41:33Z","git_url":"git://github.com/adamconnelly/WindsorAppConfigFacility.git","ssh_url":"git@github.com:adamconnelly/WindsorAppConfigFacility.git","clone_url":"https://github.com/adamconnelly/WindsorAppConfigFacility.git","svn_url":"https://github.com/adamconnelly/WindsorAppConfigFacility","homepage":null,"size":561,"stargazers_count":7,"watchers_count":7,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":2,"watchers":7,"default_branch":"master"}},"base":{"label":"adamconnelly:master","ref":"master","sha":"5d5f301369324ebddcd6354b1d0f2c47c5219e86","user":{"login":"adamconnelly","id":1884632,"node_id":"MDQ6VXNlcjE4ODQ2MzI=","avatar_url":"https://avatars1.githubusercontent.com/u/1884632?v=4","gravatar_id":"","url":"https://api.github.com/users/adamconnelly","html_url":"https://github.com/adamconnelly","followers_url":"https://api.github.com/users/adamconnelly/followers","following_url":"https://api.github.com/users/adamconnelly/following{/other_user}","gists_url":"https://api.github.com/users/adamconnelly/gists{/gist_id}","starred_url":"https://api.github.com/users/adamconnelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamconnelly/subscriptions","organizations_url":"https://api.github.com/users/adamconnelly/orgs","repos_url":"https://api.github.com/users/adamconnelly/repos","events_url":"https://api.github.com/users/adamconnelly/events{/privacy}","received_events_url":"https://api.github.com/users/adamconnelly/received_events","type":"User","site_admin":false},"repo":{"id":24988816,"node_id":"MDEwOlJlcG9zaXRvcnkyNDk4ODgxNg==","name":"WindsorAppConfigFacility","full_name":"adamconnelly/WindsorAppConfigFacility","owner":{"login":"adamconnelly","id":1884632,"node_id":"MDQ6VXNlcjE4ODQ2MzI=","avatar_url":"https://avatars1.githubusercontent.com/u/1884632?v=4","gravatar_id":"","url":"https://api.github.com/users/adamconnelly","html_url":"https://github.com/adamconnelly","followers_url":"https://api.github.com/users/adamconnelly/followers","following_url":"https://api.github.com/users/adamconnelly/following{/other_user}","gists_url":"https://api.github.com/users/adamconnelly/gists{/gist_id}","starred_url":"https://api.github.com/users/adamconnelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamconnelly/subscriptions","organizations_url":"https://api.github.com/users/adamconnelly/orgs","repos_url":"https://api.github.com/users/adamconnelly/repos","events_url":"https://api.github.com/users/adamconnelly/events{/privacy}","received_events_url":"https://api.github.com/users/adamconnelly/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adamconnelly/WindsorAppConfigFacility","description":"A Windsor facility for creating interfaces for accessing app settings","fork":false,"url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility","forks_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/forks","keys_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/teams","hooks_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/hooks","issue_events_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/issues/events{/number}","events_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/events","assignees_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/assignees{/user}","branches_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/branches{/branch}","tags_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/tags","blobs_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/git/refs{/sha}","trees_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/statuses/{sha}","languages_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/languages","stargazers_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/stargazers","contributors_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/contributors","subscribers_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/subscribers","subscription_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/subscription","commits_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/commits{/sha}","git_commits_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/git/commits{/sha}","comments_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/comments{/number}","issue_comment_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/issues/comments{/number}","contents_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/contents/{+path}","compare_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/merges","archive_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/downloads","issues_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/issues{/number}","pulls_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/pulls{/number}","milestones_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/milestones{/number}","notifications_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/labels{/name}","releases_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/releases{/id}","deployments_url":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/deployments","created_at":"2014-10-09T12:47:39Z","updated_at":"2018-03-08T07:29:12Z","pushed_at":"2018-08-25T15:41:33Z","git_url":"git://github.com/adamconnelly/WindsorAppConfigFacility.git","ssh_url":"git@github.com:adamconnelly/WindsorAppConfigFacility.git","clone_url":"https://github.com/adamconnelly/WindsorAppConfigFacility.git","svn_url":"https://github.com/adamconnelly/WindsorAppConfigFacility","homepage":null,"size":561,"stargazers_count":7,"watchers_count":7,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":2,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/pulls/5"},"html":{"href":"https://github.com/adamconnelly/WindsorAppConfigFacility/pull/5"},"issue":{"href":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/issues/5"},"comments":{"href":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/adamconnelly/WindsorAppConfigFacility/statuses/8f5355d84d58a85e01675b52886528fcdf7a9b44"}},"author_association":"OWNER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":5,"additions":228,"deletions":42,"changed_files":19}}
{"actor":{"display_login":"adamconnelly"}}