{"action":"created","comment":{"url":"https://api.github.com/repos/wireapp/wire-server/pulls/comments/241153165","pull_request_review_id":184354023,"id":241153165,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTE1MzE2NQ==","diff_hunk":"@@ -249,15 +249,5 @@ internalStatus = pure NoContent\n -- get deleted.\n internalDeleteTeam :: TeamId -> Spar NoContent\n internalDeleteTeam team = do\n-  wrapMonadClient $ do\n-    -- Delete all tokens belonging to a team.\n-    Data.deleteTeamScimTokens team\n-    -- Since IdPs are not shared between teams, we can look at the set of IdPs\n-    -- used by the team, and remove everything related to those IdPs, too.\n-    idps <- Data.getIdPConfigsByTeam team\n-    for_ idps $ \\idp -> do\n-      let idpid = idp ^. SAML.idpId\n-          issuer = idp ^. SAML.idpMetadata . SAML.edIssuer\n-      Data.deleteIdPConfig idpid issuer team\n-      Data.deleteUsersByIssuer issuer\n+  wrapMonadClient $ Data.deleteTeam team","path":"services/spar/src/Spar/API.hs","position":50,"original_position":15,"commit_id":"320fa1501c57134e4f4ef153ab0b03b0ff267ee9","original_commit_id":"320fa1501c57134e4f4ef153ab0b03b0ff267ee9","user":{"login":"fisx","id":10210727,"node_id":"MDQ6VXNlcjEwMjEwNzI3","avatar_url":"https://avatars0.githubusercontent.com/u/10210727?v=4","gravatar_id":"","url":"https://api.github.com/users/fisx","html_url":"https://github.com/fisx","followers_url":"https://api.github.com/users/fisx/followers","following_url":"https://api.github.com/users/fisx/following{/other_user}","gists_url":"https://api.github.com/users/fisx/gists{/gist_id}","starred_url":"https://api.github.com/users/fisx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fisx/subscriptions","organizations_url":"https://api.github.com/users/fisx/orgs","repos_url":"https://api.github.com/users/fisx/repos","events_url":"https://api.github.com/users/fisx/events{/privacy}","received_events_url":"https://api.github.com/users/fisx/received_events","type":"User","site_admin":false},"body":"good idea!","created_at":"2018-12-12T19:25:45Z","updated_at":"2018-12-12T19:35:14Z","html_url":"https://github.com/wireapp/wire-server/pull/519#discussion_r241153165","pull_request_url":"https://api.github.com/repos/wireapp/wire-server/pulls/519","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/wireapp/wire-server/pulls/comments/241153165"},"html":{"href":"https://github.com/wireapp/wire-server/pull/519#discussion_r241153165"},"pull_request":{"href":"https://api.github.com/repos/wireapp/wire-server/pulls/519"}}},"pull_request":{"url":"https://api.github.com/repos/wireapp/wire-server/pulls/519","id":232982746,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyOTgyNzQ2","html_url":"https://github.com/wireapp/wire-server/pull/519","diff_url":"https://github.com/wireapp/wire-server/pull/519.diff","patch_url":"https://github.com/wireapp/wire-server/pull/519.patch","issue_url":"https://api.github.com/repos/wireapp/wire-server/issues/519","number":519,"state":"open","locked":false,"title":"Notify Spar when a team is deleted","user":{"login":"neongreen","id":1523306,"node_id":"MDQ6VXNlcjE1MjMzMDY=","avatar_url":"https://avatars3.githubusercontent.com/u/1523306?v=4","gravatar_id":"","url":"https://api.github.com/users/neongreen","html_url":"https://github.com/neongreen","followers_url":"https://api.github.com/users/neongreen/followers","following_url":"https://api.github.com/users/neongreen/following{/other_user}","gists_url":"https://api.github.com/users/neongreen/gists{/gist_id}","starred_url":"https://api.github.com/users/neongreen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neongreen/subscriptions","organizations_url":"https://api.github.com/users/neongreen/orgs","repos_url":"https://api.github.com/users/neongreen/repos","events_url":"https://api.github.com/users/neongreen/events{/privacy}","received_events_url":"https://api.github.com/users/neongreen/received_events","type":"User","site_admin":false},"body":"* [x] Delete tokens when the team is deleted\r\n* [x] ~Delete tokens when the issuer is deleted?~\r\n* [x] PRs to hegemony and cailleach about adding Spar to galley.yaml","created_at":"2018-11-22T13:38:54Z","updated_at":"2018-12-12T19:35:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c25564d4eda5a42d92e388fec1a5da5f7006c313","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wireapp/wire-server/pulls/519/commits","review_comments_url":"https://api.github.com/repos/wireapp/wire-server/pulls/519/comments","review_comment_url":"https://api.github.com/repos/wireapp/wire-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wireapp/wire-server/issues/519/comments","statuses_url":"https://api.github.com/repos/wireapp/wire-server/statuses/320fa1501c57134e4f4ef153ab0b03b0ff267ee9","head":{"label":"wireapp:spar-delete-team","ref":"spar-delete-team","sha":"320fa1501c57134e4f4ef153ab0b03b0ff267ee9","user":{"login":"wireapp","id":16047324,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDQ3MzI0","avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"repo":{"id":81935044,"node_id":"MDEwOlJlcG9zaXRvcnk4MTkzNTA0NA==","name":"wire-server","full_name":"wireapp/wire-server","private":false,"owner":{"login":"wireapp","id":16047324,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDQ3MzI0","avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wireapp/wire-server","description":"🇪🇺 Wire back-end services","fork":false,"url":"https://api.github.com/repos/wireapp/wire-server","forks_url":"https://api.github.com/repos/wireapp/wire-server/forks","keys_url":"https://api.github.com/repos/wireapp/wire-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wireapp/wire-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wireapp/wire-server/teams","hooks_url":"https://api.github.com/repos/wireapp/wire-server/hooks","issue_events_url":"https://api.github.com/repos/wireapp/wire-server/issues/events{/number}","events_url":"https://api.github.com/repos/wireapp/wire-server/events","assignees_url":"https://api.github.com/repos/wireapp/wire-server/assignees{/user}","branches_url":"https://api.github.com/repos/wireapp/wire-server/branches{/branch}","tags_url":"https://api.github.com/repos/wireapp/wire-server/tags","blobs_url":"https://api.github.com/repos/wireapp/wire-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wireapp/wire-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wireapp/wire-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/wireapp/wire-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wireapp/wire-server/statuses/{sha}","languages_url":"https://api.github.com/repos/wireapp/wire-server/languages","stargazers_url":"https://api.github.com/repos/wireapp/wire-server/stargazers","contributors_url":"https://api.github.com/repos/wireapp/wire-server/contributors","subscribers_url":"https://api.github.com/repos/wireapp/wire-server/subscribers","subscription_url":"https://api.github.com/repos/wireapp/wire-server/subscription","commits_url":"https://api.github.com/repos/wireapp/wire-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/wireapp/wire-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/wireapp/wire-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/wireapp/wire-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/wireapp/wire-server/contents/{+path}","compare_url":"https://api.github.com/repos/wireapp/wire-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wireapp/wire-server/merges","archive_url":"https://api.github.com/repos/wireapp/wire-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wireapp/wire-server/downloads","issues_url":"https://api.github.com/repos/wireapp/wire-server/issues{/number}","pulls_url":"https://api.github.com/repos/wireapp/wire-server/pulls{/number}","milestones_url":"https://api.github.com/repos/wireapp/wire-server/milestones{/number}","notifications_url":"https://api.github.com/repos/wireapp/wire-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wireapp/wire-server/labels{/name}","releases_url":"https://api.github.com/repos/wireapp/wire-server/releases{/id}","deployments_url":"https://api.github.com/repos/wireapp/wire-server/deployments","created_at":"2017-02-14T10:42:59Z","updated_at":"2018-12-12T19:24:50Z","pushed_at":"2018-12-12T19:24:51Z","git_url":"git://github.com/wireapp/wire-server.git","ssh_url":"git@github.com:wireapp/wire-server.git","clone_url":"https://github.com/wireapp/wire-server.git","svn_url":"https://github.com/wireapp/wire-server","homepage":"https://wire.com","size":4189,"stargazers_count":1802,"watchers_count":1802,"language":"Haskell","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":214,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":214,"open_issues":17,"watchers":1802,"default_branch":"develop"}},"base":{"label":"wireapp:develop","ref":"develop","sha":"24af20dbf75eee419ee1db25ce620907a841903e","user":{"login":"wireapp","id":16047324,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDQ3MzI0","avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"repo":{"id":81935044,"node_id":"MDEwOlJlcG9zaXRvcnk4MTkzNTA0NA==","name":"wire-server","full_name":"wireapp/wire-server","private":false,"owner":{"login":"wireapp","id":16047324,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MDQ3MzI0","avatar_url":"https://avatars3.githubusercontent.com/u/16047324?v=4","gravatar_id":"","url":"https://api.github.com/users/wireapp","html_url":"https://github.com/wireapp","followers_url":"https://api.github.com/users/wireapp/followers","following_url":"https://api.github.com/users/wireapp/following{/other_user}","gists_url":"https://api.github.com/users/wireapp/gists{/gist_id}","starred_url":"https://api.github.com/users/wireapp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wireapp/subscriptions","organizations_url":"https://api.github.com/users/wireapp/orgs","repos_url":"https://api.github.com/users/wireapp/repos","events_url":"https://api.github.com/users/wireapp/events{/privacy}","received_events_url":"https://api.github.com/users/wireapp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wireapp/wire-server","description":"🇪🇺 Wire back-end services","fork":false,"url":"https://api.github.com/repos/wireapp/wire-server","forks_url":"https://api.github.com/repos/wireapp/wire-server/forks","keys_url":"https://api.github.com/repos/wireapp/wire-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wireapp/wire-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wireapp/wire-server/teams","hooks_url":"https://api.github.com/repos/wireapp/wire-server/hooks","issue_events_url":"https://api.github.com/repos/wireapp/wire-server/issues/events{/number}","events_url":"https://api.github.com/repos/wireapp/wire-server/events","assignees_url":"https://api.github.com/repos/wireapp/wire-server/assignees{/user}","branches_url":"https://api.github.com/repos/wireapp/wire-server/branches{/branch}","tags_url":"https://api.github.com/repos/wireapp/wire-server/tags","blobs_url":"https://api.github.com/repos/wireapp/wire-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wireapp/wire-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wireapp/wire-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/wireapp/wire-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wireapp/wire-server/statuses/{sha}","languages_url":"https://api.github.com/repos/wireapp/wire-server/languages","stargazers_url":"https://api.github.com/repos/wireapp/wire-server/stargazers","contributors_url":"https://api.github.com/repos/wireapp/wire-server/contributors","subscribers_url":"https://api.github.com/repos/wireapp/wire-server/subscribers","subscription_url":"https://api.github.com/repos/wireapp/wire-server/subscription","commits_url":"https://api.github.com/repos/wireapp/wire-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/wireapp/wire-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/wireapp/wire-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/wireapp/wire-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/wireapp/wire-server/contents/{+path}","compare_url":"https://api.github.com/repos/wireapp/wire-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wireapp/wire-server/merges","archive_url":"https://api.github.com/repos/wireapp/wire-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wireapp/wire-server/downloads","issues_url":"https://api.github.com/repos/wireapp/wire-server/issues{/number}","pulls_url":"https://api.github.com/repos/wireapp/wire-server/pulls{/number}","milestones_url":"https://api.github.com/repos/wireapp/wire-server/milestones{/number}","notifications_url":"https://api.github.com/repos/wireapp/wire-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wireapp/wire-server/labels{/name}","releases_url":"https://api.github.com/repos/wireapp/wire-server/releases{/id}","deployments_url":"https://api.github.com/repos/wireapp/wire-server/deployments","created_at":"2017-02-14T10:42:59Z","updated_at":"2018-12-12T19:24:50Z","pushed_at":"2018-12-12T19:24:51Z","git_url":"git://github.com/wireapp/wire-server.git","ssh_url":"git@github.com:wireapp/wire-server.git","clone_url":"https://github.com/wireapp/wire-server.git","svn_url":"https://github.com/wireapp/wire-server","homepage":"https://wire.com","size":4189,"stargazers_count":1802,"watchers_count":1802,"language":"Haskell","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":214,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":214,"open_issues":17,"watchers":1802,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/wireapp/wire-server/pulls/519"},"html":{"href":"https://github.com/wireapp/wire-server/pull/519"},"issue":{"href":"https://api.github.com/repos/wireapp/wire-server/issues/519"},"comments":{"href":"https://api.github.com/repos/wireapp/wire-server/issues/519/comments"},"review_comments":{"href":"https://api.github.com/repos/wireapp/wire-server/pulls/519/comments"},"review_comment":{"href":"https://api.github.com/repos/wireapp/wire-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wireapp/wire-server/pulls/519/commits"},"statuses":{"href":"https://api.github.com/repos/wireapp/wire-server/statuses/320fa1501c57134e4f4ef153ab0b03b0ff267ee9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"fisx"}}