{"action":"closed","number":1709,"pull_request":{"url":"https://api.github.com/repos/stellar/stellar-core/pulls/1709","id":193129782,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzMTI5Nzgy","html_url":"https://github.com/stellar/stellar-core/pull/1709","diff_url":"https://github.com/stellar/stellar-core/pull/1709.diff","patch_url":"https://github.com/stellar/stellar-core/pull/1709.patch","issue_url":"https://api.github.com/repos/stellar/stellar-core/issues/1709","number":1709,"state":"closed","locked":false,"title":"Signature verification 10","user":{"login":"vogel","id":101391,"node_id":"MDQ6VXNlcjEwMTM5MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/101391?v=4","gravatar_id":"","url":"https://api.github.com/users/vogel","html_url":"https://github.com/vogel","followers_url":"https://api.github.com/users/vogel/followers","following_url":"https://api.github.com/users/vogel/following{/other_user}","gists_url":"https://api.github.com/users/vogel/gists{/gist_id}","starred_url":"https://api.github.com/users/vogel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vogel/subscriptions","organizations_url":"https://api.github.com/users/vogel/orgs","repos_url":"https://api.github.com/users/vogel/repos","events_url":"https://api.github.com/users/vogel/events{/privacy}","received_events_url":"https://api.github.com/users/vogel/received_events","type":"User","site_admin":false},"body":"# Description\r\n\r\nResolves #1464\r\n\r\nThose commits changes way how signatures are checked during applying phase of transactions. In general, signatures for all operations are now checked in batch just before apply phase (after sequence number processing).\r\n\r\n# Checklist\r\n- [x] Reviewed the [contributing](../CONTRIBUTING.md) document\r\n- [x] Rebased on top of master (no merge commits)\r\n- [x] Ran `clang-format`\r\n- [x] Compiles\r\n- [x] Ran all tests\r\n- [x] If change impacts performance, include supporting evidence per the [performance document](../performance-eval.md)\r\n","created_at":"2018-06-06T20:23:26Z","updated_at":"2018-06-26T21:55:14Z","closed_at":"2018-06-26T21:55:14Z","merged_at":"2018-06-26T21:55:14Z","merge_commit_sha":"2a88584716bec4f7d648ea1eaf042be72fd6a06f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/stellar/stellar-core/pulls/1709/commits","review_comments_url":"https://api.github.com/repos/stellar/stellar-core/pulls/1709/comments","review_comment_url":"https://api.github.com/repos/stellar/stellar-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stellar/stellar-core/issues/1709/comments","statuses_url":"https://api.github.com/repos/stellar/stellar-core/statuses/2a88584716bec4f7d648ea1eaf042be72fd6a06f","head":{"label":"vogel:signature-verification-10","ref":"signature-verification-10","sha":"2a88584716bec4f7d648ea1eaf042be72fd6a06f","user":{"login":"vogel","id":101391,"node_id":"MDQ6VXNlcjEwMTM5MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/101391?v=4","gravatar_id":"","url":"https://api.github.com/users/vogel","html_url":"https://github.com/vogel","followers_url":"https://api.github.com/users/vogel/followers","following_url":"https://api.github.com/users/vogel/following{/other_user}","gists_url":"https://api.github.com/users/vogel/gists{/gist_id}","starred_url":"https://api.github.com/users/vogel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vogel/subscriptions","organizations_url":"https://api.github.com/users/vogel/orgs","repos_url":"https://api.github.com/users/vogel/repos","events_url":"https://api.github.com/users/vogel/events{/privacy}","received_events_url":"https://api.github.com/users/vogel/received_events","type":"User","site_admin":false},"repo":{"id":59241865,"node_id":"MDEwOlJlcG9zaXRvcnk1OTI0MTg2NQ==","name":"stellar-core","full_name":"vogel/stellar-core","owner":{"login":"vogel","id":101391,"node_id":"MDQ6VXNlcjEwMTM5MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/101391?v=4","gravatar_id":"","url":"https://api.github.com/users/vogel","html_url":"https://github.com/vogel","followers_url":"https://api.github.com/users/vogel/followers","following_url":"https://api.github.com/users/vogel/following{/other_user}","gists_url":"https://api.github.com/users/vogel/gists{/gist_id}","starred_url":"https://api.github.com/users/vogel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vogel/subscriptions","organizations_url":"https://api.github.com/users/vogel/orgs","repos_url":"https://api.github.com/users/vogel/repos","events_url":"https://api.github.com/users/vogel/events{/privacy}","received_events_url":"https://api.github.com/users/vogel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vogel/stellar-core","description":"stellar-core is the backbone of the Stellar network. It maintains a local copy of the ledger, communicating and staying in sync with other instances of stellar-core on the network. Optionally, stellar-core can store historical records of the ledger and participate in consensus.","fork":true,"url":"https://api.github.com/repos/vogel/stellar-core","forks_url":"https://api.github.com/repos/vogel/stellar-core/forks","keys_url":"https://api.github.com/repos/vogel/stellar-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vogel/stellar-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vogel/stellar-core/teams","hooks_url":"https://api.github.com/repos/vogel/stellar-core/hooks","issue_events_url":"https://api.github.com/repos/vogel/stellar-core/issues/events{/number}","events_url":"https://api.github.com/repos/vogel/stellar-core/events","assignees_url":"https://api.github.com/repos/vogel/stellar-core/assignees{/user}","branches_url":"https://api.github.com/repos/vogel/stellar-core/branches{/branch}","tags_url":"https://api.github.com/repos/vogel/stellar-core/tags","blobs_url":"https://api.github.com/repos/vogel/stellar-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vogel/stellar-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vogel/stellar-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/vogel/stellar-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vogel/stellar-core/statuses/{sha}","languages_url":"https://api.github.com/repos/vogel/stellar-core/languages","stargazers_url":"https://api.github.com/repos/vogel/stellar-core/stargazers","contributors_url":"https://api.github.com/repos/vogel/stellar-core/contributors","subscribers_url":"https://api.github.com/repos/vogel/stellar-core/subscribers","subscription_url":"https://api.github.com/repos/vogel/stellar-core/subscription","commits_url":"https://api.github.com/repos/vogel/stellar-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/vogel/stellar-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/vogel/stellar-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/vogel/stellar-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/vogel/stellar-core/contents/{+path}","compare_url":"https://api.github.com/repos/vogel/stellar-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vogel/stellar-core/merges","archive_url":"https://api.github.com/repos/vogel/stellar-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vogel/stellar-core/downloads","issues_url":"https://api.github.com/repos/vogel/stellar-core/issues{/number}","pulls_url":"https://api.github.com/repos/vogel/stellar-core/pulls{/number}","milestones_url":"https://api.github.com/repos/vogel/stellar-core/milestones{/number}","notifications_url":"https://api.github.com/repos/vogel/stellar-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vogel/stellar-core/labels{/name}","releases_url":"https://api.github.com/repos/vogel/stellar-core/releases{/id}","deployments_url":"https://api.github.com/repos/vogel/stellar-core/deployments","created_at":"2016-05-19T20:51:49Z","updated_at":"2018-05-21T09:35:29Z","pushed_at":"2018-06-26T15:21:09Z","git_url":"git://github.com/vogel/stellar-core.git","ssh_url":"git@github.com:vogel/stellar-core.git","clone_url":"https://github.com/vogel/stellar-core.git","svn_url":"https://github.com/vogel/stellar-core","homepage":"","size":15414,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"stellar:master","ref":"master","sha":"dd7f38dba232e20ae75a95641857c0b7ed0252e1","user":{"login":"stellar","id":7386716,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczODY3MTY=","avatar_url":"https://avatars3.githubusercontent.com/u/7386716?v=4","gravatar_id":"","url":"https://api.github.com/users/stellar","html_url":"https://github.com/stellar","followers_url":"https://api.github.com/users/stellar/followers","following_url":"https://api.github.com/users/stellar/following{/other_user}","gists_url":"https://api.github.com/users/stellar/gists{/gist_id}","starred_url":"https://api.github.com/users/stellar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stellar/subscriptions","organizations_url":"https://api.github.com/users/stellar/orgs","repos_url":"https://api.github.com/users/stellar/repos","events_url":"https://api.github.com/users/stellar/events{/privacy}","received_events_url":"https://api.github.com/users/stellar/received_events","type":"Organization","site_admin":false},"repo":{"id":27085821,"node_id":"MDEwOlJlcG9zaXRvcnkyNzA4NTgyMQ==","name":"stellar-core","full_name":"stellar/stellar-core","owner":{"login":"stellar","id":7386716,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczODY3MTY=","avatar_url":"https://avatars3.githubusercontent.com/u/7386716?v=4","gravatar_id":"","url":"https://api.github.com/users/stellar","html_url":"https://github.com/stellar","followers_url":"https://api.github.com/users/stellar/followers","following_url":"https://api.github.com/users/stellar/following{/other_user}","gists_url":"https://api.github.com/users/stellar/gists{/gist_id}","starred_url":"https://api.github.com/users/stellar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stellar/subscriptions","organizations_url":"https://api.github.com/users/stellar/orgs","repos_url":"https://api.github.com/users/stellar/repos","events_url":"https://api.github.com/users/stellar/events{/privacy}","received_events_url":"https://api.github.com/users/stellar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stellar/stellar-core","description":"stellar-core is the backbone of the Stellar network. It maintains a local copy of the ledger, communicating and staying in sync with other instances of stellar-core on the network. Optionally, stellar-core can store historical records of the ledger and participate in consensus.","fork":false,"url":"https://api.github.com/repos/stellar/stellar-core","forks_url":"https://api.github.com/repos/stellar/stellar-core/forks","keys_url":"https://api.github.com/repos/stellar/stellar-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stellar/stellar-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stellar/stellar-core/teams","hooks_url":"https://api.github.com/repos/stellar/stellar-core/hooks","issue_events_url":"https://api.github.com/repos/stellar/stellar-core/issues/events{/number}","events_url":"https://api.github.com/repos/stellar/stellar-core/events","assignees_url":"https://api.github.com/repos/stellar/stellar-core/assignees{/user}","branches_url":"https://api.github.com/repos/stellar/stellar-core/branches{/branch}","tags_url":"https://api.github.com/repos/stellar/stellar-core/tags","blobs_url":"https://api.github.com/repos/stellar/stellar-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stellar/stellar-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stellar/stellar-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/stellar/stellar-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stellar/stellar-core/statuses/{sha}","languages_url":"https://api.github.com/repos/stellar/stellar-core/languages","stargazers_url":"https://api.github.com/repos/stellar/stellar-core/stargazers","contributors_url":"https://api.github.com/repos/stellar/stellar-core/contributors","subscribers_url":"https://api.github.com/repos/stellar/stellar-core/subscribers","subscription_url":"https://api.github.com/repos/stellar/stellar-core/subscription","commits_url":"https://api.github.com/repos/stellar/stellar-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/stellar/stellar-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/stellar/stellar-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/stellar/stellar-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/stellar/stellar-core/contents/{+path}","compare_url":"https://api.github.com/repos/stellar/stellar-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stellar/stellar-core/merges","archive_url":"https://api.github.com/repos/stellar/stellar-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stellar/stellar-core/downloads","issues_url":"https://api.github.com/repos/stellar/stellar-core/issues{/number}","pulls_url":"https://api.github.com/repos/stellar/stellar-core/pulls{/number}","milestones_url":"https://api.github.com/repos/stellar/stellar-core/milestones{/number}","notifications_url":"https://api.github.com/repos/stellar/stellar-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stellar/stellar-core/labels{/name}","releases_url":"https://api.github.com/repos/stellar/stellar-core/releases{/id}","deployments_url":"https://api.github.com/repos/stellar/stellar-core/deployments","created_at":"2014-11-24T17:11:12Z","updated_at":"2018-06-26T17:40:20Z","pushed_at":"2018-06-26T21:55:12Z","git_url":"git://github.com/stellar/stellar-core.git","ssh_url":"git@github.com:stellar/stellar-core.git","clone_url":"https://github.com/stellar/stellar-core.git","svn_url":"https://github.com/stellar/stellar-core","homepage":"","size":15014,"stargazers_count":1620,"watchers_count":1620,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":439,"mirror_url":null,"archived":false,"open_issues_count":129,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":439,"open_issues":129,"watchers":1620,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stellar/stellar-core/pulls/1709"},"html":{"href":"https://github.com/stellar/stellar-core/pull/1709"},"issue":{"href":"https://api.github.com/repos/stellar/stellar-core/issues/1709"},"comments":{"href":"https://api.github.com/repos/stellar/stellar-core/issues/1709/comments"},"review_comments":{"href":"https://api.github.com/repos/stellar/stellar-core/pulls/1709/comments"},"review_comment":{"href":"https://api.github.com/repos/stellar/stellar-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stellar/stellar-core/pulls/1709/commits"},"statuses":{"href":"https://api.github.com/repos/stellar/stellar-core/statuses/2a88584716bec4f7d648ea1eaf042be72fd6a06f"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"latobarita","id":8701921,"node_id":"MDQ6VXNlcjg3MDE5MjE=","avatar_url":"https://avatars1.githubusercontent.com/u/8701921?v=4","gravatar_id":"","url":"https://api.github.com/users/latobarita","html_url":"https://github.com/latobarita","followers_url":"https://api.github.com/users/latobarita/followers","following_url":"https://api.github.com/users/latobarita/following{/other_user}","gists_url":"https://api.github.com/users/latobarita/gists{/gist_id}","starred_url":"https://api.github.com/users/latobarita/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/latobarita/subscriptions","organizations_url":"https://api.github.com/users/latobarita/orgs","repos_url":"https://api.github.com/users/latobarita/repos","events_url":"https://api.github.com/users/latobarita/events{/privacy}","received_events_url":"https://api.github.com/users/latobarita/received_events","type":"User","site_admin":false},"comments":4,"review_comments":25,"maintainer_can_modify":false,"commits":8,"additions":981,"deletions":509,"changed_files":17}}
{"actor":{"display_login":"latobarita"}}