{"action":"created","comment":{"url":"https://api.github.com/repos/spotify/flo/pulls/comments/213188106","pull_request_review_id":149970408,"id":213188106,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzE4ODEwNg==","diff_hunk":"@@ -39,40 +43,30 @@\n     /**\n      * Called to report some piece of task metadata.\n      *\n+     * By default this methods calls {@link #meta(TaskId, Map)} with a single entry.\n+     *\n      * @param task The task that is being evaluated\n      * @param key The metadata key.\n      * @param value The metadata value.\n      */\n-    void meta(TaskId task, String key, String value);\n+    default void meta(TaskId task, String key, String value) {\n+      meta(task, Collections.singletonMap(key, value));\n+    }\n \n     /**\n      * Called to report some piece of task metadata.\n      *\n-     * By default this methods calls <code>meta(TaskId task, String key, String value)</code>\n-     * for each key-value pair.\n-     *\n      * @param task The task that is being evaluated\n      * @param data The key-value metadata\n      */\n-    default void meta(TaskId task, Map<String, String> data) {\n-      data.forEach((key, value) -> meta(task, key, value));\n-    }\n+    void meta(TaskId task, Map<String, String> data);\n \n-    Listener NOP = (Listener) (task, key, value) -> { };\n+    Listener NOP = (task, data) -> { };\n \n     default Listener composeWith(Listener listener) {\n-      return new Listener() {\n-        @Override\n-        public void meta(TaskId task, String key, String value) {\n-          Listener.this.meta(task, key, value);\n-          listener.meta(task, key, value);\n-        }\n-\n-        @Override\n-        public void meta(TaskId task, Map<String, String> data) {\n-          Listener.this.meta(task, data);\n-          listener.meta(task, data);\n-        }\n+      return (task, data) -> {\n+        guardedCall(() -> Listener.this.meta(task, data));","path":"flo-workflow/src/main/java/com/spotify/flo/TaskOperator.java","position":56,"original_position":59,"commit_id":"cf6e5ea2b57d253ee4c2a33cfbe3f8903bfaf435","original_commit_id":"dd6e413f9a8f349fcfe75d2db9d369dad2a6c805","user":{"login":"danielnorberg","id":393289,"node_id":"MDQ6VXNlcjM5MzI4OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/393289?v=4","gravatar_id":"","url":"https://api.github.com/users/danielnorberg","html_url":"https://github.com/danielnorberg","followers_url":"https://api.github.com/users/danielnorberg/followers","following_url":"https://api.github.com/users/danielnorberg/following{/other_user}","gists_url":"https://api.github.com/users/danielnorberg/gists{/gist_id}","starred_url":"https://api.github.com/users/danielnorberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danielnorberg/subscriptions","organizations_url":"https://api.github.com/users/danielnorberg/orgs","repos_url":"https://api.github.com/users/danielnorberg/repos","events_url":"https://api.github.com/users/danielnorberg/events{/privacy}","received_events_url":"https://api.github.com/users/danielnorberg/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2018-08-28T05:31:43Z","updated_at":"2018-08-28T05:31:43Z","html_url":"https://github.com/spotify/flo/pull/154#discussion_r213188106","pull_request_url":"https://api.github.com/repos/spotify/flo/pulls/154","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/spotify/flo/pulls/comments/213188106"},"html":{"href":"https://github.com/spotify/flo/pull/154#discussion_r213188106"},"pull_request":{"href":"https://api.github.com/repos/spotify/flo/pulls/154"}},"in_reply_to_id":213185368},"pull_request":{"url":"https://api.github.com/repos/spotify/flo/pulls/154","id":211100332,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMTAwMzMy","html_url":"https://github.com/spotify/flo/pull/154","diff_url":"https://github.com/spotify/flo/pull/154.diff","patch_url":"https://github.com/spotify/flo/pull/154.patch","issue_url":"https://api.github.com/repos/spotify/flo/issues/154","number":154,"state":"open","locked":false,"title":"Call correct listener() and add test","user":{"login":"NatashaL","id":4315174,"node_id":"MDQ6VXNlcjQzMTUxNzQ=","avatar_url":"https://avatars1.githubusercontent.com/u/4315174?v=4","gravatar_id":"","url":"https://api.github.com/users/NatashaL","html_url":"https://github.com/NatashaL","followers_url":"https://api.github.com/users/NatashaL/followers","following_url":"https://api.github.com/users/NatashaL/following{/other_user}","gists_url":"https://api.github.com/users/NatashaL/gists{/gist_id}","starred_url":"https://api.github.com/users/NatashaL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NatashaL/subscriptions","organizations_url":"https://api.github.com/users/NatashaL/orgs","repos_url":"https://api.github.com/users/NatashaL/repos","events_url":"https://api.github.com/users/NatashaL/events{/privacy}","received_events_url":"https://api.github.com/users/NatashaL/received_events","type":"User","site_admin":false},"body":"As discussed here https://github.com/spotify/flo/pull/149/files#r212948632","created_at":"2018-08-27T12:53:03Z","updated_at":"2018-08-28T05:31:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dfa2a75d917ebc83b1b568d092d20cac09dba0a3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/spotify/flo/pulls/154/commits","review_comments_url":"https://api.github.com/repos/spotify/flo/pulls/154/comments","review_comment_url":"https://api.github.com/repos/spotify/flo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spotify/flo/issues/154/comments","statuses_url":"https://api.github.com/repos/spotify/flo/statuses/cf6e5ea2b57d253ee4c2a33cfbe3f8903bfaf435","head":{"label":"spotify:eval-fix","ref":"eval-fix","sha":"cf6e5ea2b57d253ee4c2a33cfbe3f8903bfaf435","user":{"login":"spotify","id":251374,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTM3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/251374?v=4","gravatar_id":"","url":"https://api.github.com/users/spotify","html_url":"https://github.com/spotify","followers_url":"https://api.github.com/users/spotify/followers","following_url":"https://api.github.com/users/spotify/following{/other_user}","gists_url":"https://api.github.com/users/spotify/gists{/gist_id}","starred_url":"https://api.github.com/users/spotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotify/subscriptions","organizations_url":"https://api.github.com/users/spotify/orgs","repos_url":"https://api.github.com/users/spotify/repos","events_url":"https://api.github.com/users/spotify/events{/privacy}","received_events_url":"https://api.github.com/users/spotify/received_events","type":"Organization","site_admin":false},"repo":{"id":46450575,"node_id":"MDEwOlJlcG9zaXRvcnk0NjQ1MDU3NQ==","name":"flo","full_name":"spotify/flo","owner":{"login":"spotify","id":251374,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTM3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/251374?v=4","gravatar_id":"","url":"https://api.github.com/users/spotify","html_url":"https://github.com/spotify","followers_url":"https://api.github.com/users/spotify/followers","following_url":"https://api.github.com/users/spotify/following{/other_user}","gists_url":"https://api.github.com/users/spotify/gists{/gist_id}","starred_url":"https://api.github.com/users/spotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotify/subscriptions","organizations_url":"https://api.github.com/users/spotify/orgs","repos_url":"https://api.github.com/users/spotify/repos","events_url":"https://api.github.com/users/spotify/events{/privacy}","received_events_url":"https://api.github.com/users/spotify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spotify/flo","description":"A lightweight workflow definition library","fork":false,"url":"https://api.github.com/repos/spotify/flo","forks_url":"https://api.github.com/repos/spotify/flo/forks","keys_url":"https://api.github.com/repos/spotify/flo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spotify/flo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spotify/flo/teams","hooks_url":"https://api.github.com/repos/spotify/flo/hooks","issue_events_url":"https://api.github.com/repos/spotify/flo/issues/events{/number}","events_url":"https://api.github.com/repos/spotify/flo/events","assignees_url":"https://api.github.com/repos/spotify/flo/assignees{/user}","branches_url":"https://api.github.com/repos/spotify/flo/branches{/branch}","tags_url":"https://api.github.com/repos/spotify/flo/tags","blobs_url":"https://api.github.com/repos/spotify/flo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spotify/flo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spotify/flo/git/refs{/sha}","trees_url":"https://api.github.com/repos/spotify/flo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spotify/flo/statuses/{sha}","languages_url":"https://api.github.com/repos/spotify/flo/languages","stargazers_url":"https://api.github.com/repos/spotify/flo/stargazers","contributors_url":"https://api.github.com/repos/spotify/flo/contributors","subscribers_url":"https://api.github.com/repos/spotify/flo/subscribers","subscription_url":"https://api.github.com/repos/spotify/flo/subscription","commits_url":"https://api.github.com/repos/spotify/flo/commits{/sha}","git_commits_url":"https://api.github.com/repos/spotify/flo/git/commits{/sha}","comments_url":"https://api.github.com/repos/spotify/flo/comments{/number}","issue_comment_url":"https://api.github.com/repos/spotify/flo/issues/comments{/number}","contents_url":"https://api.github.com/repos/spotify/flo/contents/{+path}","compare_url":"https://api.github.com/repos/spotify/flo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spotify/flo/merges","archive_url":"https://api.github.com/repos/spotify/flo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spotify/flo/downloads","issues_url":"https://api.github.com/repos/spotify/flo/issues{/number}","pulls_url":"https://api.github.com/repos/spotify/flo/pulls{/number}","milestones_url":"https://api.github.com/repos/spotify/flo/milestones{/number}","notifications_url":"https://api.github.com/repos/spotify/flo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spotify/flo/labels{/name}","releases_url":"https://api.github.com/repos/spotify/flo/releases{/id}","deployments_url":"https://api.github.com/repos/spotify/flo/deployments","created_at":"2015-11-18T22:06:27Z","updated_at":"2018-08-23T10:15:31Z","pushed_at":"2018-08-28T05:30:12Z","git_url":"git://github.com/spotify/flo.git","ssh_url":"git@github.com:spotify/flo.git","clone_url":"https://github.com/spotify/flo.git","svn_url":"https://github.com/spotify/flo","homepage":"http://spotify.github.io/flo/maven/latest/","size":11402,"stargazers_count":47,"watchers_count":47,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":14,"open_issues":12,"watchers":47,"default_branch":"master"}},"base":{"label":"spotify:master","ref":"master","sha":"4af2567856d2abc5b58db1eda0c9a6d6505f81d0","user":{"login":"spotify","id":251374,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTM3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/251374?v=4","gravatar_id":"","url":"https://api.github.com/users/spotify","html_url":"https://github.com/spotify","followers_url":"https://api.github.com/users/spotify/followers","following_url":"https://api.github.com/users/spotify/following{/other_user}","gists_url":"https://api.github.com/users/spotify/gists{/gist_id}","starred_url":"https://api.github.com/users/spotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotify/subscriptions","organizations_url":"https://api.github.com/users/spotify/orgs","repos_url":"https://api.github.com/users/spotify/repos","events_url":"https://api.github.com/users/spotify/events{/privacy}","received_events_url":"https://api.github.com/users/spotify/received_events","type":"Organization","site_admin":false},"repo":{"id":46450575,"node_id":"MDEwOlJlcG9zaXRvcnk0NjQ1MDU3NQ==","name":"flo","full_name":"spotify/flo","owner":{"login":"spotify","id":251374,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTM3NA==","avatar_url":"https://avatars2.githubusercontent.com/u/251374?v=4","gravatar_id":"","url":"https://api.github.com/users/spotify","html_url":"https://github.com/spotify","followers_url":"https://api.github.com/users/spotify/followers","following_url":"https://api.github.com/users/spotify/following{/other_user}","gists_url":"https://api.github.com/users/spotify/gists{/gist_id}","starred_url":"https://api.github.com/users/spotify/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotify/subscriptions","organizations_url":"https://api.github.com/users/spotify/orgs","repos_url":"https://api.github.com/users/spotify/repos","events_url":"https://api.github.com/users/spotify/events{/privacy}","received_events_url":"https://api.github.com/users/spotify/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spotify/flo","description":"A lightweight workflow definition library","fork":false,"url":"https://api.github.com/repos/spotify/flo","forks_url":"https://api.github.com/repos/spotify/flo/forks","keys_url":"https://api.github.com/repos/spotify/flo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spotify/flo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spotify/flo/teams","hooks_url":"https://api.github.com/repos/spotify/flo/hooks","issue_events_url":"https://api.github.com/repos/spotify/flo/issues/events{/number}","events_url":"https://api.github.com/repos/spotify/flo/events","assignees_url":"https://api.github.com/repos/spotify/flo/assignees{/user}","branches_url":"https://api.github.com/repos/spotify/flo/branches{/branch}","tags_url":"https://api.github.com/repos/spotify/flo/tags","blobs_url":"https://api.github.com/repos/spotify/flo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spotify/flo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spotify/flo/git/refs{/sha}","trees_url":"https://api.github.com/repos/spotify/flo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spotify/flo/statuses/{sha}","languages_url":"https://api.github.com/repos/spotify/flo/languages","stargazers_url":"https://api.github.com/repos/spotify/flo/stargazers","contributors_url":"https://api.github.com/repos/spotify/flo/contributors","subscribers_url":"https://api.github.com/repos/spotify/flo/subscribers","subscription_url":"https://api.github.com/repos/spotify/flo/subscription","commits_url":"https://api.github.com/repos/spotify/flo/commits{/sha}","git_commits_url":"https://api.github.com/repos/spotify/flo/git/commits{/sha}","comments_url":"https://api.github.com/repos/spotify/flo/comments{/number}","issue_comment_url":"https://api.github.com/repos/spotify/flo/issues/comments{/number}","contents_url":"https://api.github.com/repos/spotify/flo/contents/{+path}","compare_url":"https://api.github.com/repos/spotify/flo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spotify/flo/merges","archive_url":"https://api.github.com/repos/spotify/flo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spotify/flo/downloads","issues_url":"https://api.github.com/repos/spotify/flo/issues{/number}","pulls_url":"https://api.github.com/repos/spotify/flo/pulls{/number}","milestones_url":"https://api.github.com/repos/spotify/flo/milestones{/number}","notifications_url":"https://api.github.com/repos/spotify/flo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spotify/flo/labels{/name}","releases_url":"https://api.github.com/repos/spotify/flo/releases{/id}","deployments_url":"https://api.github.com/repos/spotify/flo/deployments","created_at":"2015-11-18T22:06:27Z","updated_at":"2018-08-23T10:15:31Z","pushed_at":"2018-08-28T05:30:12Z","git_url":"git://github.com/spotify/flo.git","ssh_url":"git@github.com:spotify/flo.git","clone_url":"https://github.com/spotify/flo.git","svn_url":"https://github.com/spotify/flo","homepage":"http://spotify.github.io/flo/maven/latest/","size":11402,"stargazers_count":47,"watchers_count":47,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":14,"open_issues":12,"watchers":47,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spotify/flo/pulls/154"},"html":{"href":"https://github.com/spotify/flo/pull/154"},"issue":{"href":"https://api.github.com/repos/spotify/flo/issues/154"},"comments":{"href":"https://api.github.com/repos/spotify/flo/issues/154/comments"},"review_comments":{"href":"https://api.github.com/repos/spotify/flo/pulls/154/comments"},"review_comment":{"href":"https://api.github.com/repos/spotify/flo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spotify/flo/pulls/154/commits"},"statuses":{"href":"https://api.github.com/repos/spotify/flo/statuses/cf6e5ea2b57d253ee4c2a33cfbe3f8903bfaf435"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"danielnorberg"}}