{"action":"created","comment":{"url":"https://api.github.com/repos/videolan/vlc-ios/pulls/comments/174926036","pull_request_review_id":104373084,"id":174926036,"diff_hunk":"@@ -26,28 +26,6 @@ + (UIBarButtonItem *)themedBackButtonWithTarget:(id)target andSelector:(SEL)sele\n     return backButton;\n }\n \n-+ (UIBarButtonItem *)themedRevealMenuButtonWithTarget:(id)target andSelector:(SEL)selector\n-{\n-    /* After day 354 of the year, the usual VLC cone is replaced by another cone\n-     * wearing a Father Xmas hat.\n-     * Note: this icon doesn't represent an endorsement of The Coca-Cola Company\n-     * and should not be confused with the idea of religious statements or propagation there off\n-     */","path":"Sources/UIBarButtonItem+Theme.m","position":10,"original_position":10,"commit_id":"19415528446cbf743f5732f5ab95b905d4ec3296","original_commit_id":"19415528446cbf743f5732f5ab95b905d4ec3296","user":{"login":"carolanitz","id":2445653,"avatar_url":"https://avatars1.githubusercontent.com/u/2445653?v=4","gravatar_id":"","url":"https://api.github.com/users/carolanitz","html_url":"https://github.com/carolanitz","followers_url":"https://api.github.com/users/carolanitz/followers","following_url":"https://api.github.com/users/carolanitz/following{/other_user}","gists_url":"https://api.github.com/users/carolanitz/gists{/gist_id}","starred_url":"https://api.github.com/users/carolanitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carolanitz/subscriptions","organizations_url":"https://api.github.com/users/carolanitz/orgs","repos_url":"https://api.github.com/users/carolanitz/repos","events_url":"https://api.github.com/users/carolanitz/events{/privacy}","received_events_url":"https://api.github.com/users/carolanitz/received_events","type":"User","site_admin":false},"body":"I hope so as well!","created_at":"2018-03-15T20:43:27Z","updated_at":"2018-03-15T20:43:27Z","html_url":"https://github.com/videolan/vlc-ios/pull/13#discussion_r174926036","pull_request_url":"https://api.github.com/repos/videolan/vlc-ios/pulls/13","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/videolan/vlc-ios/pulls/comments/174926036"},"html":{"href":"https://github.com/videolan/vlc-ios/pull/13#discussion_r174926036"},"pull_request":{"href":"https://api.github.com/repos/videolan/vlc-ios/pulls/13"}},"in_reply_to_id":173352127},"pull_request":{"url":"https://api.github.com/repos/videolan/vlc-ios/pulls/13","id":173738024,"html_url":"https://github.com/videolan/vlc-ios/pull/13","diff_url":"https://github.com/videolan/vlc-ios/pull/13.diff","patch_url":"https://github.com/videolan/vlc-ios/pull/13.patch","issue_url":"https://api.github.com/repos/videolan/vlc-ios/issues/13","number":13,"state":"open","locked":false,"title":"New shiny UI ","user":{"login":"carolanitz","id":2445653,"avatar_url":"https://avatars1.githubusercontent.com/u/2445653?v=4","gravatar_id":"","url":"https://api.github.com/users/carolanitz","html_url":"https://github.com/carolanitz","followers_url":"https://api.github.com/users/carolanitz/followers","following_url":"https://api.github.com/users/carolanitz/following{/other_user}","gists_url":"https://api.github.com/users/carolanitz/gists{/gist_id}","starred_url":"https://api.github.com/users/carolanitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carolanitz/subscriptions","organizations_url":"https://api.github.com/users/carolanitz/orgs","repos_url":"https://api.github.com/users/carolanitz/repos","events_url":"https://api.github.com/users/carolanitz/events{/privacy}","received_events_url":"https://api.github.com/users/carolanitz/received_events","type":"User","site_admin":false},"body":"First off I'm sorry for the giant PR! \r\n\r\nThis PR adds:\r\n\r\n- [x] a Tabbar as main navigation\r\n- [x] adds a Presentationtheme to switch colors between dark and white theme\r\n- [x] removed the old LibraryViewController, SidebarMenu, Menubarbutton\r\n- [x] moved the wifi-cell in the networking screen\r\n- [x] adjusted the view hierarchy to be able to display the mini player.\r\n\r\nThis is breaking a lot of things for now and is also full of workaround that need to be replaced - big changes like this always do and I'd like us all to work together on this! :) The new UI is based on the integration of the new MediaLibrary as well. I will create issues on Gitlab for the tasks that need to be done and share the current design work over there.\r\n\r\nTasks that need to be done once this is merged:\r\n-  the Mediadiscoverer currently doesn't work, adding new files are only visible after a restart\r\n-  the passcode screen is not hooked up\r\n-  opening VLC by URL and other URL related calls don't work right now\r\n-  movie and audio screen show the same content\r\n-  opened media isn't indexed by corespotlight\r\n-  sorting doesn't work yet\r\n-  replace folders by playlists which is why you can't open folders right now\r\n-  backgrounding calls that were in the libraryViewcontroller are not implemented currently\r\n\r\n![audiominiplayer](https://user-images.githubusercontent.com/2445653/37153729-8f9857be-2292-11e8-9fab-de8d04d18c72.png)\r\n![dark settings](https://user-images.githubusercontent.com/2445653/37153737-96de21f2-2292-11e8-87b7-7ae8c4a27bf3.png)\r\n![darktheme](https://user-images.githubusercontent.com/2445653/37153746-9b3163a4-2292-11e8-837a-7f4a2e0c4261.png)\r\n![whitetheme](https://user-images.githubusercontent.com/2445653/37153780-af755d70-2292-11e8-8a7e-8d97dc029a97.png)\r\n![search](https://user-images.githubusercontent.com/2445653/37153791-b77bb604-2292-11e8-9d01-4d1171fcddfc.png)\r\n\r\n\r\n","created_at":"2018-03-08T13:39:47Z","updated_at":"2018-03-15T20:43:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a99380ac649d192dbd9c7aad42619d5381055a8c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"GeoffreyMetais","id":5031161,"avatar_url":"https://avatars3.githubusercontent.com/u/5031161?v=4","gravatar_id":"","url":"https://api.github.com/users/GeoffreyMetais","html_url":"https://github.com/GeoffreyMetais","followers_url":"https://api.github.com/users/GeoffreyMetais/followers","following_url":"https://api.github.com/users/GeoffreyMetais/following{/other_user}","gists_url":"https://api.github.com/users/GeoffreyMetais/gists{/gist_id}","starred_url":"https://api.github.com/users/GeoffreyMetais/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeoffreyMetais/subscriptions","organizations_url":"https://api.github.com/users/GeoffreyMetais/orgs","repos_url":"https://api.github.com/users/GeoffreyMetais/repos","events_url":"https://api.github.com/users/GeoffreyMetais/events{/privacy}","received_events_url":"https://api.github.com/users/GeoffreyMetais/received_events","type":"User","site_admin":false},{"login":"Mikanbu","id":14984800,"avatar_url":"https://avatars2.githubusercontent.com/u/14984800?v=4","gravatar_id":"","url":"https://api.github.com/users/Mikanbu","html_url":"https://github.com/Mikanbu","followers_url":"https://api.github.com/users/Mikanbu/followers","following_url":"https://api.github.com/users/Mikanbu/following{/other_user}","gists_url":"https://api.github.com/users/Mikanbu/gists{/gist_id}","starred_url":"https://api.github.com/users/Mikanbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mikanbu/subscriptions","organizations_url":"https://api.github.com/users/Mikanbu/orgs","repos_url":"https://api.github.com/users/Mikanbu/repos","events_url":"https://api.github.com/users/Mikanbu/events{/privacy}","received_events_url":"https://api.github.com/users/Mikanbu/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/videolan/vlc-ios/pulls/13/commits","review_comments_url":"https://api.github.com/repos/videolan/vlc-ios/pulls/13/comments","review_comment_url":"https://api.github.com/repos/videolan/vlc-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/videolan/vlc-ios/issues/13/comments","statuses_url":"https://api.github.com/repos/videolan/vlc-ios/statuses/19415528446cbf743f5732f5ab95b905d4ec3296","head":{"label":"carolanitz:newshinyUI","ref":"newshinyUI","sha":"19415528446cbf743f5732f5ab95b905d4ec3296","user":{"login":"carolanitz","id":2445653,"avatar_url":"https://avatars1.githubusercontent.com/u/2445653?v=4","gravatar_id":"","url":"https://api.github.com/users/carolanitz","html_url":"https://github.com/carolanitz","followers_url":"https://api.github.com/users/carolanitz/followers","following_url":"https://api.github.com/users/carolanitz/following{/other_user}","gists_url":"https://api.github.com/users/carolanitz/gists{/gist_id}","starred_url":"https://api.github.com/users/carolanitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carolanitz/subscriptions","organizations_url":"https://api.github.com/users/carolanitz/orgs","repos_url":"https://api.github.com/users/carolanitz/repos","events_url":"https://api.github.com/users/carolanitz/events{/privacy}","received_events_url":"https://api.github.com/users/carolanitz/received_events","type":"User","site_admin":false},"repo":{"id":122180782,"name":"vlc-ios","full_name":"carolanitz/vlc-ios","owner":{"login":"carolanitz","id":2445653,"avatar_url":"https://avatars1.githubusercontent.com/u/2445653?v=4","gravatar_id":"","url":"https://api.github.com/users/carolanitz","html_url":"https://github.com/carolanitz","followers_url":"https://api.github.com/users/carolanitz/followers","following_url":"https://api.github.com/users/carolanitz/following{/other_user}","gists_url":"https://api.github.com/users/carolanitz/gists{/gist_id}","starred_url":"https://api.github.com/users/carolanitz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carolanitz/subscriptions","organizations_url":"https://api.github.com/users/carolanitz/orgs","repos_url":"https://api.github.com/users/carolanitz/repos","events_url":"https://api.github.com/users/carolanitz/events{/privacy}","received_events_url":"https://api.github.com/users/carolanitz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/carolanitz/vlc-ios","description":"VLC for iOS official mirror","fork":true,"url":"https://api.github.com/repos/carolanitz/vlc-ios","forks_url":"https://api.github.com/repos/carolanitz/vlc-ios/forks","keys_url":"https://api.github.com/repos/carolanitz/vlc-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/carolanitz/vlc-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/carolanitz/vlc-ios/teams","hooks_url":"https://api.github.com/repos/carolanitz/vlc-ios/hooks","issue_events_url":"https://api.github.com/repos/carolanitz/vlc-ios/issues/events{/number}","events_url":"https://api.github.com/repos/carolanitz/vlc-ios/events","assignees_url":"https://api.github.com/repos/carolanitz/vlc-ios/assignees{/user}","branches_url":"https://api.github.com/repos/carolanitz/vlc-ios/branches{/branch}","tags_url":"https://api.github.com/repos/carolanitz/vlc-ios/tags","blobs_url":"https://api.github.com/repos/carolanitz/vlc-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/carolanitz/vlc-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/carolanitz/vlc-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/carolanitz/vlc-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/carolanitz/vlc-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/carolanitz/vlc-ios/languages","stargazers_url":"https://api.github.com/repos/carolanitz/vlc-ios/stargazers","contributors_url":"https://api.github.com/repos/carolanitz/vlc-ios/contributors","subscribers_url":"https://api.github.com/repos/carolanitz/vlc-ios/subscribers","subscription_url":"https://api.github.com/repos/carolanitz/vlc-ios/subscription","commits_url":"https://api.github.com/repos/carolanitz/vlc-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/carolanitz/vlc-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/carolanitz/vlc-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/carolanitz/vlc-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/carolanitz/vlc-ios/contents/{+path}","compare_url":"https://api.github.com/repos/carolanitz/vlc-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/carolanitz/vlc-ios/merges","archive_url":"https://api.github.com/repos/carolanitz/vlc-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/carolanitz/vlc-ios/downloads","issues_url":"https://api.github.com/repos/carolanitz/vlc-ios/issues{/number}","pulls_url":"https://api.github.com/repos/carolanitz/vlc-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/carolanitz/vlc-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/carolanitz/vlc-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/carolanitz/vlc-ios/labels{/name}","releases_url":"https://api.github.com/repos/carolanitz/vlc-ios/releases{/id}","deployments_url":"https://api.github.com/repos/carolanitz/vlc-ios/deployments","created_at":"2018-02-20T09:56:28Z","updated_at":"2018-02-20T09:56:32Z","pushed_at":"2018-03-10T01:24:54Z","git_url":"git://github.com/carolanitz/vlc-ios.git","ssh_url":"git@github.com:carolanitz/vlc-ios.git","clone_url":"https://github.com/carolanitz/vlc-ios.git","svn_url":"https://github.com/carolanitz/vlc-ios","homepage":null,"size":43119,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"videolan:master","ref":"master","sha":"bc423a86db68cb255df0fcc95f358bd7558f035d","user":{"login":"videolan","id":1389585,"avatar_url":"https://avatars1.githubusercontent.com/u/1389585?v=4","gravatar_id":"","url":"https://api.github.com/users/videolan","html_url":"https://github.com/videolan","followers_url":"https://api.github.com/users/videolan/followers","following_url":"https://api.github.com/users/videolan/following{/other_user}","gists_url":"https://api.github.com/users/videolan/gists{/gist_id}","starred_url":"https://api.github.com/users/videolan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videolan/subscriptions","organizations_url":"https://api.github.com/users/videolan/orgs","repos_url":"https://api.github.com/users/videolan/repos","events_url":"https://api.github.com/users/videolan/events{/privacy}","received_events_url":"https://api.github.com/users/videolan/received_events","type":"Organization","site_admin":false},"repo":{"id":120193302,"name":"vlc-ios","full_name":"videolan/vlc-ios","owner":{"login":"videolan","id":1389585,"avatar_url":"https://avatars1.githubusercontent.com/u/1389585?v=4","gravatar_id":"","url":"https://api.github.com/users/videolan","html_url":"https://github.com/videolan","followers_url":"https://api.github.com/users/videolan/followers","following_url":"https://api.github.com/users/videolan/following{/other_user}","gists_url":"https://api.github.com/users/videolan/gists{/gist_id}","starred_url":"https://api.github.com/users/videolan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/videolan/subscriptions","organizations_url":"https://api.github.com/users/videolan/orgs","repos_url":"https://api.github.com/users/videolan/repos","events_url":"https://api.github.com/users/videolan/events{/privacy}","received_events_url":"https://api.github.com/users/videolan/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/videolan/vlc-ios","description":"VLC for iOS official mirror","fork":false,"url":"https://api.github.com/repos/videolan/vlc-ios","forks_url":"https://api.github.com/repos/videolan/vlc-ios/forks","keys_url":"https://api.github.com/repos/videolan/vlc-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/videolan/vlc-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/videolan/vlc-ios/teams","hooks_url":"https://api.github.com/repos/videolan/vlc-ios/hooks","issue_events_url":"https://api.github.com/repos/videolan/vlc-ios/issues/events{/number}","events_url":"https://api.github.com/repos/videolan/vlc-ios/events","assignees_url":"https://api.github.com/repos/videolan/vlc-ios/assignees{/user}","branches_url":"https://api.github.com/repos/videolan/vlc-ios/branches{/branch}","tags_url":"https://api.github.com/repos/videolan/vlc-ios/tags","blobs_url":"https://api.github.com/repos/videolan/vlc-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/videolan/vlc-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/videolan/vlc-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/videolan/vlc-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/videolan/vlc-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/videolan/vlc-ios/languages","stargazers_url":"https://api.github.com/repos/videolan/vlc-ios/stargazers","contributors_url":"https://api.github.com/repos/videolan/vlc-ios/contributors","subscribers_url":"https://api.github.com/repos/videolan/vlc-ios/subscribers","subscription_url":"https://api.github.com/repos/videolan/vlc-ios/subscription","commits_url":"https://api.github.com/repos/videolan/vlc-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/videolan/vlc-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/videolan/vlc-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/videolan/vlc-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/videolan/vlc-ios/contents/{+path}","compare_url":"https://api.github.com/repos/videolan/vlc-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/videolan/vlc-ios/merges","archive_url":"https://api.github.com/repos/videolan/vlc-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/videolan/vlc-ios/downloads","issues_url":"https://api.github.com/repos/videolan/vlc-ios/issues{/number}","pulls_url":"https://api.github.com/repos/videolan/vlc-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/videolan/vlc-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/videolan/vlc-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/videolan/vlc-ios/labels{/name}","releases_url":"https://api.github.com/repos/videolan/vlc-ios/releases{/id}","deployments_url":"https://api.github.com/repos/videolan/vlc-ios/deployments","created_at":"2018-02-04T14:44:05Z","updated_at":"2018-03-15T12:15:41Z","pushed_at":"2018-03-15T12:15:39Z","git_url":"git://github.com/videolan/vlc-ios.git","ssh_url":"git@github.com:videolan/vlc-ios.git","clone_url":"https://github.com/videolan/vlc-ios.git","svn_url":"https://github.com/videolan/vlc-ios","homepage":null,"size":43280,"stargazers_count":155,"watchers_count":155,"language":"Objective-C","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":12,"open_issues":3,"watchers":155,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/videolan/vlc-ios/pulls/13"},"html":{"href":"https://github.com/videolan/vlc-ios/pull/13"},"issue":{"href":"https://api.github.com/repos/videolan/vlc-ios/issues/13"},"comments":{"href":"https://api.github.com/repos/videolan/vlc-ios/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/videolan/vlc-ios/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/videolan/vlc-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/videolan/vlc-ios/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/videolan/vlc-ios/statuses/19415528446cbf743f5732f5ab95b905d4ec3296"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"carolanitz"}}