{"action":"created","comment":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-stdlib/pulls/comments/197207417","pull_request_review_id":130907186,"id":197207417,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NzIwNzQxNw==","diff_hunk":"@@ -4,8 +4,20 @@\n module Puppet::Parser::Functions\n   newfunction(:count, :type => :rvalue, :arity => -2, :doc => <<-DOC\n     Takes an array as first argument and an optional second argument.\n-    Count the number of elements in array that matches second argument.\n-    If called with only an array it counts the number of elements that are not nil/undef.\n+    Count the number of elements in array that is equal to the second argument.\n+    If called with only an array it counts the number of elements that are not nil/undef/empty-string.\n+\n+    Note: equality is tested with a Ruby method and it is therefore subject to what Ruby considers\n+    to be equal. For strings this means that equality is case sensitive.\n+\n+    In Puppet core, counting can be done in general by using a combination of the core functions","path":"lib/puppet/parser/functions/count.rb","position":12,"original_position":12,"commit_id":"eac001e39ed37d40c3d0b89575b30205be1bbac7","original_commit_id":"eac001e39ed37d40c3d0b89575b30205be1bbac7","user":{"login":"hlindberg","id":563066,"node_id":"MDQ6VXNlcjU2MzA2Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/563066?v=4","gravatar_id":"","url":"https://api.github.com/users/hlindberg","html_url":"https://github.com/hlindberg","followers_url":"https://api.github.com/users/hlindberg/followers","following_url":"https://api.github.com/users/hlindberg/following{/other_user}","gists_url":"https://api.github.com/users/hlindberg/gists{/gist_id}","starred_url":"https://api.github.com/users/hlindberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hlindberg/subscriptions","organizations_url":"https://api.github.com/users/hlindberg/orgs","repos_url":"https://api.github.com/users/hlindberg/repos","events_url":"https://api.github.com/users/hlindberg/events{/privacy}","received_events_url":"https://api.github.com/users/hlindberg/received_events","type":"User","site_admin":false},"body":"Hm, the line in question has `Puppet` with capital `P` already ???","created_at":"2018-06-21T17:00:11Z","updated_at":"2018-06-21T17:00:11Z","html_url":"https://github.com/puppetlabs/puppetlabs-stdlib/pull/922#discussion_r197207417","pull_request_url":"https://api.github.com/repos/puppetlabs/puppetlabs-stdlib/pulls/922","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-stdlib/pulls/comments/197207417"},"html":{"href":"https://github.com/puppetlabs/puppetlabs-stdlib/pull/922#discussion_r197207417"},"pull_request":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-stdlib/pulls/922"}},"in_reply_to_id":197207047},"pull_request":{"url":"https://api.github.com/repos/puppetlabs/puppetlabs-stdlib/pulls/922","id":195209751,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MjA5NzUx","html_url":"https://github.com/puppetlabs/puppetlabs-stdlib/pull/922","diff_url":"https://github.com/puppetlabs/puppetlabs-stdlib/pull/922.diff","patch_url":"https://github.com/puppetlabs/puppetlabs-stdlib/pull/922.patch","issue_url":"https://api.github.com/repos/puppetlabs/puppetlabs-stdlib/issues/922","number":922,"state":"open","locked":false,"title":"(docs) update documentation wrt functions moved to puppet","user":{"login":"hlindberg","id":563066,"node_id":"MDQ6VXNlcjU2MzA2Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/563066?v=4","gravatar_id":"","url":"https://api.github.com/users/hlindberg","html_url":"https://github.com/hlindberg","followers_url":"https://api.github.com/users/hlindberg/followers","following_url":"https://api.github.com/users/hlindberg/following{/other_user}","gists_url":"https://api.github.com/users/hlindberg/gists{/gist_id}","starred_url":"https://api.github.com/users/hlindberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hlindberg/subscriptions","organizations_url":"https://api.github.com/users/hlindberg/orgs","repos_url":"https://api.github.com/users/hlindberg/repos","events_url":"https://api.github.com/users/hlindberg/events{/privacy}","received_events_url":"https://api.github.com/users/hlindberg/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-15T15:29:00Z","updated_at":"2018-06-21T17:00:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"80e06e95e8d637d80b6f8e77f478db20a30510a2","assignee":null,"assignees":[],"requested_reviewers":[{"login":"clairecadman","id":28658680,"node_id":"MDQ6VXNlcjI4NjU4Njgw","avatar_url":"https://avatars0.githubusercontent.com/u/28658680?v=4","gravatar_id":"","url":"https://api.github.com/users/clairecadman","html_url":"https://github.com/clairecadman","followers_url":"https://api.github.com/users/clairecadman/followers","following_url":"https://api.github.com/users/clairecadman/following{/other_user}","gists_url":"https://api.github.com/users/clairecadman/gists{/gist_id}","starred_url":"https://api.github.com/users/clairecadman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/clairecadman/subscriptions","organizations_url":"https://api.github.com/users/clairecadman/orgs","repos_url":"https://api.github.com/users/clairecadman/repos","events_url":"https://api.github.com/users/clairecadman/events{/privacy}","received_events_url":"https://api.github.com/users/clairecadman/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-stdlib/pulls/922/commits","review_comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-stdlib/pulls/922/comments","review_comment_url":"https://api.github.com/repos/puppetlabs/puppetlabs-stdlib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-stdlib/issues/922/comments","statuses_url":"https://api.github.com/repos/puppetlabs/puppetlabs-stdlib/statuses/eac001e39ed37d40c3d0b89575b30205be1bbac7","head":{"label":"hlindberg:(docs)_update-documentation-wrt-functions-moved-to-puppet","ref":"(docs)_update-documentation-wrt-functions-moved-to-puppet","sha":"eac001e39ed37d40c3d0b89575b30205be1bbac7","user":{"login":"hlindberg","id":563066,"node_id":"MDQ6VXNlcjU2MzA2Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/563066?v=4","gravatar_id":"","url":"https://api.github.com/users/hlindberg","html_url":"https://github.com/hlindberg","followers_url":"https://api.github.com/users/hlindberg/followers","following_url":"https://api.github.com/users/hlindberg/following{/other_user}","gists_url":"https://api.github.com/users/hlindberg/gists{/gist_id}","starred_url":"https://api.github.com/users/hlindberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hlindberg/subscriptions","organizations_url":"https://api.github.com/users/hlindberg/orgs","repos_url":"https://api.github.com/users/hlindberg/repos","events_url":"https://api.github.com/users/hlindberg/events{/privacy}","received_events_url":"https://api.github.com/users/hlindberg/received_events","type":"User","site_admin":false},"repo":{"id":7739811,"node_id":"MDEwOlJlcG9zaXRvcnk3NzM5ODEx","name":"puppetlabs-stdlib","full_name":"hlindberg/puppetlabs-stdlib","owner":{"login":"hlindberg","id":563066,"node_id":"MDQ6VXNlcjU2MzA2Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/563066?v=4","gravatar_id":"","url":"https://api.github.com/users/hlindberg","html_url":"https://github.com/hlindberg","followers_url":"https://api.github.com/users/hlindberg/followers","following_url":"https://api.github.com/users/hlindberg/following{/other_user}","gists_url":"https://api.github.com/users/hlindberg/gists{/gist_id}","starred_url":"https://api.github.com/users/hlindberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hlindberg/subscriptions","organizations_url":"https://api.github.com/users/hlindberg/orgs","repos_url":"https://api.github.com/users/hlindberg/repos","events_url":"https://api.github.com/users/hlindberg/events{/privacy}","received_events_url":"https://api.github.com/users/hlindberg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hlindberg/puppetlabs-stdlib","description":"Puppet Labs Standard Library module.  Please submit issues at https://projects.puppetlabs.com/projects/modules/issues and not using the issue tracker on Github.  Pull requests, however, are encouraged. =)","fork":true,"url":"https://api.github.com/repos/hlindberg/puppetlabs-stdlib","forks_url":"https://api.github.com/repos/hlindberg/puppetlabs-stdlib/forks","keys_url":"https://api.github.com/repos/hlindberg/puppetlabs-stdlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hlindberg/puppetlabs-stdlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hlindberg/puppetlabs-stdlib/teams","hooks_url":"https://api.github.com/repos/hlindberg/puppetlabs-stdlib/hooks","issue_events_url":"https://api.github.com/repos/hlindberg/puppetlabs-stdlib/issues/events{/number}","events_url":"https://api.github.com/repos/hlindberg/puppetlabs-stdlib/events","assignees_url":"https://api.github.com/repos/hlindberg/puppetlabs-stdlib/assignees{/user}","branches_url":"https://api.github.com/repos/hlindberg/puppetlabs-stdlib/branches{/branch}","tags_url":"https://api.github.com/repos/hlindberg/puppetlabs-stdlib/tags","blobs_url":"https://api.github.com/repos/hlindberg/puppetlabs-stdlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hlindberg/puppetlabs-stdlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hlindberg/puppetlabs-stdlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/hlindberg/puppetlabs-stdlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hlindberg/puppetlabs-stdlib/statuses/{sha}","languages_url":"https://api.github.com/repos/hlindberg/puppetlabs-stdlib/languages","stargazers_url":"https://api.github.com/repos/hlindberg/puppetlabs-stdlib/stargazers","contributors_url":"https://api.github.com/repos/hlindberg/puppetlabs-stdlib/contributors","subscribers_url":"https://api.github.com/repos/hlindberg/puppetlabs-stdlib/subscribers","subscription_url":"https://api.github.com/repos/hlindberg/puppetlabs-stdlib/subscription","commits_url":"https://api.github.com/repos/hlindberg/puppetlabs-stdlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/hlindberg/puppetlabs-stdlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/hlindberg/puppetlabs-stdlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/hlindberg/puppetlabs-stdlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/hlindberg/puppetlabs-stdlib/contents/{+path}","compare_url":"https://api.github.com/repos/hlindberg/puppetlabs-stdlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hlindberg/puppetlabs-stdlib/merges","archive_url":"https://api.github.com/repos/hlindberg/puppetlabs-stdlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hlindberg/puppetlabs-stdlib/downloads","issues_url":"https://api.github.com/repos/hlindberg/puppetlabs-stdlib/issues{/number}","pulls_url":"https://api.github.com/repos/hlindberg/puppetlabs-stdlib/pulls{/number}","milestones_url":"https://api.github.com/repos/hlindberg/puppetlabs-stdlib/milestones{/number}","notifications_url":"https://api.github.com/repos/hlindberg/puppetlabs-stdlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hlindberg/puppetlabs-stdlib/labels{/name}","releases_url":"https://api.github.com/repos/hlindberg/puppetlabs-stdlib/releases{/id}","deployments_url":"https://api.github.com/repos/hlindberg/puppetlabs-stdlib/deployments","created_at":"2013-01-21T20:30:37Z","updated_at":"2013-01-21T20:30:37Z","pushed_at":"2018-06-21T16:56:28Z","git_url":"git://github.com/hlindberg/puppetlabs-stdlib.git","ssh_url":"git@github.com:hlindberg/puppetlabs-stdlib.git","clone_url":"https://github.com/hlindberg/puppetlabs-stdlib.git","svn_url":"https://github.com/hlindberg/puppetlabs-stdlib","homepage":"http://forge.puppetlabs.com/puppetlabs/stdlib","size":2858,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"puppetlabs:master","ref":"master","sha":"2cf430eb65f04a9e2b7f81dac71de40f8214a392","user":{"login":"puppetlabs","id":234268,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDI2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/234268?v=4","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":1794823,"node_id":"MDEwOlJlcG9zaXRvcnkxNzk0ODIz","name":"puppetlabs-stdlib","full_name":"puppetlabs/puppetlabs-stdlib","owner":{"login":"puppetlabs","id":234268,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNDI2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/234268?v=4","gravatar_id":"","url":"https://api.github.com/users/puppetlabs","html_url":"https://github.com/puppetlabs","followers_url":"https://api.github.com/users/puppetlabs/followers","following_url":"https://api.github.com/users/puppetlabs/following{/other_user}","gists_url":"https://api.github.com/users/puppetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/puppetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/puppetlabs/subscriptions","organizations_url":"https://api.github.com/users/puppetlabs/orgs","repos_url":"https://api.github.com/users/puppetlabs/repos","events_url":"https://api.github.com/users/puppetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/puppetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/puppetlabs/puppetlabs-stdlib","description":"Puppet Labs Standard Library module","fork":false,"url":"https://api.github.com/repos/puppetlabs/puppetlabs-stdlib","forks_url":"https://api.github.com/repos/puppetlabs/puppetlabs-stdlib/forks","keys_url":"https://api.github.com/repos/puppetlabs/puppetlabs-stdlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/puppetlabs/puppetlabs-stdlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/puppetlabs/puppetlabs-stdlib/teams","hooks_url":"https://api.github.com/repos/puppetlabs/puppetlabs-stdlib/hooks","issue_events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-stdlib/issues/events{/number}","events_url":"https://api.github.com/repos/puppetlabs/puppetlabs-stdlib/events","assignees_url":"https://api.github.com/repos/puppetlabs/puppetlabs-stdlib/assignees{/user}","branches_url":"https://api.github.com/repos/puppetlabs/puppetlabs-stdlib/branches{/branch}","tags_url":"https://api.github.com/repos/puppetlabs/puppetlabs-stdlib/tags","blobs_url":"https://api.github.com/repos/puppetlabs/puppetlabs-stdlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/puppetlabs/puppetlabs-stdlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/puppetlabs/puppetlabs-stdlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/puppetlabs/puppetlabs-stdlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/puppetlabs/puppetlabs-stdlib/statuses/{sha}","languages_url":"https://api.github.com/repos/puppetlabs/puppetlabs-stdlib/languages","stargazers_url":"https://api.github.com/repos/puppetlabs/puppetlabs-stdlib/stargazers","contributors_url":"https://api.github.com/repos/puppetlabs/puppetlabs-stdlib/contributors","subscribers_url":"https://api.github.com/repos/puppetlabs/puppetlabs-stdlib/subscribers","subscription_url":"https://api.github.com/repos/puppetlabs/puppetlabs-stdlib/subscription","commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-stdlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/puppetlabs/puppetlabs-stdlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-stdlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/puppetlabs/puppetlabs-stdlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/puppetlabs/puppetlabs-stdlib/contents/{+path}","compare_url":"https://api.github.com/repos/puppetlabs/puppetlabs-stdlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/puppetlabs/puppetlabs-stdlib/merges","archive_url":"https://api.github.com/repos/puppetlabs/puppetlabs-stdlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/puppetlabs/puppetlabs-stdlib/downloads","issues_url":"https://api.github.com/repos/puppetlabs/puppetlabs-stdlib/issues{/number}","pulls_url":"https://api.github.com/repos/puppetlabs/puppetlabs-stdlib/pulls{/number}","milestones_url":"https://api.github.com/repos/puppetlabs/puppetlabs-stdlib/milestones{/number}","notifications_url":"https://api.github.com/repos/puppetlabs/puppetlabs-stdlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/puppetlabs/puppetlabs-stdlib/labels{/name}","releases_url":"https://api.github.com/repos/puppetlabs/puppetlabs-stdlib/releases{/id}","deployments_url":"https://api.github.com/repos/puppetlabs/puppetlabs-stdlib/deployments","created_at":"2011-05-24T18:07:16Z","updated_at":"2018-06-19T16:06:52Z","pushed_at":"2018-06-21T16:56:30Z","git_url":"git://github.com/puppetlabs/puppetlabs-stdlib.git","ssh_url":"git@github.com:puppetlabs/puppetlabs-stdlib.git","clone_url":"https://github.com/puppetlabs/puppetlabs-stdlib.git","svn_url":"https://github.com/puppetlabs/puppetlabs-stdlib","homepage":"http://forge.puppetlabs.com/puppetlabs/stdlib","size":2799,"stargazers_count":345,"watchers_count":345,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":549,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":549,"open_issues":8,"watchers":345,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-stdlib/pulls/922"},"html":{"href":"https://github.com/puppetlabs/puppetlabs-stdlib/pull/922"},"issue":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-stdlib/issues/922"},"comments":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-stdlib/issues/922/comments"},"review_comments":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-stdlib/pulls/922/comments"},"review_comment":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-stdlib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-stdlib/pulls/922/commits"},"statuses":{"href":"https://api.github.com/repos/puppetlabs/puppetlabs-stdlib/statuses/eac001e39ed37d40c3d0b89575b30205be1bbac7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"hlindberg"}}