{"action":"created","issue":{"url":"https://api.github.com/repos/OriginProtocol/origin-js/issues/206","repository_url":"https://api.github.com/repos/OriginProtocol/origin-js","labels_url":"https://api.github.com/repos/OriginProtocol/origin-js/issues/206/labels{/name}","comments_url":"https://api.github.com/repos/OriginProtocol/origin-js/issues/206/comments","events_url":"https://api.github.com/repos/OriginProtocol/origin-js/issues/206/events","html_url":"https://github.com/OriginProtocol/origin-js/pull/206","id":325544980,"number":206,"title":"update npmignore file","user":{"login":"gaboesquivel","id":391270,"avatar_url":"https://avatars0.githubusercontent.com/u/391270?v=4","gravatar_id":"","url":"https://api.github.com/users/gaboesquivel","html_url":"https://github.com/gaboesquivel","followers_url":"https://api.github.com/users/gaboesquivel/followers","following_url":"https://api.github.com/users/gaboesquivel/following{/other_user}","gists_url":"https://api.github.com/users/gaboesquivel/gists{/gist_id}","starred_url":"https://api.github.com/users/gaboesquivel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaboesquivel/subscriptions","organizations_url":"https://api.github.com/users/gaboesquivel/orgs","repos_url":"https://api.github.com/users/gaboesquivel/repos","events_url":"https://api.github.com/users/gaboesquivel/events{/privacy}","received_events_url":"https://api.github.com/users/gaboesquivel/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-23T04:26:14Z","updated_at":"2018-05-23T04:51:18Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/OriginProtocol/origin-js/pulls/206","html_url":"https://github.com/OriginProtocol/origin-js/pull/206","diff_url":"https://github.com/OriginProtocol/origin-js/pull/206.diff","patch_url":"https://github.com/OriginProtocol/origin-js/pull/206.patch"},"body":"Solves #199 \r\n\r\n### Checklist:\r\n\r\n- [x] Code contains relevant tests for the problem you are solving\r\n- [x] Ensure all new and existing tests pass\r\n- [x] Update any relevant READMEs and [docs](https://github.com/OriginProtocol/docs)\r\n- [x] Submit to the `develop` branch instead of `master`\r\n\r\n### Description:\r\n\r\nThis PR updates the `.npmignore` files to exclude unnecessary files from the package\r\n\r\n### Testing Steps\r\n\r\n1. Start a local npm registry with verdaccio\r\n\r\n```\r\nnpm install -g verdaccio\r\nverdaccio\r\n```\r\n\r\n2. On a separate shell window \r\n```\r\nnpm adduser --registry  http://localhost:4873 \r\ncd origin-js\r\nnpm publish --registry http://localhost:4873 \r\n```\r\n<img width=\"1868\" alt=\"origin-package\" src=\"https://user-images.githubusercontent.com/391270/40403395-f76704dc-5e0e-11e8-8903-293dbd065df2.png\">\r\n\r\n3. Test the installation\r\n```\r\nmkdir testing-npm-install-origin\r\ncd testing-npm-install-origin\r\nnpm i -S origin\r\ntree -L 2 node_modules/origin\r\n```\r\n<img width=\"822\" alt=\"origin-package-2\" src=\"https://user-images.githubusercontent.com/391270/40403397-fae809f8-5e0e-11e8-881f-2afbe8cb87bd.png\">\r\n\r\nref https://docs.npmjs.com/misc/developers#keeping-files-out-of-your-package"},"comment":{"url":"https://api.github.com/repos/OriginProtocol/origin-js/issues/comments/391219560","html_url":"https://github.com/OriginProtocol/origin-js/pull/206#issuecomment-391219560","issue_url":"https://api.github.com/repos/OriginProtocol/origin-js/issues/206","id":391219560,"user":{"login":"gaboesquivel","id":391270,"avatar_url":"https://avatars0.githubusercontent.com/u/391270?v=4","gravatar_id":"","url":"https://api.github.com/users/gaboesquivel","html_url":"https://github.com/gaboesquivel","followers_url":"https://api.github.com/users/gaboesquivel/followers","following_url":"https://api.github.com/users/gaboesquivel/following{/other_user}","gists_url":"https://api.github.com/users/gaboesquivel/gists{/gist_id}","starred_url":"https://api.github.com/users/gaboesquivel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gaboesquivel/subscriptions","organizations_url":"https://api.github.com/users/gaboesquivel/orgs","repos_url":"https://api.github.com/users/gaboesquivel/repos","events_url":"https://api.github.com/users/gaboesquivel/events{/privacy}","received_events_url":"https://api.github.com/users/gaboesquivel/received_events","type":"User","site_admin":false},"created_at":"2018-05-23T04:51:18Z","updated_at":"2018-05-23T04:51:18Z","author_association":"NONE","body":"just realized this doesn't do what I thought it was doing. Reviewing it. "}}
{"actor":{"display_login":"gaboesquivel"}}