{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/adbhelper/pulls/comments/170282624","pull_request_review_id":98950787,"id":170282624,"diff_hunk":"@@ -47,22 +47,22 @@ Device.prototype = {\n   rebootRecovery: adb.rebootRecovery.bind(adb),\n   rebootBootloader: adb.rebootBootloader.bind(adb),\n \n-  isRoot: function() {\n+  isRoot() {\n     return adb.shell(\"id\").then(stdout => {\n       if (stdout) {\n         let uid = stdout.match(/uid=(\\d+)/)[1];\n         return uid == \"0\";\n-      } else {\n-        return false;\n       }\n+        return false;","path":"device.js","position":22,"original_position":22,"commit_id":"944fe1556621503967079484daffe845983ece72","original_commit_id":"944fe1556621503967079484daffe845983ece72","user":{"login":"jryans","id":279572,"avatar_url":"https://avatars3.githubusercontent.com/u/279572?v=4","gravatar_id":"","url":"https://api.github.com/users/jryans","html_url":"https://github.com/jryans","followers_url":"https://api.github.com/users/jryans/followers","following_url":"https://api.github.com/users/jryans/following{/other_user}","gists_url":"https://api.github.com/users/jryans/gists{/gist_id}","starred_url":"https://api.github.com/users/jryans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jryans/subscriptions","organizations_url":"https://api.github.com/users/jryans/orgs","repos_url":"https://api.github.com/users/jryans/repos","events_url":"https://api.github.com/users/jryans/events{/privacy}","received_events_url":"https://api.github.com/users/jryans/received_events","type":"User","site_admin":false},"body":"Hmm, curious! I need to watch out for `eslint --fix` more closely! 😅 ","created_at":"2018-02-23T15:34:55Z","updated_at":"2018-02-23T15:34:56Z","html_url":"https://github.com/mozilla/adbhelper/pull/40#discussion_r170282624","pull_request_url":"https://api.github.com/repos/mozilla/adbhelper/pulls/40","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mozilla/adbhelper/pulls/comments/170282624"},"html":{"href":"https://github.com/mozilla/adbhelper/pull/40#discussion_r170282624"},"pull_request":{"href":"https://api.github.com/repos/mozilla/adbhelper/pulls/40"}},"in_reply_to_id":170211901},"pull_request":{"url":"https://api.github.com/repos/mozilla/adbhelper/pulls/40","id":170929612,"html_url":"https://github.com/mozilla/adbhelper/pull/40","diff_url":"https://github.com/mozilla/adbhelper/pull/40.diff","patch_url":"https://github.com/mozilla/adbhelper/pull/40.patch","issue_url":"https://api.github.com/repos/mozilla/adbhelper/issues/40","number":40,"state":"open","locked":false,"title":"Convert to packed add-on","user":{"login":"jryans","id":279572,"avatar_url":"https://avatars3.githubusercontent.com/u/279572?v=4","gravatar_id":"","url":"https://api.github.com/users/jryans","html_url":"https://github.com/jryans","followers_url":"https://api.github.com/users/jryans/followers","following_url":"https://api.github.com/users/jryans/following{/other_user}","gists_url":"https://api.github.com/users/jryans/gists{/gist_id}","starred_url":"https://api.github.com/users/jryans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jryans/subscriptions","organizations_url":"https://api.github.com/users/jryans/orgs","repos_url":"https://api.github.com/users/jryans/repos","events_url":"https://api.github.com/users/jryans/events{/privacy}","received_events_url":"https://api.github.com/users/jryans/received_events","type":"User","site_admin":false},"body":"Firefox 59 and later require packed add-ons, so we convert to that mode here. (Some ESLint changes included as well in separate commits.)\r\n\r\nSeems to work well on macOS. Still need to test the others.","created_at":"2018-02-23T04:19:27Z","updated_at":"2018-02-23T15:34:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a532155f3992f7d365b2ee90ee55497e4c78168","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/adbhelper/pulls/40/commits","review_comments_url":"https://api.github.com/repos/mozilla/adbhelper/pulls/40/comments","review_comment_url":"https://api.github.com/repos/mozilla/adbhelper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/adbhelper/issues/40/comments","statuses_url":"https://api.github.com/repos/mozilla/adbhelper/statuses/944fe1556621503967079484daffe845983ece72","head":{"label":"jryans:packed","ref":"packed","sha":"944fe1556621503967079484daffe845983ece72","user":{"login":"jryans","id":279572,"avatar_url":"https://avatars3.githubusercontent.com/u/279572?v=4","gravatar_id":"","url":"https://api.github.com/users/jryans","html_url":"https://github.com/jryans","followers_url":"https://api.github.com/users/jryans/followers","following_url":"https://api.github.com/users/jryans/following{/other_user}","gists_url":"https://api.github.com/users/jryans/gists{/gist_id}","starred_url":"https://api.github.com/users/jryans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jryans/subscriptions","organizations_url":"https://api.github.com/users/jryans/orgs","repos_url":"https://api.github.com/users/jryans/repos","events_url":"https://api.github.com/users/jryans/events{/privacy}","received_events_url":"https://api.github.com/users/jryans/received_events","type":"User","site_admin":false},"repo":{"id":18422685,"name":"adbhelper","full_name":"jryans/adbhelper","owner":{"login":"jryans","id":279572,"avatar_url":"https://avatars3.githubusercontent.com/u/279572?v=4","gravatar_id":"","url":"https://api.github.com/users/jryans","html_url":"https://github.com/jryans","followers_url":"https://api.github.com/users/jryans/followers","following_url":"https://api.github.com/users/jryans/following{/other_user}","gists_url":"https://api.github.com/users/jryans/gists{/gist_id}","starred_url":"https://api.github.com/users/jryans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jryans/subscriptions","organizations_url":"https://api.github.com/users/jryans/orgs","repos_url":"https://api.github.com/users/jryans/repos","events_url":"https://api.github.com/users/jryans/events{/privacy}","received_events_url":"https://api.github.com/users/jryans/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jryans/adbhelper","description":"A Firefox addon to ease connecting to Firefox OS devices.","fork":true,"url":"https://api.github.com/repos/jryans/adbhelper","forks_url":"https://api.github.com/repos/jryans/adbhelper/forks","keys_url":"https://api.github.com/repos/jryans/adbhelper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jryans/adbhelper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jryans/adbhelper/teams","hooks_url":"https://api.github.com/repos/jryans/adbhelper/hooks","issue_events_url":"https://api.github.com/repos/jryans/adbhelper/issues/events{/number}","events_url":"https://api.github.com/repos/jryans/adbhelper/events","assignees_url":"https://api.github.com/repos/jryans/adbhelper/assignees{/user}","branches_url":"https://api.github.com/repos/jryans/adbhelper/branches{/branch}","tags_url":"https://api.github.com/repos/jryans/adbhelper/tags","blobs_url":"https://api.github.com/repos/jryans/adbhelper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jryans/adbhelper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jryans/adbhelper/git/refs{/sha}","trees_url":"https://api.github.com/repos/jryans/adbhelper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jryans/adbhelper/statuses/{sha}","languages_url":"https://api.github.com/repos/jryans/adbhelper/languages","stargazers_url":"https://api.github.com/repos/jryans/adbhelper/stargazers","contributors_url":"https://api.github.com/repos/jryans/adbhelper/contributors","subscribers_url":"https://api.github.com/repos/jryans/adbhelper/subscribers","subscription_url":"https://api.github.com/repos/jryans/adbhelper/subscription","commits_url":"https://api.github.com/repos/jryans/adbhelper/commits{/sha}","git_commits_url":"https://api.github.com/repos/jryans/adbhelper/git/commits{/sha}","comments_url":"https://api.github.com/repos/jryans/adbhelper/comments{/number}","issue_comment_url":"https://api.github.com/repos/jryans/adbhelper/issues/comments{/number}","contents_url":"https://api.github.com/repos/jryans/adbhelper/contents/{+path}","compare_url":"https://api.github.com/repos/jryans/adbhelper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jryans/adbhelper/merges","archive_url":"https://api.github.com/repos/jryans/adbhelper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jryans/adbhelper/downloads","issues_url":"https://api.github.com/repos/jryans/adbhelper/issues{/number}","pulls_url":"https://api.github.com/repos/jryans/adbhelper/pulls{/number}","milestones_url":"https://api.github.com/repos/jryans/adbhelper/milestones{/number}","notifications_url":"https://api.github.com/repos/jryans/adbhelper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jryans/adbhelper/labels{/name}","releases_url":"https://api.github.com/repos/jryans/adbhelper/releases{/id}","deployments_url":"https://api.github.com/repos/jryans/adbhelper/deployments","created_at":"2014-04-04T00:27:50Z","updated_at":"2016-10-20T14:06:13Z","pushed_at":"2018-02-23T04:17:43Z","git_url":"git://github.com/jryans/adbhelper.git","ssh_url":"git@github.com:jryans/adbhelper.git","clone_url":"https://github.com/jryans/adbhelper.git","svn_url":"https://github.com/jryans/adbhelper","homepage":"","size":6546,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"cf87f75493c058e5196c4497182b7f054fce3549","user":{"login":"mozilla","id":131524,"avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":20994581,"name":"adbhelper","full_name":"mozilla/adbhelper","owner":{"login":"mozilla","id":131524,"avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/adbhelper","description":"A Firefox add-on to ease connecting to Firefox for Android","fork":false,"url":"https://api.github.com/repos/mozilla/adbhelper","forks_url":"https://api.github.com/repos/mozilla/adbhelper/forks","keys_url":"https://api.github.com/repos/mozilla/adbhelper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/adbhelper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/adbhelper/teams","hooks_url":"https://api.github.com/repos/mozilla/adbhelper/hooks","issue_events_url":"https://api.github.com/repos/mozilla/adbhelper/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/adbhelper/events","assignees_url":"https://api.github.com/repos/mozilla/adbhelper/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/adbhelper/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/adbhelper/tags","blobs_url":"https://api.github.com/repos/mozilla/adbhelper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/adbhelper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/adbhelper/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/adbhelper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/adbhelper/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/adbhelper/languages","stargazers_url":"https://api.github.com/repos/mozilla/adbhelper/stargazers","contributors_url":"https://api.github.com/repos/mozilla/adbhelper/contributors","subscribers_url":"https://api.github.com/repos/mozilla/adbhelper/subscribers","subscription_url":"https://api.github.com/repos/mozilla/adbhelper/subscription","commits_url":"https://api.github.com/repos/mozilla/adbhelper/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/adbhelper/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/adbhelper/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/adbhelper/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/adbhelper/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/adbhelper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/adbhelper/merges","archive_url":"https://api.github.com/repos/mozilla/adbhelper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/adbhelper/downloads","issues_url":"https://api.github.com/repos/mozilla/adbhelper/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/adbhelper/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/adbhelper/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/adbhelper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/adbhelper/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/adbhelper/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/adbhelper/deployments","created_at":"2014-06-19T09:15:39Z","updated_at":"2018-02-13T14:26:32Z","pushed_at":"2018-02-23T04:19:28Z","git_url":"git://github.com/mozilla/adbhelper.git","ssh_url":"git@github.com:mozilla/adbhelper.git","clone_url":"https://github.com/mozilla/adbhelper.git","svn_url":"https://github.com/mozilla/adbhelper","homepage":"","size":6547,"stargazers_count":34,"watchers_count":34,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":44,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":44,"open_issues":1,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/adbhelper/pulls/40"},"html":{"href":"https://github.com/mozilla/adbhelper/pull/40"},"issue":{"href":"https://api.github.com/repos/mozilla/adbhelper/issues/40"},"comments":{"href":"https://api.github.com/repos/mozilla/adbhelper/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/adbhelper/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/adbhelper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/adbhelper/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/adbhelper/statuses/944fe1556621503967079484daffe845983ece72"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jryans"}}