{"action":"created","issue":{"url":"https://api.github.com/repos/dpgaspar/Flask-AppBuilder/issues/797","repository_url":"https://api.github.com/repos/dpgaspar/Flask-AppBuilder","labels_url":"https://api.github.com/repos/dpgaspar/Flask-AppBuilder/issues/797/labels{/name}","comments_url":"https://api.github.com/repos/dpgaspar/Flask-AppBuilder/issues/797/comments","events_url":"https://api.github.com/repos/dpgaspar/Flask-AppBuilder/issues/797/events","html_url":"https://github.com/dpgaspar/Flask-AppBuilder/pull/797","id":348495840,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2ODMzNTY3","number":797,"title":"Remove safe filter from template","user":{"login":"graceguo-supercat","id":27990562,"node_id":"MDQ6VXNlcjI3OTkwNTYy","avatar_url":"https://avatars3.githubusercontent.com/u/27990562?v=4","gravatar_id":"","url":"https://api.github.com/users/graceguo-supercat","html_url":"https://github.com/graceguo-supercat","followers_url":"https://api.github.com/users/graceguo-supercat/followers","following_url":"https://api.github.com/users/graceguo-supercat/following{/other_user}","gists_url":"https://api.github.com/users/graceguo-supercat/gists{/gist_id}","starred_url":"https://api.github.com/users/graceguo-supercat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graceguo-supercat/subscriptions","organizations_url":"https://api.github.com/users/graceguo-supercat/orgs","repos_url":"https://api.github.com/users/graceguo-supercat/repos","events_url":"https://api.github.com/users/graceguo-supercat/events{/privacy}","received_events_url":"https://api.github.com/users/graceguo-supercat/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-08-07T21:35:10Z","updated_at":"2018-08-16T00:48:20Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/dpgaspar/Flask-AppBuilder/pulls/797","html_url":"https://github.com/dpgaspar/Flask-AppBuilder/pull/797","diff_url":"https://github.com/dpgaspar/Flask-AppBuilder/pull/797.diff","patch_url":"https://github.com/dpgaspar/Flask-AppBuilder/pull/797.patch"},"body":" We found there are vulnerable to stored XSS in multiple list endpoints within the application. For example, user can inject javascript <script> tag and code into First Name, Description field, and javascript code get executed when anyone loaded the list view.\r\n\r\nThis PR is to propose a solution that remove `safe` filter in templates. In most of template, we don't want to render as HTML and js, so I think remove `safe` won't affect current good content behavior and just auto-escape those tag characters.\r\n\r\n@mistercrunch "},"comment":{"url":"https://api.github.com/repos/dpgaspar/Flask-AppBuilder/issues/comments/413385891","html_url":"https://github.com/dpgaspar/Flask-AppBuilder/pull/797#issuecomment-413385891","issue_url":"https://api.github.com/repos/dpgaspar/Flask-AppBuilder/issues/797","id":413385891,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMzM4NTg5MQ==","user":{"login":"dpgaspar","id":4025227,"node_id":"MDQ6VXNlcjQwMjUyMjc=","avatar_url":"https://avatars1.githubusercontent.com/u/4025227?v=4","gravatar_id":"","url":"https://api.github.com/users/dpgaspar","html_url":"https://github.com/dpgaspar","followers_url":"https://api.github.com/users/dpgaspar/followers","following_url":"https://api.github.com/users/dpgaspar/following{/other_user}","gists_url":"https://api.github.com/users/dpgaspar/gists{/gist_id}","starred_url":"https://api.github.com/users/dpgaspar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpgaspar/subscriptions","organizations_url":"https://api.github.com/users/dpgaspar/orgs","repos_url":"https://api.github.com/users/dpgaspar/repos","events_url":"https://api.github.com/users/dpgaspar/events{/privacy}","received_events_url":"https://api.github.com/users/dpgaspar/received_events","type":"User","site_admin":false},"created_at":"2018-08-16T00:48:20Z","updated_at":"2018-08-16T00:48:20Z","author_association":"OWNER","body":"Looks good, let me run some more tests"}}
{"actor":{"display_login":"dpgaspar"}}