{"action":"closed","number":23875,"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/23875","id":225778277,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1Nzc4Mjc3","html_url":"https://github.com/nodejs/node/pull/23875","diff_url":"https://github.com/nodejs/node/pull/23875.diff","patch_url":"https://github.com/nodejs/node/pull/23875.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/23875","number":23875,"state":"closed","locked":false,"title":"[v10.x] Revert buffer crash","user":{"login":"refack","id":96947,"node_id":"MDQ6VXNlcjk2OTQ3","avatar_url":"https://avatars3.githubusercontent.com/u/96947?v=4","gravatar_id":"","url":"https://api.github.com/users/refack","html_url":"https://github.com/refack","followers_url":"https://api.github.com/users/refack/followers","following_url":"https://api.github.com/users/refack/following{/other_user}","gists_url":"https://api.github.com/users/refack/gists{/gist_id}","starred_url":"https://api.github.com/users/refack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/refack/subscriptions","organizations_url":"https://api.github.com/users/refack/orgs","repos_url":"https://api.github.com/users/refack/repos","events_url":"https://api.github.com/users/refack/events{/privacy}","received_events_url":"https://api.github.com/users/refack/received_events","type":"User","site_admin":false},"body":"Patch for the node10 branch\r\n\r\nThis reverts https://github.com/nodejs/node/commit/2555cb4a4049dc4c41d8a2f4ce50909cc0a12a4a that introduced a native crash, and adds the regression test authored for (https://github.com/nodejs/node/pull/23795)\r\n\r\nRefs: https://github.com/nodejs/node/pull/23795\r\nRefs: https://github.com/nodejs/node/pull/22129\r\nFixes: https://github.com/nodejs/node/issues/23668\r\n\r\n\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [X] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [X] tests and/or benchmarks are included\r\n- [X] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n","created_at":"2018-10-25T14:18:53Z","updated_at":"2018-10-30T01:47:24Z","closed_at":"2018-10-30T01:47:24Z","merged_at":null,"merge_commit_sha":"5b6b53e1c17a0cf775d3af93829f07c51f4754dc","assignee":null,"assignees":[],"requested_reviewers":[{"login":"bnoordhuis","id":275871,"node_id":"MDQ6VXNlcjI3NTg3MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/275871?v=4","gravatar_id":"","url":"https://api.github.com/users/bnoordhuis","html_url":"https://github.com/bnoordhuis","followers_url":"https://api.github.com/users/bnoordhuis/followers","following_url":"https://api.github.com/users/bnoordhuis/following{/other_user}","gists_url":"https://api.github.com/users/bnoordhuis/gists{/gist_id}","starred_url":"https://api.github.com/users/bnoordhuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bnoordhuis/subscriptions","organizations_url":"https://api.github.com/users/bnoordhuis/orgs","repos_url":"https://api.github.com/users/bnoordhuis/repos","events_url":"https://api.github.com/users/bnoordhuis/events{/privacy}","received_events_url":"https://api.github.com/users/bnoordhuis/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":155267502,"node_id":"MDU6TGFiZWwxNTUyNjc1MDI=","url":"https://api.github.com/repos/nodejs/node/labels/C++","name":"C++","color":"e11d21","default":false},{"id":155267414,"node_id":"MDU6TGFiZWwxNTUyNjc0MTQ=","url":"https://api.github.com/repos/nodejs/node/labels/buffer","name":"buffer","color":"f7c6c7","default":false},{"id":281232761,"node_id":"MDU6TGFiZWwyODEyMzI3NjE=","url":"https://api.github.com/repos/nodejs/node/labels/lib%20/%20src","name":"lib / src","color":"fad8c7","default":false},{"id":1089146747,"node_id":"MDU6TGFiZWwxMDg5MTQ2NzQ3","url":"https://api.github.com/repos/nodejs/node/labels/lts-watch-v10.x","name":"lts-watch-v10.x","color":"4213c4","default":false},{"id":585819831,"node_id":"MDU6TGFiZWw1ODU4MTk4MzE=","url":"https://api.github.com/repos/nodejs/node/labels/regression","name":"regression","color":"b60205","default":false},{"id":678967907,"node_id":"MDU6TGFiZWw2Nzg5Njc5MDc=","url":"https://api.github.com/repos/nodejs/node/labels/tsc-review","name":"tsc-review","color":"006b75","default":false},{"id":904071494,"node_id":"MDU6TGFiZWw5MDQwNzE0OTQ=","url":"https://api.github.com/repos/nodejs/node/labels/v10.x","name":"v10.x","color":"4213c4","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/23875/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/23875/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/23875/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/d39da714cf1d3ebdb224d5366dd4bda231059b86","head":{"label":"refack:revert-buffer-crash","ref":"revert-buffer-crash","sha":"d39da714cf1d3ebdb224d5366dd4bda231059b86","user":{"login":"refack","id":96947,"node_id":"MDQ6VXNlcjk2OTQ3","avatar_url":"https://avatars3.githubusercontent.com/u/96947?v=4","gravatar_id":"","url":"https://api.github.com/users/refack","html_url":"https://github.com/refack","followers_url":"https://api.github.com/users/refack/followers","following_url":"https://api.github.com/users/refack/following{/other_user}","gists_url":"https://api.github.com/users/refack/gists{/gist_id}","starred_url":"https://api.github.com/users/refack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/refack/subscriptions","organizations_url":"https://api.github.com/users/refack/orgs","repos_url":"https://api.github.com/users/refack/repos","events_url":"https://api.github.com/users/refack/events{/privacy}","received_events_url":"https://api.github.com/users/refack/received_events","type":"User","site_admin":false},"repo":{"id":81225016,"node_id":"MDEwOlJlcG9zaXRvcnk4MTIyNTAxNg==","name":"node","full_name":"refack/node","private":false,"owner":{"login":"refack","id":96947,"node_id":"MDQ6VXNlcjk2OTQ3","avatar_url":"https://avatars3.githubusercontent.com/u/96947?v=4","gravatar_id":"","url":"https://api.github.com/users/refack","html_url":"https://github.com/refack","followers_url":"https://api.github.com/users/refack/followers","following_url":"https://api.github.com/users/refack/following{/other_user}","gists_url":"https://api.github.com/users/refack/gists{/gist_id}","starred_url":"https://api.github.com/users/refack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/refack/subscriptions","organizations_url":"https://api.github.com/users/refack/orgs","repos_url":"https://api.github.com/users/refack/repos","events_url":"https://api.github.com/users/refack/events{/privacy}","received_events_url":"https://api.github.com/users/refack/received_events","type":"User","site_admin":false},"html_url":"https://github.com/refack/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/refack/node","forks_url":"https://api.github.com/repos/refack/node/forks","keys_url":"https://api.github.com/repos/refack/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/refack/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/refack/node/teams","hooks_url":"https://api.github.com/repos/refack/node/hooks","issue_events_url":"https://api.github.com/repos/refack/node/issues/events{/number}","events_url":"https://api.github.com/repos/refack/node/events","assignees_url":"https://api.github.com/repos/refack/node/assignees{/user}","branches_url":"https://api.github.com/repos/refack/node/branches{/branch}","tags_url":"https://api.github.com/repos/refack/node/tags","blobs_url":"https://api.github.com/repos/refack/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/refack/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/refack/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/refack/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/refack/node/statuses/{sha}","languages_url":"https://api.github.com/repos/refack/node/languages","stargazers_url":"https://api.github.com/repos/refack/node/stargazers","contributors_url":"https://api.github.com/repos/refack/node/contributors","subscribers_url":"https://api.github.com/repos/refack/node/subscribers","subscription_url":"https://api.github.com/repos/refack/node/subscription","commits_url":"https://api.github.com/repos/refack/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/refack/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/refack/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/refack/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/refack/node/contents/{+path}","compare_url":"https://api.github.com/repos/refack/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/refack/node/merges","archive_url":"https://api.github.com/repos/refack/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/refack/node/downloads","issues_url":"https://api.github.com/repos/refack/node/issues{/number}","pulls_url":"https://api.github.com/repos/refack/node/pulls{/number}","milestones_url":"https://api.github.com/repos/refack/node/milestones{/number}","notifications_url":"https://api.github.com/repos/refack/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/refack/node/labels{/name}","releases_url":"https://api.github.com/repos/refack/node/releases{/id}","deployments_url":"https://api.github.com/repos/refack/node/deployments","created_at":"2017-02-07T15:47:09Z","updated_at":"2018-10-30T01:45:47Z","pushed_at":"2018-10-30T01:45:37Z","git_url":"git://github.com/refack/node.git","ssh_url":"git@github.com:refack/node.git","clone_url":"https://github.com/refack/node.git","svn_url":"https://github.com/refack/node","homepage":"https://nodejs.org","size":414247,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:v10.x-staging","ref":"v10.x-staging","sha":"3f63297fe8e10e54122f211c6ae573112a9f74cc","user":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"node_id":"MDEwOlJlcG9zaXRvcnkyNzE5Mzc3OQ==","name":"node","full_name":"nodejs/node","private":false,"owner":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2018-10-30T01:47:00Z","pushed_at":"2018-10-30T01:45:21Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":428281,"stargazers_count":54846,"watchers_count":54846,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11936,"mirror_url":null,"archived":false,"open_issues_count":876,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":11936,"open_issues":876,"watchers":54846,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/23875"},"html":{"href":"https://github.com/nodejs/node/pull/23875"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/23875"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/23875/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/23875/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/23875/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/d39da714cf1d3ebdb224d5366dd4bda231059b86"}},"author_association":"MEMBER","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":16,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":43,"deletions":39,"changed_files":8}}
{"actor":{"display_login":"refack"}}