{"action":"created","comment":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments/191461029","pull_request_review_id":124036451,"id":191461029,"diff_hunk":"@@ -36,6 +36,17 @@ config FLASH_PAGE_LAYOUT\n \thelp\n \t  Enables API for retrieving the layout of flash memory pages.\n \n+config FLASH_EMULATOR\n+\tbool \"Emulated flash driver\"\n+\tdepends on FLASH\n+\tdefault n","path":"drivers/flash/Kconfig","position":7,"original_position":7,"commit_id":"ed97d8f2351a6908ac08211758dc3cd7ba62a0fc","original_commit_id":"ed97d8f2351a6908ac08211758dc3cd7ba62a0fc","user":{"login":"ulfalizer","id":154768,"avatar_url":"https://avatars2.githubusercontent.com/u/154768?v=4","gravatar_id":"","url":"https://api.github.com/users/ulfalizer","html_url":"https://github.com/ulfalizer","followers_url":"https://api.github.com/users/ulfalizer/followers","following_url":"https://api.github.com/users/ulfalizer/following{/other_user}","gists_url":"https://api.github.com/users/ulfalizer/gists{/gist_id}","starred_url":"https://api.github.com/users/ulfalizer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ulfalizer/subscriptions","organizations_url":"https://api.github.com/users/ulfalizer/orgs","repos_url":"https://api.github.com/users/ulfalizer/repos","events_url":"https://api.github.com/users/ulfalizer/events{/privacy}","received_events_url":"https://api.github.com/users/ulfalizer/received_events","type":"User","site_admin":false},"body":"This seems to be common in Zephyr, and it doesn't hurt, so this is more of a style note:\r\n\r\n`bool` symbols implicitly default to `n`, so a lone `default n` is redundant.","created_at":"2018-05-29T15:05:36Z","updated_at":"2018-05-29T15:19:26Z","html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/8002#discussion_r191461029","pull_request_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/8002","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments/191461029"},"html":{"href":"https://github.com/zephyrproject-rtos/zephyr/pull/8002#discussion_r191461029"},"pull_request":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/8002"}}},"pull_request":{"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/8002","id":191176212,"html_url":"https://github.com/zephyrproject-rtos/zephyr/pull/8002","diff_url":"https://github.com/zephyrproject-rtos/zephyr/pull/8002.diff","patch_url":"https://github.com/zephyrproject-rtos/zephyr/pull/8002.patch","issue_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/8002","number":8002,"state":"closed","locked":false,"title":"driver: flash emulator","user":{"login":"lemrey","id":1151289,"avatar_url":"https://avatars1.githubusercontent.com/u/1151289?v=4","gravatar_id":"","url":"https://api.github.com/users/lemrey","html_url":"https://github.com/lemrey","followers_url":"https://api.github.com/users/lemrey/followers","following_url":"https://api.github.com/users/lemrey/following{/other_user}","gists_url":"https://api.github.com/users/lemrey/gists{/gist_id}","starred_url":"https://api.github.com/users/lemrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lemrey/subscriptions","organizations_url":"https://api.github.com/users/lemrey/orgs","repos_url":"https://api.github.com/users/lemrey/repos","events_url":"https://api.github.com/users/lemrey/events{/privacy}","received_events_url":"https://api.github.com/users/lemrey/received_events","type":"User","site_admin":false},"body":"A flash emulator driver.","created_at":"2018-05-29T15:00:02Z","updated_at":"2018-05-29T15:19:27Z","closed_at":"2018-05-29T15:00:21Z","merged_at":null,"merge_commit_sha":"aab78278c06267df7f801caf304e454b0175f13f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"nashif","id":180017,"avatar_url":"https://avatars0.githubusercontent.com/u/180017?v=4","gravatar_id":"","url":"https://api.github.com/users/nashif","html_url":"https://github.com/nashif","followers_url":"https://api.github.com/users/nashif/followers","following_url":"https://api.github.com/users/nashif/following{/other_user}","gists_url":"https://api.github.com/users/nashif/gists{/gist_id}","starred_url":"https://api.github.com/users/nashif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nashif/subscriptions","organizations_url":"https://api.github.com/users/nashif/orgs","repos_url":"https://api.github.com/users/nashif/repos","events_url":"https://api.github.com/users/nashif/events{/privacy}","received_events_url":"https://api.github.com/users/nashif/received_events","type":"User","site_admin":false},{"login":"andrewboie","id":3387369,"avatar_url":"https://avatars1.githubusercontent.com/u/3387369?v=4","gravatar_id":"","url":"https://api.github.com/users/andrewboie","html_url":"https://github.com/andrewboie","followers_url":"https://api.github.com/users/andrewboie/followers","following_url":"https://api.github.com/users/andrewboie/following{/other_user}","gists_url":"https://api.github.com/users/andrewboie/gists{/gist_id}","starred_url":"https://api.github.com/users/andrewboie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrewboie/subscriptions","organizations_url":"https://api.github.com/users/andrewboie/orgs","repos_url":"https://api.github.com/users/andrewboie/repos","events_url":"https://api.github.com/users/andrewboie/events{/privacy}","received_events_url":"https://api.github.com/users/andrewboie/received_events","type":"User","site_admin":false},{"login":"ramakrishnapallala","id":28948016,"avatar_url":"https://avatars0.githubusercontent.com/u/28948016?v=4","gravatar_id":"","url":"https://api.github.com/users/ramakrishnapallala","html_url":"https://github.com/ramakrishnapallala","followers_url":"https://api.github.com/users/ramakrishnapallala/followers","following_url":"https://api.github.com/users/ramakrishnapallala/following{/other_user}","gists_url":"https://api.github.com/users/ramakrishnapallala/gists{/gist_id}","starred_url":"https://api.github.com/users/ramakrishnapallala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ramakrishnapallala/subscriptions","organizations_url":"https://api.github.com/users/ramakrishnapallala/orgs","repos_url":"https://api.github.com/users/ramakrishnapallala/repos","events_url":"https://api.github.com/users/ramakrishnapallala/events{/privacy}","received_events_url":"https://api.github.com/users/ramakrishnapallala/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/8002/commits","review_comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/8002/comments","review_comment_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/8002/comments","statuses_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/ed97d8f2351a6908ac08211758dc3cd7ba62a0fc","head":{"label":"lemrey:flash-emulator","ref":"flash-emulator","sha":"ed97d8f2351a6908ac08211758dc3cd7ba62a0fc","user":{"login":"lemrey","id":1151289,"avatar_url":"https://avatars1.githubusercontent.com/u/1151289?v=4","gravatar_id":"","url":"https://api.github.com/users/lemrey","html_url":"https://github.com/lemrey","followers_url":"https://api.github.com/users/lemrey/followers","following_url":"https://api.github.com/users/lemrey/following{/other_user}","gists_url":"https://api.github.com/users/lemrey/gists{/gist_id}","starred_url":"https://api.github.com/users/lemrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lemrey/subscriptions","organizations_url":"https://api.github.com/users/lemrey/orgs","repos_url":"https://api.github.com/users/lemrey/repos","events_url":"https://api.github.com/users/lemrey/events{/privacy}","received_events_url":"https://api.github.com/users/lemrey/received_events","type":"User","site_admin":false},"repo":{"id":130826112,"name":"zephyr","full_name":"lemrey/zephyr","owner":{"login":"lemrey","id":1151289,"avatar_url":"https://avatars1.githubusercontent.com/u/1151289?v=4","gravatar_id":"","url":"https://api.github.com/users/lemrey","html_url":"https://github.com/lemrey","followers_url":"https://api.github.com/users/lemrey/followers","following_url":"https://api.github.com/users/lemrey/following{/other_user}","gists_url":"https://api.github.com/users/lemrey/gists{/gist_id}","starred_url":"https://api.github.com/users/lemrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lemrey/subscriptions","organizations_url":"https://api.github.com/users/lemrey/orgs","repos_url":"https://api.github.com/users/lemrey/repos","events_url":"https://api.github.com/users/lemrey/events{/privacy}","received_events_url":"https://api.github.com/users/lemrey/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lemrey/zephyr","description":"Primary GIT Repository for the Zephyr Project","fork":true,"url":"https://api.github.com/repos/lemrey/zephyr","forks_url":"https://api.github.com/repos/lemrey/zephyr/forks","keys_url":"https://api.github.com/repos/lemrey/zephyr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lemrey/zephyr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lemrey/zephyr/teams","hooks_url":"https://api.github.com/repos/lemrey/zephyr/hooks","issue_events_url":"https://api.github.com/repos/lemrey/zephyr/issues/events{/number}","events_url":"https://api.github.com/repos/lemrey/zephyr/events","assignees_url":"https://api.github.com/repos/lemrey/zephyr/assignees{/user}","branches_url":"https://api.github.com/repos/lemrey/zephyr/branches{/branch}","tags_url":"https://api.github.com/repos/lemrey/zephyr/tags","blobs_url":"https://api.github.com/repos/lemrey/zephyr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lemrey/zephyr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lemrey/zephyr/git/refs{/sha}","trees_url":"https://api.github.com/repos/lemrey/zephyr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lemrey/zephyr/statuses/{sha}","languages_url":"https://api.github.com/repos/lemrey/zephyr/languages","stargazers_url":"https://api.github.com/repos/lemrey/zephyr/stargazers","contributors_url":"https://api.github.com/repos/lemrey/zephyr/contributors","subscribers_url":"https://api.github.com/repos/lemrey/zephyr/subscribers","subscription_url":"https://api.github.com/repos/lemrey/zephyr/subscription","commits_url":"https://api.github.com/repos/lemrey/zephyr/commits{/sha}","git_commits_url":"https://api.github.com/repos/lemrey/zephyr/git/commits{/sha}","comments_url":"https://api.github.com/repos/lemrey/zephyr/comments{/number}","issue_comment_url":"https://api.github.com/repos/lemrey/zephyr/issues/comments{/number}","contents_url":"https://api.github.com/repos/lemrey/zephyr/contents/{+path}","compare_url":"https://api.github.com/repos/lemrey/zephyr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lemrey/zephyr/merges","archive_url":"https://api.github.com/repos/lemrey/zephyr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lemrey/zephyr/downloads","issues_url":"https://api.github.com/repos/lemrey/zephyr/issues{/number}","pulls_url":"https://api.github.com/repos/lemrey/zephyr/pulls{/number}","milestones_url":"https://api.github.com/repos/lemrey/zephyr/milestones{/number}","notifications_url":"https://api.github.com/repos/lemrey/zephyr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lemrey/zephyr/labels{/name}","releases_url":"https://api.github.com/repos/lemrey/zephyr/releases{/id}","deployments_url":"https://api.github.com/repos/lemrey/zephyr/deployments","created_at":"2018-04-24T09:01:04Z","updated_at":"2018-05-25T10:40:09Z","pushed_at":"2018-05-29T15:02:12Z","git_url":"git://github.com/lemrey/zephyr.git","ssh_url":"git@github.com:lemrey/zephyr.git","clone_url":"https://github.com/lemrey/zephyr.git","svn_url":"https://github.com/lemrey/zephyr","homepage":"https://zephyrproject.org/doc","size":111604,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"zephyrproject-rtos:master","ref":"master","sha":"8eb652bfd51fbda40e100896220bb0dc51976f9b","user":{"login":"zephyrproject-rtos","id":19595895,"avatar_url":"https://avatars2.githubusercontent.com/u/19595895?v=4","gravatar_id":"","url":"https://api.github.com/users/zephyrproject-rtos","html_url":"https://github.com/zephyrproject-rtos","followers_url":"https://api.github.com/users/zephyrproject-rtos/followers","following_url":"https://api.github.com/users/zephyrproject-rtos/following{/other_user}","gists_url":"https://api.github.com/users/zephyrproject-rtos/gists{/gist_id}","starred_url":"https://api.github.com/users/zephyrproject-rtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zephyrproject-rtos/subscriptions","organizations_url":"https://api.github.com/users/zephyrproject-rtos/orgs","repos_url":"https://api.github.com/users/zephyrproject-rtos/repos","events_url":"https://api.github.com/users/zephyrproject-rtos/events{/privacy}","received_events_url":"https://api.github.com/users/zephyrproject-rtos/received_events","type":"Organization","site_admin":false},"repo":{"id":59771425,"name":"zephyr","full_name":"zephyrproject-rtos/zephyr","owner":{"login":"zephyrproject-rtos","id":19595895,"avatar_url":"https://avatars2.githubusercontent.com/u/19595895?v=4","gravatar_id":"","url":"https://api.github.com/users/zephyrproject-rtos","html_url":"https://github.com/zephyrproject-rtos","followers_url":"https://api.github.com/users/zephyrproject-rtos/followers","following_url":"https://api.github.com/users/zephyrproject-rtos/following{/other_user}","gists_url":"https://api.github.com/users/zephyrproject-rtos/gists{/gist_id}","starred_url":"https://api.github.com/users/zephyrproject-rtos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zephyrproject-rtos/subscriptions","organizations_url":"https://api.github.com/users/zephyrproject-rtos/orgs","repos_url":"https://api.github.com/users/zephyrproject-rtos/repos","events_url":"https://api.github.com/users/zephyrproject-rtos/events{/privacy}","received_events_url":"https://api.github.com/users/zephyrproject-rtos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zephyrproject-rtos/zephyr","description":"Primary GIT Repository for the Zephyr Project","fork":false,"url":"https://api.github.com/repos/zephyrproject-rtos/zephyr","forks_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/forks","keys_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/teams","hooks_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/hooks","issue_events_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/events{/number}","events_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/events","assignees_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/assignees{/user}","branches_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/branches{/branch}","tags_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/tags","blobs_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/refs{/sha}","trees_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/{sha}","languages_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/languages","stargazers_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/stargazers","contributors_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/contributors","subscribers_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/subscribers","subscription_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/subscription","commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/commits{/sha}","git_commits_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/git/commits{/sha}","comments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/comments{/number}","issue_comment_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/comments{/number}","contents_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/contents/{+path}","compare_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/merges","archive_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/downloads","issues_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues{/number}","pulls_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls{/number}","milestones_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/milestones{/number}","notifications_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/labels{/name}","releases_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/releases{/id}","deployments_url":"https://api.github.com/repos/zephyrproject-rtos/zephyr/deployments","created_at":"2016-05-26T17:54:19Z","updated_at":"2018-05-29T14:46:56Z","pushed_at":"2018-05-29T15:00:03Z","git_url":"git://github.com/zephyrproject-rtos/zephyr.git","ssh_url":"git@github.com:zephyrproject-rtos/zephyr.git","clone_url":"https://github.com/zephyrproject-rtos/zephyr.git","svn_url":"https://github.com/zephyrproject-rtos/zephyr","homepage":"https://docs.zephyrproject.org","size":112155,"stargazers_count":870,"watchers_count":870,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":631,"mirror_url":null,"archived":false,"open_issues_count":911,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":631,"open_issues":911,"watchers":870,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/8002"},"html":{"href":"https://github.com/zephyrproject-rtos/zephyr/pull/8002"},"issue":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/8002"},"comments":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/issues/8002/comments"},"review_comments":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/8002/comments"},"review_comment":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/pulls/8002/commits"},"statuses":{"href":"https://api.github.com/repos/zephyrproject-rtos/zephyr/statuses/ed97d8f2351a6908ac08211758dc3cd7ba62a0fc"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"ulfalizer"}}