{"action":"created","issue":{"url":"https://api.github.com/repos/python-attrs/attrs/issues/288","repository_url":"https://api.github.com/repos/python-attrs/attrs","labels_url":"https://api.github.com/repos/python-attrs/attrs/issues/288/labels{/name}","comments_url":"https://api.github.com/repos/python-attrs/attrs/issues/288/comments","events_url":"https://api.github.com/repos/python-attrs/attrs/issues/288/events","html_url":"https://github.com/python-attrs/attrs/issues/288","id":272731300,"number":288,"title":"don't use __annotations__","user":{"login":"glyph","id":716529,"avatar_url":"https://avatars3.githubusercontent.com/u/716529?v=4","gravatar_id":"","url":"https://api.github.com/users/glyph","html_url":"https://github.com/glyph","followers_url":"https://api.github.com/users/glyph/followers","following_url":"https://api.github.com/users/glyph/following{/other_user}","gists_url":"https://api.github.com/users/glyph/gists{/gist_id}","starred_url":"https://api.github.com/users/glyph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/glyph/subscriptions","organizations_url":"https://api.github.com/users/glyph/orgs","repos_url":"https://api.github.com/users/glyph/repos","events_url":"https://api.github.com/users/glyph/events{/privacy}","received_events_url":"https://api.github.com/users/glyph/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":26,"created_at":"2017-11-09T21:32:18Z","updated_at":"2018-03-20T06:42:11Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"https://github.com/python-attrs/attrs/blob/aa501176fac1f12912f863fd2f5c4d1d08410322/src/attr/_make.py#L213 uses `__annotations__` \r\n\r\nHowever, it looks as though [an upcoming incompatible change to Python](https://github.com/python/typing/issues/400) will change `__annotations__` into a list of strings.\r\n\r\nIt seems like the correct public API to use to retrieve the information `attrs` wants would be [`get_type_hints`](https://docs.python.org/3.6/library/typing.html#typing.get_type_hints).\r\n\r\nAs a bonus, fixing this might make #265 easier to implement."},"comment":{"url":"https://api.github.com/repos/python-attrs/attrs/issues/comments/374492394","html_url":"https://github.com/python-attrs/attrs/issues/288#issuecomment-374492394","issue_url":"https://api.github.com/repos/python-attrs/attrs/issues/288","id":374492394,"user":{"login":"hynek","id":41240,"avatar_url":"https://avatars3.githubusercontent.com/u/41240?v=4","gravatar_id":"","url":"https://api.github.com/users/hynek","html_url":"https://github.com/hynek","followers_url":"https://api.github.com/users/hynek/followers","following_url":"https://api.github.com/users/hynek/following{/other_user}","gists_url":"https://api.github.com/users/hynek/gists{/gist_id}","starred_url":"https://api.github.com/users/hynek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hynek/subscriptions","organizations_url":"https://api.github.com/users/hynek/orgs","repos_url":"https://api.github.com/users/hynek/repos","events_url":"https://api.github.com/users/hynek/events{/privacy}","received_events_url":"https://api.github.com/users/hynek/received_events","type":"User","site_admin":false},"created_at":"2018-03-20T06:42:10Z","updated_at":"2018-03-20T06:42:10Z","author_association":"OWNER","body":"Just to circle back to this:\r\n\r\n> I believe the only thing we must do is make sure ClassVar works correctly.\r\n\r\nI *does* work correctly, right?\r\n\r\nSo what exactly is the plan for this issue? Anything left to be done or are we gonna keep using `__annotations__` until @ambv tells us to stop?"}}
{"actor":{"display_login":"hynek"}}