{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/openj9/pulls/comments/217453171","pull_request_review_id":155166782,"id":217453171,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzQ1MzE3MQ==","diff_hunk":"@@ -75,6 +78,11 @@ ifdef j9vm_uma_supportsIpv6\n   CPPFLAGS += -DIPv6_FUNCTION_SUPPORT\n endif\n \n+ifdef j9vm_uma_gnuDebugSymbols\n+CFLAGS+=-g\n+CXXFLAGS+=-g","path":"runtime/makelib/targets.mk.aix.inc.ftl","position":16,"original_position":16,"commit_id":"d75e7cd3381591366c0ade519abf90cd8e84f45b","original_commit_id":"d75e7cd3381591366c0ade519abf90cd8e84f45b","user":{"login":"keithc-ca","id":17774687,"node_id":"MDQ6VXNlcjE3Nzc0Njg3","avatar_url":"https://avatars1.githubusercontent.com/u/17774687?v=4","gravatar_id":"","url":"https://api.github.com/users/keithc-ca","html_url":"https://github.com/keithc-ca","followers_url":"https://api.github.com/users/keithc-ca/followers","following_url":"https://api.github.com/users/keithc-ca/following{/other_user}","gists_url":"https://api.github.com/users/keithc-ca/gists{/gist_id}","starred_url":"https://api.github.com/users/keithc-ca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keithc-ca/subscriptions","organizations_url":"https://api.github.com/users/keithc-ca/orgs","repos_url":"https://api.github.com/users/keithc-ca/repos","events_url":"https://api.github.com/users/keithc-ca/events{/privacy}","received_events_url":"https://api.github.com/users/keithc-ca/received_events","type":"User","site_admin":false},"body":"Please use spaces around `+=` for consistency with the rest of this file.","created_at":"2018-09-13T16:33:59Z","updated_at":"2018-09-13T16:47:35Z","html_url":"https://github.com/eclipse/openj9/pull/2309#discussion_r217453171","pull_request_url":"https://api.github.com/repos/eclipse/openj9/pulls/2309","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/comments/217453171"},"html":{"href":"https://github.com/eclipse/openj9/pull/2309#discussion_r217453171"},"pull_request":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/2309"}}},"pull_request":{"url":"https://api.github.com/repos/eclipse/openj9/pulls/2309","id":198401310,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NDAxMzEw","html_url":"https://github.com/eclipse/openj9/pull/2309","diff_url":"https://github.com/eclipse/openj9/pull/2309.diff","patch_url":"https://github.com/eclipse/openj9/pull/2309.patch","issue_url":"https://api.github.com/repos/eclipse/openj9/issues/2309","number":2309,"state":"open","locked":false,"title":"Bring up DDR on AIX","user":{"login":"mikezhang1234567890","id":32070971,"node_id":"MDQ6VXNlcjMyMDcwOTcx","avatar_url":"https://avatars3.githubusercontent.com/u/32070971?v=4","gravatar_id":"","url":"https://api.github.com/users/mikezhang1234567890","html_url":"https://github.com/mikezhang1234567890","followers_url":"https://api.github.com/users/mikezhang1234567890/followers","following_url":"https://api.github.com/users/mikezhang1234567890/following{/other_user}","gists_url":"https://api.github.com/users/mikezhang1234567890/gists{/gist_id}","starred_url":"https://api.github.com/users/mikezhang1234567890/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikezhang1234567890/subscriptions","organizations_url":"https://api.github.com/users/mikezhang1234567890/orgs","repos_url":"https://api.github.com/users/mikezhang1234567890/repos","events_url":"https://api.github.com/users/mikezhang1234567890/events{/privacy}","received_events_url":"https://api.github.com/users/mikezhang1234567890/received_events","type":"User","site_admin":false},"body":"This pull request, in conjunction with the corresponding OMR pull request #[2719](https://github.com/eclipse/omr/pull/2719), enables DDR on AIX as well as the DDR tests on AIX, addressing #1769.\r\n\r\nTesting was done by generating core dumps and using `jdmpview` to run various commands on them on AIX. Also ran the OpenJ9 functional test suite locally. \r\n\r\nThe OMR PR should be merged before this one.\r\n","created_at":"2018-06-29T19:12:39Z","updated_at":"2018-09-13T16:47:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dbaf0fbb93342fd9f00e7148d0570929ce166204","assignee":{"login":"keithc-ca","id":17774687,"node_id":"MDQ6VXNlcjE3Nzc0Njg3","avatar_url":"https://avatars1.githubusercontent.com/u/17774687?v=4","gravatar_id":"","url":"https://api.github.com/users/keithc-ca","html_url":"https://github.com/keithc-ca","followers_url":"https://api.github.com/users/keithc-ca/followers","following_url":"https://api.github.com/users/keithc-ca/following{/other_user}","gists_url":"https://api.github.com/users/keithc-ca/gists{/gist_id}","starred_url":"https://api.github.com/users/keithc-ca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keithc-ca/subscriptions","organizations_url":"https://api.github.com/users/keithc-ca/orgs","repos_url":"https://api.github.com/users/keithc-ca/repos","events_url":"https://api.github.com/users/keithc-ca/events{/privacy}","received_events_url":"https://api.github.com/users/keithc-ca/received_events","type":"User","site_admin":false},"assignees":[{"login":"keithc-ca","id":17774687,"node_id":"MDQ6VXNlcjE3Nzc0Njg3","avatar_url":"https://avatars1.githubusercontent.com/u/17774687?v=4","gravatar_id":"","url":"https://api.github.com/users/keithc-ca","html_url":"https://github.com/keithc-ca","followers_url":"https://api.github.com/users/keithc-ca/followers","following_url":"https://api.github.com/users/keithc-ca/following{/other_user}","gists_url":"https://api.github.com/users/keithc-ca/gists{/gist_id}","starred_url":"https://api.github.com/users/keithc-ca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keithc-ca/subscriptions","organizations_url":"https://api.github.com/users/keithc-ca/orgs","repos_url":"https://api.github.com/users/keithc-ca/repos","events_url":"https://api.github.com/users/keithc-ca/events{/privacy}","received_events_url":"https://api.github.com/users/keithc-ca/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":697962110,"node_id":"MDU6TGFiZWw2OTc5NjIxMTA=","url":"https://api.github.com/repos/eclipse/openj9/labels/comp:vm","name":"comp:vm","color":"1d76db","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/openj9/pulls/2309/commits","review_comments_url":"https://api.github.com/repos/eclipse/openj9/pulls/2309/comments","review_comment_url":"https://api.github.com/repos/eclipse/openj9/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/openj9/issues/2309/comments","statuses_url":"https://api.github.com/repos/eclipse/openj9/statuses/d75e7cd3381591366c0ade519abf90cd8e84f45b","head":{"label":"mikezhang1234567890:aix-ddr","ref":"aix-ddr","sha":"d75e7cd3381591366c0ade519abf90cd8e84f45b","user":{"login":"mikezhang1234567890","id":32070971,"node_id":"MDQ6VXNlcjMyMDcwOTcx","avatar_url":"https://avatars3.githubusercontent.com/u/32070971?v=4","gravatar_id":"","url":"https://api.github.com/users/mikezhang1234567890","html_url":"https://github.com/mikezhang1234567890","followers_url":"https://api.github.com/users/mikezhang1234567890/followers","following_url":"https://api.github.com/users/mikezhang1234567890/following{/other_user}","gists_url":"https://api.github.com/users/mikezhang1234567890/gists{/gist_id}","starred_url":"https://api.github.com/users/mikezhang1234567890/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikezhang1234567890/subscriptions","organizations_url":"https://api.github.com/users/mikezhang1234567890/orgs","repos_url":"https://api.github.com/users/mikezhang1234567890/repos","events_url":"https://api.github.com/users/mikezhang1234567890/events{/privacy}","received_events_url":"https://api.github.com/users/mikezhang1234567890/received_events","type":"User","site_admin":false},"repo":{"id":104227922,"node_id":"MDEwOlJlcG9zaXRvcnkxMDQyMjc5MjI=","name":"openj9","full_name":"mikezhang1234567890/openj9","owner":{"login":"mikezhang1234567890","id":32070971,"node_id":"MDQ6VXNlcjMyMDcwOTcx","avatar_url":"https://avatars3.githubusercontent.com/u/32070971?v=4","gravatar_id":"","url":"https://api.github.com/users/mikezhang1234567890","html_url":"https://github.com/mikezhang1234567890","followers_url":"https://api.github.com/users/mikezhang1234567890/followers","following_url":"https://api.github.com/users/mikezhang1234567890/following{/other_user}","gists_url":"https://api.github.com/users/mikezhang1234567890/gists{/gist_id}","starred_url":"https://api.github.com/users/mikezhang1234567890/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikezhang1234567890/subscriptions","organizations_url":"https://api.github.com/users/mikezhang1234567890/orgs","repos_url":"https://api.github.com/users/mikezhang1234567890/repos","events_url":"https://api.github.com/users/mikezhang1234567890/events{/privacy}","received_events_url":"https://api.github.com/users/mikezhang1234567890/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mikezhang1234567890/openj9","description":"Eclipse OpenJ9","fork":true,"url":"https://api.github.com/repos/mikezhang1234567890/openj9","forks_url":"https://api.github.com/repos/mikezhang1234567890/openj9/forks","keys_url":"https://api.github.com/repos/mikezhang1234567890/openj9/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mikezhang1234567890/openj9/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mikezhang1234567890/openj9/teams","hooks_url":"https://api.github.com/repos/mikezhang1234567890/openj9/hooks","issue_events_url":"https://api.github.com/repos/mikezhang1234567890/openj9/issues/events{/number}","events_url":"https://api.github.com/repos/mikezhang1234567890/openj9/events","assignees_url":"https://api.github.com/repos/mikezhang1234567890/openj9/assignees{/user}","branches_url":"https://api.github.com/repos/mikezhang1234567890/openj9/branches{/branch}","tags_url":"https://api.github.com/repos/mikezhang1234567890/openj9/tags","blobs_url":"https://api.github.com/repos/mikezhang1234567890/openj9/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mikezhang1234567890/openj9/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mikezhang1234567890/openj9/git/refs{/sha}","trees_url":"https://api.github.com/repos/mikezhang1234567890/openj9/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mikezhang1234567890/openj9/statuses/{sha}","languages_url":"https://api.github.com/repos/mikezhang1234567890/openj9/languages","stargazers_url":"https://api.github.com/repos/mikezhang1234567890/openj9/stargazers","contributors_url":"https://api.github.com/repos/mikezhang1234567890/openj9/contributors","subscribers_url":"https://api.github.com/repos/mikezhang1234567890/openj9/subscribers","subscription_url":"https://api.github.com/repos/mikezhang1234567890/openj9/subscription","commits_url":"https://api.github.com/repos/mikezhang1234567890/openj9/commits{/sha}","git_commits_url":"https://api.github.com/repos/mikezhang1234567890/openj9/git/commits{/sha}","comments_url":"https://api.github.com/repos/mikezhang1234567890/openj9/comments{/number}","issue_comment_url":"https://api.github.com/repos/mikezhang1234567890/openj9/issues/comments{/number}","contents_url":"https://api.github.com/repos/mikezhang1234567890/openj9/contents/{+path}","compare_url":"https://api.github.com/repos/mikezhang1234567890/openj9/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mikezhang1234567890/openj9/merges","archive_url":"https://api.github.com/repos/mikezhang1234567890/openj9/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mikezhang1234567890/openj9/downloads","issues_url":"https://api.github.com/repos/mikezhang1234567890/openj9/issues{/number}","pulls_url":"https://api.github.com/repos/mikezhang1234567890/openj9/pulls{/number}","milestones_url":"https://api.github.com/repos/mikezhang1234567890/openj9/milestones{/number}","notifications_url":"https://api.github.com/repos/mikezhang1234567890/openj9/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mikezhang1234567890/openj9/labels{/name}","releases_url":"https://api.github.com/repos/mikezhang1234567890/openj9/releases{/id}","deployments_url":"https://api.github.com/repos/mikezhang1234567890/openj9/deployments","created_at":"2017-09-20T14:42:12Z","updated_at":"2018-09-13T15:28:24Z","pushed_at":"2018-09-13T15:28:21Z","git_url":"git://github.com/mikezhang1234567890/openj9.git","ssh_url":"git@github.com:mikezhang1234567890/openj9.git","clone_url":"https://github.com/mikezhang1234567890/openj9.git","svn_url":"https://github.com/mikezhang1234567890/openj9","homepage":"","size":34064,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"103895a1a6c18296756581c3c9d1fb2ebd75b965","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":101408117,"node_id":"MDEwOlJlcG9zaXRvcnkxMDE0MDgxMTc=","name":"openj9","full_name":"eclipse/openj9","owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/openj9","description":"Eclipse OpenJ9: A Java Virtual Machine for OpenJDK that's optimized for small footprint, fast start-up, and high throughput.   Builds on Eclipse OMR (https://github.com/eclipse/omr) and combines with the Extensions for OpenJDK for OpenJ9 repo.","fork":false,"url":"https://api.github.com/repos/eclipse/openj9","forks_url":"https://api.github.com/repos/eclipse/openj9/forks","keys_url":"https://api.github.com/repos/eclipse/openj9/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/openj9/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/openj9/teams","hooks_url":"https://api.github.com/repos/eclipse/openj9/hooks","issue_events_url":"https://api.github.com/repos/eclipse/openj9/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/openj9/events","assignees_url":"https://api.github.com/repos/eclipse/openj9/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/openj9/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/openj9/tags","blobs_url":"https://api.github.com/repos/eclipse/openj9/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/openj9/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/openj9/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/openj9/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/openj9/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/openj9/languages","stargazers_url":"https://api.github.com/repos/eclipse/openj9/stargazers","contributors_url":"https://api.github.com/repos/eclipse/openj9/contributors","subscribers_url":"https://api.github.com/repos/eclipse/openj9/subscribers","subscription_url":"https://api.github.com/repos/eclipse/openj9/subscription","commits_url":"https://api.github.com/repos/eclipse/openj9/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/openj9/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/openj9/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/openj9/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/openj9/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/openj9/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/openj9/merges","archive_url":"https://api.github.com/repos/eclipse/openj9/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/openj9/downloads","issues_url":"https://api.github.com/repos/eclipse/openj9/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/openj9/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/openj9/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/openj9/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/openj9/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/openj9/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/openj9/deployments","created_at":"2017-08-25T13:46:07Z","updated_at":"2018-09-13T15:28:20Z","pushed_at":"2018-09-13T16:35:34Z","git_url":"git://github.com/eclipse/openj9.git","ssh_url":"git@github.com:eclipse/openj9.git","clone_url":"https://github.com/eclipse/openj9.git","svn_url":"https://github.com/eclipse/openj9","homepage":"","size":34069,"stargazers_count":1405,"watchers_count":1405,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":276,"mirror_url":null,"archived":false,"open_issues_count":459,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":276,"open_issues":459,"watchers":1405,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/2309"},"html":{"href":"https://github.com/eclipse/openj9/pull/2309"},"issue":{"href":"https://api.github.com/repos/eclipse/openj9/issues/2309"},"comments":{"href":"https://api.github.com/repos/eclipse/openj9/issues/2309/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/2309/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/2309/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/openj9/statuses/d75e7cd3381591366c0ade519abf90cd8e84f45b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"keithc-ca"}}