{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/zstd/pulls/comments/210138800","pull_request_review_id":146293218,"id":210138800,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDEzODgwMA==","diff_hunk":"@@ -113,14 +113,15 @@ Full list of arguments\n     dSpeed=   : Minimum decompression speed\n     cMem=     : Maximum compression memory\n     lvl=      : Searches for solutions which are strictly better than that compression lvl in ratio and cSpeed, \n-    stc=      : When invoked with lvl=, represents percentage slack in ratio/cSpeed allowed for a solution to be considered (Default 99%)\n+    stc=      : When invoked with lvl=, represents percentage slack in ratio/cSpeed allowed for a solution to be considered (Default 100%)\n               : In normal operation, represents percentage slack in choosing viable starting strategy selection in choosing the default parameters\n                 (Lower value will begin with stronger strategies) (Default 90%)\n-    preferSpeed= / preferRatio=\n-              : Only affects lvl = invocations. Defines value placed on compression speed or ratio\n-                when determining overall winner (default speed = 1, ratio = 5 for both, higher = more valued).\n+    ratioSpeedTradeoff=#:#","path":"tests/README.md","position":11,"original_position":11,"commit_id":"e7b9252b89cf751358c4edb7c27a4dd9dda3d05b","original_commit_id":"e7b9252b89cf751358c4edb7c27a4dd9dda3d05b","user":{"login":"Cyan4973","id":750081,"node_id":"MDQ6VXNlcjc1MDA4MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/750081?v=4","gravatar_id":"","url":"https://api.github.com/users/Cyan4973","html_url":"https://github.com/Cyan4973","followers_url":"https://api.github.com/users/Cyan4973/followers","following_url":"https://api.github.com/users/Cyan4973/following{/other_user}","gists_url":"https://api.github.com/users/Cyan4973/gists{/gist_id}","starred_url":"https://api.github.com/users/Cyan4973/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Cyan4973/subscriptions","organizations_url":"https://api.github.com/users/Cyan4973/orgs","repos_url":"https://api.github.com/users/Cyan4973/repos","events_url":"https://api.github.com/users/Cyan4973/events{/privacy}","received_events_url":"https://api.github.com/users/Cyan4973/received_events","type":"User","site_admin":false},"body":"I would simplify this setting to a single value `speedRatio=#`,\r\nwhich would effectively be the same as `preferRatio=#` and pin `preferSpeed` to `1`.\r\n\r\nShould you worry about a potential lack of available values at lower ranges (1,2,3, etc.),\r\nyou may allow fractional values.\r\n\r\nAlso : pay attention to value `0` : what does it mean ? how is it handled ?","created_at":"2018-08-14T23:51:55Z","updated_at":"2018-08-14T23:51:55Z","html_url":"https://github.com/facebook/zstd/pull/1277#discussion_r210138800","pull_request_url":"https://api.github.com/repos/facebook/zstd/pulls/1277","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/facebook/zstd/pulls/comments/210138800"},"html":{"href":"https://github.com/facebook/zstd/pull/1277#discussion_r210138800"},"pull_request":{"href":"https://api.github.com/repos/facebook/zstd/pulls/1277"}}},"pull_request":{"url":"https://api.github.com/repos/facebook/zstd/pulls/1277","id":208137310,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MTM3MzEw","html_url":"https://github.com/facebook/zstd/pull/1277","diff_url":"https://github.com/facebook/zstd/pull/1277.diff","patch_url":"https://github.com/facebook/zstd/pull/1277.patch","issue_url":"https://api.github.com/repos/facebook/zstd/issues/1277","number":1277,"state":"open","locked":false,"title":"memoTableOptions","user":{"login":"GeorgeLu97","id":7918209,"node_id":"MDQ6VXNlcjc5MTgyMDk=","avatar_url":"https://avatars0.githubusercontent.com/u/7918209?v=4","gravatar_id":"","url":"https://api.github.com/users/GeorgeLu97","html_url":"https://github.com/GeorgeLu97","followers_url":"https://api.github.com/users/GeorgeLu97/followers","following_url":"https://api.github.com/users/GeorgeLu97/following{/other_user}","gists_url":"https://api.github.com/users/GeorgeLu97/gists{/gist_id}","starred_url":"https://api.github.com/users/GeorgeLu97/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeorgeLu97/subscriptions","organizations_url":"https://api.github.com/users/GeorgeLu97/orgs","repos_url":"https://api.github.com/users/GeorgeLu97/repos","events_url":"https://api.github.com/users/GeorgeLu97/events{/privacy}","received_events_url":"https://api.github.com/users/GeorgeLu97/received_events","type":"User","site_admin":false},"body":"Based on forceAttachDict (Last 3 commits new)\r\n\r\nSimplify adding new params\r\nAdd option for memoization table to be hash table or to be turned off altogether\r\nChange format of speed/ratio tradeoff on command line","created_at":"2018-08-14T00:12:31Z","updated_at":"2018-08-14T23:51:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3360fe8ff701ca74c1977b4805bd7b8b155fc89d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":442840858,"node_id":"MDU6TGFiZWw0NDI4NDA4NTg=","url":"https://api.github.com/repos/facebook/zstd/labels/CLA%20Signed","name":"CLA Signed","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/zstd/pulls/1277/commits","review_comments_url":"https://api.github.com/repos/facebook/zstd/pulls/1277/comments","review_comment_url":"https://api.github.com/repos/facebook/zstd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/zstd/issues/1277/comments","statuses_url":"https://api.github.com/repos/facebook/zstd/statuses/e7b9252b89cf751358c4edb7c27a4dd9dda3d05b","head":{"label":"GeorgeLu97:mtoptions","ref":"mtoptions","sha":"e7b9252b89cf751358c4edb7c27a4dd9dda3d05b","user":{"login":"GeorgeLu97","id":7918209,"node_id":"MDQ6VXNlcjc5MTgyMDk=","avatar_url":"https://avatars0.githubusercontent.com/u/7918209?v=4","gravatar_id":"","url":"https://api.github.com/users/GeorgeLu97","html_url":"https://github.com/GeorgeLu97","followers_url":"https://api.github.com/users/GeorgeLu97/followers","following_url":"https://api.github.com/users/GeorgeLu97/following{/other_user}","gists_url":"https://api.github.com/users/GeorgeLu97/gists{/gist_id}","starred_url":"https://api.github.com/users/GeorgeLu97/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeorgeLu97/subscriptions","organizations_url":"https://api.github.com/users/GeorgeLu97/orgs","repos_url":"https://api.github.com/users/GeorgeLu97/repos","events_url":"https://api.github.com/users/GeorgeLu97/events{/privacy}","received_events_url":"https://api.github.com/users/GeorgeLu97/received_events","type":"User","site_admin":false},"repo":{"id":135644521,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU2NDQ1MjE=","name":"zstd","full_name":"GeorgeLu97/zstd","owner":{"login":"GeorgeLu97","id":7918209,"node_id":"MDQ6VXNlcjc5MTgyMDk=","avatar_url":"https://avatars0.githubusercontent.com/u/7918209?v=4","gravatar_id":"","url":"https://api.github.com/users/GeorgeLu97","html_url":"https://github.com/GeorgeLu97","followers_url":"https://api.github.com/users/GeorgeLu97/followers","following_url":"https://api.github.com/users/GeorgeLu97/following{/other_user}","gists_url":"https://api.github.com/users/GeorgeLu97/gists{/gist_id}","starred_url":"https://api.github.com/users/GeorgeLu97/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GeorgeLu97/subscriptions","organizations_url":"https://api.github.com/users/GeorgeLu97/orgs","repos_url":"https://api.github.com/users/GeorgeLu97/repos","events_url":"https://api.github.com/users/GeorgeLu97/events{/privacy}","received_events_url":"https://api.github.com/users/GeorgeLu97/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/GeorgeLu97/zstd","description":"Zstandard - Fast real-time compression algorithm","fork":true,"url":"https://api.github.com/repos/GeorgeLu97/zstd","forks_url":"https://api.github.com/repos/GeorgeLu97/zstd/forks","keys_url":"https://api.github.com/repos/GeorgeLu97/zstd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GeorgeLu97/zstd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GeorgeLu97/zstd/teams","hooks_url":"https://api.github.com/repos/GeorgeLu97/zstd/hooks","issue_events_url":"https://api.github.com/repos/GeorgeLu97/zstd/issues/events{/number}","events_url":"https://api.github.com/repos/GeorgeLu97/zstd/events","assignees_url":"https://api.github.com/repos/GeorgeLu97/zstd/assignees{/user}","branches_url":"https://api.github.com/repos/GeorgeLu97/zstd/branches{/branch}","tags_url":"https://api.github.com/repos/GeorgeLu97/zstd/tags","blobs_url":"https://api.github.com/repos/GeorgeLu97/zstd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GeorgeLu97/zstd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GeorgeLu97/zstd/git/refs{/sha}","trees_url":"https://api.github.com/repos/GeorgeLu97/zstd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GeorgeLu97/zstd/statuses/{sha}","languages_url":"https://api.github.com/repos/GeorgeLu97/zstd/languages","stargazers_url":"https://api.github.com/repos/GeorgeLu97/zstd/stargazers","contributors_url":"https://api.github.com/repos/GeorgeLu97/zstd/contributors","subscribers_url":"https://api.github.com/repos/GeorgeLu97/zstd/subscribers","subscription_url":"https://api.github.com/repos/GeorgeLu97/zstd/subscription","commits_url":"https://api.github.com/repos/GeorgeLu97/zstd/commits{/sha}","git_commits_url":"https://api.github.com/repos/GeorgeLu97/zstd/git/commits{/sha}","comments_url":"https://api.github.com/repos/GeorgeLu97/zstd/comments{/number}","issue_comment_url":"https://api.github.com/repos/GeorgeLu97/zstd/issues/comments{/number}","contents_url":"https://api.github.com/repos/GeorgeLu97/zstd/contents/{+path}","compare_url":"https://api.github.com/repos/GeorgeLu97/zstd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GeorgeLu97/zstd/merges","archive_url":"https://api.github.com/repos/GeorgeLu97/zstd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GeorgeLu97/zstd/downloads","issues_url":"https://api.github.com/repos/GeorgeLu97/zstd/issues{/number}","pulls_url":"https://api.github.com/repos/GeorgeLu97/zstd/pulls{/number}","milestones_url":"https://api.github.com/repos/GeorgeLu97/zstd/milestones{/number}","notifications_url":"https://api.github.com/repos/GeorgeLu97/zstd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GeorgeLu97/zstd/labels{/name}","releases_url":"https://api.github.com/repos/GeorgeLu97/zstd/releases{/id}","deployments_url":"https://api.github.com/repos/GeorgeLu97/zstd/deployments","created_at":"2018-05-31T23:22:52Z","updated_at":"2018-05-31T23:22:56Z","pushed_at":"2018-08-14T23:51:46Z","git_url":"git://github.com/GeorgeLu97/zstd.git","ssh_url":"git@github.com:GeorgeLu97/zstd.git","clone_url":"https://github.com/GeorgeLu97/zstd.git","svn_url":"https://github.com/GeorgeLu97/zstd","homepage":"http://www.zstd.net","size":15303,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"facebook:dev","ref":"dev","sha":"0c9772b0841d6a05c6a7696e7b770e00217c3c99","user":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":29759715,"node_id":"MDEwOlJlcG9zaXRvcnkyOTc1OTcxNQ==","name":"zstd","full_name":"facebook/zstd","owner":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/zstd","description":"Zstandard - Fast real-time compression algorithm","fork":false,"url":"https://api.github.com/repos/facebook/zstd","forks_url":"https://api.github.com/repos/facebook/zstd/forks","keys_url":"https://api.github.com/repos/facebook/zstd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/zstd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/zstd/teams","hooks_url":"https://api.github.com/repos/facebook/zstd/hooks","issue_events_url":"https://api.github.com/repos/facebook/zstd/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/zstd/events","assignees_url":"https://api.github.com/repos/facebook/zstd/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/zstd/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/zstd/tags","blobs_url":"https://api.github.com/repos/facebook/zstd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/zstd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/zstd/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/zstd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/zstd/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/zstd/languages","stargazers_url":"https://api.github.com/repos/facebook/zstd/stargazers","contributors_url":"https://api.github.com/repos/facebook/zstd/contributors","subscribers_url":"https://api.github.com/repos/facebook/zstd/subscribers","subscription_url":"https://api.github.com/repos/facebook/zstd/subscription","commits_url":"https://api.github.com/repos/facebook/zstd/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/zstd/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/zstd/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/zstd/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/zstd/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/zstd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/zstd/merges","archive_url":"https://api.github.com/repos/facebook/zstd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/zstd/downloads","issues_url":"https://api.github.com/repos/facebook/zstd/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/zstd/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/zstd/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/zstd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/zstd/labels{/name}","releases_url":"https://api.github.com/repos/facebook/zstd/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/zstd/deployments","created_at":"2015-01-24T00:22:38Z","updated_at":"2018-08-14T23:44:31Z","pushed_at":"2018-08-14T23:44:29Z","git_url":"git://github.com/facebook/zstd.git","ssh_url":"git@github.com:facebook/zstd.git","clone_url":"https://github.com/facebook/zstd.git","svn_url":"https://github.com/facebook/zstd","homepage":"http://www.zstd.net","size":15269,"stargazers_count":7691,"watchers_count":7691,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":679,"mirror_url":null,"archived":false,"open_issues_count":34,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":679,"open_issues":34,"watchers":7691,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/zstd/pulls/1277"},"html":{"href":"https://github.com/facebook/zstd/pull/1277"},"issue":{"href":"https://api.github.com/repos/facebook/zstd/issues/1277"},"comments":{"href":"https://api.github.com/repos/facebook/zstd/issues/1277/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/zstd/pulls/1277/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/zstd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/zstd/pulls/1277/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/zstd/statuses/e7b9252b89cf751358c4edb7c27a4dd9dda3d05b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Cyan4973"}}