{"action":"created","comment":{"url":"https://api.github.com/repos/ORNL-CEES/mfmg/pulls/comments/174630856","pull_request_review_id":104021045,"id":174630856,"diff_hunk":"@@ -38,9 +43,10 @@ class Laplace\n public:\n   Laplace(MPI_Comm const &comm, unsigned int fe_degree);\n \n-  void setup_system(int num_refinements = 3);\n+  void setup_system(boost::property_tree::ptree const ptree);","path":"tests/laplace.hpp","position":29,"original_position":29,"commit_id":"0f129503ee1bbe091d7413c616772ca6ab09472b","original_commit_id":"0f129503ee1bbe091d7413c616772ca6ab09472b","user":{"login":"aprokop","id":7297887,"avatar_url":"https://avatars1.githubusercontent.com/u/7297887?v=4","gravatar_id":"","url":"https://api.github.com/users/aprokop","html_url":"https://github.com/aprokop","followers_url":"https://api.github.com/users/aprokop/followers","following_url":"https://api.github.com/users/aprokop/following{/other_user}","gists_url":"https://api.github.com/users/aprokop/gists{/gist_id}","starred_url":"https://api.github.com/users/aprokop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aprokop/subscriptions","organizations_url":"https://api.github.com/users/aprokop/orgs","repos_url":"https://api.github.com/users/aprokop/repos","events_url":"https://api.github.com/users/aprokop/events{/privacy}","received_events_url":"https://api.github.com/users/aprokop/received_events","type":"User","site_admin":false},"body":"Would it not be better to add parameters to the constructor arguments, store them and then use for `setup_system` and `assemble_system`?","created_at":"2018-03-14T22:34:08Z","updated_at":"2018-03-14T22:41:31Z","html_url":"https://github.com/ORNL-CEES/mfmg/pull/38#discussion_r174630856","pull_request_url":"https://api.github.com/repos/ORNL-CEES/mfmg/pulls/38","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ORNL-CEES/mfmg/pulls/comments/174630856"},"html":{"href":"https://github.com/ORNL-CEES/mfmg/pull/38#discussion_r174630856"},"pull_request":{"href":"https://api.github.com/repos/ORNL-CEES/mfmg/pulls/38"}}},"pull_request":{"url":"https://api.github.com/repos/ORNL-CEES/mfmg/pulls/38","id":174976799,"html_url":"https://github.com/ORNL-CEES/mfmg/pull/38","diff_url":"https://github.com/ORNL-CEES/mfmg/pull/38.diff","patch_url":"https://github.com/ORNL-CEES/mfmg/pull/38.patch","issue_url":"https://api.github.com/repos/ORNL-CEES/mfmg/issues/38","number":38,"state":"open","locked":false,"title":"[WIP] Add support for more geometries","user":{"login":"Rombur","id":368538,"avatar_url":"https://avatars3.githubusercontent.com/u/368538?v=4","gravatar_id":"","url":"https://api.github.com/users/Rombur","html_url":"https://github.com/Rombur","followers_url":"https://api.github.com/users/Rombur/followers","following_url":"https://api.github.com/users/Rombur/following{/other_user}","gists_url":"https://api.github.com/users/Rombur/gists{/gist_id}","starred_url":"https://api.github.com/users/Rombur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rombur/subscriptions","organizations_url":"https://api.github.com/users/Rombur/orgs","repos_url":"https://api.github.com/users/Rombur/repos","events_url":"https://api.github.com/users/Rombur/events{/privacy}","received_events_url":"https://api.github.com/users/Rombur/received_events","type":"User","site_admin":false},"body":"\r\n\r\nThis add  support  for lapack so that we can switch betwen lapack and arpack to compute the eigenvalues. The advantage of lapack is that we don't require to invert the local system which means there is no problem when the local system is singular (e.g. Laplace without boundary condition). Also add support for hyper_ball and meshes which vertices are randomly moved.\r\n\r\nStill missing a test case.\r\n\r\nExample of new mesh (interior cells are distorted in purpose)\r\n![distorted_disc](https://user-images.githubusercontent.com/368538/37412035-90eb5cd2-277a-11e8-8d39-787e31456ee7.png)","created_at":"2018-03-14T14:40:32Z","updated_at":"2018-03-14T22:41:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4a5a31fb0147c3a096eaf52a0f37d70c84f1b6c7","assignee":{"login":"Rombur","id":368538,"avatar_url":"https://avatars3.githubusercontent.com/u/368538?v=4","gravatar_id":"","url":"https://api.github.com/users/Rombur","html_url":"https://github.com/Rombur","followers_url":"https://api.github.com/users/Rombur/followers","following_url":"https://api.github.com/users/Rombur/following{/other_user}","gists_url":"https://api.github.com/users/Rombur/gists{/gist_id}","starred_url":"https://api.github.com/users/Rombur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rombur/subscriptions","organizations_url":"https://api.github.com/users/Rombur/orgs","repos_url":"https://api.github.com/users/Rombur/repos","events_url":"https://api.github.com/users/Rombur/events{/privacy}","received_events_url":"https://api.github.com/users/Rombur/received_events","type":"User","site_admin":false},"assignees":[{"login":"Rombur","id":368538,"avatar_url":"https://avatars3.githubusercontent.com/u/368538?v=4","gravatar_id":"","url":"https://api.github.com/users/Rombur","html_url":"https://github.com/Rombur","followers_url":"https://api.github.com/users/Rombur/followers","following_url":"https://api.github.com/users/Rombur/following{/other_user}","gists_url":"https://api.github.com/users/Rombur/gists{/gist_id}","starred_url":"https://api.github.com/users/Rombur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rombur/subscriptions","organizations_url":"https://api.github.com/users/Rombur/orgs","repos_url":"https://api.github.com/users/Rombur/repos","events_url":"https://api.github.com/users/Rombur/events{/privacy}","received_events_url":"https://api.github.com/users/Rombur/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":751568496,"url":"https://api.github.com/repos/ORNL-CEES/mfmg/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ORNL-CEES/mfmg/pulls/38/commits","review_comments_url":"https://api.github.com/repos/ORNL-CEES/mfmg/pulls/38/comments","review_comment_url":"https://api.github.com/repos/ORNL-CEES/mfmg/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ORNL-CEES/mfmg/issues/38/comments","statuses_url":"https://api.github.com/repos/ORNL-CEES/mfmg/statuses/0f129503ee1bbe091d7413c616772ca6ab09472b","head":{"label":"Rombur:milestone","ref":"milestone","sha":"0f129503ee1bbe091d7413c616772ca6ab09472b","user":{"login":"Rombur","id":368538,"avatar_url":"https://avatars3.githubusercontent.com/u/368538?v=4","gravatar_id":"","url":"https://api.github.com/users/Rombur","html_url":"https://github.com/Rombur","followers_url":"https://api.github.com/users/Rombur/followers","following_url":"https://api.github.com/users/Rombur/following{/other_user}","gists_url":"https://api.github.com/users/Rombur/gists{/gist_id}","starred_url":"https://api.github.com/users/Rombur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rombur/subscriptions","organizations_url":"https://api.github.com/users/Rombur/orgs","repos_url":"https://api.github.com/users/Rombur/repos","events_url":"https://api.github.com/users/Rombur/events{/privacy}","received_events_url":"https://api.github.com/users/Rombur/received_events","type":"User","site_admin":false},"repo":{"id":109394387,"name":"mfmg","full_name":"Rombur/mfmg","owner":{"login":"Rombur","id":368538,"avatar_url":"https://avatars3.githubusercontent.com/u/368538?v=4","gravatar_id":"","url":"https://api.github.com/users/Rombur","html_url":"https://github.com/Rombur","followers_url":"https://api.github.com/users/Rombur/followers","following_url":"https://api.github.com/users/Rombur/following{/other_user}","gists_url":"https://api.github.com/users/Rombur/gists{/gist_id}","starred_url":"https://api.github.com/users/Rombur/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Rombur/subscriptions","organizations_url":"https://api.github.com/users/Rombur/orgs","repos_url":"https://api.github.com/users/Rombur/repos","events_url":"https://api.github.com/users/Rombur/events{/privacy}","received_events_url":"https://api.github.com/users/Rombur/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Rombur/mfmg","description":null,"fork":true,"url":"https://api.github.com/repos/Rombur/mfmg","forks_url":"https://api.github.com/repos/Rombur/mfmg/forks","keys_url":"https://api.github.com/repos/Rombur/mfmg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Rombur/mfmg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Rombur/mfmg/teams","hooks_url":"https://api.github.com/repos/Rombur/mfmg/hooks","issue_events_url":"https://api.github.com/repos/Rombur/mfmg/issues/events{/number}","events_url":"https://api.github.com/repos/Rombur/mfmg/events","assignees_url":"https://api.github.com/repos/Rombur/mfmg/assignees{/user}","branches_url":"https://api.github.com/repos/Rombur/mfmg/branches{/branch}","tags_url":"https://api.github.com/repos/Rombur/mfmg/tags","blobs_url":"https://api.github.com/repos/Rombur/mfmg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Rombur/mfmg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Rombur/mfmg/git/refs{/sha}","trees_url":"https://api.github.com/repos/Rombur/mfmg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Rombur/mfmg/statuses/{sha}","languages_url":"https://api.github.com/repos/Rombur/mfmg/languages","stargazers_url":"https://api.github.com/repos/Rombur/mfmg/stargazers","contributors_url":"https://api.github.com/repos/Rombur/mfmg/contributors","subscribers_url":"https://api.github.com/repos/Rombur/mfmg/subscribers","subscription_url":"https://api.github.com/repos/Rombur/mfmg/subscription","commits_url":"https://api.github.com/repos/Rombur/mfmg/commits{/sha}","git_commits_url":"https://api.github.com/repos/Rombur/mfmg/git/commits{/sha}","comments_url":"https://api.github.com/repos/Rombur/mfmg/comments{/number}","issue_comment_url":"https://api.github.com/repos/Rombur/mfmg/issues/comments{/number}","contents_url":"https://api.github.com/repos/Rombur/mfmg/contents/{+path}","compare_url":"https://api.github.com/repos/Rombur/mfmg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Rombur/mfmg/merges","archive_url":"https://api.github.com/repos/Rombur/mfmg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Rombur/mfmg/downloads","issues_url":"https://api.github.com/repos/Rombur/mfmg/issues{/number}","pulls_url":"https://api.github.com/repos/Rombur/mfmg/pulls{/number}","milestones_url":"https://api.github.com/repos/Rombur/mfmg/milestones{/number}","notifications_url":"https://api.github.com/repos/Rombur/mfmg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Rombur/mfmg/labels{/name}","releases_url":"https://api.github.com/repos/Rombur/mfmg/releases{/id}","deployments_url":"https://api.github.com/repos/Rombur/mfmg/deployments","created_at":"2017-11-03T12:44:10Z","updated_at":"2017-11-20T21:21:54Z","pushed_at":"2018-03-14T17:37:35Z","git_url":"git://github.com/Rombur/mfmg.git","ssh_url":"git@github.com:Rombur/mfmg.git","clone_url":"https://github.com/Rombur/mfmg.git","svn_url":"https://github.com/Rombur/mfmg","homepage":null,"size":188,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ORNL-CEES:master","ref":"master","sha":"63b481d3adef3b94a463af517f0015d63a8f4588","user":{"login":"ORNL-CEES","id":6653148,"avatar_url":"https://avatars0.githubusercontent.com/u/6653148?v=4","gravatar_id":"","url":"https://api.github.com/users/ORNL-CEES","html_url":"https://github.com/ORNL-CEES","followers_url":"https://api.github.com/users/ORNL-CEES/followers","following_url":"https://api.github.com/users/ORNL-CEES/following{/other_user}","gists_url":"https://api.github.com/users/ORNL-CEES/gists{/gist_id}","starred_url":"https://api.github.com/users/ORNL-CEES/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ORNL-CEES/subscriptions","organizations_url":"https://api.github.com/users/ORNL-CEES/orgs","repos_url":"https://api.github.com/users/ORNL-CEES/repos","events_url":"https://api.github.com/users/ORNL-CEES/events{/privacy}","received_events_url":"https://api.github.com/users/ORNL-CEES/received_events","type":"Organization","site_admin":false},"repo":{"id":109393720,"name":"mfmg","full_name":"ORNL-CEES/mfmg","owner":{"login":"ORNL-CEES","id":6653148,"avatar_url":"https://avatars0.githubusercontent.com/u/6653148?v=4","gravatar_id":"","url":"https://api.github.com/users/ORNL-CEES","html_url":"https://github.com/ORNL-CEES","followers_url":"https://api.github.com/users/ORNL-CEES/followers","following_url":"https://api.github.com/users/ORNL-CEES/following{/other_user}","gists_url":"https://api.github.com/users/ORNL-CEES/gists{/gist_id}","starred_url":"https://api.github.com/users/ORNL-CEES/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ORNL-CEES/subscriptions","organizations_url":"https://api.github.com/users/ORNL-CEES/orgs","repos_url":"https://api.github.com/users/ORNL-CEES/repos","events_url":"https://api.github.com/users/ORNL-CEES/events{/privacy}","received_events_url":"https://api.github.com/users/ORNL-CEES/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ORNL-CEES/mfmg","description":"MFMG is an open-source library implementing matrix-free multigrid methods.","fork":false,"url":"https://api.github.com/repos/ORNL-CEES/mfmg","forks_url":"https://api.github.com/repos/ORNL-CEES/mfmg/forks","keys_url":"https://api.github.com/repos/ORNL-CEES/mfmg/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ORNL-CEES/mfmg/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ORNL-CEES/mfmg/teams","hooks_url":"https://api.github.com/repos/ORNL-CEES/mfmg/hooks","issue_events_url":"https://api.github.com/repos/ORNL-CEES/mfmg/issues/events{/number}","events_url":"https://api.github.com/repos/ORNL-CEES/mfmg/events","assignees_url":"https://api.github.com/repos/ORNL-CEES/mfmg/assignees{/user}","branches_url":"https://api.github.com/repos/ORNL-CEES/mfmg/branches{/branch}","tags_url":"https://api.github.com/repos/ORNL-CEES/mfmg/tags","blobs_url":"https://api.github.com/repos/ORNL-CEES/mfmg/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ORNL-CEES/mfmg/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ORNL-CEES/mfmg/git/refs{/sha}","trees_url":"https://api.github.com/repos/ORNL-CEES/mfmg/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ORNL-CEES/mfmg/statuses/{sha}","languages_url":"https://api.github.com/repos/ORNL-CEES/mfmg/languages","stargazers_url":"https://api.github.com/repos/ORNL-CEES/mfmg/stargazers","contributors_url":"https://api.github.com/repos/ORNL-CEES/mfmg/contributors","subscribers_url":"https://api.github.com/repos/ORNL-CEES/mfmg/subscribers","subscription_url":"https://api.github.com/repos/ORNL-CEES/mfmg/subscription","commits_url":"https://api.github.com/repos/ORNL-CEES/mfmg/commits{/sha}","git_commits_url":"https://api.github.com/repos/ORNL-CEES/mfmg/git/commits{/sha}","comments_url":"https://api.github.com/repos/ORNL-CEES/mfmg/comments{/number}","issue_comment_url":"https://api.github.com/repos/ORNL-CEES/mfmg/issues/comments{/number}","contents_url":"https://api.github.com/repos/ORNL-CEES/mfmg/contents/{+path}","compare_url":"https://api.github.com/repos/ORNL-CEES/mfmg/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ORNL-CEES/mfmg/merges","archive_url":"https://api.github.com/repos/ORNL-CEES/mfmg/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ORNL-CEES/mfmg/downloads","issues_url":"https://api.github.com/repos/ORNL-CEES/mfmg/issues{/number}","pulls_url":"https://api.github.com/repos/ORNL-CEES/mfmg/pulls{/number}","milestones_url":"https://api.github.com/repos/ORNL-CEES/mfmg/milestones{/number}","notifications_url":"https://api.github.com/repos/ORNL-CEES/mfmg/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ORNL-CEES/mfmg/labels{/name}","releases_url":"https://api.github.com/repos/ORNL-CEES/mfmg/releases{/id}","deployments_url":"https://api.github.com/repos/ORNL-CEES/mfmg/deployments","created_at":"2017-11-03T12:36:50Z","updated_at":"2017-11-20T19:55:59Z","pushed_at":"2018-03-14T14:40:33Z","git_url":"git://github.com/ORNL-CEES/mfmg.git","ssh_url":"git@github.com:ORNL-CEES/mfmg.git","clone_url":"https://github.com/ORNL-CEES/mfmg.git","svn_url":"https://github.com/ORNL-CEES/mfmg","homepage":"https://mfmg.readthedocs.io","size":180,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":2,"open_issues":8,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ORNL-CEES/mfmg/pulls/38"},"html":{"href":"https://github.com/ORNL-CEES/mfmg/pull/38"},"issue":{"href":"https://api.github.com/repos/ORNL-CEES/mfmg/issues/38"},"comments":{"href":"https://api.github.com/repos/ORNL-CEES/mfmg/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/ORNL-CEES/mfmg/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/ORNL-CEES/mfmg/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ORNL-CEES/mfmg/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/ORNL-CEES/mfmg/statuses/0f129503ee1bbe091d7413c616772ca6ab09472b"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"aprokop"}}