{"action":"created","comment":{"url":"https://api.github.com/repos/Samsung/iotjs/pulls/comments/219162852","pull_request_review_id":157269826,"id":219162852,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTE2Mjg1Mg==","diff_hunk":"@@ -234,14 +192,13 @@ def get_snapshot_contents(js_path, snapshot_tool):\n \n         if module_name != \"iotjs\":\n             fwrapped.write(\"});\\n\")\n-\n-    ret = subprocess.call([snapshot_tool,\n-                           \"generate\",\n-                           \"-o\", snapshot_path,\n-                           wrapped_path])\n+    cmd = [snapshot_tool, \"generate\", \"-o\", snapshot_path]\n+    if literals:\n+        cmd = cmd + [\"--static\", \"--load-literals-list-format\", literals]\n+    ret = subprocess.call(cmd + [wrapped_path])\n \n     fs.remove(wrapped_path)\n-    if ret != 0:\n+    if ret != 0 and literals == None:","path":"tools/js2c.py","position":74,"original_position":74,"commit_id":"2c9f0f8912965413c64fbd0a312cb38ad986d6bb","original_commit_id":"2c9f0f8912965413c64fbd0a312cb38ad986d6bb","user":{"login":"galpeter","id":12067856,"node_id":"MDQ6VXNlcjEyMDY3ODU2","avatar_url":"https://avatars1.githubusercontent.com/u/12067856?v=4","gravatar_id":"","url":"https://api.github.com/users/galpeter","html_url":"https://github.com/galpeter","followers_url":"https://api.github.com/users/galpeter/followers","following_url":"https://api.github.com/users/galpeter/following{/other_user}","gists_url":"https://api.github.com/users/galpeter/gists{/gist_id}","starred_url":"https://api.github.com/users/galpeter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/galpeter/subscriptions","organizations_url":"https://api.github.com/users/galpeter/orgs","repos_url":"https://api.github.com/users/galpeter/repos","events_url":"https://api.github.com/users/galpeter/events{/privacy}","received_events_url":"https://api.github.com/users/galpeter/received_events","type":"User","site_admin":false},"body":"I see, then, maybe we should log out a message like: \"unable to create static snapshot falling back to normal snapshot\".","created_at":"2018-09-20T13:28:14Z","updated_at":"2018-09-20T13:43:39Z","html_url":"https://github.com/Samsung/iotjs/pull/1750#discussion_r219162852","pull_request_url":"https://api.github.com/repos/Samsung/iotjs/pulls/1750","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Samsung/iotjs/pulls/comments/219162852"},"html":{"href":"https://github.com/Samsung/iotjs/pull/1750#discussion_r219162852"},"pull_request":{"href":"https://api.github.com/repos/Samsung/iotjs/pulls/1750"}},"in_reply_to_id":219094861},"pull_request":{"url":"https://api.github.com/repos/Samsung/iotjs/pulls/1750","id":216267259,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2MjY3MjU5","html_url":"https://github.com/Samsung/iotjs/pull/1750","diff_url":"https://github.com/Samsung/iotjs/pull/1750.diff","patch_url":"https://github.com/Samsung/iotjs/pull/1750.patch","issue_url":"https://api.github.com/repos/Samsung/iotjs/issues/1750","number":1750,"state":"open","locked":false,"title":"Use static snapshots and update JerryScript.","user":{"login":"LaszloLango","id":10030017,"node_id":"MDQ6VXNlcjEwMDMwMDE3","avatar_url":"https://avatars3.githubusercontent.com/u/10030017?v=4","gravatar_id":"","url":"https://api.github.com/users/LaszloLango","html_url":"https://github.com/LaszloLango","followers_url":"https://api.github.com/users/LaszloLango/followers","following_url":"https://api.github.com/users/LaszloLango/following{/other_user}","gists_url":"https://api.github.com/users/LaszloLango/gists{/gist_id}","starred_url":"https://api.github.com/users/LaszloLango/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LaszloLango/subscriptions","organizations_url":"https://api.github.com/users/LaszloLango/orgs","repos_url":"https://api.github.com/users/LaszloLango/repos","events_url":"https://api.github.com/users/LaszloLango/events{/privacy}","received_events_url":"https://api.github.com/users/LaszloLango/received_events","type":"User","site_admin":false},"body":"IoT.js-DCO-1.0-Signed-off-by: László Langó llango.u-szeged@partner.samsung.com","created_at":"2018-09-18T11:02:34Z","updated_at":"2018-09-20T13:43:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d4009d3ad5442f77ef3d4befba90fde1043af39","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Samsung/iotjs/pulls/1750/commits","review_comments_url":"https://api.github.com/repos/Samsung/iotjs/pulls/1750/comments","review_comment_url":"https://api.github.com/repos/Samsung/iotjs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Samsung/iotjs/issues/1750/comments","statuses_url":"https://api.github.com/repos/Samsung/iotjs/statuses/2c9f0f8912965413c64fbd0a312cb38ad986d6bb","head":{"label":"LaszloLango:static-snapshot","ref":"static-snapshot","sha":"2c9f0f8912965413c64fbd0a312cb38ad986d6bb","user":{"login":"LaszloLango","id":10030017,"node_id":"MDQ6VXNlcjEwMDMwMDE3","avatar_url":"https://avatars3.githubusercontent.com/u/10030017?v=4","gravatar_id":"","url":"https://api.github.com/users/LaszloLango","html_url":"https://github.com/LaszloLango","followers_url":"https://api.github.com/users/LaszloLango/followers","following_url":"https://api.github.com/users/LaszloLango/following{/other_user}","gists_url":"https://api.github.com/users/LaszloLango/gists{/gist_id}","starred_url":"https://api.github.com/users/LaszloLango/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LaszloLango/subscriptions","organizations_url":"https://api.github.com/users/LaszloLango/orgs","repos_url":"https://api.github.com/users/LaszloLango/repos","events_url":"https://api.github.com/users/LaszloLango/events{/privacy}","received_events_url":"https://api.github.com/users/LaszloLango/received_events","type":"User","site_admin":false},"repo":{"id":54548335,"node_id":"MDEwOlJlcG9zaXRvcnk1NDU0ODMzNQ==","name":"iotjs","full_name":"LaszloLango/iotjs","private":false,"owner":{"login":"LaszloLango","id":10030017,"node_id":"MDQ6VXNlcjEwMDMwMDE3","avatar_url":"https://avatars3.githubusercontent.com/u/10030017?v=4","gravatar_id":"","url":"https://api.github.com/users/LaszloLango","html_url":"https://github.com/LaszloLango","followers_url":"https://api.github.com/users/LaszloLango/followers","following_url":"https://api.github.com/users/LaszloLango/following{/other_user}","gists_url":"https://api.github.com/users/LaszloLango/gists{/gist_id}","starred_url":"https://api.github.com/users/LaszloLango/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LaszloLango/subscriptions","organizations_url":"https://api.github.com/users/LaszloLango/orgs","repos_url":"https://api.github.com/users/LaszloLango/repos","events_url":"https://api.github.com/users/LaszloLango/events{/privacy}","received_events_url":"https://api.github.com/users/LaszloLango/received_events","type":"User","site_admin":false},"html_url":"https://github.com/LaszloLango/iotjs","description":"Platform for Internet of Things with JavaScript http://www.iotjs.net ","fork":true,"url":"https://api.github.com/repos/LaszloLango/iotjs","forks_url":"https://api.github.com/repos/LaszloLango/iotjs/forks","keys_url":"https://api.github.com/repos/LaszloLango/iotjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LaszloLango/iotjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LaszloLango/iotjs/teams","hooks_url":"https://api.github.com/repos/LaszloLango/iotjs/hooks","issue_events_url":"https://api.github.com/repos/LaszloLango/iotjs/issues/events{/number}","events_url":"https://api.github.com/repos/LaszloLango/iotjs/events","assignees_url":"https://api.github.com/repos/LaszloLango/iotjs/assignees{/user}","branches_url":"https://api.github.com/repos/LaszloLango/iotjs/branches{/branch}","tags_url":"https://api.github.com/repos/LaszloLango/iotjs/tags","blobs_url":"https://api.github.com/repos/LaszloLango/iotjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LaszloLango/iotjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LaszloLango/iotjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/LaszloLango/iotjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LaszloLango/iotjs/statuses/{sha}","languages_url":"https://api.github.com/repos/LaszloLango/iotjs/languages","stargazers_url":"https://api.github.com/repos/LaszloLango/iotjs/stargazers","contributors_url":"https://api.github.com/repos/LaszloLango/iotjs/contributors","subscribers_url":"https://api.github.com/repos/LaszloLango/iotjs/subscribers","subscription_url":"https://api.github.com/repos/LaszloLango/iotjs/subscription","commits_url":"https://api.github.com/repos/LaszloLango/iotjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/LaszloLango/iotjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/LaszloLango/iotjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/LaszloLango/iotjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/LaszloLango/iotjs/contents/{+path}","compare_url":"https://api.github.com/repos/LaszloLango/iotjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LaszloLango/iotjs/merges","archive_url":"https://api.github.com/repos/LaszloLango/iotjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LaszloLango/iotjs/downloads","issues_url":"https://api.github.com/repos/LaszloLango/iotjs/issues{/number}","pulls_url":"https://api.github.com/repos/LaszloLango/iotjs/pulls{/number}","milestones_url":"https://api.github.com/repos/LaszloLango/iotjs/milestones{/number}","notifications_url":"https://api.github.com/repos/LaszloLango/iotjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LaszloLango/iotjs/labels{/name}","releases_url":"https://api.github.com/repos/LaszloLango/iotjs/releases{/id}","deployments_url":"https://api.github.com/repos/LaszloLango/iotjs/deployments","created_at":"2016-03-23T09:46:58Z","updated_at":"2017-02-16T09:00:46Z","pushed_at":"2018-09-20T07:56:25Z","git_url":"git://github.com/LaszloLango/iotjs.git","ssh_url":"git@github.com:LaszloLango/iotjs.git","clone_url":"https://github.com/LaszloLango/iotjs.git","svn_url":"https://github.com/LaszloLango/iotjs","homepage":"","size":3699,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Samsung:master","ref":"master","sha":"4696d349d6e93c5b07ba6dd14cdee558670ec26f","user":{"login":"Samsung","id":6210390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMTAzOTA=","avatar_url":"https://avatars3.githubusercontent.com/u/6210390?v=4","gravatar_id":"","url":"https://api.github.com/users/Samsung","html_url":"https://github.com/Samsung","followers_url":"https://api.github.com/users/Samsung/followers","following_url":"https://api.github.com/users/Samsung/following{/other_user}","gists_url":"https://api.github.com/users/Samsung/gists{/gist_id}","starred_url":"https://api.github.com/users/Samsung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Samsung/subscriptions","organizations_url":"https://api.github.com/users/Samsung/orgs","repos_url":"https://api.github.com/users/Samsung/repos","events_url":"https://api.github.com/users/Samsung/events{/privacy}","received_events_url":"https://api.github.com/users/Samsung/received_events","type":"Organization","site_admin":false},"repo":{"id":33589470,"node_id":"MDEwOlJlcG9zaXRvcnkzMzU4OTQ3MA==","name":"iotjs","full_name":"Samsung/iotjs","private":false,"owner":{"login":"Samsung","id":6210390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyMTAzOTA=","avatar_url":"https://avatars3.githubusercontent.com/u/6210390?v=4","gravatar_id":"","url":"https://api.github.com/users/Samsung","html_url":"https://github.com/Samsung","followers_url":"https://api.github.com/users/Samsung/followers","following_url":"https://api.github.com/users/Samsung/following{/other_user}","gists_url":"https://api.github.com/users/Samsung/gists{/gist_id}","starred_url":"https://api.github.com/users/Samsung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Samsung/subscriptions","organizations_url":"https://api.github.com/users/Samsung/orgs","repos_url":"https://api.github.com/users/Samsung/repos","events_url":"https://api.github.com/users/Samsung/events{/privacy}","received_events_url":"https://api.github.com/users/Samsung/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Samsung/iotjs","description":"Platform for Internet of Things with JavaScript http://www.iotjs.net ","fork":false,"url":"https://api.github.com/repos/Samsung/iotjs","forks_url":"https://api.github.com/repos/Samsung/iotjs/forks","keys_url":"https://api.github.com/repos/Samsung/iotjs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Samsung/iotjs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Samsung/iotjs/teams","hooks_url":"https://api.github.com/repos/Samsung/iotjs/hooks","issue_events_url":"https://api.github.com/repos/Samsung/iotjs/issues/events{/number}","events_url":"https://api.github.com/repos/Samsung/iotjs/events","assignees_url":"https://api.github.com/repos/Samsung/iotjs/assignees{/user}","branches_url":"https://api.github.com/repos/Samsung/iotjs/branches{/branch}","tags_url":"https://api.github.com/repos/Samsung/iotjs/tags","blobs_url":"https://api.github.com/repos/Samsung/iotjs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Samsung/iotjs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Samsung/iotjs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Samsung/iotjs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Samsung/iotjs/statuses/{sha}","languages_url":"https://api.github.com/repos/Samsung/iotjs/languages","stargazers_url":"https://api.github.com/repos/Samsung/iotjs/stargazers","contributors_url":"https://api.github.com/repos/Samsung/iotjs/contributors","subscribers_url":"https://api.github.com/repos/Samsung/iotjs/subscribers","subscription_url":"https://api.github.com/repos/Samsung/iotjs/subscription","commits_url":"https://api.github.com/repos/Samsung/iotjs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Samsung/iotjs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Samsung/iotjs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Samsung/iotjs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Samsung/iotjs/contents/{+path}","compare_url":"https://api.github.com/repos/Samsung/iotjs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Samsung/iotjs/merges","archive_url":"https://api.github.com/repos/Samsung/iotjs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Samsung/iotjs/downloads","issues_url":"https://api.github.com/repos/Samsung/iotjs/issues{/number}","pulls_url":"https://api.github.com/repos/Samsung/iotjs/pulls{/number}","milestones_url":"https://api.github.com/repos/Samsung/iotjs/milestones{/number}","notifications_url":"https://api.github.com/repos/Samsung/iotjs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Samsung/iotjs/labels{/name}","releases_url":"https://api.github.com/repos/Samsung/iotjs/releases{/id}","deployments_url":"https://api.github.com/repos/Samsung/iotjs/deployments","created_at":"2015-04-08T06:41:39Z","updated_at":"2018-09-19T17:53:21Z","pushed_at":"2018-09-20T07:56:27Z","git_url":"git://github.com/Samsung/iotjs.git","ssh_url":"git@github.com:Samsung/iotjs.git","clone_url":"https://github.com/Samsung/iotjs.git","svn_url":"https://github.com/Samsung/iotjs","homepage":"","size":64248,"stargazers_count":1838,"watchers_count":1838,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":345,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":345,"open_issues":18,"watchers":1838,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Samsung/iotjs/pulls/1750"},"html":{"href":"https://github.com/Samsung/iotjs/pull/1750"},"issue":{"href":"https://api.github.com/repos/Samsung/iotjs/issues/1750"},"comments":{"href":"https://api.github.com/repos/Samsung/iotjs/issues/1750/comments"},"review_comments":{"href":"https://api.github.com/repos/Samsung/iotjs/pulls/1750/comments"},"review_comment":{"href":"https://api.github.com/repos/Samsung/iotjs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Samsung/iotjs/pulls/1750/commits"},"statuses":{"href":"https://api.github.com/repos/Samsung/iotjs/statuses/2c9f0f8912965413c64fbd0a312cb38ad986d6bb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"galpeter"}}