{"action":"created","issue":{"url":"https://api.github.com/repos/ampproject/docs/issues/1004","repository_url":"https://api.github.com/repos/ampproject/docs","labels_url":"https://api.github.com/repos/ampproject/docs/issues/1004/labels{/name}","comments_url":"https://api.github.com/repos/ampproject/docs/issues/1004/comments","events_url":"https://api.github.com/repos/ampproject/docs/issues/1004/events","html_url":"https://github.com/ampproject/docs/issues/1004","id":333839313,"node_id":"MDU6SXNzdWUzMzM4MzkzMTM=","number":1004,"title":"Make a version of `grow build` that doesn't use GH tokens","user":{"login":"rsimha","id":26553114,"node_id":"MDQ6VXNlcjI2NTUzMTE0","avatar_url":"https://avatars1.githubusercontent.com/u/26553114?v=4","gravatar_id":"","url":"https://api.github.com/users/rsimha","html_url":"https://github.com/rsimha","followers_url":"https://api.github.com/users/rsimha/followers","following_url":"https://api.github.com/users/rsimha/following{/other_user}","gists_url":"https://api.github.com/users/rsimha/gists{/gist_id}","starred_url":"https://api.github.com/users/rsimha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsimha/subscriptions","organizations_url":"https://api.github.com/users/rsimha/orgs","repos_url":"https://api.github.com/users/rsimha/repos","events_url":"https://api.github.com/users/rsimha/events{/privacy}","received_events_url":"https://api.github.com/users/rsimha/received_events","type":"User","site_admin":false},"labels":[{"id":565002204,"node_id":"MDU6TGFiZWw1NjUwMDIyMDQ=","url":"https://api.github.com/repos/ampproject/docs/labels/P2:%20Medium","name":"P2: Medium","color":"e99695","default":false},{"id":360955529,"node_id":"MDU6TGFiZWwzNjA5NTU1Mjk=","url":"https://api.github.com/repos/ampproject/docs/labels/Type:%20Site%20Infrastructure","name":"Type: Site Infrastructure","color":"bfdadc","default":false}],"state":"open","locked":false,"assignee":{"login":"rsimha","id":26553114,"node_id":"MDQ6VXNlcjI2NTUzMTE0","avatar_url":"https://avatars1.githubusercontent.com/u/26553114?v=4","gravatar_id":"","url":"https://api.github.com/users/rsimha","html_url":"https://github.com/rsimha","followers_url":"https://api.github.com/users/rsimha/followers","following_url":"https://api.github.com/users/rsimha/following{/other_user}","gists_url":"https://api.github.com/users/rsimha/gists{/gist_id}","starred_url":"https://api.github.com/users/rsimha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsimha/subscriptions","organizations_url":"https://api.github.com/users/rsimha/orgs","repos_url":"https://api.github.com/users/rsimha/repos","events_url":"https://api.github.com/users/rsimha/events{/privacy}","received_events_url":"https://api.github.com/users/rsimha/received_events","type":"User","site_admin":false},"assignees":[{"login":"rsimha","id":26553114,"node_id":"MDQ6VXNlcjI2NTUzMTE0","avatar_url":"https://avatars1.githubusercontent.com/u/26553114?v=4","gravatar_id":"","url":"https://api.github.com/users/rsimha","html_url":"https://github.com/rsimha","followers_url":"https://api.github.com/users/rsimha/followers","following_url":"https://api.github.com/users/rsimha/following{/other_user}","gists_url":"https://api.github.com/users/rsimha/gists{/gist_id}","starred_url":"https://api.github.com/users/rsimha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsimha/subscriptions","organizations_url":"https://api.github.com/users/rsimha/orgs","repos_url":"https://api.github.com/users/rsimha/repos","events_url":"https://api.github.com/users/rsimha/events{/privacy}","received_events_url":"https://api.github.com/users/rsimha/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-06-19T21:07:08Z","updated_at":"2018-06-20T17:30:23Z","closed_at":null,"author_association":"COLLABORATOR","body":"This came out of the discussion at https://github.com/ampproject/docs/pull/1002#issuecomment-398517598. It's needed so that we can run `grow build` as part of PR checks for incoming PRs, and Travis doesn't make secure tokens available to PR builds.\r\n\r\nCurrently, it's only `scripts/import_docs.js` that uses the token. Since we don't really want to do a deploy duding PR builds, perhaps we can restrict them to just building the docs and making sure nothing broke?\r\n\r\nhttps://github.com/ampproject/docs/blob/3670e95f11318d904c6a8ae5759faf88706007be/scripts/import_docs.js#L13-L16\r\n\r\n@pbakaus @bpaduch Thoughts?\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/ampproject/docs/issues/comments/398833102","html_url":"https://github.com/ampproject/docs/issues/1004#issuecomment-398833102","issue_url":"https://api.github.com/repos/ampproject/docs/issues/1004","id":398833102,"node_id":"MDEyOklzc3VlQ29tbWVudDM5ODgzMzEwMg==","user":{"login":"rsimha","id":26553114,"node_id":"MDQ6VXNlcjI2NTUzMTE0","avatar_url":"https://avatars1.githubusercontent.com/u/26553114?v=4","gravatar_id":"","url":"https://api.github.com/users/rsimha","html_url":"https://github.com/rsimha","followers_url":"https://api.github.com/users/rsimha/followers","following_url":"https://api.github.com/users/rsimha/following{/other_user}","gists_url":"https://api.github.com/users/rsimha/gists{/gist_id}","starred_url":"https://api.github.com/users/rsimha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsimha/subscriptions","organizations_url":"https://api.github.com/users/rsimha/orgs","repos_url":"https://api.github.com/users/rsimha/repos","events_url":"https://api.github.com/users/rsimha/events{/privacy}","received_events_url":"https://api.github.com/users/rsimha/received_events","type":"User","site_admin":false},"created_at":"2018-06-20T17:30:23Z","updated_at":"2018-06-20T17:30:23Z","author_association":"COLLABORATOR","body":"@pbakaus Thanks. I read about how the build works from [here](https://github.com/ampproject/docs/blob/master/contributing/ampproject-files-build-process.md) and [here](https://github.com/ampproject/docs), and noted the point about using the `.md` files from `ampproject/amphtml` as the source of truth while building `ampproject/docs`.\r\n\r\nA couple things I noticed:\r\n1. Running `grow build` seems to be calling `gulp build` internally, which in turn reports that it is done within ~5 seconds even though the full build takes much longer. Is this expected?\r\n2. At the end of `grow build`, I'm still seeing some changes. Is this expected?\r\n```\r\n content/includes/list-blog-ads.yaml                                                                           | 106 ++++++++++++++++++++++++++---------------------------\r\n content/includes/list-blog.yaml                                                                               | 123 ++++++++++++++++++++++++++++++++++----------------------------\r\n content/latest/blog-ads/ads-a-first-look-at-using-web-packaging-to-improve-amp-urls.md                        |   2 +-\r\n content/latest/blog-ads/ads-amp-and-advertising-conversions.md                                                |   2 +-\r\n content/latest/blog-ads/ads-amp-roadshow-more-cities-more-content.md                                          |   2 +-\r\n content/latest/blog-ads/ads-faster-ads-with-render-on-idle.md                                                 |   2 +-\r\n content/latest/blog-ads/ads-google-io-2018.md                                                                 |   2 +-\r\n content/latest/blog-ads/ads-jung-von-matts-road-to-the-worlds-fastest-automotive-content-marketing-website.md |   9 +++--\r\n content/latest/blog-ads/ads-new-functionality-to-help-manage-user-choice-in-amp-pages.md                      |   2 +-\r\n content/latest/blog-ads/ads-new-tools-for-building-user-controls-in-amp-pages.md                              |   2 +-\r\n 10 files changed, 132 insertions(+), 120 deletions(-)\r\n```\r\n\r\nRe: your point about committing the docs markdown files, there is a way to ignore them via `.gitignore`, and yet occasionally add / modify them by using `git add --force` or `git add -f`. See [this](https://mirrors.edge.kernel.org/pub/software/scm/git/docs/git-add.html) reference.\r\n\r\nWould that help eliminate the need for a token? Let me know, and I could make the required changes."}}
{"actor":{"display_login":"rsimha"}}