{"action":"created","comment":{"url":"https://api.github.com/repos/b2ihealthcare/snow-owl/pulls/comments/177988093","pull_request_review_id":107960169,"id":177988093,"diff_hunk":"@@ -976,9 +783,24 @@ private Relationship buildDefaultIsARelationship(Concept parentConcept, Concept\n \t\n \t@Override\n \tpublic void preCommit() {\n-\t\tif (deletionPlan != null) {\n-\t\t\tdelete(deletionPlan);\n+\t\t\n+\t\tif (!deletionPlan.isRejected() && !deletionPlan.isEmpty()) {","path":"snomed/com.b2international.snowowl.snomed.datastore/src/com/b2international/snowowl/snomed/datastore/SnomedEditingContext.java","position":457,"original_position":457,"commit_id":"76b426ad6971a151facf8db5ab8ec65428595592","original_commit_id":"76b426ad6971a151facf8db5ab8ec65428595592","user":{"login":"apeteri","id":1411829,"avatar_url":"https://avatars1.githubusercontent.com/u/1411829?v=4","gravatar_id":"","url":"https://api.github.com/users/apeteri","html_url":"https://github.com/apeteri","followers_url":"https://api.github.com/users/apeteri/followers","following_url":"https://api.github.com/users/apeteri/following{/other_user}","gists_url":"https://api.github.com/users/apeteri/gists{/gist_id}","starred_url":"https://api.github.com/users/apeteri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apeteri/subscriptions","organizations_url":"https://api.github.com/users/apeteri/orgs","repos_url":"https://api.github.com/users/apeteri/repos","events_url":"https://api.github.com/users/apeteri/events{/privacy}","received_events_url":"https://api.github.com/users/apeteri/received_events","type":"User","site_admin":false},"body":"Shouldn't we throw an exception if execution reaches this point and the deletion plan is rejected? This will silently skip the deletion parts of the commit.","created_at":"2018-03-29T08:39:37Z","updated_at":"2018-03-29T08:48:54Z","html_url":"https://github.com/b2ihealthcare/snow-owl/pull/217#discussion_r177988093","pull_request_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/pulls/217","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/b2ihealthcare/snow-owl/pulls/comments/177988093"},"html":{"href":"https://github.com/b2ihealthcare/snow-owl/pull/217#discussion_r177988093"},"pull_request":{"href":"https://api.github.com/repos/b2ihealthcare/snow-owl/pulls/217"}}},"pull_request":{"url":"https://api.github.com/repos/b2ihealthcare/snow-owl/pulls/217","id":176542955,"html_url":"https://github.com/b2ihealthcare/snow-owl/pull/217","diff_url":"https://github.com/b2ihealthcare/snow-owl/pull/217.diff","patch_url":"https://github.com/b2ihealthcare/snow-owl/pull/217.patch","issue_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/issues/217","number":217,"state":"open","locked":false,"title":"SO-2959: Properly prevent deletion of released components","user":{"login":"nagyo","id":2010200,"avatar_url":"https://avatars0.githubusercontent.com/u/2010200?v=4","gravatar_id":"","url":"https://api.github.com/users/nagyo","html_url":"https://github.com/nagyo","followers_url":"https://api.github.com/users/nagyo/followers","following_url":"https://api.github.com/users/nagyo/following{/other_user}","gists_url":"https://api.github.com/users/nagyo/gists{/gist_id}","starred_url":"https://api.github.com/users/nagyo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nagyo/subscriptions","organizations_url":"https://api.github.com/users/nagyo/orgs","repos_url":"https://api.github.com/users/nagyo/repos","events_url":"https://api.github.com/users/nagyo/events{/privacy}","received_events_url":"https://api.github.com/users/nagyo/received_events","type":"User","site_admin":false},"body":"- always use one SnomedDeletionPlan per SnomedEditingContext\r\n- allow deleting the last FSN of a concept\r\n- simplified validation of description type concepts\r\n- added unit tests for concepts, relationships and descriptions\r\n","created_at":"2018-03-21T16:53:49Z","updated_at":"2018-03-29T08:48:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5ad4becc84ba8c16458528cc9f73d2a71b752452","assignee":{"login":"nagyo","id":2010200,"avatar_url":"https://avatars0.githubusercontent.com/u/2010200?v=4","gravatar_id":"","url":"https://api.github.com/users/nagyo","html_url":"https://github.com/nagyo","followers_url":"https://api.github.com/users/nagyo/followers","following_url":"https://api.github.com/users/nagyo/following{/other_user}","gists_url":"https://api.github.com/users/nagyo/gists{/gist_id}","starred_url":"https://api.github.com/users/nagyo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nagyo/subscriptions","organizations_url":"https://api.github.com/users/nagyo/orgs","repos_url":"https://api.github.com/users/nagyo/repos","events_url":"https://api.github.com/users/nagyo/events{/privacy}","received_events_url":"https://api.github.com/users/nagyo/received_events","type":"User","site_admin":false},"assignees":[{"login":"nagyo","id":2010200,"avatar_url":"https://avatars0.githubusercontent.com/u/2010200?v=4","gravatar_id":"","url":"https://api.github.com/users/nagyo","html_url":"https://github.com/nagyo","followers_url":"https://api.github.com/users/nagyo/followers","following_url":"https://api.github.com/users/nagyo/following{/other_user}","gists_url":"https://api.github.com/users/nagyo/gists{/gist_id}","starred_url":"https://api.github.com/users/nagyo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nagyo/subscriptions","organizations_url":"https://api.github.com/users/nagyo/orgs","repos_url":"https://api.github.com/users/nagyo/repos","events_url":"https://api.github.com/users/nagyo/events{/privacy}","received_events_url":"https://api.github.com/users/nagyo/received_events","type":"User","site_admin":false},{"login":"zoliMolnar","id":24438461,"avatar_url":"https://avatars1.githubusercontent.com/u/24438461?v=4","gravatar_id":"","url":"https://api.github.com/users/zoliMolnar","html_url":"https://github.com/zoliMolnar","followers_url":"https://api.github.com/users/zoliMolnar/followers","following_url":"https://api.github.com/users/zoliMolnar/following{/other_user}","gists_url":"https://api.github.com/users/zoliMolnar/gists{/gist_id}","starred_url":"https://api.github.com/users/zoliMolnar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zoliMolnar/subscriptions","organizations_url":"https://api.github.com/users/zoliMolnar/orgs","repos_url":"https://api.github.com/users/zoliMolnar/repos","events_url":"https://api.github.com/users/zoliMolnar/events{/privacy}","received_events_url":"https://api.github.com/users/zoliMolnar/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/pulls/217/commits","review_comments_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/pulls/217/comments","review_comment_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/issues/217/comments","statuses_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/statuses/76b426ad6971a151facf8db5ab8ec65428595592","head":{"label":"b2ihealthcare:issue/SO-2959_fix_deletion_of_released_components","ref":"issue/SO-2959_fix_deletion_of_released_components","sha":"76b426ad6971a151facf8db5ab8ec65428595592","user":{"login":"b2ihealthcare","id":1296282,"avatar_url":"https://avatars2.githubusercontent.com/u/1296282?v=4","gravatar_id":"","url":"https://api.github.com/users/b2ihealthcare","html_url":"https://github.com/b2ihealthcare","followers_url":"https://api.github.com/users/b2ihealthcare/followers","following_url":"https://api.github.com/users/b2ihealthcare/following{/other_user}","gists_url":"https://api.github.com/users/b2ihealthcare/gists{/gist_id}","starred_url":"https://api.github.com/users/b2ihealthcare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b2ihealthcare/subscriptions","organizations_url":"https://api.github.com/users/b2ihealthcare/orgs","repos_url":"https://api.github.com/users/b2ihealthcare/repos","events_url":"https://api.github.com/users/b2ihealthcare/events{/privacy}","received_events_url":"https://api.github.com/users/b2ihealthcare/received_events","type":"Organization","site_admin":false},"repo":{"id":29013859,"name":"snow-owl","full_name":"b2ihealthcare/snow-owl","owner":{"login":"b2ihealthcare","id":1296282,"avatar_url":"https://avatars2.githubusercontent.com/u/1296282?v=4","gravatar_id":"","url":"https://api.github.com/users/b2ihealthcare","html_url":"https://github.com/b2ihealthcare","followers_url":"https://api.github.com/users/b2ihealthcare/followers","following_url":"https://api.github.com/users/b2ihealthcare/following{/other_user}","gists_url":"https://api.github.com/users/b2ihealthcare/gists{/gist_id}","starred_url":"https://api.github.com/users/b2ihealthcare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b2ihealthcare/subscriptions","organizations_url":"https://api.github.com/users/b2ihealthcare/orgs","repos_url":"https://api.github.com/users/b2ihealthcare/repos","events_url":"https://api.github.com/users/b2ihealthcare/events{/privacy}","received_events_url":"https://api.github.com/users/b2ihealthcare/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/b2ihealthcare/snow-owl","description":"Snow Owl Terminology Server","fork":false,"url":"https://api.github.com/repos/b2ihealthcare/snow-owl","forks_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/forks","keys_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/teams","hooks_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/hooks","issue_events_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/issues/events{/number}","events_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/events","assignees_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/assignees{/user}","branches_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/branches{/branch}","tags_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/tags","blobs_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/git/refs{/sha}","trees_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/statuses/{sha}","languages_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/languages","stargazers_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/stargazers","contributors_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/contributors","subscribers_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/subscribers","subscription_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/subscription","commits_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/commits{/sha}","git_commits_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/git/commits{/sha}","comments_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/comments{/number}","issue_comment_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/issues/comments{/number}","contents_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/contents/{+path}","compare_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/merges","archive_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/downloads","issues_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/issues{/number}","pulls_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/pulls{/number}","milestones_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/milestones{/number}","notifications_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/labels{/name}","releases_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/releases{/id}","deployments_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/deployments","created_at":"2015-01-09T11:31:14Z","updated_at":"2018-03-29T08:45:33Z","pushed_at":"2018-03-29T08:45:30Z","git_url":"git://github.com/b2ihealthcare/snow-owl.git","ssh_url":"git@github.com:b2ihealthcare/snow-owl.git","clone_url":"https://github.com/b2ihealthcare/snow-owl.git","svn_url":"https://github.com/b2ihealthcare/snow-owl","homepage":"http://b2ihealthcare.github.io/snow-owl/","size":505351,"stargazers_count":19,"watchers_count":19,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":4,"open_issues":8,"watchers":19,"default_branch":"6.x"}},"base":{"label":"b2ihealthcare:6.x","ref":"6.x","sha":"93649357dd19788033408a7640bd85a49d70e6ce","user":{"login":"b2ihealthcare","id":1296282,"avatar_url":"https://avatars2.githubusercontent.com/u/1296282?v=4","gravatar_id":"","url":"https://api.github.com/users/b2ihealthcare","html_url":"https://github.com/b2ihealthcare","followers_url":"https://api.github.com/users/b2ihealthcare/followers","following_url":"https://api.github.com/users/b2ihealthcare/following{/other_user}","gists_url":"https://api.github.com/users/b2ihealthcare/gists{/gist_id}","starred_url":"https://api.github.com/users/b2ihealthcare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b2ihealthcare/subscriptions","organizations_url":"https://api.github.com/users/b2ihealthcare/orgs","repos_url":"https://api.github.com/users/b2ihealthcare/repos","events_url":"https://api.github.com/users/b2ihealthcare/events{/privacy}","received_events_url":"https://api.github.com/users/b2ihealthcare/received_events","type":"Organization","site_admin":false},"repo":{"id":29013859,"name":"snow-owl","full_name":"b2ihealthcare/snow-owl","owner":{"login":"b2ihealthcare","id":1296282,"avatar_url":"https://avatars2.githubusercontent.com/u/1296282?v=4","gravatar_id":"","url":"https://api.github.com/users/b2ihealthcare","html_url":"https://github.com/b2ihealthcare","followers_url":"https://api.github.com/users/b2ihealthcare/followers","following_url":"https://api.github.com/users/b2ihealthcare/following{/other_user}","gists_url":"https://api.github.com/users/b2ihealthcare/gists{/gist_id}","starred_url":"https://api.github.com/users/b2ihealthcare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b2ihealthcare/subscriptions","organizations_url":"https://api.github.com/users/b2ihealthcare/orgs","repos_url":"https://api.github.com/users/b2ihealthcare/repos","events_url":"https://api.github.com/users/b2ihealthcare/events{/privacy}","received_events_url":"https://api.github.com/users/b2ihealthcare/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/b2ihealthcare/snow-owl","description":"Snow Owl Terminology Server","fork":false,"url":"https://api.github.com/repos/b2ihealthcare/snow-owl","forks_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/forks","keys_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/teams","hooks_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/hooks","issue_events_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/issues/events{/number}","events_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/events","assignees_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/assignees{/user}","branches_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/branches{/branch}","tags_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/tags","blobs_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/git/refs{/sha}","trees_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/statuses/{sha}","languages_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/languages","stargazers_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/stargazers","contributors_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/contributors","subscribers_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/subscribers","subscription_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/subscription","commits_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/commits{/sha}","git_commits_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/git/commits{/sha}","comments_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/comments{/number}","issue_comment_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/issues/comments{/number}","contents_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/contents/{+path}","compare_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/merges","archive_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/downloads","issues_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/issues{/number}","pulls_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/pulls{/number}","milestones_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/milestones{/number}","notifications_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/labels{/name}","releases_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/releases{/id}","deployments_url":"https://api.github.com/repos/b2ihealthcare/snow-owl/deployments","created_at":"2015-01-09T11:31:14Z","updated_at":"2018-03-29T08:45:33Z","pushed_at":"2018-03-29T08:45:30Z","git_url":"git://github.com/b2ihealthcare/snow-owl.git","ssh_url":"git@github.com:b2ihealthcare/snow-owl.git","clone_url":"https://github.com/b2ihealthcare/snow-owl.git","svn_url":"https://github.com/b2ihealthcare/snow-owl","homepage":"http://b2ihealthcare.github.io/snow-owl/","size":505351,"stargazers_count":19,"watchers_count":19,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":4,"open_issues":8,"watchers":19,"default_branch":"6.x"}},"_links":{"self":{"href":"https://api.github.com/repos/b2ihealthcare/snow-owl/pulls/217"},"html":{"href":"https://github.com/b2ihealthcare/snow-owl/pull/217"},"issue":{"href":"https://api.github.com/repos/b2ihealthcare/snow-owl/issues/217"},"comments":{"href":"https://api.github.com/repos/b2ihealthcare/snow-owl/issues/217/comments"},"review_comments":{"href":"https://api.github.com/repos/b2ihealthcare/snow-owl/pulls/217/comments"},"review_comment":{"href":"https://api.github.com/repos/b2ihealthcare/snow-owl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/b2ihealthcare/snow-owl/pulls/217/commits"},"statuses":{"href":"https://api.github.com/repos/b2ihealthcare/snow-owl/statuses/76b426ad6971a151facf8db5ab8ec65428595592"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"apeteri"}}