{"action":"created","issue":{"url":"https://api.github.com/repos/substantial/rrule/issues/1","repository_url":"https://api.github.com/repos/substantial/rrule","labels_url":"https://api.github.com/repos/substantial/rrule/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/substantial/rrule/issues/1/comments","events_url":"https://api.github.com/repos/substantial/rrule/issues/1/events","html_url":"https://github.com/substantial/rrule/pull/1","id":346284604,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MTg2MTU1","number":1,"title":"Streamline webpack bundle","user":{"login":"nickarora","id":8520796,"node_id":"MDQ6VXNlcjg1MjA3OTY=","avatar_url":"https://avatars2.githubusercontent.com/u/8520796?v=4","gravatar_id":"","url":"https://api.github.com/users/nickarora","html_url":"https://github.com/nickarora","followers_url":"https://api.github.com/users/nickarora/followers","following_url":"https://api.github.com/users/nickarora/following{/other_user}","gists_url":"https://api.github.com/users/nickarora/gists{/gist_id}","starred_url":"https://api.github.com/users/nickarora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickarora/subscriptions","organizations_url":"https://api.github.com/users/nickarora/orgs","repos_url":"https://api.github.com/users/nickarora/repos","events_url":"https://api.github.com/users/nickarora/events{/privacy}","received_events_url":"https://api.github.com/users/nickarora/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-07-31T17:25:52Z","updated_at":"2018-07-31T18:00:22Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/substantial/rrule/pulls/1","html_url":"https://github.com/substantial/rrule/pull/1","diff_url":"https://github.com/substantial/rrule/pull/1.diff","patch_url":"https://github.com/substantial/rrule/pull/1.patch"},"body":"Not sure if this addresses the issues you were facing but take a look:\r\n\r\n👉 streamlines the build process so that `dist` is self-sufficent.  Meaning, you can start with an empty `dist` folder and webpack will generate everything necessary for the library and demo when you build.  previously, demo relied on the assumption that `dist/rrule` was built in advance.\r\n\r\n👉 `index.html` has been moved to the `demo` folder and just serves as a sortof \"template\".  To run the demo, open `dist/index.html` after building.\r\n\r\n👉 `demo/demo.js` has been deleted.  Instead, webpack compiles the coffee script directly.\r\n\r\n👉 the built `rrule` library is now named `dist/rrule.js`.  It was a little confusing having an `index.html` which was related to the demo and an `index.js` which was related to the library.\r\n\r\nFinally, at least as far as testing with the demo applications goes, the source maps appear to work.\r\n\r\n<img width=\"354\" alt=\"screen shot 2018-07-31 at 12 21 34 am\" src=\"https://user-images.githubusercontent.com/8520796/43475932-14da75a2-94ac-11e8-8685-3268b4515bf3.png\">\r\n\r\nHere you can see I was doing some logging and chrome was referencing the line numbers in the pre-transpiled source code.  I was also able to throw errors from the source or set break points in it."},"comment":{"url":"https://api.github.com/repos/substantial/rrule/issues/comments/409312835","html_url":"https://github.com/substantial/rrule/pull/1#issuecomment-409312835","issue_url":"https://api.github.com/repos/substantial/rrule/issues/1","id":409312835,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTMxMjgzNQ==","user":{"login":"davidgoli","id":44666,"node_id":"MDQ6VXNlcjQ0NjY2","avatar_url":"https://avatars3.githubusercontent.com/u/44666?v=4","gravatar_id":"","url":"https://api.github.com/users/davidgoli","html_url":"https://github.com/davidgoli","followers_url":"https://api.github.com/users/davidgoli/followers","following_url":"https://api.github.com/users/davidgoli/following{/other_user}","gists_url":"https://api.github.com/users/davidgoli/gists{/gist_id}","starred_url":"https://api.github.com/users/davidgoli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidgoli/subscriptions","organizations_url":"https://api.github.com/users/davidgoli/orgs","repos_url":"https://api.github.com/users/davidgoli/repos","events_url":"https://api.github.com/users/davidgoli/events{/privacy}","received_events_url":"https://api.github.com/users/davidgoli/received_events","type":"User","site_admin":false},"created_at":"2018-07-31T18:00:22Z","updated_at":"2018-07-31T18:00:22Z","author_association":"MEMBER","body":"@aaronjensen I like that approach better actually, I think this library *does* need to support transitive sourcemaps for web clients (unless maybe we don't need to webpack at all?), but otherwise we should try to provide the original es6 source instead, which is what I'd prefer."}}
{"actor":{"display_login":"davidgoli"}}