{"action":"created","comment":{"url":"https://api.github.com/repos/p4lang/p4c/pulls/comments/193163305","pull_request_review_id":126081622,"id":193163305,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzE2MzMwNQ==","diff_hunk":"@@ -98,6 +100,52 @@ class JSONGenerator {\n         out << std::endl << --indent << \"}\";\n     }\n \n+    template<typename T>\n+    void generate(const std::set<T> &v) {\n+        out << \"[\" << std::endl;\n+        if (v.size() > 0) {\n+            auto it = v.begin();\n+            out << ++indent;\n+            generate(*it);\n+            for (it++; it != v.end(); ++it) {\n+                out << \",\" << std::endl << indent;\n+                generate(*it);\n+            }\n+            out << std::endl << --indent;\n+        }\n+        out << \"]\";\n+    }","path":"ir/json_generator.h","position":27,"original_position":27,"commit_id":"99048392331a237fcdb8989a89c1658d6c0cb707","original_commit_id":"99048392331a237fcdb8989a89c1658d6c0cb707","user":{"login":"ChrisDodd","id":4070641,"node_id":"MDQ6VXNlcjQwNzA2NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/4070641?v=4","gravatar_id":"","url":"https://api.github.com/users/ChrisDodd","html_url":"https://github.com/ChrisDodd","followers_url":"https://api.github.com/users/ChrisDodd/followers","following_url":"https://api.github.com/users/ChrisDodd/following{/other_user}","gists_url":"https://api.github.com/users/ChrisDodd/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisDodd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisDodd/subscriptions","organizations_url":"https://api.github.com/users/ChrisDodd/orgs","repos_url":"https://api.github.com/users/ChrisDodd/repos","events_url":"https://api.github.com/users/ChrisDodd/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisDodd/received_events","type":"User","site_admin":false},"body":":+1: :+1: :bangbang:","created_at":"2018-06-05T17:49:14Z","updated_at":"2018-06-05T17:49:14Z","html_url":"https://github.com/p4lang/p4c/pull/1323#discussion_r193163305","pull_request_url":"https://api.github.com/repos/p4lang/p4c/pulls/1323","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/p4lang/p4c/pulls/comments/193163305"},"html":{"href":"https://github.com/p4lang/p4c/pull/1323#discussion_r193163305"},"pull_request":{"href":"https://api.github.com/repos/p4lang/p4c/pulls/1323"}},"in_reply_to_id":192915139},"pull_request":{"url":"https://api.github.com/repos/p4lang/p4c/pulls/1323","id":192559348,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyNTU5MzQ4","html_url":"https://github.com/p4lang/p4c/pull/1323","diff_url":"https://github.com/p4lang/p4c/pull/1323.diff","patch_url":"https://github.com/p4lang/p4c/pull/1323.patch","issue_url":"https://api.github.com/repos/p4lang/p4c/issues/1323","number":1323,"state":"closed","locked":false,"title":"std::set, std::map, ordered_set now allowed in IR","user":{"login":"evanches","id":9094940,"node_id":"MDQ6VXNlcjkwOTQ5NDA=","avatar_url":"https://avatars2.githubusercontent.com/u/9094940?v=4","gravatar_id":"","url":"https://api.github.com/users/evanches","html_url":"https://github.com/evanches","followers_url":"https://api.github.com/users/evanches/followers","following_url":"https://api.github.com/users/evanches/following{/other_user}","gists_url":"https://api.github.com/users/evanches/gists{/gist_id}","starred_url":"https://api.github.com/users/evanches/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evanches/subscriptions","organizations_url":"https://api.github.com/users/evanches/orgs","repos_url":"https://api.github.com/users/evanches/repos","events_url":"https://api.github.com/users/evanches/events{/privacy}","received_events_url":"https://api.github.com/users/evanches/received_events","type":"User","site_admin":false},"body":"A JSON loader/JSON generator template class was required for std::set, std::map, and ordered_set in order to include it as part of the IR.","created_at":"2018-06-05T00:08:25Z","updated_at":"2018-06-05T17:49:14Z","closed_at":"2018-06-05T00:32:53Z","merged_at":"2018-06-05T00:32:52Z","merge_commit_sha":"edbcd679ae406870c2fde1cedf93880e801ff04f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/p4lang/p4c/pulls/1323/commits","review_comments_url":"https://api.github.com/repos/p4lang/p4c/pulls/1323/comments","review_comment_url":"https://api.github.com/repos/p4lang/p4c/pulls/comments{/number}","comments_url":"https://api.github.com/repos/p4lang/p4c/issues/1323/comments","statuses_url":"https://api.github.com/repos/p4lang/p4c/statuses/99048392331a237fcdb8989a89c1658d6c0cb707","head":{"label":"p4lang:evanches/json_for_sets","ref":"evanches/json_for_sets","sha":"99048392331a237fcdb8989a89c1658d6c0cb707","user":{"login":"p4lang","id":10765181,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzY1MTgx","avatar_url":"https://avatars1.githubusercontent.com/u/10765181?v=4","gravatar_id":"","url":"https://api.github.com/users/p4lang","html_url":"https://github.com/p4lang","followers_url":"https://api.github.com/users/p4lang/followers","following_url":"https://api.github.com/users/p4lang/following{/other_user}","gists_url":"https://api.github.com/users/p4lang/gists{/gist_id}","starred_url":"https://api.github.com/users/p4lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p4lang/subscriptions","organizations_url":"https://api.github.com/users/p4lang/orgs","repos_url":"https://api.github.com/users/p4lang/repos","events_url":"https://api.github.com/users/p4lang/events{/privacy}","received_events_url":"https://api.github.com/users/p4lang/received_events","type":"Organization","site_admin":false},"repo":{"id":55433859,"node_id":"MDEwOlJlcG9zaXRvcnk1NTQzMzg1OQ==","name":"p4c","full_name":"p4lang/p4c","owner":{"login":"p4lang","id":10765181,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzY1MTgx","avatar_url":"https://avatars1.githubusercontent.com/u/10765181?v=4","gravatar_id":"","url":"https://api.github.com/users/p4lang","html_url":"https://github.com/p4lang","followers_url":"https://api.github.com/users/p4lang/followers","following_url":"https://api.github.com/users/p4lang/following{/other_user}","gists_url":"https://api.github.com/users/p4lang/gists{/gist_id}","starred_url":"https://api.github.com/users/p4lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p4lang/subscriptions","organizations_url":"https://api.github.com/users/p4lang/orgs","repos_url":"https://api.github.com/users/p4lang/repos","events_url":"https://api.github.com/users/p4lang/events{/privacy}","received_events_url":"https://api.github.com/users/p4lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/p4lang/p4c","description":"P4_16 prototype compiler","fork":false,"url":"https://api.github.com/repos/p4lang/p4c","forks_url":"https://api.github.com/repos/p4lang/p4c/forks","keys_url":"https://api.github.com/repos/p4lang/p4c/keys{/key_id}","collaborators_url":"https://api.github.com/repos/p4lang/p4c/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/p4lang/p4c/teams","hooks_url":"https://api.github.com/repos/p4lang/p4c/hooks","issue_events_url":"https://api.github.com/repos/p4lang/p4c/issues/events{/number}","events_url":"https://api.github.com/repos/p4lang/p4c/events","assignees_url":"https://api.github.com/repos/p4lang/p4c/assignees{/user}","branches_url":"https://api.github.com/repos/p4lang/p4c/branches{/branch}","tags_url":"https://api.github.com/repos/p4lang/p4c/tags","blobs_url":"https://api.github.com/repos/p4lang/p4c/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/p4lang/p4c/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/p4lang/p4c/git/refs{/sha}","trees_url":"https://api.github.com/repos/p4lang/p4c/git/trees{/sha}","statuses_url":"https://api.github.com/repos/p4lang/p4c/statuses/{sha}","languages_url":"https://api.github.com/repos/p4lang/p4c/languages","stargazers_url":"https://api.github.com/repos/p4lang/p4c/stargazers","contributors_url":"https://api.github.com/repos/p4lang/p4c/contributors","subscribers_url":"https://api.github.com/repos/p4lang/p4c/subscribers","subscription_url":"https://api.github.com/repos/p4lang/p4c/subscription","commits_url":"https://api.github.com/repos/p4lang/p4c/commits{/sha}","git_commits_url":"https://api.github.com/repos/p4lang/p4c/git/commits{/sha}","comments_url":"https://api.github.com/repos/p4lang/p4c/comments{/number}","issue_comment_url":"https://api.github.com/repos/p4lang/p4c/issues/comments{/number}","contents_url":"https://api.github.com/repos/p4lang/p4c/contents/{+path}","compare_url":"https://api.github.com/repos/p4lang/p4c/compare/{base}...{head}","merges_url":"https://api.github.com/repos/p4lang/p4c/merges","archive_url":"https://api.github.com/repos/p4lang/p4c/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/p4lang/p4c/downloads","issues_url":"https://api.github.com/repos/p4lang/p4c/issues{/number}","pulls_url":"https://api.github.com/repos/p4lang/p4c/pulls{/number}","milestones_url":"https://api.github.com/repos/p4lang/p4c/milestones{/number}","notifications_url":"https://api.github.com/repos/p4lang/p4c/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/p4lang/p4c/labels{/name}","releases_url":"https://api.github.com/repos/p4lang/p4c/releases{/id}","deployments_url":"https://api.github.com/repos/p4lang/p4c/deployments","created_at":"2016-04-04T18:12:32Z","updated_at":"2018-06-05T10:53:46Z","pushed_at":"2018-06-05T17:16:31Z","git_url":"git://github.com/p4lang/p4c.git","ssh_url":"git@github.com:p4lang/p4c.git","clone_url":"https://github.com/p4lang/p4c.git","svn_url":"https://github.com/p4lang/p4c","homepage":"","size":63761,"stargazers_count":113,"watchers_count":113,"language":"P4","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":73,"mirror_url":null,"archived":false,"open_issues_count":83,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":73,"open_issues":83,"watchers":113,"default_branch":"master"}},"base":{"label":"p4lang:master","ref":"master","sha":"ea8a54145d81980b851b0a0266675cdbe56a7f30","user":{"login":"p4lang","id":10765181,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzY1MTgx","avatar_url":"https://avatars1.githubusercontent.com/u/10765181?v=4","gravatar_id":"","url":"https://api.github.com/users/p4lang","html_url":"https://github.com/p4lang","followers_url":"https://api.github.com/users/p4lang/followers","following_url":"https://api.github.com/users/p4lang/following{/other_user}","gists_url":"https://api.github.com/users/p4lang/gists{/gist_id}","starred_url":"https://api.github.com/users/p4lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p4lang/subscriptions","organizations_url":"https://api.github.com/users/p4lang/orgs","repos_url":"https://api.github.com/users/p4lang/repos","events_url":"https://api.github.com/users/p4lang/events{/privacy}","received_events_url":"https://api.github.com/users/p4lang/received_events","type":"Organization","site_admin":false},"repo":{"id":55433859,"node_id":"MDEwOlJlcG9zaXRvcnk1NTQzMzg1OQ==","name":"p4c","full_name":"p4lang/p4c","owner":{"login":"p4lang","id":10765181,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNzY1MTgx","avatar_url":"https://avatars1.githubusercontent.com/u/10765181?v=4","gravatar_id":"","url":"https://api.github.com/users/p4lang","html_url":"https://github.com/p4lang","followers_url":"https://api.github.com/users/p4lang/followers","following_url":"https://api.github.com/users/p4lang/following{/other_user}","gists_url":"https://api.github.com/users/p4lang/gists{/gist_id}","starred_url":"https://api.github.com/users/p4lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/p4lang/subscriptions","organizations_url":"https://api.github.com/users/p4lang/orgs","repos_url":"https://api.github.com/users/p4lang/repos","events_url":"https://api.github.com/users/p4lang/events{/privacy}","received_events_url":"https://api.github.com/users/p4lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/p4lang/p4c","description":"P4_16 prototype compiler","fork":false,"url":"https://api.github.com/repos/p4lang/p4c","forks_url":"https://api.github.com/repos/p4lang/p4c/forks","keys_url":"https://api.github.com/repos/p4lang/p4c/keys{/key_id}","collaborators_url":"https://api.github.com/repos/p4lang/p4c/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/p4lang/p4c/teams","hooks_url":"https://api.github.com/repos/p4lang/p4c/hooks","issue_events_url":"https://api.github.com/repos/p4lang/p4c/issues/events{/number}","events_url":"https://api.github.com/repos/p4lang/p4c/events","assignees_url":"https://api.github.com/repos/p4lang/p4c/assignees{/user}","branches_url":"https://api.github.com/repos/p4lang/p4c/branches{/branch}","tags_url":"https://api.github.com/repos/p4lang/p4c/tags","blobs_url":"https://api.github.com/repos/p4lang/p4c/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/p4lang/p4c/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/p4lang/p4c/git/refs{/sha}","trees_url":"https://api.github.com/repos/p4lang/p4c/git/trees{/sha}","statuses_url":"https://api.github.com/repos/p4lang/p4c/statuses/{sha}","languages_url":"https://api.github.com/repos/p4lang/p4c/languages","stargazers_url":"https://api.github.com/repos/p4lang/p4c/stargazers","contributors_url":"https://api.github.com/repos/p4lang/p4c/contributors","subscribers_url":"https://api.github.com/repos/p4lang/p4c/subscribers","subscription_url":"https://api.github.com/repos/p4lang/p4c/subscription","commits_url":"https://api.github.com/repos/p4lang/p4c/commits{/sha}","git_commits_url":"https://api.github.com/repos/p4lang/p4c/git/commits{/sha}","comments_url":"https://api.github.com/repos/p4lang/p4c/comments{/number}","issue_comment_url":"https://api.github.com/repos/p4lang/p4c/issues/comments{/number}","contents_url":"https://api.github.com/repos/p4lang/p4c/contents/{+path}","compare_url":"https://api.github.com/repos/p4lang/p4c/compare/{base}...{head}","merges_url":"https://api.github.com/repos/p4lang/p4c/merges","archive_url":"https://api.github.com/repos/p4lang/p4c/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/p4lang/p4c/downloads","issues_url":"https://api.github.com/repos/p4lang/p4c/issues{/number}","pulls_url":"https://api.github.com/repos/p4lang/p4c/pulls{/number}","milestones_url":"https://api.github.com/repos/p4lang/p4c/milestones{/number}","notifications_url":"https://api.github.com/repos/p4lang/p4c/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/p4lang/p4c/labels{/name}","releases_url":"https://api.github.com/repos/p4lang/p4c/releases{/id}","deployments_url":"https://api.github.com/repos/p4lang/p4c/deployments","created_at":"2016-04-04T18:12:32Z","updated_at":"2018-06-05T10:53:46Z","pushed_at":"2018-06-05T17:16:31Z","git_url":"git://github.com/p4lang/p4c.git","ssh_url":"git@github.com:p4lang/p4c.git","clone_url":"https://github.com/p4lang/p4c.git","svn_url":"https://github.com/p4lang/p4c","homepage":"","size":63761,"stargazers_count":113,"watchers_count":113,"language":"P4","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":73,"mirror_url":null,"archived":false,"open_issues_count":83,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":73,"open_issues":83,"watchers":113,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/p4lang/p4c/pulls/1323"},"html":{"href":"https://github.com/p4lang/p4c/pull/1323"},"issue":{"href":"https://api.github.com/repos/p4lang/p4c/issues/1323"},"comments":{"href":"https://api.github.com/repos/p4lang/p4c/issues/1323/comments"},"review_comments":{"href":"https://api.github.com/repos/p4lang/p4c/pulls/1323/comments"},"review_comment":{"href":"https://api.github.com/repos/p4lang/p4c/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/p4lang/p4c/pulls/1323/commits"},"statuses":{"href":"https://api.github.com/repos/p4lang/p4c/statuses/99048392331a237fcdb8989a89c1658d6c0cb707"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ChrisDodd"}}