{"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments/184641549","pull_request_review_id":115880196,"id":184641549,"diff_hunk":"@@ -200,6 +200,9 @@ live_migration_flag = VIR_MIGRATE_UNDEFINE_SOURCE, VIR_MIGRATE_PEER2PEER, VIR_MI\n     <% else %>\n block_migration_flag = VIR_MIGRATE_UNDEFINE_SOURCE, VIR_MIGRATE_PEER2PEER, VIR_MIGRATE_NON_SHARED_INC, VIR_MIGRATE_LIVE\n     <% end %>\n+# Timeout migration if less than 1MB/s RAM can be copied","path":"chef/cookbooks/nova/templates/default/nova.conf.erb","position":4,"original_position":4,"commit_id":"cb2840dfdc9cf00a63bc080ff296e5df3a5f9d22","original_commit_id":"cb2840dfdc9cf00a63bc080ff296e5df3a5f9d22","user":{"login":"jsuchome","id":910000,"avatar_url":"https://avatars2.githubusercontent.com/u/910000?v=4","gravatar_id":"","url":"https://api.github.com/users/jsuchome","html_url":"https://github.com/jsuchome","followers_url":"https://api.github.com/users/jsuchome/followers","following_url":"https://api.github.com/users/jsuchome/following{/other_user}","gists_url":"https://api.github.com/users/jsuchome/gists{/gist_id}","starred_url":"https://api.github.com/users/jsuchome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsuchome/subscriptions","organizations_url":"https://api.github.com/users/jsuchome/orgs","repos_url":"https://api.github.com/users/jsuchome/repos","events_url":"https://api.github.com/users/jsuchome/events{/privacy}","received_events_url":"https://api.github.com/users/jsuchome/received_events","type":"User","site_admin":false},"body":"Thist comment belongs to the second option","created_at":"2018-04-27T09:49:34Z","updated_at":"2018-04-27T09:49:34Z","html_url":"https://github.com/crowbar/crowbar-openstack/pull/1619#discussion_r184641549","pull_request_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/1619","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments/184641549"},"html":{"href":"https://github.com/crowbar/crowbar-openstack/pull/1619#discussion_r184641549"},"pull_request":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/1619"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/1619","id":180241649,"html_url":"https://github.com/crowbar/crowbar-openstack/pull/1619","diff_url":"https://github.com/crowbar/crowbar-openstack/pull/1619.diff","patch_url":"https://github.com/crowbar/crowbar-openstack/pull/1619.patch","issue_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/1619","number":1619,"state":"open","locked":false,"title":"nova: disable progress timeout for live migration (bsc#1091190)","user":{"login":"dirkmueller","id":1029152,"avatar_url":"https://avatars1.githubusercontent.com/u/1029152?v=4","gravatar_id":"","url":"https://api.github.com/users/dirkmueller","html_url":"https://github.com/dirkmueller","followers_url":"https://api.github.com/users/dirkmueller/followers","following_url":"https://api.github.com/users/dirkmueller/following{/other_user}","gists_url":"https://api.github.com/users/dirkmueller/gists{/gist_id}","starred_url":"https://api.github.com/users/dirkmueller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirkmueller/subscriptions","organizations_url":"https://api.github.com/users/dirkmueller/orgs","repos_url":"https://api.github.com/users/dirkmueller/repos","events_url":"https://api.github.com/users/dirkmueller/events{/privacy}","received_events_url":"https://api.github.com/users/dirkmueller/received_events","type":"User","site_admin":false},"body":"The progress timeout is unreliable and was already disabled\r\nby default in pike, however it is still enabled in Newton, hence\r\nthis is going to be backported. Also be a little bit more generous\r\nto slow compute nodes and allow migration to as slow as 1MByte/s\r\nbefore aborting it. this tremendeously helps live migration to\r\nsucceed on very busy compute nodes (where migrating away busy\r\nworkload is the best thing to do)\r\n\r\nAlso remove an outdated setting that is defaulting to 30 already.","created_at":"2018-04-09T08:25:36Z","updated_at":"2018-04-27T09:49:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8a9810c2632e44bc1a67590c6d307e02f8b3a985","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":711258318,"url":"https://api.github.com/repos/crowbar/crowbar-openstack/labels/needs%20backport%20to%20SOC7","name":"needs backport to SOC7","color":"0052cc","default":false}],"milestone":{"url":"https://api.github.com/repos/crowbar/crowbar-openstack/milestones/7","html_url":"https://github.com/crowbar/crowbar-openstack/milestone/7","labels_url":"https://api.github.com/repos/crowbar/crowbar-openstack/milestones/7/labels","id":3289976,"number":7,"title":"Cloud 8 Update1","description":null,"creator":{"login":"dirkmueller","id":1029152,"avatar_url":"https://avatars1.githubusercontent.com/u/1029152?v=4","gravatar_id":"","url":"https://api.github.com/users/dirkmueller","html_url":"https://github.com/dirkmueller","followers_url":"https://api.github.com/users/dirkmueller/followers","following_url":"https://api.github.com/users/dirkmueller/following{/other_user}","gists_url":"https://api.github.com/users/dirkmueller/gists{/gist_id}","starred_url":"https://api.github.com/users/dirkmueller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirkmueller/subscriptions","organizations_url":"https://api.github.com/users/dirkmueller/orgs","repos_url":"https://api.github.com/users/dirkmueller/repos","events_url":"https://api.github.com/users/dirkmueller/events{/privacy}","received_events_url":"https://api.github.com/users/dirkmueller/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":2,"state":"open","created_at":"2018-04-23T14:48:00Z","updated_at":"2018-04-27T09:18:45Z","due_on":"2018-05-31T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/1619/commits","review_comments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/1619/comments","review_comment_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/1619/comments","statuses_url":"https://api.github.com/repos/crowbar/crowbar-openstack/statuses/cb2840dfdc9cf00a63bc080ff296e5df3a5f9d22","head":{"label":"dirkmueller:migration","ref":"migration","sha":"cb2840dfdc9cf00a63bc080ff296e5df3a5f9d22","user":{"login":"dirkmueller","id":1029152,"avatar_url":"https://avatars1.githubusercontent.com/u/1029152?v=4","gravatar_id":"","url":"https://api.github.com/users/dirkmueller","html_url":"https://github.com/dirkmueller","followers_url":"https://api.github.com/users/dirkmueller/followers","following_url":"https://api.github.com/users/dirkmueller/following{/other_user}","gists_url":"https://api.github.com/users/dirkmueller/gists{/gist_id}","starred_url":"https://api.github.com/users/dirkmueller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirkmueller/subscriptions","organizations_url":"https://api.github.com/users/dirkmueller/orgs","repos_url":"https://api.github.com/users/dirkmueller/repos","events_url":"https://api.github.com/users/dirkmueller/events{/privacy}","received_events_url":"https://api.github.com/users/dirkmueller/received_events","type":"User","site_admin":false},"repo":{"id":41291687,"name":"crowbar-openstack","full_name":"dirkmueller/crowbar-openstack","owner":{"login":"dirkmueller","id":1029152,"avatar_url":"https://avatars1.githubusercontent.com/u/1029152?v=4","gravatar_id":"","url":"https://api.github.com/users/dirkmueller","html_url":"https://github.com/dirkmueller","followers_url":"https://api.github.com/users/dirkmueller/followers","following_url":"https://api.github.com/users/dirkmueller/following{/other_user}","gists_url":"https://api.github.com/users/dirkmueller/gists{/gist_id}","starred_url":"https://api.github.com/users/dirkmueller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirkmueller/subscriptions","organizations_url":"https://api.github.com/users/dirkmueller/orgs","repos_url":"https://api.github.com/users/dirkmueller/repos","events_url":"https://api.github.com/users/dirkmueller/events{/privacy}","received_events_url":"https://api.github.com/users/dirkmueller/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dirkmueller/crowbar-openstack","description":"Openstack deployment for Crowbar","fork":true,"url":"https://api.github.com/repos/dirkmueller/crowbar-openstack","forks_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/forks","keys_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/teams","hooks_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/hooks","issue_events_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/issues/events{/number}","events_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/events","assignees_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/assignees{/user}","branches_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/branches{/branch}","tags_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/tags","blobs_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/statuses/{sha}","languages_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/languages","stargazers_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/stargazers","contributors_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/contributors","subscribers_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/subscribers","subscription_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/subscription","commits_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/contents/{+path}","compare_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/merges","archive_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/downloads","issues_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/issues{/number}","pulls_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/pulls{/number}","milestones_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/milestones{/number}","notifications_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/labels{/name}","releases_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/releases{/id}","deployments_url":"https://api.github.com/repos/dirkmueller/crowbar-openstack/deployments","created_at":"2015-08-24T08:33:53Z","updated_at":"2018-04-06T20:28:19Z","pushed_at":"2018-04-27T09:40:45Z","git_url":"git://github.com/dirkmueller/crowbar-openstack.git","ssh_url":"git@github.com:dirkmueller/crowbar-openstack.git","clone_url":"https://github.com/dirkmueller/crowbar-openstack.git","svn_url":"https://github.com/dirkmueller/crowbar-openstack","homepage":null,"size":21018,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:master","ref":"master","sha":"1dad1cc984d0a1ee2894aa9427be1e09c7bcf7d9","user":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars2.githubusercontent.com/u/2910205?v=4","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":39006903,"name":"crowbar-openstack","full_name":"crowbar/crowbar-openstack","owner":{"login":"crowbar","id":2910205,"avatar_url":"https://avatars2.githubusercontent.com/u/2910205?v=4","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crowbar/crowbar-openstack","description":"Openstack deployment for Crowbar","fork":false,"url":"https://api.github.com/repos/crowbar/crowbar-openstack","forks_url":"https://api.github.com/repos/crowbar/crowbar-openstack/forks","keys_url":"https://api.github.com/repos/crowbar/crowbar-openstack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/crowbar-openstack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/crowbar-openstack/teams","hooks_url":"https://api.github.com/repos/crowbar/crowbar-openstack/hooks","issue_events_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/crowbar-openstack/events","assignees_url":"https://api.github.com/repos/crowbar/crowbar-openstack/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/crowbar-openstack/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/crowbar-openstack/tags","blobs_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/crowbar-openstack/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/crowbar-openstack/languages","stargazers_url":"https://api.github.com/repos/crowbar/crowbar-openstack/stargazers","contributors_url":"https://api.github.com/repos/crowbar/crowbar-openstack/contributors","subscribers_url":"https://api.github.com/repos/crowbar/crowbar-openstack/subscribers","subscription_url":"https://api.github.com/repos/crowbar/crowbar-openstack/subscription","commits_url":"https://api.github.com/repos/crowbar/crowbar-openstack/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/crowbar-openstack/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/comments{/number}","contents_url":"https://api.github.com/repos/crowbar/crowbar-openstack/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/crowbar-openstack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/crowbar-openstack/merges","archive_url":"https://api.github.com/repos/crowbar/crowbar-openstack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/crowbar-openstack/downloads","issues_url":"https://api.github.com/repos/crowbar/crowbar-openstack/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/crowbar-openstack/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/crowbar-openstack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/crowbar-openstack/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/crowbar-openstack/releases{/id}","deployments_url":"https://api.github.com/repos/crowbar/crowbar-openstack/deployments","created_at":"2015-07-13T10:55:33Z","updated_at":"2018-04-27T09:34:53Z","pushed_at":"2018-04-27T09:40:47Z","git_url":"git://github.com/crowbar/crowbar-openstack.git","ssh_url":"git@github.com:crowbar/crowbar-openstack.git","clone_url":"https://github.com/crowbar/crowbar-openstack.git","svn_url":"https://github.com/crowbar/crowbar-openstack","homepage":null,"size":20982,"stargazers_count":15,"watchers_count":15,"language":"Ruby","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":81,"mirror_url":null,"archived":false,"open_issues_count":73,"license":null,"forks":81,"open_issues":73,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/1619"},"html":{"href":"https://github.com/crowbar/crowbar-openstack/pull/1619"},"issue":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/1619"},"comments":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/issues/1619/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/1619/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/pulls/1619/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/crowbar-openstack/statuses/cb2840dfdc9cf00a63bc080ff296e5df3a5f9d22"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jsuchome"}}