{"action":"created","issue":{"url":"https://api.github.com/repos/mpogue2/SquareDesk/issues/368","repository_url":"https://api.github.com/repos/mpogue2/SquareDesk","labels_url":"https://api.github.com/repos/mpogue2/SquareDesk/issues/368/labels{/name}","comments_url":"https://api.github.com/repos/mpogue2/SquareDesk/issues/368/comments","events_url":"https://api.github.com/repos/mpogue2/SquareDesk/issues/368/events","html_url":"https://github.com/mpogue2/SquareDesk/issues/368","id":331008913,"node_id":"MDU6SXNzdWUzMzEwMDg5MTM=","number":368,"title":"Bug: misc bugs around File > Export Play Data...","user":{"login":"mpogue2","id":6316003,"node_id":"MDQ6VXNlcjYzMTYwMDM=","avatar_url":"https://avatars3.githubusercontent.com/u/6316003?v=4","gravatar_id":"","url":"https://api.github.com/users/mpogue2","html_url":"https://github.com/mpogue2","followers_url":"https://api.github.com/users/mpogue2/followers","following_url":"https://api.github.com/users/mpogue2/following{/other_user}","gists_url":"https://api.github.com/users/mpogue2/gists{/gist_id}","starred_url":"https://api.github.com/users/mpogue2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpogue2/subscriptions","organizations_url":"https://api.github.com/users/mpogue2/orgs","repos_url":"https://api.github.com/users/mpogue2/repos","events_url":"https://api.github.com/users/mpogue2/events{/privacy}","received_events_url":"https://api.github.com/users/mpogue2/received_events","type":"User","site_admin":false},"labels":[{"id":574649020,"node_id":"MDU6TGFiZWw1NzQ2NDkwMjA=","url":"https://api.github.com/repos/mpogue2/SquareDesk/labels/bug","name":"bug","color":"ee0701","default":true}],"state":"open","locked":false,"assignee":{"login":"danlyke","id":88919,"node_id":"MDQ6VXNlcjg4OTE5","avatar_url":"https://avatars0.githubusercontent.com/u/88919?v=4","gravatar_id":"","url":"https://api.github.com/users/danlyke","html_url":"https://github.com/danlyke","followers_url":"https://api.github.com/users/danlyke/followers","following_url":"https://api.github.com/users/danlyke/following{/other_user}","gists_url":"https://api.github.com/users/danlyke/gists{/gist_id}","starred_url":"https://api.github.com/users/danlyke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danlyke/subscriptions","organizations_url":"https://api.github.com/users/danlyke/orgs","repos_url":"https://api.github.com/users/danlyke/repos","events_url":"https://api.github.com/users/danlyke/events{/privacy}","received_events_url":"https://api.github.com/users/danlyke/received_events","type":"User","site_admin":false},"assignees":[{"login":"danlyke","id":88919,"node_id":"MDQ6VXNlcjg4OTE5","avatar_url":"https://avatars0.githubusercontent.com/u/88919?v=4","gravatar_id":"","url":"https://api.github.com/users/danlyke","html_url":"https://github.com/danlyke","followers_url":"https://api.github.com/users/danlyke/followers","following_url":"https://api.github.com/users/danlyke/following{/other_user}","gists_url":"https://api.github.com/users/danlyke/gists{/gist_id}","starred_url":"https://api.github.com/users/danlyke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danlyke/subscriptions","organizations_url":"https://api.github.com/users/danlyke/orgs","repos_url":"https://api.github.com/users/danlyke/repos","events_url":"https://api.github.com/users/danlyke/events{/privacy}","received_events_url":"https://api.github.com/users/danlyke/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-06-10T22:37:20Z","updated_at":"2018-06-28T00:14:32Z","closed_at":null,"author_association":"OWNER","body":"Misc comments, and some bugs, maybe?\r\n1) I think it would be good to put a separator above Export Play Data... in the File menu, since this is a different function from Export Song Data... (minor feature request!)\r\n2) Maybe Export Song Data should be renamed or moved, because it's used very infrequently compared to Export Song Data?\r\n3) At first it wouldn't export anything at all to the file.  I'm sure that I've played many songs!  Or, is this a new table, that is only now being populated?  I had both checkboxes checked.  But I also tried to set the start date to a year ago.  Nothing.  After some experimentation, I think PART of the problem is that the default from and to are backwards.  It was supposed to be 1 day, but the from is today and the to is yesterday.\r\n4) I tried playing a song!  Now it exports exactly one song.\r\n5) Export appears to be in local time -- I think in general datetimes that are imported or exported should all be UTC...  If we need local time (and I think that's a nice idea!) maybe we could have a third column, and the header would be either \"local time\" or \"Pacific Time\" (using the standard naming convention for timezones).  Or, maybe to make it easier to delete UTC for those who don't want it, we could make the order something like \"Song\", \"play time (PST)\", \"play time (UTC)\".\r\n6) Filenames with double quotes in them need to be treated special, in order that the output file is valid CSV (i.e. each double quote in the string needs to be replaced with two double quotes, before the opening and closing double quotes are added).  Currently, a file called ESP 451 - 'Cuda copy \"3\" shows up as \"ESP 451 - 'Cuda copy \"3\"\",\"2018-06-10 15:18:39\" and it should be\r\n\"ESP 451 - 'Cuda copy \"\"3\"\"\",\"2018-06-10 15:18:39\"\r\n7) The song \"POP - Awoo (Sofi Tukker feat. Betta Lemme).m4a\" exports as \" Betta Lemme)\",\"2018-06-10 15:26:40\", which chops off a bunch of the first characters of the filename.  I suspect that filenames with periods in them are the root cause of this.\r\n8) Title of the dialog \"Export Song Play History\" should probably match the name of the command in the menu, which is current \"Export Play Data\".  I actually like \"Export Song Play History\" better, because it seems more descriptive.\r\n9) If I choose the same filename as before to export to, it warns me, but on my way back into the dialog, which is probably a non-standard way to do it.  Consider this alternative:  Dialog that pops up does NOT contain a File field and a Choose button, but it does contain all the other stuff that it has now.  Then, clicking OK pops up the Save As dialog (defaulting to the last folder that the user chose, with a title something like \"Save Play History Data As...\").  Now, if I choose the same filename, the \"replace?\" dialog comes up, as expected.  Clicking \"Cancel\" brings you back to the \"export song play history\" dialog.  Clicking \"Replace\" does the save.  It's still the same two steps, but it's in the more standard order (save dialog last), I think..."},"comment":{"url":"https://api.github.com/repos/mpogue2/SquareDesk/issues/comments/400869869","html_url":"https://github.com/mpogue2/SquareDesk/issues/368#issuecomment-400869869","issue_url":"https://api.github.com/repos/mpogue2/SquareDesk/issues/368","id":400869869,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMDg2OTg2OQ==","user":{"login":"danlyke","id":88919,"node_id":"MDQ6VXNlcjg4OTE5","avatar_url":"https://avatars0.githubusercontent.com/u/88919?v=4","gravatar_id":"","url":"https://api.github.com/users/danlyke","html_url":"https://github.com/danlyke","followers_url":"https://api.github.com/users/danlyke/followers","following_url":"https://api.github.com/users/danlyke/following{/other_user}","gists_url":"https://api.github.com/users/danlyke/gists{/gist_id}","starred_url":"https://api.github.com/users/danlyke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danlyke/subscriptions","organizations_url":"https://api.github.com/users/danlyke/orgs","repos_url":"https://api.github.com/users/danlyke/repos","events_url":"https://api.github.com/users/danlyke/events{/privacy}","received_events_url":"https://api.github.com/users/danlyke/received_events","type":"User","site_admin":false},"created_at":"2018-06-28T00:14:32Z","updated_at":"2018-06-28T00:14:32Z","author_association":"COLLABORATOR","body":"Bunch of changes in 9a217110fa0fbfec2ad164159e66f489dcb3a534\r\n\r\n1. Added\r\n2. Yeah, kinda seems like these need to go into some sort of sub-menu or something.\r\n3. Whoops, had some things backwards, sideways and upsides down, including... well... it was all broken.\r\n4. It exports more than that for me now!\r\n5. Added a local time column, moved the UTC time right.\r\n6. Went with backslash escaping (because I had the code in there but it had a typo). If this is an issue can easily do double quote escaping.\r\n7. Fixed. It turns out the problem was with how currentMP3filename was getting set(!)\r\n8. Changed the menu: 4b039ec2aef0a3d976b6b5257ba67a33b83b8e67\r\n9. Good idea. Implemented that.\r\n"}}
{"actor":{"display_login":"danlyke"}}