{"action":"created","issue":{"url":"https://api.github.com/repos/grpc/grpc/issues/15420","repository_url":"https://api.github.com/repos/grpc/grpc","labels_url":"https://api.github.com/repos/grpc/grpc/issues/15420/labels{/name}","comments_url":"https://api.github.com/repos/grpc/grpc/issues/15420/comments","events_url":"https://api.github.com/repos/grpc/grpc/issues/15420/events","html_url":"https://github.com/grpc/grpc/pull/15420","id":323840108,"number":15420,"title":"Rename a flag in c-ares driver, add a test for cancelled queries","user":{"login":"apolcyn","id":9566254,"avatar_url":"https://avatars1.githubusercontent.com/u/9566254?v=4","gravatar_id":"","url":"https://api.github.com/users/apolcyn","html_url":"https://github.com/apolcyn","followers_url":"https://api.github.com/users/apolcyn/followers","following_url":"https://api.github.com/users/apolcyn/following{/other_user}","gists_url":"https://api.github.com/users/apolcyn/gists{/gist_id}","starred_url":"https://api.github.com/users/apolcyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apolcyn/subscriptions","organizations_url":"https://api.github.com/users/apolcyn/orgs","repos_url":"https://api.github.com/users/apolcyn/repos","events_url":"https://api.github.com/users/apolcyn/events{/privacy}","received_events_url":"https://api.github.com/users/apolcyn/received_events","type":"User","site_admin":false},"labels":[{"id":166332702,"url":"https://api.github.com/repos/grpc/grpc/labels/area/core","name":"area/core","color":"efdb40","default":false}],"state":"closed","locked":false,"assignee":{"login":"markdroth","id":18664614,"avatar_url":"https://avatars2.githubusercontent.com/u/18664614?v=4","gravatar_id":"","url":"https://api.github.com/users/markdroth","html_url":"https://github.com/markdroth","followers_url":"https://api.github.com/users/markdroth/followers","following_url":"https://api.github.com/users/markdroth/following{/other_user}","gists_url":"https://api.github.com/users/markdroth/gists{/gist_id}","starred_url":"https://api.github.com/users/markdroth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markdroth/subscriptions","organizations_url":"https://api.github.com/users/markdroth/orgs","repos_url":"https://api.github.com/users/markdroth/repos","events_url":"https://api.github.com/users/markdroth/events{/privacy}","received_events_url":"https://api.github.com/users/markdroth/received_events","type":"User","site_admin":false},"assignees":[{"login":"markdroth","id":18664614,"avatar_url":"https://avatars2.githubusercontent.com/u/18664614?v=4","gravatar_id":"","url":"https://api.github.com/users/markdroth","html_url":"https://github.com/markdroth","followers_url":"https://api.github.com/users/markdroth/followers","following_url":"https://api.github.com/users/markdroth/following{/other_user}","gists_url":"https://api.github.com/users/markdroth/gists{/gist_id}","starred_url":"https://api.github.com/users/markdroth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markdroth/subscriptions","organizations_url":"https://api.github.com/users/markdroth/orgs","repos_url":"https://api.github.com/users/markdroth/repos","events_url":"https://api.github.com/users/markdroth/events{/privacy}","received_events_url":"https://api.github.com/users/markdroth/received_events","type":"User","site_admin":false}],"milestone":null,"comments":24,"created_at":"2018-05-17T01:20:39Z","updated_at":"2018-05-18T19:36:51Z","closed_at":"2018-05-18T19:36:51Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/grpc/grpc/pulls/15420","html_url":"https://github.com/grpc/grpc/pull/15420","diff_url":"https://github.com/grpc/grpc/pull/15420.diff","patch_url":"https://github.com/grpc/grpc/pull/15420.patch"},"body":"Bringing this out of https://github.com/grpc/grpc/pull/15179\r\n\r\nThis changes the c-ares fd shutdown/destroy logic to use ref counts rather than `shutdown` and `readable/writeable_registered` flags, which makes it simpler to convert to C++ (which in turn simplifies porting to windows). Also adds a test for DNS queries that are cancelled.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/grpc/grpc/15420)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/grpc/grpc/issues/comments/390311015","html_url":"https://github.com/grpc/grpc/pull/15420#issuecomment-390311015","issue_url":"https://api.github.com/repos/grpc/grpc/issues/15420","id":390311015,"user":{"login":"apolcyn","id":9566254,"avatar_url":"https://avatars1.githubusercontent.com/u/9566254?v=4","gravatar_id":"","url":"https://api.github.com/users/apolcyn","html_url":"https://github.com/apolcyn","followers_url":"https://api.github.com/users/apolcyn/followers","following_url":"https://api.github.com/users/apolcyn/following{/other_user}","gists_url":"https://api.github.com/users/apolcyn/gists{/gist_id}","starred_url":"https://api.github.com/users/apolcyn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apolcyn/subscriptions","organizations_url":"https://api.github.com/users/apolcyn/orgs","repos_url":"https://api.github.com/users/apolcyn/repos","events_url":"https://api.github.com/users/apolcyn/events{/privacy}","received_events_url":"https://api.github.com/users/apolcyn/received_events","type":"User","site_admin":false},"created_at":"2018-05-18T19:36:51Z","updated_at":"2018-05-18T19:36:51Z","author_association":"CONTRIBUTOR","body":"Since there's turning out to be a lot of overlap between this and https://github.com/grpc/grpc/pull/15435, I've merged the changes in this PR into https://github.com/grpc/grpc/pull/15435, and I'll close this one."}}
{"actor":{"display_login":"apolcyn"}}