{"action":"created","issue":{"url":"https://api.github.com/repos/cnlohr/colorchord/issues/60","repository_url":"https://api.github.com/repos/cnlohr/colorchord","labels_url":"https://api.github.com/repos/cnlohr/colorchord/issues/60/labels{/name}","comments_url":"https://api.github.com/repos/cnlohr/colorchord/issues/60/comments","events_url":"https://api.github.com/repos/cnlohr/colorchord/issues/60/events","html_url":"https://github.com/cnlohr/colorchord/issues/60","id":295382618,"number":60,"title":"Unrecoverable crash when setting \tgAMP_1_IIR_BITS to 0","user":{"login":"Fireflaker","id":22672963,"avatar_url":"https://avatars3.githubusercontent.com/u/22672963?v=4","gravatar_id":"","url":"https://api.github.com/users/Fireflaker","html_url":"https://github.com/Fireflaker","followers_url":"https://api.github.com/users/Fireflaker/followers","following_url":"https://api.github.com/users/Fireflaker/following{/other_user}","gists_url":"https://api.github.com/users/Fireflaker/gists{/gist_id}","starred_url":"https://api.github.com/users/Fireflaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fireflaker/subscriptions","organizations_url":"https://api.github.com/users/Fireflaker/orgs","repos_url":"https://api.github.com/users/Fireflaker/repos","events_url":"https://api.github.com/users/Fireflaker/events{/privacy}","received_events_url":"https://api.github.com/users/Fireflaker/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-02-08T04:34:17Z","updated_at":"2018-02-16T22:27:23Z","closed_at":null,"author_association":"NONE","body":"When I played around with the parameters, setting gAMP_1_IIR_BITS to 0 crashed the program embedded on ESP8266 and need to be reflashed."},"comment":{"url":"https://api.github.com/repos/cnlohr/colorchord/issues/comments/366376712","html_url":"https://github.com/cnlohr/colorchord/issues/60#issuecomment-366376712","issue_url":"https://api.github.com/repos/cnlohr/colorchord/issues/60","id":366376712,"user":{"login":"cnlohr","id":2748168,"avatar_url":"https://avatars2.githubusercontent.com/u/2748168?v=4","gravatar_id":"","url":"https://api.github.com/users/cnlohr","html_url":"https://github.com/cnlohr","followers_url":"https://api.github.com/users/cnlohr/followers","following_url":"https://api.github.com/users/cnlohr/following{/other_user}","gists_url":"https://api.github.com/users/cnlohr/gists{/gist_id}","starred_url":"https://api.github.com/users/cnlohr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cnlohr/subscriptions","organizations_url":"https://api.github.com/users/cnlohr/orgs","repos_url":"https://api.github.com/users/cnlohr/repos","events_url":"https://api.github.com/users/cnlohr/events{/privacy}","received_events_url":"https://api.github.com/users/cnlohr/received_events","type":"User","site_admin":false},"created_at":"2018-02-16T22:27:22Z","updated_at":"2018-02-16T22:27:22Z","author_association":"OWNER","body":"You actually can operate at 160MHz!  We did that on a commercial project.  I don't remember what the change was, I actually think it JustWorked™. \r\n\r\nSo, I really don't see why setting AMP_1_IIR_BITS in the code would cause an issue, and I'm still not near anything I could examine it further with at the moment.  It looks like perhaps there could be an overflow of sorts. There is some suspicious logic around \r\n\r\n```\r\n\t\tnote_peak_amps[i] -= note_peak_amps[i]>>AMP_1_IIR_BITS;\r\n```\r\n\r\nSo, a possible solution would be to ``` if( !AMP_1_IIR_BITS) ``` it out. That said, I don't actually understand the purpose of why you would want to set it to 0.  It would make the output schizophrenic. "}}
{"actor":{"display_login":"cnlohr"}}