{"push_id":2554065973,"size":41,"distinct_size":41,"ref":"refs/heads/master","head":"a11970210e9c001dfe11fcbfb14765881bd1877f","before":"b7070f14510c862f034f2988dd2739573babd8f1","commits":[{"sha":"fe0f1433d7a21ff38cb5143e079094cdb9ed2449","author":{"name":"kaipi","email":"13332955a35a14793b44c09e53e6322b16be5b5a@google.com"},"message":"Fix an issue where second level framework dependencies resources wouldn't get deduplicated.\n\nRELNOTES: None\nPiperOrigin-RevId: 192283420","distinct":true,"url":"https://api.github.com/repos/thomasvl/rules_apple/commits/fe0f1433d7a21ff38cb5143e079094cdb9ed2449"},{"sha":"536b6c15815c847075de7a63624fabb3d428be0a","author":{"name":"thomasvl","email":"7669cbe5a9c997b64160cb048e7966fcb349daf5@google.com"},"message":"Document resources/structured_resources.\n\nPiperOrigin-RevId: 192327911","distinct":true,"url":"https://api.github.com/repos/thomasvl/rules_apple/commits/536b6c15815c847075de7a63624fabb3d428be0a"},{"sha":"a9ec1736dc57be693ad22c233ea489e034a829e4","author":{"name":"thomasvl","email":"7669cbe5a9c997b64160cb048e7966fcb349daf5@google.com"},"message":"Ensure app_icons and launch_images have paths that match what is expected.\n\nSince there are also tests during bundling, do a subset of tests to help catch\nwhat is likely a bad glob() usage. The current resource flows would result in\ntwo places needed checks, so leave todos about how to avoid some of the\nduplication and where things could/should end up more strict.\n\nPiperOrigin-RevId: 192481148","distinct":true,"url":"https://api.github.com/repos/thomasvl/rules_apple/commits/a9ec1736dc57be693ad22c233ea489e034a829e4"},{"sha":"811d72da4ba6031b99d1c11b3b7f1200139f5b90","author":{"name":"allevato","email":"d0f62bd4a32d68b34c76909ea8a029451feecd78@google.com"},"message":"Update bundling aspect to support swift_library targets that don't propagate AppleResourceInfo.\n\nThis is for a future refactoring of the Swift rules and how resources are handled there.\n\nRELNOTES: None.\nPiperOrigin-RevId: 192614690","distinct":true,"url":"https://api.github.com/repos/thomasvl/rules_apple/commits/811d72da4ba6031b99d1c11b3b7f1200139f5b90"},{"sha":"75f409141f27521c672a17ab5f0fc72cb2c599a6","author":{"name":"thomasvl","email":"7669cbe5a9c997b64160cb048e7966fcb349daf5@google.com"},"message":"Validation the assets on app_icons for iOS StickerPack extensions.\n\nUsing Xcode 9.3, created a new Sticker Pack App, and add both sticker\ntypes to it to check the assets structure on disk:\n\n  stickers/Info.plist\n  stickers StickerPackExtension/Stickers.xcstickers/iMessage App Icon.stickersiconset/Contents.json\n  stickers StickerPackExtension/Stickers.xcstickers/Contents.json\n  stickers StickerPackExtension/Stickers.xcstickers/Sticker Pack.stickerpack/Sticker.sticker/Contents.json\n  stickers StickerPackExtension/Stickers.xcstickers/Sticker Pack.stickerpack/Sticker Sequence.stickersequence/Contents.json\n  stickers StickerPackExtension/Stickers.xcstickers/Sticker Pack.stickerpack/Contents.json\n  stickers StickerPackExtension/Info.plist\n  stickers.xcodeproj/project.pbxproj\n  stickers.xcodeproj/project.xcworkspace/contents.xcworkspacedata\n  stickers.xcodeproj/project.xcworkspace/xcshareddata/IDEWorkspaceChecks.plist\n\nAlso switch over the old app_icons/launch_images validation to a new helper\nto better streamline the callers.\n\nPiperOrigin-RevId: 192765736","distinct":true,"url":"https://api.github.com/repos/thomasvl/rules_apple/commits/75f409141f27521c672a17ab5f0fc72cb2c599a6"},{"sha":"34fab13c241104062bc44f150591eab3a091b387","author":{"name":"kaipi","email":"13332955a35a14793b44c09e53e6322b16be5b5a@google.com"},"message":"Fix swiftstdlibtool args ordering\n\nRELNOTES: None\nPiperOrigin-RevId: 192770862","distinct":true,"url":"https://api.github.com/repos/thomasvl/rules_apple/commits/34fab13c241104062bc44f150591eab3a091b387"},{"sha":"347e95cf8137bda035e7e206d232ac01ea5944c7","author":{"name":"thomasvl","email":"7669cbe5a9c997b64160cb048e7966fcb349daf5@google.com"},"message":"Fix packaging of macOS sub-bundle Info.plist/PkgInfo files.\n\nA macOS bundle gets Contents and Contents/Resources directories for some things\nto be packed into. This was being taken into account for everything but the\nInfo.plist (and PkgInfo) for a sub bundle. They would go directly into\nContents, effectively causing a second bundle to be create in an odd location.\n\n- Fix bundler.run() to put sub bundle Info.plist and PkgInfo into the proper\n  locations for macOS.\n- Revert https://github.com/bazelbuild/rules_apple/commit/8585e07e886108d94e6f359326f3b651e2e3a799\n  It was just adding --deep to codesign for cases we thought we weren't directly\n  signing everything we should. But reality was the error about a bundle not\n  being signed was the bogus bundle with just the Info.plist we were putting\n  in the wrong place.\n- Update the testdata properly name/bucket things that are/aren't platform\n  specific.\n- Add macos_application_resources_test.sh based on the iOS one to ensure all of\n  the resources are going in the right locations since macOS has as different\n  bundling structure.\n  - There are TODO for back fill some resources that aren't being done at the\n    moment since this grew to way more then intended.\n\nPiperOrigin-RevId: 192790364","distinct":true,"url":"https://api.github.com/repos/thomasvl/rules_apple/commits/347e95cf8137bda035e7e206d232ac01ea5944c7"},{"sha":"19062f6fb3056631f8f88cb05466f4c57941eb9b","author":{"name":"thomasvl","email":"7669cbe5a9c997b64160cb048e7966fcb349daf5@google.com"},"message":"Validate the asset types for Message Extension's app_icons.\n\nThis should be the last of the validations that are reasonable\nfrom the discussion in the github issue.\n\nFixes https://github.com/bazelbuild/rules_apple/issues/123\n\nPiperOrigin-RevId: 192819558","distinct":true,"url":"https://api.github.com/repos/thomasvl/rules_apple/commits/19062f6fb3056631f8f88cb05466f4c57941eb9b"},{"sha":"facc7b988110c20a35fdce8c67774ac66c3c9db3","author":{"name":"thomasvl","email":"7669cbe5a9c997b64160cb048e7966fcb349daf5@google.com"},"message":"Remove get_environment_supplier.\n\nThe current rules seem to require 0.9.0 or later for other places so it seems\nsafe to remove this shim.\n\nPiperOrigin-RevId: 193035286","distinct":true,"url":"https://api.github.com/repos/thomasvl/rules_apple/commits/facc7b988110c20a35fdce8c67774ac66c3c9db3"},{"sha":"d523b39918108214cc5914f5cd7ef7a3fc811ed1","author":{"name":"kaipi","email":"13332955a35a14793b44c09e53e6322b16be5b5a@google.com"},"message":"Enable framework deduplication on test bundles when the files are also present in the test host.\n\nThis change also refactors the propagates_frameworks option into bundles_frameworks. This makes it more semantically correct as now all bundle types propagate framework information (this is required to signal the test bundle which framework files are already accounted for, so that they are not bundled twice).\n\nRELNOTES: ios_unit_test targets stops bundling dynamic framework bundles depended through objc_framework and ios_framework.\nPiperOrigin-RevId: 193211833","distinct":true,"url":"https://api.github.com/repos/thomasvl/rules_apple/commits/d523b39918108214cc5914f5cd7ef7a3fc811ed1"},{"sha":"12801e04966879e119e43bb7f81f6a72e6dd4c24","author":{"name":"thomasvl","email":"7669cbe5a9c997b64160cb048e7966fcb349daf5@google.com"},"message":"Remove launch_storyboard from tvos_application.\n\nApple's docs don't call it out, but the best I can tell:\n\nhttps://developer.apple.com/ios/human-interface-guidelines/icons-and-images/\nhttps://developer.apple.com/tvos/human-interface-guidelines/icons-and-images/\n\nOn tvOS it has a sub section titled \"Launch Image\", which only talks about images.\nOn iOS it has a sub section titled \"Launch Screen\", which talks about storyboards or images.\n\nAll of the Xcode 9.3 templates start out with launch image support.\n\nThe one possible source of confusion is they use a main storyboard for their ui.\n\nPiperOrigin-RevId: 193385625","distinct":true,"url":"https://api.github.com/repos/thomasvl/rules_apple/commits/12801e04966879e119e43bb7f81f6a72e6dd4c24"},{"sha":"d8489c0dc12b97e48f9f6c1bd3fee4cd5cb7e428","author":{"name":"thomasvl","email":"7669cbe5a9c997b64160cb048e7966fcb349daf5@google.com"},"message":"Move to Xcode 9.3 which also means a High Sierra image.\n\nPiperOrigin-RevId: 193714309","distinct":true,"url":"https://api.github.com/repos/thomasvl/rules_apple/commits/d8489c0dc12b97e48f9f6c1bd3fee4cd5cb7e428"},{"sha":"7b2b26ec9e7f812f03280d3940e00beb110c84b3","author":{"name":"kaipi","email":"13332955a35a14793b44c09e53e6322b16be5b5a@google.com"},"message":"Enable watchos_application example target.\n\nRELNOTES: None\nPiperOrigin-RevId: 193970259","distinct":true,"url":"https://api.github.com/repos/thomasvl/rules_apple/commits/7b2b26ec9e7f812f03280d3940e00beb110c84b3"},{"sha":"91b31454202a9cfc657b6afdfe41aebfb325a749","author":{"name":"thomasvl","email":"7669cbe5a9c997b64160cb048e7966fcb349daf5@google.com"},"message":"Pass the args in one block so arg dedupping cant drop any.\n\nPiperOrigin-RevId: 194104850","distinct":true,"url":"https://api.github.com/repos/thomasvl/rules_apple/commits/91b31454202a9cfc657b6afdfe41aebfb325a749"},{"sha":"a65c81051b958a369feb2a3befe4f8a3d7630cf5","author":{"name":"A Googler","email":"8254d1186852c26c9fb3d343db6a5be86317fea9@google.com"},"message":"macos_command_line_application: Add a launchdplists option (__TEXT __launchd_plist section to the binary)\n\nPiperOrigin-RevId: 194131065","distinct":true,"url":"https://api.github.com/repos/thomasvl/rules_apple/commits/a65c81051b958a369feb2a3befe4f8a3d7630cf5"},{"sha":"be9bcd031290988b542cb1b4ae113480e429e86e","author":{"name":"A Googler","email":"8254d1186852c26c9fb3d343db6a5be86317fea9@google.com"},"message":"Changes fastbuild so that by default it only copies English resources.\n\nAdds support for copying other resources with the \"apple_locales_to_include\" flag.\n\nRELNOTES: 'fastbuild' for Apple projects will now only install English resources by default.\nPiperOrigin-RevId: 194242395","distinct":true,"url":"https://api.github.com/repos/thomasvl/rules_apple/commits/be9bcd031290988b542cb1b4ae113480e429e86e"},{"sha":"dff83ea94d631b37a3ae12272dbcbb56cc41c0bd","author":{"name":"kaipi","email":"13332955a35a14793b44c09e53e6322b16be5b5a@google.com"},"message":"Add documentation on the --ios_signing_cert_name flag.\n\nRELNOTES: None\nPiperOrigin-RevId: 194268329","distinct":true,"url":"https://api.github.com/repos/thomasvl/rules_apple/commits/dff83ea94d631b37a3ae12272dbcbb56cc41c0bd"},{"sha":"97f94797e7f3995eba58300fdb526e372acb798a","author":{"name":"A Googler","email":"8254d1186852c26c9fb3d343db6a5be86317fea9@google.com"},"message":"Automated g4 rollback of commit dacf48e7b55bd554287c7d06476c4b2fc4b56aaa.\n\n*** Reason for rollback ***\n\nBroken too many targets. So much for using the tap train...\n\n*** Original change description ***\n\nChanges fastbuild so that by default it only copies English resources.\n\nAdds support for copying other resources with the \"apple_locales_to_include\" flag.\n\nRELNOTES: 'fastbuild' for Apple projects will now only install English resources by default.\nPiperOrigin-RevId: 194279756","distinct":true,"url":"https://api.github.com/repos/thomasvl/rules_apple/commits/97f94797e7f3995eba58300fdb526e372acb798a"},{"sha":"dab8aabee4ccc5439198df9603ef7fe4926faf3d","author":{"name":"kaipi","email":"13332955a35a14793b44c09e53e6322b16be5b5a@google.com"},"message":"Use the new DefaultInfo provider for files to build and runfiles which should be made available when depending on this target through the data attribute, for instance, for sh_tests.\n\nRELNOTES: None\nPiperOrigin-RevId: 194403830","distinct":true,"url":"https://api.github.com/repos/thomasvl/rules_apple/commits/dab8aabee4ccc5439198df9603ef7fe4926faf3d"},{"sha":"9409373d48dbfefde6f3537777fff7904a80f949","author":{"name":"thomasvl","email":"7669cbe5a9c997b64160cb048e7966fcb349daf5@google.com"},"message":"Fix skylint warnings in common/.\n\nPiperOrigin-RevId: 194406701","distinct":true,"url":"https://api.github.com/repos/thomasvl/rules_apple/commits/9409373d48dbfefde6f3537777fff7904a80f949"}]}
{"actor":{"display_login":"thomasvl"}}