{"action":"created","comment":{"url":"https://api.github.com/repos/OCA/product-attribute/pulls/comments/230299513","pull_request_review_id":171006370,"id":230299513,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDI5OTUxMw==","diff_hunk":"@@ -0,0 +1,107 @@\n+# Copyright 2018 Tecnativa - Vicent Cubells\n+# Copyright 2018 Tecnativa - Pedro M. Baeza\n+# License AGPL-3 - See http://www.gnu.org/licenses/agpl-3.0.html\n+\n+from odoo.tests import common\n+\n+\n+class TestProductSupplierinfo(common.SavepointCase):\n+    at_install = False","path":"product_pricelist_supplierinfo/tests/test_product_supplierinfo.py","position":9,"original_position":9,"commit_id":"d1f3638b1681df59ef4d94ffe653df023db7a2b2","original_commit_id":"d1f3638b1681df59ef4d94ffe653df023db7a2b2","user":{"login":"pedrobaeza","id":7165771,"node_id":"MDQ6VXNlcjcxNjU3NzE=","avatar_url":"https://avatars2.githubusercontent.com/u/7165771?v=4","gravatar_id":"","url":"https://api.github.com/users/pedrobaeza","html_url":"https://github.com/pedrobaeza","followers_url":"https://api.github.com/users/pedrobaeza/followers","following_url":"https://api.github.com/users/pedrobaeza/following{/other_user}","gists_url":"https://api.github.com/users/pedrobaeza/gists{/gist_id}","starred_url":"https://api.github.com/users/pedrobaeza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedrobaeza/subscriptions","organizations_url":"https://api.github.com/users/pedrobaeza/orgs","repos_url":"https://api.github.com/users/pedrobaeza/repos","events_url":"https://api.github.com/users/pedrobaeza/events{/privacy}","received_events_url":"https://api.github.com/users/pedrobaeza/received_events","type":"User","site_admin":false},"body":"I can't remove it because I have the problem when creating the products that if `product`is installed, it fails by the SQL constraint.","created_at":"2018-11-02T08:30:36Z","updated_at":"2018-11-02T08:30:36Z","html_url":"https://github.com/OCA/product-attribute/pull/400#discussion_r230299513","pull_request_url":"https://api.github.com/repos/OCA/product-attribute/pulls/400","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/OCA/product-attribute/pulls/comments/230299513"},"html":{"href":"https://github.com/OCA/product-attribute/pull/400#discussion_r230299513"},"pull_request":{"href":"https://api.github.com/repos/OCA/product-attribute/pulls/400"}},"in_reply_to_id":230294429},"pull_request":{"url":"https://api.github.com/repos/OCA/product-attribute/pulls/400","id":227383749,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3MzgzNzQ5","html_url":"https://github.com/OCA/product-attribute/pull/400","diff_url":"https://github.com/OCA/product-attribute/pull/400.diff","patch_url":"https://github.com/OCA/product-attribute/pull/400.patch","issue_url":"https://api.github.com/repos/OCA/product-attribute/issues/400","number":400,"state":"open","locked":false,"title":"[11.0][ADD] product_pricelist_supplierinfo: Supplier info prices in sales pricelists","user":{"login":"pedrobaeza","id":7165771,"node_id":"MDQ6VXNlcjcxNjU3NzE=","avatar_url":"https://avatars2.githubusercontent.com/u/7165771?v=4","gravatar_id":"","url":"https://api.github.com/users/pedrobaeza","html_url":"https://github.com/pedrobaeza","followers_url":"https://api.github.com/users/pedrobaeza/followers","following_url":"https://api.github.com/users/pedrobaeza/following{/other_user}","gists_url":"https://api.github.com/users/pedrobaeza/gists{/gist_id}","starred_url":"https://api.github.com/users/pedrobaeza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedrobaeza/subscriptions","organizations_url":"https://api.github.com/users/pedrobaeza/orgs","repos_url":"https://api.github.com/users/pedrobaeza/repos","events_url":"https://api.github.com/users/pedrobaeza/events{/privacy}","received_events_url":"https://api.github.com/users/pedrobaeza/received_events","type":"User","site_admin":false},"body":"This module allows you to create a sales pricelist based on product supplierinfo prices. If you want, you can bypass minimum quantity in pricelist item.\r\n\r\nInstallation\r\n============\r\nAlthough this module doesn't depend technically on **Sales Management**, you must install it for configuring and seeing the effects of it.\r\n\r\nConfiguration\r\n=============\r\n\r\nTo configure pricelists with the new feature of this module, you need to:\r\n\r\n* Go to *Sales > Configuration > Settings* and check \"Multiple Sales Prices per Product\" option and   \"Prices computed from formulas\" after that. You must have correct permissions and you must install **Sales Management** app (sale) to see these settings.\r\n* Create or edit a Sales Pricelist at *Sales > Catalog > Pricelists*.\r\n* Add or edit a pricelist item and check \"Formula\" option in \"Price Computation\" section.\r\n* You will see the new option \"Prices based on supplier info\".\r\n* If you want to bypass the \"Min.Quantity\" field of the supplier info and always select the lowest quantity price, check the option \"Ignore Supplier Info Min. Quantity\".\r\n\r\nUsage\r\n=====\r\n\r\nFor adding supplier info:\r\n\r\n* Go to *Sales > Catalog > Products*\r\n* Open or create a product.\r\n* Go to \"Purchase\" page.\r\n* On \"Vendors\" section, add the supplier and prices.\r\n* You can drag and drop for reordering these lines.\r\n\r\nCheck the remark in known issues about the supplier info line selection.\r\n\r\nFor checking pricelists in action, you can (with `sale` module installed):\r\n\r\n* Go to *Sales > Orders > Quotations*\r\n* Create or edit a quotation.\r\n* Add a line.\r\n* Select a product with the criteria to match the pricelist from supplier info.\r\n* See the proper price appears in the line.\r\n\r\nKnown issues / Roadmap\r\n======================\r\n\r\n* First line that matches by minimum quantity criteria, independently from the supplier, will be the one that provides the price for the pricelist.\r\n* There's no mechanism for selecting the supplier from possible sources like sales orders.\r\n\r\ncc @Tecnativa","created_at":"2018-10-31T17:47:53Z","updated_at":"2018-11-02T08:30:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"03f7e466e3c736fb7bd99c4b6b1a88049e82a087","assignee":null,"assignees":[],"requested_reviewers":[{"login":"cubells","id":4386443,"node_id":"MDQ6VXNlcjQzODY0NDM=","avatar_url":"https://avatars0.githubusercontent.com/u/4386443?v=4","gravatar_id":"","url":"https://api.github.com/users/cubells","html_url":"https://github.com/cubells","followers_url":"https://api.github.com/users/cubells/followers","following_url":"https://api.github.com/users/cubells/following{/other_user}","gists_url":"https://api.github.com/users/cubells/gists{/gist_id}","starred_url":"https://api.github.com/users/cubells/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cubells/subscriptions","organizations_url":"https://api.github.com/users/cubells/orgs","repos_url":"https://api.github.com/users/cubells/repos","events_url":"https://api.github.com/users/cubells/events{/privacy}","received_events_url":"https://api.github.com/users/cubells/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":121861063,"node_id":"MDU6TGFiZWwxMjE4NjEwNjM=","url":"https://api.github.com/repos/OCA/product-attribute/labels/needs%20review","name":"needs review","color":"fbca04","default":false}],"milestone":{"url":"https://api.github.com/repos/OCA/product-attribute/milestones/4","html_url":"https://github.com/OCA/product-attribute/milestone/4","labels_url":"https://api.github.com/repos/OCA/product-attribute/milestones/4/labels","id":2810715,"node_id":"MDk6TWlsZXN0b25lMjgxMDcxNQ==","number":4,"title":"11.0","description":null,"creator":{"login":"pedrobaeza","id":7165771,"node_id":"MDQ6VXNlcjcxNjU3NzE=","avatar_url":"https://avatars2.githubusercontent.com/u/7165771?v=4","gravatar_id":"","url":"https://api.github.com/users/pedrobaeza","html_url":"https://github.com/pedrobaeza","followers_url":"https://api.github.com/users/pedrobaeza/followers","following_url":"https://api.github.com/users/pedrobaeza/following{/other_user}","gists_url":"https://api.github.com/users/pedrobaeza/gists{/gist_id}","starred_url":"https://api.github.com/users/pedrobaeza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pedrobaeza/subscriptions","organizations_url":"https://api.github.com/users/pedrobaeza/orgs","repos_url":"https://api.github.com/users/pedrobaeza/repos","events_url":"https://api.github.com/users/pedrobaeza/events{/privacy}","received_events_url":"https://api.github.com/users/pedrobaeza/received_events","type":"User","site_admin":false},"open_issues":10,"closed_issues":27,"state":"open","created_at":"2017-10-03T14:51:48Z","updated_at":"2018-10-31T17:47:53Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/OCA/product-attribute/pulls/400/commits","review_comments_url":"https://api.github.com/repos/OCA/product-attribute/pulls/400/comments","review_comment_url":"https://api.github.com/repos/OCA/product-attribute/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OCA/product-attribute/issues/400/comments","statuses_url":"https://api.github.com/repos/OCA/product-attribute/statuses/d1f3638b1681df59ef4d94ffe653df023db7a2b2","head":{"label":"OCA:11.0-product_pricelist_supplierinfo","ref":"11.0-product_pricelist_supplierinfo","sha":"d1f3638b1681df59ef4d94ffe653df023db7a2b2","user":{"login":"OCA","id":7600578,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MDA1Nzg=","avatar_url":"https://avatars1.githubusercontent.com/u/7600578?v=4","gravatar_id":"","url":"https://api.github.com/users/OCA","html_url":"https://github.com/OCA","followers_url":"https://api.github.com/users/OCA/followers","following_url":"https://api.github.com/users/OCA/following{/other_user}","gists_url":"https://api.github.com/users/OCA/gists{/gist_id}","starred_url":"https://api.github.com/users/OCA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OCA/subscriptions","organizations_url":"https://api.github.com/users/OCA/orgs","repos_url":"https://api.github.com/users/OCA/repos","events_url":"https://api.github.com/users/OCA/events{/privacy}","received_events_url":"https://api.github.com/users/OCA/received_events","type":"Organization","site_admin":false},"repo":{"id":20894654,"node_id":"MDEwOlJlcG9zaXRvcnkyMDg5NDY1NA==","name":"product-attribute","full_name":"OCA/product-attribute","private":false,"owner":{"login":"OCA","id":7600578,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MDA1Nzg=","avatar_url":"https://avatars1.githubusercontent.com/u/7600578?v=4","gravatar_id":"","url":"https://api.github.com/users/OCA","html_url":"https://github.com/OCA","followers_url":"https://api.github.com/users/OCA/followers","following_url":"https://api.github.com/users/OCA/following{/other_user}","gists_url":"https://api.github.com/users/OCA/gists{/gist_id}","starred_url":"https://api.github.com/users/OCA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OCA/subscriptions","organizations_url":"https://api.github.com/users/OCA/orgs","repos_url":"https://api.github.com/users/OCA/repos","events_url":"https://api.github.com/users/OCA/events{/privacy}","received_events_url":"https://api.github.com/users/OCA/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OCA/product-attribute","description":"Odoo Product Attribute","fork":false,"url":"https://api.github.com/repos/OCA/product-attribute","forks_url":"https://api.github.com/repos/OCA/product-attribute/forks","keys_url":"https://api.github.com/repos/OCA/product-attribute/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OCA/product-attribute/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OCA/product-attribute/teams","hooks_url":"https://api.github.com/repos/OCA/product-attribute/hooks","issue_events_url":"https://api.github.com/repos/OCA/product-attribute/issues/events{/number}","events_url":"https://api.github.com/repos/OCA/product-attribute/events","assignees_url":"https://api.github.com/repos/OCA/product-attribute/assignees{/user}","branches_url":"https://api.github.com/repos/OCA/product-attribute/branches{/branch}","tags_url":"https://api.github.com/repos/OCA/product-attribute/tags","blobs_url":"https://api.github.com/repos/OCA/product-attribute/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OCA/product-attribute/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OCA/product-attribute/git/refs{/sha}","trees_url":"https://api.github.com/repos/OCA/product-attribute/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OCA/product-attribute/statuses/{sha}","languages_url":"https://api.github.com/repos/OCA/product-attribute/languages","stargazers_url":"https://api.github.com/repos/OCA/product-attribute/stargazers","contributors_url":"https://api.github.com/repos/OCA/product-attribute/contributors","subscribers_url":"https://api.github.com/repos/OCA/product-attribute/subscribers","subscription_url":"https://api.github.com/repos/OCA/product-attribute/subscription","commits_url":"https://api.github.com/repos/OCA/product-attribute/commits{/sha}","git_commits_url":"https://api.github.com/repos/OCA/product-attribute/git/commits{/sha}","comments_url":"https://api.github.com/repos/OCA/product-attribute/comments{/number}","issue_comment_url":"https://api.github.com/repos/OCA/product-attribute/issues/comments{/number}","contents_url":"https://api.github.com/repos/OCA/product-attribute/contents/{+path}","compare_url":"https://api.github.com/repos/OCA/product-attribute/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OCA/product-attribute/merges","archive_url":"https://api.github.com/repos/OCA/product-attribute/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OCA/product-attribute/downloads","issues_url":"https://api.github.com/repos/OCA/product-attribute/issues{/number}","pulls_url":"https://api.github.com/repos/OCA/product-attribute/pulls{/number}","milestones_url":"https://api.github.com/repos/OCA/product-attribute/milestones{/number}","notifications_url":"https://api.github.com/repos/OCA/product-attribute/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OCA/product-attribute/labels{/name}","releases_url":"https://api.github.com/repos/OCA/product-attribute/releases{/id}","deployments_url":"https://api.github.com/repos/OCA/product-attribute/deployments","created_at":"2014-06-16T17:57:41Z","updated_at":"2018-10-18T19:43:32Z","pushed_at":"2018-10-31T20:14:43Z","git_url":"git://github.com/OCA/product-attribute.git","ssh_url":"git@github.com:OCA/product-attribute.git","clone_url":"https://github.com/OCA/product-attribute.git","svn_url":"https://github.com/OCA/product-attribute","homepage":"https://odoo-community.org/project/product-maintainers-27","size":8511,"stargazers_count":54,"watchers_count":54,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":295,"mirror_url":null,"archived":false,"open_issues_count":70,"license":null,"forks":295,"open_issues":70,"watchers":54,"default_branch":"11.0"}},"base":{"label":"OCA:11.0","ref":"11.0","sha":"33d67eeab90995b90a8d2db3e87ff254d8b226ee","user":{"login":"OCA","id":7600578,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MDA1Nzg=","avatar_url":"https://avatars1.githubusercontent.com/u/7600578?v=4","gravatar_id":"","url":"https://api.github.com/users/OCA","html_url":"https://github.com/OCA","followers_url":"https://api.github.com/users/OCA/followers","following_url":"https://api.github.com/users/OCA/following{/other_user}","gists_url":"https://api.github.com/users/OCA/gists{/gist_id}","starred_url":"https://api.github.com/users/OCA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OCA/subscriptions","organizations_url":"https://api.github.com/users/OCA/orgs","repos_url":"https://api.github.com/users/OCA/repos","events_url":"https://api.github.com/users/OCA/events{/privacy}","received_events_url":"https://api.github.com/users/OCA/received_events","type":"Organization","site_admin":false},"repo":{"id":20894654,"node_id":"MDEwOlJlcG9zaXRvcnkyMDg5NDY1NA==","name":"product-attribute","full_name":"OCA/product-attribute","private":false,"owner":{"login":"OCA","id":7600578,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MDA1Nzg=","avatar_url":"https://avatars1.githubusercontent.com/u/7600578?v=4","gravatar_id":"","url":"https://api.github.com/users/OCA","html_url":"https://github.com/OCA","followers_url":"https://api.github.com/users/OCA/followers","following_url":"https://api.github.com/users/OCA/following{/other_user}","gists_url":"https://api.github.com/users/OCA/gists{/gist_id}","starred_url":"https://api.github.com/users/OCA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OCA/subscriptions","organizations_url":"https://api.github.com/users/OCA/orgs","repos_url":"https://api.github.com/users/OCA/repos","events_url":"https://api.github.com/users/OCA/events{/privacy}","received_events_url":"https://api.github.com/users/OCA/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OCA/product-attribute","description":"Odoo Product Attribute","fork":false,"url":"https://api.github.com/repos/OCA/product-attribute","forks_url":"https://api.github.com/repos/OCA/product-attribute/forks","keys_url":"https://api.github.com/repos/OCA/product-attribute/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OCA/product-attribute/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OCA/product-attribute/teams","hooks_url":"https://api.github.com/repos/OCA/product-attribute/hooks","issue_events_url":"https://api.github.com/repos/OCA/product-attribute/issues/events{/number}","events_url":"https://api.github.com/repos/OCA/product-attribute/events","assignees_url":"https://api.github.com/repos/OCA/product-attribute/assignees{/user}","branches_url":"https://api.github.com/repos/OCA/product-attribute/branches{/branch}","tags_url":"https://api.github.com/repos/OCA/product-attribute/tags","blobs_url":"https://api.github.com/repos/OCA/product-attribute/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OCA/product-attribute/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OCA/product-attribute/git/refs{/sha}","trees_url":"https://api.github.com/repos/OCA/product-attribute/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OCA/product-attribute/statuses/{sha}","languages_url":"https://api.github.com/repos/OCA/product-attribute/languages","stargazers_url":"https://api.github.com/repos/OCA/product-attribute/stargazers","contributors_url":"https://api.github.com/repos/OCA/product-attribute/contributors","subscribers_url":"https://api.github.com/repos/OCA/product-attribute/subscribers","subscription_url":"https://api.github.com/repos/OCA/product-attribute/subscription","commits_url":"https://api.github.com/repos/OCA/product-attribute/commits{/sha}","git_commits_url":"https://api.github.com/repos/OCA/product-attribute/git/commits{/sha}","comments_url":"https://api.github.com/repos/OCA/product-attribute/comments{/number}","issue_comment_url":"https://api.github.com/repos/OCA/product-attribute/issues/comments{/number}","contents_url":"https://api.github.com/repos/OCA/product-attribute/contents/{+path}","compare_url":"https://api.github.com/repos/OCA/product-attribute/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OCA/product-attribute/merges","archive_url":"https://api.github.com/repos/OCA/product-attribute/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OCA/product-attribute/downloads","issues_url":"https://api.github.com/repos/OCA/product-attribute/issues{/number}","pulls_url":"https://api.github.com/repos/OCA/product-attribute/pulls{/number}","milestones_url":"https://api.github.com/repos/OCA/product-attribute/milestones{/number}","notifications_url":"https://api.github.com/repos/OCA/product-attribute/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OCA/product-attribute/labels{/name}","releases_url":"https://api.github.com/repos/OCA/product-attribute/releases{/id}","deployments_url":"https://api.github.com/repos/OCA/product-attribute/deployments","created_at":"2014-06-16T17:57:41Z","updated_at":"2018-10-18T19:43:32Z","pushed_at":"2018-10-31T20:14:43Z","git_url":"git://github.com/OCA/product-attribute.git","ssh_url":"git@github.com:OCA/product-attribute.git","clone_url":"https://github.com/OCA/product-attribute.git","svn_url":"https://github.com/OCA/product-attribute","homepage":"https://odoo-community.org/project/product-maintainers-27","size":8511,"stargazers_count":54,"watchers_count":54,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":295,"mirror_url":null,"archived":false,"open_issues_count":70,"license":null,"forks":295,"open_issues":70,"watchers":54,"default_branch":"11.0"}},"_links":{"self":{"href":"https://api.github.com/repos/OCA/product-attribute/pulls/400"},"html":{"href":"https://github.com/OCA/product-attribute/pull/400"},"issue":{"href":"https://api.github.com/repos/OCA/product-attribute/issues/400"},"comments":{"href":"https://api.github.com/repos/OCA/product-attribute/issues/400/comments"},"review_comments":{"href":"https://api.github.com/repos/OCA/product-attribute/pulls/400/comments"},"review_comment":{"href":"https://api.github.com/repos/OCA/product-attribute/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OCA/product-attribute/pulls/400/commits"},"statuses":{"href":"https://api.github.com/repos/OCA/product-attribute/statuses/d1f3638b1681df59ef4d94ffe653df023db7a2b2"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pedrobaeza"}}