{"action":"created","issue":{"url":"https://api.github.com/repos/TheCherno/Hazel/issues/1","repository_url":"https://api.github.com/repos/TheCherno/Hazel","labels_url":"https://api.github.com/repos/TheCherno/Hazel/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/TheCherno/Hazel/issues/1/comments","events_url":"https://api.github.com/repos/TheCherno/Hazel/issues/1/events","html_url":"https://github.com/TheCherno/Hazel/pull/1","id":377196315,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MjAzOTI5","number":1,"title":"Add CMake support to the project","user":{"login":"tobanteGaming","id":41272570,"node_id":"MDQ6VXNlcjQxMjcyNTcw","avatar_url":"https://avatars1.githubusercontent.com/u/41272570?v=4","gravatar_id":"","url":"https://api.github.com/users/tobanteGaming","html_url":"https://github.com/tobanteGaming","followers_url":"https://api.github.com/users/tobanteGaming/followers","following_url":"https://api.github.com/users/tobanteGaming/following{/other_user}","gists_url":"https://api.github.com/users/tobanteGaming/gists{/gist_id}","starred_url":"https://api.github.com/users/tobanteGaming/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobanteGaming/subscriptions","organizations_url":"https://api.github.com/users/tobanteGaming/orgs","repos_url":"https://api.github.com/users/tobanteGaming/repos","events_url":"https://api.github.com/users/tobanteGaming/events{/privacy}","received_events_url":"https://api.github.com/users/tobanteGaming/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-11-04T21:23:25Z","updated_at":"2018-11-04T22:55:39Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/TheCherno/Hazel/pulls/1","html_url":"https://github.com/TheCherno/Hazel/pull/1","diff_url":"https://github.com/TheCherno/Hazel/pull/1.diff","patch_url":"https://github.com/TheCherno/Hazel/pull/1.patch"},"body":"Hi TheCherno,\r\n\r\nI updated your project to be built with CMake. I thought it would be a good idea to start using CMake early on, so it will be easier to migrate to different platforms.\r\n\r\nI only added three ```CMakeLists.txt``` files & updated ```.gitignore ```. I did no changes to the source code, so it's still windows only. The CMake project already has the necessary structure for future platforms & external libraries (e.g. logging). I tried to document the CMake files as much as possible, so hopefully, there are no unclear lines.\r\n\r\nYou can obviously still build the project using the Visual Studio solution file ```.sln```. I'm happy to maintain the CMake build files if you don't want to, but they only need to change for new c++ files, defines or new libraries anyway.\r\n\r\nHere is an example on how to build the project with CMake from git-bash, since I'm not very familiar with cmd:\r\n\r\n```sh\r\ncd Hazel\r\nmkdir build && cd build\r\ncmake ..\r\ncmake --build .\r\n```\r\nThen you can copy the hazel-engine.dll to the sandox folder and run the .exe\r\n\r\nHope this helps. \r\n\r\nGreetings,\r\n**tobante**"},"comment":{"url":"https://api.github.com/repos/TheCherno/Hazel/issues/comments/435716297","html_url":"https://github.com/TheCherno/Hazel/pull/1#issuecomment-435716297","issue_url":"https://api.github.com/repos/TheCherno/Hazel/issues/1","id":435716297,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTcxNjI5Nw==","user":{"login":"tobanteGaming","id":41272570,"node_id":"MDQ6VXNlcjQxMjcyNTcw","avatar_url":"https://avatars1.githubusercontent.com/u/41272570?v=4","gravatar_id":"","url":"https://api.github.com/users/tobanteGaming","html_url":"https://github.com/tobanteGaming","followers_url":"https://api.github.com/users/tobanteGaming/followers","following_url":"https://api.github.com/users/tobanteGaming/following{/other_user}","gists_url":"https://api.github.com/users/tobanteGaming/gists{/gist_id}","starred_url":"https://api.github.com/users/tobanteGaming/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tobanteGaming/subscriptions","organizations_url":"https://api.github.com/users/tobanteGaming/orgs","repos_url":"https://api.github.com/users/tobanteGaming/repos","events_url":"https://api.github.com/users/tobanteGaming/events{/privacy}","received_events_url":"https://api.github.com/users/tobanteGaming/received_events","type":"User","site_admin":false},"created_at":"2018-11-04T22:55:39Z","updated_at":"2018-11-04T22:55:39Z","author_association":"NONE","body":"@EdSwordsmith Sure definitely an option, or we could use ``` add_costum_command ``` to copy the dll after the sandbox build. But the ```install``` command is probably the cleaner solution."}}
{"actor":{"display_login":"tobanteGaming"}}