{"action":"created","issue":{"url":"https://api.github.com/repos/apache/spark/issues/22279","repository_url":"https://api.github.com/repos/apache/spark","labels_url":"https://api.github.com/repos/apache/spark/issues/22279/labels{/name}","comments_url":"https://api.github.com/repos/apache/spark/issues/22279/comments","events_url":"https://api.github.com/repos/apache/spark/issues/22279/events","html_url":"https://github.com/apache/spark/pull/22279","id":355457970,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExOTgwNzE4","number":22279,"title":"[SPARK-25277][YARN] YARN applicationMaster metrics should not register static metrics","user":{"login":"LucaCanali","id":5243162,"node_id":"MDQ6VXNlcjUyNDMxNjI=","avatar_url":"https://avatars2.githubusercontent.com/u/5243162?v=4","gravatar_id":"","url":"https://api.github.com/users/LucaCanali","html_url":"https://github.com/LucaCanali","followers_url":"https://api.github.com/users/LucaCanali/followers","following_url":"https://api.github.com/users/LucaCanali/following{/other_user}","gists_url":"https://api.github.com/users/LucaCanali/gists{/gist_id}","starred_url":"https://api.github.com/users/LucaCanali/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LucaCanali/subscriptions","organizations_url":"https://api.github.com/users/LucaCanali/orgs","repos_url":"https://api.github.com/users/LucaCanali/repos","events_url":"https://api.github.com/users/LucaCanali/events{/privacy}","received_events_url":"https://api.github.com/users/LucaCanali/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-08-30T07:27:19Z","updated_at":"2018-12-12T09:12:39Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/22279","html_url":"https://github.com/apache/spark/pull/22279","diff_url":"https://github.com/apache/spark/pull/22279.diff","patch_url":"https://github.com/apache/spark/pull/22279.patch"},"body":"## What changes were proposed in this pull request?\r\n\r\nYARN applicationMaster metrics registration introduced in SPARK-24594 causes further registration of static metrics (Codegenerator and HiveExternalCatalog) and of JVM metrics, which I believe do not belong in this context.\r\nThis looks like an unintended side effect of using the start method of [[MetricsSystem]].\r\nA possible solution proposed here, is to introduce startNoRegisterSources to avoid these additional registrations of static sources and of JVM sources in the case of YARN applicationMaster metrics (this could be useful for other metrics that may be added in the future).\r\n\r\n## How was this patch tested?\r\n\r\nManually tested on a YARN cluster,\r\n"},"comment":{"url":"https://api.github.com/repos/apache/spark/issues/comments/446515525","html_url":"https://github.com/apache/spark/pull/22279#issuecomment-446515525","issue_url":"https://api.github.com/repos/apache/spark/issues/22279","id":446515525,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NjUxNTUyNQ==","user":{"login":"AmplabJenkins","id":4031291,"node_id":"MDQ6VXNlcjQwMzEyOTE=","avatar_url":"https://avatars3.githubusercontent.com/u/4031291?v=4","gravatar_id":"","url":"https://api.github.com/users/AmplabJenkins","html_url":"https://github.com/AmplabJenkins","followers_url":"https://api.github.com/users/AmplabJenkins/followers","following_url":"https://api.github.com/users/AmplabJenkins/following{/other_user}","gists_url":"https://api.github.com/users/AmplabJenkins/gists{/gist_id}","starred_url":"https://api.github.com/users/AmplabJenkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AmplabJenkins/subscriptions","organizations_url":"https://api.github.com/users/AmplabJenkins/orgs","repos_url":"https://api.github.com/users/AmplabJenkins/repos","events_url":"https://api.github.com/users/AmplabJenkins/events{/privacy}","received_events_url":"https://api.github.com/users/AmplabJenkins/received_events","type":"User","site_admin":false},"created_at":"2018-12-12T09:12:39Z","updated_at":"2018-12-12T09:12:39Z","author_association":"NONE","body":"Merged build finished. Test PASSed."}}
{"actor":{"display_login":"AmplabJenkins"}}