{"action":"created","issue":{"url":"https://api.github.com/repos/Codeception/Codeception/issues/5217","repository_url":"https://api.github.com/repos/Codeception/Codeception","labels_url":"https://api.github.com/repos/Codeception/Codeception/issues/5217/labels{/name}","comments_url":"https://api.github.com/repos/Codeception/Codeception/issues/5217/comments","events_url":"https://api.github.com/repos/Codeception/Codeception/issues/5217/events","html_url":"https://github.com/Codeception/Codeception/pull/5217","id":367436867,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwODczMzE2","number":5217,"title":"Add waitForElementClickable","user":{"login":"FatBoyXPC","id":744962,"node_id":"MDQ6VXNlcjc0NDk2Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/744962?v=4","gravatar_id":"","url":"https://api.github.com/users/FatBoyXPC","html_url":"https://github.com/FatBoyXPC","followers_url":"https://api.github.com/users/FatBoyXPC/followers","following_url":"https://api.github.com/users/FatBoyXPC/following{/other_user}","gists_url":"https://api.github.com/users/FatBoyXPC/gists{/gist_id}","starred_url":"https://api.github.com/users/FatBoyXPC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FatBoyXPC/subscriptions","organizations_url":"https://api.github.com/users/FatBoyXPC/orgs","repos_url":"https://api.github.com/users/FatBoyXPC/repos","events_url":"https://api.github.com/users/FatBoyXPC/events{/privacy}","received_events_url":"https://api.github.com/users/FatBoyXPC/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-06T08:31:23Z","updated_at":"2018-10-06T09:13:02Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/Codeception/Codeception/pulls/5217","html_url":"https://github.com/Codeception/Codeception/pull/5217","diff_url":"https://github.com/Codeception/Codeception/pull/5217.diff","patch_url":"https://github.com/Codeception/Codeception/pull/5217.patch"},"body":"I needed a way to wait on a button to become clickable, and noticed that WebDriver already has a `WebDriverExpectedCondition::elementToBeClickable()` method available. Pretty easy win!\r\n\r\nFixes #5216.\r\n\r\nNote: I was unable to get the `web` suite working, so I was unable to actually test this through `WebDriverTest`, but I actually built this into my own app before submitting here. It looks like that suite isn't running in TravisCI? I was hoping I'd be able to at least let CI tell me if I got it right.\r\n\r\nI tried running this through the `docker-compose` steps in [the readme](https://github.com/Codeception/Codeception/blob/2.5/tests/README.md), but I'm unsure if docker automatically spins up chromedriver and the rest of the necessary steps. When I tried running `docker-compose run --rm codecept run web --env chrome WebDriverTest:testWebDriverWaits` I would receive an error tat chrome couldn't connect to chromedriver. I ended up running chromedriver locally and I get this message:\r\n```\r\nE WebDriverTest: Web driver waits \r\n--------------------------------------------------------------------------------------\r\nDEPRECATION: Stub::exactly is deprecated in favor of \\Codeception\\Stub\\Expected::exactly\r\n\r\n\r\nTime: 122 ms, Memory: 14.00MB\r\n\r\nThere was 1 error:\r\n\r\n---------\r\n1) WebDriverTest: Web driver waits\r\n Test  tests/web/WebDriverTest.php:testWebDriverWaits\r\n                                                                                                                                                             \r\n  [Facebook\\WebDriver\\Exception\\WebDriverException] JSON decoding of remote response failed.\r\nError code: 4\r\nThe response: 'unknown command: wd/hub/session'\r\n  \r\n                                                                                                                                                             \r\n#1  /home/james/dev/Codeception/vendor/facebook/webdriver/lib/Remote/HttpCommandExecutor.php:298\r\n#2  /home/james/dev/Codeception/vendor/facebook/webdriver/lib/Remote/RemoteWebDriver.php:126\r\n#3  /home/james/dev/Codeception/src/Codeception/Module/WebDriver.php:1441\r\n#4  /home/james/dev/Codeception/src/Codeception/Module/WebDriver.php:426\r\n#5  /home/james/dev/Codeception/vendor/symfony/event-dispatcher/EventDispatcher.php:212\r\n#6  /home/james/dev/Codeception/vendor/symfony/event-dispatcher/EventDispatcher.php:44\r\n#7  /home/james/dev/Codeception/codecept:43\r\n\r\nERRORS!\r\nTests: 1, Assertions: 0, Errors: 1.\r\n```\r\n\r\nI'd absolutely love to get this test working, just let me know what to do!"},"comment":{"url":"https://api.github.com/repos/Codeception/Codeception/issues/comments/427558961","html_url":"https://github.com/Codeception/Codeception/pull/5217#issuecomment-427558961","issue_url":"https://api.github.com/repos/Codeception/Codeception/issues/5217","id":427558961,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzU1ODk2MQ==","user":{"login":"FatBoyXPC","id":744962,"node_id":"MDQ6VXNlcjc0NDk2Mg==","avatar_url":"https://avatars2.githubusercontent.com/u/744962?v=4","gravatar_id":"","url":"https://api.github.com/users/FatBoyXPC","html_url":"https://github.com/FatBoyXPC","followers_url":"https://api.github.com/users/FatBoyXPC/followers","following_url":"https://api.github.com/users/FatBoyXPC/following{/other_user}","gists_url":"https://api.github.com/users/FatBoyXPC/gists{/gist_id}","starred_url":"https://api.github.com/users/FatBoyXPC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FatBoyXPC/subscriptions","organizations_url":"https://api.github.com/users/FatBoyXPC/orgs","repos_url":"https://api.github.com/users/FatBoyXPC/repos","events_url":"https://api.github.com/users/FatBoyXPC/events{/privacy}","received_events_url":"https://api.github.com/users/FatBoyXPC/received_events","type":"User","site_admin":false},"created_at":"2018-10-06T09:13:02Z","updated_at":"2018-10-06T09:13:02Z","author_association":"NONE","body":"Okay, that was easier than I expected. I didn't realize at first we were just concerned with the `wait` method getting called. Simple enough! Let me know if I need to squash those commits down into one :slightly_smiling_face: "}}
{"actor":{"display_login":"FatBoyXPC"}}