{"action":"created","issue":{"url":"https://api.github.com/repos/diagrams/diagrams-builder/issues/33","repository_url":"https://api.github.com/repos/diagrams/diagrams-builder","labels_url":"https://api.github.com/repos/diagrams/diagrams-builder/issues/33/labels{/name}","comments_url":"https://api.github.com/repos/diagrams/diagrams-builder/issues/33/comments","events_url":"https://api.github.com/repos/diagrams/diagrams-builder/issues/33/events","html_url":"https://github.com/diagrams/diagrams-builder/pull/33","id":377587708,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4NDk1NDkz","number":33,"title":"Improvements to diagrams-latex.sty","user":{"login":"apirogov","id":371708,"node_id":"MDQ6VXNlcjM3MTcwOA==","avatar_url":"https://avatars0.githubusercontent.com/u/371708?v=4","gravatar_id":"","url":"https://api.github.com/users/apirogov","html_url":"https://github.com/apirogov","followers_url":"https://api.github.com/users/apirogov/followers","following_url":"https://api.github.com/users/apirogov/following{/other_user}","gists_url":"https://api.github.com/users/apirogov/gists{/gist_id}","starred_url":"https://api.github.com/users/apirogov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apirogov/subscriptions","organizations_url":"https://api.github.com/users/apirogov/orgs","repos_url":"https://api.github.com/users/apirogov/repos","events_url":"https://api.github.com/users/apirogov/events{/privacy}","received_events_url":"https://api.github.com/users/apirogov/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-05T21:21:40Z","updated_at":"2018-11-06T04:15:41Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/diagrams/diagrams-builder/pulls/33","html_url":"https://github.com/diagrams/diagrams-builder/pull/33","diff_url":"https://github.com/diagrams/diagrams-builder/pull/33.diff","patch_url":"https://github.com/diagrams/diagrams-builder/pull/33.patch"},"body":"I hope this is an acceptable patch. I am not a TeX expert by any means, I just tried to evaluate diagrams as a candidate to replace TikZ in presentations and articles and these were just some of the usability issues that were nagging me enough that I tried to fix it...\r\n\r\nI added a cmdprefix option, for example one can write\r\n\r\n`\\usepackage[backend=pgf, extension=pgf, outputdir=diagrams, input, cmdprefix={stack exec --}, beamer]{diagrams-latex}`\r\n\r\nand then it works nicely with diagrams installed in the global project by stack.\r\n\r\nThe `beamer` option makes diagrams aware of overlays when using with beamer. It defines the `overlay` variable that can be used in the script to vary the diagram depending on the slide number. The only drawback is that this enforces the indentation level (as a line of code is added). I don't know whether there is a nice way to do this smarter, but I think this is better than nothing and if one does not enable it, the base indentation depth remains \"flexible\", as before.\r\n\r\nFurthermore, I didn't like that `width` and `height` were unitless numbers. Now one can write `\\begin{diagram}[width=\\textwidth]` and it works as one would expect.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/diagrams/diagrams-builder/issues/comments/436125738","html_url":"https://github.com/diagrams/diagrams-builder/pull/33#issuecomment-436125738","issue_url":"https://api.github.com/repos/diagrams/diagrams-builder/issues/33","id":436125738,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNjEyNTczOA==","user":{"login":"byorgey","id":533859,"node_id":"MDQ6VXNlcjUzMzg1OQ==","avatar_url":"https://avatars0.githubusercontent.com/u/533859?v=4","gravatar_id":"","url":"https://api.github.com/users/byorgey","html_url":"https://github.com/byorgey","followers_url":"https://api.github.com/users/byorgey/followers","following_url":"https://api.github.com/users/byorgey/following{/other_user}","gists_url":"https://api.github.com/users/byorgey/gists{/gist_id}","starred_url":"https://api.github.com/users/byorgey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/byorgey/subscriptions","organizations_url":"https://api.github.com/users/byorgey/orgs","repos_url":"https://api.github.com/users/byorgey/repos","events_url":"https://api.github.com/users/byorgey/events{/privacy}","received_events_url":"https://api.github.com/users/byorgey/received_events","type":"User","site_admin":false},"created_at":"2018-11-06T04:15:41Z","updated_at":"2018-11-06T04:15:41Z","author_association":"MEMBER","body":"These changes look great, thanks so much!"}}
{"actor":{"display_login":"byorgey"}}