{"action":"closed","issue":{"url":"https://api.github.com/repos/FormidableLabs/react-fast-compare/issues/30","repository_url":"https://api.github.com/repos/FormidableLabs/react-fast-compare","labels_url":"https://api.github.com/repos/FormidableLabs/react-fast-compare/issues/30/labels{/name}","comments_url":"https://api.github.com/repos/FormidableLabs/react-fast-compare/issues/30/comments","events_url":"https://api.github.com/repos/FormidableLabs/react-fast-compare/issues/30/events","html_url":"https://github.com/FormidableLabs/react-fast-compare/issues/30","id":340741119,"node_id":"MDU6SXNzdWUzNDA3NDExMTk=","number":30,"title":"[2.0.1] Circular references in prod","user":{"login":"natew","id":12100,"node_id":"MDQ6VXNlcjEyMTAw","avatar_url":"https://avatars0.githubusercontent.com/u/12100?v=4","gravatar_id":"","url":"https://api.github.com/users/natew","html_url":"https://github.com/natew","followers_url":"https://api.github.com/users/natew/followers","following_url":"https://api.github.com/users/natew/following{/other_user}","gists_url":"https://api.github.com/users/natew/gists{/gist_id}","starred_url":"https://api.github.com/users/natew/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natew/subscriptions","organizations_url":"https://api.github.com/users/natew/orgs","repos_url":"https://api.github.com/users/natew/repos","events_url":"https://api.github.com/users/natew/events{/privacy}","received_events_url":"https://api.github.com/users/natew/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-07-12T18:04:09Z","updated_at":"2018-11-09T05:02:47Z","closed_at":"2018-11-09T05:02:47Z","author_association":"NONE","body":"Saw a previous issue, but still getting this in 2.0.1. Here's the output:\r\n\r\n![image](https://user-images.githubusercontent.com/12100/42650456-4831f258-85c1-11e8-99c1-95c99626f549.png)\r\n\r\nI'm essentially comparing props, nothing too strange. The objects are all non-circular besides the react children. In dev mode it works just fine, in prod (Uglify compressed) it seems to break.\r\n\r\nI'm using these opts:\r\n\r\n```\r\nnew UglifyJsPlugin({\r\n        uglifyOptions: {\r\n          ecma: 8,\r\n          toplevel: true,\r\n        },\r\n        sourceMap: true,\r\n        cache: true,\r\n        parallel: true,\r\n      }),\r\n```\r\n\r\nAnd packages:\r\n\r\n```\r\nwebpack@4.15.1\r\nreact@16.4.0\r\n```\r\n\r\nGoing to look into it further, prod mode is a bit harder to debug obviously but I've isolated where it's happening."}}
{"actor":{"display_login":"chrisbolin"}}