{"action":"created","comment":{"url":"https://api.github.com/repos/DotNetAnalyzers/AsyncUsageAnalyzers/pulls/comments/207864363","pull_request_review_id":143558714,"id":207864363,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzg2NDM2Mw==","diff_hunk":"@@ -25,7 +25,8 @@ public static bool HasAsyncSignature(this IMethodSymbol symbol, bool treatAsyncV\n             if (!symbol.IsAsync)\n             {\n                 // This check conveniently covers Task and Task<T> by ignoring the `1 in Task<T>.\n-                if (!string.Equals(nameof(Task), symbol.ReturnType?.Name, StringComparison.Ordinal))\n+                if (!string.Equals(nameof(Task), symbol.ReturnType?.Name, StringComparison.Ordinal)\n+                    && !string.Equals(\"ValueTask\", symbol.ReturnType?.Name, StringComparison.Ordinal))","path":"AsyncUsageAnalyzers/AsyncUsageAnalyzers/Helpers/MethodSymbolExtensions.cs","position":6,"original_position":6,"commit_id":"a770626dfbb8959000286b2f9d3358e9dcb25d6f","original_commit_id":"a770626dfbb8959000286b2f9d3358e9dcb25d6f","user":{"login":"AArnott","id":3548,"node_id":"MDQ6VXNlcjM1NDg=","avatar_url":"https://avatars2.githubusercontent.com/u/3548?v=4","gravatar_id":"","url":"https://api.github.com/users/AArnott","html_url":"https://github.com/AArnott","followers_url":"https://api.github.com/users/AArnott/followers","following_url":"https://api.github.com/users/AArnott/following{/other_user}","gists_url":"https://api.github.com/users/AArnott/gists{/gist_id}","starred_url":"https://api.github.com/users/AArnott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AArnott/subscriptions","organizations_url":"https://api.github.com/users/AArnott/orgs","repos_url":"https://api.github.com/users/AArnott/repos","events_url":"https://api.github.com/users/AArnott/events{/privacy}","received_events_url":"https://api.github.com/users/AArnott/received_events","type":"User","site_admin":false},"body":"Why not allow any type whose GetAwaitInfo suggests the type is awaitable? ","created_at":"2018-08-06T11:52:57Z","updated_at":"2018-08-06T11:53:08Z","html_url":"https://github.com/DotNetAnalyzers/AsyncUsageAnalyzers/pull/70#discussion_r207864363","pull_request_url":"https://api.github.com/repos/DotNetAnalyzers/AsyncUsageAnalyzers/pulls/70","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/DotNetAnalyzers/AsyncUsageAnalyzers/pulls/comments/207864363"},"html":{"href":"https://github.com/DotNetAnalyzers/AsyncUsageAnalyzers/pull/70#discussion_r207864363"},"pull_request":{"href":"https://api.github.com/repos/DotNetAnalyzers/AsyncUsageAnalyzers/pulls/70"}}},"pull_request":{"url":"https://api.github.com/repos/DotNetAnalyzers/AsyncUsageAnalyzers/pulls/70","id":206364713,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MzY0NzEz","html_url":"https://github.com/DotNetAnalyzers/AsyncUsageAnalyzers/pull/70","diff_url":"https://github.com/DotNetAnalyzers/AsyncUsageAnalyzers/pull/70.diff","patch_url":"https://github.com/DotNetAnalyzers/AsyncUsageAnalyzers/pull/70.patch","issue_url":"https://api.github.com/repos/DotNetAnalyzers/AsyncUsageAnalyzers/issues/70","number":70,"state":"open","locked":false,"title":"Treat ValueTask<TResult> as an asynchronous return type","user":{"login":"sharwell","id":1408396,"node_id":"MDQ6VXNlcjE0MDgzOTY=","avatar_url":"https://avatars1.githubusercontent.com/u/1408396?v=4","gravatar_id":"","url":"https://api.github.com/users/sharwell","html_url":"https://github.com/sharwell","followers_url":"https://api.github.com/users/sharwell/followers","following_url":"https://api.github.com/users/sharwell/following{/other_user}","gists_url":"https://api.github.com/users/sharwell/gists{/gist_id}","starred_url":"https://api.github.com/users/sharwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharwell/subscriptions","organizations_url":"https://api.github.com/users/sharwell/orgs","repos_url":"https://api.github.com/users/sharwell/repos","events_url":"https://api.github.com/users/sharwell/events{/privacy}","received_events_url":"https://api.github.com/users/sharwell/received_events","type":"User","site_admin":false},"body":"Fixes #68","created_at":"2018-08-06T11:09:26Z","updated_at":"2018-08-06T11:53:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8d22057fa790a88bfcc0de8d4a76d43797a77652","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/DotNetAnalyzers/AsyncUsageAnalyzers/pulls/70/commits","review_comments_url":"https://api.github.com/repos/DotNetAnalyzers/AsyncUsageAnalyzers/pulls/70/comments","review_comment_url":"https://api.github.com/repos/DotNetAnalyzers/AsyncUsageAnalyzers/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DotNetAnalyzers/AsyncUsageAnalyzers/issues/70/comments","statuses_url":"https://api.github.com/repos/DotNetAnalyzers/AsyncUsageAnalyzers/statuses/a770626dfbb8959000286b2f9d3358e9dcb25d6f","head":{"label":"sharwell:support-valuetask","ref":"support-valuetask","sha":"a770626dfbb8959000286b2f9d3358e9dcb25d6f","user":{"login":"sharwell","id":1408396,"node_id":"MDQ6VXNlcjE0MDgzOTY=","avatar_url":"https://avatars1.githubusercontent.com/u/1408396?v=4","gravatar_id":"","url":"https://api.github.com/users/sharwell","html_url":"https://github.com/sharwell","followers_url":"https://api.github.com/users/sharwell/followers","following_url":"https://api.github.com/users/sharwell/following{/other_user}","gists_url":"https://api.github.com/users/sharwell/gists{/gist_id}","starred_url":"https://api.github.com/users/sharwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharwell/subscriptions","organizations_url":"https://api.github.com/users/sharwell/orgs","repos_url":"https://api.github.com/users/sharwell/repos","events_url":"https://api.github.com/users/sharwell/events{/privacy}","received_events_url":"https://api.github.com/users/sharwell/received_events","type":"User","site_admin":false},"repo":{"id":34986458,"node_id":"MDEwOlJlcG9zaXRvcnkzNDk4NjQ1OA==","name":"AsyncUsageAnalyzers","full_name":"sharwell/AsyncUsageAnalyzers","owner":{"login":"sharwell","id":1408396,"node_id":"MDQ6VXNlcjE0MDgzOTY=","avatar_url":"https://avatars1.githubusercontent.com/u/1408396?v=4","gravatar_id":"","url":"https://api.github.com/users/sharwell","html_url":"https://github.com/sharwell","followers_url":"https://api.github.com/users/sharwell/followers","following_url":"https://api.github.com/users/sharwell/following{/other_user}","gists_url":"https://api.github.com/users/sharwell/gists{/gist_id}","starred_url":"https://api.github.com/users/sharwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharwell/subscriptions","organizations_url":"https://api.github.com/users/sharwell/orgs","repos_url":"https://api.github.com/users/sharwell/repos","events_url":"https://api.github.com/users/sharwell/events{/privacy}","received_events_url":"https://api.github.com/users/sharwell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sharwell/AsyncUsageAnalyzers","description":"Analyzers for asynchronous .NET code","fork":true,"url":"https://api.github.com/repos/sharwell/AsyncUsageAnalyzers","forks_url":"https://api.github.com/repos/sharwell/AsyncUsageAnalyzers/forks","keys_url":"https://api.github.com/repos/sharwell/AsyncUsageAnalyzers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sharwell/AsyncUsageAnalyzers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sharwell/AsyncUsageAnalyzers/teams","hooks_url":"https://api.github.com/repos/sharwell/AsyncUsageAnalyzers/hooks","issue_events_url":"https://api.github.com/repos/sharwell/AsyncUsageAnalyzers/issues/events{/number}","events_url":"https://api.github.com/repos/sharwell/AsyncUsageAnalyzers/events","assignees_url":"https://api.github.com/repos/sharwell/AsyncUsageAnalyzers/assignees{/user}","branches_url":"https://api.github.com/repos/sharwell/AsyncUsageAnalyzers/branches{/branch}","tags_url":"https://api.github.com/repos/sharwell/AsyncUsageAnalyzers/tags","blobs_url":"https://api.github.com/repos/sharwell/AsyncUsageAnalyzers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sharwell/AsyncUsageAnalyzers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sharwell/AsyncUsageAnalyzers/git/refs{/sha}","trees_url":"https://api.github.com/repos/sharwell/AsyncUsageAnalyzers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sharwell/AsyncUsageAnalyzers/statuses/{sha}","languages_url":"https://api.github.com/repos/sharwell/AsyncUsageAnalyzers/languages","stargazers_url":"https://api.github.com/repos/sharwell/AsyncUsageAnalyzers/stargazers","contributors_url":"https://api.github.com/repos/sharwell/AsyncUsageAnalyzers/contributors","subscribers_url":"https://api.github.com/repos/sharwell/AsyncUsageAnalyzers/subscribers","subscription_url":"https://api.github.com/repos/sharwell/AsyncUsageAnalyzers/subscription","commits_url":"https://api.github.com/repos/sharwell/AsyncUsageAnalyzers/commits{/sha}","git_commits_url":"https://api.github.com/repos/sharwell/AsyncUsageAnalyzers/git/commits{/sha}","comments_url":"https://api.github.com/repos/sharwell/AsyncUsageAnalyzers/comments{/number}","issue_comment_url":"https://api.github.com/repos/sharwell/AsyncUsageAnalyzers/issues/comments{/number}","contents_url":"https://api.github.com/repos/sharwell/AsyncUsageAnalyzers/contents/{+path}","compare_url":"https://api.github.com/repos/sharwell/AsyncUsageAnalyzers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sharwell/AsyncUsageAnalyzers/merges","archive_url":"https://api.github.com/repos/sharwell/AsyncUsageAnalyzers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sharwell/AsyncUsageAnalyzers/downloads","issues_url":"https://api.github.com/repos/sharwell/AsyncUsageAnalyzers/issues{/number}","pulls_url":"https://api.github.com/repos/sharwell/AsyncUsageAnalyzers/pulls{/number}","milestones_url":"https://api.github.com/repos/sharwell/AsyncUsageAnalyzers/milestones{/number}","notifications_url":"https://api.github.com/repos/sharwell/AsyncUsageAnalyzers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sharwell/AsyncUsageAnalyzers/labels{/name}","releases_url":"https://api.github.com/repos/sharwell/AsyncUsageAnalyzers/releases{/id}","deployments_url":"https://api.github.com/repos/sharwell/AsyncUsageAnalyzers/deployments","created_at":"2015-05-03T13:12:30Z","updated_at":"2017-07-25T01:19:35Z","pushed_at":"2018-08-06T11:47:23Z","git_url":"git://github.com/sharwell/AsyncUsageAnalyzers.git","ssh_url":"git@github.com:sharwell/AsyncUsageAnalyzers.git","clone_url":"https://github.com/sharwell/AsyncUsageAnalyzers.git","svn_url":"https://github.com/sharwell/AsyncUsageAnalyzers","homepage":"","size":202,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DotNetAnalyzers:master","ref":"master","sha":"68e64c0d50439b3ea0aa483b791ad1c6bf40ee77","user":{"login":"DotNetAnalyzers","id":9735576,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk3MzU1NzY=","avatar_url":"https://avatars1.githubusercontent.com/u/9735576?v=4","gravatar_id":"","url":"https://api.github.com/users/DotNetAnalyzers","html_url":"https://github.com/DotNetAnalyzers","followers_url":"https://api.github.com/users/DotNetAnalyzers/followers","following_url":"https://api.github.com/users/DotNetAnalyzers/following{/other_user}","gists_url":"https://api.github.com/users/DotNetAnalyzers/gists{/gist_id}","starred_url":"https://api.github.com/users/DotNetAnalyzers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DotNetAnalyzers/subscriptions","organizations_url":"https://api.github.com/users/DotNetAnalyzers/orgs","repos_url":"https://api.github.com/users/DotNetAnalyzers/repos","events_url":"https://api.github.com/users/DotNetAnalyzers/events{/privacy}","received_events_url":"https://api.github.com/users/DotNetAnalyzers/received_events","type":"Organization","site_admin":false},"repo":{"id":26833711,"node_id":"MDEwOlJlcG9zaXRvcnkyNjgzMzcxMQ==","name":"AsyncUsageAnalyzers","full_name":"DotNetAnalyzers/AsyncUsageAnalyzers","owner":{"login":"DotNetAnalyzers","id":9735576,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk3MzU1NzY=","avatar_url":"https://avatars1.githubusercontent.com/u/9735576?v=4","gravatar_id":"","url":"https://api.github.com/users/DotNetAnalyzers","html_url":"https://github.com/DotNetAnalyzers","followers_url":"https://api.github.com/users/DotNetAnalyzers/followers","following_url":"https://api.github.com/users/DotNetAnalyzers/following{/other_user}","gists_url":"https://api.github.com/users/DotNetAnalyzers/gists{/gist_id}","starred_url":"https://api.github.com/users/DotNetAnalyzers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DotNetAnalyzers/subscriptions","organizations_url":"https://api.github.com/users/DotNetAnalyzers/orgs","repos_url":"https://api.github.com/users/DotNetAnalyzers/repos","events_url":"https://api.github.com/users/DotNetAnalyzers/events{/privacy}","received_events_url":"https://api.github.com/users/DotNetAnalyzers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DotNetAnalyzers/AsyncUsageAnalyzers","description":"Analyzers for asynchronous .NET code","fork":false,"url":"https://api.github.com/repos/DotNetAnalyzers/AsyncUsageAnalyzers","forks_url":"https://api.github.com/repos/DotNetAnalyzers/AsyncUsageAnalyzers/forks","keys_url":"https://api.github.com/repos/DotNetAnalyzers/AsyncUsageAnalyzers/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DotNetAnalyzers/AsyncUsageAnalyzers/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DotNetAnalyzers/AsyncUsageAnalyzers/teams","hooks_url":"https://api.github.com/repos/DotNetAnalyzers/AsyncUsageAnalyzers/hooks","issue_events_url":"https://api.github.com/repos/DotNetAnalyzers/AsyncUsageAnalyzers/issues/events{/number}","events_url":"https://api.github.com/repos/DotNetAnalyzers/AsyncUsageAnalyzers/events","assignees_url":"https://api.github.com/repos/DotNetAnalyzers/AsyncUsageAnalyzers/assignees{/user}","branches_url":"https://api.github.com/repos/DotNetAnalyzers/AsyncUsageAnalyzers/branches{/branch}","tags_url":"https://api.github.com/repos/DotNetAnalyzers/AsyncUsageAnalyzers/tags","blobs_url":"https://api.github.com/repos/DotNetAnalyzers/AsyncUsageAnalyzers/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DotNetAnalyzers/AsyncUsageAnalyzers/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DotNetAnalyzers/AsyncUsageAnalyzers/git/refs{/sha}","trees_url":"https://api.github.com/repos/DotNetAnalyzers/AsyncUsageAnalyzers/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DotNetAnalyzers/AsyncUsageAnalyzers/statuses/{sha}","languages_url":"https://api.github.com/repos/DotNetAnalyzers/AsyncUsageAnalyzers/languages","stargazers_url":"https://api.github.com/repos/DotNetAnalyzers/AsyncUsageAnalyzers/stargazers","contributors_url":"https://api.github.com/repos/DotNetAnalyzers/AsyncUsageAnalyzers/contributors","subscribers_url":"https://api.github.com/repos/DotNetAnalyzers/AsyncUsageAnalyzers/subscribers","subscription_url":"https://api.github.com/repos/DotNetAnalyzers/AsyncUsageAnalyzers/subscription","commits_url":"https://api.github.com/repos/DotNetAnalyzers/AsyncUsageAnalyzers/commits{/sha}","git_commits_url":"https://api.github.com/repos/DotNetAnalyzers/AsyncUsageAnalyzers/git/commits{/sha}","comments_url":"https://api.github.com/repos/DotNetAnalyzers/AsyncUsageAnalyzers/comments{/number}","issue_comment_url":"https://api.github.com/repos/DotNetAnalyzers/AsyncUsageAnalyzers/issues/comments{/number}","contents_url":"https://api.github.com/repos/DotNetAnalyzers/AsyncUsageAnalyzers/contents/{+path}","compare_url":"https://api.github.com/repos/DotNetAnalyzers/AsyncUsageAnalyzers/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DotNetAnalyzers/AsyncUsageAnalyzers/merges","archive_url":"https://api.github.com/repos/DotNetAnalyzers/AsyncUsageAnalyzers/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DotNetAnalyzers/AsyncUsageAnalyzers/downloads","issues_url":"https://api.github.com/repos/DotNetAnalyzers/AsyncUsageAnalyzers/issues{/number}","pulls_url":"https://api.github.com/repos/DotNetAnalyzers/AsyncUsageAnalyzers/pulls{/number}","milestones_url":"https://api.github.com/repos/DotNetAnalyzers/AsyncUsageAnalyzers/milestones{/number}","notifications_url":"https://api.github.com/repos/DotNetAnalyzers/AsyncUsageAnalyzers/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DotNetAnalyzers/AsyncUsageAnalyzers/labels{/name}","releases_url":"https://api.github.com/repos/DotNetAnalyzers/AsyncUsageAnalyzers/releases{/id}","deployments_url":"https://api.github.com/repos/DotNetAnalyzers/AsyncUsageAnalyzers/deployments","created_at":"2014-11-18T22:44:42Z","updated_at":"2018-07-30T10:36:21Z","pushed_at":"2018-08-06T11:52:50Z","git_url":"git://github.com/DotNetAnalyzers/AsyncUsageAnalyzers.git","ssh_url":"git@github.com:DotNetAnalyzers/AsyncUsageAnalyzers.git","clone_url":"https://github.com/DotNetAnalyzers/AsyncUsageAnalyzers.git","svn_url":"https://github.com/DotNetAnalyzers/AsyncUsageAnalyzers","homepage":"","size":207,"stargazers_count":46,"watchers_count":46,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":14,"open_issues":24,"watchers":46,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DotNetAnalyzers/AsyncUsageAnalyzers/pulls/70"},"html":{"href":"https://github.com/DotNetAnalyzers/AsyncUsageAnalyzers/pull/70"},"issue":{"href":"https://api.github.com/repos/DotNetAnalyzers/AsyncUsageAnalyzers/issues/70"},"comments":{"href":"https://api.github.com/repos/DotNetAnalyzers/AsyncUsageAnalyzers/issues/70/comments"},"review_comments":{"href":"https://api.github.com/repos/DotNetAnalyzers/AsyncUsageAnalyzers/pulls/70/comments"},"review_comment":{"href":"https://api.github.com/repos/DotNetAnalyzers/AsyncUsageAnalyzers/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DotNetAnalyzers/AsyncUsageAnalyzers/pulls/70/commits"},"statuses":{"href":"https://api.github.com/repos/DotNetAnalyzers/AsyncUsageAnalyzers/statuses/a770626dfbb8959000286b2f9d3358e9dcb25d6f"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"AArnott"}}