{"action":"created","issue":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/44951","repository_url":"https://api.github.com/repos/NixOS/nixpkgs","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/44951/labels{/name}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/44951/comments","events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/44951/events","html_url":"https://github.com/NixOS/nixpkgs/pull/44951","id":349848238,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3ODQzMDgw","number":44951,"title":"eagle: 7.7 -> 9.1.2","user":{"login":"rittelle","id":33598633,"node_id":"MDQ6VXNlcjMzNTk4NjMz","avatar_url":"https://avatars3.githubusercontent.com/u/33598633?v=4","gravatar_id":"","url":"https://api.github.com/users/rittelle","html_url":"https://github.com/rittelle","followers_url":"https://api.github.com/users/rittelle/followers","following_url":"https://api.github.com/users/rittelle/following{/other_user}","gists_url":"https://api.github.com/users/rittelle/gists{/gist_id}","starred_url":"https://api.github.com/users/rittelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rittelle/subscriptions","organizations_url":"https://api.github.com/users/rittelle/orgs","repos_url":"https://api.github.com/users/rittelle/repos","events_url":"https://api.github.com/users/rittelle/events{/privacy}","received_events_url":"https://api.github.com/users/rittelle/received_events","type":"User","site_admin":false},"labels":[{"id":737642262,"node_id":"MDU6TGFiZWw3Mzc2NDIyNjI=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%200","name":"10.rebuild-darwin: 0","color":"eeffee","default":false},{"id":731733923,"node_id":"MDU6TGFiZWw3MzE3MzM5MjM=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%201-10","name":"10.rebuild-linux: 1-10","color":"eeffee","default":false},{"id":290122988,"node_id":"MDU6TGFiZWwyOTAxMjI5ODg=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20clean-up","name":"8.has: clean-up","color":"009800","default":false},{"id":290122734,"node_id":"MDU6TGFiZWwyOTAxMjI3MzQ=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20package%20(new)","name":"8.has: package (new)","color":"009800","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":13,"created_at":"2018-08-12T22:10:38Z","updated_at":"2018-08-21T02:34:56Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/44951","html_url":"https://github.com/NixOS/nixpkgs/pull/44951","diff_url":"https://github.com/NixOS/nixpkgs/pull/44951.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/44951.patch"},"body":"Updated eagle to version to 9.1.2 while keeping version 7.7 as eagle7.\r\n\r\n###### Motivation for this change\r\n\r\nEagle was _a bit_ outdated (see #43695).\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [X] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [X] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)\r\n- [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments/414530270","html_url":"https://github.com/NixOS/nixpkgs/pull/44951#issuecomment-414530270","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/44951","id":414530270,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNDUzMDI3MA==","user":{"login":"bjornfor","id":133602,"node_id":"MDQ6VXNlcjEzMzYwMg==","avatar_url":"https://avatars1.githubusercontent.com/u/133602?v=4","gravatar_id":"","url":"https://api.github.com/users/bjornfor","html_url":"https://github.com/bjornfor","followers_url":"https://api.github.com/users/bjornfor/followers","following_url":"https://api.github.com/users/bjornfor/following{/other_user}","gists_url":"https://api.github.com/users/bjornfor/gists{/gist_id}","starred_url":"https://api.github.com/users/bjornfor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bjornfor/subscriptions","organizations_url":"https://api.github.com/users/bjornfor/orgs","repos_url":"https://api.github.com/users/bjornfor/repos","events_url":"https://api.github.com/users/bjornfor/events{/privacy}","received_events_url":"https://api.github.com/users/bjornfor/received_events","type":"User","site_admin":false},"created_at":"2018-08-21T02:34:56Z","updated_at":"2018-08-21T02:34:56Z","author_association":"CONTRIBUTOR","body":"@rittelle: I build and run with ```git checkout origin/pr/44951 && nix-build -A eagle && ./result/bin/eagle```.\r\n\r\nUsing  ```nix-build -E 'with import <nixpkgs> { }; libsForQt5.callPackage ./eagle.nix {}'``` is not reproducible since ```<nixpkgs>``` resolves to different things depending on what's in $NIX_PATH (different glibc, qt etc.). When I'm on NixOS 18.03 it works. When I switch to unstable/master it fails, in the same way as running ```nix-build -A eagle && ./result/bin/eagle``` in the nixpkgs tree.\r\n\r\n@Mic92: Yes, I still get the problem when using ```nix-review pr 44951``` and invoking ```eagle``` in its nix-shell. How weird that we get different result.\r\n"}}
{"actor":{"display_login":"bjornfor"}}