{"action":"created","issue":{"url":"https://api.github.com/repos/quantopian/zipline/issues/2192","repository_url":"https://api.github.com/repos/quantopian/zipline","labels_url":"https://api.github.com/repos/quantopian/zipline/issues/2192/labels{/name}","comments_url":"https://api.github.com/repos/quantopian/zipline/issues/2192/comments","events_url":"https://api.github.com/repos/quantopian/zipline/issues/2192/events","html_url":"https://github.com/quantopian/zipline/pull/2192","id":324798850,"number":2192,"title":"Remove TradingEnvironment","user":{"login":"ssanderson","id":1588357,"avatar_url":"https://avatars0.githubusercontent.com/u/1588357?v=4","gravatar_id":"","url":"https://api.github.com/users/ssanderson","html_url":"https://github.com/ssanderson","followers_url":"https://api.github.com/users/ssanderson/followers","following_url":"https://api.github.com/users/ssanderson/following{/other_user}","gists_url":"https://api.github.com/users/ssanderson/gists{/gist_id}","starred_url":"https://api.github.com/users/ssanderson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssanderson/subscriptions","organizations_url":"https://api.github.com/users/ssanderson/orgs","repos_url":"https://api.github.com/users/ssanderson/repos","events_url":"https://api.github.com/users/ssanderson/events{/privacy}","received_events_url":"https://api.github.com/users/ssanderson/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-21T06:11:06Z","updated_at":"2018-05-21T15:16:50Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/quantopian/zipline/pulls/2192","html_url":"https://github.com/quantopian/zipline/pull/2192","diff_url":"https://github.com/quantopian/zipline/pull/2192.diff","patch_url":"https://github.com/quantopian/zipline/pull/2192.patch"},"body":"Built on top of https://github.com/quantopian/zipline/pull/2191. Only the last commit is new.\r\n\r\nThis PR removes the `TradingEnvironment` class, along with all existing references to it. The remaining usages of the class were:\r\n\r\n1. Carrying around an `AssetFinder`. Many pieces of code accessed an asset finder via `self.env.asset_finder`. These were straightforward to replace with a direct reference to an available asset finder.\r\n2. Mutating the `AssetFinder`'s `engine` in place via the `write_data` method. This happened in TradingAlgorithm when the user passed in a Panel or DataFrame. I removed that code path entirely, since it was a mess, and we've been encouraging people to use the bundle API for over a year now. Nevertheless, this is a nontrivial breaking change. It probably warrants a 2.0 release for Zipline. If that's the case, I think we should consider removing many of the backwards compat shims, since using them is questionable at best, and they've been deprecated for nearly two years now.\r\n3. Managing benchmark and treasury data. I replaced this with a new `benchmark_returns` parameter on TradingAlgorithm, which is used where we would have previously used `self.env.benchmark_returns`."},"comment":{"url":"https://api.github.com/repos/quantopian/zipline/issues/comments/390685555","html_url":"https://github.com/quantopian/zipline/pull/2192#issuecomment-390685555","issue_url":"https://api.github.com/repos/quantopian/zipline/issues/2192","id":390685555,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars1.githubusercontent.com/u/2354108?v=4","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2018-05-21T15:16:50Z","updated_at":"2018-05-21T15:16:50Z","author_association":"NONE","body":"\n[![Coverage Status](https://coveralls.io/builds/17087153/badge)](https://coveralls.io/builds/17087153)\n\nCoverage increased (+0.3%) to 87.021% when pulling **83501a052da39f3449c3541e37d0d06fec6ff7e5 on trading-environment-is-dead-long-live-trading-environment** into **7723c19297455065dbc38ca2eb5c91f9530197f3 on master**.\n"}}
{"actor":{"display_login":"coveralls"}}