{"action":"closed","issue":{"url":"https://api.github.com/repos/Cycling74/min-lib/issues/37","repository_url":"https://api.github.com/repos/Cycling74/min-lib","labels_url":"https://api.github.com/repos/Cycling74/min-lib/issues/37/labels{/name}","comments_url":"https://api.github.com/repos/Cycling74/min-lib/issues/37/comments","events_url":"https://api.github.com/repos/Cycling74/min-lib/issues/37/events","html_url":"https://github.com/Cycling74/min-lib/issues/37","id":329840651,"node_id":"MDU6SXNzdWUzMjk4NDA2NTE=","number":37,"title":"Delay intergral_size() value should be stored in class variable","user":{"login":"nwolek","id":464655,"node_id":"MDQ6VXNlcjQ2NDY1NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/464655?v=4","gravatar_id":"","url":"https://api.github.com/users/nwolek","html_url":"https://github.com/nwolek","followers_url":"https://api.github.com/users/nwolek/followers","following_url":"https://api.github.com/users/nwolek/following{/other_user}","gists_url":"https://api.github.com/users/nwolek/gists{/gist_id}","starred_url":"https://api.github.com/users/nwolek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nwolek/subscriptions","organizations_url":"https://api.github.com/users/nwolek/orgs","repos_url":"https://api.github.com/users/nwolek/repos","events_url":"https://api.github.com/users/nwolek/events{/privacy}","received_events_url":"https://api.github.com/users/nwolek/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-06-06T12:11:36Z","updated_at":"2018-06-19T12:16:41Z","closed_at":"2018-06-19T12:16:41Z","author_association":"COLLABORATOR","body":"The [function for integral_size()](https://github.com/Cycling74/min-lib/blob/master/include/c74_lib_delay.h#L62) in Delay is performing this cast operation each time it is called:\r\n\r\n`static_cast<std::size_t>(m_size);`\r\n\r\nBecause of interpolation, this is now happening 4+ times for each sample. Performing the cast [once at the time we set size](https://github.com/Cycling74/min-lib/blob/master/include/c74_lib_delay.h#L45) and storing it in a class variable should give us a performance boost. We already do this with [m_fractional_size](https://github.com/Cycling74/min-lib/blob/master/include/c74_lib_delay.h#L70)."}}
{"actor":{"display_login":"nwolek"}}