{"action":"closed","number":5373,"pull_request":{"url":"https://api.github.com/repos/PolarisSS13/Polaris/pulls/5373","id":196965096,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2OTY1MDk2","html_url":"https://github.com/PolarisSS13/Polaris/pull/5373","diff_url":"https://github.com/PolarisSS13/Polaris/pull/5373.diff","patch_url":"https://github.com/PolarisSS13/Polaris/pull/5373.patch","issue_url":"https://api.github.com/repos/PolarisSS13/Polaris/issues/5373","number":5373,"state":"closed","locked":false,"title":"Fix invalid logic in clonepod beaker function","user":{"login":"Arokha","id":15028025,"node_id":"MDQ6VXNlcjE1MDI4MDI1","avatar_url":"https://avatars1.githubusercontent.com/u/15028025?v=4","gravatar_id":"","url":"https://api.github.com/users/Arokha","html_url":"https://github.com/Arokha","followers_url":"https://api.github.com/users/Arokha/followers","following_url":"https://api.github.com/users/Arokha/following{/other_user}","gists_url":"https://api.github.com/users/Arokha/gists{/gist_id}","starred_url":"https://api.github.com/users/Arokha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Arokha/subscriptions","organizations_url":"https://api.github.com/users/Arokha/orgs","repos_url":"https://api.github.com/users/Arokha/repos","events_url":"https://api.github.com/users/Arokha/events{/privacy}","received_events_url":"https://api.github.com/users/Arokha/received_events","type":"User","site_admin":false},"body":"Reported in: https://github.com/VOREStation/VOREStation/issues/3926\r\n\r\nThis logic doesn't do what you think it does, perhaps. If you have 0 beakers in the clonepod, then you will never be able to add another beaker. The flow will go thus:\r\n![sourcetree_2018-06-24_15-12-22](https://user-images.githubusercontent.com/15028025/41822696-ccaeaea8-77c1-11e8-9c46-479b41997ca4.png)\r\n\r\nLazylen will be 'false' because it will be 0, and therefore you will be told you can't put any beakers in. If you have any beakers in, you can add more, but if you remove all of them or ever reach 0 beakers, you cannot insert any more.","created_at":"2018-06-24T19:18:46Z","updated_at":"2018-06-26T00:38:27Z","closed_at":"2018-06-26T00:38:27Z","merged_at":"2018-06-26T00:38:26Z","merge_commit_sha":"3a709c12d6d80e26df5cdbedfc6982b133d5798f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":233601898,"node_id":"MDU6TGFiZWwyMzM2MDE4OTg=","url":"https://api.github.com/repos/PolarisSS13/Polaris/labels/Bugfix","name":"Bugfix","color":"6daa2c","default":false},{"id":196204164,"node_id":"MDU6TGFiZWwxOTYyMDQxNjQ=","url":"https://api.github.com/repos/PolarisSS13/Polaris/labels/Oversight","name":"Oversight","color":"d04648","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/PolarisSS13/Polaris/pulls/5373/commits","review_comments_url":"https://api.github.com/repos/PolarisSS13/Polaris/pulls/5373/comments","review_comment_url":"https://api.github.com/repos/PolarisSS13/Polaris/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PolarisSS13/Polaris/issues/5373/comments","statuses_url":"https://api.github.com/repos/PolarisSS13/Polaris/statuses/e6a7b744f0f3200ae9a894627098f17e8c01c336","head":{"label":"VOREStation:pol-podfix","ref":"pol-podfix","sha":"e6a7b744f0f3200ae9a894627098f17e8c01c336","user":{"login":"VOREStation","id":12787406,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzg3NDA2","avatar_url":"https://avatars1.githubusercontent.com/u/12787406?v=4","gravatar_id":"","url":"https://api.github.com/users/VOREStation","html_url":"https://github.com/VOREStation","followers_url":"https://api.github.com/users/VOREStation/followers","following_url":"https://api.github.com/users/VOREStation/following{/other_user}","gists_url":"https://api.github.com/users/VOREStation/gists{/gist_id}","starred_url":"https://api.github.com/users/VOREStation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VOREStation/subscriptions","organizations_url":"https://api.github.com/users/VOREStation/orgs","repos_url":"https://api.github.com/users/VOREStation/repos","events_url":"https://api.github.com/users/VOREStation/events{/privacy}","received_events_url":"https://api.github.com/users/VOREStation/received_events","type":"Organization","site_admin":false},"repo":{"id":58276221,"node_id":"MDEwOlJlcG9zaXRvcnk1ODI3NjIyMQ==","name":"Polaris","full_name":"VOREStation/Polaris","owner":{"login":"VOREStation","id":12787406,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNzg3NDA2","avatar_url":"https://avatars1.githubusercontent.com/u/12787406?v=4","gravatar_id":"","url":"https://api.github.com/users/VOREStation","html_url":"https://github.com/VOREStation","followers_url":"https://api.github.com/users/VOREStation/followers","following_url":"https://api.github.com/users/VOREStation/following{/other_user}","gists_url":"https://api.github.com/users/VOREStation/gists{/gist_id}","starred_url":"https://api.github.com/users/VOREStation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VOREStation/subscriptions","organizations_url":"https://api.github.com/users/VOREStation/orgs","repos_url":"https://api.github.com/users/VOREStation/repos","events_url":"https://api.github.com/users/VOREStation/events{/privacy}","received_events_url":"https://api.github.com/users/VOREStation/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/VOREStation/Polaris","description":"[DO NOT DEV] VOREStation direct fork of Polaris, for making upstream PRs.","fork":true,"url":"https://api.github.com/repos/VOREStation/Polaris","forks_url":"https://api.github.com/repos/VOREStation/Polaris/forks","keys_url":"https://api.github.com/repos/VOREStation/Polaris/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VOREStation/Polaris/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VOREStation/Polaris/teams","hooks_url":"https://api.github.com/repos/VOREStation/Polaris/hooks","issue_events_url":"https://api.github.com/repos/VOREStation/Polaris/issues/events{/number}","events_url":"https://api.github.com/repos/VOREStation/Polaris/events","assignees_url":"https://api.github.com/repos/VOREStation/Polaris/assignees{/user}","branches_url":"https://api.github.com/repos/VOREStation/Polaris/branches{/branch}","tags_url":"https://api.github.com/repos/VOREStation/Polaris/tags","blobs_url":"https://api.github.com/repos/VOREStation/Polaris/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VOREStation/Polaris/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VOREStation/Polaris/git/refs{/sha}","trees_url":"https://api.github.com/repos/VOREStation/Polaris/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VOREStation/Polaris/statuses/{sha}","languages_url":"https://api.github.com/repos/VOREStation/Polaris/languages","stargazers_url":"https://api.github.com/repos/VOREStation/Polaris/stargazers","contributors_url":"https://api.github.com/repos/VOREStation/Polaris/contributors","subscribers_url":"https://api.github.com/repos/VOREStation/Polaris/subscribers","subscription_url":"https://api.github.com/repos/VOREStation/Polaris/subscription","commits_url":"https://api.github.com/repos/VOREStation/Polaris/commits{/sha}","git_commits_url":"https://api.github.com/repos/VOREStation/Polaris/git/commits{/sha}","comments_url":"https://api.github.com/repos/VOREStation/Polaris/comments{/number}","issue_comment_url":"https://api.github.com/repos/VOREStation/Polaris/issues/comments{/number}","contents_url":"https://api.github.com/repos/VOREStation/Polaris/contents/{+path}","compare_url":"https://api.github.com/repos/VOREStation/Polaris/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VOREStation/Polaris/merges","archive_url":"https://api.github.com/repos/VOREStation/Polaris/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VOREStation/Polaris/downloads","issues_url":"https://api.github.com/repos/VOREStation/Polaris/issues{/number}","pulls_url":"https://api.github.com/repos/VOREStation/Polaris/pulls{/number}","milestones_url":"https://api.github.com/repos/VOREStation/Polaris/milestones{/number}","notifications_url":"https://api.github.com/repos/VOREStation/Polaris/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VOREStation/Polaris/labels{/name}","releases_url":"https://api.github.com/repos/VOREStation/Polaris/releases{/id}","deployments_url":"https://api.github.com/repos/VOREStation/Polaris/deployments","created_at":"2016-05-07T17:12:56Z","updated_at":"2018-06-24T19:05:55Z","pushed_at":"2018-06-24T19:19:58Z","git_url":"git://github.com/VOREStation/Polaris.git","ssh_url":"git@github.com:VOREStation/Polaris.git","clone_url":"https://github.com/VOREStation/Polaris.git","svn_url":"https://github.com/VOREStation/Polaris","homepage":"","size":929422,"stargazers_count":0,"watchers_count":0,"language":"DM","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PolarisSS13:master","ref":"master","sha":"94013e81bc05ea32bb1c47b048ca427600dfe512","user":{"login":"PolarisSS13","id":11812425,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODEyNDI1","avatar_url":"https://avatars1.githubusercontent.com/u/11812425?v=4","gravatar_id":"","url":"https://api.github.com/users/PolarisSS13","html_url":"https://github.com/PolarisSS13","followers_url":"https://api.github.com/users/PolarisSS13/followers","following_url":"https://api.github.com/users/PolarisSS13/following{/other_user}","gists_url":"https://api.github.com/users/PolarisSS13/gists{/gist_id}","starred_url":"https://api.github.com/users/PolarisSS13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolarisSS13/subscriptions","organizations_url":"https://api.github.com/users/PolarisSS13/orgs","repos_url":"https://api.github.com/users/PolarisSS13/repos","events_url":"https://api.github.com/users/PolarisSS13/events{/privacy}","received_events_url":"https://api.github.com/users/PolarisSS13/received_events","type":"Organization","site_admin":false},"repo":{"id":33467707,"node_id":"MDEwOlJlcG9zaXRvcnkzMzQ2NzcwNw==","name":"Polaris","full_name":"PolarisSS13/Polaris","owner":{"login":"PolarisSS13","id":11812425,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODEyNDI1","avatar_url":"https://avatars1.githubusercontent.com/u/11812425?v=4","gravatar_id":"","url":"https://api.github.com/users/PolarisSS13","html_url":"https://github.com/PolarisSS13","followers_url":"https://api.github.com/users/PolarisSS13/followers","following_url":"https://api.github.com/users/PolarisSS13/following{/other_user}","gists_url":"https://api.github.com/users/PolarisSS13/gists{/gist_id}","starred_url":"https://api.github.com/users/PolarisSS13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolarisSS13/subscriptions","organizations_url":"https://api.github.com/users/PolarisSS13/orgs","repos_url":"https://api.github.com/users/PolarisSS13/repos","events_url":"https://api.github.com/users/PolarisSS13/events{/privacy}","received_events_url":"https://api.github.com/users/PolarisSS13/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PolarisSS13/Polaris","description":" Polaris - A version of Spacestation13, forked from Baystation12.","fork":false,"url":"https://api.github.com/repos/PolarisSS13/Polaris","forks_url":"https://api.github.com/repos/PolarisSS13/Polaris/forks","keys_url":"https://api.github.com/repos/PolarisSS13/Polaris/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PolarisSS13/Polaris/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PolarisSS13/Polaris/teams","hooks_url":"https://api.github.com/repos/PolarisSS13/Polaris/hooks","issue_events_url":"https://api.github.com/repos/PolarisSS13/Polaris/issues/events{/number}","events_url":"https://api.github.com/repos/PolarisSS13/Polaris/events","assignees_url":"https://api.github.com/repos/PolarisSS13/Polaris/assignees{/user}","branches_url":"https://api.github.com/repos/PolarisSS13/Polaris/branches{/branch}","tags_url":"https://api.github.com/repos/PolarisSS13/Polaris/tags","blobs_url":"https://api.github.com/repos/PolarisSS13/Polaris/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PolarisSS13/Polaris/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PolarisSS13/Polaris/git/refs{/sha}","trees_url":"https://api.github.com/repos/PolarisSS13/Polaris/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PolarisSS13/Polaris/statuses/{sha}","languages_url":"https://api.github.com/repos/PolarisSS13/Polaris/languages","stargazers_url":"https://api.github.com/repos/PolarisSS13/Polaris/stargazers","contributors_url":"https://api.github.com/repos/PolarisSS13/Polaris/contributors","subscribers_url":"https://api.github.com/repos/PolarisSS13/Polaris/subscribers","subscription_url":"https://api.github.com/repos/PolarisSS13/Polaris/subscription","commits_url":"https://api.github.com/repos/PolarisSS13/Polaris/commits{/sha}","git_commits_url":"https://api.github.com/repos/PolarisSS13/Polaris/git/commits{/sha}","comments_url":"https://api.github.com/repos/PolarisSS13/Polaris/comments{/number}","issue_comment_url":"https://api.github.com/repos/PolarisSS13/Polaris/issues/comments{/number}","contents_url":"https://api.github.com/repos/PolarisSS13/Polaris/contents/{+path}","compare_url":"https://api.github.com/repos/PolarisSS13/Polaris/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PolarisSS13/Polaris/merges","archive_url":"https://api.github.com/repos/PolarisSS13/Polaris/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PolarisSS13/Polaris/downloads","issues_url":"https://api.github.com/repos/PolarisSS13/Polaris/issues{/number}","pulls_url":"https://api.github.com/repos/PolarisSS13/Polaris/pulls{/number}","milestones_url":"https://api.github.com/repos/PolarisSS13/Polaris/milestones{/number}","notifications_url":"https://api.github.com/repos/PolarisSS13/Polaris/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PolarisSS13/Polaris/labels{/name}","releases_url":"https://api.github.com/repos/PolarisSS13/Polaris/releases{/id}","deployments_url":"https://api.github.com/repos/PolarisSS13/Polaris/deployments","created_at":"2015-04-06T05:10:58Z","updated_at":"2018-06-22T01:24:21Z","pushed_at":"2018-06-26T00:38:26Z","git_url":"git://github.com/PolarisSS13/Polaris.git","ssh_url":"git@github.com:PolarisSS13/Polaris.git","clone_url":"https://github.com/PolarisSS13/Polaris.git","svn_url":"https://github.com/PolarisSS13/Polaris","homepage":null,"size":795352,"stargazers_count":41,"watchers_count":41,"language":"DM","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":186,"mirror_url":null,"archived":false,"open_issues_count":206,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":186,"open_issues":206,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PolarisSS13/Polaris/pulls/5373"},"html":{"href":"https://github.com/PolarisSS13/Polaris/pull/5373"},"issue":{"href":"https://api.github.com/repos/PolarisSS13/Polaris/issues/5373"},"comments":{"href":"https://api.github.com/repos/PolarisSS13/Polaris/issues/5373/comments"},"review_comments":{"href":"https://api.github.com/repos/PolarisSS13/Polaris/pulls/5373/comments"},"review_comment":{"href":"https://api.github.com/repos/PolarisSS13/Polaris/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PolarisSS13/Polaris/pulls/5373/commits"},"statuses":{"href":"https://api.github.com/repos/PolarisSS13/Polaris/statuses/e6a7b744f0f3200ae9a894627098f17e8c01c336"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"Anewbe","id":10236878,"node_id":"MDQ6VXNlcjEwMjM2ODc4","avatar_url":"https://avatars2.githubusercontent.com/u/10236878?v=4","gravatar_id":"","url":"https://api.github.com/users/Anewbe","html_url":"https://github.com/Anewbe","followers_url":"https://api.github.com/users/Anewbe/followers","following_url":"https://api.github.com/users/Anewbe/following{/other_user}","gists_url":"https://api.github.com/users/Anewbe/gists{/gist_id}","starred_url":"https://api.github.com/users/Anewbe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Anewbe/subscriptions","organizations_url":"https://api.github.com/users/Anewbe/orgs","repos_url":"https://api.github.com/users/Anewbe/repos","events_url":"https://api.github.com/users/Anewbe/events{/privacy}","received_events_url":"https://api.github.com/users/Anewbe/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":8,"deletions":14,"changed_files":1}}
{"actor":{"display_login":"Anewbe"}}