{"action":"created","issue":{"url":"https://api.github.com/repos/rs/SDWebImage/issues/2303","repository_url":"https://api.github.com/repos/rs/SDWebImage","labels_url":"https://api.github.com/repos/rs/SDWebImage/issues/2303/labels{/name}","comments_url":"https://api.github.com/repos/rs/SDWebImage/issues/2303/comments","events_url":"https://api.github.com/repos/rs/SDWebImage/issues/2303/events","html_url":"https://github.com/rs/SDWebImage/pull/2303","id":317518312,"number":2303,"title":"Remove the duplicated process to force decode (draw on bitmap context) in Image/IO's progressive decoding.","user":{"login":"dreampiggy","id":6919743,"avatar_url":"https://avatars2.githubusercontent.com/u/6919743?v=4","gravatar_id":"","url":"https://api.github.com/users/dreampiggy","html_url":"https://github.com/dreampiggy","followers_url":"https://api.github.com/users/dreampiggy/followers","following_url":"https://api.github.com/users/dreampiggy/following{/other_user}","gists_url":"https://api.github.com/users/dreampiggy/gists{/gist_id}","starred_url":"https://api.github.com/users/dreampiggy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dreampiggy/subscriptions","organizations_url":"https://api.github.com/users/dreampiggy/orgs","repos_url":"https://api.github.com/users/dreampiggy/repos","events_url":"https://api.github.com/users/dreampiggy/events{/privacy}","received_events_url":"https://api.github.com/users/dreampiggy/received_events","type":"User","site_admin":false},"labels":[{"id":779880922,"url":"https://api.github.com/repos/rs/SDWebImage/labels/fix","name":"fix","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/rs/SDWebImage/milestones/15","html_url":"https://github.com/rs/SDWebImage/milestone/15","labels_url":"https://api.github.com/repos/rs/SDWebImage/milestones/15/labels","id":2676459,"number":15,"title":"5.0.0","description":"5.0.0 beta release","creator":{"login":"bpoplauschi","id":154913,"avatar_url":"https://avatars2.githubusercontent.com/u/154913?v=4","gravatar_id":"","url":"https://api.github.com/users/bpoplauschi","html_url":"https://github.com/bpoplauschi","followers_url":"https://api.github.com/users/bpoplauschi/followers","following_url":"https://api.github.com/users/bpoplauschi/following{/other_user}","gists_url":"https://api.github.com/users/bpoplauschi/gists{/gist_id}","starred_url":"https://api.github.com/users/bpoplauschi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bpoplauschi/subscriptions","organizations_url":"https://api.github.com/users/bpoplauschi/orgs","repos_url":"https://api.github.com/users/bpoplauschi/repos","events_url":"https://api.github.com/users/bpoplauschi/events{/privacy}","received_events_url":"https://api.github.com/users/bpoplauschi/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":37,"state":"open","created_at":"2017-08-02T12:24:08Z","updated_at":"2018-04-25T07:59:37Z","due_on":"2018-04-22T07:00:00Z","closed_at":null},"comments":0,"created_at":"2018-04-25T07:59:37Z","updated_at":"2018-04-25T08:14:21Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/rs/SDWebImage/pulls/2303","html_url":"https://github.com/rs/SDWebImage/pull/2303","diff_url":"https://github.com/rs/SDWebImage/pull/2303.diff","patch_url":"https://github.com/rs/SDWebImage/pull/2303.patch"},"body":"This is the bug in early version of Image/IO framework, but now it's already been fixed and duplicated process impact performance\r\n\r\n### New Pull Request Checklist\r\n\r\n* [x] I have read and understood the [CONTRIBUTING guide](https://github.com/rs/SDWebImage/blob/master/.github/CONTRIBUTING.md)\r\n* [x] I have read the [Documentation](http://cocoadocs.org/docsets/SDWebImage/)\r\n* [x] I have searched for a similar pull request in the [project](https://github.com/rs/SDWebImage/pulls) and found none\r\n\r\n* [x] I have updated this branch with the latest master to avoid conflicts (via merge from master or rebase)\r\n* [x] I have added the required tests to prove the fix/feature I am adding\r\n* [x] I have updated the documentation (if necessary)\r\n* [x] I have run the tests and they pass\r\n* [x] I have run the lint and it passes (`pod lib lint`)\r\n\r\nThis merge request fixes / reffers to the following issues: #1481\r\n\r\n### Pull Request Description\r\n\r\n### Reason\r\nThere seems a hack code to fix the issue about that `Workaround for iOS anamorphic image`. Which draw the image during progressive image decoding from `CGImageSourceCreateImageAtIndex`, into a bitmap context to `stretch` the full height. The original code is from [here](https://cocoaintheshell.whine.fr/2011/05/progressive-images-download-imageio/)\r\n\r\nHowever, this fix seems only useful for the early version of iOS firmware and Image/IO framework. During my test, Image/IO works well for iOS 8 and above. The returned image always and already contains transparent space to fill the unfinished height of progressive decoding. (The pixel data is not enough to produce full height images). So there are no need to draw it again, which cause more CPU usage. The test result can be found there in #1481\r\n\r\nI'd suggest to firstly merge in 5.x. This fix may not merge this into 4.x because it still supports iOS 7 and it's need another test later."},"comment":{"url":"https://api.github.com/repos/rs/SDWebImage/issues/comments/384199943","html_url":"https://github.com/rs/SDWebImage/pull/2303#issuecomment-384199943","issue_url":"https://api.github.com/repos/rs/SDWebImage/issues/2303","id":384199943,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-04-25T08:14:21Z","updated_at":"2018-04-25T08:14:21Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/rs/SDWebImage/pull/2303?src=pr&el=h1) Report\n> Merging [#2303](https://codecov.io/gh/rs/SDWebImage/pull/2303?src=pr&el=desc) into [5.x](https://codecov.io/gh/rs/SDWebImage/commit/5f85848aaa8f9d90a6c8c2e78269085b7e321c5f?src=pr&el=desc) will **decrease** coverage by `0.07%`.\n> The diff coverage is `n/a`.\n\n[![Impacted file tree graph](https://codecov.io/gh/rs/SDWebImage/pull/2303/graphs/tree.svg?width=650&height=150&src=pr&token=z7rinBoWL6)](https://codecov.io/gh/rs/SDWebImage/pull/2303?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##              5.x    #2303      +/-   ##\n==========================================\n- Coverage   69.09%   69.02%   -0.08%     \n==========================================\n  Files          48       48              \n  Lines        6572     6557      -15     \n==========================================\n- Hits         4541     4526      -15     \n  Misses       2031     2031\n```\n\n| Flag | Coverage Δ | |\n|---|---|---|\n| #iOS | `70.17% <ø> (-0.11%)` | :arrow_down: |\n| #macOS | `67.63% <ø> (-0.17%)` | :arrow_down: |\n\n| [Impacted Files](https://codecov.io/gh/rs/SDWebImage/pull/2303?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [SDWebImage/SDWebImageImageIOCoder.m](https://codecov.io/gh/rs/SDWebImage/pull/2303/diff?src=pr&el=tree#diff-U0RXZWJJbWFnZS9TRFdlYkltYWdlSW1hZ2VJT0NvZGVyLm0=) | `63.04% <ø> (-1.28%)` | :arrow_down: |\n| [SDWebImage/SDAnimatedImageView.m](https://codecov.io/gh/rs/SDWebImage/pull/2303/diff?src=pr&el=tree#diff-U0RXZWJJbWFnZS9TREFuaW1hdGVkSW1hZ2VWaWV3Lm0=) | `69.28% <0%> (-0.93%)` | :arrow_down: |\n| [SDWebImage/SDWebImageDownloader.m](https://codecov.io/gh/rs/SDWebImage/pull/2303/diff?src=pr&el=tree#diff-U0RXZWJJbWFnZS9TRFdlYkltYWdlRG93bmxvYWRlci5t) | `81.44% <0%> (+0.34%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/rs/SDWebImage/pull/2303?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/rs/SDWebImage/pull/2303?src=pr&el=footer). Last update [5f85848...8f49d75](https://codecov.io/gh/rs/SDWebImage/pull/2303?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}