{"action":"opened","number":31267,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/31267","id":222196714,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMTk2NzE0","html_url":"https://github.com/cockroachdb/cockroach/pull/31267","diff_url":"https://github.com/cockroachdb/cockroach/pull/31267.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/31267.patch","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/31267","number":31267,"state":"open","locked":false,"title":"roachtest: cluster ctors no longer take a test","user":{"login":"andreimatei","id":377201,"node_id":"MDQ6VXNlcjM3NzIwMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/377201?v=4","gravatar_id":"","url":"https://api.github.com/users/andreimatei","html_url":"https://github.com/andreimatei","followers_url":"https://api.github.com/users/andreimatei/followers","following_url":"https://api.github.com/users/andreimatei/following{/other_user}","gists_url":"https://api.github.com/users/andreimatei/gists{/gist_id}","starred_url":"https://api.github.com/users/andreimatei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreimatei/subscriptions","organizations_url":"https://api.github.com/users/andreimatei/orgs","repos_url":"https://api.github.com/users/andreimatei/repos","events_url":"https://api.github.com/users/andreimatei/events{/privacy}","received_events_url":"https://api.github.com/users/andreimatei/received_events","type":"User","site_admin":false},"body":"The divorcing of clusters from tests is now unavoidable, and this patch\r\nis another step in that direction.\r\nThis patch changes the cluster ctors to not take a test at all. Instead,\r\nc.setTest() needs to be called later to set c.t. The idea is that it can\r\nbe called multiple times on the same cluster (and also that eventually\r\nit will not be needed at all).\r\n\r\nRelease note: None","created_at":"2018-10-11T16:11:15Z","updated_at":"2018-10-11T16:11:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"petermattis","id":6201335,"node_id":"MDQ6VXNlcjYyMDEzMzU=","avatar_url":"https://avatars0.githubusercontent.com/u/6201335?v=4","gravatar_id":"","url":"https://api.github.com/users/petermattis","html_url":"https://github.com/petermattis","followers_url":"https://api.github.com/users/petermattis/followers","following_url":"https://api.github.com/users/petermattis/following{/other_user}","gists_url":"https://api.github.com/users/petermattis/gists{/gist_id}","starred_url":"https://api.github.com/users/petermattis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petermattis/subscriptions","organizations_url":"https://api.github.com/users/petermattis/orgs","repos_url":"https://api.github.com/users/petermattis/repos","events_url":"https://api.github.com/users/petermattis/events{/privacy}","received_events_url":"https://api.github.com/users/petermattis/received_events","type":"User","site_admin":false},"assignees":[{"login":"petermattis","id":6201335,"node_id":"MDQ6VXNlcjYyMDEzMzU=","avatar_url":"https://avatars0.githubusercontent.com/u/6201335?v=4","gravatar_id":"","url":"https://api.github.com/users/petermattis","html_url":"https://github.com/petermattis","followers_url":"https://api.github.com/users/petermattis/followers","following_url":"https://api.github.com/users/petermattis/following{/other_user}","gists_url":"https://api.github.com/users/petermattis/gists{/gist_id}","starred_url":"https://api.github.com/users/petermattis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/petermattis/subscriptions","organizations_url":"https://api.github.com/users/petermattis/orgs","repos_url":"https://api.github.com/users/petermattis/repos","events_url":"https://api.github.com/users/petermattis/events{/privacy}","received_events_url":"https://api.github.com/users/petermattis/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/31267/commits","review_comments_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/31267/comments","review_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/31267/comments","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/5b47ca092de62680920466e3b7eeb261030cdc37","head":{"label":"andreimatei:roachtest-set-test","ref":"roachtest-set-test","sha":"5b47ca092de62680920466e3b7eeb261030cdc37","user":{"login":"andreimatei","id":377201,"node_id":"MDQ6VXNlcjM3NzIwMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/377201?v=4","gravatar_id":"","url":"https://api.github.com/users/andreimatei","html_url":"https://github.com/andreimatei","followers_url":"https://api.github.com/users/andreimatei/followers","following_url":"https://api.github.com/users/andreimatei/following{/other_user}","gists_url":"https://api.github.com/users/andreimatei/gists{/gist_id}","starred_url":"https://api.github.com/users/andreimatei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreimatei/subscriptions","organizations_url":"https://api.github.com/users/andreimatei/orgs","repos_url":"https://api.github.com/users/andreimatei/repos","events_url":"https://api.github.com/users/andreimatei/events{/privacy}","received_events_url":"https://api.github.com/users/andreimatei/received_events","type":"User","site_admin":false},"repo":{"id":47720332,"node_id":"MDEwOlJlcG9zaXRvcnk0NzcyMDMzMg==","name":"cockroach","full_name":"andreimatei/cockroach","private":false,"owner":{"login":"andreimatei","id":377201,"node_id":"MDQ6VXNlcjM3NzIwMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/377201?v=4","gravatar_id":"","url":"https://api.github.com/users/andreimatei","html_url":"https://github.com/andreimatei","followers_url":"https://api.github.com/users/andreimatei/followers","following_url":"https://api.github.com/users/andreimatei/following{/other_user}","gists_url":"https://api.github.com/users/andreimatei/gists{/gist_id}","starred_url":"https://api.github.com/users/andreimatei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreimatei/subscriptions","organizations_url":"https://api.github.com/users/andreimatei/orgs","repos_url":"https://api.github.com/users/andreimatei/repos","events_url":"https://api.github.com/users/andreimatei/events{/privacy}","received_events_url":"https://api.github.com/users/andreimatei/received_events","type":"User","site_admin":false},"html_url":"https://github.com/andreimatei/cockroach","description":"A Scalable, Geo-Replicated, Transactional Datastore","fork":true,"url":"https://api.github.com/repos/andreimatei/cockroach","forks_url":"https://api.github.com/repos/andreimatei/cockroach/forks","keys_url":"https://api.github.com/repos/andreimatei/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andreimatei/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andreimatei/cockroach/teams","hooks_url":"https://api.github.com/repos/andreimatei/cockroach/hooks","issue_events_url":"https://api.github.com/repos/andreimatei/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/andreimatei/cockroach/events","assignees_url":"https://api.github.com/repos/andreimatei/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/andreimatei/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/andreimatei/cockroach/tags","blobs_url":"https://api.github.com/repos/andreimatei/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andreimatei/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andreimatei/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/andreimatei/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andreimatei/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/andreimatei/cockroach/languages","stargazers_url":"https://api.github.com/repos/andreimatei/cockroach/stargazers","contributors_url":"https://api.github.com/repos/andreimatei/cockroach/contributors","subscribers_url":"https://api.github.com/repos/andreimatei/cockroach/subscribers","subscription_url":"https://api.github.com/repos/andreimatei/cockroach/subscription","commits_url":"https://api.github.com/repos/andreimatei/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/andreimatei/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/andreimatei/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/andreimatei/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/andreimatei/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/andreimatei/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andreimatei/cockroach/merges","archive_url":"https://api.github.com/repos/andreimatei/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andreimatei/cockroach/downloads","issues_url":"https://api.github.com/repos/andreimatei/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/andreimatei/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/andreimatei/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/andreimatei/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andreimatei/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/andreimatei/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/andreimatei/cockroach/deployments","created_at":"2015-12-09T21:34:16Z","updated_at":"2016-05-05T22:01:56Z","pushed_at":"2018-10-11T16:10:58Z","git_url":"git://github.com/andreimatei/cockroach.git","ssh_url":"git@github.com:andreimatei/cockroach.git","clone_url":"https://github.com/andreimatei/cockroach.git","svn_url":"https://github.com/andreimatei/cockroach","homepage":null,"size":524801,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cockroachdb:master","ref":"master","sha":"8bd51731d70edceb213727e700f471b9b62f6621","user":{"login":"cockroachdb","id":6748139,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NDgxMzk=","avatar_url":"https://avatars3.githubusercontent.com/u/6748139?v=4","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"repo":{"id":16563587,"node_id":"MDEwOlJlcG9zaXRvcnkxNjU2MzU4Nw==","name":"cockroach","full_name":"cockroachdb/cockroach","private":false,"owner":{"login":"cockroachdb","id":6748139,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NDgxMzk=","avatar_url":"https://avatars3.githubusercontent.com/u/6748139?v=4","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cockroachdb/cockroach","description":"CockroachDB - the open source, cloud-native SQL database.","fork":false,"url":"https://api.github.com/repos/cockroachdb/cockroach","forks_url":"https://api.github.com/repos/cockroachdb/cockroach/forks","keys_url":"https://api.github.com/repos/cockroachdb/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cockroachdb/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cockroachdb/cockroach/teams","hooks_url":"https://api.github.com/repos/cockroachdb/cockroach/hooks","issue_events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/cockroachdb/cockroach/events","assignees_url":"https://api.github.com/repos/cockroachdb/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/cockroachdb/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/cockroachdb/cockroach/tags","blobs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cockroachdb/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/cockroachdb/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/cockroachdb/cockroach/languages","stargazers_url":"https://api.github.com/repos/cockroachdb/cockroach/stargazers","contributors_url":"https://api.github.com/repos/cockroachdb/cockroach/contributors","subscribers_url":"https://api.github.com/repos/cockroachdb/cockroach/subscribers","subscription_url":"https://api.github.com/repos/cockroachdb/cockroach/subscription","commits_url":"https://api.github.com/repos/cockroachdb/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/cockroachdb/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/cockroachdb/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/cockroachdb/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cockroachdb/cockroach/merges","archive_url":"https://api.github.com/repos/cockroachdb/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cockroachdb/cockroach/downloads","issues_url":"https://api.github.com/repos/cockroachdb/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/cockroachdb/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/cockroachdb/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/cockroachdb/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/cockroachdb/cockroach/deployments","created_at":"2014-02-06T00:18:47Z","updated_at":"2018-10-11T15:25:24Z","pushed_at":"2018-10-11T15:44:49Z","git_url":"git://github.com/cockroachdb/cockroach.git","ssh_url":"git@github.com:cockroachdb/cockroach.git","clone_url":"https://github.com/cockroachdb/cockroach.git","svn_url":"https://github.com/cockroachdb/cockroach","homepage":"https://www.cockroachlabs.com","size":1041944,"stargazers_count":14461,"watchers_count":14461,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1525,"mirror_url":null,"archived":false,"open_issues_count":1878,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1525,"open_issues":1878,"watchers":14461,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/31267"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/31267"},"issue":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/31267"},"comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/31267/comments"},"review_comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/31267/comments"},"review_comment":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/31267/commits"},"statuses":{"href":"https://api.github.com/repos/cockroachdb/cockroach/statuses/5b47ca092de62680920466e3b7eeb261030cdc37"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":71,"deletions":52,"changed_files":3}}
{"actor":{"display_login":"andreimatei"}}