{"action":"created","issue":{"url":"https://api.github.com/repos/ptaoussanis/timbre/issues/235","repository_url":"https://api.github.com/repos/ptaoussanis/timbre","labels_url":"https://api.github.com/repos/ptaoussanis/timbre/issues/235/labels{/name}","comments_url":"https://api.github.com/repos/ptaoussanis/timbre/issues/235/comments","events_url":"https://api.github.com/repos/ptaoussanis/timbre/issues/235/events","html_url":"https://github.com/ptaoussanis/timbre/issues/235","id":239848157,"number":235,"title":"Default appender doesn't use :?err, is this intentional?","user":{"login":"JayAndCatchFire","id":10983817,"avatar_url":"https://avatars0.githubusercontent.com/u/10983817?v=4","gravatar_id":"","url":"https://api.github.com/users/JayAndCatchFire","html_url":"https://github.com/JayAndCatchFire","followers_url":"https://api.github.com/users/JayAndCatchFire/followers","following_url":"https://api.github.com/users/JayAndCatchFire/following{/other_user}","gists_url":"https://api.github.com/users/JayAndCatchFire/gists{/gist_id}","starred_url":"https://api.github.com/users/JayAndCatchFire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JayAndCatchFire/subscriptions","organizations_url":"https://api.github.com/users/JayAndCatchFire/orgs","repos_url":"https://api.github.com/users/JayAndCatchFire/repos","events_url":"https://api.github.com/users/JayAndCatchFire/events{/privacy}","received_events_url":"https://api.github.com/users/JayAndCatchFire/received_events","type":"User","site_admin":false},"labels":[{"id":303006667,"url":"https://api.github.com/repos/ptaoussanis/timbre/labels/question/usage","name":"question/usage","color":"d4c5f9","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-06-30T17:55:52Z","updated_at":"2018-04-16T00:53:16Z","closed_at":"2018-04-16T00:53:16Z","author_association":"NONE","body":"The default appender for Clojure doesn't seem to respect :?err.  Is this intentional?  (Sort of related to https://github.com/ptaoussanis/timbre/pull/216)\r\n\r\nFor example, if I run\r\n```clojure\r\n(require '[taoensso.timbre :as log])\r\n(log/log :debug nil \"Hello!\")\r\n```\r\nwhere the `nil` is in place of an exception that might be `nil`, it prints\r\n```\r\n17-06-30 17:24:32 computer-name DEBUG [example.core:1] - nil Hello!\r\n```\r\nwith that superfluous `nil` there."},"comment":{"url":"https://api.github.com/repos/ptaoussanis/timbre/issues/comments/381452252","html_url":"https://github.com/ptaoussanis/timbre/issues/235#issuecomment-381452252","issue_url":"https://api.github.com/repos/ptaoussanis/timbre/issues/235","id":381452252,"user":{"login":"JayAndCatchFire","id":10983817,"avatar_url":"https://avatars0.githubusercontent.com/u/10983817?v=4","gravatar_id":"","url":"https://api.github.com/users/JayAndCatchFire","html_url":"https://github.com/JayAndCatchFire","followers_url":"https://api.github.com/users/JayAndCatchFire/followers","following_url":"https://api.github.com/users/JayAndCatchFire/following{/other_user}","gists_url":"https://api.github.com/users/JayAndCatchFire/gists{/gist_id}","starred_url":"https://api.github.com/users/JayAndCatchFire/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JayAndCatchFire/subscriptions","organizations_url":"https://api.github.com/users/JayAndCatchFire/orgs","repos_url":"https://api.github.com/users/JayAndCatchFire/repos","events_url":"https://api.github.com/users/JayAndCatchFire/events{/privacy}","received_events_url":"https://api.github.com/users/JayAndCatchFire/received_events","type":"User","site_admin":false},"created_at":"2018-04-16T00:53:16Z","updated_at":"2018-04-16T00:53:16Z","author_association":"NONE","body":"Your comment adds the clarity to the intent of the function signature that I was hoping for.\r\n\r\nIn the [ring-timbre-logger code](https://github.com/nberger/ring-logger-timbre/commit/05574e1d5aed904d81d0227d67f8e06123f2e57f), there was no test to see if `throwable` was `nil` before it was passed into the `log` function.  Because of that, `nil`s were being logged in almost every message.\r\n\r\nAs you can see in the discussion of https://github.com/nberger/ring-logger-timbre/pull/6#issuecomment-313039543, there was some confusion about what the intended behavior of `log` was supposed to be in regard to `nil`  being passed instead of a legitimate throwable.  Was it supposed to add it to the log message or just ignore it?  You've clarified the intent in your response.  Thank you."}}
{"actor":{"display_login":"JayAndCatchFire"}}