{"action":"created","comment":{"url":"https://api.github.com/repos/tridactyl/tridactyl/pulls/comments/230591315","pull_request_review_id":171365191,"id":230591315,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDU5MTMxNQ==","diff_hunk":"@@ -16,6 +16,11 @@ interface Window {\n     eval(str: string): any\n }\n \n+// Firefox Document interface","path":"src/tridactyl.d.ts","position":4,"original_position":4,"commit_id":"75e28e1abb1b9faec555158d54bb3eb6cc7e33c0","original_commit_id":"75e28e1abb1b9faec555158d54bb3eb6cc7e33c0","user":{"login":"antonva","id":1540222,"node_id":"MDQ6VXNlcjE1NDAyMjI=","avatar_url":"https://avatars1.githubusercontent.com/u/1540222?v=4","gravatar_id":"","url":"https://api.github.com/users/antonva","html_url":"https://github.com/antonva","followers_url":"https://api.github.com/users/antonva/followers","following_url":"https://api.github.com/users/antonva/following{/other_user}","gists_url":"https://api.github.com/users/antonva/gists{/gist_id}","starred_url":"https://api.github.com/users/antonva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antonva/subscriptions","organizations_url":"https://api.github.com/users/antonva/orgs","repos_url":"https://api.github.com/users/antonva/repos","events_url":"https://api.github.com/users/antonva/events{/privacy}","received_events_url":"https://api.github.com/users/antonva/received_events","type":"User","site_admin":false},"body":"We should probably strive to flesh this out and maybe upstream it to web-ext-types?","created_at":"2018-11-04T14:39:30Z","updated_at":"2018-11-04T14:39:30Z","html_url":"https://github.com/tridactyl/tridactyl/pull/1132#discussion_r230591315","pull_request_url":"https://api.github.com/repos/tridactyl/tridactyl/pulls/1132","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/tridactyl/tridactyl/pulls/comments/230591315"},"html":{"href":"https://github.com/tridactyl/tridactyl/pull/1132#discussion_r230591315"},"pull_request":{"href":"https://api.github.com/repos/tridactyl/tridactyl/pulls/1132"}}},"pull_request":{"url":"https://api.github.com/repos/tridactyl/tridactyl/pulls/1132","id":227661117,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3NjYxMTE3","html_url":"https://github.com/tridactyl/tridactyl/pull/1132","diff_url":"https://github.com/tridactyl/tridactyl/pull/1132.diff","patch_url":"https://github.com/tridactyl/tridactyl/pull/1132.patch","issue_url":"https://api.github.com/repos/tridactyl/tridactyl/issues/1132","number":1132,"state":"open","locked":false,"title":"Fix me: broken update to dev dependencies","user":{"login":"bovine3dom","id":6505246,"node_id":"MDQ6VXNlcjY1MDUyNDY=","avatar_url":"https://avatars3.githubusercontent.com/u/6505246?v=4","gravatar_id":"","url":"https://api.github.com/users/bovine3dom","html_url":"https://github.com/bovine3dom","followers_url":"https://api.github.com/users/bovine3dom/followers","following_url":"https://api.github.com/users/bovine3dom/following{/other_user}","gists_url":"https://api.github.com/users/bovine3dom/gists{/gist_id}","starred_url":"https://api.github.com/users/bovine3dom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bovine3dom/subscriptions","organizations_url":"https://api.github.com/users/bovine3dom/orgs","repos_url":"https://api.github.com/users/bovine3dom/repos","events_url":"https://api.github.com/users/bovine3dom/events{/privacy}","received_events_url":"https://api.github.com/users/bovine3dom/received_events","type":"User","site_admin":false},"body":"I get the following errors. I think they are all from updating TypeScript. It seems to have decided that `HTMLElement.focus()` needs an argument amongst other things.\r\n\r\n```\r\nℹ ｢atl｣: Using typescript@3.0.3 from typescript\r\nℹ ｢atl｣: Using tsconfig.json from /home/olie/projects/tridactyl/tsconfig.json\r\nℹ ｢atl｣: Checking started in a separate process...\r\nError: /home/olie/projects/tridactyl/src/.excmds_content.generated.ts(1497)\r\n Property 'fullscreenElement' does not exist on type 'Document'.\r\nError: /home/olie/projects/tridactyl/src/.excmds_content.generated.ts(1643)\r\n Expected 1 arguments, but got 0.\r\nError: /home/olie/projects/tridactyl/src/commandline_frame.ts(85)\r\n Expected 1 arguments, but got 0.\r\nError: /home/olie/projects/tridactyl/src/commandline_frame.ts(88)\r\n Expected 1 arguments, but got 0.\r\nError: /home/olie/projects/tridactyl/src/content/commandline_content.ts(84)\r\n Expected 1 arguments, but got 0.\r\nError: /home/olie/projects/tridactyl/src/excmds.ts(1929)\r\n Property 'fullscreenElement' does not exist on type 'Document'.\r\nError: /home/olie/projects/tridactyl/src/excmds.ts(2102)\r\n Expected 1 arguments, but got 0.\r\nError: /home/olie/projects/tridactyl/src/lib/dom.ts(469)\r\n Expected 1 arguments, but got 0.\r\nℹ ｢atl｣: Time: 1099ms\r\nWarning: Unknown language: \"text\"\r\nWarning: Unknown language: \"text\"\r\nRendering [========================================] 100%\r\n```","created_at":"2018-11-01T15:36:26Z","updated_at":"2018-11-04T14:39:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7ed3c1cfc8f97e24fafee82b34833b32a4242248","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tridactyl/tridactyl/pulls/1132/commits","review_comments_url":"https://api.github.com/repos/tridactyl/tridactyl/pulls/1132/comments","review_comment_url":"https://api.github.com/repos/tridactyl/tridactyl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tridactyl/tridactyl/issues/1132/comments","statuses_url":"https://api.github.com/repos/tridactyl/tridactyl/statuses/75e28e1abb1b9faec555158d54bb3eb6cc7e33c0","head":{"label":"tridactyl:update-deps","ref":"update-deps","sha":"75e28e1abb1b9faec555158d54bb3eb6cc7e33c0","user":{"login":"tridactyl","id":42609447,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNjA5NDQ3","avatar_url":"https://avatars3.githubusercontent.com/u/42609447?v=4","gravatar_id":"","url":"https://api.github.com/users/tridactyl","html_url":"https://github.com/tridactyl","followers_url":"https://api.github.com/users/tridactyl/followers","following_url":"https://api.github.com/users/tridactyl/following{/other_user}","gists_url":"https://api.github.com/users/tridactyl/gists{/gist_id}","starred_url":"https://api.github.com/users/tridactyl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tridactyl/subscriptions","organizations_url":"https://api.github.com/users/tridactyl/orgs","repos_url":"https://api.github.com/users/tridactyl/repos","events_url":"https://api.github.com/users/tridactyl/events{/privacy}","received_events_url":"https://api.github.com/users/tridactyl/received_events","type":"Organization","site_admin":false},"repo":{"id":83070966,"node_id":"MDEwOlJlcG9zaXRvcnk4MzA3MDk2Ng==","name":"tridactyl","full_name":"tridactyl/tridactyl","private":false,"owner":{"login":"tridactyl","id":42609447,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNjA5NDQ3","avatar_url":"https://avatars3.githubusercontent.com/u/42609447?v=4","gravatar_id":"","url":"https://api.github.com/users/tridactyl","html_url":"https://github.com/tridactyl","followers_url":"https://api.github.com/users/tridactyl/followers","following_url":"https://api.github.com/users/tridactyl/following{/other_user}","gists_url":"https://api.github.com/users/tridactyl/gists{/gist_id}","starred_url":"https://api.github.com/users/tridactyl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tridactyl/subscriptions","organizations_url":"https://api.github.com/users/tridactyl/orgs","repos_url":"https://api.github.com/users/tridactyl/repos","events_url":"https://api.github.com/users/tridactyl/events{/privacy}","received_events_url":"https://api.github.com/users/tridactyl/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tridactyl/tridactyl","description":"A Vim-like interface for Firefox, inspired by Vimperator/Pentadactyl.","fork":false,"url":"https://api.github.com/repos/tridactyl/tridactyl","forks_url":"https://api.github.com/repos/tridactyl/tridactyl/forks","keys_url":"https://api.github.com/repos/tridactyl/tridactyl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tridactyl/tridactyl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tridactyl/tridactyl/teams","hooks_url":"https://api.github.com/repos/tridactyl/tridactyl/hooks","issue_events_url":"https://api.github.com/repos/tridactyl/tridactyl/issues/events{/number}","events_url":"https://api.github.com/repos/tridactyl/tridactyl/events","assignees_url":"https://api.github.com/repos/tridactyl/tridactyl/assignees{/user}","branches_url":"https://api.github.com/repos/tridactyl/tridactyl/branches{/branch}","tags_url":"https://api.github.com/repos/tridactyl/tridactyl/tags","blobs_url":"https://api.github.com/repos/tridactyl/tridactyl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tridactyl/tridactyl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tridactyl/tridactyl/git/refs{/sha}","trees_url":"https://api.github.com/repos/tridactyl/tridactyl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tridactyl/tridactyl/statuses/{sha}","languages_url":"https://api.github.com/repos/tridactyl/tridactyl/languages","stargazers_url":"https://api.github.com/repos/tridactyl/tridactyl/stargazers","contributors_url":"https://api.github.com/repos/tridactyl/tridactyl/contributors","subscribers_url":"https://api.github.com/repos/tridactyl/tridactyl/subscribers","subscription_url":"https://api.github.com/repos/tridactyl/tridactyl/subscription","commits_url":"https://api.github.com/repos/tridactyl/tridactyl/commits{/sha}","git_commits_url":"https://api.github.com/repos/tridactyl/tridactyl/git/commits{/sha}","comments_url":"https://api.github.com/repos/tridactyl/tridactyl/comments{/number}","issue_comment_url":"https://api.github.com/repos/tridactyl/tridactyl/issues/comments{/number}","contents_url":"https://api.github.com/repos/tridactyl/tridactyl/contents/{+path}","compare_url":"https://api.github.com/repos/tridactyl/tridactyl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tridactyl/tridactyl/merges","archive_url":"https://api.github.com/repos/tridactyl/tridactyl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tridactyl/tridactyl/downloads","issues_url":"https://api.github.com/repos/tridactyl/tridactyl/issues{/number}","pulls_url":"https://api.github.com/repos/tridactyl/tridactyl/pulls{/number}","milestones_url":"https://api.github.com/repos/tridactyl/tridactyl/milestones{/number}","notifications_url":"https://api.github.com/repos/tridactyl/tridactyl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tridactyl/tridactyl/labels{/name}","releases_url":"https://api.github.com/repos/tridactyl/tridactyl/releases{/id}","deployments_url":"https://api.github.com/repos/tridactyl/tridactyl/deployments","created_at":"2017-02-24T18:29:34Z","updated_at":"2018-11-04T12:41:42Z","pushed_at":"2018-11-04T14:37:58Z","git_url":"git://github.com/tridactyl/tridactyl.git","ssh_url":"git@github.com:tridactyl/tridactyl.git","clone_url":"https://github.com/tridactyl/tridactyl.git","svn_url":"https://github.com/tridactyl/tridactyl","homepage":"","size":16112,"stargazers_count":1243,"watchers_count":1243,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":128,"mirror_url":null,"archived":false,"open_issues_count":266,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":128,"open_issues":266,"watchers":1243,"default_branch":"master"}},"base":{"label":"tridactyl:master","ref":"master","sha":"f94fb9aa3dc74b19616313f0cfb97a251380a5a4","user":{"login":"tridactyl","id":42609447,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNjA5NDQ3","avatar_url":"https://avatars3.githubusercontent.com/u/42609447?v=4","gravatar_id":"","url":"https://api.github.com/users/tridactyl","html_url":"https://github.com/tridactyl","followers_url":"https://api.github.com/users/tridactyl/followers","following_url":"https://api.github.com/users/tridactyl/following{/other_user}","gists_url":"https://api.github.com/users/tridactyl/gists{/gist_id}","starred_url":"https://api.github.com/users/tridactyl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tridactyl/subscriptions","organizations_url":"https://api.github.com/users/tridactyl/orgs","repos_url":"https://api.github.com/users/tridactyl/repos","events_url":"https://api.github.com/users/tridactyl/events{/privacy}","received_events_url":"https://api.github.com/users/tridactyl/received_events","type":"Organization","site_admin":false},"repo":{"id":83070966,"node_id":"MDEwOlJlcG9zaXRvcnk4MzA3MDk2Ng==","name":"tridactyl","full_name":"tridactyl/tridactyl","private":false,"owner":{"login":"tridactyl","id":42609447,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNjA5NDQ3","avatar_url":"https://avatars3.githubusercontent.com/u/42609447?v=4","gravatar_id":"","url":"https://api.github.com/users/tridactyl","html_url":"https://github.com/tridactyl","followers_url":"https://api.github.com/users/tridactyl/followers","following_url":"https://api.github.com/users/tridactyl/following{/other_user}","gists_url":"https://api.github.com/users/tridactyl/gists{/gist_id}","starred_url":"https://api.github.com/users/tridactyl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tridactyl/subscriptions","organizations_url":"https://api.github.com/users/tridactyl/orgs","repos_url":"https://api.github.com/users/tridactyl/repos","events_url":"https://api.github.com/users/tridactyl/events{/privacy}","received_events_url":"https://api.github.com/users/tridactyl/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/tridactyl/tridactyl","description":"A Vim-like interface for Firefox, inspired by Vimperator/Pentadactyl.","fork":false,"url":"https://api.github.com/repos/tridactyl/tridactyl","forks_url":"https://api.github.com/repos/tridactyl/tridactyl/forks","keys_url":"https://api.github.com/repos/tridactyl/tridactyl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tridactyl/tridactyl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tridactyl/tridactyl/teams","hooks_url":"https://api.github.com/repos/tridactyl/tridactyl/hooks","issue_events_url":"https://api.github.com/repos/tridactyl/tridactyl/issues/events{/number}","events_url":"https://api.github.com/repos/tridactyl/tridactyl/events","assignees_url":"https://api.github.com/repos/tridactyl/tridactyl/assignees{/user}","branches_url":"https://api.github.com/repos/tridactyl/tridactyl/branches{/branch}","tags_url":"https://api.github.com/repos/tridactyl/tridactyl/tags","blobs_url":"https://api.github.com/repos/tridactyl/tridactyl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tridactyl/tridactyl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tridactyl/tridactyl/git/refs{/sha}","trees_url":"https://api.github.com/repos/tridactyl/tridactyl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tridactyl/tridactyl/statuses/{sha}","languages_url":"https://api.github.com/repos/tridactyl/tridactyl/languages","stargazers_url":"https://api.github.com/repos/tridactyl/tridactyl/stargazers","contributors_url":"https://api.github.com/repos/tridactyl/tridactyl/contributors","subscribers_url":"https://api.github.com/repos/tridactyl/tridactyl/subscribers","subscription_url":"https://api.github.com/repos/tridactyl/tridactyl/subscription","commits_url":"https://api.github.com/repos/tridactyl/tridactyl/commits{/sha}","git_commits_url":"https://api.github.com/repos/tridactyl/tridactyl/git/commits{/sha}","comments_url":"https://api.github.com/repos/tridactyl/tridactyl/comments{/number}","issue_comment_url":"https://api.github.com/repos/tridactyl/tridactyl/issues/comments{/number}","contents_url":"https://api.github.com/repos/tridactyl/tridactyl/contents/{+path}","compare_url":"https://api.github.com/repos/tridactyl/tridactyl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tridactyl/tridactyl/merges","archive_url":"https://api.github.com/repos/tridactyl/tridactyl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tridactyl/tridactyl/downloads","issues_url":"https://api.github.com/repos/tridactyl/tridactyl/issues{/number}","pulls_url":"https://api.github.com/repos/tridactyl/tridactyl/pulls{/number}","milestones_url":"https://api.github.com/repos/tridactyl/tridactyl/milestones{/number}","notifications_url":"https://api.github.com/repos/tridactyl/tridactyl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tridactyl/tridactyl/labels{/name}","releases_url":"https://api.github.com/repos/tridactyl/tridactyl/releases{/id}","deployments_url":"https://api.github.com/repos/tridactyl/tridactyl/deployments","created_at":"2017-02-24T18:29:34Z","updated_at":"2018-11-04T12:41:42Z","pushed_at":"2018-11-04T14:37:58Z","git_url":"git://github.com/tridactyl/tridactyl.git","ssh_url":"git@github.com:tridactyl/tridactyl.git","clone_url":"https://github.com/tridactyl/tridactyl.git","svn_url":"https://github.com/tridactyl/tridactyl","homepage":"","size":16112,"stargazers_count":1243,"watchers_count":1243,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":128,"mirror_url":null,"archived":false,"open_issues_count":266,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":128,"open_issues":266,"watchers":1243,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tridactyl/tridactyl/pulls/1132"},"html":{"href":"https://github.com/tridactyl/tridactyl/pull/1132"},"issue":{"href":"https://api.github.com/repos/tridactyl/tridactyl/issues/1132"},"comments":{"href":"https://api.github.com/repos/tridactyl/tridactyl/issues/1132/comments"},"review_comments":{"href":"https://api.github.com/repos/tridactyl/tridactyl/pulls/1132/comments"},"review_comment":{"href":"https://api.github.com/repos/tridactyl/tridactyl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tridactyl/tridactyl/pulls/1132/commits"},"statuses":{"href":"https://api.github.com/repos/tridactyl/tridactyl/statuses/75e28e1abb1b9faec555158d54bb3eb6cc7e33c0"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"antonva"}}