{"action":"created","comment":{"url":"https://api.github.com/repos/spinnaker/spinnaker/pulls/comments/236792086","pull_request_review_id":178942651,"id":236792086,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjc5MjA4Ng==","diff_hunk":"@@ -1,12 +1,15 @@\n {\n   pipeline():: {\n-    limitConcurrent: true,\n     keepWaitingPipelines: false,\n+    limitConcurrent: true,\n     notifications: [],\n     stages: [],\n     triggers: [],\n     withApplication(application):: self + { application: application },\n     withExpectedArtifacts(expectedArtifacts):: self + if std.type(expectedArtifacts) == 'array' then { expectedArtifacts: expectedArtifacts } else { expectedArtifacts: [expectedArtifacts] },\n+    withId(id):: self + { id: id },","path":"sponnet/pipeline.libsonnet","position":11,"original_position":11,"commit_id":"4d6424ea4b359b4b35d2d272ce5486191bf5a1bb","original_commit_id":"4d6424ea4b359b4b35d2d272ce5486191bf5a1bb","user":{"login":"kskewes","id":10180699,"node_id":"MDQ6VXNlcjEwMTgwNjk5","avatar_url":"https://avatars2.githubusercontent.com/u/10180699?v=4","gravatar_id":"","url":"https://api.github.com/users/kskewes","html_url":"https://github.com/kskewes","followers_url":"https://api.github.com/users/kskewes/followers","following_url":"https://api.github.com/users/kskewes/following{/other_user}","gists_url":"https://api.github.com/users/kskewes/gists{/gist_id}","starred_url":"https://api.github.com/users/kskewes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kskewes/subscriptions","organizations_url":"https://api.github.com/users/kskewes/orgs","repos_url":"https://api.github.com/users/kskewes/repos","events_url":"https://api.github.com/users/kskewes/events{/privacy}","received_events_url":"https://api.github.com/users/kskewes/received_events","type":"User","site_admin":false},"body":"Okay. I can remove setting the pipeline id in the demo and update this PR: https://github.com/spinnaker/spinnaker/pull/3635/files#diff-01c380160d0d012b77fc2bdbbded0996R165\r\n\r\nOr, we can leave it in and I can remove in a later PR once other changes are merged?\r\nI expect that I'll be testing out the new Kubernetes stages when 1.11 and will end up adding those to sponnet. Whatever is not too much hassle for reviewers. \r\nPlease sing out if batching too much/little in any case.","created_at":"2018-11-27T18:33:59Z","updated_at":"2018-11-27T18:34:00Z","html_url":"https://github.com/spinnaker/spinnaker/pull/3635#discussion_r236792086","pull_request_url":"https://api.github.com/repos/spinnaker/spinnaker/pulls/3635","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/spinnaker/spinnaker/pulls/comments/236792086"},"html":{"href":"https://github.com/spinnaker/spinnaker/pull/3635#discussion_r236792086"},"pull_request":{"href":"https://api.github.com/repos/spinnaker/spinnaker/pulls/3635"}},"in_reply_to_id":236298433},"pull_request":{"url":"https://api.github.com/repos/spinnaker/spinnaker/pulls/3635","id":232884645,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyODg0NjQ1","html_url":"https://github.com/spinnaker/spinnaker/pull/3635","diff_url":"https://github.com/spinnaker/spinnaker/pull/3635.diff","patch_url":"https://github.com/spinnaker/spinnaker/pull/3635.patch","issue_url":"https://api.github.com/repos/spinnaker/spinnaker/issues/3635","number":3635,"state":"open","locked":false,"title":"feat(sponnet): Additional stages, execution options, application support, fixes","user":{"login":"kskewes","id":10180699,"node_id":"MDQ6VXNlcjEwMTgwNjk5","avatar_url":"https://avatars2.githubusercontent.com/u/10180699?v=4","gravatar_id":"","url":"https://api.github.com/users/kskewes","html_url":"https://github.com/kskewes","followers_url":"https://api.github.com/users/kskewes/followers","following_url":"https://api.github.com/users/kskewes/following{/other_user}","gists_url":"https://api.github.com/users/kskewes/gists{/gist_id}","starred_url":"https://api.github.com/users/kskewes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kskewes/subscriptions","organizations_url":"https://api.github.com/users/kskewes/orgs","repos_url":"https://api.github.com/users/kskewes/repos","events_url":"https://api.github.com/users/kskewes/events{/privacy}","received_events_url":"https://api.github.com/users/kskewes/received_events","type":"User","site_admin":false},"body":"\r\nFixes:\r\nManual judgment stage fix to match Spinnaker locality naming or typo? (judgment not judgement) and add input value array.\r\nAdd Pipeline ID required for `spin` CLI to save pipeline. This has come up in slack channels.\r\n```\r\n$ jsonnet demo.jsonnet > demo.json && spin pipeline save --file demo.json\r\nRequired pipeline key 'id' missing...\r\n```\r\n\r\nFeatures:\r\nRefactor notifications to support Manual Judgment stage notifications\r\nAdd Check Preconditions stage\r\nAdd additional stage execution options. Time Window is basic.\r\nAdd additional pipeline options\r\nAdd ability to create Applications\r\nUpdate README.\r\n\r\nVerified app and pipeline save with `spin` CLI per updated README.md instructions and both look ok in Deck.\r\n\r\nDemo pipeline has become quite large and could be pared back a bit.\r\nIn practice one refactors shared variables and sections out into separate files for re-use by multiple apps/pipelines so leaving as is.","created_at":"2018-11-22T07:43:04Z","updated_at":"2018-11-27T18:34:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b3e7cdeb57e47af7747cb9be96aa4dd394fcd61f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/spinnaker/spinnaker/pulls/3635/commits","review_comments_url":"https://api.github.com/repos/spinnaker/spinnaker/pulls/3635/comments","review_comment_url":"https://api.github.com/repos/spinnaker/spinnaker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spinnaker/spinnaker/issues/3635/comments","statuses_url":"https://api.github.com/repos/spinnaker/spinnaker/statuses/4d6424ea4b359b4b35d2d272ce5486191bf5a1bb","head":{"label":"kskewes:sponnetv2","ref":"sponnetv2","sha":"4d6424ea4b359b4b35d2d272ce5486191bf5a1bb","user":{"login":"kskewes","id":10180699,"node_id":"MDQ6VXNlcjEwMTgwNjk5","avatar_url":"https://avatars2.githubusercontent.com/u/10180699?v=4","gravatar_id":"","url":"https://api.github.com/users/kskewes","html_url":"https://github.com/kskewes","followers_url":"https://api.github.com/users/kskewes/followers","following_url":"https://api.github.com/users/kskewes/following{/other_user}","gists_url":"https://api.github.com/users/kskewes/gists{/gist_id}","starred_url":"https://api.github.com/users/kskewes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kskewes/subscriptions","organizations_url":"https://api.github.com/users/kskewes/orgs","repos_url":"https://api.github.com/users/kskewes/repos","events_url":"https://api.github.com/users/kskewes/events{/privacy}","received_events_url":"https://api.github.com/users/kskewes/received_events","type":"User","site_admin":false},"repo":{"id":153034737,"node_id":"MDEwOlJlcG9zaXRvcnkxNTMwMzQ3Mzc=","name":"spinnaker","full_name":"kskewes/spinnaker","private":false,"owner":{"login":"kskewes","id":10180699,"node_id":"MDQ6VXNlcjEwMTgwNjk5","avatar_url":"https://avatars2.githubusercontent.com/u/10180699?v=4","gravatar_id":"","url":"https://api.github.com/users/kskewes","html_url":"https://github.com/kskewes","followers_url":"https://api.github.com/users/kskewes/followers","following_url":"https://api.github.com/users/kskewes/following{/other_user}","gists_url":"https://api.github.com/users/kskewes/gists{/gist_id}","starred_url":"https://api.github.com/users/kskewes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kskewes/subscriptions","organizations_url":"https://api.github.com/users/kskewes/orgs","repos_url":"https://api.github.com/users/kskewes/repos","events_url":"https://api.github.com/users/kskewes/events{/privacy}","received_events_url":"https://api.github.com/users/kskewes/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kskewes/spinnaker","description":"Spinnaker is an open source, multi-cloud continuous delivery platform for releasing software changes with high velocity and confidence.","fork":true,"url":"https://api.github.com/repos/kskewes/spinnaker","forks_url":"https://api.github.com/repos/kskewes/spinnaker/forks","keys_url":"https://api.github.com/repos/kskewes/spinnaker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kskewes/spinnaker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kskewes/spinnaker/teams","hooks_url":"https://api.github.com/repos/kskewes/spinnaker/hooks","issue_events_url":"https://api.github.com/repos/kskewes/spinnaker/issues/events{/number}","events_url":"https://api.github.com/repos/kskewes/spinnaker/events","assignees_url":"https://api.github.com/repos/kskewes/spinnaker/assignees{/user}","branches_url":"https://api.github.com/repos/kskewes/spinnaker/branches{/branch}","tags_url":"https://api.github.com/repos/kskewes/spinnaker/tags","blobs_url":"https://api.github.com/repos/kskewes/spinnaker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kskewes/spinnaker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kskewes/spinnaker/git/refs{/sha}","trees_url":"https://api.github.com/repos/kskewes/spinnaker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kskewes/spinnaker/statuses/{sha}","languages_url":"https://api.github.com/repos/kskewes/spinnaker/languages","stargazers_url":"https://api.github.com/repos/kskewes/spinnaker/stargazers","contributors_url":"https://api.github.com/repos/kskewes/spinnaker/contributors","subscribers_url":"https://api.github.com/repos/kskewes/spinnaker/subscribers","subscription_url":"https://api.github.com/repos/kskewes/spinnaker/subscription","commits_url":"https://api.github.com/repos/kskewes/spinnaker/commits{/sha}","git_commits_url":"https://api.github.com/repos/kskewes/spinnaker/git/commits{/sha}","comments_url":"https://api.github.com/repos/kskewes/spinnaker/comments{/number}","issue_comment_url":"https://api.github.com/repos/kskewes/spinnaker/issues/comments{/number}","contents_url":"https://api.github.com/repos/kskewes/spinnaker/contents/{+path}","compare_url":"https://api.github.com/repos/kskewes/spinnaker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kskewes/spinnaker/merges","archive_url":"https://api.github.com/repos/kskewes/spinnaker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kskewes/spinnaker/downloads","issues_url":"https://api.github.com/repos/kskewes/spinnaker/issues{/number}","pulls_url":"https://api.github.com/repos/kskewes/spinnaker/pulls{/number}","milestones_url":"https://api.github.com/repos/kskewes/spinnaker/milestones{/number}","notifications_url":"https://api.github.com/repos/kskewes/spinnaker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kskewes/spinnaker/labels{/name}","releases_url":"https://api.github.com/repos/kskewes/spinnaker/releases{/id}","deployments_url":"https://api.github.com/repos/kskewes/spinnaker/deployments","created_at":"2018-10-15T01:10:48Z","updated_at":"2018-11-22T05:56:00Z","pushed_at":"2018-11-26T22:52:22Z","git_url":"git://github.com/kskewes/spinnaker.git","ssh_url":"git@github.com:kskewes/spinnaker.git","clone_url":"https://github.com/kskewes/spinnaker.git","svn_url":"https://github.com/kskewes/spinnaker","homepage":"http://www.spinnaker.io/","size":4943,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spinnaker:master","ref":"master","sha":"7218db1c8d31fd9fb692a3a45085f282f5936482","user":{"login":"spinnaker","id":7634182,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MzQxODI=","avatar_url":"https://avatars1.githubusercontent.com/u/7634182?v=4","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"repo":{"id":21436816,"node_id":"MDEwOlJlcG9zaXRvcnkyMTQzNjgxNg==","name":"spinnaker","full_name":"spinnaker/spinnaker","private":false,"owner":{"login":"spinnaker","id":7634182,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MzQxODI=","avatar_url":"https://avatars1.githubusercontent.com/u/7634182?v=4","gravatar_id":"","url":"https://api.github.com/users/spinnaker","html_url":"https://github.com/spinnaker","followers_url":"https://api.github.com/users/spinnaker/followers","following_url":"https://api.github.com/users/spinnaker/following{/other_user}","gists_url":"https://api.github.com/users/spinnaker/gists{/gist_id}","starred_url":"https://api.github.com/users/spinnaker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spinnaker/subscriptions","organizations_url":"https://api.github.com/users/spinnaker/orgs","repos_url":"https://api.github.com/users/spinnaker/repos","events_url":"https://api.github.com/users/spinnaker/events{/privacy}","received_events_url":"https://api.github.com/users/spinnaker/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/spinnaker/spinnaker","description":"Spinnaker is an open source, multi-cloud continuous delivery platform for releasing software changes with high velocity and confidence.","fork":false,"url":"https://api.github.com/repos/spinnaker/spinnaker","forks_url":"https://api.github.com/repos/spinnaker/spinnaker/forks","keys_url":"https://api.github.com/repos/spinnaker/spinnaker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spinnaker/spinnaker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spinnaker/spinnaker/teams","hooks_url":"https://api.github.com/repos/spinnaker/spinnaker/hooks","issue_events_url":"https://api.github.com/repos/spinnaker/spinnaker/issues/events{/number}","events_url":"https://api.github.com/repos/spinnaker/spinnaker/events","assignees_url":"https://api.github.com/repos/spinnaker/spinnaker/assignees{/user}","branches_url":"https://api.github.com/repos/spinnaker/spinnaker/branches{/branch}","tags_url":"https://api.github.com/repos/spinnaker/spinnaker/tags","blobs_url":"https://api.github.com/repos/spinnaker/spinnaker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spinnaker/spinnaker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spinnaker/spinnaker/git/refs{/sha}","trees_url":"https://api.github.com/repos/spinnaker/spinnaker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spinnaker/spinnaker/statuses/{sha}","languages_url":"https://api.github.com/repos/spinnaker/spinnaker/languages","stargazers_url":"https://api.github.com/repos/spinnaker/spinnaker/stargazers","contributors_url":"https://api.github.com/repos/spinnaker/spinnaker/contributors","subscribers_url":"https://api.github.com/repos/spinnaker/spinnaker/subscribers","subscription_url":"https://api.github.com/repos/spinnaker/spinnaker/subscription","commits_url":"https://api.github.com/repos/spinnaker/spinnaker/commits{/sha}","git_commits_url":"https://api.github.com/repos/spinnaker/spinnaker/git/commits{/sha}","comments_url":"https://api.github.com/repos/spinnaker/spinnaker/comments{/number}","issue_comment_url":"https://api.github.com/repos/spinnaker/spinnaker/issues/comments{/number}","contents_url":"https://api.github.com/repos/spinnaker/spinnaker/contents/{+path}","compare_url":"https://api.github.com/repos/spinnaker/spinnaker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spinnaker/spinnaker/merges","archive_url":"https://api.github.com/repos/spinnaker/spinnaker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spinnaker/spinnaker/downloads","issues_url":"https://api.github.com/repos/spinnaker/spinnaker/issues{/number}","pulls_url":"https://api.github.com/repos/spinnaker/spinnaker/pulls{/number}","milestones_url":"https://api.github.com/repos/spinnaker/spinnaker/milestones{/number}","notifications_url":"https://api.github.com/repos/spinnaker/spinnaker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spinnaker/spinnaker/labels{/name}","releases_url":"https://api.github.com/repos/spinnaker/spinnaker/releases{/id}","deployments_url":"https://api.github.com/repos/spinnaker/spinnaker/deployments","created_at":"2014-07-02T19:02:36Z","updated_at":"2018-11-27T16:46:48Z","pushed_at":"2018-11-27T16:46:45Z","git_url":"git://github.com/spinnaker/spinnaker.git","ssh_url":"git@github.com:spinnaker/spinnaker.git","clone_url":"https://github.com/spinnaker/spinnaker.git","svn_url":"https://github.com/spinnaker/spinnaker","homepage":"http://www.spinnaker.io/","size":4936,"stargazers_count":5435,"watchers_count":5435,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":785,"mirror_url":null,"archived":false,"open_issues_count":368,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":785,"open_issues":368,"watchers":5435,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spinnaker/spinnaker/pulls/3635"},"html":{"href":"https://github.com/spinnaker/spinnaker/pull/3635"},"issue":{"href":"https://api.github.com/repos/spinnaker/spinnaker/issues/3635"},"comments":{"href":"https://api.github.com/repos/spinnaker/spinnaker/issues/3635/comments"},"review_comments":{"href":"https://api.github.com/repos/spinnaker/spinnaker/pulls/3635/comments"},"review_comment":{"href":"https://api.github.com/repos/spinnaker/spinnaker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spinnaker/spinnaker/pulls/3635/commits"},"statuses":{"href":"https://api.github.com/repos/spinnaker/spinnaker/statuses/4d6424ea4b359b4b35d2d272ce5486191bf5a1bb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kskewes"}}