{"action":"created","issue":{"url":"https://api.github.com/repos/freqtrade/freqtrade/issues/1044","repository_url":"https://api.github.com/repos/freqtrade/freqtrade","labels_url":"https://api.github.com/repos/freqtrade/freqtrade/issues/1044/labels{/name}","comments_url":"https://api.github.com/repos/freqtrade/freqtrade/issues/1044/comments","events_url":"https://api.github.com/repos/freqtrade/freqtrade/issues/1044/events","html_url":"https://github.com/freqtrade/freqtrade/pull/1044","id":342448055,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyMzQ1ODU3","number":1044,"title":"pair to strategy enhancement","user":{"login":"xmatthias","id":5024695,"node_id":"MDQ6VXNlcjUwMjQ2OTU=","avatar_url":"https://avatars3.githubusercontent.com/u/5024695?v=4","gravatar_id":"","url":"https://api.github.com/users/xmatthias","html_url":"https://github.com/xmatthias","followers_url":"https://api.github.com/users/xmatthias/followers","following_url":"https://api.github.com/users/xmatthias/following{/other_user}","gists_url":"https://api.github.com/users/xmatthias/gists{/gist_id}","starred_url":"https://api.github.com/users/xmatthias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xmatthias/subscriptions","organizations_url":"https://api.github.com/users/xmatthias/orgs","repos_url":"https://api.github.com/users/xmatthias/repos","events_url":"https://api.github.com/users/xmatthias/events{/privacy}","received_events_url":"https://api.github.com/users/xmatthias/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":13,"created_at":"2018-07-18T18:47:55Z","updated_at":"2018-07-27T06:02:08Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/freqtrade/freqtrade/pulls/1044","html_url":"https://github.com/freqtrade/freqtrade/pull/1044","diff_url":"https://github.com/freqtrade/freqtrade/pull/1044.diff","patch_url":"https://github.com/freqtrade/freqtrade/pull/1044.patch"},"body":"## Summary\r\nThis is a continuation from #918, adding some tests \r\n\r\nSolve the issue: #909\r\n\r\n## new logic\r\n\r\nthe new logic always uses `advise_*` functions, which fall back to the `populate_*` functions if they are not overwritten.\r\n\r\n\r\n## original PR text by @berlinguyinca \r\nWorking on the first required changes to make #909 work. Basically replace all the calls to the methods, with advise methods and wrapping the old methods with a warning to use the new methods.\r\n\r\nRight now we are introducing the pair as a parameter. Any suggestions for other arguments, which might be needed?\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/freqtrade/freqtrade/issues/comments/408320322","html_url":"https://github.com/freqtrade/freqtrade/pull/1044#issuecomment-408320322","issue_url":"https://api.github.com/repos/freqtrade/freqtrade/issues/1044","id":408320322,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODMyMDMyMg==","user":{"login":"xmatthias","id":5024695,"node_id":"MDQ6VXNlcjUwMjQ2OTU=","avatar_url":"https://avatars3.githubusercontent.com/u/5024695?v=4","gravatar_id":"","url":"https://api.github.com/users/xmatthias","html_url":"https://github.com/xmatthias","followers_url":"https://api.github.com/users/xmatthias/followers","following_url":"https://api.github.com/users/xmatthias/following{/other_user}","gists_url":"https://api.github.com/users/xmatthias/gists{/gist_id}","starred_url":"https://api.github.com/users/xmatthias/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xmatthias/subscriptions","organizations_url":"https://api.github.com/users/xmatthias/orgs","repos_url":"https://api.github.com/users/xmatthias/repos","events_url":"https://api.github.com/users/xmatthias/events{/privacy}","received_events_url":"https://api.github.com/users/xmatthias/received_events","type":"User","site_admin":false},"created_at":"2018-07-27T06:02:08Z","updated_at":"2018-07-27T06:02:08Z","author_association":"MEMBER","body":"rebased against develop, selfreviewd - i think it's ready (but need other opinions)."}}
{"actor":{"display_login":"xmatthias"}}