{"action":"created","comment":{"url":"https://api.github.com/repos/rustwasm/wasm-pack/pulls/comments/233213742","pull_request_review_id":174576424,"id":233213742,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzIxMzc0Mg==","diff_hunk":"@@ -210,8 +211,25 @@ impl CrateData {\n         }\n         let manifest = fs::read_to_string(&manifest_path)\n             .with_context(|_| format!(\"failed to read: {}\", manifest_path.display()))?;\n-        let manifest: CargoManifest = toml::from_str(&manifest)\n-            .with_context(|_| format!(\"failed to parse manifest: {}\", manifest_path.display()))?;\n+        let manifest = &mut toml::Deserializer::new(&manifest);\n+\n+        let mut unused_keys = BTreeSet::new();\n+\n+        let manifest: CargoManifest = serde_ignored::deserialize(manifest, |path| {\n+            let path_string = path.to_string();\n+\n+            if path_string.contains(\"metadata\") {","path":"src/manifest/mod.rs","position":null,"original_position":21,"commit_id":"203cf6996cdd76048daf05ce755d77420946003a","original_commit_id":"59039e41181a47dccdf1fbb5c5e151f04492a7b8","user":{"login":"alexcrichton","id":64996,"node_id":"MDQ6VXNlcjY0OTk2","avatar_url":"https://avatars1.githubusercontent.com/u/64996?v=4","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"body":"That's true, but I personally would think that we can't land this while it warns about `[package.metadata.some-unrelated-tool]`. \r\n\r\nWe can possibly do a lehvenstein distance thing (typically used for \"did you typo this?\") to figure out if it looks like `wasm-pack` specifically, but other crates/tools using `[package.metadata]` should not be warned about when using `wasm-pack`","created_at":"2018-11-13T20:41:18Z","updated_at":"2018-11-13T20:41:18Z","html_url":"https://github.com/rustwasm/wasm-pack/pull/446#discussion_r233213742","pull_request_url":"https://api.github.com/repos/rustwasm/wasm-pack/pulls/446","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/rustwasm/wasm-pack/pulls/comments/233213742"},"html":{"href":"https://github.com/rustwasm/wasm-pack/pull/446#discussion_r233213742"},"pull_request":{"href":"https://api.github.com/repos/rustwasm/wasm-pack/pulls/446"}},"in_reply_to_id":232823209},"pull_request":{"url":"https://api.github.com/repos/rustwasm/wasm-pack/pulls/446","id":230263580,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMjYzNTgw","html_url":"https://github.com/rustwasm/wasm-pack/pull/446","diff_url":"https://github.com/rustwasm/wasm-pack/pull/446.diff","patch_url":"https://github.com/rustwasm/wasm-pack/pull/446.patch","issue_url":"https://api.github.com/repos/rustwasm/wasm-pack/issues/446","number":446,"state":"open","locked":false,"title":"feat: Catch typos in Cargo.toml and warn about them","user":{"login":"drager","id":1957563,"node_id":"MDQ6VXNlcjE5NTc1NjM=","avatar_url":"https://avatars1.githubusercontent.com/u/1957563?v=4","gravatar_id":"","url":"https://api.github.com/users/drager","html_url":"https://github.com/drager","followers_url":"https://api.github.com/users/drager/followers","following_url":"https://api.github.com/users/drager/following{/other_user}","gists_url":"https://api.github.com/users/drager/gists{/gist_id}","starred_url":"https://api.github.com/users/drager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drager/subscriptions","organizations_url":"https://api.github.com/users/drager/orgs","repos_url":"https://api.github.com/users/drager/repos","events_url":"https://api.github.com/users/drager/events{/privacy}","received_events_url":"https://api.github.com/users/drager/received_events","type":"User","site_admin":false},"body":"This intends to fix #443.","created_at":"2018-11-12T20:47:19Z","updated_at":"2018-11-13T20:41:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"06d32bf43311b4765cc3fd81083a34b6c27bac71","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rustwasm/wasm-pack/pulls/446/commits","review_comments_url":"https://api.github.com/repos/rustwasm/wasm-pack/pulls/446/comments","review_comment_url":"https://api.github.com/repos/rustwasm/wasm-pack/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rustwasm/wasm-pack/issues/446/comments","statuses_url":"https://api.github.com/repos/rustwasm/wasm-pack/statuses/203cf6996cdd76048daf05ce755d77420946003a","head":{"label":"drager:catch-types-in-cargo-toml","ref":"catch-types-in-cargo-toml","sha":"203cf6996cdd76048daf05ce755d77420946003a","user":{"login":"drager","id":1957563,"node_id":"MDQ6VXNlcjE5NTc1NjM=","avatar_url":"https://avatars1.githubusercontent.com/u/1957563?v=4","gravatar_id":"","url":"https://api.github.com/users/drager","html_url":"https://github.com/drager","followers_url":"https://api.github.com/users/drager/followers","following_url":"https://api.github.com/users/drager/following{/other_user}","gists_url":"https://api.github.com/users/drager/gists{/gist_id}","starred_url":"https://api.github.com/users/drager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drager/subscriptions","organizations_url":"https://api.github.com/users/drager/orgs","repos_url":"https://api.github.com/users/drager/repos","events_url":"https://api.github.com/users/drager/events{/privacy}","received_events_url":"https://api.github.com/users/drager/received_events","type":"User","site_admin":false},"repo":{"id":151945218,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE5NDUyMTg=","name":"wasm-pack","full_name":"drager/wasm-pack","private":false,"owner":{"login":"drager","id":1957563,"node_id":"MDQ6VXNlcjE5NTc1NjM=","avatar_url":"https://avatars1.githubusercontent.com/u/1957563?v=4","gravatar_id":"","url":"https://api.github.com/users/drager","html_url":"https://github.com/drager","followers_url":"https://api.github.com/users/drager/followers","following_url":"https://api.github.com/users/drager/following{/other_user}","gists_url":"https://api.github.com/users/drager/gists{/gist_id}","starred_url":"https://api.github.com/users/drager/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/drager/subscriptions","organizations_url":"https://api.github.com/users/drager/orgs","repos_url":"https://api.github.com/users/drager/repos","events_url":"https://api.github.com/users/drager/events{/privacy}","received_events_url":"https://api.github.com/users/drager/received_events","type":"User","site_admin":false},"html_url":"https://github.com/drager/wasm-pack","description":"📦✨ your favorite rust -> wasm workflow tool!","fork":true,"url":"https://api.github.com/repos/drager/wasm-pack","forks_url":"https://api.github.com/repos/drager/wasm-pack/forks","keys_url":"https://api.github.com/repos/drager/wasm-pack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/drager/wasm-pack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/drager/wasm-pack/teams","hooks_url":"https://api.github.com/repos/drager/wasm-pack/hooks","issue_events_url":"https://api.github.com/repos/drager/wasm-pack/issues/events{/number}","events_url":"https://api.github.com/repos/drager/wasm-pack/events","assignees_url":"https://api.github.com/repos/drager/wasm-pack/assignees{/user}","branches_url":"https://api.github.com/repos/drager/wasm-pack/branches{/branch}","tags_url":"https://api.github.com/repos/drager/wasm-pack/tags","blobs_url":"https://api.github.com/repos/drager/wasm-pack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/drager/wasm-pack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/drager/wasm-pack/git/refs{/sha}","trees_url":"https://api.github.com/repos/drager/wasm-pack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/drager/wasm-pack/statuses/{sha}","languages_url":"https://api.github.com/repos/drager/wasm-pack/languages","stargazers_url":"https://api.github.com/repos/drager/wasm-pack/stargazers","contributors_url":"https://api.github.com/repos/drager/wasm-pack/contributors","subscribers_url":"https://api.github.com/repos/drager/wasm-pack/subscribers","subscription_url":"https://api.github.com/repos/drager/wasm-pack/subscription","commits_url":"https://api.github.com/repos/drager/wasm-pack/commits{/sha}","git_commits_url":"https://api.github.com/repos/drager/wasm-pack/git/commits{/sha}","comments_url":"https://api.github.com/repos/drager/wasm-pack/comments{/number}","issue_comment_url":"https://api.github.com/repos/drager/wasm-pack/issues/comments{/number}","contents_url":"https://api.github.com/repos/drager/wasm-pack/contents/{+path}","compare_url":"https://api.github.com/repos/drager/wasm-pack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/drager/wasm-pack/merges","archive_url":"https://api.github.com/repos/drager/wasm-pack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/drager/wasm-pack/downloads","issues_url":"https://api.github.com/repos/drager/wasm-pack/issues{/number}","pulls_url":"https://api.github.com/repos/drager/wasm-pack/pulls{/number}","milestones_url":"https://api.github.com/repos/drager/wasm-pack/milestones{/number}","notifications_url":"https://api.github.com/repos/drager/wasm-pack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/drager/wasm-pack/labels{/name}","releases_url":"https://api.github.com/repos/drager/wasm-pack/releases{/id}","deployments_url":"https://api.github.com/repos/drager/wasm-pack/deployments","created_at":"2018-10-07T13:38:49Z","updated_at":"2018-11-12T19:40:16Z","pushed_at":"2018-11-13T19:54:13Z","git_url":"git://github.com/drager/wasm-pack.git","ssh_url":"git@github.com:drager/wasm-pack.git","clone_url":"https://github.com/drager/wasm-pack.git","svn_url":"https://github.com/drager/wasm-pack","homepage":"https://rustwasm.github.io/wasm-pack/","size":2187,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rustwasm:master","ref":"master","sha":"51e6351c28fbd40745719e6d4a7bf26dadd30c85","user":{"login":"rustwasm","id":37272798,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MjcyNzk4","avatar_url":"https://avatars1.githubusercontent.com/u/37272798?v=4","gravatar_id":"","url":"https://api.github.com/users/rustwasm","html_url":"https://github.com/rustwasm","followers_url":"https://api.github.com/users/rustwasm/followers","following_url":"https://api.github.com/users/rustwasm/following{/other_user}","gists_url":"https://api.github.com/users/rustwasm/gists{/gist_id}","starred_url":"https://api.github.com/users/rustwasm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rustwasm/subscriptions","organizations_url":"https://api.github.com/users/rustwasm/orgs","repos_url":"https://api.github.com/users/rustwasm/repos","events_url":"https://api.github.com/users/rustwasm/events{/privacy}","received_events_url":"https://api.github.com/users/rustwasm/received_events","type":"Organization","site_admin":false},"repo":{"id":121253762,"node_id":"MDEwOlJlcG9zaXRvcnkxMjEyNTM3NjI=","name":"wasm-pack","full_name":"rustwasm/wasm-pack","private":false,"owner":{"login":"rustwasm","id":37272798,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MjcyNzk4","avatar_url":"https://avatars1.githubusercontent.com/u/37272798?v=4","gravatar_id":"","url":"https://api.github.com/users/rustwasm","html_url":"https://github.com/rustwasm","followers_url":"https://api.github.com/users/rustwasm/followers","following_url":"https://api.github.com/users/rustwasm/following{/other_user}","gists_url":"https://api.github.com/users/rustwasm/gists{/gist_id}","starred_url":"https://api.github.com/users/rustwasm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rustwasm/subscriptions","organizations_url":"https://api.github.com/users/rustwasm/orgs","repos_url":"https://api.github.com/users/rustwasm/repos","events_url":"https://api.github.com/users/rustwasm/events{/privacy}","received_events_url":"https://api.github.com/users/rustwasm/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rustwasm/wasm-pack","description":"📦✨ your favorite rust -> wasm workflow tool!","fork":false,"url":"https://api.github.com/repos/rustwasm/wasm-pack","forks_url":"https://api.github.com/repos/rustwasm/wasm-pack/forks","keys_url":"https://api.github.com/repos/rustwasm/wasm-pack/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rustwasm/wasm-pack/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rustwasm/wasm-pack/teams","hooks_url":"https://api.github.com/repos/rustwasm/wasm-pack/hooks","issue_events_url":"https://api.github.com/repos/rustwasm/wasm-pack/issues/events{/number}","events_url":"https://api.github.com/repos/rustwasm/wasm-pack/events","assignees_url":"https://api.github.com/repos/rustwasm/wasm-pack/assignees{/user}","branches_url":"https://api.github.com/repos/rustwasm/wasm-pack/branches{/branch}","tags_url":"https://api.github.com/repos/rustwasm/wasm-pack/tags","blobs_url":"https://api.github.com/repos/rustwasm/wasm-pack/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rustwasm/wasm-pack/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rustwasm/wasm-pack/git/refs{/sha}","trees_url":"https://api.github.com/repos/rustwasm/wasm-pack/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rustwasm/wasm-pack/statuses/{sha}","languages_url":"https://api.github.com/repos/rustwasm/wasm-pack/languages","stargazers_url":"https://api.github.com/repos/rustwasm/wasm-pack/stargazers","contributors_url":"https://api.github.com/repos/rustwasm/wasm-pack/contributors","subscribers_url":"https://api.github.com/repos/rustwasm/wasm-pack/subscribers","subscription_url":"https://api.github.com/repos/rustwasm/wasm-pack/subscription","commits_url":"https://api.github.com/repos/rustwasm/wasm-pack/commits{/sha}","git_commits_url":"https://api.github.com/repos/rustwasm/wasm-pack/git/commits{/sha}","comments_url":"https://api.github.com/repos/rustwasm/wasm-pack/comments{/number}","issue_comment_url":"https://api.github.com/repos/rustwasm/wasm-pack/issues/comments{/number}","contents_url":"https://api.github.com/repos/rustwasm/wasm-pack/contents/{+path}","compare_url":"https://api.github.com/repos/rustwasm/wasm-pack/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rustwasm/wasm-pack/merges","archive_url":"https://api.github.com/repos/rustwasm/wasm-pack/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rustwasm/wasm-pack/downloads","issues_url":"https://api.github.com/repos/rustwasm/wasm-pack/issues{/number}","pulls_url":"https://api.github.com/repos/rustwasm/wasm-pack/pulls{/number}","milestones_url":"https://api.github.com/repos/rustwasm/wasm-pack/milestones{/number}","notifications_url":"https://api.github.com/repos/rustwasm/wasm-pack/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rustwasm/wasm-pack/labels{/name}","releases_url":"https://api.github.com/repos/rustwasm/wasm-pack/releases{/id}","deployments_url":"https://api.github.com/repos/rustwasm/wasm-pack/deployments","created_at":"2018-02-12T14:04:34Z","updated_at":"2018-11-12T19:00:13Z","pushed_at":"2018-11-13T19:54:14Z","git_url":"git://github.com/rustwasm/wasm-pack.git","ssh_url":"git@github.com:rustwasm/wasm-pack.git","clone_url":"https://github.com/rustwasm/wasm-pack.git","svn_url":"https://github.com/rustwasm/wasm-pack","homepage":"https://rustwasm.github.io/wasm-pack/","size":2122,"stargazers_count":1276,"watchers_count":1276,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":78,"mirror_url":null,"archived":false,"open_issues_count":58,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":78,"open_issues":58,"watchers":1276,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rustwasm/wasm-pack/pulls/446"},"html":{"href":"https://github.com/rustwasm/wasm-pack/pull/446"},"issue":{"href":"https://api.github.com/repos/rustwasm/wasm-pack/issues/446"},"comments":{"href":"https://api.github.com/repos/rustwasm/wasm-pack/issues/446/comments"},"review_comments":{"href":"https://api.github.com/repos/rustwasm/wasm-pack/pulls/446/comments"},"review_comment":{"href":"https://api.github.com/repos/rustwasm/wasm-pack/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rustwasm/wasm-pack/pulls/446/commits"},"statuses":{"href":"https://api.github.com/repos/rustwasm/wasm-pack/statuses/203cf6996cdd76048daf05ce755d77420946003a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"alexcrichton"}}