{"action":"created","issue":{"url":"https://api.github.com/repos/unitsofmeasurement/indriya/issues/17","repository_url":"https://api.github.com/repos/unitsofmeasurement/indriya","labels_url":"https://api.github.com/repos/unitsofmeasurement/indriya/issues/17/labels{/name}","comments_url":"https://api.github.com/repos/unitsofmeasurement/indriya/issues/17/comments","events_url":"https://api.github.com/repos/unitsofmeasurement/indriya/issues/17/events","html_url":"https://github.com/unitsofmeasurement/indriya/issues/17","id":284798017,"number":17,"title":"CompoundUnit or CompoundQuantity?","user":{"login":"keilw","id":70496,"avatar_url":"https://avatars0.githubusercontent.com/u/70496?v=4","gravatar_id":"","url":"https://api.github.com/users/keilw","html_url":"https://github.com/keilw","followers_url":"https://api.github.com/users/keilw/followers","following_url":"https://api.github.com/users/keilw/following{/other_user}","gists_url":"https://api.github.com/users/keilw/gists{/gist_id}","starred_url":"https://api.github.com/users/keilw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keilw/subscriptions","organizations_url":"https://api.github.com/users/keilw/orgs","repos_url":"https://api.github.com/users/keilw/repos","events_url":"https://api.github.com/users/keilw/events{/privacy}","received_events_url":"https://api.github.com/users/keilw/received_events","type":"User","site_admin":false},"labels":[{"id":650703082,"url":"https://api.github.com/repos/unitsofmeasurement/indriya/labels/help%20wanted","name":"help wanted","color":"128A0C","default":true},{"id":650703084,"url":"https://api.github.com/repos/unitsofmeasurement/indriya/labels/question","name":"question","color":"cc317c","default":true},{"id":765700366,"url":"https://api.github.com/repos/unitsofmeasurement/indriya/labels/to%20do","name":"to do","color":"ededed","default":false},{"id":798621827,"url":"https://api.github.com/repos/unitsofmeasurement/indriya/labels/vote","name":"vote","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/unitsofmeasurement/indriya/milestones/1","html_url":"https://github.com/unitsofmeasurement/indriya/milestone/1","labels_url":"https://api.github.com/repos/unitsofmeasurement/indriya/milestones/1/labels","id":2652190,"number":1,"title":"2.0","description":"Next Generation RI; 2.0","creator":{"login":"keilw","id":70496,"avatar_url":"https://avatars0.githubusercontent.com/u/70496?v=4","gravatar_id":"","url":"https://api.github.com/users/keilw","html_url":"https://github.com/keilw","followers_url":"https://api.github.com/users/keilw/followers","following_url":"https://api.github.com/users/keilw/following{/other_user}","gists_url":"https://api.github.com/users/keilw/gists{/gist_id}","starred_url":"https://api.github.com/users/keilw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keilw/subscriptions","organizations_url":"https://api.github.com/users/keilw/orgs","repos_url":"https://api.github.com/users/keilw/repos","events_url":"https://api.github.com/users/keilw/events{/privacy}","received_events_url":"https://api.github.com/users/keilw/received_events","type":"User","site_admin":false},"open_issues":9,"closed_issues":7,"state":"open","created_at":"2017-07-20T10:26:00Z","updated_at":"2018-03-04T16:13:37Z","due_on":"2019-02-19T08:00:00Z","closed_at":null},"comments":23,"created_at":"2017-12-27T21:20:44Z","updated_at":"2018-03-04T17:03:59Z","closed_at":null,"author_association":"OWNER","body":"Hi,\r\n\r\nI did a bit of brush-up to Indriya over the holidays. And through JUnit tests for `CompoundUnit` a problem occurred to me we should rethink the need for a `CompoundUnit` as opposed to something like a `CompoundQuantity`. \r\n\r\nIt is currently possible to create a compound chained across even multiple steps like `HOUR.compound(MINUTE).compound(SECOND)`. However, trying to combine this type of `Unit` into the current `Quantity`, how to handle `\"1 hour: 5 minutes: 30 seconds\"`, if only the unit part is multidimensional? We may need something along the lines of a `CompoundQuantity`.  JSR 310 `TemporalAmount` could be a very vague inspiration, but we should ask ourselves questions like do we need a `List` or `Set` of units, because `TemporalAmount` states\r\n> The list of units completely and uniquely represents the state of the object without omissions, overlaps or `duplication` \r\n\r\nWhich would speak for a Set avoiding duplication.\r\n\r\nEither way, it seems we have to think about that and come up with an idea how to best combine a \"list\" of Unit elements and numeric values attached. JSR 310 `TemporalAmount` implementations are overly simplified, they do not allow more than 2 or 3 distinct units each. E.g. \"Year, month, day\" in case of the `Period`. We need a more flexible approach for general purpose unit support. "},"comment":{"url":"https://api.github.com/repos/unitsofmeasurement/indriya/issues/comments/370245142","html_url":"https://github.com/unitsofmeasurement/indriya/issues/17#issuecomment-370245142","issue_url":"https://api.github.com/repos/unitsofmeasurement/indriya/issues/17","id":370245142,"user":{"login":"keilw","id":70496,"avatar_url":"https://avatars0.githubusercontent.com/u/70496?v=4","gravatar_id":"","url":"https://api.github.com/users/keilw","html_url":"https://github.com/keilw","followers_url":"https://api.github.com/users/keilw/followers","following_url":"https://api.github.com/users/keilw/following{/other_user}","gists_url":"https://api.github.com/users/keilw/gists{/gist_id}","starred_url":"https://api.github.com/users/keilw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keilw/subscriptions","organizations_url":"https://api.github.com/users/keilw/orgs","repos_url":"https://api.github.com/users/keilw/repos","events_url":"https://api.github.com/users/keilw/events{/privacy}","received_events_url":"https://api.github.com/users/keilw/received_events","type":"User","site_admin":false},"created_at":"2018-03-04T17:03:59Z","updated_at":"2018-03-04T17:03:59Z","author_association":"OWNER","body":"The problem is, that of `Quantity` at least `getUnit `and `getValue `don't make sense, but instead **plurals** like `getUnits `or (not there, but it might also exist) `getValue `are needed."}}
{"actor":{"display_login":"keilw"}}