{"action":"created","comment":{"url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/pulls/comments/228456927","pull_request_review_id":168734586,"id":228456927,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODQ1NjkyNw==","diff_hunk":"@@ -48,7 +48,7 @@ export class FormComponent implements OnInit, OnChanges, OnDestroy {\n     static START_PROCESS_OUTCOME_ID: string = '$startProcess';\n     static CUSTOM_OUTCOME_ID: string = '$custom';\n     static COMPLETE_BUTTON_COLOR: string = 'primary';\n-    static COMPLETE_OUTCOME_NAME: string = 'Complete'\n+    static COMPLETE_OUTCOME_NAME: string = 'START';","path":"lib/core/form/components/form.component.ts","position":5,"original_position":5,"commit_id":"3928d90d82d74b6335a3bd25744ba74aa50949b1","original_commit_id":"3928d90d82d74b6335a3bd25744ba74aa50949b1","user":{"login":"davidcanonieto","id":18293044,"node_id":"MDQ6VXNlcjE4MjkzMDQ0","avatar_url":"https://avatars1.githubusercontent.com/u/18293044?v=4","gravatar_id":"","url":"https://api.github.com/users/davidcanonieto","html_url":"https://github.com/davidcanonieto","followers_url":"https://api.github.com/users/davidcanonieto/followers","following_url":"https://api.github.com/users/davidcanonieto/following{/other_user}","gists_url":"https://api.github.com/users/davidcanonieto/gists{/gist_id}","starred_url":"https://api.github.com/users/davidcanonieto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidcanonieto/subscriptions","organizations_url":"https://api.github.com/users/davidcanonieto/orgs","repos_url":"https://api.github.com/users/davidcanonieto/repos","events_url":"https://api.github.com/users/davidcanonieto/events{/privacy}","received_events_url":"https://api.github.com/users/davidcanonieto/received_events","type":"User","site_admin":false},"body":"Because that is the key to the translation value. \r\n{\r\n  \"SAVE\": \"SAVE\",\r\n  \"**START**\": \"COMPLETE\",\r\n  \"START PROCESS\": \"START PROCESS\",\r\n  \"FORM\": { ...","created_at":"2018-10-26T09:11:52Z","updated_at":"2018-10-26T09:11:52Z","html_url":"https://github.com/Alfresco/alfresco-ng2-components/pull/3920#discussion_r228456927","pull_request_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/pulls/3920","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/pulls/comments/228456927"},"html":{"href":"https://github.com/Alfresco/alfresco-ng2-components/pull/3920#discussion_r228456927"},"pull_request":{"href":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/pulls/3920"}},"in_reply_to_id":228354704},"pull_request":{"url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/pulls/3920","id":225731978,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1NzMxOTc4","html_url":"https://github.com/Alfresco/alfresco-ng2-components/pull/3920","diff_url":"https://github.com/Alfresco/alfresco-ng2-components/pull/3920.diff","patch_url":"https://github.com/Alfresco/alfresco-ng2-components/pull/3920.patch","issue_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/issues/3920","number":3920,"state":"open","locked":false,"title":"[ADF-3561] Fix form action buttons translation","user":{"login":"davidcanonieto","id":18293044,"node_id":"MDQ6VXNlcjE4MjkzMDQ0","avatar_url":"https://avatars1.githubusercontent.com/u/18293044?v=4","gravatar_id":"","url":"https://api.github.com/users/davidcanonieto","html_url":"https://github.com/davidcanonieto","followers_url":"https://api.github.com/users/davidcanonieto/followers","following_url":"https://api.github.com/users/davidcanonieto/following{/other_user}","gists_url":"https://api.github.com/users/davidcanonieto/gists{/gist_id}","starred_url":"https://api.github.com/users/davidcanonieto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidcanonieto/subscriptions","organizations_url":"https://api.github.com/users/davidcanonieto/orgs","repos_url":"https://api.github.com/users/davidcanonieto/repos","events_url":"https://api.github.com/users/davidcanonieto/events{/privacy}","received_events_url":"https://api.github.com/users/davidcanonieto/received_events","type":"User","site_admin":false},"body":"**Please check if the PR fulfills these requirements**\r\n\r\n> - [ ] The commit message follows our [guidelines](https://github.com/Alfresco/alfresco-ng2-components/wiki/Commit-format)\r\n> - [ ] Tests for the changes have been added (for bug fixes / features)\r\n> - [ ] Docs have been added / updated (for bug fixes / features)\r\n\r\n<!--\r\n Before submitting your PR, please check that your code follows our contribution guidelines:\r\n https://github.com/Alfresco/alfresco-ng2-components/wiki/Code-contribution-acceptance-criteria\r\n -->\r\n\r\n**What kind of change does this PR introduce?** (check one with \"x\")\r\n\r\n> - [x] Bugfix\r\n> - [ ] Feature\r\n> - [ ] Code style update (formatting, local variables)\r\n> - [ ] Refactoring (no functional changes, no api changes)\r\n> - [ ] Build related changes\r\n> - [ ] Documentation\r\n> - [ ] Other... Please describe:\r\n\r\n\r\n**What is the current behaviour?** (You can also link to an open issue here)\r\nhttps://issues.alfresco.com/jira/browse/ADF-3561\r\nAction buttons on forms are hardcoded se they cannot be translated.\r\nVisibility and disability of these buttons are also hardcoded.\r\n\r\n**What is the new behaviour?**\r\nAction buttons get their labels from the translation file.\r\nVisibility and disability of these buttons now work regardless of language.\r\n\r\n**Does this PR introduce a breaking change?** (check one with \"x\")\r\n\r\n> - [ ] Yes\r\n> - [x] No\r\n\r\n\r\nIf this PR contains a breaking change, please describe the impact and migration path for existing applications: ...\r\n\r\n**Other information**:\r\n","created_at":"2018-10-25T12:03:14Z","updated_at":"2018-10-26T09:11:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ce39019f4c9e931a7eb8996a32c1e3bd16be930a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":754213670,"node_id":"MDU6TGFiZWw3NTQyMTM2NzA=","url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/labels/change%20requested","name":"change requested","color":"dd7cd5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/pulls/3920/commits","review_comments_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/pulls/3920/comments","review_comment_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/issues/3920/comments","statuses_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/statuses/3928d90d82d74b6335a3bd25744ba74aa50949b1","head":{"label":"Alfresco:dev-dcano-ADF-3561","ref":"dev-dcano-ADF-3561","sha":"3928d90d82d74b6335a3bd25744ba74aa50949b1","user":{"login":"Alfresco","id":391127,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MTEyNw==","avatar_url":"https://avatars2.githubusercontent.com/u/391127?v=4","gravatar_id":"","url":"https://api.github.com/users/Alfresco","html_url":"https://github.com/Alfresco","followers_url":"https://api.github.com/users/Alfresco/followers","following_url":"https://api.github.com/users/Alfresco/following{/other_user}","gists_url":"https://api.github.com/users/Alfresco/gists{/gist_id}","starred_url":"https://api.github.com/users/Alfresco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alfresco/subscriptions","organizations_url":"https://api.github.com/users/Alfresco/orgs","repos_url":"https://api.github.com/users/Alfresco/repos","events_url":"https://api.github.com/users/Alfresco/events{/privacy}","received_events_url":"https://api.github.com/users/Alfresco/received_events","type":"Organization","site_admin":false},"repo":{"id":55400726,"node_id":"MDEwOlJlcG9zaXRvcnk1NTQwMDcyNg==","name":"alfresco-ng2-components","full_name":"Alfresco/alfresco-ng2-components","private":false,"owner":{"login":"Alfresco","id":391127,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MTEyNw==","avatar_url":"https://avatars2.githubusercontent.com/u/391127?v=4","gravatar_id":"","url":"https://api.github.com/users/Alfresco","html_url":"https://github.com/Alfresco","followers_url":"https://api.github.com/users/Alfresco/followers","following_url":"https://api.github.com/users/Alfresco/following{/other_user}","gists_url":"https://api.github.com/users/Alfresco/gists{/gist_id}","starred_url":"https://api.github.com/users/Alfresco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alfresco/subscriptions","organizations_url":"https://api.github.com/users/Alfresco/orgs","repos_url":"https://api.github.com/users/Alfresco/repos","events_url":"https://api.github.com/users/Alfresco/events{/privacy}","received_events_url":"https://api.github.com/users/Alfresco/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Alfresco/alfresco-ng2-components","description":"Alfresco Angular Components","fork":false,"url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components","forks_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/forks","keys_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/teams","hooks_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/hooks","issue_events_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/issues/events{/number}","events_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/events","assignees_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/assignees{/user}","branches_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/branches{/branch}","tags_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/tags","blobs_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/statuses/{sha}","languages_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/languages","stargazers_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/stargazers","contributors_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/contributors","subscribers_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/subscribers","subscription_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/subscription","commits_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/contents/{+path}","compare_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/merges","archive_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/downloads","issues_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/issues{/number}","pulls_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/pulls{/number}","milestones_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/milestones{/number}","notifications_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/labels{/name}","releases_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/releases{/id}","deployments_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/deployments","created_at":"2016-04-04T09:54:25Z","updated_at":"2018-10-26T08:55:02Z","pushed_at":"2018-10-26T08:54:58Z","git_url":"git://github.com/Alfresco/alfresco-ng2-components.git","ssh_url":"git@github.com:Alfresco/alfresco-ng2-components.git","clone_url":"https://github.com/Alfresco/alfresco-ng2-components.git","svn_url":"https://github.com/Alfresco/alfresco-ng2-components","homepage":"https://alfresco.github.io/adf-component-catalog/","size":397021,"stargazers_count":181,"watchers_count":181,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":94,"mirror_url":null,"archived":false,"open_issues_count":64,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":94,"open_issues":64,"watchers":181,"default_branch":"development"}},"base":{"label":"Alfresco:development","ref":"development","sha":"021fc4218c5db1100d35ee5a4dd9d96041d0460e","user":{"login":"Alfresco","id":391127,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MTEyNw==","avatar_url":"https://avatars2.githubusercontent.com/u/391127?v=4","gravatar_id":"","url":"https://api.github.com/users/Alfresco","html_url":"https://github.com/Alfresco","followers_url":"https://api.github.com/users/Alfresco/followers","following_url":"https://api.github.com/users/Alfresco/following{/other_user}","gists_url":"https://api.github.com/users/Alfresco/gists{/gist_id}","starred_url":"https://api.github.com/users/Alfresco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alfresco/subscriptions","organizations_url":"https://api.github.com/users/Alfresco/orgs","repos_url":"https://api.github.com/users/Alfresco/repos","events_url":"https://api.github.com/users/Alfresco/events{/privacy}","received_events_url":"https://api.github.com/users/Alfresco/received_events","type":"Organization","site_admin":false},"repo":{"id":55400726,"node_id":"MDEwOlJlcG9zaXRvcnk1NTQwMDcyNg==","name":"alfresco-ng2-components","full_name":"Alfresco/alfresco-ng2-components","private":false,"owner":{"login":"Alfresco","id":391127,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MTEyNw==","avatar_url":"https://avatars2.githubusercontent.com/u/391127?v=4","gravatar_id":"","url":"https://api.github.com/users/Alfresco","html_url":"https://github.com/Alfresco","followers_url":"https://api.github.com/users/Alfresco/followers","following_url":"https://api.github.com/users/Alfresco/following{/other_user}","gists_url":"https://api.github.com/users/Alfresco/gists{/gist_id}","starred_url":"https://api.github.com/users/Alfresco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alfresco/subscriptions","organizations_url":"https://api.github.com/users/Alfresco/orgs","repos_url":"https://api.github.com/users/Alfresco/repos","events_url":"https://api.github.com/users/Alfresco/events{/privacy}","received_events_url":"https://api.github.com/users/Alfresco/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Alfresco/alfresco-ng2-components","description":"Alfresco Angular Components","fork":false,"url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components","forks_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/forks","keys_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/teams","hooks_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/hooks","issue_events_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/issues/events{/number}","events_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/events","assignees_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/assignees{/user}","branches_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/branches{/branch}","tags_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/tags","blobs_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/git/refs{/sha}","trees_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/statuses/{sha}","languages_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/languages","stargazers_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/stargazers","contributors_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/contributors","subscribers_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/subscribers","subscription_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/subscription","commits_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/commits{/sha}","git_commits_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/git/commits{/sha}","comments_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/comments{/number}","issue_comment_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/issues/comments{/number}","contents_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/contents/{+path}","compare_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/merges","archive_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/downloads","issues_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/issues{/number}","pulls_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/pulls{/number}","milestones_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/milestones{/number}","notifications_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/labels{/name}","releases_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/releases{/id}","deployments_url":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/deployments","created_at":"2016-04-04T09:54:25Z","updated_at":"2018-10-26T08:55:02Z","pushed_at":"2018-10-26T08:54:58Z","git_url":"git://github.com/Alfresco/alfresco-ng2-components.git","ssh_url":"git@github.com:Alfresco/alfresco-ng2-components.git","clone_url":"https://github.com/Alfresco/alfresco-ng2-components.git","svn_url":"https://github.com/Alfresco/alfresco-ng2-components","homepage":"https://alfresco.github.io/adf-component-catalog/","size":397021,"stargazers_count":181,"watchers_count":181,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":94,"mirror_url":null,"archived":false,"open_issues_count":64,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":94,"open_issues":64,"watchers":181,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/pulls/3920"},"html":{"href":"https://github.com/Alfresco/alfresco-ng2-components/pull/3920"},"issue":{"href":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/issues/3920"},"comments":{"href":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/issues/3920/comments"},"review_comments":{"href":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/pulls/3920/comments"},"review_comment":{"href":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/pulls/3920/commits"},"statuses":{"href":"https://api.github.com/repos/Alfresco/alfresco-ng2-components/statuses/3928d90d82d74b6335a3bd25744ba74aa50949b1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"davidcanonieto"}}