{"action":"created","issue":{"url":"https://api.github.com/repos/blockstack/blockstack-browser/issues/1218","repository_url":"https://api.github.com/repos/blockstack/blockstack-browser","labels_url":"https://api.github.com/repos/blockstack/blockstack-browser/issues/1218/labels{/name}","comments_url":"https://api.github.com/repos/blockstack/blockstack-browser/issues/1218/comments","events_url":"https://api.github.com/repos/blockstack/blockstack-browser/issues/1218/events","html_url":"https://github.com/blockstack/blockstack-browser/pull/1218","id":298484650,"number":1218,"title":"Client-side transaction generation","user":{"login":"yknl","id":29081231,"avatar_url":"https://avatars3.githubusercontent.com/u/29081231?v=4","gravatar_id":"","url":"https://api.github.com/users/yknl","html_url":"https://github.com/yknl","followers_url":"https://api.github.com/users/yknl/followers","following_url":"https://api.github.com/users/yknl/following{/other_user}","gists_url":"https://api.github.com/users/yknl/gists{/gist_id}","starred_url":"https://api.github.com/users/yknl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yknl/subscriptions","organizations_url":"https://api.github.com/users/yknl/orgs","repos_url":"https://api.github.com/users/yknl/repos","events_url":"https://api.github.com/users/yknl/events{/privacy}","received_events_url":"https://api.github.com/users/yknl/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-02-20T06:26:59Z","updated_at":"2018-02-20T14:04:58Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/blockstack/blockstack-browser/pulls/1218","html_url":"https://github.com/blockstack/blockstack-browser/pull/1218","diff_url":"https://github.com/blockstack/blockstack-browser/pull/1218.diff","patch_url":"https://github.com/blockstack/blockstack-browser/pull/1218.patch"},"body":"This pull request enables client-side transaction generation using the newest version of Blockstack.js and the transaction broadcasting service. \r\n\r\nTesting steps:\r\n1. Run `npm link` from blockstack.js repo on the `blockstack-operations` branch\r\n2. Run `npm link blockstack` from the browser repo\r\n3. Run `npm run mac` to build the new CORS proxy executable (which handles both http + https requests)\r\n4. Run the native app from xcode\r\n5. Enable development mode + Enable regtest mode\r\n6. Start the regtest docker container using the following command:\r\n```\r\nIMAGE=$(docker run -dt -p 6270:6270 -p 16269:16269 -p 18332:18332 -e BLOCKSTACK_TEST_CLIENT_RPC_PORT=6270 -e BLOCKSTACK_TEST_CLIENT_BIND=0.0.0.0 -e BLOCKSTACK_TEST_BITCOIND_ALLOWIP=0.0.0.0/0 quay.io/blockstack/integrationtests:develop blockstack-test-scenario --interactive 2 blockstack_integration_tests.scenarios.browser_env)\r\n```\r\nThe docker container includes a transaction broadcasting service instance\r\n\r\n7. Wait for docker container to fully start\r\n8. Click on the Blockstack system tray icon to launch the browser in dev mode, this will now open the browser to `regtest` mode, where registrations transactions will be generated for the LOCAL_REGTEST env.\r\n9. Create a new account\r\n10. Go to `/wallet/send-core` and transfer out the bitcoin\r\n11. Go to IDs -> Add username\r\n12. Verify that the name is registered successfully.\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/blockstack/blockstack-browser/issues/comments/366986994","html_url":"https://github.com/blockstack/blockstack-browser/pull/1218#issuecomment-366986994","issue_url":"https://api.github.com/repos/blockstack/blockstack-browser/issues/1218","id":366986994,"user":{"login":"larrysalibra","id":597182,"avatar_url":"https://avatars0.githubusercontent.com/u/597182?v=4","gravatar_id":"","url":"https://api.github.com/users/larrysalibra","html_url":"https://github.com/larrysalibra","followers_url":"https://api.github.com/users/larrysalibra/followers","following_url":"https://api.github.com/users/larrysalibra/following{/other_user}","gists_url":"https://api.github.com/users/larrysalibra/gists{/gist_id}","starred_url":"https://api.github.com/users/larrysalibra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larrysalibra/subscriptions","organizations_url":"https://api.github.com/users/larrysalibra/orgs","repos_url":"https://api.github.com/users/larrysalibra/repos","events_url":"https://api.github.com/users/larrysalibra/events{/privacy}","received_events_url":"https://api.github.com/users/larrysalibra/received_events","type":"User","site_admin":false},"created_at":"2018-02-20T14:04:58Z","updated_at":"2018-02-20T14:04:58Z","author_association":"MEMBER","body":"@yknl thanks for the detailed testing instructions - always appreciated!\r\n\r\ntaking a look at this now - will try to merge these conflicting files in `develop` in\r\n"}}
{"actor":{"display_login":"larrysalibra"}}