{"action":"created","issue":{"url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/1608","repository_url":"https://api.github.com/repos/aws/amazon-ecs-agent","labels_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/1608/labels{/name}","comments_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/1608/comments","events_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/1608/events","html_url":"https://github.com/aws/amazon-ecs-agent/pull/1608","id":368402287,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxNTg5MTA2","number":1608,"title":" amazon-ecs-cni-plugin: update to rev 2018.08.0@a134a97","user":{"login":"adnxn","id":596369,"node_id":"MDQ6VXNlcjU5NjM2OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/596369?v=4","gravatar_id":"","url":"https://api.github.com/users/adnxn","html_url":"https://github.com/adnxn","followers_url":"https://api.github.com/users/adnxn/followers","following_url":"https://api.github.com/users/adnxn/following{/other_user}","gists_url":"https://api.github.com/users/adnxn/gists{/gist_id}","starred_url":"https://api.github.com/users/adnxn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adnxn/subscriptions","organizations_url":"https://api.github.com/users/adnxn/orgs","repos_url":"https://api.github.com/users/adnxn/repos","events_url":"https://api.github.com/users/adnxn/events{/privacy}","received_events_url":"https://api.github.com/users/adnxn/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-09T21:18:28Z","updated_at":"2018-10-09T21:27:52Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/1608","html_url":"https://github.com/aws/amazon-ecs-agent/pull/1608","diff_url":"https://github.com/aws/amazon-ecs-agent/pull/1608.diff","patch_url":"https://github.com/aws/amazon-ecs-agent/pull/1608.patch"},"body":"<!--\r\nPlease make sure you've read and understood our contributing guidelines;\r\nhttps://github.com/aws/amazon-ecs-agent/blob/master/CONTRIBUTING.md\r\n\r\nPlease provide the following information:\r\n-->\r\n\r\n### Summary\r\n<!-- What does this pull request do? -->\r\n\r\n### Implementation details\r\n<!-- How are the changes implemented? -->\r\n\r\n### Testing\r\n<!-- How was this tested? -->\r\n<!--\r\nNote for external contributors:\r\n`make test` and `make run-integ-tests` can run in a Linux development\r\nenvironment like your laptop.  `go test -timeout=25s ./agent/...` and\r\n`.\\scripts\\run-integ.tests.ps1` can run in a Windows development environment\r\nlike your laptop.  Please ensure unit and integration tests pass (on at least\r\none platform) before opening the pull request.  `make run-functional-tests` and\r\n`.\\scripts\\run-functional-tests.ps1` must be run on an EC2 instance with an\r\ninstance profile allowing it access to AWS resources.  Running\r\n`make run-functional-tests` and `.\\scripts\\run-functional-tests.ps1` may incur\r\ncharges to your AWS account; if you're unable or unwilling to run these tests\r\nin your own account, we can run the tests and provide test results.\r\n-->\r\n- [ ] Builds on Linux (`make release`)\r\n- [ ] Builds on Windows (`go build -out amazon-ecs-agent.exe ./agent`)\r\n- [ ] Unit tests on Linux (`make test`) pass\r\n- [ ] Unit tests on Windows (`go test -timeout=25s ./agent/...`) pass\r\n- [ ] Integration tests on Linux (`make run-integ-tests`) pass\r\n- [ ] Integration tests on Windows (`.\\scripts\\run-integ-tests.ps1`) pass\r\n- [ ] Functional tests on Linux (`make run-functional-tests`) pass\r\n- [ ] Functional tests on Windows (`.\\scripts\\run-functional-tests.ps1`) pass\r\n\r\nNew tests cover the changes: <!-- yes|no -->\r\n\r\n### Description for the changelog\r\n<!--\r\nWrite a short (one line) summary that describes the changes in this\r\npull request for inclusion in the changelog.\r\nYou can see our changelog entry style here:\r\nhttps://github.com/aws/amazon-ecs-agent/commit/c9aefebc2b3007f09468f651f6308136bd7b384f\r\n-->\r\n\r\n### Licensing\r\n\r\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.\r\n"},"comment":{"url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/comments/428358929","html_url":"https://github.com/aws/amazon-ecs-agent/pull/1608#issuecomment-428358929","issue_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/1608","id":428358929,"node_id":"MDEyOklzc3VlQ29tbWVudDQyODM1ODkyOQ==","user":{"login":"sharanyad","id":14119911,"node_id":"MDQ6VXNlcjE0MTE5OTEx","avatar_url":"https://avatars1.githubusercontent.com/u/14119911?v=4","gravatar_id":"","url":"https://api.github.com/users/sharanyad","html_url":"https://github.com/sharanyad","followers_url":"https://api.github.com/users/sharanyad/followers","following_url":"https://api.github.com/users/sharanyad/following{/other_user}","gists_url":"https://api.github.com/users/sharanyad/gists{/gist_id}","starred_url":"https://api.github.com/users/sharanyad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharanyad/subscriptions","organizations_url":"https://api.github.com/users/sharanyad/orgs","repos_url":"https://api.github.com/users/sharanyad/repos","events_url":"https://api.github.com/users/sharanyad/events{/privacy}","received_events_url":"https://api.github.com/users/sharanyad/received_events","type":"User","site_admin":false},"created_at":"2018-10-09T21:27:52Z","updated_at":"2018-10-09T21:27:52Z","author_association":"CONTRIBUTOR","body":"> i don't think so since this is an implementation detail of agent. \r\n\r\nlooks like we have done it in the [past](https://github.com/aws/amazon-ecs-agent/releases/tag/v1.20.3)"}}
{"actor":{"display_login":"sharanyad"}}