{"action":"created","comment":{"url":"https://api.github.com/repos/qmk/qmk_firmware/pulls/comments/224977362","pull_request_review_id":164482487,"id":224977362,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDk3NzM2Mg==","diff_hunk":"@@ -0,0 +1,69 @@\n+/* Copyright 2018 MechMerlin\n+ *\n+ * This program is free software: you can redistribute it and/or modify\n+ * it under the terms of the GNU General Public License as published by\n+ * the Free Software Foundation, either version 2 of the License, or\n+ * (at your option) any later version.\n+ *\n+ * This program is distributed in the hope that it will be useful,\n+ * but WITHOUT ANY WARRANTY; without even the implied warranty of\n+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the\n+ * GNU General Public License for more details.\n+ *\n+ * You should have received a copy of the GNU General Public License\n+ * along with this program.  If not, see <http://www.gnu.org/licenses/>.\n+ */\n+#include QMK_KEYBOARD_H\n+\n+// iproved hhkb layout with more functionality\n+\n+const uint16_t PROGMEM keymaps[][MATRIX_ROWS][MATRIX_COLS] = {\n+  [0] = LAYOUT(\n+      KC_ESC,  KC_1,    KC_2,    KC_3,    KC_4,    KC_5,     KC_6,   KC_7,   KC_8,    KC_9,    KC_0,    KC_MINS, KC_EQL,  KC_BSLS, KC_GRV,\n+      KC_TAB,  KC_Q,    KC_W,    KC_E,    KC_R,    KC_T,     KC_Y,   KC_U,   KC_I,    KC_O,    KC_P,    KC_LBRC, KC_RBRC, KC_BSPC,\n+      KC_LCTL, KC_A,    KC_S,    KC_D,    KC_F,    KC_G,     KC_H,   KC_J,   KC_K,    KC_L,    KC_SCLN, KC_QUOT, KC_ENT,\n+      KC_LSFT, KC_Z,    KC_X,    KC_C,    KC_V,    KC_B,     KC_N,   KC_M,   KC_COMM, KC_DOT,  KC_SLSH, KC_RSFT, MO(1),\n+      KC_LCTL, KC_LGUI, KC_LALT,                   KC_SPACE,                 KC_RALT, KC_RGUI, KC_RCTL\n+      ),\n+\n+  [1] = LAYOUT(\n+      KC_ESC,  KC_F1,   KC_F2,   KC_F3,   KC_F4,   KC_F5,   KC_F6,   KC_F7,   KC_F8,   KC_F9,   KC_F10,  KC_F11,  KC_F12,  KC_INS, RESET,\n+      KC_CAPS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS, KC_PSCR, KC_SLCK, KC_PAUS, KC_UP, KC_TRNS, KC_DEL,\n+      KC_RCTL, KC_VOLU, KC_VOLD, KC_MUTE, KC_MPLY, KC_MSTP, KC_ASTR, KC_SLSH, KC_HOME, KC_PGUP, KC_LEFT, KC_RGHT, KC_TRNS,\n+      KC_TRNS, KC_TRNS, KC_TRNS, KC_TRNS,  KC_TRNS, KC_TRNS,  KC_PLUS, KC_UNDS, KC_END, KC_PGDN, KC_DOWN, KC_TRNS, KC_TRNS,\n+      KC_TRNS, KC_TRNS, KC_TRNS,                   KC_TRNS,                   KC_TRNS, KC_TRNS, KC_TRNS\n+      ),\n+};\n+\n+const uint16_t PROGMEM fn_actions[] = {","path":"keyboards/kbd6x/keymaps/hhkb-default-improved/keymap.c","position":38,"original_position":38,"commit_id":"389ddab56cddacc0e7b1743ae39e12dca19d2040","original_commit_id":"389ddab56cddacc0e7b1743ae39e12dca19d2040","user":{"login":"noroadsleft","id":18669334,"node_id":"MDQ6VXNlcjE4NjY5MzM0","avatar_url":"https://avatars3.githubusercontent.com/u/18669334?v=4","gravatar_id":"","url":"https://api.github.com/users/noroadsleft","html_url":"https://github.com/noroadsleft","followers_url":"https://api.github.com/users/noroadsleft/followers","following_url":"https://api.github.com/users/noroadsleft/following{/other_user}","gists_url":"https://api.github.com/users/noroadsleft/gists{/gist_id}","starred_url":"https://api.github.com/users/noroadsleft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noroadsleft/subscriptions","organizations_url":"https://api.github.com/users/noroadsleft/orgs","repos_url":"https://api.github.com/users/noroadsleft/repos","events_url":"https://api.github.com/users/noroadsleft/events{/privacy}","received_events_url":"https://api.github.com/users/noroadsleft/received_events","type":"User","site_admin":false},"body":"Lines 38-55 should be deleted. The functions are deprecated, and the keymap isn't using the functionality provided.","created_at":"2018-10-14T02:50:45Z","updated_at":"2018-10-14T02:54:13Z","html_url":"https://github.com/qmk/qmk_firmware/pull/4132#discussion_r224977362","pull_request_url":"https://api.github.com/repos/qmk/qmk_firmware/pulls/4132","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/qmk/qmk_firmware/pulls/comments/224977362"},"html":{"href":"https://github.com/qmk/qmk_firmware/pull/4132#discussion_r224977362"},"pull_request":{"href":"https://api.github.com/repos/qmk/qmk_firmware/pulls/4132"}}},"pull_request":{"url":"https://api.github.com/repos/qmk/qmk_firmware/pulls/4132","id":222686522,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNjg2NTIy","html_url":"https://github.com/qmk/qmk_firmware/pull/4132","diff_url":"https://github.com/qmk/qmk_firmware/pull/4132.diff","patch_url":"https://github.com/qmk/qmk_firmware/pull/4132.patch","issue_url":"https://api.github.com/repos/qmk/qmk_firmware/issues/4132","number":4132,"state":"open","locked":false,"title":"added layouts to the kbd6x for the tofu hhkb so new owners dont have to make it themselves","user":{"login":"ChrisUC","id":38164944,"node_id":"MDQ6VXNlcjM4MTY0OTQ0","avatar_url":"https://avatars2.githubusercontent.com/u/38164944?v=4","gravatar_id":"","url":"https://api.github.com/users/ChrisUC","html_url":"https://github.com/ChrisUC","followers_url":"https://api.github.com/users/ChrisUC/followers","following_url":"https://api.github.com/users/ChrisUC/following{/other_user}","gists_url":"https://api.github.com/users/ChrisUC/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisUC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisUC/subscriptions","organizations_url":"https://api.github.com/users/ChrisUC/orgs","repos_url":"https://api.github.com/users/ChrisUC/repos","events_url":"https://api.github.com/users/ChrisUC/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisUC/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-14T01:21:58Z","updated_at":"2018-10-14T02:54:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"09ca6e992a04a9854f013739f2fb00b7a433d186","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/qmk/qmk_firmware/pulls/4132/commits","review_comments_url":"https://api.github.com/repos/qmk/qmk_firmware/pulls/4132/comments","review_comment_url":"https://api.github.com/repos/qmk/qmk_firmware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qmk/qmk_firmware/issues/4132/comments","statuses_url":"https://api.github.com/repos/qmk/qmk_firmware/statuses/389ddab56cddacc0e7b1743ae39e12dca19d2040","head":{"label":"ChrisUC:master","ref":"master","sha":"389ddab56cddacc0e7b1743ae39e12dca19d2040","user":{"login":"ChrisUC","id":38164944,"node_id":"MDQ6VXNlcjM4MTY0OTQ0","avatar_url":"https://avatars2.githubusercontent.com/u/38164944?v=4","gravatar_id":"","url":"https://api.github.com/users/ChrisUC","html_url":"https://github.com/ChrisUC","followers_url":"https://api.github.com/users/ChrisUC/followers","following_url":"https://api.github.com/users/ChrisUC/following{/other_user}","gists_url":"https://api.github.com/users/ChrisUC/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisUC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisUC/subscriptions","organizations_url":"https://api.github.com/users/ChrisUC/orgs","repos_url":"https://api.github.com/users/ChrisUC/repos","events_url":"https://api.github.com/users/ChrisUC/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisUC/received_events","type":"User","site_admin":false},"repo":{"id":152928253,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI5MjgyNTM=","name":"qmk_firmware","full_name":"ChrisUC/qmk_firmware","private":false,"owner":{"login":"ChrisUC","id":38164944,"node_id":"MDQ6VXNlcjM4MTY0OTQ0","avatar_url":"https://avatars2.githubusercontent.com/u/38164944?v=4","gravatar_id":"","url":"https://api.github.com/users/ChrisUC","html_url":"https://github.com/ChrisUC","followers_url":"https://api.github.com/users/ChrisUC/followers","following_url":"https://api.github.com/users/ChrisUC/following{/other_user}","gists_url":"https://api.github.com/users/ChrisUC/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisUC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisUC/subscriptions","organizations_url":"https://api.github.com/users/ChrisUC/orgs","repos_url":"https://api.github.com/users/ChrisUC/repos","events_url":"https://api.github.com/users/ChrisUC/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisUC/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ChrisUC/qmk_firmware","description":"keyboard controller firmware for Atmel AVR and ARM USB families","fork":true,"url":"https://api.github.com/repos/ChrisUC/qmk_firmware","forks_url":"https://api.github.com/repos/ChrisUC/qmk_firmware/forks","keys_url":"https://api.github.com/repos/ChrisUC/qmk_firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ChrisUC/qmk_firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ChrisUC/qmk_firmware/teams","hooks_url":"https://api.github.com/repos/ChrisUC/qmk_firmware/hooks","issue_events_url":"https://api.github.com/repos/ChrisUC/qmk_firmware/issues/events{/number}","events_url":"https://api.github.com/repos/ChrisUC/qmk_firmware/events","assignees_url":"https://api.github.com/repos/ChrisUC/qmk_firmware/assignees{/user}","branches_url":"https://api.github.com/repos/ChrisUC/qmk_firmware/branches{/branch}","tags_url":"https://api.github.com/repos/ChrisUC/qmk_firmware/tags","blobs_url":"https://api.github.com/repos/ChrisUC/qmk_firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ChrisUC/qmk_firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ChrisUC/qmk_firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/ChrisUC/qmk_firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ChrisUC/qmk_firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/ChrisUC/qmk_firmware/languages","stargazers_url":"https://api.github.com/repos/ChrisUC/qmk_firmware/stargazers","contributors_url":"https://api.github.com/repos/ChrisUC/qmk_firmware/contributors","subscribers_url":"https://api.github.com/repos/ChrisUC/qmk_firmware/subscribers","subscription_url":"https://api.github.com/repos/ChrisUC/qmk_firmware/subscription","commits_url":"https://api.github.com/repos/ChrisUC/qmk_firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/ChrisUC/qmk_firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/ChrisUC/qmk_firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/ChrisUC/qmk_firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/ChrisUC/qmk_firmware/contents/{+path}","compare_url":"https://api.github.com/repos/ChrisUC/qmk_firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ChrisUC/qmk_firmware/merges","archive_url":"https://api.github.com/repos/ChrisUC/qmk_firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ChrisUC/qmk_firmware/downloads","issues_url":"https://api.github.com/repos/ChrisUC/qmk_firmware/issues{/number}","pulls_url":"https://api.github.com/repos/ChrisUC/qmk_firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/ChrisUC/qmk_firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/ChrisUC/qmk_firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ChrisUC/qmk_firmware/labels{/name}","releases_url":"https://api.github.com/repos/ChrisUC/qmk_firmware/releases{/id}","deployments_url":"https://api.github.com/repos/ChrisUC/qmk_firmware/deployments","created_at":"2018-10-14T01:16:48Z","updated_at":"2018-10-14T01:20:50Z","pushed_at":"2018-10-14T01:20:48Z","git_url":"git://github.com/ChrisUC/qmk_firmware.git","ssh_url":"git@github.com:ChrisUC/qmk_firmware.git","clone_url":"https://github.com/ChrisUC/qmk_firmware.git","svn_url":"https://github.com/ChrisUC/qmk_firmware","homepage":"http://qmk.fm","size":105031,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"qmk:master","ref":"master","sha":"533f6848875feb10d3944c1f41ff51060bcdabf2","user":{"login":"qmk","id":25358678,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzU4Njc4","avatar_url":"https://avatars3.githubusercontent.com/u/25358678?v=4","gravatar_id":"","url":"https://api.github.com/users/qmk","html_url":"https://github.com/qmk","followers_url":"https://api.github.com/users/qmk/followers","following_url":"https://api.github.com/users/qmk/following{/other_user}","gists_url":"https://api.github.com/users/qmk/gists{/gist_id}","starred_url":"https://api.github.com/users/qmk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qmk/subscriptions","organizations_url":"https://api.github.com/users/qmk/orgs","repos_url":"https://api.github.com/users/qmk/repos","events_url":"https://api.github.com/users/qmk/events{/privacy}","received_events_url":"https://api.github.com/users/qmk/received_events","type":"Organization","site_admin":false},"repo":{"id":27737393,"node_id":"MDEwOlJlcG9zaXRvcnkyNzczNzM5Mw==","name":"qmk_firmware","full_name":"qmk/qmk_firmware","private":false,"owner":{"login":"qmk","id":25358678,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzU4Njc4","avatar_url":"https://avatars3.githubusercontent.com/u/25358678?v=4","gravatar_id":"","url":"https://api.github.com/users/qmk","html_url":"https://github.com/qmk","followers_url":"https://api.github.com/users/qmk/followers","following_url":"https://api.github.com/users/qmk/following{/other_user}","gists_url":"https://api.github.com/users/qmk/gists{/gist_id}","starred_url":"https://api.github.com/users/qmk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qmk/subscriptions","organizations_url":"https://api.github.com/users/qmk/orgs","repos_url":"https://api.github.com/users/qmk/repos","events_url":"https://api.github.com/users/qmk/events{/privacy}","received_events_url":"https://api.github.com/users/qmk/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/qmk/qmk_firmware","description":"keyboard controller firmware for Atmel AVR and ARM USB families","fork":false,"url":"https://api.github.com/repos/qmk/qmk_firmware","forks_url":"https://api.github.com/repos/qmk/qmk_firmware/forks","keys_url":"https://api.github.com/repos/qmk/qmk_firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qmk/qmk_firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qmk/qmk_firmware/teams","hooks_url":"https://api.github.com/repos/qmk/qmk_firmware/hooks","issue_events_url":"https://api.github.com/repos/qmk/qmk_firmware/issues/events{/number}","events_url":"https://api.github.com/repos/qmk/qmk_firmware/events","assignees_url":"https://api.github.com/repos/qmk/qmk_firmware/assignees{/user}","branches_url":"https://api.github.com/repos/qmk/qmk_firmware/branches{/branch}","tags_url":"https://api.github.com/repos/qmk/qmk_firmware/tags","blobs_url":"https://api.github.com/repos/qmk/qmk_firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qmk/qmk_firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qmk/qmk_firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/qmk/qmk_firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qmk/qmk_firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/qmk/qmk_firmware/languages","stargazers_url":"https://api.github.com/repos/qmk/qmk_firmware/stargazers","contributors_url":"https://api.github.com/repos/qmk/qmk_firmware/contributors","subscribers_url":"https://api.github.com/repos/qmk/qmk_firmware/subscribers","subscription_url":"https://api.github.com/repos/qmk/qmk_firmware/subscription","commits_url":"https://api.github.com/repos/qmk/qmk_firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/qmk/qmk_firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/qmk/qmk_firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/qmk/qmk_firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/qmk/qmk_firmware/contents/{+path}","compare_url":"https://api.github.com/repos/qmk/qmk_firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qmk/qmk_firmware/merges","archive_url":"https://api.github.com/repos/qmk/qmk_firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qmk/qmk_firmware/downloads","issues_url":"https://api.github.com/repos/qmk/qmk_firmware/issues{/number}","pulls_url":"https://api.github.com/repos/qmk/qmk_firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/qmk/qmk_firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/qmk/qmk_firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qmk/qmk_firmware/labels{/name}","releases_url":"https://api.github.com/repos/qmk/qmk_firmware/releases{/id}","deployments_url":"https://api.github.com/repos/qmk/qmk_firmware/deployments","created_at":"2014-12-08T22:02:05Z","updated_at":"2018-10-13T22:45:49Z","pushed_at":"2018-10-14T02:43:13Z","git_url":"git://github.com/qmk/qmk_firmware.git","ssh_url":"git@github.com:qmk/qmk_firmware.git","clone_url":"https://github.com/qmk/qmk_firmware.git","svn_url":"https://github.com/qmk/qmk_firmware","homepage":"http://qmk.fm","size":104953,"stargazers_count":3066,"watchers_count":3066,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":5716,"mirror_url":null,"archived":false,"open_issues_count":382,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5716,"open_issues":382,"watchers":3066,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qmk/qmk_firmware/pulls/4132"},"html":{"href":"https://github.com/qmk/qmk_firmware/pull/4132"},"issue":{"href":"https://api.github.com/repos/qmk/qmk_firmware/issues/4132"},"comments":{"href":"https://api.github.com/repos/qmk/qmk_firmware/issues/4132/comments"},"review_comments":{"href":"https://api.github.com/repos/qmk/qmk_firmware/pulls/4132/comments"},"review_comment":{"href":"https://api.github.com/repos/qmk/qmk_firmware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qmk/qmk_firmware/pulls/4132/commits"},"statuses":{"href":"https://api.github.com/repos/qmk/qmk_firmware/statuses/389ddab56cddacc0e7b1743ae39e12dca19d2040"}},"author_association":"NONE"}}
{"actor":{"display_login":"noroadsleft"}}