{"action":"closed","number":20553,"pull_request":{"url":"https://api.github.com/repos/dotnet/coreclr/pulls/20553","id":225152024,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1MTUyMDI0","html_url":"https://github.com/dotnet/coreclr/pull/20553","diff_url":"https://github.com/dotnet/coreclr/pull/20553.diff","patch_url":"https://github.com/dotnet/coreclr/pull/20553.patch","issue_url":"https://api.github.com/repos/dotnet/coreclr/issues/20553","number":20553,"state":"closed","locked":false,"title":"JIT: refactor how we do late devirtualization","user":{"login":"AndyAyersMS","id":10121823,"node_id":"MDQ6VXNlcjEwMTIxODIz","avatar_url":"https://avatars1.githubusercontent.com/u/10121823?v=4","gravatar_id":"","url":"https://api.github.com/users/AndyAyersMS","html_url":"https://github.com/AndyAyersMS","followers_url":"https://api.github.com/users/AndyAyersMS/followers","following_url":"https://api.github.com/users/AndyAyersMS/following{/other_user}","gists_url":"https://api.github.com/users/AndyAyersMS/gists{/gist_id}","starred_url":"https://api.github.com/users/AndyAyersMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndyAyersMS/subscriptions","organizations_url":"https://api.github.com/users/AndyAyersMS/orgs","repos_url":"https://api.github.com/users/AndyAyersMS/repos","events_url":"https://api.github.com/users/AndyAyersMS/events{/privacy}","received_events_url":"https://api.github.com/users/AndyAyersMS/received_events","type":"User","site_admin":false},"body":"Change late devirtualization to run in a postorder callback during\r\nthe tree search to update GT_RET_EXPRs, instead of shoehorning it into\r\nthe preorder callback.\r\n\r\nThis allows the jit to reconsider all calls for late devirtualization,\r\nnot just calls that are parents of particular GT_RET_EXPRs. The jit will\r\ntake advantage of this in subsequent work that does more aggressive\r\nbottup-up type sharpening.\r\n\r\nReconsidering all calls for late devirt instead of just a select subset\r\nincurs around a 0.5% throughput impact.\r\n\r\nTo mitigate this, short-circult the tree walk when we no longer see a\r\nGTF_CALL flag. This prevents us from walking through CALL and RET_EXPR\r\nfree subtrees.\r\n\r\nTo make this work we have to make sure all node types propagate flags from\r\ntheir children. This required some updates to a few node constructors.\r\n\r\nAlso take advantage of `gtRetExprVal` to tunnel through GT_RET_EXPR chains\r\nto the final tree to avoid needing multiple overwrites when propagating\r\nthe return expression back into the IR.\r\n\r\nWith these mitigations this change has minimal throughput impact.","created_at":"2018-10-23T19:04:08Z","updated_at":"2018-10-26T17:55:07Z","closed_at":"2018-10-26T17:55:06Z","merged_at":"2018-10-26T17:55:06Z","merge_commit_sha":"dfd0f4f8032e8297ba8d5b5dc92e4f08d5204983","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/coreclr/pulls/20553/commits","review_comments_url":"https://api.github.com/repos/dotnet/coreclr/pulls/20553/comments","review_comment_url":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/coreclr/issues/20553/comments","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/d5535815af20bed4ee49d9c5cbf947d9ae023d5e","head":{"label":"AndyAyersMS:RunReturnValuePlaceholderPostorder","ref":"RunReturnValuePlaceholderPostorder","sha":"d5535815af20bed4ee49d9c5cbf947d9ae023d5e","user":{"login":"AndyAyersMS","id":10121823,"node_id":"MDQ6VXNlcjEwMTIxODIz","avatar_url":"https://avatars1.githubusercontent.com/u/10121823?v=4","gravatar_id":"","url":"https://api.github.com/users/AndyAyersMS","html_url":"https://github.com/AndyAyersMS","followers_url":"https://api.github.com/users/AndyAyersMS/followers","following_url":"https://api.github.com/users/AndyAyersMS/following{/other_user}","gists_url":"https://api.github.com/users/AndyAyersMS/gists{/gist_id}","starred_url":"https://api.github.com/users/AndyAyersMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndyAyersMS/subscriptions","organizations_url":"https://api.github.com/users/AndyAyersMS/orgs","repos_url":"https://api.github.com/users/AndyAyersMS/repos","events_url":"https://api.github.com/users/AndyAyersMS/events{/privacy}","received_events_url":"https://api.github.com/users/AndyAyersMS/received_events","type":"User","site_admin":false},"repo":{"id":34692475,"node_id":"MDEwOlJlcG9zaXRvcnkzNDY5MjQ3NQ==","name":"coreclr","full_name":"AndyAyersMS/coreclr","private":false,"owner":{"login":"AndyAyersMS","id":10121823,"node_id":"MDQ6VXNlcjEwMTIxODIz","avatar_url":"https://avatars1.githubusercontent.com/u/10121823?v=4","gravatar_id":"","url":"https://api.github.com/users/AndyAyersMS","html_url":"https://github.com/AndyAyersMS","followers_url":"https://api.github.com/users/AndyAyersMS/followers","following_url":"https://api.github.com/users/AndyAyersMS/following{/other_user}","gists_url":"https://api.github.com/users/AndyAyersMS/gists{/gist_id}","starred_url":"https://api.github.com/users/AndyAyersMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndyAyersMS/subscriptions","organizations_url":"https://api.github.com/users/AndyAyersMS/orgs","repos_url":"https://api.github.com/users/AndyAyersMS/repos","events_url":"https://api.github.com/users/AndyAyersMS/events{/privacy}","received_events_url":"https://api.github.com/users/AndyAyersMS/received_events","type":"User","site_admin":false},"html_url":"https://github.com/AndyAyersMS/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called mscorlib. It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes.","fork":true,"url":"https://api.github.com/repos/AndyAyersMS/coreclr","forks_url":"https://api.github.com/repos/AndyAyersMS/coreclr/forks","keys_url":"https://api.github.com/repos/AndyAyersMS/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AndyAyersMS/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AndyAyersMS/coreclr/teams","hooks_url":"https://api.github.com/repos/AndyAyersMS/coreclr/hooks","issue_events_url":"https://api.github.com/repos/AndyAyersMS/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/AndyAyersMS/coreclr/events","assignees_url":"https://api.github.com/repos/AndyAyersMS/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/AndyAyersMS/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/AndyAyersMS/coreclr/tags","blobs_url":"https://api.github.com/repos/AndyAyersMS/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AndyAyersMS/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AndyAyersMS/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/AndyAyersMS/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AndyAyersMS/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/AndyAyersMS/coreclr/languages","stargazers_url":"https://api.github.com/repos/AndyAyersMS/coreclr/stargazers","contributors_url":"https://api.github.com/repos/AndyAyersMS/coreclr/contributors","subscribers_url":"https://api.github.com/repos/AndyAyersMS/coreclr/subscribers","subscription_url":"https://api.github.com/repos/AndyAyersMS/coreclr/subscription","commits_url":"https://api.github.com/repos/AndyAyersMS/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/AndyAyersMS/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/AndyAyersMS/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/AndyAyersMS/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/AndyAyersMS/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/AndyAyersMS/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AndyAyersMS/coreclr/merges","archive_url":"https://api.github.com/repos/AndyAyersMS/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AndyAyersMS/coreclr/downloads","issues_url":"https://api.github.com/repos/AndyAyersMS/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/AndyAyersMS/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/AndyAyersMS/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/AndyAyersMS/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AndyAyersMS/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/AndyAyersMS/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/AndyAyersMS/coreclr/deployments","created_at":"2015-04-27T21:34:06Z","updated_at":"2018-08-20T22:29:42Z","pushed_at":"2018-10-26T17:48:00Z","git_url":"git://github.com/AndyAyersMS/coreclr.git","ssh_url":"git@github.com:AndyAyersMS/coreclr.git","clone_url":"https://github.com/AndyAyersMS/coreclr.git","svn_url":"https://github.com/AndyAyersMS/coreclr","homepage":"","size":247751,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"cd89eaf4ecf86a877187ebe2b091d4ed17db7c0e","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":30092893,"node_id":"MDEwOlJlcG9zaXRvcnkzMDA5Mjg5Mw==","name":"coreclr","full_name":"dotnet/coreclr","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/coreclr","description":"This repo contains the .NET Core runtime, called CoreCLR, and the base library, called System.Private.Corelib (or mscorlib). It includes the garbage collector, JIT compiler, base .NET data types and many low-level classes. We welcome contributions.","fork":false,"url":"https://api.github.com/repos/dotnet/coreclr","forks_url":"https://api.github.com/repos/dotnet/coreclr/forks","keys_url":"https://api.github.com/repos/dotnet/coreclr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/coreclr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/coreclr/teams","hooks_url":"https://api.github.com/repos/dotnet/coreclr/hooks","issue_events_url":"https://api.github.com/repos/dotnet/coreclr/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/coreclr/events","assignees_url":"https://api.github.com/repos/dotnet/coreclr/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/coreclr/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/coreclr/tags","blobs_url":"https://api.github.com/repos/dotnet/coreclr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/coreclr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/coreclr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/coreclr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/coreclr/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/coreclr/languages","stargazers_url":"https://api.github.com/repos/dotnet/coreclr/stargazers","contributors_url":"https://api.github.com/repos/dotnet/coreclr/contributors","subscribers_url":"https://api.github.com/repos/dotnet/coreclr/subscribers","subscription_url":"https://api.github.com/repos/dotnet/coreclr/subscription","commits_url":"https://api.github.com/repos/dotnet/coreclr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/coreclr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/coreclr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/coreclr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/coreclr/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/coreclr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/coreclr/merges","archive_url":"https://api.github.com/repos/dotnet/coreclr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/coreclr/downloads","issues_url":"https://api.github.com/repos/dotnet/coreclr/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/coreclr/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/coreclr/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/coreclr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/coreclr/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/coreclr/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/coreclr/deployments","created_at":"2015-01-30T22:10:02Z","updated_at":"2018-10-26T17:50:53Z","pushed_at":"2018-10-26T17:55:06Z","git_url":"git://github.com/dotnet/coreclr.git","ssh_url":"git@github.com:dotnet/coreclr.git","clone_url":"https://github.com/dotnet/coreclr.git","svn_url":"https://github.com/dotnet/coreclr","homepage":"https://github.com/dotnet/core","size":250182,"stargazers_count":10381,"watchers_count":10381,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2486,"mirror_url":null,"archived":false,"open_issues_count":1985,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2486,"open_issues":1985,"watchers":10381,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/20553"},"html":{"href":"https://github.com/dotnet/coreclr/pull/20553"},"issue":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/20553"},"comments":{"href":"https://api.github.com/repos/dotnet/coreclr/issues/20553/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/20553/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/coreclr/pulls/20553/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/coreclr/statuses/d5535815af20bed4ee49d9c5cbf947d9ae023d5e"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"AndyAyersMS","id":10121823,"node_id":"MDQ6VXNlcjEwMTIxODIz","avatar_url":"https://avatars1.githubusercontent.com/u/10121823?v=4","gravatar_id":"","url":"https://api.github.com/users/AndyAyersMS","html_url":"https://github.com/AndyAyersMS","followers_url":"https://api.github.com/users/AndyAyersMS/followers","following_url":"https://api.github.com/users/AndyAyersMS/following{/other_user}","gists_url":"https://api.github.com/users/AndyAyersMS/gists{/gist_id}","starred_url":"https://api.github.com/users/AndyAyersMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AndyAyersMS/subscriptions","organizations_url":"https://api.github.com/users/AndyAyersMS/orgs","repos_url":"https://api.github.com/users/AndyAyersMS/repos","events_url":"https://api.github.com/users/AndyAyersMS/events{/privacy}","received_events_url":"https://api.github.com/users/AndyAyersMS/received_events","type":"User","site_admin":false},"comments":16,"review_comments":1,"maintainer_can_modify":false,"commits":3,"additions":137,"deletions":82,"changed_files":4}}
{"actor":{"display_login":"AndyAyersMS"}}