{"action":"created","comment":{"url":"https://api.github.com/repos/immutables/immutables/pulls/comments/223891287","pull_request_review_id":163131235,"id":223891287,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzg5MTI4Nw==","diff_hunk":"@@ -2670,6 +2670,9 @@ static final [output.linesShortable]class Json[type.generics]\n   [signature] { throw new UnsupportedOperationException(); }\n [/for]\n [for v in type.allAccessibleAttributes]\n+  [if v.isGenerateDerived]","path":"value-processor/src/org/immutables/value/processor/Immutables.generator","position":4,"original_position":4,"commit_id":"1f0168af435150c063548b42228cde7532b2ad62","original_commit_id":"1f0168af435150c063548b42228cde7532b2ad62","user":{"login":"elucash","id":1692611,"node_id":"MDQ6VXNlcjE2OTI2MTE=","avatar_url":"https://avatars1.githubusercontent.com/u/1692611?v=4","gravatar_id":"","url":"https://api.github.com/users/elucash","html_url":"https://github.com/elucash","followers_url":"https://api.github.com/users/elucash/followers","following_url":"https://api.github.com/users/elucash/following{/other_user}","gists_url":"https://api.github.com/users/elucash/gists{/gist_id}","starred_url":"https://api.github.com/users/elucash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elucash/subscriptions","organizations_url":"https://api.github.com/users/elucash/orgs","repos_url":"https://api.github.com/users/elucash/repos","events_url":"https://api.github.com/users/elucash/events{/privacy}","received_events_url":"https://api.github.com/users/elucash/received_events","type":"User","site_admin":false},"body":"should we mark all stub methods as ignored (not only derived), does it cause any problem with deserialization of mandatory attributes?","created_at":"2018-10-09T23:01:30Z","updated_at":"2018-10-09T23:01:30Z","html_url":"https://github.com/immutables/immutables/pull/846#discussion_r223891287","pull_request_url":"https://api.github.com/repos/immutables/immutables/pulls/846","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/immutables/immutables/pulls/comments/223891287"},"html":{"href":"https://github.com/immutables/immutables/pull/846#discussion_r223891287"},"pull_request":{"href":"https://api.github.com/repos/immutables/immutables/pulls/846"}}},"pull_request":{"url":"https://api.github.com/repos/immutables/immutables/pulls/846","id":221604337,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxNjA0MzM3","html_url":"https://github.com/immutables/immutables/pull/846","diff_url":"https://github.com/immutables/immutables/pull/846.diff","patch_url":"https://github.com/immutables/immutables/pull/846.patch","issue_url":"https://api.github.com/repos/immutables/immutables/issues/846","number":846,"state":"open","locked":false,"title":"Issue #603 - automatically add `@JsonIgnore` to the `class Json` builder for derived functions.","user":{"login":"jdstapleton","id":5853065,"node_id":"MDQ6VXNlcjU4NTMwNjU=","avatar_url":"https://avatars0.githubusercontent.com/u/5853065?v=4","gravatar_id":"","url":"https://api.github.com/users/jdstapleton","html_url":"https://github.com/jdstapleton","followers_url":"https://api.github.com/users/jdstapleton/followers","following_url":"https://api.github.com/users/jdstapleton/following{/other_user}","gists_url":"https://api.github.com/users/jdstapleton/gists{/gist_id}","starred_url":"https://api.github.com/users/jdstapleton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdstapleton/subscriptions","organizations_url":"https://api.github.com/users/jdstapleton/orgs","repos_url":"https://api.github.com/users/jdstapleton/repos","events_url":"https://api.github.com/users/jdstapleton/events{/privacy}","received_events_url":"https://api.github.com/users/jdstapleton/received_events","type":"User","site_admin":false},"body":"Since derived functions are calculated fields that are outputted when serialized to json, they\r\nshouldn't be attempted to be deserialized from the Json structure.","created_at":"2018-10-09T22:20:50Z","updated_at":"2018-10-09T23:01:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9c9e357b361b393e70b08fef79cebf9408ba3d41","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/immutables/immutables/pulls/846/commits","review_comments_url":"https://api.github.com/repos/immutables/immutables/pulls/846/comments","review_comment_url":"https://api.github.com/repos/immutables/immutables/pulls/comments{/number}","comments_url":"https://api.github.com/repos/immutables/immutables/issues/846/comments","statuses_url":"https://api.github.com/repos/immutables/immutables/statuses/1f0168af435150c063548b42228cde7532b2ad62","head":{"label":"jdstapleton:master","ref":"master","sha":"1f0168af435150c063548b42228cde7532b2ad62","user":{"login":"jdstapleton","id":5853065,"node_id":"MDQ6VXNlcjU4NTMwNjU=","avatar_url":"https://avatars0.githubusercontent.com/u/5853065?v=4","gravatar_id":"","url":"https://api.github.com/users/jdstapleton","html_url":"https://github.com/jdstapleton","followers_url":"https://api.github.com/users/jdstapleton/followers","following_url":"https://api.github.com/users/jdstapleton/following{/other_user}","gists_url":"https://api.github.com/users/jdstapleton/gists{/gist_id}","starred_url":"https://api.github.com/users/jdstapleton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdstapleton/subscriptions","organizations_url":"https://api.github.com/users/jdstapleton/orgs","repos_url":"https://api.github.com/users/jdstapleton/repos","events_url":"https://api.github.com/users/jdstapleton/events{/privacy}","received_events_url":"https://api.github.com/users/jdstapleton/received_events","type":"User","site_admin":false},"repo":{"id":152296998,"node_id":"MDEwOlJlcG9zaXRvcnkxNTIyOTY5OTg=","name":"immutables","full_name":"jdstapleton/immutables","private":false,"owner":{"login":"jdstapleton","id":5853065,"node_id":"MDQ6VXNlcjU4NTMwNjU=","avatar_url":"https://avatars0.githubusercontent.com/u/5853065?v=4","gravatar_id":"","url":"https://api.github.com/users/jdstapleton","html_url":"https://github.com/jdstapleton","followers_url":"https://api.github.com/users/jdstapleton/followers","following_url":"https://api.github.com/users/jdstapleton/following{/other_user}","gists_url":"https://api.github.com/users/jdstapleton/gists{/gist_id}","starred_url":"https://api.github.com/users/jdstapleton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdstapleton/subscriptions","organizations_url":"https://api.github.com/users/jdstapleton/orgs","repos_url":"https://api.github.com/users/jdstapleton/repos","events_url":"https://api.github.com/users/jdstapleton/events{/privacy}","received_events_url":"https://api.github.com/users/jdstapleton/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jdstapleton/immutables","description":"Annotation processor to create immutable objects and builders. Feels like Guava's immutable collections but for regular value objects. JSON, Jackson, Gson, JAX-RS integrations included","fork":true,"url":"https://api.github.com/repos/jdstapleton/immutables","forks_url":"https://api.github.com/repos/jdstapleton/immutables/forks","keys_url":"https://api.github.com/repos/jdstapleton/immutables/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jdstapleton/immutables/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jdstapleton/immutables/teams","hooks_url":"https://api.github.com/repos/jdstapleton/immutables/hooks","issue_events_url":"https://api.github.com/repos/jdstapleton/immutables/issues/events{/number}","events_url":"https://api.github.com/repos/jdstapleton/immutables/events","assignees_url":"https://api.github.com/repos/jdstapleton/immutables/assignees{/user}","branches_url":"https://api.github.com/repos/jdstapleton/immutables/branches{/branch}","tags_url":"https://api.github.com/repos/jdstapleton/immutables/tags","blobs_url":"https://api.github.com/repos/jdstapleton/immutables/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jdstapleton/immutables/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jdstapleton/immutables/git/refs{/sha}","trees_url":"https://api.github.com/repos/jdstapleton/immutables/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jdstapleton/immutables/statuses/{sha}","languages_url":"https://api.github.com/repos/jdstapleton/immutables/languages","stargazers_url":"https://api.github.com/repos/jdstapleton/immutables/stargazers","contributors_url":"https://api.github.com/repos/jdstapleton/immutables/contributors","subscribers_url":"https://api.github.com/repos/jdstapleton/immutables/subscribers","subscription_url":"https://api.github.com/repos/jdstapleton/immutables/subscription","commits_url":"https://api.github.com/repos/jdstapleton/immutables/commits{/sha}","git_commits_url":"https://api.github.com/repos/jdstapleton/immutables/git/commits{/sha}","comments_url":"https://api.github.com/repos/jdstapleton/immutables/comments{/number}","issue_comment_url":"https://api.github.com/repos/jdstapleton/immutables/issues/comments{/number}","contents_url":"https://api.github.com/repos/jdstapleton/immutables/contents/{+path}","compare_url":"https://api.github.com/repos/jdstapleton/immutables/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jdstapleton/immutables/merges","archive_url":"https://api.github.com/repos/jdstapleton/immutables/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jdstapleton/immutables/downloads","issues_url":"https://api.github.com/repos/jdstapleton/immutables/issues{/number}","pulls_url":"https://api.github.com/repos/jdstapleton/immutables/pulls{/number}","milestones_url":"https://api.github.com/repos/jdstapleton/immutables/milestones{/number}","notifications_url":"https://api.github.com/repos/jdstapleton/immutables/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jdstapleton/immutables/labels{/name}","releases_url":"https://api.github.com/repos/jdstapleton/immutables/releases{/id}","deployments_url":"https://api.github.com/repos/jdstapleton/immutables/deployments","created_at":"2018-10-09T17:58:46Z","updated_at":"2018-10-09T22:20:20Z","pushed_at":"2018-10-09T22:20:19Z","git_url":"git://github.com/jdstapleton/immutables.git","ssh_url":"git@github.com:jdstapleton/immutables.git","clone_url":"https://github.com/jdstapleton/immutables.git","svn_url":"https://github.com/jdstapleton/immutables","homepage":"http://immutables.org","size":9219,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"immutables:master","ref":"master","sha":"9ae9c368ddb23d18e5dda579459e76a74af222d1","user":{"login":"immutables","id":4175333,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxNzUzMzM=","avatar_url":"https://avatars1.githubusercontent.com/u/4175333?v=4","gravatar_id":"","url":"https://api.github.com/users/immutables","html_url":"https://github.com/immutables","followers_url":"https://api.github.com/users/immutables/followers","following_url":"https://api.github.com/users/immutables/following{/other_user}","gists_url":"https://api.github.com/users/immutables/gists{/gist_id}","starred_url":"https://api.github.com/users/immutables/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/immutables/subscriptions","organizations_url":"https://api.github.com/users/immutables/orgs","repos_url":"https://api.github.com/users/immutables/repos","events_url":"https://api.github.com/users/immutables/events{/privacy}","received_events_url":"https://api.github.com/users/immutables/received_events","type":"Organization","site_admin":false},"repo":{"id":11233996,"node_id":"MDEwOlJlcG9zaXRvcnkxMTIzMzk5Ng==","name":"immutables","full_name":"immutables/immutables","private":false,"owner":{"login":"immutables","id":4175333,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxNzUzMzM=","avatar_url":"https://avatars1.githubusercontent.com/u/4175333?v=4","gravatar_id":"","url":"https://api.github.com/users/immutables","html_url":"https://github.com/immutables","followers_url":"https://api.github.com/users/immutables/followers","following_url":"https://api.github.com/users/immutables/following{/other_user}","gists_url":"https://api.github.com/users/immutables/gists{/gist_id}","starred_url":"https://api.github.com/users/immutables/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/immutables/subscriptions","organizations_url":"https://api.github.com/users/immutables/orgs","repos_url":"https://api.github.com/users/immutables/repos","events_url":"https://api.github.com/users/immutables/events{/privacy}","received_events_url":"https://api.github.com/users/immutables/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/immutables/immutables","description":"Annotation processor to create immutable objects and builders. Feels like Guava's immutable collections but for regular value objects. JSON, Jackson, Gson, JAX-RS integrations included","fork":false,"url":"https://api.github.com/repos/immutables/immutables","forks_url":"https://api.github.com/repos/immutables/immutables/forks","keys_url":"https://api.github.com/repos/immutables/immutables/keys{/key_id}","collaborators_url":"https://api.github.com/repos/immutables/immutables/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/immutables/immutables/teams","hooks_url":"https://api.github.com/repos/immutables/immutables/hooks","issue_events_url":"https://api.github.com/repos/immutables/immutables/issues/events{/number}","events_url":"https://api.github.com/repos/immutables/immutables/events","assignees_url":"https://api.github.com/repos/immutables/immutables/assignees{/user}","branches_url":"https://api.github.com/repos/immutables/immutables/branches{/branch}","tags_url":"https://api.github.com/repos/immutables/immutables/tags","blobs_url":"https://api.github.com/repos/immutables/immutables/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/immutables/immutables/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/immutables/immutables/git/refs{/sha}","trees_url":"https://api.github.com/repos/immutables/immutables/git/trees{/sha}","statuses_url":"https://api.github.com/repos/immutables/immutables/statuses/{sha}","languages_url":"https://api.github.com/repos/immutables/immutables/languages","stargazers_url":"https://api.github.com/repos/immutables/immutables/stargazers","contributors_url":"https://api.github.com/repos/immutables/immutables/contributors","subscribers_url":"https://api.github.com/repos/immutables/immutables/subscribers","subscription_url":"https://api.github.com/repos/immutables/immutables/subscription","commits_url":"https://api.github.com/repos/immutables/immutables/commits{/sha}","git_commits_url":"https://api.github.com/repos/immutables/immutables/git/commits{/sha}","comments_url":"https://api.github.com/repos/immutables/immutables/comments{/number}","issue_comment_url":"https://api.github.com/repos/immutables/immutables/issues/comments{/number}","contents_url":"https://api.github.com/repos/immutables/immutables/contents/{+path}","compare_url":"https://api.github.com/repos/immutables/immutables/compare/{base}...{head}","merges_url":"https://api.github.com/repos/immutables/immutables/merges","archive_url":"https://api.github.com/repos/immutables/immutables/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/immutables/immutables/downloads","issues_url":"https://api.github.com/repos/immutables/immutables/issues{/number}","pulls_url":"https://api.github.com/repos/immutables/immutables/pulls{/number}","milestones_url":"https://api.github.com/repos/immutables/immutables/milestones{/number}","notifications_url":"https://api.github.com/repos/immutables/immutables/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/immutables/immutables/labels{/name}","releases_url":"https://api.github.com/repos/immutables/immutables/releases{/id}","deployments_url":"https://api.github.com/repos/immutables/immutables/deployments","created_at":"2013-07-07T13:48:23Z","updated_at":"2018-10-09T22:44:40Z","pushed_at":"2018-10-09T22:20:50Z","git_url":"git://github.com/immutables/immutables.git","ssh_url":"git@github.com:immutables/immutables.git","clone_url":"https://github.com/immutables/immutables.git","svn_url":"https://github.com/immutables/immutables","homepage":"http://immutables.org","size":9219,"stargazers_count":2145,"watchers_count":2145,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":161,"mirror_url":null,"archived":false,"open_issues_count":163,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":161,"open_issues":163,"watchers":2145,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/immutables/immutables/pulls/846"},"html":{"href":"https://github.com/immutables/immutables/pull/846"},"issue":{"href":"https://api.github.com/repos/immutables/immutables/issues/846"},"comments":{"href":"https://api.github.com/repos/immutables/immutables/issues/846/comments"},"review_comments":{"href":"https://api.github.com/repos/immutables/immutables/pulls/846/comments"},"review_comment":{"href":"https://api.github.com/repos/immutables/immutables/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/immutables/immutables/pulls/846/commits"},"statuses":{"href":"https://api.github.com/repos/immutables/immutables/statuses/1f0168af435150c063548b42228cde7532b2ad62"}},"author_association":"NONE"}}
{"actor":{"display_login":"elucash"}}