{"action":"created","issue":{"url":"https://api.github.com/repos/openSUSE/osc/issues/416","repository_url":"https://api.github.com/repos/openSUSE/osc","labels_url":"https://api.github.com/repos/openSUSE/osc/issues/416/labels{/name}","comments_url":"https://api.github.com/repos/openSUSE/osc/issues/416/comments","events_url":"https://api.github.com/repos/openSUSE/osc/issues/416/events","html_url":"https://github.com/openSUSE/osc/pull/416","id":320533300,"number":416,"title":"Adding User prompt to enable keyring or not.","user":{"login":"philo-math","id":26297035,"avatar_url":"https://avatars1.githubusercontent.com/u/26297035?v=4","gravatar_id":"","url":"https://api.github.com/users/philo-math","html_url":"https://github.com/philo-math","followers_url":"https://api.github.com/users/philo-math/followers","following_url":"https://api.github.com/users/philo-math/following{/other_user}","gists_url":"https://api.github.com/users/philo-math/gists{/gist_id}","starred_url":"https://api.github.com/users/philo-math/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philo-math/subscriptions","organizations_url":"https://api.github.com/users/philo-math/orgs","repos_url":"https://api.github.com/users/philo-math/repos","events_url":"https://api.github.com/users/philo-math/events{/privacy}","received_events_url":"https://api.github.com/users/philo-math/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-05-05T19:00:38Z","updated_at":"2018-05-07T14:52:54Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/openSUSE/osc/pulls/416","html_url":"https://github.com/openSUSE/osc/pull/416","diff_url":"https://github.com/openSUSE/osc/pull/416.diff","patch_url":"https://github.com/openSUSE/osc/pull/416.patch"},"body":"This patch is referenced to Issue: #406. A user prompt is added to commandline.py  file. \r\n@lethliel @marcus-h \r\nPlease review this patch. I have few doubts regarding the patch, if anyone can help: \r\n* Since config file is created using a template, so if the user choose to enable keyring, same config file template is used with the use_keyring commented which might be confusing. So, should we create another template for keyring enabled scenario?\r\n* An error occurred when the keyring is enabled by the user, which is resolved by installing keyrings.alt package. If there is any better way, can anyone help me?\r\n> Traceback (most recent call last):\r\n  File \"osc-wrapper.py\", line 41, in <module>\r\n    r = babysitter.run(osccli)\r\n  File \"/home/matrix/projects/opensuse/osc_test/osc/osc/babysitter.py\", line 61, in run\r\n    return prg.main(argv)\r\n  File \"/home/matrix/projects/opensuse/osc_test/osc/osc/cmdln.py\", line 336, in main\r\n    self.postoptparse()\r\n  File \"/home/matrix/projects/opensuse/osc_test/osc/osc/commandline.py\", line 177, in postoptparse\r\n    conf.write_initial_config(e.file, config)\r\n  File \"/home/matrix/projects/opensuse/osc_test/osc/osc/conf.py\", line 747, in write_initial_config\r\n    keyring.set_password(host, config['user'], config['pass'])\r\n  File \"/home/matrix/projects/opensuse/osc_test/osc/requirements/local/lib/python2.7/site-packages/keyring/core.py\", line 47, in set_password\r\n    _keyring_backend.set_password(service_name, username, password)\r\n  File \"/home/matrix/projects/opensuse/osc_test/osc/requirements/local/lib/python2.7/site-packages/keyring/backends/fail.py\", line 23, in get_password\r\n    raise RuntimeError(msg)\r\nRuntimeError: No recommended backend was available. Install the keyrings.alt package if you want to use the non-recommended backends. See README.rst for details.\r\n\r\nIf I am missing something in the patch, please guide me on improving it.\r\nThanks"},"comment":{"url":"https://api.github.com/repos/openSUSE/osc/issues/comments/387090660","html_url":"https://github.com/openSUSE/osc/pull/416#issuecomment-387090660","issue_url":"https://api.github.com/repos/openSUSE/osc/issues/416","id":387090660,"user":{"login":"adrianschroeter","id":1067148,"avatar_url":"https://avatars3.githubusercontent.com/u/1067148?v=4","gravatar_id":"","url":"https://api.github.com/users/adrianschroeter","html_url":"https://github.com/adrianschroeter","followers_url":"https://api.github.com/users/adrianschroeter/followers","following_url":"https://api.github.com/users/adrianschroeter/following{/other_user}","gists_url":"https://api.github.com/users/adrianschroeter/gists{/gist_id}","starred_url":"https://api.github.com/users/adrianschroeter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrianschroeter/subscriptions","organizations_url":"https://api.github.com/users/adrianschroeter/orgs","repos_url":"https://api.github.com/users/adrianschroeter/repos","events_url":"https://api.github.com/users/adrianschroeter/events{/privacy}","received_events_url":"https://api.github.com/users/adrianschroeter/received_events","type":"User","site_admin":false},"created_at":"2018-05-07T14:52:54Z","updated_at":"2018-05-07T14:52:54Z","author_association":"OWNER","body":"On Samstag, 5. Mai 2018, 22:30:50 CEST wrote Marcus Hüwe:\n...\n> # use KDE/Gnome/MacOS/Windows keyring for credentials if available\n> use_keyring = %(use_keyring)s\n> \n> (probably, we also need something similar for the gnome_keyring).\n\nA bit out of topic, but can't we drop gnome_keyring and rely on the gnome\nimplementation of python-keyring?\n\nI can remember gnome_keyring only as problem child, causing all kinds\nof wired bugreports esp. when it is not used on the right gnome version.\nOr you had shared home directory but were loged-in into some other server\nwhich did not have the gnome stuff installed.\n\nany reason to keep it?\n\n\n-- \n\nAdrian Schroeter\nemail: adrian@suse.de\n\nSUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) \n \nMaxfeldstraße 5                         \n90409 Nürnberg \nGermany \n\n\n\n\n"}}
{"actor":{"display_login":"adrianschroeter"}}