{"action":"created","issue":{"url":"https://api.github.com/repos/vim/vim/issues/3501","repository_url":"https://api.github.com/repos/vim/vim","labels_url":"https://api.github.com/repos/vim/vim/issues/3501/labels{/name}","comments_url":"https://api.github.com/repos/vim/vim/issues/3501/comments","events_url":"https://api.github.com/repos/vim/vim/issues/3501/events","html_url":"https://github.com/vim/vim/pull/3501","id":365294023,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MjQ5MjY4","number":3501,"title":"[WIP] win32: Refactor the NSIS installer","user":{"login":"k-takata","id":840186,"node_id":"MDQ6VXNlcjg0MDE4Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/840186?v=4","gravatar_id":"","url":"https://api.github.com/users/k-takata","html_url":"https://github.com/k-takata","followers_url":"https://api.github.com/users/k-takata/followers","following_url":"https://api.github.com/users/k-takata/following{/other_user}","gists_url":"https://api.github.com/users/k-takata/gists{/gist_id}","starred_url":"https://api.github.com/users/k-takata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k-takata/subscriptions","organizations_url":"https://api.github.com/users/k-takata/orgs","repos_url":"https://api.github.com/users/k-takata/repos","events_url":"https://api.github.com/users/k-takata/events{/privacy}","received_events_url":"https://api.github.com/users/k-takata/received_events","type":"User","site_admin":false},"labels":[{"id":718754193,"node_id":"MDU6TGFiZWw3MTg3NTQxOTM=","url":"https://api.github.com/repos/vim/vim/labels/installer","name":"installer","color":"65f776","default":false},{"id":717757429,"node_id":"MDU6TGFiZWw3MTc3NTc0Mjk=","url":"https://api.github.com/repos/vim/vim/labels/platform-windows","name":"platform-windows","color":"02e10c","default":false}],"state":"open","locked":false,"assignee":{"login":"k-takata","id":840186,"node_id":"MDQ6VXNlcjg0MDE4Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/840186?v=4","gravatar_id":"","url":"https://api.github.com/users/k-takata","html_url":"https://github.com/k-takata","followers_url":"https://api.github.com/users/k-takata/followers","following_url":"https://api.github.com/users/k-takata/following{/other_user}","gists_url":"https://api.github.com/users/k-takata/gists{/gist_id}","starred_url":"https://api.github.com/users/k-takata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k-takata/subscriptions","organizations_url":"https://api.github.com/users/k-takata/orgs","repos_url":"https://api.github.com/users/k-takata/repos","events_url":"https://api.github.com/users/k-takata/events{/privacy}","received_events_url":"https://api.github.com/users/k-takata/received_events","type":"User","site_admin":false},"assignees":[{"login":"k-takata","id":840186,"node_id":"MDQ6VXNlcjg0MDE4Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/840186?v=4","gravatar_id":"","url":"https://api.github.com/users/k-takata","html_url":"https://github.com/k-takata","followers_url":"https://api.github.com/users/k-takata/followers","following_url":"https://api.github.com/users/k-takata/following{/other_user}","gists_url":"https://api.github.com/users/k-takata/gists{/gist_id}","starred_url":"https://api.github.com/users/k-takata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k-takata/subscriptions","organizations_url":"https://api.github.com/users/k-takata/orgs","repos_url":"https://api.github.com/users/k-takata/repos","events_url":"https://api.github.com/users/k-takata/events{/privacy}","received_events_url":"https://api.github.com/users/k-takata/received_events","type":"User","site_admin":false}],"milestone":null,"comments":33,"created_at":"2018-10-01T03:06:12Z","updated_at":"2018-10-05T18:40:48Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/vim/vim/pulls/3501","html_url":"https://github.com/vim/vim/pull/3501","diff_url":"https://github.com/vim/vim/pull/3501.diff","patch_url":"https://github.com/vim/vim/pull/3501.patch"},"body":"After the discussion in #3485, I have created a new NSIS installer.\r\nThe appearance is based on @gpwen's work and also uses MUI2, but the rest of the code is based on the original (non-MUI2) NSIS script and this still relies on dosinst.c. So we don't need to maintain duplicated codes.\r\nThe items I listed at https://github.com/vim/vim/issues/3485#issuecomment-425577841 are all implemented.\r\n\r\nAnd also:\r\n* Most of the message boxes were removed like gpwen's.\r\n* The command prompt will not be shown. (`nsExec::Exec` is used instead of `ExecWait`.)\r\n* Uninstallation of the old version will be started after selecting the install location. (same as gpwen's)\r\n* The installer now remembers the selections of the user for generating `_vimrc`. (Key remap and mouse behavior.)\r\n* Unicode mode is turned on for future translation. This requires NSIS 3.0.\r\n  (gpwen's translation uses each encoding for each language. This uses UTF-8 (with BOM) for all languages.)\r\n\r\nYou can download an installer from here:\r\nhttps://ci.appveyor.com/project/k-takata/vim-win32-installer/build/175/job/jod0d3d3y9fvet3y/artifacts\r\n(No need to care about the CI status. It's just failed to push the result to GitHub releases.)\r\n\r\nEdited:\r\nYou can also download it from here:\r\nhttps://github.com/k-takata/vim-win32-installer/releases/tag/v8.1.0443-newinstaller\r\nNewer version is also avaliable in my later comment."},"comment":{"url":"https://api.github.com/repos/vim/vim/issues/comments/427461791","html_url":"https://github.com/vim/vim/pull/3501#issuecomment-427461791","issue_url":"https://api.github.com/repos/vim/vim/issues/3501","id":427461791,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzQ2MTc5MQ==","user":{"login":"chrisbra","id":244927,"node_id":"MDQ6VXNlcjI0NDkyNw==","avatar_url":"https://avatars0.githubusercontent.com/u/244927?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisbra","html_url":"https://github.com/chrisbra","followers_url":"https://api.github.com/users/chrisbra/followers","following_url":"https://api.github.com/users/chrisbra/following{/other_user}","gists_url":"https://api.github.com/users/chrisbra/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisbra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisbra/subscriptions","organizations_url":"https://api.github.com/users/chrisbra/orgs","repos_url":"https://api.github.com/users/chrisbra/repos","events_url":"https://api.github.com/users/chrisbra/events{/privacy}","received_events_url":"https://api.github.com/users/chrisbra/received_events","type":"User","site_admin":false},"created_at":"2018-10-05T18:40:48Z","updated_at":"2018-10-05T18:40:48Z","author_association":"MEMBER","body":"@chdiza okay reverted back to the old behaviour. If anybody feels differently, please open a new ticket, so we don't spam unrelated issues."}}
{"actor":{"display_login":"chrisbra"}}