{"action":"created","comment":{"url":"https://api.github.com/repos/LucasAlderfer/Battleship/pulls/comments/189447711","pull_request_review_id":121632424,"id":189447711,"diff_hunk":"@@ -36,33 +36,80 @@ def test_it_can_remember_guessed_spaces\n \n   def test_it_can_assign_ship_spaces_for_first_ship\n     gb = GameBoard.new\n-    ss = FirstShipPlacement.new('C1', 'B1').first_ship\n+    ss = FirstShipPlacement.new('C1 B1').first_ship\n     gb.place_small_ship(ss)\n     assert_equal gb.small_ship, [gb.basic_spaces[4], gb.basic_spaces[8]]\n   end\n \n-  def test_it_removes_ship_spaces_from_empty\n+  def test_it_marks_spaces_of_small_ship_full\n     gb = GameBoard.new\n-    ss = FirstShipPlacement.new('C1', 'B1').first_ship\n+    ss = FirstShipPlacement.new('C1 B1').first_ship\n+    gb.place_small_ship(ss)\n+    assert_equal true, gb.small_ship[0].fill\n+    assert_equal true, gb.small_ship[1].fill\n+  end\n+\n+  def test_it_removes_small_ship_spaces_from_empty\n+    gb = GameBoard.new\n+    ss = FirstShipPlacement.new('C1 B1').first_ship\n     gb.place_small_ship(ss)\n     assert_equal 14, gb.empty_spaces.length\n     assert_equal 2, gb.small_ship.length\n   end\n \n   def test_it_removes_correct_three_space_options\n     gb = GameBoard.new\n-    ss = FirstShipPlacement.new('C1', 'B1').first_ship\n+    ss = FirstShipPlacement.new('C1 B1').first_ship\n     gb.place_small_ship(ss)\n     assert_equal 12, gb.valid_three_space_positions.length\n   end\n \n   def test_no_overlapping_ships\n     gb = GameBoard.new\n-    fsp = FirstShipPlacement.new('A1', 'B1')\n-    ssp_1 = SecondShipPlacement.new('A1', 'C1')\n-    ssp_2 = SecondShipPlacement.new('B2', 'D2')\n+    fsp = FirstShipPlacement.new('A1 B1')\n+    ssp_1 = SecondShipPlacement.new('A1 C1')","path":"test/game_board_test.rb","position":42,"original_position":42,"commit_id":"5cbb35ff9eceab720d200a1fd04ffa149dbf3264","original_commit_id":"5cbb35ff9eceab720d200a1fd04ffa149dbf3264","user":{"login":"houndci-bot","id":6697940,"avatar_url":"https://avatars0.githubusercontent.com/u/6697940?v=4","gravatar_id":"","url":"https://api.github.com/users/houndci-bot","html_url":"https://github.com/houndci-bot","followers_url":"https://api.github.com/users/houndci-bot/followers","following_url":"https://api.github.com/users/houndci-bot/following{/other_user}","gists_url":"https://api.github.com/users/houndci-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/houndci-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/houndci-bot/subscriptions","organizations_url":"https://api.github.com/users/houndci-bot/orgs","repos_url":"https://api.github.com/users/houndci-bot/repos","events_url":"https://api.github.com/users/houndci-bot/events{/privacy}","received_events_url":"https://api.github.com/users/houndci-bot/received_events","type":"User","site_admin":false},"body":"Naming/VariableNumber: Use normalcase for variable numbers.","created_at":"2018-05-20T00:06:42Z","updated_at":"2018-05-20T00:06:44Z","html_url":"https://github.com/LucasAlderfer/Battleship/pull/3#discussion_r189447711","pull_request_url":"https://api.github.com/repos/LucasAlderfer/Battleship/pulls/3","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/LucasAlderfer/Battleship/pulls/comments/189447711"},"html":{"href":"https://github.com/LucasAlderfer/Battleship/pull/3#discussion_r189447711"},"pull_request":{"href":"https://api.github.com/repos/LucasAlderfer/Battleship/pulls/3"}}},"pull_request":{"url":"https://api.github.com/repos/LucasAlderfer/Battleship/pulls/3","id":189212423,"html_url":"https://github.com/LucasAlderfer/Battleship/pull/3","diff_url":"https://github.com/LucasAlderfer/Battleship/pull/3.diff","patch_url":"https://github.com/LucasAlderfer/Battleship/pull/3.patch","issue_url":"https://api.github.com/repos/LucasAlderfer/Battleship/issues/3","number":3,"state":"open","locked":false,"title":"Saturday Evening","user":{"login":"LucasAlderfer","id":36676968,"avatar_url":"https://avatars1.githubusercontent.com/u/36676968?v=4","gravatar_id":"","url":"https://api.github.com/users/LucasAlderfer","html_url":"https://github.com/LucasAlderfer","followers_url":"https://api.github.com/users/LucasAlderfer/followers","following_url":"https://api.github.com/users/LucasAlderfer/following{/other_user}","gists_url":"https://api.github.com/users/LucasAlderfer/gists{/gist_id}","starred_url":"https://api.github.com/users/LucasAlderfer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LucasAlderfer/subscriptions","organizations_url":"https://api.github.com/users/LucasAlderfer/orgs","repos_url":"https://api.github.com/users/LucasAlderfer/repos","events_url":"https://api.github.com/users/LucasAlderfer/events{/privacy}","received_events_url":"https://api.github.com/users/LucasAlderfer/received_events","type":"User","site_admin":false},"body":"Spaces can be hit by guessing their position, start a runner file, game can display the board, both ships can be placed on the board","created_at":"2018-05-20T00:06:31Z","updated_at":"2018-05-20T00:06:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec25fd4c2e01655484d30de1c2dffcad80e5aa4b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/LucasAlderfer/Battleship/pulls/3/commits","review_comments_url":"https://api.github.com/repos/LucasAlderfer/Battleship/pulls/3/comments","review_comment_url":"https://api.github.com/repos/LucasAlderfer/Battleship/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LucasAlderfer/Battleship/issues/3/comments","statuses_url":"https://api.github.com/repos/LucasAlderfer/Battleship/statuses/5cbb35ff9eceab720d200a1fd04ffa149dbf3264","head":{"label":"LucasAlderfer:Lucas","ref":"Lucas","sha":"5cbb35ff9eceab720d200a1fd04ffa149dbf3264","user":{"login":"LucasAlderfer","id":36676968,"avatar_url":"https://avatars1.githubusercontent.com/u/36676968?v=4","gravatar_id":"","url":"https://api.github.com/users/LucasAlderfer","html_url":"https://github.com/LucasAlderfer","followers_url":"https://api.github.com/users/LucasAlderfer/followers","following_url":"https://api.github.com/users/LucasAlderfer/following{/other_user}","gists_url":"https://api.github.com/users/LucasAlderfer/gists{/gist_id}","starred_url":"https://api.github.com/users/LucasAlderfer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LucasAlderfer/subscriptions","organizations_url":"https://api.github.com/users/LucasAlderfer/orgs","repos_url":"https://api.github.com/users/LucasAlderfer/repos","events_url":"https://api.github.com/users/LucasAlderfer/events{/privacy}","received_events_url":"https://api.github.com/users/LucasAlderfer/received_events","type":"User","site_admin":false},"repo":{"id":134079391,"name":"Battleship","full_name":"LucasAlderfer/Battleship","owner":{"login":"LucasAlderfer","id":36676968,"avatar_url":"https://avatars1.githubusercontent.com/u/36676968?v=4","gravatar_id":"","url":"https://api.github.com/users/LucasAlderfer","html_url":"https://github.com/LucasAlderfer","followers_url":"https://api.github.com/users/LucasAlderfer/followers","following_url":"https://api.github.com/users/LucasAlderfer/following{/other_user}","gists_url":"https://api.github.com/users/LucasAlderfer/gists{/gist_id}","starred_url":"https://api.github.com/users/LucasAlderfer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LucasAlderfer/subscriptions","organizations_url":"https://api.github.com/users/LucasAlderfer/orgs","repos_url":"https://api.github.com/users/LucasAlderfer/repos","events_url":"https://api.github.com/users/LucasAlderfer/events{/privacy}","received_events_url":"https://api.github.com/users/LucasAlderfer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LucasAlderfer/Battleship","description":null,"fork":false,"url":"https://api.github.com/repos/LucasAlderfer/Battleship","forks_url":"https://api.github.com/repos/LucasAlderfer/Battleship/forks","keys_url":"https://api.github.com/repos/LucasAlderfer/Battleship/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LucasAlderfer/Battleship/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LucasAlderfer/Battleship/teams","hooks_url":"https://api.github.com/repos/LucasAlderfer/Battleship/hooks","issue_events_url":"https://api.github.com/repos/LucasAlderfer/Battleship/issues/events{/number}","events_url":"https://api.github.com/repos/LucasAlderfer/Battleship/events","assignees_url":"https://api.github.com/repos/LucasAlderfer/Battleship/assignees{/user}","branches_url":"https://api.github.com/repos/LucasAlderfer/Battleship/branches{/branch}","tags_url":"https://api.github.com/repos/LucasAlderfer/Battleship/tags","blobs_url":"https://api.github.com/repos/LucasAlderfer/Battleship/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LucasAlderfer/Battleship/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LucasAlderfer/Battleship/git/refs{/sha}","trees_url":"https://api.github.com/repos/LucasAlderfer/Battleship/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LucasAlderfer/Battleship/statuses/{sha}","languages_url":"https://api.github.com/repos/LucasAlderfer/Battleship/languages","stargazers_url":"https://api.github.com/repos/LucasAlderfer/Battleship/stargazers","contributors_url":"https://api.github.com/repos/LucasAlderfer/Battleship/contributors","subscribers_url":"https://api.github.com/repos/LucasAlderfer/Battleship/subscribers","subscription_url":"https://api.github.com/repos/LucasAlderfer/Battleship/subscription","commits_url":"https://api.github.com/repos/LucasAlderfer/Battleship/commits{/sha}","git_commits_url":"https://api.github.com/repos/LucasAlderfer/Battleship/git/commits{/sha}","comments_url":"https://api.github.com/repos/LucasAlderfer/Battleship/comments{/number}","issue_comment_url":"https://api.github.com/repos/LucasAlderfer/Battleship/issues/comments{/number}","contents_url":"https://api.github.com/repos/LucasAlderfer/Battleship/contents/{+path}","compare_url":"https://api.github.com/repos/LucasAlderfer/Battleship/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LucasAlderfer/Battleship/merges","archive_url":"https://api.github.com/repos/LucasAlderfer/Battleship/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LucasAlderfer/Battleship/downloads","issues_url":"https://api.github.com/repos/LucasAlderfer/Battleship/issues{/number}","pulls_url":"https://api.github.com/repos/LucasAlderfer/Battleship/pulls{/number}","milestones_url":"https://api.github.com/repos/LucasAlderfer/Battleship/milestones{/number}","notifications_url":"https://api.github.com/repos/LucasAlderfer/Battleship/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LucasAlderfer/Battleship/labels{/name}","releases_url":"https://api.github.com/repos/LucasAlderfer/Battleship/releases{/id}","deployments_url":"https://api.github.com/repos/LucasAlderfer/Battleship/deployments","created_at":"2018-05-19T16:33:54Z","updated_at":"2018-05-19T21:18:22Z","pushed_at":"2018-05-20T00:06:32Z","git_url":"git://github.com/LucasAlderfer/Battleship.git","ssh_url":"git@github.com:LucasAlderfer/Battleship.git","clone_url":"https://github.com/LucasAlderfer/Battleship.git","svn_url":"https://github.com/LucasAlderfer/Battleship","homepage":null,"size":7,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"LucasAlderfer:master","ref":"master","sha":"208b998627c2b4ec62d6d37cbdd9361d1ee80670","user":{"login":"LucasAlderfer","id":36676968,"avatar_url":"https://avatars1.githubusercontent.com/u/36676968?v=4","gravatar_id":"","url":"https://api.github.com/users/LucasAlderfer","html_url":"https://github.com/LucasAlderfer","followers_url":"https://api.github.com/users/LucasAlderfer/followers","following_url":"https://api.github.com/users/LucasAlderfer/following{/other_user}","gists_url":"https://api.github.com/users/LucasAlderfer/gists{/gist_id}","starred_url":"https://api.github.com/users/LucasAlderfer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LucasAlderfer/subscriptions","organizations_url":"https://api.github.com/users/LucasAlderfer/orgs","repos_url":"https://api.github.com/users/LucasAlderfer/repos","events_url":"https://api.github.com/users/LucasAlderfer/events{/privacy}","received_events_url":"https://api.github.com/users/LucasAlderfer/received_events","type":"User","site_admin":false},"repo":{"id":134079391,"name":"Battleship","full_name":"LucasAlderfer/Battleship","owner":{"login":"LucasAlderfer","id":36676968,"avatar_url":"https://avatars1.githubusercontent.com/u/36676968?v=4","gravatar_id":"","url":"https://api.github.com/users/LucasAlderfer","html_url":"https://github.com/LucasAlderfer","followers_url":"https://api.github.com/users/LucasAlderfer/followers","following_url":"https://api.github.com/users/LucasAlderfer/following{/other_user}","gists_url":"https://api.github.com/users/LucasAlderfer/gists{/gist_id}","starred_url":"https://api.github.com/users/LucasAlderfer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LucasAlderfer/subscriptions","organizations_url":"https://api.github.com/users/LucasAlderfer/orgs","repos_url":"https://api.github.com/users/LucasAlderfer/repos","events_url":"https://api.github.com/users/LucasAlderfer/events{/privacy}","received_events_url":"https://api.github.com/users/LucasAlderfer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LucasAlderfer/Battleship","description":null,"fork":false,"url":"https://api.github.com/repos/LucasAlderfer/Battleship","forks_url":"https://api.github.com/repos/LucasAlderfer/Battleship/forks","keys_url":"https://api.github.com/repos/LucasAlderfer/Battleship/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LucasAlderfer/Battleship/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LucasAlderfer/Battleship/teams","hooks_url":"https://api.github.com/repos/LucasAlderfer/Battleship/hooks","issue_events_url":"https://api.github.com/repos/LucasAlderfer/Battleship/issues/events{/number}","events_url":"https://api.github.com/repos/LucasAlderfer/Battleship/events","assignees_url":"https://api.github.com/repos/LucasAlderfer/Battleship/assignees{/user}","branches_url":"https://api.github.com/repos/LucasAlderfer/Battleship/branches{/branch}","tags_url":"https://api.github.com/repos/LucasAlderfer/Battleship/tags","blobs_url":"https://api.github.com/repos/LucasAlderfer/Battleship/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LucasAlderfer/Battleship/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LucasAlderfer/Battleship/git/refs{/sha}","trees_url":"https://api.github.com/repos/LucasAlderfer/Battleship/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LucasAlderfer/Battleship/statuses/{sha}","languages_url":"https://api.github.com/repos/LucasAlderfer/Battleship/languages","stargazers_url":"https://api.github.com/repos/LucasAlderfer/Battleship/stargazers","contributors_url":"https://api.github.com/repos/LucasAlderfer/Battleship/contributors","subscribers_url":"https://api.github.com/repos/LucasAlderfer/Battleship/subscribers","subscription_url":"https://api.github.com/repos/LucasAlderfer/Battleship/subscription","commits_url":"https://api.github.com/repos/LucasAlderfer/Battleship/commits{/sha}","git_commits_url":"https://api.github.com/repos/LucasAlderfer/Battleship/git/commits{/sha}","comments_url":"https://api.github.com/repos/LucasAlderfer/Battleship/comments{/number}","issue_comment_url":"https://api.github.com/repos/LucasAlderfer/Battleship/issues/comments{/number}","contents_url":"https://api.github.com/repos/LucasAlderfer/Battleship/contents/{+path}","compare_url":"https://api.github.com/repos/LucasAlderfer/Battleship/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LucasAlderfer/Battleship/merges","archive_url":"https://api.github.com/repos/LucasAlderfer/Battleship/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LucasAlderfer/Battleship/downloads","issues_url":"https://api.github.com/repos/LucasAlderfer/Battleship/issues{/number}","pulls_url":"https://api.github.com/repos/LucasAlderfer/Battleship/pulls{/number}","milestones_url":"https://api.github.com/repos/LucasAlderfer/Battleship/milestones{/number}","notifications_url":"https://api.github.com/repos/LucasAlderfer/Battleship/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LucasAlderfer/Battleship/labels{/name}","releases_url":"https://api.github.com/repos/LucasAlderfer/Battleship/releases{/id}","deployments_url":"https://api.github.com/repos/LucasAlderfer/Battleship/deployments","created_at":"2018-05-19T16:33:54Z","updated_at":"2018-05-19T21:18:22Z","pushed_at":"2018-05-20T00:06:32Z","git_url":"git://github.com/LucasAlderfer/Battleship.git","ssh_url":"git@github.com:LucasAlderfer/Battleship.git","clone_url":"https://github.com/LucasAlderfer/Battleship.git","svn_url":"https://github.com/LucasAlderfer/Battleship","homepage":null,"size":7,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LucasAlderfer/Battleship/pulls/3"},"html":{"href":"https://github.com/LucasAlderfer/Battleship/pull/3"},"issue":{"href":"https://api.github.com/repos/LucasAlderfer/Battleship/issues/3"},"comments":{"href":"https://api.github.com/repos/LucasAlderfer/Battleship/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/LucasAlderfer/Battleship/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/LucasAlderfer/Battleship/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LucasAlderfer/Battleship/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/LucasAlderfer/Battleship/statuses/5cbb35ff9eceab720d200a1fd04ffa149dbf3264"}},"author_association":"OWNER"}}
{"actor":{"display_login":"houndci-bot"}}