{"action":"opened","issue":{"url":"https://api.github.com/repos/rails/sprockets/issues/576","repository_url":"https://api.github.com/repos/rails/sprockets","labels_url":"https://api.github.com/repos/rails/sprockets/issues/576/labels{/name}","comments_url":"https://api.github.com/repos/rails/sprockets/issues/576/comments","events_url":"https://api.github.com/repos/rails/sprockets/issues/576/events","html_url":"https://github.com/rails/sprockets/issues/576","id":360505381,"node_id":"MDU6SXNzdWUzNjA1MDUzODE=","number":576,"title":"possible update/clarification to manifest.js readme section?","user":{"login":"josh-m-sharpe","id":39473,"node_id":"MDQ6VXNlcjM5NDcz","avatar_url":"https://avatars3.githubusercontent.com/u/39473?v=4","gravatar_id":"","url":"https://api.github.com/users/josh-m-sharpe","html_url":"https://github.com/josh-m-sharpe","followers_url":"https://api.github.com/users/josh-m-sharpe/followers","following_url":"https://api.github.com/users/josh-m-sharpe/following{/other_user}","gists_url":"https://api.github.com/users/josh-m-sharpe/gists{/gist_id}","starred_url":"https://api.github.com/users/josh-m-sharpe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josh-m-sharpe/subscriptions","organizations_url":"https://api.github.com/users/josh-m-sharpe/orgs","repos_url":"https://api.github.com/users/josh-m-sharpe/repos","events_url":"https://api.github.com/users/josh-m-sharpe/events{/privacy}","received_events_url":"https://api.github.com/users/josh-m-sharpe/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-15T04:10:07Z","updated_at":"2018-09-15T04:10:07Z","closed_at":null,"author_association":"NONE","body":"Not really a bug, but some thoughts on the `manifest.js` section of the README:\r\n\r\nThe readme states: `If you've got a manifest.js file and you want to explicitly make sure an admin.js file is generated and made available to the public you can link it like this:`\r\n\r\n1) it seems that app/assets/config/manifest.js is required now.  Without it, `rake assets:precompile` fails with `Sprockets::Railtie::ManifestNeededError`.\r\n2) That said, a blank manifest.js seems to work 'just fine' - So why do we need it?\r\n3) Even with a blank manifest.js all my assets that are defined by `Rails.application.config.assets.precompile` (the way they were in sprockets 3.7.1) are both compiled and available to the public -- which doesn't seem to follow from what is stated in the README\r\n\r\n### System configuration\r\n\r\nsprockets 4.0.beta8\r\nruby 2.5.1\r\n\r\nThanks!"}}
{"actor":{"display_login":"josh-m-sharpe"}}