{"action":"created","issue":{"url":"https://api.github.com/repos/SpareBank1/designsystem/issues/123","repository_url":"https://api.github.com/repos/SpareBank1/designsystem","labels_url":"https://api.github.com/repos/SpareBank1/designsystem/issues/123/labels{/name}","comments_url":"https://api.github.com/repos/SpareBank1/designsystem/issues/123/comments","events_url":"https://api.github.com/repos/SpareBank1/designsystem/issues/123/events","html_url":"https://github.com/SpareBank1/designsystem/pull/123","id":308366440,"number":123,"title":"feat(ffe-tables): modifier to preserve whitespace","user":{"login":"ivarni","id":379849,"avatar_url":"https://avatars2.githubusercontent.com/u/379849?v=4","gravatar_id":"","url":"https://api.github.com/users/ivarni","html_url":"https://github.com/ivarni","followers_url":"https://api.github.com/users/ivarni/followers","following_url":"https://api.github.com/users/ivarni/following{/other_user}","gists_url":"https://api.github.com/users/ivarni/gists{/gist_id}","starred_url":"https://api.github.com/users/ivarni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivarni/subscriptions","organizations_url":"https://api.github.com/users/ivarni/orgs","repos_url":"https://api.github.com/users/ivarni/repos","events_url":"https://api.github.com/users/ivarni/events{/privacy}","received_events_url":"https://api.github.com/users/ivarni/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-25T17:02:58Z","updated_at":"2018-03-25T17:11:56Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/SpareBank1/designsystem/pulls/123","html_url":"https://github.com/SpareBank1/designsystem/pull/123","diff_url":"https://github.com/SpareBank1/designsystem/pull/123.diff","patch_url":"https://github.com/SpareBank1/designsystem/pull/123.patch"},"body":"Added a `--preserve-white-space` modifier to the table cell\r\nclass `ffe-table__cell`. Using this will add `white-space: pre`\r\nto the cell it's used on.\r\n\r\n<!-- \r\nThanks for opening a pull request! 🎉\r\n\r\nIf your changes include some kind of UI element, please attach a screenshot of \r\nhow it looks.\r\n\r\nBefore submitting a pull request, please have a look through the CONTRIBUTING.md\r\ndocument. TL;DR:\r\n\r\n- Follow the conventional commit standard\r\n- Write full, explanatory commit messages\r\n- Follow our code standards\r\n- Write tests where applicable\r\n- Be courteous and respect our code of conduct\r\n-->\r\n"},"comment":{"url":"https://api.github.com/repos/SpareBank1/designsystem/issues/comments/375986557","html_url":"https://github.com/SpareBank1/designsystem/pull/123#issuecomment-375986557","issue_url":"https://api.github.com/repos/SpareBank1/designsystem/issues/123","id":375986557,"user":{"login":"ivarni","id":379849,"avatar_url":"https://avatars2.githubusercontent.com/u/379849?v=4","gravatar_id":"","url":"https://api.github.com/users/ivarni","html_url":"https://github.com/ivarni","followers_url":"https://api.github.com/users/ivarni/followers","following_url":"https://api.github.com/users/ivarni/following{/other_user}","gists_url":"https://api.github.com/users/ivarni/gists{/gist_id}","starred_url":"https://api.github.com/users/ivarni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivarni/subscriptions","organizations_url":"https://api.github.com/users/ivarni/orgs","repos_url":"https://api.github.com/users/ivarni/repos","events_url":"https://api.github.com/users/ivarni/events{/privacy}","received_events_url":"https://api.github.com/users/ivarni/received_events","type":"User","site_admin":false},"created_at":"2018-03-25T17:11:56Z","updated_at":"2018-03-25T17:11:56Z","author_association":"NONE","body":"It doesn't seem like the less-modules are documentet any more so I couldn't figure out a good place to add documentation for this modifier. Normally the React component would have it but\r\n\r\n1) Nothing is currently documentet in the [styleguide](https://design.sparebank1.no/styleguidist/index.html#table) because there are no inline comments for anything in [the propTypes](https://github.com/SpareBank1/designsystem/blob/master/packages/ffe-tables-react/src/Table/Table.js#L114) and it looks like a giant scope-creep to have to document the entire component just to add a modifier in the less-package.\r\n\r\n2) I don't see how the current API of `Table` would let me selectively add a modifier to a table cell in any kind of useful way so I can't really make a corresponding change in the component that can act as documentation\r\n\r\nIf nothing else, it's going to be listed in the changelog so that's something I guess.\r\n\r\n"}}
{"actor":{"display_login":"ivarni"}}