{"action":"created","issue":{"url":"https://api.github.com/repos/bosnet/sebak/issues/389","repository_url":"https://api.github.com/repos/bosnet/sebak","labels_url":"https://api.github.com/repos/bosnet/sebak/issues/389/labels{/name}","comments_url":"https://api.github.com/repos/bosnet/sebak/issues/389/comments","events_url":"https://api.github.com/repos/bosnet/sebak/issues/389/events","html_url":"https://github.com/bosnet/sebak/pull/389","id":359976006,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MzQ1MTI2","number":389,"title":"Implement default operationBody struct(#356)","user":{"login":"soonkuk","id":24219197,"node_id":"MDQ6VXNlcjI0MjE5MTk3","avatar_url":"https://avatars0.githubusercontent.com/u/24219197?v=4","gravatar_id":"","url":"https://api.github.com/users/soonkuk","html_url":"https://github.com/soonkuk","followers_url":"https://api.github.com/users/soonkuk/followers","following_url":"https://api.github.com/users/soonkuk/following{/other_user}","gists_url":"https://api.github.com/users/soonkuk/gists{/gist_id}","starred_url":"https://api.github.com/users/soonkuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soonkuk/subscriptions","organizations_url":"https://api.github.com/users/soonkuk/orgs","repos_url":"https://api.github.com/users/soonkuk/repos","events_url":"https://api.github.com/users/soonkuk/events{/privacy}","received_events_url":"https://api.github.com/users/soonkuk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-09-13T16:41:39Z","updated_at":"2018-09-13T16:41:48Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/bosnet/sebak/pulls/389","html_url":"https://github.com/bosnet/sebak/pull/389","diff_url":"https://github.com/bosnet/sebak/pull/389.diff","patch_url":"https://github.com/bosnet/sebak/pull/389.patch"},"body":"### Github Issue\r\n<!--\r\n    Add the Github issue number if one exists, prefixed by one of Github's keywords, ex. `Fixes #1`, `Closes #1` or `Resolves #1`.\r\n-->\r\n\r\n### Background\r\nWe defined operation type for the transfer feature(`payment`, `createAccount`) until now.\r\nAnd the methods which is defined in `OperationBody` interface are `Validate()`, `IsWellFormed()`, `TargetAddress()`, `GetAmount()`.\r\nThere is a need to define more operation type increasingly.\r\nBut the methods of `OperationBody` interface isn't general for other operation type.(e.g. `operation_voting_result`, `operation_proposal` ...). However `OperationBody` implementation for voting result should have GetAmount() method to satisfy interface.\r\nIt will be good if `OperationBody` struct doesn't need to implement unnecessary methods repeatedly and use current `OperationBody` interface continually.\r\n\r\n\r\n### Solution\r\nImplement default struct about interface.\r\nThe default struct define the methods which should be generated.\r\nEach operation type inherit default struct and define the method only needed for it.\r\n\r\n### Possible Drawbacks\r\n<!--\r\n    What are the possible side-effects or negative impacts of the code change?\r\n-->\r\n"},"comment":{"url":"https://api.github.com/repos/bosnet/sebak/issues/comments/421072779","html_url":"https://github.com/bosnet/sebak/pull/389#issuecomment-421072779","issue_url":"https://api.github.com/repos/bosnet/sebak/issues/389","id":421072779,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMTA3Mjc3OQ==","user":{"login":"CLAassistant","id":11571300,"node_id":"MDQ6VXNlcjExNTcxMzAw","avatar_url":"https://avatars1.githubusercontent.com/u/11571300?v=4","gravatar_id":"","url":"https://api.github.com/users/CLAassistant","html_url":"https://github.com/CLAassistant","followers_url":"https://api.github.com/users/CLAassistant/followers","following_url":"https://api.github.com/users/CLAassistant/following{/other_user}","gists_url":"https://api.github.com/users/CLAassistant/gists{/gist_id}","starred_url":"https://api.github.com/users/CLAassistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CLAassistant/subscriptions","organizations_url":"https://api.github.com/users/CLAassistant/orgs","repos_url":"https://api.github.com/users/CLAassistant/repos","events_url":"https://api.github.com/users/CLAassistant/events{/privacy}","received_events_url":"https://api.github.com/users/CLAassistant/received_events","type":"User","site_admin":false},"created_at":"2018-09-13T16:41:47Z","updated_at":"2018-09-13T16:41:47Z","author_association":"NONE","body":"[![CLA assistant check](https://cla-assistant.io/pull/badge/not_signed)](https://cla-assistant.io/bosnet/sebak?pullRequest=389) <br/>Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our [Contributor License Agreement](https://cla-assistant.io/bosnet/sebak?pullRequest=389) before we can accept your contribution.<br/><hr/>**Soon Kuk Kang** seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please [add the email address used for this commit to your account](https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user).<br/><sub>You have signed the CLA already but the status is still pending? Let us [recheck](https://cla-assistant.io/check/bosnet/sebak?pullRequest=389) it.</sub>"}}
{"actor":{"display_login":"CLAassistant"}}