{"action":"created","comment":{"url":"https://api.github.com/repos/luna/basegl-ui/pulls/comments/226582599","pull_request_review_id":166440767,"id":226582599,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjU4MjU5OQ==","diff_hunk":"@@ -1,47 +1,78 @@\n import {ContainerComponent} from 'abstract/ContainerComponent'\n import {HtmlShape}          from 'shape/Html'\n import * as style           from 'style'\n+import {BreadcrumbArrow}    from 'view/BreadcrumbArrow'\n+import {TextContainer}      from 'view/Text'\n+import {HorizontalLayout}   from 'widget/HorizontalLayout'\n \n \n breadcrumbId = 'breadcrumbs'\n nullModuleNameError = 'No file selected'\n \n+breadcrumbHeight = 20\n+overlap = -1\n+\n export class Breadcrumb extends ContainerComponent\n     initModel: =>\n+        position: [0,0]\n+        scale: 1\n         moduleName: null\n         items: []\n \n     prepare: =>\n-        @addDef 'root', HtmlShape,\n-            element: 'div'\n-            id: breadcrumbId\n-            scalable: false\n-            still: true\n+        @addDef 'items', HorizontalLayout,\n+            height: breadcrumbHeight\n+            offset: overlap\n \n     update: =>\n         if @changed.once or @changed.items or @changed.moduleName\n-            domElem = @def('root').getDomElement()\n-            domElem.innerHTML = ''\n-            container = document.createElement 'div'\n-            container.className = style.luna ['breadcrumbs', 'noselect']\n-            @model.items[0] ?= name: nullModuleNameError\n-            if @model.items[0].name == ''\n-                @model.items[0].name = @model.moduleName\n-            @model.items.forEach (item) =>\n-                container.appendChild @__renderItem item\n-            domElem.appendChild container\n+            breadcrumbArrow =\n+                cons: BreadcrumbArrow\n+                frameColor: [@style.breadcrumb_color_r, @style.breadcrumb_color_g, @style.breadcrumb_color_b]","path":"src/view/Breadcrumb.coffee","position":46,"original_position":46,"commit_id":"54f5191bcf11ce4232065ecf70ad49b7aa4d0a92","original_commit_id":"54f5191bcf11ce4232065ecf70ad49b7aa4d0a92","user":{"login":"piotrMocz","id":3109645,"node_id":"MDQ6VXNlcjMxMDk2NDU=","avatar_url":"https://avatars3.githubusercontent.com/u/3109645?v=4","gravatar_id":"","url":"https://api.github.com/users/piotrMocz","html_url":"https://github.com/piotrMocz","followers_url":"https://api.github.com/users/piotrMocz/followers","following_url":"https://api.github.com/users/piotrMocz/following{/other_user}","gists_url":"https://api.github.com/users/piotrMocz/gists{/gist_id}","starred_url":"https://api.github.com/users/piotrMocz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piotrMocz/subscriptions","organizations_url":"https://api.github.com/users/piotrMocz/orgs","repos_url":"https://api.github.com/users/piotrMocz/repos","events_url":"https://api.github.com/users/piotrMocz/events{/privacy}","received_events_url":"https://api.github.com/users/piotrMocz/received_events","type":"User","site_admin":false},"body":"I wonder: could `@style` simply connect lists of these components, so that you could write `frameColor: @style.breadcrumbColor` instead of creating the lists yourself? The same goes for other style properties ;)","created_at":"2018-10-19T09:16:46Z","updated_at":"2018-10-19T09:21:37Z","html_url":"https://github.com/luna/basegl-ui/pull/84#discussion_r226582599","pull_request_url":"https://api.github.com/repos/luna/basegl-ui/pulls/84","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/luna/basegl-ui/pulls/comments/226582599"},"html":{"href":"https://github.com/luna/basegl-ui/pull/84#discussion_r226582599"},"pull_request":{"href":"https://api.github.com/repos/luna/basegl-ui/pulls/84"}}},"pull_request":{"url":"https://api.github.com/repos/luna/basegl-ui/pulls/84","id":223884145,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzODg0MTQ1","html_url":"https://github.com/luna/basegl-ui/pull/84","diff_url":"https://github.com/luna/basegl-ui/pull/84.diff","patch_url":"https://github.com/luna/basegl-ui/pull/84.patch","issue_url":"https://api.github.com/repos/luna/basegl-ui/issues/84","number":84,"state":"open","locked":false,"title":"Basegl breadcrumbs","user":{"login":"pmlodawski","id":5347572,"node_id":"MDQ6VXNlcjUzNDc1NzI=","avatar_url":"https://avatars0.githubusercontent.com/u/5347572?v=4","gravatar_id":"","url":"https://api.github.com/users/pmlodawski","html_url":"https://github.com/pmlodawski","followers_url":"https://api.github.com/users/pmlodawski/followers","following_url":"https://api.github.com/users/pmlodawski/following{/other_user}","gists_url":"https://api.github.com/users/pmlodawski/gists{/gist_id}","starred_url":"https://api.github.com/users/pmlodawski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmlodawski/subscriptions","organizations_url":"https://api.github.com/users/pmlodawski/orgs","repos_url":"https://api.github.com/users/pmlodawski/repos","events_url":"https://api.github.com/users/pmlodawski/events{/privacy}","received_events_url":"https://api.github.com/users/pmlodawski/received_events","type":"User","site_admin":false},"body":"This PR introduces Breadcrumbs implemented in pure basegl instead of HTML","created_at":"2018-10-18T09:26:33Z","updated_at":"2018-10-19T09:21:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7e50b601182fd38227a4bd59bbf77daa5806a8f6","assignee":{"login":"pmlodawski","id":5347572,"node_id":"MDQ6VXNlcjUzNDc1NzI=","avatar_url":"https://avatars0.githubusercontent.com/u/5347572?v=4","gravatar_id":"","url":"https://api.github.com/users/pmlodawski","html_url":"https://github.com/pmlodawski","followers_url":"https://api.github.com/users/pmlodawski/followers","following_url":"https://api.github.com/users/pmlodawski/following{/other_user}","gists_url":"https://api.github.com/users/pmlodawski/gists{/gist_id}","starred_url":"https://api.github.com/users/pmlodawski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmlodawski/subscriptions","organizations_url":"https://api.github.com/users/pmlodawski/orgs","repos_url":"https://api.github.com/users/pmlodawski/repos","events_url":"https://api.github.com/users/pmlodawski/events{/privacy}","received_events_url":"https://api.github.com/users/pmlodawski/received_events","type":"User","site_admin":false},"assignees":[{"login":"pmlodawski","id":5347572,"node_id":"MDQ6VXNlcjUzNDc1NzI=","avatar_url":"https://avatars0.githubusercontent.com/u/5347572?v=4","gravatar_id":"","url":"https://api.github.com/users/pmlodawski","html_url":"https://github.com/pmlodawski","followers_url":"https://api.github.com/users/pmlodawski/followers","following_url":"https://api.github.com/users/pmlodawski/following{/other_user}","gists_url":"https://api.github.com/users/pmlodawski/gists{/gist_id}","starred_url":"https://api.github.com/users/pmlodawski/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmlodawski/subscriptions","organizations_url":"https://api.github.com/users/pmlodawski/orgs","repos_url":"https://api.github.com/users/pmlodawski/repos","events_url":"https://api.github.com/users/pmlodawski/events{/privacy}","received_events_url":"https://api.github.com/users/pmlodawski/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"ljkania","id":7061422,"node_id":"MDQ6VXNlcjcwNjE0MjI=","avatar_url":"https://avatars0.githubusercontent.com/u/7061422?v=4","gravatar_id":"","url":"https://api.github.com/users/ljkania","html_url":"https://github.com/ljkania","followers_url":"https://api.github.com/users/ljkania/followers","following_url":"https://api.github.com/users/ljkania/following{/other_user}","gists_url":"https://api.github.com/users/ljkania/gists{/gist_id}","starred_url":"https://api.github.com/users/ljkania/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ljkania/subscriptions","organizations_url":"https://api.github.com/users/ljkania/orgs","repos_url":"https://api.github.com/users/ljkania/repos","events_url":"https://api.github.com/users/ljkania/events{/privacy}","received_events_url":"https://api.github.com/users/ljkania/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/luna/basegl-ui/pulls/84/commits","review_comments_url":"https://api.github.com/repos/luna/basegl-ui/pulls/84/comments","review_comment_url":"https://api.github.com/repos/luna/basegl-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/luna/basegl-ui/issues/84/comments","statuses_url":"https://api.github.com/repos/luna/basegl-ui/statuses/54f5191bcf11ce4232065ecf70ad49b7aa4d0a92","head":{"label":"luna:basegl-breadcrumbs","ref":"basegl-breadcrumbs","sha":"54f5191bcf11ce4232065ecf70ad49b7aa4d0a92","user":{"login":"luna","id":17415943,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NDE1OTQz","avatar_url":"https://avatars0.githubusercontent.com/u/17415943?v=4","gravatar_id":"","url":"https://api.github.com/users/luna","html_url":"https://github.com/luna","followers_url":"https://api.github.com/users/luna/followers","following_url":"https://api.github.com/users/luna/following{/other_user}","gists_url":"https://api.github.com/users/luna/gists{/gist_id}","starred_url":"https://api.github.com/users/luna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luna/subscriptions","organizations_url":"https://api.github.com/users/luna/orgs","repos_url":"https://api.github.com/users/luna/repos","events_url":"https://api.github.com/users/luna/events{/privacy}","received_events_url":"https://api.github.com/users/luna/received_events","type":"Organization","site_admin":false},"repo":{"id":124790721,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQ3OTA3MjE=","name":"basegl-ui","full_name":"luna/basegl-ui","private":false,"owner":{"login":"luna","id":17415943,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NDE1OTQz","avatar_url":"https://avatars0.githubusercontent.com/u/17415943?v=4","gravatar_id":"","url":"https://api.github.com/users/luna","html_url":"https://github.com/luna","followers_url":"https://api.github.com/users/luna/followers","following_url":"https://api.github.com/users/luna/following{/other_user}","gists_url":"https://api.github.com/users/luna/gists{/gist_id}","starred_url":"https://api.github.com/users/luna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luna/subscriptions","organizations_url":"https://api.github.com/users/luna/orgs","repos_url":"https://api.github.com/users/luna/repos","events_url":"https://api.github.com/users/luna/events{/privacy}","received_events_url":"https://api.github.com/users/luna/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/luna/basegl-ui","description":null,"fork":false,"url":"https://api.github.com/repos/luna/basegl-ui","forks_url":"https://api.github.com/repos/luna/basegl-ui/forks","keys_url":"https://api.github.com/repos/luna/basegl-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/luna/basegl-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/luna/basegl-ui/teams","hooks_url":"https://api.github.com/repos/luna/basegl-ui/hooks","issue_events_url":"https://api.github.com/repos/luna/basegl-ui/issues/events{/number}","events_url":"https://api.github.com/repos/luna/basegl-ui/events","assignees_url":"https://api.github.com/repos/luna/basegl-ui/assignees{/user}","branches_url":"https://api.github.com/repos/luna/basegl-ui/branches{/branch}","tags_url":"https://api.github.com/repos/luna/basegl-ui/tags","blobs_url":"https://api.github.com/repos/luna/basegl-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/luna/basegl-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/luna/basegl-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/luna/basegl-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/luna/basegl-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/luna/basegl-ui/languages","stargazers_url":"https://api.github.com/repos/luna/basegl-ui/stargazers","contributors_url":"https://api.github.com/repos/luna/basegl-ui/contributors","subscribers_url":"https://api.github.com/repos/luna/basegl-ui/subscribers","subscription_url":"https://api.github.com/repos/luna/basegl-ui/subscription","commits_url":"https://api.github.com/repos/luna/basegl-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/luna/basegl-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/luna/basegl-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/luna/basegl-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/luna/basegl-ui/contents/{+path}","compare_url":"https://api.github.com/repos/luna/basegl-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/luna/basegl-ui/merges","archive_url":"https://api.github.com/repos/luna/basegl-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/luna/basegl-ui/downloads","issues_url":"https://api.github.com/repos/luna/basegl-ui/issues{/number}","pulls_url":"https://api.github.com/repos/luna/basegl-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/luna/basegl-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/luna/basegl-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/luna/basegl-ui/labels{/name}","releases_url":"https://api.github.com/repos/luna/basegl-ui/releases{/id}","deployments_url":"https://api.github.com/repos/luna/basegl-ui/deployments","created_at":"2018-03-11T19:26:40Z","updated_at":"2018-10-18T10:59:28Z","pushed_at":"2018-10-18T10:59:26Z","git_url":"git://github.com/luna/basegl-ui.git","ssh_url":"git@github.com:luna/basegl-ui.git","clone_url":"https://github.com/luna/basegl-ui.git","svn_url":"https://github.com/luna/basegl-ui","homepage":null,"size":2501,"stargazers_count":2,"watchers_count":2,"language":"CoffeeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":43,"license":null,"forks":0,"open_issues":43,"watchers":2,"default_branch":"master"}},"base":{"label":"luna:master","ref":"master","sha":"b766032cb94582f6c28347097fc56d4c10d4c375","user":{"login":"luna","id":17415943,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NDE1OTQz","avatar_url":"https://avatars0.githubusercontent.com/u/17415943?v=4","gravatar_id":"","url":"https://api.github.com/users/luna","html_url":"https://github.com/luna","followers_url":"https://api.github.com/users/luna/followers","following_url":"https://api.github.com/users/luna/following{/other_user}","gists_url":"https://api.github.com/users/luna/gists{/gist_id}","starred_url":"https://api.github.com/users/luna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luna/subscriptions","organizations_url":"https://api.github.com/users/luna/orgs","repos_url":"https://api.github.com/users/luna/repos","events_url":"https://api.github.com/users/luna/events{/privacy}","received_events_url":"https://api.github.com/users/luna/received_events","type":"Organization","site_admin":false},"repo":{"id":124790721,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQ3OTA3MjE=","name":"basegl-ui","full_name":"luna/basegl-ui","private":false,"owner":{"login":"luna","id":17415943,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NDE1OTQz","avatar_url":"https://avatars0.githubusercontent.com/u/17415943?v=4","gravatar_id":"","url":"https://api.github.com/users/luna","html_url":"https://github.com/luna","followers_url":"https://api.github.com/users/luna/followers","following_url":"https://api.github.com/users/luna/following{/other_user}","gists_url":"https://api.github.com/users/luna/gists{/gist_id}","starred_url":"https://api.github.com/users/luna/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/luna/subscriptions","organizations_url":"https://api.github.com/users/luna/orgs","repos_url":"https://api.github.com/users/luna/repos","events_url":"https://api.github.com/users/luna/events{/privacy}","received_events_url":"https://api.github.com/users/luna/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/luna/basegl-ui","description":null,"fork":false,"url":"https://api.github.com/repos/luna/basegl-ui","forks_url":"https://api.github.com/repos/luna/basegl-ui/forks","keys_url":"https://api.github.com/repos/luna/basegl-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/luna/basegl-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/luna/basegl-ui/teams","hooks_url":"https://api.github.com/repos/luna/basegl-ui/hooks","issue_events_url":"https://api.github.com/repos/luna/basegl-ui/issues/events{/number}","events_url":"https://api.github.com/repos/luna/basegl-ui/events","assignees_url":"https://api.github.com/repos/luna/basegl-ui/assignees{/user}","branches_url":"https://api.github.com/repos/luna/basegl-ui/branches{/branch}","tags_url":"https://api.github.com/repos/luna/basegl-ui/tags","blobs_url":"https://api.github.com/repos/luna/basegl-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/luna/basegl-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/luna/basegl-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/luna/basegl-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/luna/basegl-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/luna/basegl-ui/languages","stargazers_url":"https://api.github.com/repos/luna/basegl-ui/stargazers","contributors_url":"https://api.github.com/repos/luna/basegl-ui/contributors","subscribers_url":"https://api.github.com/repos/luna/basegl-ui/subscribers","subscription_url":"https://api.github.com/repos/luna/basegl-ui/subscription","commits_url":"https://api.github.com/repos/luna/basegl-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/luna/basegl-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/luna/basegl-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/luna/basegl-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/luna/basegl-ui/contents/{+path}","compare_url":"https://api.github.com/repos/luna/basegl-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/luna/basegl-ui/merges","archive_url":"https://api.github.com/repos/luna/basegl-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/luna/basegl-ui/downloads","issues_url":"https://api.github.com/repos/luna/basegl-ui/issues{/number}","pulls_url":"https://api.github.com/repos/luna/basegl-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/luna/basegl-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/luna/basegl-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/luna/basegl-ui/labels{/name}","releases_url":"https://api.github.com/repos/luna/basegl-ui/releases{/id}","deployments_url":"https://api.github.com/repos/luna/basegl-ui/deployments","created_at":"2018-03-11T19:26:40Z","updated_at":"2018-10-18T10:59:28Z","pushed_at":"2018-10-18T10:59:26Z","git_url":"git://github.com/luna/basegl-ui.git","ssh_url":"git@github.com:luna/basegl-ui.git","clone_url":"https://github.com/luna/basegl-ui.git","svn_url":"https://github.com/luna/basegl-ui","homepage":null,"size":2501,"stargazers_count":2,"watchers_count":2,"language":"CoffeeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":43,"license":null,"forks":0,"open_issues":43,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/luna/basegl-ui/pulls/84"},"html":{"href":"https://github.com/luna/basegl-ui/pull/84"},"issue":{"href":"https://api.github.com/repos/luna/basegl-ui/issues/84"},"comments":{"href":"https://api.github.com/repos/luna/basegl-ui/issues/84/comments"},"review_comments":{"href":"https://api.github.com/repos/luna/basegl-ui/pulls/84/comments"},"review_comment":{"href":"https://api.github.com/repos/luna/basegl-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/luna/basegl-ui/pulls/84/commits"},"statuses":{"href":"https://api.github.com/repos/luna/basegl-ui/statuses/54f5191bcf11ce4232065ecf70ad49b7aa4d0a92"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"piotrMocz"}}