{"action":"created","issue":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/7589","repository_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android","labels_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/7589/labels{/name}","comments_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/7589/comments","events_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/7589/events","html_url":"https://github.com/wordpress-mobile/WordPress-Android/pull/7589","id":311001421,"number":7589,"title":"Issue/7579 featured image confirmation","user":{"login":"nbradbury","id":3903757,"avatar_url":"https://avatars2.githubusercontent.com/u/3903757?v=4","gravatar_id":"","url":"https://api.github.com/users/nbradbury","html_url":"https://github.com/nbradbury","followers_url":"https://api.github.com/users/nbradbury/followers","following_url":"https://api.github.com/users/nbradbury/following{/other_user}","gists_url":"https://api.github.com/users/nbradbury/gists{/gist_id}","starred_url":"https://api.github.com/users/nbradbury/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nbradbury/subscriptions","organizations_url":"https://api.github.com/users/nbradbury/orgs","repos_url":"https://api.github.com/users/nbradbury/repos","events_url":"https://api.github.com/users/nbradbury/events{/privacy}","received_events_url":"https://api.github.com/users/nbradbury/received_events","type":"User","site_admin":false},"labels":[{"id":114455495,"url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/labels/Media","name":"Media","color":"006b75","default":false}],"state":"open","locked":false,"assignee":{"login":"hypest","id":1032913,"avatar_url":"https://avatars1.githubusercontent.com/u/1032913?v=4","gravatar_id":"","url":"https://api.github.com/users/hypest","html_url":"https://github.com/hypest","followers_url":"https://api.github.com/users/hypest/followers","following_url":"https://api.github.com/users/hypest/following{/other_user}","gists_url":"https://api.github.com/users/hypest/gists{/gist_id}","starred_url":"https://api.github.com/users/hypest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hypest/subscriptions","organizations_url":"https://api.github.com/users/hypest/orgs","repos_url":"https://api.github.com/users/hypest/repos","events_url":"https://api.github.com/users/hypest/events{/privacy}","received_events_url":"https://api.github.com/users/hypest/received_events","type":"User","site_admin":false},"assignees":[{"login":"hypest","id":1032913,"avatar_url":"https://avatars1.githubusercontent.com/u/1032913?v=4","gravatar_id":"","url":"https://api.github.com/users/hypest","html_url":"https://github.com/hypest","followers_url":"https://api.github.com/users/hypest/followers","following_url":"https://api.github.com/users/hypest/following{/other_user}","gists_url":"https://api.github.com/users/hypest/gists{/gist_id}","starred_url":"https://api.github.com/users/hypest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hypest/subscriptions","organizations_url":"https://api.github.com/users/hypest/orgs","repos_url":"https://api.github.com/users/hypest/repos","events_url":"https://api.github.com/users/hypest/events{/privacy}","received_events_url":"https://api.github.com/users/hypest/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2018-04-03T21:15:06Z","updated_at":"2018-04-13T16:07:14Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/pulls/7589","html_url":"https://github.com/wordpress-mobile/WordPress-Android/pull/7589","diff_url":"https://github.com/wordpress-mobile/WordPress-Android/pull/7589.diff","patch_url":"https://github.com/wordpress-mobile/WordPress-Android/pull/7589.patch"},"body":"Fixes #7579 - This PR is a refactoring of the device photo picker, which previously treated tapping a photo as an immediate selection. For example, if the user was choosing a featured image, simply tapping a photo would immediately upload it and set it as the featured image. This was inconsistent with how selection works in the new stock photo picker, plus it was simply annoying because users shouldn't expect a simple tap to result in uploading, etc.\r\n\r\nSo, this PR adds a confirmation step (via the CAB) so the user has a chance to approve the selection before anything gets uploaded.\r\n\r\nTo test, open a post in the editor and set a featured image, or tap the gravator on the Me page to select a new gravatar image.\r\n\r\n![single photo picker](https://user-images.githubusercontent.com/3903757/38275789-07dbfd4c-3761-11e8-8f0f-4878180d98bd.gif)\r\n"},"comment":{"url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/comments/381183880","html_url":"https://github.com/wordpress-mobile/WordPress-Android/pull/7589#issuecomment-381183880","issue_url":"https://api.github.com/repos/wordpress-mobile/WordPress-Android/issues/7589","id":381183880,"user":{"login":"nbradbury","id":3903757,"avatar_url":"https://avatars2.githubusercontent.com/u/3903757?v=4","gravatar_id":"","url":"https://api.github.com/users/nbradbury","html_url":"https://github.com/nbradbury","followers_url":"https://api.github.com/users/nbradbury/followers","following_url":"https://api.github.com/users/nbradbury/following{/other_user}","gists_url":"https://api.github.com/users/nbradbury/gists{/gist_id}","starred_url":"https://api.github.com/users/nbradbury/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nbradbury/subscriptions","organizations_url":"https://api.github.com/users/nbradbury/orgs","repos_url":"https://api.github.com/users/nbradbury/repos","events_url":"https://api.github.com/users/nbradbury/events{/privacy}","received_events_url":"https://api.github.com/users/nbradbury/received_events","type":"User","site_admin":false},"created_at":"2018-04-13T16:07:14Z","updated_at":"2018-04-13T16:07:14Z","author_association":"CONTRIBUTOR","body":"> It seems that on rotation the selected item is preserved, but the 'selected' mode is not: the \"checkmark\" CAB action is lost and the bottom bar is still visible.\r\n\r\nFixed in 312eb28.\r\n\r\n> when a thumbnail gets deselected, its bubble icon animates OK but the icon itself is depicted as deselected\r\n\r\nFixed in 57b4397.\r\n\r\n"}}
{"actor":{"display_login":"nbradbury"}}