{"action":"created","comment":{"url":"https://api.github.com/repos/EasyRPG/liblcf/pulls/comments/221929979","pull_request_review_id":160694450,"id":221929979,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTkyOTk3OQ==","diff_hunk":"@@ -89,9 +89,9 @@ namespace RPG {\n \t\tint32_t special_lateral_party = 10;\n \t\tint32_t special_lateral_enemies = 5;\n \t\tint32_t grid_location = 0;\n-\t\tint32_t grid_a = 0;\n-\t\tint32_t grid_b = 0;\n-\t\tint32_t grid_c = 0;\n+\t\tint32_t grid_a = 120;\n+\t\tint32_t grid_b = 392;\n+\t\tint32_t grid_c = 16000;","path":"src/generated/rpg_terrain.h","position":63,"original_position":9,"commit_id":"7ca897e1b28182e7a826f8428f22be1266e8aa8b","original_commit_id":"dca9a6bf8cc4e5067b19352479268014e17ac79f","user":{"login":"Ghabry","id":1331889,"node_id":"MDQ6VXNlcjEzMzE4ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/1331889?v=4","gravatar_id":"","url":"https://api.github.com/users/Ghabry","html_url":"https://github.com/Ghabry","followers_url":"https://api.github.com/users/Ghabry/followers","following_url":"https://api.github.com/users/Ghabry/following{/other_user}","gists_url":"https://api.github.com/users/Ghabry/gists{/gist_id}","starred_url":"https://api.github.com/users/Ghabry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ghabry/subscriptions","organizations_url":"https://api.github.com/users/Ghabry/orgs","repos_url":"https://api.github.com/users/Ghabry/repos","events_url":"https://api.github.com/users/Ghabry/events{/privacy}","received_events_url":"https://api.github.com/users/Ghabry/received_events","type":"User","site_admin":false},"body":"Intersting, this could fix battle issues we have in some RPG2k3 games! (all party members overlapping)","created_at":"2018-10-02T12:28:34Z","updated_at":"2018-10-02T12:28:34Z","html_url":"https://github.com/EasyRPG/liblcf/pull/242#discussion_r221929979","pull_request_url":"https://api.github.com/repos/EasyRPG/liblcf/pulls/242","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/EasyRPG/liblcf/pulls/comments/221929979"},"html":{"href":"https://github.com/EasyRPG/liblcf/pull/242#discussion_r221929979"},"pull_request":{"href":"https://api.github.com/repos/EasyRPG/liblcf/pulls/242"}}},"pull_request":{"url":"https://api.github.com/repos/EasyRPG/liblcf/pulls/242","id":219183908,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MTgzOTA4","html_url":"https://github.com/EasyRPG/liblcf/pull/242","diff_url":"https://github.com/EasyRPG/liblcf/pull/242.diff","patch_url":"https://github.com/EasyRPG/liblcf/pull/242.patch","issue_url":"https://api.github.com/repos/EasyRPG/liblcf/issues/242","number":242,"state":"open","locked":false,"title":"Support bit perfect reading and writing of RPG_RT.ldb","user":{"login":"fmatthew5876","id":1198466,"node_id":"MDQ6VXNlcjExOTg0NjY=","avatar_url":"https://avatars1.githubusercontent.com/u/1198466?v=4","gravatar_id":"","url":"https://api.github.com/users/fmatthew5876","html_url":"https://github.com/fmatthew5876","followers_url":"https://api.github.com/users/fmatthew5876/followers","following_url":"https://api.github.com/users/fmatthew5876/following{/other_user}","gists_url":"https://api.github.com/users/fmatthew5876/gists{/gist_id}","starred_url":"https://api.github.com/users/fmatthew5876/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fmatthew5876/subscriptions","organizations_url":"https://api.github.com/users/fmatthew5876/orgs","repos_url":"https://api.github.com/users/fmatthew5876/repos","events_url":"https://api.github.com/users/fmatthew5876/events{/privacy}","received_events_url":"https://api.github.com/users/fmatthew5876/received_events","type":"User","site_admin":false},"body":"This series of changes supports bitperfect reading and writing of RPG_RT.ldb binary databases. It supports 2k and 2k3 mode.\r\n\r\nCloses out issues #234 and #229.\r\n\r\nThis one depends on all my other PR's.\r\n\r\nI've tested it with the following:\r\n* An empty 2k3 database\r\n* The default New project database for 2k3\r\n* An empty 2k database\r\n* The default new project database for 2k\r\n* HH3 (2k game ~ 16MB RPG_RT.ldb)\r\n\r\nPlease if anyone has time. Checkout this branch, download some rm2k/rm2k3 games and test it against their databases. Let me know if any game doesn't come through perfectly.","created_at":"2018-09-30T04:17:37Z","updated_at":"2018-10-02T12:28:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cb9f52d347d56eae56ef9082ecf6e8cef404b5f0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":84676502,"node_id":"MDU6TGFiZWw4NDY3NjUwMg==","url":"https://api.github.com/repos/EasyRPG/liblcf/labels/Chunks","name":"Chunks","color":"e11d21","default":false},{"id":717180056,"node_id":"MDU6TGFiZWw3MTcxODAwNTY=","url":"https://api.github.com/repos/EasyRPG/liblcf/labels/Refactor","name":"Refactor","color":"fbca04","default":false}],"milestone":{"url":"https://api.github.com/repos/EasyRPG/liblcf/milestones/7","html_url":"https://github.com/EasyRPG/liblcf/milestone/7","labels_url":"https://api.github.com/repos/EasyRPG/liblcf/milestones/7/labels","id":2068416,"node_id":"MDk6TWlsZXN0b25lMjA2ODQxNg==","number":7,"title":"0.6.0","description":"","creator":{"login":"fdelapena","id":174885,"node_id":"MDQ6VXNlcjE3NDg4NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/174885?v=4","gravatar_id":"","url":"https://api.github.com/users/fdelapena","html_url":"https://github.com/fdelapena","followers_url":"https://api.github.com/users/fdelapena/followers","following_url":"https://api.github.com/users/fdelapena/following{/other_user}","gists_url":"https://api.github.com/users/fdelapena/gists{/gist_id}","starred_url":"https://api.github.com/users/fdelapena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fdelapena/subscriptions","organizations_url":"https://api.github.com/users/fdelapena/orgs","repos_url":"https://api.github.com/users/fdelapena/repos","events_url":"https://api.github.com/users/fdelapena/events{/privacy}","received_events_url":"https://api.github.com/users/fdelapena/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":0,"state":"open","created_at":"2016-10-13T17:06:19Z","updated_at":"2018-10-01T14:44:09Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/EasyRPG/liblcf/pulls/242/commits","review_comments_url":"https://api.github.com/repos/EasyRPG/liblcf/pulls/242/comments","review_comment_url":"https://api.github.com/repos/EasyRPG/liblcf/pulls/comments{/number}","comments_url":"https://api.github.com/repos/EasyRPG/liblcf/issues/242/comments","statuses_url":"https://api.github.com/repos/EasyRPG/liblcf/statuses/7ca897e1b28182e7a826f8428f22be1266e8aa8b","head":{"label":"fmatthew5876:ldb_enums2","ref":"ldb_enums2","sha":"7ca897e1b28182e7a826f8428f22be1266e8aa8b","user":{"login":"fmatthew5876","id":1198466,"node_id":"MDQ6VXNlcjExOTg0NjY=","avatar_url":"https://avatars1.githubusercontent.com/u/1198466?v=4","gravatar_id":"","url":"https://api.github.com/users/fmatthew5876","html_url":"https://github.com/fmatthew5876","followers_url":"https://api.github.com/users/fmatthew5876/followers","following_url":"https://api.github.com/users/fmatthew5876/following{/other_user}","gists_url":"https://api.github.com/users/fmatthew5876/gists{/gist_id}","starred_url":"https://api.github.com/users/fmatthew5876/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fmatthew5876/subscriptions","organizations_url":"https://api.github.com/users/fmatthew5876/orgs","repos_url":"https://api.github.com/users/fmatthew5876/repos","events_url":"https://api.github.com/users/fmatthew5876/events{/privacy}","received_events_url":"https://api.github.com/users/fmatthew5876/received_events","type":"User","site_admin":false},"repo":{"id":142932831,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI5MzI4MzE=","name":"liblcf","full_name":"fmatthew5876/liblcf","private":false,"owner":{"login":"fmatthew5876","id":1198466,"node_id":"MDQ6VXNlcjExOTg0NjY=","avatar_url":"https://avatars1.githubusercontent.com/u/1198466?v=4","gravatar_id":"","url":"https://api.github.com/users/fmatthew5876","html_url":"https://github.com/fmatthew5876","followers_url":"https://api.github.com/users/fmatthew5876/followers","following_url":"https://api.github.com/users/fmatthew5876/following{/other_user}","gists_url":"https://api.github.com/users/fmatthew5876/gists{/gist_id}","starred_url":"https://api.github.com/users/fmatthew5876/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fmatthew5876/subscriptions","organizations_url":"https://api.github.com/users/fmatthew5876/orgs","repos_url":"https://api.github.com/users/fmatthew5876/repos","events_url":"https://api.github.com/users/fmatthew5876/events{/privacy}","received_events_url":"https://api.github.com/users/fmatthew5876/received_events","type":"User","site_admin":false},"html_url":"https://github.com/fmatthew5876/liblcf","description":"Library to handle RPG Maker 2000/2003 and EasyRPG projects","fork":true,"url":"https://api.github.com/repos/fmatthew5876/liblcf","forks_url":"https://api.github.com/repos/fmatthew5876/liblcf/forks","keys_url":"https://api.github.com/repos/fmatthew5876/liblcf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fmatthew5876/liblcf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fmatthew5876/liblcf/teams","hooks_url":"https://api.github.com/repos/fmatthew5876/liblcf/hooks","issue_events_url":"https://api.github.com/repos/fmatthew5876/liblcf/issues/events{/number}","events_url":"https://api.github.com/repos/fmatthew5876/liblcf/events","assignees_url":"https://api.github.com/repos/fmatthew5876/liblcf/assignees{/user}","branches_url":"https://api.github.com/repos/fmatthew5876/liblcf/branches{/branch}","tags_url":"https://api.github.com/repos/fmatthew5876/liblcf/tags","blobs_url":"https://api.github.com/repos/fmatthew5876/liblcf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fmatthew5876/liblcf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fmatthew5876/liblcf/git/refs{/sha}","trees_url":"https://api.github.com/repos/fmatthew5876/liblcf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fmatthew5876/liblcf/statuses/{sha}","languages_url":"https://api.github.com/repos/fmatthew5876/liblcf/languages","stargazers_url":"https://api.github.com/repos/fmatthew5876/liblcf/stargazers","contributors_url":"https://api.github.com/repos/fmatthew5876/liblcf/contributors","subscribers_url":"https://api.github.com/repos/fmatthew5876/liblcf/subscribers","subscription_url":"https://api.github.com/repos/fmatthew5876/liblcf/subscription","commits_url":"https://api.github.com/repos/fmatthew5876/liblcf/commits{/sha}","git_commits_url":"https://api.github.com/repos/fmatthew5876/liblcf/git/commits{/sha}","comments_url":"https://api.github.com/repos/fmatthew5876/liblcf/comments{/number}","issue_comment_url":"https://api.github.com/repos/fmatthew5876/liblcf/issues/comments{/number}","contents_url":"https://api.github.com/repos/fmatthew5876/liblcf/contents/{+path}","compare_url":"https://api.github.com/repos/fmatthew5876/liblcf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fmatthew5876/liblcf/merges","archive_url":"https://api.github.com/repos/fmatthew5876/liblcf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fmatthew5876/liblcf/downloads","issues_url":"https://api.github.com/repos/fmatthew5876/liblcf/issues{/number}","pulls_url":"https://api.github.com/repos/fmatthew5876/liblcf/pulls{/number}","milestones_url":"https://api.github.com/repos/fmatthew5876/liblcf/milestones{/number}","notifications_url":"https://api.github.com/repos/fmatthew5876/liblcf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fmatthew5876/liblcf/labels{/name}","releases_url":"https://api.github.com/repos/fmatthew5876/liblcf/releases{/id}","deployments_url":"https://api.github.com/repos/fmatthew5876/liblcf/deployments","created_at":"2018-07-30T22:05:31Z","updated_at":"2018-09-30T12:59:00Z","pushed_at":"2018-10-02T02:59:23Z","git_url":"git://github.com/fmatthew5876/liblcf.git","ssh_url":"git@github.com:fmatthew5876/liblcf.git","clone_url":"https://github.com/fmatthew5876/liblcf.git","svn_url":"https://github.com/fmatthew5876/liblcf","homepage":"https://easyrpg.org","size":2504,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"EasyRPG:master","ref":"master","sha":"9f0d390b3fa84100649ee7391bd305b9f870b205","user":{"login":"EasyRPG","id":1331871,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzE4NzE=","avatar_url":"https://avatars0.githubusercontent.com/u/1331871?v=4","gravatar_id":"","url":"https://api.github.com/users/EasyRPG","html_url":"https://github.com/EasyRPG","followers_url":"https://api.github.com/users/EasyRPG/followers","following_url":"https://api.github.com/users/EasyRPG/following{/other_user}","gists_url":"https://api.github.com/users/EasyRPG/gists{/gist_id}","starred_url":"https://api.github.com/users/EasyRPG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EasyRPG/subscriptions","organizations_url":"https://api.github.com/users/EasyRPG/orgs","repos_url":"https://api.github.com/users/EasyRPG/repos","events_url":"https://api.github.com/users/EasyRPG/events{/privacy}","received_events_url":"https://api.github.com/users/EasyRPG/received_events","type":"Organization","site_admin":false},"repo":{"id":3264627,"node_id":"MDEwOlJlcG9zaXRvcnkzMjY0NjI3","name":"liblcf","full_name":"EasyRPG/liblcf","private":false,"owner":{"login":"EasyRPG","id":1331871,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzE4NzE=","avatar_url":"https://avatars0.githubusercontent.com/u/1331871?v=4","gravatar_id":"","url":"https://api.github.com/users/EasyRPG","html_url":"https://github.com/EasyRPG","followers_url":"https://api.github.com/users/EasyRPG/followers","following_url":"https://api.github.com/users/EasyRPG/following{/other_user}","gists_url":"https://api.github.com/users/EasyRPG/gists{/gist_id}","starred_url":"https://api.github.com/users/EasyRPG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EasyRPG/subscriptions","organizations_url":"https://api.github.com/users/EasyRPG/orgs","repos_url":"https://api.github.com/users/EasyRPG/repos","events_url":"https://api.github.com/users/EasyRPG/events{/privacy}","received_events_url":"https://api.github.com/users/EasyRPG/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/EasyRPG/liblcf","description":"Library to handle RPG Maker 2000/2003 and EasyRPG projects","fork":false,"url":"https://api.github.com/repos/EasyRPG/liblcf","forks_url":"https://api.github.com/repos/EasyRPG/liblcf/forks","keys_url":"https://api.github.com/repos/EasyRPG/liblcf/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EasyRPG/liblcf/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EasyRPG/liblcf/teams","hooks_url":"https://api.github.com/repos/EasyRPG/liblcf/hooks","issue_events_url":"https://api.github.com/repos/EasyRPG/liblcf/issues/events{/number}","events_url":"https://api.github.com/repos/EasyRPG/liblcf/events","assignees_url":"https://api.github.com/repos/EasyRPG/liblcf/assignees{/user}","branches_url":"https://api.github.com/repos/EasyRPG/liblcf/branches{/branch}","tags_url":"https://api.github.com/repos/EasyRPG/liblcf/tags","blobs_url":"https://api.github.com/repos/EasyRPG/liblcf/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EasyRPG/liblcf/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EasyRPG/liblcf/git/refs{/sha}","trees_url":"https://api.github.com/repos/EasyRPG/liblcf/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EasyRPG/liblcf/statuses/{sha}","languages_url":"https://api.github.com/repos/EasyRPG/liblcf/languages","stargazers_url":"https://api.github.com/repos/EasyRPG/liblcf/stargazers","contributors_url":"https://api.github.com/repos/EasyRPG/liblcf/contributors","subscribers_url":"https://api.github.com/repos/EasyRPG/liblcf/subscribers","subscription_url":"https://api.github.com/repos/EasyRPG/liblcf/subscription","commits_url":"https://api.github.com/repos/EasyRPG/liblcf/commits{/sha}","git_commits_url":"https://api.github.com/repos/EasyRPG/liblcf/git/commits{/sha}","comments_url":"https://api.github.com/repos/EasyRPG/liblcf/comments{/number}","issue_comment_url":"https://api.github.com/repos/EasyRPG/liblcf/issues/comments{/number}","contents_url":"https://api.github.com/repos/EasyRPG/liblcf/contents/{+path}","compare_url":"https://api.github.com/repos/EasyRPG/liblcf/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EasyRPG/liblcf/merges","archive_url":"https://api.github.com/repos/EasyRPG/liblcf/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EasyRPG/liblcf/downloads","issues_url":"https://api.github.com/repos/EasyRPG/liblcf/issues{/number}","pulls_url":"https://api.github.com/repos/EasyRPG/liblcf/pulls{/number}","milestones_url":"https://api.github.com/repos/EasyRPG/liblcf/milestones{/number}","notifications_url":"https://api.github.com/repos/EasyRPG/liblcf/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EasyRPG/liblcf/labels{/name}","releases_url":"https://api.github.com/repos/EasyRPG/liblcf/releases{/id}","deployments_url":"https://api.github.com/repos/EasyRPG/liblcf/deployments","created_at":"2012-01-25T12:34:11Z","updated_at":"2018-09-30T12:51:22Z","pushed_at":"2018-10-02T02:59:25Z","git_url":"git://github.com/EasyRPG/liblcf.git","ssh_url":"git@github.com:EasyRPG/liblcf.git","clone_url":"https://github.com/EasyRPG/liblcf.git","svn_url":"https://github.com/EasyRPG/liblcf","homepage":"https://easyrpg.org","size":2404,"stargazers_count":42,"watchers_count":42,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":31,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":31,"open_issues":22,"watchers":42,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/EasyRPG/liblcf/pulls/242"},"html":{"href":"https://github.com/EasyRPG/liblcf/pull/242"},"issue":{"href":"https://api.github.com/repos/EasyRPG/liblcf/issues/242"},"comments":{"href":"https://api.github.com/repos/EasyRPG/liblcf/issues/242/comments"},"review_comments":{"href":"https://api.github.com/repos/EasyRPG/liblcf/pulls/242/comments"},"review_comment":{"href":"https://api.github.com/repos/EasyRPG/liblcf/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/EasyRPG/liblcf/pulls/242/commits"},"statuses":{"href":"https://api.github.com/repos/EasyRPG/liblcf/statuses/7ca897e1b28182e7a826f8428f22be1266e8aa8b"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Ghabry"}}