{"action":"created","comment":{"url":"https://api.github.com/repos/ProseMirror/prosemirror-tables/pulls/comments/217932274","pull_request_review_id":155762303,"id":217932274,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzkzMjI3NA==","diff_hunk":"@@ -249,6 +249,27 @@ function isCellBoundarySelection({$from, $to}) {\n   return afterFrom == beforeTo && /row|table/.test($from.node(depth).type.spec.tableRole)\n }\n \n+function isTextSelectionAcrossCells({$from, $to}) {\n+  let fromCellBoundaryNode;\n+  let toCellBoundaryNode;\n+\n+  for (let i = $from.depth; i > 0; i--) {\n+    let node = $from.node(i);\n+    if (node.type.spec.tableRole === 'cell' || node.type.spec.tableRole === 'header_cell') {\n+      fromCellBoundaryNode = node;","path":"src/cellselection.js","position":11,"original_position":11,"commit_id":"a282d57620b812a6a41ac9ace69e0c62c006e0a7","original_commit_id":"a282d57620b812a6a41ac9ace69e0c62c006e0a7","user":{"login":"eshvedai","id":26512812,"node_id":"MDQ6VXNlcjI2NTEyODEy","avatar_url":"https://avatars0.githubusercontent.com/u/26512812?v=4","gravatar_id":"","url":"https://api.github.com/users/eshvedai","html_url":"https://github.com/eshvedai","followers_url":"https://api.github.com/users/eshvedai/followers","following_url":"https://api.github.com/users/eshvedai/following{/other_user}","gists_url":"https://api.github.com/users/eshvedai/gists{/gist_id}","starred_url":"https://api.github.com/users/eshvedai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eshvedai/subscriptions","organizations_url":"https://api.github.com/users/eshvedai/orgs","repos_url":"https://api.github.com/users/eshvedai/repos","events_url":"https://api.github.com/users/eshvedai/events{/privacy}","received_events_url":"https://api.github.com/users/eshvedai/received_events","type":"User","site_admin":false},"body":"you could probably `break` the loop here","created_at":"2018-09-16T23:36:14Z","updated_at":"2018-09-16T23:37:30Z","html_url":"https://github.com/ProseMirror/prosemirror-tables/pull/61#discussion_r217932274","pull_request_url":"https://api.github.com/repos/ProseMirror/prosemirror-tables/pulls/61","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ProseMirror/prosemirror-tables/pulls/comments/217932274"},"html":{"href":"https://github.com/ProseMirror/prosemirror-tables/pull/61#discussion_r217932274"},"pull_request":{"href":"https://api.github.com/repos/ProseMirror/prosemirror-tables/pulls/61"}}},"pull_request":{"url":"https://api.github.com/repos/ProseMirror/prosemirror-tables/pulls/61","id":214478777,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0NDc4Nzc3","html_url":"https://github.com/ProseMirror/prosemirror-tables/pull/61","diff_url":"https://github.com/ProseMirror/prosemirror-tables/pull/61.diff","patch_url":"https://github.com/ProseMirror/prosemirror-tables/pull/61.patch","issue_url":"https://api.github.com/repos/ProseMirror/prosemirror-tables/issues/61","number":61,"state":"open","locked":false,"title":"Normalize a text selection that ends at the start of the next cell","user":{"login":"nathf","id":646098,"node_id":"MDQ6VXNlcjY0NjA5OA==","avatar_url":"https://avatars2.githubusercontent.com/u/646098?v=4","gravatar_id":"","url":"https://api.github.com/users/nathf","html_url":"https://github.com/nathf","followers_url":"https://api.github.com/users/nathf/followers","following_url":"https://api.github.com/users/nathf/following{/other_user}","gists_url":"https://api.github.com/users/nathf/gists{/gist_id}","starred_url":"https://api.github.com/users/nathf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathf/subscriptions","organizations_url":"https://api.github.com/users/nathf/orgs","repos_url":"https://api.github.com/users/nathf/repos","events_url":"https://api.github.com/users/nathf/events{/privacy}","received_events_url":"https://api.github.com/users/nathf/received_events","type":"User","site_admin":false},"body":"Fixes #60 ","created_at":"2018-09-11T00:12:55Z","updated_at":"2018-09-16T23:37:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ec4eef34cc2ba8a6fd2fb3402f25c81ddf7357dc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ProseMirror/prosemirror-tables/pulls/61/commits","review_comments_url":"https://api.github.com/repos/ProseMirror/prosemirror-tables/pulls/61/comments","review_comment_url":"https://api.github.com/repos/ProseMirror/prosemirror-tables/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ProseMirror/prosemirror-tables/issues/61/comments","statuses_url":"https://api.github.com/repos/ProseMirror/prosemirror-tables/statuses/a282d57620b812a6a41ac9ace69e0c62c006e0a7","head":{"label":"nathf:normalize-across-cell-selection","ref":"normalize-across-cell-selection","sha":"a282d57620b812a6a41ac9ace69e0c62c006e0a7","user":{"login":"nathf","id":646098,"node_id":"MDQ6VXNlcjY0NjA5OA==","avatar_url":"https://avatars2.githubusercontent.com/u/646098?v=4","gravatar_id":"","url":"https://api.github.com/users/nathf","html_url":"https://github.com/nathf","followers_url":"https://api.github.com/users/nathf/followers","following_url":"https://api.github.com/users/nathf/following{/other_user}","gists_url":"https://api.github.com/users/nathf/gists{/gist_id}","starred_url":"https://api.github.com/users/nathf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathf/subscriptions","organizations_url":"https://api.github.com/users/nathf/orgs","repos_url":"https://api.github.com/users/nathf/repos","events_url":"https://api.github.com/users/nathf/events{/privacy}","received_events_url":"https://api.github.com/users/nathf/received_events","type":"User","site_admin":false},"repo":{"id":141241683,"node_id":"MDEwOlJlcG9zaXRvcnkxNDEyNDE2ODM=","name":"prosemirror-tables","full_name":"nathf/prosemirror-tables","private":false,"owner":{"login":"nathf","id":646098,"node_id":"MDQ6VXNlcjY0NjA5OA==","avatar_url":"https://avatars2.githubusercontent.com/u/646098?v=4","gravatar_id":"","url":"https://api.github.com/users/nathf","html_url":"https://github.com/nathf","followers_url":"https://api.github.com/users/nathf/followers","following_url":"https://api.github.com/users/nathf/following{/other_user}","gists_url":"https://api.github.com/users/nathf/gists{/gist_id}","starred_url":"https://api.github.com/users/nathf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathf/subscriptions","organizations_url":"https://api.github.com/users/nathf/orgs","repos_url":"https://api.github.com/users/nathf/repos","events_url":"https://api.github.com/users/nathf/events{/privacy}","received_events_url":"https://api.github.com/users/nathf/received_events","type":"User","site_admin":false},"html_url":"https://github.com/nathf/prosemirror-tables","description":"Table module for ProseMirror","fork":true,"url":"https://api.github.com/repos/nathf/prosemirror-tables","forks_url":"https://api.github.com/repos/nathf/prosemirror-tables/forks","keys_url":"https://api.github.com/repos/nathf/prosemirror-tables/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nathf/prosemirror-tables/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nathf/prosemirror-tables/teams","hooks_url":"https://api.github.com/repos/nathf/prosemirror-tables/hooks","issue_events_url":"https://api.github.com/repos/nathf/prosemirror-tables/issues/events{/number}","events_url":"https://api.github.com/repos/nathf/prosemirror-tables/events","assignees_url":"https://api.github.com/repos/nathf/prosemirror-tables/assignees{/user}","branches_url":"https://api.github.com/repos/nathf/prosemirror-tables/branches{/branch}","tags_url":"https://api.github.com/repos/nathf/prosemirror-tables/tags","blobs_url":"https://api.github.com/repos/nathf/prosemirror-tables/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nathf/prosemirror-tables/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nathf/prosemirror-tables/git/refs{/sha}","trees_url":"https://api.github.com/repos/nathf/prosemirror-tables/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nathf/prosemirror-tables/statuses/{sha}","languages_url":"https://api.github.com/repos/nathf/prosemirror-tables/languages","stargazers_url":"https://api.github.com/repos/nathf/prosemirror-tables/stargazers","contributors_url":"https://api.github.com/repos/nathf/prosemirror-tables/contributors","subscribers_url":"https://api.github.com/repos/nathf/prosemirror-tables/subscribers","subscription_url":"https://api.github.com/repos/nathf/prosemirror-tables/subscription","commits_url":"https://api.github.com/repos/nathf/prosemirror-tables/commits{/sha}","git_commits_url":"https://api.github.com/repos/nathf/prosemirror-tables/git/commits{/sha}","comments_url":"https://api.github.com/repos/nathf/prosemirror-tables/comments{/number}","issue_comment_url":"https://api.github.com/repos/nathf/prosemirror-tables/issues/comments{/number}","contents_url":"https://api.github.com/repos/nathf/prosemirror-tables/contents/{+path}","compare_url":"https://api.github.com/repos/nathf/prosemirror-tables/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nathf/prosemirror-tables/merges","archive_url":"https://api.github.com/repos/nathf/prosemirror-tables/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nathf/prosemirror-tables/downloads","issues_url":"https://api.github.com/repos/nathf/prosemirror-tables/issues{/number}","pulls_url":"https://api.github.com/repos/nathf/prosemirror-tables/pulls{/number}","milestones_url":"https://api.github.com/repos/nathf/prosemirror-tables/milestones{/number}","notifications_url":"https://api.github.com/repos/nathf/prosemirror-tables/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nathf/prosemirror-tables/labels{/name}","releases_url":"https://api.github.com/repos/nathf/prosemirror-tables/releases{/id}","deployments_url":"https://api.github.com/repos/nathf/prosemirror-tables/deployments","created_at":"2018-07-17T06:26:19Z","updated_at":"2018-09-07T00:39:11Z","pushed_at":"2018-09-13T04:29:27Z","git_url":"git://github.com/nathf/prosemirror-tables.git","ssh_url":"git@github.com:nathf/prosemirror-tables.git","clone_url":"https://github.com/nathf/prosemirror-tables.git","svn_url":"https://github.com/nathf/prosemirror-tables","homepage":null,"size":181,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ProseMirror:master","ref":"master","sha":"ef012d75ea3e8af50821eb9d8be99d787c33ef38","user":{"login":"ProseMirror","id":13659461,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjU5NDYx","avatar_url":"https://avatars3.githubusercontent.com/u/13659461?v=4","gravatar_id":"","url":"https://api.github.com/users/ProseMirror","html_url":"https://github.com/ProseMirror","followers_url":"https://api.github.com/users/ProseMirror/followers","following_url":"https://api.github.com/users/ProseMirror/following{/other_user}","gists_url":"https://api.github.com/users/ProseMirror/gists{/gist_id}","starred_url":"https://api.github.com/users/ProseMirror/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProseMirror/subscriptions","organizations_url":"https://api.github.com/users/ProseMirror/orgs","repos_url":"https://api.github.com/users/ProseMirror/repos","events_url":"https://api.github.com/users/ProseMirror/events{/privacy}","received_events_url":"https://api.github.com/users/ProseMirror/received_events","type":"Organization","site_admin":false},"repo":{"id":93031343,"node_id":"MDEwOlJlcG9zaXRvcnk5MzAzMTM0Mw==","name":"prosemirror-tables","full_name":"ProseMirror/prosemirror-tables","private":false,"owner":{"login":"ProseMirror","id":13659461,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjU5NDYx","avatar_url":"https://avatars3.githubusercontent.com/u/13659461?v=4","gravatar_id":"","url":"https://api.github.com/users/ProseMirror","html_url":"https://github.com/ProseMirror","followers_url":"https://api.github.com/users/ProseMirror/followers","following_url":"https://api.github.com/users/ProseMirror/following{/other_user}","gists_url":"https://api.github.com/users/ProseMirror/gists{/gist_id}","starred_url":"https://api.github.com/users/ProseMirror/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ProseMirror/subscriptions","organizations_url":"https://api.github.com/users/ProseMirror/orgs","repos_url":"https://api.github.com/users/ProseMirror/repos","events_url":"https://api.github.com/users/ProseMirror/events{/privacy}","received_events_url":"https://api.github.com/users/ProseMirror/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ProseMirror/prosemirror-tables","description":"Table module for ProseMirror","fork":false,"url":"https://api.github.com/repos/ProseMirror/prosemirror-tables","forks_url":"https://api.github.com/repos/ProseMirror/prosemirror-tables/forks","keys_url":"https://api.github.com/repos/ProseMirror/prosemirror-tables/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ProseMirror/prosemirror-tables/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ProseMirror/prosemirror-tables/teams","hooks_url":"https://api.github.com/repos/ProseMirror/prosemirror-tables/hooks","issue_events_url":"https://api.github.com/repos/ProseMirror/prosemirror-tables/issues/events{/number}","events_url":"https://api.github.com/repos/ProseMirror/prosemirror-tables/events","assignees_url":"https://api.github.com/repos/ProseMirror/prosemirror-tables/assignees{/user}","branches_url":"https://api.github.com/repos/ProseMirror/prosemirror-tables/branches{/branch}","tags_url":"https://api.github.com/repos/ProseMirror/prosemirror-tables/tags","blobs_url":"https://api.github.com/repos/ProseMirror/prosemirror-tables/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ProseMirror/prosemirror-tables/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ProseMirror/prosemirror-tables/git/refs{/sha}","trees_url":"https://api.github.com/repos/ProseMirror/prosemirror-tables/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ProseMirror/prosemirror-tables/statuses/{sha}","languages_url":"https://api.github.com/repos/ProseMirror/prosemirror-tables/languages","stargazers_url":"https://api.github.com/repos/ProseMirror/prosemirror-tables/stargazers","contributors_url":"https://api.github.com/repos/ProseMirror/prosemirror-tables/contributors","subscribers_url":"https://api.github.com/repos/ProseMirror/prosemirror-tables/subscribers","subscription_url":"https://api.github.com/repos/ProseMirror/prosemirror-tables/subscription","commits_url":"https://api.github.com/repos/ProseMirror/prosemirror-tables/commits{/sha}","git_commits_url":"https://api.github.com/repos/ProseMirror/prosemirror-tables/git/commits{/sha}","comments_url":"https://api.github.com/repos/ProseMirror/prosemirror-tables/comments{/number}","issue_comment_url":"https://api.github.com/repos/ProseMirror/prosemirror-tables/issues/comments{/number}","contents_url":"https://api.github.com/repos/ProseMirror/prosemirror-tables/contents/{+path}","compare_url":"https://api.github.com/repos/ProseMirror/prosemirror-tables/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ProseMirror/prosemirror-tables/merges","archive_url":"https://api.github.com/repos/ProseMirror/prosemirror-tables/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ProseMirror/prosemirror-tables/downloads","issues_url":"https://api.github.com/repos/ProseMirror/prosemirror-tables/issues{/number}","pulls_url":"https://api.github.com/repos/ProseMirror/prosemirror-tables/pulls{/number}","milestones_url":"https://api.github.com/repos/ProseMirror/prosemirror-tables/milestones{/number}","notifications_url":"https://api.github.com/repos/ProseMirror/prosemirror-tables/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ProseMirror/prosemirror-tables/labels{/name}","releases_url":"https://api.github.com/repos/ProseMirror/prosemirror-tables/releases{/id}","deployments_url":"https://api.github.com/repos/ProseMirror/prosemirror-tables/deployments","created_at":"2017-06-01T07:52:45Z","updated_at":"2018-09-05T06:27:49Z","pushed_at":"2018-09-13T04:30:34Z","git_url":"git://github.com/ProseMirror/prosemirror-tables.git","ssh_url":"git@github.com:ProseMirror/prosemirror-tables.git","clone_url":"https://github.com/ProseMirror/prosemirror-tables.git","svn_url":"https://github.com/ProseMirror/prosemirror-tables","homepage":null,"size":171,"stargazers_count":25,"watchers_count":25,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":18,"open_issues":9,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ProseMirror/prosemirror-tables/pulls/61"},"html":{"href":"https://github.com/ProseMirror/prosemirror-tables/pull/61"},"issue":{"href":"https://api.github.com/repos/ProseMirror/prosemirror-tables/issues/61"},"comments":{"href":"https://api.github.com/repos/ProseMirror/prosemirror-tables/issues/61/comments"},"review_comments":{"href":"https://api.github.com/repos/ProseMirror/prosemirror-tables/pulls/61/comments"},"review_comment":{"href":"https://api.github.com/repos/ProseMirror/prosemirror-tables/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ProseMirror/prosemirror-tables/pulls/61/commits"},"statuses":{"href":"https://api.github.com/repos/ProseMirror/prosemirror-tables/statuses/a282d57620b812a6a41ac9ace69e0c62c006e0a7"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"eshvedai"}}