{"action":"created","comment":{"url":"https://api.github.com/repos/pmgbergen/porepy/pulls/comments/216671052","pull_request_review_id":154204907,"id":216671052,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjY3MTA1Mg==","diff_hunk":"@@ -598,18 +620,25 @@ def _mpfa_local(g, k, bnd, eta=None, inverter=\"numba\", apertures=None):\n     bound_exclusion = fvutils.ExcludeBoundaries(subcell_topology, bnd, g.dim)\n \n     # No flux conditions for Dirichlet boundary faces\n-    nk_grad = bound_exclusion.exclude_dirichlet(nk_grad)\n-    nk_cell = bound_exclusion.exclude_dirichlet(nk_cell)\n-    # No pressure condition for Neumann boundary faces\n-    pr_cont_grad_all = pr_cont_grad\n-    pr_cont_grad = bound_exclusion.exclude_neumann(pr_cont_grad)\n-    pr_cont_cell = bound_exclusion.exclude_neumann(pr_cont_cell)\n+    nk_grad_n = bound_exclusion.exclude_rob_dir(nk_grad_all)","path":"src/porepy/numerics/fv/mpfa.py","position":150,"original_position":108,"commit_id":"220d12233454cb2f916f18f031df49874c3253e4","original_commit_id":"c6fa6e773bfcbe37daa167704daf43be3186495d","user":{"login":"rbe051","id":28568071,"node_id":"MDQ6VXNlcjI4NTY4MDcx","avatar_url":"https://avatars1.githubusercontent.com/u/28568071?v=4","gravatar_id":"","url":"https://api.github.com/users/rbe051","html_url":"https://github.com/rbe051","followers_url":"https://api.github.com/users/rbe051/followers","following_url":"https://api.github.com/users/rbe051/following{/other_user}","gists_url":"https://api.github.com/users/rbe051/gists{/gist_id}","starred_url":"https://api.github.com/users/rbe051/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbe051/subscriptions","organizations_url":"https://api.github.com/users/rbe051/orgs","repos_url":"https://api.github.com/users/rbe051/repos","events_url":"https://api.github.com/users/rbe051/events{/privacy}","received_events_url":"https://api.github.com/users/rbe051/received_events","type":"User","site_admin":false},"body":" I guess the rough idea is given for the mpfa discretization, but the discretization is messy, so it would not be bad to add some more","created_at":"2018-09-11T13:35:58Z","updated_at":"2018-09-11T13:35:59Z","html_url":"https://github.com/pmgbergen/porepy/pull/152#discussion_r216671052","pull_request_url":"https://api.github.com/repos/pmgbergen/porepy/pulls/152","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/pmgbergen/porepy/pulls/comments/216671052"},"html":{"href":"https://github.com/pmgbergen/porepy/pull/152#discussion_r216671052"},"pull_request":{"href":"https://api.github.com/repos/pmgbergen/porepy/pulls/152"}},"in_reply_to_id":216643941},"pull_request":{"url":"https://api.github.com/repos/pmgbergen/porepy/pulls/152","id":214573908,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0NTczOTA4","html_url":"https://github.com/pmgbergen/porepy/pull/152","diff_url":"https://github.com/pmgbergen/porepy/pull/152.diff","patch_url":"https://github.com/pmgbergen/porepy/pull/152.patch","issue_url":"https://api.github.com/repos/pmgbergen/porepy/issues/152","number":152,"state":"open","locked":false,"title":"Robin bc","user":{"login":"rbe051","id":28568071,"node_id":"MDQ6VXNlcjI4NTY4MDcx","avatar_url":"https://avatars1.githubusercontent.com/u/28568071?v=4","gravatar_id":"","url":"https://api.github.com/users/rbe051","html_url":"https://github.com/rbe051","followers_url":"https://api.github.com/users/rbe051/followers","following_url":"https://api.github.com/users/rbe051/following{/other_user}","gists_url":"https://api.github.com/users/rbe051/gists{/gist_id}","starred_url":"https://api.github.com/users/rbe051/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rbe051/subscriptions","organizations_url":"https://api.github.com/users/rbe051/orgs","repos_url":"https://api.github.com/users/rbe051/repos","events_url":"https://api.github.com/users/rbe051/events{/privacy}","received_events_url":"https://api.github.com/users/rbe051/received_events","type":"User","site_admin":false},"body":"Implemented Robin conditions for the MPFA and MPSA discretization. In the process I also found the bug in MPSA which gave sub-optimal convergence rates for the MPSA with Neumann. The issue was that at the interior faces the asymmetric part of the stress tensor cancel by construction, so it was just thrown away in the code. At the Neumann boundaries we then have two options: \r\n1: Include the asymmetric part for the discretization of these faces\r\n2: Also throw away the asymmetric part of the given traction, or force the user to only give asymmetric part (I don't like this option too much)\r\n\r\nTherefore, I ended up implementing option 3, and included the asymmetric part for all faces (I'm lazy). \r\nApparently this breaks down in some cases (some of the unittests fails) because the local system becomes singular. I am not sure if this is because we included the asymmetric part to the interior faces (which would be strange since these should cancel), or because they are included to the exterior faces.\r\n\r\nAlso, I am afraid the robin implementation increases the memory use by 1/3, as we have to create all the local matrices also for the Robin condition. I guess if we are a bit clever we can mitigate this issue.\r\n\r\nAnother task that is left before a merge is to implement robin for vector bc (should be trivial?) and possible for TPFA also.\r\n\r\n","created_at":"2018-09-11T09:47:19Z","updated_at":"2018-09-11T13:35:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5bf2854d7ac49c86a30c3dcd741617ff9d1259f7","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mstarnoni","id":32573650,"node_id":"MDQ6VXNlcjMyNTczNjUw","avatar_url":"https://avatars2.githubusercontent.com/u/32573650?v=4","gravatar_id":"","url":"https://api.github.com/users/mstarnoni","html_url":"https://github.com/mstarnoni","followers_url":"https://api.github.com/users/mstarnoni/followers","following_url":"https://api.github.com/users/mstarnoni/following{/other_user}","gists_url":"https://api.github.com/users/mstarnoni/gists{/gist_id}","starred_url":"https://api.github.com/users/mstarnoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mstarnoni/subscriptions","organizations_url":"https://api.github.com/users/mstarnoni/orgs","repos_url":"https://api.github.com/users/mstarnoni/repos","events_url":"https://api.github.com/users/mstarnoni/events{/privacy}","received_events_url":"https://api.github.com/users/mstarnoni/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pmgbergen/porepy/pulls/152/commits","review_comments_url":"https://api.github.com/repos/pmgbergen/porepy/pulls/152/comments","review_comment_url":"https://api.github.com/repos/pmgbergen/porepy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pmgbergen/porepy/issues/152/comments","statuses_url":"https://api.github.com/repos/pmgbergen/porepy/statuses/220d12233454cb2f916f18f031df49874c3253e4","head":{"label":"pmgbergen:robin_bc","ref":"robin_bc","sha":"220d12233454cb2f916f18f031df49874c3253e4","user":{"login":"pmgbergen","id":27725718,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NzI1NzE4","avatar_url":"https://avatars1.githubusercontent.com/u/27725718?v=4","gravatar_id":"","url":"https://api.github.com/users/pmgbergen","html_url":"https://github.com/pmgbergen","followers_url":"https://api.github.com/users/pmgbergen/followers","following_url":"https://api.github.com/users/pmgbergen/following{/other_user}","gists_url":"https://api.github.com/users/pmgbergen/gists{/gist_id}","starred_url":"https://api.github.com/users/pmgbergen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmgbergen/subscriptions","organizations_url":"https://api.github.com/users/pmgbergen/orgs","repos_url":"https://api.github.com/users/pmgbergen/repos","events_url":"https://api.github.com/users/pmgbergen/events{/privacy}","received_events_url":"https://api.github.com/users/pmgbergen/received_events","type":"Organization","site_admin":false},"repo":{"id":89228838,"node_id":"MDEwOlJlcG9zaXRvcnk4OTIyODgzOA==","name":"porepy","full_name":"pmgbergen/porepy","owner":{"login":"pmgbergen","id":27725718,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NzI1NzE4","avatar_url":"https://avatars1.githubusercontent.com/u/27725718?v=4","gravatar_id":"","url":"https://api.github.com/users/pmgbergen","html_url":"https://github.com/pmgbergen","followers_url":"https://api.github.com/users/pmgbergen/followers","following_url":"https://api.github.com/users/pmgbergen/following{/other_user}","gists_url":"https://api.github.com/users/pmgbergen/gists{/gist_id}","starred_url":"https://api.github.com/users/pmgbergen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmgbergen/subscriptions","organizations_url":"https://api.github.com/users/pmgbergen/orgs","repos_url":"https://api.github.com/users/pmgbergen/repos","events_url":"https://api.github.com/users/pmgbergen/events{/privacy}","received_events_url":"https://api.github.com/users/pmgbergen/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pmgbergen/porepy","description":"Python Simulation Tool for Fractured and Deformable Porous Media","fork":false,"url":"https://api.github.com/repos/pmgbergen/porepy","forks_url":"https://api.github.com/repos/pmgbergen/porepy/forks","keys_url":"https://api.github.com/repos/pmgbergen/porepy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pmgbergen/porepy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pmgbergen/porepy/teams","hooks_url":"https://api.github.com/repos/pmgbergen/porepy/hooks","issue_events_url":"https://api.github.com/repos/pmgbergen/porepy/issues/events{/number}","events_url":"https://api.github.com/repos/pmgbergen/porepy/events","assignees_url":"https://api.github.com/repos/pmgbergen/porepy/assignees{/user}","branches_url":"https://api.github.com/repos/pmgbergen/porepy/branches{/branch}","tags_url":"https://api.github.com/repos/pmgbergen/porepy/tags","blobs_url":"https://api.github.com/repos/pmgbergen/porepy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pmgbergen/porepy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pmgbergen/porepy/git/refs{/sha}","trees_url":"https://api.github.com/repos/pmgbergen/porepy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pmgbergen/porepy/statuses/{sha}","languages_url":"https://api.github.com/repos/pmgbergen/porepy/languages","stargazers_url":"https://api.github.com/repos/pmgbergen/porepy/stargazers","contributors_url":"https://api.github.com/repos/pmgbergen/porepy/contributors","subscribers_url":"https://api.github.com/repos/pmgbergen/porepy/subscribers","subscription_url":"https://api.github.com/repos/pmgbergen/porepy/subscription","commits_url":"https://api.github.com/repos/pmgbergen/porepy/commits{/sha}","git_commits_url":"https://api.github.com/repos/pmgbergen/porepy/git/commits{/sha}","comments_url":"https://api.github.com/repos/pmgbergen/porepy/comments{/number}","issue_comment_url":"https://api.github.com/repos/pmgbergen/porepy/issues/comments{/number}","contents_url":"https://api.github.com/repos/pmgbergen/porepy/contents/{+path}","compare_url":"https://api.github.com/repos/pmgbergen/porepy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pmgbergen/porepy/merges","archive_url":"https://api.github.com/repos/pmgbergen/porepy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pmgbergen/porepy/downloads","issues_url":"https://api.github.com/repos/pmgbergen/porepy/issues{/number}","pulls_url":"https://api.github.com/repos/pmgbergen/porepy/pulls{/number}","milestones_url":"https://api.github.com/repos/pmgbergen/porepy/milestones{/number}","notifications_url":"https://api.github.com/repos/pmgbergen/porepy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pmgbergen/porepy/labels{/name}","releases_url":"https://api.github.com/repos/pmgbergen/porepy/releases{/id}","deployments_url":"https://api.github.com/repos/pmgbergen/porepy/deployments","created_at":"2017-04-24T10:43:24Z","updated_at":"2018-09-11T01:41:34Z","pushed_at":"2018-09-11T13:34:23Z","git_url":"git://github.com/pmgbergen/porepy.git","ssh_url":"git@github.com:pmgbergen/porepy.git","clone_url":"https://github.com/pmgbergen/porepy.git","svn_url":"https://github.com/pmgbergen/porepy","homepage":"","size":19796,"stargazers_count":30,"watchers_count":30,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":11,"open_issues":11,"watchers":30,"default_branch":"develop"}},"base":{"label":"pmgbergen:develop","ref":"develop","sha":"5a3d9d79b70e680917956376fd057f71cf8677d7","user":{"login":"pmgbergen","id":27725718,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NzI1NzE4","avatar_url":"https://avatars1.githubusercontent.com/u/27725718?v=4","gravatar_id":"","url":"https://api.github.com/users/pmgbergen","html_url":"https://github.com/pmgbergen","followers_url":"https://api.github.com/users/pmgbergen/followers","following_url":"https://api.github.com/users/pmgbergen/following{/other_user}","gists_url":"https://api.github.com/users/pmgbergen/gists{/gist_id}","starred_url":"https://api.github.com/users/pmgbergen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmgbergen/subscriptions","organizations_url":"https://api.github.com/users/pmgbergen/orgs","repos_url":"https://api.github.com/users/pmgbergen/repos","events_url":"https://api.github.com/users/pmgbergen/events{/privacy}","received_events_url":"https://api.github.com/users/pmgbergen/received_events","type":"Organization","site_admin":false},"repo":{"id":89228838,"node_id":"MDEwOlJlcG9zaXRvcnk4OTIyODgzOA==","name":"porepy","full_name":"pmgbergen/porepy","owner":{"login":"pmgbergen","id":27725718,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NzI1NzE4","avatar_url":"https://avatars1.githubusercontent.com/u/27725718?v=4","gravatar_id":"","url":"https://api.github.com/users/pmgbergen","html_url":"https://github.com/pmgbergen","followers_url":"https://api.github.com/users/pmgbergen/followers","following_url":"https://api.github.com/users/pmgbergen/following{/other_user}","gists_url":"https://api.github.com/users/pmgbergen/gists{/gist_id}","starred_url":"https://api.github.com/users/pmgbergen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmgbergen/subscriptions","organizations_url":"https://api.github.com/users/pmgbergen/orgs","repos_url":"https://api.github.com/users/pmgbergen/repos","events_url":"https://api.github.com/users/pmgbergen/events{/privacy}","received_events_url":"https://api.github.com/users/pmgbergen/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pmgbergen/porepy","description":"Python Simulation Tool for Fractured and Deformable Porous Media","fork":false,"url":"https://api.github.com/repos/pmgbergen/porepy","forks_url":"https://api.github.com/repos/pmgbergen/porepy/forks","keys_url":"https://api.github.com/repos/pmgbergen/porepy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pmgbergen/porepy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pmgbergen/porepy/teams","hooks_url":"https://api.github.com/repos/pmgbergen/porepy/hooks","issue_events_url":"https://api.github.com/repos/pmgbergen/porepy/issues/events{/number}","events_url":"https://api.github.com/repos/pmgbergen/porepy/events","assignees_url":"https://api.github.com/repos/pmgbergen/porepy/assignees{/user}","branches_url":"https://api.github.com/repos/pmgbergen/porepy/branches{/branch}","tags_url":"https://api.github.com/repos/pmgbergen/porepy/tags","blobs_url":"https://api.github.com/repos/pmgbergen/porepy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pmgbergen/porepy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pmgbergen/porepy/git/refs{/sha}","trees_url":"https://api.github.com/repos/pmgbergen/porepy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pmgbergen/porepy/statuses/{sha}","languages_url":"https://api.github.com/repos/pmgbergen/porepy/languages","stargazers_url":"https://api.github.com/repos/pmgbergen/porepy/stargazers","contributors_url":"https://api.github.com/repos/pmgbergen/porepy/contributors","subscribers_url":"https://api.github.com/repos/pmgbergen/porepy/subscribers","subscription_url":"https://api.github.com/repos/pmgbergen/porepy/subscription","commits_url":"https://api.github.com/repos/pmgbergen/porepy/commits{/sha}","git_commits_url":"https://api.github.com/repos/pmgbergen/porepy/git/commits{/sha}","comments_url":"https://api.github.com/repos/pmgbergen/porepy/comments{/number}","issue_comment_url":"https://api.github.com/repos/pmgbergen/porepy/issues/comments{/number}","contents_url":"https://api.github.com/repos/pmgbergen/porepy/contents/{+path}","compare_url":"https://api.github.com/repos/pmgbergen/porepy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pmgbergen/porepy/merges","archive_url":"https://api.github.com/repos/pmgbergen/porepy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pmgbergen/porepy/downloads","issues_url":"https://api.github.com/repos/pmgbergen/porepy/issues{/number}","pulls_url":"https://api.github.com/repos/pmgbergen/porepy/pulls{/number}","milestones_url":"https://api.github.com/repos/pmgbergen/porepy/milestones{/number}","notifications_url":"https://api.github.com/repos/pmgbergen/porepy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pmgbergen/porepy/labels{/name}","releases_url":"https://api.github.com/repos/pmgbergen/porepy/releases{/id}","deployments_url":"https://api.github.com/repos/pmgbergen/porepy/deployments","created_at":"2017-04-24T10:43:24Z","updated_at":"2018-09-11T01:41:34Z","pushed_at":"2018-09-11T13:34:23Z","git_url":"git://github.com/pmgbergen/porepy.git","ssh_url":"git@github.com:pmgbergen/porepy.git","clone_url":"https://github.com/pmgbergen/porepy.git","svn_url":"https://github.com/pmgbergen/porepy","homepage":"","size":19796,"stargazers_count":30,"watchers_count":30,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":11,"open_issues":11,"watchers":30,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/pmgbergen/porepy/pulls/152"},"html":{"href":"https://github.com/pmgbergen/porepy/pull/152"},"issue":{"href":"https://api.github.com/repos/pmgbergen/porepy/issues/152"},"comments":{"href":"https://api.github.com/repos/pmgbergen/porepy/issues/152/comments"},"review_comments":{"href":"https://api.github.com/repos/pmgbergen/porepy/pulls/152/comments"},"review_comment":{"href":"https://api.github.com/repos/pmgbergen/porepy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pmgbergen/porepy/pulls/152/commits"},"statuses":{"href":"https://api.github.com/repos/pmgbergen/porepy/statuses/220d12233454cb2f916f18f031df49874c3253e4"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"rbe051"}}