{"action":"created","comment":{"url":"https://api.github.com/repos/friendica/friendica/pulls/comments/223814245","pull_request_review_id":163033599,"id":223814245,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzgxNDI0NQ==","diff_hunk":"@@ -709,23 +717,23 @@ public function get_hostname()\n \t\treturn $this->hostname;\n \t}\n \n-\tpublic function get_path()\n+\tpublic function getUrlpath()","path":"src/App.php","position":221,"original_position":221,"commit_id":"911b1d12cead2b9012a26edd4faeee2ff2fe06fd","original_commit_id":"911b1d12cead2b9012a26edd4faeee2ff2fe06fd","user":{"login":"MrPetovan","id":925415,"node_id":"MDQ6VXNlcjkyNTQxNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/925415?v=4","gravatar_id":"","url":"https://api.github.com/users/MrPetovan","html_url":"https://github.com/MrPetovan","followers_url":"https://api.github.com/users/MrPetovan/followers","following_url":"https://api.github.com/users/MrPetovan/following{/other_user}","gists_url":"https://api.github.com/users/MrPetovan/gists{/gist_id}","starred_url":"https://api.github.com/users/MrPetovan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MrPetovan/subscriptions","organizations_url":"https://api.github.com/users/MrPetovan/orgs","repos_url":"https://api.github.com/users/MrPetovan/repos","events_url":"https://api.github.com/users/MrPetovan/events{/privacy}","received_events_url":"https://api.github.com/users/MrPetovan/received_events","type":"User","site_admin":false},"body":"Please rename to `getUrlPath()`.","created_at":"2018-10-09T18:29:50Z","updated_at":"2018-10-09T18:33:04Z","html_url":"https://github.com/friendica/friendica/pull/5862#discussion_r223814245","pull_request_url":"https://api.github.com/repos/friendica/friendica/pulls/5862","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/friendica/friendica/pulls/comments/223814245"},"html":{"href":"https://github.com/friendica/friendica/pull/5862#discussion_r223814245"},"pull_request":{"href":"https://api.github.com/repos/friendica/friendica/pulls/5862"}}},"pull_request":{"url":"https://api.github.com/repos/friendica/friendica/pulls/5862","id":221536921,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxNTM2OTIx","html_url":"https://github.com/friendica/friendica/pull/5862","diff_url":"https://github.com/friendica/friendica/pull/5862.diff","patch_url":"https://github.com/friendica/friendica/pull/5862.patch","issue_url":"https://api.github.com/repos/friendica/friendica/issues/5862","number":5862,"state":"open","locked":false,"title":"Rename app methods","user":{"login":"nupplaphil","id":379654,"node_id":"MDQ6VXNlcjM3OTY1NA==","avatar_url":"https://avatars3.githubusercontent.com/u/379654?v=4","gravatar_id":"","url":"https://api.github.com/users/nupplaphil","html_url":"https://github.com/nupplaphil","followers_url":"https://api.github.com/users/nupplaphil/followers","following_url":"https://api.github.com/users/nupplaphil/following{/other_user}","gists_url":"https://api.github.com/users/nupplaphil/gists{/gist_id}","starred_url":"https://api.github.com/users/nupplaphil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nupplaphil/subscriptions","organizations_url":"https://api.github.com/users/nupplaphil/orgs","repos_url":"https://api.github.com/users/nupplaphil/repos","events_url":"https://api.github.com/users/nupplaphil/events{/privacy}","received_events_url":"https://api.github.com/users/nupplaphil/received_events","type":"User","site_admin":false},"body":"I changed the method signatures from a_method_name to aMethodName() for every `App` method.\r\n\r\nIt's one step and the next step is to create some `getVariable()` and `setVariable()` methods for accessing variables from outside.\r\n=> With this encapsulation, it's a progress to mock methods in tests and to increase the OOP-Pattern in Friendica","created_at":"2018-10-09T18:18:02Z","updated_at":"2018-10-09T18:33:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0cbae8f8d5bb5af40bb60baeed568f1d7322e275","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/friendica/friendica/pulls/5862/commits","review_comments_url":"https://api.github.com/repos/friendica/friendica/pulls/5862/comments","review_comment_url":"https://api.github.com/repos/friendica/friendica/pulls/comments{/number}","comments_url":"https://api.github.com/repos/friendica/friendica/issues/5862/comments","statuses_url":"https://api.github.com/repos/friendica/friendica/statuses/911b1d12cead2b9012a26edd4faeee2ff2fe06fd","head":{"label":"nupplaphil:rename_App_Methods","ref":"rename_App_Methods","sha":"911b1d12cead2b9012a26edd4faeee2ff2fe06fd","user":{"login":"nupplaphil","id":379654,"node_id":"MDQ6VXNlcjM3OTY1NA==","avatar_url":"https://avatars3.githubusercontent.com/u/379654?v=4","gravatar_id":"","url":"https://api.github.com/users/nupplaphil","html_url":"https://github.com/nupplaphil","followers_url":"https://api.github.com/users/nupplaphil/followers","following_url":"https://api.github.com/users/nupplaphil/following{/other_user}","gists_url":"https://api.github.com/users/nupplaphil/gists{/gist_id}","starred_url":"https://api.github.com/users/nupplaphil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nupplaphil/subscriptions","organizations_url":"https://api.github.com/users/nupplaphil/orgs","repos_url":"https://api.github.com/users/nupplaphil/repos","events_url":"https://api.github.com/users/nupplaphil/events{/privacy}","received_events_url":"https://api.github.com/users/nupplaphil/received_events","type":"User","site_admin":false},"repo":{"id":128665702,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg2NjU3MDI=","name":"friendica","full_name":"nupplaphil/friendica","private":false,"owner":{"login":"nupplaphil","id":379654,"node_id":"MDQ6VXNlcjM3OTY1NA==","avatar_url":"https://avatars3.githubusercontent.com/u/379654?v=4","gravatar_id":"","url":"https://api.github.com/users/nupplaphil","html_url":"https://github.com/nupplaphil","followers_url":"https://api.github.com/users/nupplaphil/followers","following_url":"https://api.github.com/users/nupplaphil/following{/other_user}","gists_url":"https://api.github.com/users/nupplaphil/gists{/gist_id}","starred_url":"https://api.github.com/users/nupplaphil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nupplaphil/subscriptions","organizations_url":"https://api.github.com/users/nupplaphil/orgs","repos_url":"https://api.github.com/users/nupplaphil/repos","events_url":"https://api.github.com/users/nupplaphil/events{/privacy}","received_events_url":"https://api.github.com/users/nupplaphil/received_events","type":"User","site_admin":false},"html_url":"https://github.com/nupplaphil/friendica","description":"Friendica Communications Platform","fork":true,"url":"https://api.github.com/repos/nupplaphil/friendica","forks_url":"https://api.github.com/repos/nupplaphil/friendica/forks","keys_url":"https://api.github.com/repos/nupplaphil/friendica/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nupplaphil/friendica/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nupplaphil/friendica/teams","hooks_url":"https://api.github.com/repos/nupplaphil/friendica/hooks","issue_events_url":"https://api.github.com/repos/nupplaphil/friendica/issues/events{/number}","events_url":"https://api.github.com/repos/nupplaphil/friendica/events","assignees_url":"https://api.github.com/repos/nupplaphil/friendica/assignees{/user}","branches_url":"https://api.github.com/repos/nupplaphil/friendica/branches{/branch}","tags_url":"https://api.github.com/repos/nupplaphil/friendica/tags","blobs_url":"https://api.github.com/repos/nupplaphil/friendica/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nupplaphil/friendica/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nupplaphil/friendica/git/refs{/sha}","trees_url":"https://api.github.com/repos/nupplaphil/friendica/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nupplaphil/friendica/statuses/{sha}","languages_url":"https://api.github.com/repos/nupplaphil/friendica/languages","stargazers_url":"https://api.github.com/repos/nupplaphil/friendica/stargazers","contributors_url":"https://api.github.com/repos/nupplaphil/friendica/contributors","subscribers_url":"https://api.github.com/repos/nupplaphil/friendica/subscribers","subscription_url":"https://api.github.com/repos/nupplaphil/friendica/subscription","commits_url":"https://api.github.com/repos/nupplaphil/friendica/commits{/sha}","git_commits_url":"https://api.github.com/repos/nupplaphil/friendica/git/commits{/sha}","comments_url":"https://api.github.com/repos/nupplaphil/friendica/comments{/number}","issue_comment_url":"https://api.github.com/repos/nupplaphil/friendica/issues/comments{/number}","contents_url":"https://api.github.com/repos/nupplaphil/friendica/contents/{+path}","compare_url":"https://api.github.com/repos/nupplaphil/friendica/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nupplaphil/friendica/merges","archive_url":"https://api.github.com/repos/nupplaphil/friendica/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nupplaphil/friendica/downloads","issues_url":"https://api.github.com/repos/nupplaphil/friendica/issues{/number}","pulls_url":"https://api.github.com/repos/nupplaphil/friendica/pulls{/number}","milestones_url":"https://api.github.com/repos/nupplaphil/friendica/milestones{/number}","notifications_url":"https://api.github.com/repos/nupplaphil/friendica/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nupplaphil/friendica/labels{/name}","releases_url":"https://api.github.com/repos/nupplaphil/friendica/releases{/id}","deployments_url":"https://api.github.com/repos/nupplaphil/friendica/deployments","created_at":"2018-04-08T17:33:43Z","updated_at":"2018-10-09T18:21:01Z","pushed_at":"2018-10-09T18:23:26Z","git_url":"git://github.com/nupplaphil/friendica.git","ssh_url":"git@github.com:nupplaphil/friendica.git","clone_url":"https://github.com/nupplaphil/friendica.git","svn_url":"https://github.com/nupplaphil/friendica","homepage":"https://friendi.ca","size":106131,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"friendica:develop","ref":"develop","sha":"23be68e74df0a9a1f2571eab6655788ad028c67d","user":{"login":"friendica","id":1176581,"node_id":"MDQ6VXNlcjExNzY1ODE=","avatar_url":"https://avatars1.githubusercontent.com/u/1176581?v=4","gravatar_id":"","url":"https://api.github.com/users/friendica","html_url":"https://github.com/friendica","followers_url":"https://api.github.com/users/friendica/followers","following_url":"https://api.github.com/users/friendica/following{/other_user}","gists_url":"https://api.github.com/users/friendica/gists{/gist_id}","starred_url":"https://api.github.com/users/friendica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/friendica/subscriptions","organizations_url":"https://api.github.com/users/friendica/orgs","repos_url":"https://api.github.com/users/friendica/repos","events_url":"https://api.github.com/users/friendica/events{/privacy}","received_events_url":"https://api.github.com/users/friendica/received_events","type":"User","site_admin":false},"repo":{"id":2722709,"node_id":"MDEwOlJlcG9zaXRvcnkyNzIyNzA5","name":"friendica","full_name":"friendica/friendica","private":false,"owner":{"login":"friendica","id":1176581,"node_id":"MDQ6VXNlcjExNzY1ODE=","avatar_url":"https://avatars1.githubusercontent.com/u/1176581?v=4","gravatar_id":"","url":"https://api.github.com/users/friendica","html_url":"https://github.com/friendica","followers_url":"https://api.github.com/users/friendica/followers","following_url":"https://api.github.com/users/friendica/following{/other_user}","gists_url":"https://api.github.com/users/friendica/gists{/gist_id}","starred_url":"https://api.github.com/users/friendica/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/friendica/subscriptions","organizations_url":"https://api.github.com/users/friendica/orgs","repos_url":"https://api.github.com/users/friendica/repos","events_url":"https://api.github.com/users/friendica/events{/privacy}","received_events_url":"https://api.github.com/users/friendica/received_events","type":"User","site_admin":false},"html_url":"https://github.com/friendica/friendica","description":"Friendica Communications Platform","fork":true,"url":"https://api.github.com/repos/friendica/friendica","forks_url":"https://api.github.com/repos/friendica/friendica/forks","keys_url":"https://api.github.com/repos/friendica/friendica/keys{/key_id}","collaborators_url":"https://api.github.com/repos/friendica/friendica/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/friendica/friendica/teams","hooks_url":"https://api.github.com/repos/friendica/friendica/hooks","issue_events_url":"https://api.github.com/repos/friendica/friendica/issues/events{/number}","events_url":"https://api.github.com/repos/friendica/friendica/events","assignees_url":"https://api.github.com/repos/friendica/friendica/assignees{/user}","branches_url":"https://api.github.com/repos/friendica/friendica/branches{/branch}","tags_url":"https://api.github.com/repos/friendica/friendica/tags","blobs_url":"https://api.github.com/repos/friendica/friendica/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/friendica/friendica/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/friendica/friendica/git/refs{/sha}","trees_url":"https://api.github.com/repos/friendica/friendica/git/trees{/sha}","statuses_url":"https://api.github.com/repos/friendica/friendica/statuses/{sha}","languages_url":"https://api.github.com/repos/friendica/friendica/languages","stargazers_url":"https://api.github.com/repos/friendica/friendica/stargazers","contributors_url":"https://api.github.com/repos/friendica/friendica/contributors","subscribers_url":"https://api.github.com/repos/friendica/friendica/subscribers","subscription_url":"https://api.github.com/repos/friendica/friendica/subscription","commits_url":"https://api.github.com/repos/friendica/friendica/commits{/sha}","git_commits_url":"https://api.github.com/repos/friendica/friendica/git/commits{/sha}","comments_url":"https://api.github.com/repos/friendica/friendica/comments{/number}","issue_comment_url":"https://api.github.com/repos/friendica/friendica/issues/comments{/number}","contents_url":"https://api.github.com/repos/friendica/friendica/contents/{+path}","compare_url":"https://api.github.com/repos/friendica/friendica/compare/{base}...{head}","merges_url":"https://api.github.com/repos/friendica/friendica/merges","archive_url":"https://api.github.com/repos/friendica/friendica/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/friendica/friendica/downloads","issues_url":"https://api.github.com/repos/friendica/friendica/issues{/number}","pulls_url":"https://api.github.com/repos/friendica/friendica/pulls{/number}","milestones_url":"https://api.github.com/repos/friendica/friendica/milestones{/number}","notifications_url":"https://api.github.com/repos/friendica/friendica/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/friendica/friendica/labels{/name}","releases_url":"https://api.github.com/repos/friendica/friendica/releases{/id}","deployments_url":"https://api.github.com/repos/friendica/friendica/deployments","created_at":"2011-11-06T22:19:41Z","updated_at":"2018-10-09T15:17:16Z","pushed_at":"2018-10-09T18:23:28Z","git_url":"git://github.com/friendica/friendica.git","ssh_url":"git@github.com:friendica/friendica.git","clone_url":"https://github.com/friendica/friendica.git","svn_url":"https://github.com/friendica/friendica","homepage":"https://friendi.ca","size":106158,"stargazers_count":643,"watchers_count":643,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":211,"mirror_url":null,"archived":false,"open_issues_count":401,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":211,"open_issues":401,"watchers":643,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/friendica/friendica/pulls/5862"},"html":{"href":"https://github.com/friendica/friendica/pull/5862"},"issue":{"href":"https://api.github.com/repos/friendica/friendica/issues/5862"},"comments":{"href":"https://api.github.com/repos/friendica/friendica/issues/5862/comments"},"review_comments":{"href":"https://api.github.com/repos/friendica/friendica/pulls/5862/comments"},"review_comment":{"href":"https://api.github.com/repos/friendica/friendica/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/friendica/friendica/pulls/5862/commits"},"statuses":{"href":"https://api.github.com/repos/friendica/friendica/statuses/911b1d12cead2b9012a26edd4faeee2ff2fe06fd"}},"author_association":"NONE"}}
{"actor":{"display_login":"MrPetovan"}}