{"action":"created","comment":{"url":"https://api.github.com/repos/root-project/root/pulls/comments/194976289","pull_request_review_id":128250226,"id":194976289,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDk3NjI4OQ==","diff_hunk":"@@ -5916,15 +5928,16 @@ static void* LazyFunctionCreatorAutoloadForModule(const std::string& mangled_nam\n                // for symbols that cannot be found (neither by dlsym nor in the JIT).\n                if (dyLibManager->isLibraryLoaded(FileName.c_str()))\n                   continue;\n-               sLibraries.insert(FileName);\n+               sLibraries.push_back(std::make_pair(sPathsLast, filename(FileName)));","path":"core/metacling/src/TCling.cxx","position":42,"original_position":42,"commit_id":"cc338ca63144086c9c8098c25e85027e35e48ed4","original_commit_id":"cc338ca63144086c9c8098c25e85027e35e48ed4","user":{"login":"vgvassilev","id":6516307,"node_id":"MDQ6VXNlcjY1MTYzMDc=","avatar_url":"https://avatars1.githubusercontent.com/u/6516307?v=4","gravatar_id":"","url":"https://api.github.com/users/vgvassilev","html_url":"https://github.com/vgvassilev","followers_url":"https://api.github.com/users/vgvassilev/followers","following_url":"https://api.github.com/users/vgvassilev/following{/other_user}","gists_url":"https://api.github.com/users/vgvassilev/gists{/gist_id}","starred_url":"https://api.github.com/users/vgvassilev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vgvassilev/subscriptions","organizations_url":"https://api.github.com/users/vgvassilev/orgs","repos_url":"https://api.github.com/users/vgvassilev/repos","events_url":"https://api.github.com/users/vgvassilev/events{/privacy}","received_events_url":"https://api.github.com/users/vgvassilev/received_events","type":"User","site_admin":false},"body":"Please change the type of `FileName` to `const std::string &`.","created_at":"2018-06-13T07:11:53Z","updated_at":"2018-06-13T07:11:53Z","html_url":"https://github.com/root-project/root/pull/2137#discussion_r194976289","pull_request_url":"https://api.github.com/repos/root-project/root/pulls/2137","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/root-project/root/pulls/comments/194976289"},"html":{"href":"https://github.com/root-project/root/pull/2137#discussion_r194976289"},"pull_request":{"href":"https://api.github.com/repos/root-project/root/pulls/2137"}}},"pull_request":{"url":"https://api.github.com/repos/root-project/root/pulls/2137","id":192352826,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMzUyODI2","html_url":"https://github.com/root-project/root/pull/2137","diff_url":"https://github.com/root-project/root/pull/2137.diff","patch_url":"https://github.com/root-project/root/pull/2137.patch","issue_url":"https://api.github.com/repos/root-project/root/issues/2137","number":2137,"state":"open","locked":false,"title":"[cxxmodules] Respect LD_LIBRARY_PATH order and save memory","user":{"login":"yamaguchi1024","id":12247908,"node_id":"MDQ6VXNlcjEyMjQ3OTA4","avatar_url":"https://avatars0.githubusercontent.com/u/12247908?v=4","gravatar_id":"","url":"https://api.github.com/users/yamaguchi1024","html_url":"https://github.com/yamaguchi1024","followers_url":"https://api.github.com/users/yamaguchi1024/followers","following_url":"https://api.github.com/users/yamaguchi1024/following{/other_user}","gists_url":"https://api.github.com/users/yamaguchi1024/gists{/gist_id}","starred_url":"https://api.github.com/users/yamaguchi1024/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yamaguchi1024/subscriptions","organizations_url":"https://api.github.com/users/yamaguchi1024/orgs","repos_url":"https://api.github.com/users/yamaguchi1024/repos","events_url":"https://api.github.com/users/yamaguchi1024/events{/privacy}","received_events_url":"https://api.github.com/users/yamaguchi1024/received_events","type":"User","site_admin":false},"body":"std::set was not good because it sorted libraries by alphabetical order\r\nand didn't preserve LD_LIBRARY_PATH order information. We can use\r\nstd::vector instead. (Erasing rarely happens and doesn't cost so much)\r\n\r\nPath prefix like \"/home/yuka/modules/lib/\" costs memory, I\r\nthink it makes sense to avoid path duplication in sLibraries and make sPaths\r\nvector for this prefix.\r\n\r\nWith this patch\r\n```\r\nProcessing tutorials/hsimple.C...\r\nhsimple   : Real Time =   0.14 seconds Cpu Time =   0.14 seconds\r\n(TFile *) 0x31eb0d0\r\nProcessing memory.C...\r\n cpu  time = 0.861813 seconds\r\n sys  time = 0.155326 seconds\r\n res  memory = 178.988 Mbytes\r\n vir  memory = 435.332 Mbytes\r\n```\r\n\r\nw/o\r\n```\r\nProcessing tutorials/hsimple.C...\r\nhsimple   : Real Time =   0.21 seconds Cpu Time =   0.20 seconds\r\n(TFile *) 0x30db6e0\r\nProcessing memory.C...\r\n cpu  time = 1.266833 seconds\r\n sys  time = 0.227562 seconds\r\n res  memory = 178.965 Mbytes\r\n vir  memory = 435.301 Mbytes\r\n```\r\n\r\nActually cpu time improved","created_at":"2018-06-04T09:46:19Z","updated_at":"2018-06-13T07:11:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6d94b44dab81953c58a14297ade4fa0aa22c39a5","assignee":{"login":"vgvassilev","id":6516307,"node_id":"MDQ6VXNlcjY1MTYzMDc=","avatar_url":"https://avatars1.githubusercontent.com/u/6516307?v=4","gravatar_id":"","url":"https://api.github.com/users/vgvassilev","html_url":"https://github.com/vgvassilev","followers_url":"https://api.github.com/users/vgvassilev/followers","following_url":"https://api.github.com/users/vgvassilev/following{/other_user}","gists_url":"https://api.github.com/users/vgvassilev/gists{/gist_id}","starred_url":"https://api.github.com/users/vgvassilev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vgvassilev/subscriptions","organizations_url":"https://api.github.com/users/vgvassilev/orgs","repos_url":"https://api.github.com/users/vgvassilev/repos","events_url":"https://api.github.com/users/vgvassilev/events{/privacy}","received_events_url":"https://api.github.com/users/vgvassilev/received_events","type":"User","site_admin":false},"assignees":[{"login":"vgvassilev","id":6516307,"node_id":"MDQ6VXNlcjY1MTYzMDc=","avatar_url":"https://avatars1.githubusercontent.com/u/6516307?v=4","gravatar_id":"","url":"https://api.github.com/users/vgvassilev","html_url":"https://github.com/vgvassilev","followers_url":"https://api.github.com/users/vgvassilev/followers","following_url":"https://api.github.com/users/vgvassilev/following{/other_user}","gists_url":"https://api.github.com/users/vgvassilev/gists{/gist_id}","starred_url":"https://api.github.com/users/vgvassilev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vgvassilev/subscriptions","organizations_url":"https://api.github.com/users/vgvassilev/orgs","repos_url":"https://api.github.com/users/vgvassilev/repos","events_url":"https://api.github.com/users/vgvassilev/events{/privacy}","received_events_url":"https://api.github.com/users/vgvassilev/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"pcanal","id":5175087,"node_id":"MDQ6VXNlcjUxNzUwODc=","avatar_url":"https://avatars3.githubusercontent.com/u/5175087?v=4","gravatar_id":"","url":"https://api.github.com/users/pcanal","html_url":"https://github.com/pcanal","followers_url":"https://api.github.com/users/pcanal/followers","following_url":"https://api.github.com/users/pcanal/following{/other_user}","gists_url":"https://api.github.com/users/pcanal/gists{/gist_id}","starred_url":"https://api.github.com/users/pcanal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcanal/subscriptions","organizations_url":"https://api.github.com/users/pcanal/orgs","repos_url":"https://api.github.com/users/pcanal/repos","events_url":"https://api.github.com/users/pcanal/events{/privacy}","received_events_url":"https://api.github.com/users/pcanal/received_events","type":"User","site_admin":false},{"login":"oshadura","id":7012420,"node_id":"MDQ6VXNlcjcwMTI0MjA=","avatar_url":"https://avatars2.githubusercontent.com/u/7012420?v=4","gravatar_id":"","url":"https://api.github.com/users/oshadura","html_url":"https://github.com/oshadura","followers_url":"https://api.github.com/users/oshadura/followers","following_url":"https://api.github.com/users/oshadura/following{/other_user}","gists_url":"https://api.github.com/users/oshadura/gists{/gist_id}","starred_url":"https://api.github.com/users/oshadura/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oshadura/subscriptions","organizations_url":"https://api.github.com/users/oshadura/orgs","repos_url":"https://api.github.com/users/oshadura/repos","events_url":"https://api.github.com/users/oshadura/events{/privacy}","received_events_url":"https://api.github.com/users/oshadura/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":651918276,"node_id":"MDU6TGFiZWw2NTE5MTgyNzY=","url":"https://api.github.com/repos/root-project/root/labels/needs%20review","name":"needs review","color":"fef2c0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/root-project/root/pulls/2137/commits","review_comments_url":"https://api.github.com/repos/root-project/root/pulls/2137/comments","review_comment_url":"https://api.github.com/repos/root-project/root/pulls/comments{/number}","comments_url":"https://api.github.com/repos/root-project/root/issues/2137/comments","statuses_url":"https://api.github.com/repos/root-project/root/statuses/cc338ca63144086c9c8098c25e85027e35e48ed4","head":{"label":"yamaguchi1024:vector","ref":"vector","sha":"cc338ca63144086c9c8098c25e85027e35e48ed4","user":{"login":"yamaguchi1024","id":12247908,"node_id":"MDQ6VXNlcjEyMjQ3OTA4","avatar_url":"https://avatars0.githubusercontent.com/u/12247908?v=4","gravatar_id":"","url":"https://api.github.com/users/yamaguchi1024","html_url":"https://github.com/yamaguchi1024","followers_url":"https://api.github.com/users/yamaguchi1024/followers","following_url":"https://api.github.com/users/yamaguchi1024/following{/other_user}","gists_url":"https://api.github.com/users/yamaguchi1024/gists{/gist_id}","starred_url":"https://api.github.com/users/yamaguchi1024/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yamaguchi1024/subscriptions","organizations_url":"https://api.github.com/users/yamaguchi1024/orgs","repos_url":"https://api.github.com/users/yamaguchi1024/repos","events_url":"https://api.github.com/users/yamaguchi1024/events{/privacy}","received_events_url":"https://api.github.com/users/yamaguchi1024/received_events","type":"User","site_admin":false},"repo":{"id":123582891,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM1ODI4OTE=","name":"root","full_name":"yamaguchi1024/root","owner":{"login":"yamaguchi1024","id":12247908,"node_id":"MDQ6VXNlcjEyMjQ3OTA4","avatar_url":"https://avatars0.githubusercontent.com/u/12247908?v=4","gravatar_id":"","url":"https://api.github.com/users/yamaguchi1024","html_url":"https://github.com/yamaguchi1024","followers_url":"https://api.github.com/users/yamaguchi1024/followers","following_url":"https://api.github.com/users/yamaguchi1024/following{/other_user}","gists_url":"https://api.github.com/users/yamaguchi1024/gists{/gist_id}","starred_url":"https://api.github.com/users/yamaguchi1024/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yamaguchi1024/subscriptions","organizations_url":"https://api.github.com/users/yamaguchi1024/orgs","repos_url":"https://api.github.com/users/yamaguchi1024/repos","events_url":"https://api.github.com/users/yamaguchi1024/events{/privacy}","received_events_url":"https://api.github.com/users/yamaguchi1024/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yamaguchi1024/root","description":"The official ROOT repository","fork":true,"url":"https://api.github.com/repos/yamaguchi1024/root","forks_url":"https://api.github.com/repos/yamaguchi1024/root/forks","keys_url":"https://api.github.com/repos/yamaguchi1024/root/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yamaguchi1024/root/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yamaguchi1024/root/teams","hooks_url":"https://api.github.com/repos/yamaguchi1024/root/hooks","issue_events_url":"https://api.github.com/repos/yamaguchi1024/root/issues/events{/number}","events_url":"https://api.github.com/repos/yamaguchi1024/root/events","assignees_url":"https://api.github.com/repos/yamaguchi1024/root/assignees{/user}","branches_url":"https://api.github.com/repos/yamaguchi1024/root/branches{/branch}","tags_url":"https://api.github.com/repos/yamaguchi1024/root/tags","blobs_url":"https://api.github.com/repos/yamaguchi1024/root/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yamaguchi1024/root/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yamaguchi1024/root/git/refs{/sha}","trees_url":"https://api.github.com/repos/yamaguchi1024/root/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yamaguchi1024/root/statuses/{sha}","languages_url":"https://api.github.com/repos/yamaguchi1024/root/languages","stargazers_url":"https://api.github.com/repos/yamaguchi1024/root/stargazers","contributors_url":"https://api.github.com/repos/yamaguchi1024/root/contributors","subscribers_url":"https://api.github.com/repos/yamaguchi1024/root/subscribers","subscription_url":"https://api.github.com/repos/yamaguchi1024/root/subscription","commits_url":"https://api.github.com/repos/yamaguchi1024/root/commits{/sha}","git_commits_url":"https://api.github.com/repos/yamaguchi1024/root/git/commits{/sha}","comments_url":"https://api.github.com/repos/yamaguchi1024/root/comments{/number}","issue_comment_url":"https://api.github.com/repos/yamaguchi1024/root/issues/comments{/number}","contents_url":"https://api.github.com/repos/yamaguchi1024/root/contents/{+path}","compare_url":"https://api.github.com/repos/yamaguchi1024/root/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yamaguchi1024/root/merges","archive_url":"https://api.github.com/repos/yamaguchi1024/root/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yamaguchi1024/root/downloads","issues_url":"https://api.github.com/repos/yamaguchi1024/root/issues{/number}","pulls_url":"https://api.github.com/repos/yamaguchi1024/root/pulls{/number}","milestones_url":"https://api.github.com/repos/yamaguchi1024/root/milestones{/number}","notifications_url":"https://api.github.com/repos/yamaguchi1024/root/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yamaguchi1024/root/labels{/name}","releases_url":"https://api.github.com/repos/yamaguchi1024/root/releases{/id}","deployments_url":"https://api.github.com/repos/yamaguchi1024/root/deployments","created_at":"2018-03-02T13:33:28Z","updated_at":"2018-06-12T20:20:22Z","pushed_at":"2018-06-12T21:36:23Z","git_url":"git://github.com/yamaguchi1024/root.git","ssh_url":"git@github.com:yamaguchi1024/root.git","clone_url":"https://github.com/yamaguchi1024/root.git","svn_url":"https://github.com/yamaguchi1024/root","homepage":"https://root.cern","size":695619,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"root-project:master","ref":"master","sha":"b646b9bd748654590aecf7794e5900c0e51f8c72","user":{"login":"root-project","id":6450093,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NTAwOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/6450093?v=4","gravatar_id":"","url":"https://api.github.com/users/root-project","html_url":"https://github.com/root-project","followers_url":"https://api.github.com/users/root-project/followers","following_url":"https://api.github.com/users/root-project/following{/other_user}","gists_url":"https://api.github.com/users/root-project/gists{/gist_id}","starred_url":"https://api.github.com/users/root-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/root-project/subscriptions","organizations_url":"https://api.github.com/users/root-project/orgs","repos_url":"https://api.github.com/users/root-project/repos","events_url":"https://api.github.com/users/root-project/events{/privacy}","received_events_url":"https://api.github.com/users/root-project/received_events","type":"Organization","site_admin":false},"repo":{"id":10994345,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk5NDM0NQ==","name":"root","full_name":"root-project/root","owner":{"login":"root-project","id":6450093,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NTAwOTM=","avatar_url":"https://avatars1.githubusercontent.com/u/6450093?v=4","gravatar_id":"","url":"https://api.github.com/users/root-project","html_url":"https://github.com/root-project","followers_url":"https://api.github.com/users/root-project/followers","following_url":"https://api.github.com/users/root-project/following{/other_user}","gists_url":"https://api.github.com/users/root-project/gists{/gist_id}","starred_url":"https://api.github.com/users/root-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/root-project/subscriptions","organizations_url":"https://api.github.com/users/root-project/orgs","repos_url":"https://api.github.com/users/root-project/repos","events_url":"https://api.github.com/users/root-project/events{/privacy}","received_events_url":"https://api.github.com/users/root-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/root-project/root","description":"The official repository for ROOT: analyzing, storing and visualizing big data","fork":false,"url":"https://api.github.com/repos/root-project/root","forks_url":"https://api.github.com/repos/root-project/root/forks","keys_url":"https://api.github.com/repos/root-project/root/keys{/key_id}","collaborators_url":"https://api.github.com/repos/root-project/root/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/root-project/root/teams","hooks_url":"https://api.github.com/repos/root-project/root/hooks","issue_events_url":"https://api.github.com/repos/root-project/root/issues/events{/number}","events_url":"https://api.github.com/repos/root-project/root/events","assignees_url":"https://api.github.com/repos/root-project/root/assignees{/user}","branches_url":"https://api.github.com/repos/root-project/root/branches{/branch}","tags_url":"https://api.github.com/repos/root-project/root/tags","blobs_url":"https://api.github.com/repos/root-project/root/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/root-project/root/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/root-project/root/git/refs{/sha}","trees_url":"https://api.github.com/repos/root-project/root/git/trees{/sha}","statuses_url":"https://api.github.com/repos/root-project/root/statuses/{sha}","languages_url":"https://api.github.com/repos/root-project/root/languages","stargazers_url":"https://api.github.com/repos/root-project/root/stargazers","contributors_url":"https://api.github.com/repos/root-project/root/contributors","subscribers_url":"https://api.github.com/repos/root-project/root/subscribers","subscription_url":"https://api.github.com/repos/root-project/root/subscription","commits_url":"https://api.github.com/repos/root-project/root/commits{/sha}","git_commits_url":"https://api.github.com/repos/root-project/root/git/commits{/sha}","comments_url":"https://api.github.com/repos/root-project/root/comments{/number}","issue_comment_url":"https://api.github.com/repos/root-project/root/issues/comments{/number}","contents_url":"https://api.github.com/repos/root-project/root/contents/{+path}","compare_url":"https://api.github.com/repos/root-project/root/compare/{base}...{head}","merges_url":"https://api.github.com/repos/root-project/root/merges","archive_url":"https://api.github.com/repos/root-project/root/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/root-project/root/downloads","issues_url":"https://api.github.com/repos/root-project/root/issues{/number}","pulls_url":"https://api.github.com/repos/root-project/root/pulls{/number}","milestones_url":"https://api.github.com/repos/root-project/root/milestones{/number}","notifications_url":"https://api.github.com/repos/root-project/root/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/root-project/root/labels{/name}","releases_url":"https://api.github.com/repos/root-project/root/releases{/id}","deployments_url":"https://api.github.com/repos/root-project/root/deployments","created_at":"2013-06-27T10:46:59Z","updated_at":"2018-06-13T05:19:59Z","pushed_at":"2018-06-12T21:36:25Z","git_url":"git://github.com/root-project/root.git","ssh_url":"git@github.com:root-project/root.git","clone_url":"https://github.com/root-project/root.git","svn_url":"https://github.com/root-project/root","homepage":"https://root.cern","size":696052,"stargazers_count":588,"watchers_count":588,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":428,"mirror_url":null,"archived":false,"open_issues_count":57,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":428,"open_issues":57,"watchers":588,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/root-project/root/pulls/2137"},"html":{"href":"https://github.com/root-project/root/pull/2137"},"issue":{"href":"https://api.github.com/repos/root-project/root/issues/2137"},"comments":{"href":"https://api.github.com/repos/root-project/root/issues/2137/comments"},"review_comments":{"href":"https://api.github.com/repos/root-project/root/pulls/2137/comments"},"review_comment":{"href":"https://api.github.com/repos/root-project/root/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/root-project/root/pulls/2137/commits"},"statuses":{"href":"https://api.github.com/repos/root-project/root/statuses/cc338ca63144086c9c8098c25e85027e35e48ed4"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"vgvassilev"}}