{"action":"created","comment":{"url":"https://api.github.com/repos/D3-AI/Cardea/pulls/comments/227077700","pull_request_review_id":167036697,"id":227077700,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzA3NzcwMA==","diff_hunk":"@@ -9,51 +9,53 @@ class MissedAppointmentProblemDefinition (ProblemDefinition):\n     Attributes:\n         target_label: The target label of the prediction problem.\n         target_entity: The entity name which contains the target label.\n+        cutoff_time_label: The cutoff time label of the prediction problem\n+        cutoff_entity: The entity name in which it contains the cutoff time label.\n         prediction_type: The type of the machine learning prediction.\n     \"\"\"\n \n-    global target_label\n-    global target_entity\n-\n     target_label = 'status'\n     target_entity = 'Appointment'\n     prediction_type = 'classification'\n+    cutoff_time_label = 'created'\n+    cutoff_entity = target_entity\n \n     def generate_cutoff_times(self, entity_set):\n         \"\"\"Generates cutoff times for the predection problem.\n \n         Args:\n-            entity_set: FHIR entityset.\n+            entity_set: fhir entityset.\n \n         Returns:\n-            entity_set, target_entity, target_label and a dataframe of cutoff_times\n+            entity_set, target_entity, Series of target_label and a dataframe of cutoff_times","path":"cardea/problem_definition/show_noshow_appointment.py","position":27,"original_position":27,"commit_id":"2219a35604898f6ac70be6b7ed54f0805cab4853","original_commit_id":"2219a35604898f6ac70be6b7ed54f0805cab4853","user":{"login":"bryanfarris","id":1606844,"node_id":"MDQ6VXNlcjE2MDY4NDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1606844?v=4","gravatar_id":"","url":"https://api.github.com/users/bryanfarris","html_url":"https://github.com/bryanfarris","followers_url":"https://api.github.com/users/bryanfarris/followers","following_url":"https://api.github.com/users/bryanfarris/following{/other_user}","gists_url":"https://api.github.com/users/bryanfarris/gists{/gist_id}","starred_url":"https://api.github.com/users/bryanfarris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bryanfarris/subscriptions","organizations_url":"https://api.github.com/users/bryanfarris/orgs","repos_url":"https://api.github.com/users/bryanfarris/repos","events_url":"https://api.github.com/users/bryanfarris/events{/privacy}","received_events_url":"https://api.github.com/users/bryanfarris/received_events","type":"User","site_admin":false},"body":"```suggestion\r\n            entity_set, target_entity, series of target_labels and a dataframe of cutoff_times\r\n```","created_at":"2018-10-22T18:10:10Z","updated_at":"2018-10-22T18:18:13Z","html_url":"https://github.com/D3-AI/Cardea/pull/8#discussion_r227077700","pull_request_url":"https://api.github.com/repos/D3-AI/Cardea/pulls/8","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/D3-AI/Cardea/pulls/comments/227077700"},"html":{"href":"https://github.com/D3-AI/Cardea/pull/8#discussion_r227077700"},"pull_request":{"href":"https://api.github.com/repos/D3-AI/Cardea/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/D3-AI/Cardea/pulls/8","id":222968764,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyOTY4NzY0","html_url":"https://github.com/D3-AI/Cardea/pull/8","diff_url":"https://github.com/D3-AI/Cardea/pull/8.diff","patch_url":"https://github.com/D3-AI/Cardea/pull/8.patch","issue_url":"https://api.github.com/repos/D3-AI/Cardea/issues/8","number":8,"state":"open","locked":false,"title":"Problem definition","user":{"login":"ShahadThobaiti","id":35901600,"node_id":"MDQ6VXNlcjM1OTAxNjAw","avatar_url":"https://avatars0.githubusercontent.com/u/35901600?v=4","gravatar_id":"","url":"https://api.github.com/users/ShahadThobaiti","html_url":"https://github.com/ShahadThobaiti","followers_url":"https://api.github.com/users/ShahadThobaiti/followers","following_url":"https://api.github.com/users/ShahadThobaiti/following{/other_user}","gists_url":"https://api.github.com/users/ShahadThobaiti/gists{/gist_id}","starred_url":"https://api.github.com/users/ShahadThobaiti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShahadThobaiti/subscriptions","organizations_url":"https://api.github.com/users/ShahadThobaiti/orgs","repos_url":"https://api.github.com/users/ShahadThobaiti/repos","events_url":"https://api.github.com/users/ShahadThobaiti/events{/privacy}","received_events_url":"https://api.github.com/users/ShahadThobaiti/received_events","type":"User","site_admin":false},"body":"Added new prediction problem definition.","created_at":"2018-10-15T16:33:23Z","updated_at":"2018-10-22T18:18:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d192f00a2be4d3ee81c3ea4de0633a9aac7ef98b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/D3-AI/Cardea/pulls/8/commits","review_comments_url":"https://api.github.com/repos/D3-AI/Cardea/pulls/8/comments","review_comment_url":"https://api.github.com/repos/D3-AI/Cardea/pulls/comments{/number}","comments_url":"https://api.github.com/repos/D3-AI/Cardea/issues/8/comments","statuses_url":"https://api.github.com/repos/D3-AI/Cardea/statuses/2219a35604898f6ac70be6b7ed54f0805cab4853","head":{"label":"D3-AI:problem_definition","ref":"problem_definition","sha":"2219a35604898f6ac70be6b7ed54f0805cab4853","user":{"login":"D3-AI","id":13336772,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzM2Nzcy","avatar_url":"https://avatars1.githubusercontent.com/u/13336772?v=4","gravatar_id":"","url":"https://api.github.com/users/D3-AI","html_url":"https://github.com/D3-AI","followers_url":"https://api.github.com/users/D3-AI/followers","following_url":"https://api.github.com/users/D3-AI/following{/other_user}","gists_url":"https://api.github.com/users/D3-AI/gists{/gist_id}","starred_url":"https://api.github.com/users/D3-AI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D3-AI/subscriptions","organizations_url":"https://api.github.com/users/D3-AI/orgs","repos_url":"https://api.github.com/users/D3-AI/repos","events_url":"https://api.github.com/users/D3-AI/events{/privacy}","received_events_url":"https://api.github.com/users/D3-AI/received_events","type":"Organization","site_admin":false},"repo":{"id":142302922,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIzMDI5MjI=","name":"Cardea","full_name":"D3-AI/Cardea","private":false,"owner":{"login":"D3-AI","id":13336772,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzM2Nzcy","avatar_url":"https://avatars1.githubusercontent.com/u/13336772?v=4","gravatar_id":"","url":"https://api.github.com/users/D3-AI","html_url":"https://github.com/D3-AI","followers_url":"https://api.github.com/users/D3-AI/followers","following_url":"https://api.github.com/users/D3-AI/following{/other_user}","gists_url":"https://api.github.com/users/D3-AI/gists{/gist_id}","starred_url":"https://api.github.com/users/D3-AI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D3-AI/subscriptions","organizations_url":"https://api.github.com/users/D3-AI/orgs","repos_url":"https://api.github.com/users/D3-AI/repos","events_url":"https://api.github.com/users/D3-AI/events{/privacy}","received_events_url":"https://api.github.com/users/D3-AI/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/D3-AI/Cardea","description":"Cardea","fork":false,"url":"https://api.github.com/repos/D3-AI/Cardea","forks_url":"https://api.github.com/repos/D3-AI/Cardea/forks","keys_url":"https://api.github.com/repos/D3-AI/Cardea/keys{/key_id}","collaborators_url":"https://api.github.com/repos/D3-AI/Cardea/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/D3-AI/Cardea/teams","hooks_url":"https://api.github.com/repos/D3-AI/Cardea/hooks","issue_events_url":"https://api.github.com/repos/D3-AI/Cardea/issues/events{/number}","events_url":"https://api.github.com/repos/D3-AI/Cardea/events","assignees_url":"https://api.github.com/repos/D3-AI/Cardea/assignees{/user}","branches_url":"https://api.github.com/repos/D3-AI/Cardea/branches{/branch}","tags_url":"https://api.github.com/repos/D3-AI/Cardea/tags","blobs_url":"https://api.github.com/repos/D3-AI/Cardea/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/D3-AI/Cardea/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/D3-AI/Cardea/git/refs{/sha}","trees_url":"https://api.github.com/repos/D3-AI/Cardea/git/trees{/sha}","statuses_url":"https://api.github.com/repos/D3-AI/Cardea/statuses/{sha}","languages_url":"https://api.github.com/repos/D3-AI/Cardea/languages","stargazers_url":"https://api.github.com/repos/D3-AI/Cardea/stargazers","contributors_url":"https://api.github.com/repos/D3-AI/Cardea/contributors","subscribers_url":"https://api.github.com/repos/D3-AI/Cardea/subscribers","subscription_url":"https://api.github.com/repos/D3-AI/Cardea/subscription","commits_url":"https://api.github.com/repos/D3-AI/Cardea/commits{/sha}","git_commits_url":"https://api.github.com/repos/D3-AI/Cardea/git/commits{/sha}","comments_url":"https://api.github.com/repos/D3-AI/Cardea/comments{/number}","issue_comment_url":"https://api.github.com/repos/D3-AI/Cardea/issues/comments{/number}","contents_url":"https://api.github.com/repos/D3-AI/Cardea/contents/{+path}","compare_url":"https://api.github.com/repos/D3-AI/Cardea/compare/{base}...{head}","merges_url":"https://api.github.com/repos/D3-AI/Cardea/merges","archive_url":"https://api.github.com/repos/D3-AI/Cardea/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/D3-AI/Cardea/downloads","issues_url":"https://api.github.com/repos/D3-AI/Cardea/issues{/number}","pulls_url":"https://api.github.com/repos/D3-AI/Cardea/pulls{/number}","milestones_url":"https://api.github.com/repos/D3-AI/Cardea/milestones{/number}","notifications_url":"https://api.github.com/repos/D3-AI/Cardea/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/D3-AI/Cardea/labels{/name}","releases_url":"https://api.github.com/repos/D3-AI/Cardea/releases{/id}","deployments_url":"https://api.github.com/repos/D3-AI/Cardea/deployments","created_at":"2018-07-25T13:21:33Z","updated_at":"2018-10-04T13:17:42Z","pushed_at":"2018-10-18T16:53:01Z","git_url":"git://github.com/D3-AI/Cardea.git","ssh_url":"git@github.com:D3-AI/Cardea.git","clone_url":"https://github.com/D3-AI/Cardea.git","svn_url":"https://github.com/D3-AI/Cardea","homepage":null,"size":7424,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":3,"watchers":1,"default_branch":"master"}},"base":{"label":"D3-AI:master","ref":"master","sha":"4a868faad52cc73e753d18582eae2fd41fbc4f53","user":{"login":"D3-AI","id":13336772,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzM2Nzcy","avatar_url":"https://avatars1.githubusercontent.com/u/13336772?v=4","gravatar_id":"","url":"https://api.github.com/users/D3-AI","html_url":"https://github.com/D3-AI","followers_url":"https://api.github.com/users/D3-AI/followers","following_url":"https://api.github.com/users/D3-AI/following{/other_user}","gists_url":"https://api.github.com/users/D3-AI/gists{/gist_id}","starred_url":"https://api.github.com/users/D3-AI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D3-AI/subscriptions","organizations_url":"https://api.github.com/users/D3-AI/orgs","repos_url":"https://api.github.com/users/D3-AI/repos","events_url":"https://api.github.com/users/D3-AI/events{/privacy}","received_events_url":"https://api.github.com/users/D3-AI/received_events","type":"Organization","site_admin":false},"repo":{"id":142302922,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIzMDI5MjI=","name":"Cardea","full_name":"D3-AI/Cardea","private":false,"owner":{"login":"D3-AI","id":13336772,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzM2Nzcy","avatar_url":"https://avatars1.githubusercontent.com/u/13336772?v=4","gravatar_id":"","url":"https://api.github.com/users/D3-AI","html_url":"https://github.com/D3-AI","followers_url":"https://api.github.com/users/D3-AI/followers","following_url":"https://api.github.com/users/D3-AI/following{/other_user}","gists_url":"https://api.github.com/users/D3-AI/gists{/gist_id}","starred_url":"https://api.github.com/users/D3-AI/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/D3-AI/subscriptions","organizations_url":"https://api.github.com/users/D3-AI/orgs","repos_url":"https://api.github.com/users/D3-AI/repos","events_url":"https://api.github.com/users/D3-AI/events{/privacy}","received_events_url":"https://api.github.com/users/D3-AI/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/D3-AI/Cardea","description":"Cardea","fork":false,"url":"https://api.github.com/repos/D3-AI/Cardea","forks_url":"https://api.github.com/repos/D3-AI/Cardea/forks","keys_url":"https://api.github.com/repos/D3-AI/Cardea/keys{/key_id}","collaborators_url":"https://api.github.com/repos/D3-AI/Cardea/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/D3-AI/Cardea/teams","hooks_url":"https://api.github.com/repos/D3-AI/Cardea/hooks","issue_events_url":"https://api.github.com/repos/D3-AI/Cardea/issues/events{/number}","events_url":"https://api.github.com/repos/D3-AI/Cardea/events","assignees_url":"https://api.github.com/repos/D3-AI/Cardea/assignees{/user}","branches_url":"https://api.github.com/repos/D3-AI/Cardea/branches{/branch}","tags_url":"https://api.github.com/repos/D3-AI/Cardea/tags","blobs_url":"https://api.github.com/repos/D3-AI/Cardea/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/D3-AI/Cardea/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/D3-AI/Cardea/git/refs{/sha}","trees_url":"https://api.github.com/repos/D3-AI/Cardea/git/trees{/sha}","statuses_url":"https://api.github.com/repos/D3-AI/Cardea/statuses/{sha}","languages_url":"https://api.github.com/repos/D3-AI/Cardea/languages","stargazers_url":"https://api.github.com/repos/D3-AI/Cardea/stargazers","contributors_url":"https://api.github.com/repos/D3-AI/Cardea/contributors","subscribers_url":"https://api.github.com/repos/D3-AI/Cardea/subscribers","subscription_url":"https://api.github.com/repos/D3-AI/Cardea/subscription","commits_url":"https://api.github.com/repos/D3-AI/Cardea/commits{/sha}","git_commits_url":"https://api.github.com/repos/D3-AI/Cardea/git/commits{/sha}","comments_url":"https://api.github.com/repos/D3-AI/Cardea/comments{/number}","issue_comment_url":"https://api.github.com/repos/D3-AI/Cardea/issues/comments{/number}","contents_url":"https://api.github.com/repos/D3-AI/Cardea/contents/{+path}","compare_url":"https://api.github.com/repos/D3-AI/Cardea/compare/{base}...{head}","merges_url":"https://api.github.com/repos/D3-AI/Cardea/merges","archive_url":"https://api.github.com/repos/D3-AI/Cardea/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/D3-AI/Cardea/downloads","issues_url":"https://api.github.com/repos/D3-AI/Cardea/issues{/number}","pulls_url":"https://api.github.com/repos/D3-AI/Cardea/pulls{/number}","milestones_url":"https://api.github.com/repos/D3-AI/Cardea/milestones{/number}","notifications_url":"https://api.github.com/repos/D3-AI/Cardea/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/D3-AI/Cardea/labels{/name}","releases_url":"https://api.github.com/repos/D3-AI/Cardea/releases{/id}","deployments_url":"https://api.github.com/repos/D3-AI/Cardea/deployments","created_at":"2018-07-25T13:21:33Z","updated_at":"2018-10-04T13:17:42Z","pushed_at":"2018-10-18T16:53:01Z","git_url":"git://github.com/D3-AI/Cardea.git","ssh_url":"git@github.com:D3-AI/Cardea.git","clone_url":"https://github.com/D3-AI/Cardea.git","svn_url":"https://github.com/D3-AI/Cardea","homepage":null,"size":7424,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/D3-AI/Cardea/pulls/8"},"html":{"href":"https://github.com/D3-AI/Cardea/pull/8"},"issue":{"href":"https://api.github.com/repos/D3-AI/Cardea/issues/8"},"comments":{"href":"https://api.github.com/repos/D3-AI/Cardea/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/D3-AI/Cardea/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/D3-AI/Cardea/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/D3-AI/Cardea/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/D3-AI/Cardea/statuses/2219a35604898f6ac70be6b7ed54f0805cab4853"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bryanfarris"}}