{"action":"created","comment":{"url":"https://api.github.com/repos/w3c/web-platform-tests/pulls/comments/185015176","pull_request_review_id":116321510,"id":185015176,"diff_hunk":"@@ -59,8 +59,16 @@ def setup(self):\n         self.marionette = self.parent.marionette\n \n     def execute_script(self, script, async=False):\n-        method = self.marionette.execute_async_script if async else self.marionette.execute_script\n-        return method(script, new_sandbox=False)\n+        body = {\n+            \"script\": script.strip(),\n+            \"args\": [],\n+            \"newSandbox\": False,\n+            \"specialPowers\": None,\n+            \"scriptTimeout\": None\n+        }\n+        method = \"WebDriver:ExecuteAsyncScript\" if async else \"WebDriver:ExecuteScript\"\n+        rv = self.marionette._send_message(method, body, key=\"value\")\n+        return self.marionette._from_json(rv)","path":"tools/wptrunner/wptrunner/executors/executormarionette.py","position":15,"original_position":15,"commit_id":"6c9590284b382d120fed785c1f164cce6f883a00","original_commit_id":"6c9590284b382d120fed785c1f164cce6f883a00","user":{"login":"whimboo","id":129603,"avatar_url":"https://avatars2.githubusercontent.com/u/129603?v=4","gravatar_id":"","url":"https://api.github.com/users/whimboo","html_url":"https://github.com/whimboo","followers_url":"https://api.github.com/users/whimboo/followers","following_url":"https://api.github.com/users/whimboo/following{/other_user}","gists_url":"https://api.github.com/users/whimboo/gists{/gist_id}","starred_url":"https://api.github.com/users/whimboo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/whimboo/subscriptions","organizations_url":"https://api.github.com/users/whimboo/orgs","repos_url":"https://api.github.com/users/whimboo/repos","events_url":"https://api.github.com/users/whimboo/events{/privacy}","received_events_url":"https://api.github.com/users/whimboo/received_events","type":"User","site_admin":false},"body":"I don't know all this code at all, so maybe I'm not the best reviewer. But I want to state that using the private message `_send_message` from Marionette isn't what I want to see. Can you please explain why this is necessary? \r\n\r\nAlso note that a script timeout of None will result in a hang if something goes wrong in a call to an async script.","created_at":"2018-04-30T15:09:03Z","updated_at":"2018-04-30T15:09:03Z","html_url":"https://github.com/w3c/web-platform-tests/pull/10691#discussion_r185015176","pull_request_url":"https://api.github.com/repos/w3c/web-platform-tests/pulls/10691","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/w3c/web-platform-tests/pulls/comments/185015176"},"html":{"href":"https://github.com/w3c/web-platform-tests/pull/10691#discussion_r185015176"},"pull_request":{"href":"https://api.github.com/repos/w3c/web-platform-tests/pulls/10691"}}},"pull_request":{"url":"https://api.github.com/repos/w3c/web-platform-tests/pulls/10691","id":184689289,"html_url":"https://github.com/w3c/web-platform-tests/pull/10691","diff_url":"https://github.com/w3c/web-platform-tests/pull/10691.diff","patch_url":"https://github.com/w3c/web-platform-tests/pull/10691.patch","issue_url":"https://api.github.com/repos/w3c/web-platform-tests/issues/10691","number":10691,"state":"open","locked":false,"title":"Complete the migration from marionette-specific scripts.","user":{"login":"jgraham","id":294864,"avatar_url":"https://avatars1.githubusercontent.com/u/294864?v=4","gravatar_id":"","url":"https://api.github.com/users/jgraham","html_url":"https://github.com/jgraham","followers_url":"https://api.github.com/users/jgraham/followers","following_url":"https://api.github.com/users/jgraham/following{/other_user}","gists_url":"https://api.github.com/users/jgraham/gists{/gist_id}","starred_url":"https://api.github.com/users/jgraham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgraham/subscriptions","organizations_url":"https://api.github.com/users/jgraham/orgs","repos_url":"https://api.github.com/users/jgraham/repos","events_url":"https://api.github.com/users/jgraham/events{/privacy}","received_events_url":"https://api.github.com/users/jgraham/received_events","type":"User","site_admin":false},"body":"Previously we removed the wrappedJSObject from\r\nexecutor_marionette.js. However it turns out that this migration was\r\nincomplete; in order to fully avoid the wrappedJSObject, we need to\r\nensure that we never create a sandbox on the marionette side. As a\r\nresult of this omission we were getting an error trying to call the\r\ntimeout() function, causing more EXTERNAL-TIMEOUTs and so performance\r\nissues.\r\n\r\nThe solution is to use the same approach as geckodriver, which isn't\r\nexposed through the js marionette client. Essentially we have to\r\nensure that the sandbox is None for all calls to (content) js. Since\r\nthis isn't exposed in the client we construct the message directly and\r\nensure that all calls to content js co through the base protocolpart\r\nrather than calling marionette.execute_* directly.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/w3c/web-platform-tests/10691)\n<!-- Reviewable:end -->\n","created_at":"2018-04-27T18:03:13Z","updated_at":"2018-04-30T15:09:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"53aafde5a6b543f44256c6a99aa289b368a9507f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"gsnedders","id":176218,"avatar_url":"https://avatars2.githubusercontent.com/u/176218?v=4","gravatar_id":"","url":"https://api.github.com/users/gsnedders","html_url":"https://github.com/gsnedders","followers_url":"https://api.github.com/users/gsnedders/followers","following_url":"https://api.github.com/users/gsnedders/following{/other_user}","gists_url":"https://api.github.com/users/gsnedders/gists{/gist_id}","starred_url":"https://api.github.com/users/gsnedders/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsnedders/subscriptions","organizations_url":"https://api.github.com/users/gsnedders/orgs","repos_url":"https://api.github.com/users/gsnedders/repos","events_url":"https://api.github.com/users/gsnedders/events{/privacy}","received_events_url":"https://api.github.com/users/gsnedders/received_events","type":"User","site_admin":false},{"login":"mjzffr","id":6024326,"avatar_url":"https://avatars2.githubusercontent.com/u/6024326?v=4","gravatar_id":"","url":"https://api.github.com/users/mjzffr","html_url":"https://github.com/mjzffr","followers_url":"https://api.github.com/users/mjzffr/followers","following_url":"https://api.github.com/users/mjzffr/following{/other_user}","gists_url":"https://api.github.com/users/mjzffr/gists{/gist_id}","starred_url":"https://api.github.com/users/mjzffr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjzffr/subscriptions","organizations_url":"https://api.github.com/users/mjzffr/orgs","repos_url":"https://api.github.com/users/mjzffr/repos","events_url":"https://api.github.com/users/mjzffr/events{/privacy}","received_events_url":"https://api.github.com/users/mjzffr/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":45230790,"url":"https://api.github.com/repos/w3c/web-platform-tests/labels/infra","name":"infra","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/w3c/web-platform-tests/pulls/10691/commits","review_comments_url":"https://api.github.com/repos/w3c/web-platform-tests/pulls/10691/comments","review_comment_url":"https://api.github.com/repos/w3c/web-platform-tests/pulls/comments{/number}","comments_url":"https://api.github.com/repos/w3c/web-platform-tests/issues/10691/comments","statuses_url":"https://api.github.com/repos/w3c/web-platform-tests/statuses/6c9590284b382d120fed785c1f164cce6f883a00","head":{"label":"w3c:marionette_sandbox_fixes","ref":"marionette_sandbox_fixes","sha":"6c9590284b382d120fed785c1f164cce6f883a00","user":{"login":"w3c","id":379216,"avatar_url":"https://avatars2.githubusercontent.com/u/379216?v=4","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"repo":{"id":3618133,"name":"web-platform-tests","full_name":"w3c/web-platform-tests","owner":{"login":"w3c","id":379216,"avatar_url":"https://avatars2.githubusercontent.com/u/379216?v=4","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/w3c/web-platform-tests","description":"Test suites for Web-platform specs — including WHATWG, W3C, and others","fork":false,"url":"https://api.github.com/repos/w3c/web-platform-tests","forks_url":"https://api.github.com/repos/w3c/web-platform-tests/forks","keys_url":"https://api.github.com/repos/w3c/web-platform-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/w3c/web-platform-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/w3c/web-platform-tests/teams","hooks_url":"https://api.github.com/repos/w3c/web-platform-tests/hooks","issue_events_url":"https://api.github.com/repos/w3c/web-platform-tests/issues/events{/number}","events_url":"https://api.github.com/repos/w3c/web-platform-tests/events","assignees_url":"https://api.github.com/repos/w3c/web-platform-tests/assignees{/user}","branches_url":"https://api.github.com/repos/w3c/web-platform-tests/branches{/branch}","tags_url":"https://api.github.com/repos/w3c/web-platform-tests/tags","blobs_url":"https://api.github.com/repos/w3c/web-platform-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/w3c/web-platform-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/w3c/web-platform-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/w3c/web-platform-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/w3c/web-platform-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/w3c/web-platform-tests/languages","stargazers_url":"https://api.github.com/repos/w3c/web-platform-tests/stargazers","contributors_url":"https://api.github.com/repos/w3c/web-platform-tests/contributors","subscribers_url":"https://api.github.com/repos/w3c/web-platform-tests/subscribers","subscription_url":"https://api.github.com/repos/w3c/web-platform-tests/subscription","commits_url":"https://api.github.com/repos/w3c/web-platform-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/w3c/web-platform-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/w3c/web-platform-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/w3c/web-platform-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/w3c/web-platform-tests/contents/{+path}","compare_url":"https://api.github.com/repos/w3c/web-platform-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/w3c/web-platform-tests/merges","archive_url":"https://api.github.com/repos/w3c/web-platform-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/w3c/web-platform-tests/downloads","issues_url":"https://api.github.com/repos/w3c/web-platform-tests/issues{/number}","pulls_url":"https://api.github.com/repos/w3c/web-platform-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/w3c/web-platform-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/w3c/web-platform-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/w3c/web-platform-tests/labels{/name}","releases_url":"https://api.github.com/repos/w3c/web-platform-tests/releases{/id}","deployments_url":"https://api.github.com/repos/w3c/web-platform-tests/deployments","created_at":"2012-03-04T12:58:11Z","updated_at":"2018-04-30T14:36:15Z","pushed_at":"2018-04-30T14:53:24Z","git_url":"git://github.com/w3c/web-platform-tests.git","ssh_url":"git@github.com:w3c/web-platform-tests.git","clone_url":"https://github.com/w3c/web-platform-tests.git","svn_url":"https://github.com/w3c/web-platform-tests","homepage":"http://irc.w3.org/?channels=testing","size":291300,"stargazers_count":1560,"watchers_count":1560,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1404,"mirror_url":null,"archived":false,"open_issues_count":1181,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1404,"open_issues":1181,"watchers":1560,"default_branch":"master"}},"base":{"label":"w3c:master","ref":"master","sha":"e7523c1fd6ba45a326535caeefcf06a001bf2dca","user":{"login":"w3c","id":379216,"avatar_url":"https://avatars2.githubusercontent.com/u/379216?v=4","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"repo":{"id":3618133,"name":"web-platform-tests","full_name":"w3c/web-platform-tests","owner":{"login":"w3c","id":379216,"avatar_url":"https://avatars2.githubusercontent.com/u/379216?v=4","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/w3c/web-platform-tests","description":"Test suites for Web-platform specs — including WHATWG, W3C, and others","fork":false,"url":"https://api.github.com/repos/w3c/web-platform-tests","forks_url":"https://api.github.com/repos/w3c/web-platform-tests/forks","keys_url":"https://api.github.com/repos/w3c/web-platform-tests/keys{/key_id}","collaborators_url":"https://api.github.com/repos/w3c/web-platform-tests/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/w3c/web-platform-tests/teams","hooks_url":"https://api.github.com/repos/w3c/web-platform-tests/hooks","issue_events_url":"https://api.github.com/repos/w3c/web-platform-tests/issues/events{/number}","events_url":"https://api.github.com/repos/w3c/web-platform-tests/events","assignees_url":"https://api.github.com/repos/w3c/web-platform-tests/assignees{/user}","branches_url":"https://api.github.com/repos/w3c/web-platform-tests/branches{/branch}","tags_url":"https://api.github.com/repos/w3c/web-platform-tests/tags","blobs_url":"https://api.github.com/repos/w3c/web-platform-tests/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/w3c/web-platform-tests/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/w3c/web-platform-tests/git/refs{/sha}","trees_url":"https://api.github.com/repos/w3c/web-platform-tests/git/trees{/sha}","statuses_url":"https://api.github.com/repos/w3c/web-platform-tests/statuses/{sha}","languages_url":"https://api.github.com/repos/w3c/web-platform-tests/languages","stargazers_url":"https://api.github.com/repos/w3c/web-platform-tests/stargazers","contributors_url":"https://api.github.com/repos/w3c/web-platform-tests/contributors","subscribers_url":"https://api.github.com/repos/w3c/web-platform-tests/subscribers","subscription_url":"https://api.github.com/repos/w3c/web-platform-tests/subscription","commits_url":"https://api.github.com/repos/w3c/web-platform-tests/commits{/sha}","git_commits_url":"https://api.github.com/repos/w3c/web-platform-tests/git/commits{/sha}","comments_url":"https://api.github.com/repos/w3c/web-platform-tests/comments{/number}","issue_comment_url":"https://api.github.com/repos/w3c/web-platform-tests/issues/comments{/number}","contents_url":"https://api.github.com/repos/w3c/web-platform-tests/contents/{+path}","compare_url":"https://api.github.com/repos/w3c/web-platform-tests/compare/{base}...{head}","merges_url":"https://api.github.com/repos/w3c/web-platform-tests/merges","archive_url":"https://api.github.com/repos/w3c/web-platform-tests/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/w3c/web-platform-tests/downloads","issues_url":"https://api.github.com/repos/w3c/web-platform-tests/issues{/number}","pulls_url":"https://api.github.com/repos/w3c/web-platform-tests/pulls{/number}","milestones_url":"https://api.github.com/repos/w3c/web-platform-tests/milestones{/number}","notifications_url":"https://api.github.com/repos/w3c/web-platform-tests/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/w3c/web-platform-tests/labels{/name}","releases_url":"https://api.github.com/repos/w3c/web-platform-tests/releases{/id}","deployments_url":"https://api.github.com/repos/w3c/web-platform-tests/deployments","created_at":"2012-03-04T12:58:11Z","updated_at":"2018-04-30T14:36:15Z","pushed_at":"2018-04-30T14:53:24Z","git_url":"git://github.com/w3c/web-platform-tests.git","ssh_url":"git@github.com:w3c/web-platform-tests.git","clone_url":"https://github.com/w3c/web-platform-tests.git","svn_url":"https://github.com/w3c/web-platform-tests","homepage":"http://irc.w3.org/?channels=testing","size":291300,"stargazers_count":1560,"watchers_count":1560,"language":"HTML","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1404,"mirror_url":null,"archived":false,"open_issues_count":1181,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1404,"open_issues":1181,"watchers":1560,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/w3c/web-platform-tests/pulls/10691"},"html":{"href":"https://github.com/w3c/web-platform-tests/pull/10691"},"issue":{"href":"https://api.github.com/repos/w3c/web-platform-tests/issues/10691"},"comments":{"href":"https://api.github.com/repos/w3c/web-platform-tests/issues/10691/comments"},"review_comments":{"href":"https://api.github.com/repos/w3c/web-platform-tests/pulls/10691/comments"},"review_comment":{"href":"https://api.github.com/repos/w3c/web-platform-tests/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/w3c/web-platform-tests/pulls/10691/commits"},"statuses":{"href":"https://api.github.com/repos/w3c/web-platform-tests/statuses/6c9590284b382d120fed785c1f164cce6f883a00"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"whimboo"}}