{"action":"created","comment":{"url":"https://api.github.com/repos/REGoth-project/REGoth/pulls/comments/217853117","pull_request_review_id":155675921,"id":217853117,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzg1MzExNw==","diff_hunk":"@@ -0,0 +1,488 @@\n+#ifdef RE_USE_SOUND\n+\n+#include \"OpenALAudioEngine.h\"\n+\n+#include <algorithm>\n+#include <array>\n+#include <atomic>\n+#include <mutex>\n+#include <thread>\n+\n+#include <AL/al.h>\n+#include <AL/alc.h>\n+\n+using namespace Audio;\n+\n+static std::vector<std::string> enumeratedDevices;","path":"src/audio/OpenALAudioEngine.cpp","position":16,"original_position":16,"commit_id":"5979f79f572303f8f39bd6ad1178f758a64587ac","original_commit_id":"5979f79f572303f8f39bd6ad1178f758a64587ac","user":{"login":"ShFil119","id":7227492,"node_id":"MDQ6VXNlcjcyMjc0OTI=","avatar_url":"https://avatars1.githubusercontent.com/u/7227492?v=4","gravatar_id":"","url":"https://api.github.com/users/ShFil119","html_url":"https://github.com/ShFil119","followers_url":"https://api.github.com/users/ShFil119/followers","following_url":"https://api.github.com/users/ShFil119/following{/other_user}","gists_url":"https://api.github.com/users/ShFil119/gists{/gist_id}","starred_url":"https://api.github.com/users/ShFil119/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ShFil119/subscriptions","organizations_url":"https://api.github.com/users/ShFil119/orgs","repos_url":"https://api.github.com/users/ShFil119/repos","events_url":"https://api.github.com/users/ShFil119/events{/privacy}","received_events_url":"https://api.github.com/users/ShFil119/received_events","type":"User","site_admin":false},"body":"maybe instead of global `static` use anonymous namespace?","created_at":"2018-09-14T22:01:06Z","updated_at":"2018-09-14T22:10:02Z","html_url":"https://github.com/REGoth-project/REGoth/pull/366#discussion_r217853117","pull_request_url":"https://api.github.com/repos/REGoth-project/REGoth/pulls/366","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/REGoth-project/REGoth/pulls/comments/217853117"},"html":{"href":"https://github.com/REGoth-project/REGoth/pull/366#discussion_r217853117"},"pull_request":{"href":"https://api.github.com/repos/REGoth-project/REGoth/pulls/366"}}},"pull_request":{"url":"https://api.github.com/repos/REGoth-project/REGoth/pulls/366","id":215072980,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MDcyOTgw","html_url":"https://github.com/REGoth-project/REGoth/pull/366","diff_url":"https://github.com/REGoth-project/REGoth/pull/366.diff","patch_url":"https://github.com/REGoth-project/REGoth/pull/366.patch","issue_url":"https://api.github.com/repos/REGoth-project/REGoth/issues/366","number":366,"state":"open","locked":false,"title":"[WIP] Update audio engine","user":{"login":"frabert","id":1268384,"node_id":"MDQ6VXNlcjEyNjgzODQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1268384?v=4","gravatar_id":"","url":"https://api.github.com/users/frabert","html_url":"https://github.com/frabert","followers_url":"https://api.github.com/users/frabert/followers","following_url":"https://api.github.com/users/frabert/following{/other_user}","gists_url":"https://api.github.com/users/frabert/gists{/gist_id}","starred_url":"https://api.github.com/users/frabert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frabert/subscriptions","organizations_url":"https://api.github.com/users/frabert/orgs","repos_url":"https://api.github.com/users/frabert/repos","events_url":"https://api.github.com/users/frabert/events{/privacy}","received_events_url":"https://api.github.com/users/frabert/received_events","type":"User","site_admin":false},"body":"Provides a more backend-independent audio system\r\nAlso fixes some sounds being played at half speed (chapter introductions)","created_at":"2018-09-12T19:39:59Z","updated_at":"2018-09-14T22:10:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4f772a91e145af5657e30e3384fd37a9bc06acb5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/REGoth-project/REGoth/pulls/366/commits","review_comments_url":"https://api.github.com/repos/REGoth-project/REGoth/pulls/366/comments","review_comment_url":"https://api.github.com/repos/REGoth-project/REGoth/pulls/comments{/number}","comments_url":"https://api.github.com/repos/REGoth-project/REGoth/issues/366/comments","statuses_url":"https://api.github.com/repos/REGoth-project/REGoth/statuses/5979f79f572303f8f39bd6ad1178f758a64587ac","head":{"label":"REGoth-project:reword-audio-system-2","ref":"reword-audio-system-2","sha":"5979f79f572303f8f39bd6ad1178f758a64587ac","user":{"login":"REGoth-project","id":25042372,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MDQyMzcy","avatar_url":"https://avatars1.githubusercontent.com/u/25042372?v=4","gravatar_id":"","url":"https://api.github.com/users/REGoth-project","html_url":"https://github.com/REGoth-project","followers_url":"https://api.github.com/users/REGoth-project/followers","following_url":"https://api.github.com/users/REGoth-project/following{/other_user}","gists_url":"https://api.github.com/users/REGoth-project/gists{/gist_id}","starred_url":"https://api.github.com/users/REGoth-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/REGoth-project/subscriptions","organizations_url":"https://api.github.com/users/REGoth-project/orgs","repos_url":"https://api.github.com/users/REGoth-project/repos","events_url":"https://api.github.com/users/REGoth-project/events{/privacy}","received_events_url":"https://api.github.com/users/REGoth-project/received_events","type":"Organization","site_admin":false},"repo":{"id":60484367,"node_id":"MDEwOlJlcG9zaXRvcnk2MDQ4NDM2Nw==","name":"REGoth","full_name":"REGoth-project/REGoth","owner":{"login":"REGoth-project","id":25042372,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MDQyMzcy","avatar_url":"https://avatars1.githubusercontent.com/u/25042372?v=4","gravatar_id":"","url":"https://api.github.com/users/REGoth-project","html_url":"https://github.com/REGoth-project","followers_url":"https://api.github.com/users/REGoth-project/followers","following_url":"https://api.github.com/users/REGoth-project/following{/other_user}","gists_url":"https://api.github.com/users/REGoth-project/gists{/gist_id}","starred_url":"https://api.github.com/users/REGoth-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/REGoth-project/subscriptions","organizations_url":"https://api.github.com/users/REGoth-project/orgs","repos_url":"https://api.github.com/users/REGoth-project/repos","events_url":"https://api.github.com/users/REGoth-project/events{/privacy}","received_events_url":"https://api.github.com/users/REGoth-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/REGoth-project/REGoth","description":"OpenSource-Reimplementation of the zEngine, used by the game \"Gothic\"","fork":false,"url":"https://api.github.com/repos/REGoth-project/REGoth","forks_url":"https://api.github.com/repos/REGoth-project/REGoth/forks","keys_url":"https://api.github.com/repos/REGoth-project/REGoth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/REGoth-project/REGoth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/REGoth-project/REGoth/teams","hooks_url":"https://api.github.com/repos/REGoth-project/REGoth/hooks","issue_events_url":"https://api.github.com/repos/REGoth-project/REGoth/issues/events{/number}","events_url":"https://api.github.com/repos/REGoth-project/REGoth/events","assignees_url":"https://api.github.com/repos/REGoth-project/REGoth/assignees{/user}","branches_url":"https://api.github.com/repos/REGoth-project/REGoth/branches{/branch}","tags_url":"https://api.github.com/repos/REGoth-project/REGoth/tags","blobs_url":"https://api.github.com/repos/REGoth-project/REGoth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/REGoth-project/REGoth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/REGoth-project/REGoth/git/refs{/sha}","trees_url":"https://api.github.com/repos/REGoth-project/REGoth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/REGoth-project/REGoth/statuses/{sha}","languages_url":"https://api.github.com/repos/REGoth-project/REGoth/languages","stargazers_url":"https://api.github.com/repos/REGoth-project/REGoth/stargazers","contributors_url":"https://api.github.com/repos/REGoth-project/REGoth/contributors","subscribers_url":"https://api.github.com/repos/REGoth-project/REGoth/subscribers","subscription_url":"https://api.github.com/repos/REGoth-project/REGoth/subscription","commits_url":"https://api.github.com/repos/REGoth-project/REGoth/commits{/sha}","git_commits_url":"https://api.github.com/repos/REGoth-project/REGoth/git/commits{/sha}","comments_url":"https://api.github.com/repos/REGoth-project/REGoth/comments{/number}","issue_comment_url":"https://api.github.com/repos/REGoth-project/REGoth/issues/comments{/number}","contents_url":"https://api.github.com/repos/REGoth-project/REGoth/contents/{+path}","compare_url":"https://api.github.com/repos/REGoth-project/REGoth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/REGoth-project/REGoth/merges","archive_url":"https://api.github.com/repos/REGoth-project/REGoth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/REGoth-project/REGoth/downloads","issues_url":"https://api.github.com/repos/REGoth-project/REGoth/issues{/number}","pulls_url":"https://api.github.com/repos/REGoth-project/REGoth/pulls{/number}","milestones_url":"https://api.github.com/repos/REGoth-project/REGoth/milestones{/number}","notifications_url":"https://api.github.com/repos/REGoth-project/REGoth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/REGoth-project/REGoth/labels{/name}","releases_url":"https://api.github.com/repos/REGoth-project/REGoth/releases{/id}","deployments_url":"https://api.github.com/repos/REGoth-project/REGoth/deployments","created_at":"2016-06-05T22:35:35Z","updated_at":"2018-09-13T11:02:33Z","pushed_at":"2018-09-14T16:41:32Z","git_url":"git://github.com/REGoth-project/REGoth.git","ssh_url":"git@github.com:REGoth-project/REGoth.git","clone_url":"https://github.com/REGoth-project/REGoth.git","svn_url":"https://github.com/REGoth-project/REGoth","homepage":"","size":6347,"stargazers_count":468,"watchers_count":468,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":51,"mirror_url":null,"archived":false,"open_issues_count":83,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":51,"open_issues":83,"watchers":468,"default_branch":"master"}},"base":{"label":"REGoth-project:master","ref":"master","sha":"4281dc879e50e5d21d700136136a2fb5914d4ce6","user":{"login":"REGoth-project","id":25042372,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MDQyMzcy","avatar_url":"https://avatars1.githubusercontent.com/u/25042372?v=4","gravatar_id":"","url":"https://api.github.com/users/REGoth-project","html_url":"https://github.com/REGoth-project","followers_url":"https://api.github.com/users/REGoth-project/followers","following_url":"https://api.github.com/users/REGoth-project/following{/other_user}","gists_url":"https://api.github.com/users/REGoth-project/gists{/gist_id}","starred_url":"https://api.github.com/users/REGoth-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/REGoth-project/subscriptions","organizations_url":"https://api.github.com/users/REGoth-project/orgs","repos_url":"https://api.github.com/users/REGoth-project/repos","events_url":"https://api.github.com/users/REGoth-project/events{/privacy}","received_events_url":"https://api.github.com/users/REGoth-project/received_events","type":"Organization","site_admin":false},"repo":{"id":60484367,"node_id":"MDEwOlJlcG9zaXRvcnk2MDQ4NDM2Nw==","name":"REGoth","full_name":"REGoth-project/REGoth","owner":{"login":"REGoth-project","id":25042372,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MDQyMzcy","avatar_url":"https://avatars1.githubusercontent.com/u/25042372?v=4","gravatar_id":"","url":"https://api.github.com/users/REGoth-project","html_url":"https://github.com/REGoth-project","followers_url":"https://api.github.com/users/REGoth-project/followers","following_url":"https://api.github.com/users/REGoth-project/following{/other_user}","gists_url":"https://api.github.com/users/REGoth-project/gists{/gist_id}","starred_url":"https://api.github.com/users/REGoth-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/REGoth-project/subscriptions","organizations_url":"https://api.github.com/users/REGoth-project/orgs","repos_url":"https://api.github.com/users/REGoth-project/repos","events_url":"https://api.github.com/users/REGoth-project/events{/privacy}","received_events_url":"https://api.github.com/users/REGoth-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/REGoth-project/REGoth","description":"OpenSource-Reimplementation of the zEngine, used by the game \"Gothic\"","fork":false,"url":"https://api.github.com/repos/REGoth-project/REGoth","forks_url":"https://api.github.com/repos/REGoth-project/REGoth/forks","keys_url":"https://api.github.com/repos/REGoth-project/REGoth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/REGoth-project/REGoth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/REGoth-project/REGoth/teams","hooks_url":"https://api.github.com/repos/REGoth-project/REGoth/hooks","issue_events_url":"https://api.github.com/repos/REGoth-project/REGoth/issues/events{/number}","events_url":"https://api.github.com/repos/REGoth-project/REGoth/events","assignees_url":"https://api.github.com/repos/REGoth-project/REGoth/assignees{/user}","branches_url":"https://api.github.com/repos/REGoth-project/REGoth/branches{/branch}","tags_url":"https://api.github.com/repos/REGoth-project/REGoth/tags","blobs_url":"https://api.github.com/repos/REGoth-project/REGoth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/REGoth-project/REGoth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/REGoth-project/REGoth/git/refs{/sha}","trees_url":"https://api.github.com/repos/REGoth-project/REGoth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/REGoth-project/REGoth/statuses/{sha}","languages_url":"https://api.github.com/repos/REGoth-project/REGoth/languages","stargazers_url":"https://api.github.com/repos/REGoth-project/REGoth/stargazers","contributors_url":"https://api.github.com/repos/REGoth-project/REGoth/contributors","subscribers_url":"https://api.github.com/repos/REGoth-project/REGoth/subscribers","subscription_url":"https://api.github.com/repos/REGoth-project/REGoth/subscription","commits_url":"https://api.github.com/repos/REGoth-project/REGoth/commits{/sha}","git_commits_url":"https://api.github.com/repos/REGoth-project/REGoth/git/commits{/sha}","comments_url":"https://api.github.com/repos/REGoth-project/REGoth/comments{/number}","issue_comment_url":"https://api.github.com/repos/REGoth-project/REGoth/issues/comments{/number}","contents_url":"https://api.github.com/repos/REGoth-project/REGoth/contents/{+path}","compare_url":"https://api.github.com/repos/REGoth-project/REGoth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/REGoth-project/REGoth/merges","archive_url":"https://api.github.com/repos/REGoth-project/REGoth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/REGoth-project/REGoth/downloads","issues_url":"https://api.github.com/repos/REGoth-project/REGoth/issues{/number}","pulls_url":"https://api.github.com/repos/REGoth-project/REGoth/pulls{/number}","milestones_url":"https://api.github.com/repos/REGoth-project/REGoth/milestones{/number}","notifications_url":"https://api.github.com/repos/REGoth-project/REGoth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/REGoth-project/REGoth/labels{/name}","releases_url":"https://api.github.com/repos/REGoth-project/REGoth/releases{/id}","deployments_url":"https://api.github.com/repos/REGoth-project/REGoth/deployments","created_at":"2016-06-05T22:35:35Z","updated_at":"2018-09-13T11:02:33Z","pushed_at":"2018-09-14T16:41:32Z","git_url":"git://github.com/REGoth-project/REGoth.git","ssh_url":"git@github.com:REGoth-project/REGoth.git","clone_url":"https://github.com/REGoth-project/REGoth.git","svn_url":"https://github.com/REGoth-project/REGoth","homepage":"","size":6347,"stargazers_count":468,"watchers_count":468,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":51,"mirror_url":null,"archived":false,"open_issues_count":83,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":51,"open_issues":83,"watchers":468,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/REGoth-project/REGoth/pulls/366"},"html":{"href":"https://github.com/REGoth-project/REGoth/pull/366"},"issue":{"href":"https://api.github.com/repos/REGoth-project/REGoth/issues/366"},"comments":{"href":"https://api.github.com/repos/REGoth-project/REGoth/issues/366/comments"},"review_comments":{"href":"https://api.github.com/repos/REGoth-project/REGoth/pulls/366/comments"},"review_comment":{"href":"https://api.github.com/repos/REGoth-project/REGoth/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/REGoth-project/REGoth/pulls/366/commits"},"statuses":{"href":"https://api.github.com/repos/REGoth-project/REGoth/statuses/5979f79f572303f8f39bd6ad1178f758a64587ac"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ShFil119"}}