{"action":"opened","number":198,"pull_request":{"url":"https://api.github.com/repos/joaotavora/sly/pulls/198","id":230994205,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwOTk0MjA1","html_url":"https://github.com/joaotavora/sly/pull/198","diff_url":"https://github.com/joaotavora/sly/pull/198.diff","patch_url":"https://github.com/joaotavora/sly/pull/198.patch","issue_url":"https://api.github.com/repos/joaotavora/sly/issues/198","number":198,"state":"open","locked":false,"title":"Generalize sly tramp and add a docker-tramp contrib","user":{"login":"fisxoj","id":1530842,"node_id":"MDQ6VXNlcjE1MzA4NDI=","avatar_url":"https://avatars3.githubusercontent.com/u/1530842?v=4","gravatar_id":"","url":"https://api.github.com/users/fisxoj","html_url":"https://github.com/fisxoj","followers_url":"https://api.github.com/users/fisxoj/followers","following_url":"https://api.github.com/users/fisxoj/following{/other_user}","gists_url":"https://api.github.com/users/fisxoj/gists{/gist_id}","starred_url":"https://api.github.com/users/fisxoj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fisxoj/subscriptions","organizations_url":"https://api.github.com/users/fisxoj/orgs","repos_url":"https://api.github.com/users/fisxoj/repos","events_url":"https://api.github.com/users/fisxoj/events{/privacy}","received_events_url":"https://api.github.com/users/fisxoj/received_events","type":"User","site_admin":false},"body":"Hi Jão!\r\n\r\nThanks for your help figuring out how to run slynk in a docker container.  To continue along those lines, I was looking into ways to get the filename translations to work, too.  I haven't done a lot of elisp, nor have I contributed to sly before, so I wanted to open this as a proof of concept and ask for some helpful criticism on the elisp.  Also, would you accept this as a contrib at all?\r\n\r\nSome questions I have:\r\n* What will happen if the user doesn't have `docker-tramp` installed?  Will the contrib fail to load silently? (That sounds like the best case, to me)\r\n* Do you mind changing the `car` of each entry of `sly-filename-translations` to a predicate function instead of a regex?  I could add a special case for strings if we should worry about backwards compatibility.\r\n* The calls to `tramp-make-tramp-file-name` in `sly-tramp.el` don't seem to have enough arguments on my emacs (`GNU Emacs 26.1 (build 1, x86_64-redhat-linux-gnu, GTK+ Version 3.23.2)\r\n of 2018-08-13`).  Is that a bug?\r\n\r\nThanks!","created_at":"2018-11-14T21:51:51Z","updated_at":"2018-11-14T21:51:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/joaotavora/sly/pulls/198/commits","review_comments_url":"https://api.github.com/repos/joaotavora/sly/pulls/198/comments","review_comment_url":"https://api.github.com/repos/joaotavora/sly/pulls/comments{/number}","comments_url":"https://api.github.com/repos/joaotavora/sly/issues/198/comments","statuses_url":"https://api.github.com/repos/joaotavora/sly/statuses/28cccbcd721581bf9f1e2566fe9589cf5768e863","head":{"label":"fisxoj:feature/generalize-sly-tramp","ref":"feature/generalize-sly-tramp","sha":"28cccbcd721581bf9f1e2566fe9589cf5768e863","user":{"login":"fisxoj","id":1530842,"node_id":"MDQ6VXNlcjE1MzA4NDI=","avatar_url":"https://avatars3.githubusercontent.com/u/1530842?v=4","gravatar_id":"","url":"https://api.github.com/users/fisxoj","html_url":"https://github.com/fisxoj","followers_url":"https://api.github.com/users/fisxoj/followers","following_url":"https://api.github.com/users/fisxoj/following{/other_user}","gists_url":"https://api.github.com/users/fisxoj/gists{/gist_id}","starred_url":"https://api.github.com/users/fisxoj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fisxoj/subscriptions","organizations_url":"https://api.github.com/users/fisxoj/orgs","repos_url":"https://api.github.com/users/fisxoj/repos","events_url":"https://api.github.com/users/fisxoj/events{/privacy}","received_events_url":"https://api.github.com/users/fisxoj/received_events","type":"User","site_admin":false},"repo":{"id":157053290,"node_id":"MDEwOlJlcG9zaXRvcnkxNTcwNTMyOTA=","name":"sly","full_name":"fisxoj/sly","private":false,"owner":{"login":"fisxoj","id":1530842,"node_id":"MDQ6VXNlcjE1MzA4NDI=","avatar_url":"https://avatars3.githubusercontent.com/u/1530842?v=4","gravatar_id":"","url":"https://api.github.com/users/fisxoj","html_url":"https://github.com/fisxoj","followers_url":"https://api.github.com/users/fisxoj/followers","following_url":"https://api.github.com/users/fisxoj/following{/other_user}","gists_url":"https://api.github.com/users/fisxoj/gists{/gist_id}","starred_url":"https://api.github.com/users/fisxoj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fisxoj/subscriptions","organizations_url":"https://api.github.com/users/fisxoj/orgs","repos_url":"https://api.github.com/users/fisxoj/repos","events_url":"https://api.github.com/users/fisxoj/events{/privacy}","received_events_url":"https://api.github.com/users/fisxoj/received_events","type":"User","site_admin":false},"html_url":"https://github.com/fisxoj/sly","description":"Sylvester the Cat's Common Lisp IDE","fork":true,"url":"https://api.github.com/repos/fisxoj/sly","forks_url":"https://api.github.com/repos/fisxoj/sly/forks","keys_url":"https://api.github.com/repos/fisxoj/sly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fisxoj/sly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fisxoj/sly/teams","hooks_url":"https://api.github.com/repos/fisxoj/sly/hooks","issue_events_url":"https://api.github.com/repos/fisxoj/sly/issues/events{/number}","events_url":"https://api.github.com/repos/fisxoj/sly/events","assignees_url":"https://api.github.com/repos/fisxoj/sly/assignees{/user}","branches_url":"https://api.github.com/repos/fisxoj/sly/branches{/branch}","tags_url":"https://api.github.com/repos/fisxoj/sly/tags","blobs_url":"https://api.github.com/repos/fisxoj/sly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fisxoj/sly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fisxoj/sly/git/refs{/sha}","trees_url":"https://api.github.com/repos/fisxoj/sly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fisxoj/sly/statuses/{sha}","languages_url":"https://api.github.com/repos/fisxoj/sly/languages","stargazers_url":"https://api.github.com/repos/fisxoj/sly/stargazers","contributors_url":"https://api.github.com/repos/fisxoj/sly/contributors","subscribers_url":"https://api.github.com/repos/fisxoj/sly/subscribers","subscription_url":"https://api.github.com/repos/fisxoj/sly/subscription","commits_url":"https://api.github.com/repos/fisxoj/sly/commits{/sha}","git_commits_url":"https://api.github.com/repos/fisxoj/sly/git/commits{/sha}","comments_url":"https://api.github.com/repos/fisxoj/sly/comments{/number}","issue_comment_url":"https://api.github.com/repos/fisxoj/sly/issues/comments{/number}","contents_url":"https://api.github.com/repos/fisxoj/sly/contents/{+path}","compare_url":"https://api.github.com/repos/fisxoj/sly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fisxoj/sly/merges","archive_url":"https://api.github.com/repos/fisxoj/sly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fisxoj/sly/downloads","issues_url":"https://api.github.com/repos/fisxoj/sly/issues{/number}","pulls_url":"https://api.github.com/repos/fisxoj/sly/pulls{/number}","milestones_url":"https://api.github.com/repos/fisxoj/sly/milestones{/number}","notifications_url":"https://api.github.com/repos/fisxoj/sly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fisxoj/sly/labels{/name}","releases_url":"https://api.github.com/repos/fisxoj/sly/releases{/id}","deployments_url":"https://api.github.com/repos/fisxoj/sly/deployments","created_at":"2018-11-11T06:21:07Z","updated_at":"2018-11-11T06:21:10Z","pushed_at":"2018-11-11T06:45:18Z","git_url":"git://github.com/fisxoj/sly.git","ssh_url":"git@github.com:fisxoj/sly.git","clone_url":"https://github.com/fisxoj/sly.git","svn_url":"https://github.com/fisxoj/sly","homepage":"","size":24232,"stargazers_count":0,"watchers_count":0,"language":"Common Lisp","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"joaotavora:master","ref":"master","sha":"68b73b0e12333c9a6253252f76c6b2615cf4bd98","user":{"login":"joaotavora","id":387011,"node_id":"MDQ6VXNlcjM4NzAxMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/387011?v=4","gravatar_id":"","url":"https://api.github.com/users/joaotavora","html_url":"https://github.com/joaotavora","followers_url":"https://api.github.com/users/joaotavora/followers","following_url":"https://api.github.com/users/joaotavora/following{/other_user}","gists_url":"https://api.github.com/users/joaotavora/gists{/gist_id}","starred_url":"https://api.github.com/users/joaotavora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joaotavora/subscriptions","organizations_url":"https://api.github.com/users/joaotavora/orgs","repos_url":"https://api.github.com/users/joaotavora/repos","events_url":"https://api.github.com/users/joaotavora/events{/privacy}","received_events_url":"https://api.github.com/users/joaotavora/received_events","type":"User","site_admin":false},"repo":{"id":17603517,"node_id":"MDEwOlJlcG9zaXRvcnkxNzYwMzUxNw==","name":"sly","full_name":"joaotavora/sly","private":false,"owner":{"login":"joaotavora","id":387011,"node_id":"MDQ6VXNlcjM4NzAxMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/387011?v=4","gravatar_id":"","url":"https://api.github.com/users/joaotavora","html_url":"https://github.com/joaotavora","followers_url":"https://api.github.com/users/joaotavora/followers","following_url":"https://api.github.com/users/joaotavora/following{/other_user}","gists_url":"https://api.github.com/users/joaotavora/gists{/gist_id}","starred_url":"https://api.github.com/users/joaotavora/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joaotavora/subscriptions","organizations_url":"https://api.github.com/users/joaotavora/orgs","repos_url":"https://api.github.com/users/joaotavora/repos","events_url":"https://api.github.com/users/joaotavora/events{/privacy}","received_events_url":"https://api.github.com/users/joaotavora/received_events","type":"User","site_admin":false},"html_url":"https://github.com/joaotavora/sly","description":"Sylvester the Cat's Common Lisp IDE","fork":false,"url":"https://api.github.com/repos/joaotavora/sly","forks_url":"https://api.github.com/repos/joaotavora/sly/forks","keys_url":"https://api.github.com/repos/joaotavora/sly/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joaotavora/sly/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joaotavora/sly/teams","hooks_url":"https://api.github.com/repos/joaotavora/sly/hooks","issue_events_url":"https://api.github.com/repos/joaotavora/sly/issues/events{/number}","events_url":"https://api.github.com/repos/joaotavora/sly/events","assignees_url":"https://api.github.com/repos/joaotavora/sly/assignees{/user}","branches_url":"https://api.github.com/repos/joaotavora/sly/branches{/branch}","tags_url":"https://api.github.com/repos/joaotavora/sly/tags","blobs_url":"https://api.github.com/repos/joaotavora/sly/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joaotavora/sly/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joaotavora/sly/git/refs{/sha}","trees_url":"https://api.github.com/repos/joaotavora/sly/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joaotavora/sly/statuses/{sha}","languages_url":"https://api.github.com/repos/joaotavora/sly/languages","stargazers_url":"https://api.github.com/repos/joaotavora/sly/stargazers","contributors_url":"https://api.github.com/repos/joaotavora/sly/contributors","subscribers_url":"https://api.github.com/repos/joaotavora/sly/subscribers","subscription_url":"https://api.github.com/repos/joaotavora/sly/subscription","commits_url":"https://api.github.com/repos/joaotavora/sly/commits{/sha}","git_commits_url":"https://api.github.com/repos/joaotavora/sly/git/commits{/sha}","comments_url":"https://api.github.com/repos/joaotavora/sly/comments{/number}","issue_comment_url":"https://api.github.com/repos/joaotavora/sly/issues/comments{/number}","contents_url":"https://api.github.com/repos/joaotavora/sly/contents/{+path}","compare_url":"https://api.github.com/repos/joaotavora/sly/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joaotavora/sly/merges","archive_url":"https://api.github.com/repos/joaotavora/sly/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joaotavora/sly/downloads","issues_url":"https://api.github.com/repos/joaotavora/sly/issues{/number}","pulls_url":"https://api.github.com/repos/joaotavora/sly/pulls{/number}","milestones_url":"https://api.github.com/repos/joaotavora/sly/milestones{/number}","notifications_url":"https://api.github.com/repos/joaotavora/sly/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joaotavora/sly/labels{/name}","releases_url":"https://api.github.com/repos/joaotavora/sly/releases{/id}","deployments_url":"https://api.github.com/repos/joaotavora/sly/deployments","created_at":"2014-03-10T18:24:08Z","updated_at":"2018-11-14T19:04:57Z","pushed_at":"2018-11-14T19:04:54Z","git_url":"git://github.com/joaotavora/sly.git","ssh_url":"git@github.com:joaotavora/sly.git","clone_url":"https://github.com/joaotavora/sly.git","svn_url":"https://github.com/joaotavora/sly","homepage":"","size":24261,"stargazers_count":421,"watchers_count":421,"language":"Common Lisp","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":39,"license":null,"forks":30,"open_issues":39,"watchers":421,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/joaotavora/sly/pulls/198"},"html":{"href":"https://github.com/joaotavora/sly/pull/198"},"issue":{"href":"https://api.github.com/repos/joaotavora/sly/issues/198"},"comments":{"href":"https://api.github.com/repos/joaotavora/sly/issues/198/comments"},"review_comments":{"href":"https://api.github.com/repos/joaotavora/sly/pulls/198/comments"},"review_comment":{"href":"https://api.github.com/repos/joaotavora/sly/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/joaotavora/sly/pulls/198/commits"},"statuses":{"href":"https://api.github.com/repos/joaotavora/sly/statuses/28cccbcd721581bf9f1e2566fe9589cf5768e863"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":40,"deletions":9,"changed_files":2}}
{"actor":{"display_login":"fisxoj"}}