{"action":"closed","number":29,"pull_request":{"url":"https://api.github.com/repos/cloudera/clusterdock/pulls/29","id":116067412,"html_url":"https://github.com/cloudera/clusterdock/pull/29","diff_url":"https://github.com/cloudera/clusterdock/pull/29.diff","patch_url":"https://github.com/cloudera/clusterdock/pull/29.patch","issue_url":"https://api.github.com/repos/cloudera/clusterdock/issues/29","number":29,"state":"closed","locked":false,"title":"Replaced == with = in clusterdock_ssh() for wider shell compatibility.","user":{"login":"a-vk","id":8017539,"avatar_url":"https://avatars0.githubusercontent.com/u/8017539?v=4","gravatar_id":"","url":"https://api.github.com/users/a-vk","html_url":"https://github.com/a-vk","followers_url":"https://api.github.com/users/a-vk/followers","following_url":"https://api.github.com/users/a-vk/following{/other_user}","gists_url":"https://api.github.com/users/a-vk/gists{/gist_id}","starred_url":"https://api.github.com/users/a-vk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-vk/subscriptions","organizations_url":"https://api.github.com/users/a-vk/orgs","repos_url":"https://api.github.com/users/a-vk/repos","events_url":"https://api.github.com/users/a-vk/events{/privacy}","received_events_url":"https://api.github.com/users/a-vk/received_events","type":"User","site_admin":false},"body":"Using zsh, and running clusterdock_ssh() kept throwing a “= not found” message. Looking around, seemed like just a single = was the POSIX standard for string comparison and had wider shell compatibility. Tested the single = in bash and it still worked.","created_at":"2017-04-16T18:56:55Z","updated_at":"2018-03-12T21:28:33Z","closed_at":"2018-03-12T21:28:33Z","merged_at":"2018-03-12T21:28:33Z","merge_commit_sha":"222ac2d5a9aa2fef7b84b3cf704f9ee54c0cc5d2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cloudera/clusterdock/pulls/29/commits","review_comments_url":"https://api.github.com/repos/cloudera/clusterdock/pulls/29/comments","review_comment_url":"https://api.github.com/repos/cloudera/clusterdock/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cloudera/clusterdock/issues/29/comments","statuses_url":"https://api.github.com/repos/cloudera/clusterdock/statuses/2d25066b47e2222a1eae33dd3086495974727ecb","head":{"label":"a-vk:master","ref":"master","sha":"2d25066b47e2222a1eae33dd3086495974727ecb","user":{"login":"a-vk","id":8017539,"avatar_url":"https://avatars0.githubusercontent.com/u/8017539?v=4","gravatar_id":"","url":"https://api.github.com/users/a-vk","html_url":"https://github.com/a-vk","followers_url":"https://api.github.com/users/a-vk/followers","following_url":"https://api.github.com/users/a-vk/following{/other_user}","gists_url":"https://api.github.com/users/a-vk/gists{/gist_id}","starred_url":"https://api.github.com/users/a-vk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-vk/subscriptions","organizations_url":"https://api.github.com/users/a-vk/orgs","repos_url":"https://api.github.com/users/a-vk/repos","events_url":"https://api.github.com/users/a-vk/events{/privacy}","received_events_url":"https://api.github.com/users/a-vk/received_events","type":"User","site_admin":false},"repo":{"id":88427251,"name":"clusterdock","full_name":"a-vk/clusterdock","owner":{"login":"a-vk","id":8017539,"avatar_url":"https://avatars0.githubusercontent.com/u/8017539?v=4","gravatar_id":"","url":"https://api.github.com/users/a-vk","html_url":"https://github.com/a-vk","followers_url":"https://api.github.com/users/a-vk/followers","following_url":"https://api.github.com/users/a-vk/following{/other_user}","gists_url":"https://api.github.com/users/a-vk/gists{/gist_id}","starred_url":"https://api.github.com/users/a-vk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-vk/subscriptions","organizations_url":"https://api.github.com/users/a-vk/orgs","repos_url":"https://api.github.com/users/a-vk/repos","events_url":"https://api.github.com/users/a-vk/events{/privacy}","received_events_url":"https://api.github.com/users/a-vk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/a-vk/clusterdock","description":null,"fork":true,"url":"https://api.github.com/repos/a-vk/clusterdock","forks_url":"https://api.github.com/repos/a-vk/clusterdock/forks","keys_url":"https://api.github.com/repos/a-vk/clusterdock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/a-vk/clusterdock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/a-vk/clusterdock/teams","hooks_url":"https://api.github.com/repos/a-vk/clusterdock/hooks","issue_events_url":"https://api.github.com/repos/a-vk/clusterdock/issues/events{/number}","events_url":"https://api.github.com/repos/a-vk/clusterdock/events","assignees_url":"https://api.github.com/repos/a-vk/clusterdock/assignees{/user}","branches_url":"https://api.github.com/repos/a-vk/clusterdock/branches{/branch}","tags_url":"https://api.github.com/repos/a-vk/clusterdock/tags","blobs_url":"https://api.github.com/repos/a-vk/clusterdock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/a-vk/clusterdock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/a-vk/clusterdock/git/refs{/sha}","trees_url":"https://api.github.com/repos/a-vk/clusterdock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/a-vk/clusterdock/statuses/{sha}","languages_url":"https://api.github.com/repos/a-vk/clusterdock/languages","stargazers_url":"https://api.github.com/repos/a-vk/clusterdock/stargazers","contributors_url":"https://api.github.com/repos/a-vk/clusterdock/contributors","subscribers_url":"https://api.github.com/repos/a-vk/clusterdock/subscribers","subscription_url":"https://api.github.com/repos/a-vk/clusterdock/subscription","commits_url":"https://api.github.com/repos/a-vk/clusterdock/commits{/sha}","git_commits_url":"https://api.github.com/repos/a-vk/clusterdock/git/commits{/sha}","comments_url":"https://api.github.com/repos/a-vk/clusterdock/comments{/number}","issue_comment_url":"https://api.github.com/repos/a-vk/clusterdock/issues/comments{/number}","contents_url":"https://api.github.com/repos/a-vk/clusterdock/contents/{+path}","compare_url":"https://api.github.com/repos/a-vk/clusterdock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/a-vk/clusterdock/merges","archive_url":"https://api.github.com/repos/a-vk/clusterdock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/a-vk/clusterdock/downloads","issues_url":"https://api.github.com/repos/a-vk/clusterdock/issues{/number}","pulls_url":"https://api.github.com/repos/a-vk/clusterdock/pulls{/number}","milestones_url":"https://api.github.com/repos/a-vk/clusterdock/milestones{/number}","notifications_url":"https://api.github.com/repos/a-vk/clusterdock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/a-vk/clusterdock/labels{/name}","releases_url":"https://api.github.com/repos/a-vk/clusterdock/releases{/id}","deployments_url":"https://api.github.com/repos/a-vk/clusterdock/deployments","created_at":"2017-04-16T16:21:06Z","updated_at":"2017-04-16T16:21:08Z","pushed_at":"2017-04-16T18:43:06Z","git_url":"git://github.com/a-vk/clusterdock.git","ssh_url":"git@github.com:a-vk/clusterdock.git","clone_url":"https://github.com/a-vk/clusterdock.git","svn_url":"https://github.com/a-vk/clusterdock","homepage":null,"size":113,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cloudera:master","ref":"master","sha":"120970d73c314815effa273e98017555379e22da","user":{"login":"cloudera","id":87383,"avatar_url":"https://avatars3.githubusercontent.com/u/87383?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudera","html_url":"https://github.com/cloudera","followers_url":"https://api.github.com/users/cloudera/followers","following_url":"https://api.github.com/users/cloudera/following{/other_user}","gists_url":"https://api.github.com/users/cloudera/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudera/subscriptions","organizations_url":"https://api.github.com/users/cloudera/orgs","repos_url":"https://api.github.com/users/cloudera/repos","events_url":"https://api.github.com/users/cloudera/events{/privacy}","received_events_url":"https://api.github.com/users/cloudera/received_events","type":"Organization","site_admin":false},"repo":{"id":63985040,"name":"clusterdock","full_name":"cloudera/clusterdock","owner":{"login":"cloudera","id":87383,"avatar_url":"https://avatars3.githubusercontent.com/u/87383?v=4","gravatar_id":"","url":"https://api.github.com/users/cloudera","html_url":"https://github.com/cloudera","followers_url":"https://api.github.com/users/cloudera/followers","following_url":"https://api.github.com/users/cloudera/following{/other_user}","gists_url":"https://api.github.com/users/cloudera/gists{/gist_id}","starred_url":"https://api.github.com/users/cloudera/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cloudera/subscriptions","organizations_url":"https://api.github.com/users/cloudera/orgs","repos_url":"https://api.github.com/users/cloudera/repos","events_url":"https://api.github.com/users/cloudera/events{/privacy}","received_events_url":"https://api.github.com/users/cloudera/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cloudera/clusterdock","description":null,"fork":false,"url":"https://api.github.com/repos/cloudera/clusterdock","forks_url":"https://api.github.com/repos/cloudera/clusterdock/forks","keys_url":"https://api.github.com/repos/cloudera/clusterdock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cloudera/clusterdock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cloudera/clusterdock/teams","hooks_url":"https://api.github.com/repos/cloudera/clusterdock/hooks","issue_events_url":"https://api.github.com/repos/cloudera/clusterdock/issues/events{/number}","events_url":"https://api.github.com/repos/cloudera/clusterdock/events","assignees_url":"https://api.github.com/repos/cloudera/clusterdock/assignees{/user}","branches_url":"https://api.github.com/repos/cloudera/clusterdock/branches{/branch}","tags_url":"https://api.github.com/repos/cloudera/clusterdock/tags","blobs_url":"https://api.github.com/repos/cloudera/clusterdock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cloudera/clusterdock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cloudera/clusterdock/git/refs{/sha}","trees_url":"https://api.github.com/repos/cloudera/clusterdock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cloudera/clusterdock/statuses/{sha}","languages_url":"https://api.github.com/repos/cloudera/clusterdock/languages","stargazers_url":"https://api.github.com/repos/cloudera/clusterdock/stargazers","contributors_url":"https://api.github.com/repos/cloudera/clusterdock/contributors","subscribers_url":"https://api.github.com/repos/cloudera/clusterdock/subscribers","subscription_url":"https://api.github.com/repos/cloudera/clusterdock/subscription","commits_url":"https://api.github.com/repos/cloudera/clusterdock/commits{/sha}","git_commits_url":"https://api.github.com/repos/cloudera/clusterdock/git/commits{/sha}","comments_url":"https://api.github.com/repos/cloudera/clusterdock/comments{/number}","issue_comment_url":"https://api.github.com/repos/cloudera/clusterdock/issues/comments{/number}","contents_url":"https://api.github.com/repos/cloudera/clusterdock/contents/{+path}","compare_url":"https://api.github.com/repos/cloudera/clusterdock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cloudera/clusterdock/merges","archive_url":"https://api.github.com/repos/cloudera/clusterdock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cloudera/clusterdock/downloads","issues_url":"https://api.github.com/repos/cloudera/clusterdock/issues{/number}","pulls_url":"https://api.github.com/repos/cloudera/clusterdock/pulls{/number}","milestones_url":"https://api.github.com/repos/cloudera/clusterdock/milestones{/number}","notifications_url":"https://api.github.com/repos/cloudera/clusterdock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cloudera/clusterdock/labels{/name}","releases_url":"https://api.github.com/repos/cloudera/clusterdock/releases{/id}","deployments_url":"https://api.github.com/repos/cloudera/clusterdock/deployments","created_at":"2016-07-22T21:41:44Z","updated_at":"2018-03-11T03:24:17Z","pushed_at":"2018-03-12T21:28:33Z","git_url":"git://github.com/cloudera/clusterdock.git","ssh_url":"git@github.com:cloudera/clusterdock.git","clone_url":"https://github.com/cloudera/clusterdock.git","svn_url":"https://github.com/cloudera/clusterdock","homepage":null,"size":126,"stargazers_count":43,"watchers_count":43,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":41,"open_issues":11,"watchers":43,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cloudera/clusterdock/pulls/29"},"html":{"href":"https://github.com/cloudera/clusterdock/pull/29"},"issue":{"href":"https://api.github.com/repos/cloudera/clusterdock/issues/29"},"comments":{"href":"https://api.github.com/repos/cloudera/clusterdock/issues/29/comments"},"review_comments":{"href":"https://api.github.com/repos/cloudera/clusterdock/pulls/29/comments"},"review_comment":{"href":"https://api.github.com/repos/cloudera/clusterdock/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cloudera/clusterdock/pulls/29/commits"},"statuses":{"href":"https://api.github.com/repos/cloudera/clusterdock/statuses/2d25066b47e2222a1eae33dd3086495974727ecb"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"dimaspivak","id":6088908,"avatar_url":"https://avatars3.githubusercontent.com/u/6088908?v=4","gravatar_id":"","url":"https://api.github.com/users/dimaspivak","html_url":"https://github.com/dimaspivak","followers_url":"https://api.github.com/users/dimaspivak/followers","following_url":"https://api.github.com/users/dimaspivak/following{/other_user}","gists_url":"https://api.github.com/users/dimaspivak/gists{/gist_id}","starred_url":"https://api.github.com/users/dimaspivak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dimaspivak/subscriptions","organizations_url":"https://api.github.com/users/dimaspivak/orgs","repos_url":"https://api.github.com/users/dimaspivak/repos","events_url":"https://api.github.com/users/dimaspivak/events{/privacy}","received_events_url":"https://api.github.com/users/dimaspivak/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"dimaspivak"}}