{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/telemetry-streaming/pulls/comments/206951152","pull_request_review_id":142464554,"id":206951152,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjk1MTE1Mg==","diff_hunk":"@@ -107,6 +133,28 @@ case class MainPing(application: Application,\n     dynamicProcessEvents.filter(_.category == \"normandy\")\n   }\n \n+\n+  override def sessionSplitEvents: Seq[JObject] = {\n+    import org.json4s.JsonDSL._\n+\n+    val eventType = \"session split\"\n+    val event = pingAmplitudeProperties merge","path":"src/main/scala/com/mozilla/telemetry/pings/MainPing.scala","position":null,"original_position":49,"commit_id":"795bb04452f5278a02dcd809fab9ea4a8ab59f97","original_commit_id":"7e587b9258e5eee5b2a7e1d419b13ab65ae92247","user":{"login":"sunahsuh","id":953153,"node_id":"MDQ6VXNlcjk1MzE1Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/953153?v=4","gravatar_id":"","url":"https://api.github.com/users/sunahsuh","html_url":"https://github.com/sunahsuh","followers_url":"https://api.github.com/users/sunahsuh/followers","following_url":"https://api.github.com/users/sunahsuh/following{/other_user}","gists_url":"https://api.github.com/users/sunahsuh/gists{/gist_id}","starred_url":"https://api.github.com/users/sunahsuh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sunahsuh/subscriptions","organizations_url":"https://api.github.com/users/sunahsuh/orgs","repos_url":"https://api.github.com/users/sunahsuh/repos","events_url":"https://api.github.com/users/sunahsuh/events{/privacy}","received_events_url":"https://api.github.com/users/sunahsuh/received_events","type":"User","site_admin":false},"body":"Okay, one more thought/piece of context that might not be clear: there is no such thing as a session split in mobile. This is a concept that's specific to the main ping, hence why it feels wrong to me to add this at the top-level to a schema that includes non-desktop pings.\r\n\r\n> So it's well defined that behavior in this case is that no sessionSplitEvent is produced.\r\n\r\nMy point is that if that happens it's likely an error by the person writing the schema. If we want to get to a point where it's not data engineers writing the schema (which, dear deity I hope we do) we should consider where we might be putting footguns ;)","created_at":"2018-08-01T16:41:53Z","updated_at":"2018-08-01T16:41:53Z","html_url":"https://github.com/mozilla/telemetry-streaming/pull/165#discussion_r206951152","pull_request_url":"https://api.github.com/repos/mozilla/telemetry-streaming/pulls/165","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mozilla/telemetry-streaming/pulls/comments/206951152"},"html":{"href":"https://github.com/mozilla/telemetry-streaming/pull/165#discussion_r206951152"},"pull_request":{"href":"https://api.github.com/repos/mozilla/telemetry-streaming/pulls/165"}},"in_reply_to_id":206918529},"pull_request":{"url":"https://api.github.com/repos/mozilla/telemetry-streaming/pulls/165","id":205197800,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MTk3ODAw","html_url":"https://github.com/mozilla/telemetry-streaming/pull/165","diff_url":"https://github.com/mozilla/telemetry-streaming/pull/165.diff","patch_url":"https://github.com/mozilla/telemetry-streaming/pull/165.patch","issue_url":"https://api.github.com/repos/mozilla/telemetry-streaming/issues/165","number":165,"state":"open","locked":false,"title":"Bug 1474987 Add \"ping sent\" event","user":{"login":"jklukas","id":691060,"node_id":"MDQ6VXNlcjY5MTA2MA==","avatar_url":"https://avatars0.githubusercontent.com/u/691060?v=4","gravatar_id":"","url":"https://api.github.com/users/jklukas","html_url":"https://github.com/jklukas","followers_url":"https://api.github.com/users/jklukas/followers","following_url":"https://api.github.com/users/jklukas/following{/other_user}","gists_url":"https://api.github.com/users/jklukas/gists{/gist_id}","starred_url":"https://api.github.com/users/jklukas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jklukas/subscriptions","organizations_url":"https://api.github.com/users/jklukas/orgs","repos_url":"https://api.github.com/users/jklukas/repos","events_url":"https://api.github.com/users/jklukas/events{/privacy}","received_events_url":"https://api.github.com/users/jklukas/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-31T18:11:13Z","updated_at":"2018-08-01T16:41:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"224f210f6dd5a668207622d52532741dfb50ca6d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/telemetry-streaming/pulls/165/commits","review_comments_url":"https://api.github.com/repos/mozilla/telemetry-streaming/pulls/165/comments","review_comment_url":"https://api.github.com/repos/mozilla/telemetry-streaming/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/telemetry-streaming/issues/165/comments","statuses_url":"https://api.github.com/repos/mozilla/telemetry-streaming/statuses/795bb04452f5278a02dcd809fab9ea4a8ab59f97","head":{"label":"jklukas:savant-ping-sent-event","ref":"savant-ping-sent-event","sha":"795bb04452f5278a02dcd809fab9ea4a8ab59f97","user":{"login":"jklukas","id":691060,"node_id":"MDQ6VXNlcjY5MTA2MA==","avatar_url":"https://avatars0.githubusercontent.com/u/691060?v=4","gravatar_id":"","url":"https://api.github.com/users/jklukas","html_url":"https://github.com/jklukas","followers_url":"https://api.github.com/users/jklukas/followers","following_url":"https://api.github.com/users/jklukas/following{/other_user}","gists_url":"https://api.github.com/users/jklukas/gists{/gist_id}","starred_url":"https://api.github.com/users/jklukas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jklukas/subscriptions","organizations_url":"https://api.github.com/users/jklukas/orgs","repos_url":"https://api.github.com/users/jklukas/repos","events_url":"https://api.github.com/users/jklukas/events{/privacy}","received_events_url":"https://api.github.com/users/jklukas/received_events","type":"User","site_admin":false},"repo":{"id":137925083,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc5MjUwODM=","name":"telemetry-streaming","full_name":"jklukas/telemetry-streaming","owner":{"login":"jklukas","id":691060,"node_id":"MDQ6VXNlcjY5MTA2MA==","avatar_url":"https://avatars0.githubusercontent.com/u/691060?v=4","gravatar_id":"","url":"https://api.github.com/users/jklukas","html_url":"https://github.com/jklukas","followers_url":"https://api.github.com/users/jklukas/followers","following_url":"https://api.github.com/users/jklukas/following{/other_user}","gists_url":"https://api.github.com/users/jklukas/gists{/gist_id}","starred_url":"https://api.github.com/users/jklukas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jklukas/subscriptions","organizations_url":"https://api.github.com/users/jklukas/orgs","repos_url":"https://api.github.com/users/jklukas/repos","events_url":"https://api.github.com/users/jklukas/events{/privacy}","received_events_url":"https://api.github.com/users/jklukas/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jklukas/telemetry-streaming","description":"Spark Streaming ETL jobs for Mozilla Telemetry","fork":true,"url":"https://api.github.com/repos/jklukas/telemetry-streaming","forks_url":"https://api.github.com/repos/jklukas/telemetry-streaming/forks","keys_url":"https://api.github.com/repos/jklukas/telemetry-streaming/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jklukas/telemetry-streaming/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jklukas/telemetry-streaming/teams","hooks_url":"https://api.github.com/repos/jklukas/telemetry-streaming/hooks","issue_events_url":"https://api.github.com/repos/jklukas/telemetry-streaming/issues/events{/number}","events_url":"https://api.github.com/repos/jklukas/telemetry-streaming/events","assignees_url":"https://api.github.com/repos/jklukas/telemetry-streaming/assignees{/user}","branches_url":"https://api.github.com/repos/jklukas/telemetry-streaming/branches{/branch}","tags_url":"https://api.github.com/repos/jklukas/telemetry-streaming/tags","blobs_url":"https://api.github.com/repos/jklukas/telemetry-streaming/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jklukas/telemetry-streaming/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jklukas/telemetry-streaming/git/refs{/sha}","trees_url":"https://api.github.com/repos/jklukas/telemetry-streaming/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jklukas/telemetry-streaming/statuses/{sha}","languages_url":"https://api.github.com/repos/jklukas/telemetry-streaming/languages","stargazers_url":"https://api.github.com/repos/jklukas/telemetry-streaming/stargazers","contributors_url":"https://api.github.com/repos/jklukas/telemetry-streaming/contributors","subscribers_url":"https://api.github.com/repos/jklukas/telemetry-streaming/subscribers","subscription_url":"https://api.github.com/repos/jklukas/telemetry-streaming/subscription","commits_url":"https://api.github.com/repos/jklukas/telemetry-streaming/commits{/sha}","git_commits_url":"https://api.github.com/repos/jklukas/telemetry-streaming/git/commits{/sha}","comments_url":"https://api.github.com/repos/jklukas/telemetry-streaming/comments{/number}","issue_comment_url":"https://api.github.com/repos/jklukas/telemetry-streaming/issues/comments{/number}","contents_url":"https://api.github.com/repos/jklukas/telemetry-streaming/contents/{+path}","compare_url":"https://api.github.com/repos/jklukas/telemetry-streaming/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jklukas/telemetry-streaming/merges","archive_url":"https://api.github.com/repos/jklukas/telemetry-streaming/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jklukas/telemetry-streaming/downloads","issues_url":"https://api.github.com/repos/jklukas/telemetry-streaming/issues{/number}","pulls_url":"https://api.github.com/repos/jklukas/telemetry-streaming/pulls{/number}","milestones_url":"https://api.github.com/repos/jklukas/telemetry-streaming/milestones{/number}","notifications_url":"https://api.github.com/repos/jklukas/telemetry-streaming/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jklukas/telemetry-streaming/labels{/name}","releases_url":"https://api.github.com/repos/jklukas/telemetry-streaming/releases{/id}","deployments_url":"https://api.github.com/repos/jklukas/telemetry-streaming/deployments","created_at":"2018-06-19T17:39:59Z","updated_at":"2018-06-19T20:06:12Z","pushed_at":"2018-08-01T15:28:42Z","git_url":"git://github.com/jklukas/telemetry-streaming.git","ssh_url":"git@github.com:jklukas/telemetry-streaming.git","clone_url":"https://github.com/jklukas/telemetry-streaming.git","svn_url":"https://github.com/jklukas/telemetry-streaming","homepage":"","size":530,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"b106fae866dcd8d378273ec2ab8bbd7e6ec77a72","user":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":78219155,"node_id":"MDEwOlJlcG9zaXRvcnk3ODIxOTE1NQ==","name":"telemetry-streaming","full_name":"mozilla/telemetry-streaming","owner":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/telemetry-streaming","description":"Spark Streaming ETL jobs for Mozilla Telemetry","fork":false,"url":"https://api.github.com/repos/mozilla/telemetry-streaming","forks_url":"https://api.github.com/repos/mozilla/telemetry-streaming/forks","keys_url":"https://api.github.com/repos/mozilla/telemetry-streaming/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/telemetry-streaming/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/telemetry-streaming/teams","hooks_url":"https://api.github.com/repos/mozilla/telemetry-streaming/hooks","issue_events_url":"https://api.github.com/repos/mozilla/telemetry-streaming/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/telemetry-streaming/events","assignees_url":"https://api.github.com/repos/mozilla/telemetry-streaming/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/telemetry-streaming/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/telemetry-streaming/tags","blobs_url":"https://api.github.com/repos/mozilla/telemetry-streaming/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/telemetry-streaming/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/telemetry-streaming/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/telemetry-streaming/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/telemetry-streaming/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/telemetry-streaming/languages","stargazers_url":"https://api.github.com/repos/mozilla/telemetry-streaming/stargazers","contributors_url":"https://api.github.com/repos/mozilla/telemetry-streaming/contributors","subscribers_url":"https://api.github.com/repos/mozilla/telemetry-streaming/subscribers","subscription_url":"https://api.github.com/repos/mozilla/telemetry-streaming/subscription","commits_url":"https://api.github.com/repos/mozilla/telemetry-streaming/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/telemetry-streaming/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/telemetry-streaming/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/telemetry-streaming/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/telemetry-streaming/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/telemetry-streaming/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/telemetry-streaming/merges","archive_url":"https://api.github.com/repos/mozilla/telemetry-streaming/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/telemetry-streaming/downloads","issues_url":"https://api.github.com/repos/mozilla/telemetry-streaming/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/telemetry-streaming/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/telemetry-streaming/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/telemetry-streaming/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/telemetry-streaming/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/telemetry-streaming/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/telemetry-streaming/deployments","created_at":"2017-01-06T16:05:58Z","updated_at":"2018-07-31T18:23:53Z","pushed_at":"2018-08-01T16:10:10Z","git_url":"git://github.com/mozilla/telemetry-streaming.git","ssh_url":"git@github.com:mozilla/telemetry-streaming.git","clone_url":"https://github.com/mozilla/telemetry-streaming.git","svn_url":"https://github.com/mozilla/telemetry-streaming","homepage":"","size":508,"stargazers_count":9,"watchers_count":9,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":9,"open_issues":1,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/telemetry-streaming/pulls/165"},"html":{"href":"https://github.com/mozilla/telemetry-streaming/pull/165"},"issue":{"href":"https://api.github.com/repos/mozilla/telemetry-streaming/issues/165"},"comments":{"href":"https://api.github.com/repos/mozilla/telemetry-streaming/issues/165/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/telemetry-streaming/pulls/165/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/telemetry-streaming/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/telemetry-streaming/pulls/165/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/telemetry-streaming/statuses/795bb04452f5278a02dcd809fab9ea4a8ab59f97"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sunahsuh"}}