{"action":"created","comment":{"url":"https://api.github.com/repos/diasurgical/devilution/pulls/comments/219705598","pull_request_review_id":157945941,"id":219705598,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTcwNTU5OA==","diff_hunk":"@@ -3233,36 +3233,33 @@ void __fastcall ArmorDur(int pnum)\n \t}\r\n }\r\n \r\n-int __fastcall PM_DoDeath(int pnum)\r\n+BOOL __fastcall PM_DoDeath(int pnum)\r\n {\r\n-\tint v1; // edi\r\n-\tint v2; // esi\r\n-\tint v3; // ecx\r\n-\tint v4; // eax\r\n-\tint v5; // eax\r\n-\r\n-\tv1 = pnum;\r\n-\tif ( (unsigned int)pnum >= MAX_PLRS )\r\n+\tif ( (DWORD)pnum >= MAX_PLRS ) {\r\n \t\tTermMsg(\"PM_DoDeath: illegal player %d\", pnum);\r\n-\tv2 = v1;\r\n-\tif ( plr[v1]._pVar8 >= 2 * plr[v1]._pDFrames )\r\n-\t{\r\n-\t\tif ( deathdelay > 1 && v1 == myplr && --deathdelay == 1 )\r\n-\t\t{\r\n-\t\t\tdeathflag = 1;\r\n-\t\t\tif ( gbMaxPlayers == 1 )\r\n-\t\t\t\tgamemenu_previous();\r\n+\t}\r\n+\r\n+\tif ( plr[pnum]._pVar8 >= 2 * plr[pnum]._pDFrames ) {\r\n+\t\tif ( deathdelay > 1 && pnum == myplr ) {\r\n+\t\t\tdeathdelay--;\r\n+\t\t\tif ( deathdelay == 1 ) {\r\n+\t\t\t\tdeathflag = 1;\r\n+\t\t\t\tif ( gbMaxPlayers == 1 ) {\r\n+\t\t\t\t\tgamemenu_previous();\r\n+\t\t\t\t}\r\n+\t\t\t}\r\n \t\t}\r\n-\t\tv3 = plr[v2].WorldY;\r\n-\t\tplr[v2]._pAnimFrame = plr[v2]._pAnimLen;\r\n-\t\tv4 = plr[v2].WorldX;\r\n-\t\tplr[v2]._pAnimDelay = 10000;\r\n-\t\tdFlags[v4][v3] |= 4u;\r\n-\t}\r\n-\tv5 = plr[v2]._pVar8;\r\n-\tif ( v5 < 100 )\r\n-\t\tplr[v2]._pVar8 = v5 + 1;\r\n-\treturn 0;\r\n+\r\n+\t\tplr[pnum]._pAnimFrame = plr[pnum]._pAnimLen;\r\n+\t\tplr[pnum]._pAnimDelay = 10000;\r\n+\t\tdFlags[plr[pnum].WorldX][plr[pnum].WorldY] |= 4;\r","path":"Source/player.cpp","position":50,"original_position":50,"commit_id":"475a6119684fe0707cd0b71dfc6ca0e96dfffc3e","original_commit_id":"475a6119684fe0707cd0b71dfc6ca0e96dfffc3e","user":{"login":"AJenbo","id":204594,"node_id":"MDQ6VXNlcjIwNDU5NA==","avatar_url":"https://avatars3.githubusercontent.com/u/204594?v=4","gravatar_id":"","url":"https://api.github.com/users/AJenbo","html_url":"https://github.com/AJenbo","followers_url":"https://api.github.com/users/AJenbo/followers","following_url":"https://api.github.com/users/AJenbo/following{/other_user}","gists_url":"https://api.github.com/users/AJenbo/gists{/gist_id}","starred_url":"https://api.github.com/users/AJenbo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AJenbo/subscriptions","organizations_url":"https://api.github.com/users/AJenbo/orgs","repos_url":"https://api.github.com/users/AJenbo/repos","events_url":"https://api.github.com/users/AJenbo/events{/privacy}","received_events_url":"https://api.github.com/users/AJenbo/received_events","type":"User","site_admin":false},"body":"There are also checks for 0x40 next to plr[myplr]._pInfraFlag","created_at":"2018-09-23T17:27:46Z","updated_at":"2018-09-23T17:27:46Z","html_url":"https://github.com/diasurgical/devilution/pull/317#discussion_r219705598","pull_request_url":"https://api.github.com/repos/diasurgical/devilution/pulls/317","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/diasurgical/devilution/pulls/comments/219705598"},"html":{"href":"https://github.com/diasurgical/devilution/pull/317#discussion_r219705598"},"pull_request":{"href":"https://api.github.com/repos/diasurgical/devilution/pulls/317"}},"in_reply_to_id":219680274},"pull_request":{"url":"https://api.github.com/repos/diasurgical/devilution/pulls/317","id":217455803,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NDU1ODAz","html_url":"https://github.com/diasurgical/devilution/pull/317","diff_url":"https://github.com/diasurgical/devilution/pull/317.diff","patch_url":"https://github.com/diasurgical/devilution/pull/317.patch","issue_url":"https://api.github.com/repos/diasurgical/devilution/issues/317","number":317,"state":"open","locked":false,"title":"Clean up PM_DoDeath","user":{"login":"AJenbo","id":204594,"node_id":"MDQ6VXNlcjIwNDU5NA==","avatar_url":"https://avatars3.githubusercontent.com/u/204594?v=4","gravatar_id":"","url":"https://api.github.com/users/AJenbo","html_url":"https://github.com/AJenbo","followers_url":"https://api.github.com/users/AJenbo/followers","following_url":"https://api.github.com/users/AJenbo/following{/other_user}","gists_url":"https://api.github.com/users/AJenbo/gists{/gist_id}","starred_url":"https://api.github.com/users/AJenbo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AJenbo/subscriptions","organizations_url":"https://api.github.com/users/AJenbo/orgs","repos_url":"https://api.github.com/users/AJenbo/repos","events_url":"https://api.github.com/users/AJenbo/events{/privacy}","received_events_url":"https://api.github.com/users/AJenbo/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-09-22T12:46:57Z","updated_at":"2018-09-23T17:27:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a87fb156fe6586e9e7d873596e96e94c11bbc90f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1061404337,"node_id":"MDU6TGFiZWwxMDYxNDA0MzM3","url":"https://api.github.com/repos/diasurgical/devilution/labels/Binary%20exact","name":"Binary exact","color":"6fe879","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/diasurgical/devilution/pulls/317/commits","review_comments_url":"https://api.github.com/repos/diasurgical/devilution/pulls/317/comments","review_comment_url":"https://api.github.com/repos/diasurgical/devilution/pulls/comments{/number}","comments_url":"https://api.github.com/repos/diasurgical/devilution/issues/317/comments","statuses_url":"https://api.github.com/repos/diasurgical/devilution/statuses/475a6119684fe0707cd0b71dfc6ca0e96dfffc3e","head":{"label":"AJenbo:PM_DoDeath","ref":"PM_DoDeath","sha":"475a6119684fe0707cd0b71dfc6ca0e96dfffc3e","user":{"login":"AJenbo","id":204594,"node_id":"MDQ6VXNlcjIwNDU5NA==","avatar_url":"https://avatars3.githubusercontent.com/u/204594?v=4","gravatar_id":"","url":"https://api.github.com/users/AJenbo","html_url":"https://github.com/AJenbo","followers_url":"https://api.github.com/users/AJenbo/followers","following_url":"https://api.github.com/users/AJenbo/following{/other_user}","gists_url":"https://api.github.com/users/AJenbo/gists{/gist_id}","starred_url":"https://api.github.com/users/AJenbo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AJenbo/subscriptions","organizations_url":"https://api.github.com/users/AJenbo/orgs","repos_url":"https://api.github.com/users/AJenbo/repos","events_url":"https://api.github.com/users/AJenbo/events{/privacy}","received_events_url":"https://api.github.com/users/AJenbo/received_events","type":"User","site_admin":false},"repo":{"id":145342024,"node_id":"MDEwOlJlcG9zaXRvcnkxNDUzNDIwMjQ=","name":"devilution","full_name":"AJenbo/devilution","private":false,"owner":{"login":"AJenbo","id":204594,"node_id":"MDQ6VXNlcjIwNDU5NA==","avatar_url":"https://avatars3.githubusercontent.com/u/204594?v=4","gravatar_id":"","url":"https://api.github.com/users/AJenbo","html_url":"https://github.com/AJenbo","followers_url":"https://api.github.com/users/AJenbo/followers","following_url":"https://api.github.com/users/AJenbo/following{/other_user}","gists_url":"https://api.github.com/users/AJenbo/gists{/gist_id}","starred_url":"https://api.github.com/users/AJenbo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AJenbo/subscriptions","organizations_url":"https://api.github.com/users/AJenbo/orgs","repos_url":"https://api.github.com/users/AJenbo/repos","events_url":"https://api.github.com/users/AJenbo/events{/privacy}","received_events_url":"https://api.github.com/users/AJenbo/received_events","type":"User","site_admin":false},"html_url":"https://github.com/AJenbo/devilution","description":"Diablo devolved - magic behind the 1996 computer game","fork":true,"url":"https://api.github.com/repos/AJenbo/devilution","forks_url":"https://api.github.com/repos/AJenbo/devilution/forks","keys_url":"https://api.github.com/repos/AJenbo/devilution/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AJenbo/devilution/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AJenbo/devilution/teams","hooks_url":"https://api.github.com/repos/AJenbo/devilution/hooks","issue_events_url":"https://api.github.com/repos/AJenbo/devilution/issues/events{/number}","events_url":"https://api.github.com/repos/AJenbo/devilution/events","assignees_url":"https://api.github.com/repos/AJenbo/devilution/assignees{/user}","branches_url":"https://api.github.com/repos/AJenbo/devilution/branches{/branch}","tags_url":"https://api.github.com/repos/AJenbo/devilution/tags","blobs_url":"https://api.github.com/repos/AJenbo/devilution/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AJenbo/devilution/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AJenbo/devilution/git/refs{/sha}","trees_url":"https://api.github.com/repos/AJenbo/devilution/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AJenbo/devilution/statuses/{sha}","languages_url":"https://api.github.com/repos/AJenbo/devilution/languages","stargazers_url":"https://api.github.com/repos/AJenbo/devilution/stargazers","contributors_url":"https://api.github.com/repos/AJenbo/devilution/contributors","subscribers_url":"https://api.github.com/repos/AJenbo/devilution/subscribers","subscription_url":"https://api.github.com/repos/AJenbo/devilution/subscription","commits_url":"https://api.github.com/repos/AJenbo/devilution/commits{/sha}","git_commits_url":"https://api.github.com/repos/AJenbo/devilution/git/commits{/sha}","comments_url":"https://api.github.com/repos/AJenbo/devilution/comments{/number}","issue_comment_url":"https://api.github.com/repos/AJenbo/devilution/issues/comments{/number}","contents_url":"https://api.github.com/repos/AJenbo/devilution/contents/{+path}","compare_url":"https://api.github.com/repos/AJenbo/devilution/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AJenbo/devilution/merges","archive_url":"https://api.github.com/repos/AJenbo/devilution/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AJenbo/devilution/downloads","issues_url":"https://api.github.com/repos/AJenbo/devilution/issues{/number}","pulls_url":"https://api.github.com/repos/AJenbo/devilution/pulls{/number}","milestones_url":"https://api.github.com/repos/AJenbo/devilution/milestones{/number}","notifications_url":"https://api.github.com/repos/AJenbo/devilution/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AJenbo/devilution/labels{/name}","releases_url":"https://api.github.com/repos/AJenbo/devilution/releases{/id}","deployments_url":"https://api.github.com/repos/AJenbo/devilution/deployments","created_at":"2018-08-19T22:29:20Z","updated_at":"2018-09-18T22:18:42Z","pushed_at":"2018-09-23T15:34:11Z","git_url":"git://github.com/AJenbo/devilution.git","ssh_url":"git@github.com:AJenbo/devilution.git","clone_url":"https://github.com/AJenbo/devilution.git","svn_url":"https://github.com/AJenbo/devilution","homepage":"","size":2229,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"unlicense","name":"The Unlicense","spdx_id":"Unlicense","url":"https://api.github.com/licenses/unlicense","node_id":"MDc6TGljZW5zZTE1"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"diasurgical:nightly","ref":"nightly","sha":"648dddf4d076cad68bdcee5d19fd88fe08301cd7","user":{"login":"diasurgical","id":40645014,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNjQ1MDE0","avatar_url":"https://avatars1.githubusercontent.com/u/40645014?v=4","gravatar_id":"","url":"https://api.github.com/users/diasurgical","html_url":"https://github.com/diasurgical","followers_url":"https://api.github.com/users/diasurgical/followers","following_url":"https://api.github.com/users/diasurgical/following{/other_user}","gists_url":"https://api.github.com/users/diasurgical/gists{/gist_id}","starred_url":"https://api.github.com/users/diasurgical/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diasurgical/subscriptions","organizations_url":"https://api.github.com/users/diasurgical/orgs","repos_url":"https://api.github.com/users/diasurgical/repos","events_url":"https://api.github.com/users/diasurgical/events{/privacy}","received_events_url":"https://api.github.com/users/diasurgical/received_events","type":"Organization","site_admin":false},"repo":{"id":127684759,"node_id":"MDEwOlJlcG9zaXRvcnkxMjc2ODQ3NTk=","name":"devilution","full_name":"diasurgical/devilution","private":false,"owner":{"login":"diasurgical","id":40645014,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNjQ1MDE0","avatar_url":"https://avatars1.githubusercontent.com/u/40645014?v=4","gravatar_id":"","url":"https://api.github.com/users/diasurgical","html_url":"https://github.com/diasurgical","followers_url":"https://api.github.com/users/diasurgical/followers","following_url":"https://api.github.com/users/diasurgical/following{/other_user}","gists_url":"https://api.github.com/users/diasurgical/gists{/gist_id}","starred_url":"https://api.github.com/users/diasurgical/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/diasurgical/subscriptions","organizations_url":"https://api.github.com/users/diasurgical/orgs","repos_url":"https://api.github.com/users/diasurgical/repos","events_url":"https://api.github.com/users/diasurgical/events{/privacy}","received_events_url":"https://api.github.com/users/diasurgical/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/diasurgical/devilution","description":"Diablo devolved - magic behind the 1996 computer game","fork":false,"url":"https://api.github.com/repos/diasurgical/devilution","forks_url":"https://api.github.com/repos/diasurgical/devilution/forks","keys_url":"https://api.github.com/repos/diasurgical/devilution/keys{/key_id}","collaborators_url":"https://api.github.com/repos/diasurgical/devilution/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/diasurgical/devilution/teams","hooks_url":"https://api.github.com/repos/diasurgical/devilution/hooks","issue_events_url":"https://api.github.com/repos/diasurgical/devilution/issues/events{/number}","events_url":"https://api.github.com/repos/diasurgical/devilution/events","assignees_url":"https://api.github.com/repos/diasurgical/devilution/assignees{/user}","branches_url":"https://api.github.com/repos/diasurgical/devilution/branches{/branch}","tags_url":"https://api.github.com/repos/diasurgical/devilution/tags","blobs_url":"https://api.github.com/repos/diasurgical/devilution/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/diasurgical/devilution/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/diasurgical/devilution/git/refs{/sha}","trees_url":"https://api.github.com/repos/diasurgical/devilution/git/trees{/sha}","statuses_url":"https://api.github.com/repos/diasurgical/devilution/statuses/{sha}","languages_url":"https://api.github.com/repos/diasurgical/devilution/languages","stargazers_url":"https://api.github.com/repos/diasurgical/devilution/stargazers","contributors_url":"https://api.github.com/repos/diasurgical/devilution/contributors","subscribers_url":"https://api.github.com/repos/diasurgical/devilution/subscribers","subscription_url":"https://api.github.com/repos/diasurgical/devilution/subscription","commits_url":"https://api.github.com/repos/diasurgical/devilution/commits{/sha}","git_commits_url":"https://api.github.com/repos/diasurgical/devilution/git/commits{/sha}","comments_url":"https://api.github.com/repos/diasurgical/devilution/comments{/number}","issue_comment_url":"https://api.github.com/repos/diasurgical/devilution/issues/comments{/number}","contents_url":"https://api.github.com/repos/diasurgical/devilution/contents/{+path}","compare_url":"https://api.github.com/repos/diasurgical/devilution/compare/{base}...{head}","merges_url":"https://api.github.com/repos/diasurgical/devilution/merges","archive_url":"https://api.github.com/repos/diasurgical/devilution/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/diasurgical/devilution/downloads","issues_url":"https://api.github.com/repos/diasurgical/devilution/issues{/number}","pulls_url":"https://api.github.com/repos/diasurgical/devilution/pulls{/number}","milestones_url":"https://api.github.com/repos/diasurgical/devilution/milestones{/number}","notifications_url":"https://api.github.com/repos/diasurgical/devilution/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/diasurgical/devilution/labels{/name}","releases_url":"https://api.github.com/repos/diasurgical/devilution/releases{/id}","deployments_url":"https://api.github.com/repos/diasurgical/devilution/deployments","created_at":"2018-04-02T01:01:47Z","updated_at":"2018-09-23T14:22:25Z","pushed_at":"2018-09-23T15:34:12Z","git_url":"git://github.com/diasurgical/devilution.git","ssh_url":"git@github.com:diasurgical/devilution.git","clone_url":"https://github.com/diasurgical/devilution.git","svn_url":"https://github.com/diasurgical/devilution","homepage":"","size":2447,"stargazers_count":5487,"watchers_count":5487,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":666,"mirror_url":null,"archived":false,"open_issues_count":101,"license":{"key":"unlicense","name":"The Unlicense","spdx_id":"Unlicense","url":"https://api.github.com/licenses/unlicense","node_id":"MDc6TGljZW5zZTE1"},"forks":666,"open_issues":101,"watchers":5487,"default_branch":"nightly"}},"_links":{"self":{"href":"https://api.github.com/repos/diasurgical/devilution/pulls/317"},"html":{"href":"https://github.com/diasurgical/devilution/pull/317"},"issue":{"href":"https://api.github.com/repos/diasurgical/devilution/issues/317"},"comments":{"href":"https://api.github.com/repos/diasurgical/devilution/issues/317/comments"},"review_comments":{"href":"https://api.github.com/repos/diasurgical/devilution/pulls/317/comments"},"review_comment":{"href":"https://api.github.com/repos/diasurgical/devilution/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/diasurgical/devilution/pulls/317/commits"},"statuses":{"href":"https://api.github.com/repos/diasurgical/devilution/statuses/475a6119684fe0707cd0b71dfc6ca0e96dfffc3e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"AJenbo"}}