{"action":"created","issue":{"url":"https://api.github.com/repos/ansible/ansible/issues/39547","repository_url":"https://api.github.com/repos/ansible/ansible","labels_url":"https://api.github.com/repos/ansible/ansible/issues/39547/labels{/name}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/39547/comments","events_url":"https://api.github.com/repos/ansible/ansible/issues/39547/events","html_url":"https://github.com/ansible/ansible/pull/39547","id":319157620,"number":39547,"title":"Azure Module Fixes with primary field and base-url","user":{"login":"scassidy-ukcloud","id":37589942,"avatar_url":"https://avatars1.githubusercontent.com/u/37589942?v=4","gravatar_id":"","url":"https://api.github.com/users/scassidy-ukcloud","html_url":"https://github.com/scassidy-ukcloud","followers_url":"https://api.github.com/users/scassidy-ukcloud/followers","following_url":"https://api.github.com/users/scassidy-ukcloud/following{/other_user}","gists_url":"https://api.github.com/users/scassidy-ukcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/scassidy-ukcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scassidy-ukcloud/subscriptions","organizations_url":"https://api.github.com/users/scassidy-ukcloud/orgs","repos_url":"https://api.github.com/users/scassidy-ukcloud/repos","events_url":"https://api.github.com/users/scassidy-ukcloud/events{/privacy}","received_events_url":"https://api.github.com/users/scassidy-ukcloud/received_events","type":"User","site_admin":false},"labels":[{"id":379680468,"url":"https://api.github.com/repos/ansible/ansible/labels/azure","name":"azure","color":"c5def5","default":false},{"id":785271699,"url":"https://api.github.com/repos/ansible/ansible/labels/bug","name":"bug","color":"fbca04","default":true},{"id":530145226,"url":"https://api.github.com/repos/ansible/ansible/labels/ci_verified","name":"ci_verified","color":"b60205","default":false},{"id":61528803,"url":"https://api.github.com/repos/ansible/ansible/labels/cloud","name":"cloud","color":"c7def8","default":false},{"id":496359346,"url":"https://api.github.com/repos/ansible/ansible/labels/module","name":"module","color":"1d76db","default":false},{"id":578474583,"url":"https://api.github.com/repos/ansible/ansible/labels/needs_repo","name":"needs_repo","color":"fef2c0","default":false},{"id":61436281,"url":"https://api.github.com/repos/ansible/ansible/labels/needs_revision","name":"needs_revision","color":"eb6450","default":false},{"id":723150340,"url":"https://api.github.com/repos/ansible/ansible/labels/new_contributor","name":"new_contributor","color":"ededed","default":false},{"id":669975544,"url":"https://api.github.com/repos/ansible/ansible/labels/support:certified","name":"support:certified","color":"ededed","default":false},{"id":636352796,"url":"https://api.github.com/repos/ansible/ansible/labels/support:core","name":"support:core","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":16,"created_at":"2018-05-01T09:43:15Z","updated_at":"2018-05-08T09:10:49Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/39547","html_url":"https://github.com/ansible/ansible/pull/39547","diff_url":"https://github.com/ansible/ansible/pull/39547.diff","patch_url":"https://github.com/ansible/ansible/pull/39547.patch"},"body":"##### SUMMARY\r\n<!--- Describe the change, including rationale and design decisions -->\r\n When creating a Network Security Group in AzureStack using Ansible\r\n       when looking at the code the base-url was shown as \"none\" - this caused the code to use\r\n       the standard public azure base-url of \"management.azure.com\" - this caused ansible \r\n      not to work with AzureStack as the URL for AzureStack is not the public one. This address was\r\n     set in the credentials file and caused other resources (public ip address, resource grouyp etc...) to\r\n     be created OK but did not work for network security groups. After degugging I found that the\r\n     local variable is set to the credientials fiule value in this case but the value is not passed to\r\n     subsequent functions. This fixes this.\r\n\r\nIn Ansible 2.5 a new field has appeared under Azure Network Interface called primary.\r\nAccording to the documentation this field is not mandatory but when running a playbook without this field errors have resulted. To get around this I include the field primary and set it to \"True\" - after this another error has resulted. THis subserquent error comes from the Python module stating that the \"primary\" field does not exist in the data structures that are used. To get around this I removed the line from the python module and this works. I think this may be a symptom of an issue elsewhere so not sure if this is the best fix.\r\n\r\n\r\n<!--- If you are fixing an existing issue, please include \"Fixes #nnn\" in your\r\ncommit message and your description; but you should still explain what\r\nthe change does.-->\r\n\r\n##### ISSUE TYPE\r\n<!--- Pick one below and delete the rest: -->\r\n - Bugfix Pull Request\r\n\r\n\r\n##### COMPONENT NAME\r\n<!--- Name of the module, plugin, module or task -->\r\n\r\n##### ANSIBLE VERSION\r\n<!--- Paste verbatim output from \"ansible --version\" between quotes below -->\r\n```\r\nansible 2.5.2\r\n  config file = None\r\n  configured module search path = [u'/root/.ansible/plugins/modules', u'/usr/share/ansible/plugins/modules']\r\n  ansible python module location = /usr/lib/python2.7/site-packages/ansible\r\n  executable location = /usr/bin/ansible\r\n  python version = 2.7.5 (default, Aug  4 2017, 00:39:18) [GCC 4.8.5 20150623 (Red Hat 4.8.5-16)]\r\n\r\n```\r\n\r\n\r\n##### ADDITIONAL INFORMATION\r\n<!--- Include additional information to help people understand the change here.\r\nFor bugs that don't have a linked bug report, a step-by-step reproduction\r\nof the problem is helpful. -->\r\n\r\n<!--- Paste verbatim command output below, e.g. before and after your change -->\r\n```\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/ansible/ansible/issues/comments/387337710","html_url":"https://github.com/ansible/ansible/pull/39547#issuecomment-387337710","issue_url":"https://api.github.com/repos/ansible/ansible/issues/39547","id":387337710,"user":{"login":"scassidy-ukcloud","id":37589942,"avatar_url":"https://avatars1.githubusercontent.com/u/37589942?v=4","gravatar_id":"","url":"https://api.github.com/users/scassidy-ukcloud","html_url":"https://github.com/scassidy-ukcloud","followers_url":"https://api.github.com/users/scassidy-ukcloud/followers","following_url":"https://api.github.com/users/scassidy-ukcloud/following{/other_user}","gists_url":"https://api.github.com/users/scassidy-ukcloud/gists{/gist_id}","starred_url":"https://api.github.com/users/scassidy-ukcloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scassidy-ukcloud/subscriptions","organizations_url":"https://api.github.com/users/scassidy-ukcloud/orgs","repos_url":"https://api.github.com/users/scassidy-ukcloud/repos","events_url":"https://api.github.com/users/scassidy-ukcloud/events{/privacy}","received_events_url":"https://api.github.com/users/scassidy-ukcloud/received_events","type":"User","site_admin":false},"created_at":"2018-05-08T09:10:49Z","updated_at":"2018-05-08T09:10:49Z","author_association":"NONE","body":"I have two pull requests for the same file - I think it is probably best for me to close my two pull requests (this one and the other one I created) and create one consolidated pull request.\r\n"}}
{"actor":{"display_login":"scassidy-ukcloud"}}