{"action":"created","comment":{"url":"https://api.github.com/repos/graknlabs/grakn/pulls/comments/218782166","pull_request_review_id":156793167,"id":218782166,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODc4MjE2Ng==","diff_hunk":"@@ -126,15 +126,15 @@\n     },\n     methods: {\n       async loadAttributeTypes() {\n-        await this.localStore.openGraknTx();\n+        const graknTx = await this.localStore.openGraknTx();\n \n-        const type = await this.localStore.graknTx.getSchemaConcept(this.currentType);\n+        const type = await graknTx.getSchemaConcept(this.currentType);\n \n         this.nodeAttributes = await Promise.all((await (await type.attributes()).collect()).map(type => type.label()));\n         this.nodeAttributes.sort();\n         this.currentTypeSavedAttributes = NodeSettings.getTypeLabels(this.currentType);\n \n-        await this.localStore.closeGraknTx();\n+        await graknTx.close();","path":"workbase/src/renderer/components/Visualiser/RightBar/SettingsTab/DisplaySettingsPanel.vue","position":null,"original_position":15,"commit_id":"57891c8c5e1f61a67f25817afdc47a51b211b35f","original_commit_id":"57891c8c5e1f61a67f25817afdc47a51b211b35f","user":{"login":"marco-scoppetta","id":6430514,"node_id":"MDQ6VXNlcjY0MzA1MTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/6430514?v=4","gravatar_id":"","url":"https://api.github.com/users/marco-scoppetta","html_url":"https://github.com/marco-scoppetta","followers_url":"https://api.github.com/users/marco-scoppetta/followers","following_url":"https://api.github.com/users/marco-scoppetta/following{/other_user}","gists_url":"https://api.github.com/users/marco-scoppetta/gists{/gist_id}","starred_url":"https://api.github.com/users/marco-scoppetta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marco-scoppetta/subscriptions","organizations_url":"https://api.github.com/users/marco-scoppetta/orgs","repos_url":"https://api.github.com/users/marco-scoppetta/repos","events_url":"https://api.github.com/users/marco-scoppetta/events{/privacy}","received_events_url":"https://api.github.com/users/marco-scoppetta/received_events","type":"User","site_admin":false},"body":"no need to await on close, we don't have to perform any specific operation","created_at":"2018-09-19T12:27:38Z","updated_at":"2018-09-19T12:29:26Z","html_url":"https://github.com/graknlabs/grakn/pull/2997#discussion_r218782166","pull_request_url":"https://api.github.com/repos/graknlabs/grakn/pulls/2997","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/graknlabs/grakn/pulls/comments/218782166"},"html":{"href":"https://github.com/graknlabs/grakn/pull/2997#discussion_r218782166"},"pull_request":{"href":"https://api.github.com/repos/graknlabs/grakn/pulls/2997"}}},"pull_request":{"url":"https://api.github.com/repos/graknlabs/grakn/pulls/2997","id":216362643,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2MzYyNjQz","html_url":"https://github.com/graknlabs/grakn/pull/2997","diff_url":"https://github.com/graknlabs/grakn/pull/2997.diff","patch_url":"https://github.com/graknlabs/grakn/pull/2997.patch","issue_url":"https://api.github.com/repos/graknlabs/grakn/issues/2997","number":2997,"state":"open","locked":false,"title":"[Workbase] - Initialise GRPC transactions locally and attach attributes to nodes [do no merge]","user":{"login":"Irtazaraza","id":5437855,"node_id":"MDQ6VXNlcjU0Mzc4NTU=","avatar_url":"https://avatars3.githubusercontent.com/u/5437855?v=4","gravatar_id":"","url":"https://api.github.com/users/Irtazaraza","html_url":"https://github.com/Irtazaraza","followers_url":"https://api.github.com/users/Irtazaraza/followers","following_url":"https://api.github.com/users/Irtazaraza/following{/other_user}","gists_url":"https://api.github.com/users/Irtazaraza/gists{/gist_id}","starred_url":"https://api.github.com/users/Irtazaraza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Irtazaraza/subscriptions","organizations_url":"https://api.github.com/users/Irtazaraza/orgs","repos_url":"https://api.github.com/users/Irtazaraza/repos","events_url":"https://api.github.com/users/Irtazaraza/events{/privacy}","received_events_url":"https://api.github.com/users/Irtazaraza/received_events","type":"User","site_admin":false},"body":"# Why is this PR needed?\r\nA GRPC transaction was only being opened once and hence Workbase did not register any real-time changes to the graph\r\n\r\n# What does the PR do?\r\n- Open and close transactions locally for whenever API calls are needed to be made\r\n- Attach attributes to nodes when they are queried initially so attributes of inferred types are persisted \r\n\r\n# Does it break backwards compatibility?\r\n- No\r\n\r\n# List of future improvements not on this PR\r\n- No","created_at":"2018-09-18T16:04:17Z","updated_at":"2018-09-19T12:29:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"88520b03e86ce7e33465867e3496517ed1e83361","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/graknlabs/grakn/pulls/2997/commits","review_comments_url":"https://api.github.com/repos/graknlabs/grakn/pulls/2997/comments","review_comment_url":"https://api.github.com/repos/graknlabs/grakn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/graknlabs/grakn/issues/2997/comments","statuses_url":"https://api.github.com/repos/graknlabs/grakn/statuses/57891c8c5e1f61a67f25817afdc47a51b211b35f","head":{"label":"Irtazaraza:open-close-transaction-for-every-query","ref":"open-close-transaction-for-every-query","sha":"57891c8c5e1f61a67f25817afdc47a51b211b35f","user":{"login":"Irtazaraza","id":5437855,"node_id":"MDQ6VXNlcjU0Mzc4NTU=","avatar_url":"https://avatars3.githubusercontent.com/u/5437855?v=4","gravatar_id":"","url":"https://api.github.com/users/Irtazaraza","html_url":"https://github.com/Irtazaraza","followers_url":"https://api.github.com/users/Irtazaraza/followers","following_url":"https://api.github.com/users/Irtazaraza/following{/other_user}","gists_url":"https://api.github.com/users/Irtazaraza/gists{/gist_id}","starred_url":"https://api.github.com/users/Irtazaraza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Irtazaraza/subscriptions","organizations_url":"https://api.github.com/users/Irtazaraza/orgs","repos_url":"https://api.github.com/users/Irtazaraza/repos","events_url":"https://api.github.com/users/Irtazaraza/events{/privacy}","received_events_url":"https://api.github.com/users/Irtazaraza/received_events","type":"User","site_admin":false},"repo":{"id":129378055,"node_id":"MDEwOlJlcG9zaXRvcnkxMjkzNzgwNTU=","name":"grakn","full_name":"Irtazaraza/grakn","private":false,"owner":{"login":"Irtazaraza","id":5437855,"node_id":"MDQ6VXNlcjU0Mzc4NTU=","avatar_url":"https://avatars3.githubusercontent.com/u/5437855?v=4","gravatar_id":"","url":"https://api.github.com/users/Irtazaraza","html_url":"https://github.com/Irtazaraza","followers_url":"https://api.github.com/users/Irtazaraza/followers","following_url":"https://api.github.com/users/Irtazaraza/following{/other_user}","gists_url":"https://api.github.com/users/Irtazaraza/gists{/gist_id}","starred_url":"https://api.github.com/users/Irtazaraza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Irtazaraza/subscriptions","organizations_url":"https://api.github.com/users/Irtazaraza/orgs","repos_url":"https://api.github.com/users/Irtazaraza/repos","events_url":"https://api.github.com/users/Irtazaraza/events{/privacy}","received_events_url":"https://api.github.com/users/Irtazaraza/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Irtazaraza/grakn","description":"The Knowledge Graph","fork":true,"url":"https://api.github.com/repos/Irtazaraza/grakn","forks_url":"https://api.github.com/repos/Irtazaraza/grakn/forks","keys_url":"https://api.github.com/repos/Irtazaraza/grakn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Irtazaraza/grakn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Irtazaraza/grakn/teams","hooks_url":"https://api.github.com/repos/Irtazaraza/grakn/hooks","issue_events_url":"https://api.github.com/repos/Irtazaraza/grakn/issues/events{/number}","events_url":"https://api.github.com/repos/Irtazaraza/grakn/events","assignees_url":"https://api.github.com/repos/Irtazaraza/grakn/assignees{/user}","branches_url":"https://api.github.com/repos/Irtazaraza/grakn/branches{/branch}","tags_url":"https://api.github.com/repos/Irtazaraza/grakn/tags","blobs_url":"https://api.github.com/repos/Irtazaraza/grakn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Irtazaraza/grakn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Irtazaraza/grakn/git/refs{/sha}","trees_url":"https://api.github.com/repos/Irtazaraza/grakn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Irtazaraza/grakn/statuses/{sha}","languages_url":"https://api.github.com/repos/Irtazaraza/grakn/languages","stargazers_url":"https://api.github.com/repos/Irtazaraza/grakn/stargazers","contributors_url":"https://api.github.com/repos/Irtazaraza/grakn/contributors","subscribers_url":"https://api.github.com/repos/Irtazaraza/grakn/subscribers","subscription_url":"https://api.github.com/repos/Irtazaraza/grakn/subscription","commits_url":"https://api.github.com/repos/Irtazaraza/grakn/commits{/sha}","git_commits_url":"https://api.github.com/repos/Irtazaraza/grakn/git/commits{/sha}","comments_url":"https://api.github.com/repos/Irtazaraza/grakn/comments{/number}","issue_comment_url":"https://api.github.com/repos/Irtazaraza/grakn/issues/comments{/number}","contents_url":"https://api.github.com/repos/Irtazaraza/grakn/contents/{+path}","compare_url":"https://api.github.com/repos/Irtazaraza/grakn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Irtazaraza/grakn/merges","archive_url":"https://api.github.com/repos/Irtazaraza/grakn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Irtazaraza/grakn/downloads","issues_url":"https://api.github.com/repos/Irtazaraza/grakn/issues{/number}","pulls_url":"https://api.github.com/repos/Irtazaraza/grakn/pulls{/number}","milestones_url":"https://api.github.com/repos/Irtazaraza/grakn/milestones{/number}","notifications_url":"https://api.github.com/repos/Irtazaraza/grakn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Irtazaraza/grakn/labels{/name}","releases_url":"https://api.github.com/repos/Irtazaraza/grakn/releases{/id}","deployments_url":"https://api.github.com/repos/Irtazaraza/grakn/deployments","created_at":"2018-04-13T09:12:11Z","updated_at":"2018-04-27T11:15:24Z","pushed_at":"2018-09-19T11:49:29Z","git_url":"git://github.com/Irtazaraza/grakn.git","ssh_url":"git@github.com:Irtazaraza/grakn.git","clone_url":"https://github.com/Irtazaraza/grakn.git","svn_url":"https://github.com/Irtazaraza/grakn","homepage":"https://grakn.ai","size":67940,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"graknlabs:master","ref":"master","sha":"08c1cfc52aad449caae528042c51c2c06665be4c","user":{"login":"graknlabs","id":10490615,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNDkwNjE1","avatar_url":"https://avatars1.githubusercontent.com/u/10490615?v=4","gravatar_id":"","url":"https://api.github.com/users/graknlabs","html_url":"https://github.com/graknlabs","followers_url":"https://api.github.com/users/graknlabs/followers","following_url":"https://api.github.com/users/graknlabs/following{/other_user}","gists_url":"https://api.github.com/users/graknlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/graknlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graknlabs/subscriptions","organizations_url":"https://api.github.com/users/graknlabs/orgs","repos_url":"https://api.github.com/users/graknlabs/repos","events_url":"https://api.github.com/users/graknlabs/events{/privacy}","received_events_url":"https://api.github.com/users/graknlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":63110867,"node_id":"MDEwOlJlcG9zaXRvcnk2MzExMDg2Nw==","name":"grakn","full_name":"graknlabs/grakn","private":false,"owner":{"login":"graknlabs","id":10490615,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNDkwNjE1","avatar_url":"https://avatars1.githubusercontent.com/u/10490615?v=4","gravatar_id":"","url":"https://api.github.com/users/graknlabs","html_url":"https://github.com/graknlabs","followers_url":"https://api.github.com/users/graknlabs/followers","following_url":"https://api.github.com/users/graknlabs/following{/other_user}","gists_url":"https://api.github.com/users/graknlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/graknlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graknlabs/subscriptions","organizations_url":"https://api.github.com/users/graknlabs/orgs","repos_url":"https://api.github.com/users/graknlabs/repos","events_url":"https://api.github.com/users/graknlabs/events{/privacy}","received_events_url":"https://api.github.com/users/graknlabs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/graknlabs/grakn","description":"The Knowledge Graph","fork":false,"url":"https://api.github.com/repos/graknlabs/grakn","forks_url":"https://api.github.com/repos/graknlabs/grakn/forks","keys_url":"https://api.github.com/repos/graknlabs/grakn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/graknlabs/grakn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/graknlabs/grakn/teams","hooks_url":"https://api.github.com/repos/graknlabs/grakn/hooks","issue_events_url":"https://api.github.com/repos/graknlabs/grakn/issues/events{/number}","events_url":"https://api.github.com/repos/graknlabs/grakn/events","assignees_url":"https://api.github.com/repos/graknlabs/grakn/assignees{/user}","branches_url":"https://api.github.com/repos/graknlabs/grakn/branches{/branch}","tags_url":"https://api.github.com/repos/graknlabs/grakn/tags","blobs_url":"https://api.github.com/repos/graknlabs/grakn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/graknlabs/grakn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/graknlabs/grakn/git/refs{/sha}","trees_url":"https://api.github.com/repos/graknlabs/grakn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/graknlabs/grakn/statuses/{sha}","languages_url":"https://api.github.com/repos/graknlabs/grakn/languages","stargazers_url":"https://api.github.com/repos/graknlabs/grakn/stargazers","contributors_url":"https://api.github.com/repos/graknlabs/grakn/contributors","subscribers_url":"https://api.github.com/repos/graknlabs/grakn/subscribers","subscription_url":"https://api.github.com/repos/graknlabs/grakn/subscription","commits_url":"https://api.github.com/repos/graknlabs/grakn/commits{/sha}","git_commits_url":"https://api.github.com/repos/graknlabs/grakn/git/commits{/sha}","comments_url":"https://api.github.com/repos/graknlabs/grakn/comments{/number}","issue_comment_url":"https://api.github.com/repos/graknlabs/grakn/issues/comments{/number}","contents_url":"https://api.github.com/repos/graknlabs/grakn/contents/{+path}","compare_url":"https://api.github.com/repos/graknlabs/grakn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/graknlabs/grakn/merges","archive_url":"https://api.github.com/repos/graknlabs/grakn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/graknlabs/grakn/downloads","issues_url":"https://api.github.com/repos/graknlabs/grakn/issues{/number}","pulls_url":"https://api.github.com/repos/graknlabs/grakn/pulls{/number}","milestones_url":"https://api.github.com/repos/graknlabs/grakn/milestones{/number}","notifications_url":"https://api.github.com/repos/graknlabs/grakn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/graknlabs/grakn/labels{/name}","releases_url":"https://api.github.com/repos/graknlabs/grakn/releases{/id}","deployments_url":"https://api.github.com/repos/graknlabs/grakn/deployments","created_at":"2016-07-11T23:59:57Z","updated_at":"2018-09-19T11:23:13Z","pushed_at":"2018-09-19T11:49:31Z","git_url":"git://github.com/graknlabs/grakn.git","ssh_url":"git@github.com:graknlabs/grakn.git","clone_url":"https://github.com/graknlabs/grakn.git","svn_url":"https://github.com/graknlabs/grakn","homepage":"https://grakn.ai","size":67792,"stargazers_count":1157,"watchers_count":1157,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":154,"mirror_url":null,"archived":false,"open_issues_count":38,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":154,"open_issues":38,"watchers":1157,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/graknlabs/grakn/pulls/2997"},"html":{"href":"https://github.com/graknlabs/grakn/pull/2997"},"issue":{"href":"https://api.github.com/repos/graknlabs/grakn/issues/2997"},"comments":{"href":"https://api.github.com/repos/graknlabs/grakn/issues/2997/comments"},"review_comments":{"href":"https://api.github.com/repos/graknlabs/grakn/pulls/2997/comments"},"review_comment":{"href":"https://api.github.com/repos/graknlabs/grakn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/graknlabs/grakn/pulls/2997/commits"},"statuses":{"href":"https://api.github.com/repos/graknlabs/grakn/statuses/57891c8c5e1f61a67f25817afdc47a51b211b35f"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"marco-scoppetta"}}