{"action":"opened","number":162,"pull_request":{"url":"https://api.github.com/repos/Remmeauth/remme-core/pulls/162","id":239406746,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5NDA2NzQ2","html_url":"https://github.com/Remmeauth/remme-core/pull/162","diff_url":"https://github.com/Remmeauth/remme-core/pull/162.diff","patch_url":"https://github.com/Remmeauth/remme-core/pull/162.patch","issue_url":"https://api.github.com/repos/Remmeauth/remme-core/issues/162","number":162,"state":"open","locked":false,"title":"WIP REM-885 Remove timestamp from atomic swap transactions","user":{"login":"eugene-babichenko","id":15912853,"node_id":"MDQ6VXNlcjE1OTEyODUz","avatar_url":"https://avatars1.githubusercontent.com/u/15912853?v=4","gravatar_id":"","url":"https://api.github.com/users/eugene-babichenko","html_url":"https://github.com/eugene-babichenko","followers_url":"https://api.github.com/users/eugene-babichenko/followers","following_url":"https://api.github.com/users/eugene-babichenko/following{/other_user}","gists_url":"https://api.github.com/users/eugene-babichenko/gists{/gist_id}","starred_url":"https://api.github.com/users/eugene-babichenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugene-babichenko/subscriptions","organizations_url":"https://api.github.com/users/eugene-babichenko/orgs","repos_url":"https://api.github.com/users/eugene-babichenko/repos","events_url":"https://api.github.com/users/eugene-babichenko/events{/privacy}","received_events_url":"https://api.github.com/users/eugene-babichenko/received_events","type":"User","site_admin":false},"body":"Implements issue REM-885.\r\n\r\nThis pull request removes timestamp from atomic swap transactions. In general, we should not trust any timings coming from a user. This timings also caused numerous bugs, so we decided to remove them.\r\n\r\n**A note about protocol buffers**\r\n\r\nThis pull request is backwards compatible with older protobufs **so it doesn't require an immediate update of the client libraries.**\r\n\r\nHowever, it uses protobuf definitions from a separate branch with `created_at` field removed. https://github.com/Remmeauth/remme-protobuf/pull/8\r\nThis should be merged only after client libraries upgrade.","created_at":"2018-12-18T08:50:13Z","updated_at":"2018-12-18T08:50:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Remmeauth/remme-core/pulls/162/commits","review_comments_url":"https://api.github.com/repos/Remmeauth/remme-core/pulls/162/comments","review_comment_url":"https://api.github.com/repos/Remmeauth/remme-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Remmeauth/remme-core/issues/162/comments","statuses_url":"https://api.github.com/repos/Remmeauth/remme-core/statuses/611a2c555ffbe1584774eec73c128db9932da075","head":{"label":"Remmeauth:f-remove-atomic-swap-timestamp-from-tx","ref":"f-remove-atomic-swap-timestamp-from-tx","sha":"611a2c555ffbe1584774eec73c128db9932da075","user":{"login":"Remmeauth","id":29229038,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MjI5MDM4","avatar_url":"https://avatars1.githubusercontent.com/u/29229038?v=4","gravatar_id":"","url":"https://api.github.com/users/Remmeauth","html_url":"https://github.com/Remmeauth","followers_url":"https://api.github.com/users/Remmeauth/followers","following_url":"https://api.github.com/users/Remmeauth/following{/other_user}","gists_url":"https://api.github.com/users/Remmeauth/gists{/gist_id}","starred_url":"https://api.github.com/users/Remmeauth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Remmeauth/subscriptions","organizations_url":"https://api.github.com/users/Remmeauth/orgs","repos_url":"https://api.github.com/users/Remmeauth/repos","events_url":"https://api.github.com/users/Remmeauth/events{/privacy}","received_events_url":"https://api.github.com/users/Remmeauth/received_events","type":"Organization","site_admin":false},"repo":{"id":121400220,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE0MDAyMjA=","name":"remme-core","full_name":"Remmeauth/remme-core","private":false,"owner":{"login":"Remmeauth","id":29229038,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MjI5MDM4","avatar_url":"https://avatars1.githubusercontent.com/u/29229038?v=4","gravatar_id":"","url":"https://api.github.com/users/Remmeauth","html_url":"https://github.com/Remmeauth","followers_url":"https://api.github.com/users/Remmeauth/followers","following_url":"https://api.github.com/users/Remmeauth/following{/other_user}","gists_url":"https://api.github.com/users/Remmeauth/gists{/gist_id}","starred_url":"https://api.github.com/users/Remmeauth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Remmeauth/subscriptions","organizations_url":"https://api.github.com/users/Remmeauth/orgs","repos_url":"https://api.github.com/users/Remmeauth/repos","events_url":"https://api.github.com/users/Remmeauth/events{/privacy}","received_events_url":"https://api.github.com/users/Remmeauth/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Remmeauth/remme-core","description":"Distributed Public Key Infrastructure (dPKI) protocol","fork":false,"url":"https://api.github.com/repos/Remmeauth/remme-core","forks_url":"https://api.github.com/repos/Remmeauth/remme-core/forks","keys_url":"https://api.github.com/repos/Remmeauth/remme-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Remmeauth/remme-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Remmeauth/remme-core/teams","hooks_url":"https://api.github.com/repos/Remmeauth/remme-core/hooks","issue_events_url":"https://api.github.com/repos/Remmeauth/remme-core/issues/events{/number}","events_url":"https://api.github.com/repos/Remmeauth/remme-core/events","assignees_url":"https://api.github.com/repos/Remmeauth/remme-core/assignees{/user}","branches_url":"https://api.github.com/repos/Remmeauth/remme-core/branches{/branch}","tags_url":"https://api.github.com/repos/Remmeauth/remme-core/tags","blobs_url":"https://api.github.com/repos/Remmeauth/remme-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Remmeauth/remme-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Remmeauth/remme-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/Remmeauth/remme-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Remmeauth/remme-core/statuses/{sha}","languages_url":"https://api.github.com/repos/Remmeauth/remme-core/languages","stargazers_url":"https://api.github.com/repos/Remmeauth/remme-core/stargazers","contributors_url":"https://api.github.com/repos/Remmeauth/remme-core/contributors","subscribers_url":"https://api.github.com/repos/Remmeauth/remme-core/subscribers","subscription_url":"https://api.github.com/repos/Remmeauth/remme-core/subscription","commits_url":"https://api.github.com/repos/Remmeauth/remme-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/Remmeauth/remme-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/Remmeauth/remme-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/Remmeauth/remme-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/Remmeauth/remme-core/contents/{+path}","compare_url":"https://api.github.com/repos/Remmeauth/remme-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Remmeauth/remme-core/merges","archive_url":"https://api.github.com/repos/Remmeauth/remme-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Remmeauth/remme-core/downloads","issues_url":"https://api.github.com/repos/Remmeauth/remme-core/issues{/number}","pulls_url":"https://api.github.com/repos/Remmeauth/remme-core/pulls{/number}","milestones_url":"https://api.github.com/repos/Remmeauth/remme-core/milestones{/number}","notifications_url":"https://api.github.com/repos/Remmeauth/remme-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Remmeauth/remme-core/labels{/name}","releases_url":"https://api.github.com/repos/Remmeauth/remme-core/releases{/id}","deployments_url":"https://api.github.com/repos/Remmeauth/remme-core/deployments","created_at":"2018-02-13T15:36:38Z","updated_at":"2018-12-12T22:29:09Z","pushed_at":"2018-12-18T08:42:24Z","git_url":"git://github.com/Remmeauth/remme-core.git","ssh_url":"git@github.com:Remmeauth/remme-core.git","clone_url":"https://github.com/Remmeauth/remme-core.git","svn_url":"https://github.com/Remmeauth/remme-core","homepage":"https://remme.io/","size":4926,"stargazers_count":50,"watchers_count":50,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":9,"open_issues":5,"watchers":50,"default_branch":"master"}},"base":{"label":"Remmeauth:dev","ref":"dev","sha":"7db3b685b16bf6441c79acee6bb49d16a05c58fc","user":{"login":"Remmeauth","id":29229038,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MjI5MDM4","avatar_url":"https://avatars1.githubusercontent.com/u/29229038?v=4","gravatar_id":"","url":"https://api.github.com/users/Remmeauth","html_url":"https://github.com/Remmeauth","followers_url":"https://api.github.com/users/Remmeauth/followers","following_url":"https://api.github.com/users/Remmeauth/following{/other_user}","gists_url":"https://api.github.com/users/Remmeauth/gists{/gist_id}","starred_url":"https://api.github.com/users/Remmeauth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Remmeauth/subscriptions","organizations_url":"https://api.github.com/users/Remmeauth/orgs","repos_url":"https://api.github.com/users/Remmeauth/repos","events_url":"https://api.github.com/users/Remmeauth/events{/privacy}","received_events_url":"https://api.github.com/users/Remmeauth/received_events","type":"Organization","site_admin":false},"repo":{"id":121400220,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE0MDAyMjA=","name":"remme-core","full_name":"Remmeauth/remme-core","private":false,"owner":{"login":"Remmeauth","id":29229038,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MjI5MDM4","avatar_url":"https://avatars1.githubusercontent.com/u/29229038?v=4","gravatar_id":"","url":"https://api.github.com/users/Remmeauth","html_url":"https://github.com/Remmeauth","followers_url":"https://api.github.com/users/Remmeauth/followers","following_url":"https://api.github.com/users/Remmeauth/following{/other_user}","gists_url":"https://api.github.com/users/Remmeauth/gists{/gist_id}","starred_url":"https://api.github.com/users/Remmeauth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Remmeauth/subscriptions","organizations_url":"https://api.github.com/users/Remmeauth/orgs","repos_url":"https://api.github.com/users/Remmeauth/repos","events_url":"https://api.github.com/users/Remmeauth/events{/privacy}","received_events_url":"https://api.github.com/users/Remmeauth/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Remmeauth/remme-core","description":"Distributed Public Key Infrastructure (dPKI) protocol","fork":false,"url":"https://api.github.com/repos/Remmeauth/remme-core","forks_url":"https://api.github.com/repos/Remmeauth/remme-core/forks","keys_url":"https://api.github.com/repos/Remmeauth/remme-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Remmeauth/remme-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Remmeauth/remme-core/teams","hooks_url":"https://api.github.com/repos/Remmeauth/remme-core/hooks","issue_events_url":"https://api.github.com/repos/Remmeauth/remme-core/issues/events{/number}","events_url":"https://api.github.com/repos/Remmeauth/remme-core/events","assignees_url":"https://api.github.com/repos/Remmeauth/remme-core/assignees{/user}","branches_url":"https://api.github.com/repos/Remmeauth/remme-core/branches{/branch}","tags_url":"https://api.github.com/repos/Remmeauth/remme-core/tags","blobs_url":"https://api.github.com/repos/Remmeauth/remme-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Remmeauth/remme-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Remmeauth/remme-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/Remmeauth/remme-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Remmeauth/remme-core/statuses/{sha}","languages_url":"https://api.github.com/repos/Remmeauth/remme-core/languages","stargazers_url":"https://api.github.com/repos/Remmeauth/remme-core/stargazers","contributors_url":"https://api.github.com/repos/Remmeauth/remme-core/contributors","subscribers_url":"https://api.github.com/repos/Remmeauth/remme-core/subscribers","subscription_url":"https://api.github.com/repos/Remmeauth/remme-core/subscription","commits_url":"https://api.github.com/repos/Remmeauth/remme-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/Remmeauth/remme-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/Remmeauth/remme-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/Remmeauth/remme-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/Remmeauth/remme-core/contents/{+path}","compare_url":"https://api.github.com/repos/Remmeauth/remme-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Remmeauth/remme-core/merges","archive_url":"https://api.github.com/repos/Remmeauth/remme-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Remmeauth/remme-core/downloads","issues_url":"https://api.github.com/repos/Remmeauth/remme-core/issues{/number}","pulls_url":"https://api.github.com/repos/Remmeauth/remme-core/pulls{/number}","milestones_url":"https://api.github.com/repos/Remmeauth/remme-core/milestones{/number}","notifications_url":"https://api.github.com/repos/Remmeauth/remme-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Remmeauth/remme-core/labels{/name}","releases_url":"https://api.github.com/repos/Remmeauth/remme-core/releases{/id}","deployments_url":"https://api.github.com/repos/Remmeauth/remme-core/deployments","created_at":"2018-02-13T15:36:38Z","updated_at":"2018-12-12T22:29:09Z","pushed_at":"2018-12-18T08:42:24Z","git_url":"git://github.com/Remmeauth/remme-core.git","ssh_url":"git@github.com:Remmeauth/remme-core.git","clone_url":"https://github.com/Remmeauth/remme-core.git","svn_url":"https://github.com/Remmeauth/remme-core","homepage":"https://remme.io/","size":4926,"stargazers_count":50,"watchers_count":50,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":9,"open_issues":5,"watchers":50,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Remmeauth/remme-core/pulls/162"},"html":{"href":"https://github.com/Remmeauth/remme-core/pull/162"},"issue":{"href":"https://api.github.com/repos/Remmeauth/remme-core/issues/162"},"comments":{"href":"https://api.github.com/repos/Remmeauth/remme-core/issues/162/comments"},"review_comments":{"href":"https://api.github.com/repos/Remmeauth/remme-core/pulls/162/comments"},"review_comment":{"href":"https://api.github.com/repos/Remmeauth/remme-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Remmeauth/remme-core/pulls/162/commits"},"statuses":{"href":"https://api.github.com/repos/Remmeauth/remme-core/statuses/611a2c555ffbe1584774eec73c128db9932da075"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":6,"deletions":11,"changed_files":2}}
{"actor":{"display_login":"eugene-babichenko"}}