{"action":"created","comment":{"url":"https://api.github.com/repos/victordomingos/Count-files/pulls/comments/187920661","pull_request_review_id":119794944,"id":187920661,"diff_hunk":"@@ -53,6 +55,7 @@ def _has_hidden_attribute(filepath):\n     Adapted from Jason R. Coombs (https://stackoverflow.com/a/6365265/6167478)\n     \"\"\"\n     try:\n+        # unresolved reference 'unicode'?","path":"countfiles/utils/file_handlers.py","position":12,"original_position":12,"commit_id":"bb288bcf4cbdb5b143dd862e253160efd6f82737","original_commit_id":"d3aee74ccaf63c78ee51b4b37847026c31e19196","user":{"login":"victordomingos","id":18650184,"avatar_url":"https://avatars3.githubusercontent.com/u/18650184?v=4","gravatar_id":"","url":"https://api.github.com/users/victordomingos","html_url":"https://github.com/victordomingos","followers_url":"https://api.github.com/users/victordomingos/followers","following_url":"https://api.github.com/users/victordomingos/following{/other_user}","gists_url":"https://api.github.com/users/victordomingos/gists{/gist_id}","starred_url":"https://api.github.com/users/victordomingos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/victordomingos/subscriptions","organizations_url":"https://api.github.com/users/victordomingos/orgs","repos_url":"https://api.github.com/users/victordomingos/repos","events_url":"https://api.github.com/users/victordomingos/events{/privacy}","received_events_url":"https://api.github.com/users/victordomingos/received_events","type":"User","site_admin":false},"body":"If it works as I suggested above, could you please update your pull request by removing the `unicode()` call?","created_at":"2018-05-14T11:36:49Z","updated_at":"2018-05-14T11:50:55Z","html_url":"https://github.com/victordomingos/Count-files/pull/22#discussion_r187920661","pull_request_url":"https://api.github.com/repos/victordomingos/Count-files/pulls/22","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/victordomingos/Count-files/pulls/comments/187920661"},"html":{"href":"https://github.com/victordomingos/Count-files/pull/22#discussion_r187920661"},"pull_request":{"href":"https://api.github.com/repos/victordomingos/Count-files/pulls/22"}},"in_reply_to_id":187906679},"pull_request":{"url":"https://api.github.com/repos/victordomingos/Count-files/pulls/22","id":187763709,"html_url":"https://github.com/victordomingos/Count-files/pull/22","diff_url":"https://github.com/victordomingos/Count-files/pull/22.diff","patch_url":"https://github.com/victordomingos/Count-files/pull/22.patch","issue_url":"https://api.github.com/repos/victordomingos/Count-files/issues/22","number":22,"state":"open","locked":false,"title":"added def recursive_search, def non_recursive_search and def is_hidden_file_or_dir","user":{"login":"NataliaBondarenko","id":23127253,"avatar_url":"https://avatars1.githubusercontent.com/u/23127253?v=4","gravatar_id":"","url":"https://api.github.com/users/NataliaBondarenko","html_url":"https://github.com/NataliaBondarenko","followers_url":"https://api.github.com/users/NataliaBondarenko/followers","following_url":"https://api.github.com/users/NataliaBondarenko/following{/other_user}","gists_url":"https://api.github.com/users/NataliaBondarenko/gists{/gist_id}","starred_url":"https://api.github.com/users/NataliaBondarenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NataliaBondarenko/subscriptions","organizations_url":"https://api.github.com/users/NataliaBondarenko/orgs","repos_url":"https://api.github.com/users/NataliaBondarenko/repos","events_url":"https://api.github.com/users/NataliaBondarenko/events{/privacy}","received_events_url":"https://api.github.com/users/NataliaBondarenko/received_events","type":"User","site_admin":false},"body":"changelog:\r\n- For allow to choose inclusion or exclusion of hidden files/directories:\r\n  - Added def recursive_search, def non_recursive_search and def is_hidden_file_or_dir to utils/file_handlers.py\r\n- Added tests for new functions, new test dataset for Windows and Linux (with hidden filles)\r\n- Added platform_name = sys.platform in main.py\r\n-  if not include_hidden and is_hidden_file_or_dir(platform_name, location):\r\n        print(f'\\nNot counting any files, because {loc_text[2:]} is hidden.') moved to top\r\nTODO: \r\n  - adapt for Pythonista/iOS and test.\r\n  - add checking for hidden folder in Windows to skip it.\r\n  - check the speed of processing large folders for def recursive_search, def non_recursive_search (Windows and Linux)\r\n- Note: Integration tests are falling due to unresolved reference 'unicode' in def _has_hidden_attribute (utils/file_handlers.py)","created_at":"2018-05-14T09:13:57Z","updated_at":"2018-05-14T11:50:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d7ab753e0cf3ae7f0e77502876a2a0fdee2bd61d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/victordomingos/Count-files/pulls/22/commits","review_comments_url":"https://api.github.com/repos/victordomingos/Count-files/pulls/22/comments","review_comment_url":"https://api.github.com/repos/victordomingos/Count-files/pulls/comments{/number}","comments_url":"https://api.github.com/repos/victordomingos/Count-files/issues/22/comments","statuses_url":"https://api.github.com/repos/victordomingos/Count-files/statuses/bb288bcf4cbdb5b143dd862e253160efd6f82737","head":{"label":"NataliaBondarenko:master","ref":"master","sha":"bb288bcf4cbdb5b143dd862e253160efd6f82737","user":{"login":"NataliaBondarenko","id":23127253,"avatar_url":"https://avatars1.githubusercontent.com/u/23127253?v=4","gravatar_id":"","url":"https://api.github.com/users/NataliaBondarenko","html_url":"https://github.com/NataliaBondarenko","followers_url":"https://api.github.com/users/NataliaBondarenko/followers","following_url":"https://api.github.com/users/NataliaBondarenko/following{/other_user}","gists_url":"https://api.github.com/users/NataliaBondarenko/gists{/gist_id}","starred_url":"https://api.github.com/users/NataliaBondarenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NataliaBondarenko/subscriptions","organizations_url":"https://api.github.com/users/NataliaBondarenko/orgs","repos_url":"https://api.github.com/users/NataliaBondarenko/repos","events_url":"https://api.github.com/users/NataliaBondarenko/events{/privacy}","received_events_url":"https://api.github.com/users/NataliaBondarenko/received_events","type":"User","site_admin":false},"repo":{"id":132328440,"name":"Count-files","full_name":"NataliaBondarenko/Count-files","owner":{"login":"NataliaBondarenko","id":23127253,"avatar_url":"https://avatars1.githubusercontent.com/u/23127253?v=4","gravatar_id":"","url":"https://api.github.com/users/NataliaBondarenko","html_url":"https://github.com/NataliaBondarenko","followers_url":"https://api.github.com/users/NataliaBondarenko/followers","following_url":"https://api.github.com/users/NataliaBondarenko/following{/other_user}","gists_url":"https://api.github.com/users/NataliaBondarenko/gists{/gist_id}","starred_url":"https://api.github.com/users/NataliaBondarenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NataliaBondarenko/subscriptions","organizations_url":"https://api.github.com/users/NataliaBondarenko/orgs","repos_url":"https://api.github.com/users/NataliaBondarenko/repos","events_url":"https://api.github.com/users/NataliaBondarenko/events{/privacy}","received_events_url":"https://api.github.com/users/NataliaBondarenko/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/NataliaBondarenko/Count-files","description":"A little CLI utility written in Python to help you count files, grouped by extension, in a directory. By default, it will count files recursively in current working directory and all of its subdirectories, and will display a table showing the frequency for each file extension (e.g.: .txt, .py, .html, .css) and the total number of files found.","fork":true,"url":"https://api.github.com/repos/NataliaBondarenko/Count-files","forks_url":"https://api.github.com/repos/NataliaBondarenko/Count-files/forks","keys_url":"https://api.github.com/repos/NataliaBondarenko/Count-files/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NataliaBondarenko/Count-files/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NataliaBondarenko/Count-files/teams","hooks_url":"https://api.github.com/repos/NataliaBondarenko/Count-files/hooks","issue_events_url":"https://api.github.com/repos/NataliaBondarenko/Count-files/issues/events{/number}","events_url":"https://api.github.com/repos/NataliaBondarenko/Count-files/events","assignees_url":"https://api.github.com/repos/NataliaBondarenko/Count-files/assignees{/user}","branches_url":"https://api.github.com/repos/NataliaBondarenko/Count-files/branches{/branch}","tags_url":"https://api.github.com/repos/NataliaBondarenko/Count-files/tags","blobs_url":"https://api.github.com/repos/NataliaBondarenko/Count-files/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NataliaBondarenko/Count-files/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NataliaBondarenko/Count-files/git/refs{/sha}","trees_url":"https://api.github.com/repos/NataliaBondarenko/Count-files/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NataliaBondarenko/Count-files/statuses/{sha}","languages_url":"https://api.github.com/repos/NataliaBondarenko/Count-files/languages","stargazers_url":"https://api.github.com/repos/NataliaBondarenko/Count-files/stargazers","contributors_url":"https://api.github.com/repos/NataliaBondarenko/Count-files/contributors","subscribers_url":"https://api.github.com/repos/NataliaBondarenko/Count-files/subscribers","subscription_url":"https://api.github.com/repos/NataliaBondarenko/Count-files/subscription","commits_url":"https://api.github.com/repos/NataliaBondarenko/Count-files/commits{/sha}","git_commits_url":"https://api.github.com/repos/NataliaBondarenko/Count-files/git/commits{/sha}","comments_url":"https://api.github.com/repos/NataliaBondarenko/Count-files/comments{/number}","issue_comment_url":"https://api.github.com/repos/NataliaBondarenko/Count-files/issues/comments{/number}","contents_url":"https://api.github.com/repos/NataliaBondarenko/Count-files/contents/{+path}","compare_url":"https://api.github.com/repos/NataliaBondarenko/Count-files/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NataliaBondarenko/Count-files/merges","archive_url":"https://api.github.com/repos/NataliaBondarenko/Count-files/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NataliaBondarenko/Count-files/downloads","issues_url":"https://api.github.com/repos/NataliaBondarenko/Count-files/issues{/number}","pulls_url":"https://api.github.com/repos/NataliaBondarenko/Count-files/pulls{/number}","milestones_url":"https://api.github.com/repos/NataliaBondarenko/Count-files/milestones{/number}","notifications_url":"https://api.github.com/repos/NataliaBondarenko/Count-files/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NataliaBondarenko/Count-files/labels{/name}","releases_url":"https://api.github.com/repos/NataliaBondarenko/Count-files/releases{/id}","deployments_url":"https://api.github.com/repos/NataliaBondarenko/Count-files/deployments","created_at":"2018-05-06T10:30:29Z","updated_at":"2018-05-14T08:52:31Z","pushed_at":"2018-05-14T08:52:30Z","git_url":"git://github.com/NataliaBondarenko/Count-files.git","ssh_url":"git@github.com:NataliaBondarenko/Count-files.git","clone_url":"https://github.com/NataliaBondarenko/Count-files.git","svn_url":"https://github.com/NataliaBondarenko/Count-files","homepage":"","size":2090,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"cc-by-sa-4.0","name":"Creative Commons Attribution Share Alike 4.0","spdx_id":"CC-BY-SA-4.0","url":"https://api.github.com/licenses/cc-by-sa-4.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"victordomingos:master","ref":"master","sha":"9137580b07dace7b4f2ca70ee22dc6657f9ba3a5","user":{"login":"victordomingos","id":18650184,"avatar_url":"https://avatars3.githubusercontent.com/u/18650184?v=4","gravatar_id":"","url":"https://api.github.com/users/victordomingos","html_url":"https://github.com/victordomingos","followers_url":"https://api.github.com/users/victordomingos/followers","following_url":"https://api.github.com/users/victordomingos/following{/other_user}","gists_url":"https://api.github.com/users/victordomingos/gists{/gist_id}","starred_url":"https://api.github.com/users/victordomingos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/victordomingos/subscriptions","organizations_url":"https://api.github.com/users/victordomingos/orgs","repos_url":"https://api.github.com/users/victordomingos/repos","events_url":"https://api.github.com/users/victordomingos/events{/privacy}","received_events_url":"https://api.github.com/users/victordomingos/received_events","type":"User","site_admin":false},"repo":{"id":131506465,"name":"Count-files","full_name":"victordomingos/Count-files","owner":{"login":"victordomingos","id":18650184,"avatar_url":"https://avatars3.githubusercontent.com/u/18650184?v=4","gravatar_id":"","url":"https://api.github.com/users/victordomingos","html_url":"https://github.com/victordomingos","followers_url":"https://api.github.com/users/victordomingos/followers","following_url":"https://api.github.com/users/victordomingos/following{/other_user}","gists_url":"https://api.github.com/users/victordomingos/gists{/gist_id}","starred_url":"https://api.github.com/users/victordomingos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/victordomingos/subscriptions","organizations_url":"https://api.github.com/users/victordomingos/orgs","repos_url":"https://api.github.com/users/victordomingos/repos","events_url":"https://api.github.com/users/victordomingos/events{/privacy}","received_events_url":"https://api.github.com/users/victordomingos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/victordomingos/Count-files","description":"A little CLI utility written in Python to help you count files, grouped by extension, in a directory. By default, it will count files recursively in current working directory and all of its subdirectories, and will display a table showing the frequency for each file extension (e.g.: .txt, .py, .html, .css) and the total number of files found.","fork":false,"url":"https://api.github.com/repos/victordomingos/Count-files","forks_url":"https://api.github.com/repos/victordomingos/Count-files/forks","keys_url":"https://api.github.com/repos/victordomingos/Count-files/keys{/key_id}","collaborators_url":"https://api.github.com/repos/victordomingos/Count-files/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/victordomingos/Count-files/teams","hooks_url":"https://api.github.com/repos/victordomingos/Count-files/hooks","issue_events_url":"https://api.github.com/repos/victordomingos/Count-files/issues/events{/number}","events_url":"https://api.github.com/repos/victordomingos/Count-files/events","assignees_url":"https://api.github.com/repos/victordomingos/Count-files/assignees{/user}","branches_url":"https://api.github.com/repos/victordomingos/Count-files/branches{/branch}","tags_url":"https://api.github.com/repos/victordomingos/Count-files/tags","blobs_url":"https://api.github.com/repos/victordomingos/Count-files/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/victordomingos/Count-files/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/victordomingos/Count-files/git/refs{/sha}","trees_url":"https://api.github.com/repos/victordomingos/Count-files/git/trees{/sha}","statuses_url":"https://api.github.com/repos/victordomingos/Count-files/statuses/{sha}","languages_url":"https://api.github.com/repos/victordomingos/Count-files/languages","stargazers_url":"https://api.github.com/repos/victordomingos/Count-files/stargazers","contributors_url":"https://api.github.com/repos/victordomingos/Count-files/contributors","subscribers_url":"https://api.github.com/repos/victordomingos/Count-files/subscribers","subscription_url":"https://api.github.com/repos/victordomingos/Count-files/subscription","commits_url":"https://api.github.com/repos/victordomingos/Count-files/commits{/sha}","git_commits_url":"https://api.github.com/repos/victordomingos/Count-files/git/commits{/sha}","comments_url":"https://api.github.com/repos/victordomingos/Count-files/comments{/number}","issue_comment_url":"https://api.github.com/repos/victordomingos/Count-files/issues/comments{/number}","contents_url":"https://api.github.com/repos/victordomingos/Count-files/contents/{+path}","compare_url":"https://api.github.com/repos/victordomingos/Count-files/compare/{base}...{head}","merges_url":"https://api.github.com/repos/victordomingos/Count-files/merges","archive_url":"https://api.github.com/repos/victordomingos/Count-files/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/victordomingos/Count-files/downloads","issues_url":"https://api.github.com/repos/victordomingos/Count-files/issues{/number}","pulls_url":"https://api.github.com/repos/victordomingos/Count-files/pulls{/number}","milestones_url":"https://api.github.com/repos/victordomingos/Count-files/milestones{/number}","notifications_url":"https://api.github.com/repos/victordomingos/Count-files/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/victordomingos/Count-files/labels{/name}","releases_url":"https://api.github.com/repos/victordomingos/Count-files/releases{/id}","deployments_url":"https://api.github.com/repos/victordomingos/Count-files/deployments","created_at":"2018-04-29T15:32:19Z","updated_at":"2018-05-13T10:43:34Z","pushed_at":"2018-05-14T09:13:58Z","git_url":"git://github.com/victordomingos/Count-files.git","ssh_url":"git@github.com:victordomingos/Count-files.git","clone_url":"https://github.com/victordomingos/Count-files.git","svn_url":"https://github.com/victordomingos/Count-files","homepage":"","size":2077,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"cc-by-sa-4.0","name":"Creative Commons Attribution Share Alike 4.0","spdx_id":"CC-BY-SA-4.0","url":"https://api.github.com/licenses/cc-by-sa-4.0"},"forks":2,"open_issues":7,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/victordomingos/Count-files/pulls/22"},"html":{"href":"https://github.com/victordomingos/Count-files/pull/22"},"issue":{"href":"https://api.github.com/repos/victordomingos/Count-files/issues/22"},"comments":{"href":"https://api.github.com/repos/victordomingos/Count-files/issues/22/comments"},"review_comments":{"href":"https://api.github.com/repos/victordomingos/Count-files/pulls/22/comments"},"review_comment":{"href":"https://api.github.com/repos/victordomingos/Count-files/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/victordomingos/Count-files/pulls/22/commits"},"statuses":{"href":"https://api.github.com/repos/victordomingos/Count-files/statuses/bb288bcf4cbdb5b143dd862e253160efd6f82737"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"victordomingos"}}