{"action":"created","comment":{"url":"https://api.github.com/repos/codice/saml-conformance/pulls/comments/242305140","pull_request_review_id":185784768,"id":242305140,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjMwNTE0MA==","diff_hunk":"@@ -99,12 +99,21 @@ When logging in to an IdP using the Single Sign-On protocol, there are 6 steps:\n 1. Service Provider grants or denies access to Principal\n \n The specification mentions that in step 4, \"the principal is identified by the identity provider by some means outside the scope of \\[the Single Sign-On\\] profile\".\n-Since the authentication step is implementation specific, each IdP must write a plugin which will process the authentication of a principal.\n+This means that the CTK doesn't know how to give the IdP the principal's credentials, since the authentication step is implementation specific. \\\n+Therefore each IdP must write a plugin which will process the authentication of a principal.\n See [4.1 Web Browser SSO Profile](https://www.oasis-open.org/committees/download.php/56782/sstc-saml-profiles-errata-2.0-wd-07.pdf) for more information on the different steps for the SSO profile.\n \n+###### Examining the DDF plugin jar\n+In the case of DDF's IdP plugin:\n+\n+1. The plugin implements the [IdpSSOResponder](external/samlconf-plugins-api/src/main/java/org/codice/compliance/saml/plugin/IdpSSOResponder.java) interface.\n+1. The plugin receives the login page from DDF's IdP as an http response in the interface methods.","path":"README.md","position":13,"original_position":13,"commit_id":"f1ba613af7650e047837dd53a7d4a2bc18c31283","original_commit_id":"f1ba613af7650e047837dd53a7d4a2bc18c31283","user":{"login":"bakejeyner","id":14284361,"node_id":"MDQ6VXNlcjE0Mjg0MzYx","avatar_url":"https://avatars2.githubusercontent.com/u/14284361?v=4","gravatar_id":"","url":"https://api.github.com/users/bakejeyner","html_url":"https://github.com/bakejeyner","followers_url":"https://api.github.com/users/bakejeyner/followers","following_url":"https://api.github.com/users/bakejeyner/following{/other_user}","gists_url":"https://api.github.com/users/bakejeyner/gists{/gist_id}","starred_url":"https://api.github.com/users/bakejeyner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bakejeyner/subscriptions","organizations_url":"https://api.github.com/users/bakejeyner/orgs","repos_url":"https://api.github.com/users/bakejeyner/repos","events_url":"https://api.github.com/users/bakejeyner/events{/privacy}","received_events_url":"https://api.github.com/users/bakejeyner/received_events","type":"User","site_admin":false},"body":"I actually prefer not sequentially numbering the list in the source. That way if we need to add a step, we don't have to refactor all of the numbers.","created_at":"2018-12-17T20:30:37Z","updated_at":"2018-12-17T20:30:37Z","html_url":"https://github.com/codice/saml-conformance/pull/206#discussion_r242305140","pull_request_url":"https://api.github.com/repos/codice/saml-conformance/pulls/206","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/codice/saml-conformance/pulls/comments/242305140"},"html":{"href":"https://github.com/codice/saml-conformance/pull/206#discussion_r242305140"},"pull_request":{"href":"https://api.github.com/repos/codice/saml-conformance/pulls/206"}},"in_reply_to_id":237667203},"pull_request":{"url":"https://api.github.com/repos/codice/saml-conformance/pulls/206","id":234792829,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NzkyODI5","html_url":"https://github.com/codice/saml-conformance/pull/206","diff_url":"https://github.com/codice/saml-conformance/pull/206.diff","patch_url":"https://github.com/codice/saml-conformance/pull/206.patch","issue_url":"https://api.github.com/repos/codice/saml-conformance/issues/206","number":206,"state":"open","locked":false,"title":"Improve plugin section of readme","user":{"login":"bakejeyner","id":14284361,"node_id":"MDQ6VXNlcjE0Mjg0MzYx","avatar_url":"https://avatars2.githubusercontent.com/u/14284361?v=4","gravatar_id":"","url":"https://api.github.com/users/bakejeyner","html_url":"https://github.com/bakejeyner","followers_url":"https://api.github.com/users/bakejeyner/followers","following_url":"https://api.github.com/users/bakejeyner/following{/other_user}","gists_url":"https://api.github.com/users/bakejeyner/gists{/gist_id}","starred_url":"https://api.github.com/users/bakejeyner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bakejeyner/subscriptions","organizations_url":"https://api.github.com/users/bakejeyner/orgs","repos_url":"https://api.github.com/users/bakejeyner/repos","events_url":"https://api.github.com/users/bakejeyner/events{/privacy}","received_events_url":"https://api.github.com/users/bakejeyner/received_events","type":"User","site_admin":false},"body":"### Description of the Change\r\n<!--\r\nWe must be able to understand your change from this description.\r\n-->\r\nImproving the plugin jar section of the root readme.\r\n\r\n### SAML V2.0 Specification Quote\r\n<!--\r\nAdd the SAML document, section, and a direct quote of the section being tested.\r\n-->\r\nN/A\r\n\r\n### Verification Process\r\n<!--\r\nWhat process did you follow to verify that your change has the desired effects?\r\n- How did you verify that all new functionality works as expected?\r\n- Which Identity Providers did you test your changes against?\r\n-->\r\nN/A\r\n\r\n### Checklist:\r\n- [ ] Unit Tests Added/Modified\r\n","created_at":"2018-11-29T21:30:45Z","updated_at":"2018-12-17T20:30:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8dfc902a75b9c4a4629a6561ebf09ee397febd36","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/codice/saml-conformance/pulls/206/commits","review_comments_url":"https://api.github.com/repos/codice/saml-conformance/pulls/206/comments","review_comment_url":"https://api.github.com/repos/codice/saml-conformance/pulls/comments{/number}","comments_url":"https://api.github.com/repos/codice/saml-conformance/issues/206/comments","statuses_url":"https://api.github.com/repos/codice/saml-conformance/statuses/f1ba613af7650e047837dd53a7d4a2bc18c31283","head":{"label":"bakejeyner:readme-improvements","ref":"readme-improvements","sha":"f1ba613af7650e047837dd53a7d4a2bc18c31283","user":{"login":"bakejeyner","id":14284361,"node_id":"MDQ6VXNlcjE0Mjg0MzYx","avatar_url":"https://avatars2.githubusercontent.com/u/14284361?v=4","gravatar_id":"","url":"https://api.github.com/users/bakejeyner","html_url":"https://github.com/bakejeyner","followers_url":"https://api.github.com/users/bakejeyner/followers","following_url":"https://api.github.com/users/bakejeyner/following{/other_user}","gists_url":"https://api.github.com/users/bakejeyner/gists{/gist_id}","starred_url":"https://api.github.com/users/bakejeyner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bakejeyner/subscriptions","organizations_url":"https://api.github.com/users/bakejeyner/orgs","repos_url":"https://api.github.com/users/bakejeyner/repos","events_url":"https://api.github.com/users/bakejeyner/events{/privacy}","received_events_url":"https://api.github.com/users/bakejeyner/received_events","type":"User","site_admin":false},"repo":{"id":126053857,"node_id":"MDEwOlJlcG9zaXRvcnkxMjYwNTM4NTc=","name":"saml-conformance","full_name":"bakejeyner/saml-conformance","private":false,"owner":{"login":"bakejeyner","id":14284361,"node_id":"MDQ6VXNlcjE0Mjg0MzYx","avatar_url":"https://avatars2.githubusercontent.com/u/14284361?v=4","gravatar_id":"","url":"https://api.github.com/users/bakejeyner","html_url":"https://github.com/bakejeyner","followers_url":"https://api.github.com/users/bakejeyner/followers","following_url":"https://api.github.com/users/bakejeyner/following{/other_user}","gists_url":"https://api.github.com/users/bakejeyner/gists{/gist_id}","starred_url":"https://api.github.com/users/bakejeyner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bakejeyner/subscriptions","organizations_url":"https://api.github.com/users/bakejeyner/orgs","repos_url":"https://api.github.com/users/bakejeyner/repos","events_url":"https://api.github.com/users/bakejeyner/events{/privacy}","received_events_url":"https://api.github.com/users/bakejeyner/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bakejeyner/saml-conformance","description":null,"fork":true,"url":"https://api.github.com/repos/bakejeyner/saml-conformance","forks_url":"https://api.github.com/repos/bakejeyner/saml-conformance/forks","keys_url":"https://api.github.com/repos/bakejeyner/saml-conformance/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bakejeyner/saml-conformance/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bakejeyner/saml-conformance/teams","hooks_url":"https://api.github.com/repos/bakejeyner/saml-conformance/hooks","issue_events_url":"https://api.github.com/repos/bakejeyner/saml-conformance/issues/events{/number}","events_url":"https://api.github.com/repos/bakejeyner/saml-conformance/events","assignees_url":"https://api.github.com/repos/bakejeyner/saml-conformance/assignees{/user}","branches_url":"https://api.github.com/repos/bakejeyner/saml-conformance/branches{/branch}","tags_url":"https://api.github.com/repos/bakejeyner/saml-conformance/tags","blobs_url":"https://api.github.com/repos/bakejeyner/saml-conformance/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bakejeyner/saml-conformance/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bakejeyner/saml-conformance/git/refs{/sha}","trees_url":"https://api.github.com/repos/bakejeyner/saml-conformance/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bakejeyner/saml-conformance/statuses/{sha}","languages_url":"https://api.github.com/repos/bakejeyner/saml-conformance/languages","stargazers_url":"https://api.github.com/repos/bakejeyner/saml-conformance/stargazers","contributors_url":"https://api.github.com/repos/bakejeyner/saml-conformance/contributors","subscribers_url":"https://api.github.com/repos/bakejeyner/saml-conformance/subscribers","subscription_url":"https://api.github.com/repos/bakejeyner/saml-conformance/subscription","commits_url":"https://api.github.com/repos/bakejeyner/saml-conformance/commits{/sha}","git_commits_url":"https://api.github.com/repos/bakejeyner/saml-conformance/git/commits{/sha}","comments_url":"https://api.github.com/repos/bakejeyner/saml-conformance/comments{/number}","issue_comment_url":"https://api.github.com/repos/bakejeyner/saml-conformance/issues/comments{/number}","contents_url":"https://api.github.com/repos/bakejeyner/saml-conformance/contents/{+path}","compare_url":"https://api.github.com/repos/bakejeyner/saml-conformance/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bakejeyner/saml-conformance/merges","archive_url":"https://api.github.com/repos/bakejeyner/saml-conformance/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bakejeyner/saml-conformance/downloads","issues_url":"https://api.github.com/repos/bakejeyner/saml-conformance/issues{/number}","pulls_url":"https://api.github.com/repos/bakejeyner/saml-conformance/pulls{/number}","milestones_url":"https://api.github.com/repos/bakejeyner/saml-conformance/milestones{/number}","notifications_url":"https://api.github.com/repos/bakejeyner/saml-conformance/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bakejeyner/saml-conformance/labels{/name}","releases_url":"https://api.github.com/repos/bakejeyner/saml-conformance/releases{/id}","deployments_url":"https://api.github.com/repos/bakejeyner/saml-conformance/deployments","created_at":"2018-03-20T17:05:50Z","updated_at":"2018-09-12T15:08:04Z","pushed_at":"2018-11-29T21:29:38Z","git_url":"git://github.com/bakejeyner/saml-conformance.git","ssh_url":"git@github.com:bakejeyner/saml-conformance.git","clone_url":"https://github.com/bakejeyner/saml-conformance.git","svn_url":"https://github.com/bakejeyner/saml-conformance","homepage":null,"size":1351,"stargazers_count":0,"watchers_count":0,"language":"Kotlin","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"codice:master","ref":"master","sha":"1f5feed269a666813530a2647bb711f1d671a2f5","user":{"login":"codice","id":2386734,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzODY3MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2386734?v=4","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"repo":{"id":121804316,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE4MDQzMTY=","name":"saml-conformance","full_name":"codice/saml-conformance","private":false,"owner":{"login":"codice","id":2386734,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzODY3MzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2386734?v=4","gravatar_id":"","url":"https://api.github.com/users/codice","html_url":"https://github.com/codice","followers_url":"https://api.github.com/users/codice/followers","following_url":"https://api.github.com/users/codice/following{/other_user}","gists_url":"https://api.github.com/users/codice/gists{/gist_id}","starred_url":"https://api.github.com/users/codice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codice/subscriptions","organizations_url":"https://api.github.com/users/codice/orgs","repos_url":"https://api.github.com/users/codice/repos","events_url":"https://api.github.com/users/codice/events{/privacy}","received_events_url":"https://api.github.com/users/codice/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/codice/saml-conformance","description":"A set of blackbox tests that verify the conformance of an Identity Provider to the SAML V2.0 Standard Specification.","fork":false,"url":"https://api.github.com/repos/codice/saml-conformance","forks_url":"https://api.github.com/repos/codice/saml-conformance/forks","keys_url":"https://api.github.com/repos/codice/saml-conformance/keys{/key_id}","collaborators_url":"https://api.github.com/repos/codice/saml-conformance/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/codice/saml-conformance/teams","hooks_url":"https://api.github.com/repos/codice/saml-conformance/hooks","issue_events_url":"https://api.github.com/repos/codice/saml-conformance/issues/events{/number}","events_url":"https://api.github.com/repos/codice/saml-conformance/events","assignees_url":"https://api.github.com/repos/codice/saml-conformance/assignees{/user}","branches_url":"https://api.github.com/repos/codice/saml-conformance/branches{/branch}","tags_url":"https://api.github.com/repos/codice/saml-conformance/tags","blobs_url":"https://api.github.com/repos/codice/saml-conformance/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/codice/saml-conformance/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/codice/saml-conformance/git/refs{/sha}","trees_url":"https://api.github.com/repos/codice/saml-conformance/git/trees{/sha}","statuses_url":"https://api.github.com/repos/codice/saml-conformance/statuses/{sha}","languages_url":"https://api.github.com/repos/codice/saml-conformance/languages","stargazers_url":"https://api.github.com/repos/codice/saml-conformance/stargazers","contributors_url":"https://api.github.com/repos/codice/saml-conformance/contributors","subscribers_url":"https://api.github.com/repos/codice/saml-conformance/subscribers","subscription_url":"https://api.github.com/repos/codice/saml-conformance/subscription","commits_url":"https://api.github.com/repos/codice/saml-conformance/commits{/sha}","git_commits_url":"https://api.github.com/repos/codice/saml-conformance/git/commits{/sha}","comments_url":"https://api.github.com/repos/codice/saml-conformance/comments{/number}","issue_comment_url":"https://api.github.com/repos/codice/saml-conformance/issues/comments{/number}","contents_url":"https://api.github.com/repos/codice/saml-conformance/contents/{+path}","compare_url":"https://api.github.com/repos/codice/saml-conformance/compare/{base}...{head}","merges_url":"https://api.github.com/repos/codice/saml-conformance/merges","archive_url":"https://api.github.com/repos/codice/saml-conformance/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/codice/saml-conformance/downloads","issues_url":"https://api.github.com/repos/codice/saml-conformance/issues{/number}","pulls_url":"https://api.github.com/repos/codice/saml-conformance/pulls{/number}","milestones_url":"https://api.github.com/repos/codice/saml-conformance/milestones{/number}","notifications_url":"https://api.github.com/repos/codice/saml-conformance/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/codice/saml-conformance/labels{/name}","releases_url":"https://api.github.com/repos/codice/saml-conformance/releases{/id}","deployments_url":"https://api.github.com/repos/codice/saml-conformance/deployments","created_at":"2018-02-16T21:48:23Z","updated_at":"2018-12-13T17:22:50Z","pushed_at":"2018-12-17T20:21:09Z","git_url":"git://github.com/codice/saml-conformance.git","ssh_url":"git@github.com:codice/saml-conformance.git","clone_url":"https://github.com/codice/saml-conformance.git","svn_url":"https://github.com/codice/saml-conformance","homepage":"","size":1339,"stargazers_count":3,"watchers_count":3,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":7,"license":null,"forks":8,"open_issues":7,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/codice/saml-conformance/pulls/206"},"html":{"href":"https://github.com/codice/saml-conformance/pull/206"},"issue":{"href":"https://api.github.com/repos/codice/saml-conformance/issues/206"},"comments":{"href":"https://api.github.com/repos/codice/saml-conformance/issues/206/comments"},"review_comments":{"href":"https://api.github.com/repos/codice/saml-conformance/pulls/206/comments"},"review_comment":{"href":"https://api.github.com/repos/codice/saml-conformance/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/codice/saml-conformance/pulls/206/commits"},"statuses":{"href":"https://api.github.com/repos/codice/saml-conformance/statuses/f1ba613af7650e047837dd53a7d4a2bc18c31283"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"bakejeyner"}}