{"action":"created","issue":{"url":"https://api.github.com/repos/brave/browser-laptop/issues/13294","repository_url":"https://api.github.com/repos/brave/browser-laptop","labels_url":"https://api.github.com/repos/brave/browser-laptop/issues/13294/labels{/name}","comments_url":"https://api.github.com/repos/brave/browser-laptop/issues/13294/comments","events_url":"https://api.github.com/repos/brave/browser-laptop/issues/13294/events","html_url":"https://github.com/brave/browser-laptop/pull/13294","id":299940059,"number":13294,"title":"Fixes big list overflow","user":{"login":"NejcZdovc","id":9574457,"avatar_url":"https://avatars1.githubusercontent.com/u/9574457?v=4","gravatar_id":"","url":"https://api.github.com/users/NejcZdovc","html_url":"https://github.com/NejcZdovc","followers_url":"https://api.github.com/users/NejcZdovc/followers","following_url":"https://api.github.com/users/NejcZdovc/following{/other_user}","gists_url":"https://api.github.com/users/NejcZdovc/gists{/gist_id}","starred_url":"https://api.github.com/users/NejcZdovc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NejcZdovc/subscriptions","organizations_url":"https://api.github.com/users/NejcZdovc/orgs","repos_url":"https://api.github.com/users/NejcZdovc/repos","events_url":"https://api.github.com/users/NejcZdovc/events{/privacy}","received_events_url":"https://api.github.com/users/NejcZdovc/received_events","type":"User","site_admin":false},"labels":[{"id":408464251,"url":"https://api.github.com/repos/brave/browser-laptop/labels/feature/ledger","name":"feature/ledger","color":"ff5000","default":false}],"state":"closed","locked":false,"assignee":{"login":"NejcZdovc","id":9574457,"avatar_url":"https://avatars1.githubusercontent.com/u/9574457?v=4","gravatar_id":"","url":"https://api.github.com/users/NejcZdovc","html_url":"https://github.com/NejcZdovc","followers_url":"https://api.github.com/users/NejcZdovc/followers","following_url":"https://api.github.com/users/NejcZdovc/following{/other_user}","gists_url":"https://api.github.com/users/NejcZdovc/gists{/gist_id}","starred_url":"https://api.github.com/users/NejcZdovc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NejcZdovc/subscriptions","organizations_url":"https://api.github.com/users/NejcZdovc/orgs","repos_url":"https://api.github.com/users/NejcZdovc/repos","events_url":"https://api.github.com/users/NejcZdovc/events{/privacy}","received_events_url":"https://api.github.com/users/NejcZdovc/received_events","type":"User","site_admin":false},"assignees":[{"login":"NejcZdovc","id":9574457,"avatar_url":"https://avatars1.githubusercontent.com/u/9574457?v=4","gravatar_id":"","url":"https://api.github.com/users/NejcZdovc","html_url":"https://github.com/NejcZdovc","followers_url":"https://api.github.com/users/NejcZdovc/followers","following_url":"https://api.github.com/users/NejcZdovc/following{/other_user}","gists_url":"https://api.github.com/users/NejcZdovc/gists{/gist_id}","starred_url":"https://api.github.com/users/NejcZdovc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NejcZdovc/subscriptions","organizations_url":"https://api.github.com/users/NejcZdovc/orgs","repos_url":"https://api.github.com/users/NejcZdovc/repos","events_url":"https://api.github.com/users/NejcZdovc/events{/privacy}","received_events_url":"https://api.github.com/users/NejcZdovc/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/brave/browser-laptop/milestones/104","html_url":"https://github.com/brave/browser-laptop/milestone/104","labels_url":"https://api.github.com/repos/brave/browser-laptop/milestones/104/labels","id":3140646,"number":104,"title":"0.21.x (Beta Channel)","description":"Twitch","creator":{"login":"NejcZdovc","id":9574457,"avatar_url":"https://avatars1.githubusercontent.com/u/9574457?v=4","gravatar_id":"","url":"https://api.github.com/users/NejcZdovc","html_url":"https://github.com/NejcZdovc","followers_url":"https://api.github.com/users/NejcZdovc/followers","following_url":"https://api.github.com/users/NejcZdovc/following{/other_user}","gists_url":"https://api.github.com/users/NejcZdovc/gists{/gist_id}","starred_url":"https://api.github.com/users/NejcZdovc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NejcZdovc/subscriptions","organizations_url":"https://api.github.com/users/NejcZdovc/orgs","repos_url":"https://api.github.com/users/NejcZdovc/repos","events_url":"https://api.github.com/users/NejcZdovc/events{/privacy}","received_events_url":"https://api.github.com/users/NejcZdovc/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":40,"state":"open","created_at":"2018-02-24T09:34:53Z","updated_at":"2018-02-25T07:03:40Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2018-02-24T13:10:07Z","updated_at":"2018-02-25T07:15:44Z","closed_at":"2018-02-25T07:03:40Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/brave/browser-laptop/pulls/13294","html_url":"https://github.com/brave/browser-laptop/pull/13294","diff_url":"https://github.com/brave/browser-laptop/pull/13294.diff","patch_url":"https://github.com/brave/browser-laptop/pull/13294.patch"},"body":"Resolves #13284 \r\n\r\n## Submitter Checklist:\r\n\r\n- [x] Submitted a [ticket](https://github.com/brave/browser-laptop/issues) for my issue if one did not already exist.\r\n- [x] Used Github [auto-closing keywords](https://help.github.com/articles/closing-issues-via-commit-messages/) in the commit message.\r\n- [ ] Added/updated tests for this change (for new code or code which already has tests).\r\n- [x] Ran `git rebase -i` to squash commits (if needed).\r\n- [x] Tagged reviewers and labelled the pull request [as needed](https://github.com/brave/browser-laptop/wiki/Pull-request-process).\r\n- [ ] Request a security/privacy review [as needed](https://github.com/brave/handbook/blob/master/development/security.md#how-to-request-a-security-review). (Ask a Brave employee to help if you cannot access this document.)\r\n\r\n## Test Plan:\r\n\r\n1. enabled payments\r\n2. close browser\r\n3. run `npm run add-simulated-synopsis-visits`\r\n4. delete all publishers\r\n5. make sure that dialog is scrollable and nice\r\n\r\n## Reviewer Checklist:\r\n\r\n- [ ] Request a security/privacy review [as needed](https://github.com/brave/handbook/blob/master/development/security.md#how-to-request-a-security-review) if one was not already requested.\r\n\r\nTests\r\n\r\n\r\n- [ ] Adequate test coverage exists to prevent regressions\r\n- [ ] Tests should be independent and work correctly when run individually or as a suite [ref](https://github.com/brave/browser-laptop/wiki/Code-Guidelines#test-dependencies)\r\n- [ ] New files have MPL2 license header\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/brave/browser-laptop/issues/comments/368288929","html_url":"https://github.com/brave/browser-laptop/pull/13294#issuecomment-368288929","issue_url":"https://api.github.com/repos/brave/browser-laptop/issues/13294","id":368288929,"user":{"login":"bsclifton","id":4733304,"avatar_url":"https://avatars3.githubusercontent.com/u/4733304?v=4","gravatar_id":"","url":"https://api.github.com/users/bsclifton","html_url":"https://github.com/bsclifton","followers_url":"https://api.github.com/users/bsclifton/followers","following_url":"https://api.github.com/users/bsclifton/following{/other_user}","gists_url":"https://api.github.com/users/bsclifton/gists{/gist_id}","starred_url":"https://api.github.com/users/bsclifton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsclifton/subscriptions","organizations_url":"https://api.github.com/users/bsclifton/orgs","repos_url":"https://api.github.com/users/bsclifton/repos","events_url":"https://api.github.com/users/bsclifton/events{/privacy}","received_events_url":"https://api.github.com/users/bsclifton/received_events","type":"User","site_admin":false},"created_at":"2018-02-25T07:15:44Z","updated_at":"2018-02-25T07:15:44Z","author_association":"OWNER","body":"master 1ddda29675035b2d6e41330c8e6de08d29c7706d\r\n0.22.x 0dd876c7394014784c13c6cf9ff01dbb1d084519\r\n0.21.x d46ab3179062cb362e51117aef3196e82ed98139"}}
{"actor":{"display_login":"bsclifton"}}