{"action":"created","comment":{"url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/pulls/comments/223200799","pull_request_review_id":162277428,"id":223200799,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzIwMDc5OQ==","diff_hunk":"@@ -259,6 +261,30 @@ describe('reactA11yAnchorsRule', () : void => {\n         TestHelper.assertViolations(ruleName, script, [ ]);\n     });\n \n+    it('should pass when identical hrefs have texts with different cases on ignore-case enabled', () : void => {","path":"src/tests/ReactA11yAnchorsRuleTests.ts","position":12,"original_position":12,"commit_id":"988b9ee1819df086289480db80abee7e120014dd","original_commit_id":"988b9ee1819df086289480db80abee7e120014dd","user":{"login":"JoshuaKGoldberg","id":3335181,"node_id":"MDQ6VXNlcjMzMzUxODE=","avatar_url":"https://avatars1.githubusercontent.com/u/3335181?v=4","gravatar_id":"","url":"https://api.github.com/users/JoshuaKGoldberg","html_url":"https://github.com/JoshuaKGoldberg","followers_url":"https://api.github.com/users/JoshuaKGoldberg/followers","following_url":"https://api.github.com/users/JoshuaKGoldberg/following{/other_user}","gists_url":"https://api.github.com/users/JoshuaKGoldberg/gists{/gist_id}","starred_url":"https://api.github.com/users/JoshuaKGoldberg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JoshuaKGoldberg/subscriptions","organizations_url":"https://api.github.com/users/JoshuaKGoldberg/orgs","repos_url":"https://api.github.com/users/JoshuaKGoldberg/repos","events_url":"https://api.github.com/users/JoshuaKGoldberg/events{/privacy}","received_events_url":"https://api.github.com/users/JoshuaKGoldberg/received_events","type":"User","site_admin":false},"body":"Good unit tests for the case of the rules enabled! But: could you please also add equivalent tests for the same cases but with your new options not enabled? That way we still capture the case of the rule accidentally always enabling those options.","created_at":"2018-10-07T04:50:45Z","updated_at":"2018-10-07T04:56:04Z","html_url":"https://github.com/Microsoft/tslint-microsoft-contrib/pull/524#discussion_r223200799","pull_request_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/pulls/524","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/pulls/comments/223200799"},"html":{"href":"https://github.com/Microsoft/tslint-microsoft-contrib/pull/524#discussion_r223200799"},"pull_request":{"href":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/pulls/524"}}},"pull_request":{"url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/pulls/524","id":220907304,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwOTA3MzA0","html_url":"https://github.com/Microsoft/tslint-microsoft-contrib/pull/524","diff_url":"https://github.com/Microsoft/tslint-microsoft-contrib/pull/524.diff","patch_url":"https://github.com/Microsoft/tslint-microsoft-contrib/pull/524.patch","issue_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/issues/524","number":524,"state":"open","locked":false,"title":"Fix #394: Add ignore-case and ignore-whitespace options to react-a11y-anchors","user":{"login":"nadyafebi","id":19828938,"node_id":"MDQ6VXNlcjE5ODI4OTM4","avatar_url":"https://avatars1.githubusercontent.com/u/19828938?v=4","gravatar_id":"","url":"https://api.github.com/users/nadyafebi","html_url":"https://github.com/nadyafebi","followers_url":"https://api.github.com/users/nadyafebi/followers","following_url":"https://api.github.com/users/nadyafebi/following{/other_user}","gists_url":"https://api.github.com/users/nadyafebi/gists{/gist_id}","starred_url":"https://api.github.com/users/nadyafebi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nadyafebi/subscriptions","organizations_url":"https://api.github.com/users/nadyafebi/orgs","repos_url":"https://api.github.com/users/nadyafebi/repos","events_url":"https://api.github.com/users/nadyafebi/events{/privacy}","received_events_url":"https://api.github.com/users/nadyafebi/received_events","type":"User","site_admin":false},"body":"Fixes #394.\r\n\r\nAdded toggleable `ignore-case` and `ignore-whitespace` options to `react-a11y-anchors` rule.\r\n\r\nAlso added unit tests and documentation for these options.","created_at":"2018-10-06T19:43:24Z","updated_at":"2018-10-07T04:56:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"482747579511d905d150c666069bf26983997100","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/pulls/524/commits","review_comments_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/pulls/524/comments","review_comment_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/issues/524/comments","statuses_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/statuses/988b9ee1819df086289480db80abee7e120014dd","head":{"label":"nadyafebi:issue-394","ref":"issue-394","sha":"988b9ee1819df086289480db80abee7e120014dd","user":{"login":"nadyafebi","id":19828938,"node_id":"MDQ6VXNlcjE5ODI4OTM4","avatar_url":"https://avatars1.githubusercontent.com/u/19828938?v=4","gravatar_id":"","url":"https://api.github.com/users/nadyafebi","html_url":"https://github.com/nadyafebi","followers_url":"https://api.github.com/users/nadyafebi/followers","following_url":"https://api.github.com/users/nadyafebi/following{/other_user}","gists_url":"https://api.github.com/users/nadyafebi/gists{/gist_id}","starred_url":"https://api.github.com/users/nadyafebi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nadyafebi/subscriptions","organizations_url":"https://api.github.com/users/nadyafebi/orgs","repos_url":"https://api.github.com/users/nadyafebi/repos","events_url":"https://api.github.com/users/nadyafebi/events{/privacy}","received_events_url":"https://api.github.com/users/nadyafebi/received_events","type":"User","site_admin":false},"repo":{"id":151864918,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE4NjQ5MTg=","name":"tslint-microsoft-contrib","full_name":"nadyafebi/tslint-microsoft-contrib","private":false,"owner":{"login":"nadyafebi","id":19828938,"node_id":"MDQ6VXNlcjE5ODI4OTM4","avatar_url":"https://avatars1.githubusercontent.com/u/19828938?v=4","gravatar_id":"","url":"https://api.github.com/users/nadyafebi","html_url":"https://github.com/nadyafebi","followers_url":"https://api.github.com/users/nadyafebi/followers","following_url":"https://api.github.com/users/nadyafebi/following{/other_user}","gists_url":"https://api.github.com/users/nadyafebi/gists{/gist_id}","starred_url":"https://api.github.com/users/nadyafebi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nadyafebi/subscriptions","organizations_url":"https://api.github.com/users/nadyafebi/orgs","repos_url":"https://api.github.com/users/nadyafebi/repos","events_url":"https://api.github.com/users/nadyafebi/events{/privacy}","received_events_url":"https://api.github.com/users/nadyafebi/received_events","type":"User","site_admin":false},"html_url":"https://github.com/nadyafebi/tslint-microsoft-contrib","description":":writing_hand: Contributor | A set of TSLint rules used on some Microsoft projects.","fork":true,"url":"https://api.github.com/repos/nadyafebi/tslint-microsoft-contrib","forks_url":"https://api.github.com/repos/nadyafebi/tslint-microsoft-contrib/forks","keys_url":"https://api.github.com/repos/nadyafebi/tslint-microsoft-contrib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nadyafebi/tslint-microsoft-contrib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nadyafebi/tslint-microsoft-contrib/teams","hooks_url":"https://api.github.com/repos/nadyafebi/tslint-microsoft-contrib/hooks","issue_events_url":"https://api.github.com/repos/nadyafebi/tslint-microsoft-contrib/issues/events{/number}","events_url":"https://api.github.com/repos/nadyafebi/tslint-microsoft-contrib/events","assignees_url":"https://api.github.com/repos/nadyafebi/tslint-microsoft-contrib/assignees{/user}","branches_url":"https://api.github.com/repos/nadyafebi/tslint-microsoft-contrib/branches{/branch}","tags_url":"https://api.github.com/repos/nadyafebi/tslint-microsoft-contrib/tags","blobs_url":"https://api.github.com/repos/nadyafebi/tslint-microsoft-contrib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nadyafebi/tslint-microsoft-contrib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nadyafebi/tslint-microsoft-contrib/git/refs{/sha}","trees_url":"https://api.github.com/repos/nadyafebi/tslint-microsoft-contrib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nadyafebi/tslint-microsoft-contrib/statuses/{sha}","languages_url":"https://api.github.com/repos/nadyafebi/tslint-microsoft-contrib/languages","stargazers_url":"https://api.github.com/repos/nadyafebi/tslint-microsoft-contrib/stargazers","contributors_url":"https://api.github.com/repos/nadyafebi/tslint-microsoft-contrib/contributors","subscribers_url":"https://api.github.com/repos/nadyafebi/tslint-microsoft-contrib/subscribers","subscription_url":"https://api.github.com/repos/nadyafebi/tslint-microsoft-contrib/subscription","commits_url":"https://api.github.com/repos/nadyafebi/tslint-microsoft-contrib/commits{/sha}","git_commits_url":"https://api.github.com/repos/nadyafebi/tslint-microsoft-contrib/git/commits{/sha}","comments_url":"https://api.github.com/repos/nadyafebi/tslint-microsoft-contrib/comments{/number}","issue_comment_url":"https://api.github.com/repos/nadyafebi/tslint-microsoft-contrib/issues/comments{/number}","contents_url":"https://api.github.com/repos/nadyafebi/tslint-microsoft-contrib/contents/{+path}","compare_url":"https://api.github.com/repos/nadyafebi/tslint-microsoft-contrib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nadyafebi/tslint-microsoft-contrib/merges","archive_url":"https://api.github.com/repos/nadyafebi/tslint-microsoft-contrib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nadyafebi/tslint-microsoft-contrib/downloads","issues_url":"https://api.github.com/repos/nadyafebi/tslint-microsoft-contrib/issues{/number}","pulls_url":"https://api.github.com/repos/nadyafebi/tslint-microsoft-contrib/pulls{/number}","milestones_url":"https://api.github.com/repos/nadyafebi/tslint-microsoft-contrib/milestones{/number}","notifications_url":"https://api.github.com/repos/nadyafebi/tslint-microsoft-contrib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nadyafebi/tslint-microsoft-contrib/labels{/name}","releases_url":"https://api.github.com/repos/nadyafebi/tslint-microsoft-contrib/releases{/id}","deployments_url":"https://api.github.com/repos/nadyafebi/tslint-microsoft-contrib/deployments","created_at":"2018-10-06T17:33:09Z","updated_at":"2018-10-06T19:46:03Z","pushed_at":"2018-10-06T19:32:05Z","git_url":"git://github.com/nadyafebi/tslint-microsoft-contrib.git","ssh_url":"git@github.com:nadyafebi/tslint-microsoft-contrib.git","clone_url":"https://github.com/nadyafebi/tslint-microsoft-contrib.git","svn_url":"https://github.com/nadyafebi/tslint-microsoft-contrib","homepage":"","size":2365,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"0ca679b1f6c25d2a82862b8a3aa1441c62c8afec","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":41095157,"node_id":"MDEwOlJlcG9zaXRvcnk0MTA5NTE1Nw==","name":"tslint-microsoft-contrib","full_name":"Microsoft/tslint-microsoft-contrib","private":false,"owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Microsoft/tslint-microsoft-contrib","description":"A set of TSLint rules used on some Microsoft projects.","fork":false,"url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib","forks_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/forks","keys_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/teams","hooks_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/events","assignees_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/tags","blobs_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/languages","stargazers_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/subscription","commits_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/merges","archive_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/downloads","issues_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/deployments","created_at":"2015-08-20T12:44:29Z","updated_at":"2018-10-05T00:28:03Z","pushed_at":"2018-10-06T23:49:15Z","git_url":"git://github.com/Microsoft/tslint-microsoft-contrib.git","ssh_url":"git@github.com:Microsoft/tslint-microsoft-contrib.git","clone_url":"https://github.com/Microsoft/tslint-microsoft-contrib.git","svn_url":"https://github.com/Microsoft/tslint-microsoft-contrib","homepage":null,"size":2347,"stargazers_count":425,"watchers_count":425,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":135,"mirror_url":null,"archived":false,"open_issues_count":102,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":135,"open_issues":102,"watchers":425,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/pulls/524"},"html":{"href":"https://github.com/Microsoft/tslint-microsoft-contrib/pull/524"},"issue":{"href":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/issues/524"},"comments":{"href":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/issues/524/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/pulls/524/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/pulls/524/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/tslint-microsoft-contrib/statuses/988b9ee1819df086289480db80abee7e120014dd"}},"author_association":"NONE"}}
{"actor":{"display_login":"JoshuaKGoldberg"}}