{"action":"created","issue":{"url":"https://api.github.com/repos/weaveworks/flux/issues/1364","repository_url":"https://api.github.com/repos/weaveworks/flux","labels_url":"https://api.github.com/repos/weaveworks/flux/issues/1364/labels{/name}","comments_url":"https://api.github.com/repos/weaveworks/flux/issues/1364/comments","events_url":"https://api.github.com/repos/weaveworks/flux/issues/1364/events","html_url":"https://github.com/weaveworks/flux/pull/1364","id":360369187,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1NjQ0NzY0","number":1364,"title":"Don't create git secret if name is overridden","user":{"login":"mt-inside","id":1371795,"node_id":"MDQ6VXNlcjEzNzE3OTU=","avatar_url":"https://avatars1.githubusercontent.com/u/1371795?v=4","gravatar_id":"","url":"https://api.github.com/users/mt-inside","html_url":"https://github.com/mt-inside","followers_url":"https://api.github.com/users/mt-inside/followers","following_url":"https://api.github.com/users/mt-inside/following{/other_user}","gists_url":"https://api.github.com/users/mt-inside/gists{/gist_id}","starred_url":"https://api.github.com/users/mt-inside/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mt-inside/subscriptions","organizations_url":"https://api.github.com/users/mt-inside/orgs","repos_url":"https://api.github.com/users/mt-inside/repos","events_url":"https://api.github.com/users/mt-inside/events{/privacy}","received_events_url":"https://api.github.com/users/mt-inside/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-09-14T16:16:50Z","updated_at":"2018-10-16T13:47:00Z","closed_at":"2018-09-28T14:28:04Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/weaveworks/flux/pulls/1364","html_url":"https://github.com/weaveworks/flux/pull/1364","diff_url":"https://github.com/weaveworks/flux/pull/1364.diff","patch_url":"https://github.com/weaveworks/flux/pull/1364.patch"},"body":"I want to supply my own private keys for github access (I am creating them, uploading them to github, and to k8s all with terraform. This is completely automatic and avoids the manual process of: install flux; wait; copy out public key; upload to github).\r\n\r\nThe problem is that because the secret flux-git-deploy already exists, install of the whole chart fails. Automatic creation of this secret (which by dint of being empty causes flux to generate a keypair) should be optional.\r\n\r\nI've made it so\r\n\"The manifest operator now takes a secretName like the Helm operator\r\ndoes. If the secretName is specified (i.e. is non-default), the user is\r\nassumed to be bringing their own secret and none is created.\"\r\n\r\nOpen to opinions on this: avoiding creation of the key is now inferred from the use of any non-default name. Maybe this is too magic and we want a separate \"don't make the secret\" flag? Is there a use case for auto-generated keys being stored in custom-named secrets?"},"comment":{"url":"https://api.github.com/repos/weaveworks/flux/issues/comments/430243760","html_url":"https://github.com/weaveworks/flux/pull/1364#issuecomment-430243760","issue_url":"https://api.github.com/repos/weaveworks/flux/issues/1364","id":430243760,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMDI0Mzc2MA==","user":{"login":"mt-inside","id":1371795,"node_id":"MDQ6VXNlcjEzNzE3OTU=","avatar_url":"https://avatars1.githubusercontent.com/u/1371795?v=4","gravatar_id":"","url":"https://api.github.com/users/mt-inside","html_url":"https://github.com/mt-inside","followers_url":"https://api.github.com/users/mt-inside/followers","following_url":"https://api.github.com/users/mt-inside/following{/other_user}","gists_url":"https://api.github.com/users/mt-inside/gists{/gist_id}","starred_url":"https://api.github.com/users/mt-inside/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mt-inside/subscriptions","organizations_url":"https://api.github.com/users/mt-inside/orgs","repos_url":"https://api.github.com/users/mt-inside/repos","events_url":"https://api.github.com/users/mt-inside/events{/privacy}","received_events_url":"https://api.github.com/users/mt-inside/received_events","type":"User","site_admin":false},"created_at":"2018-10-16T13:47:00Z","updated_at":"2018-10-16T13:47:00Z","author_association":"CONTRIBUTOR","body":"Sorry I didn't get a chance to keep up with this. Thanks for the more comprehensive fix!"}}
{"actor":{"display_login":"mt-inside"}}