{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/comments/241935012","pull_request_review_id":185339101,"id":241935012,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTkzNTAxMg==","diff_hunk":"@@ -640,10 +640,12 @@ private static void TrySchedule(PipeScheduler scheduler, Action<object> action,\n             }\n         }\n \n+        [MethodImpl(MethodImplOptions.AggressiveInlining)]\n         private static void TrySchedule(PipeScheduler scheduler, in CompletionData completionData)\n         {\n+            Action<object> completion = completionData.Completion;\n             // Nothing to do\n-            if (completionData.Completion == null)\n+            if (completion is null)","path":"src/System.IO.Pipelines/src/System/IO/Pipelines/Pipe.cs","position":84,"original_position":26,"commit_id":"75205984fff23de8f87095739ebac2e3b791e01e","original_commit_id":"3474d3629dfa265438a2171b102061db526a134f","user":{"login":"benaadams","id":1142958,"node_id":"MDQ6VXNlcjExNDI5NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1142958?v=4","gravatar_id":"","url":"https://api.github.com/users/benaadams","html_url":"https://github.com/benaadams","followers_url":"https://api.github.com/users/benaadams/followers","following_url":"https://api.github.com/users/benaadams/following{/other_user}","gists_url":"https://api.github.com/users/benaadams/gists{/gist_id}","starred_url":"https://api.github.com/users/benaadams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benaadams/subscriptions","organizations_url":"https://api.github.com/users/benaadams/orgs","repos_url":"https://api.github.com/users/benaadams/repos","events_url":"https://api.github.com/users/benaadams/events{/privacy}","received_events_url":"https://api.github.com/users/benaadams/received_events","type":"User","site_admin":false},"body":"`MulticastDelegate.operator==` does inline now for the null and reference equals check https://github.com/dotnet/coreclr/pull/16431 but its still chunkier than just doing a `is` null or `ReferenceEquals` check (which don't call the virtual overload Equals methods)","created_at":"2018-12-15T02:36:22Z","updated_at":"2018-12-15T02:36:22Z","html_url":"https://github.com/dotnet/corefx/pull/34104#discussion_r241935012","pull_request_url":"https://api.github.com/repos/dotnet/corefx/pulls/34104","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments/241935012"},"html":{"href":"https://github.com/dotnet/corefx/pull/34104#discussion_r241935012"},"pull_request":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/34104"}},"in_reply_to_id":241916037},"pull_request":{"url":"https://api.github.com/repos/dotnet/corefx/pulls/34104","id":238857837,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4ODU3ODM3","html_url":"https://github.com/dotnet/corefx/pull/34104","diff_url":"https://github.com/dotnet/corefx/pull/34104.diff","patch_url":"https://github.com/dotnet/corefx/pull/34104.patch","issue_url":"https://api.github.com/repos/dotnet/corefx/issues/34104","number":34104,"state":"open","locked":false,"title":"Fast-path inline Pipe TrySchedule","user":{"login":"benaadams","id":1142958,"node_id":"MDQ6VXNlcjExNDI5NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1142958?v=4","gravatar_id":"","url":"https://api.github.com/users/benaadams","html_url":"https://github.com/benaadams","followers_url":"https://api.github.com/users/benaadams/followers","following_url":"https://api.github.com/users/benaadams/following{/other_user}","gists_url":"https://api.github.com/users/benaadams/gists{/gist_id}","starred_url":"https://api.github.com/users/benaadams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benaadams/subscriptions","organizations_url":"https://api.github.com/users/benaadams/orgs","repos_url":"https://api.github.com/users/benaadams/repos","events_url":"https://api.github.com/users/benaadams/events{/privacy}","received_events_url":"https://api.github.com/users/benaadams/received_events","type":"User","site_admin":false},"body":"Call count can be a multiple of x246 higher than doing further work:\r\n\r\n![image](https://user-images.githubusercontent.com/1142958/50032832-ec349080-ffed-11e8-85cb-91bb1a12a194.png)\r\n\r\n/cc @pakrym @davidfowl @ahsonkhan ","created_at":"2018-12-14T22:18:02Z","updated_at":"2018-12-15T02:36:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"cf0db5996b5c0319337baa8a64019f2ff75e5c4b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/corefx/pulls/34104/commits","review_comments_url":"https://api.github.com/repos/dotnet/corefx/pulls/34104/comments","review_comment_url":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/corefx/issues/34104/comments","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/75205984fff23de8f87095739ebac2e3b791e01e","head":{"label":"benaadams:pipelines-schedule","ref":"pipelines-schedule","sha":"75205984fff23de8f87095739ebac2e3b791e01e","user":{"login":"benaadams","id":1142958,"node_id":"MDQ6VXNlcjExNDI5NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1142958?v=4","gravatar_id":"","url":"https://api.github.com/users/benaadams","html_url":"https://github.com/benaadams","followers_url":"https://api.github.com/users/benaadams/followers","following_url":"https://api.github.com/users/benaadams/following{/other_user}","gists_url":"https://api.github.com/users/benaadams/gists{/gist_id}","starred_url":"https://api.github.com/users/benaadams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benaadams/subscriptions","organizations_url":"https://api.github.com/users/benaadams/orgs","repos_url":"https://api.github.com/users/benaadams/repos","events_url":"https://api.github.com/users/benaadams/events{/privacy}","received_events_url":"https://api.github.com/users/benaadams/received_events","type":"User","site_admin":false},"repo":{"id":42275218,"node_id":"MDEwOlJlcG9zaXRvcnk0MjI3NTIxOA==","name":"corefx","full_name":"benaadams/corefx","private":false,"owner":{"login":"benaadams","id":1142958,"node_id":"MDQ6VXNlcjExNDI5NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/1142958?v=4","gravatar_id":"","url":"https://api.github.com/users/benaadams","html_url":"https://github.com/benaadams","followers_url":"https://api.github.com/users/benaadams/followers","following_url":"https://api.github.com/users/benaadams/following{/other_user}","gists_url":"https://api.github.com/users/benaadams/gists{/gist_id}","starred_url":"https://api.github.com/users/benaadams/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benaadams/subscriptions","organizations_url":"https://api.github.com/users/benaadams/orgs","repos_url":"https://api.github.com/users/benaadams/repos","events_url":"https://api.github.com/users/benaadams/events{/privacy}","received_events_url":"https://api.github.com/users/benaadams/received_events","type":"User","site_admin":false},"html_url":"https://github.com/benaadams/corefx","description":"This repo contains the .NET Core foundational libraries, called CoreFX. It includes classes for collections, file systems, console, XML, async and many others.","fork":true,"url":"https://api.github.com/repos/benaadams/corefx","forks_url":"https://api.github.com/repos/benaadams/corefx/forks","keys_url":"https://api.github.com/repos/benaadams/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/benaadams/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/benaadams/corefx/teams","hooks_url":"https://api.github.com/repos/benaadams/corefx/hooks","issue_events_url":"https://api.github.com/repos/benaadams/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/benaadams/corefx/events","assignees_url":"https://api.github.com/repos/benaadams/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/benaadams/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/benaadams/corefx/tags","blobs_url":"https://api.github.com/repos/benaadams/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/benaadams/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/benaadams/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/benaadams/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/benaadams/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/benaadams/corefx/languages","stargazers_url":"https://api.github.com/repos/benaadams/corefx/stargazers","contributors_url":"https://api.github.com/repos/benaadams/corefx/contributors","subscribers_url":"https://api.github.com/repos/benaadams/corefx/subscribers","subscription_url":"https://api.github.com/repos/benaadams/corefx/subscription","commits_url":"https://api.github.com/repos/benaadams/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/benaadams/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/benaadams/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/benaadams/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/benaadams/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/benaadams/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/benaadams/corefx/merges","archive_url":"https://api.github.com/repos/benaadams/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/benaadams/corefx/downloads","issues_url":"https://api.github.com/repos/benaadams/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/benaadams/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/benaadams/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/benaadams/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/benaadams/corefx/labels{/name}","releases_url":"https://api.github.com/repos/benaadams/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/benaadams/corefx/deployments","created_at":"2015-09-10T23:01:41Z","updated_at":"2018-11-04T03:23:55Z","pushed_at":"2018-12-15T02:28:55Z","git_url":"git://github.com/benaadams/corefx.git","ssh_url":"git@github.com:benaadams/corefx.git","clone_url":"https://github.com/benaadams/corefx.git","svn_url":"https://github.com/benaadams/corefx","homepage":"http://dotnet.github.io/core/","size":187299,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"f70737841e9d38f33d053d81c36faf5298b4a689","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":26295345,"node_id":"MDEwOlJlcG9zaXRvcnkyNjI5NTM0NQ==","name":"corefx","full_name":"dotnet/corefx","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/corefx","description":"CoreFX is the foundational class libraries for .NET Core. It includes types for collections, file systems, console, JSON, XML, async and many others.","fork":false,"url":"https://api.github.com/repos/dotnet/corefx","forks_url":"https://api.github.com/repos/dotnet/corefx/forks","keys_url":"https://api.github.com/repos/dotnet/corefx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/corefx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/corefx/teams","hooks_url":"https://api.github.com/repos/dotnet/corefx/hooks","issue_events_url":"https://api.github.com/repos/dotnet/corefx/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/corefx/events","assignees_url":"https://api.github.com/repos/dotnet/corefx/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/corefx/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/corefx/tags","blobs_url":"https://api.github.com/repos/dotnet/corefx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/corefx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/corefx/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/corefx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/corefx/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/corefx/languages","stargazers_url":"https://api.github.com/repos/dotnet/corefx/stargazers","contributors_url":"https://api.github.com/repos/dotnet/corefx/contributors","subscribers_url":"https://api.github.com/repos/dotnet/corefx/subscribers","subscription_url":"https://api.github.com/repos/dotnet/corefx/subscription","commits_url":"https://api.github.com/repos/dotnet/corefx/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/corefx/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/corefx/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/corefx/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/corefx/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/corefx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/corefx/merges","archive_url":"https://api.github.com/repos/dotnet/corefx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/corefx/downloads","issues_url":"https://api.github.com/repos/dotnet/corefx/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/corefx/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/corefx/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/corefx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/corefx/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/corefx/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/corefx/deployments","created_at":"2014-11-06T23:42:48Z","updated_at":"2018-12-15T02:02:45Z","pushed_at":"2018-12-15T02:30:39Z","git_url":"git://github.com/dotnet/corefx.git","ssh_url":"git@github.com:dotnet/corefx.git","clone_url":"https://github.com/dotnet/corefx.git","svn_url":"https://github.com/dotnet/corefx","homepage":"https://docs.microsoft.com/dotnet/core/","size":194968,"stargazers_count":15353,"watchers_count":15353,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4574,"mirror_url":null,"archived":false,"open_issues_count":2737,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4574,"open_issues":2737,"watchers":15353,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/34104"},"html":{"href":"https://github.com/dotnet/corefx/pull/34104"},"issue":{"href":"https://api.github.com/repos/dotnet/corefx/issues/34104"},"comments":{"href":"https://api.github.com/repos/dotnet/corefx/issues/34104/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/34104/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/corefx/pulls/34104/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/corefx/statuses/75205984fff23de8f87095739ebac2e3b791e01e"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"benaadams"}}