{"action":"created","issue":{"url":"https://api.github.com/repos/godotengine/godot/issues/16987","repository_url":"https://api.github.com/repos/godotengine/godot","labels_url":"https://api.github.com/repos/godotengine/godot/issues/16987/labels{/name}","comments_url":"https://api.github.com/repos/godotengine/godot/issues/16987/comments","events_url":"https://api.github.com/repos/godotengine/godot/issues/16987/events","html_url":"https://github.com/godotengine/godot/pull/16987","id":299967206,"node_id":"MDExOlB1bGxSZXF1ZXN0MTcxMTk0MjQy","number":16987,"title":"Mono: Pending exceptions and cleanup","user":{"login":"neikeq","id":7718100,"node_id":"MDQ6VXNlcjc3MTgxMDA=","avatar_url":"https://avatars3.githubusercontent.com/u/7718100?v=4","gravatar_id":"","url":"https://api.github.com/users/neikeq","html_url":"https://github.com/neikeq","followers_url":"https://api.github.com/users/neikeq/followers","following_url":"https://api.github.com/users/neikeq/following{/other_user}","gists_url":"https://api.github.com/users/neikeq/gists{/gist_id}","starred_url":"https://api.github.com/users/neikeq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neikeq/subscriptions","organizations_url":"https://api.github.com/users/neikeq/orgs","repos_url":"https://api.github.com/users/neikeq/repos","events_url":"https://api.github.com/users/neikeq/events{/privacy}","received_events_url":"https://api.github.com/users/neikeq/received_events","type":"User","site_admin":false},"labels":[{"id":820006056,"node_id":"MDU6TGFiZWw4MjAwMDYwNTY=","url":"https://api.github.com/repos/godotengine/godot/labels/cherrypick","name":"cherrypick","color":"043a96","default":false},{"id":73330066,"node_id":"MDU6TGFiZWw3MzMzMDA2Ng==","url":"https://api.github.com/repos/godotengine/godot/labels/enhancement","name":"enhancement","color":"44bbff","default":true},{"id":709269775,"node_id":"MDU6TGFiZWw3MDkyNjk3NzU=","url":"https://api.github.com/repos/godotengine/godot/labels/topic:mono","name":"topic:mono","color":"ffdd44","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/godotengine/godot/milestones/7","html_url":"https://github.com/godotengine/godot/milestone/7","labels_url":"https://api.github.com/repos/godotengine/godot/milestones/7/labels","id":2529217,"node_id":"MDk6TWlsZXN0b25lMjUyOTIxNw==","number":7,"title":"3.1","description":"","creator":{"login":"akien-mga","id":4701338,"node_id":"MDQ6VXNlcjQ3MDEzMzg=","avatar_url":"https://avatars0.githubusercontent.com/u/4701338?v=4","gravatar_id":"","url":"https://api.github.com/users/akien-mga","html_url":"https://github.com/akien-mga","followers_url":"https://api.github.com/users/akien-mga/followers","following_url":"https://api.github.com/users/akien-mga/following{/other_user}","gists_url":"https://api.github.com/users/akien-mga/gists{/gist_id}","starred_url":"https://api.github.com/users/akien-mga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akien-mga/subscriptions","organizations_url":"https://api.github.com/users/akien-mga/orgs","repos_url":"https://api.github.com/users/akien-mga/repos","events_url":"https://api.github.com/users/akien-mga/events{/privacy}","received_events_url":"https://api.github.com/users/akien-mga/received_events","type":"User","site_admin":false},"open_issues":1074,"closed_issues":1971,"state":"open","created_at":"2017-05-18T13:33:56Z","updated_at":"2018-07-20T14:42:07Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2018-02-24T19:45:52Z","updated_at":"2018-07-20T14:57:52Z","closed_at":"2018-07-04T01:45:11Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/godotengine/godot/pulls/16987","html_url":"https://github.com/godotengine/godot/pull/16987","diff_url":"https://github.com/godotengine/godot/pull/16987.diff","patch_url":"https://github.com/godotengine/godot/pull/16987.patch"},"body":"Recently, the function `mono_runtime_set_pending_exception` was exposed to embedders. This allows Godot, which does not allow exceptions, to pass exceptions from native to managed code instead of treating them as unhandled exceptions.\r\n\r\n**Important:** This raises the minimum Mono version for compiling the module to 5.12.\r\n"},"comment":{"url":"https://api.github.com/repos/godotengine/godot/issues/comments/406626524","html_url":"https://github.com/godotengine/godot/pull/16987#issuecomment-406626524","issue_url":"https://api.github.com/repos/godotengine/godot/issues/16987","id":406626524,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNjYyNjUyNA==","user":{"login":"PJB3005","id":8107459,"node_id":"MDQ6VXNlcjgxMDc0NTk=","avatar_url":"https://avatars0.githubusercontent.com/u/8107459?v=4","gravatar_id":"","url":"https://api.github.com/users/PJB3005","html_url":"https://github.com/PJB3005","followers_url":"https://api.github.com/users/PJB3005/followers","following_url":"https://api.github.com/users/PJB3005/following{/other_user}","gists_url":"https://api.github.com/users/PJB3005/gists{/gist_id}","starred_url":"https://api.github.com/users/PJB3005/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PJB3005/subscriptions","organizations_url":"https://api.github.com/users/PJB3005/orgs","repos_url":"https://api.github.com/users/PJB3005/repos","events_url":"https://api.github.com/users/PJB3005/events{/privacy}","received_events_url":"https://api.github.com/users/PJB3005/received_events","type":"User","site_admin":false},"created_at":"2018-07-20T14:57:51Z","updated_at":"2018-07-20T14:57:51Z","author_association":"CONTRIBUTOR","body":"Throw an exception inside, say, _process and you've got yourself an\nuhandled one.\n\nOn Jul 20, 2018 16:48, \"Ignacio Etcheverry\" <notifications@github.com>\nwrote:\n\n@PJB3005 <https://github.com/PJB3005> How is every exception being treated\nas unhandled. Can you share an example?\n\nGD_MONO_BEGIN_RUNTIME_INVOKE must be placed right before some kind of\nmethod invoke (that includes property set/get and mono_object_to_string),\nand GD_MONO_END_RUNTIME_INVOKE right after it.\nThe counter has an initial value of 0. The former macro increments the\ncounter, the later decrements it. If the counter is higher than 0, it means\nthere is a managed method that could catch the exception.\n\n—\nYou are receiving this because you were mentioned.\nReply to this email directly, view it on GitHub\n<https://github.com/godotengine/godot/pull/16987#issuecomment-406623355>,\nor mute the thread\n<https://github.com/notifications/unsubscribe-auth/AHu1wwLadRnKXgtRS7pJiA_rj6BbOygdks5uIe2kgaJpZM4SSBI6>\n.\n"}}
{"actor":{"display_login":"PJB3005"}}