{"action":"created","comment":{"url":"https://api.github.com/repos/PegaSysEng/pantheon/pulls/comments/241291289","pull_request_review_id":184523355,"id":241291289,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTI5MTI4OQ==","diff_hunk":"@@ -487,41 +493,89 @@ public void callingWithRefreshDelayWithNegativeValueMustError() {\n   }\n \n   @Test\n-  public void callingWithNodesWhitelistOptionButNoValueMustNotError() {\n-    parseCommand(\"--nodes-whitelist\");\n+  public void callingWithInvalidNodesWhitelistMustDisplayErrorAndUsage() {\n+    parseCommand(\"--nodes-whitelist\", \"invalid_enode_url\");\n+    assertThat(commandOutput.toString()).isEmpty();\n+    /*\n+     Because of the way Picocli handles errors parsing errors for lists with arity 0..*, we don't\n+     get the nice error msg with that was wrong. It only shows to the user the values that weren't\n+     parsed correctly.\n+    */\n+    final String expectedErrorOutputStart = \"Unmatched argument: invalid_enode_url\";\n+    assertThat(commandErrorOutput.toString()).startsWith(expectedErrorOutputStart);\n+  }\n+\n+  @Test\n+  public void nodesWhitelistOptionMustBeUsed() {\n+    parseCommand(\n+        \"--nodes-whitelist\",\n+        String.join(\",\", validENodeStrings),\n+        \"--bootnodes\",\n+        validENodeStrings[0]);\n \n     verify(mockRunnerBuilder)\n         .permissioningConfiguration(permissioningConfigurationArgumentCaptor.capture());\n     verify(mockRunnerBuilder).build();\n \n-    assertThat(permissioningConfigurationArgumentCaptor.getValue().getNodeWhitelist()).isEmpty();\n+    assertThat(","path":"pantheon/src/test/java/tech/pegasys/pantheon/cli/PantheonCommandTest.java","position":70,"original_position":70,"commit_id":"f7785fd70752e2d3df0504ac0eb877348858e2b9","original_commit_id":"f7785fd70752e2d3df0504ac0eb877348858e2b9","user":{"login":"lucassaldanha","id":1766440,"node_id":"MDQ6VXNlcjE3NjY0NDA=","avatar_url":"https://avatars2.githubusercontent.com/u/1766440?v=4","gravatar_id":"","url":"https://api.github.com/users/lucassaldanha","html_url":"https://github.com/lucassaldanha","followers_url":"https://api.github.com/users/lucassaldanha/followers","following_url":"https://api.github.com/users/lucassaldanha/following{/other_user}","gists_url":"https://api.github.com/users/lucassaldanha/gists{/gist_id}","starred_url":"https://api.github.com/users/lucassaldanha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucassaldanha/subscriptions","organizations_url":"https://api.github.com/users/lucassaldanha/orgs","repos_url":"https://api.github.com/users/lucassaldanha/repos","events_url":"https://api.github.com/users/lucassaldanha/events{/privacy}","received_events_url":"https://api.github.com/users/lucassaldanha/received_events","type":"User","site_admin":false},"body":"I would create a List<String> enodeURLAsStringList (or something similar) variable and assign the stream-mapping -collect result to it.\r\nThis will make the assertion cleaner:\r\n`assertThat(enodeURLAsStringList).containsExactlyInAnyOrder(validENodeStrings);`","created_at":"2018-12-13T07:11:55Z","updated_at":"2018-12-13T07:15:44Z","html_url":"https://github.com/PegaSysEng/pantheon/pull/414#discussion_r241291289","pull_request_url":"https://api.github.com/repos/PegaSysEng/pantheon/pulls/414","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/PegaSysEng/pantheon/pulls/comments/241291289"},"html":{"href":"https://github.com/PegaSysEng/pantheon/pull/414#discussion_r241291289"},"pull_request":{"href":"https://api.github.com/repos/PegaSysEng/pantheon/pulls/414"}}},"pull_request":{"url":"https://api.github.com/repos/PegaSysEng/pantheon/pulls/414","id":238259698,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4MjU5Njk4","html_url":"https://github.com/PegaSysEng/pantheon/pull/414","diff_url":"https://github.com/PegaSysEng/pantheon/pull/414.diff","patch_url":"https://github.com/PegaSysEng/pantheon/pull/414.patch","issue_url":"https://api.github.com/repos/PegaSysEng/pantheon/issues/414","number":414,"state":"open","locked":false,"title":"NC-1930 ensure bootnodes are a subset of node whitelist","user":{"login":"macfarla","id":2627919,"node_id":"MDQ6VXNlcjI2Mjc5MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/2627919?v=4","gravatar_id":"","url":"https://api.github.com/users/macfarla","html_url":"https://github.com/macfarla","followers_url":"https://api.github.com/users/macfarla/followers","following_url":"https://api.github.com/users/macfarla/following{/other_user}","gists_url":"https://api.github.com/users/macfarla/gists{/gist_id}","starred_url":"https://api.github.com/users/macfarla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macfarla/subscriptions","organizations_url":"https://api.github.com/users/macfarla/orgs","repos_url":"https://api.github.com/users/macfarla/repos","events_url":"https://api.github.com/users/macfarla/events{/privacy}","received_events_url":"https://api.github.com/users/macfarla/received_events","type":"User","site_admin":false},"body":"## PR description\r\nEnsure all bootnodes are included in node-whitelist. This includes custom bootnodes specified with --bootnodes option, as well as pre-defined bootnodes eg those used by the --ropsten option.\r\n\r\n## Fixed Issue(s)\r\nNC-1966\r\n","created_at":"2018-12-13T04:14:37Z","updated_at":"2018-12-13T07:15:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4558affdd3b248ad65973c78cbff59b980becc08","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PegaSysEng/pantheon/pulls/414/commits","review_comments_url":"https://api.github.com/repos/PegaSysEng/pantheon/pulls/414/comments","review_comment_url":"https://api.github.com/repos/PegaSysEng/pantheon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PegaSysEng/pantheon/issues/414/comments","statuses_url":"https://api.github.com/repos/PegaSysEng/pantheon/statuses/f7785fd70752e2d3df0504ac0eb877348858e2b9","head":{"label":"macfarla:NC-1930-ensure-bootnodes-subset-node-whitelist","ref":"NC-1930-ensure-bootnodes-subset-node-whitelist","sha":"f7785fd70752e2d3df0504ac0eb877348858e2b9","user":{"login":"macfarla","id":2627919,"node_id":"MDQ6VXNlcjI2Mjc5MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/2627919?v=4","gravatar_id":"","url":"https://api.github.com/users/macfarla","html_url":"https://github.com/macfarla","followers_url":"https://api.github.com/users/macfarla/followers","following_url":"https://api.github.com/users/macfarla/following{/other_user}","gists_url":"https://api.github.com/users/macfarla/gists{/gist_id}","starred_url":"https://api.github.com/users/macfarla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macfarla/subscriptions","organizations_url":"https://api.github.com/users/macfarla/orgs","repos_url":"https://api.github.com/users/macfarla/repos","events_url":"https://api.github.com/users/macfarla/events{/privacy}","received_events_url":"https://api.github.com/users/macfarla/received_events","type":"User","site_admin":false},"repo":{"id":154775478,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ3NzU0Nzg=","name":"pantheon","full_name":"macfarla/pantheon","private":false,"owner":{"login":"macfarla","id":2627919,"node_id":"MDQ6VXNlcjI2Mjc5MTk=","avatar_url":"https://avatars1.githubusercontent.com/u/2627919?v=4","gravatar_id":"","url":"https://api.github.com/users/macfarla","html_url":"https://github.com/macfarla","followers_url":"https://api.github.com/users/macfarla/followers","following_url":"https://api.github.com/users/macfarla/following{/other_user}","gists_url":"https://api.github.com/users/macfarla/gists{/gist_id}","starred_url":"https://api.github.com/users/macfarla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macfarla/subscriptions","organizations_url":"https://api.github.com/users/macfarla/orgs","repos_url":"https://api.github.com/users/macfarla/repos","events_url":"https://api.github.com/users/macfarla/events{/privacy}","received_events_url":"https://api.github.com/users/macfarla/received_events","type":"User","site_admin":false},"html_url":"https://github.com/macfarla/pantheon","description":"PegaSys' Enterprise Blockchain Client","fork":true,"url":"https://api.github.com/repos/macfarla/pantheon","forks_url":"https://api.github.com/repos/macfarla/pantheon/forks","keys_url":"https://api.github.com/repos/macfarla/pantheon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/macfarla/pantheon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/macfarla/pantheon/teams","hooks_url":"https://api.github.com/repos/macfarla/pantheon/hooks","issue_events_url":"https://api.github.com/repos/macfarla/pantheon/issues/events{/number}","events_url":"https://api.github.com/repos/macfarla/pantheon/events","assignees_url":"https://api.github.com/repos/macfarla/pantheon/assignees{/user}","branches_url":"https://api.github.com/repos/macfarla/pantheon/branches{/branch}","tags_url":"https://api.github.com/repos/macfarla/pantheon/tags","blobs_url":"https://api.github.com/repos/macfarla/pantheon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/macfarla/pantheon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/macfarla/pantheon/git/refs{/sha}","trees_url":"https://api.github.com/repos/macfarla/pantheon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/macfarla/pantheon/statuses/{sha}","languages_url":"https://api.github.com/repos/macfarla/pantheon/languages","stargazers_url":"https://api.github.com/repos/macfarla/pantheon/stargazers","contributors_url":"https://api.github.com/repos/macfarla/pantheon/contributors","subscribers_url":"https://api.github.com/repos/macfarla/pantheon/subscribers","subscription_url":"https://api.github.com/repos/macfarla/pantheon/subscription","commits_url":"https://api.github.com/repos/macfarla/pantheon/commits{/sha}","git_commits_url":"https://api.github.com/repos/macfarla/pantheon/git/commits{/sha}","comments_url":"https://api.github.com/repos/macfarla/pantheon/comments{/number}","issue_comment_url":"https://api.github.com/repos/macfarla/pantheon/issues/comments{/number}","contents_url":"https://api.github.com/repos/macfarla/pantheon/contents/{+path}","compare_url":"https://api.github.com/repos/macfarla/pantheon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/macfarla/pantheon/merges","archive_url":"https://api.github.com/repos/macfarla/pantheon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/macfarla/pantheon/downloads","issues_url":"https://api.github.com/repos/macfarla/pantheon/issues{/number}","pulls_url":"https://api.github.com/repos/macfarla/pantheon/pulls{/number}","milestones_url":"https://api.github.com/repos/macfarla/pantheon/milestones{/number}","notifications_url":"https://api.github.com/repos/macfarla/pantheon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/macfarla/pantheon/labels{/name}","releases_url":"https://api.github.com/repos/macfarla/pantheon/releases{/id}","deployments_url":"https://api.github.com/repos/macfarla/pantheon/deployments","created_at":"2018-10-26T04:03:58Z","updated_at":"2018-12-13T03:05:28Z","pushed_at":"2018-12-13T04:15:10Z","git_url":"git://github.com/macfarla/pantheon.git","ssh_url":"git@github.com:macfarla/pantheon.git","clone_url":"https://github.com/macfarla/pantheon.git","svn_url":"https://github.com/macfarla/pantheon","homepage":"","size":7453,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PegaSysEng:master","ref":"master","sha":"6e6893c99da7bf22fc768977a6e2b9097132f5a8","user":{"login":"PegaSysEng","id":41842516,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxODQyNTE2","avatar_url":"https://avatars0.githubusercontent.com/u/41842516?v=4","gravatar_id":"","url":"https://api.github.com/users/PegaSysEng","html_url":"https://github.com/PegaSysEng","followers_url":"https://api.github.com/users/PegaSysEng/followers","following_url":"https://api.github.com/users/PegaSysEng/following{/other_user}","gists_url":"https://api.github.com/users/PegaSysEng/gists{/gist_id}","starred_url":"https://api.github.com/users/PegaSysEng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PegaSysEng/subscriptions","organizations_url":"https://api.github.com/users/PegaSysEng/orgs","repos_url":"https://api.github.com/users/PegaSysEng/repos","events_url":"https://api.github.com/users/PegaSysEng/events{/privacy}","received_events_url":"https://api.github.com/users/PegaSysEng/received_events","type":"Organization","site_admin":false},"repo":{"id":152270344,"node_id":"MDEwOlJlcG9zaXRvcnkxNTIyNzAzNDQ=","name":"pantheon","full_name":"PegaSysEng/pantheon","private":false,"owner":{"login":"PegaSysEng","id":41842516,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxODQyNTE2","avatar_url":"https://avatars0.githubusercontent.com/u/41842516?v=4","gravatar_id":"","url":"https://api.github.com/users/PegaSysEng","html_url":"https://github.com/PegaSysEng","followers_url":"https://api.github.com/users/PegaSysEng/followers","following_url":"https://api.github.com/users/PegaSysEng/following{/other_user}","gists_url":"https://api.github.com/users/PegaSysEng/gists{/gist_id}","starred_url":"https://api.github.com/users/PegaSysEng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PegaSysEng/subscriptions","organizations_url":"https://api.github.com/users/PegaSysEng/orgs","repos_url":"https://api.github.com/users/PegaSysEng/repos","events_url":"https://api.github.com/users/PegaSysEng/events{/privacy}","received_events_url":"https://api.github.com/users/PegaSysEng/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PegaSysEng/pantheon","description":"An enterprise-grade Java-based, Apache 2.0 licensed Ethereum client","fork":false,"url":"https://api.github.com/repos/PegaSysEng/pantheon","forks_url":"https://api.github.com/repos/PegaSysEng/pantheon/forks","keys_url":"https://api.github.com/repos/PegaSysEng/pantheon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PegaSysEng/pantheon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PegaSysEng/pantheon/teams","hooks_url":"https://api.github.com/repos/PegaSysEng/pantheon/hooks","issue_events_url":"https://api.github.com/repos/PegaSysEng/pantheon/issues/events{/number}","events_url":"https://api.github.com/repos/PegaSysEng/pantheon/events","assignees_url":"https://api.github.com/repos/PegaSysEng/pantheon/assignees{/user}","branches_url":"https://api.github.com/repos/PegaSysEng/pantheon/branches{/branch}","tags_url":"https://api.github.com/repos/PegaSysEng/pantheon/tags","blobs_url":"https://api.github.com/repos/PegaSysEng/pantheon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PegaSysEng/pantheon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PegaSysEng/pantheon/git/refs{/sha}","trees_url":"https://api.github.com/repos/PegaSysEng/pantheon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PegaSysEng/pantheon/statuses/{sha}","languages_url":"https://api.github.com/repos/PegaSysEng/pantheon/languages","stargazers_url":"https://api.github.com/repos/PegaSysEng/pantheon/stargazers","contributors_url":"https://api.github.com/repos/PegaSysEng/pantheon/contributors","subscribers_url":"https://api.github.com/repos/PegaSysEng/pantheon/subscribers","subscription_url":"https://api.github.com/repos/PegaSysEng/pantheon/subscription","commits_url":"https://api.github.com/repos/PegaSysEng/pantheon/commits{/sha}","git_commits_url":"https://api.github.com/repos/PegaSysEng/pantheon/git/commits{/sha}","comments_url":"https://api.github.com/repos/PegaSysEng/pantheon/comments{/number}","issue_comment_url":"https://api.github.com/repos/PegaSysEng/pantheon/issues/comments{/number}","contents_url":"https://api.github.com/repos/PegaSysEng/pantheon/contents/{+path}","compare_url":"https://api.github.com/repos/PegaSysEng/pantheon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PegaSysEng/pantheon/merges","archive_url":"https://api.github.com/repos/PegaSysEng/pantheon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PegaSysEng/pantheon/downloads","issues_url":"https://api.github.com/repos/PegaSysEng/pantheon/issues{/number}","pulls_url":"https://api.github.com/repos/PegaSysEng/pantheon/pulls{/number}","milestones_url":"https://api.github.com/repos/PegaSysEng/pantheon/milestones{/number}","notifications_url":"https://api.github.com/repos/PegaSysEng/pantheon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PegaSysEng/pantheon/labels{/name}","releases_url":"https://api.github.com/repos/PegaSysEng/pantheon/releases{/id}","deployments_url":"https://api.github.com/repos/PegaSysEng/pantheon/deployments","created_at":"2018-10-09T14:54:59Z","updated_at":"2018-12-13T03:06:58Z","pushed_at":"2018-12-13T05:45:50Z","git_url":"git://github.com/PegaSysEng/pantheon.git","ssh_url":"git@github.com:PegaSysEng/pantheon.git","clone_url":"https://github.com/PegaSysEng/pantheon.git","svn_url":"https://github.com/PegaSysEng/pantheon","homepage":"","size":7433,"stargazers_count":194,"watchers_count":194,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"archived":false,"open_issues_count":45,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":43,"open_issues":45,"watchers":194,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PegaSysEng/pantheon/pulls/414"},"html":{"href":"https://github.com/PegaSysEng/pantheon/pull/414"},"issue":{"href":"https://api.github.com/repos/PegaSysEng/pantheon/issues/414"},"comments":{"href":"https://api.github.com/repos/PegaSysEng/pantheon/issues/414/comments"},"review_comments":{"href":"https://api.github.com/repos/PegaSysEng/pantheon/pulls/414/comments"},"review_comment":{"href":"https://api.github.com/repos/PegaSysEng/pantheon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PegaSysEng/pantheon/pulls/414/commits"},"statuses":{"href":"https://api.github.com/repos/PegaSysEng/pantheon/statuses/f7785fd70752e2d3df0504ac0eb877348858e2b9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lucassaldanha"}}