{"action":"created","comment":{"url":"https://api.github.com/repos/Wikia/design-system/pulls/comments/203956357","pull_request_review_id":138950269,"id":203956357,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMzk1NjM1Nw==","diff_hunk":"@@ -80,12 +80,16 @@ export default Service.extend({\n \t\tthis.get('model').markAllAsRead();\n \t},\n \n-\tmarkAsRead(notification) {\n-\t\tthis.get('model').markAsRead(notification);\n+\tmarkAsRead(notification, willUnloadPage = false) {\n+\t\treturn this.get('model').markAsRead(notification, willUnloadPage);\n \t},\n \n \tgetUnreadCount() {\n \t\treturn this.get('model.unreadCount');\n-\t}\n+\t},\n \n+\tgoToDestination(notification) {\n+\t\t// TODO check if it's a local url and use transitionTo or delegate to app","path":"app/services/wds-on-site-notifications.js","position":16,"original_position":16,"commit_id":"f240f3f5be693123d75ad07a61f7c546c2568dee","original_commit_id":"f240f3f5be693123d75ad07a61f7c546c2568dee","user":{"login":"rybmat","id":1534495,"node_id":"MDQ6VXNlcjE1MzQ0OTU=","avatar_url":"https://avatars3.githubusercontent.com/u/1534495?v=4","gravatar_id":"","url":"https://api.github.com/users/rybmat","html_url":"https://github.com/rybmat","followers_url":"https://api.github.com/users/rybmat/followers","following_url":"https://api.github.com/users/rybmat/following{/other_user}","gists_url":"https://api.github.com/users/rybmat/gists{/gist_id}","starred_url":"https://api.github.com/users/rybmat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rybmat/subscriptions","organizations_url":"https://api.github.com/users/rybmat/orgs","repos_url":"https://api.github.com/users/rybmat/repos","events_url":"https://api.github.com/users/rybmat/events{/privacy}","received_events_url":"https://api.github.com/users/rybmat/received_events","type":"User","site_admin":false},"body":"what about this TODO?","created_at":"2018-07-20T07:16:38Z","updated_at":"2018-07-20T07:16:58Z","html_url":"https://github.com/Wikia/design-system/pull/253#discussion_r203956357","pull_request_url":"https://api.github.com/repos/Wikia/design-system/pulls/253","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/Wikia/design-system/pulls/comments/203956357"},"html":{"href":"https://github.com/Wikia/design-system/pull/253#discussion_r203956357"},"pull_request":{"href":"https://api.github.com/repos/Wikia/design-system/pulls/253"}}},"pull_request":{"url":"https://api.github.com/repos/Wikia/design-system/pulls/253","id":202597546,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyNTk3NTQ2","html_url":"https://github.com/Wikia/design-system/pull/253","diff_url":"https://github.com/Wikia/design-system/pull/253.diff","patch_url":"https://github.com/Wikia/design-system/pull/253.patch","issue_url":"https://api.github.com/repos/Wikia/design-system/issues/253","number":253,"state":"open","locked":false,"title":"IRIS-6405 | Use sendBeacon to mark notification as read on page unload","user":{"login":"rogatty","id":7030884,"node_id":"MDQ6VXNlcjcwMzA4ODQ=","avatar_url":"https://avatars3.githubusercontent.com/u/7030884?v=4","gravatar_id":"","url":"https://api.github.com/users/rogatty","html_url":"https://github.com/rogatty","followers_url":"https://api.github.com/users/rogatty/followers","following_url":"https://api.github.com/users/rogatty/following{/other_user}","gists_url":"https://api.github.com/users/rogatty/gists{/gist_id}","starred_url":"https://api.github.com/users/rogatty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rogatty/subscriptions","organizations_url":"https://api.github.com/users/rogatty/orgs","repos_url":"https://api.github.com/users/rogatty/repos","events_url":"https://api.github.com/users/rogatty/events{/privacy}","received_events_url":"https://api.github.com/users/rogatty/received_events","type":"User","site_admin":false},"body":"https://wikia-inc.atlassian.net/browse/IRIS-6405\r\nhttps://github.com/Wikia/app/pull/15736\r\n\r\n@Wikia/iris ","created_at":"2018-07-19T15:24:38Z","updated_at":"2018-07-20T07:16:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bca87afdd1503717550b9dd531a890751b60383f","assignee":null,"assignees":[],"requested_reviewers":[{"login":"hakubo","id":1018759,"node_id":"MDQ6VXNlcjEwMTg3NTk=","avatar_url":"https://avatars1.githubusercontent.com/u/1018759?v=4","gravatar_id":"","url":"https://api.github.com/users/hakubo","html_url":"https://github.com/hakubo","followers_url":"https://api.github.com/users/hakubo/followers","following_url":"https://api.github.com/users/hakubo/following{/other_user}","gists_url":"https://api.github.com/users/hakubo/gists{/gist_id}","starred_url":"https://api.github.com/users/hakubo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hakubo/subscriptions","organizations_url":"https://api.github.com/users/hakubo/orgs","repos_url":"https://api.github.com/users/hakubo/repos","events_url":"https://api.github.com/users/hakubo/events{/privacy}","received_events_url":"https://api.github.com/users/hakubo/received_events","type":"User","site_admin":false},{"login":"xkxd","id":6940495,"node_id":"MDQ6VXNlcjY5NDA0OTU=","avatar_url":"https://avatars1.githubusercontent.com/u/6940495?v=4","gravatar_id":"","url":"https://api.github.com/users/xkxd","html_url":"https://github.com/xkxd","followers_url":"https://api.github.com/users/xkxd/followers","following_url":"https://api.github.com/users/xkxd/following{/other_user}","gists_url":"https://api.github.com/users/xkxd/gists{/gist_id}","starred_url":"https://api.github.com/users/xkxd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xkxd/subscriptions","organizations_url":"https://api.github.com/users/xkxd/orgs","repos_url":"https://api.github.com/users/xkxd/repos","events_url":"https://api.github.com/users/xkxd/events{/privacy}","received_events_url":"https://api.github.com/users/xkxd/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Wikia/design-system/pulls/253/commits","review_comments_url":"https://api.github.com/repos/Wikia/design-system/pulls/253/comments","review_comment_url":"https://api.github.com/repos/Wikia/design-system/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Wikia/design-system/issues/253/comments","statuses_url":"https://api.github.com/repos/Wikia/design-system/statuses/f240f3f5be693123d75ad07a61f7c546c2568dee","head":{"label":"Wikia:IRIS-6405","ref":"IRIS-6405","sha":"f240f3f5be693123d75ad07a61f7c546c2568dee","user":{"login":"Wikia","id":1171011,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzEwMTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1171011?v=4","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":60171247,"node_id":"MDEwOlJlcG9zaXRvcnk2MDE3MTI0Nw==","name":"design-system","full_name":"Wikia/design-system","owner":{"login":"Wikia","id":1171011,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzEwMTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1171011?v=4","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/design-system","description":"Design System for Wikia","fork":false,"url":"https://api.github.com/repos/Wikia/design-system","forks_url":"https://api.github.com/repos/Wikia/design-system/forks","keys_url":"https://api.github.com/repos/Wikia/design-system/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/design-system/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/design-system/teams","hooks_url":"https://api.github.com/repos/Wikia/design-system/hooks","issue_events_url":"https://api.github.com/repos/Wikia/design-system/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/design-system/events","assignees_url":"https://api.github.com/repos/Wikia/design-system/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/design-system/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/design-system/tags","blobs_url":"https://api.github.com/repos/Wikia/design-system/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/design-system/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/design-system/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/design-system/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/design-system/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/design-system/languages","stargazers_url":"https://api.github.com/repos/Wikia/design-system/stargazers","contributors_url":"https://api.github.com/repos/Wikia/design-system/contributors","subscribers_url":"https://api.github.com/repos/Wikia/design-system/subscribers","subscription_url":"https://api.github.com/repos/Wikia/design-system/subscription","commits_url":"https://api.github.com/repos/Wikia/design-system/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/design-system/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/design-system/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/design-system/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/design-system/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/design-system/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/design-system/merges","archive_url":"https://api.github.com/repos/Wikia/design-system/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/design-system/downloads","issues_url":"https://api.github.com/repos/Wikia/design-system/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/design-system/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/design-system/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/design-system/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/design-system/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/design-system/releases{/id}","deployments_url":"https://api.github.com/repos/Wikia/design-system/deployments","created_at":"2016-06-01T11:30:53Z","updated_at":"2018-07-20T06:28:11Z","pushed_at":"2018-07-20T06:28:09Z","git_url":"git://github.com/Wikia/design-system.git","ssh_url":"git@github.com:Wikia/design-system.git","clone_url":"https://github.com/Wikia/design-system.git","svn_url":"https://github.com/Wikia/design-system","homepage":"","size":24788,"stargazers_count":6,"watchers_count":6,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":8,"open_issues":5,"watchers":6,"default_branch":"master"}},"base":{"label":"Wikia:master","ref":"master","sha":"8548a5acc05f2525c3fdaabda94cee91a1e89ec6","user":{"login":"Wikia","id":1171011,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzEwMTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1171011?v=4","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"repo":{"id":60171247,"node_id":"MDEwOlJlcG9zaXRvcnk2MDE3MTI0Nw==","name":"design-system","full_name":"Wikia/design-system","owner":{"login":"Wikia","id":1171011,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzEwMTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1171011?v=4","gravatar_id":"","url":"https://api.github.com/users/Wikia","html_url":"https://github.com/Wikia","followers_url":"https://api.github.com/users/Wikia/followers","following_url":"https://api.github.com/users/Wikia/following{/other_user}","gists_url":"https://api.github.com/users/Wikia/gists{/gist_id}","starred_url":"https://api.github.com/users/Wikia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wikia/subscriptions","organizations_url":"https://api.github.com/users/Wikia/orgs","repos_url":"https://api.github.com/users/Wikia/repos","events_url":"https://api.github.com/users/Wikia/events{/privacy}","received_events_url":"https://api.github.com/users/Wikia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Wikia/design-system","description":"Design System for Wikia","fork":false,"url":"https://api.github.com/repos/Wikia/design-system","forks_url":"https://api.github.com/repos/Wikia/design-system/forks","keys_url":"https://api.github.com/repos/Wikia/design-system/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wikia/design-system/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wikia/design-system/teams","hooks_url":"https://api.github.com/repos/Wikia/design-system/hooks","issue_events_url":"https://api.github.com/repos/Wikia/design-system/issues/events{/number}","events_url":"https://api.github.com/repos/Wikia/design-system/events","assignees_url":"https://api.github.com/repos/Wikia/design-system/assignees{/user}","branches_url":"https://api.github.com/repos/Wikia/design-system/branches{/branch}","tags_url":"https://api.github.com/repos/Wikia/design-system/tags","blobs_url":"https://api.github.com/repos/Wikia/design-system/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wikia/design-system/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wikia/design-system/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wikia/design-system/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wikia/design-system/statuses/{sha}","languages_url":"https://api.github.com/repos/Wikia/design-system/languages","stargazers_url":"https://api.github.com/repos/Wikia/design-system/stargazers","contributors_url":"https://api.github.com/repos/Wikia/design-system/contributors","subscribers_url":"https://api.github.com/repos/Wikia/design-system/subscribers","subscription_url":"https://api.github.com/repos/Wikia/design-system/subscription","commits_url":"https://api.github.com/repos/Wikia/design-system/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wikia/design-system/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wikia/design-system/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wikia/design-system/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wikia/design-system/contents/{+path}","compare_url":"https://api.github.com/repos/Wikia/design-system/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wikia/design-system/merges","archive_url":"https://api.github.com/repos/Wikia/design-system/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wikia/design-system/downloads","issues_url":"https://api.github.com/repos/Wikia/design-system/issues{/number}","pulls_url":"https://api.github.com/repos/Wikia/design-system/pulls{/number}","milestones_url":"https://api.github.com/repos/Wikia/design-system/milestones{/number}","notifications_url":"https://api.github.com/repos/Wikia/design-system/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wikia/design-system/labels{/name}","releases_url":"https://api.github.com/repos/Wikia/design-system/releases{/id}","deployments_url":"https://api.github.com/repos/Wikia/design-system/deployments","created_at":"2016-06-01T11:30:53Z","updated_at":"2018-07-20T06:28:11Z","pushed_at":"2018-07-20T06:28:09Z","git_url":"git://github.com/Wikia/design-system.git","ssh_url":"git@github.com:Wikia/design-system.git","clone_url":"https://github.com/Wikia/design-system.git","svn_url":"https://github.com/Wikia/design-system","homepage":"","size":24788,"stargazers_count":6,"watchers_count":6,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":8,"open_issues":5,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Wikia/design-system/pulls/253"},"html":{"href":"https://github.com/Wikia/design-system/pull/253"},"issue":{"href":"https://api.github.com/repos/Wikia/design-system/issues/253"},"comments":{"href":"https://api.github.com/repos/Wikia/design-system/issues/253/comments"},"review_comments":{"href":"https://api.github.com/repos/Wikia/design-system/pulls/253/comments"},"review_comment":{"href":"https://api.github.com/repos/Wikia/design-system/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Wikia/design-system/pulls/253/commits"},"statuses":{"href":"https://api.github.com/repos/Wikia/design-system/statuses/f240f3f5be693123d75ad07a61f7c546c2568dee"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rybmat"}}