{"action":"created","issue":{"url":"https://api.github.com/repos/eichstaedtPTB/PyDynamic/issues/18","repository_url":"https://api.github.com/repos/eichstaedtPTB/PyDynamic","labels_url":"https://api.github.com/repos/eichstaedtPTB/PyDynamic/issues/18/labels{/name}","comments_url":"https://api.github.com/repos/eichstaedtPTB/PyDynamic/issues/18/comments","events_url":"https://api.github.com/repos/eichstaedtPTB/PyDynamic/issues/18/events","html_url":"https://github.com/eichstaedtPTB/PyDynamic/issues/18","id":214306299,"node_id":"MDU6SXNzdWUyMTQzMDYyOTk=","number":18,"title":"Inconsistent function signature","user":{"login":"Ma-Weber","id":26428149,"node_id":"MDQ6VXNlcjI2NDI4MTQ5","avatar_url":"https://avatars2.githubusercontent.com/u/26428149?v=4","gravatar_id":"","url":"https://api.github.com/users/Ma-Weber","html_url":"https://github.com/Ma-Weber","followers_url":"https://api.github.com/users/Ma-Weber/followers","following_url":"https://api.github.com/users/Ma-Weber/following{/other_user}","gists_url":"https://api.github.com/users/Ma-Weber/gists{/gist_id}","starred_url":"https://api.github.com/users/Ma-Weber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ma-Weber/subscriptions","organizations_url":"https://api.github.com/users/Ma-Weber/orgs","repos_url":"https://api.github.com/users/Ma-Weber/repos","events_url":"https://api.github.com/users/Ma-Weber/events{/privacy}","received_events_url":"https://api.github.com/users/Ma-Weber/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"eichstaedtPTB","id":12184315,"node_id":"MDQ6VXNlcjEyMTg0MzE1","avatar_url":"https://avatars2.githubusercontent.com/u/12184315?v=4","gravatar_id":"","url":"https://api.github.com/users/eichstaedtPTB","html_url":"https://github.com/eichstaedtPTB","followers_url":"https://api.github.com/users/eichstaedtPTB/followers","following_url":"https://api.github.com/users/eichstaedtPTB/following{/other_user}","gists_url":"https://api.github.com/users/eichstaedtPTB/gists{/gist_id}","starred_url":"https://api.github.com/users/eichstaedtPTB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eichstaedtPTB/subscriptions","organizations_url":"https://api.github.com/users/eichstaedtPTB/orgs","repos_url":"https://api.github.com/users/eichstaedtPTB/repos","events_url":"https://api.github.com/users/eichstaedtPTB/events{/privacy}","received_events_url":"https://api.github.com/users/eichstaedtPTB/received_events","type":"User","site_admin":false},"assignees":[{"login":"eichstaedtPTB","id":12184315,"node_id":"MDQ6VXNlcjEyMTg0MzE1","avatar_url":"https://avatars2.githubusercontent.com/u/12184315?v=4","gravatar_id":"","url":"https://api.github.com/users/eichstaedtPTB","html_url":"https://github.com/eichstaedtPTB","followers_url":"https://api.github.com/users/eichstaedtPTB/followers","following_url":"https://api.github.com/users/eichstaedtPTB/following{/other_user}","gists_url":"https://api.github.com/users/eichstaedtPTB/gists{/gist_id}","starred_url":"https://api.github.com/users/eichstaedtPTB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eichstaedtPTB/subscriptions","organizations_url":"https://api.github.com/users/eichstaedtPTB/orgs","repos_url":"https://api.github.com/users/eichstaedtPTB/repos","events_url":"https://api.github.com/users/eichstaedtPTB/events{/privacy}","received_events_url":"https://api.github.com/users/eichstaedtPTB/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2017-03-15T07:40:03Z","updated_at":"2018-06-08T17:06:16Z","closed_at":"2018-06-08T17:06:16Z","author_association":"CONTRIBUTOR","body":"The following function definition in PyDynamic-1.2.61\\PyDynamic\\uncertainty\\propagate_DFT.py use slightly different orders of the parameters (Y,X,UY,UX vs. Y,UY,X,UX). This need special attention for the user and might be a pitfall when changing from multiplication to division.\r\n`def DFT_transferfunction(X, Y, UX, UY):`\r\n`def DFT_deconv(H, Y, UH, UY):`\r\n`def DFT_multiply(Y, UY, F, UF=None):`\r\nMaybe introduce an additional function `DFT_divide(Y, UY, X, UX)` for calculation of Y/X.\r\nAdditionaly, for me, the order of parameters “numerator followed by denominator” is more intuitive. In DFT_deconv and DFT_transferfunction the order is “denominator followed by numerator”.\r\n"},"comment":{"url":"https://api.github.com/repos/eichstaedtPTB/PyDynamic/issues/comments/395824907","html_url":"https://github.com/eichstaedtPTB/PyDynamic/issues/18#issuecomment-395824907","issue_url":"https://api.github.com/repos/eichstaedtPTB/PyDynamic/issues/18","id":395824907,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NTgyNDkwNw==","user":{"login":"eichstaedtPTB","id":12184315,"node_id":"MDQ6VXNlcjEyMTg0MzE1","avatar_url":"https://avatars2.githubusercontent.com/u/12184315?v=4","gravatar_id":"","url":"https://api.github.com/users/eichstaedtPTB","html_url":"https://github.com/eichstaedtPTB","followers_url":"https://api.github.com/users/eichstaedtPTB/followers","following_url":"https://api.github.com/users/eichstaedtPTB/following{/other_user}","gists_url":"https://api.github.com/users/eichstaedtPTB/gists{/gist_id}","starred_url":"https://api.github.com/users/eichstaedtPTB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eichstaedtPTB/subscriptions","organizations_url":"https://api.github.com/users/eichstaedtPTB/orgs","repos_url":"https://api.github.com/users/eichstaedtPTB/repos","events_url":"https://api.github.com/users/eichstaedtPTB/events{/privacy}","received_events_url":"https://api.github.com/users/eichstaedtPTB/received_events","type":"User","site_admin":false},"created_at":"2018-06-08T17:06:16Z","updated_at":"2018-06-08T17:06:16Z","author_association":"OWNER","body":"Solved with commit 909da53e8a42f1bcdb408f7d517e29f8703b8d7e"}}
{"actor":{"display_login":"eichstaedtPTB"}}