{"action":"created","issue":{"url":"https://api.github.com/repos/istio/istio/issues/5232","repository_url":"https://api.github.com/repos/istio/istio","labels_url":"https://api.github.com/repos/istio/istio/issues/5232/labels{/name}","comments_url":"https://api.github.com/repos/istio/istio/issues/5232/comments","events_url":"https://api.github.com/repos/istio/istio/issues/5232/events","html_url":"https://github.com/istio/istio/pull/5232","id":318201616,"number":5232,"title":"Set listeners h2 max streams to override nghttp2 client default of 100","user":{"login":"kyessenov","id":9537734,"avatar_url":"https://avatars2.githubusercontent.com/u/9537734?v=4","gravatar_id":"","url":"https://api.github.com/users/kyessenov","html_url":"https://github.com/kyessenov","followers_url":"https://api.github.com/users/kyessenov/followers","following_url":"https://api.github.com/users/kyessenov/following{/other_user}","gists_url":"https://api.github.com/users/kyessenov/gists{/gist_id}","starred_url":"https://api.github.com/users/kyessenov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kyessenov/subscriptions","organizations_url":"https://api.github.com/users/kyessenov/orgs","repos_url":"https://api.github.com/users/kyessenov/repos","events_url":"https://api.github.com/users/kyessenov/events{/privacy}","received_events_url":"https://api.github.com/users/kyessenov/received_events","type":"User","site_admin":false},"labels":[{"id":491318011,"url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-04-26T21:23:01Z","updated_at":"2018-04-26T22:43:32Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/5232","html_url":"https://github.com/istio/istio/pull/5232","diff_url":"https://github.com/istio/istio/pull/5232.diff","patch_url":"https://github.com/istio/istio/pull/5232.patch"},"body":"Reference issue: https://github.com/envoyproxy/envoy/issues/3076\r\nSigned-off-by: Kuat Yessenov <kuat@google.com>"},"comment":{"url":"https://api.github.com/repos/istio/istio/issues/comments/384811246","html_url":"https://github.com/istio/istio/pull/5232#issuecomment-384811246","issue_url":"https://api.github.com/repos/istio/istio/issues/5232","id":384811246,"user":{"login":"geeknoid","id":22780957,"avatar_url":"https://avatars3.githubusercontent.com/u/22780957?v=4","gravatar_id":"","url":"https://api.github.com/users/geeknoid","html_url":"https://github.com/geeknoid","followers_url":"https://api.github.com/users/geeknoid/followers","following_url":"https://api.github.com/users/geeknoid/following{/other_user}","gists_url":"https://api.github.com/users/geeknoid/gists{/gist_id}","starred_url":"https://api.github.com/users/geeknoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geeknoid/subscriptions","organizations_url":"https://api.github.com/users/geeknoid/orgs","repos_url":"https://api.github.com/users/geeknoid/repos","events_url":"https://api.github.com/users/geeknoid/events{/privacy}","received_events_url":"https://api.github.com/users/geeknoid/received_events","type":"User","site_admin":false},"created_at":"2018-04-26T22:43:32Z","updated_at":"2018-04-26T22:43:32Z","author_association":"CONTRIBUTOR","body":"But for the server's own self-preservation perspective, wouldn't it be\nsafer to specify something smaller?\n\nAs we discussed yesterday, servers shouldn't trust clients to do the right\nthing. So setting this number to infinity could let a client open an\ninfinite number of streams, which could kill the server. So maybe setting a\nlimit where (maxNumStreams*numBytesOfHeapNeededPerStream) is a reasonable\nnumber for our sidecars would be preferable?\n\n\nOn Thu, Apr 26, 2018 at 3:40 PM Kuat <notifications@github.com> wrote:\n\n> @geeknoid <https://github.com/geeknoid> We have a circuit breaker enabled\n> on the client-side envoy, which should prevent it reaching the limit. I\n> think it's set to 100,000 streams per client. The issue is\n> mis-understanding the omitted value. The server assumes the unset value is\n> infinity, which the client assumes it is 100. Making the server declare it\n> to be infinity avoids the misunderstanding.\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/istio/istio/pull/5232#issuecomment-384810595>, or mute\n> the thread\n> <https://github.com/notifications/unsubscribe-auth/AVucHez64XvF0ofgbmlwqRAlSzbFgFmQks5tskzNgaJpZM4Tn83y>\n> .\n>\n"}}
{"actor":{"display_login":"geeknoid"}}