{"action":"created","comment":{"url":"https://api.github.com/repos/helm/charts/pulls/comments/239890726","pull_request_review_id":182801657,"id":239890726,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTg5MDcyNg==","diff_hunk":"@@ -32,9 +32,11 @@ spec:\n     spec:\n       securityContext:\n {{ toYaml .Values.keycloak.securityContext | indent 8 }}\n-    {{- with .Values.keycloak.image.pullSecrets }}\n+    {{- if .Values.keycloak.image.pullSecrets }}","path":"stable/keycloak/templates/statefulset.yaml","position":5,"original_position":5,"commit_id":"1db673bf28ebca0618083ecf3e3d20bc70303670","original_commit_id":"1db673bf28ebca0618083ecf3e3d20bc70303670","user":{"login":"unguiculus","id":925412,"node_id":"MDQ6VXNlcjkyNTQxMg==","avatar_url":"https://avatars1.githubusercontent.com/u/925412?v=4","gravatar_id":"","url":"https://api.github.com/users/unguiculus","html_url":"https://github.com/unguiculus","followers_url":"https://api.github.com/users/unguiculus/followers","following_url":"https://api.github.com/users/unguiculus/following{/other_user}","gists_url":"https://api.github.com/users/unguiculus/gists{/gist_id}","starred_url":"https://api.github.com/users/unguiculus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unguiculus/subscriptions","organizations_url":"https://api.github.com/users/unguiculus/orgs","repos_url":"https://api.github.com/users/unguiculus/repos","events_url":"https://api.github.com/users/unguiculus/events{/privacy}","received_events_url":"https://api.github.com/users/unguiculus/received_events","type":"User","site_admin":false},"body":"From the top of my head, this should work:\r\n\r\n```yaml\r\n{{- with .Values.keycloak.image.pullSecrets }}\r\n  imagePullSecrets:\r\n  {{- range . }}\r\n    - name: {{ . }}\r\n  {{- end }}\r\n{{- end }}\r\n```\r\n","created_at":"2018-12-07T17:47:11Z","updated_at":"2018-12-07T17:47:11Z","html_url":"https://github.com/helm/charts/pull/9802#discussion_r239890726","pull_request_url":"https://api.github.com/repos/helm/charts/pulls/9802","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/helm/charts/pulls/comments/239890726"},"html":{"href":"https://github.com/helm/charts/pull/9802#discussion_r239890726"},"pull_request":{"href":"https://api.github.com/repos/helm/charts/pulls/9802"}},"in_reply_to_id":239856676},"pull_request":{"url":"https://api.github.com/repos/helm/charts/pulls/9802","id":236889090,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2ODg5MDkw","html_url":"https://github.com/helm/charts/pull/9802","diff_url":"https://github.com/helm/charts/pull/9802.diff","patch_url":"https://github.com/helm/charts/pull/9802.patch","issue_url":"https://api.github.com/repos/helm/charts/issues/9802","number":9802,"state":"open","locked":false,"title":"[stable/keycloak] Update pullSecrets variable usage","user":{"login":"alivespirit","id":4292101,"node_id":"MDQ6VXNlcjQyOTIxMDE=","avatar_url":"https://avatars2.githubusercontent.com/u/4292101?v=4","gravatar_id":"","url":"https://api.github.com/users/alivespirit","html_url":"https://github.com/alivespirit","followers_url":"https://api.github.com/users/alivespirit/followers","following_url":"https://api.github.com/users/alivespirit/following{/other_user}","gists_url":"https://api.github.com/users/alivespirit/gists{/gist_id}","starred_url":"https://api.github.com/users/alivespirit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alivespirit/subscriptions","organizations_url":"https://api.github.com/users/alivespirit/orgs","repos_url":"https://api.github.com/users/alivespirit/repos","events_url":"https://api.github.com/users/alivespirit/events{/privacy}","received_events_url":"https://api.github.com/users/alivespirit/received_events","type":"User","site_admin":false},"body":"#### What this PR does / why we need it:\r\nUpdating pullSecrets variable to match the example in values.yaml. Current version has this example:\r\n```\r\n    pullSecrets: []\r\n    #  - myRegistrKeySecretName\r\n```\r\nbut the construction in [templates/statefulset.yaml](templates/statefulset.yaml) expects it to be:\r\n```\r\n    pullSecrets:\r\n      - name: myRegistrKeySecretName\r\n```\r\nSo, if pull secrets are set like in values.yaml, deploy fails with error like `Spec: v1.PodSpec: ImagePullSecrets: []v1.LocalObjectReference: readObjectStart: expect { or n, parsing 2503 ...ecrets\"`\r\nMy changes update template to use pull secret value in a similar way as in stable/postgresql chart.\r\n\r\n#### Checklist\r\n[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]\r\n- [x] pullSecret variable usage updated\r\n- [x] Chart Version bumped\r\n","created_at":"2018-12-07T14:41:50Z","updated_at":"2018-12-07T17:47:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f60e5c148801ccf09935b42f4348ed48f8545d53","assignee":null,"assignees":[],"requested_reviewers":[{"login":"paulczar","id":2488346,"node_id":"MDQ6VXNlcjI0ODgzNDY=","avatar_url":"https://avatars2.githubusercontent.com/u/2488346?v=4","gravatar_id":"","url":"https://api.github.com/users/paulczar","html_url":"https://github.com/paulczar","followers_url":"https://api.github.com/users/paulczar/followers","following_url":"https://api.github.com/users/paulczar/following{/other_user}","gists_url":"https://api.github.com/users/paulczar/gists{/gist_id}","starred_url":"https://api.github.com/users/paulczar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulczar/subscriptions","organizations_url":"https://api.github.com/users/paulczar/orgs","repos_url":"https://api.github.com/users/paulczar/repos","events_url":"https://api.github.com/users/paulczar/events{/privacy}","received_events_url":"https://api.github.com/users/paulczar/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":676009699,"node_id":"MDU6TGFiZWw2NzYwMDk2OTk=","url":"https://api.github.com/repos/helm/charts/labels/size/S","name":"size/S","color":"77bb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/helm/charts/pulls/9802/commits","review_comments_url":"https://api.github.com/repos/helm/charts/pulls/9802/comments","review_comment_url":"https://api.github.com/repos/helm/charts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/helm/charts/issues/9802/comments","statuses_url":"https://api.github.com/repos/helm/charts/statuses/1db673bf28ebca0618083ecf3e3d20bc70303670","head":{"label":"alivespirit:patch-1","ref":"patch-1","sha":"1db673bf28ebca0618083ecf3e3d20bc70303670","user":{"login":"alivespirit","id":4292101,"node_id":"MDQ6VXNlcjQyOTIxMDE=","avatar_url":"https://avatars2.githubusercontent.com/u/4292101?v=4","gravatar_id":"","url":"https://api.github.com/users/alivespirit","html_url":"https://github.com/alivespirit","followers_url":"https://api.github.com/users/alivespirit/followers","following_url":"https://api.github.com/users/alivespirit/following{/other_user}","gists_url":"https://api.github.com/users/alivespirit/gists{/gist_id}","starred_url":"https://api.github.com/users/alivespirit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alivespirit/subscriptions","organizations_url":"https://api.github.com/users/alivespirit/orgs","repos_url":"https://api.github.com/users/alivespirit/repos","events_url":"https://api.github.com/users/alivespirit/events{/privacy}","received_events_url":"https://api.github.com/users/alivespirit/received_events","type":"User","site_admin":false},"repo":{"id":160832086,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA4MzIwODY=","name":"charts","full_name":"alivespirit/charts","private":false,"owner":{"login":"alivespirit","id":4292101,"node_id":"MDQ6VXNlcjQyOTIxMDE=","avatar_url":"https://avatars2.githubusercontent.com/u/4292101?v=4","gravatar_id":"","url":"https://api.github.com/users/alivespirit","html_url":"https://github.com/alivespirit","followers_url":"https://api.github.com/users/alivespirit/followers","following_url":"https://api.github.com/users/alivespirit/following{/other_user}","gists_url":"https://api.github.com/users/alivespirit/gists{/gist_id}","starred_url":"https://api.github.com/users/alivespirit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alivespirit/subscriptions","organizations_url":"https://api.github.com/users/alivespirit/orgs","repos_url":"https://api.github.com/users/alivespirit/repos","events_url":"https://api.github.com/users/alivespirit/events{/privacy}","received_events_url":"https://api.github.com/users/alivespirit/received_events","type":"User","site_admin":false},"html_url":"https://github.com/alivespirit/charts","description":"Curated applications for Kubernetes","fork":true,"url":"https://api.github.com/repos/alivespirit/charts","forks_url":"https://api.github.com/repos/alivespirit/charts/forks","keys_url":"https://api.github.com/repos/alivespirit/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alivespirit/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alivespirit/charts/teams","hooks_url":"https://api.github.com/repos/alivespirit/charts/hooks","issue_events_url":"https://api.github.com/repos/alivespirit/charts/issues/events{/number}","events_url":"https://api.github.com/repos/alivespirit/charts/events","assignees_url":"https://api.github.com/repos/alivespirit/charts/assignees{/user}","branches_url":"https://api.github.com/repos/alivespirit/charts/branches{/branch}","tags_url":"https://api.github.com/repos/alivespirit/charts/tags","blobs_url":"https://api.github.com/repos/alivespirit/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alivespirit/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alivespirit/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/alivespirit/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alivespirit/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/alivespirit/charts/languages","stargazers_url":"https://api.github.com/repos/alivespirit/charts/stargazers","contributors_url":"https://api.github.com/repos/alivespirit/charts/contributors","subscribers_url":"https://api.github.com/repos/alivespirit/charts/subscribers","subscription_url":"https://api.github.com/repos/alivespirit/charts/subscription","commits_url":"https://api.github.com/repos/alivespirit/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/alivespirit/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/alivespirit/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/alivespirit/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/alivespirit/charts/contents/{+path}","compare_url":"https://api.github.com/repos/alivespirit/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alivespirit/charts/merges","archive_url":"https://api.github.com/repos/alivespirit/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alivespirit/charts/downloads","issues_url":"https://api.github.com/repos/alivespirit/charts/issues{/number}","pulls_url":"https://api.github.com/repos/alivespirit/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/alivespirit/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/alivespirit/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alivespirit/charts/labels{/name}","releases_url":"https://api.github.com/repos/alivespirit/charts/releases{/id}","deployments_url":"https://api.github.com/repos/alivespirit/charts/deployments","created_at":"2018-12-07T14:12:05Z","updated_at":"2018-12-07T14:12:12Z","pushed_at":"2018-12-07T14:49:39Z","git_url":"git://github.com/alivespirit/charts.git","ssh_url":"git@github.com:alivespirit/charts.git","clone_url":"https://github.com/alivespirit/charts.git","svn_url":"https://github.com/alivespirit/charts","homepage":"","size":14324,"stargazers_count":0,"watchers_count":0,"language":"Smarty","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"helm:master","ref":"master","sha":"f68259033dde151e6c18fd9299811f3e813635eb","user":{"login":"helm","id":15859888,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1ODU5ODg4","avatar_url":"https://avatars2.githubusercontent.com/u/15859888?v=4","gravatar_id":"","url":"https://api.github.com/users/helm","html_url":"https://github.com/helm","followers_url":"https://api.github.com/users/helm/followers","following_url":"https://api.github.com/users/helm/following{/other_user}","gists_url":"https://api.github.com/users/helm/gists{/gist_id}","starred_url":"https://api.github.com/users/helm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helm/subscriptions","organizations_url":"https://api.github.com/users/helm/orgs","repos_url":"https://api.github.com/users/helm/repos","events_url":"https://api.github.com/users/helm/events{/privacy}","received_events_url":"https://api.github.com/users/helm/received_events","type":"Organization","site_admin":false},"repo":{"id":46806184,"node_id":"MDEwOlJlcG9zaXRvcnk0NjgwNjE4NA==","name":"charts","full_name":"helm/charts","private":false,"owner":{"login":"helm","id":15859888,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1ODU5ODg4","avatar_url":"https://avatars2.githubusercontent.com/u/15859888?v=4","gravatar_id":"","url":"https://api.github.com/users/helm","html_url":"https://github.com/helm","followers_url":"https://api.github.com/users/helm/followers","following_url":"https://api.github.com/users/helm/following{/other_user}","gists_url":"https://api.github.com/users/helm/gists{/gist_id}","starred_url":"https://api.github.com/users/helm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helm/subscriptions","organizations_url":"https://api.github.com/users/helm/orgs","repos_url":"https://api.github.com/users/helm/repos","events_url":"https://api.github.com/users/helm/events{/privacy}","received_events_url":"https://api.github.com/users/helm/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/helm/charts","description":"Curated applications for Kubernetes","fork":false,"url":"https://api.github.com/repos/helm/charts","forks_url":"https://api.github.com/repos/helm/charts/forks","keys_url":"https://api.github.com/repos/helm/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/helm/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/helm/charts/teams","hooks_url":"https://api.github.com/repos/helm/charts/hooks","issue_events_url":"https://api.github.com/repos/helm/charts/issues/events{/number}","events_url":"https://api.github.com/repos/helm/charts/events","assignees_url":"https://api.github.com/repos/helm/charts/assignees{/user}","branches_url":"https://api.github.com/repos/helm/charts/branches{/branch}","tags_url":"https://api.github.com/repos/helm/charts/tags","blobs_url":"https://api.github.com/repos/helm/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/helm/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/helm/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/helm/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/helm/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/helm/charts/languages","stargazers_url":"https://api.github.com/repos/helm/charts/stargazers","contributors_url":"https://api.github.com/repos/helm/charts/contributors","subscribers_url":"https://api.github.com/repos/helm/charts/subscribers","subscription_url":"https://api.github.com/repos/helm/charts/subscription","commits_url":"https://api.github.com/repos/helm/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/helm/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/helm/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/helm/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/helm/charts/contents/{+path}","compare_url":"https://api.github.com/repos/helm/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/helm/charts/merges","archive_url":"https://api.github.com/repos/helm/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/helm/charts/downloads","issues_url":"https://api.github.com/repos/helm/charts/issues{/number}","pulls_url":"https://api.github.com/repos/helm/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/helm/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/helm/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/helm/charts/labels{/name}","releases_url":"https://api.github.com/repos/helm/charts/releases{/id}","deployments_url":"https://api.github.com/repos/helm/charts/deployments","created_at":"2015-11-24T17:05:28Z","updated_at":"2018-12-07T17:43:43Z","pushed_at":"2018-12-07T17:45:51Z","git_url":"git://github.com/helm/charts.git","ssh_url":"git@github.com:helm/charts.git","clone_url":"https://github.com/helm/charts.git","svn_url":"https://github.com/helm/charts","homepage":"","size":14363,"stargazers_count":5921,"watchers_count":5921,"language":"Smarty","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5384,"mirror_url":null,"archived":false,"open_issues_count":687,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5384,"open_issues":687,"watchers":5921,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/helm/charts/pulls/9802"},"html":{"href":"https://github.com/helm/charts/pull/9802"},"issue":{"href":"https://api.github.com/repos/helm/charts/issues/9802"},"comments":{"href":"https://api.github.com/repos/helm/charts/issues/9802/comments"},"review_comments":{"href":"https://api.github.com/repos/helm/charts/pulls/9802/comments"},"review_comment":{"href":"https://api.github.com/repos/helm/charts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/helm/charts/pulls/9802/commits"},"statuses":{"href":"https://api.github.com/repos/helm/charts/statuses/1db673bf28ebca0618083ecf3e3d20bc70303670"}},"author_association":"NONE"}}
{"actor":{"display_login":"unguiculus"}}