{"action":"created","comment":{"url":"https://api.github.com/repos/concord-consortium/collaborative-learning/pulls/comments/228250098","pull_request_review_id":168479794,"id":228250098,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODI1MDA5OA==","diff_hunk":"@@ -38,6 +38,7 @@ interface IProps {\n   context: string;\n   docId: string;\n   scale?: number;\n+  tabIndex?: number;","path":"src/components/canvas-tools/tool-tile.tsx","position":25,"original_position":4,"commit_id":"e67819860febf82325c623fb74b99b1572488045","original_commit_id":"f36da048ac45e07eae5b596220d5adbdf4020ade","user":{"login":"ekosmin","id":3824039,"node_id":"MDQ6VXNlcjM4MjQwMzk=","avatar_url":"https://avatars1.githubusercontent.com/u/3824039?v=4","gravatar_id":"","url":"https://api.github.com/users/ekosmin","html_url":"https://github.com/ekosmin","followers_url":"https://api.github.com/users/ekosmin/followers","following_url":"https://api.github.com/users/ekosmin/following{/other_user}","gists_url":"https://api.github.com/users/ekosmin/gists{/gist_id}","starred_url":"https://api.github.com/users/ekosmin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekosmin/subscriptions","organizations_url":"https://api.github.com/users/ekosmin/orgs","repos_url":"https://api.github.com/users/ekosmin/repos","events_url":"https://api.github.com/users/ekosmin/events{/privacy}","received_events_url":"https://api.github.com/users/ekosmin/received_events","type":"User","site_admin":false},"body":"Is the idea that `tabIndex` is necessary for keyboard focus to do things like backspace points?\r\n\r\nAlso seems useful in some world where we get to think about accessible controls","created_at":"2018-10-25T16:41:33Z","updated_at":"2018-10-25T16:41:33Z","html_url":"https://github.com/concord-consortium/collaborative-learning/pull/127#discussion_r228250098","pull_request_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/pulls/127","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/concord-consortium/collaborative-learning/pulls/comments/228250098"},"html":{"href":"https://github.com/concord-consortium/collaborative-learning/pull/127#discussion_r228250098"},"pull_request":{"href":"https://api.github.com/repos/concord-consortium/collaborative-learning/pulls/127"}}},"pull_request":{"url":"https://api.github.com/repos/concord-consortium/collaborative-learning/pulls/127","id":225632537,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1NjMyNTM3","html_url":"https://github.com/concord-consortium/collaborative-learning/pull/127","diff_url":"https://github.com/concord-consortium/collaborative-learning/pull/127.diff","patch_url":"https://github.com/concord-consortium/collaborative-learning/pull/127.patch","issue_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/issues/127","number":127,"state":"open","locked":false,"title":"Geometry tool supports selecting points","user":{"login":"kswenson","id":235234,"node_id":"MDQ6VXNlcjIzNTIzNA==","avatar_url":"https://avatars0.githubusercontent.com/u/235234?v=4","gravatar_id":"","url":"https://api.github.com/users/kswenson","html_url":"https://github.com/kswenson","followers_url":"https://api.github.com/users/kswenson/followers","following_url":"https://api.github.com/users/kswenson/following{/other_user}","gists_url":"https://api.github.com/users/kswenson/gists{/gist_id}","starred_url":"https://api.github.com/users/kswenson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kswenson/subscriptions","organizations_url":"https://api.github.com/users/kswenson/orgs","repos_url":"https://api.github.com/users/kswenson/repos","events_url":"https://api.github.com/users/kswenson/events{/privacy}","received_events_url":"https://api.github.com/users/kswenson/received_events","type":"User","site_admin":false},"body":"Implement selection of points [#160969495]\r\n- points are gray by default, red when selected\r\n- clicking on a single point selects it\r\n- ctrl/shift/cmd-click to select/deselect multiple points\r\n- click on background deselects all points\r\n- backspace/delete keys delete selected points [#161272021]\r\n- first click on the interior of a polygon selects all its vertices\r\n- click on interior of polygon with all vertices selected creates a new point\r\n- click on red-X in toolbar to delete selected points [#161272021]\r\n\r\nImplementing this required several pieces of new architecture.\r\n- pass `tabIndex` to rows/tiles\r\n  - `tabIndex` is required for keyboard focus\r\n- tile-specific metadata objects are created and passed to tiles that require them (currently only the geometry tool) for storage of tile-related data that is not serialized to firebase (e.g. geometry element selection)\r\n- mechanism for tiles to specify tile-specific API callbacks for use by document/toolbar-level entities\r\n  - required to implement red-X delete of geometry content\r\n","created_at":"2018-10-25T05:57:37Z","updated_at":"2018-10-25T16:41:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"86c88ddf020374adb6898706a7f6e66015fea80e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/pulls/127/commits","review_comments_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/pulls/127/comments","review_comment_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/pulls/comments{/number}","comments_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/issues/127/comments","statuses_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/statuses/e67819860febf82325c623fb74b99b1572488045","head":{"label":"concord-consortium:160969495-geometry-select-points","ref":"160969495-geometry-select-points","sha":"e67819860febf82325c623fb74b99b1572488045","user":{"login":"concord-consortium","id":319219,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTIxOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/319219?v=4","gravatar_id":"","url":"https://api.github.com/users/concord-consortium","html_url":"https://github.com/concord-consortium","followers_url":"https://api.github.com/users/concord-consortium/followers","following_url":"https://api.github.com/users/concord-consortium/following{/other_user}","gists_url":"https://api.github.com/users/concord-consortium/gists{/gist_id}","starred_url":"https://api.github.com/users/concord-consortium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/concord-consortium/subscriptions","organizations_url":"https://api.github.com/users/concord-consortium/orgs","repos_url":"https://api.github.com/users/concord-consortium/repos","events_url":"https://api.github.com/users/concord-consortium/events{/privacy}","received_events_url":"https://api.github.com/users/concord-consortium/received_events","type":"Organization","site_admin":false},"repo":{"id":145902554,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU5MDI1NTQ=","name":"collaborative-learning","full_name":"concord-consortium/collaborative-learning","private":false,"owner":{"login":"concord-consortium","id":319219,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTIxOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/319219?v=4","gravatar_id":"","url":"https://api.github.com/users/concord-consortium","html_url":"https://github.com/concord-consortium","followers_url":"https://api.github.com/users/concord-consortium/followers","following_url":"https://api.github.com/users/concord-consortium/following{/other_user}","gists_url":"https://api.github.com/users/concord-consortium/gists{/gist_id}","starred_url":"https://api.github.com/users/concord-consortium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/concord-consortium/subscriptions","organizations_url":"https://api.github.com/users/concord-consortium/orgs","repos_url":"https://api.github.com/users/concord-consortium/repos","events_url":"https://api.github.com/users/concord-consortium/events{/privacy}","received_events_url":"https://api.github.com/users/concord-consortium/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/concord-consortium/collaborative-learning","description":null,"fork":false,"url":"https://api.github.com/repos/concord-consortium/collaborative-learning","forks_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/forks","keys_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/teams","hooks_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/hooks","issue_events_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/issues/events{/number}","events_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/events","assignees_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/assignees{/user}","branches_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/branches{/branch}","tags_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/tags","blobs_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/git/refs{/sha}","trees_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/statuses/{sha}","languages_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/languages","stargazers_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/stargazers","contributors_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/contributors","subscribers_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/subscribers","subscription_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/subscription","commits_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/commits{/sha}","git_commits_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/git/commits{/sha}","comments_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/comments{/number}","issue_comment_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/issues/comments{/number}","contents_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/contents/{+path}","compare_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/merges","archive_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/downloads","issues_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/issues{/number}","pulls_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/pulls{/number}","milestones_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/milestones{/number}","notifications_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/labels{/name}","releases_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/releases{/id}","deployments_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/deployments","created_at":"2018-08-23T20:16:15Z","updated_at":"2018-10-25T07:48:15Z","pushed_at":"2018-10-25T15:56:50Z","git_url":"git://github.com/concord-consortium/collaborative-learning.git","ssh_url":"git@github.com:concord-consortium/collaborative-learning.git","clone_url":"https://github.com/concord-consortium/collaborative-learning.git","svn_url":"https://github.com/concord-consortium/collaborative-learning","homepage":null,"size":6722,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"concord-consortium:master","ref":"master","sha":"5210285b0befe3a505962cd01803cd6e5bf1aa0f","user":{"login":"concord-consortium","id":319219,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTIxOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/319219?v=4","gravatar_id":"","url":"https://api.github.com/users/concord-consortium","html_url":"https://github.com/concord-consortium","followers_url":"https://api.github.com/users/concord-consortium/followers","following_url":"https://api.github.com/users/concord-consortium/following{/other_user}","gists_url":"https://api.github.com/users/concord-consortium/gists{/gist_id}","starred_url":"https://api.github.com/users/concord-consortium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/concord-consortium/subscriptions","organizations_url":"https://api.github.com/users/concord-consortium/orgs","repos_url":"https://api.github.com/users/concord-consortium/repos","events_url":"https://api.github.com/users/concord-consortium/events{/privacy}","received_events_url":"https://api.github.com/users/concord-consortium/received_events","type":"Organization","site_admin":false},"repo":{"id":145902554,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU5MDI1NTQ=","name":"collaborative-learning","full_name":"concord-consortium/collaborative-learning","private":false,"owner":{"login":"concord-consortium","id":319219,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTIxOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/319219?v=4","gravatar_id":"","url":"https://api.github.com/users/concord-consortium","html_url":"https://github.com/concord-consortium","followers_url":"https://api.github.com/users/concord-consortium/followers","following_url":"https://api.github.com/users/concord-consortium/following{/other_user}","gists_url":"https://api.github.com/users/concord-consortium/gists{/gist_id}","starred_url":"https://api.github.com/users/concord-consortium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/concord-consortium/subscriptions","organizations_url":"https://api.github.com/users/concord-consortium/orgs","repos_url":"https://api.github.com/users/concord-consortium/repos","events_url":"https://api.github.com/users/concord-consortium/events{/privacy}","received_events_url":"https://api.github.com/users/concord-consortium/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/concord-consortium/collaborative-learning","description":null,"fork":false,"url":"https://api.github.com/repos/concord-consortium/collaborative-learning","forks_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/forks","keys_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/teams","hooks_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/hooks","issue_events_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/issues/events{/number}","events_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/events","assignees_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/assignees{/user}","branches_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/branches{/branch}","tags_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/tags","blobs_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/git/refs{/sha}","trees_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/statuses/{sha}","languages_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/languages","stargazers_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/stargazers","contributors_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/contributors","subscribers_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/subscribers","subscription_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/subscription","commits_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/commits{/sha}","git_commits_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/git/commits{/sha}","comments_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/comments{/number}","issue_comment_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/issues/comments{/number}","contents_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/contents/{+path}","compare_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/merges","archive_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/downloads","issues_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/issues{/number}","pulls_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/pulls{/number}","milestones_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/milestones{/number}","notifications_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/labels{/name}","releases_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/releases{/id}","deployments_url":"https://api.github.com/repos/concord-consortium/collaborative-learning/deployments","created_at":"2018-08-23T20:16:15Z","updated_at":"2018-10-25T07:48:15Z","pushed_at":"2018-10-25T15:56:50Z","git_url":"git://github.com/concord-consortium/collaborative-learning.git","ssh_url":"git@github.com:concord-consortium/collaborative-learning.git","clone_url":"https://github.com/concord-consortium/collaborative-learning.git","svn_url":"https://github.com/concord-consortium/collaborative-learning","homepage":null,"size":6722,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/concord-consortium/collaborative-learning/pulls/127"},"html":{"href":"https://github.com/concord-consortium/collaborative-learning/pull/127"},"issue":{"href":"https://api.github.com/repos/concord-consortium/collaborative-learning/issues/127"},"comments":{"href":"https://api.github.com/repos/concord-consortium/collaborative-learning/issues/127/comments"},"review_comments":{"href":"https://api.github.com/repos/concord-consortium/collaborative-learning/pulls/127/comments"},"review_comment":{"href":"https://api.github.com/repos/concord-consortium/collaborative-learning/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/concord-consortium/collaborative-learning/pulls/127/commits"},"statuses":{"href":"https://api.github.com/repos/concord-consortium/collaborative-learning/statuses/e67819860febf82325c623fb74b99b1572488045"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ekosmin"}}