{"action":"created","comment":{"url":"https://api.github.com/repos/genialis/resolwe/pulls/comments/200100647","pull_request_review_id":134347783,"id":200100647,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDEwMDY0Nw==","diff_hunk":"@@ -184,12 +189,32 @@ def new_volume(kind, base_dir_name, volume, path=None, read_only=True):\n         # A non-login Bash shell should be used here (a subshell will be spawned later).\n         command_args['shell'] = '/bin/bash'\n \n+        docker_command = (\n+            '{command} run --rm --interactive {container_name} {network} {volumes} {limits} '\n+            '{security} {workdir} {user} {container_image} {shell}'.format(**command_args)\n+        )\n+\n+        logger.info(\"Starting docker container with command: {}\".format(docker_command))\n+        start_time = time.time()\n+\n         self.proc = subprocess.Popen(\n-            shlex.split(\n-                '{command} run --rm --interactive {container_name} {network} {volumes} {limits} '\n-                '{security} {workdir} {user} {container_image} {shell}'.format(**command_args)),\n-            stdin=subprocess.PIPE, stdout=subprocess.PIPE, stderr=subprocess.STDOUT,\n-            universal_newlines=True)\n+            shlex.split(docker_command),\n+            stdin=subprocess.PIPE,\n+            stdout=subprocess.PIPE,\n+            stderr=subprocess.STDOUT,\n+            universal_newlines=True,\n+            bufsize=1,\n+        )\n+\n+        # Wait for Docker container to start.","path":"resolwe/flow/executors/docker/run.py","position":48,"original_position":48,"commit_id":"f221dcb12f926a86269aa65cb55a49cd72af5063","original_commit_id":"f221dcb12f926a86269aa65cb55a49cd72af5063","user":{"login":"tjanez","id":2518544,"node_id":"MDQ6VXNlcjI1MTg1NDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2518544?v=4","gravatar_id":"","url":"https://api.github.com/users/tjanez","html_url":"https://github.com/tjanez","followers_url":"https://api.github.com/users/tjanez/followers","following_url":"https://api.github.com/users/tjanez/following{/other_user}","gists_url":"https://api.github.com/users/tjanez/gists{/gist_id}","starred_url":"https://api.github.com/users/tjanez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjanez/subscriptions","organizations_url":"https://api.github.com/users/tjanez/orgs","repos_url":"https://api.github.com/users/tjanez/repos","events_url":"https://api.github.com/users/tjanez/events{/privacy}","received_events_url":"https://api.github.com/users/tjanez/received_events","type":"User","site_admin":false},"body":"Can you rewrite the comment to be more along the lines of:\r\n\r\n```\r\n# Write something to stdout to measure container's start-up time.\r\n```","created_at":"2018-07-04T11:43:55Z","updated_at":"2018-07-04T11:50:16Z","html_url":"https://github.com/genialis/resolwe/pull/505#discussion_r200100647","pull_request_url":"https://api.github.com/repos/genialis/resolwe/pulls/505","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/genialis/resolwe/pulls/comments/200100647"},"html":{"href":"https://github.com/genialis/resolwe/pull/505#discussion_r200100647"},"pull_request":{"href":"https://api.github.com/repos/genialis/resolwe/pulls/505"}}},"pull_request":{"url":"https://api.github.com/repos/genialis/resolwe/pulls/505","id":199182409,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5MTgyNDA5","html_url":"https://github.com/genialis/resolwe/pull/505","diff_url":"https://github.com/genialis/resolwe/pull/505.diff","patch_url":"https://github.com/genialis/resolwe/pull/505.patch","issue_url":"https://api.github.com/repos/genialis/resolwe/issues/505","number":505,"state":"open","locked":false,"title":"Add debug log messages to executor and listener","user":{"login":"dblenkus","id":5970282,"node_id":"MDQ6VXNlcjU5NzAyODI=","avatar_url":"https://avatars2.githubusercontent.com/u/5970282?v=4","gravatar_id":"","url":"https://api.github.com/users/dblenkus","html_url":"https://github.com/dblenkus","followers_url":"https://api.github.com/users/dblenkus/followers","following_url":"https://api.github.com/users/dblenkus/following{/other_user}","gists_url":"https://api.github.com/users/dblenkus/gists{/gist_id}","starred_url":"https://api.github.com/users/dblenkus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dblenkus/subscriptions","organizations_url":"https://api.github.com/users/dblenkus/orgs","repos_url":"https://api.github.com/users/dblenkus/repos","events_url":"https://api.github.com/users/dblenkus/events{/privacy}","received_events_url":"https://api.github.com/users/dblenkus/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-04T08:59:42Z","updated_at":"2018-07-04T11:50:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bf76aac24ec8b1c72ac5826fcbdb75cd35d92e49","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/genialis/resolwe/pulls/505/commits","review_comments_url":"https://api.github.com/repos/genialis/resolwe/pulls/505/comments","review_comment_url":"https://api.github.com/repos/genialis/resolwe/pulls/comments{/number}","comments_url":"https://api.github.com/repos/genialis/resolwe/issues/505/comments","statuses_url":"https://api.github.com/repos/genialis/resolwe/statuses/f221dcb12f926a86269aa65cb55a49cd72af5063","head":{"label":"dblenkus:feature/executor-logging","ref":"feature/executor-logging","sha":"f221dcb12f926a86269aa65cb55a49cd72af5063","user":{"login":"dblenkus","id":5970282,"node_id":"MDQ6VXNlcjU5NzAyODI=","avatar_url":"https://avatars2.githubusercontent.com/u/5970282?v=4","gravatar_id":"","url":"https://api.github.com/users/dblenkus","html_url":"https://github.com/dblenkus","followers_url":"https://api.github.com/users/dblenkus/followers","following_url":"https://api.github.com/users/dblenkus/following{/other_user}","gists_url":"https://api.github.com/users/dblenkus/gists{/gist_id}","starred_url":"https://api.github.com/users/dblenkus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dblenkus/subscriptions","organizations_url":"https://api.github.com/users/dblenkus/orgs","repos_url":"https://api.github.com/users/dblenkus/repos","events_url":"https://api.github.com/users/dblenkus/events{/privacy}","received_events_url":"https://api.github.com/users/dblenkus/received_events","type":"User","site_admin":false},"repo":{"id":47176255,"node_id":"MDEwOlJlcG9zaXRvcnk0NzE3NjI1NQ==","name":"resolwe","full_name":"dblenkus/resolwe","owner":{"login":"dblenkus","id":5970282,"node_id":"MDQ6VXNlcjU5NzAyODI=","avatar_url":"https://avatars2.githubusercontent.com/u/5970282?v=4","gravatar_id":"","url":"https://api.github.com/users/dblenkus","html_url":"https://github.com/dblenkus","followers_url":"https://api.github.com/users/dblenkus/followers","following_url":"https://api.github.com/users/dblenkus/following{/other_user}","gists_url":"https://api.github.com/users/dblenkus/gists{/gist_id}","starred_url":"https://api.github.com/users/dblenkus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dblenkus/subscriptions","organizations_url":"https://api.github.com/users/dblenkus/orgs","repos_url":"https://api.github.com/users/dblenkus/repos","events_url":"https://api.github.com/users/dblenkus/events{/privacy}","received_events_url":"https://api.github.com/users/dblenkus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dblenkus/resolwe","description":"Open source dataflow engine in Django","fork":true,"url":"https://api.github.com/repos/dblenkus/resolwe","forks_url":"https://api.github.com/repos/dblenkus/resolwe/forks","keys_url":"https://api.github.com/repos/dblenkus/resolwe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dblenkus/resolwe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dblenkus/resolwe/teams","hooks_url":"https://api.github.com/repos/dblenkus/resolwe/hooks","issue_events_url":"https://api.github.com/repos/dblenkus/resolwe/issues/events{/number}","events_url":"https://api.github.com/repos/dblenkus/resolwe/events","assignees_url":"https://api.github.com/repos/dblenkus/resolwe/assignees{/user}","branches_url":"https://api.github.com/repos/dblenkus/resolwe/branches{/branch}","tags_url":"https://api.github.com/repos/dblenkus/resolwe/tags","blobs_url":"https://api.github.com/repos/dblenkus/resolwe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dblenkus/resolwe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dblenkus/resolwe/git/refs{/sha}","trees_url":"https://api.github.com/repos/dblenkus/resolwe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dblenkus/resolwe/statuses/{sha}","languages_url":"https://api.github.com/repos/dblenkus/resolwe/languages","stargazers_url":"https://api.github.com/repos/dblenkus/resolwe/stargazers","contributors_url":"https://api.github.com/repos/dblenkus/resolwe/contributors","subscribers_url":"https://api.github.com/repos/dblenkus/resolwe/subscribers","subscription_url":"https://api.github.com/repos/dblenkus/resolwe/subscription","commits_url":"https://api.github.com/repos/dblenkus/resolwe/commits{/sha}","git_commits_url":"https://api.github.com/repos/dblenkus/resolwe/git/commits{/sha}","comments_url":"https://api.github.com/repos/dblenkus/resolwe/comments{/number}","issue_comment_url":"https://api.github.com/repos/dblenkus/resolwe/issues/comments{/number}","contents_url":"https://api.github.com/repos/dblenkus/resolwe/contents/{+path}","compare_url":"https://api.github.com/repos/dblenkus/resolwe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dblenkus/resolwe/merges","archive_url":"https://api.github.com/repos/dblenkus/resolwe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dblenkus/resolwe/downloads","issues_url":"https://api.github.com/repos/dblenkus/resolwe/issues{/number}","pulls_url":"https://api.github.com/repos/dblenkus/resolwe/pulls{/number}","milestones_url":"https://api.github.com/repos/dblenkus/resolwe/milestones{/number}","notifications_url":"https://api.github.com/repos/dblenkus/resolwe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dblenkus/resolwe/labels{/name}","releases_url":"https://api.github.com/repos/dblenkus/resolwe/releases{/id}","deployments_url":"https://api.github.com/repos/dblenkus/resolwe/deployments","created_at":"2015-12-01T08:32:56Z","updated_at":"2018-06-11T09:47:14Z","pushed_at":"2018-07-04T08:59:15Z","git_url":"git://github.com/dblenkus/resolwe.git","ssh_url":"git@github.com:dblenkus/resolwe.git","clone_url":"https://github.com/dblenkus/resolwe.git","svn_url":"https://github.com/dblenkus/resolwe","homepage":"","size":2021,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"genialis:master","ref":"master","sha":"87bd96fd52090d959f8a01c383a95e37c1173606","user":{"login":"genialis","id":2120224,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjAyMjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2120224?v=4","gravatar_id":"","url":"https://api.github.com/users/genialis","html_url":"https://github.com/genialis","followers_url":"https://api.github.com/users/genialis/followers","following_url":"https://api.github.com/users/genialis/following{/other_user}","gists_url":"https://api.github.com/users/genialis/gists{/gist_id}","starred_url":"https://api.github.com/users/genialis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/genialis/subscriptions","organizations_url":"https://api.github.com/users/genialis/orgs","repos_url":"https://api.github.com/users/genialis/repos","events_url":"https://api.github.com/users/genialis/events{/privacy}","received_events_url":"https://api.github.com/users/genialis/received_events","type":"Organization","site_admin":false},"repo":{"id":33678988,"node_id":"MDEwOlJlcG9zaXRvcnkzMzY3ODk4OA==","name":"resolwe","full_name":"genialis/resolwe","owner":{"login":"genialis","id":2120224,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMjAyMjQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2120224?v=4","gravatar_id":"","url":"https://api.github.com/users/genialis","html_url":"https://github.com/genialis","followers_url":"https://api.github.com/users/genialis/followers","following_url":"https://api.github.com/users/genialis/following{/other_user}","gists_url":"https://api.github.com/users/genialis/gists{/gist_id}","starred_url":"https://api.github.com/users/genialis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/genialis/subscriptions","organizations_url":"https://api.github.com/users/genialis/orgs","repos_url":"https://api.github.com/users/genialis/repos","events_url":"https://api.github.com/users/genialis/events{/privacy}","received_events_url":"https://api.github.com/users/genialis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/genialis/resolwe","description":"Open source dataflow engine in Django","fork":false,"url":"https://api.github.com/repos/genialis/resolwe","forks_url":"https://api.github.com/repos/genialis/resolwe/forks","keys_url":"https://api.github.com/repos/genialis/resolwe/keys{/key_id}","collaborators_url":"https://api.github.com/repos/genialis/resolwe/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/genialis/resolwe/teams","hooks_url":"https://api.github.com/repos/genialis/resolwe/hooks","issue_events_url":"https://api.github.com/repos/genialis/resolwe/issues/events{/number}","events_url":"https://api.github.com/repos/genialis/resolwe/events","assignees_url":"https://api.github.com/repos/genialis/resolwe/assignees{/user}","branches_url":"https://api.github.com/repos/genialis/resolwe/branches{/branch}","tags_url":"https://api.github.com/repos/genialis/resolwe/tags","blobs_url":"https://api.github.com/repos/genialis/resolwe/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/genialis/resolwe/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/genialis/resolwe/git/refs{/sha}","trees_url":"https://api.github.com/repos/genialis/resolwe/git/trees{/sha}","statuses_url":"https://api.github.com/repos/genialis/resolwe/statuses/{sha}","languages_url":"https://api.github.com/repos/genialis/resolwe/languages","stargazers_url":"https://api.github.com/repos/genialis/resolwe/stargazers","contributors_url":"https://api.github.com/repos/genialis/resolwe/contributors","subscribers_url":"https://api.github.com/repos/genialis/resolwe/subscribers","subscription_url":"https://api.github.com/repos/genialis/resolwe/subscription","commits_url":"https://api.github.com/repos/genialis/resolwe/commits{/sha}","git_commits_url":"https://api.github.com/repos/genialis/resolwe/git/commits{/sha}","comments_url":"https://api.github.com/repos/genialis/resolwe/comments{/number}","issue_comment_url":"https://api.github.com/repos/genialis/resolwe/issues/comments{/number}","contents_url":"https://api.github.com/repos/genialis/resolwe/contents/{+path}","compare_url":"https://api.github.com/repos/genialis/resolwe/compare/{base}...{head}","merges_url":"https://api.github.com/repos/genialis/resolwe/merges","archive_url":"https://api.github.com/repos/genialis/resolwe/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/genialis/resolwe/downloads","issues_url":"https://api.github.com/repos/genialis/resolwe/issues{/number}","pulls_url":"https://api.github.com/repos/genialis/resolwe/pulls{/number}","milestones_url":"https://api.github.com/repos/genialis/resolwe/milestones{/number}","notifications_url":"https://api.github.com/repos/genialis/resolwe/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/genialis/resolwe/labels{/name}","releases_url":"https://api.github.com/repos/genialis/resolwe/releases{/id}","deployments_url":"https://api.github.com/repos/genialis/resolwe/deployments","created_at":"2015-04-09T16:07:20Z","updated_at":"2018-07-03T20:54:31Z","pushed_at":"2018-07-04T08:59:42Z","git_url":"git://github.com/genialis/resolwe.git","ssh_url":"git@github.com:genialis/resolwe.git","clone_url":"https://github.com/genialis/resolwe.git","svn_url":"https://github.com/genialis/resolwe","homepage":"","size":2048,"stargazers_count":16,"watchers_count":16,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":14,"open_issues":15,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/genialis/resolwe/pulls/505"},"html":{"href":"https://github.com/genialis/resolwe/pull/505"},"issue":{"href":"https://api.github.com/repos/genialis/resolwe/issues/505"},"comments":{"href":"https://api.github.com/repos/genialis/resolwe/issues/505/comments"},"review_comments":{"href":"https://api.github.com/repos/genialis/resolwe/pulls/505/comments"},"review_comment":{"href":"https://api.github.com/repos/genialis/resolwe/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/genialis/resolwe/pulls/505/commits"},"statuses":{"href":"https://api.github.com/repos/genialis/resolwe/statuses/f221dcb12f926a86269aa65cb55a49cd72af5063"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"tjanez"}}