{"action":"created","comment":{"url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/pulls/comments/190841998","pull_request_review_id":123305575,"id":190841998,"diff_hunk":"@@ -116,8 +118,8 @@ export default ({ api, coreSagas }) => {\n         if (isUndefinedOrEqualsToZero(sourceAmount)) return defaultResult\n         const quotation = yield call(api.createQuote, sourceAmount, pair, true)\n         const targetAmount = path(['success', 'withdrawalAmount'], quotation) || 0\n-        const sourceFiat = convertCoinToFiat(sourceAmount, sourceCoin, sourceCoin, 'USD', sourceRates).value\n-        const targetFiat = convertCoinToFiat(targetAmount, targetCoin, targetCoin, 'USD', targetRates).value\n+        const sourceFiat = convertCoinToFiat(sourceAmount, sourceCoin, sourceCoin, currency, sourceRates).value\n+        const targetFiat = convertCoinToFiat(targetAmount, targetCoin, targetCoin, currency, targetRates).value\n         return { sourceAmount, sourceFiat, targetAmount, targetFiat }","path":"packages/blockchain-wallet-v4-frontend/src/data/components/exchange/sagas.utils.js","position":26,"original_position":48,"commit_id":"e9799eb53659ed3eabac406b8568708127248de8","original_commit_id":"e9799eb53659ed3eabac406b8568708127248de8","user":{"login":"Lyncee59","id":13176504,"avatar_url":"https://avatars1.githubusercontent.com/u/13176504?v=4","gravatar_id":"","url":"https://api.github.com/users/Lyncee59","html_url":"https://github.com/Lyncee59","followers_url":"https://api.github.com/users/Lyncee59/followers","following_url":"https://api.github.com/users/Lyncee59/following{/other_user}","gists_url":"https://api.github.com/users/Lyncee59/gists{/gist_id}","starred_url":"https://api.github.com/users/Lyncee59/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lyncee59/subscriptions","organizations_url":"https://api.github.com/users/Lyncee59/orgs","repos_url":"https://api.github.com/users/Lyncee59/repos","events_url":"https://api.github.com/users/Lyncee59/events{/privacy}","received_events_url":"https://api.github.com/users/Lyncee59/received_events","type":"User","site_admin":false},"body":"I never heard about the 500 limits ? does it mean we can't validate the trade if fiat amount > 500 ?","created_at":"2018-05-25T09:37:56Z","updated_at":"2018-05-25T09:37:57Z","html_url":"https://github.com/blockchain/blockchain-wallet-v4-frontend/pull/444#discussion_r190841998","pull_request_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/pulls/444","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/pulls/comments/190841998"},"html":{"href":"https://github.com/blockchain/blockchain-wallet-v4-frontend/pull/444#discussion_r190841998"},"pull_request":{"href":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/pulls/444"}},"in_reply_to_id":190687657},"pull_request":{"url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/pulls/444","id":190284977,"html_url":"https://github.com/blockchain/blockchain-wallet-v4-frontend/pull/444","diff_url":"https://github.com/blockchain/blockchain-wallet-v4-frontend/pull/444.diff","patch_url":"https://github.com/blockchain/blockchain-wallet-v4-frontend/pull/444.patch","issue_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/issues/444","number":444,"state":"open","locked":false,"title":"Feature/misc bugs 2","user":{"login":"Lyncee59","id":13176504,"avatar_url":"https://avatars1.githubusercontent.com/u/13176504?v=4","gravatar_id":"","url":"https://api.github.com/users/Lyncee59","html_url":"https://github.com/Lyncee59","followers_url":"https://api.github.com/users/Lyncee59/followers","following_url":"https://api.github.com/users/Lyncee59/following{/other_user}","gists_url":"https://api.github.com/users/Lyncee59/gists{/gist_id}","starred_url":"https://api.github.com/users/Lyncee59/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Lyncee59/subscriptions","organizations_url":"https://api.github.com/users/Lyncee59/orgs","repos_url":"https://api.github.com/users/Lyncee59/repos","events_url":"https://api.github.com/users/Lyncee59/events{/privacy}","received_events_url":"https://api.github.com/users/Lyncee59/received_events","type":"User","site_admin":false},"body":"## Description\r\nDifferent bugs fixes on exchange\r\n\r\n## Change Type\r\nPlease enter one or more of the following: \r\n- Bug fixes related to exchange\r\n\r\n## Testing Steps\r\nDetail the steps required for the reviewer(s) to verify and test these changes.\r\n\r\n## PR Creator Checklist\r\n- [x] Code compiles correctly\r\n- [ ] No lint issues exist (verified via `yarn lint`)\r\n- [ ] All unit tests pass (verified via `yarn test`)\r\n- [ ] Updated `README.md` and other documentation (if necessary)\r\n\r\n## PR Reviewer Checklist\r\n- [ ] Change validated and application spot checked\r\n- [ ] Code styles and best practices met\r\n- [ ] Code is readable and commented when necessary\r\n\r\n","created_at":"2018-05-24T13:12:43Z","updated_at":"2018-05-25T09:37:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"13bb26c100751ae95ee5c12c23dcf4aa67efc1f3","assignee":null,"assignees":[],"requested_reviewers":[{"login":"prwelber","id":12749543,"avatar_url":"https://avatars1.githubusercontent.com/u/12749543?v=4","gravatar_id":"","url":"https://api.github.com/users/prwelber","html_url":"https://github.com/prwelber","followers_url":"https://api.github.com/users/prwelber/followers","following_url":"https://api.github.com/users/prwelber/following{/other_user}","gists_url":"https://api.github.com/users/prwelber/gists{/gist_id}","starred_url":"https://api.github.com/users/prwelber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prwelber/subscriptions","organizations_url":"https://api.github.com/users/prwelber/orgs","repos_url":"https://api.github.com/users/prwelber/repos","events_url":"https://api.github.com/users/prwelber/events{/privacy}","received_events_url":"https://api.github.com/users/prwelber/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/pulls/444/commits","review_comments_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/pulls/444/comments","review_comment_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/pulls/comments{/number}","comments_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/issues/444/comments","statuses_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/statuses/e9799eb53659ed3eabac406b8568708127248de8","head":{"label":"blockchain:feature/misc-bugs-2","ref":"feature/misc-bugs-2","sha":"e9799eb53659ed3eabac406b8568708127248de8","user":{"login":"blockchain","id":1777722,"avatar_url":"https://avatars3.githubusercontent.com/u/1777722?v=4","gravatar_id":"","url":"https://api.github.com/users/blockchain","html_url":"https://github.com/blockchain","followers_url":"https://api.github.com/users/blockchain/followers","following_url":"https://api.github.com/users/blockchain/following{/other_user}","gists_url":"https://api.github.com/users/blockchain/gists{/gist_id}","starred_url":"https://api.github.com/users/blockchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blockchain/subscriptions","organizations_url":"https://api.github.com/users/blockchain/orgs","repos_url":"https://api.github.com/users/blockchain/repos","events_url":"https://api.github.com/users/blockchain/events{/privacy}","received_events_url":"https://api.github.com/users/blockchain/received_events","type":"Organization","site_admin":false},"repo":{"id":94121845,"name":"blockchain-wallet-v4-frontend","full_name":"blockchain/blockchain-wallet-v4-frontend","owner":{"login":"blockchain","id":1777722,"avatar_url":"https://avatars3.githubusercontent.com/u/1777722?v=4","gravatar_id":"","url":"https://api.github.com/users/blockchain","html_url":"https://github.com/blockchain","followers_url":"https://api.github.com/users/blockchain/followers","following_url":"https://api.github.com/users/blockchain/following{/other_user}","gists_url":"https://api.github.com/users/blockchain/gists{/gist_id}","starred_url":"https://api.github.com/users/blockchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blockchain/subscriptions","organizations_url":"https://api.github.com/users/blockchain/orgs","repos_url":"https://api.github.com/users/blockchain/repos","events_url":"https://api.github.com/users/blockchain/events{/privacy}","received_events_url":"https://api.github.com/users/blockchain/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/blockchain/blockchain-wallet-v4-frontend","description":"Next generation (pre-release) version of Blockchain Wallet built with React & Redux","fork":false,"url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend","forks_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/forks","keys_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/teams","hooks_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/hooks","issue_events_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/events","assignees_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/tags","blobs_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/languages","stargazers_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/stargazers","contributors_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/contributors","subscribers_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/subscribers","subscription_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/subscription","commits_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/merges","archive_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/downloads","issues_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/labels{/name}","releases_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/deployments","created_at":"2017-06-12T17:20:32Z","updated_at":"2018-05-24T14:59:01Z","pushed_at":"2018-05-24T20:59:16Z","git_url":"git://github.com/blockchain/blockchain-wallet-v4-frontend.git","ssh_url":"git@github.com:blockchain/blockchain-wallet-v4-frontend.git","clone_url":"https://github.com/blockchain/blockchain-wallet-v4-frontend.git","svn_url":"https://github.com/blockchain/blockchain-wallet-v4-frontend","homepage":"","size":20173,"stargazers_count":17,"watchers_count":17,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":11,"license":null,"forks":6,"open_issues":11,"watchers":17,"default_branch":"development"}},"base":{"label":"blockchain:development","ref":"development","sha":"d0244b27027b16a6cfcd2a055365d375e85c662d","user":{"login":"blockchain","id":1777722,"avatar_url":"https://avatars3.githubusercontent.com/u/1777722?v=4","gravatar_id":"","url":"https://api.github.com/users/blockchain","html_url":"https://github.com/blockchain","followers_url":"https://api.github.com/users/blockchain/followers","following_url":"https://api.github.com/users/blockchain/following{/other_user}","gists_url":"https://api.github.com/users/blockchain/gists{/gist_id}","starred_url":"https://api.github.com/users/blockchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blockchain/subscriptions","organizations_url":"https://api.github.com/users/blockchain/orgs","repos_url":"https://api.github.com/users/blockchain/repos","events_url":"https://api.github.com/users/blockchain/events{/privacy}","received_events_url":"https://api.github.com/users/blockchain/received_events","type":"Organization","site_admin":false},"repo":{"id":94121845,"name":"blockchain-wallet-v4-frontend","full_name":"blockchain/blockchain-wallet-v4-frontend","owner":{"login":"blockchain","id":1777722,"avatar_url":"https://avatars3.githubusercontent.com/u/1777722?v=4","gravatar_id":"","url":"https://api.github.com/users/blockchain","html_url":"https://github.com/blockchain","followers_url":"https://api.github.com/users/blockchain/followers","following_url":"https://api.github.com/users/blockchain/following{/other_user}","gists_url":"https://api.github.com/users/blockchain/gists{/gist_id}","starred_url":"https://api.github.com/users/blockchain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blockchain/subscriptions","organizations_url":"https://api.github.com/users/blockchain/orgs","repos_url":"https://api.github.com/users/blockchain/repos","events_url":"https://api.github.com/users/blockchain/events{/privacy}","received_events_url":"https://api.github.com/users/blockchain/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/blockchain/blockchain-wallet-v4-frontend","description":"Next generation (pre-release) version of Blockchain Wallet built with React & Redux","fork":false,"url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend","forks_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/forks","keys_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/teams","hooks_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/hooks","issue_events_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/issues/events{/number}","events_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/events","assignees_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/assignees{/user}","branches_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/branches{/branch}","tags_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/tags","blobs_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/git/refs{/sha}","trees_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/statuses/{sha}","languages_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/languages","stargazers_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/stargazers","contributors_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/contributors","subscribers_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/subscribers","subscription_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/subscription","commits_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/commits{/sha}","git_commits_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/git/commits{/sha}","comments_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/comments{/number}","issue_comment_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/issues/comments{/number}","contents_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/contents/{+path}","compare_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/merges","archive_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/downloads","issues_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/issues{/number}","pulls_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/pulls{/number}","milestones_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/milestones{/number}","notifications_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/labels{/name}","releases_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/releases{/id}","deployments_url":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/deployments","created_at":"2017-06-12T17:20:32Z","updated_at":"2018-05-24T14:59:01Z","pushed_at":"2018-05-24T20:59:16Z","git_url":"git://github.com/blockchain/blockchain-wallet-v4-frontend.git","ssh_url":"git@github.com:blockchain/blockchain-wallet-v4-frontend.git","clone_url":"https://github.com/blockchain/blockchain-wallet-v4-frontend.git","svn_url":"https://github.com/blockchain/blockchain-wallet-v4-frontend","homepage":"","size":20173,"stargazers_count":17,"watchers_count":17,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":11,"license":null,"forks":6,"open_issues":11,"watchers":17,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/pulls/444"},"html":{"href":"https://github.com/blockchain/blockchain-wallet-v4-frontend/pull/444"},"issue":{"href":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/issues/444"},"comments":{"href":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/issues/444/comments"},"review_comments":{"href":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/pulls/444/comments"},"review_comment":{"href":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/pulls/444/commits"},"statuses":{"href":"https://api.github.com/repos/blockchain/blockchain-wallet-v4-frontend/statuses/e9799eb53659ed3eabac406b8568708127248de8"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"Lyncee59"}}