{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/3521","repository_url":"https://api.github.com/repos/kubernetes/ingress-nginx","labels_url":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/3521/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/3521/comments","events_url":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/3521/events","html_url":"https://github.com/kubernetes/ingress-nginx/pull/3521","id":387815647,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2MjIwNzQ3","number":3521,"title":"Fix a bug with Canary becoming main server","user":{"login":"wayt","id":2571010,"node_id":"MDQ6VXNlcjI1NzEwMTA=","avatar_url":"https://avatars0.githubusercontent.com/u/2571010?v=4","gravatar_id":"","url":"https://api.github.com/users/wayt","html_url":"https://github.com/wayt","followers_url":"https://api.github.com/users/wayt/followers","following_url":"https://api.github.com/users/wayt/following{/other_user}","gists_url":"https://api.github.com/users/wayt/gists{/gist_id}","starred_url":"https://api.github.com/users/wayt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wayt/subscriptions","organizations_url":"https://api.github.com/users/wayt/orgs","repos_url":"https://api.github.com/users/wayt/repos","events_url":"https://api.github.com/users/wayt/events{/privacy}","received_events_url":"https://api.github.com/users/wayt/received_events","type":"User","site_admin":false},"labels":[{"id":486873161,"node_id":"MDU6TGFiZWw0ODY4NzMxNjE=","url":"https://api.github.com/repos/kubernetes/ingress-nginx/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":486994237,"node_id":"MDU6TGFiZWw0ODY5OTQyMzc=","url":"https://api.github.com/repos/kubernetes/ingress-nginx/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":676097629,"node_id":"MDU6TGFiZWw2NzYwOTc2Mjk=","url":"https://api.github.com/repos/kubernetes/ingress-nginx/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":{"login":"ElvinEfendi","id":1150042,"node_id":"MDQ6VXNlcjExNTAwNDI=","avatar_url":"https://avatars0.githubusercontent.com/u/1150042?v=4","gravatar_id":"","url":"https://api.github.com/users/ElvinEfendi","html_url":"https://github.com/ElvinEfendi","followers_url":"https://api.github.com/users/ElvinEfendi/followers","following_url":"https://api.github.com/users/ElvinEfendi/following{/other_user}","gists_url":"https://api.github.com/users/ElvinEfendi/gists{/gist_id}","starred_url":"https://api.github.com/users/ElvinEfendi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElvinEfendi/subscriptions","organizations_url":"https://api.github.com/users/ElvinEfendi/orgs","repos_url":"https://api.github.com/users/ElvinEfendi/repos","events_url":"https://api.github.com/users/ElvinEfendi/events{/privacy}","received_events_url":"https://api.github.com/users/ElvinEfendi/received_events","type":"User","site_admin":false},"assignees":[{"login":"ElvinEfendi","id":1150042,"node_id":"MDQ6VXNlcjExNTAwNDI=","avatar_url":"https://avatars0.githubusercontent.com/u/1150042?v=4","gravatar_id":"","url":"https://api.github.com/users/ElvinEfendi","html_url":"https://github.com/ElvinEfendi","followers_url":"https://api.github.com/users/ElvinEfendi/followers","following_url":"https://api.github.com/users/ElvinEfendi/following{/other_user}","gists_url":"https://api.github.com/users/ElvinEfendi/gists{/gist_id}","starred_url":"https://api.github.com/users/ElvinEfendi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElvinEfendi/subscriptions","organizations_url":"https://api.github.com/users/ElvinEfendi/orgs","repos_url":"https://api.github.com/users/ElvinEfendi/repos","events_url":"https://api.github.com/users/ElvinEfendi/events{/privacy}","received_events_url":"https://api.github.com/users/ElvinEfendi/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2018-12-05T15:40:12Z","updated_at":"2018-12-06T16:43:30Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kubernetes/ingress-nginx/pulls/3521","html_url":"https://github.com/kubernetes/ingress-nginx/pull/3521","diff_url":"https://github.com/kubernetes/ingress-nginx/pull/3521.diff","patch_url":"https://github.com/kubernetes/ingress-nginx/pull/3521.patch"},"body":"**What this PR does / why we need it**:\r\n\r\nA canary `Ingress` should never become a catch-all server if no other `Ingress` is a catch-all.\r\n\r\nThis PR prevent canary `Ingress` from becoming a catch-all server, or a server with a domain name if no regular `Ingress` is present.\r\n\r\n**Which issue this PR fixes**\r\n\r\n**Special notes for your reviewer**:\r\n\r\nCc @ElvinEfendi @clandry94 "},"comment":{"url":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/comments/444940599","html_url":"https://github.com/kubernetes/ingress-nginx/pull/3521#issuecomment-444940599","issue_url":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/3521","id":444940599,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NDk0MDU5OQ==","user":{"login":"ElvinEfendi","id":1150042,"node_id":"MDQ6VXNlcjExNTAwNDI=","avatar_url":"https://avatars0.githubusercontent.com/u/1150042?v=4","gravatar_id":"","url":"https://api.github.com/users/ElvinEfendi","html_url":"https://github.com/ElvinEfendi","followers_url":"https://api.github.com/users/ElvinEfendi/followers","following_url":"https://api.github.com/users/ElvinEfendi/following{/other_user}","gists_url":"https://api.github.com/users/ElvinEfendi/gists{/gist_id}","starred_url":"https://api.github.com/users/ElvinEfendi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElvinEfendi/subscriptions","organizations_url":"https://api.github.com/users/ElvinEfendi/orgs","repos_url":"https://api.github.com/users/ElvinEfendi/repos","events_url":"https://api.github.com/users/ElvinEfendi/events{/privacy}","received_events_url":"https://api.github.com/users/ElvinEfendi/received_events","type":"User","site_admin":false},"created_at":"2018-12-06T16:43:30Z","updated_at":"2018-12-06T16:43:30Z","author_association":"MEMBER","body":"/hold\r\n\r\nwill wait for @clandry94 to 👍 first\r\n\r\nfor me LGTM"}}
{"actor":{"display_login":"ElvinEfendi"}}