{"action":"created","comment":{"url":"https://api.github.com/repos/EasyRPG/Player/pulls/comments/228716035","pull_request_review_id":169058847,"id":228716035,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODcxNjAzNQ==","diff_hunk":"@@ -102,9 +102,7 @@ void Scene_Battle_Rpg2k::CreateBattleCommandWindow() {\n }\n \n void Scene_Battle_Rpg2k::RefreshCommandWindow() {\n-\tstd::string skill_name = active_actor->GetSkillName();\n-\tcommand_window->SetItemText(1,","path":"src/scene_battle_rpg2k.cpp","position":5,"original_position":5,"commit_id":"43c232b6305540d884db5b7162c1a01767327525","original_commit_id":"3695bfc5a2f5d91b182d205ca9488f97ccc431db","user":{"login":"fmatthew5876","id":1198466,"node_id":"MDQ6VXNlcjExOTg0NjY=","avatar_url":"https://avatars1.githubusercontent.com/u/1198466?v=4","gravatar_id":"","url":"https://api.github.com/users/fmatthew5876","html_url":"https://github.com/fmatthew5876","followers_url":"https://api.github.com/users/fmatthew5876/followers","following_url":"https://api.github.com/users/fmatthew5876/following{/other_user}","gists_url":"https://api.github.com/users/fmatthew5876/gists{/gist_id}","starred_url":"https://api.github.com/users/fmatthew5876/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fmatthew5876/subscriptions","organizations_url":"https://api.github.com/users/fmatthew5876/orgs","repos_url":"https://api.github.com/users/fmatthew5876/repos","events_url":"https://api.github.com/users/fmatthew5876/events{/privacy}","received_events_url":"https://api.github.com/users/fmatthew5876/received_events","type":"User","site_admin":false},"body":"I think that makes sense. From Player perspective there is only 1 skill name. The renaming stuff is a liblcf detail.","created_at":"2018-10-27T15:10:35Z","updated_at":"2018-10-27T15:10:35Z","html_url":"https://github.com/EasyRPG/Player/pull/1447#discussion_r228716035","pull_request_url":"https://api.github.com/repos/EasyRPG/Player/pulls/1447","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/EasyRPG/Player/pulls/comments/228716035"},"html":{"href":"https://github.com/EasyRPG/Player/pull/1447#discussion_r228716035"},"pull_request":{"href":"https://api.github.com/repos/EasyRPG/Player/pulls/1447"}},"in_reply_to_id":228715742},"pull_request":{"url":"https://api.github.com/repos/EasyRPG/Player/pulls/1447","id":222741066,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNzQxMDY2","html_url":"https://github.com/EasyRPG/Player/pull/1447","diff_url":"https://github.com/EasyRPG/Player/pull/1447.diff","patch_url":"https://github.com/EasyRPG/Player/pull/1447.patch","issue_url":"https://api.github.com/repos/EasyRPG/Player/issues/1447","number":1447,"state":"open","locked":false,"title":"Albeleons's Battle fixes 1 of N","user":{"login":"fmatthew5876","id":1198466,"node_id":"MDQ6VXNlcjExOTg0NjY=","avatar_url":"https://avatars1.githubusercontent.com/u/1198466?v=4","gravatar_id":"","url":"https://api.github.com/users/fmatthew5876","html_url":"https://github.com/fmatthew5876","followers_url":"https://api.github.com/users/fmatthew5876/followers","following_url":"https://api.github.com/users/fmatthew5876/following{/other_user}","gists_url":"https://api.github.com/users/fmatthew5876/gists{/gist_id}","starred_url":"https://api.github.com/users/fmatthew5876/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fmatthew5876/subscriptions","organizations_url":"https://api.github.com/users/fmatthew5876/orgs","repos_url":"https://api.github.com/users/fmatthew5876/repos","events_url":"https://api.github.com/users/fmatthew5876/events{/privacy}","received_events_url":"https://api.github.com/users/fmatthew5876/received_events","type":"User","site_admin":false},"body":"Here is the first batch of rebased fixes from #1373\r\n\r\nAll of these are pretty simple changes so I'm making a first PR with these. They are not all in the same order as originally presented. I'm trying to pull out the ones that are simple and don't require a lot of merging so they can be quickly reviewed and merged into master.\r\n\r\nChanges made:\r\n * ~~2.7 - Using `Player::escape_char` instead of `\"\\\\\"`~~\r\n * ~~4.1 - `Battle_BGM` was moved earlier so don't play it twice.~~\r\n * 2.15 - Added back `const`\r\n\r\nThese alone fix some issues from #1418 and #985","created_at":"2018-10-14T20:31:00Z","updated_at":"2018-10-27T15:10:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0930eb60556a5601fc18415ada10b572ae5f430b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/EasyRPG/Player/pulls/1447/commits","review_comments_url":"https://api.github.com/repos/EasyRPG/Player/pulls/1447/comments","review_comment_url":"https://api.github.com/repos/EasyRPG/Player/pulls/comments{/number}","comments_url":"https://api.github.com/repos/EasyRPG/Player/issues/1447/comments","statuses_url":"https://api.github.com/repos/EasyRPG/Player/statuses/43c232b6305540d884db5b7162c1a01767327525","head":{"label":"fmatthew5876:albeleon_battle_1","ref":"albeleon_battle_1","sha":"43c232b6305540d884db5b7162c1a01767327525","user":{"login":"fmatthew5876","id":1198466,"node_id":"MDQ6VXNlcjExOTg0NjY=","avatar_url":"https://avatars1.githubusercontent.com/u/1198466?v=4","gravatar_id":"","url":"https://api.github.com/users/fmatthew5876","html_url":"https://github.com/fmatthew5876","followers_url":"https://api.github.com/users/fmatthew5876/followers","following_url":"https://api.github.com/users/fmatthew5876/following{/other_user}","gists_url":"https://api.github.com/users/fmatthew5876/gists{/gist_id}","starred_url":"https://api.github.com/users/fmatthew5876/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fmatthew5876/subscriptions","organizations_url":"https://api.github.com/users/fmatthew5876/orgs","repos_url":"https://api.github.com/users/fmatthew5876/repos","events_url":"https://api.github.com/users/fmatthew5876/events{/privacy}","received_events_url":"https://api.github.com/users/fmatthew5876/received_events","type":"User","site_admin":false},"repo":{"id":149674899,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk2NzQ4OTk=","name":"Player","full_name":"fmatthew5876/Player","private":false,"owner":{"login":"fmatthew5876","id":1198466,"node_id":"MDQ6VXNlcjExOTg0NjY=","avatar_url":"https://avatars1.githubusercontent.com/u/1198466?v=4","gravatar_id":"","url":"https://api.github.com/users/fmatthew5876","html_url":"https://github.com/fmatthew5876","followers_url":"https://api.github.com/users/fmatthew5876/followers","following_url":"https://api.github.com/users/fmatthew5876/following{/other_user}","gists_url":"https://api.github.com/users/fmatthew5876/gists{/gist_id}","starred_url":"https://api.github.com/users/fmatthew5876/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fmatthew5876/subscriptions","organizations_url":"https://api.github.com/users/fmatthew5876/orgs","repos_url":"https://api.github.com/users/fmatthew5876/repos","events_url":"https://api.github.com/users/fmatthew5876/events{/privacy}","received_events_url":"https://api.github.com/users/fmatthew5876/received_events","type":"User","site_admin":false},"html_url":"https://github.com/fmatthew5876/Player","description":"RPG Maker 2000/2003 and EasyRPG games interpreter","fork":true,"url":"https://api.github.com/repos/fmatthew5876/Player","forks_url":"https://api.github.com/repos/fmatthew5876/Player/forks","keys_url":"https://api.github.com/repos/fmatthew5876/Player/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fmatthew5876/Player/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fmatthew5876/Player/teams","hooks_url":"https://api.github.com/repos/fmatthew5876/Player/hooks","issue_events_url":"https://api.github.com/repos/fmatthew5876/Player/issues/events{/number}","events_url":"https://api.github.com/repos/fmatthew5876/Player/events","assignees_url":"https://api.github.com/repos/fmatthew5876/Player/assignees{/user}","branches_url":"https://api.github.com/repos/fmatthew5876/Player/branches{/branch}","tags_url":"https://api.github.com/repos/fmatthew5876/Player/tags","blobs_url":"https://api.github.com/repos/fmatthew5876/Player/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fmatthew5876/Player/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fmatthew5876/Player/git/refs{/sha}","trees_url":"https://api.github.com/repos/fmatthew5876/Player/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fmatthew5876/Player/statuses/{sha}","languages_url":"https://api.github.com/repos/fmatthew5876/Player/languages","stargazers_url":"https://api.github.com/repos/fmatthew5876/Player/stargazers","contributors_url":"https://api.github.com/repos/fmatthew5876/Player/contributors","subscribers_url":"https://api.github.com/repos/fmatthew5876/Player/subscribers","subscription_url":"https://api.github.com/repos/fmatthew5876/Player/subscription","commits_url":"https://api.github.com/repos/fmatthew5876/Player/commits{/sha}","git_commits_url":"https://api.github.com/repos/fmatthew5876/Player/git/commits{/sha}","comments_url":"https://api.github.com/repos/fmatthew5876/Player/comments{/number}","issue_comment_url":"https://api.github.com/repos/fmatthew5876/Player/issues/comments{/number}","contents_url":"https://api.github.com/repos/fmatthew5876/Player/contents/{+path}","compare_url":"https://api.github.com/repos/fmatthew5876/Player/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fmatthew5876/Player/merges","archive_url":"https://api.github.com/repos/fmatthew5876/Player/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fmatthew5876/Player/downloads","issues_url":"https://api.github.com/repos/fmatthew5876/Player/issues{/number}","pulls_url":"https://api.github.com/repos/fmatthew5876/Player/pulls{/number}","milestones_url":"https://api.github.com/repos/fmatthew5876/Player/milestones{/number}","notifications_url":"https://api.github.com/repos/fmatthew5876/Player/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fmatthew5876/Player/labels{/name}","releases_url":"https://api.github.com/repos/fmatthew5876/Player/releases{/id}","deployments_url":"https://api.github.com/repos/fmatthew5876/Player/deployments","created_at":"2018-09-20T21:52:44Z","updated_at":"2018-10-27T14:52:30Z","pushed_at":"2018-10-27T14:56:13Z","git_url":"git://github.com/fmatthew5876/Player.git","ssh_url":"git@github.com:fmatthew5876/Player.git","clone_url":"https://github.com/fmatthew5876/Player.git","svn_url":"https://github.com/fmatthew5876/Player","homepage":"https://easyrpg.org/player/","size":30328,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"EasyRPG:master","ref":"master","sha":"30670c2bdefe8e102953ffaecd41946c7ebd9720","user":{"login":"EasyRPG","id":1331871,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzE4NzE=","avatar_url":"https://avatars0.githubusercontent.com/u/1331871?v=4","gravatar_id":"","url":"https://api.github.com/users/EasyRPG","html_url":"https://github.com/EasyRPG","followers_url":"https://api.github.com/users/EasyRPG/followers","following_url":"https://api.github.com/users/EasyRPG/following{/other_user}","gists_url":"https://api.github.com/users/EasyRPG/gists{/gist_id}","starred_url":"https://api.github.com/users/EasyRPG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EasyRPG/subscriptions","organizations_url":"https://api.github.com/users/EasyRPG/orgs","repos_url":"https://api.github.com/users/EasyRPG/repos","events_url":"https://api.github.com/users/EasyRPG/events{/privacy}","received_events_url":"https://api.github.com/users/EasyRPG/received_events","type":"Organization","site_admin":false},"repo":{"id":3297519,"node_id":"MDEwOlJlcG9zaXRvcnkzMjk3NTE5","name":"Player","full_name":"EasyRPG/Player","private":false,"owner":{"login":"EasyRPG","id":1331871,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzE4NzE=","avatar_url":"https://avatars0.githubusercontent.com/u/1331871?v=4","gravatar_id":"","url":"https://api.github.com/users/EasyRPG","html_url":"https://github.com/EasyRPG","followers_url":"https://api.github.com/users/EasyRPG/followers","following_url":"https://api.github.com/users/EasyRPG/following{/other_user}","gists_url":"https://api.github.com/users/EasyRPG/gists{/gist_id}","starred_url":"https://api.github.com/users/EasyRPG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EasyRPG/subscriptions","organizations_url":"https://api.github.com/users/EasyRPG/orgs","repos_url":"https://api.github.com/users/EasyRPG/repos","events_url":"https://api.github.com/users/EasyRPG/events{/privacy}","received_events_url":"https://api.github.com/users/EasyRPG/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/EasyRPG/Player","description":"RPG Maker 2000/2003 and EasyRPG games interpreter","fork":false,"url":"https://api.github.com/repos/EasyRPG/Player","forks_url":"https://api.github.com/repos/EasyRPG/Player/forks","keys_url":"https://api.github.com/repos/EasyRPG/Player/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EasyRPG/Player/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EasyRPG/Player/teams","hooks_url":"https://api.github.com/repos/EasyRPG/Player/hooks","issue_events_url":"https://api.github.com/repos/EasyRPG/Player/issues/events{/number}","events_url":"https://api.github.com/repos/EasyRPG/Player/events","assignees_url":"https://api.github.com/repos/EasyRPG/Player/assignees{/user}","branches_url":"https://api.github.com/repos/EasyRPG/Player/branches{/branch}","tags_url":"https://api.github.com/repos/EasyRPG/Player/tags","blobs_url":"https://api.github.com/repos/EasyRPG/Player/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EasyRPG/Player/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EasyRPG/Player/git/refs{/sha}","trees_url":"https://api.github.com/repos/EasyRPG/Player/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EasyRPG/Player/statuses/{sha}","languages_url":"https://api.github.com/repos/EasyRPG/Player/languages","stargazers_url":"https://api.github.com/repos/EasyRPG/Player/stargazers","contributors_url":"https://api.github.com/repos/EasyRPG/Player/contributors","subscribers_url":"https://api.github.com/repos/EasyRPG/Player/subscribers","subscription_url":"https://api.github.com/repos/EasyRPG/Player/subscription","commits_url":"https://api.github.com/repos/EasyRPG/Player/commits{/sha}","git_commits_url":"https://api.github.com/repos/EasyRPG/Player/git/commits{/sha}","comments_url":"https://api.github.com/repos/EasyRPG/Player/comments{/number}","issue_comment_url":"https://api.github.com/repos/EasyRPG/Player/issues/comments{/number}","contents_url":"https://api.github.com/repos/EasyRPG/Player/contents/{+path}","compare_url":"https://api.github.com/repos/EasyRPG/Player/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EasyRPG/Player/merges","archive_url":"https://api.github.com/repos/EasyRPG/Player/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EasyRPG/Player/downloads","issues_url":"https://api.github.com/repos/EasyRPG/Player/issues{/number}","pulls_url":"https://api.github.com/repos/EasyRPG/Player/pulls{/number}","milestones_url":"https://api.github.com/repos/EasyRPG/Player/milestones{/number}","notifications_url":"https://api.github.com/repos/EasyRPG/Player/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EasyRPG/Player/labels{/name}","releases_url":"https://api.github.com/repos/EasyRPG/Player/releases{/id}","deployments_url":"https://api.github.com/repos/EasyRPG/Player/deployments","created_at":"2012-01-29T14:35:47Z","updated_at":"2018-10-27T14:44:15Z","pushed_at":"2018-10-27T14:54:49Z","git_url":"git://github.com/EasyRPG/Player.git","ssh_url":"git@github.com:EasyRPG/Player.git","clone_url":"https://github.com/EasyRPG/Player.git","svn_url":"https://github.com/EasyRPG/Player","homepage":"https://easyrpg.org/player/","size":29990,"stargazers_count":332,"watchers_count":332,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":78,"mirror_url":null,"archived":false,"open_issues_count":189,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":78,"open_issues":189,"watchers":332,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/EasyRPG/Player/pulls/1447"},"html":{"href":"https://github.com/EasyRPG/Player/pull/1447"},"issue":{"href":"https://api.github.com/repos/EasyRPG/Player/issues/1447"},"comments":{"href":"https://api.github.com/repos/EasyRPG/Player/issues/1447/comments"},"review_comments":{"href":"https://api.github.com/repos/EasyRPG/Player/pulls/1447/comments"},"review_comment":{"href":"https://api.github.com/repos/EasyRPG/Player/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/EasyRPG/Player/pulls/1447/commits"},"statuses":{"href":"https://api.github.com/repos/EasyRPG/Player/statuses/43c232b6305540d884db5b7162c1a01767327525"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"fmatthew5876"}}