{"action":"created","issue":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/30289","repository_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/30289/labels{/name}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/30289/comments","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/30289/events","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/30289","id":377582257,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4NDkxMTUx","number":30289,"title":"Enhance echarts options definition","user":{"login":"iRON5","id":13545665,"node_id":"MDQ6VXNlcjEzNTQ1NjY1","avatar_url":"https://avatars1.githubusercontent.com/u/13545665?v=4","gravatar_id":"","url":"https://api.github.com/users/iRON5","html_url":"https://github.com/iRON5","followers_url":"https://api.github.com/users/iRON5/followers","following_url":"https://api.github.com/users/iRON5/following{/other_user}","gists_url":"https://api.github.com/users/iRON5/gists{/gist_id}","starred_url":"https://api.github.com/users/iRON5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iRON5/subscriptions","organizations_url":"https://api.github.com/users/iRON5/orgs","repos_url":"https://api.github.com/users/iRON5/repos","events_url":"https://api.github.com/users/iRON5/events{/privacy}","received_events_url":"https://api.github.com/users/iRON5/received_events","type":"User","site_admin":false},"labels":[{"id":646788888,"node_id":"MDU6TGFiZWw2NDY3ODg4ODg=","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/New%20Definition","name":"New Definition","color":"4eca56","default":false},{"id":395679059,"node_id":"MDU6TGFiZWwzOTU2NzkwNTk=","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Revision%20needed","name":"Revision needed","color":"b60205","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-11-05T21:05:56Z","updated_at":"2018-11-15T02:45:29Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/30289","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/30289","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/30289.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/30289.patch"},"body":"Types were defined using [official documentation](https://ecomfe.github.io/echarts-doc/public/en/option.html#title).\r\n\r\nDefinitions for tooltip and axis were created manually according to the documentation and [source code](https://github.com/apache/incubator-echarts/tree/master/src).\r\n\r\nAdded part of [zrender library](https://github.com/ecomfe/zrender) as it is a dependency for echarts library.\r\n\r\nDefinitions for `series` option were generated automaticaly according to mentioned documentation using following [generator](https://github.com/iRON5/echarts-ts-describer). These definitions are too massive so they are split to several files to be able normally edit and review them.\r\n\r\nAlso these definitions could lead to some breaks for users because they were written by official documentation that contain mistakes.\r\nSo `npm` major version should be raised for `@types/echarts` package.\r\n\r\nVSCode local history plugin was added to ignore."},"comment":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments/438896787","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/30289#issuecomment-438896787","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/30289","id":438896787,"node_id":"MDEyOklzc3VlQ29tbWVudDQzODg5Njc4Nw==","user":{"login":"Ovilia","id":779050,"node_id":"MDQ6VXNlcjc3OTA1MA==","avatar_url":"https://avatars3.githubusercontent.com/u/779050?v=4","gravatar_id":"","url":"https://api.github.com/users/Ovilia","html_url":"https://github.com/Ovilia","followers_url":"https://api.github.com/users/Ovilia/followers","following_url":"https://api.github.com/users/Ovilia/following{/other_user}","gists_url":"https://api.github.com/users/Ovilia/gists{/gist_id}","starred_url":"https://api.github.com/users/Ovilia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ovilia/subscriptions","organizations_url":"https://api.github.com/users/Ovilia/orgs","repos_url":"https://api.github.com/users/Ovilia/repos","events_url":"https://api.github.com/users/Ovilia/events{/privacy}","received_events_url":"https://api.github.com/users/Ovilia/received_events","type":"User","site_admin":false},"created_at":"2018-11-15T02:45:29Z","updated_at":"2018-11-15T02:45:29Z","author_association":"CONTRIBUTOR","body":"@iRON5 It looks all right. But seems there's too much code to review, and my browser just get not responding when opening the code. So I'd suggest we merge it first and may fix the problems after we found one."}}
{"actor":{"display_login":"Ovilia"}}