{"action":"created","issue":{"url":"https://api.github.com/repos/eerimoq/cantools/issues/40","repository_url":"https://api.github.com/repos/eerimoq/cantools","labels_url":"https://api.github.com/repos/eerimoq/cantools/issues/40/labels{/name}","comments_url":"https://api.github.com/repos/eerimoq/cantools/issues/40/comments","events_url":"https://api.github.com/repos/eerimoq/cantools/issues/40/events","html_url":"https://github.com/eerimoq/cantools/pull/40","id":331544867,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MjQ2Nzg3","number":40,"title":"Added signal, message and node level attributes. ","user":{"login":"juleq","id":1632707,"node_id":"MDQ6VXNlcjE2MzI3MDc=","avatar_url":"https://avatars2.githubusercontent.com/u/1632707?v=4","gravatar_id":"","url":"https://api.github.com/users/juleq","html_url":"https://github.com/juleq","followers_url":"https://api.github.com/users/juleq/followers","following_url":"https://api.github.com/users/juleq/following{/other_user}","gists_url":"https://api.github.com/users/juleq/gists{/gist_id}","starred_url":"https://api.github.com/users/juleq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juleq/subscriptions","organizations_url":"https://api.github.com/users/juleq/orgs","repos_url":"https://api.github.com/users/juleq/repos","events_url":"https://api.github.com/users/juleq/events{/privacy}","received_events_url":"https://api.github.com/users/juleq/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":20,"created_at":"2018-06-12T11:19:23Z","updated_at":"2018-06-18T06:51:54Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/eerimoq/cantools/pulls/40","html_url":"https://github.com/eerimoq/cantools/pull/40","diff_url":"https://github.com/eerimoq/cantools/pull/40.diff","patch_url":"https://github.com/eerimoq/cantools/pull/40.patch"},"body":"Changed whitespace handling and had to do minor whitespace tweaks to existing test files. \r\nCorrected minor quirks such as \"Vector_XXX\" is not a valid node name. CANdb will remove it. \r\nOr: Standard CAN ids outside of the 11bit range. CANdb++ will not accept that.\r\n\r\nSorry for putting all of that in one commit. "},"comment":{"url":"https://api.github.com/repos/eerimoq/cantools/issues/comments/397958042","html_url":"https://github.com/eerimoq/cantools/pull/40#issuecomment-397958042","issue_url":"https://api.github.com/repos/eerimoq/cantools/issues/40","id":397958042,"node_id":"MDEyOklzc3VlQ29tbWVudDM5Nzk1ODA0Mg==","user":{"login":"juleq","id":1632707,"node_id":"MDQ6VXNlcjE2MzI3MDc=","avatar_url":"https://avatars2.githubusercontent.com/u/1632707?v=4","gravatar_id":"","url":"https://api.github.com/users/juleq","html_url":"https://github.com/juleq","followers_url":"https://api.github.com/users/juleq/followers","following_url":"https://api.github.com/users/juleq/following{/other_user}","gists_url":"https://api.github.com/users/juleq/gists{/gist_id}","starred_url":"https://api.github.com/users/juleq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juleq/subscriptions","organizations_url":"https://api.github.com/users/juleq/orgs","repos_url":"https://api.github.com/users/juleq/repos","events_url":"https://api.github.com/users/juleq/events{/privacy}","received_events_url":"https://api.github.com/users/juleq/received_events","type":"User","site_admin":false},"created_at":"2018-06-18T06:51:54Z","updated_at":"2018-06-18T06:51:54Z","author_association":"CONTRIBUTOR","body":"I am not sure about the policy regarding blank lines: I have identified so far:\r\n\r\n- After local variable definition\r\n- Before and after if statements\r\n- Before return\r\n\r\nI would further assume the following, but your feedback said otherwise:\r\n- Before and after local functions\r\n- Before and after for if it enhances readability or separates groups ( e.g. iterating nodes/messages/signals for the same purpose)\r\n\r\nCould you clarify? Thanks."}}
{"actor":{"display_login":"juleq"}}