{"action":"created","comment":{"url":"https://api.github.com/repos/molgenis/molgenis/pulls/comments/192100134","pull_request_review_id":124805502,"id":192100134,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjEwMDEzNA==","diff_hunk":"@@ -140,28 +179,90 @@ public void testServeAppInactiveApp() throws Exception\n \n \t\tAppResponse appResponse = AppResponse.create(app);\n \t\twhen(appManagerService.getAppByUri(\"uri\")).thenReturn(appResponse);\n-\t\tString expectedMessage = \"\";\n-\t\ttry\n-\t\t{\n-\t\t\tmockMvc.perform(get(AppController.URI + \"/uri/\")).andExpect(status().is4xxClientError());\n-\t\t}\n-\t\tcatch (Exception e)\n-\t\t{\n-\t\t\texpectedMessage = e.getCause().getMessage();\n-\t\t}\n-\t\tfinally\n-\t\t{\n-\t\t\tassertEquals(expectedMessage, \"uri:uri\");\n-\t\t}\n+\n+\t\tmockMvc.perform(get(AppController.URI + \"/uri/\"))\n+\t\t\t   .andExpect(status().is4xxClientError())\n+\t\t\t   .andExpect(model().attribute(\"errorMessageResponse\",\n+\t\t\t\t\t   ErrorMessageResponse.create(\"Access denied for inactive app at location /app/uri\", \"AM07\")))","path":"molgenis-app-manager/src/test/java/org/molgenis/app/manager/controller/AppControllerTest.java","position":186,"original_position":186,"commit_id":"7e7e3f0c5405255a42f340018136d7b228c21bba","original_commit_id":"7e7e3f0c5405255a42f340018136d7b228c21bba","user":{"login":"fdlk","id":1523838,"node_id":"MDQ6VXNlcjE1MjM4Mzg=","avatar_url":"https://avatars2.githubusercontent.com/u/1523838?v=4","gravatar_id":"","url":"https://api.github.com/users/fdlk","html_url":"https://github.com/fdlk","followers_url":"https://api.github.com/users/fdlk/followers","following_url":"https://api.github.com/users/fdlk/following{/other_user}","gists_url":"https://api.github.com/users/fdlk/gists{/gist_id}","starred_url":"https://api.github.com/users/fdlk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fdlk/subscriptions","organizations_url":"https://api.github.com/users/fdlk/orgs","repos_url":"https://api.github.com/users/fdlk/repos","events_url":"https://api.github.com/users/fdlk/events{/privacy}","received_events_url":"https://api.github.com/users/fdlk/received_events","type":"User","site_admin":false},"body":"I'd expect the style to match other exception messages, i.e.\r\n> Access denied for inactive app at location '/app/uri'.\r\n\r\n(But the PR doesn't contain this message.)\r\n","created_at":"2018-05-31T13:34:02Z","updated_at":"2018-05-31T13:41:12Z","html_url":"https://github.com/molgenis/molgenis/pull/7392#discussion_r192100134","pull_request_url":"https://api.github.com/repos/molgenis/molgenis/pulls/7392","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/molgenis/molgenis/pulls/comments/192100134"},"html":{"href":"https://github.com/molgenis/molgenis/pull/7392#discussion_r192100134"},"pull_request":{"href":"https://api.github.com/repos/molgenis/molgenis/pulls/7392"}}},"pull_request":{"url":"https://api.github.com/repos/molgenis/molgenis/pulls/7392","id":191475432,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNDc1NDMy","html_url":"https://github.com/molgenis/molgenis/pull/7392","diff_url":"https://github.com/molgenis/molgenis/pull/7392.diff","patch_url":"https://github.com/molgenis/molgenis/pull/7392.patch","issue_url":"https://api.github.com/repos/molgenis/molgenis/issues/7392","number":7392,"state":"open","locked":false,"title":"[FEATURE] synchronize plugin permissions with App Manager ","user":{"login":"sidohaakma","id":27900092,"node_id":"MDQ6VXNlcjI3OTAwMDky","avatar_url":"https://avatars2.githubusercontent.com/u/27900092?v=4","gravatar_id":"","url":"https://api.github.com/users/sidohaakma","html_url":"https://github.com/sidohaakma","followers_url":"https://api.github.com/users/sidohaakma/followers","following_url":"https://api.github.com/users/sidohaakma/following{/other_user}","gists_url":"https://api.github.com/users/sidohaakma/gists{/gist_id}","starred_url":"https://api.github.com/users/sidohaakma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sidohaakma/subscriptions","organizations_url":"https://api.github.com/users/sidohaakma/orgs","repos_url":"https://api.github.com/users/sidohaakma/repos","events_url":"https://api.github.com/users/sidohaakma/events{/privacy}","received_events_url":"https://api.github.com/users/sidohaakma/received_events","type":"User","site_admin":false},"body":"#### Checklist\r\n- [ ] Functionality works & meets specifications\r\n- [ ] Code reviewed\r\n- [ ] Code unit/integration/system tested\r\n- [ ] User documentation updated\r\n- [ ] (If you have changed REST API interface) view-swagger.ftl updated\r\n- [ ] Test plan template updated\r\n- [ ] Clean commits\r\n- [ ] Added Feature/Fix to release notes\r\n","created_at":"2018-05-30T14:35:43Z","updated_at":"2018-05-31T13:41:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d120f23aae1f42b5657b17b7634c818c85c14d8d","assignee":{"login":"fdlk","id":1523838,"node_id":"MDQ6VXNlcjE1MjM4Mzg=","avatar_url":"https://avatars2.githubusercontent.com/u/1523838?v=4","gravatar_id":"","url":"https://api.github.com/users/fdlk","html_url":"https://github.com/fdlk","followers_url":"https://api.github.com/users/fdlk/followers","following_url":"https://api.github.com/users/fdlk/following{/other_user}","gists_url":"https://api.github.com/users/fdlk/gists{/gist_id}","starred_url":"https://api.github.com/users/fdlk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fdlk/subscriptions","organizations_url":"https://api.github.com/users/fdlk/orgs","repos_url":"https://api.github.com/users/fdlk/repos","events_url":"https://api.github.com/users/fdlk/events{/privacy}","received_events_url":"https://api.github.com/users/fdlk/received_events","type":"User","site_admin":false},"assignees":[{"login":"fdlk","id":1523838,"node_id":"MDQ6VXNlcjE1MjM4Mzg=","avatar_url":"https://avatars2.githubusercontent.com/u/1523838?v=4","gravatar_id":"","url":"https://api.github.com/users/fdlk","html_url":"https://github.com/fdlk","followers_url":"https://api.github.com/users/fdlk/followers","following_url":"https://api.github.com/users/fdlk/following{/other_user}","gists_url":"https://api.github.com/users/fdlk/gists{/gist_id}","starred_url":"https://api.github.com/users/fdlk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fdlk/subscriptions","organizations_url":"https://api.github.com/users/fdlk/orgs","repos_url":"https://api.github.com/users/fdlk/repos","events_url":"https://api.github.com/users/fdlk/events{/privacy}","received_events_url":"https://api.github.com/users/fdlk/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/molgenis/molgenis/pulls/7392/commits","review_comments_url":"https://api.github.com/repos/molgenis/molgenis/pulls/7392/comments","review_comment_url":"https://api.github.com/repos/molgenis/molgenis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/molgenis/molgenis/issues/7392/comments","statuses_url":"https://api.github.com/repos/molgenis/molgenis/statuses/7e7e3f0c5405255a42f340018136d7b228c21bba","head":{"label":"sidohaakma:feature/sync-app-manager-with-permissions","ref":"feature/sync-app-manager-with-permissions","sha":"7e7e3f0c5405255a42f340018136d7b228c21bba","user":{"login":"sidohaakma","id":27900092,"node_id":"MDQ6VXNlcjI3OTAwMDky","avatar_url":"https://avatars2.githubusercontent.com/u/27900092?v=4","gravatar_id":"","url":"https://api.github.com/users/sidohaakma","html_url":"https://github.com/sidohaakma","followers_url":"https://api.github.com/users/sidohaakma/followers","following_url":"https://api.github.com/users/sidohaakma/following{/other_user}","gists_url":"https://api.github.com/users/sidohaakma/gists{/gist_id}","starred_url":"https://api.github.com/users/sidohaakma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sidohaakma/subscriptions","organizations_url":"https://api.github.com/users/sidohaakma/orgs","repos_url":"https://api.github.com/users/sidohaakma/repos","events_url":"https://api.github.com/users/sidohaakma/events{/privacy}","received_events_url":"https://api.github.com/users/sidohaakma/received_events","type":"User","site_admin":false},"repo":{"id":96145401,"node_id":"MDEwOlJlcG9zaXRvcnk5NjE0NTQwMQ==","name":"molgenis","full_name":"sidohaakma/molgenis","owner":{"login":"sidohaakma","id":27900092,"node_id":"MDQ6VXNlcjI3OTAwMDky","avatar_url":"https://avatars2.githubusercontent.com/u/27900092?v=4","gravatar_id":"","url":"https://api.github.com/users/sidohaakma","html_url":"https://github.com/sidohaakma","followers_url":"https://api.github.com/users/sidohaakma/followers","following_url":"https://api.github.com/users/sidohaakma/following{/other_user}","gists_url":"https://api.github.com/users/sidohaakma/gists{/gist_id}","starred_url":"https://api.github.com/users/sidohaakma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sidohaakma/subscriptions","organizations_url":"https://api.github.com/users/sidohaakma/orgs","repos_url":"https://api.github.com/users/sidohaakma/repos","events_url":"https://api.github.com/users/sidohaakma/events{/privacy}","received_events_url":"https://api.github.com/users/sidohaakma/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sidohaakma/molgenis","description":"MOLGENIS - for scientific data: management, exploration, integration and analysis. ","fork":true,"url":"https://api.github.com/repos/sidohaakma/molgenis","forks_url":"https://api.github.com/repos/sidohaakma/molgenis/forks","keys_url":"https://api.github.com/repos/sidohaakma/molgenis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sidohaakma/molgenis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sidohaakma/molgenis/teams","hooks_url":"https://api.github.com/repos/sidohaakma/molgenis/hooks","issue_events_url":"https://api.github.com/repos/sidohaakma/molgenis/issues/events{/number}","events_url":"https://api.github.com/repos/sidohaakma/molgenis/events","assignees_url":"https://api.github.com/repos/sidohaakma/molgenis/assignees{/user}","branches_url":"https://api.github.com/repos/sidohaakma/molgenis/branches{/branch}","tags_url":"https://api.github.com/repos/sidohaakma/molgenis/tags","blobs_url":"https://api.github.com/repos/sidohaakma/molgenis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sidohaakma/molgenis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sidohaakma/molgenis/git/refs{/sha}","trees_url":"https://api.github.com/repos/sidohaakma/molgenis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sidohaakma/molgenis/statuses/{sha}","languages_url":"https://api.github.com/repos/sidohaakma/molgenis/languages","stargazers_url":"https://api.github.com/repos/sidohaakma/molgenis/stargazers","contributors_url":"https://api.github.com/repos/sidohaakma/molgenis/contributors","subscribers_url":"https://api.github.com/repos/sidohaakma/molgenis/subscribers","subscription_url":"https://api.github.com/repos/sidohaakma/molgenis/subscription","commits_url":"https://api.github.com/repos/sidohaakma/molgenis/commits{/sha}","git_commits_url":"https://api.github.com/repos/sidohaakma/molgenis/git/commits{/sha}","comments_url":"https://api.github.com/repos/sidohaakma/molgenis/comments{/number}","issue_comment_url":"https://api.github.com/repos/sidohaakma/molgenis/issues/comments{/number}","contents_url":"https://api.github.com/repos/sidohaakma/molgenis/contents/{+path}","compare_url":"https://api.github.com/repos/sidohaakma/molgenis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sidohaakma/molgenis/merges","archive_url":"https://api.github.com/repos/sidohaakma/molgenis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sidohaakma/molgenis/downloads","issues_url":"https://api.github.com/repos/sidohaakma/molgenis/issues{/number}","pulls_url":"https://api.github.com/repos/sidohaakma/molgenis/pulls{/number}","milestones_url":"https://api.github.com/repos/sidohaakma/molgenis/milestones{/number}","notifications_url":"https://api.github.com/repos/sidohaakma/molgenis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sidohaakma/molgenis/labels{/name}","releases_url":"https://api.github.com/repos/sidohaakma/molgenis/releases{/id}","deployments_url":"https://api.github.com/repos/sidohaakma/molgenis/deployments","created_at":"2017-07-03T19:48:32Z","updated_at":"2018-05-30T14:17:01Z","pushed_at":"2018-05-31T13:09:00Z","git_url":"git://github.com/sidohaakma/molgenis.git","ssh_url":"git@github.com:sidohaakma/molgenis.git","clone_url":"https://github.com/sidohaakma/molgenis.git","svn_url":"https://github.com/sidohaakma/molgenis","homepage":" https://molgenis.github.io","size":141915,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"molgenis:master","ref":"master","sha":"61fbc9f567e4b94f76b188d9afcb907714ee28d3","user":{"login":"molgenis","id":1688158,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2ODgxNTg=","avatar_url":"https://avatars3.githubusercontent.com/u/1688158?v=4","gravatar_id":"","url":"https://api.github.com/users/molgenis","html_url":"https://github.com/molgenis","followers_url":"https://api.github.com/users/molgenis/followers","following_url":"https://api.github.com/users/molgenis/following{/other_user}","gists_url":"https://api.github.com/users/molgenis/gists{/gist_id}","starred_url":"https://api.github.com/users/molgenis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/molgenis/subscriptions","organizations_url":"https://api.github.com/users/molgenis/orgs","repos_url":"https://api.github.com/users/molgenis/repos","events_url":"https://api.github.com/users/molgenis/events{/privacy}","received_events_url":"https://api.github.com/users/molgenis/received_events","type":"Organization","site_admin":false},"repo":{"id":8010626,"node_id":"MDEwOlJlcG9zaXRvcnk4MDEwNjI2","name":"molgenis","full_name":"molgenis/molgenis","owner":{"login":"molgenis","id":1688158,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2ODgxNTg=","avatar_url":"https://avatars3.githubusercontent.com/u/1688158?v=4","gravatar_id":"","url":"https://api.github.com/users/molgenis","html_url":"https://github.com/molgenis","followers_url":"https://api.github.com/users/molgenis/followers","following_url":"https://api.github.com/users/molgenis/following{/other_user}","gists_url":"https://api.github.com/users/molgenis/gists{/gist_id}","starred_url":"https://api.github.com/users/molgenis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/molgenis/subscriptions","organizations_url":"https://api.github.com/users/molgenis/orgs","repos_url":"https://api.github.com/users/molgenis/repos","events_url":"https://api.github.com/users/molgenis/events{/privacy}","received_events_url":"https://api.github.com/users/molgenis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/molgenis/molgenis","description":"MOLGENIS - for scientific data: management, exploration, integration and analysis. ","fork":false,"url":"https://api.github.com/repos/molgenis/molgenis","forks_url":"https://api.github.com/repos/molgenis/molgenis/forks","keys_url":"https://api.github.com/repos/molgenis/molgenis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/molgenis/molgenis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/molgenis/molgenis/teams","hooks_url":"https://api.github.com/repos/molgenis/molgenis/hooks","issue_events_url":"https://api.github.com/repos/molgenis/molgenis/issues/events{/number}","events_url":"https://api.github.com/repos/molgenis/molgenis/events","assignees_url":"https://api.github.com/repos/molgenis/molgenis/assignees{/user}","branches_url":"https://api.github.com/repos/molgenis/molgenis/branches{/branch}","tags_url":"https://api.github.com/repos/molgenis/molgenis/tags","blobs_url":"https://api.github.com/repos/molgenis/molgenis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/molgenis/molgenis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/molgenis/molgenis/git/refs{/sha}","trees_url":"https://api.github.com/repos/molgenis/molgenis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/molgenis/molgenis/statuses/{sha}","languages_url":"https://api.github.com/repos/molgenis/molgenis/languages","stargazers_url":"https://api.github.com/repos/molgenis/molgenis/stargazers","contributors_url":"https://api.github.com/repos/molgenis/molgenis/contributors","subscribers_url":"https://api.github.com/repos/molgenis/molgenis/subscribers","subscription_url":"https://api.github.com/repos/molgenis/molgenis/subscription","commits_url":"https://api.github.com/repos/molgenis/molgenis/commits{/sha}","git_commits_url":"https://api.github.com/repos/molgenis/molgenis/git/commits{/sha}","comments_url":"https://api.github.com/repos/molgenis/molgenis/comments{/number}","issue_comment_url":"https://api.github.com/repos/molgenis/molgenis/issues/comments{/number}","contents_url":"https://api.github.com/repos/molgenis/molgenis/contents/{+path}","compare_url":"https://api.github.com/repos/molgenis/molgenis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/molgenis/molgenis/merges","archive_url":"https://api.github.com/repos/molgenis/molgenis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/molgenis/molgenis/downloads","issues_url":"https://api.github.com/repos/molgenis/molgenis/issues{/number}","pulls_url":"https://api.github.com/repos/molgenis/molgenis/pulls{/number}","milestones_url":"https://api.github.com/repos/molgenis/molgenis/milestones{/number}","notifications_url":"https://api.github.com/repos/molgenis/molgenis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/molgenis/molgenis/labels{/name}","releases_url":"https://api.github.com/repos/molgenis/molgenis/releases{/id}","deployments_url":"https://api.github.com/repos/molgenis/molgenis/deployments","created_at":"2013-02-04T16:02:36Z","updated_at":"2018-05-30T14:01:06Z","pushed_at":"2018-05-31T13:29:11Z","git_url":"git://github.com/molgenis/molgenis.git","ssh_url":"git@github.com:molgenis/molgenis.git","clone_url":"https://github.com/molgenis/molgenis.git","svn_url":"https://github.com/molgenis/molgenis","homepage":" https://molgenis.github.io","size":141931,"stargazers_count":52,"watchers_count":52,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":80,"mirror_url":null,"archived":false,"open_issues_count":287,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":80,"open_issues":287,"watchers":52,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/molgenis/molgenis/pulls/7392"},"html":{"href":"https://github.com/molgenis/molgenis/pull/7392"},"issue":{"href":"https://api.github.com/repos/molgenis/molgenis/issues/7392"},"comments":{"href":"https://api.github.com/repos/molgenis/molgenis/issues/7392/comments"},"review_comments":{"href":"https://api.github.com/repos/molgenis/molgenis/pulls/7392/comments"},"review_comment":{"href":"https://api.github.com/repos/molgenis/molgenis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/molgenis/molgenis/pulls/7392/commits"},"statuses":{"href":"https://api.github.com/repos/molgenis/molgenis/statuses/7e7e3f0c5405255a42f340018136d7b228c21bba"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"fdlk"}}