{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/24117","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/24117/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/24117/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/24117/events","html_url":"https://github.com/cockroachdb/cockroach/pull/24117","id":307330134,"number":24117,"title":"roachpb: fix error in resume reason while combining ResponseHeaders","user":{"login":"spencerkimball","id":6147149,"avatar_url":"https://avatars0.githubusercontent.com/u/6147149?v=4","gravatar_id":"","url":"https://api.github.com/users/spencerkimball","html_url":"https://github.com/spencerkimball","followers_url":"https://api.github.com/users/spencerkimball/followers","following_url":"https://api.github.com/users/spencerkimball/following{/other_user}","gists_url":"https://api.github.com/users/spencerkimball/gists{/gist_id}","starred_url":"https://api.github.com/users/spencerkimball/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spencerkimball/subscriptions","organizations_url":"https://api.github.com/users/spencerkimball/orgs","repos_url":"https://api.github.com/users/spencerkimball/repos","events_url":"https://api.github.com/users/spencerkimball/events{/privacy}","received_events_url":"https://api.github.com/users/spencerkimball/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-21T16:50:16Z","updated_at":"2018-03-21T18:14:55Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/24117","html_url":"https://github.com/cockroachdb/cockroach/pull/24117","diff_url":"https://github.com/cockroachdb/cockroach/pull/24117.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/24117.patch"},"body":"This doesn't include a unittest because I could simply not figure out\r\nhow the problem is still possible given the current code. However,\r\nthe fix in this PR does address a problem in the combination of responses\r\nwhich prevented the `ResumeReason` from being properly combined.\r\nThere are plenty of unittests already in `kv/dist_sender_server_test.go`\r\nwhich exercise this code path, and demonstrate also that while this bug\r\nhas existed for a long time, the code in `kv/dist_sender.go`, specifically\r\nin `fillSkippedResponses`, papers over the problem by resetting the\r\n`ResumeReason` appropriately.\r\n\r\nBecause the fix is so suggestive, I'm going to tentatively close the\r\nissue reported by sentry. If it crops up again, we can reopen.\r\n\r\nFixes #22370\r\n\r\nRelease note: None"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/375044889","html_url":"https://github.com/cockroachdb/cockroach/pull/24117#issuecomment-375044889","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/24117","id":375044889,"user":{"login":"bdarnell","id":160562,"avatar_url":"https://avatars1.githubusercontent.com/u/160562?v=4","gravatar_id":"","url":"https://api.github.com/users/bdarnell","html_url":"https://github.com/bdarnell","followers_url":"https://api.github.com/users/bdarnell/followers","following_url":"https://api.github.com/users/bdarnell/following{/other_user}","gists_url":"https://api.github.com/users/bdarnell/gists{/gist_id}","starred_url":"https://api.github.com/users/bdarnell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bdarnell/subscriptions","organizations_url":"https://api.github.com/users/bdarnell/orgs","repos_url":"https://api.github.com/users/bdarnell/repos","events_url":"https://api.github.com/users/bdarnell/events{/privacy}","received_events_url":"https://api.github.com/users/bdarnell/received_events","type":"User","site_admin":false},"created_at":"2018-03-21T18:14:55Z","updated_at":"2018-03-21T18:14:55Z","author_association":"OWNER","body":"<img class=\"emoji\" title=\":lgtm:\" alt=\":lgtm:\" align=\"absmiddle\" src=\"https://reviewable.io/lgtm.png\" height=\"20\" width=\"61\"/>\n\n---\n\nReview status: 0 of 2 files reviewed at latest revision, all discussions resolved.\n\n---\n\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/cockroachdb/cockroach/24117#-:-L88lBvV7vtc2jsn3oiX:bg7igk9)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"bdarnell"}}