{"action":"created","issue":{"url":"https://api.github.com/repos/basnijholt/adaptive/issues/19","repository_url":"https://api.github.com/repos/basnijholt/adaptive","labels_url":"https://api.github.com/repos/basnijholt/adaptive/issues/19/labels{/name}","comments_url":"https://api.github.com/repos/basnijholt/adaptive/issues/19/comments","events_url":"https://api.github.com/repos/basnijholt/adaptive/issues/19/events","html_url":"https://github.com/basnijholt/adaptive/issues/19","id":391794973,"node_id":"MDU6SXNzdWUzOTE3OTQ5NzM=","number":19,"title":"Learner.load does not raise an exception if the provided filename was not found","user":{"login":"basnijholt","id":6897215,"node_id":"MDQ6VXNlcjY4OTcyMTU=","avatar_url":"https://avatars2.githubusercontent.com/u/6897215?v=4","gravatar_id":"","url":"https://api.github.com/users/basnijholt","html_url":"https://github.com/basnijholt","followers_url":"https://api.github.com/users/basnijholt/followers","following_url":"https://api.github.com/users/basnijholt/following{/other_user}","gists_url":"https://api.github.com/users/basnijholt/gists{/gist_id}","starred_url":"https://api.github.com/users/basnijholt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basnijholt/subscriptions","organizations_url":"https://api.github.com/users/basnijholt/orgs","repos_url":"https://api.github.com/users/basnijholt/repos","events_url":"https://api.github.com/users/basnijholt/events{/privacy}","received_events_url":"https://api.github.com/users/basnijholt/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-17T16:38:23Z","updated_at":"2018-12-17T16:38:24Z","closed_at":null,"author_association":"OWNER","body":"## ([original issue on GitLab](https://gitlab.kwant-project.org/qt/adaptive/issues/124))\n\nopened by Joseph Weston (username_url) at 2018-11-19T14:19:24.632Z\n\nThe default implementation is:\n\n```\nwith suppress(FileNotFoundError, EOFError):\n    data = load(fname, compress)\n    self._set_data(data)\n```\n\nThis means that if 'fname' does not exist this method silently fails. IMO it is the caller's responsibility to catch any errors."},"comment":{"url":"https://api.github.com/repos/basnijholt/adaptive/issues/comments/447910714","html_url":"https://github.com/basnijholt/adaptive/issues/19#issuecomment-447910714","issue_url":"https://api.github.com/repos/basnijholt/adaptive/issues/19","id":447910714,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NzkxMDcxNA==","user":{"login":"basnijholt","id":6897215,"node_id":"MDQ6VXNlcjY4OTcyMTU=","avatar_url":"https://avatars2.githubusercontent.com/u/6897215?v=4","gravatar_id":"","url":"https://api.github.com/users/basnijholt","html_url":"https://github.com/basnijholt","followers_url":"https://api.github.com/users/basnijholt/followers","following_url":"https://api.github.com/users/basnijholt/following{/other_user}","gists_url":"https://api.github.com/users/basnijholt/gists{/gist_id}","starred_url":"https://api.github.com/users/basnijholt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/basnijholt/subscriptions","organizations_url":"https://api.github.com/users/basnijholt/orgs","repos_url":"https://api.github.com/users/basnijholt/repos","events_url":"https://api.github.com/users/basnijholt/events{/privacy}","received_events_url":"https://api.github.com/users/basnijholt/received_events","type":"User","site_admin":false},"created_at":"2018-12-17T16:38:24Z","updated_at":"2018-12-17T16:38:24Z","author_association":"OWNER","body":"originally posted by Bas Nijholt (@[basnijholt](https://gitlab.kwant-project.org/basnijholt)) at 2018-11-19T15:24:43.030Z on [GitLab](https://gitlab.kwant-project.org/qt/adaptive/issues/124)\n\nThis is actually a really great way of using it.\n\n> This means that if 'fname' does not exist this method silently fails. IMO it is the caller's responsibility to catch any errors.\n\nThat doesn't happen, because [this is always called](https://gitlab.kwant-project.org/qt/adaptive/blob/master/adaptive/learner/base_learner.py#L163)."}}
{"actor":{"display_login":"basnijholt"}}