{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/212061058","pull_request_review_id":148613426,"id":212061058,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjA2MTA1OA==","diff_hunk":"@@ -309,7 +319,8 @@ impl<'tcx, O> EvalErrorKind<'tcx, O> {\n             ReadForeignStatic =>\n                 \"tried to read from foreign (extern) static\",\n             InvalidPointerMath =>\n-                \"attempted to do invalid arithmetic on pointers that would leak base addresses, e.g. comparing pointers into different allocations\",\n+                \"attempted to do invalid arithmetic on pointers that would leak base addresses,\n+                e.g. comparing pointers into different allocations\",","path":"src/librustc/mir/interpret/error.rs","position":20,"original_position":20,"commit_id":"f30d4fa2e943a77ae0d0a65d95a23960423942bd","original_commit_id":"f30d4fa2e943a77ae0d0a65d95a23960423942bd","user":{"login":"RalfJung","id":330628,"node_id":"MDQ6VXNlcjMzMDYyOA==","avatar_url":"https://avatars1.githubusercontent.com/u/330628?v=4","gravatar_id":"","url":"https://api.github.com/users/RalfJung","html_url":"https://github.com/RalfJung","followers_url":"https://api.github.com/users/RalfJung/followers","following_url":"https://api.github.com/users/RalfJung/following{/other_user}","gists_url":"https://api.github.com/users/RalfJung/gists{/gist_id}","starred_url":"https://api.github.com/users/RalfJung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RalfJung/subscriptions","organizations_url":"https://api.github.com/users/RalfJung/orgs","repos_url":"https://api.github.com/users/RalfJung/repos","events_url":"https://api.github.com/users/RalfJung/events{/privacy}","received_events_url":"https://api.github.com/users/RalfJung/received_events","type":"User","site_admin":false},"body":"This needs a backslash to not change the actual string being computed:\r\n```\r\n                \"attempted to do invalid arithmetic on pointers that would leak base addresses, \\\r\n                e.g. comparing pointers into different allocations\",\r\n```\r\nHere and elsewhere.","created_at":"2018-08-22T18:30:29Z","updated_at":"2018-08-22T18:30:29Z","html_url":"https://github.com/rust-lang/rust/pull/53609#discussion_r212061058","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/53609","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/212061058"},"html":{"href":"https://github.com/rust-lang/rust/pull/53609#discussion_r212061058"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/53609"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/53609","id":210206885,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwMjA2ODg1","html_url":"https://github.com/rust-lang/rust/pull/53609","diff_url":"https://github.com/rust-lang/rust/pull/53609.diff","patch_url":"https://github.com/rust-lang/rust/pull/53609.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/53609","number":53609,"state":"open","locked":false,"title":"Tidy CFTE/MIRI","user":{"login":"bemeurer","id":7243783,"node_id":"MDQ6VXNlcjcyNDM3ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/7243783?v=4","gravatar_id":"","url":"https://api.github.com/users/bemeurer","html_url":"https://github.com/bemeurer","followers_url":"https://api.github.com/users/bemeurer/followers","following_url":"https://api.github.com/users/bemeurer/following{/other_user}","gists_url":"https://api.github.com/users/bemeurer/gists{/gist_id}","starred_url":"https://api.github.com/users/bemeurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bemeurer/subscriptions","organizations_url":"https://api.github.com/users/bemeurer/orgs","repos_url":"https://api.github.com/users/bemeurer/repos","events_url":"https://api.github.com/users/bemeurer/events{/privacy}","received_events_url":"https://api.github.com/users/bemeurer/received_events","type":"User","site_admin":false},"body":"Fixes #53596 ","created_at":"2018-08-22T17:24:03Z","updated_at":"2018-08-22T18:30:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c65bb374d86b15e8fa0caf33f2fb704da733d1b0","assignee":{"login":"RalfJung","id":330628,"node_id":"MDQ6VXNlcjMzMDYyOA==","avatar_url":"https://avatars1.githubusercontent.com/u/330628?v=4","gravatar_id":"","url":"https://api.github.com/users/RalfJung","html_url":"https://github.com/RalfJung","followers_url":"https://api.github.com/users/RalfJung/followers","following_url":"https://api.github.com/users/RalfJung/following{/other_user}","gists_url":"https://api.github.com/users/RalfJung/gists{/gist_id}","starred_url":"https://api.github.com/users/RalfJung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RalfJung/subscriptions","organizations_url":"https://api.github.com/users/RalfJung/orgs","repos_url":"https://api.github.com/users/RalfJung/repos","events_url":"https://api.github.com/users/RalfJung/events{/privacy}","received_events_url":"https://api.github.com/users/RalfJung/received_events","type":"User","site_admin":false},"assignees":[{"login":"RalfJung","id":330628,"node_id":"MDQ6VXNlcjMzMDYyOA==","avatar_url":"https://avatars1.githubusercontent.com/u/330628?v=4","gravatar_id":"","url":"https://api.github.com/users/RalfJung","html_url":"https://github.com/RalfJung","followers_url":"https://api.github.com/users/RalfJung/followers","following_url":"https://api.github.com/users/RalfJung/following{/other_user}","gists_url":"https://api.github.com/users/RalfJung/gists{/gist_id}","starred_url":"https://api.github.com/users/RalfJung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RalfJung/subscriptions","organizations_url":"https://api.github.com/users/RalfJung/orgs","repos_url":"https://api.github.com/users/RalfJung/repos","events_url":"https://api.github.com/users/RalfJung/events{/privacy}","received_events_url":"https://api.github.com/users/RalfJung/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":583426710,"node_id":"MDU6TGFiZWw1ODM0MjY3MTA=","url":"https://api.github.com/repos/rust-lang/rust/labels/S-waiting-on-review","name":"S-waiting-on-review","color":"d3dddd","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/53609/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/53609/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/53609/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/f30d4fa2e943a77ae0d0a65d95a23960423942bd","head":{"label":"bemeurer:tidy-ctfe","ref":"tidy-ctfe","sha":"f30d4fa2e943a77ae0d0a65d95a23960423942bd","user":{"login":"bemeurer","id":7243783,"node_id":"MDQ6VXNlcjcyNDM3ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/7243783?v=4","gravatar_id":"","url":"https://api.github.com/users/bemeurer","html_url":"https://github.com/bemeurer","followers_url":"https://api.github.com/users/bemeurer/followers","following_url":"https://api.github.com/users/bemeurer/following{/other_user}","gists_url":"https://api.github.com/users/bemeurer/gists{/gist_id}","starred_url":"https://api.github.com/users/bemeurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bemeurer/subscriptions","organizations_url":"https://api.github.com/users/bemeurer/orgs","repos_url":"https://api.github.com/users/bemeurer/repos","events_url":"https://api.github.com/users/bemeurer/events{/privacy}","received_events_url":"https://api.github.com/users/bemeurer/received_events","type":"User","site_admin":false},"repo":{"id":143899465,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM4OTk0NjU=","name":"rust","full_name":"bemeurer/rust","owner":{"login":"bemeurer","id":7243783,"node_id":"MDQ6VXNlcjcyNDM3ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/7243783?v=4","gravatar_id":"","url":"https://api.github.com/users/bemeurer","html_url":"https://github.com/bemeurer","followers_url":"https://api.github.com/users/bemeurer/followers","following_url":"https://api.github.com/users/bemeurer/following{/other_user}","gists_url":"https://api.github.com/users/bemeurer/gists{/gist_id}","starred_url":"https://api.github.com/users/bemeurer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bemeurer/subscriptions","organizations_url":"https://api.github.com/users/bemeurer/orgs","repos_url":"https://api.github.com/users/bemeurer/repos","events_url":"https://api.github.com/users/bemeurer/events{/privacy}","received_events_url":"https://api.github.com/users/bemeurer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bemeurer/rust","description":"A safe, concurrent, practical language.","fork":true,"url":"https://api.github.com/repos/bemeurer/rust","forks_url":"https://api.github.com/repos/bemeurer/rust/forks","keys_url":"https://api.github.com/repos/bemeurer/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bemeurer/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bemeurer/rust/teams","hooks_url":"https://api.github.com/repos/bemeurer/rust/hooks","issue_events_url":"https://api.github.com/repos/bemeurer/rust/issues/events{/number}","events_url":"https://api.github.com/repos/bemeurer/rust/events","assignees_url":"https://api.github.com/repos/bemeurer/rust/assignees{/user}","branches_url":"https://api.github.com/repos/bemeurer/rust/branches{/branch}","tags_url":"https://api.github.com/repos/bemeurer/rust/tags","blobs_url":"https://api.github.com/repos/bemeurer/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bemeurer/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bemeurer/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/bemeurer/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bemeurer/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/bemeurer/rust/languages","stargazers_url":"https://api.github.com/repos/bemeurer/rust/stargazers","contributors_url":"https://api.github.com/repos/bemeurer/rust/contributors","subscribers_url":"https://api.github.com/repos/bemeurer/rust/subscribers","subscription_url":"https://api.github.com/repos/bemeurer/rust/subscription","commits_url":"https://api.github.com/repos/bemeurer/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/bemeurer/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/bemeurer/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/bemeurer/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/bemeurer/rust/contents/{+path}","compare_url":"https://api.github.com/repos/bemeurer/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bemeurer/rust/merges","archive_url":"https://api.github.com/repos/bemeurer/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bemeurer/rust/downloads","issues_url":"https://api.github.com/repos/bemeurer/rust/issues{/number}","pulls_url":"https://api.github.com/repos/bemeurer/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/bemeurer/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/bemeurer/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bemeurer/rust/labels{/name}","releases_url":"https://api.github.com/repos/bemeurer/rust/releases{/id}","deployments_url":"https://api.github.com/repos/bemeurer/rust/deployments","created_at":"2018-08-07T16:23:03Z","updated_at":"2018-08-07T16:23:35Z","pushed_at":"2018-08-22T18:13:07Z","git_url":"git://github.com/bemeurer/rust.git","ssh_url":"git@github.com:bemeurer/rust.git","clone_url":"https://github.com/bemeurer/rust.git","svn_url":"https://github.com/bemeurer/rust","homepage":"https://www.rust-lang.org","size":388073,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"c24f27c0452a9aaecfb70d225d846df2e517385f","user":{"login":"rust-lang","id":5430905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MzA5MDU=","avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"node_id":"MDEwOlJlcG9zaXRvcnk3MjQ3MTI=","name":"rust","full_name":"rust-lang/rust","owner":{"login":"rust-lang","id":5430905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MzA5MDU=","avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/rust","description":"A safe, concurrent, practical language.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2018-08-22T17:44:10Z","pushed_at":"2018-08-22T18:25:23Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"https://www.rust-lang.org","size":388234,"stargazers_count":30144,"watchers_count":30144,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5128,"mirror_url":null,"archived":false,"open_issues_count":4229,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5128,"open_issues":4229,"watchers":30144,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/53609"},"html":{"href":"https://github.com/rust-lang/rust/pull/53609"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/53609"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/53609/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/53609/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/53609/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/f30d4fa2e943a77ae0d0a65d95a23960423942bd"}},"author_association":"NONE"}}
{"actor":{"display_login":"RalfJung"}}