{"action":"created","issue":{"url":"https://api.github.com/repos/istio/istio/issues/10495","repository_url":"https://api.github.com/repos/istio/istio","labels_url":"https://api.github.com/repos/istio/istio/issues/10495/labels{/name}","comments_url":"https://api.github.com/repos/istio/istio/issues/10495/comments","events_url":"https://api.github.com/repos/istio/istio/issues/10495/events","html_url":"https://github.com/istio/istio/pull/10495","id":391244261,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4ODI1NDA1","number":10495,"title":"Fix data race during pilot shutdown","user":{"login":"Nino-K","id":10409174,"node_id":"MDQ6VXNlcjEwNDA5MTc0","avatar_url":"https://avatars2.githubusercontent.com/u/10409174?v=4","gravatar_id":"","url":"https://api.github.com/users/Nino-K","html_url":"https://github.com/Nino-K","followers_url":"https://api.github.com/users/Nino-K/followers","following_url":"https://api.github.com/users/Nino-K/following{/other_user}","gists_url":"https://api.github.com/users/Nino-K/gists{/gist_id}","starred_url":"https://api.github.com/users/Nino-K/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Nino-K/subscriptions","organizations_url":"https://api.github.com/users/Nino-K/orgs","repos_url":"https://api.github.com/users/Nino-K/repos","events_url":"https://api.github.com/users/Nino-K/events{/privacy}","received_events_url":"https://api.github.com/users/Nino-K/received_events","type":"User","site_admin":false},"labels":[{"id":491318011,"node_id":"MDU6TGFiZWw0OTEzMTgwMTE=","url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-14T19:53:46Z","updated_at":"2018-12-14T19:53:50Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/10495","html_url":"https://github.com/istio/istio/pull/10495","diff_url":"https://github.com/istio/istio/pull/10495.diff","patch_url":"https://github.com/istio/istio/pull/10495.patch"},"body":"There seem to be a race when shutting down pilot server. For more context, the data race is revealed more when shutting down an [in-memory pilot](https://github.com/istio/istio/blob/913b459130045fc4846a36c46c05a48da88776bb/tests/e2e/tests/pilot/mcp_test.go#L180) during tests. The following [data race](https://gist.github.com/Nino-K/3a93ad89419bb4d5beabd414f4358c52) indicates that the `secureHTTPServer` object is being read and written to simultaneously [here](https://github.com/istio/istio/blob/913b459130045fc4846a36c46c05a48da88776bb/pilot/pkg/bootstrap/server.go#L1002) and [here](https://github.com/istio/istio/blob/913b459130045fc4846a36c46c05a48da88776bb/pilot/pkg/bootstrap/server.go#L1089)."},"comment":{"url":"https://api.github.com/repos/istio/istio/issues/comments/447436339","html_url":"https://github.com/istio/istio/pull/10495#issuecomment-447436339","issue_url":"https://api.github.com/repos/istio/istio/issues/10495","id":447436339,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NzQzNjMzOQ==","user":{"login":"istio-testing","id":25311884,"node_id":"MDQ6VXNlcjI1MzExODg0","avatar_url":"https://avatars1.githubusercontent.com/u/25311884?v=4","gravatar_id":"","url":"https://api.github.com/users/istio-testing","html_url":"https://github.com/istio-testing","followers_url":"https://api.github.com/users/istio-testing/followers","following_url":"https://api.github.com/users/istio-testing/following{/other_user}","gists_url":"https://api.github.com/users/istio-testing/gists{/gist_id}","starred_url":"https://api.github.com/users/istio-testing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio-testing/subscriptions","organizations_url":"https://api.github.com/users/istio-testing/orgs","repos_url":"https://api.github.com/users/istio-testing/repos","events_url":"https://api.github.com/users/istio-testing/events{/privacy}","received_events_url":"https://api.github.com/users/istio-testing/received_events","type":"User","site_admin":false},"created_at":"2018-12-14T19:53:50Z","updated_at":"2018-12-14T19:53:50Z","author_association":"COLLABORATOR","body":"[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: *<a href=\"https://github.com/istio/istio/pull/10495#\" title=\"Author self-approved\">Nino-K</a>*\nTo fully approve this pull request, please assign additional approvers.\nWe suggest the following additional approver: **rshriram**\n\nIf they are not already assigned, you can assign the PR to them by writing `/assign @rshriram` in a comment when ready.\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[pilot/OWNERS](https://github.com/istio/istio/blob/release-1.1/pilot/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"rshriram\"]} -->"}}
{"actor":{"display_login":"istio-testing"}}