{"action":"created","issue":{"url":"https://api.github.com/repos/vmware/concord-bft/issues/4","repository_url":"https://api.github.com/repos/vmware/concord-bft","labels_url":"https://api.github.com/repos/vmware/concord-bft/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/vmware/concord-bft/issues/4/comments","events_url":"https://api.github.com/repos/vmware/concord-bft/issues/4/events","html_url":"https://github.com/vmware/concord-bft/pull/4","id":362809244,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NDI4Mjc2","number":4,"title":"Fix compiler warnings","user":{"login":"beerriot","id":190975,"node_id":"MDQ6VXNlcjE5MDk3NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/190975?v=4","gravatar_id":"","url":"https://api.github.com/users/beerriot","html_url":"https://github.com/beerriot","followers_url":"https://api.github.com/users/beerriot/followers","following_url":"https://api.github.com/users/beerriot/following{/other_user}","gists_url":"https://api.github.com/users/beerriot/gists{/gist_id}","starred_url":"https://api.github.com/users/beerriot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/beerriot/subscriptions","organizations_url":"https://api.github.com/users/beerriot/orgs","repos_url":"https://api.github.com/users/beerriot/repos","events_url":"https://api.github.com/users/beerriot/events{/privacy}","received_events_url":"https://api.github.com/users/beerriot/received_events","type":"User","site_admin":false},"labels":[{"id":1049529535,"node_id":"MDU6TGFiZWwxMDQ5NTI5NTM1","url":"https://api.github.com/repos/vmware/concord-bft/labels/cla-not-required","name":"cla-not-required","color":"159818","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-09-22T00:20:43Z","updated_at":"2018-10-01T18:08:08Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/vmware/concord-bft/pulls/4","html_url":"https://github.com/vmware/concord-bft/pull/4","diff_url":"https://github.com/vmware/concord-bft/pull/4.diff","patch_url":"https://github.com/vmware/concord-bft/pull/4.patch"},"body":"Building concord-bft generated a number of warnings around:\r\n\r\n * extra semicolons\r\n * signed/unsigned comparison\r\n * unused functions/variables\r\n * unmatched enumeration values in switch statements\r\n\r\nThis change cleans them all up, so that no warnings are reported with either Clang 3.8.0 or GNU 5.4.0.\r\n\r\nSince the changes were fairly extensive to CommFactory.{cpp,hpp}, I also cleaned up the cpplint complaints for those files (the last three commits here).\r\n\r\nI also accidentally committed my addition to .gitignore for emacs temporary files. Sorry to include it in unrelated changes, but it's a good and simple addition."},"comment":{"url":"https://api.github.com/repos/vmware/concord-bft/issues/comments/426006468","html_url":"https://github.com/vmware/concord-bft/pull/4#issuecomment-426006468","issue_url":"https://api.github.com/repos/vmware/concord-bft/issues/4","id":426006468,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNjAwNjQ2OA==","user":{"login":"guyg7","id":8308645,"node_id":"MDQ6VXNlcjgzMDg2NDU=","avatar_url":"https://avatars0.githubusercontent.com/u/8308645?v=4","gravatar_id":"","url":"https://api.github.com/users/guyg7","html_url":"https://github.com/guyg7","followers_url":"https://api.github.com/users/guyg7/followers","following_url":"https://api.github.com/users/guyg7/following{/other_user}","gists_url":"https://api.github.com/users/guyg7/gists{/gist_id}","starred_url":"https://api.github.com/users/guyg7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guyg7/subscriptions","organizations_url":"https://api.github.com/users/guyg7/orgs","repos_url":"https://api.github.com/users/guyg7/repos","events_url":"https://api.github.com/users/guyg7/events{/privacy}","received_events_url":"https://api.github.com/users/guyg7/received_events","type":"User","site_admin":false},"created_at":"2018-10-01T18:08:08Z","updated_at":"2018-10-01T18:08:08Z","author_association":"NONE","body":"@salieri11:\r\nGreat. Let's try to keep the interfaces as simple as possible.\r\nI suggest to also delete these functions from this repository.\r\n"}}
{"actor":{"display_login":"guyg7"}}