{"action":"created","comment":{"url":"https://api.github.com/repos/google/turbinia/pulls/comments/222313210","pull_request_review_id":161168122,"id":222313210,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjMxMzIxMA==","diff_hunk":"@@ -243,16 +281,11 @@ def __init__(self, embedded_path=None, *args, **kwargs):\n     super(GoogleCloudDiskRawEmbedded, self).__init__(*args, **kwargs)\n \n   def preprocess(self):\n-    self.local_path = google_cloud.PreprocessAttachDisk(self.disk_name)\n-    self.loopdevice_path = mount_local.PreprocessLosetup(self.local_path)\n-    self.mount_path = mount_local.PreprocessMountDisk(\n-        self.loopdevice_path, self.mount_partition)\n-    self.local_path = os.path.join(self.mount_path, self.embedded_path)\n+    super(GoogleCloudDiskRawEmbedded, self).preprocess()\n+    self.local_path = os.path.join(self._disk_mount_path, self.embedded_path)\n \n   def postprocess(self):\n-    google_cloud.PostprocessDetachDisk(self.disk_name, self.local_path)\n-    mount_local.PostprocessUnmountPath(self.mount_path)\n-    mount_local.PostprocessDeleteLosetup(self.loopdevice_path)\n+    super(GoogleCloudDiskRawEmbedded, self).post()","path":"turbinia/evidence.py","position":97,"original_position":97,"commit_id":"5a7d5f97d1080fb69435d419f3199932ce587d62","original_commit_id":"5a7d5f97d1080fb69435d419f3199932ce587d62","user":{"login":"rgayon","id":15198637,"node_id":"MDQ6VXNlcjE1MTk4NjM3","avatar_url":"https://avatars1.githubusercontent.com/u/15198637?v=4","gravatar_id":"","url":"https://api.github.com/users/rgayon","html_url":"https://github.com/rgayon","followers_url":"https://api.github.com/users/rgayon/followers","following_url":"https://api.github.com/users/rgayon/following{/other_user}","gists_url":"https://api.github.com/users/rgayon/gists{/gist_id}","starred_url":"https://api.github.com/users/rgayon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgayon/subscriptions","organizations_url":"https://api.github.com/users/rgayon/orgs","repos_url":"https://api.github.com/users/rgayon/repos","events_url":"https://api.github.com/users/rgayon/events{/privacy}","received_events_url":"https://api.github.com/users/rgayon/received_events","type":"User","site_admin":false},"body":"yest it should. fixed","created_at":"2018-10-03T13:41:47Z","updated_at":"2018-10-03T13:41:47Z","html_url":"https://github.com/google/turbinia/pull/261#discussion_r222313210","pull_request_url":"https://api.github.com/repos/google/turbinia/pulls/261","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/google/turbinia/pulls/comments/222313210"},"html":{"href":"https://github.com/google/turbinia/pull/261#discussion_r222313210"},"pull_request":{"href":"https://api.github.com/repos/google/turbinia/pulls/261"}},"in_reply_to_id":221818069},"pull_request":{"url":"https://api.github.com/repos/google/turbinia/pulls/261","id":217728566,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NzI4NTY2","html_url":"https://github.com/google/turbinia/pull/261","diff_url":"https://github.com/google/turbinia/pull/261.diff","patch_url":"https://github.com/google/turbinia/pull/261.patch","issue_url":"https://api.github.com/repos/google/turbinia/issues/261","number":261,"state":"open","locked":false,"title":"Stack Evidence types","user":{"login":"rgayon","id":15198637,"node_id":"MDQ6VXNlcjE1MTk4NjM3","avatar_url":"https://avatars1.githubusercontent.com/u/15198637?v=4","gravatar_id":"","url":"https://api.github.com/users/rgayon","html_url":"https://github.com/rgayon","followers_url":"https://api.github.com/users/rgayon/followers","following_url":"https://api.github.com/users/rgayon/following{/other_user}","gists_url":"https://api.github.com/users/rgayon/gists{/gist_id}","starred_url":"https://api.github.com/users/rgayon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgayon/subscriptions","organizations_url":"https://api.github.com/users/rgayon/orgs","repos_url":"https://api.github.com/users/rgayon/repos","events_url":"https://api.github.com/users/rgayon/events{/privacy}","received_events_url":"https://api.github.com/users/rgayon/received_events","type":"User","site_admin":false},"body":"Evidence types are \"stacked\". As in, Evidence1 inheriting Evidence2, will call its parent's pre & post processor.\r\n\r\nWe also add a \"copy context\" method, that should be called when a new Evidence \"Child\" is generated in a Task that is currently analyzing Evidence \"Parent\", that will be processed by other types. This method ensures the state of Parent is passed down to Children, so that all required post&pre processing will be done properly, to access data in Children.\r\n\r\nThe problem with the current solution is that new Evidence types are expected to properly implement this method, while making sure to not overwrite its parent attribute.\r\nOne solution I found is https://gist.github.com/rgayon/f1af6b32c316a67f72a37697a3c7e4c9 albeit quite disgusting :(","created_at":"2018-09-24T17:19:05Z","updated_at":"2018-10-03T13:41:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fabc694dc837f005226b3d795daee180ad3a170d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/turbinia/pulls/261/commits","review_comments_url":"https://api.github.com/repos/google/turbinia/pulls/261/comments","review_comment_url":"https://api.github.com/repos/google/turbinia/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/turbinia/issues/261/comments","statuses_url":"https://api.github.com/repos/google/turbinia/statuses/5a7d5f97d1080fb69435d419f3199932ce587d62","head":{"label":"rgayon:stack-evidence","ref":"stack-evidence","sha":"5a7d5f97d1080fb69435d419f3199932ce587d62","user":{"login":"rgayon","id":15198637,"node_id":"MDQ6VXNlcjE1MTk4NjM3","avatar_url":"https://avatars1.githubusercontent.com/u/15198637?v=4","gravatar_id":"","url":"https://api.github.com/users/rgayon","html_url":"https://github.com/rgayon","followers_url":"https://api.github.com/users/rgayon/followers","following_url":"https://api.github.com/users/rgayon/following{/other_user}","gists_url":"https://api.github.com/users/rgayon/gists{/gist_id}","starred_url":"https://api.github.com/users/rgayon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgayon/subscriptions","organizations_url":"https://api.github.com/users/rgayon/orgs","repos_url":"https://api.github.com/users/rgayon/repos","events_url":"https://api.github.com/users/rgayon/events{/privacy}","received_events_url":"https://api.github.com/users/rgayon/received_events","type":"User","site_admin":false},"repo":{"id":146625122,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY2MjUxMjI=","name":"turbinia","full_name":"rgayon/turbinia","private":false,"owner":{"login":"rgayon","id":15198637,"node_id":"MDQ6VXNlcjE1MTk4NjM3","avatar_url":"https://avatars1.githubusercontent.com/u/15198637?v=4","gravatar_id":"","url":"https://api.github.com/users/rgayon","html_url":"https://github.com/rgayon","followers_url":"https://api.github.com/users/rgayon/followers","following_url":"https://api.github.com/users/rgayon/following{/other_user}","gists_url":"https://api.github.com/users/rgayon/gists{/gist_id}","starred_url":"https://api.github.com/users/rgayon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rgayon/subscriptions","organizations_url":"https://api.github.com/users/rgayon/orgs","repos_url":"https://api.github.com/users/rgayon/repos","events_url":"https://api.github.com/users/rgayon/events{/privacy}","received_events_url":"https://api.github.com/users/rgayon/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rgayon/turbinia","description":"Automation and Scaling of Digital Forensics Tools","fork":true,"url":"https://api.github.com/repos/rgayon/turbinia","forks_url":"https://api.github.com/repos/rgayon/turbinia/forks","keys_url":"https://api.github.com/repos/rgayon/turbinia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rgayon/turbinia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rgayon/turbinia/teams","hooks_url":"https://api.github.com/repos/rgayon/turbinia/hooks","issue_events_url":"https://api.github.com/repos/rgayon/turbinia/issues/events{/number}","events_url":"https://api.github.com/repos/rgayon/turbinia/events","assignees_url":"https://api.github.com/repos/rgayon/turbinia/assignees{/user}","branches_url":"https://api.github.com/repos/rgayon/turbinia/branches{/branch}","tags_url":"https://api.github.com/repos/rgayon/turbinia/tags","blobs_url":"https://api.github.com/repos/rgayon/turbinia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rgayon/turbinia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rgayon/turbinia/git/refs{/sha}","trees_url":"https://api.github.com/repos/rgayon/turbinia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rgayon/turbinia/statuses/{sha}","languages_url":"https://api.github.com/repos/rgayon/turbinia/languages","stargazers_url":"https://api.github.com/repos/rgayon/turbinia/stargazers","contributors_url":"https://api.github.com/repos/rgayon/turbinia/contributors","subscribers_url":"https://api.github.com/repos/rgayon/turbinia/subscribers","subscription_url":"https://api.github.com/repos/rgayon/turbinia/subscription","commits_url":"https://api.github.com/repos/rgayon/turbinia/commits{/sha}","git_commits_url":"https://api.github.com/repos/rgayon/turbinia/git/commits{/sha}","comments_url":"https://api.github.com/repos/rgayon/turbinia/comments{/number}","issue_comment_url":"https://api.github.com/repos/rgayon/turbinia/issues/comments{/number}","contents_url":"https://api.github.com/repos/rgayon/turbinia/contents/{+path}","compare_url":"https://api.github.com/repos/rgayon/turbinia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rgayon/turbinia/merges","archive_url":"https://api.github.com/repos/rgayon/turbinia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rgayon/turbinia/downloads","issues_url":"https://api.github.com/repos/rgayon/turbinia/issues{/number}","pulls_url":"https://api.github.com/repos/rgayon/turbinia/pulls{/number}","milestones_url":"https://api.github.com/repos/rgayon/turbinia/milestones{/number}","notifications_url":"https://api.github.com/repos/rgayon/turbinia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rgayon/turbinia/labels{/name}","releases_url":"https://api.github.com/repos/rgayon/turbinia/releases{/id}","deployments_url":"https://api.github.com/repos/rgayon/turbinia/deployments","created_at":"2018-08-29T16:03:21Z","updated_at":"2018-09-27T11:59:35Z","pushed_at":"2018-09-27T12:35:24Z","git_url":"git://github.com/rgayon/turbinia.git","ssh_url":"git@github.com:rgayon/turbinia.git","clone_url":"https://github.com/rgayon/turbinia.git","svn_url":"https://github.com/rgayon/turbinia","homepage":"","size":1275,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"1b94c6e7dfcd5d9da7d8cae4d95b776784fb3db3","user":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":42533053,"node_id":"MDEwOlJlcG9zaXRvcnk0MjUzMzA1Mw==","name":"turbinia","full_name":"google/turbinia","private":false,"owner":{"login":"google","id":1342004,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNDIwMDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/google/turbinia","description":"Automation and Scaling of Digital Forensics Tools","fork":false,"url":"https://api.github.com/repos/google/turbinia","forks_url":"https://api.github.com/repos/google/turbinia/forks","keys_url":"https://api.github.com/repos/google/turbinia/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/turbinia/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/turbinia/teams","hooks_url":"https://api.github.com/repos/google/turbinia/hooks","issue_events_url":"https://api.github.com/repos/google/turbinia/issues/events{/number}","events_url":"https://api.github.com/repos/google/turbinia/events","assignees_url":"https://api.github.com/repos/google/turbinia/assignees{/user}","branches_url":"https://api.github.com/repos/google/turbinia/branches{/branch}","tags_url":"https://api.github.com/repos/google/turbinia/tags","blobs_url":"https://api.github.com/repos/google/turbinia/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/turbinia/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/turbinia/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/turbinia/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/turbinia/statuses/{sha}","languages_url":"https://api.github.com/repos/google/turbinia/languages","stargazers_url":"https://api.github.com/repos/google/turbinia/stargazers","contributors_url":"https://api.github.com/repos/google/turbinia/contributors","subscribers_url":"https://api.github.com/repos/google/turbinia/subscribers","subscription_url":"https://api.github.com/repos/google/turbinia/subscription","commits_url":"https://api.github.com/repos/google/turbinia/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/turbinia/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/turbinia/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/turbinia/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/turbinia/contents/{+path}","compare_url":"https://api.github.com/repos/google/turbinia/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/turbinia/merges","archive_url":"https://api.github.com/repos/google/turbinia/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/turbinia/downloads","issues_url":"https://api.github.com/repos/google/turbinia/issues{/number}","pulls_url":"https://api.github.com/repos/google/turbinia/pulls{/number}","milestones_url":"https://api.github.com/repos/google/turbinia/milestones{/number}","notifications_url":"https://api.github.com/repos/google/turbinia/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/turbinia/labels{/name}","releases_url":"https://api.github.com/repos/google/turbinia/releases{/id}","deployments_url":"https://api.github.com/repos/google/turbinia/deployments","created_at":"2015-09-15T16:50:40Z","updated_at":"2018-09-29T06:16:44Z","pushed_at":"2018-09-28T23:55:29Z","git_url":"git://github.com/google/turbinia.git","ssh_url":"git@github.com:google/turbinia.git","clone_url":"https://github.com/google/turbinia.git","svn_url":"https://github.com/google/turbinia","homepage":"","size":1273,"stargazers_count":158,"watchers_count":158,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":true,"has_pages":false,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":58,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":33,"open_issues":58,"watchers":158,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/turbinia/pulls/261"},"html":{"href":"https://github.com/google/turbinia/pull/261"},"issue":{"href":"https://api.github.com/repos/google/turbinia/issues/261"},"comments":{"href":"https://api.github.com/repos/google/turbinia/issues/261/comments"},"review_comments":{"href":"https://api.github.com/repos/google/turbinia/pulls/261/comments"},"review_comment":{"href":"https://api.github.com/repos/google/turbinia/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/turbinia/pulls/261/commits"},"statuses":{"href":"https://api.github.com/repos/google/turbinia/statuses/5a7d5f97d1080fb69435d419f3199932ce587d62"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"rgayon"}}