{"action":"created","comment":{"url":"https://api.github.com/repos/strongbox/strongbox/pulls/comments/228527125","pull_request_review_id":168823119,"id":228527125,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODUyNzEyNQ==","diff_hunk":"@@ -0,0 +1,168 @@\n+package org.carlspring.strongbox.artifact.coordinates;\n+\n+import java.util.Map;\n+import java.util.regex.Matcher;\n+import java.util.regex.Pattern;\n+\n+import org.semver.Version;","path":"strongbox-storage/strongbox-storage-layout-providers/strongbox-storage-pypi-layout-provider/src/main/java/org/carlspring/strongbox/artifact/coordinates/PyPiArtifactCoordinates.java","position":7,"original_position":7,"commit_id":"3b7890d228acb81c7954cb521159a2dbfa4bd9b7","original_commit_id":"59c90d012aee3954e2fc34b1528cfa45e8b1c1c2","user":{"login":"ror6ax","id":2385157,"node_id":"MDQ6VXNlcjIzODUxNTc=","avatar_url":"https://avatars2.githubusercontent.com/u/2385157?v=4","gravatar_id":"","url":"https://api.github.com/users/ror6ax","html_url":"https://github.com/ror6ax","followers_url":"https://api.github.com/users/ror6ax/followers","following_url":"https://api.github.com/users/ror6ax/following{/other_user}","gists_url":"https://api.github.com/users/ror6ax/gists{/gist_id}","starred_url":"https://api.github.com/users/ror6ax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ror6ax/subscriptions","organizations_url":"https://api.github.com/users/ror6ax/orgs","repos_url":"https://api.github.com/users/ror6ax/repos","events_url":"https://api.github.com/users/ror6ax/events{/privacy}","received_events_url":"https://api.github.com/users/ror6ax/received_events","type":"User","site_admin":false},"body":"With all possible version schemes and frankly nothing holding a person from making up their own, version format is frankly not parseable. Do we just treat is as a string then?","created_at":"2018-10-26T13:30:24Z","updated_at":"2018-10-26T13:30:24Z","html_url":"https://github.com/strongbox/strongbox/pull/888#discussion_r228527125","pull_request_url":"https://api.github.com/repos/strongbox/strongbox/pulls/888","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/strongbox/strongbox/pulls/comments/228527125"},"html":{"href":"https://github.com/strongbox/strongbox/pull/888#discussion_r228527125"},"pull_request":{"href":"https://api.github.com/repos/strongbox/strongbox/pulls/888"}},"in_reply_to_id":228258383},"pull_request":{"url":"https://api.github.com/repos/strongbox/strongbox/pulls/888","id":224398642,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0Mzk4NjQy","html_url":"https://github.com/strongbox/strongbox/pull/888","diff_url":"https://github.com/strongbox/strongbox/pull/888.diff","patch_url":"https://github.com/strongbox/strongbox/pull/888.patch","issue_url":"https://api.github.com/repos/strongbox/strongbox/issues/888","number":888,"state":"open","locked":false,"title":"added PyPi coordinates","user":{"login":"ror6ax","id":2385157,"node_id":"MDQ6VXNlcjIzODUxNTc=","avatar_url":"https://avatars2.githubusercontent.com/u/2385157?v=4","gravatar_id":"","url":"https://api.github.com/users/ror6ax","html_url":"https://github.com/ror6ax","followers_url":"https://api.github.com/users/ror6ax/followers","following_url":"https://api.github.com/users/ror6ax/following{/other_user}","gists_url":"https://api.github.com/users/ror6ax/gists{/gist_id}","starred_url":"https://api.github.com/users/ror6ax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ror6ax/subscriptions","organizations_url":"https://api.github.com/users/ror6ax/orgs","repos_url":"https://api.github.com/users/ror6ax/repos","events_url":"https://api.github.com/users/ror6ax/events{/privacy}","received_events_url":"https://api.github.com/users/ror6ax/received_events","type":"User","site_admin":false},"body":"To address https://github.com/strongbox/strongbox/issues/809\r\n\r\nIt's a semi - wip and is hence pretty bumpy. Ill be happy with any remarks that you might have.\r\nOne question is whether ID is a requirement to be had? It seems like it, together with version. I went with constructing it from most common unique elements. Please let me know if that is what's supposed to happen ;)","created_at":"2018-10-19T20:15:00Z","updated_at":"2018-10-26T13:30:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"dcab1b50576dcffde7dc390b6e69cc4640b3c98f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/strongbox/strongbox/pulls/888/commits","review_comments_url":"https://api.github.com/repos/strongbox/strongbox/pulls/888/comments","review_comment_url":"https://api.github.com/repos/strongbox/strongbox/pulls/comments{/number}","comments_url":"https://api.github.com/repos/strongbox/strongbox/issues/888/comments","statuses_url":"https://api.github.com/repos/strongbox/strongbox/statuses/3b7890d228acb81c7954cb521159a2dbfa4bd9b7","head":{"label":"ror6ax:PyPiCoordinates","ref":"PyPiCoordinates","sha":"3b7890d228acb81c7954cb521159a2dbfa4bd9b7","user":{"login":"ror6ax","id":2385157,"node_id":"MDQ6VXNlcjIzODUxNTc=","avatar_url":"https://avatars2.githubusercontent.com/u/2385157?v=4","gravatar_id":"","url":"https://api.github.com/users/ror6ax","html_url":"https://github.com/ror6ax","followers_url":"https://api.github.com/users/ror6ax/followers","following_url":"https://api.github.com/users/ror6ax/following{/other_user}","gists_url":"https://api.github.com/users/ror6ax/gists{/gist_id}","starred_url":"https://api.github.com/users/ror6ax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ror6ax/subscriptions","organizations_url":"https://api.github.com/users/ror6ax/orgs","repos_url":"https://api.github.com/users/ror6ax/repos","events_url":"https://api.github.com/users/ror6ax/events{/privacy}","received_events_url":"https://api.github.com/users/ror6ax/received_events","type":"User","site_admin":false},"repo":{"id":153125854,"node_id":"MDEwOlJlcG9zaXRvcnkxNTMxMjU4NTQ=","name":"strongbox","full_name":"ror6ax/strongbox","private":false,"owner":{"login":"ror6ax","id":2385157,"node_id":"MDQ6VXNlcjIzODUxNTc=","avatar_url":"https://avatars2.githubusercontent.com/u/2385157?v=4","gravatar_id":"","url":"https://api.github.com/users/ror6ax","html_url":"https://github.com/ror6ax","followers_url":"https://api.github.com/users/ror6ax/followers","following_url":"https://api.github.com/users/ror6ax/following{/other_user}","gists_url":"https://api.github.com/users/ror6ax/gists{/gist_id}","starred_url":"https://api.github.com/users/ror6ax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ror6ax/subscriptions","organizations_url":"https://api.github.com/users/ror6ax/orgs","repos_url":"https://api.github.com/users/ror6ax/repos","events_url":"https://api.github.com/users/ror6ax/events{/privacy}","received_events_url":"https://api.github.com/users/ror6ax/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ror6ax/strongbox","description":"Strongbox is an artifact repository manager.","fork":true,"url":"https://api.github.com/repos/ror6ax/strongbox","forks_url":"https://api.github.com/repos/ror6ax/strongbox/forks","keys_url":"https://api.github.com/repos/ror6ax/strongbox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ror6ax/strongbox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ror6ax/strongbox/teams","hooks_url":"https://api.github.com/repos/ror6ax/strongbox/hooks","issue_events_url":"https://api.github.com/repos/ror6ax/strongbox/issues/events{/number}","events_url":"https://api.github.com/repos/ror6ax/strongbox/events","assignees_url":"https://api.github.com/repos/ror6ax/strongbox/assignees{/user}","branches_url":"https://api.github.com/repos/ror6ax/strongbox/branches{/branch}","tags_url":"https://api.github.com/repos/ror6ax/strongbox/tags","blobs_url":"https://api.github.com/repos/ror6ax/strongbox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ror6ax/strongbox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ror6ax/strongbox/git/refs{/sha}","trees_url":"https://api.github.com/repos/ror6ax/strongbox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ror6ax/strongbox/statuses/{sha}","languages_url":"https://api.github.com/repos/ror6ax/strongbox/languages","stargazers_url":"https://api.github.com/repos/ror6ax/strongbox/stargazers","contributors_url":"https://api.github.com/repos/ror6ax/strongbox/contributors","subscribers_url":"https://api.github.com/repos/ror6ax/strongbox/subscribers","subscription_url":"https://api.github.com/repos/ror6ax/strongbox/subscription","commits_url":"https://api.github.com/repos/ror6ax/strongbox/commits{/sha}","git_commits_url":"https://api.github.com/repos/ror6ax/strongbox/git/commits{/sha}","comments_url":"https://api.github.com/repos/ror6ax/strongbox/comments{/number}","issue_comment_url":"https://api.github.com/repos/ror6ax/strongbox/issues/comments{/number}","contents_url":"https://api.github.com/repos/ror6ax/strongbox/contents/{+path}","compare_url":"https://api.github.com/repos/ror6ax/strongbox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ror6ax/strongbox/merges","archive_url":"https://api.github.com/repos/ror6ax/strongbox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ror6ax/strongbox/downloads","issues_url":"https://api.github.com/repos/ror6ax/strongbox/issues{/number}","pulls_url":"https://api.github.com/repos/ror6ax/strongbox/pulls{/number}","milestones_url":"https://api.github.com/repos/ror6ax/strongbox/milestones{/number}","notifications_url":"https://api.github.com/repos/ror6ax/strongbox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ror6ax/strongbox/labels{/name}","releases_url":"https://api.github.com/repos/ror6ax/strongbox/releases{/id}","deployments_url":"https://api.github.com/repos/ror6ax/strongbox/deployments","created_at":"2018-10-15T14:15:31Z","updated_at":"2018-10-15T20:50:57Z","pushed_at":"2018-10-25T19:30:46Z","git_url":"git://github.com/ror6ax/strongbox.git","ssh_url":"git@github.com:ror6ax/strongbox.git","clone_url":"https://github.com/ror6ax/strongbox.git","svn_url":"https://github.com/ror6ax/strongbox","homepage":"","size":10390,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"strongbox:master","ref":"master","sha":"8e21522467d3cbc1786a354ad851d52094915170","user":{"login":"strongbox","id":5637881,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2Mzc4ODE=","avatar_url":"https://avatars0.githubusercontent.com/u/5637881?v=4","gravatar_id":"","url":"https://api.github.com/users/strongbox","html_url":"https://github.com/strongbox","followers_url":"https://api.github.com/users/strongbox/followers","following_url":"https://api.github.com/users/strongbox/following{/other_user}","gists_url":"https://api.github.com/users/strongbox/gists{/gist_id}","starred_url":"https://api.github.com/users/strongbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongbox/subscriptions","organizations_url":"https://api.github.com/users/strongbox/orgs","repos_url":"https://api.github.com/users/strongbox/repos","events_url":"https://api.github.com/users/strongbox/events{/privacy}","received_events_url":"https://api.github.com/users/strongbox/received_events","type":"Organization","site_admin":false},"repo":{"id":11830269,"node_id":"MDEwOlJlcG9zaXRvcnkxMTgzMDI2OQ==","name":"strongbox","full_name":"strongbox/strongbox","private":false,"owner":{"login":"strongbox","id":5637881,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2Mzc4ODE=","avatar_url":"https://avatars0.githubusercontent.com/u/5637881?v=4","gravatar_id":"","url":"https://api.github.com/users/strongbox","html_url":"https://github.com/strongbox","followers_url":"https://api.github.com/users/strongbox/followers","following_url":"https://api.github.com/users/strongbox/following{/other_user}","gists_url":"https://api.github.com/users/strongbox/gists{/gist_id}","starred_url":"https://api.github.com/users/strongbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strongbox/subscriptions","organizations_url":"https://api.github.com/users/strongbox/orgs","repos_url":"https://api.github.com/users/strongbox/repos","events_url":"https://api.github.com/users/strongbox/events{/privacy}","received_events_url":"https://api.github.com/users/strongbox/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/strongbox/strongbox","description":"Strongbox is an artifact repository manager.","fork":false,"url":"https://api.github.com/repos/strongbox/strongbox","forks_url":"https://api.github.com/repos/strongbox/strongbox/forks","keys_url":"https://api.github.com/repos/strongbox/strongbox/keys{/key_id}","collaborators_url":"https://api.github.com/repos/strongbox/strongbox/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/strongbox/strongbox/teams","hooks_url":"https://api.github.com/repos/strongbox/strongbox/hooks","issue_events_url":"https://api.github.com/repos/strongbox/strongbox/issues/events{/number}","events_url":"https://api.github.com/repos/strongbox/strongbox/events","assignees_url":"https://api.github.com/repos/strongbox/strongbox/assignees{/user}","branches_url":"https://api.github.com/repos/strongbox/strongbox/branches{/branch}","tags_url":"https://api.github.com/repos/strongbox/strongbox/tags","blobs_url":"https://api.github.com/repos/strongbox/strongbox/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/strongbox/strongbox/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/strongbox/strongbox/git/refs{/sha}","trees_url":"https://api.github.com/repos/strongbox/strongbox/git/trees{/sha}","statuses_url":"https://api.github.com/repos/strongbox/strongbox/statuses/{sha}","languages_url":"https://api.github.com/repos/strongbox/strongbox/languages","stargazers_url":"https://api.github.com/repos/strongbox/strongbox/stargazers","contributors_url":"https://api.github.com/repos/strongbox/strongbox/contributors","subscribers_url":"https://api.github.com/repos/strongbox/strongbox/subscribers","subscription_url":"https://api.github.com/repos/strongbox/strongbox/subscription","commits_url":"https://api.github.com/repos/strongbox/strongbox/commits{/sha}","git_commits_url":"https://api.github.com/repos/strongbox/strongbox/git/commits{/sha}","comments_url":"https://api.github.com/repos/strongbox/strongbox/comments{/number}","issue_comment_url":"https://api.github.com/repos/strongbox/strongbox/issues/comments{/number}","contents_url":"https://api.github.com/repos/strongbox/strongbox/contents/{+path}","compare_url":"https://api.github.com/repos/strongbox/strongbox/compare/{base}...{head}","merges_url":"https://api.github.com/repos/strongbox/strongbox/merges","archive_url":"https://api.github.com/repos/strongbox/strongbox/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/strongbox/strongbox/downloads","issues_url":"https://api.github.com/repos/strongbox/strongbox/issues{/number}","pulls_url":"https://api.github.com/repos/strongbox/strongbox/pulls{/number}","milestones_url":"https://api.github.com/repos/strongbox/strongbox/milestones{/number}","notifications_url":"https://api.github.com/repos/strongbox/strongbox/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/strongbox/strongbox/labels{/name}","releases_url":"https://api.github.com/repos/strongbox/strongbox/releases{/id}","deployments_url":"https://api.github.com/repos/strongbox/strongbox/deployments","created_at":"2013-08-01T23:27:37Z","updated_at":"2018-10-25T22:00:45Z","pushed_at":"2018-10-26T02:01:22Z","git_url":"git://github.com/strongbox/strongbox.git","ssh_url":"git@github.com:strongbox/strongbox.git","clone_url":"https://github.com/strongbox/strongbox.git","svn_url":"https://github.com/strongbox/strongbox","homepage":"","size":10610,"stargazers_count":46,"watchers_count":46,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":76,"mirror_url":null,"archived":false,"open_issues_count":123,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":76,"open_issues":123,"watchers":46,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/strongbox/strongbox/pulls/888"},"html":{"href":"https://github.com/strongbox/strongbox/pull/888"},"issue":{"href":"https://api.github.com/repos/strongbox/strongbox/issues/888"},"comments":{"href":"https://api.github.com/repos/strongbox/strongbox/issues/888/comments"},"review_comments":{"href":"https://api.github.com/repos/strongbox/strongbox/pulls/888/comments"},"review_comment":{"href":"https://api.github.com/repos/strongbox/strongbox/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/strongbox/strongbox/pulls/888/commits"},"statuses":{"href":"https://api.github.com/repos/strongbox/strongbox/statuses/3b7890d228acb81c7954cb521159a2dbfa4bd9b7"}},"author_association":"NONE"}}
{"actor":{"display_login":"ror6ax"}}