{"action":"created","comment":{"url":"https://api.github.com/repos/istio/istio/pulls/comments/215837089","pull_request_review_id":153192709,"id":215837089,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTgzNzA4OQ==","diff_hunk":"@@ -87,6 +87,11 @@ type Server struct {\n // this case and apply appropriate policy.\n type AuthChecker interface {\n \tCheck(authInfo credentials.AuthInfo) error\n+\t// ShouldRecordFailure is to rate limit auth check failures\n+\t// to avoid flooding logs with duplicate information.\n+\t// it returns with bool and int value that indicate failure counts\n+\t// since last time.\n+\tShouldRecordFailure() (bool, int)","path":"pkg/mcp/server/server.go","position":8,"original_position":8,"commit_id":"7e008009afc96a9c2588a316e6a5db8ec76358a0","original_commit_id":"7e008009afc96a9c2588a316e6a5db8ec76358a0","user":{"login":"lichuqiang","id":12265352,"node_id":"MDQ6VXNlcjEyMjY1MzUy","avatar_url":"https://avatars3.githubusercontent.com/u/12265352?v=4","gravatar_id":"","url":"https://api.github.com/users/lichuqiang","html_url":"https://github.com/lichuqiang","followers_url":"https://api.github.com/users/lichuqiang/followers","following_url":"https://api.github.com/users/lichuqiang/following{/other_user}","gists_url":"https://api.github.com/users/lichuqiang/gists{/gist_id}","starred_url":"https://api.github.com/users/lichuqiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lichuqiang/subscriptions","organizations_url":"https://api.github.com/users/lichuqiang/orgs","repos_url":"https://api.github.com/users/lichuqiang/repos","events_url":"https://api.github.com/users/lichuqiang/events{/privacy}","received_events_url":"https://api.github.com/users/lichuqiang/received_events","type":"User","site_admin":false},"body":"> We should use https://godoc.org/golang.org/x/time/rate instead of re-implementing our own rate limiting code\r\n\r\nThe limiter limits number of events *per second*, won't it be too frequent for us here?","created_at":"2018-09-07T03:28:29Z","updated_at":"2018-09-07T03:28:30Z","html_url":"https://github.com/istio/istio/pull/8518#discussion_r215837089","pull_request_url":"https://api.github.com/repos/istio/istio/pulls/8518","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/comments/215837089"},"html":{"href":"https://github.com/istio/istio/pull/8518#discussion_r215837089"},"pull_request":{"href":"https://api.github.com/repos/istio/istio/pulls/8518"}},"in_reply_to_id":215694992},"pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/8518","id":213518631,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNTE4NjMx","html_url":"https://github.com/istio/istio/pull/8518","diff_url":"https://github.com/istio/istio/pull/8518.diff","patch_url":"https://github.com/istio/istio/pull/8518.patch","issue_url":"https://api.github.com/repos/istio/istio/issues/8518","number":8518,"state":"open","locked":false,"title":"rate limit MCP auth check handler failures","user":{"login":"lichuqiang","id":12265352,"node_id":"MDQ6VXNlcjEyMjY1MzUy","avatar_url":"https://avatars3.githubusercontent.com/u/12265352?v=4","gravatar_id":"","url":"https://api.github.com/users/lichuqiang","html_url":"https://github.com/lichuqiang","followers_url":"https://api.github.com/users/lichuqiang/followers","following_url":"https://api.github.com/users/lichuqiang/following{/other_user}","gists_url":"https://api.github.com/users/lichuqiang/gists{/gist_id}","starred_url":"https://api.github.com/users/lichuqiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lichuqiang/subscriptions","organizations_url":"https://api.github.com/users/lichuqiang/orgs","repos_url":"https://api.github.com/users/lichuqiang/repos","events_url":"https://api.github.com/users/lichuqiang/events{/privacy}","received_events_url":"https://api.github.com/users/lichuqiang/received_events","type":"User","site_admin":false},"body":"To fix #8470 \r\n\r\n/assign @ayj ","created_at":"2018-09-06T07:23:03Z","updated_at":"2018-09-07T03:28:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5edca7254c8a14100bf89c6e6d6bdc83c627668","assignee":{"login":"ayj","id":116378,"node_id":"MDQ6VXNlcjExNjM3OA==","avatar_url":"https://avatars1.githubusercontent.com/u/116378?v=4","gravatar_id":"","url":"https://api.github.com/users/ayj","html_url":"https://github.com/ayj","followers_url":"https://api.github.com/users/ayj/followers","following_url":"https://api.github.com/users/ayj/following{/other_user}","gists_url":"https://api.github.com/users/ayj/gists{/gist_id}","starred_url":"https://api.github.com/users/ayj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ayj/subscriptions","organizations_url":"https://api.github.com/users/ayj/orgs","repos_url":"https://api.github.com/users/ayj/repos","events_url":"https://api.github.com/users/ayj/events{/privacy}","received_events_url":"https://api.github.com/users/ayj/received_events","type":"User","site_admin":false},"assignees":[{"login":"ayj","id":116378,"node_id":"MDQ6VXNlcjExNjM3OA==","avatar_url":"https://avatars1.githubusercontent.com/u/116378?v=4","gravatar_id":"","url":"https://api.github.com/users/ayj","html_url":"https://github.com/ayj","followers_url":"https://api.github.com/users/ayj/followers","following_url":"https://api.github.com/users/ayj/following{/other_user}","gists_url":"https://api.github.com/users/ayj/gists{/gist_id}","starred_url":"https://api.github.com/users/ayj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ayj/subscriptions","organizations_url":"https://api.github.com/users/ayj/orgs","repos_url":"https://api.github.com/users/ayj/repos","events_url":"https://api.github.com/users/ayj/events{/privacy}","received_events_url":"https://api.github.com/users/ayj/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":491318011,"node_id":"MDU6TGFiZWw0OTEzMTgwMTE=","url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/istio/istio/pulls/8518/commits","review_comments_url":"https://api.github.com/repos/istio/istio/pulls/8518/comments","review_comment_url":"https://api.github.com/repos/istio/istio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/istio/istio/issues/8518/comments","statuses_url":"https://api.github.com/repos/istio/istio/statuses/7e008009afc96a9c2588a316e6a5db8ec76358a0","head":{"label":"lichuqiang:ratelimit1","ref":"ratelimit1","sha":"7e008009afc96a9c2588a316e6a5db8ec76358a0","user":{"login":"lichuqiang","id":12265352,"node_id":"MDQ6VXNlcjEyMjY1MzUy","avatar_url":"https://avatars3.githubusercontent.com/u/12265352?v=4","gravatar_id":"","url":"https://api.github.com/users/lichuqiang","html_url":"https://github.com/lichuqiang","followers_url":"https://api.github.com/users/lichuqiang/followers","following_url":"https://api.github.com/users/lichuqiang/following{/other_user}","gists_url":"https://api.github.com/users/lichuqiang/gists{/gist_id}","starred_url":"https://api.github.com/users/lichuqiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lichuqiang/subscriptions","organizations_url":"https://api.github.com/users/lichuqiang/orgs","repos_url":"https://api.github.com/users/lichuqiang/repos","events_url":"https://api.github.com/users/lichuqiang/events{/privacy}","received_events_url":"https://api.github.com/users/lichuqiang/received_events","type":"User","site_admin":false},"repo":{"id":126926498,"node_id":"MDEwOlJlcG9zaXRvcnkxMjY5MjY0OTg=","name":"istio","full_name":"lichuqiang/istio","owner":{"login":"lichuqiang","id":12265352,"node_id":"MDQ6VXNlcjEyMjY1MzUy","avatar_url":"https://avatars3.githubusercontent.com/u/12265352?v=4","gravatar_id":"","url":"https://api.github.com/users/lichuqiang","html_url":"https://github.com/lichuqiang","followers_url":"https://api.github.com/users/lichuqiang/followers","following_url":"https://api.github.com/users/lichuqiang/following{/other_user}","gists_url":"https://api.github.com/users/lichuqiang/gists{/gist_id}","starred_url":"https://api.github.com/users/lichuqiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lichuqiang/subscriptions","organizations_url":"https://api.github.com/users/lichuqiang/orgs","repos_url":"https://api.github.com/users/lichuqiang/repos","events_url":"https://api.github.com/users/lichuqiang/events{/privacy}","received_events_url":"https://api.github.com/users/lichuqiang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lichuqiang/istio","description":"An open platform to connect, manage, and secure microservices.","fork":true,"url":"https://api.github.com/repos/lichuqiang/istio","forks_url":"https://api.github.com/repos/lichuqiang/istio/forks","keys_url":"https://api.github.com/repos/lichuqiang/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lichuqiang/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lichuqiang/istio/teams","hooks_url":"https://api.github.com/repos/lichuqiang/istio/hooks","issue_events_url":"https://api.github.com/repos/lichuqiang/istio/issues/events{/number}","events_url":"https://api.github.com/repos/lichuqiang/istio/events","assignees_url":"https://api.github.com/repos/lichuqiang/istio/assignees{/user}","branches_url":"https://api.github.com/repos/lichuqiang/istio/branches{/branch}","tags_url":"https://api.github.com/repos/lichuqiang/istio/tags","blobs_url":"https://api.github.com/repos/lichuqiang/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lichuqiang/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lichuqiang/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/lichuqiang/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lichuqiang/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/lichuqiang/istio/languages","stargazers_url":"https://api.github.com/repos/lichuqiang/istio/stargazers","contributors_url":"https://api.github.com/repos/lichuqiang/istio/contributors","subscribers_url":"https://api.github.com/repos/lichuqiang/istio/subscribers","subscription_url":"https://api.github.com/repos/lichuqiang/istio/subscription","commits_url":"https://api.github.com/repos/lichuqiang/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/lichuqiang/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/lichuqiang/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/lichuqiang/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/lichuqiang/istio/contents/{+path}","compare_url":"https://api.github.com/repos/lichuqiang/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lichuqiang/istio/merges","archive_url":"https://api.github.com/repos/lichuqiang/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lichuqiang/istio/downloads","issues_url":"https://api.github.com/repos/lichuqiang/istio/issues{/number}","pulls_url":"https://api.github.com/repos/lichuqiang/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/lichuqiang/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/lichuqiang/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lichuqiang/istio/labels{/name}","releases_url":"https://api.github.com/repos/lichuqiang/istio/releases{/id}","deployments_url":"https://api.github.com/repos/lichuqiang/istio/deployments","created_at":"2018-03-27T03:58:29Z","updated_at":"2018-08-10T03:26:25Z","pushed_at":"2018-09-07T02:24:24Z","git_url":"git://github.com/lichuqiang/istio.git","ssh_url":"git@github.com:lichuqiang/istio.git","clone_url":"https://github.com/lichuqiang/istio.git","svn_url":"https://github.com/lichuqiang/istio","homepage":"https://istio.io","size":46904,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"istio:master","ref":"master","sha":"909468090bb552387fa62fe0341698d4dfb2ee04","user":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"repo":{"id":74175805,"node_id":"MDEwOlJlcG9zaXRvcnk3NDE3NTgwNQ==","name":"istio","full_name":"istio/istio","owner":{"login":"istio","id":23534644,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzNTM0NjQ0","avatar_url":"https://avatars1.githubusercontent.com/u/23534644?v=4","gravatar_id":"","url":"https://api.github.com/users/istio","html_url":"https://github.com/istio","followers_url":"https://api.github.com/users/istio/followers","following_url":"https://api.github.com/users/istio/following{/other_user}","gists_url":"https://api.github.com/users/istio/gists{/gist_id}","starred_url":"https://api.github.com/users/istio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/istio/subscriptions","organizations_url":"https://api.github.com/users/istio/orgs","repos_url":"https://api.github.com/users/istio/repos","events_url":"https://api.github.com/users/istio/events{/privacy}","received_events_url":"https://api.github.com/users/istio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/istio/istio","description":"Connect, secure, control, and observe services.","fork":false,"url":"https://api.github.com/repos/istio/istio","forks_url":"https://api.github.com/repos/istio/istio/forks","keys_url":"https://api.github.com/repos/istio/istio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/istio/istio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/istio/istio/teams","hooks_url":"https://api.github.com/repos/istio/istio/hooks","issue_events_url":"https://api.github.com/repos/istio/istio/issues/events{/number}","events_url":"https://api.github.com/repos/istio/istio/events","assignees_url":"https://api.github.com/repos/istio/istio/assignees{/user}","branches_url":"https://api.github.com/repos/istio/istio/branches{/branch}","tags_url":"https://api.github.com/repos/istio/istio/tags","blobs_url":"https://api.github.com/repos/istio/istio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/istio/istio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/istio/istio/git/refs{/sha}","trees_url":"https://api.github.com/repos/istio/istio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/istio/istio/statuses/{sha}","languages_url":"https://api.github.com/repos/istio/istio/languages","stargazers_url":"https://api.github.com/repos/istio/istio/stargazers","contributors_url":"https://api.github.com/repos/istio/istio/contributors","subscribers_url":"https://api.github.com/repos/istio/istio/subscribers","subscription_url":"https://api.github.com/repos/istio/istio/subscription","commits_url":"https://api.github.com/repos/istio/istio/commits{/sha}","git_commits_url":"https://api.github.com/repos/istio/istio/git/commits{/sha}","comments_url":"https://api.github.com/repos/istio/istio/comments{/number}","issue_comment_url":"https://api.github.com/repos/istio/istio/issues/comments{/number}","contents_url":"https://api.github.com/repos/istio/istio/contents/{+path}","compare_url":"https://api.github.com/repos/istio/istio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/istio/istio/merges","archive_url":"https://api.github.com/repos/istio/istio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/istio/istio/downloads","issues_url":"https://api.github.com/repos/istio/istio/issues{/number}","pulls_url":"https://api.github.com/repos/istio/istio/pulls{/number}","milestones_url":"https://api.github.com/repos/istio/istio/milestones{/number}","notifications_url":"https://api.github.com/repos/istio/istio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/istio/istio/labels{/name}","releases_url":"https://api.github.com/repos/istio/istio/releases{/id}","deployments_url":"https://api.github.com/repos/istio/istio/deployments","created_at":"2016-11-18T23:57:21Z","updated_at":"2018-09-07T03:24:03Z","pushed_at":"2018-09-07T03:23:42Z","git_url":"git://github.com/istio/istio.git","ssh_url":"git@github.com:istio/istio.git","clone_url":"https://github.com/istio/istio.git","svn_url":"https://github.com/istio/istio","homepage":"https://istio.io","size":47876,"stargazers_count":11462,"watchers_count":11462,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1668,"mirror_url":null,"archived":false,"open_issues_count":888,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1668,"open_issues":888,"watchers":11462,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/istio/istio/pulls/8518"},"html":{"href":"https://github.com/istio/istio/pull/8518"},"issue":{"href":"https://api.github.com/repos/istio/istio/issues/8518"},"comments":{"href":"https://api.github.com/repos/istio/istio/issues/8518/comments"},"review_comments":{"href":"https://api.github.com/repos/istio/istio/pulls/8518/comments"},"review_comment":{"href":"https://api.github.com/repos/istio/istio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/istio/istio/pulls/8518/commits"},"statuses":{"href":"https://api.github.com/repos/istio/istio/statuses/7e008009afc96a9c2588a316e6a5db8ec76358a0"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"lichuqiang"}}