{"action":"created","issue":{"url":"https://api.github.com/repos/pytest-dev/pytest-xdist/issues/344","repository_url":"https://api.github.com/repos/pytest-dev/pytest-xdist","labels_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/issues/344/labels{/name}","comments_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/issues/344/comments","events_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/issues/344/events","html_url":"https://github.com/pytest-dev/pytest-xdist/issues/344","id":364108831,"node_id":"MDU6SXNzdWUzNjQxMDg4MzE=","number":344,"title":"Warning subclass which break subclassing protocol break xdist","user":{"login":"BrandonHoffman","id":2158257,"node_id":"MDQ6VXNlcjIxNTgyNTc=","avatar_url":"https://avatars0.githubusercontent.com/u/2158257?v=4","gravatar_id":"","url":"https://api.github.com/users/BrandonHoffman","html_url":"https://github.com/BrandonHoffman","followers_url":"https://api.github.com/users/BrandonHoffman/followers","following_url":"https://api.github.com/users/BrandonHoffman/following{/other_user}","gists_url":"https://api.github.com/users/BrandonHoffman/gists{/gist_id}","starred_url":"https://api.github.com/users/BrandonHoffman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BrandonHoffman/subscriptions","organizations_url":"https://api.github.com/users/BrandonHoffman/orgs","repos_url":"https://api.github.com/users/BrandonHoffman/repos","events_url":"https://api.github.com/users/BrandonHoffman/events{/privacy}","received_events_url":"https://api.github.com/users/BrandonHoffman/received_events","type":"User","site_admin":false},"labels":[{"id":255239944,"node_id":"MDU6TGFiZWwyNTUyMzk5NDQ=","url":"https://api.github.com/repos/pytest-dev/pytest-xdist/labels/bug","name":"bug","color":"fc2929","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-09-26T16:14:51Z","updated_at":"2018-09-26T17:38:34Z","closed_at":null,"author_association":"NONE","body":"The latest xdist change causes issues whenever a subclass of the Warning class which does not set the args property due to this line: https://github.com/nicoddemus/pytest-xdist/commit/eb81450915528976cea8372bbc4c41cb7e82e9d1#diff-cb98e0a92df3b797a1570a6e1a49b8d6R429\r\n\r\nsee the issue I created for an example: https://github.com/briancurtin/deprecation/issues/36\r\n\r\nI think it would be a good to add some error handling for cases like this in xdist so that they do not cause pytest to fail with an internal error."},"comment":{"url":"https://api.github.com/repos/pytest-dev/pytest-xdist/issues/comments/424805566","html_url":"https://github.com/pytest-dev/pytest-xdist/issues/344#issuecomment-424805566","issue_url":"https://api.github.com/repos/pytest-dev/pytest-xdist/issues/344","id":424805566,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNDgwNTU2Ng==","user":{"login":"nicoddemus","id":1085180,"node_id":"MDQ6VXNlcjEwODUxODA=","avatar_url":"https://avatars2.githubusercontent.com/u/1085180?v=4","gravatar_id":"","url":"https://api.github.com/users/nicoddemus","html_url":"https://github.com/nicoddemus","followers_url":"https://api.github.com/users/nicoddemus/followers","following_url":"https://api.github.com/users/nicoddemus/following{/other_user}","gists_url":"https://api.github.com/users/nicoddemus/gists{/gist_id}","starred_url":"https://api.github.com/users/nicoddemus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicoddemus/subscriptions","organizations_url":"https://api.github.com/users/nicoddemus/orgs","repos_url":"https://api.github.com/users/nicoddemus/repos","events_url":"https://api.github.com/users/nicoddemus/events{/privacy}","received_events_url":"https://api.github.com/users/nicoddemus/received_events","type":"User","site_admin":false},"created_at":"2018-09-26T17:38:34Z","updated_at":"2018-09-26T17:38:34Z","author_association":"MEMBER","body":"@BrandonHoffman I'm fine with implementing a quick workaround like the one you mention. Would you like to open a PR with that? I'm afraid I'll be short on time on the next few days to work on that PR.\r\n\r\n> also setstate/getstate, it basically requires a safe serialize/de-serialize just like we need it for reports as well - this is something that takes quite a while to get right\r\n\r\nMy feelings exactly."}}
{"actor":{"display_login":"nicoddemus"}}