{"action":"created","comment":{"url":"https://api.github.com/repos/mixxxdj/buildserver/pulls/comments/189493583","pull_request_review_id":121681553,"id":189493583,"diff_hunk":"@@ -0,0 +1,38 @@\n+#!/bin/bash\n+\n+# Echo commands\n+set -x\n+\n+# Quit on errors\n+set -e\n+\n+# Get the path to our scripts folder.\n+pushd `dirname $0` > /dev/null\n+PROGDIR=`pwd -P`\n+popd > /dev/null\n+\n+export VERSION_NUMBER=1.14.0\n+export VERSION=lv2-${VERSION_NUMBER}\n+export ARCHIVE=$VERSION.tar.bz2\n+\n+echo \"Building $VERSION for $MIXXX_ENVIRONMENT_NAME for architectures: ${MIXXX_ARCHS[@]}\"\n+\n+for ARCH in ${MIXXX_ARCHS[@]}\n+do\n+  mkdir -p $VERSION-$ARCH\n+  tar -jxf $DEPENDENCIES/$ARCHIVE -C $VERSION-$ARCH --strip-components 1\n+  cd $VERSION-$ARCH\n+  source $PROGDIR/environment.sh $ARCH\n+\n+  ./waf configure build --lv2dir \"$MIXXX_PREFIX/Library/Audio/Plug-Ins/LV2\" --prefix=\"$MIXXX_PREFIX\" --no-plugins","path":"scripts/macosx/build_lv2.sh","position":27,"original_position":27,"commit_id":"a3c289a63cb444452d15afefae4ed11b761ece09","original_commit_id":"a3c289a63cb444452d15afefae4ed11b761ece09","user":{"login":"rryan","id":26527,"avatar_url":"https://avatars3.githubusercontent.com/u/26527?v=4","gravatar_id":"","url":"https://api.github.com/users/rryan","html_url":"https://github.com/rryan","followers_url":"https://api.github.com/users/rryan/followers","following_url":"https://api.github.com/users/rryan/following{/other_user}","gists_url":"https://api.github.com/users/rryan/gists{/gist_id}","starred_url":"https://api.github.com/users/rryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rryan/subscriptions","organizations_url":"https://api.github.com/users/rryan/orgs","repos_url":"https://api.github.com/users/rryan/repos","events_url":"https://api.github.com/users/rryan/events{/privacy}","received_events_url":"https://api.github.com/users/rryan/received_events","type":"User","site_admin":false},"body":"If you don't set --lvd2dir then this installer script tries to install a bunch of manifest junk to /Library/Audio/Plug-Ins/LV2 on the build VM, so I changed it to $PREFIX//Library/Audio/Plug-Ins/LV2. I don't know what we're supposed to do with these manifests -- does Mixxx need to install them on the user's computer? We don't have an installer on macOS, the user just drops the Mixxx.app bundle into /Applications.","created_at":"2018-05-21T04:36:04Z","updated_at":"2018-05-21T04:36:04Z","html_url":"https://github.com/mixxxdj/buildserver/pull/43#discussion_r189493583","pull_request_url":"https://api.github.com/repos/mixxxdj/buildserver/pulls/43","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mixxxdj/buildserver/pulls/comments/189493583"},"html":{"href":"https://github.com/mixxxdj/buildserver/pull/43#discussion_r189493583"},"pull_request":{"href":"https://api.github.com/repos/mixxxdj/buildserver/pulls/43"}},"in_reply_to_id":189492127},"pull_request":{"url":"https://api.github.com/repos/mixxxdj/buildserver/pulls/43","id":189274492,"html_url":"https://github.com/mixxxdj/buildserver/pull/43","diff_url":"https://github.com/mixxxdj/buildserver/pull/43.diff","patch_url":"https://github.com/mixxxdj/buildserver/pull/43.patch","issue_url":"https://api.github.com/repos/mixxxdj/buildserver/issues/43","number":43,"state":"open","locked":false,"title":"Add lv2, serd, sord, sratom, and lilv support to macOS build. #15","user":{"login":"rryan","id":26527,"avatar_url":"https://avatars3.githubusercontent.com/u/26527?v=4","gravatar_id":"","url":"https://api.github.com/users/rryan","html_url":"https://github.com/rryan","followers_url":"https://api.github.com/users/rryan/followers","following_url":"https://api.github.com/users/rryan/following{/other_user}","gists_url":"https://api.github.com/users/rryan/gists{/gist_id}","starred_url":"https://api.github.com/users/rryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rryan/subscriptions","organizations_url":"https://api.github.com/users/rryan/orgs","repos_url":"https://api.github.com/users/rryan/repos","events_url":"https://api.github.com/users/rryan/events{/privacy}","received_events_url":"https://api.github.com/users/rryan/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-05-21T03:25:37Z","updated_at":"2018-05-21T04:36:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e9c4add34f2d6a80522e2accb2f76f61c24146a6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mixxxdj/buildserver/pulls/43/commits","review_comments_url":"https://api.github.com/repos/mixxxdj/buildserver/pulls/43/comments","review_comment_url":"https://api.github.com/repos/mixxxdj/buildserver/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mixxxdj/buildserver/issues/43/comments","statuses_url":"https://api.github.com/repos/mixxxdj/buildserver/statuses/a3c289a63cb444452d15afefae4ed11b761ece09","head":{"label":"rryan:lilv","ref":"lilv","sha":"a3c289a63cb444452d15afefae4ed11b761ece09","user":{"login":"rryan","id":26527,"avatar_url":"https://avatars3.githubusercontent.com/u/26527?v=4","gravatar_id":"","url":"https://api.github.com/users/rryan","html_url":"https://github.com/rryan","followers_url":"https://api.github.com/users/rryan/followers","following_url":"https://api.github.com/users/rryan/following{/other_user}","gists_url":"https://api.github.com/users/rryan/gists{/gist_id}","starred_url":"https://api.github.com/users/rryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rryan/subscriptions","organizations_url":"https://api.github.com/users/rryan/orgs","repos_url":"https://api.github.com/users/rryan/repos","events_url":"https://api.github.com/users/rryan/events{/privacy}","received_events_url":"https://api.github.com/users/rryan/received_events","type":"User","site_admin":false},"repo":{"id":77336053,"name":"buildserver","full_name":"rryan/buildserver","owner":{"login":"rryan","id":26527,"avatar_url":"https://avatars3.githubusercontent.com/u/26527?v=4","gravatar_id":"","url":"https://api.github.com/users/rryan","html_url":"https://github.com/rryan","followers_url":"https://api.github.com/users/rryan/followers","following_url":"https://api.github.com/users/rryan/following{/other_user}","gists_url":"https://api.github.com/users/rryan/gists{/gist_id}","starred_url":"https://api.github.com/users/rryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rryan/subscriptions","organizations_url":"https://api.github.com/users/rryan/orgs","repos_url":"https://api.github.com/users/rryan/repos","events_url":"https://api.github.com/users/rryan/events{/privacy}","received_events_url":"https://api.github.com/users/rryan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rryan/buildserver","description":"Tools for managing the Mixxx build server and build VMs.","fork":true,"url":"https://api.github.com/repos/rryan/buildserver","forks_url":"https://api.github.com/repos/rryan/buildserver/forks","keys_url":"https://api.github.com/repos/rryan/buildserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rryan/buildserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rryan/buildserver/teams","hooks_url":"https://api.github.com/repos/rryan/buildserver/hooks","issue_events_url":"https://api.github.com/repos/rryan/buildserver/issues/events{/number}","events_url":"https://api.github.com/repos/rryan/buildserver/events","assignees_url":"https://api.github.com/repos/rryan/buildserver/assignees{/user}","branches_url":"https://api.github.com/repos/rryan/buildserver/branches{/branch}","tags_url":"https://api.github.com/repos/rryan/buildserver/tags","blobs_url":"https://api.github.com/repos/rryan/buildserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rryan/buildserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rryan/buildserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/rryan/buildserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rryan/buildserver/statuses/{sha}","languages_url":"https://api.github.com/repos/rryan/buildserver/languages","stargazers_url":"https://api.github.com/repos/rryan/buildserver/stargazers","contributors_url":"https://api.github.com/repos/rryan/buildserver/contributors","subscribers_url":"https://api.github.com/repos/rryan/buildserver/subscribers","subscription_url":"https://api.github.com/repos/rryan/buildserver/subscription","commits_url":"https://api.github.com/repos/rryan/buildserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/rryan/buildserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/rryan/buildserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/rryan/buildserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/rryan/buildserver/contents/{+path}","compare_url":"https://api.github.com/repos/rryan/buildserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rryan/buildserver/merges","archive_url":"https://api.github.com/repos/rryan/buildserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rryan/buildserver/downloads","issues_url":"https://api.github.com/repos/rryan/buildserver/issues{/number}","pulls_url":"https://api.github.com/repos/rryan/buildserver/pulls{/number}","milestones_url":"https://api.github.com/repos/rryan/buildserver/milestones{/number}","notifications_url":"https://api.github.com/repos/rryan/buildserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rryan/buildserver/labels{/name}","releases_url":"https://api.github.com/repos/rryan/buildserver/releases{/id}","deployments_url":"https://api.github.com/repos/rryan/buildserver/deployments","created_at":"2016-12-25T17:26:51Z","updated_at":"2016-12-25T17:26:53Z","pushed_at":"2018-05-21T03:23:38Z","git_url":"git://github.com/rryan/buildserver.git","ssh_url":"git@github.com:rryan/buildserver.git","clone_url":"https://github.com/rryan/buildserver.git","svn_url":"https://github.com/rryan/buildserver","homepage":null,"size":298607,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mixxxdj:2.2.x-unix","ref":"2.2.x-unix","sha":"3ba7040be8725142e81628e7f04526da2ed1628d","user":{"login":"mixxxdj","id":1743769,"avatar_url":"https://avatars3.githubusercontent.com/u/1743769?v=4","gravatar_id":"","url":"https://api.github.com/users/mixxxdj","html_url":"https://github.com/mixxxdj","followers_url":"https://api.github.com/users/mixxxdj/followers","following_url":"https://api.github.com/users/mixxxdj/following{/other_user}","gists_url":"https://api.github.com/users/mixxxdj/gists{/gist_id}","starred_url":"https://api.github.com/users/mixxxdj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixxxdj/subscriptions","organizations_url":"https://api.github.com/users/mixxxdj/orgs","repos_url":"https://api.github.com/users/mixxxdj/repos","events_url":"https://api.github.com/users/mixxxdj/events{/privacy}","received_events_url":"https://api.github.com/users/mixxxdj/received_events","type":"Organization","site_admin":false},"repo":{"id":19151449,"name":"buildserver","full_name":"mixxxdj/buildserver","owner":{"login":"mixxxdj","id":1743769,"avatar_url":"https://avatars3.githubusercontent.com/u/1743769?v=4","gravatar_id":"","url":"https://api.github.com/users/mixxxdj","html_url":"https://github.com/mixxxdj","followers_url":"https://api.github.com/users/mixxxdj/followers","following_url":"https://api.github.com/users/mixxxdj/following{/other_user}","gists_url":"https://api.github.com/users/mixxxdj/gists{/gist_id}","starred_url":"https://api.github.com/users/mixxxdj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixxxdj/subscriptions","organizations_url":"https://api.github.com/users/mixxxdj/orgs","repos_url":"https://api.github.com/users/mixxxdj/repos","events_url":"https://api.github.com/users/mixxxdj/events{/privacy}","received_events_url":"https://api.github.com/users/mixxxdj/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mixxxdj/buildserver","description":"Tools for managing the Mixxx build server and build VMs.","fork":false,"url":"https://api.github.com/repos/mixxxdj/buildserver","forks_url":"https://api.github.com/repos/mixxxdj/buildserver/forks","keys_url":"https://api.github.com/repos/mixxxdj/buildserver/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mixxxdj/buildserver/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mixxxdj/buildserver/teams","hooks_url":"https://api.github.com/repos/mixxxdj/buildserver/hooks","issue_events_url":"https://api.github.com/repos/mixxxdj/buildserver/issues/events{/number}","events_url":"https://api.github.com/repos/mixxxdj/buildserver/events","assignees_url":"https://api.github.com/repos/mixxxdj/buildserver/assignees{/user}","branches_url":"https://api.github.com/repos/mixxxdj/buildserver/branches{/branch}","tags_url":"https://api.github.com/repos/mixxxdj/buildserver/tags","blobs_url":"https://api.github.com/repos/mixxxdj/buildserver/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mixxxdj/buildserver/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mixxxdj/buildserver/git/refs{/sha}","trees_url":"https://api.github.com/repos/mixxxdj/buildserver/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mixxxdj/buildserver/statuses/{sha}","languages_url":"https://api.github.com/repos/mixxxdj/buildserver/languages","stargazers_url":"https://api.github.com/repos/mixxxdj/buildserver/stargazers","contributors_url":"https://api.github.com/repos/mixxxdj/buildserver/contributors","subscribers_url":"https://api.github.com/repos/mixxxdj/buildserver/subscribers","subscription_url":"https://api.github.com/repos/mixxxdj/buildserver/subscription","commits_url":"https://api.github.com/repos/mixxxdj/buildserver/commits{/sha}","git_commits_url":"https://api.github.com/repos/mixxxdj/buildserver/git/commits{/sha}","comments_url":"https://api.github.com/repos/mixxxdj/buildserver/comments{/number}","issue_comment_url":"https://api.github.com/repos/mixxxdj/buildserver/issues/comments{/number}","contents_url":"https://api.github.com/repos/mixxxdj/buildserver/contents/{+path}","compare_url":"https://api.github.com/repos/mixxxdj/buildserver/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mixxxdj/buildserver/merges","archive_url":"https://api.github.com/repos/mixxxdj/buildserver/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mixxxdj/buildserver/downloads","issues_url":"https://api.github.com/repos/mixxxdj/buildserver/issues{/number}","pulls_url":"https://api.github.com/repos/mixxxdj/buildserver/pulls{/number}","milestones_url":"https://api.github.com/repos/mixxxdj/buildserver/milestones{/number}","notifications_url":"https://api.github.com/repos/mixxxdj/buildserver/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mixxxdj/buildserver/labels{/name}","releases_url":"https://api.github.com/repos/mixxxdj/buildserver/releases{/id}","deployments_url":"https://api.github.com/repos/mixxxdj/buildserver/deployments","created_at":"2014-04-25T15:48:27Z","updated_at":"2018-05-19T18:18:03Z","pushed_at":"2018-05-21T03:25:38Z","git_url":"git://github.com/mixxxdj/buildserver.git","ssh_url":"git@github.com:mixxxdj/buildserver.git","clone_url":"https://github.com/mixxxdj/buildserver.git","svn_url":"https://github.com/mixxxdj/buildserver","homepage":null,"size":298608,"stargazers_count":9,"watchers_count":9,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":17,"license":null,"forks":20,"open_issues":17,"watchers":9,"default_branch":"2.2.x-unix"}},"_links":{"self":{"href":"https://api.github.com/repos/mixxxdj/buildserver/pulls/43"},"html":{"href":"https://github.com/mixxxdj/buildserver/pull/43"},"issue":{"href":"https://api.github.com/repos/mixxxdj/buildserver/issues/43"},"comments":{"href":"https://api.github.com/repos/mixxxdj/buildserver/issues/43/comments"},"review_comments":{"href":"https://api.github.com/repos/mixxxdj/buildserver/pulls/43/comments"},"review_comment":{"href":"https://api.github.com/repos/mixxxdj/buildserver/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mixxxdj/buildserver/pulls/43/commits"},"statuses":{"href":"https://api.github.com/repos/mixxxdj/buildserver/statuses/a3c289a63cb444452d15afefae4ed11b761ece09"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"rryan"}}