{"action":"created","comment":{"url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/pulls/comments/210269814","pull_request_review_id":146446431,"id":210269814,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDI2OTgxNA==","diff_hunk":"@@ -149,12 +147,12 @@ class AppConverters {\n     }\n \n     @TypeConverter\n-    fun fromDateTime(localDateTime: LocalDateTime?): Long? = localDateTime?.let {\n-        it.toInstant(ZoneId.systemDefault().rules.getOffset(it)).toEpochMilli()\n+    fun fromDateTime(input: ZonedDateTime?): String? = input?.let {\n+        it.toString()\n     }\n \n     @TypeConverter\n-    fun toDateTime(time: Long?): LocalDateTime? = time?.let { LocalDateTime.ofInstant(Instant.ofEpochMilli(it), ZoneId.systemDefault()) }\n+    fun toDateTime(time: String?): ZonedDateTime? = time?.let { DateTimeFormatter.ISO_DATE_TIME.parse(it, ZonedDateTime.FROM) }","path":"db/src/main/kotlin/edu/artic/db/AppConverters.kt","position":33,"original_position":33,"commit_id":"9137e688add441fdb51eaaa738882630d0799248","original_commit_id":"9137e688add441fdb51eaaa738882630d0799248","user":{"login":"agrosner","id":2117859,"node_id":"MDQ6VXNlcjIxMTc4NTk=","avatar_url":"https://avatars3.githubusercontent.com/u/2117859?v=4","gravatar_id":"","url":"https://api.github.com/users/agrosner","html_url":"https://github.com/agrosner","followers_url":"https://api.github.com/users/agrosner/followers","following_url":"https://api.github.com/users/agrosner/following{/other_user}","gists_url":"https://api.github.com/users/agrosner/gists{/gist_id}","starred_url":"https://api.github.com/users/agrosner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agrosner/subscriptions","organizations_url":"https://api.github.com/users/agrosner/orgs","repos_url":"https://api.github.com/users/agrosner/repos","events_url":"https://api.github.com/users/agrosner/events{/privacy}","received_events_url":"https://api.github.com/users/agrosner/received_events","type":"User","site_admin":false},"body":"might be worth doing a `try..catch datetimeparseexception` I think it throws? but we should also just log it if it does, but to be safe we dont crash here.","created_at":"2018-08-15T13:35:19Z","updated_at":"2018-08-15T13:39:18Z","html_url":"https://github.com/art-institute-of-chicago/aic-mobile-android/pull/48#discussion_r210269814","pull_request_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/pulls/48","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/pulls/comments/210269814"},"html":{"href":"https://github.com/art-institute-of-chicago/aic-mobile-android/pull/48#discussion_r210269814"},"pull_request":{"href":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/pulls/48"}}},"pull_request":{"url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/pulls/48","id":208390953,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MzkwOTUz","html_url":"https://github.com/art-institute-of-chicago/aic-mobile-android/pull/48","diff_url":"https://github.com/art-institute-of-chicago/aic-mobile-android/pull/48.diff","patch_url":"https://github.com/art-institute-of-chicago/aic-mobile-android/pull/48.patch","issue_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/issues/48","number":48,"state":"open","locked":false,"title":"Events Date issue","user":{"login":"sam33rdhakal","id":4182727,"node_id":"MDQ6VXNlcjQxODI3Mjc=","avatar_url":"https://avatars3.githubusercontent.com/u/4182727?v=4","gravatar_id":"","url":"https://api.github.com/users/sam33rdhakal","html_url":"https://github.com/sam33rdhakal","followers_url":"https://api.github.com/users/sam33rdhakal/followers","following_url":"https://api.github.com/users/sam33rdhakal/following{/other_user}","gists_url":"https://api.github.com/users/sam33rdhakal/gists{/gist_id}","starred_url":"https://api.github.com/users/sam33rdhakal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sam33rdhakal/subscriptions","organizations_url":"https://api.github.com/users/sam33rdhakal/orgs","repos_url":"https://api.github.com/users/sam33rdhakal/repos","events_url":"https://api.github.com/users/sam33rdhakal/events{/privacy}","received_events_url":"https://api.github.com/users/sam33rdhakal/received_events","type":"User","site_admin":false},"body":"Fixes date time issue.","created_at":"2018-08-14T19:50:41Z","updated_at":"2018-08-15T13:39:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"30471927961201f61faeb7e0d620a040d830250a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/pulls/48/commits","review_comments_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/pulls/48/comments","review_comment_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/issues/48/comments","statuses_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/statuses/9137e688add441fdb51eaaa738882630d0799248","head":{"label":"art-institute-of-chicago:events_header_issue","ref":"events_header_issue","sha":"9137e688add441fdb51eaaa738882630d0799248","user":{"login":"art-institute-of-chicago","id":20950489,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwOTUwNDg5","avatar_url":"https://avatars1.githubusercontent.com/u/20950489?v=4","gravatar_id":"","url":"https://api.github.com/users/art-institute-of-chicago","html_url":"https://github.com/art-institute-of-chicago","followers_url":"https://api.github.com/users/art-institute-of-chicago/followers","following_url":"https://api.github.com/users/art-institute-of-chicago/following{/other_user}","gists_url":"https://api.github.com/users/art-institute-of-chicago/gists{/gist_id}","starred_url":"https://api.github.com/users/art-institute-of-chicago/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/art-institute-of-chicago/subscriptions","organizations_url":"https://api.github.com/users/art-institute-of-chicago/orgs","repos_url":"https://api.github.com/users/art-institute-of-chicago/repos","events_url":"https://api.github.com/users/art-institute-of-chicago/events{/privacy}","received_events_url":"https://api.github.com/users/art-institute-of-chicago/received_events","type":"Organization","site_admin":false},"repo":{"id":138611305,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg2MTEzMDU=","name":"aic-mobile-android","full_name":"art-institute-of-chicago/aic-mobile-android","owner":{"login":"art-institute-of-chicago","id":20950489,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwOTUwNDg5","avatar_url":"https://avatars1.githubusercontent.com/u/20950489?v=4","gravatar_id":"","url":"https://api.github.com/users/art-institute-of-chicago","html_url":"https://github.com/art-institute-of-chicago","followers_url":"https://api.github.com/users/art-institute-of-chicago/followers","following_url":"https://api.github.com/users/art-institute-of-chicago/following{/other_user}","gists_url":"https://api.github.com/users/art-institute-of-chicago/gists{/gist_id}","starred_url":"https://api.github.com/users/art-institute-of-chicago/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/art-institute-of-chicago/subscriptions","organizations_url":"https://api.github.com/users/art-institute-of-chicago/orgs","repos_url":"https://api.github.com/users/art-institute-of-chicago/repos","events_url":"https://api.github.com/users/art-institute-of-chicago/events{/privacy}","received_events_url":"https://api.github.com/users/art-institute-of-chicago/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/art-institute-of-chicago/aic-mobile-android","description":"Art Institute of Chicago Official Mobile App - Android","fork":false,"url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android","forks_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/forks","keys_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/teams","hooks_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/hooks","issue_events_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/issues/events{/number}","events_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/events","assignees_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/assignees{/user}","branches_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/branches{/branch}","tags_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/tags","blobs_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/statuses/{sha}","languages_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/languages","stargazers_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/stargazers","contributors_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/contributors","subscribers_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/subscribers","subscription_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/subscription","commits_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/contents/{+path}","compare_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/merges","archive_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/downloads","issues_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/issues{/number}","pulls_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/pulls{/number}","milestones_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/milestones{/number}","notifications_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/labels{/name}","releases_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/releases{/id}","deployments_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/deployments","created_at":"2018-06-25T15:07:32Z","updated_at":"2018-08-15T13:27:07Z","pushed_at":"2018-08-15T13:27:07Z","git_url":"git://github.com/art-institute-of-chicago/aic-mobile-android.git","ssh_url":"git@github.com:art-institute-of-chicago/aic-mobile-android.git","clone_url":"https://github.com/art-institute-of-chicago/aic-mobile-android.git","svn_url":"https://github.com/art-institute-of-chicago/aic-mobile-android","homepage":null,"size":6416,"stargazers_count":3,"watchers_count":3,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":2,"open_issues":3,"watchers":3,"default_branch":"dev"}},"base":{"label":"art-institute-of-chicago:dev","ref":"dev","sha":"a530f54f915ab38fe9031daf69e7642e5311bcc6","user":{"login":"art-institute-of-chicago","id":20950489,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwOTUwNDg5","avatar_url":"https://avatars1.githubusercontent.com/u/20950489?v=4","gravatar_id":"","url":"https://api.github.com/users/art-institute-of-chicago","html_url":"https://github.com/art-institute-of-chicago","followers_url":"https://api.github.com/users/art-institute-of-chicago/followers","following_url":"https://api.github.com/users/art-institute-of-chicago/following{/other_user}","gists_url":"https://api.github.com/users/art-institute-of-chicago/gists{/gist_id}","starred_url":"https://api.github.com/users/art-institute-of-chicago/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/art-institute-of-chicago/subscriptions","organizations_url":"https://api.github.com/users/art-institute-of-chicago/orgs","repos_url":"https://api.github.com/users/art-institute-of-chicago/repos","events_url":"https://api.github.com/users/art-institute-of-chicago/events{/privacy}","received_events_url":"https://api.github.com/users/art-institute-of-chicago/received_events","type":"Organization","site_admin":false},"repo":{"id":138611305,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg2MTEzMDU=","name":"aic-mobile-android","full_name":"art-institute-of-chicago/aic-mobile-android","owner":{"login":"art-institute-of-chicago","id":20950489,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwOTUwNDg5","avatar_url":"https://avatars1.githubusercontent.com/u/20950489?v=4","gravatar_id":"","url":"https://api.github.com/users/art-institute-of-chicago","html_url":"https://github.com/art-institute-of-chicago","followers_url":"https://api.github.com/users/art-institute-of-chicago/followers","following_url":"https://api.github.com/users/art-institute-of-chicago/following{/other_user}","gists_url":"https://api.github.com/users/art-institute-of-chicago/gists{/gist_id}","starred_url":"https://api.github.com/users/art-institute-of-chicago/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/art-institute-of-chicago/subscriptions","organizations_url":"https://api.github.com/users/art-institute-of-chicago/orgs","repos_url":"https://api.github.com/users/art-institute-of-chicago/repos","events_url":"https://api.github.com/users/art-institute-of-chicago/events{/privacy}","received_events_url":"https://api.github.com/users/art-institute-of-chicago/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/art-institute-of-chicago/aic-mobile-android","description":"Art Institute of Chicago Official Mobile App - Android","fork":false,"url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android","forks_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/forks","keys_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/teams","hooks_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/hooks","issue_events_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/issues/events{/number}","events_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/events","assignees_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/assignees{/user}","branches_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/branches{/branch}","tags_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/tags","blobs_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/statuses/{sha}","languages_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/languages","stargazers_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/stargazers","contributors_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/contributors","subscribers_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/subscribers","subscription_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/subscription","commits_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/contents/{+path}","compare_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/merges","archive_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/downloads","issues_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/issues{/number}","pulls_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/pulls{/number}","milestones_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/milestones{/number}","notifications_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/labels{/name}","releases_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/releases{/id}","deployments_url":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/deployments","created_at":"2018-06-25T15:07:32Z","updated_at":"2018-08-15T13:27:07Z","pushed_at":"2018-08-15T13:27:07Z","git_url":"git://github.com/art-institute-of-chicago/aic-mobile-android.git","ssh_url":"git@github.com:art-institute-of-chicago/aic-mobile-android.git","clone_url":"https://github.com/art-institute-of-chicago/aic-mobile-android.git","svn_url":"https://github.com/art-institute-of-chicago/aic-mobile-android","homepage":null,"size":6416,"stargazers_count":3,"watchers_count":3,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":2,"open_issues":3,"watchers":3,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/pulls/48"},"html":{"href":"https://github.com/art-institute-of-chicago/aic-mobile-android/pull/48"},"issue":{"href":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/issues/48"},"comments":{"href":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/issues/48/comments"},"review_comments":{"href":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/pulls/48/comments"},"review_comment":{"href":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/pulls/48/commits"},"statuses":{"href":"https://api.github.com/repos/art-institute-of-chicago/aic-mobile-android/statuses/9137e688add441fdb51eaaa738882630d0799248"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"agrosner"}}