{"action":"closed","number":48044,"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/48044","id":221105987,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxMTA1OTg3","html_url":"https://github.com/NixOS/nixpkgs/pull/48044","diff_url":"https://github.com/NixOS/nixpkgs/pull/48044.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/48044.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/48044","number":48044,"state":"closed","locked":false,"title":"treewide: Use fetchFromGitHub instead of fetchurl","user":{"login":"schneefux","id":15379000,"node_id":"MDQ6VXNlcjE1Mzc5MDAw","avatar_url":"https://avatars0.githubusercontent.com/u/15379000?v=4","gravatar_id":"","url":"https://api.github.com/users/schneefux","html_url":"https://github.com/schneefux","followers_url":"https://api.github.com/users/schneefux/followers","following_url":"https://api.github.com/users/schneefux/following{/other_user}","gists_url":"https://api.github.com/users/schneefux/gists{/gist_id}","starred_url":"https://api.github.com/users/schneefux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schneefux/subscriptions","organizations_url":"https://api.github.com/users/schneefux/orgs","repos_url":"https://api.github.com/users/schneefux/repos","events_url":"https://api.github.com/users/schneefux/events{/privacy}","received_events_url":"https://api.github.com/users/schneefux/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\nAs per #32997, replaced a few calls of `fetchurl` by `fetchFromGitHub`.\r\nReplaced `fetchgit` by `fetchFromGitHub` where, according to the comments, submodule support was needed but not present. See also https://github.com/NixOS/nixpkgs/pull/27327#issuecomment-314874995 for a discussion whether to prefer `fetchgit` for GitHub.\r\nAlso updated the affected packages sutils, bootchart, moonlight-embedded, neopg and nitrokey-app to the latest version.\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [ ] NixOS\r\n   - [ ] macOS\r\n   - [x] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [ ] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).","created_at":"2018-10-08T12:52:53Z","updated_at":"2018-11-14T08:48:23Z","closed_at":"2018-11-14T08:48:23Z","merged_at":"2018-11-14T08:48:23Z","merge_commit_sha":"cde945a165f90cc9f3a102b81d84c343ec1c1076","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":731735222,"node_id":"MDU6TGFiZWw3MzE3MzUyMjI=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%201-10","name":"10.rebuild-darwin: 1-10","color":"eeffee","default":false},{"id":731734101,"node_id":"MDU6TGFiZWw3MzE3MzQxMDE=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%2011-100","name":"10.rebuild-linux: 11-100","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/48044/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/48044/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/48044/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/d81a96e601b352453ccc328cac42d13907b362c0","head":{"label":"schneefux:pkg/fetchfromgithub","ref":"pkg/fetchfromgithub","sha":"d81a96e601b352453ccc328cac42d13907b362c0","user":{"login":"schneefux","id":15379000,"node_id":"MDQ6VXNlcjE1Mzc5MDAw","avatar_url":"https://avatars0.githubusercontent.com/u/15379000?v=4","gravatar_id":"","url":"https://api.github.com/users/schneefux","html_url":"https://github.com/schneefux","followers_url":"https://api.github.com/users/schneefux/followers","following_url":"https://api.github.com/users/schneefux/following{/other_user}","gists_url":"https://api.github.com/users/schneefux/gists{/gist_id}","starred_url":"https://api.github.com/users/schneefux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schneefux/subscriptions","organizations_url":"https://api.github.com/users/schneefux/orgs","repos_url":"https://api.github.com/users/schneefux/repos","events_url":"https://api.github.com/users/schneefux/events{/privacy}","received_events_url":"https://api.github.com/users/schneefux/received_events","type":"User","site_admin":false},"repo":{"id":57986481,"node_id":"MDEwOlJlcG9zaXRvcnk1Nzk4NjQ4MQ==","name":"nixpkgs","full_name":"schneefux/nixpkgs","private":false,"owner":{"login":"schneefux","id":15379000,"node_id":"MDQ6VXNlcjE1Mzc5MDAw","avatar_url":"https://avatars0.githubusercontent.com/u/15379000?v=4","gravatar_id":"","url":"https://api.github.com/users/schneefux","html_url":"https://github.com/schneefux","followers_url":"https://api.github.com/users/schneefux/followers","following_url":"https://api.github.com/users/schneefux/following{/other_user}","gists_url":"https://api.github.com/users/schneefux/gists{/gist_id}","starred_url":"https://api.github.com/users/schneefux/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schneefux/subscriptions","organizations_url":"https://api.github.com/users/schneefux/orgs","repos_url":"https://api.github.com/users/schneefux/repos","events_url":"https://api.github.com/users/schneefux/events{/privacy}","received_events_url":"https://api.github.com/users/schneefux/received_events","type":"User","site_admin":false},"html_url":"https://github.com/schneefux/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/schneefux/nixpkgs","forks_url":"https://api.github.com/repos/schneefux/nixpkgs/forks","keys_url":"https://api.github.com/repos/schneefux/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/schneefux/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/schneefux/nixpkgs/teams","hooks_url":"https://api.github.com/repos/schneefux/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/schneefux/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/schneefux/nixpkgs/events","assignees_url":"https://api.github.com/repos/schneefux/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/schneefux/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/schneefux/nixpkgs/tags","blobs_url":"https://api.github.com/repos/schneefux/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/schneefux/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/schneefux/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/schneefux/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/schneefux/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/schneefux/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/schneefux/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/schneefux/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/schneefux/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/schneefux/nixpkgs/subscription","commits_url":"https://api.github.com/repos/schneefux/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/schneefux/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/schneefux/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/schneefux/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/schneefux/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/schneefux/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/schneefux/nixpkgs/merges","archive_url":"https://api.github.com/repos/schneefux/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/schneefux/nixpkgs/downloads","issues_url":"https://api.github.com/repos/schneefux/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/schneefux/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/schneefux/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/schneefux/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/schneefux/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/schneefux/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/schneefux/nixpkgs/deployments","created_at":"2016-05-03T17:04:32Z","updated_at":"2016-05-03T17:04:56Z","pushed_at":"2018-10-08T12:35:31Z","git_url":"git://github.com/schneefux/nixpkgs.git","ssh_url":"git@github.com:schneefux/nixpkgs.git","clone_url":"https://github.com/schneefux/nixpkgs.git","svn_url":"https://github.com/schneefux/nixpkgs","homepage":null,"size":765540,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"e6a33e7697e1bebc9a4d76226f6f635cd370ecdd","user":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"node_id":"MDEwOlJlcG9zaXRvcnk0NTQyNzE2","name":"nixpkgs","full_name":"NixOS/nixpkgs","private":false,"owner":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2018-11-14T08:45:46Z","pushed_at":"2018-11-14T08:48:23Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":882824,"stargazers_count":3000,"watchers_count":3000,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3181,"mirror_url":null,"archived":false,"open_issues_count":3370,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3181,"open_issues":3370,"watchers":3000,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/48044"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/48044"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/48044"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/48044/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/48044/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/48044/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/d81a96e601b352453ccc328cac42d13907b362c0"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"c0bw3b","id":24417923,"node_id":"MDQ6VXNlcjI0NDE3OTIz","avatar_url":"https://avatars1.githubusercontent.com/u/24417923?v=4","gravatar_id":"","url":"https://api.github.com/users/c0bw3b","html_url":"https://github.com/c0bw3b","followers_url":"https://api.github.com/users/c0bw3b/followers","following_url":"https://api.github.com/users/c0bw3b/following{/other_user}","gists_url":"https://api.github.com/users/c0bw3b/gists{/gist_id}","starred_url":"https://api.github.com/users/c0bw3b/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c0bw3b/subscriptions","organizations_url":"https://api.github.com/users/c0bw3b/orgs","repos_url":"https://api.github.com/users/c0bw3b/repos","events_url":"https://api.github.com/users/c0bw3b/events{/privacy}","received_events_url":"https://api.github.com/users/c0bw3b/received_events","type":"User","site_admin":false},"comments":4,"review_comments":2,"maintainer_can_modify":false,"commits":16,"additions":70,"deletions":52,"changed_files":11}}
{"actor":{"display_login":"c0bw3b"}}