{"action":"created","comment":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/169416698","pull_request_review_id":97939890,"id":169416698,"diff_hunk":"@@ -0,0 +1,136 @@\n+\"\"\"Deprecation helpers for Home Assistant.\"\"\"","path":"homeassistant/helpers/filter.py","position":1,"original_position":1,"commit_id":"167f35fd610393c2e8f49360bb34e8119ccd0659","original_commit_id":"167f35fd610393c2e8f49360bb34e8119ccd0659","user":{"login":"dgomes","id":137684,"avatar_url":"https://avatars2.githubusercontent.com/u/137684?v=4","gravatar_id":"","url":"https://api.github.com/users/dgomes","html_url":"https://github.com/dgomes","followers_url":"https://api.github.com/users/dgomes/followers","following_url":"https://api.github.com/users/dgomes/following{/other_user}","gists_url":"https://api.github.com/users/dgomes/gists{/gist_id}","starred_url":"https://api.github.com/users/dgomes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgomes/subscriptions","organizations_url":"https://api.github.com/users/dgomes/orgs","repos_url":"https://api.github.com/users/dgomes/repos","events_url":"https://api.github.com/users/dgomes/events{/privacy}","received_events_url":"https://api.github.com/users/dgomes/received_events","type":"User","site_admin":false},"body":"ups!","created_at":"2018-02-20T18:36:14Z","updated_at":"2018-02-20T18:36:15Z","html_url":"https://github.com/home-assistant/home-assistant/pull/12506#discussion_r169416698","pull_request_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12506","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments/169416698"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/12506#discussion_r169416698"},"pull_request":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12506"}},"in_reply_to_id":169224296},"pull_request":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12506","id":169843590,"html_url":"https://github.com/home-assistant/home-assistant/pull/12506","diff_url":"https://github.com/home-assistant/home-assistant/pull/12506.diff","patch_url":"https://github.com/home-assistant/home-assistant/pull/12506.patch","issue_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/12506","number":12506,"state":"open","locked":false,"title":"[RFC] Filter helper decorator","user":{"login":"dgomes","id":137684,"avatar_url":"https://avatars2.githubusercontent.com/u/137684?v=4","gravatar_id":"","url":"https://api.github.com/users/dgomes","html_url":"https://github.com/dgomes","followers_url":"https://api.github.com/users/dgomes/followers","following_url":"https://api.github.com/users/dgomes/following{/other_user}","gists_url":"https://api.github.com/users/dgomes/gists{/gist_id}","starred_url":"https://api.github.com/users/dgomes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgomes/subscriptions","organizations_url":"https://api.github.com/users/dgomes/orgs","repos_url":"https://api.github.com/users/dgomes/repos","events_url":"https://api.github.com/users/dgomes/events{/privacy}","received_events_url":"https://api.github.com/users/dgomes/received_events","type":"User","site_admin":false},"body":"## Description:\r\n\r\nWhen dealing with physical sensors (those who read real life data) it is common to get errors and noise (due to the quality of the sensors or undesirable events). Good devices implement internally *filters* that remove outliers and smooth data. But many other devices do not (especially DIY devices/hardware and cheap devices).\r\n\r\nThis Pull request introduces a helper decorator *Filter* that can be added to the state() method or to any other @property method. \r\n\r\nTwo files are provided:\r\n- helpers/filter.py : implements the decorator and filter algorithms \r\n- components/sensor/filter.py : implements a meta sensor that uses the fore mentioned decorator and can be used regardless of components being updated with the Filter decorator\r\n\r\nFilters have been implemented as decorators since I believe they are of broader use then to this single meta filter component (I personally use it for two different custom_components that handle sensor information coming from DIY devices). Furthermore this implementation makes it trivial to add filtering to existing and future components.\r\n\r\n**Pull request in [home-assistant.github.io](https://github.com/home-assistant/home-assistant.github.io) with documentation (if applicable):** home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>\r\n\r\n## Example entry for `configuration.yaml` (if applicable):\r\n```yaml\r\nsensor:\r\n  - platform: filter\r\n    entity_id: sensor.relative_humidity\r\n    name: lowpass\r\n    options:\r\n      time_constant: 10\r\n```\r\n\r\n## Checklist:\r\n  - [x] The code change is tested and works locally.\r\n  - [ ] Documentation added/updated in [home-assistant.github.io](https://github.com/home-assistant/home-assistant.github.io)\r\n  - [x] Local tests with `tox` run successfully. **Your PR cannot be merged unless tests pass**\r\n  - [ ] Tests have been added to verify that the new code works.\r\n","created_at":"2018-02-18T18:40:32Z","updated_at":"2018-02-20T18:36:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"14d914e7e8870f8455e62fb3c62b32c918e3e459","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":527871105,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/cla-signed","name":"cla-signed","color":"008000","default":false},{"id":451931292,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/core","name":"core","color":"c5def5","default":false},{"id":526146744,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/new-platform","name":"new-platform","color":"ededed","default":false},{"id":840963745,"url":"https://api.github.com/repos/home-assistant/home-assistant/labels/platform:%20sensor.filter","name":"platform: sensor.filter","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12506/commits","review_comments_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12506/comments","review_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/12506/comments","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/167f35fd610393c2e8f49360bb34e8119ccd0659","head":{"label":"dgomes:filter","ref":"filter","sha":"167f35fd610393c2e8f49360bb34e8119ccd0659","user":{"login":"dgomes","id":137684,"avatar_url":"https://avatars2.githubusercontent.com/u/137684?v=4","gravatar_id":"","url":"https://api.github.com/users/dgomes","html_url":"https://github.com/dgomes","followers_url":"https://api.github.com/users/dgomes/followers","following_url":"https://api.github.com/users/dgomes/following{/other_user}","gists_url":"https://api.github.com/users/dgomes/gists{/gist_id}","starred_url":"https://api.github.com/users/dgomes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgomes/subscriptions","organizations_url":"https://api.github.com/users/dgomes/orgs","repos_url":"https://api.github.com/users/dgomes/repos","events_url":"https://api.github.com/users/dgomes/events{/privacy}","received_events_url":"https://api.github.com/users/dgomes/received_events","type":"User","site_admin":false},"repo":{"id":94482740,"name":"home-assistant","full_name":"dgomes/home-assistant","owner":{"login":"dgomes","id":137684,"avatar_url":"https://avatars2.githubusercontent.com/u/137684?v=4","gravatar_id":"","url":"https://api.github.com/users/dgomes","html_url":"https://github.com/dgomes","followers_url":"https://api.github.com/users/dgomes/followers","following_url":"https://api.github.com/users/dgomes/following{/other_user}","gists_url":"https://api.github.com/users/dgomes/gists{/gist_id}","starred_url":"https://api.github.com/users/dgomes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dgomes/subscriptions","organizations_url":"https://api.github.com/users/dgomes/orgs","repos_url":"https://api.github.com/users/dgomes/repos","events_url":"https://api.github.com/users/dgomes/events{/privacy}","received_events_url":"https://api.github.com/users/dgomes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dgomes/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":true,"url":"https://api.github.com/repos/dgomes/home-assistant","forks_url":"https://api.github.com/repos/dgomes/home-assistant/forks","keys_url":"https://api.github.com/repos/dgomes/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dgomes/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dgomes/home-assistant/teams","hooks_url":"https://api.github.com/repos/dgomes/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/dgomes/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/dgomes/home-assistant/events","assignees_url":"https://api.github.com/repos/dgomes/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/dgomes/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/dgomes/home-assistant/tags","blobs_url":"https://api.github.com/repos/dgomes/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dgomes/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dgomes/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/dgomes/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dgomes/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/dgomes/home-assistant/languages","stargazers_url":"https://api.github.com/repos/dgomes/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/dgomes/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/dgomes/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/dgomes/home-assistant/subscription","commits_url":"https://api.github.com/repos/dgomes/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/dgomes/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/dgomes/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/dgomes/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/dgomes/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/dgomes/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dgomes/home-assistant/merges","archive_url":"https://api.github.com/repos/dgomes/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dgomes/home-assistant/downloads","issues_url":"https://api.github.com/repos/dgomes/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/dgomes/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/dgomes/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/dgomes/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dgomes/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/dgomes/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/dgomes/home-assistant/deployments","created_at":"2017-06-15T22:12:01Z","updated_at":"2018-02-20T08:15:51Z","pushed_at":"2018-02-20T01:24:51Z","git_url":"git://github.com/dgomes/home-assistant.git","ssh_url":"git@github.com:dgomes/home-assistant.git","clone_url":"https://github.com/dgomes/home-assistant.git","svn_url":"https://github.com/dgomes/home-assistant","homepage":"https://home-assistant.io","size":78501,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":2,"default_branch":"dev"}},"base":{"label":"home-assistant:dev","ref":"dev","sha":"2280dc2a347d3f192e6ff963980a6d35a8614e0a","user":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"repo":{"id":12888993,"name":"home-assistant","full_name":"home-assistant/home-assistant","owner":{"login":"home-assistant","id":13844975,"avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/home-assistant/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":false,"url":"https://api.github.com/repos/home-assistant/home-assistant","forks_url":"https://api.github.com/repos/home-assistant/home-assistant/forks","keys_url":"https://api.github.com/repos/home-assistant/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/home-assistant/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/home-assistant/home-assistant/teams","hooks_url":"https://api.github.com/repos/home-assistant/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/home-assistant/home-assistant/events","assignees_url":"https://api.github.com/repos/home-assistant/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/home-assistant/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/home-assistant/home-assistant/tags","blobs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/home-assistant/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/home-assistant/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/home-assistant/home-assistant/languages","stargazers_url":"https://api.github.com/repos/home-assistant/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/home-assistant/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/home-assistant/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/home-assistant/home-assistant/subscription","commits_url":"https://api.github.com/repos/home-assistant/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/home-assistant/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/home-assistant/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/home-assistant/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/home-assistant/home-assistant/merges","archive_url":"https://api.github.com/repos/home-assistant/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/home-assistant/home-assistant/downloads","issues_url":"https://api.github.com/repos/home-assistant/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/home-assistant/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/home-assistant/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/home-assistant/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/home-assistant/home-assistant/deployments","created_at":"2013-09-17T07:29:48Z","updated_at":"2018-02-20T18:06:44Z","pushed_at":"2018-02-20T18:07:57Z","git_url":"git://github.com/home-assistant/home-assistant.git","ssh_url":"git@github.com:home-assistant/home-assistant.git","clone_url":"https://github.com/home-assistant/home-assistant.git","svn_url":"https://github.com/home-assistant/home-assistant","homepage":"https://home-assistant.io","size":78745,"stargazers_count":12655,"watchers_count":12655,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3658,"mirror_url":null,"archived":false,"open_issues_count":833,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":3658,"open_issues":833,"watchers":12655,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12506"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/12506"},"issue":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/12506"},"comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/12506/comments"},"review_comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12506/comments"},"review_comment":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/12506/commits"},"statuses":{"href":"https://api.github.com/repos/home-assistant/home-assistant/statuses/167f35fd610393c2e8f49360bb34e8119ccd0659"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dgomes"}}