{"action":"created","comment":{"url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/pulls/comments/173849993","pull_request_review_id":103106913,"id":173849993,"diff_hunk":"@@ -248,6 +242,12 @@ HashSet<ITypeSymbol> typeStack\n \t\t\t\treturn MutabilityInspectionResult.NotMutable();\r\n \t\t\t}\r\n \r\n+\t\t\tvar scope = type.GetImmutabilityScope();\r\n+\t\t\tif( !flags.HasFlag( MutabilityInspectionFlags.IgnoreImmutabilityAttribute ) && scope != ImmutabilityScope.None ) {\r","path":"src/D2L.CodeStyle.Analyzers/Immutability/MutabilityInspector.cs","position":24,"original_position":24,"commit_id":"36e09975e3ebbdd83e6df3b72a407ee176ecbbef","original_commit_id":"36e09975e3ebbdd83e6df3b72a407ee176ecbbef","user":{"login":"j3parker","id":597907,"avatar_url":"https://avatars2.githubusercontent.com/u/597907?v=4","gravatar_id":"","url":"https://api.github.com/users/j3parker","html_url":"https://github.com/j3parker","followers_url":"https://api.github.com/users/j3parker/followers","following_url":"https://api.github.com/users/j3parker/following{/other_user}","gists_url":"https://api.github.com/users/j3parker/gists{/gist_id}","starred_url":"https://api.github.com/users/j3parker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j3parker/subscriptions","organizations_url":"https://api.github.com/users/j3parker/orgs","repos_url":"https://api.github.com/users/j3parker/repos","events_url":"https://api.github.com/users/j3parker/events{/privacy}","received_events_url":"https://api.github.com/users/j3parker/received_events","type":"User","site_admin":false},"body":"Good point. I'm very confident that enum won't ever gain/lose members. I'm going to go with this for now. I might change how that stuff is structured 9the enum/helpers) after the flags are gone but still undecided.","created_at":"2018-03-12T16:00:25Z","updated_at":"2018-03-12T16:00:25Z","html_url":"https://github.com/Brightspace/D2L.CodeStyle/pull/307#discussion_r173849993","pull_request_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/pulls/307","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/pulls/comments/173849993"},"html":{"href":"https://github.com/Brightspace/D2L.CodeStyle/pull/307#discussion_r173849993"},"pull_request":{"href":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/pulls/307"}},"in_reply_to_id":173848983},"pull_request":{"url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/pulls/307","id":174109815,"html_url":"https://github.com/Brightspace/D2L.CodeStyle/pull/307","diff_url":"https://github.com/Brightspace/D2L.CodeStyle/pull/307.diff","patch_url":"https://github.com/Brightspace/D2L.CodeStyle/pull/307.patch","issue_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/issues/307","number":307,"state":"open","locked":false,"title":"Untangle/split some logic that was in InspectType into InspectConcreteType","user":{"login":"j3parker","id":597907,"avatar_url":"https://avatars2.githubusercontent.com/u/597907?v=4","gravatar_id":"","url":"https://api.github.com/users/j3parker","html_url":"https://github.com/j3parker","followers_url":"https://api.github.com/users/j3parker/followers","following_url":"https://api.github.com/users/j3parker/following{/other_user}","gists_url":"https://api.github.com/users/j3parker/gists{/gist_id}","starred_url":"https://api.github.com/users/j3parker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j3parker/subscriptions","organizations_url":"https://api.github.com/users/j3parker/orgs","repos_url":"https://api.github.com/users/j3parker/repos","events_url":"https://api.github.com/users/j3parker/events{/privacy}","received_events_url":"https://api.github.com/users/j3parker/received_events","type":"User","site_admin":false},"body":"This one requires a bit more lookin'. It might help to ignore what was there before an just look at what's there now.\r\n\r\nKey fact: `AllowUnsealed` is only ever passed into `InspectType` by way of `InspectConcreteType`. So if we move logic predicated on `AllowUnsealed` into `InspectConcreteType` then the checks in `InspectType` become completely redundant.\r\n\r\nThe only concern is what we're commuting the check over in `InspectType` to get \"up\" to `InspectConcreteType` (i.e. what checks came before the thing we're moving, inside `InspectType`, that will now happen after... if the checks aren't commutative it isn't safe.)","created_at":"2018-03-09T21:13:15Z","updated_at":"2018-03-12T16:00:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"02a278d686003e446119980f1ca10ced499077ab","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/pulls/307/commits","review_comments_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/pulls/307/comments","review_comment_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/issues/307/comments","statuses_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/statuses/36e09975e3ebbdd83e6df3b72a407ee176ecbbef","head":{"label":"j3parker:more-inspectconcretetype-work","ref":"more-inspectconcretetype-work","sha":"36e09975e3ebbdd83e6df3b72a407ee176ecbbef","user":{"login":"j3parker","id":597907,"avatar_url":"https://avatars2.githubusercontent.com/u/597907?v=4","gravatar_id":"","url":"https://api.github.com/users/j3parker","html_url":"https://github.com/j3parker","followers_url":"https://api.github.com/users/j3parker/followers","following_url":"https://api.github.com/users/j3parker/following{/other_user}","gists_url":"https://api.github.com/users/j3parker/gists{/gist_id}","starred_url":"https://api.github.com/users/j3parker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j3parker/subscriptions","organizations_url":"https://api.github.com/users/j3parker/orgs","repos_url":"https://api.github.com/users/j3parker/repos","events_url":"https://api.github.com/users/j3parker/events{/privacy}","received_events_url":"https://api.github.com/users/j3parker/received_events","type":"User","site_admin":false},"repo":{"id":124264641,"name":"D2L.CodeStyle","full_name":"j3parker/D2L.CodeStyle","owner":{"login":"j3parker","id":597907,"avatar_url":"https://avatars2.githubusercontent.com/u/597907?v=4","gravatar_id":"","url":"https://api.github.com/users/j3parker","html_url":"https://github.com/j3parker","followers_url":"https://api.github.com/users/j3parker/followers","following_url":"https://api.github.com/users/j3parker/following{/other_user}","gists_url":"https://api.github.com/users/j3parker/gists{/gist_id}","starred_url":"https://api.github.com/users/j3parker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j3parker/subscriptions","organizations_url":"https://api.github.com/users/j3parker/orgs","repos_url":"https://api.github.com/users/j3parker/repos","events_url":"https://api.github.com/users/j3parker/events{/privacy}","received_events_url":"https://api.github.com/users/j3parker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/j3parker/D2L.CodeStyle","description":"Annotations and analysis tools for D2L C# code style","fork":true,"url":"https://api.github.com/repos/j3parker/D2L.CodeStyle","forks_url":"https://api.github.com/repos/j3parker/D2L.CodeStyle/forks","keys_url":"https://api.github.com/repos/j3parker/D2L.CodeStyle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/j3parker/D2L.CodeStyle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/j3parker/D2L.CodeStyle/teams","hooks_url":"https://api.github.com/repos/j3parker/D2L.CodeStyle/hooks","issue_events_url":"https://api.github.com/repos/j3parker/D2L.CodeStyle/issues/events{/number}","events_url":"https://api.github.com/repos/j3parker/D2L.CodeStyle/events","assignees_url":"https://api.github.com/repos/j3parker/D2L.CodeStyle/assignees{/user}","branches_url":"https://api.github.com/repos/j3parker/D2L.CodeStyle/branches{/branch}","tags_url":"https://api.github.com/repos/j3parker/D2L.CodeStyle/tags","blobs_url":"https://api.github.com/repos/j3parker/D2L.CodeStyle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/j3parker/D2L.CodeStyle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/j3parker/D2L.CodeStyle/git/refs{/sha}","trees_url":"https://api.github.com/repos/j3parker/D2L.CodeStyle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/j3parker/D2L.CodeStyle/statuses/{sha}","languages_url":"https://api.github.com/repos/j3parker/D2L.CodeStyle/languages","stargazers_url":"https://api.github.com/repos/j3parker/D2L.CodeStyle/stargazers","contributors_url":"https://api.github.com/repos/j3parker/D2L.CodeStyle/contributors","subscribers_url":"https://api.github.com/repos/j3parker/D2L.CodeStyle/subscribers","subscription_url":"https://api.github.com/repos/j3parker/D2L.CodeStyle/subscription","commits_url":"https://api.github.com/repos/j3parker/D2L.CodeStyle/commits{/sha}","git_commits_url":"https://api.github.com/repos/j3parker/D2L.CodeStyle/git/commits{/sha}","comments_url":"https://api.github.com/repos/j3parker/D2L.CodeStyle/comments{/number}","issue_comment_url":"https://api.github.com/repos/j3parker/D2L.CodeStyle/issues/comments{/number}","contents_url":"https://api.github.com/repos/j3parker/D2L.CodeStyle/contents/{+path}","compare_url":"https://api.github.com/repos/j3parker/D2L.CodeStyle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/j3parker/D2L.CodeStyle/merges","archive_url":"https://api.github.com/repos/j3parker/D2L.CodeStyle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/j3parker/D2L.CodeStyle/downloads","issues_url":"https://api.github.com/repos/j3parker/D2L.CodeStyle/issues{/number}","pulls_url":"https://api.github.com/repos/j3parker/D2L.CodeStyle/pulls{/number}","milestones_url":"https://api.github.com/repos/j3parker/D2L.CodeStyle/milestones{/number}","notifications_url":"https://api.github.com/repos/j3parker/D2L.CodeStyle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/j3parker/D2L.CodeStyle/labels{/name}","releases_url":"https://api.github.com/repos/j3parker/D2L.CodeStyle/releases{/id}","deployments_url":"https://api.github.com/repos/j3parker/D2L.CodeStyle/deployments","created_at":"2018-03-07T16:38:01Z","updated_at":"2018-03-07T16:38:03Z","pushed_at":"2018-03-09T21:16:30Z","git_url":"git://github.com/j3parker/D2L.CodeStyle.git","ssh_url":"git@github.com:j3parker/D2L.CodeStyle.git","clone_url":"https://github.com/j3parker/D2L.CodeStyle.git","svn_url":"https://github.com/j3parker/D2L.CodeStyle","homepage":"","size":1014,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Brightspace:master","ref":"master","sha":"a62d961563cf05341d5afa7bd52a62261a570ac9","user":{"login":"Brightspace","id":5429170,"avatar_url":"https://avatars2.githubusercontent.com/u/5429170?v=4","gravatar_id":"","url":"https://api.github.com/users/Brightspace","html_url":"https://github.com/Brightspace","followers_url":"https://api.github.com/users/Brightspace/followers","following_url":"https://api.github.com/users/Brightspace/following{/other_user}","gists_url":"https://api.github.com/users/Brightspace/gists{/gist_id}","starred_url":"https://api.github.com/users/Brightspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Brightspace/subscriptions","organizations_url":"https://api.github.com/users/Brightspace/orgs","repos_url":"https://api.github.com/users/Brightspace/repos","events_url":"https://api.github.com/users/Brightspace/events{/privacy}","received_events_url":"https://api.github.com/users/Brightspace/received_events","type":"Organization","site_admin":false},"repo":{"id":66025309,"name":"D2L.CodeStyle","full_name":"Brightspace/D2L.CodeStyle","owner":{"login":"Brightspace","id":5429170,"avatar_url":"https://avatars2.githubusercontent.com/u/5429170?v=4","gravatar_id":"","url":"https://api.github.com/users/Brightspace","html_url":"https://github.com/Brightspace","followers_url":"https://api.github.com/users/Brightspace/followers","following_url":"https://api.github.com/users/Brightspace/following{/other_user}","gists_url":"https://api.github.com/users/Brightspace/gists{/gist_id}","starred_url":"https://api.github.com/users/Brightspace/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Brightspace/subscriptions","organizations_url":"https://api.github.com/users/Brightspace/orgs","repos_url":"https://api.github.com/users/Brightspace/repos","events_url":"https://api.github.com/users/Brightspace/events{/privacy}","received_events_url":"https://api.github.com/users/Brightspace/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Brightspace/D2L.CodeStyle","description":"Annotations and analysis tools for D2L C# code style","fork":false,"url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle","forks_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/forks","keys_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/teams","hooks_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/hooks","issue_events_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/issues/events{/number}","events_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/events","assignees_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/assignees{/user}","branches_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/branches{/branch}","tags_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/tags","blobs_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/git/refs{/sha}","trees_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/statuses/{sha}","languages_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/languages","stargazers_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/stargazers","contributors_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/contributors","subscribers_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/subscribers","subscription_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/subscription","commits_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/commits{/sha}","git_commits_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/git/commits{/sha}","comments_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/comments{/number}","issue_comment_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/issues/comments{/number}","contents_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/contents/{+path}","compare_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/merges","archive_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/downloads","issues_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/issues{/number}","pulls_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/pulls{/number}","milestones_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/milestones{/number}","notifications_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/labels{/name}","releases_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/releases{/id}","deployments_url":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/deployments","created_at":"2016-08-18T19:36:38Z","updated_at":"2018-03-12T14:33:58Z","pushed_at":"2018-03-09T21:13:16Z","git_url":"git://github.com/Brightspace/D2L.CodeStyle.git","ssh_url":"git@github.com:Brightspace/D2L.CodeStyle.git","clone_url":"https://github.com/Brightspace/D2L.CodeStyle.git","svn_url":"https://github.com/Brightspace/D2L.CodeStyle","homepage":"","size":946,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":3,"open_issues":9,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/pulls/307"},"html":{"href":"https://github.com/Brightspace/D2L.CodeStyle/pull/307"},"issue":{"href":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/issues/307"},"comments":{"href":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/issues/307/comments"},"review_comments":{"href":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/pulls/307/comments"},"review_comment":{"href":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/pulls/307/commits"},"statuses":{"href":"https://api.github.com/repos/Brightspace/D2L.CodeStyle/statuses/36e09975e3ebbdd83e6df3b72a407ee176ecbbef"}},"author_association":"OWNER"}}
{"actor":{"display_login":"j3parker"}}