{"action":"opened","number":578,"pull_request":{"url":"https://api.github.com/repos/snipsco/snips-nlu/pulls/578","id":184623165,"html_url":"https://github.com/snipsco/snips-nlu/pull/578","diff_url":"https://github.com/snipsco/snips-nlu/pull/578.diff","patch_url":"https://github.com/snipsco/snips-nlu/pull/578.patch","issue_url":"https://api.github.com/repos/snipsco/snips-nlu/issues/578","number":578,"state":"open","locked":false,"title":"Fix issues with DeterministicIntentParser causing mismatch","user":{"login":"adrienball","id":11029979,"avatar_url":"https://avatars0.githubusercontent.com/u/11029979?v=4","gravatar_id":"","url":"https://api.github.com/users/adrienball","html_url":"https://github.com/adrienball","followers_url":"https://api.github.com/users/adrienball/followers","following_url":"https://api.github.com/users/adrienball/following{/other_user}","gists_url":"https://api.github.com/users/adrienball/gists{/gist_id}","starred_url":"https://api.github.com/users/adrienball/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adrienball/subscriptions","organizations_url":"https://api.github.com/users/adrienball/orgs","repos_url":"https://api.github.com/users/adrienball/repos","events_url":"https://api.github.com/users/adrienball/events{/privacy}","received_events_url":"https://api.github.com/users/adrienball/received_events","type":"User","site_admin":false},"body":"**Description**\r\nThis PR resolves several issues, one of which being the following:\r\nConsider a dataset with one intent `good_morning` with a single utterance `\"good morning\"` and one intent `good_night` with a single utterance `\"good night\"`. At train time, the preprocessing of builtin entities will produce for both intent the same pattern which will be similar to  `\"good\\s+%SNIPSDATETIME%\"`. At inference, it means that `\"good morning\"` will be parsed either by one intent or the other, depending of the order of processing (and same for \"`good night\"`).\r\n\r\nThe issue is that at train time we do replacements with placeholders such as `%SNIPSDATETIME%` in parts of the sentence that are not slots.\r\nThis PR fixes this by performing the placeholder replacement _only_ for slots.","created_at":"2018-04-27T13:31:53Z","updated_at":"2018-04-27T13:31:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/snipsco/snips-nlu/pulls/578/commits","review_comments_url":"https://api.github.com/repos/snipsco/snips-nlu/pulls/578/comments","review_comment_url":"https://api.github.com/repos/snipsco/snips-nlu/pulls/comments{/number}","comments_url":"https://api.github.com/repos/snipsco/snips-nlu/issues/578/comments","statuses_url":"https://api.github.com/repos/snipsco/snips-nlu/statuses/a647393891199a12a3c5388072c0e7e70ebd2a4c","head":{"label":"snipsco:fix/deterministic-parser","ref":"fix/deterministic-parser","sha":"a647393891199a12a3c5388072c0e7e70ebd2a4c","user":{"login":"snipsco","id":2564618,"avatar_url":"https://avatars0.githubusercontent.com/u/2564618?v=4","gravatar_id":"","url":"https://api.github.com/users/snipsco","html_url":"https://github.com/snipsco","followers_url":"https://api.github.com/users/snipsco/followers","following_url":"https://api.github.com/users/snipsco/following{/other_user}","gists_url":"https://api.github.com/users/snipsco/gists{/gist_id}","starred_url":"https://api.github.com/users/snipsco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snipsco/subscriptions","organizations_url":"https://api.github.com/users/snipsco/orgs","repos_url":"https://api.github.com/users/snipsco/repos","events_url":"https://api.github.com/users/snipsco/events{/privacy}","received_events_url":"https://api.github.com/users/snipsco/received_events","type":"Organization","site_admin":false},"repo":{"id":81349068,"name":"snips-nlu","full_name":"snipsco/snips-nlu","owner":{"login":"snipsco","id":2564618,"avatar_url":"https://avatars0.githubusercontent.com/u/2564618?v=4","gravatar_id":"","url":"https://api.github.com/users/snipsco","html_url":"https://github.com/snipsco","followers_url":"https://api.github.com/users/snipsco/followers","following_url":"https://api.github.com/users/snipsco/following{/other_user}","gists_url":"https://api.github.com/users/snipsco/gists{/gist_id}","starred_url":"https://api.github.com/users/snipsco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snipsco/subscriptions","organizations_url":"https://api.github.com/users/snipsco/orgs","repos_url":"https://api.github.com/users/snipsco/repos","events_url":"https://api.github.com/users/snipsco/events{/privacy}","received_events_url":"https://api.github.com/users/snipsco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/snipsco/snips-nlu","description":"Snips Python library to extract meaning from text","fork":false,"url":"https://api.github.com/repos/snipsco/snips-nlu","forks_url":"https://api.github.com/repos/snipsco/snips-nlu/forks","keys_url":"https://api.github.com/repos/snipsco/snips-nlu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snipsco/snips-nlu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snipsco/snips-nlu/teams","hooks_url":"https://api.github.com/repos/snipsco/snips-nlu/hooks","issue_events_url":"https://api.github.com/repos/snipsco/snips-nlu/issues/events{/number}","events_url":"https://api.github.com/repos/snipsco/snips-nlu/events","assignees_url":"https://api.github.com/repos/snipsco/snips-nlu/assignees{/user}","branches_url":"https://api.github.com/repos/snipsco/snips-nlu/branches{/branch}","tags_url":"https://api.github.com/repos/snipsco/snips-nlu/tags","blobs_url":"https://api.github.com/repos/snipsco/snips-nlu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snipsco/snips-nlu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snipsco/snips-nlu/git/refs{/sha}","trees_url":"https://api.github.com/repos/snipsco/snips-nlu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snipsco/snips-nlu/statuses/{sha}","languages_url":"https://api.github.com/repos/snipsco/snips-nlu/languages","stargazers_url":"https://api.github.com/repos/snipsco/snips-nlu/stargazers","contributors_url":"https://api.github.com/repos/snipsco/snips-nlu/contributors","subscribers_url":"https://api.github.com/repos/snipsco/snips-nlu/subscribers","subscription_url":"https://api.github.com/repos/snipsco/snips-nlu/subscription","commits_url":"https://api.github.com/repos/snipsco/snips-nlu/commits{/sha}","git_commits_url":"https://api.github.com/repos/snipsco/snips-nlu/git/commits{/sha}","comments_url":"https://api.github.com/repos/snipsco/snips-nlu/comments{/number}","issue_comment_url":"https://api.github.com/repos/snipsco/snips-nlu/issues/comments{/number}","contents_url":"https://api.github.com/repos/snipsco/snips-nlu/contents/{+path}","compare_url":"https://api.github.com/repos/snipsco/snips-nlu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snipsco/snips-nlu/merges","archive_url":"https://api.github.com/repos/snipsco/snips-nlu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snipsco/snips-nlu/downloads","issues_url":"https://api.github.com/repos/snipsco/snips-nlu/issues{/number}","pulls_url":"https://api.github.com/repos/snipsco/snips-nlu/pulls{/number}","milestones_url":"https://api.github.com/repos/snipsco/snips-nlu/milestones{/number}","notifications_url":"https://api.github.com/repos/snipsco/snips-nlu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snipsco/snips-nlu/labels{/name}","releases_url":"https://api.github.com/repos/snipsco/snips-nlu/releases{/id}","deployments_url":"https://api.github.com/repos/snipsco/snips-nlu/deployments","created_at":"2017-02-08T16:16:36Z","updated_at":"2018-04-27T11:40:29Z","pushed_at":"2018-04-27T13:05:30Z","git_url":"git://github.com/snipsco/snips-nlu.git","ssh_url":"git@github.com:snipsco/snips-nlu.git","clone_url":"https://github.com/snipsco/snips-nlu.git","svn_url":"https://github.com/snipsco/snips-nlu","homepage":"https://snips-nlu.readthedocs.io","size":5927,"stargazers_count":1478,"watchers_count":1478,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":83,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":83,"open_issues":10,"watchers":1478,"default_branch":"develop"}},"base":{"label":"snipsco:develop","ref":"develop","sha":"b8aa58d7992ad2c0ccf4c548445a8a2c23b95a16","user":{"login":"snipsco","id":2564618,"avatar_url":"https://avatars0.githubusercontent.com/u/2564618?v=4","gravatar_id":"","url":"https://api.github.com/users/snipsco","html_url":"https://github.com/snipsco","followers_url":"https://api.github.com/users/snipsco/followers","following_url":"https://api.github.com/users/snipsco/following{/other_user}","gists_url":"https://api.github.com/users/snipsco/gists{/gist_id}","starred_url":"https://api.github.com/users/snipsco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snipsco/subscriptions","organizations_url":"https://api.github.com/users/snipsco/orgs","repos_url":"https://api.github.com/users/snipsco/repos","events_url":"https://api.github.com/users/snipsco/events{/privacy}","received_events_url":"https://api.github.com/users/snipsco/received_events","type":"Organization","site_admin":false},"repo":{"id":81349068,"name":"snips-nlu","full_name":"snipsco/snips-nlu","owner":{"login":"snipsco","id":2564618,"avatar_url":"https://avatars0.githubusercontent.com/u/2564618?v=4","gravatar_id":"","url":"https://api.github.com/users/snipsco","html_url":"https://github.com/snipsco","followers_url":"https://api.github.com/users/snipsco/followers","following_url":"https://api.github.com/users/snipsco/following{/other_user}","gists_url":"https://api.github.com/users/snipsco/gists{/gist_id}","starred_url":"https://api.github.com/users/snipsco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snipsco/subscriptions","organizations_url":"https://api.github.com/users/snipsco/orgs","repos_url":"https://api.github.com/users/snipsco/repos","events_url":"https://api.github.com/users/snipsco/events{/privacy}","received_events_url":"https://api.github.com/users/snipsco/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/snipsco/snips-nlu","description":"Snips Python library to extract meaning from text","fork":false,"url":"https://api.github.com/repos/snipsco/snips-nlu","forks_url":"https://api.github.com/repos/snipsco/snips-nlu/forks","keys_url":"https://api.github.com/repos/snipsco/snips-nlu/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snipsco/snips-nlu/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snipsco/snips-nlu/teams","hooks_url":"https://api.github.com/repos/snipsco/snips-nlu/hooks","issue_events_url":"https://api.github.com/repos/snipsco/snips-nlu/issues/events{/number}","events_url":"https://api.github.com/repos/snipsco/snips-nlu/events","assignees_url":"https://api.github.com/repos/snipsco/snips-nlu/assignees{/user}","branches_url":"https://api.github.com/repos/snipsco/snips-nlu/branches{/branch}","tags_url":"https://api.github.com/repos/snipsco/snips-nlu/tags","blobs_url":"https://api.github.com/repos/snipsco/snips-nlu/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snipsco/snips-nlu/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snipsco/snips-nlu/git/refs{/sha}","trees_url":"https://api.github.com/repos/snipsco/snips-nlu/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snipsco/snips-nlu/statuses/{sha}","languages_url":"https://api.github.com/repos/snipsco/snips-nlu/languages","stargazers_url":"https://api.github.com/repos/snipsco/snips-nlu/stargazers","contributors_url":"https://api.github.com/repos/snipsco/snips-nlu/contributors","subscribers_url":"https://api.github.com/repos/snipsco/snips-nlu/subscribers","subscription_url":"https://api.github.com/repos/snipsco/snips-nlu/subscription","commits_url":"https://api.github.com/repos/snipsco/snips-nlu/commits{/sha}","git_commits_url":"https://api.github.com/repos/snipsco/snips-nlu/git/commits{/sha}","comments_url":"https://api.github.com/repos/snipsco/snips-nlu/comments{/number}","issue_comment_url":"https://api.github.com/repos/snipsco/snips-nlu/issues/comments{/number}","contents_url":"https://api.github.com/repos/snipsco/snips-nlu/contents/{+path}","compare_url":"https://api.github.com/repos/snipsco/snips-nlu/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snipsco/snips-nlu/merges","archive_url":"https://api.github.com/repos/snipsco/snips-nlu/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snipsco/snips-nlu/downloads","issues_url":"https://api.github.com/repos/snipsco/snips-nlu/issues{/number}","pulls_url":"https://api.github.com/repos/snipsco/snips-nlu/pulls{/number}","milestones_url":"https://api.github.com/repos/snipsco/snips-nlu/milestones{/number}","notifications_url":"https://api.github.com/repos/snipsco/snips-nlu/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snipsco/snips-nlu/labels{/name}","releases_url":"https://api.github.com/repos/snipsco/snips-nlu/releases{/id}","deployments_url":"https://api.github.com/repos/snipsco/snips-nlu/deployments","created_at":"2017-02-08T16:16:36Z","updated_at":"2018-04-27T11:40:29Z","pushed_at":"2018-04-27T13:05:30Z","git_url":"git://github.com/snipsco/snips-nlu.git","ssh_url":"git@github.com:snipsco/snips-nlu.git","clone_url":"https://github.com/snipsco/snips-nlu.git","svn_url":"https://github.com/snipsco/snips-nlu","homepage":"https://snips-nlu.readthedocs.io","size":5927,"stargazers_count":1478,"watchers_count":1478,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":83,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":83,"open_issues":10,"watchers":1478,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/snipsco/snips-nlu/pulls/578"},"html":{"href":"https://github.com/snipsco/snips-nlu/pull/578"},"issue":{"href":"https://api.github.com/repos/snipsco/snips-nlu/issues/578"},"comments":{"href":"https://api.github.com/repos/snipsco/snips-nlu/issues/578/comments"},"review_comments":{"href":"https://api.github.com/repos/snipsco/snips-nlu/pulls/578/comments"},"review_comment":{"href":"https://api.github.com/repos/snipsco/snips-nlu/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/snipsco/snips-nlu/pulls/578/commits"},"statuses":{"href":"https://api.github.com/repos/snipsco/snips-nlu/statuses/a647393891199a12a3c5388072c0e7e70ebd2a4c"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":60,"deletions":198,"changed_files":3}}
{"actor":{"display_login":"adrienball"}}