{"action":"created","issue":{"url":"https://api.github.com/repos/telegraf/telegraf-session-firebase/issues/1","repository_url":"https://api.github.com/repos/telegraf/telegraf-session-firebase","labels_url":"https://api.github.com/repos/telegraf/telegraf-session-firebase/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/telegraf/telegraf-session-firebase/issues/1/comments","events_url":"https://api.github.com/repos/telegraf/telegraf-session-firebase/issues/1/events","html_url":"https://github.com/telegraf/telegraf-session-firebase/issues/1","id":294915502,"node_id":"MDU6SXNzdWUyOTQ5MTU1MDI=","number":1,"title":"Cannot leave scene if there is additional session data","user":{"login":"Alpvax","id":1474110,"node_id":"MDQ6VXNlcjE0NzQxMTA=","avatar_url":"https://avatars3.githubusercontent.com/u/1474110?v=4","gravatar_id":"","url":"https://api.github.com/users/Alpvax","html_url":"https://github.com/Alpvax","followers_url":"https://api.github.com/users/Alpvax/followers","following_url":"https://api.github.com/users/Alpvax/following{/other_user}","gists_url":"https://api.github.com/users/Alpvax/gists{/gist_id}","starred_url":"https://api.github.com/users/Alpvax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Alpvax/subscriptions","organizations_url":"https://api.github.com/users/Alpvax/orgs","repos_url":"https://api.github.com/users/Alpvax/repos","events_url":"https://api.github.com/users/Alpvax/events{/privacy}","received_events_url":"https://api.github.com/users/Alpvax/received_events","type":"User","site_admin":false},"labels":[{"id":689706981,"node_id":"MDU6TGFiZWw2ODk3MDY5ODE=","url":"https://api.github.com/repos/telegraf/telegraf-session-firebase/labels/bug","name":"bug","color":"ee0701","default":true},{"id":689706984,"node_id":"MDU6TGFiZWw2ODk3MDY5ODQ=","url":"https://api.github.com/repos/telegraf/telegraf-session-firebase/labels/help%20wanted","name":"help wanted","color":"33aa3f","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-06T21:17:28Z","updated_at":"2018-07-21T19:21:43Z","closed_at":null,"author_association":"NONE","body":"When `SceneContext.leave()` is called, it removes the `__scene` property from the session object.\r\nBut when the session is saved it checks if the session is an empty object, and if so removes it from the database. If it is not an empty object it calls `ref.update`, which doesn't remove the `__scene` property from the database. It should call `ref.set` instead."},"comment":{"url":"https://api.github.com/repos/telegraf/telegraf-session-firebase/issues/comments/406818133","html_url":"https://github.com/telegraf/telegraf-session-firebase/issues/1#issuecomment-406818133","issue_url":"https://api.github.com/repos/telegraf/telegraf-session-firebase/issues/1","id":406818133,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNjgxODEzMw==","user":{"login":"snowwm","id":16854668,"node_id":"MDQ6VXNlcjE2ODU0NjY4","avatar_url":"https://avatars3.githubusercontent.com/u/16854668?v=4","gravatar_id":"","url":"https://api.github.com/users/snowwm","html_url":"https://github.com/snowwm","followers_url":"https://api.github.com/users/snowwm/followers","following_url":"https://api.github.com/users/snowwm/following{/other_user}","gists_url":"https://api.github.com/users/snowwm/gists{/gist_id}","starred_url":"https://api.github.com/users/snowwm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snowwm/subscriptions","organizations_url":"https://api.github.com/users/snowwm/orgs","repos_url":"https://api.github.com/users/snowwm/repos","events_url":"https://api.github.com/users/snowwm/events{/privacy}","received_events_url":"https://api.github.com/users/snowwm/received_events","type":"User","site_admin":false},"created_at":"2018-07-21T19:21:43Z","updated_at":"2018-07-21T19:21:43Z","author_association":"NONE","body":"@dotcypress Well, and what are the reasons for using `ref.update` instead of `ref.set`? If they are strong, we can add a line to manually set `__scene` to `null` if it's `undefined`, which will effectively remove it from the database."}}
{"actor":{"display_login":"snowwm"}}