{"action":"created","issue":{"url":"https://api.github.com/repos/nim-lang/Nim/issues/7543","repository_url":"https://api.github.com/repos/nim-lang/Nim","labels_url":"https://api.github.com/repos/nim-lang/Nim/issues/7543/labels{/name}","comments_url":"https://api.github.com/repos/nim-lang/Nim/issues/7543/comments","events_url":"https://api.github.com/repos/nim-lang/Nim/issues/7543/events","html_url":"https://github.com/nim-lang/Nim/pull/7543","id":312270053,"number":7543,"title":"os.setLastModificationTime*(file: string, t: times.Time)","user":{"login":"hendrikgit","id":7437391,"avatar_url":"https://avatars3.githubusercontent.com/u/7437391?v=4","gravatar_id":"","url":"https://api.github.com/users/hendrikgit","html_url":"https://github.com/hendrikgit","followers_url":"https://api.github.com/users/hendrikgit/followers","following_url":"https://api.github.com/users/hendrikgit/following{/other_user}","gists_url":"https://api.github.com/users/hendrikgit/gists{/gist_id}","starred_url":"https://api.github.com/users/hendrikgit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hendrikgit/subscriptions","organizations_url":"https://api.github.com/users/hendrikgit/orgs","repos_url":"https://api.github.com/users/hendrikgit/repos","events_url":"https://api.github.com/users/hendrikgit/events{/privacy}","received_events_url":"https://api.github.com/users/hendrikgit/received_events","type":"User","site_admin":false},"labels":[{"id":101971351,"url":"https://api.github.com/repos/nim-lang/Nim/labels/Stdlib","name":"Stdlib","color":"eb6420","default":false},{"id":636157241,"url":"https://api.github.com/repos/nim-lang/Nim/labels/Times","name":"Times","color":"b60205","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-04-08T03:57:56Z","updated_at":"2018-04-08T06:34:50Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/nim-lang/Nim/pulls/7543","html_url":"https://github.com/nim-lang/Nim/pull/7543","diff_url":"https://github.com/nim-lang/Nim/pull/7543.diff","patch_url":"https://github.com/nim-lang/Nim/pull/7543.patch"},"body":"This PR is to add `proc setLastModificationTime*(file: string, t: times.Time)` to os.\r\n\r\nThe proc setLastModificationTime is missing it's pragma, I was not sure what was required there.\r\n\r\n`toWinTime` was added to avoid unixTimeToWinTime which expects CTime and CTime is not exported.\r\n\r\nI have not figured out yet how to only set the last modification time with utimes, so I set the last access time too. Is that acceptable behaviour? The utimes documentation says only the whole times array can be null (in that case both times will be set to current time) or they each need to have a value."},"comment":{"url":"https://api.github.com/repos/nim-lang/Nim/issues/comments/379524841","html_url":"https://github.com/nim-lang/Nim/pull/7543#issuecomment-379524841","issue_url":"https://api.github.com/repos/nim-lang/Nim/issues/7543","id":379524841,"user":{"login":"GULPF","id":1022431,"avatar_url":"https://avatars1.githubusercontent.com/u/1022431?v=4","gravatar_id":"","url":"https://api.github.com/users/GULPF","html_url":"https://github.com/GULPF","followers_url":"https://api.github.com/users/GULPF/followers","following_url":"https://api.github.com/users/GULPF/following{/other_user}","gists_url":"https://api.github.com/users/GULPF/gists{/gist_id}","starred_url":"https://api.github.com/users/GULPF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GULPF/subscriptions","organizations_url":"https://api.github.com/users/GULPF/orgs","repos_url":"https://api.github.com/users/GULPF/repos","events_url":"https://api.github.com/users/GULPF/events{/privacy}","received_events_url":"https://api.github.com/users/GULPF/received_events","type":"User","site_admin":false},"created_at":"2018-04-08T06:34:50Z","updated_at":"2018-04-08T06:34:50Z","author_association":"CONTRIBUTOR","body":"Looks good, but is there a reason why `toFILETIME` can't do the work of `toWinTime` as well? I know that `unixTimeToWinTime` is broken, but is there a common use case for getting a windows timestamp represented as a `int64` instead of a `FILETIME`?\r\n\r\nIf not, I think it's better to just deprecate `unixTimeToWinTime` and refer to `winlean.toFILETIME` as a replacement. If the user really wants the result as a `int64` then `toFILETIME(unixTime, nanoseconds).rdFileTime()` can be used."}}
{"actor":{"display_login":"GULPF"}}