{"action":"created","issue":{"url":"https://api.github.com/repos/github/VisualStudio/issues/1420","repository_url":"https://api.github.com/repos/github/VisualStudio","labels_url":"https://api.github.com/repos/github/VisualStudio/issues/1420/labels{/name}","comments_url":"https://api.github.com/repos/github/VisualStudio/issues/1420/comments","events_url":"https://api.github.com/repos/github/VisualStudio/issues/1420/events","html_url":"https://github.com/github/VisualStudio/pull/1420","id":289219592,"number":1420,"title":"Navigate to correct repository for inline comment GitHub link where fork repository is open.","user":{"login":"grokys","id":1775141,"avatar_url":"https://avatars1.githubusercontent.com/u/1775141?v=4","gravatar_id":"","url":"https://api.github.com/users/grokys","html_url":"https://github.com/grokys","followers_url":"https://api.github.com/users/grokys/followers","following_url":"https://api.github.com/users/grokys/following{/other_user}","gists_url":"https://api.github.com/users/grokys/gists{/gist_id}","starred_url":"https://api.github.com/users/grokys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grokys/subscriptions","organizations_url":"https://api.github.com/users/grokys/orgs","repos_url":"https://api.github.com/users/grokys/repos","events_url":"https://api.github.com/users/grokys/events{/privacy}","received_events_url":"https://api.github.com/users/grokys/received_events","type":"User","site_admin":true},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-01-17T10:44:12Z","updated_at":"2018-02-14T15:06:08Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/github/VisualStudio/pulls/1420","html_url":"https://github.com/github/VisualStudio/pull/1420","diff_url":"https://github.com/github/VisualStudio/pull/1420.diff","patch_url":"https://github.com/github/VisualStudio/pull/1420.patch"},"body":"When a fork repository was open in VS, but the PRs for the parent repository were being viewed, clicking on the \"date\" link in an inline comment to go to the comment online was navigating to the fork repository instead of the parent repository.\r\n\r\nTo fix this, use the correct repository owner for GitHub link in `InlineCommentThreadViewModel.GetCommentUrl`. An optional `owner` parameter was added to `UriString.ToRepositoryUrl`. which will change the owner of the produced repository URL.\r\n\r\nFixes #1413"},"comment":{"url":"https://api.github.com/repos/github/VisualStudio/issues/comments/365635184","html_url":"https://github.com/github/VisualStudio/pull/1420#issuecomment-365635184","issue_url":"https://api.github.com/repos/github/VisualStudio/issues/1420","id":365635184,"user":{"login":"grokys","id":1775141,"avatar_url":"https://avatars1.githubusercontent.com/u/1775141?v=4","gravatar_id":"","url":"https://api.github.com/users/grokys","html_url":"https://github.com/grokys","followers_url":"https://api.github.com/users/grokys/followers","following_url":"https://api.github.com/users/grokys/following{/other_user}","gists_url":"https://api.github.com/users/grokys/gists{/gist_id}","starred_url":"https://api.github.com/users/grokys/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grokys/subscriptions","organizations_url":"https://api.github.com/users/grokys/orgs","repos_url":"https://api.github.com/users/grokys/repos","events_url":"https://api.github.com/users/grokys/events{/privacy}","received_events_url":"https://api.github.com/users/grokys/received_events","type":"User","site_admin":true},"created_at":"2018-02-14T15:06:08Z","updated_at":"2018-02-14T15:06:08Z","author_association":"CONTRIBUTOR","body":"@shana I've updated the code with a few more tests and a fix.\r\n\r\n> Nit: Given owner = null and NameWithOwner != null, won't this mean that nameWithOwner will be /bar instead of bar?\r\n\r\nDid you mean the parameter `owner` here or the property `Owner`? If you mean the parameter then it would work, unless I'm misunderstanding. If you meant the `Owner` property then that can't be null if `NameWithOwner != null`.\r\n\r\n> Also, if RepositoryName is null (it can be), should this probably return null even if owner is passed in, for consistency?\r\n\r\n`RepositoryName` gets taken before owner, so if there's an owner there's a repository name."}}
{"actor":{"display_login":"grokys"}}