{"action":"reopened","number":148,"pull_request":{"url":"https://api.github.com/repos/omise/omise-magento/pulls/148","id":213533514,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNTMzNTE0","html_url":"https://github.com/omise/omise-magento/pull/148","diff_url":"https://github.com/omise/omise-magento/pull/148.diff","patch_url":"https://github.com/omise/omise-magento/pull/148.patch","issue_url":"https://api.github.com/repos/omise/omise-magento/issues/148","number":148,"state":"open","locked":false,"title":"2 installment","user":{"login":"jacekstan","id":10651523,"node_id":"MDQ6VXNlcjEwNjUxNTIz","avatar_url":"https://avatars1.githubusercontent.com/u/10651523?v=4","gravatar_id":"","url":"https://api.github.com/users/jacekstan","html_url":"https://github.com/jacekstan","followers_url":"https://api.github.com/users/jacekstan/followers","following_url":"https://api.github.com/users/jacekstan/following{/other_user}","gists_url":"https://api.github.com/users/jacekstan/gists{/gist_id}","starred_url":"https://api.github.com/users/jacekstan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jacekstan/subscriptions","organizations_url":"https://api.github.com/users/jacekstan/orgs","repos_url":"https://api.github.com/users/jacekstan/repos","events_url":"https://api.github.com/users/jacekstan/events{/privacy}","received_events_url":"https://api.github.com/users/jacekstan/received_events","type":"User","site_admin":false},"body":"Tesco lotus uses the same functionality as all other methods except CC, and tesco is not offsite method, so we need to change names for more fitting to offsite and offline payments.\r\n\r\nSo now now since Offsite functionality is common also for Offline payments like Tesco Lotus, and future payments like Installment this PR is proposal is to have 2 descriptions.\r\nOmiseAPMXXXXXX - for `offsite` and `offline` methods\r\nand OmiseCCXXXXX - for `CC` credit card related methods\r\n\r\n#### 1. Objective\r\n\r\nThis PR is necessary as for offline _tesco lotus_ functionality to use the same parts of code as offsite payments (alipay internet banking).\r\n\r\n\r\n#### 2. Description of change\r\n\r\nJust names of classes,\r\n\r\n\r\n#### 3. Quality assurance\r\n\r\nSpecify where and how you tested this and what further testing it might need.\r\n\r\n**🔧 Environments:**\r\n\r\n- **Platform version**: Magento CE 2.2.4.\r\n- **Omise plugin version**: Omise-Magento 2.4.\r\n- **PHP version**: 7.0.29.\r\n\r\n**✏️ Details:**\r\n\r\nTo properly test it you need to make payments with offsite Alipay, Internet Banking, and with Credit Card method.\r\n\r\n#### 4. Impact of the change\r\n\r\nN/A\r\n\r\n#### 5. Priority of change\r\n\r\nHigh\r\n\r\n#### 6. Additional Notes\r\n\r\nN/A","created_at":"2018-09-06T08:22:59Z","updated_at":"2018-09-06T15:36:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"172476f5edbd010a58cfc07fdefe22b149641903","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":202752921,"node_id":"MDU6TGFiZWwyMDI3NTI5MjE=","url":"https://api.github.com/repos/omise/omise-magento/labels/status:%20Invalid","name":"status: Invalid","color":"e6e6e6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/omise/omise-magento/pulls/148/commits","review_comments_url":"https://api.github.com/repos/omise/omise-magento/pulls/148/comments","review_comment_url":"https://api.github.com/repos/omise/omise-magento/pulls/comments{/number}","comments_url":"https://api.github.com/repos/omise/omise-magento/issues/148/comments","statuses_url":"https://api.github.com/repos/omise/omise-magento/statuses/12372e3d2195813f18bbfb1d585cd2f14f8f39d3","head":{"label":"omise:2-installment","ref":"2-installment","sha":"12372e3d2195813f18bbfb1d585cd2f14f8f39d3","user":{"login":"omise","id":4662729,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2NjI3Mjk=","avatar_url":"https://avatars1.githubusercontent.com/u/4662729?v=4","gravatar_id":"","url":"https://api.github.com/users/omise","html_url":"https://github.com/omise","followers_url":"https://api.github.com/users/omise/followers","following_url":"https://api.github.com/users/omise/following{/other_user}","gists_url":"https://api.github.com/users/omise/gists{/gist_id}","starred_url":"https://api.github.com/users/omise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omise/subscriptions","organizations_url":"https://api.github.com/users/omise/orgs","repos_url":"https://api.github.com/users/omise/repos","events_url":"https://api.github.com/users/omise/events{/privacy}","received_events_url":"https://api.github.com/users/omise/received_events","type":"Organization","site_admin":false},"repo":{"id":34387213,"node_id":"MDEwOlJlcG9zaXRvcnkzNDM4NzIxMw==","name":"omise-magento","full_name":"omise/omise-magento","owner":{"login":"omise","id":4662729,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2NjI3Mjk=","avatar_url":"https://avatars1.githubusercontent.com/u/4662729?v=4","gravatar_id":"","url":"https://api.github.com/users/omise","html_url":"https://github.com/omise","followers_url":"https://api.github.com/users/omise/followers","following_url":"https://api.github.com/users/omise/following{/other_user}","gists_url":"https://api.github.com/users/omise/gists{/gist_id}","starred_url":"https://api.github.com/users/omise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omise/subscriptions","organizations_url":"https://api.github.com/users/omise/orgs","repos_url":"https://api.github.com/users/omise/repos","events_url":"https://api.github.com/users/omise/events{/privacy}","received_events_url":"https://api.github.com/users/omise/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/omise/omise-magento","description":"Omise Magento Integration","fork":false,"url":"https://api.github.com/repos/omise/omise-magento","forks_url":"https://api.github.com/repos/omise/omise-magento/forks","keys_url":"https://api.github.com/repos/omise/omise-magento/keys{/key_id}","collaborators_url":"https://api.github.com/repos/omise/omise-magento/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/omise/omise-magento/teams","hooks_url":"https://api.github.com/repos/omise/omise-magento/hooks","issue_events_url":"https://api.github.com/repos/omise/omise-magento/issues/events{/number}","events_url":"https://api.github.com/repos/omise/omise-magento/events","assignees_url":"https://api.github.com/repos/omise/omise-magento/assignees{/user}","branches_url":"https://api.github.com/repos/omise/omise-magento/branches{/branch}","tags_url":"https://api.github.com/repos/omise/omise-magento/tags","blobs_url":"https://api.github.com/repos/omise/omise-magento/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/omise/omise-magento/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/omise/omise-magento/git/refs{/sha}","trees_url":"https://api.github.com/repos/omise/omise-magento/git/trees{/sha}","statuses_url":"https://api.github.com/repos/omise/omise-magento/statuses/{sha}","languages_url":"https://api.github.com/repos/omise/omise-magento/languages","stargazers_url":"https://api.github.com/repos/omise/omise-magento/stargazers","contributors_url":"https://api.github.com/repos/omise/omise-magento/contributors","subscribers_url":"https://api.github.com/repos/omise/omise-magento/subscribers","subscription_url":"https://api.github.com/repos/omise/omise-magento/subscription","commits_url":"https://api.github.com/repos/omise/omise-magento/commits{/sha}","git_commits_url":"https://api.github.com/repos/omise/omise-magento/git/commits{/sha}","comments_url":"https://api.github.com/repos/omise/omise-magento/comments{/number}","issue_comment_url":"https://api.github.com/repos/omise/omise-magento/issues/comments{/number}","contents_url":"https://api.github.com/repos/omise/omise-magento/contents/{+path}","compare_url":"https://api.github.com/repos/omise/omise-magento/compare/{base}...{head}","merges_url":"https://api.github.com/repos/omise/omise-magento/merges","archive_url":"https://api.github.com/repos/omise/omise-magento/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/omise/omise-magento/downloads","issues_url":"https://api.github.com/repos/omise/omise-magento/issues{/number}","pulls_url":"https://api.github.com/repos/omise/omise-magento/pulls{/number}","milestones_url":"https://api.github.com/repos/omise/omise-magento/milestones{/number}","notifications_url":"https://api.github.com/repos/omise/omise-magento/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/omise/omise-magento/labels{/name}","releases_url":"https://api.github.com/repos/omise/omise-magento/releases{/id}","deployments_url":"https://api.github.com/repos/omise/omise-magento/deployments","created_at":"2015-04-22T11:45:56Z","updated_at":"2018-09-04T09:19:53Z","pushed_at":"2018-09-06T11:12:33Z","git_url":"git://github.com/omise/omise-magento.git","ssh_url":"git@github.com:omise/omise-magento.git","clone_url":"https://github.com/omise/omise-magento.git","svn_url":"https://github.com/omise/omise-magento","homepage":"https://www.omise.co/","size":1750,"stargazers_count":20,"watchers_count":20,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6,"open_issues":6,"watchers":20,"default_branch":"master"}},"base":{"label":"omise:master","ref":"master","sha":"3f67ff307ddca868b29f5281ba41b098cbc22366","user":{"login":"omise","id":4662729,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2NjI3Mjk=","avatar_url":"https://avatars1.githubusercontent.com/u/4662729?v=4","gravatar_id":"","url":"https://api.github.com/users/omise","html_url":"https://github.com/omise","followers_url":"https://api.github.com/users/omise/followers","following_url":"https://api.github.com/users/omise/following{/other_user}","gists_url":"https://api.github.com/users/omise/gists{/gist_id}","starred_url":"https://api.github.com/users/omise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omise/subscriptions","organizations_url":"https://api.github.com/users/omise/orgs","repos_url":"https://api.github.com/users/omise/repos","events_url":"https://api.github.com/users/omise/events{/privacy}","received_events_url":"https://api.github.com/users/omise/received_events","type":"Organization","site_admin":false},"repo":{"id":34387213,"node_id":"MDEwOlJlcG9zaXRvcnkzNDM4NzIxMw==","name":"omise-magento","full_name":"omise/omise-magento","owner":{"login":"omise","id":4662729,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ2NjI3Mjk=","avatar_url":"https://avatars1.githubusercontent.com/u/4662729?v=4","gravatar_id":"","url":"https://api.github.com/users/omise","html_url":"https://github.com/omise","followers_url":"https://api.github.com/users/omise/followers","following_url":"https://api.github.com/users/omise/following{/other_user}","gists_url":"https://api.github.com/users/omise/gists{/gist_id}","starred_url":"https://api.github.com/users/omise/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/omise/subscriptions","organizations_url":"https://api.github.com/users/omise/orgs","repos_url":"https://api.github.com/users/omise/repos","events_url":"https://api.github.com/users/omise/events{/privacy}","received_events_url":"https://api.github.com/users/omise/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/omise/omise-magento","description":"Omise Magento Integration","fork":false,"url":"https://api.github.com/repos/omise/omise-magento","forks_url":"https://api.github.com/repos/omise/omise-magento/forks","keys_url":"https://api.github.com/repos/omise/omise-magento/keys{/key_id}","collaborators_url":"https://api.github.com/repos/omise/omise-magento/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/omise/omise-magento/teams","hooks_url":"https://api.github.com/repos/omise/omise-magento/hooks","issue_events_url":"https://api.github.com/repos/omise/omise-magento/issues/events{/number}","events_url":"https://api.github.com/repos/omise/omise-magento/events","assignees_url":"https://api.github.com/repos/omise/omise-magento/assignees{/user}","branches_url":"https://api.github.com/repos/omise/omise-magento/branches{/branch}","tags_url":"https://api.github.com/repos/omise/omise-magento/tags","blobs_url":"https://api.github.com/repos/omise/omise-magento/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/omise/omise-magento/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/omise/omise-magento/git/refs{/sha}","trees_url":"https://api.github.com/repos/omise/omise-magento/git/trees{/sha}","statuses_url":"https://api.github.com/repos/omise/omise-magento/statuses/{sha}","languages_url":"https://api.github.com/repos/omise/omise-magento/languages","stargazers_url":"https://api.github.com/repos/omise/omise-magento/stargazers","contributors_url":"https://api.github.com/repos/omise/omise-magento/contributors","subscribers_url":"https://api.github.com/repos/omise/omise-magento/subscribers","subscription_url":"https://api.github.com/repos/omise/omise-magento/subscription","commits_url":"https://api.github.com/repos/omise/omise-magento/commits{/sha}","git_commits_url":"https://api.github.com/repos/omise/omise-magento/git/commits{/sha}","comments_url":"https://api.github.com/repos/omise/omise-magento/comments{/number}","issue_comment_url":"https://api.github.com/repos/omise/omise-magento/issues/comments{/number}","contents_url":"https://api.github.com/repos/omise/omise-magento/contents/{+path}","compare_url":"https://api.github.com/repos/omise/omise-magento/compare/{base}...{head}","merges_url":"https://api.github.com/repos/omise/omise-magento/merges","archive_url":"https://api.github.com/repos/omise/omise-magento/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/omise/omise-magento/downloads","issues_url":"https://api.github.com/repos/omise/omise-magento/issues{/number}","pulls_url":"https://api.github.com/repos/omise/omise-magento/pulls{/number}","milestones_url":"https://api.github.com/repos/omise/omise-magento/milestones{/number}","notifications_url":"https://api.github.com/repos/omise/omise-magento/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/omise/omise-magento/labels{/name}","releases_url":"https://api.github.com/repos/omise/omise-magento/releases{/id}","deployments_url":"https://api.github.com/repos/omise/omise-magento/deployments","created_at":"2015-04-22T11:45:56Z","updated_at":"2018-09-04T09:19:53Z","pushed_at":"2018-09-06T11:12:33Z","git_url":"git://github.com/omise/omise-magento.git","ssh_url":"git@github.com:omise/omise-magento.git","clone_url":"https://github.com/omise/omise-magento.git","svn_url":"https://github.com/omise/omise-magento","homepage":"https://www.omise.co/","size":1750,"stargazers_count":20,"watchers_count":20,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6,"open_issues":6,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/omise/omise-magento/pulls/148"},"html":{"href":"https://github.com/omise/omise-magento/pull/148"},"issue":{"href":"https://api.github.com/repos/omise/omise-magento/issues/148"},"comments":{"href":"https://api.github.com/repos/omise/omise-magento/issues/148/comments"},"review_comments":{"href":"https://api.github.com/repos/omise/omise-magento/pulls/148/comments"},"review_comment":{"href":"https://api.github.com/repos/omise/omise-magento/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/omise/omise-magento/pulls/148/commits"},"statuses":{"href":"https://api.github.com/repos/omise/omise-magento/statuses/12372e3d2195813f18bbfb1d585cd2f14f8f39d3"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":430,"deletions":66,"changed_files":16}}
{"actor":{"display_login":"jacekstan"}}