{"action":"closed","number":5376,"pull_request":{"url":"https://api.github.com/repos/jupyterlab/jupyterlab/pulls/5376","id":217806192,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3ODA2MTky","html_url":"https://github.com/jupyterlab/jupyterlab/pull/5376","diff_url":"https://github.com/jupyterlab/jupyterlab/pull/5376.diff","patch_url":"https://github.com/jupyterlab/jupyterlab/pull/5376.patch","issue_url":"https://api.github.com/repos/jupyterlab/jupyterlab/issues/5376","number":5376,"state":"closed","locked":false,"title":"[master] adding 'writable' checks to some of the menu and toolbar options","user":{"login":"dharmaquark","id":14363644,"node_id":"MDQ6VXNlcjE0MzYzNjQ0","avatar_url":"https://avatars3.githubusercontent.com/u/14363644?v=4","gravatar_id":"","url":"https://api.github.com/users/dharmaquark","html_url":"https://github.com/dharmaquark","followers_url":"https://api.github.com/users/dharmaquark/followers","following_url":"https://api.github.com/users/dharmaquark/following{/other_user}","gists_url":"https://api.github.com/users/dharmaquark/gists{/gist_id}","starred_url":"https://api.github.com/users/dharmaquark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dharmaquark/subscriptions","organizations_url":"https://api.github.com/users/dharmaquark/orgs","repos_url":"https://api.github.com/users/dharmaquark/repos","events_url":"https://api.github.com/users/dharmaquark/events{/privacy}","received_events_url":"https://api.github.com/users/dharmaquark/received_events","type":"User","site_admin":false},"body":"adding logic to check 'writable' for the following menu items:\r\n- Save\r\n- Save As ...\r\n- Save All .. (only disabling if ALL files are not writable)\r\n- Rename\r\n\r\ntoolbar items:\r\n- Save\r\n\r\nas a followup to this PR, when the refactoring that @jasongrout  is working on around 'Save Notebook with Extras' lands, I'm hoping to add a similar 'writable' check (tricky to do that now without adding cyclic dependencies between the docmanager and mainmenu extensions)\r\n","created_at":"2018-09-24T22:26:19Z","updated_at":"2018-09-28T19:44:43Z","closed_at":"2018-09-28T19:44:43Z","merged_at":"2018-09-28T19:44:43Z","merge_commit_sha":"4d9ba2f24bb653c1e4426c07d42a45616b57df65","assignee":{"login":"saulshanabrook","id":1186124,"node_id":"MDQ6VXNlcjExODYxMjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1186124?v=4","gravatar_id":"","url":"https://api.github.com/users/saulshanabrook","html_url":"https://github.com/saulshanabrook","followers_url":"https://api.github.com/users/saulshanabrook/followers","following_url":"https://api.github.com/users/saulshanabrook/following{/other_user}","gists_url":"https://api.github.com/users/saulshanabrook/gists{/gist_id}","starred_url":"https://api.github.com/users/saulshanabrook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saulshanabrook/subscriptions","organizations_url":"https://api.github.com/users/saulshanabrook/orgs","repos_url":"https://api.github.com/users/saulshanabrook/repos","events_url":"https://api.github.com/users/saulshanabrook/events{/privacy}","received_events_url":"https://api.github.com/users/saulshanabrook/received_events","type":"User","site_admin":false},"assignees":[{"login":"saulshanabrook","id":1186124,"node_id":"MDQ6VXNlcjExODYxMjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1186124?v=4","gravatar_id":"","url":"https://api.github.com/users/saulshanabrook","html_url":"https://github.com/saulshanabrook","followers_url":"https://api.github.com/users/saulshanabrook/followers","following_url":"https://api.github.com/users/saulshanabrook/following{/other_user}","gists_url":"https://api.github.com/users/saulshanabrook/gists{/gist_id}","starred_url":"https://api.github.com/users/saulshanabrook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/saulshanabrook/subscriptions","organizations_url":"https://api.github.com/users/saulshanabrook/orgs","repos_url":"https://api.github.com/users/saulshanabrook/repos","events_url":"https://api.github.com/users/saulshanabrook/events{/privacy}","received_events_url":"https://api.github.com/users/saulshanabrook/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/jupyterlab/jupyterlab/milestones/18","html_url":"https://github.com/jupyterlab/jupyterlab/milestone/18","labels_url":"https://api.github.com/repos/jupyterlab/jupyterlab/milestones/18/labels","id":3564568,"node_id":"MDk6TWlsZXN0b25lMzU2NDU2OA==","number":18,"title":"0.35","description":"The last release before 1.0.","creator":{"login":"blink1073","id":2096628,"node_id":"MDQ6VXNlcjIwOTY2Mjg=","avatar_url":"https://avatars2.githubusercontent.com/u/2096628?v=4","gravatar_id":"","url":"https://api.github.com/users/blink1073","html_url":"https://github.com/blink1073","followers_url":"https://api.github.com/users/blink1073/followers","following_url":"https://api.github.com/users/blink1073/following{/other_user}","gists_url":"https://api.github.com/users/blink1073/gists{/gist_id}","starred_url":"https://api.github.com/users/blink1073/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blink1073/subscriptions","organizations_url":"https://api.github.com/users/blink1073/orgs","repos_url":"https://api.github.com/users/blink1073/repos","events_url":"https://api.github.com/users/blink1073/events{/privacy}","received_events_url":"https://api.github.com/users/blink1073/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":54,"state":"open","created_at":"2018-08-13T09:33:31Z","updated_at":"2018-09-28T19:44:43Z","due_on":"2018-10-04T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/jupyterlab/jupyterlab/pulls/5376/commits","review_comments_url":"https://api.github.com/repos/jupyterlab/jupyterlab/pulls/5376/comments","review_comment_url":"https://api.github.com/repos/jupyterlab/jupyterlab/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jupyterlab/jupyterlab/issues/5376/comments","statuses_url":"https://api.github.com/repos/jupyterlab/jupyterlab/statuses/7cba91c7a583a297a64dbdc12cb96149d0d61765","head":{"label":"dharmaquark:0918-readonly","ref":"0918-readonly","sha":"7cba91c7a583a297a64dbdc12cb96149d0d61765","user":{"login":"dharmaquark","id":14363644,"node_id":"MDQ6VXNlcjE0MzYzNjQ0","avatar_url":"https://avatars3.githubusercontent.com/u/14363644?v=4","gravatar_id":"","url":"https://api.github.com/users/dharmaquark","html_url":"https://github.com/dharmaquark","followers_url":"https://api.github.com/users/dharmaquark/followers","following_url":"https://api.github.com/users/dharmaquark/following{/other_user}","gists_url":"https://api.github.com/users/dharmaquark/gists{/gist_id}","starred_url":"https://api.github.com/users/dharmaquark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dharmaquark/subscriptions","organizations_url":"https://api.github.com/users/dharmaquark/orgs","repos_url":"https://api.github.com/users/dharmaquark/repos","events_url":"https://api.github.com/users/dharmaquark/events{/privacy}","received_events_url":"https://api.github.com/users/dharmaquark/received_events","type":"User","site_admin":false},"repo":{"id":93521317,"node_id":"MDEwOlJlcG9zaXRvcnk5MzUyMTMxNw==","name":"jupyterlab","full_name":"dharmaquark/jupyterlab","private":false,"owner":{"login":"dharmaquark","id":14363644,"node_id":"MDQ6VXNlcjE0MzYzNjQ0","avatar_url":"https://avatars3.githubusercontent.com/u/14363644?v=4","gravatar_id":"","url":"https://api.github.com/users/dharmaquark","html_url":"https://github.com/dharmaquark","followers_url":"https://api.github.com/users/dharmaquark/followers","following_url":"https://api.github.com/users/dharmaquark/following{/other_user}","gists_url":"https://api.github.com/users/dharmaquark/gists{/gist_id}","starred_url":"https://api.github.com/users/dharmaquark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dharmaquark/subscriptions","organizations_url":"https://api.github.com/users/dharmaquark/orgs","repos_url":"https://api.github.com/users/dharmaquark/repos","events_url":"https://api.github.com/users/dharmaquark/events{/privacy}","received_events_url":"https://api.github.com/users/dharmaquark/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dharmaquark/jupyterlab","description":"JupyterLab computational environment. This is a very early preview, and is not suitable for general usage yet.","fork":true,"url":"https://api.github.com/repos/dharmaquark/jupyterlab","forks_url":"https://api.github.com/repos/dharmaquark/jupyterlab/forks","keys_url":"https://api.github.com/repos/dharmaquark/jupyterlab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dharmaquark/jupyterlab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dharmaquark/jupyterlab/teams","hooks_url":"https://api.github.com/repos/dharmaquark/jupyterlab/hooks","issue_events_url":"https://api.github.com/repos/dharmaquark/jupyterlab/issues/events{/number}","events_url":"https://api.github.com/repos/dharmaquark/jupyterlab/events","assignees_url":"https://api.github.com/repos/dharmaquark/jupyterlab/assignees{/user}","branches_url":"https://api.github.com/repos/dharmaquark/jupyterlab/branches{/branch}","tags_url":"https://api.github.com/repos/dharmaquark/jupyterlab/tags","blobs_url":"https://api.github.com/repos/dharmaquark/jupyterlab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dharmaquark/jupyterlab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dharmaquark/jupyterlab/git/refs{/sha}","trees_url":"https://api.github.com/repos/dharmaquark/jupyterlab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dharmaquark/jupyterlab/statuses/{sha}","languages_url":"https://api.github.com/repos/dharmaquark/jupyterlab/languages","stargazers_url":"https://api.github.com/repos/dharmaquark/jupyterlab/stargazers","contributors_url":"https://api.github.com/repos/dharmaquark/jupyterlab/contributors","subscribers_url":"https://api.github.com/repos/dharmaquark/jupyterlab/subscribers","subscription_url":"https://api.github.com/repos/dharmaquark/jupyterlab/subscription","commits_url":"https://api.github.com/repos/dharmaquark/jupyterlab/commits{/sha}","git_commits_url":"https://api.github.com/repos/dharmaquark/jupyterlab/git/commits{/sha}","comments_url":"https://api.github.com/repos/dharmaquark/jupyterlab/comments{/number}","issue_comment_url":"https://api.github.com/repos/dharmaquark/jupyterlab/issues/comments{/number}","contents_url":"https://api.github.com/repos/dharmaquark/jupyterlab/contents/{+path}","compare_url":"https://api.github.com/repos/dharmaquark/jupyterlab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dharmaquark/jupyterlab/merges","archive_url":"https://api.github.com/repos/dharmaquark/jupyterlab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dharmaquark/jupyterlab/downloads","issues_url":"https://api.github.com/repos/dharmaquark/jupyterlab/issues{/number}","pulls_url":"https://api.github.com/repos/dharmaquark/jupyterlab/pulls{/number}","milestones_url":"https://api.github.com/repos/dharmaquark/jupyterlab/milestones{/number}","notifications_url":"https://api.github.com/repos/dharmaquark/jupyterlab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dharmaquark/jupyterlab/labels{/name}","releases_url":"https://api.github.com/repos/dharmaquark/jupyterlab/releases{/id}","deployments_url":"https://api.github.com/repos/dharmaquark/jupyterlab/deployments","created_at":"2017-06-06T13:25:29Z","updated_at":"2018-08-16T22:50:02Z","pushed_at":"2018-09-28T17:23:23Z","git_url":"git://github.com/dharmaquark/jupyterlab.git","ssh_url":"git@github.com:dharmaquark/jupyterlab.git","clone_url":"https://github.com/dharmaquark/jupyterlab.git","svn_url":"https://github.com/dharmaquark/jupyterlab","homepage":"","size":60283,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jupyterlab:master","ref":"master","sha":"af548c2674427da79d54ad5c4b69bb175463e9a0","user":{"login":"jupyterlab","id":22800682,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODAwNjgy","avatar_url":"https://avatars1.githubusercontent.com/u/22800682?v=4","gravatar_id":"","url":"https://api.github.com/users/jupyterlab","html_url":"https://github.com/jupyterlab","followers_url":"https://api.github.com/users/jupyterlab/followers","following_url":"https://api.github.com/users/jupyterlab/following{/other_user}","gists_url":"https://api.github.com/users/jupyterlab/gists{/gist_id}","starred_url":"https://api.github.com/users/jupyterlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jupyterlab/subscriptions","organizations_url":"https://api.github.com/users/jupyterlab/orgs","repos_url":"https://api.github.com/users/jupyterlab/repos","events_url":"https://api.github.com/users/jupyterlab/events{/privacy}","received_events_url":"https://api.github.com/users/jupyterlab/received_events","type":"Organization","site_admin":false},"repo":{"id":60374819,"node_id":"MDEwOlJlcG9zaXRvcnk2MDM3NDgxOQ==","name":"jupyterlab","full_name":"jupyterlab/jupyterlab","private":false,"owner":{"login":"jupyterlab","id":22800682,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODAwNjgy","avatar_url":"https://avatars1.githubusercontent.com/u/22800682?v=4","gravatar_id":"","url":"https://api.github.com/users/jupyterlab","html_url":"https://github.com/jupyterlab","followers_url":"https://api.github.com/users/jupyterlab/followers","following_url":"https://api.github.com/users/jupyterlab/following{/other_user}","gists_url":"https://api.github.com/users/jupyterlab/gists{/gist_id}","starred_url":"https://api.github.com/users/jupyterlab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jupyterlab/subscriptions","organizations_url":"https://api.github.com/users/jupyterlab/orgs","repos_url":"https://api.github.com/users/jupyterlab/repos","events_url":"https://api.github.com/users/jupyterlab/events{/privacy}","received_events_url":"https://api.github.com/users/jupyterlab/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/jupyterlab/jupyterlab","description":"JupyterLab computational environment.","fork":false,"url":"https://api.github.com/repos/jupyterlab/jupyterlab","forks_url":"https://api.github.com/repos/jupyterlab/jupyterlab/forks","keys_url":"https://api.github.com/repos/jupyterlab/jupyterlab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jupyterlab/jupyterlab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jupyterlab/jupyterlab/teams","hooks_url":"https://api.github.com/repos/jupyterlab/jupyterlab/hooks","issue_events_url":"https://api.github.com/repos/jupyterlab/jupyterlab/issues/events{/number}","events_url":"https://api.github.com/repos/jupyterlab/jupyterlab/events","assignees_url":"https://api.github.com/repos/jupyterlab/jupyterlab/assignees{/user}","branches_url":"https://api.github.com/repos/jupyterlab/jupyterlab/branches{/branch}","tags_url":"https://api.github.com/repos/jupyterlab/jupyterlab/tags","blobs_url":"https://api.github.com/repos/jupyterlab/jupyterlab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jupyterlab/jupyterlab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jupyterlab/jupyterlab/git/refs{/sha}","trees_url":"https://api.github.com/repos/jupyterlab/jupyterlab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jupyterlab/jupyterlab/statuses/{sha}","languages_url":"https://api.github.com/repos/jupyterlab/jupyterlab/languages","stargazers_url":"https://api.github.com/repos/jupyterlab/jupyterlab/stargazers","contributors_url":"https://api.github.com/repos/jupyterlab/jupyterlab/contributors","subscribers_url":"https://api.github.com/repos/jupyterlab/jupyterlab/subscribers","subscription_url":"https://api.github.com/repos/jupyterlab/jupyterlab/subscription","commits_url":"https://api.github.com/repos/jupyterlab/jupyterlab/commits{/sha}","git_commits_url":"https://api.github.com/repos/jupyterlab/jupyterlab/git/commits{/sha}","comments_url":"https://api.github.com/repos/jupyterlab/jupyterlab/comments{/number}","issue_comment_url":"https://api.github.com/repos/jupyterlab/jupyterlab/issues/comments{/number}","contents_url":"https://api.github.com/repos/jupyterlab/jupyterlab/contents/{+path}","compare_url":"https://api.github.com/repos/jupyterlab/jupyterlab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jupyterlab/jupyterlab/merges","archive_url":"https://api.github.com/repos/jupyterlab/jupyterlab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jupyterlab/jupyterlab/downloads","issues_url":"https://api.github.com/repos/jupyterlab/jupyterlab/issues{/number}","pulls_url":"https://api.github.com/repos/jupyterlab/jupyterlab/pulls{/number}","milestones_url":"https://api.github.com/repos/jupyterlab/jupyterlab/milestones{/number}","notifications_url":"https://api.github.com/repos/jupyterlab/jupyterlab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jupyterlab/jupyterlab/labels{/name}","releases_url":"https://api.github.com/repos/jupyterlab/jupyterlab/releases{/id}","deployments_url":"https://api.github.com/repos/jupyterlab/jupyterlab/deployments","created_at":"2016-06-03T20:09:17Z","updated_at":"2018-09-28T19:24:51Z","pushed_at":"2018-09-28T19:44:43Z","git_url":"git://github.com/jupyterlab/jupyterlab.git","ssh_url":"git@github.com:jupyterlab/jupyterlab.git","clone_url":"https://github.com/jupyterlab/jupyterlab.git","svn_url":"https://github.com/jupyterlab/jupyterlab","homepage":"","size":61597,"stargazers_count":6360,"watchers_count":6360,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":820,"mirror_url":null,"archived":false,"open_issues_count":812,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":820,"open_issues":812,"watchers":6360,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jupyterlab/jupyterlab/pulls/5376"},"html":{"href":"https://github.com/jupyterlab/jupyterlab/pull/5376"},"issue":{"href":"https://api.github.com/repos/jupyterlab/jupyterlab/issues/5376"},"comments":{"href":"https://api.github.com/repos/jupyterlab/jupyterlab/issues/5376/comments"},"review_comments":{"href":"https://api.github.com/repos/jupyterlab/jupyterlab/pulls/5376/comments"},"review_comment":{"href":"https://api.github.com/repos/jupyterlab/jupyterlab/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jupyterlab/jupyterlab/pulls/5376/commits"},"statuses":{"href":"https://api.github.com/repos/jupyterlab/jupyterlab/statuses/7cba91c7a583a297a64dbdc12cb96149d0d61765"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jasongrout","id":192614,"node_id":"MDQ6VXNlcjE5MjYxNA==","avatar_url":"https://avatars0.githubusercontent.com/u/192614?v=4","gravatar_id":"","url":"https://api.github.com/users/jasongrout","html_url":"https://github.com/jasongrout","followers_url":"https://api.github.com/users/jasongrout/followers","following_url":"https://api.github.com/users/jasongrout/following{/other_user}","gists_url":"https://api.github.com/users/jasongrout/gists{/gist_id}","starred_url":"https://api.github.com/users/jasongrout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasongrout/subscriptions","organizations_url":"https://api.github.com/users/jasongrout/orgs","repos_url":"https://api.github.com/users/jasongrout/repos","events_url":"https://api.github.com/users/jasongrout/events{/privacy}","received_events_url":"https://api.github.com/users/jasongrout/received_events","type":"User","site_admin":false},"comments":20,"review_comments":2,"maintainer_can_modify":false,"commits":6,"additions":29,"deletions":3,"changed_files":2}}
{"actor":{"display_login":"jasongrout"}}