{"action":"closed","issue":{"url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/issues/470","repository_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild","labels_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/issues/470/labels{/name}","comments_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/issues/470/comments","events_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/issues/470/events","html_url":"https://github.com/SonarSource/sonar-scanner-msbuild/issues/470","id":311606045,"number":470,"title":"Allow users to simply extend the list MSBuild Project Items","user":{"login":"Evangelink","id":11340282,"avatar_url":"https://avatars0.githubusercontent.com/u/11340282?v=4","gravatar_id":"","url":"https://api.github.com/users/Evangelink","html_url":"https://github.com/Evangelink","followers_url":"https://api.github.com/users/Evangelink/followers","following_url":"https://api.github.com/users/Evangelink/following{/other_user}","gists_url":"https://api.github.com/users/Evangelink/gists{/gist_id}","starred_url":"https://api.github.com/users/Evangelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Evangelink/subscriptions","organizations_url":"https://api.github.com/users/Evangelink/orgs","repos_url":"https://api.github.com/users/Evangelink/repos","events_url":"https://api.github.com/users/Evangelink/events{/privacy}","received_events_url":"https://api.github.com/users/Evangelink/received_events","type":"User","site_admin":false},"labels":[{"id":844836656,"url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/labels/Status:%20Needs%20Review","name":"Status: Needs Review","color":"b60205","default":false},{"id":844835056,"url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/labels/Type:%20New%20Feature","name":"Type: New Feature","color":"0e8a16","default":false}],"state":"closed","locked":false,"assignee":{"login":"michalb-sonar","id":28255392,"avatar_url":"https://avatars1.githubusercontent.com/u/28255392?v=4","gravatar_id":"","url":"https://api.github.com/users/michalb-sonar","html_url":"https://github.com/michalb-sonar","followers_url":"https://api.github.com/users/michalb-sonar/followers","following_url":"https://api.github.com/users/michalb-sonar/following{/other_user}","gists_url":"https://api.github.com/users/michalb-sonar/gists{/gist_id}","starred_url":"https://api.github.com/users/michalb-sonar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michalb-sonar/subscriptions","organizations_url":"https://api.github.com/users/michalb-sonar/orgs","repos_url":"https://api.github.com/users/michalb-sonar/repos","events_url":"https://api.github.com/users/michalb-sonar/events{/privacy}","received_events_url":"https://api.github.com/users/michalb-sonar/received_events","type":"User","site_admin":false},"assignees":[{"login":"michalb-sonar","id":28255392,"avatar_url":"https://avatars1.githubusercontent.com/u/28255392?v=4","gravatar_id":"","url":"https://api.github.com/users/michalb-sonar","html_url":"https://github.com/michalb-sonar","followers_url":"https://api.github.com/users/michalb-sonar/followers","following_url":"https://api.github.com/users/michalb-sonar/following{/other_user}","gists_url":"https://api.github.com/users/michalb-sonar/gists{/gist_id}","starred_url":"https://api.github.com/users/michalb-sonar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michalb-sonar/subscriptions","organizations_url":"https://api.github.com/users/michalb-sonar/orgs","repos_url":"https://api.github.com/users/michalb-sonar/repos","events_url":"https://api.github.com/users/michalb-sonar/events{/privacy}","received_events_url":"https://api.github.com/users/michalb-sonar/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/milestones/3","html_url":"https://github.com/SonarSource/sonar-scanner-msbuild/milestone/3","labels_url":"https://api.github.com/repos/SonarSource/sonar-scanner-msbuild/milestones/3/labels","id":3238165,"number":3,"title":"4.2","description":"Improve support for other languages and (visual studio) project types","creator":{"login":"Evangelink","id":11340282,"avatar_url":"https://avatars0.githubusercontent.com/u/11340282?v=4","gravatar_id":"","url":"https://api.github.com/users/Evangelink","html_url":"https://github.com/Evangelink","followers_url":"https://api.github.com/users/Evangelink/followers","following_url":"https://api.github.com/users/Evangelink/following{/other_user}","gists_url":"https://api.github.com/users/Evangelink/gists{/gist_id}","starred_url":"https://api.github.com/users/Evangelink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Evangelink/subscriptions","organizations_url":"https://api.github.com/users/Evangelink/orgs","repos_url":"https://api.github.com/users/Evangelink/repos","events_url":"https://api.github.com/users/Evangelink/events{/privacy}","received_events_url":"https://api.github.com/users/Evangelink/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":2,"state":"open","created_at":"2018-04-03T10:22:44Z","updated_at":"2018-04-06T14:08:54Z","due_on":"2018-04-06T07:00:00Z","closed_at":null},"comments":0,"created_at":"2018-04-05T13:17:20Z","updated_at":"2018-04-06T14:08:54Z","closed_at":"2018-04-06T14:08:54Z","author_association":"CONTRIBUTOR","body":"### Description\r\n\r\nWe have ([here](https://github.com/SonarSource/sonar-scanner-msbuild/blob/master/src/SonarScanner.MSBuild.Tasks/Targets/SonarQube.Integration.targets#L96)) a hard-coded list of `Project Items` we support (i.e. analyze). It is possible that our end-users rely on custom `Project Items` coming from specific tools. If the user wants to support these new files he will have to put in each of the MSBuild project he is using the following lines:\r\n\r\n```\r\n<PropertyGroup>\r\n    <SQAnalysisFileItemTypes Condition=\" $(SQAnalysisFileItemTypes) == '' \">Compile;Content;EmbeddedResource;None;ClCompile;ClInclude;Page;TypeScriptCompile;EXTRA_SUPPORTED_PROJECT_ITEMS</SQAnalysisFileItemTypes>\r\n</PropertyGroup>\r\n```\r\n\r\nThis is not ideal because this list can change between versions, forcing the user to track changes to update his \"hack\". Besides that's a lot of boilerplace just to add a few items.\r\n\r\n### Suggestion\r\n\r\nAdd a new property (e.g. `SQAdditionalAnalysisFileItemTypes`), empty by default that would be concatenated to `SQAnalysisFileItemTypes `. Doing so the user would be able to specify only the following:\r\n\r\n```\r\n<PropertyGroup>\r\n    <SQAdditionalAnalysisFileItemTypes>$(SQAdditionalAnalysisFileItemTypes);EXTRA_SUPPORTED_PROJECT_ITEMS</SQAdditionalAnalysisFileItemTypes>\r\n</PropertyGroup>\r\n```"}}
{"actor":{"display_login":"michalb-sonar"}}