{"action":"created","comment":{"url":"https://api.github.com/repos/xapi-project/xenopsd/pulls/comments/174492084","pull_request_review_id":103858395,"id":174492084,"diff_hunk":"@@ -1012,9 +1008,15 @@ module VM = struct\n               for i = 0 to vm.vcpu_max - 1 do\n                 Device.Vcpu.add ~xs ~devid:i domid (i < vm.vcpus)\n               done;\n-              set_domain_type ~xs domid vm\n-           );\n-      )\n+              set_domain_type ~xs domid vm;\n+              Some {\n+                VmExtra.persistent = persistent;\n+                VmExtra.non_persistent = non_persistent","path":"xc/xenops_server_xen.ml","position":44,"original_position":35,"commit_id":"f8a822f95f586a573756fd9e851e0575a9b5cdb3","original_commit_id":"5b875a8f7900860460868f4468e0a5bc054a4451","user":{"login":"jonludlam","id":210963,"avatar_url":"https://avatars3.githubusercontent.com/u/210963?v=4","gravatar_id":"","url":"https://api.github.com/users/jonludlam","html_url":"https://github.com/jonludlam","followers_url":"https://api.github.com/users/jonludlam/followers","following_url":"https://api.github.com/users/jonludlam/following{/other_user}","gists_url":"https://api.github.com/users/jonludlam/gists{/gist_id}","starred_url":"https://api.github.com/users/jonludlam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonludlam/subscriptions","organizations_url":"https://api.github.com/users/jonludlam/orgs","repos_url":"https://api.github.com/users/jonludlam/repos","events_url":"https://api.github.com/users/jonludlam/events{/privacy}","received_events_url":"https://api.github.com/users/jonludlam/received_events","type":"User","site_admin":false},"body":"We're doing quite a lot here under this mutex - do we need to?","created_at":"2018-03-14T15:06:01Z","updated_at":"2018-03-14T15:06:01Z","html_url":"https://github.com/xapi-project/xenopsd/pull/475#discussion_r174492084","pull_request_url":"https://api.github.com/repos/xapi-project/xenopsd/pulls/475","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/xapi-project/xenopsd/pulls/comments/174492084"},"html":{"href":"https://github.com/xapi-project/xenopsd/pull/475#discussion_r174492084"},"pull_request":{"href":"https://api.github.com/repos/xapi-project/xenopsd/pulls/475"}}},"pull_request":{"url":"https://api.github.com/repos/xapi-project/xenopsd/pulls/475","id":174983173,"html_url":"https://github.com/xapi-project/xenopsd/pull/475","diff_url":"https://github.com/xapi-project/xenopsd/pull/475.diff","patch_url":"https://github.com/xapi-project/xenopsd/pull/475.patch","issue_url":"https://api.github.com/repos/xapi-project/xenopsd/issues/475","number":475,"state":"open","locked":false,"title":"CA-284768: Fix race between metadata DB updates","user":{"login":"robhoes","id":413005,"avatar_url":"https://avatars1.githubusercontent.com/u/413005?v=4","gravatar_id":"","url":"https://api.github.com/users/robhoes","html_url":"https://github.com/robhoes","followers_url":"https://api.github.com/users/robhoes/followers","following_url":"https://api.github.com/users/robhoes/following{/other_user}","gists_url":"https://api.github.com/users/robhoes/gists{/gist_id}","starred_url":"https://api.github.com/users/robhoes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robhoes/subscriptions","organizations_url":"https://api.github.com/users/robhoes/orgs","repos_url":"https://api.github.com/users/robhoes/repos","events_url":"https://api.github.com/users/robhoes/events{/privacy}","received_events_url":"https://api.github.com/users/robhoes/received_events","type":"User","site_admin":false},"body":"This passed a (smallish) stress test where VMs underwent many lifecycle operations.","created_at":"2018-03-14T14:59:24Z","updated_at":"2018-03-14T15:06:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b446c22009856602a2f114682bbbb4b2788f7bde","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/xapi-project/xenopsd/pulls/475/commits","review_comments_url":"https://api.github.com/repos/xapi-project/xenopsd/pulls/475/comments","review_comment_url":"https://api.github.com/repos/xapi-project/xenopsd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xapi-project/xenopsd/issues/475/comments","statuses_url":"https://api.github.com/repos/xapi-project/xenopsd/statuses/f8a822f95f586a573756fd9e851e0575a9b5cdb3","head":{"label":"robhoes:master","ref":"master","sha":"f8a822f95f586a573756fd9e851e0575a9b5cdb3","user":{"login":"robhoes","id":413005,"avatar_url":"https://avatars1.githubusercontent.com/u/413005?v=4","gravatar_id":"","url":"https://api.github.com/users/robhoes","html_url":"https://github.com/robhoes","followers_url":"https://api.github.com/users/robhoes/followers","following_url":"https://api.github.com/users/robhoes/following{/other_user}","gists_url":"https://api.github.com/users/robhoes/gists{/gist_id}","starred_url":"https://api.github.com/users/robhoes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robhoes/subscriptions","organizations_url":"https://api.github.com/users/robhoes/orgs","repos_url":"https://api.github.com/users/robhoes/repos","events_url":"https://api.github.com/users/robhoes/events{/privacy}","received_events_url":"https://api.github.com/users/robhoes/received_events","type":"User","site_admin":false},"repo":{"id":11787155,"name":"xenopsd","full_name":"robhoes/xenopsd","owner":{"login":"robhoes","id":413005,"avatar_url":"https://avatars1.githubusercontent.com/u/413005?v=4","gravatar_id":"","url":"https://api.github.com/users/robhoes","html_url":"https://github.com/robhoes","followers_url":"https://api.github.com/users/robhoes/followers","following_url":"https://api.github.com/users/robhoes/following{/other_user}","gists_url":"https://api.github.com/users/robhoes/gists{/gist_id}","starred_url":"https://api.github.com/users/robhoes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robhoes/subscriptions","organizations_url":"https://api.github.com/users/robhoes/orgs","repos_url":"https://api.github.com/users/robhoes/repos","events_url":"https://api.github.com/users/robhoes/events{/privacy}","received_events_url":"https://api.github.com/users/robhoes/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/robhoes/xenopsd","description":"XCP toolstack domain manager","fork":true,"url":"https://api.github.com/repos/robhoes/xenopsd","forks_url":"https://api.github.com/repos/robhoes/xenopsd/forks","keys_url":"https://api.github.com/repos/robhoes/xenopsd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robhoes/xenopsd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robhoes/xenopsd/teams","hooks_url":"https://api.github.com/repos/robhoes/xenopsd/hooks","issue_events_url":"https://api.github.com/repos/robhoes/xenopsd/issues/events{/number}","events_url":"https://api.github.com/repos/robhoes/xenopsd/events","assignees_url":"https://api.github.com/repos/robhoes/xenopsd/assignees{/user}","branches_url":"https://api.github.com/repos/robhoes/xenopsd/branches{/branch}","tags_url":"https://api.github.com/repos/robhoes/xenopsd/tags","blobs_url":"https://api.github.com/repos/robhoes/xenopsd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robhoes/xenopsd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robhoes/xenopsd/git/refs{/sha}","trees_url":"https://api.github.com/repos/robhoes/xenopsd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robhoes/xenopsd/statuses/{sha}","languages_url":"https://api.github.com/repos/robhoes/xenopsd/languages","stargazers_url":"https://api.github.com/repos/robhoes/xenopsd/stargazers","contributors_url":"https://api.github.com/repos/robhoes/xenopsd/contributors","subscribers_url":"https://api.github.com/repos/robhoes/xenopsd/subscribers","subscription_url":"https://api.github.com/repos/robhoes/xenopsd/subscription","commits_url":"https://api.github.com/repos/robhoes/xenopsd/commits{/sha}","git_commits_url":"https://api.github.com/repos/robhoes/xenopsd/git/commits{/sha}","comments_url":"https://api.github.com/repos/robhoes/xenopsd/comments{/number}","issue_comment_url":"https://api.github.com/repos/robhoes/xenopsd/issues/comments{/number}","contents_url":"https://api.github.com/repos/robhoes/xenopsd/contents/{+path}","compare_url":"https://api.github.com/repos/robhoes/xenopsd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robhoes/xenopsd/merges","archive_url":"https://api.github.com/repos/robhoes/xenopsd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robhoes/xenopsd/downloads","issues_url":"https://api.github.com/repos/robhoes/xenopsd/issues{/number}","pulls_url":"https://api.github.com/repos/robhoes/xenopsd/pulls{/number}","milestones_url":"https://api.github.com/repos/robhoes/xenopsd/milestones{/number}","notifications_url":"https://api.github.com/repos/robhoes/xenopsd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robhoes/xenopsd/labels{/name}","releases_url":"https://api.github.com/repos/robhoes/xenopsd/releases{/id}","deployments_url":"https://api.github.com/repos/robhoes/xenopsd/deployments","created_at":"2013-07-31T09:13:05Z","updated_at":"2018-03-14T14:56:48Z","pushed_at":"2018-03-14T14:56:44Z","git_url":"git://github.com/robhoes/xenopsd.git","ssh_url":"git@github.com:robhoes/xenopsd.git","clone_url":"https://github.com/robhoes/xenopsd.git","svn_url":"https://github.com/robhoes/xenopsd","homepage":null,"size":4449,"stargazers_count":0,"watchers_count":0,"language":"OCaml","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"xapi-project:master","ref":"master","sha":"53a707caf66c5e2dd392c8d93c30b45150970b25","user":{"login":"xapi-project","id":317268,"avatar_url":"https://avatars3.githubusercontent.com/u/317268?v=4","gravatar_id":"","url":"https://api.github.com/users/xapi-project","html_url":"https://github.com/xapi-project","followers_url":"https://api.github.com/users/xapi-project/followers","following_url":"https://api.github.com/users/xapi-project/following{/other_user}","gists_url":"https://api.github.com/users/xapi-project/gists{/gist_id}","starred_url":"https://api.github.com/users/xapi-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xapi-project/subscriptions","organizations_url":"https://api.github.com/users/xapi-project/orgs","repos_url":"https://api.github.com/users/xapi-project/repos","events_url":"https://api.github.com/users/xapi-project/events{/privacy}","received_events_url":"https://api.github.com/users/xapi-project/received_events","type":"Organization","site_admin":false},"repo":{"id":7563740,"name":"xenopsd","full_name":"xapi-project/xenopsd","owner":{"login":"xapi-project","id":317268,"avatar_url":"https://avatars3.githubusercontent.com/u/317268?v=4","gravatar_id":"","url":"https://api.github.com/users/xapi-project","html_url":"https://github.com/xapi-project","followers_url":"https://api.github.com/users/xapi-project/followers","following_url":"https://api.github.com/users/xapi-project/following{/other_user}","gists_url":"https://api.github.com/users/xapi-project/gists{/gist_id}","starred_url":"https://api.github.com/users/xapi-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xapi-project/subscriptions","organizations_url":"https://api.github.com/users/xapi-project/orgs","repos_url":"https://api.github.com/users/xapi-project/repos","events_url":"https://api.github.com/users/xapi-project/events{/privacy}","received_events_url":"https://api.github.com/users/xapi-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xapi-project/xenopsd","description":"XCP toolstack domain manager","fork":false,"url":"https://api.github.com/repos/xapi-project/xenopsd","forks_url":"https://api.github.com/repos/xapi-project/xenopsd/forks","keys_url":"https://api.github.com/repos/xapi-project/xenopsd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xapi-project/xenopsd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xapi-project/xenopsd/teams","hooks_url":"https://api.github.com/repos/xapi-project/xenopsd/hooks","issue_events_url":"https://api.github.com/repos/xapi-project/xenopsd/issues/events{/number}","events_url":"https://api.github.com/repos/xapi-project/xenopsd/events","assignees_url":"https://api.github.com/repos/xapi-project/xenopsd/assignees{/user}","branches_url":"https://api.github.com/repos/xapi-project/xenopsd/branches{/branch}","tags_url":"https://api.github.com/repos/xapi-project/xenopsd/tags","blobs_url":"https://api.github.com/repos/xapi-project/xenopsd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xapi-project/xenopsd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xapi-project/xenopsd/git/refs{/sha}","trees_url":"https://api.github.com/repos/xapi-project/xenopsd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xapi-project/xenopsd/statuses/{sha}","languages_url":"https://api.github.com/repos/xapi-project/xenopsd/languages","stargazers_url":"https://api.github.com/repos/xapi-project/xenopsd/stargazers","contributors_url":"https://api.github.com/repos/xapi-project/xenopsd/contributors","subscribers_url":"https://api.github.com/repos/xapi-project/xenopsd/subscribers","subscription_url":"https://api.github.com/repos/xapi-project/xenopsd/subscription","commits_url":"https://api.github.com/repos/xapi-project/xenopsd/commits{/sha}","git_commits_url":"https://api.github.com/repos/xapi-project/xenopsd/git/commits{/sha}","comments_url":"https://api.github.com/repos/xapi-project/xenopsd/comments{/number}","issue_comment_url":"https://api.github.com/repos/xapi-project/xenopsd/issues/comments{/number}","contents_url":"https://api.github.com/repos/xapi-project/xenopsd/contents/{+path}","compare_url":"https://api.github.com/repos/xapi-project/xenopsd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xapi-project/xenopsd/merges","archive_url":"https://api.github.com/repos/xapi-project/xenopsd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xapi-project/xenopsd/downloads","issues_url":"https://api.github.com/repos/xapi-project/xenopsd/issues{/number}","pulls_url":"https://api.github.com/repos/xapi-project/xenopsd/pulls{/number}","milestones_url":"https://api.github.com/repos/xapi-project/xenopsd/milestones{/number}","notifications_url":"https://api.github.com/repos/xapi-project/xenopsd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xapi-project/xenopsd/labels{/name}","releases_url":"https://api.github.com/repos/xapi-project/xenopsd/releases{/id}","deployments_url":"https://api.github.com/repos/xapi-project/xenopsd/deployments","created_at":"2013-01-11T17:19:31Z","updated_at":"2018-03-12T14:30:21Z","pushed_at":"2018-03-14T14:59:25Z","git_url":"git://github.com/xapi-project/xenopsd.git","ssh_url":"git@github.com:xapi-project/xenopsd.git","clone_url":"https://github.com/xapi-project/xenopsd.git","svn_url":"https://github.com/xapi-project/xenopsd","homepage":null,"size":33056,"stargazers_count":7,"watchers_count":7,"language":"OCaml","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":56,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":56,"open_issues":11,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xapi-project/xenopsd/pulls/475"},"html":{"href":"https://github.com/xapi-project/xenopsd/pull/475"},"issue":{"href":"https://api.github.com/repos/xapi-project/xenopsd/issues/475"},"comments":{"href":"https://api.github.com/repos/xapi-project/xenopsd/issues/475/comments"},"review_comments":{"href":"https://api.github.com/repos/xapi-project/xenopsd/pulls/475/comments"},"review_comment":{"href":"https://api.github.com/repos/xapi-project/xenopsd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xapi-project/xenopsd/pulls/475/commits"},"statuses":{"href":"https://api.github.com/repos/xapi-project/xenopsd/statuses/f8a822f95f586a573756fd9e851e0575a9b5cdb3"}},"author_association":"OWNER"}}
{"actor":{"display_login":"jonludlam"}}