{"action":"created","issue":{"url":"https://api.github.com/repos/firecracker-microvm/firecracker-go-sdk/issues/32","repository_url":"https://api.github.com/repos/firecracker-microvm/firecracker-go-sdk","labels_url":"https://api.github.com/repos/firecracker-microvm/firecracker-go-sdk/issues/32/labels{/name}","comments_url":"https://api.github.com/repos/firecracker-microvm/firecracker-go-sdk/issues/32/comments","events_url":"https://api.github.com/repos/firecracker-microvm/firecracker-go-sdk/issues/32/events","html_url":"https://github.com/firecracker-microvm/firecracker-go-sdk/issues/32","id":387993081,"node_id":"MDU6SXNzdWUzODc5OTMwODE=","number":32,"title":"firectl should check PATH for firecracker by default","user":{"login":"nmeyerhans","id":621967,"node_id":"MDQ6VXNlcjYyMTk2Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/621967?v=4","gravatar_id":"","url":"https://api.github.com/users/nmeyerhans","html_url":"https://github.com/nmeyerhans","followers_url":"https://api.github.com/users/nmeyerhans/followers","following_url":"https://api.github.com/users/nmeyerhans/following{/other_user}","gists_url":"https://api.github.com/users/nmeyerhans/gists{/gist_id}","starred_url":"https://api.github.com/users/nmeyerhans/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmeyerhans/subscriptions","organizations_url":"https://api.github.com/users/nmeyerhans/orgs","repos_url":"https://api.github.com/users/nmeyerhans/repos","events_url":"https://api.github.com/users/nmeyerhans/events{/privacy}","received_events_url":"https://api.github.com/users/nmeyerhans/received_events","type":"User","site_admin":false},"labels":[{"id":1122441362,"node_id":"MDU6TGFiZWwxMTIyNDQxMzYy","url":"https://api.github.com/repos/firecracker-microvm/firecracker-go-sdk/labels/bug","name":"bug","color":"d73a4a","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-12-05T23:36:31Z","updated_at":"2018-12-05T23:48:31Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Currently, if you don't explicitly provide the location of the firecracker binary, firectl fails with an unhelpful error:\r\n> $ ./cmd/firectl/firectl --root-drive=testdata/drive-2.img --kernel-opts=\"ro console=ttyS0 noapic reboot=k panic=0 pci=off nomodules\"              \r\nINFO[0000] Called startVMM(), setting up a VMM on ./firecracker.sock \r\nERRO[0000] Failed to start VMM: fork/exec : no such file or directory \r\nFATA[0000] Firecracker Init returned error fork/exec : no such file or directory\r\n\r\nWe should address this two ways:\r\n1. Consult `PATH` by default, overriding only if `--firecracker-binary=` is provided.\r\n2. Report a meaningful error in the event that there is no firecracker binary found or provided."},"comment":{"url":"https://api.github.com/repos/firecracker-microvm/firecracker-go-sdk/issues/comments/444695265","html_url":"https://github.com/firecracker-microvm/firecracker-go-sdk/issues/32#issuecomment-444695265","issue_url":"https://api.github.com/repos/firecracker-microvm/firecracker-go-sdk/issues/32","id":444695265,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NDY5NTI2NQ==","user":{"login":"xibz","id":1964445,"node_id":"MDQ6VXNlcjE5NjQ0NDU=","avatar_url":"https://avatars0.githubusercontent.com/u/1964445?v=4","gravatar_id":"","url":"https://api.github.com/users/xibz","html_url":"https://github.com/xibz","followers_url":"https://api.github.com/users/xibz/followers","following_url":"https://api.github.com/users/xibz/following{/other_user}","gists_url":"https://api.github.com/users/xibz/gists{/gist_id}","starred_url":"https://api.github.com/users/xibz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xibz/subscriptions","organizations_url":"https://api.github.com/users/xibz/orgs","repos_url":"https://api.github.com/users/xibz/repos","events_url":"https://api.github.com/users/xibz/events{/privacy}","received_events_url":"https://api.github.com/users/xibz/received_events","type":"User","site_admin":false},"created_at":"2018-12-05T23:48:31Z","updated_at":"2018-12-05T23:48:31Z","author_association":"CONTRIBUTOR","body":"Okay, good to know. I will go ahead and update to allow overriding and also return a meaningful error if the binary cant be found in the path"}}
{"actor":{"display_login":"xibz"}}