{"action":"created","comment":{"url":"https://api.github.com/repos/Spadavecchia/liquid-elixir/pulls/comments/215114859","pull_request_review_id":152309951,"id":215114859,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTExNDg1OQ==","diff_hunk":"@@ -1,33 +1,23 @@\n defmodule Liquid.Combinators.Tags.CustomBlock do\n+  @moduledoc \"\"\"\n+  Allows to parse a user's custom tag block.\n+  \"\"\"\n   import NimbleParsec\n   alias Liquid.Combinators.Tags.CustomTag\n \n-  def end_name do\n-    valid_end_name()\n-    |> unwrap_and_tag(:custom_name)\n-  end\n-\n-  defp markup do\n-    empty()\n-    |> parsec(:ignore_whitespaces)\n-    |> concat(valid_markup())\n-    |> reduce({List, :to_string, []})\n-    |> unwrap_and_tag(:custom_markup)\n-  end\n+  @type t :: [custom_block: CustomBlock.markup()]\n \n-  def opener_custom_tag do\n-    parsec(:start_tag)\n-    |> concat(end_name())\n-    |> optional(markup())\n-    |> parsec(:end_tag)\n-  end\n-\n-  def closer_custom_tag do\n-    parsec(:start_tag)\n-    |> concat(end_name())\n-    |> parsec(:end_tag)\n-  end\n+  @type markup :: [\n+          custom_name: String.t(),\n+          custom_markup: String.t(),\n+          body: Liquid.NimbleParser.t()\n+        ]\n \n+  @doc \"\"\"\n+  Parses a  Custom tag of type block, creates a Keyword list where the key `:custom_block`","path":"lib/liquid/combinators/tags/custom_block.ex","position":41,"original_position":41,"commit_id":"04d74490d64b8722ebb6ef2e2a03e6051230c0a9","original_commit_id":"04d74490d64b8722ebb6ef2e2a03e6051230c0a9","user":{"login":"Spadavecchia","id":1404185,"node_id":"MDQ6VXNlcjE0MDQxODU=","avatar_url":"https://avatars2.githubusercontent.com/u/1404185?v=4","gravatar_id":"","url":"https://api.github.com/users/Spadavecchia","html_url":"https://github.com/Spadavecchia","followers_url":"https://api.github.com/users/Spadavecchia/followers","following_url":"https://api.github.com/users/Spadavecchia/following{/other_user}","gists_url":"https://api.github.com/users/Spadavecchia/gists{/gist_id}","starred_url":"https://api.github.com/users/Spadavecchia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Spadavecchia/subscriptions","organizations_url":"https://api.github.com/users/Spadavecchia/orgs","repos_url":"https://api.github.com/users/Spadavecchia/repos","events_url":"https://api.github.com/users/Spadavecchia/events{/privacy}","received_events_url":"https://api.github.com/users/Spadavecchia/received_events","type":"User","site_admin":false},"body":"There are weird unnecessary blank spaces `a  Custom` `name , markup`","created_at":"2018-09-05T01:43:37Z","updated_at":"2018-09-05T01:51:29Z","html_url":"https://github.com/Spadavecchia/liquid-elixir/pull/95#discussion_r215114859","pull_request_url":"https://api.github.com/repos/Spadavecchia/liquid-elixir/pulls/95","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/Spadavecchia/liquid-elixir/pulls/comments/215114859"},"html":{"href":"https://github.com/Spadavecchia/liquid-elixir/pull/95#discussion_r215114859"},"pull_request":{"href":"https://api.github.com/repos/Spadavecchia/liquid-elixir/pulls/95"}}},"pull_request":{"url":"https://api.github.com/repos/Spadavecchia/liquid-elixir/pulls/95","id":213040411,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzMDQwNDEx","html_url":"https://github.com/Spadavecchia/liquid-elixir/pull/95","diff_url":"https://github.com/Spadavecchia/liquid-elixir/pull/95.diff","patch_url":"https://github.com/Spadavecchia/liquid-elixir/pull/95.patch","issue_url":"https://api.github.com/repos/Spadavecchia/liquid-elixir/issues/95","number":95,"state":"open","locked":false,"title":"refact: PR requirements ","user":{"login":"samunefalara80","id":36305012,"node_id":"MDQ6VXNlcjM2MzA1MDEy","avatar_url":"https://avatars1.githubusercontent.com/u/36305012?v=4","gravatar_id":"","url":"https://api.github.com/users/samunefalara80","html_url":"https://github.com/samunefalara80","followers_url":"https://api.github.com/users/samunefalara80/followers","following_url":"https://api.github.com/users/samunefalara80/following{/other_user}","gists_url":"https://api.github.com/users/samunefalara80/gists{/gist_id}","starred_url":"https://api.github.com/users/samunefalara80/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samunefalara80/subscriptions","organizations_url":"https://api.github.com/users/samunefalara80/orgs","repos_url":"https://api.github.com/users/samunefalara80/repos","events_url":"https://api.github.com/users/samunefalara80/events{/privacy}","received_events_url":"https://api.github.com/users/samunefalara80/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-09-04T16:49:43Z","updated_at":"2018-09-05T01:51:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"57e435dff3b5f6ec2b1de77c0fd07c6d3626a0b5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Spadavecchia/liquid-elixir/pulls/95/commits","review_comments_url":"https://api.github.com/repos/Spadavecchia/liquid-elixir/pulls/95/comments","review_comment_url":"https://api.github.com/repos/Spadavecchia/liquid-elixir/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Spadavecchia/liquid-elixir/issues/95/comments","statuses_url":"https://api.github.com/repos/Spadavecchia/liquid-elixir/statuses/04d74490d64b8722ebb6ef2e2a03e6051230c0a9","head":{"label":"samunefalara80:feature/improved-parse","ref":"feature/improved-parse","sha":"04d74490d64b8722ebb6ef2e2a03e6051230c0a9","user":{"login":"samunefalara80","id":36305012,"node_id":"MDQ6VXNlcjM2MzA1MDEy","avatar_url":"https://avatars1.githubusercontent.com/u/36305012?v=4","gravatar_id":"","url":"https://api.github.com/users/samunefalara80","html_url":"https://github.com/samunefalara80","followers_url":"https://api.github.com/users/samunefalara80/followers","following_url":"https://api.github.com/users/samunefalara80/following{/other_user}","gists_url":"https://api.github.com/users/samunefalara80/gists{/gist_id}","starred_url":"https://api.github.com/users/samunefalara80/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samunefalara80/subscriptions","organizations_url":"https://api.github.com/users/samunefalara80/orgs","repos_url":"https://api.github.com/users/samunefalara80/repos","events_url":"https://api.github.com/users/samunefalara80/events{/privacy}","received_events_url":"https://api.github.com/users/samunefalara80/received_events","type":"User","site_admin":false},"repo":{"id":133400310,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM0MDAzMTA=","name":"liquid-elixir","full_name":"samunefalara80/liquid-elixir","owner":{"login":"samunefalara80","id":36305012,"node_id":"MDQ6VXNlcjM2MzA1MDEy","avatar_url":"https://avatars1.githubusercontent.com/u/36305012?v=4","gravatar_id":"","url":"https://api.github.com/users/samunefalara80","html_url":"https://github.com/samunefalara80","followers_url":"https://api.github.com/users/samunefalara80/followers","following_url":"https://api.github.com/users/samunefalara80/following{/other_user}","gists_url":"https://api.github.com/users/samunefalara80/gists{/gist_id}","starred_url":"https://api.github.com/users/samunefalara80/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samunefalara80/subscriptions","organizations_url":"https://api.github.com/users/samunefalara80/orgs","repos_url":"https://api.github.com/users/samunefalara80/repos","events_url":"https://api.github.com/users/samunefalara80/events{/privacy}","received_events_url":"https://api.github.com/users/samunefalara80/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/samunefalara80/liquid-elixir","description":"Logic-less templating engine in Elixir (patterned after Liquid)","fork":true,"url":"https://api.github.com/repos/samunefalara80/liquid-elixir","forks_url":"https://api.github.com/repos/samunefalara80/liquid-elixir/forks","keys_url":"https://api.github.com/repos/samunefalara80/liquid-elixir/keys{/key_id}","collaborators_url":"https://api.github.com/repos/samunefalara80/liquid-elixir/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/samunefalara80/liquid-elixir/teams","hooks_url":"https://api.github.com/repos/samunefalara80/liquid-elixir/hooks","issue_events_url":"https://api.github.com/repos/samunefalara80/liquid-elixir/issues/events{/number}","events_url":"https://api.github.com/repos/samunefalara80/liquid-elixir/events","assignees_url":"https://api.github.com/repos/samunefalara80/liquid-elixir/assignees{/user}","branches_url":"https://api.github.com/repos/samunefalara80/liquid-elixir/branches{/branch}","tags_url":"https://api.github.com/repos/samunefalara80/liquid-elixir/tags","blobs_url":"https://api.github.com/repos/samunefalara80/liquid-elixir/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/samunefalara80/liquid-elixir/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/samunefalara80/liquid-elixir/git/refs{/sha}","trees_url":"https://api.github.com/repos/samunefalara80/liquid-elixir/git/trees{/sha}","statuses_url":"https://api.github.com/repos/samunefalara80/liquid-elixir/statuses/{sha}","languages_url":"https://api.github.com/repos/samunefalara80/liquid-elixir/languages","stargazers_url":"https://api.github.com/repos/samunefalara80/liquid-elixir/stargazers","contributors_url":"https://api.github.com/repos/samunefalara80/liquid-elixir/contributors","subscribers_url":"https://api.github.com/repos/samunefalara80/liquid-elixir/subscribers","subscription_url":"https://api.github.com/repos/samunefalara80/liquid-elixir/subscription","commits_url":"https://api.github.com/repos/samunefalara80/liquid-elixir/commits{/sha}","git_commits_url":"https://api.github.com/repos/samunefalara80/liquid-elixir/git/commits{/sha}","comments_url":"https://api.github.com/repos/samunefalara80/liquid-elixir/comments{/number}","issue_comment_url":"https://api.github.com/repos/samunefalara80/liquid-elixir/issues/comments{/number}","contents_url":"https://api.github.com/repos/samunefalara80/liquid-elixir/contents/{+path}","compare_url":"https://api.github.com/repos/samunefalara80/liquid-elixir/compare/{base}...{head}","merges_url":"https://api.github.com/repos/samunefalara80/liquid-elixir/merges","archive_url":"https://api.github.com/repos/samunefalara80/liquid-elixir/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/samunefalara80/liquid-elixir/downloads","issues_url":"https://api.github.com/repos/samunefalara80/liquid-elixir/issues{/number}","pulls_url":"https://api.github.com/repos/samunefalara80/liquid-elixir/pulls{/number}","milestones_url":"https://api.github.com/repos/samunefalara80/liquid-elixir/milestones{/number}","notifications_url":"https://api.github.com/repos/samunefalara80/liquid-elixir/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/samunefalara80/liquid-elixir/labels{/name}","releases_url":"https://api.github.com/repos/samunefalara80/liquid-elixir/releases{/id}","deployments_url":"https://api.github.com/repos/samunefalara80/liquid-elixir/deployments","created_at":"2018-05-14T17:48:41Z","updated_at":"2018-05-14T17:48:43Z","pushed_at":"2018-09-04T16:46:11Z","git_url":"git://github.com/samunefalara80/liquid-elixir.git","ssh_url":"git@github.com:samunefalara80/liquid-elixir.git","clone_url":"https://github.com/samunefalara80/liquid-elixir.git","svn_url":"https://github.com/samunefalara80/liquid-elixir","homepage":null,"size":1794,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Spadavecchia:feature/improved-parsing","ref":"feature/improved-parsing","sha":"1ce43782465f025d7646bd1eabf05ca442e4441e","user":{"login":"Spadavecchia","id":1404185,"node_id":"MDQ6VXNlcjE0MDQxODU=","avatar_url":"https://avatars2.githubusercontent.com/u/1404185?v=4","gravatar_id":"","url":"https://api.github.com/users/Spadavecchia","html_url":"https://github.com/Spadavecchia","followers_url":"https://api.github.com/users/Spadavecchia/followers","following_url":"https://api.github.com/users/Spadavecchia/following{/other_user}","gists_url":"https://api.github.com/users/Spadavecchia/gists{/gist_id}","starred_url":"https://api.github.com/users/Spadavecchia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Spadavecchia/subscriptions","organizations_url":"https://api.github.com/users/Spadavecchia/orgs","repos_url":"https://api.github.com/users/Spadavecchia/repos","events_url":"https://api.github.com/users/Spadavecchia/events{/privacy}","received_events_url":"https://api.github.com/users/Spadavecchia/received_events","type":"User","site_admin":false},"repo":{"id":129757886,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk3NTc4ODY=","name":"liquid-elixir","full_name":"Spadavecchia/liquid-elixir","owner":{"login":"Spadavecchia","id":1404185,"node_id":"MDQ6VXNlcjE0MDQxODU=","avatar_url":"https://avatars2.githubusercontent.com/u/1404185?v=4","gravatar_id":"","url":"https://api.github.com/users/Spadavecchia","html_url":"https://github.com/Spadavecchia","followers_url":"https://api.github.com/users/Spadavecchia/followers","following_url":"https://api.github.com/users/Spadavecchia/following{/other_user}","gists_url":"https://api.github.com/users/Spadavecchia/gists{/gist_id}","starred_url":"https://api.github.com/users/Spadavecchia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Spadavecchia/subscriptions","organizations_url":"https://api.github.com/users/Spadavecchia/orgs","repos_url":"https://api.github.com/users/Spadavecchia/repos","events_url":"https://api.github.com/users/Spadavecchia/events{/privacy}","received_events_url":"https://api.github.com/users/Spadavecchia/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Spadavecchia/liquid-elixir","description":"Logic-less templating engine in Elixir (patterned after Liquid)","fork":true,"url":"https://api.github.com/repos/Spadavecchia/liquid-elixir","forks_url":"https://api.github.com/repos/Spadavecchia/liquid-elixir/forks","keys_url":"https://api.github.com/repos/Spadavecchia/liquid-elixir/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Spadavecchia/liquid-elixir/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Spadavecchia/liquid-elixir/teams","hooks_url":"https://api.github.com/repos/Spadavecchia/liquid-elixir/hooks","issue_events_url":"https://api.github.com/repos/Spadavecchia/liquid-elixir/issues/events{/number}","events_url":"https://api.github.com/repos/Spadavecchia/liquid-elixir/events","assignees_url":"https://api.github.com/repos/Spadavecchia/liquid-elixir/assignees{/user}","branches_url":"https://api.github.com/repos/Spadavecchia/liquid-elixir/branches{/branch}","tags_url":"https://api.github.com/repos/Spadavecchia/liquid-elixir/tags","blobs_url":"https://api.github.com/repos/Spadavecchia/liquid-elixir/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Spadavecchia/liquid-elixir/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Spadavecchia/liquid-elixir/git/refs{/sha}","trees_url":"https://api.github.com/repos/Spadavecchia/liquid-elixir/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Spadavecchia/liquid-elixir/statuses/{sha}","languages_url":"https://api.github.com/repos/Spadavecchia/liquid-elixir/languages","stargazers_url":"https://api.github.com/repos/Spadavecchia/liquid-elixir/stargazers","contributors_url":"https://api.github.com/repos/Spadavecchia/liquid-elixir/contributors","subscribers_url":"https://api.github.com/repos/Spadavecchia/liquid-elixir/subscribers","subscription_url":"https://api.github.com/repos/Spadavecchia/liquid-elixir/subscription","commits_url":"https://api.github.com/repos/Spadavecchia/liquid-elixir/commits{/sha}","git_commits_url":"https://api.github.com/repos/Spadavecchia/liquid-elixir/git/commits{/sha}","comments_url":"https://api.github.com/repos/Spadavecchia/liquid-elixir/comments{/number}","issue_comment_url":"https://api.github.com/repos/Spadavecchia/liquid-elixir/issues/comments{/number}","contents_url":"https://api.github.com/repos/Spadavecchia/liquid-elixir/contents/{+path}","compare_url":"https://api.github.com/repos/Spadavecchia/liquid-elixir/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Spadavecchia/liquid-elixir/merges","archive_url":"https://api.github.com/repos/Spadavecchia/liquid-elixir/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Spadavecchia/liquid-elixir/downloads","issues_url":"https://api.github.com/repos/Spadavecchia/liquid-elixir/issues{/number}","pulls_url":"https://api.github.com/repos/Spadavecchia/liquid-elixir/pulls{/number}","milestones_url":"https://api.github.com/repos/Spadavecchia/liquid-elixir/milestones{/number}","notifications_url":"https://api.github.com/repos/Spadavecchia/liquid-elixir/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Spadavecchia/liquid-elixir/labels{/name}","releases_url":"https://api.github.com/repos/Spadavecchia/liquid-elixir/releases{/id}","deployments_url":"https://api.github.com/repos/Spadavecchia/liquid-elixir/deployments","created_at":"2018-04-16T14:39:03Z","updated_at":"2018-04-16T14:39:05Z","pushed_at":"2018-09-04T16:54:10Z","git_url":"git://github.com/Spadavecchia/liquid-elixir.git","ssh_url":"git@github.com:Spadavecchia/liquid-elixir.git","clone_url":"https://github.com/Spadavecchia/liquid-elixir.git","svn_url":"https://github.com/Spadavecchia/liquid-elixir","homepage":null,"size":1774,"stargazers_count":0,"watchers_count":0,"language":"Elixir","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":2,"open_issues":5,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Spadavecchia/liquid-elixir/pulls/95"},"html":{"href":"https://github.com/Spadavecchia/liquid-elixir/pull/95"},"issue":{"href":"https://api.github.com/repos/Spadavecchia/liquid-elixir/issues/95"},"comments":{"href":"https://api.github.com/repos/Spadavecchia/liquid-elixir/issues/95/comments"},"review_comments":{"href":"https://api.github.com/repos/Spadavecchia/liquid-elixir/pulls/95/comments"},"review_comment":{"href":"https://api.github.com/repos/Spadavecchia/liquid-elixir/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Spadavecchia/liquid-elixir/pulls/95/commits"},"statuses":{"href":"https://api.github.com/repos/Spadavecchia/liquid-elixir/statuses/04d74490d64b8722ebb6ef2e2a03e6051230c0a9"}},"author_association":"NONE"}}
{"actor":{"display_login":"Spadavecchia"}}