{"action":"created","issue":{"url":"https://api.github.com/repos/Bill-Gray/lunar/issues/2","repository_url":"https://api.github.com/repos/Bill-Gray/lunar","labels_url":"https://api.github.com/repos/Bill-Gray/lunar/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/Bill-Gray/lunar/issues/2/comments","events_url":"https://api.github.com/repos/Bill-Gray/lunar/issues/2/events","html_url":"https://github.com/Bill-Gray/lunar/issues/2","id":349470345,"node_id":"MDU6SXNzdWUzNDk0NzAzNDU=","number":2,"title":"Building problem.","user":{"login":"Anandir","id":9789409,"node_id":"MDQ6VXNlcjk3ODk0MDk=","avatar_url":"https://avatars2.githubusercontent.com/u/9789409?v=4","gravatar_id":"","url":"https://api.github.com/users/Anandir","html_url":"https://github.com/Anandir","followers_url":"https://api.github.com/users/Anandir/followers","following_url":"https://api.github.com/users/Anandir/following{/other_user}","gists_url":"https://api.github.com/users/Anandir/gists{/gist_id}","starred_url":"https://api.github.com/users/Anandir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Anandir/subscriptions","organizations_url":"https://api.github.com/users/Anandir/orgs","repos_url":"https://api.github.com/users/Anandir/repos","events_url":"https://api.github.com/users/Anandir/events{/privacy}","received_events_url":"https://api.github.com/users/Anandir/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-08-10T10:54:37Z","updated_at":"2018-08-12T00:09:06Z","closed_at":null,"author_association":"NONE","body":"Hi :-)!\r\nI'm trying to build the library on a Windows 10 machine with Visual Studio 2017 Build Tools and I've this error:\r\n\r\n```\r\nC:\\Users\\me\\Projects\\Find_Orb_Build\\lunar>nmake -f lunar.mak BITS_32=Y DLL=Y\r\n\r\nMicrosoft (R) Program Maintenance Utility Version 14.14.26433.0\r\nCopyright (C) Microsoft Corporation.  All rights reserved.\r\n\r\n        cl -c -nologo -W3 -Ox -MT -D_CRT_SECURE_NO_WARNINGS -EHsc -LD -DNDEBUG astcheck.cpp\r\nastcheck.cpp\r\nastcheck.cpp(134): warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data\r\nastcheck.cpp(448): error C2084: function 'int snprintf(char *const ,const size_t,const char *const ,...)' already has a body\r\nC:\\Program Files (x86)\\Windows Kits\\10\\include\\10.0.17134.0\\ucrt\\stdio.h(1940): note: see previous definition of 'snprintf'\r\nNMAKE : fatal error U1077: '\"C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\BuildTools\\VC\\Tools\\MSVC\\14.14.26428\\bin\\HostX86\\x64\\cl.EXE\"' : return code '0x2'\r\nStop.\r\n\r\nC:\\Users\\me\\Projects\\Find_Orb_Build\\lunar>\r\n```\r\n\r\nThe only solution I've found is to comment out your snprintf reimplementation, but it's not a smart move and I would like to keep the code.\r\nDo you know if there are walkaroud/fixes over this?\r\nThanks a lot in advance and thanks a lot for your outstanding work!"},"comment":{"url":"https://api.github.com/repos/Bill-Gray/lunar/issues/comments/412309545","html_url":"https://github.com/Bill-Gray/lunar/issues/2#issuecomment-412309545","issue_url":"https://api.github.com/repos/Bill-Gray/lunar/issues/2","id":412309545,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjMwOTU0NQ==","user":{"login":"Anandir","id":9789409,"node_id":"MDQ6VXNlcjk3ODk0MDk=","avatar_url":"https://avatars2.githubusercontent.com/u/9789409?v=4","gravatar_id":"","url":"https://api.github.com/users/Anandir","html_url":"https://github.com/Anandir","followers_url":"https://api.github.com/users/Anandir/followers","following_url":"https://api.github.com/users/Anandir/following{/other_user}","gists_url":"https://api.github.com/users/Anandir/gists{/gist_id}","starred_url":"https://api.github.com/users/Anandir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Anandir/subscriptions","organizations_url":"https://api.github.com/users/Anandir/orgs","repos_url":"https://api.github.com/users/Anandir/repos","events_url":"https://api.github.com/users/Anandir/events{/privacy}","received_events_url":"https://api.github.com/users/Anandir/received_events","type":"User","site_admin":false},"created_at":"2018-08-12T00:09:06Z","updated_at":"2018-08-12T00:09:06Z","author_association":"NONE","body":"Thanks @Bill-Gray for you reply!\r\nRegarding the conversion warning (`astcheck.cpp(134): warning C4267: '=': conversion from 'size_t' to 'int', possible loss of data`) I will ignore it basically.\r\nThanks a lot for the fix.\r\nAfter the fix I've got this error:\r\n\r\n```\r\nC:\\Users\\me\\Projects\\Find_Orb_Build\\lunar>nmake -f lunar.mak BITS_32=Y\r\n\r\nMicrosoft (R) Program Maintenance Utility Version 14.14.26433.0\r\nCopyright (C) Microsoft Corporation.  All rights reserved.\r\n\r\n        link /nologo    astcheck.obj eart2000.obj mpcorb.obj lunar.lib\r\nastcheck.obj : error LNK2019: unresolved external symbol extract_date_from_mpc_report referenced in function \"int __cdecl get_mpc_data(char const *,double *,double *,double *)\" (?get_mpc_data@@YAHPEBDPEAN11@Z)\r\nastcheck.obj : error LNK2019: unresolved external symbol get_ra_dec_from_mpc_report referenced in function \"int __cdecl get_mpc_data(char const *,double *,double *,double *)\" (?get_mpc_data@@YAHPEBDPEAN11@Z)\r\nastcheck.obj : error LNK2019: unresolved external symbol \"int __cdecl extract_sof_data(struct elements *,char const *,char const *)\" (?extract_sof_data@@YAHPEAUelements@@PEBD1@Z) referenced in function \"struct AST_DATA * __cdecl compute_day_data(long)\" (?compute_day_data@@YAPEAUAST_DATA@@J@Z)\r\nastcheck.exe : fatal error LNK1120: 3 unresolved externals\r\nNMAKE : fatal error U1077: '\"C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\BuildTools\\VC\\Tools\\MSVC\\14.14.26428\\bin\\HostX86\\x64\\link.EXE\"' : return code '0x460'\r\nStop.\r\n\r\nC:\\Users\\me\\Projects\\Find_Orb_Build\\lunar>\r\n```\r\n\r\nBut I've fixed it adding those lines to the lunar.def file:\r\n\r\n```\r\n   extract_date_from_mpc_report           @91\r\n   get_ra_dec_from_mpc_report             @92\r\n   extract_sof_data                       @93\r\n   lat_alt_to_parallax                    @94\r\n```\r\n\r\nI hope that this can help!"}}
{"actor":{"display_login":"Anandir"}}