{"action":"created","comment":{"url":"https://api.github.com/repos/ArkEcosystem/core/pulls/comments/237810656","pull_request_review_id":180200617,"id":237810656,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzgxMDY1Ng==","diff_hunk":"@@ -209,34 +219,51 @@ module.exports = class TransactionPoolInterface {\n         ? this.walletManager.findByAddress(transaction.recipientId)\n         : false\n \n-      // If sender or recipient wallet in pool we try to apply transaction\n-      const exists = this.transactionExists(transaction.id)\n-      if (!exists && (senderWallet || recipientWallet)) {\n-        try {\n-          this.walletManager.applyPoolTransaction(transaction)\n-        } catch (error) {\n-          logger.error(`AcceptChainedBlock in pool: ${error}`)\n-          // Purge sender\n-          this.purgeByPublicKey(senderPublicKey)\n-        }\n-      } else {\n-        this.removeTransaction(transaction)\n+      if (recipientWallet) {\n+        recipientWallet.applyTransactionToRecipient(transaction)\n       }\n \n-      if (\n-        senderWallet &&\n-        senderWallet.balance === 0 &&\n-        this.getSenderSize(senderPublicKey) === 0\n-      ) {\n-        this.walletManager.deleteWallet(senderPublicKey)\n+      if (exists) {\n+        this.removeTransaction(transaction)\n+      } else if (senderWallet) {\n+        const errors = []\n+        if (senderWallet.canApply(transaction, errors)) {","path":"packages/core-transaction-pool/lib/interface.js","position":63,"original_position":54,"commit_id":"f465ea895e9c35b4cddde313e6e7890761194b7a","original_commit_id":"3911ccea8121790f7bb4c74b33fe5bc65f1d53b6","user":{"login":"kristjank","id":414412,"node_id":"MDQ6VXNlcjQxNDQxMg==","avatar_url":"https://avatars2.githubusercontent.com/u/414412?v=4","gravatar_id":"","url":"https://api.github.com/users/kristjank","html_url":"https://github.com/kristjank","followers_url":"https://api.github.com/users/kristjank/followers","following_url":"https://api.github.com/users/kristjank/following{/other_user}","gists_url":"https://api.github.com/users/kristjank/gists{/gist_id}","starred_url":"https://api.github.com/users/kristjank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kristjank/subscriptions","organizations_url":"https://api.github.com/users/kristjank/orgs","repos_url":"https://api.github.com/users/kristjank/repos","events_url":"https://api.github.com/users/kristjank/events{/privacy}","received_events_url":"https://api.github.com/users/kristjank/received_events","type":"User","site_admin":false},"body":"Not true. Block is already applied and forged before we enter this function and the definitive and true state of the chain. Here we apply that state if needed, and if not successful the senders must go out of pool.\r\n\r\nOrder is important for other things, vote/unvote etc, but not related to this.","created_at":"2018-11-30T10:19:01Z","updated_at":"2018-11-30T10:19:01Z","html_url":"https://github.com/ArkEcosystem/core/pull/1547#discussion_r237810656","pull_request_url":"https://api.github.com/repos/ArkEcosystem/core/pulls/1547","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ArkEcosystem/core/pulls/comments/237810656"},"html":{"href":"https://github.com/ArkEcosystem/core/pull/1547#discussion_r237810656"},"pull_request":{"href":"https://api.github.com/repos/ArkEcosystem/core/pulls/1547"}},"in_reply_to_id":237802149},"pull_request":{"url":"https://api.github.com/repos/ArkEcosystem/core/pulls/1547","id":234834861,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0ODM0ODYx","html_url":"https://github.com/ArkEcosystem/core/pull/1547","diff_url":"https://github.com/ArkEcosystem/core/pull/1547.diff","patch_url":"https://github.com/ArkEcosystem/core/pull/1547.patch","issue_url":"https://api.github.com/repos/ArkEcosystem/core/issues/1547","number":1547,"state":"open","locked":false,"title":"[WIP] fix: Transaction pool wallet manager apply logic change","user":{"login":"supaiku0","id":1311798,"node_id":"MDQ6VXNlcjEzMTE3OTg=","avatar_url":"https://avatars2.githubusercontent.com/u/1311798?v=4","gravatar_id":"","url":"https://api.github.com/users/supaiku0","html_url":"https://github.com/supaiku0","followers_url":"https://api.github.com/users/supaiku0/followers","following_url":"https://api.github.com/users/supaiku0/following{/other_user}","gists_url":"https://api.github.com/users/supaiku0/gists{/gist_id}","starred_url":"https://api.github.com/users/supaiku0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/supaiku0/subscriptions","organizations_url":"https://api.github.com/users/supaiku0/orgs","repos_url":"https://api.github.com/users/supaiku0/repos","events_url":"https://api.github.com/users/supaiku0/events{/privacy}","received_events_url":"https://api.github.com/users/supaiku0/received_events","type":"User","site_admin":false},"body":"## Proposed changes\r\n<!--\r\nDescribe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.\r\n-->\r\nThe issue in the pool-wallet-manager was related to the pool balance apply logic. Since we were tracking the balance spent, and the balance to be spent, we also applied not yet forged funds to the recipient(in pool only), allowing users to send \"future\" spend transactions to the pool and thus allowing chaining of transfers tx1:A->B, tx2:B->C to the pool, meaning even if tx1 was not forged, we allowed tx2 to enter the pool. This caused a ripple effect when network was spamming since the state begins to differ and forger could produce invalid blocks.\r\n\r\nDue to this we changed some of the logic and rules of AIP17, where we now only apply transaction to the sender - when entering pool, and to recipient when block is forged (if present in pool, and transaction not in pool).\r\n\r\nThis should also close edge cases on possible spamming of network with address tumbling or just cold wallet spending in general.\r\n\r\n## Types of changes\r\n<!--\r\nWhat types of changes does your code introduce?\r\n_Put an `x` in the boxes that apply and remove the rest of them: keep this PR as concise, but descriptive, as possible.._\r\n-->\r\n\r\n- [X] Bugfix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [X] Refactoring (improve a current implementation without adding a new feature or fixing a bug)\r\n- [X] Breaking change (fix or feature that would cause existing functionality to not work as expected)\r\n- [ ] Build (changes that affect the build system)\r\n- [ ] Docs (documentation only changes)\r\n- [X] Test (adding missing tests or fixing existing tests)\r\n- [ ] Other... Please describe:\r\n\r\n## Checklist\r\n<!--\r\n_Put an `x` in the boxes that apply and remove this text and the rest of them. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._\r\n-->\r\n\r\n- [X] I have read the [CONTRIBUTING](https://docs.ark.io/developers/guidelines/contributing.html) documentation\r\n- [X] Lint and unit tests pass locally with my changes\r\n- [X] I have added tests that prove my fix is effective or that my feature works\r\n- [X] I have added necessary documentation (if appropriate)\r\n<!--\r\n\r\n## Further comments\r\n\r\nIf this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...\r\n-->","created_at":"2018-11-30T00:38:43Z","updated_at":"2018-11-30T10:19:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3dd26bd1582ecbc92219987057cfc2b3645cd8c3","assignee":{"login":"supaiku0","id":1311798,"node_id":"MDQ6VXNlcjEzMTE3OTg=","avatar_url":"https://avatars2.githubusercontent.com/u/1311798?v=4","gravatar_id":"","url":"https://api.github.com/users/supaiku0","html_url":"https://github.com/supaiku0","followers_url":"https://api.github.com/users/supaiku0/followers","following_url":"https://api.github.com/users/supaiku0/following{/other_user}","gists_url":"https://api.github.com/users/supaiku0/gists{/gist_id}","starred_url":"https://api.github.com/users/supaiku0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/supaiku0/subscriptions","organizations_url":"https://api.github.com/users/supaiku0/orgs","repos_url":"https://api.github.com/users/supaiku0/repos","events_url":"https://api.github.com/users/supaiku0/events{/privacy}","received_events_url":"https://api.github.com/users/supaiku0/received_events","type":"User","site_admin":false},"assignees":[{"login":"kristjank","id":414412,"node_id":"MDQ6VXNlcjQxNDQxMg==","avatar_url":"https://avatars2.githubusercontent.com/u/414412?v=4","gravatar_id":"","url":"https://api.github.com/users/kristjank","html_url":"https://github.com/kristjank","followers_url":"https://api.github.com/users/kristjank/followers","following_url":"https://api.github.com/users/kristjank/following{/other_user}","gists_url":"https://api.github.com/users/kristjank/gists{/gist_id}","starred_url":"https://api.github.com/users/kristjank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kristjank/subscriptions","organizations_url":"https://api.github.com/users/kristjank/orgs","repos_url":"https://api.github.com/users/kristjank/repos","events_url":"https://api.github.com/users/kristjank/events{/privacy}","received_events_url":"https://api.github.com/users/kristjank/received_events","type":"User","site_admin":false},{"login":"supaiku0","id":1311798,"node_id":"MDQ6VXNlcjEzMTE3OTg=","avatar_url":"https://avatars2.githubusercontent.com/u/1311798?v=4","gravatar_id":"","url":"https://api.github.com/users/supaiku0","html_url":"https://github.com/supaiku0","followers_url":"https://api.github.com/users/supaiku0/followers","following_url":"https://api.github.com/users/supaiku0/following{/other_user}","gists_url":"https://api.github.com/users/supaiku0/gists{/gist_id}","starred_url":"https://api.github.com/users/supaiku0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/supaiku0/subscriptions","organizations_url":"https://api.github.com/users/supaiku0/orgs","repos_url":"https://api.github.com/users/supaiku0/repos","events_url":"https://api.github.com/users/supaiku0/events{/privacy}","received_events_url":"https://api.github.com/users/supaiku0/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"kristjank","id":414412,"node_id":"MDQ6VXNlcjQxNDQxMg==","avatar_url":"https://avatars2.githubusercontent.com/u/414412?v=4","gravatar_id":"","url":"https://api.github.com/users/kristjank","html_url":"https://github.com/kristjank","followers_url":"https://api.github.com/users/kristjank/followers","following_url":"https://api.github.com/users/kristjank/following{/other_user}","gists_url":"https://api.github.com/users/kristjank/gists{/gist_id}","starred_url":"https://api.github.com/users/kristjank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kristjank/subscriptions","organizations_url":"https://api.github.com/users/kristjank/orgs","repos_url":"https://api.github.com/users/kristjank/repos","events_url":"https://api.github.com/users/kristjank/events{/privacy}","received_events_url":"https://api.github.com/users/kristjank/received_events","type":"User","site_admin":false},{"login":"faustbrian","id":22145591,"node_id":"MDQ6VXNlcjIyMTQ1NTkx","avatar_url":"https://avatars3.githubusercontent.com/u/22145591?v=4","gravatar_id":"","url":"https://api.github.com/users/faustbrian","html_url":"https://github.com/faustbrian","followers_url":"https://api.github.com/users/faustbrian/followers","following_url":"https://api.github.com/users/faustbrian/following{/other_user}","gists_url":"https://api.github.com/users/faustbrian/gists{/gist_id}","starred_url":"https://api.github.com/users/faustbrian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faustbrian/subscriptions","organizations_url":"https://api.github.com/users/faustbrian/orgs","repos_url":"https://api.github.com/users/faustbrian/repos","events_url":"https://api.github.com/users/faustbrian/events{/privacy}","received_events_url":"https://api.github.com/users/faustbrian/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1101101126,"node_id":"MDU6TGFiZWwxMTAxMTAxMTI2","url":"https://api.github.com/repos/ArkEcosystem/core/labels/review","name":"review","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ArkEcosystem/core/pulls/1547/commits","review_comments_url":"https://api.github.com/repos/ArkEcosystem/core/pulls/1547/comments","review_comment_url":"https://api.github.com/repos/ArkEcosystem/core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ArkEcosystem/core/issues/1547/comments","statuses_url":"https://api.github.com/repos/ArkEcosystem/core/statuses/f465ea895e9c35b4cddde313e6e7890761194b7a","head":{"label":"ArkEcosystem:fix/pool-wallet-apply-logic","ref":"fix/pool-wallet-apply-logic","sha":"f465ea895e9c35b4cddde313e6e7890761194b7a","user":{"login":"ArkEcosystem","id":22457396,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNDU3Mzk2","avatar_url":"https://avatars3.githubusercontent.com/u/22457396?v=4","gravatar_id":"","url":"https://api.github.com/users/ArkEcosystem","html_url":"https://github.com/ArkEcosystem","followers_url":"https://api.github.com/users/ArkEcosystem/followers","following_url":"https://api.github.com/users/ArkEcosystem/following{/other_user}","gists_url":"https://api.github.com/users/ArkEcosystem/gists{/gist_id}","starred_url":"https://api.github.com/users/ArkEcosystem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArkEcosystem/subscriptions","organizations_url":"https://api.github.com/users/ArkEcosystem/orgs","repos_url":"https://api.github.com/users/ArkEcosystem/repos","events_url":"https://api.github.com/users/ArkEcosystem/events{/privacy}","received_events_url":"https://api.github.com/users/ArkEcosystem/received_events","type":"Organization","site_admin":false},"repo":{"id":111684364,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE2ODQzNjQ=","name":"core","full_name":"ArkEcosystem/core","private":false,"owner":{"login":"ArkEcosystem","id":22457396,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNDU3Mzk2","avatar_url":"https://avatars3.githubusercontent.com/u/22457396?v=4","gravatar_id":"","url":"https://api.github.com/users/ArkEcosystem","html_url":"https://github.com/ArkEcosystem","followers_url":"https://api.github.com/users/ArkEcosystem/followers","following_url":"https://api.github.com/users/ArkEcosystem/following{/other_user}","gists_url":"https://api.github.com/users/ArkEcosystem/gists{/gist_id}","starred_url":"https://api.github.com/users/ArkEcosystem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArkEcosystem/subscriptions","organizations_url":"https://api.github.com/users/ArkEcosystem/orgs","repos_url":"https://api.github.com/users/ArkEcosystem/repos","events_url":"https://api.github.com/users/ArkEcosystem/events{/privacy}","received_events_url":"https://api.github.com/users/ArkEcosystem/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ArkEcosystem/core","description":"The Ark Blockchain :fireworks:. Check https://docs.ark.io/guidebook/ for more information.","fork":false,"url":"https://api.github.com/repos/ArkEcosystem/core","forks_url":"https://api.github.com/repos/ArkEcosystem/core/forks","keys_url":"https://api.github.com/repos/ArkEcosystem/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ArkEcosystem/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ArkEcosystem/core/teams","hooks_url":"https://api.github.com/repos/ArkEcosystem/core/hooks","issue_events_url":"https://api.github.com/repos/ArkEcosystem/core/issues/events{/number}","events_url":"https://api.github.com/repos/ArkEcosystem/core/events","assignees_url":"https://api.github.com/repos/ArkEcosystem/core/assignees{/user}","branches_url":"https://api.github.com/repos/ArkEcosystem/core/branches{/branch}","tags_url":"https://api.github.com/repos/ArkEcosystem/core/tags","blobs_url":"https://api.github.com/repos/ArkEcosystem/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ArkEcosystem/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ArkEcosystem/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/ArkEcosystem/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ArkEcosystem/core/statuses/{sha}","languages_url":"https://api.github.com/repos/ArkEcosystem/core/languages","stargazers_url":"https://api.github.com/repos/ArkEcosystem/core/stargazers","contributors_url":"https://api.github.com/repos/ArkEcosystem/core/contributors","subscribers_url":"https://api.github.com/repos/ArkEcosystem/core/subscribers","subscription_url":"https://api.github.com/repos/ArkEcosystem/core/subscription","commits_url":"https://api.github.com/repos/ArkEcosystem/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/ArkEcosystem/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/ArkEcosystem/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/ArkEcosystem/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/ArkEcosystem/core/contents/{+path}","compare_url":"https://api.github.com/repos/ArkEcosystem/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ArkEcosystem/core/merges","archive_url":"https://api.github.com/repos/ArkEcosystem/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ArkEcosystem/core/downloads","issues_url":"https://api.github.com/repos/ArkEcosystem/core/issues{/number}","pulls_url":"https://api.github.com/repos/ArkEcosystem/core/pulls{/number}","milestones_url":"https://api.github.com/repos/ArkEcosystem/core/milestones{/number}","notifications_url":"https://api.github.com/repos/ArkEcosystem/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ArkEcosystem/core/labels{/name}","releases_url":"https://api.github.com/repos/ArkEcosystem/core/releases{/id}","deployments_url":"https://api.github.com/repos/ArkEcosystem/core/deployments","created_at":"2017-11-22T12:57:35Z","updated_at":"2018-11-30T05:40:12Z","pushed_at":"2018-11-30T09:49:51Z","git_url":"git://github.com/ArkEcosystem/core.git","ssh_url":"git@github.com:ArkEcosystem/core.git","clone_url":"https://github.com/ArkEcosystem/core.git","svn_url":"https://github.com/ArkEcosystem/core","homepage":"https://ark.io","size":11057,"stargazers_count":97,"watchers_count":97,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":64,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":64,"open_issues":7,"watchers":97,"default_branch":"develop"}},"base":{"label":"ArkEcosystem:develop","ref":"develop","sha":"0ae1aef265c4e88dad1d942f46c220a96a6fa50a","user":{"login":"ArkEcosystem","id":22457396,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNDU3Mzk2","avatar_url":"https://avatars3.githubusercontent.com/u/22457396?v=4","gravatar_id":"","url":"https://api.github.com/users/ArkEcosystem","html_url":"https://github.com/ArkEcosystem","followers_url":"https://api.github.com/users/ArkEcosystem/followers","following_url":"https://api.github.com/users/ArkEcosystem/following{/other_user}","gists_url":"https://api.github.com/users/ArkEcosystem/gists{/gist_id}","starred_url":"https://api.github.com/users/ArkEcosystem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArkEcosystem/subscriptions","organizations_url":"https://api.github.com/users/ArkEcosystem/orgs","repos_url":"https://api.github.com/users/ArkEcosystem/repos","events_url":"https://api.github.com/users/ArkEcosystem/events{/privacy}","received_events_url":"https://api.github.com/users/ArkEcosystem/received_events","type":"Organization","site_admin":false},"repo":{"id":111684364,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE2ODQzNjQ=","name":"core","full_name":"ArkEcosystem/core","private":false,"owner":{"login":"ArkEcosystem","id":22457396,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNDU3Mzk2","avatar_url":"https://avatars3.githubusercontent.com/u/22457396?v=4","gravatar_id":"","url":"https://api.github.com/users/ArkEcosystem","html_url":"https://github.com/ArkEcosystem","followers_url":"https://api.github.com/users/ArkEcosystem/followers","following_url":"https://api.github.com/users/ArkEcosystem/following{/other_user}","gists_url":"https://api.github.com/users/ArkEcosystem/gists{/gist_id}","starred_url":"https://api.github.com/users/ArkEcosystem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArkEcosystem/subscriptions","organizations_url":"https://api.github.com/users/ArkEcosystem/orgs","repos_url":"https://api.github.com/users/ArkEcosystem/repos","events_url":"https://api.github.com/users/ArkEcosystem/events{/privacy}","received_events_url":"https://api.github.com/users/ArkEcosystem/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ArkEcosystem/core","description":"The Ark Blockchain :fireworks:. Check https://docs.ark.io/guidebook/ for more information.","fork":false,"url":"https://api.github.com/repos/ArkEcosystem/core","forks_url":"https://api.github.com/repos/ArkEcosystem/core/forks","keys_url":"https://api.github.com/repos/ArkEcosystem/core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ArkEcosystem/core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ArkEcosystem/core/teams","hooks_url":"https://api.github.com/repos/ArkEcosystem/core/hooks","issue_events_url":"https://api.github.com/repos/ArkEcosystem/core/issues/events{/number}","events_url":"https://api.github.com/repos/ArkEcosystem/core/events","assignees_url":"https://api.github.com/repos/ArkEcosystem/core/assignees{/user}","branches_url":"https://api.github.com/repos/ArkEcosystem/core/branches{/branch}","tags_url":"https://api.github.com/repos/ArkEcosystem/core/tags","blobs_url":"https://api.github.com/repos/ArkEcosystem/core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ArkEcosystem/core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ArkEcosystem/core/git/refs{/sha}","trees_url":"https://api.github.com/repos/ArkEcosystem/core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ArkEcosystem/core/statuses/{sha}","languages_url":"https://api.github.com/repos/ArkEcosystem/core/languages","stargazers_url":"https://api.github.com/repos/ArkEcosystem/core/stargazers","contributors_url":"https://api.github.com/repos/ArkEcosystem/core/contributors","subscribers_url":"https://api.github.com/repos/ArkEcosystem/core/subscribers","subscription_url":"https://api.github.com/repos/ArkEcosystem/core/subscription","commits_url":"https://api.github.com/repos/ArkEcosystem/core/commits{/sha}","git_commits_url":"https://api.github.com/repos/ArkEcosystem/core/git/commits{/sha}","comments_url":"https://api.github.com/repos/ArkEcosystem/core/comments{/number}","issue_comment_url":"https://api.github.com/repos/ArkEcosystem/core/issues/comments{/number}","contents_url":"https://api.github.com/repos/ArkEcosystem/core/contents/{+path}","compare_url":"https://api.github.com/repos/ArkEcosystem/core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ArkEcosystem/core/merges","archive_url":"https://api.github.com/repos/ArkEcosystem/core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ArkEcosystem/core/downloads","issues_url":"https://api.github.com/repos/ArkEcosystem/core/issues{/number}","pulls_url":"https://api.github.com/repos/ArkEcosystem/core/pulls{/number}","milestones_url":"https://api.github.com/repos/ArkEcosystem/core/milestones{/number}","notifications_url":"https://api.github.com/repos/ArkEcosystem/core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ArkEcosystem/core/labels{/name}","releases_url":"https://api.github.com/repos/ArkEcosystem/core/releases{/id}","deployments_url":"https://api.github.com/repos/ArkEcosystem/core/deployments","created_at":"2017-11-22T12:57:35Z","updated_at":"2018-11-30T05:40:12Z","pushed_at":"2018-11-30T09:49:51Z","git_url":"git://github.com/ArkEcosystem/core.git","ssh_url":"git@github.com:ArkEcosystem/core.git","clone_url":"https://github.com/ArkEcosystem/core.git","svn_url":"https://github.com/ArkEcosystem/core","homepage":"https://ark.io","size":11057,"stargazers_count":97,"watchers_count":97,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":64,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":64,"open_issues":7,"watchers":97,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ArkEcosystem/core/pulls/1547"},"html":{"href":"https://github.com/ArkEcosystem/core/pull/1547"},"issue":{"href":"https://api.github.com/repos/ArkEcosystem/core/issues/1547"},"comments":{"href":"https://api.github.com/repos/ArkEcosystem/core/issues/1547/comments"},"review_comments":{"href":"https://api.github.com/repos/ArkEcosystem/core/pulls/1547/comments"},"review_comment":{"href":"https://api.github.com/repos/ArkEcosystem/core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ArkEcosystem/core/pulls/1547/commits"},"statuses":{"href":"https://api.github.com/repos/ArkEcosystem/core/statuses/f465ea895e9c35b4cddde313e6e7890761194b7a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"kristjank"}}