{"action":"created","issue":{"url":"https://api.github.com/repos/RadeonOpenCompute/ROCT-Thunk-Interface/issues/25","repository_url":"https://api.github.com/repos/RadeonOpenCompute/ROCT-Thunk-Interface","labels_url":"https://api.github.com/repos/RadeonOpenCompute/ROCT-Thunk-Interface/issues/25/labels{/name}","comments_url":"https://api.github.com/repos/RadeonOpenCompute/ROCT-Thunk-Interface/issues/25/comments","events_url":"https://api.github.com/repos/RadeonOpenCompute/ROCT-Thunk-Interface/issues/25/events","html_url":"https://github.com/RadeonOpenCompute/ROCT-Thunk-Interface/pull/25","id":357991939,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzODY5OTk1","number":25,"title":"[cmake] Correctly install the library into the system","user":{"login":"cryptomilk","id":545480,"node_id":"MDQ6VXNlcjU0NTQ4MA==","avatar_url":"https://avatars1.githubusercontent.com/u/545480?v=4","gravatar_id":"","url":"https://api.github.com/users/cryptomilk","html_url":"https://github.com/cryptomilk","followers_url":"https://api.github.com/users/cryptomilk/followers","following_url":"https://api.github.com/users/cryptomilk/following{/other_user}","gists_url":"https://api.github.com/users/cryptomilk/gists{/gist_id}","starred_url":"https://api.github.com/users/cryptomilk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cryptomilk/subscriptions","organizations_url":"https://api.github.com/users/cryptomilk/orgs","repos_url":"https://api.github.com/users/cryptomilk/repos","events_url":"https://api.github.com/users/cryptomilk/events{/privacy}","received_events_url":"https://api.github.com/users/cryptomilk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-07T09:33:03Z","updated_at":"2018-09-07T23:46:12Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/RadeonOpenCompute/ROCT-Thunk-Interface/pulls/25","html_url":"https://github.com/RadeonOpenCompute/ROCT-Thunk-Interface/pull/25","diff_url":"https://github.com/RadeonOpenCompute/ROCT-Thunk-Interface/pull/25.diff","patch_url":"https://github.com/RadeonOpenCompute/ROCT-Thunk-Interface/pull/25.patch"},"body":"This patchset cleans up cmake so that the library can be correctly packaged for distributions. It also cleans up cmake as there are several things which should not be done in cmake.\r\n\r\nSee also:\r\nhttps://pabloariasal.github.io/2018/02/19/its-time-to-do-cmake-right/\r\n\r\nThe package is built here:\r\nhttps://build.opensuse.org/package/show/home:gladiac:rocm/hsakmt-roct"},"comment":{"url":"https://api.github.com/repos/RadeonOpenCompute/ROCT-Thunk-Interface/issues/comments/419593943","html_url":"https://github.com/RadeonOpenCompute/ROCT-Thunk-Interface/pull/25#issuecomment-419593943","issue_url":"https://api.github.com/repos/RadeonOpenCompute/ROCT-Thunk-Interface/issues/25","id":419593943,"node_id":"MDEyOklzc3VlQ29tbWVudDQxOTU5Mzk0Mw==","user":{"login":"fxkamd","id":13965893,"node_id":"MDQ6VXNlcjEzOTY1ODkz","avatar_url":"https://avatars1.githubusercontent.com/u/13965893?v=4","gravatar_id":"","url":"https://api.github.com/users/fxkamd","html_url":"https://github.com/fxkamd","followers_url":"https://api.github.com/users/fxkamd/followers","following_url":"https://api.github.com/users/fxkamd/following{/other_user}","gists_url":"https://api.github.com/users/fxkamd/gists{/gist_id}","starred_url":"https://api.github.com/users/fxkamd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fxkamd/subscriptions","organizations_url":"https://api.github.com/users/fxkamd/orgs","repos_url":"https://api.github.com/users/fxkamd/repos","events_url":"https://api.github.com/users/fxkamd/events{/privacy}","received_events_url":"https://api.github.com/users/fxkamd/received_events","type":"User","site_admin":false},"created_at":"2018-09-07T23:46:12Z","updated_at":"2018-09-07T23:46:12Z","author_association":"CONTRIBUTOR","body":"I think part of this (or something equivalent) will be in the upcoming ROCm 1.9 release: using GNUInstallDirs, installing a pkgconfig file, and some reorganization of the dev package and how the headers are installed. I think we're still putting the pkgconfig in the wrong place, I'll look info fixing that.\r\n\r\nCan you explain the reasoning behind the changes not to mess with CMAKE_SHARED_LINKER_FLAGS and CMAKE_C_FLAGS? Excuse my ignorance, I'm not a cmake expert.\r\n\r\nThanks,\r\n  Felix"}}
{"actor":{"display_login":"fxkamd"}}