{"action":"reopened","number":56990,"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/56990","id":239943897,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5OTQzODk3","html_url":"https://github.com/rust-lang/rust/pull/56990","diff_url":"https://github.com/rust-lang/rust/pull/56990.diff","patch_url":"https://github.com/rust-lang/rust/pull/56990.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/56990","number":56990,"state":"open","locked":false,"title":"Add gdb to the build","user":{"login":"tromey","id":1557670,"node_id":"MDQ6VXNlcjE1NTc2NzA=","avatar_url":"https://avatars3.githubusercontent.com/u/1557670?v=4","gravatar_id":"","url":"https://api.github.com/users/tromey","html_url":"https://github.com/tromey","followers_url":"https://api.github.com/users/tromey/followers","following_url":"https://api.github.com/users/tromey/following{/other_user}","gists_url":"https://api.github.com/users/tromey/gists{/gist_id}","starred_url":"https://api.github.com/users/tromey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tromey/subscriptions","organizations_url":"https://api.github.com/users/tromey/orgs","repos_url":"https://api.github.com/users/tromey/repos","events_url":"https://api.github.com/users/tromey/events{/privacy}","received_events_url":"https://api.github.com/users/tromey/received_events","type":"User","site_admin":false},"body":"This optionally adds gdb to the Rust build, allowing gdb to be\r\ninstalled via rustup.  This makes it simpler to make debuginfo\r\nchanges, as gdb updates can now be shipped immediately.\r\n\r\nIf gdb is not checked out, nothing changes.\r\n\r\nThe build is perhaps a bit chatty, as gdb's \"make\" and \"make install\"\r\nare run each time, even if they do nothing.\r\n\r\nrust-gdb is modified to prefer the gdb installed by rustup.  This is\r\nanalogous to what was done for rust-lldb.\r\n\r\nThe built gdb requires Python 2.7 as a shared library (other\r\ndependencies are statically linked).  This is a\r\nleast-common-denominator Python that is widely available and stable;\r\ndynamic linking is used to avoid breaking existing gdb Python code\r\nthat might load shared libraries that themselves require a dynamic\r\nlibpython.  To avoid problems here, a small wrapper program is used\r\nthat attemps to dlopen libpython; with failures being reported to the\r\nuser in an intelligible way.\r\n\r\nTwo of the Linux dist builds are updated to build gdb.  More could be\r\nadded if need be.\r\n\r\nIf gdb is built as part of the build, and if no other gdb was\r\nspecified in config.toml, then the just-built gdb will be used for\r\ndebuginfo testing.\r\n\r\nCloses #34457","created_at":"2018-12-19T19:08:33Z","updated_at":"2018-12-21T17:33:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e2eb39f202f7c4efb2f4542c9dca164fb33fb94e","assignee":{"login":"alexcrichton","id":64996,"node_id":"MDQ6VXNlcjY0OTk2","avatar_url":"https://avatars1.githubusercontent.com/u/64996?v=4","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"assignees":[{"login":"alexcrichton","id":64996,"node_id":"MDQ6VXNlcjY0OTk2","avatar_url":"https://avatars1.githubusercontent.com/u/64996?v=4","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":583426710,"node_id":"MDU6TGFiZWw1ODM0MjY3MTA=","url":"https://api.github.com/repos/rust-lang/rust/labels/S-waiting-on-review","name":"S-waiting-on-review","color":"d3dddd","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/56990/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/56990/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/56990/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/5193d1f404a47dffdc7421ca38986e9a6d216a9f","head":{"label":"tromey:build-gdb","ref":"build-gdb","sha":"5193d1f404a47dffdc7421ca38986e9a6d216a9f","user":{"login":"tromey","id":1557670,"node_id":"MDQ6VXNlcjE1NTc2NzA=","avatar_url":"https://avatars3.githubusercontent.com/u/1557670?v=4","gravatar_id":"","url":"https://api.github.com/users/tromey","html_url":"https://github.com/tromey","followers_url":"https://api.github.com/users/tromey/followers","following_url":"https://api.github.com/users/tromey/following{/other_user}","gists_url":"https://api.github.com/users/tromey/gists{/gist_id}","starred_url":"https://api.github.com/users/tromey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tromey/subscriptions","organizations_url":"https://api.github.com/users/tromey/orgs","repos_url":"https://api.github.com/users/tromey/repos","events_url":"https://api.github.com/users/tromey/events{/privacy}","received_events_url":"https://api.github.com/users/tromey/received_events","type":"User","site_admin":false},"repo":{"id":54232577,"node_id":"MDEwOlJlcG9zaXRvcnk1NDIzMjU3Nw==","name":"rust","full_name":"tromey/rust","private":false,"owner":{"login":"tromey","id":1557670,"node_id":"MDQ6VXNlcjE1NTc2NzA=","avatar_url":"https://avatars3.githubusercontent.com/u/1557670?v=4","gravatar_id":"","url":"https://api.github.com/users/tromey","html_url":"https://github.com/tromey","followers_url":"https://api.github.com/users/tromey/followers","following_url":"https://api.github.com/users/tromey/following{/other_user}","gists_url":"https://api.github.com/users/tromey/gists{/gist_id}","starred_url":"https://api.github.com/users/tromey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tromey/subscriptions","organizations_url":"https://api.github.com/users/tromey/orgs","repos_url":"https://api.github.com/users/tromey/repos","events_url":"https://api.github.com/users/tromey/events{/privacy}","received_events_url":"https://api.github.com/users/tromey/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tromey/rust","description":"A safe, concurrent, practical language.","fork":true,"url":"https://api.github.com/repos/tromey/rust","forks_url":"https://api.github.com/repos/tromey/rust/forks","keys_url":"https://api.github.com/repos/tromey/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tromey/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tromey/rust/teams","hooks_url":"https://api.github.com/repos/tromey/rust/hooks","issue_events_url":"https://api.github.com/repos/tromey/rust/issues/events{/number}","events_url":"https://api.github.com/repos/tromey/rust/events","assignees_url":"https://api.github.com/repos/tromey/rust/assignees{/user}","branches_url":"https://api.github.com/repos/tromey/rust/branches{/branch}","tags_url":"https://api.github.com/repos/tromey/rust/tags","blobs_url":"https://api.github.com/repos/tromey/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tromey/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tromey/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/tromey/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tromey/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/tromey/rust/languages","stargazers_url":"https://api.github.com/repos/tromey/rust/stargazers","contributors_url":"https://api.github.com/repos/tromey/rust/contributors","subscribers_url":"https://api.github.com/repos/tromey/rust/subscribers","subscription_url":"https://api.github.com/repos/tromey/rust/subscription","commits_url":"https://api.github.com/repos/tromey/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/tromey/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/tromey/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/tromey/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/tromey/rust/contents/{+path}","compare_url":"https://api.github.com/repos/tromey/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tromey/rust/merges","archive_url":"https://api.github.com/repos/tromey/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tromey/rust/downloads","issues_url":"https://api.github.com/repos/tromey/rust/issues{/number}","pulls_url":"https://api.github.com/repos/tromey/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/tromey/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/tromey/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tromey/rust/labels{/name}","releases_url":"https://api.github.com/repos/tromey/rust/releases{/id}","deployments_url":"https://api.github.com/repos/tromey/rust/deployments","created_at":"2016-03-18T21:30:06Z","updated_at":"2018-03-06T18:54:50Z","pushed_at":"2018-12-18T23:21:55Z","git_url":"git://github.com/tromey/rust.git","ssh_url":"git@github.com:tromey/rust.git","clone_url":"https://github.com/tromey/rust.git","svn_url":"https://github.com/tromey/rust","homepage":"http://www.rust-lang.org","size":404128,"stargazers_count":1,"watchers_count":1,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"0a4a4ffc69f2d05eb8b8a32eaf9bd0607b69fe38","user":{"login":"rust-lang","id":5430905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MzA5MDU=","avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"node_id":"MDEwOlJlcG9zaXRvcnk3MjQ3MTI=","name":"rust","full_name":"rust-lang/rust","private":false,"owner":{"login":"rust-lang","id":5430905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MzA5MDU=","avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rust-lang/rust","description":"Empowering everyone to build reliable and efficient software.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2018-12-21T16:26:07Z","pushed_at":"2018-12-21T17:32:09Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"https://www.rust-lang.org","size":409564,"stargazers_count":32637,"watchers_count":32637,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5398,"mirror_url":null,"archived":false,"open_issues_count":4761,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5398,"open_issues":4761,"watchers":32637,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/56990"},"html":{"href":"https://github.com/rust-lang/rust/pull/56990"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/56990"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/56990/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/56990/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/56990/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/5193d1f404a47dffdc7421ca38986e9a6d216a9f"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":5,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":227,"deletions":5,"changed_files":17}}
{"actor":{"display_login":"alexcrichton"}}