{"action":"created","issue":{"url":"https://api.github.com/repos/glmark2/glmark2/issues/51","repository_url":"https://api.github.com/repos/glmark2/glmark2","labels_url":"https://api.github.com/repos/glmark2/glmark2/issues/51/labels{/name}","comments_url":"https://api.github.com/repos/glmark2/glmark2/issues/51/comments","events_url":"https://api.github.com/repos/glmark2/glmark2/issues/51/events","html_url":"https://github.com/glmark2/glmark2/issues/51","id":306490344,"number":51,"title":"tear down of EGL context","user":{"login":"eliyam32","id":4784265,"avatar_url":"https://avatars2.githubusercontent.com/u/4784265?v=4","gravatar_id":"","url":"https://api.github.com/users/eliyam32","html_url":"https://github.com/eliyam32","followers_url":"https://api.github.com/users/eliyam32/followers","following_url":"https://api.github.com/users/eliyam32/following{/other_user}","gists_url":"https://api.github.com/users/eliyam32/gists{/gist_id}","starred_url":"https://api.github.com/users/eliyam32/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eliyam32/subscriptions","organizations_url":"https://api.github.com/users/eliyam32/orgs","repos_url":"https://api.github.com/users/eliyam32/repos","events_url":"https://api.github.com/users/eliyam32/events{/privacy}","received_events_url":"https://api.github.com/users/eliyam32/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-19T14:39:00Z","updated_at":"2018-03-20T13:03:53Z","closed_at":null,"author_association":"NONE","body":"Hi, I have not found the code that tears down the EGL context: \r\n\r\nsomething like the following snippet : \r\nstatic void term_display() {\r\n         if (display != EGL_NO_DISPLAY) {\r\n         eglMakeCurrent(display, EGL_NO_SURFACE, EGL_NO_SURFACE, EGL_NO_CONTEXT);\r\n         if (context != EGL_NO_CONTEXT) {\r\n             eglDestroyContext(display, context);\r\n         }\r\n         if (surface != EGL_NO_SURFACE) {\r\n             eglDestroySurface(display, surface);\r\n         }\r\n         eglTerminate(display);\r\n     }\r\n     display = EGL_NO_DISPLAY;\r\n     context = EGL_NO_CONTEXT;\r\n     surface = EGL_NO_SURFACE;\r\n}\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/glmark2/glmark2/issues/comments/374589505","html_url":"https://github.com/glmark2/glmark2/issues/51#issuecomment-374589505","issue_url":"https://api.github.com/repos/glmark2/glmark2/issues/51","id":374589505,"user":{"login":"afrantzis","id":495575,"avatar_url":"https://avatars1.githubusercontent.com/u/495575?v=4","gravatar_id":"","url":"https://api.github.com/users/afrantzis","html_url":"https://github.com/afrantzis","followers_url":"https://api.github.com/users/afrantzis/followers","following_url":"https://api.github.com/users/afrantzis/following{/other_user}","gists_url":"https://api.github.com/users/afrantzis/gists{/gist_id}","starred_url":"https://api.github.com/users/afrantzis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/afrantzis/subscriptions","organizations_url":"https://api.github.com/users/afrantzis/orgs","repos_url":"https://api.github.com/users/afrantzis/repos","events_url":"https://api.github.com/users/afrantzis/events{/privacy}","received_events_url":"https://api.github.com/users/afrantzis/received_events","type":"User","site_admin":false},"created_at":"2018-03-20T13:03:53Z","updated_at":"2018-03-20T13:03:53Z","author_association":"CONTRIBUTOR","body":"Hi, there is currently no code in glmark2 to perform explicit EGLSurface/EGLDisplay teardown, since the EGL resources are implicitly released during program shutdown and we don't have a need for more controlled resource release during execution. That being said, I wouldn't be against having the explicit EGL teardown code.\r\n\r\nThere is code to destroy the EGLContext in GLStateEGL::reset() which is called before each benchmark to start it with a clean context (unless the --reuse-context flag is specified)."}}
{"actor":{"display_login":"afrantzis"}}