{"action":"created","issue":{"url":"https://api.github.com/repos/apache/spark/issues/20923","repository_url":"https://api.github.com/repos/apache/spark","labels_url":"https://api.github.com/repos/apache/spark/issues/20923/labels{/name}","comments_url":"https://api.github.com/repos/apache/spark/issues/20923/comments","events_url":"https://api.github.com/repos/apache/spark/issues/20923/events","html_url":"https://github.com/apache/spark/pull/20923","id":309473206,"number":20923,"title":"[SPARK-23807][BUILD] Add Hadoop 3.1 profile with relevant POM fix ups","user":{"login":"steveloughran","id":162090,"avatar_url":"https://avatars2.githubusercontent.com/u/162090?v=4","gravatar_id":"","url":"https://api.github.com/users/steveloughran","html_url":"https://github.com/steveloughran","followers_url":"https://api.github.com/users/steveloughran/followers","following_url":"https://api.github.com/users/steveloughran/following{/other_user}","gists_url":"https://api.github.com/users/steveloughran/gists{/gist_id}","starred_url":"https://api.github.com/users/steveloughran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steveloughran/subscriptions","organizations_url":"https://api.github.com/users/steveloughran/orgs","repos_url":"https://api.github.com/users/steveloughran/repos","events_url":"https://api.github.com/users/steveloughran/events{/privacy}","received_events_url":"https://api.github.com/users/steveloughran/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":32,"created_at":"2018-03-28T18:08:57Z","updated_at":"2018-04-23T23:50:32Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/20923","html_url":"https://github.com/apache/spark/pull/20923","diff_url":"https://github.com/apache/spark/pull/20923.diff","patch_url":"https://github.com/apache/spark/pull/20923.patch"},"body":"## What changes were proposed in this pull request?\r\n\r\n1. Adds a `hadoop-3.1` profile build depending on the hadoop-3.1 artifacts.\r\n1. In the hadoop-cloud module, adds an explicit hadoop-3.1 profile which switches from explicitly pulling in cloud connectors (hadoop-openstack, hadoop-aws, hadoop-azure) to depending on the hadoop-cloudstorage POM artifact, which pulls these in, has pre-excluded things like hadoop-common, and stays up to date with new connectors (hadoop-azuredatalake, hadoop-allyun). Goal: it becomes the Hadoop projects homework of keeping this clean, and the spark project doesn't need to handle new hadoop releases adding more dependencies.\r\n1. the hadoop-cloud/hadoop-3.1 profile also declares support for jetty-ajax and jetty-util to ensure that these jars get into the distribution jar directory when needed by unshaded libraries.\r\n1. Increases the curator and zookeeper versions to match those in hadoop-3, fixing spark core to build in sbt with the hadoop-3 dependencies.\r\n\r\n## How was this patch tested?\r\n\r\n* Everything this has been built and tested against both ASF Hadoop branch-3.1 and hadoop trunk.\r\n* spark-shell was used to create connectors to all the stores and verify that file IO could take place. \r\n\r\n\r\nThe spark hive-1.2.1 JAR has problems here, as it's version check logic fails for Hadoop versions > 2.\r\n\r\nThis can be avoided with either of\r\n\r\n* The hadoop JARs built to declare their version as Hadoop 2.11  `mvn install -DskipTests -DskipShade -Ddeclared.hadoop.version=2.11` . This is safe for local test runs, not for deployment (HDFS is very strict about cross-version deployment).\r\n* A modified version of spark hive whose version check switch statement is happy with hadoop 3.\r\n\r\nI've done both, with maven and SBT. \r\n\r\n\r\nThree issues surfaced\r\n\r\n1. A spark-core test failure —fixed in SPARK-23787. \r\n1. SBT only: Zookeeper not being found in spark-core. Somehow curator 2.12.0 triggers some slightly different dependency resolution logic from previous versions, and Ivy was missing zookeeper.jar entirely. This patch adds the explicit declaration for all spark profiles, setting the ZK version = 3.4.9 for hadoop-3.1\r\n1. Marking jetty-utils as provided in spark was stopping hadoop-azure from being able to instantiate the azure wasb:// client; it was using jetty-util-ajax, which could then not find a class in jetty-util. \r\n"},"comment":{"url":"https://api.github.com/repos/apache/spark/issues/comments/383758171","html_url":"https://github.com/apache/spark/pull/20923#issuecomment-383758171","issue_url":"https://api.github.com/repos/apache/spark/issues/20923","id":383758171,"user":{"login":"AmplabJenkins","id":4031291,"avatar_url":"https://avatars3.githubusercontent.com/u/4031291?v=4","gravatar_id":"","url":"https://api.github.com/users/AmplabJenkins","html_url":"https://github.com/AmplabJenkins","followers_url":"https://api.github.com/users/AmplabJenkins/followers","following_url":"https://api.github.com/users/AmplabJenkins/following{/other_user}","gists_url":"https://api.github.com/users/AmplabJenkins/gists{/gist_id}","starred_url":"https://api.github.com/users/AmplabJenkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AmplabJenkins/subscriptions","organizations_url":"https://api.github.com/users/AmplabJenkins/orgs","repos_url":"https://api.github.com/users/AmplabJenkins/repos","events_url":"https://api.github.com/users/AmplabJenkins/events{/privacy}","received_events_url":"https://api.github.com/users/AmplabJenkins/received_events","type":"User","site_admin":false},"created_at":"2018-04-23T23:50:32Z","updated_at":"2018-04-23T23:50:32Z","author_association":"NONE","body":"Test PASSed.\nRefer to this link for build results (access rights to CI server needed): \nhttps://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/2603/\nTest PASSed."}}
{"actor":{"display_login":"AmplabJenkins"}}