{"action":"created","comment":{"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments/193646558","pull_request_review_id":126657795,"id":193646558,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzY0NjU1OA==","diff_hunk":"@@ -956,7 +954,7 @@ private void CheckMaxReorgRuleViolated(ChainedHeader chainedHeader)\n                 {\n                     int reorgLength = consensusTip.Height - fork.Height;\n \n-                    if (reorgLength > maxReorgLength)\n+                    if (fork.Height <= this.finalizedBlockHeight.GetFinalizedBlockHeight())\n                     {\n                         this.logger.LogTrace(\"Reorganization of length {0} prevented, maximal reorganization length is {1}, consensus tip is '{2}'.\", reorgLength, maxReorgLength, consensusTip);","path":"src/Stratis.Bitcoin/Consensus/ChainedHeaderTree.cs","position":58,"original_position":58,"commit_id":"e9ffd750562b0bc484cbbbc81094fc0e7dbb3360","original_commit_id":"e9ffd750562b0bc484cbbbc81094fc0e7dbb3360","user":{"login":"Aprogiena","id":30052221,"node_id":"MDQ6VXNlcjMwMDUyMjIx","avatar_url":"https://avatars0.githubusercontent.com/u/30052221?v=4","gravatar_id":"","url":"https://api.github.com/users/Aprogiena","html_url":"https://github.com/Aprogiena","followers_url":"https://api.github.com/users/Aprogiena/followers","following_url":"https://api.github.com/users/Aprogiena/following{/other_user}","gists_url":"https://api.github.com/users/Aprogiena/gists{/gist_id}","starred_url":"https://api.github.com/users/Aprogiena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aprogiena/subscriptions","organizations_url":"https://api.github.com/users/Aprogiena/orgs","repos_url":"https://api.github.com/users/Aprogiena/repos","events_url":"https://api.github.com/users/Aprogiena/events{/privacy}","received_events_url":"https://api.github.com/users/Aprogiena/received_events","type":"User","site_admin":false},"body":"It might be nice to have the actual finalise block height in the log as well for comparison.\r\n\r\nAlso the consensus state is no longer relevant and should not be in the log.","created_at":"2018-06-07T07:16:10Z","updated_at":"2018-06-07T07:16:10Z","html_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1480#discussion_r193646558","pull_request_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1480","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments/193646558"},"html":{"href":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1480#discussion_r193646558"},"pull_request":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1480"}}},"pull_request":{"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1480","id":193021255,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzMDIxMjU1","html_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1480","diff_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1480.diff","patch_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1480.patch","issue_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1480","number":1480,"state":"open","locked":false,"title":"Added finalized block height","user":{"login":"noescape00","id":10259355,"node_id":"MDQ6VXNlcjEwMjU5MzU1","avatar_url":"https://avatars0.githubusercontent.com/u/10259355?v=4","gravatar_id":"","url":"https://api.github.com/users/noescape00","html_url":"https://github.com/noescape00","followers_url":"https://api.github.com/users/noescape00/followers","following_url":"https://api.github.com/users/noescape00/following{/other_user}","gists_url":"https://api.github.com/users/noescape00/gists{/gist_id}","starred_url":"https://api.github.com/users/noescape00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noescape00/subscriptions","organizations_url":"https://api.github.com/users/noescape00/orgs","repos_url":"https://api.github.com/users/noescape00/repos","events_url":"https://api.github.com/users/noescape00/events{/privacy}","received_events_url":"https://api.github.com/users/noescape00/received_events","type":"User","site_admin":false},"body":"Fix: #1181 ","created_at":"2018-06-06T13:53:30Z","updated_at":"2018-06-07T07:16:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f57fbaf23188f46d3b374ba8b31efdfc086be3e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1480/commits","review_comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1480/comments","review_comment_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1480/comments","statuses_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/e9ffd750562b0bc484cbbbc81094fc0e7dbb3360","head":{"label":"noescape00:finalizedChainedHeader","ref":"finalizedChainedHeader","sha":"e9ffd750562b0bc484cbbbc81094fc0e7dbb3360","user":{"login":"noescape00","id":10259355,"node_id":"MDQ6VXNlcjEwMjU5MzU1","avatar_url":"https://avatars0.githubusercontent.com/u/10259355?v=4","gravatar_id":"","url":"https://api.github.com/users/noescape00","html_url":"https://github.com/noescape00","followers_url":"https://api.github.com/users/noescape00/followers","following_url":"https://api.github.com/users/noescape00/following{/other_user}","gists_url":"https://api.github.com/users/noescape00/gists{/gist_id}","starred_url":"https://api.github.com/users/noescape00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noescape00/subscriptions","organizations_url":"https://api.github.com/users/noescape00/orgs","repos_url":"https://api.github.com/users/noescape00/repos","events_url":"https://api.github.com/users/noescape00/events{/privacy}","received_events_url":"https://api.github.com/users/noescape00/received_events","type":"User","site_admin":false},"repo":{"id":109851531,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk4NTE1MzE=","name":"StratisBitcoinFullNode","full_name":"noescape00/StratisBitcoinFullNode","owner":{"login":"noescape00","id":10259355,"node_id":"MDQ6VXNlcjEwMjU5MzU1","avatar_url":"https://avatars0.githubusercontent.com/u/10259355?v=4","gravatar_id":"","url":"https://api.github.com/users/noescape00","html_url":"https://github.com/noescape00","followers_url":"https://api.github.com/users/noescape00/followers","following_url":"https://api.github.com/users/noescape00/following{/other_user}","gists_url":"https://api.github.com/users/noescape00/gists{/gist_id}","starred_url":"https://api.github.com/users/noescape00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/noescape00/subscriptions","organizations_url":"https://api.github.com/users/noescape00/orgs","repos_url":"https://api.github.com/users/noescape00/repos","events_url":"https://api.github.com/users/noescape00/events{/privacy}","received_events_url":"https://api.github.com/users/noescape00/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/noescape00/StratisBitcoinFullNode","description":"Bitcoin full node in C#","fork":true,"url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode","forks_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/forks","keys_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/teams","hooks_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/hooks","issue_events_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/issues/events{/number}","events_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/events","assignees_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/assignees{/user}","branches_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/branches{/branch}","tags_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/tags","blobs_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/git/refs{/sha}","trees_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/statuses/{sha}","languages_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/languages","stargazers_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/stargazers","contributors_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/contributors","subscribers_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/subscribers","subscription_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/subscription","commits_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/commits{/sha}","git_commits_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/git/commits{/sha}","comments_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/comments{/number}","issue_comment_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/issues/comments{/number}","contents_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/contents/{+path}","compare_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/merges","archive_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/downloads","issues_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/issues{/number}","pulls_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/pulls{/number}","milestones_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/milestones{/number}","notifications_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/labels{/name}","releases_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/releases{/id}","deployments_url":"https://api.github.com/repos/noescape00/StratisBitcoinFullNode/deployments","created_at":"2017-11-07T15:09:59Z","updated_at":"2018-06-06T17:03:08Z","pushed_at":"2018-06-06T19:11:48Z","git_url":"git://github.com/noescape00/StratisBitcoinFullNode.git","ssh_url":"git@github.com:noescape00/StratisBitcoinFullNode.git","clone_url":"https://github.com/noescape00/StratisBitcoinFullNode.git","svn_url":"https://github.com/noescape00/StratisBitcoinFullNode","homepage":"https://stratisplatform.com","size":28546,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"stratisproject:master","ref":"master","sha":"f49291898d6f06bdecd59b9ccb17c25f23b3f6a4","user":{"login":"stratisproject","id":15229748,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjI5NzQ4","avatar_url":"https://avatars0.githubusercontent.com/u/15229748?v=4","gravatar_id":"","url":"https://api.github.com/users/stratisproject","html_url":"https://github.com/stratisproject","followers_url":"https://api.github.com/users/stratisproject/followers","following_url":"https://api.github.com/users/stratisproject/following{/other_user}","gists_url":"https://api.github.com/users/stratisproject/gists{/gist_id}","starred_url":"https://api.github.com/users/stratisproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratisproject/subscriptions","organizations_url":"https://api.github.com/users/stratisproject/orgs","repos_url":"https://api.github.com/users/stratisproject/repos","events_url":"https://api.github.com/users/stratisproject/events{/privacy}","received_events_url":"https://api.github.com/users/stratisproject/received_events","type":"Organization","site_admin":false},"repo":{"id":67271290,"node_id":"MDEwOlJlcG9zaXRvcnk2NzI3MTI5MA==","name":"StratisBitcoinFullNode","full_name":"stratisproject/StratisBitcoinFullNode","owner":{"login":"stratisproject","id":15229748,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjI5NzQ4","avatar_url":"https://avatars0.githubusercontent.com/u/15229748?v=4","gravatar_id":"","url":"https://api.github.com/users/stratisproject","html_url":"https://github.com/stratisproject","followers_url":"https://api.github.com/users/stratisproject/followers","following_url":"https://api.github.com/users/stratisproject/following{/other_user}","gists_url":"https://api.github.com/users/stratisproject/gists{/gist_id}","starred_url":"https://api.github.com/users/stratisproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratisproject/subscriptions","organizations_url":"https://api.github.com/users/stratisproject/orgs","repos_url":"https://api.github.com/users/stratisproject/repos","events_url":"https://api.github.com/users/stratisproject/events{/privacy}","received_events_url":"https://api.github.com/users/stratisproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stratisproject/StratisBitcoinFullNode","description":"Bitcoin full node in C#","fork":false,"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode","forks_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/forks","keys_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/teams","hooks_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/hooks","issue_events_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/events{/number}","events_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/events","assignees_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/assignees{/user}","branches_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/branches{/branch}","tags_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/tags","blobs_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/refs{/sha}","trees_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/{sha}","languages_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/languages","stargazers_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/stargazers","contributors_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/contributors","subscribers_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/subscribers","subscription_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/subscription","commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/commits{/sha}","git_commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/commits{/sha}","comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/comments{/number}","issue_comment_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/comments{/number}","contents_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/contents/{+path}","compare_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/merges","archive_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/downloads","issues_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues{/number}","pulls_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls{/number}","milestones_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/milestones{/number}","notifications_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/labels{/name}","releases_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/releases{/id}","deployments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/deployments","created_at":"2016-09-03T04:32:51Z","updated_at":"2018-06-06T16:35:49Z","pushed_at":"2018-06-07T00:26:54Z","git_url":"git://github.com/stratisproject/StratisBitcoinFullNode.git","ssh_url":"git@github.com:stratisproject/StratisBitcoinFullNode.git","clone_url":"https://github.com/stratisproject/StratisBitcoinFullNode.git","svn_url":"https://github.com/stratisproject/StratisBitcoinFullNode","homepage":"https://stratisplatform.com","size":29430,"stargazers_count":486,"watchers_count":486,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":207,"mirror_url":null,"archived":false,"open_issues_count":107,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":207,"open_issues":107,"watchers":486,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1480"},"html":{"href":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1480"},"issue":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1480"},"comments":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1480/comments"},"review_comments":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1480/comments"},"review_comment":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1480/commits"},"statuses":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/e9ffd750562b0bc484cbbbc81094fc0e7dbb3360"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Aprogiena"}}