{"action":"closed","number":1220,"pull_request":{"url":"https://api.github.com/repos/cypress-io/cypress/pulls/1220","id":164715633,"html_url":"https://github.com/cypress-io/cypress/pull/1220","diff_url":"https://github.com/cypress-io/cypress/pull/1220.diff","patch_url":"https://github.com/cypress-io/cypress/pull/1220.patch","issue_url":"https://api.github.com/repos/cypress-io/cypress/issues/1220","number":1220,"state":"closed","locked":false,"title":"fix: Incorrect type for 'then' returning a wrapped 'undefined'","user":{"login":"NicholasBoll","id":338257,"avatar_url":"https://avatars2.githubusercontent.com/u/338257?v=4","gravatar_id":"","url":"https://api.github.com/users/NicholasBoll","html_url":"https://github.com/NicholasBoll","followers_url":"https://api.github.com/users/NicholasBoll/followers","following_url":"https://api.github.com/users/NicholasBoll/following{/other_user}","gists_url":"https://api.github.com/users/NicholasBoll/gists{/gist_id}","starred_url":"https://api.github.com/users/NicholasBoll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NicholasBoll/subscriptions","organizations_url":"https://api.github.com/users/NicholasBoll/orgs","repos_url":"https://api.github.com/users/NicholasBoll/repos","events_url":"https://api.github.com/users/NicholasBoll/events{/privacy}","received_events_url":"https://api.github.com/users/NicholasBoll/received_events","type":"User","site_admin":false},"body":"It is valid to return a wrapped `undefined`. Example: `cy.wrap(undefined)` or `Promise.resolve(undefined)` or even `cy.wrap(null)`.\r\n\r\nAs it is before this PR, returning a wrapped `undefined` or `null` would result in a double-wrapped type\r\n\r\nFixes #1219","created_at":"2018-01-23T23:11:55Z","updated_at":"2018-02-04T19:45:43Z","closed_at":"2018-02-04T19:45:43Z","merged_at":"2018-02-04T19:45:43Z","merge_commit_sha":"88f534bf082987a8f025dea8b1a9f4b9ba862428","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/cypress-io/cypress/pulls/1220/commits","review_comments_url":"https://api.github.com/repos/cypress-io/cypress/pulls/1220/comments","review_comment_url":"https://api.github.com/repos/cypress-io/cypress/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cypress-io/cypress/issues/1220/comments","statuses_url":"https://api.github.com/repos/cypress-io/cypress/statuses/be0b00b052279de972390f262a2c005c9365a9f6","head":{"label":"NicholasBoll:fix/then-wrapped-undefined","ref":"fix/then-wrapped-undefined","sha":"be0b00b052279de972390f262a2c005c9365a9f6","user":{"login":"NicholasBoll","id":338257,"avatar_url":"https://avatars2.githubusercontent.com/u/338257?v=4","gravatar_id":"","url":"https://api.github.com/users/NicholasBoll","html_url":"https://github.com/NicholasBoll","followers_url":"https://api.github.com/users/NicholasBoll/followers","following_url":"https://api.github.com/users/NicholasBoll/following{/other_user}","gists_url":"https://api.github.com/users/NicholasBoll/gists{/gist_id}","starred_url":"https://api.github.com/users/NicholasBoll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NicholasBoll/subscriptions","organizations_url":"https://api.github.com/users/NicholasBoll/orgs","repos_url":"https://api.github.com/users/NicholasBoll/repos","events_url":"https://api.github.com/users/NicholasBoll/events{/privacy}","received_events_url":"https://api.github.com/users/NicholasBoll/received_events","type":"User","site_admin":false},"repo":{"id":113554396,"name":"cypress","full_name":"NicholasBoll/cypress","owner":{"login":"NicholasBoll","id":338257,"avatar_url":"https://avatars2.githubusercontent.com/u/338257?v=4","gravatar_id":"","url":"https://api.github.com/users/NicholasBoll","html_url":"https://github.com/NicholasBoll","followers_url":"https://api.github.com/users/NicholasBoll/followers","following_url":"https://api.github.com/users/NicholasBoll/following{/other_user}","gists_url":"https://api.github.com/users/NicholasBoll/gists{/gist_id}","starred_url":"https://api.github.com/users/NicholasBoll/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NicholasBoll/subscriptions","organizations_url":"https://api.github.com/users/NicholasBoll/orgs","repos_url":"https://api.github.com/users/NicholasBoll/repos","events_url":"https://api.github.com/users/NicholasBoll/events{/privacy}","received_events_url":"https://api.github.com/users/NicholasBoll/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/NicholasBoll/cypress","description":"Fast, easy and reliable testing for anything that runs in a browser.","fork":true,"url":"https://api.github.com/repos/NicholasBoll/cypress","forks_url":"https://api.github.com/repos/NicholasBoll/cypress/forks","keys_url":"https://api.github.com/repos/NicholasBoll/cypress/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NicholasBoll/cypress/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NicholasBoll/cypress/teams","hooks_url":"https://api.github.com/repos/NicholasBoll/cypress/hooks","issue_events_url":"https://api.github.com/repos/NicholasBoll/cypress/issues/events{/number}","events_url":"https://api.github.com/repos/NicholasBoll/cypress/events","assignees_url":"https://api.github.com/repos/NicholasBoll/cypress/assignees{/user}","branches_url":"https://api.github.com/repos/NicholasBoll/cypress/branches{/branch}","tags_url":"https://api.github.com/repos/NicholasBoll/cypress/tags","blobs_url":"https://api.github.com/repos/NicholasBoll/cypress/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NicholasBoll/cypress/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NicholasBoll/cypress/git/refs{/sha}","trees_url":"https://api.github.com/repos/NicholasBoll/cypress/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NicholasBoll/cypress/statuses/{sha}","languages_url":"https://api.github.com/repos/NicholasBoll/cypress/languages","stargazers_url":"https://api.github.com/repos/NicholasBoll/cypress/stargazers","contributors_url":"https://api.github.com/repos/NicholasBoll/cypress/contributors","subscribers_url":"https://api.github.com/repos/NicholasBoll/cypress/subscribers","subscription_url":"https://api.github.com/repos/NicholasBoll/cypress/subscription","commits_url":"https://api.github.com/repos/NicholasBoll/cypress/commits{/sha}","git_commits_url":"https://api.github.com/repos/NicholasBoll/cypress/git/commits{/sha}","comments_url":"https://api.github.com/repos/NicholasBoll/cypress/comments{/number}","issue_comment_url":"https://api.github.com/repos/NicholasBoll/cypress/issues/comments{/number}","contents_url":"https://api.github.com/repos/NicholasBoll/cypress/contents/{+path}","compare_url":"https://api.github.com/repos/NicholasBoll/cypress/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NicholasBoll/cypress/merges","archive_url":"https://api.github.com/repos/NicholasBoll/cypress/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NicholasBoll/cypress/downloads","issues_url":"https://api.github.com/repos/NicholasBoll/cypress/issues{/number}","pulls_url":"https://api.github.com/repos/NicholasBoll/cypress/pulls{/number}","milestones_url":"https://api.github.com/repos/NicholasBoll/cypress/milestones{/number}","notifications_url":"https://api.github.com/repos/NicholasBoll/cypress/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NicholasBoll/cypress/labels{/name}","releases_url":"https://api.github.com/repos/NicholasBoll/cypress/releases{/id}","deployments_url":"https://api.github.com/repos/NicholasBoll/cypress/deployments","created_at":"2017-12-08T09:04:43Z","updated_at":"2017-12-08T09:04:47Z","pushed_at":"2018-01-23T23:03:15Z","git_url":"git://github.com/NicholasBoll/cypress.git","ssh_url":"git@github.com:NicholasBoll/cypress.git","clone_url":"https://github.com/NicholasBoll/cypress.git","svn_url":"https://github.com/NicholasBoll/cypress","homepage":"https://www.cypress.io","size":119962,"stargazers_count":0,"watchers_count":0,"language":"CoffeeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"cypress-io:develop","ref":"develop","sha":"80456ea8ddfb28760b3135c5110356e112f25695","user":{"login":"cypress-io","id":8908513,"avatar_url":"https://avatars3.githubusercontent.com/u/8908513?v=4","gravatar_id":"","url":"https://api.github.com/users/cypress-io","html_url":"https://github.com/cypress-io","followers_url":"https://api.github.com/users/cypress-io/followers","following_url":"https://api.github.com/users/cypress-io/following{/other_user}","gists_url":"https://api.github.com/users/cypress-io/gists{/gist_id}","starred_url":"https://api.github.com/users/cypress-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cypress-io/subscriptions","organizations_url":"https://api.github.com/users/cypress-io/orgs","repos_url":"https://api.github.com/users/cypress-io/repos","events_url":"https://api.github.com/users/cypress-io/events{/privacy}","received_events_url":"https://api.github.com/users/cypress-io/received_events","type":"Organization","site_admin":false},"repo":{"id":31629751,"name":"cypress","full_name":"cypress-io/cypress","owner":{"login":"cypress-io","id":8908513,"avatar_url":"https://avatars3.githubusercontent.com/u/8908513?v=4","gravatar_id":"","url":"https://api.github.com/users/cypress-io","html_url":"https://github.com/cypress-io","followers_url":"https://api.github.com/users/cypress-io/followers","following_url":"https://api.github.com/users/cypress-io/following{/other_user}","gists_url":"https://api.github.com/users/cypress-io/gists{/gist_id}","starred_url":"https://api.github.com/users/cypress-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cypress-io/subscriptions","organizations_url":"https://api.github.com/users/cypress-io/orgs","repos_url":"https://api.github.com/users/cypress-io/repos","events_url":"https://api.github.com/users/cypress-io/events{/privacy}","received_events_url":"https://api.github.com/users/cypress-io/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cypress-io/cypress","description":"Fast, easy and reliable testing for anything that runs in a browser.","fork":false,"url":"https://api.github.com/repos/cypress-io/cypress","forks_url":"https://api.github.com/repos/cypress-io/cypress/forks","keys_url":"https://api.github.com/repos/cypress-io/cypress/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cypress-io/cypress/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cypress-io/cypress/teams","hooks_url":"https://api.github.com/repos/cypress-io/cypress/hooks","issue_events_url":"https://api.github.com/repos/cypress-io/cypress/issues/events{/number}","events_url":"https://api.github.com/repos/cypress-io/cypress/events","assignees_url":"https://api.github.com/repos/cypress-io/cypress/assignees{/user}","branches_url":"https://api.github.com/repos/cypress-io/cypress/branches{/branch}","tags_url":"https://api.github.com/repos/cypress-io/cypress/tags","blobs_url":"https://api.github.com/repos/cypress-io/cypress/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cypress-io/cypress/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cypress-io/cypress/git/refs{/sha}","trees_url":"https://api.github.com/repos/cypress-io/cypress/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cypress-io/cypress/statuses/{sha}","languages_url":"https://api.github.com/repos/cypress-io/cypress/languages","stargazers_url":"https://api.github.com/repos/cypress-io/cypress/stargazers","contributors_url":"https://api.github.com/repos/cypress-io/cypress/contributors","subscribers_url":"https://api.github.com/repos/cypress-io/cypress/subscribers","subscription_url":"https://api.github.com/repos/cypress-io/cypress/subscription","commits_url":"https://api.github.com/repos/cypress-io/cypress/commits{/sha}","git_commits_url":"https://api.github.com/repos/cypress-io/cypress/git/commits{/sha}","comments_url":"https://api.github.com/repos/cypress-io/cypress/comments{/number}","issue_comment_url":"https://api.github.com/repos/cypress-io/cypress/issues/comments{/number}","contents_url":"https://api.github.com/repos/cypress-io/cypress/contents/{+path}","compare_url":"https://api.github.com/repos/cypress-io/cypress/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cypress-io/cypress/merges","archive_url":"https://api.github.com/repos/cypress-io/cypress/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cypress-io/cypress/downloads","issues_url":"https://api.github.com/repos/cypress-io/cypress/issues{/number}","pulls_url":"https://api.github.com/repos/cypress-io/cypress/pulls{/number}","milestones_url":"https://api.github.com/repos/cypress-io/cypress/milestones{/number}","notifications_url":"https://api.github.com/repos/cypress-io/cypress/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cypress-io/cypress/labels{/name}","releases_url":"https://api.github.com/repos/cypress-io/cypress/releases{/id}","deployments_url":"https://api.github.com/repos/cypress-io/cypress/deployments","created_at":"2015-03-04T00:46:28Z","updated_at":"2018-02-04T17:42:08Z","pushed_at":"2018-02-04T19:45:43Z","git_url":"git://github.com/cypress-io/cypress.git","ssh_url":"git@github.com:cypress-io/cypress.git","clone_url":"https://github.com/cypress-io/cypress.git","svn_url":"https://github.com/cypress-io/cypress","homepage":"https://www.cypress.io","size":120328,"stargazers_count":3649,"watchers_count":3649,"language":"CoffeeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":125,"mirror_url":null,"archived":false,"open_issues_count":424,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":125,"open_issues":424,"watchers":3649,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/cypress-io/cypress/pulls/1220"},"html":{"href":"https://github.com/cypress-io/cypress/pull/1220"},"issue":{"href":"https://api.github.com/repos/cypress-io/cypress/issues/1220"},"comments":{"href":"https://api.github.com/repos/cypress-io/cypress/issues/1220/comments"},"review_comments":{"href":"https://api.github.com/repos/cypress-io/cypress/pulls/1220/comments"},"review_comment":{"href":"https://api.github.com/repos/cypress-io/cypress/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cypress-io/cypress/pulls/1220/commits"},"statuses":{"href":"https://api.github.com/repos/cypress-io/cypress/statuses/be0b00b052279de972390f262a2c005c9365a9f6"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"brian-mann","id":1268976,"avatar_url":"https://avatars2.githubusercontent.com/u/1268976?v=4","gravatar_id":"","url":"https://api.github.com/users/brian-mann","html_url":"https://github.com/brian-mann","followers_url":"https://api.github.com/users/brian-mann/followers","following_url":"https://api.github.com/users/brian-mann/following{/other_user}","gists_url":"https://api.github.com/users/brian-mann/gists{/gist_id}","starred_url":"https://api.github.com/users/brian-mann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brian-mann/subscriptions","organizations_url":"https://api.github.com/users/brian-mann/orgs","repos_url":"https://api.github.com/users/brian-mann/repos","events_url":"https://api.github.com/users/brian-mann/events{/privacy}","received_events_url":"https://api.github.com/users/brian-mann/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":11,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"brian-mann"}}