{"action":"closed","number":784,"pull_request":{"url":"https://api.github.com/repos/bullhorn/novo-elements/pulls/784","id":208042698,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MDQyNjk4","html_url":"https://github.com/bullhorn/novo-elements/pull/784","diff_url":"https://github.com/bullhorn/novo-elements/pull/784.diff","patch_url":"https://github.com/bullhorn/novo-elements/pull/784.patch","issue_url":"https://api.github.com/repos/bullhorn/novo-elements/issues/784","number":784,"state":"closed","locked":false,"title":"fix(Picker): Make picker results dynamic height so they fit on screen","user":{"login":"ndickerson","id":3843503,"node_id":"MDQ6VXNlcjM4NDM1MDM=","avatar_url":"https://avatars2.githubusercontent.com/u/3843503?v=4","gravatar_id":"","url":"https://api.github.com/users/ndickerson","html_url":"https://github.com/ndickerson","followers_url":"https://api.github.com/users/ndickerson/followers","following_url":"https://api.github.com/users/ndickerson/following{/other_user}","gists_url":"https://api.github.com/users/ndickerson/gists{/gist_id}","starred_url":"https://api.github.com/users/ndickerson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndickerson/subscriptions","organizations_url":"https://api.github.com/users/ndickerson/orgs","repos_url":"https://api.github.com/users/ndickerson/repos","events_url":"https://api.github.com/users/ndickerson/events{/privacy}","received_events_url":"https://api.github.com/users/ndickerson/received_events","type":"User","site_admin":false},"body":"## **Description**\r\n\r\n Height of picker results is slightly less than half of the screen\r\n height so that they will always be able to be positioned above/below\r\n and still fit on screen. The static height of 450px was sometimes too\r\n tall for the window height.\r\n\r\n#### **Verify that...**\r\n\r\n- [x] Any related demos where added and `npm start` still works\r\n- [x] New demos work in `Safari`, `Chrome` and `Firefox`\r\n- [x] `npm run lint` passes\r\n- [x] `npm test` passes and code coverage is increased\r\n- [x] `npm run build` still works\r\n\r\n#### **Bullhorn Internal Developers**\r\n- [x] Run `Novo Automation`\r\n- [x] Run `BBO Automation`\r\n\r\n##### **Screenshots**\r\n![dynamic-picker-height](https://user-images.githubusercontent.com/3843503/44046415-fa3a2c34-9ef0-11e8-9a35-82e31adcaf7b.gif)\r\n","created_at":"2018-08-13T17:04:47Z","updated_at":"2018-08-15T13:57:17Z","closed_at":"2018-08-15T13:57:17Z","merged_at":"2018-08-15T13:57:17Z","merge_commit_sha":"1459a52694189c9fe6fdd2bdf2a0b0e2fda888b6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":773803405,"node_id":"MDU6TGFiZWw3NzM4MDM0MDU=","url":"https://api.github.com/repos/bullhorn/novo-elements/labels/merge%20please","name":"merge please","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/bullhorn/novo-elements/pulls/784/commits","review_comments_url":"https://api.github.com/repos/bullhorn/novo-elements/pulls/784/comments","review_comment_url":"https://api.github.com/repos/bullhorn/novo-elements/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bullhorn/novo-elements/issues/784/comments","statuses_url":"https://api.github.com/repos/bullhorn/novo-elements/statuses/87343bcc7cff93b6a98a0af2f5132bfe1cdc8d03","head":{"label":"bullhorn:f/picker-height","ref":"f/picker-height","sha":"87343bcc7cff93b6a98a0af2f5132bfe1cdc8d03","user":{"login":"bullhorn","id":4107582,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDc1ODI=","avatar_url":"https://avatars0.githubusercontent.com/u/4107582?v=4","gravatar_id":"","url":"https://api.github.com/users/bullhorn","html_url":"https://github.com/bullhorn","followers_url":"https://api.github.com/users/bullhorn/followers","following_url":"https://api.github.com/users/bullhorn/following{/other_user}","gists_url":"https://api.github.com/users/bullhorn/gists{/gist_id}","starred_url":"https://api.github.com/users/bullhorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bullhorn/subscriptions","organizations_url":"https://api.github.com/users/bullhorn/orgs","repos_url":"https://api.github.com/users/bullhorn/repos","events_url":"https://api.github.com/users/bullhorn/events{/privacy}","received_events_url":"https://api.github.com/users/bullhorn/received_events","type":"Organization","site_admin":false},"repo":{"id":56453136,"node_id":"MDEwOlJlcG9zaXRvcnk1NjQ1MzEzNg==","name":"novo-elements","full_name":"bullhorn/novo-elements","owner":{"login":"bullhorn","id":4107582,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDc1ODI=","avatar_url":"https://avatars0.githubusercontent.com/u/4107582?v=4","gravatar_id":"","url":"https://api.github.com/users/bullhorn","html_url":"https://github.com/bullhorn","followers_url":"https://api.github.com/users/bullhorn/followers","following_url":"https://api.github.com/users/bullhorn/following{/other_user}","gists_url":"https://api.github.com/users/bullhorn/gists{/gist_id}","starred_url":"https://api.github.com/users/bullhorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bullhorn/subscriptions","organizations_url":"https://api.github.com/users/bullhorn/orgs","repos_url":"https://api.github.com/users/bullhorn/repos","events_url":"https://api.github.com/users/bullhorn/events{/privacy}","received_events_url":"https://api.github.com/users/bullhorn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bullhorn/novo-elements","description":"UI Repository for Bullhorn's Novo Theme","fork":false,"url":"https://api.github.com/repos/bullhorn/novo-elements","forks_url":"https://api.github.com/repos/bullhorn/novo-elements/forks","keys_url":"https://api.github.com/repos/bullhorn/novo-elements/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bullhorn/novo-elements/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bullhorn/novo-elements/teams","hooks_url":"https://api.github.com/repos/bullhorn/novo-elements/hooks","issue_events_url":"https://api.github.com/repos/bullhorn/novo-elements/issues/events{/number}","events_url":"https://api.github.com/repos/bullhorn/novo-elements/events","assignees_url":"https://api.github.com/repos/bullhorn/novo-elements/assignees{/user}","branches_url":"https://api.github.com/repos/bullhorn/novo-elements/branches{/branch}","tags_url":"https://api.github.com/repos/bullhorn/novo-elements/tags","blobs_url":"https://api.github.com/repos/bullhorn/novo-elements/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bullhorn/novo-elements/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bullhorn/novo-elements/git/refs{/sha}","trees_url":"https://api.github.com/repos/bullhorn/novo-elements/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bullhorn/novo-elements/statuses/{sha}","languages_url":"https://api.github.com/repos/bullhorn/novo-elements/languages","stargazers_url":"https://api.github.com/repos/bullhorn/novo-elements/stargazers","contributors_url":"https://api.github.com/repos/bullhorn/novo-elements/contributors","subscribers_url":"https://api.github.com/repos/bullhorn/novo-elements/subscribers","subscription_url":"https://api.github.com/repos/bullhorn/novo-elements/subscription","commits_url":"https://api.github.com/repos/bullhorn/novo-elements/commits{/sha}","git_commits_url":"https://api.github.com/repos/bullhorn/novo-elements/git/commits{/sha}","comments_url":"https://api.github.com/repos/bullhorn/novo-elements/comments{/number}","issue_comment_url":"https://api.github.com/repos/bullhorn/novo-elements/issues/comments{/number}","contents_url":"https://api.github.com/repos/bullhorn/novo-elements/contents/{+path}","compare_url":"https://api.github.com/repos/bullhorn/novo-elements/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bullhorn/novo-elements/merges","archive_url":"https://api.github.com/repos/bullhorn/novo-elements/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bullhorn/novo-elements/downloads","issues_url":"https://api.github.com/repos/bullhorn/novo-elements/issues{/number}","pulls_url":"https://api.github.com/repos/bullhorn/novo-elements/pulls{/number}","milestones_url":"https://api.github.com/repos/bullhorn/novo-elements/milestones{/number}","notifications_url":"https://api.github.com/repos/bullhorn/novo-elements/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bullhorn/novo-elements/labels{/name}","releases_url":"https://api.github.com/repos/bullhorn/novo-elements/releases{/id}","deployments_url":"https://api.github.com/repos/bullhorn/novo-elements/deployments","created_at":"2016-04-17T19:00:11Z","updated_at":"2018-08-15T13:30:43Z","pushed_at":"2018-08-15T13:57:17Z","git_url":"git://github.com/bullhorn/novo-elements.git","ssh_url":"git@github.com:bullhorn/novo-elements.git","clone_url":"https://github.com/bullhorn/novo-elements.git","svn_url":"https://github.com/bullhorn/novo-elements","homepage":"http://bullhorn.github.io/novo-elements","size":42555,"stargazers_count":45,"watchers_count":45,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":37,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":33,"open_issues":37,"watchers":45,"default_branch":"master"}},"base":{"label":"bullhorn:master","ref":"master","sha":"ee2958adea22d28df23a1167bc0c1e6b9563205d","user":{"login":"bullhorn","id":4107582,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDc1ODI=","avatar_url":"https://avatars0.githubusercontent.com/u/4107582?v=4","gravatar_id":"","url":"https://api.github.com/users/bullhorn","html_url":"https://github.com/bullhorn","followers_url":"https://api.github.com/users/bullhorn/followers","following_url":"https://api.github.com/users/bullhorn/following{/other_user}","gists_url":"https://api.github.com/users/bullhorn/gists{/gist_id}","starred_url":"https://api.github.com/users/bullhorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bullhorn/subscriptions","organizations_url":"https://api.github.com/users/bullhorn/orgs","repos_url":"https://api.github.com/users/bullhorn/repos","events_url":"https://api.github.com/users/bullhorn/events{/privacy}","received_events_url":"https://api.github.com/users/bullhorn/received_events","type":"Organization","site_admin":false},"repo":{"id":56453136,"node_id":"MDEwOlJlcG9zaXRvcnk1NjQ1MzEzNg==","name":"novo-elements","full_name":"bullhorn/novo-elements","owner":{"login":"bullhorn","id":4107582,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDc1ODI=","avatar_url":"https://avatars0.githubusercontent.com/u/4107582?v=4","gravatar_id":"","url":"https://api.github.com/users/bullhorn","html_url":"https://github.com/bullhorn","followers_url":"https://api.github.com/users/bullhorn/followers","following_url":"https://api.github.com/users/bullhorn/following{/other_user}","gists_url":"https://api.github.com/users/bullhorn/gists{/gist_id}","starred_url":"https://api.github.com/users/bullhorn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bullhorn/subscriptions","organizations_url":"https://api.github.com/users/bullhorn/orgs","repos_url":"https://api.github.com/users/bullhorn/repos","events_url":"https://api.github.com/users/bullhorn/events{/privacy}","received_events_url":"https://api.github.com/users/bullhorn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/bullhorn/novo-elements","description":"UI Repository for Bullhorn's Novo Theme","fork":false,"url":"https://api.github.com/repos/bullhorn/novo-elements","forks_url":"https://api.github.com/repos/bullhorn/novo-elements/forks","keys_url":"https://api.github.com/repos/bullhorn/novo-elements/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bullhorn/novo-elements/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bullhorn/novo-elements/teams","hooks_url":"https://api.github.com/repos/bullhorn/novo-elements/hooks","issue_events_url":"https://api.github.com/repos/bullhorn/novo-elements/issues/events{/number}","events_url":"https://api.github.com/repos/bullhorn/novo-elements/events","assignees_url":"https://api.github.com/repos/bullhorn/novo-elements/assignees{/user}","branches_url":"https://api.github.com/repos/bullhorn/novo-elements/branches{/branch}","tags_url":"https://api.github.com/repos/bullhorn/novo-elements/tags","blobs_url":"https://api.github.com/repos/bullhorn/novo-elements/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bullhorn/novo-elements/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bullhorn/novo-elements/git/refs{/sha}","trees_url":"https://api.github.com/repos/bullhorn/novo-elements/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bullhorn/novo-elements/statuses/{sha}","languages_url":"https://api.github.com/repos/bullhorn/novo-elements/languages","stargazers_url":"https://api.github.com/repos/bullhorn/novo-elements/stargazers","contributors_url":"https://api.github.com/repos/bullhorn/novo-elements/contributors","subscribers_url":"https://api.github.com/repos/bullhorn/novo-elements/subscribers","subscription_url":"https://api.github.com/repos/bullhorn/novo-elements/subscription","commits_url":"https://api.github.com/repos/bullhorn/novo-elements/commits{/sha}","git_commits_url":"https://api.github.com/repos/bullhorn/novo-elements/git/commits{/sha}","comments_url":"https://api.github.com/repos/bullhorn/novo-elements/comments{/number}","issue_comment_url":"https://api.github.com/repos/bullhorn/novo-elements/issues/comments{/number}","contents_url":"https://api.github.com/repos/bullhorn/novo-elements/contents/{+path}","compare_url":"https://api.github.com/repos/bullhorn/novo-elements/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bullhorn/novo-elements/merges","archive_url":"https://api.github.com/repos/bullhorn/novo-elements/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bullhorn/novo-elements/downloads","issues_url":"https://api.github.com/repos/bullhorn/novo-elements/issues{/number}","pulls_url":"https://api.github.com/repos/bullhorn/novo-elements/pulls{/number}","milestones_url":"https://api.github.com/repos/bullhorn/novo-elements/milestones{/number}","notifications_url":"https://api.github.com/repos/bullhorn/novo-elements/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bullhorn/novo-elements/labels{/name}","releases_url":"https://api.github.com/repos/bullhorn/novo-elements/releases{/id}","deployments_url":"https://api.github.com/repos/bullhorn/novo-elements/deployments","created_at":"2016-04-17T19:00:11Z","updated_at":"2018-08-15T13:30:43Z","pushed_at":"2018-08-15T13:57:17Z","git_url":"git://github.com/bullhorn/novo-elements.git","ssh_url":"git@github.com:bullhorn/novo-elements.git","clone_url":"https://github.com/bullhorn/novo-elements.git","svn_url":"https://github.com/bullhorn/novo-elements","homepage":"http://bullhorn.github.io/novo-elements","size":42555,"stargazers_count":45,"watchers_count":45,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":33,"mirror_url":null,"archived":false,"open_issues_count":37,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":33,"open_issues":37,"watchers":45,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bullhorn/novo-elements/pulls/784"},"html":{"href":"https://github.com/bullhorn/novo-elements/pull/784"},"issue":{"href":"https://api.github.com/repos/bullhorn/novo-elements/issues/784"},"comments":{"href":"https://api.github.com/repos/bullhorn/novo-elements/issues/784/comments"},"review_comments":{"href":"https://api.github.com/repos/bullhorn/novo-elements/pulls/784/comments"},"review_comment":{"href":"https://api.github.com/repos/bullhorn/novo-elements/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bullhorn/novo-elements/pulls/784/commits"},"statuses":{"href":"https://api.github.com/repos/bullhorn/novo-elements/statuses/87343bcc7cff93b6a98a0af2f5132bfe1cdc8d03"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jgodi","id":870799,"node_id":"MDQ6VXNlcjg3MDc5OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/870799?v=4","gravatar_id":"","url":"https://api.github.com/users/jgodi","html_url":"https://github.com/jgodi","followers_url":"https://api.github.com/users/jgodi/followers","following_url":"https://api.github.com/users/jgodi/following{/other_user}","gists_url":"https://api.github.com/users/jgodi/gists{/gist_id}","starred_url":"https://api.github.com/users/jgodi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgodi/subscriptions","organizations_url":"https://api.github.com/users/jgodi/orgs","repos_url":"https://api.github.com/users/jgodi/repos","events_url":"https://api.github.com/users/jgodi/events{/privacy}","received_events_url":"https://api.github.com/users/jgodi/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":3,"deletions":3,"changed_files":2}}
{"actor":{"display_login":"jgodi"}}