{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/project-system/pulls/comments/241604868","pull_request_review_id":184922277,"id":241604868,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTYwNDg2OA==","diff_hunk":"@@ -2,52 +2,48 @@\n \n using System.Collections.Generic;\n using System.Threading.Tasks;\n-using Microsoft.Build.Construction;\n using Microsoft.VisualStudio.ProjectSystem.Properties;\n \n namespace Microsoft.VisualStudio.ProjectSystem.VS.Properties.InterceptedProjectProperties\n {\n     internal abstract partial class AbstractBuildEventValueProvider : InterceptingPropertyValueProviderBase\n     {\n-        private readonly IProjectLockService _projectLockService;\n+        private readonly IProjectAccessor _projectAccessor;\n         private readonly UnconfiguredProject _unconfiguredProject;\n+        private readonly IProjectThreadingService _threadingService;\n         private readonly AbstractBuildEventHelper _helper;\n \n         protected AbstractBuildEventValueProvider(\n-            IProjectLockService projectLockService,\n+            IProjectAccessor projectAccessor,\n             UnconfiguredProject project,\n+            IProjectThreadingService threadingService,\n             AbstractBuildEventHelper helper)\n         {\n-            _projectLockService = projectLockService;\n+            _projectAccessor = projectAccessor;\n             _unconfiguredProject = project;\n+            _threadingService = threadingService;\n             _helper = helper;\n         }\n \n         public override Task<string> OnGetEvaluatedPropertyValueAsync(\n             string evaluatedPropertyValue,\n             IProjectProperties defaultProperties)\n         {\n-#pragma warning disable RS0030 // symbol IProjectLockService is banned\n-            return _projectLockService.ReadLockAsync(async access =>\n+            return _projectAccessor.OpenProjectXmlForReadAsync(_unconfiguredProject, projectXml =>\n             {\n-                ProjectRootElement projectXml = await access.GetProjectXmlAsync(_unconfiguredProject.FullPath);\n-                return await _helper.GetPropertyAsync(projectXml, defaultProperties);\n+                return _threadingService.ExecuteSynchronously(() => _helper.GetPropertyAsync(projectXml, defaultProperties));\n             });\n-#pragma warning restore RS0030 // symbol IProjectLockService is banned\n         }\n \n         public override async Task<string> OnSetPropertyValueAsync(\n             string unevaluatedPropertyValue,\n             IProjectProperties defaultProperties,\n             IReadOnlyDictionary<string, string> dimensionalConditions = null)\n         {\n-#pragma warning disable RS0030 // symbol IProjectLockService is banned\n-            await _projectLockService.WriteLockAsync(async access =>\n+            await _projectAccessor.OpenProjectXmlForWriteAsync(_unconfiguredProject, projectXml =>\n             {\n-                ProjectRootElement projectXml = await access.GetProjectXmlAsync(_unconfiguredProject.FullPath);\n-                await _helper.SetPropertyAsync(unevaluatedPropertyValue, defaultProperties, projectXml);\n+                _threadingService.ExecuteSynchronously(() => _helper.SetPropertyAsync(unevaluatedPropertyValue, defaultProperties, projectXml));","path":"src/Microsoft.VisualStudio.ProjectSystem.Managed.VS/ProjectSystem/VS/Properties/InterceptedProjectProperties/AbstractBuildEventValueProvider.cs","position":57,"original_position":57,"commit_id":"d5946c34a06c4a6b2328f4ca4f8728219e1723df","original_commit_id":"d5946c34a06c4a6b2328f4ca4f8728219e1723df","user":{"login":"davidwengier","id":754264,"node_id":"MDQ6VXNlcjc1NDI2NA==","avatar_url":"https://avatars3.githubusercontent.com/u/754264?v=4","gravatar_id":"","url":"https://api.github.com/users/davidwengier","html_url":"https://github.com/davidwengier","followers_url":"https://api.github.com/users/davidwengier/followers","following_url":"https://api.github.com/users/davidwengier/following{/other_user}","gists_url":"https://api.github.com/users/davidwengier/gists{/gist_id}","starred_url":"https://api.github.com/users/davidwengier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidwengier/subscriptions","organizations_url":"https://api.github.com/users/davidwengier/orgs","repos_url":"https://api.github.com/users/davidwengier/repos","events_url":"https://api.github.com/users/davidwengier/events{/privacy}","received_events_url":"https://api.github.com/users/davidwengier/received_events","type":"User","site_admin":false},"body":"> Also, what's the difference between ExecuteSynchronously and JTF.Run?\r\n\r\n[Nothing](https://devdiv.visualstudio.com/DevDiv/_git/CPS?path=%2Fsrc%2FMicrosoft.VisualStudio.ProjectSystem.Implementation%2FProjectServices%2FProjectMultiThreadedService.cs&version=GBmaster&line=144&lineStyle=plain&lineEnd=149&lineStartColumn=1&lineEndColumn=1)","created_at":"2018-12-13T23:56:55Z","updated_at":"2018-12-13T23:56:56Z","html_url":"https://github.com/dotnet/project-system/pull/4385#discussion_r241604868","pull_request_url":"https://api.github.com/repos/dotnet/project-system/pulls/4385","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dotnet/project-system/pulls/comments/241604868"},"html":{"href":"https://github.com/dotnet/project-system/pull/4385#discussion_r241604868"},"pull_request":{"href":"https://api.github.com/repos/dotnet/project-system/pulls/4385"}},"in_reply_to_id":241600065},"pull_request":{"url":"https://api.github.com/repos/dotnet/project-system/pulls/4385","id":238566219,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4NTY2MjE5","html_url":"https://github.com/dotnet/project-system/pull/4385","diff_url":"https://github.com/dotnet/project-system/pull/4385.diff","patch_url":"https://github.com/dotnet/project-system/pull/4385.patch","issue_url":"https://api.github.com/repos/dotnet/project-system/issues/4385","number":4385,"state":"open","locked":false,"title":"remove use of `IProjectLockService` in favor of `IProjectAccessor`","user":{"login":"jmarolf","id":9797472,"node_id":"MDQ6VXNlcjk3OTc0NzI=","avatar_url":"https://avatars2.githubusercontent.com/u/9797472?v=4","gravatar_id":"","url":"https://api.github.com/users/jmarolf","html_url":"https://github.com/jmarolf","followers_url":"https://api.github.com/users/jmarolf/followers","following_url":"https://api.github.com/users/jmarolf/following{/other_user}","gists_url":"https://api.github.com/users/jmarolf/gists{/gist_id}","starred_url":"https://api.github.com/users/jmarolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmarolf/subscriptions","organizations_url":"https://api.github.com/users/jmarolf/orgs","repos_url":"https://api.github.com/users/jmarolf/repos","events_url":"https://api.github.com/users/jmarolf/events{/privacy}","received_events_url":"https://api.github.com/users/jmarolf/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-12-13T23:29:38Z","updated_at":"2018-12-13T23:56:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5360c0c6256ce177f6d9808a3382017cafa23d58","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/project-system/pulls/4385/commits","review_comments_url":"https://api.github.com/repos/dotnet/project-system/pulls/4385/comments","review_comment_url":"https://api.github.com/repos/dotnet/project-system/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/project-system/issues/4385/comments","statuses_url":"https://api.github.com/repos/dotnet/project-system/statuses/d5946c34a06c4a6b2328f4ca4f8728219e1723df","head":{"label":"jmarolf:do-not-use-IProjectLockService","ref":"do-not-use-IProjectLockService","sha":"d5946c34a06c4a6b2328f4ca4f8728219e1723df","user":{"login":"jmarolf","id":9797472,"node_id":"MDQ6VXNlcjk3OTc0NzI=","avatar_url":"https://avatars2.githubusercontent.com/u/9797472?v=4","gravatar_id":"","url":"https://api.github.com/users/jmarolf","html_url":"https://github.com/jmarolf","followers_url":"https://api.github.com/users/jmarolf/followers","following_url":"https://api.github.com/users/jmarolf/following{/other_user}","gists_url":"https://api.github.com/users/jmarolf/gists{/gist_id}","starred_url":"https://api.github.com/users/jmarolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmarolf/subscriptions","organizations_url":"https://api.github.com/users/jmarolf/orgs","repos_url":"https://api.github.com/users/jmarolf/repos","events_url":"https://api.github.com/users/jmarolf/events{/privacy}","received_events_url":"https://api.github.com/users/jmarolf/received_events","type":"User","site_admin":false},"repo":{"id":67172674,"node_id":"MDEwOlJlcG9zaXRvcnk2NzE3MjY3NA==","name":"project-system","full_name":"jmarolf/project-system","private":false,"owner":{"login":"jmarolf","id":9797472,"node_id":"MDQ6VXNlcjk3OTc0NzI=","avatar_url":"https://avatars2.githubusercontent.com/u/9797472?v=4","gravatar_id":"","url":"https://api.github.com/users/jmarolf","html_url":"https://github.com/jmarolf","followers_url":"https://api.github.com/users/jmarolf/followers","following_url":"https://api.github.com/users/jmarolf/following{/other_user}","gists_url":"https://api.github.com/users/jmarolf/gists{/gist_id}","starred_url":"https://api.github.com/users/jmarolf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmarolf/subscriptions","organizations_url":"https://api.github.com/users/jmarolf/orgs","repos_url":"https://api.github.com/users/jmarolf/repos","events_url":"https://api.github.com/users/jmarolf/events{/privacy}","received_events_url":"https://api.github.com/users/jmarolf/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jmarolf/project-system","description":"The C# and Visual Basic project system for Visual Studio \"15\"","fork":true,"url":"https://api.github.com/repos/jmarolf/project-system","forks_url":"https://api.github.com/repos/jmarolf/project-system/forks","keys_url":"https://api.github.com/repos/jmarolf/project-system/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmarolf/project-system/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmarolf/project-system/teams","hooks_url":"https://api.github.com/repos/jmarolf/project-system/hooks","issue_events_url":"https://api.github.com/repos/jmarolf/project-system/issues/events{/number}","events_url":"https://api.github.com/repos/jmarolf/project-system/events","assignees_url":"https://api.github.com/repos/jmarolf/project-system/assignees{/user}","branches_url":"https://api.github.com/repos/jmarolf/project-system/branches{/branch}","tags_url":"https://api.github.com/repos/jmarolf/project-system/tags","blobs_url":"https://api.github.com/repos/jmarolf/project-system/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmarolf/project-system/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmarolf/project-system/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmarolf/project-system/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmarolf/project-system/statuses/{sha}","languages_url":"https://api.github.com/repos/jmarolf/project-system/languages","stargazers_url":"https://api.github.com/repos/jmarolf/project-system/stargazers","contributors_url":"https://api.github.com/repos/jmarolf/project-system/contributors","subscribers_url":"https://api.github.com/repos/jmarolf/project-system/subscribers","subscription_url":"https://api.github.com/repos/jmarolf/project-system/subscription","commits_url":"https://api.github.com/repos/jmarolf/project-system/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmarolf/project-system/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmarolf/project-system/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmarolf/project-system/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmarolf/project-system/contents/{+path}","compare_url":"https://api.github.com/repos/jmarolf/project-system/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmarolf/project-system/merges","archive_url":"https://api.github.com/repos/jmarolf/project-system/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmarolf/project-system/downloads","issues_url":"https://api.github.com/repos/jmarolf/project-system/issues{/number}","pulls_url":"https://api.github.com/repos/jmarolf/project-system/pulls{/number}","milestones_url":"https://api.github.com/repos/jmarolf/project-system/milestones{/number}","notifications_url":"https://api.github.com/repos/jmarolf/project-system/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmarolf/project-system/labels{/name}","releases_url":"https://api.github.com/repos/jmarolf/project-system/releases{/id}","deployments_url":"https://api.github.com/repos/jmarolf/project-system/deployments","created_at":"2016-09-01T23:09:12Z","updated_at":"2018-11-12T17:57:49Z","pushed_at":"2018-12-13T23:29:17Z","git_url":"git://github.com/jmarolf/project-system.git","ssh_url":"git@github.com:jmarolf/project-system.git","clone_url":"https://github.com/jmarolf/project-system.git","svn_url":"https://github.com/jmarolf/project-system","homepage":null,"size":22623,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"81492404fee8a9e9a53f07ed68958836e3d1a0f0","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":56740275,"node_id":"MDEwOlJlcG9zaXRvcnk1Njc0MDI3NQ==","name":"project-system","full_name":"dotnet/project-system","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/project-system","description":"The C#, F# and Visual Basic project system for Visual Studio","fork":false,"url":"https://api.github.com/repos/dotnet/project-system","forks_url":"https://api.github.com/repos/dotnet/project-system/forks","keys_url":"https://api.github.com/repos/dotnet/project-system/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/project-system/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/project-system/teams","hooks_url":"https://api.github.com/repos/dotnet/project-system/hooks","issue_events_url":"https://api.github.com/repos/dotnet/project-system/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/project-system/events","assignees_url":"https://api.github.com/repos/dotnet/project-system/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/project-system/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/project-system/tags","blobs_url":"https://api.github.com/repos/dotnet/project-system/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/project-system/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/project-system/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/project-system/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/project-system/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/project-system/languages","stargazers_url":"https://api.github.com/repos/dotnet/project-system/stargazers","contributors_url":"https://api.github.com/repos/dotnet/project-system/contributors","subscribers_url":"https://api.github.com/repos/dotnet/project-system/subscribers","subscription_url":"https://api.github.com/repos/dotnet/project-system/subscription","commits_url":"https://api.github.com/repos/dotnet/project-system/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/project-system/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/project-system/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/project-system/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/project-system/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/project-system/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/project-system/merges","archive_url":"https://api.github.com/repos/dotnet/project-system/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/project-system/downloads","issues_url":"https://api.github.com/repos/dotnet/project-system/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/project-system/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/project-system/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/project-system/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/project-system/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/project-system/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/project-system/deployments","created_at":"2016-04-21T03:40:18Z","updated_at":"2018-12-13T23:21:45Z","pushed_at":"2018-12-13T23:29:38Z","git_url":"git://github.com/dotnet/project-system.git","ssh_url":"git@github.com:dotnet/project-system.git","clone_url":"https://github.com/dotnet/project-system.git","svn_url":"https://github.com/dotnet/project-system","homepage":"","size":22702,"stargazers_count":461,"watchers_count":461,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":147,"mirror_url":null,"archived":false,"open_issues_count":599,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":147,"open_issues":599,"watchers":461,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/project-system/pulls/4385"},"html":{"href":"https://github.com/dotnet/project-system/pull/4385"},"issue":{"href":"https://api.github.com/repos/dotnet/project-system/issues/4385"},"comments":{"href":"https://api.github.com/repos/dotnet/project-system/issues/4385/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/project-system/pulls/4385/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/project-system/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/project-system/pulls/4385/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/project-system/statuses/d5946c34a06c4a6b2328f4ca4f8728219e1723df"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"davidwengier"}}