{"action":"created","issue":{"url":"https://api.github.com/repos/Evolveum/midpoint/issues/70","repository_url":"https://api.github.com/repos/Evolveum/midpoint","labels_url":"https://api.github.com/repos/Evolveum/midpoint/issues/70/labels{/name}","comments_url":"https://api.github.com/repos/Evolveum/midpoint/issues/70/comments","events_url":"https://api.github.com/repos/Evolveum/midpoint/issues/70/events","html_url":"https://github.com/Evolveum/midpoint/pull/70","id":302269169,"number":70,"title":"Style Guidelines - Implement checkstyle maven plugin","user":{"login":"mmoayyed","id":1205228,"avatar_url":"https://avatars1.githubusercontent.com/u/1205228?v=4","gravatar_id":"","url":"https://api.github.com/users/mmoayyed","html_url":"https://github.com/mmoayyed","followers_url":"https://api.github.com/users/mmoayyed/followers","following_url":"https://api.github.com/users/mmoayyed/following{/other_user}","gists_url":"https://api.github.com/users/mmoayyed/gists{/gist_id}","starred_url":"https://api.github.com/users/mmoayyed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mmoayyed/subscriptions","organizations_url":"https://api.github.com/users/mmoayyed/orgs","repos_url":"https://api.github.com/users/mmoayyed/repos","events_url":"https://api.github.com/users/mmoayyed/events{/privacy}","received_events_url":"https://api.github.com/users/mmoayyed/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-05T11:44:15Z","updated_at":"2018-03-05T11:58:09Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/Evolveum/midpoint/pulls/70","html_url":"https://github.com/Evolveum/midpoint/pull/70","diff_url":"https://github.com/Evolveum/midpoint/pull/70.diff","patch_url":"https://github.com/Evolveum/midpoint/pull/70.patch"},"body":"Provide a basic styling guide for the codebase that for now treats most issues warnings but enforces a handful of rules around imports. Can be run as:\r\n\r\n```bash\r\nmvn checkstyle:check -Dcheckstyle.skip=false -Dcheckstyle.config.location=/path/to/midpoint/checkstyle-rules.xml -Dcheckstyle.suppressions.location=/path/to/midpoint/checkstyle-suppressions.xml\r\n```\r\n\r\nA number of warnings are also fixed as part of this PR. \r\n\r\nAs follow-up work, it would be great to standardize the usage tabs vs spaces and have the plugin enforce this rule for future reference to provide easier formatting and reviews when future PRs are posted."},"comment":{"url":"https://api.github.com/repos/Evolveum/midpoint/issues/comments/370397352","html_url":"https://github.com/Evolveum/midpoint/pull/70#issuecomment-370397352","issue_url":"https://api.github.com/repos/Evolveum/midpoint/issues/70","id":370397352,"user":{"login":"semancik","id":6285618,"avatar_url":"https://avatars3.githubusercontent.com/u/6285618?v=4","gravatar_id":"","url":"https://api.github.com/users/semancik","html_url":"https://github.com/semancik","followers_url":"https://api.github.com/users/semancik/followers","following_url":"https://api.github.com/users/semancik/following{/other_user}","gists_url":"https://api.github.com/users/semancik/gists{/gist_id}","starred_url":"https://api.github.com/users/semancik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/semancik/subscriptions","organizations_url":"https://api.github.com/users/semancik/orgs","repos_url":"https://api.github.com/users/semancik/repos","events_url":"https://api.github.com/users/semancik/events{/privacy}","received_events_url":"https://api.github.com/users/semancik/received_events","type":"User","site_admin":false},"created_at":"2018-03-05T11:58:09Z","updated_at":"2018-03-05T11:58:09Z","author_association":"OWNER","body":"Oh, checkstyle. We need to be careful with this one. I personally hate checkstyle. It makes contributions (and even a lot of day-to-day work) unnecessarily painful. Checkstyle rules lead to overuse of automatic code formatters which (paradoxically) leads to unreadable code.\r\nOn the other hand, we need to do something about formatting, especially whitespace. For now we have endorsed tabs. But it looks like space indentation would suit us be better. So, we will switch to that. But we need to plan that carefully. Otherwise we get into support nightmares (e.g. unable to cleanly backport bugfixes)."}}
{"actor":{"display_login":"semancik"}}