{"action":"created","issue":{"url":"https://api.github.com/repos/crossbario/crossbar/issues/1406","repository_url":"https://api.github.com/repos/crossbario/crossbar","labels_url":"https://api.github.com/repos/crossbario/crossbar/issues/1406/labels{/name}","comments_url":"https://api.github.com/repos/crossbario/crossbar/issues/1406/comments","events_url":"https://api.github.com/repos/crossbario/crossbar/issues/1406/events","html_url":"https://github.com/crossbario/crossbar/pull/1406","id":364085323,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4MzU3OTcz","number":1406,"title":"requirements-min.txt: remove idna.","user":{"login":"asafkahlon","id":35964924,"node_id":"MDQ6VXNlcjM1OTY0OTI0","avatar_url":"https://avatars0.githubusercontent.com/u/35964924?v=4","gravatar_id":"","url":"https://api.github.com/users/asafkahlon","html_url":"https://github.com/asafkahlon","followers_url":"https://api.github.com/users/asafkahlon/followers","following_url":"https://api.github.com/users/asafkahlon/following{/other_user}","gists_url":"https://api.github.com/users/asafkahlon/gists{/gist_id}","starred_url":"https://api.github.com/users/asafkahlon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asafkahlon/subscriptions","organizations_url":"https://api.github.com/users/asafkahlon/orgs","repos_url":"https://api.github.com/users/asafkahlon/repos","events_url":"https://api.github.com/users/asafkahlon/events{/privacy}","received_events_url":"https://api.github.com/users/asafkahlon/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-09-26T15:20:26Z","updated_at":"2018-10-19T05:32:22Z","closed_at":"2018-10-19T05:32:22Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/crossbario/crossbar/pulls/1406","html_url":"https://github.com/crossbario/crossbar/pull/1406","diff_url":"https://github.com/crossbario/crossbar/pull/1406.diff","patch_url":"https://github.com/crossbario/crossbar/pull/1406.patch"},"body":"A short \"git grep idna\" shows there's no direct use in idna\r\nin crossbar.\r\n\r\nSigned-off-by: Asaf Kahlon <asafka7@gmail.com>"},"comment":{"url":"https://api.github.com/repos/crossbario/crossbar/issues/comments/431249596","html_url":"https://github.com/crossbario/crossbar/pull/1406#issuecomment-431249596","issue_url":"https://api.github.com/repos/crossbario/crossbar/issues/1406","id":431249596,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMTI0OTU5Ng==","user":{"login":"oberstet","id":233340,"node_id":"MDQ6VXNlcjIzMzM0MA==","avatar_url":"https://avatars3.githubusercontent.com/u/233340?v=4","gravatar_id":"","url":"https://api.github.com/users/oberstet","html_url":"https://github.com/oberstet","followers_url":"https://api.github.com/users/oberstet/followers","following_url":"https://api.github.com/users/oberstet/following{/other_user}","gists_url":"https://api.github.com/users/oberstet/gists{/gist_id}","starred_url":"https://api.github.com/users/oberstet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oberstet/subscriptions","organizations_url":"https://api.github.com/users/oberstet/orgs","repos_url":"https://api.github.com/users/oberstet/repos","events_url":"https://api.github.com/users/oberstet/events{/privacy}","received_events_url":"https://api.github.com/users/oberstet/received_events","type":"User","site_admin":false},"created_at":"2018-10-19T05:32:22Z","updated_at":"2018-10-19T05:32:22Z","author_association":"MEMBER","body":"this is a recommended depdendency for use of TLS with Twisted. pls see the note here https://twisted.readthedocs.io/en/twisted-18.7.0/core/howto/ssl.html#connecting-to-public-servers\r\n\r\n> To properly validate your hostname parameter according to RFC6125, please also install the “service_identity” and “idna” packages from PyPI. Without this package, Twisted will currently make a conservative guess as to the correctness of the server’s certificate, but this will reject a large number of potentially valid certificates. service_identity implements the standard correctly and it will be a required dependency for TLS in a future release of Twisted."}}
{"actor":{"display_login":"oberstet"}}