{"action":"created","issue":{"url":"https://api.github.com/repos/rust-lang/rust/issues/53686","repository_url":"https://api.github.com/repos/rust-lang/rust","labels_url":"https://api.github.com/repos/rust-lang/rust/issues/53686/labels{/name}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/53686/comments","events_url":"https://api.github.com/repos/rust-lang/rust/issues/53686/events","html_url":"https://github.com/rust-lang/rust/issues/53686","id":353935280,"node_id":"MDU6SXNzdWUzNTM5MzUyODA=","number":53686,"title":"Macro invocations bypass new keyword identifier checks","user":{"login":"alexcrichton","id":64996,"node_id":"MDQ6VXNlcjY0OTk2","avatar_url":"https://avatars1.githubusercontent.com/u/64996?v=4","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"labels":[{"id":980999956,"node_id":"MDU6TGFiZWw5ODA5OTk5NTY=","url":"https://api.github.com/repos/rust-lang/rust/labels/A-edition-2018-lints","name":"A-edition-2018-lints","color":"d7e102","default":false},{"id":930400927,"node_id":"MDU6TGFiZWw5MzA0MDA5Mjc=","url":"https://api.github.com/repos/rust-lang/rust/labels/A-rust-2018-preview","name":"A-rust-2018-preview","color":"d7e102","default":false},{"id":31942528,"node_id":"MDU6TGFiZWwzMTk0MjUyOA==","url":"https://api.github.com/repos/rust-lang/rust/labels/I-nominated","name":"I-nominated","color":"e10c02","default":false},{"id":203429200,"node_id":"MDU6TGFiZWwyMDM0MjkyMDA=","url":"https://api.github.com/repos/rust-lang/rust/labels/P-high","name":"P-high","color":"eb6420","default":false},{"id":211668100,"node_id":"MDU6TGFiZWwyMTE2NjgxMDA=","url":"https://api.github.com/repos/rust-lang/rust/labels/T-compiler","name":"T-compiler","color":"bfd4f2","default":false},{"id":211668019,"node_id":"MDU6TGFiZWwyMTE2NjgwMTk=","url":"https://api.github.com/repos/rust-lang/rust/labels/T-lang","name":"T-lang","color":"bfd4f2","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/rust-lang/rust/milestones/54","html_url":"https://github.com/rust-lang/rust/milestone/54","labels_url":"https://api.github.com/repos/rust-lang/rust/milestones/54/labels","id":3463305,"node_id":"MDk6TWlsZXN0b25lMzQ2MzMwNQ==","number":54,"title":"Rust 2018 RC","description":"See https://internals.rust-lang.org/t/rust-2018-the-home-stretch/7810","creator":{"login":"nikomatsakis","id":155238,"node_id":"MDQ6VXNlcjE1NTIzOA==","avatar_url":"https://avatars0.githubusercontent.com/u/155238?v=4","gravatar_id":"","url":"https://api.github.com/users/nikomatsakis","html_url":"https://github.com/nikomatsakis","followers_url":"https://api.github.com/users/nikomatsakis/followers","following_url":"https://api.github.com/users/nikomatsakis/following{/other_user}","gists_url":"https://api.github.com/users/nikomatsakis/gists{/gist_id}","starred_url":"https://api.github.com/users/nikomatsakis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikomatsakis/subscriptions","organizations_url":"https://api.github.com/users/nikomatsakis/orgs","repos_url":"https://api.github.com/users/nikomatsakis/repos","events_url":"https://api.github.com/users/nikomatsakis/events{/privacy}","received_events_url":"https://api.github.com/users/nikomatsakis/received_events","type":"User","site_admin":false},"open_issues":49,"closed_issues":42,"state":"open","created_at":"2018-06-29T18:51:29Z","updated_at":"2018-08-24T21:47:44Z","due_on":"2018-09-13T07:00:00Z","closed_at":null},"comments":6,"created_at":"2018-08-24T21:34:39Z","updated_at":"2018-08-25T05:27:34Z","closed_at":null,"author_association":"MEMBER","body":"This code currently compiles on nightly:\r\n\r\n```rust\r\n#![warn(rust_2018_compatibility)]\r\n#![feature(rust_2018_preview)]\r\n\r\nmacro_rules! r#async {\r\n    () => ()\r\n}\r\n\r\nfn main() {\r\n    async!();\r\n}\r\n```\r\n\r\n.. with no warnings, but it should get a warning about the macro invocation!\r\n\r\ncc @zackmdavis, do you know if there's a good location we can run lints before macro expansion? I think the bug here is that the macro is fully expanded by the time we hit the lint passes, so it's not even present in the AST."},"comment":{"url":"https://api.github.com/repos/rust-lang/rust/issues/comments/415939208","html_url":"https://github.com/rust-lang/rust/issues/53686#issuecomment-415939208","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/53686","id":415939208,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNTkzOTIwOA==","user":{"login":"Centril","id":855702,"node_id":"MDQ6VXNlcjg1NTcwMg==","avatar_url":"https://avatars2.githubusercontent.com/u/855702?v=4","gravatar_id":"","url":"https://api.github.com/users/Centril","html_url":"https://github.com/Centril","followers_url":"https://api.github.com/users/Centril/followers","following_url":"https://api.github.com/users/Centril/following{/other_user}","gists_url":"https://api.github.com/users/Centril/gists{/gist_id}","starred_url":"https://api.github.com/users/Centril/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Centril/subscriptions","organizations_url":"https://api.github.com/users/Centril/orgs","repos_url":"https://api.github.com/users/Centril/repos","events_url":"https://api.github.com/users/Centril/events{/privacy}","received_events_url":"https://api.github.com/users/Centril/received_events","type":"User","site_admin":false},"created_at":"2018-08-25T05:27:34Z","updated_at":"2018-08-25T05:27:34Z","author_association":"CONTRIBUTOR","body":"@eddyb I mean, that's what the choice before us is. We can make `try!(..)` work in Rust 2018 if we want technically, can't we?\r\n\r\n+ I agree that not allowing `try!(..)` would be consistent thing to do.\r\n+ On the other hand, we might want to reduce breakage.\r\n+ However, another point is that it might be beneficial to break `try!(expr)` as further encouragement in favor of `expr?` and rustfix people towards the latter.\r\n\r\nThere's arguments in favor of and against each choice here. 🤔"}}
{"actor":{"display_login":"Centril"}}