{"action":"opened","issue":{"url":"https://api.github.com/repos/mhart/kinesalite/issues/70","repository_url":"https://api.github.com/repos/mhart/kinesalite","labels_url":"https://api.github.com/repos/mhart/kinesalite/issues/70/labels{/name}","comments_url":"https://api.github.com/repos/mhart/kinesalite/issues/70/comments","events_url":"https://api.github.com/repos/mhart/kinesalite/issues/70/events","html_url":"https://github.com/mhart/kinesalite/issues/70","id":324211492,"number":70,"title":"getShardIterator expects seconds, should expect milliseconds","user":{"login":"chody-h","id":4218016,"avatar_url":"https://avatars3.githubusercontent.com/u/4218016?v=4","gravatar_id":"","url":"https://api.github.com/users/chody-h","html_url":"https://github.com/chody-h","followers_url":"https://api.github.com/users/chody-h/followers","following_url":"https://api.github.com/users/chody-h/following{/other_user}","gists_url":"https://api.github.com/users/chody-h/gists{/gist_id}","starred_url":"https://api.github.com/users/chody-h/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chody-h/subscriptions","organizations_url":"https://api.github.com/users/chody-h/orgs","repos_url":"https://api.github.com/users/chody-h/repos","events_url":"https://api.github.com/users/chody-h/events{/privacy}","received_events_url":"https://api.github.com/users/chody-h/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-17T22:45:11Z","updated_at":"2018-05-17T22:45:11Z","closed_at":null,"author_association":"NONE","body":"The Kinesis docs specify that the parameter of the `getShardIterator` call using the `\"AT_TIMESTAMP\"` ShardIteratorType should be a timestamp in milliseconds. However, the Kinesalite server [multiplies the supplied parameter by 1000](https://github.com/mhart/kinesalite/blob/master/actions/getShardIterator.js#L84). Since it is expecting milliseconds, there is no need to multiply.\r\n\r\nThis should be a simple fix: remove line 84 in getShardIterator.js and touch up the corresponding unit tests. If you agree, I'd love to get a pull request in for you to take a look at."}}
{"actor":{"display_login":"chody-h"}}