{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/pulls/comments/171771894","pull_request_review_id":100684331,"id":171771894,"diff_hunk":"@@ -104,6 +105,89 @@ export class DebugSession implements IDebugSession {\n         });\r\n     }\r\n \r\n+    /**\r\n+     * In attach mode, the user should choose the running pod first, then the debugger will attach to it.\r\n+     *\r\n+     * @param workspaceFolder the active workspace folder.\r\n+     * @param pod the target pod name.\r\n+     */\r\n+    public async attach(workspaceFolder: vscode.WorkspaceFolder, pod?: string): Promise<void> {\r\n+        if (!workspaceFolder) {\r\n+            return;\r\n+        }\r\n+\r\n+        // Select the image type to attach.\r\n+        this.debugProvider = await providerRegistry.getDebugProvider();\r","path":"src/debug/debugSession.ts","position":24,"original_position":24,"commit_id":"1b5cb321192d0d90c9b01fc7540eb50f1e344959","original_commit_id":"1b5cb321192d0d90c9b01fc7540eb50f1e344959","user":{"login":"akaroml","id":16755094,"avatar_url":"https://avatars2.githubusercontent.com/u/16755094?v=4","gravatar_id":"","url":"https://api.github.com/users/akaroml","html_url":"https://github.com/akaroml","followers_url":"https://api.github.com/users/akaroml/followers","following_url":"https://api.github.com/users/akaroml/following{/other_user}","gists_url":"https://api.github.com/users/akaroml/gists{/gist_id}","starred_url":"https://api.github.com/users/akaroml/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akaroml/subscriptions","organizations_url":"https://api.github.com/users/akaroml/orgs","repos_url":"https://api.github.com/users/akaroml/repos","events_url":"https://api.github.com/users/akaroml/events{/privacy}","received_events_url":"https://api.github.com/users/akaroml/received_events","type":"User","site_admin":false},"body":"This block is duplicated inside `launch()`. Suggest refactoring.","created_at":"2018-03-02T06:23:03Z","updated_at":"2018-03-02T06:29:05Z","html_url":"https://github.com/Azure/vscode-kubernetes-tools/pull/64#discussion_r171771894","pull_request_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/pulls/64","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/pulls/comments/171771894"},"html":{"href":"https://github.com/Azure/vscode-kubernetes-tools/pull/64#discussion_r171771894"},"pull_request":{"href":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/pulls/64"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/pulls/64","id":172415599,"html_url":"https://github.com/Azure/vscode-kubernetes-tools/pull/64","diff_url":"https://github.com/Azure/vscode-kubernetes-tools/pull/64.diff","patch_url":"https://github.com/Azure/vscode-kubernetes-tools/pull/64.patch","issue_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/issues/64","number":64,"state":"open","locked":false,"title":"Support debug attach to a running java pod","user":{"login":"testforstephen","id":14052197,"avatar_url":"https://avatars3.githubusercontent.com/u/14052197?v=4","gravatar_id":"","url":"https://api.github.com/users/testforstephen","html_url":"https://github.com/testforstephen","followers_url":"https://api.github.com/users/testforstephen/followers","following_url":"https://api.github.com/users/testforstephen/following{/other_user}","gists_url":"https://api.github.com/users/testforstephen/gists{/gist_id}","starred_url":"https://api.github.com/users/testforstephen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/testforstephen/subscriptions","organizations_url":"https://api.github.com/users/testforstephen/orgs","repos_url":"https://api.github.com/users/testforstephen/repos","events_url":"https://api.github.com/users/testforstephen/events{/privacy}","received_events_url":"https://api.github.com/users/testforstephen/received_events","type":"User","site_admin":false},"body":"Plan to split the local debug support to several PRs for review.\r\n\r\nPR1: Define debug framework and add java debug implementation. (**merged**)\r\nPR2: Add node debug implementation.\r\n**PR3: Add debug (attach) support.**\r\nPR4: Enable the new debug framework via kubernetes commands Debug(Launch) and Debug(Attach)\r\nPR5: Support docker-compose.yml ?","created_at":"2018-03-02T03:42:37Z","updated_at":"2018-03-02T06:29:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bc5645da70c109368eeabd6e5a35a0e408b1647a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"itowlson","id":865538,"avatar_url":"https://avatars1.githubusercontent.com/u/865538?v=4","gravatar_id":"","url":"https://api.github.com/users/itowlson","html_url":"https://github.com/itowlson","followers_url":"https://api.github.com/users/itowlson/followers","following_url":"https://api.github.com/users/itowlson/following{/other_user}","gists_url":"https://api.github.com/users/itowlson/gists{/gist_id}","starred_url":"https://api.github.com/users/itowlson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/itowlson/subscriptions","organizations_url":"https://api.github.com/users/itowlson/orgs","repos_url":"https://api.github.com/users/itowlson/repos","events_url":"https://api.github.com/users/itowlson/events{/privacy}","received_events_url":"https://api.github.com/users/itowlson/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/pulls/64/commits","review_comments_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/pulls/64/comments","review_comment_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/issues/64/comments","statuses_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/statuses/1b5cb321192d0d90c9b01fc7540eb50f1e344959","head":{"label":"testforstephen:jinbo_debugattach","ref":"jinbo_debugattach","sha":"1b5cb321192d0d90c9b01fc7540eb50f1e344959","user":{"login":"testforstephen","id":14052197,"avatar_url":"https://avatars3.githubusercontent.com/u/14052197?v=4","gravatar_id":"","url":"https://api.github.com/users/testforstephen","html_url":"https://github.com/testforstephen","followers_url":"https://api.github.com/users/testforstephen/followers","following_url":"https://api.github.com/users/testforstephen/following{/other_user}","gists_url":"https://api.github.com/users/testforstephen/gists{/gist_id}","starred_url":"https://api.github.com/users/testforstephen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/testforstephen/subscriptions","organizations_url":"https://api.github.com/users/testforstephen/orgs","repos_url":"https://api.github.com/users/testforstephen/repos","events_url":"https://api.github.com/users/testforstephen/events{/privacy}","received_events_url":"https://api.github.com/users/testforstephen/received_events","type":"User","site_admin":false},"repo":{"id":115995912,"name":"vscode-kubernetes-tools","full_name":"testforstephen/vscode-kubernetes-tools","owner":{"login":"testforstephen","id":14052197,"avatar_url":"https://avatars3.githubusercontent.com/u/14052197?v=4","gravatar_id":"","url":"https://api.github.com/users/testforstephen","html_url":"https://github.com/testforstephen","followers_url":"https://api.github.com/users/testforstephen/followers","following_url":"https://api.github.com/users/testforstephen/following{/other_user}","gists_url":"https://api.github.com/users/testforstephen/gists{/gist_id}","starred_url":"https://api.github.com/users/testforstephen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/testforstephen/subscriptions","organizations_url":"https://api.github.com/users/testforstephen/orgs","repos_url":"https://api.github.com/users/testforstephen/repos","events_url":"https://api.github.com/users/testforstephen/events{/privacy}","received_events_url":"https://api.github.com/users/testforstephen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/testforstephen/vscode-kubernetes-tools","description":"Kubernetes extension for Visual Studio Code","fork":true,"url":"https://api.github.com/repos/testforstephen/vscode-kubernetes-tools","forks_url":"https://api.github.com/repos/testforstephen/vscode-kubernetes-tools/forks","keys_url":"https://api.github.com/repos/testforstephen/vscode-kubernetes-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/testforstephen/vscode-kubernetes-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/testforstephen/vscode-kubernetes-tools/teams","hooks_url":"https://api.github.com/repos/testforstephen/vscode-kubernetes-tools/hooks","issue_events_url":"https://api.github.com/repos/testforstephen/vscode-kubernetes-tools/issues/events{/number}","events_url":"https://api.github.com/repos/testforstephen/vscode-kubernetes-tools/events","assignees_url":"https://api.github.com/repos/testforstephen/vscode-kubernetes-tools/assignees{/user}","branches_url":"https://api.github.com/repos/testforstephen/vscode-kubernetes-tools/branches{/branch}","tags_url":"https://api.github.com/repos/testforstephen/vscode-kubernetes-tools/tags","blobs_url":"https://api.github.com/repos/testforstephen/vscode-kubernetes-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/testforstephen/vscode-kubernetes-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/testforstephen/vscode-kubernetes-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/testforstephen/vscode-kubernetes-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/testforstephen/vscode-kubernetes-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/testforstephen/vscode-kubernetes-tools/languages","stargazers_url":"https://api.github.com/repos/testforstephen/vscode-kubernetes-tools/stargazers","contributors_url":"https://api.github.com/repos/testforstephen/vscode-kubernetes-tools/contributors","subscribers_url":"https://api.github.com/repos/testforstephen/vscode-kubernetes-tools/subscribers","subscription_url":"https://api.github.com/repos/testforstephen/vscode-kubernetes-tools/subscription","commits_url":"https://api.github.com/repos/testforstephen/vscode-kubernetes-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/testforstephen/vscode-kubernetes-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/testforstephen/vscode-kubernetes-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/testforstephen/vscode-kubernetes-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/testforstephen/vscode-kubernetes-tools/contents/{+path}","compare_url":"https://api.github.com/repos/testforstephen/vscode-kubernetes-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/testforstephen/vscode-kubernetes-tools/merges","archive_url":"https://api.github.com/repos/testforstephen/vscode-kubernetes-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/testforstephen/vscode-kubernetes-tools/downloads","issues_url":"https://api.github.com/repos/testforstephen/vscode-kubernetes-tools/issues{/number}","pulls_url":"https://api.github.com/repos/testforstephen/vscode-kubernetes-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/testforstephen/vscode-kubernetes-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/testforstephen/vscode-kubernetes-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/testforstephen/vscode-kubernetes-tools/labels{/name}","releases_url":"https://api.github.com/repos/testforstephen/vscode-kubernetes-tools/releases{/id}","deployments_url":"https://api.github.com/repos/testforstephen/vscode-kubernetes-tools/deployments","created_at":"2018-01-02T09:04:11Z","updated_at":"2018-01-02T09:04:14Z","pushed_at":"2018-03-02T05:47:19Z","git_url":"git://github.com/testforstephen/vscode-kubernetes-tools.git","ssh_url":"git@github.com:testforstephen/vscode-kubernetes-tools.git","clone_url":"https://github.com/testforstephen/vscode-kubernetes-tools.git","svn_url":"https://github.com/testforstephen/vscode-kubernetes-tools","homepage":null,"size":365,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:master","ref":"master","sha":"c9a6b3780202b429800ae984e93a056422d4029a","user":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":98263285,"name":"vscode-kubernetes-tools","full_name":"Azure/vscode-kubernetes-tools","owner":{"login":"Azure","id":6844498,"avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/vscode-kubernetes-tools","description":"Kubernetes extension for Visual Studio Code","fork":false,"url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools","forks_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/forks","keys_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/teams","hooks_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/hooks","issue_events_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/events","assignees_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/tags","blobs_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/languages","stargazers_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/stargazers","contributors_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/contributors","subscribers_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/subscribers","subscription_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/subscription","commits_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/merges","archive_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/downloads","issues_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/labels{/name}","releases_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/deployments","created_at":"2017-07-25T04:12:07Z","updated_at":"2018-02-25T05:21:49Z","pushed_at":"2018-03-02T05:47:20Z","git_url":"git://github.com/Azure/vscode-kubernetes-tools.git","ssh_url":"git@github.com:Azure/vscode-kubernetes-tools.git","clone_url":"https://github.com/Azure/vscode-kubernetes-tools.git","svn_url":"https://github.com/Azure/vscode-kubernetes-tools","homepage":null,"size":309,"stargazers_count":26,"watchers_count":26,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":10,"open_issues":16,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/pulls/64"},"html":{"href":"https://github.com/Azure/vscode-kubernetes-tools/pull/64"},"issue":{"href":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/issues/64"},"comments":{"href":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/issues/64/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/pulls/64/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/pulls/64/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/vscode-kubernetes-tools/statuses/1b5cb321192d0d90c9b01fc7540eb50f1e344959"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"akaroml"}}