{"action":"created","comment":{"url":"https://api.github.com/repos/IntelRealSense/librealsense/pulls/comments/202605703","pull_request_review_id":137336335,"id":202605703,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjYwNTcwMw==","diff_hunk":"@@ -310,13 +683,33 @@ namespace librealsense\n \n                 byte* other_aligned_to_depth = const_cast<byte*>(aligned_frame.frame->get_frame_data());\n                 memset(other_aligned_to_depth, 0, depth_intrinsics.height * depth_intrinsics.width * aligned_bytes_per_pixel);\n+#ifdef __SSSE3__\n+                auto uid = other_frame->get_stream()->get_unique_id();","path":"src/proc/align.cpp","position":396,"original_position":396,"commit_id":"a9ecc1bf97da4ba2cdfc49653b4e81bf7181864a","original_commit_id":"a9ecc1bf97da4ba2cdfc49653b4e81bf7181864a","user":{"login":"ev-mp","id":17897861,"node_id":"MDQ6VXNlcjE3ODk3ODYx","avatar_url":"https://avatars0.githubusercontent.com/u/17897861?v=4","gravatar_id":"","url":"https://api.github.com/users/ev-mp","html_url":"https://github.com/ev-mp","followers_url":"https://api.github.com/users/ev-mp/followers","following_url":"https://api.github.com/users/ev-mp/following{/other_user}","gists_url":"https://api.github.com/users/ev-mp/gists{/gist_id}","starred_url":"https://api.github.com/users/ev-mp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ev-mp/subscriptions","organizations_url":"https://api.github.com/users/ev-mp/orgs","repos_url":"https://api.github.com/users/ev-mp/repos","events_url":"https://api.github.com/users/ev-mp/events{/privacy}","received_events_url":"https://api.github.com/users/ev-mp/received_events","type":"User","site_admin":false},"body":"Is it used ?","created_at":"2018-07-16T08:34:15Z","updated_at":"2018-07-16T08:37:16Z","html_url":"https://github.com/IntelRealSense/librealsense/pull/2040#discussion_r202605703","pull_request_url":"https://api.github.com/repos/IntelRealSense/librealsense/pulls/2040","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/IntelRealSense/librealsense/pulls/comments/202605703"},"html":{"href":"https://github.com/IntelRealSense/librealsense/pull/2040#discussion_r202605703"},"pull_request":{"href":"https://api.github.com/repos/IntelRealSense/librealsense/pulls/2040"}}},"pull_request":{"url":"https://api.github.com/repos/IntelRealSense/librealsense/pulls/2040","id":200762002,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNzYyMDAy","html_url":"https://github.com/IntelRealSense/librealsense/pull/2040","diff_url":"https://github.com/IntelRealSense/librealsense/pull/2040.diff","patch_url":"https://github.com/IntelRealSense/librealsense/pull/2040.patch","issue_url":"https://api.github.com/repos/IntelRealSense/librealsense/issues/2040","number":2040,"state":"open","locked":false,"title":"Performance optimization for Align post processing block","user":{"login":"aangerma","id":22448952,"node_id":"MDQ6VXNlcjIyNDQ4OTUy","avatar_url":"https://avatars1.githubusercontent.com/u/22448952?v=4","gravatar_id":"","url":"https://api.github.com/users/aangerma","html_url":"https://github.com/aangerma","followers_url":"https://api.github.com/users/aangerma/followers","following_url":"https://api.github.com/users/aangerma/following{/other_user}","gists_url":"https://api.github.com/users/aangerma/gists{/gist_id}","starred_url":"https://api.github.com/users/aangerma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aangerma/subscriptions","organizations_url":"https://api.github.com/users/aangerma/orgs","repos_url":"https://api.github.com/users/aangerma/repos","events_url":"https://api.github.com/users/aangerma/events{/privacy}","received_events_url":"https://api.github.com/users/aangerma/received_events","type":"User","site_admin":false},"body":"This pull-request improves latency and CPU utilization of `align` processing block.\r\nThe solution combines SSE4 optimization for Intel architecture with changes to the algorithm to reduce overhead. \r\n\r\nFollowing-up on: #1189, #1105\r\n\r\n## OS Microsoft Windows 10 Enterprise\r\nProcessor Intel(R) Core(TM) i5-5300U CPU @ 2.30GHz, 2301 Mhz, 2 Core(s), 4 Logical Processor(s)\r\n\r\n### Align depth to color\r\n\r\n\r\n  |   | **Depth 640x480** | **Depth 1280x720**\r\n-- | -- | -- | --\r\n**Color   640x480** | NAIVE  (microseconds) | 11217.4 | 26023.6\r\n | |SSE    (microseconds) | 4346.96 | 4360.56\r\nSpeedup |   | **x 2.58** | **x 5.96**\r\n**Color 1280x720** | NAIVE  (microseconds) | 14868.2 | 44311.9\r\n | |SSE     (microseconds) | 10497.1 | 8327.42\r\nSpeedup |   | **x 1.41** | **x 5.32**\r\n\r\n\r\n\r\n### Align color to depth\r\n\r\n\r\n  |   | **Color 640x480** | **Color 1280x720**\r\n-- | -- | -- | --\r\n**Depth   640x480** | NAIVE    (microseconds) | 14904.4 | 14642.8\r\n | | SSE       (microseconds) | 3454.34 | 3863.21\r\nSpeedup |   | **x 4.31** | **x 3.79**\r\n**Depth 1280x720** | NAIVE  (microseconds) | 24630.5 | 22478.8\r\n | | SSE     (microseconds) | 3218.72 | 3292.07\r\nSpeedup |   | **x 7.65** | **x 6.82**\r\n\r\n## Ubuntu   16.04\r\nIntel®   Core™ i7-6700 CPU @ 3.40GHz × 8\r\n\r\n### Align depth to color\r\n\r\n\r\n  |   | **Depth 640x480** | **Depth 1280x720**\r\n-- | -- | -- | --\r\n**Color   640x480** | NAIVE (microseconds) | 13006.9 | 19729.7\r\n | | SSE   (microseconds) | 1941.03 | 1120.02\r\nSpeedup  |   | **x 6.70** |  **x 17.61**\r\n**Color 1280x720** | NAIVE (microseconds) | 8325.66 | 21869.3\r\n | | SSE    (microseconds) | 4256.76 | 3838.1\r\nSpeedup  |   | **x 1.95** | **x 5.69**\r\n\r\n\r\n### Align color to depth\r\n\r\n\r\n  |   | Color 640x480 | Color 1280x720\r\n-- | -- | -- | --\r\n**Depth   640x480** | NAIVE (microseconds) | 14049.8 | 10048.8\r\n | | SSE    (microseconds) | 1475.04 | 1518.32\r\nSpeedup |   | **x 9.52** | **x 6.61**\r\n**Depth 1280x720** | NAIVE (microseconds) | 22304.3 | 25391.8\r\n | | SSE    (microseconds) | 1430.76 | 1526.98\r\nSpeedup |   | **x 15.58** | **x 16.62**\r\n\r\n\r\n","created_at":"2018-07-11T16:43:40Z","updated_at":"2018-07-16T08:37:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5f09d4455d7765a2d98bc6abe8ffdc57eb6cbf6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/IntelRealSense/librealsense/pulls/2040/commits","review_comments_url":"https://api.github.com/repos/IntelRealSense/librealsense/pulls/2040/comments","review_comment_url":"https://api.github.com/repos/IntelRealSense/librealsense/pulls/comments{/number}","comments_url":"https://api.github.com/repos/IntelRealSense/librealsense/issues/2040/comments","statuses_url":"https://api.github.com/repos/IntelRealSense/librealsense/statuses/a9ecc1bf97da4ba2cdfc49653b4e81bf7181864a","head":{"label":"aangerma:development","ref":"development","sha":"a9ecc1bf97da4ba2cdfc49653b4e81bf7181864a","user":{"login":"aangerma","id":22448952,"node_id":"MDQ6VXNlcjIyNDQ4OTUy","avatar_url":"https://avatars1.githubusercontent.com/u/22448952?v=4","gravatar_id":"","url":"https://api.github.com/users/aangerma","html_url":"https://github.com/aangerma","followers_url":"https://api.github.com/users/aangerma/followers","following_url":"https://api.github.com/users/aangerma/following{/other_user}","gists_url":"https://api.github.com/users/aangerma/gists{/gist_id}","starred_url":"https://api.github.com/users/aangerma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aangerma/subscriptions","organizations_url":"https://api.github.com/users/aangerma/orgs","repos_url":"https://api.github.com/users/aangerma/repos","events_url":"https://api.github.com/users/aangerma/events{/privacy}","received_events_url":"https://api.github.com/users/aangerma/received_events","type":"User","site_admin":false},"repo":{"id":103163333,"node_id":"MDEwOlJlcG9zaXRvcnkxMDMxNjMzMzM=","name":"librealsense","full_name":"aangerma/librealsense","owner":{"login":"aangerma","id":22448952,"node_id":"MDQ6VXNlcjIyNDQ4OTUy","avatar_url":"https://avatars1.githubusercontent.com/u/22448952?v=4","gravatar_id":"","url":"https://api.github.com/users/aangerma","html_url":"https://github.com/aangerma","followers_url":"https://api.github.com/users/aangerma/followers","following_url":"https://api.github.com/users/aangerma/following{/other_user}","gists_url":"https://api.github.com/users/aangerma/gists{/gist_id}","starred_url":"https://api.github.com/users/aangerma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aangerma/subscriptions","organizations_url":"https://api.github.com/users/aangerma/orgs","repos_url":"https://api.github.com/users/aangerma/repos","events_url":"https://api.github.com/users/aangerma/events{/privacy}","received_events_url":"https://api.github.com/users/aangerma/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aangerma/librealsense","description":" :camera: Cross-platform API for Intel® RealSense™ devices","fork":true,"url":"https://api.github.com/repos/aangerma/librealsense","forks_url":"https://api.github.com/repos/aangerma/librealsense/forks","keys_url":"https://api.github.com/repos/aangerma/librealsense/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aangerma/librealsense/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aangerma/librealsense/teams","hooks_url":"https://api.github.com/repos/aangerma/librealsense/hooks","issue_events_url":"https://api.github.com/repos/aangerma/librealsense/issues/events{/number}","events_url":"https://api.github.com/repos/aangerma/librealsense/events","assignees_url":"https://api.github.com/repos/aangerma/librealsense/assignees{/user}","branches_url":"https://api.github.com/repos/aangerma/librealsense/branches{/branch}","tags_url":"https://api.github.com/repos/aangerma/librealsense/tags","blobs_url":"https://api.github.com/repos/aangerma/librealsense/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aangerma/librealsense/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aangerma/librealsense/git/refs{/sha}","trees_url":"https://api.github.com/repos/aangerma/librealsense/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aangerma/librealsense/statuses/{sha}","languages_url":"https://api.github.com/repos/aangerma/librealsense/languages","stargazers_url":"https://api.github.com/repos/aangerma/librealsense/stargazers","contributors_url":"https://api.github.com/repos/aangerma/librealsense/contributors","subscribers_url":"https://api.github.com/repos/aangerma/librealsense/subscribers","subscription_url":"https://api.github.com/repos/aangerma/librealsense/subscription","commits_url":"https://api.github.com/repos/aangerma/librealsense/commits{/sha}","git_commits_url":"https://api.github.com/repos/aangerma/librealsense/git/commits{/sha}","comments_url":"https://api.github.com/repos/aangerma/librealsense/comments{/number}","issue_comment_url":"https://api.github.com/repos/aangerma/librealsense/issues/comments{/number}","contents_url":"https://api.github.com/repos/aangerma/librealsense/contents/{+path}","compare_url":"https://api.github.com/repos/aangerma/librealsense/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aangerma/librealsense/merges","archive_url":"https://api.github.com/repos/aangerma/librealsense/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aangerma/librealsense/downloads","issues_url":"https://api.github.com/repos/aangerma/librealsense/issues{/number}","pulls_url":"https://api.github.com/repos/aangerma/librealsense/pulls{/number}","milestones_url":"https://api.github.com/repos/aangerma/librealsense/milestones{/number}","notifications_url":"https://api.github.com/repos/aangerma/librealsense/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aangerma/librealsense/labels{/name}","releases_url":"https://api.github.com/repos/aangerma/librealsense/releases{/id}","deployments_url":"https://api.github.com/repos/aangerma/librealsense/deployments","created_at":"2017-09-11T16:57:33Z","updated_at":"2017-09-11T16:57:35Z","pushed_at":"2018-07-16T06:42:05Z","git_url":"git://github.com/aangerma/librealsense.git","ssh_url":"git@github.com:aangerma/librealsense.git","clone_url":"https://github.com/aangerma/librealsense.git","svn_url":"https://github.com/aangerma/librealsense","homepage":"https://communities.intel.com/community/tech/realsense","size":123484,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"IntelRealSense:development","ref":"development","sha":"3e0a8da8ac62028fbaf17faa6a4106edb5f5a096","user":{"login":"IntelRealSense","id":14095512,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDk1NTEy","avatar_url":"https://avatars0.githubusercontent.com/u/14095512?v=4","gravatar_id":"","url":"https://api.github.com/users/IntelRealSense","html_url":"https://github.com/IntelRealSense","followers_url":"https://api.github.com/users/IntelRealSense/followers","following_url":"https://api.github.com/users/IntelRealSense/following{/other_user}","gists_url":"https://api.github.com/users/IntelRealSense/gists{/gist_id}","starred_url":"https://api.github.com/users/IntelRealSense/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IntelRealSense/subscriptions","organizations_url":"https://api.github.com/users/IntelRealSense/orgs","repos_url":"https://api.github.com/users/IntelRealSense/repos","events_url":"https://api.github.com/users/IntelRealSense/events{/privacy}","received_events_url":"https://api.github.com/users/IntelRealSense/received_events","type":"Organization","site_admin":false},"repo":{"id":46374199,"node_id":"MDEwOlJlcG9zaXRvcnk0NjM3NDE5OQ==","name":"librealsense","full_name":"IntelRealSense/librealsense","owner":{"login":"IntelRealSense","id":14095512,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MDk1NTEy","avatar_url":"https://avatars0.githubusercontent.com/u/14095512?v=4","gravatar_id":"","url":"https://api.github.com/users/IntelRealSense","html_url":"https://github.com/IntelRealSense","followers_url":"https://api.github.com/users/IntelRealSense/followers","following_url":"https://api.github.com/users/IntelRealSense/following{/other_user}","gists_url":"https://api.github.com/users/IntelRealSense/gists{/gist_id}","starred_url":"https://api.github.com/users/IntelRealSense/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IntelRealSense/subscriptions","organizations_url":"https://api.github.com/users/IntelRealSense/orgs","repos_url":"https://api.github.com/users/IntelRealSense/repos","events_url":"https://api.github.com/users/IntelRealSense/events{/privacy}","received_events_url":"https://api.github.com/users/IntelRealSense/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/IntelRealSense/librealsense","description":"Intel® RealSense™ SDK","fork":false,"url":"https://api.github.com/repos/IntelRealSense/librealsense","forks_url":"https://api.github.com/repos/IntelRealSense/librealsense/forks","keys_url":"https://api.github.com/repos/IntelRealSense/librealsense/keys{/key_id}","collaborators_url":"https://api.github.com/repos/IntelRealSense/librealsense/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/IntelRealSense/librealsense/teams","hooks_url":"https://api.github.com/repos/IntelRealSense/librealsense/hooks","issue_events_url":"https://api.github.com/repos/IntelRealSense/librealsense/issues/events{/number}","events_url":"https://api.github.com/repos/IntelRealSense/librealsense/events","assignees_url":"https://api.github.com/repos/IntelRealSense/librealsense/assignees{/user}","branches_url":"https://api.github.com/repos/IntelRealSense/librealsense/branches{/branch}","tags_url":"https://api.github.com/repos/IntelRealSense/librealsense/tags","blobs_url":"https://api.github.com/repos/IntelRealSense/librealsense/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/IntelRealSense/librealsense/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/IntelRealSense/librealsense/git/refs{/sha}","trees_url":"https://api.github.com/repos/IntelRealSense/librealsense/git/trees{/sha}","statuses_url":"https://api.github.com/repos/IntelRealSense/librealsense/statuses/{sha}","languages_url":"https://api.github.com/repos/IntelRealSense/librealsense/languages","stargazers_url":"https://api.github.com/repos/IntelRealSense/librealsense/stargazers","contributors_url":"https://api.github.com/repos/IntelRealSense/librealsense/contributors","subscribers_url":"https://api.github.com/repos/IntelRealSense/librealsense/subscribers","subscription_url":"https://api.github.com/repos/IntelRealSense/librealsense/subscription","commits_url":"https://api.github.com/repos/IntelRealSense/librealsense/commits{/sha}","git_commits_url":"https://api.github.com/repos/IntelRealSense/librealsense/git/commits{/sha}","comments_url":"https://api.github.com/repos/IntelRealSense/librealsense/comments{/number}","issue_comment_url":"https://api.github.com/repos/IntelRealSense/librealsense/issues/comments{/number}","contents_url":"https://api.github.com/repos/IntelRealSense/librealsense/contents/{+path}","compare_url":"https://api.github.com/repos/IntelRealSense/librealsense/compare/{base}...{head}","merges_url":"https://api.github.com/repos/IntelRealSense/librealsense/merges","archive_url":"https://api.github.com/repos/IntelRealSense/librealsense/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/IntelRealSense/librealsense/downloads","issues_url":"https://api.github.com/repos/IntelRealSense/librealsense/issues{/number}","pulls_url":"https://api.github.com/repos/IntelRealSense/librealsense/pulls{/number}","milestones_url":"https://api.github.com/repos/IntelRealSense/librealsense/milestones{/number}","notifications_url":"https://api.github.com/repos/IntelRealSense/librealsense/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/IntelRealSense/librealsense/labels{/name}","releases_url":"https://api.github.com/repos/IntelRealSense/librealsense/releases{/id}","deployments_url":"https://api.github.com/repos/IntelRealSense/librealsense/deployments","created_at":"2015-11-17T20:42:18Z","updated_at":"2018-07-16T08:20:16Z","pushed_at":"2018-07-16T08:37:02Z","git_url":"git://github.com/IntelRealSense/librealsense.git","ssh_url":"git@github.com:IntelRealSense/librealsense.git","clone_url":"https://github.com/IntelRealSense/librealsense.git","svn_url":"https://github.com/IntelRealSense/librealsense","homepage":"https://realsense.intel.com","size":124130,"stargazers_count":1620,"watchers_count":1620,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":918,"mirror_url":null,"archived":false,"open_issues_count":157,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":918,"open_issues":157,"watchers":1620,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/IntelRealSense/librealsense/pulls/2040"},"html":{"href":"https://github.com/IntelRealSense/librealsense/pull/2040"},"issue":{"href":"https://api.github.com/repos/IntelRealSense/librealsense/issues/2040"},"comments":{"href":"https://api.github.com/repos/IntelRealSense/librealsense/issues/2040/comments"},"review_comments":{"href":"https://api.github.com/repos/IntelRealSense/librealsense/pulls/2040/comments"},"review_comment":{"href":"https://api.github.com/repos/IntelRealSense/librealsense/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/IntelRealSense/librealsense/pulls/2040/commits"},"statuses":{"href":"https://api.github.com/repos/IntelRealSense/librealsense/statuses/a9ecc1bf97da4ba2cdfc49653b4e81bf7181864a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ev-mp"}}