{"action":"created","issue":{"url":"https://api.github.com/repos/Polymer/lit-html/issues/229","repository_url":"https://api.github.com/repos/Polymer/lit-html","labels_url":"https://api.github.com/repos/Polymer/lit-html/issues/229/labels{/name}","comments_url":"https://api.github.com/repos/Polymer/lit-html/issues/229/comments","events_url":"https://api.github.com/repos/Polymer/lit-html/issues/229/events","html_url":"https://github.com/Polymer/lit-html/pull/229","id":281900357,"number":229,"title":"Switch to using text nodes with a marker instead of empty comment nodes","user":{"login":"bgotink","id":821510,"avatar_url":"https://avatars1.githubusercontent.com/u/821510?v=4","gravatar_id":"","url":"https://api.github.com/users/bgotink","html_url":"https://github.com/bgotink","followers_url":"https://api.github.com/users/bgotink/followers","following_url":"https://api.github.com/users/bgotink/following{/other_user}","gists_url":"https://api.github.com/users/bgotink/gists{/gist_id}","starred_url":"https://api.github.com/users/bgotink/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgotink/subscriptions","organizations_url":"https://api.github.com/users/bgotink/orgs","repos_url":"https://api.github.com/users/bgotink/repos","events_url":"https://api.github.com/users/bgotink/events{/privacy}","received_events_url":"https://api.github.com/users/bgotink/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":17,"created_at":"2017-12-13T21:18:56Z","updated_at":"2018-02-03T00:37:57Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Polymer/lit-html/pulls/229","html_url":"https://github.com/Polymer/lit-html/pull/229","diff_url":"https://github.com/Polymer/lit-html/pull/229.diff","patch_url":"https://github.com/Polymer/lit-html/pull/229.patch"},"body":"Comment nodes are problematic when inserted into textContent, e.g. a `<style>`\r\nelement. This commit changes to using a text node with a marker content rather\r\nthan an empty comment. The markers are removed at clone time.\r\n\r\nAll of this is implemented using a platform check to ensure that we only do\r\nthis on platforms that don't clone empty text nodes (IE).\r\n\r\nFixes #214\r\n\r\nNote: not yet tested on IE because I can't access any Windows machine/vm atm."},"comment":{"url":"https://api.github.com/repos/Polymer/lit-html/issues/comments/362752352","html_url":"https://github.com/Polymer/lit-html/pull/229#issuecomment-362752352","issue_url":"https://api.github.com/repos/Polymer/lit-html/issues/229","id":362752352,"user":{"login":"justinfagnani","id":522948,"avatar_url":"https://avatars0.githubusercontent.com/u/522948?v=4","gravatar_id":"","url":"https://api.github.com/users/justinfagnani","html_url":"https://github.com/justinfagnani","followers_url":"https://api.github.com/users/justinfagnani/followers","following_url":"https://api.github.com/users/justinfagnani/following{/other_user}","gists_url":"https://api.github.com/users/justinfagnani/gists{/gist_id}","starred_url":"https://api.github.com/users/justinfagnani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinfagnani/subscriptions","organizations_url":"https://api.github.com/users/justinfagnani/orgs","repos_url":"https://api.github.com/users/justinfagnani/repos","events_url":"https://api.github.com/users/justinfagnani/events{/privacy}","received_events_url":"https://api.github.com/users/justinfagnani/received_events","type":"User","site_admin":false},"created_at":"2018-02-03T00:37:57Z","updated_at":"2018-02-03T00:37:57Z","author_association":"COLLABORATOR","body":"Hey everyone, I'm taking a look at IE11 again.\r\n\r\nJust a heads up: I wanted to explore some options and started from #202 as a base while trying to keep style and script bindings working properly. I like that because once we use comment nodes for placeholders, we can start to do less work when prepping the template - just leave the comment nodes in there as parsed.\r\n\r\nSo far I think a workable solution is somewhat like this PR, but use comment nodes in the templates, then swap them for empty text nodes on clone. We can limit the swapping to only in STYLE and SCRIPT elements too."}}
{"actor":{"display_login":"justinfagnani"}}