{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/comments/239126694","pull_request_review_id":181818445,"id":239126694,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTEyNjY5NA==","diff_hunk":"@@ -265,6 +268,9 @@ class ShardingContainerPoolBalancer(\n     chosen\n       .map { invoker =>\n         setupActivation(msg, action, invoker)\n+        logging.info(\n+          this,\n+          s\"activation ${msg.activationId} of $actionType-action '${msg.action.asString}' invoked by namespace '${msg.user.namespace.name.asString}' with memory-limit of ${action.limits.memory.megabytes} MB will be executed on ${invoker.instance}\")","path":"core/controller/src/main/scala/org/apache/openwhisk/core/loadBalancer/ShardingContainerPoolBalancer.scala","position":19,"original_position":19,"commit_id":"76840f0df43feea9ae7720b0697d9024b5e130ca","original_commit_id":"76840f0df43feea9ae7720b0697d9024b5e130ca","user":{"login":"sven-lange-last","id":17647888,"node_id":"MDQ6VXNlcjE3NjQ3ODg4","avatar_url":"https://avatars1.githubusercontent.com/u/17647888?v=4","gravatar_id":"","url":"https://api.github.com/users/sven-lange-last","html_url":"https://github.com/sven-lange-last","followers_url":"https://api.github.com/users/sven-lange-last/followers","following_url":"https://api.github.com/users/sven-lange-last/following{/other_user}","gists_url":"https://api.github.com/users/sven-lange-last/gists{/gist_id}","starred_url":"https://api.github.com/users/sven-lange-last/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sven-lange-last/subscriptions","organizations_url":"https://api.github.com/users/sven-lange-last/orgs","repos_url":"https://api.github.com/users/sven-lange-last/repos","events_url":"https://api.github.com/users/sven-lange-last/events{/privacy}","received_events_url":"https://api.github.com/users/sven-lange-last/received_events","type":"User","site_admin":false},"body":"You are adding a new message to be logged for each activation while method `sendActivationToInvoker()` called in next line logs the activation anyway (https://github.com/apache/incubator-openwhisk/pull/4159/files#diff-f749d7d6e4e8ae0b5202a75af1136202R345).\r\n\r\nI suggest to extend the existing message - the current proposal may have a performance impact because of the additional log messages. I understand that extending the existing message would require a change of parameters passed to `sendActivationToInvoker()`.","created_at":"2018-12-05T16:00:11Z","updated_at":"2018-12-05T16:01:00Z","html_url":"https://github.com/apache/incubator-openwhisk/pull/4159#discussion_r239126694","pull_request_url":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/4159","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/comments/239126694"},"html":{"href":"https://github.com/apache/incubator-openwhisk/pull/4159#discussion_r239126694"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/4159"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/4159","id":236214613,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2MjE0NjEz","html_url":"https://github.com/apache/incubator-openwhisk/pull/4159","diff_url":"https://github.com/apache/incubator-openwhisk/pull/4159.diff","patch_url":"https://github.com/apache/incubator-openwhisk/pull/4159.patch","issue_url":"https://api.github.com/repos/apache/incubator-openwhisk/issues/4159","number":4159,"state":"open","locked":false,"title":"Add additional debug information to Loadbalancer.","user":{"login":"cbickel","id":13397688,"node_id":"MDQ6VXNlcjEzMzk3Njg4","avatar_url":"https://avatars1.githubusercontent.com/u/13397688?v=4","gravatar_id":"","url":"https://api.github.com/users/cbickel","html_url":"https://github.com/cbickel","followers_url":"https://api.github.com/users/cbickel/followers","following_url":"https://api.github.com/users/cbickel/following{/other_user}","gists_url":"https://api.github.com/users/cbickel/gists{/gist_id}","starred_url":"https://api.github.com/users/cbickel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbickel/subscriptions","organizations_url":"https://api.github.com/users/cbickel/orgs","repos_url":"https://api.github.com/users/cbickel/repos","events_url":"https://api.github.com/users/cbickel/events{/privacy}","received_events_url":"https://api.github.com/users/cbickel/received_events","type":"User","site_admin":false},"body":"This PR will add additional information into the loadbalancer which enhances debugging. With these information it will be much easier to debug, which user and which action consumed how much memory.\n\n<!--- Provide a concise summary of your changes in the Title -->\n\n## Description\n<!--- Provide a detailed description of your changes. -->\n<!--- Include details of what problem you are solving and how your changes are tested. -->\n\n## Related issue and scope\n<!--- Please include a link to a related issue if there is one. -->\n- [ ] I opened an issue to propose and discuss this change (#????)\n\n## My changes affect the following components\n<!--- Select below all system components are affected by your change. -->\n<!--- Enter an `x` in all applicable boxes. -->\n- [ ] API\n- [ ] Controller\n- [ ] Message Bus (e.g., Kafka)\n- [x] Loadbalancer\n- [ ] Invoker\n- [ ] Intrinsic actions (e.g., sequences, conductors)\n- [ ] Data stores (e.g., CouchDB)\n- [ ] Tests\n- [ ] Deployment\n- [ ] CLI\n- [ ] General tooling\n- [ ] Documentation\n\n## Types of changes\n<!--- What types of changes does your code introduce? Use `x` in all the boxes that apply: -->\n- [x] Bug fix (generally a non-breaking change which closes an issue).\n- [ ] Enhancement or new feature (adds new functionality).\n- [ ] Breaking change (a bug fix or enhancement which changes existing behavior).\n\n## Checklist:\n<!--- Please review the points below which help you make sure you've covered all aspects of the change you're making. -->\n\n- [x] I signed an [Apache CLA](https://github.com/apache/incubator-openwhisk/blob/master/CONTRIBUTING.md).\n- [x] I reviewed the [style guides](https://github.com/apache/incubator-openwhisk/wiki/Contributing:-Git-guidelines#code-readiness) and followed the recommendations (Travis CI will check :).\n- [ ] I added tests to cover my changes.\n- [ ] My changes require further changes to the documentation.\n- [ ] I updated the documentation where necessary.","created_at":"2018-12-05T15:24:26Z","updated_at":"2018-12-05T16:01:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"66670844f6d9ab2b14ad2a15b4232b3a28a5a125","assignee":{"login":"sven-lange-last","id":17647888,"node_id":"MDQ6VXNlcjE3NjQ3ODg4","avatar_url":"https://avatars1.githubusercontent.com/u/17647888?v=4","gravatar_id":"","url":"https://api.github.com/users/sven-lange-last","html_url":"https://github.com/sven-lange-last","followers_url":"https://api.github.com/users/sven-lange-last/followers","following_url":"https://api.github.com/users/sven-lange-last/following{/other_user}","gists_url":"https://api.github.com/users/sven-lange-last/gists{/gist_id}","starred_url":"https://api.github.com/users/sven-lange-last/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sven-lange-last/subscriptions","organizations_url":"https://api.github.com/users/sven-lange-last/orgs","repos_url":"https://api.github.com/users/sven-lange-last/repos","events_url":"https://api.github.com/users/sven-lange-last/events{/privacy}","received_events_url":"https://api.github.com/users/sven-lange-last/received_events","type":"User","site_admin":false},"assignees":[{"login":"sven-lange-last","id":17647888,"node_id":"MDQ6VXNlcjE3NjQ3ODg4","avatar_url":"https://avatars1.githubusercontent.com/u/17647888?v=4","gravatar_id":"","url":"https://api.github.com/users/sven-lange-last","html_url":"https://github.com/sven-lange-last","followers_url":"https://api.github.com/users/sven-lange-last/followers","following_url":"https://api.github.com/users/sven-lange-last/following{/other_user}","gists_url":"https://api.github.com/users/sven-lange-last/gists{/gist_id}","starred_url":"https://api.github.com/users/sven-lange-last/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sven-lange-last/subscriptions","organizations_url":"https://api.github.com/users/sven-lange-last/orgs","repos_url":"https://api.github.com/users/sven-lange-last/repos","events_url":"https://api.github.com/users/sven-lange-last/events{/privacy}","received_events_url":"https://api.github.com/users/sven-lange-last/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":401833916,"node_id":"MDU6TGFiZWw0MDE4MzM5MTY=","url":"https://api.github.com/repos/apache/incubator-openwhisk/labels/review","name":"review","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/4159/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/4159/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-openwhisk/issues/4159/comments","statuses_url":"https://api.github.com/repos/apache/incubator-openwhisk/statuses/76840f0df43feea9ae7720b0697d9024b5e130ca","head":{"label":"cbickel:inf","ref":"inf","sha":"76840f0df43feea9ae7720b0697d9024b5e130ca","user":{"login":"cbickel","id":13397688,"node_id":"MDQ6VXNlcjEzMzk3Njg4","avatar_url":"https://avatars1.githubusercontent.com/u/13397688?v=4","gravatar_id":"","url":"https://api.github.com/users/cbickel","html_url":"https://github.com/cbickel","followers_url":"https://api.github.com/users/cbickel/followers","following_url":"https://api.github.com/users/cbickel/following{/other_user}","gists_url":"https://api.github.com/users/cbickel/gists{/gist_id}","starred_url":"https://api.github.com/users/cbickel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbickel/subscriptions","organizations_url":"https://api.github.com/users/cbickel/orgs","repos_url":"https://api.github.com/users/cbickel/repos","events_url":"https://api.github.com/users/cbickel/events{/privacy}","received_events_url":"https://api.github.com/users/cbickel/received_events","type":"User","site_admin":false},"repo":{"id":52370280,"node_id":"MDEwOlJlcG9zaXRvcnk1MjM3MDI4MA==","name":"openwhisk","full_name":"cbickel/openwhisk","private":false,"owner":{"login":"cbickel","id":13397688,"node_id":"MDQ6VXNlcjEzMzk3Njg4","avatar_url":"https://avatars1.githubusercontent.com/u/13397688?v=4","gravatar_id":"","url":"https://api.github.com/users/cbickel","html_url":"https://github.com/cbickel","followers_url":"https://api.github.com/users/cbickel/followers","following_url":"https://api.github.com/users/cbickel/following{/other_user}","gists_url":"https://api.github.com/users/cbickel/gists{/gist_id}","starred_url":"https://api.github.com/users/cbickel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cbickel/subscriptions","organizations_url":"https://api.github.com/users/cbickel/orgs","repos_url":"https://api.github.com/users/cbickel/repos","events_url":"https://api.github.com/users/cbickel/events{/privacy}","received_events_url":"https://api.github.com/users/cbickel/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cbickel/openwhisk","description":"OpenWhisk is a cloud-first distributed event-based programming service.","fork":true,"url":"https://api.github.com/repos/cbickel/openwhisk","forks_url":"https://api.github.com/repos/cbickel/openwhisk/forks","keys_url":"https://api.github.com/repos/cbickel/openwhisk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cbickel/openwhisk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cbickel/openwhisk/teams","hooks_url":"https://api.github.com/repos/cbickel/openwhisk/hooks","issue_events_url":"https://api.github.com/repos/cbickel/openwhisk/issues/events{/number}","events_url":"https://api.github.com/repos/cbickel/openwhisk/events","assignees_url":"https://api.github.com/repos/cbickel/openwhisk/assignees{/user}","branches_url":"https://api.github.com/repos/cbickel/openwhisk/branches{/branch}","tags_url":"https://api.github.com/repos/cbickel/openwhisk/tags","blobs_url":"https://api.github.com/repos/cbickel/openwhisk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cbickel/openwhisk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cbickel/openwhisk/git/refs{/sha}","trees_url":"https://api.github.com/repos/cbickel/openwhisk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cbickel/openwhisk/statuses/{sha}","languages_url":"https://api.github.com/repos/cbickel/openwhisk/languages","stargazers_url":"https://api.github.com/repos/cbickel/openwhisk/stargazers","contributors_url":"https://api.github.com/repos/cbickel/openwhisk/contributors","subscribers_url":"https://api.github.com/repos/cbickel/openwhisk/subscribers","subscription_url":"https://api.github.com/repos/cbickel/openwhisk/subscription","commits_url":"https://api.github.com/repos/cbickel/openwhisk/commits{/sha}","git_commits_url":"https://api.github.com/repos/cbickel/openwhisk/git/commits{/sha}","comments_url":"https://api.github.com/repos/cbickel/openwhisk/comments{/number}","issue_comment_url":"https://api.github.com/repos/cbickel/openwhisk/issues/comments{/number}","contents_url":"https://api.github.com/repos/cbickel/openwhisk/contents/{+path}","compare_url":"https://api.github.com/repos/cbickel/openwhisk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cbickel/openwhisk/merges","archive_url":"https://api.github.com/repos/cbickel/openwhisk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cbickel/openwhisk/downloads","issues_url":"https://api.github.com/repos/cbickel/openwhisk/issues{/number}","pulls_url":"https://api.github.com/repos/cbickel/openwhisk/pulls{/number}","milestones_url":"https://api.github.com/repos/cbickel/openwhisk/milestones{/number}","notifications_url":"https://api.github.com/repos/cbickel/openwhisk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cbickel/openwhisk/labels{/name}","releases_url":"https://api.github.com/repos/cbickel/openwhisk/releases{/id}","deployments_url":"https://api.github.com/repos/cbickel/openwhisk/deployments","created_at":"2016-02-23T15:44:59Z","updated_at":"2018-12-05T08:11:33Z","pushed_at":"2018-12-05T15:27:13Z","git_url":"git://github.com/cbickel/openwhisk.git","ssh_url":"git@github.com:cbickel/openwhisk.git","clone_url":"https://github.com/cbickel/openwhisk.git","svn_url":"https://github.com/cbickel/openwhisk","homepage":"","size":63600,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"de2663fdcef41ae39fe5985c62f46c75f26427a4","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":52039373,"node_id":"MDEwOlJlcG9zaXRvcnk1MjAzOTM3Mw==","name":"incubator-openwhisk","full_name":"apache/incubator-openwhisk","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/incubator-openwhisk","description":"Apache OpenWhisk is a serverless event-based programming service and an Apache Incubator project.","fork":false,"url":"https://api.github.com/repos/apache/incubator-openwhisk","forks_url":"https://api.github.com/repos/apache/incubator-openwhisk/forks","keys_url":"https://api.github.com/repos/apache/incubator-openwhisk/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-openwhisk/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-openwhisk/teams","hooks_url":"https://api.github.com/repos/apache/incubator-openwhisk/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-openwhisk/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-openwhisk/events","assignees_url":"https://api.github.com/repos/apache/incubator-openwhisk/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-openwhisk/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-openwhisk/tags","blobs_url":"https://api.github.com/repos/apache/incubator-openwhisk/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-openwhisk/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-openwhisk/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-openwhisk/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-openwhisk/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-openwhisk/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-openwhisk/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-openwhisk/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-openwhisk/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-openwhisk/subscription","commits_url":"https://api.github.com/repos/apache/incubator-openwhisk/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-openwhisk/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-openwhisk/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-openwhisk/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-openwhisk/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-openwhisk/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-openwhisk/merges","archive_url":"https://api.github.com/repos/apache/incubator-openwhisk/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-openwhisk/downloads","issues_url":"https://api.github.com/repos/apache/incubator-openwhisk/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-openwhisk/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-openwhisk/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-openwhisk/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-openwhisk/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-openwhisk/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-openwhisk/deployments","created_at":"2016-02-18T21:16:19Z","updated_at":"2018-12-05T07:05:16Z","pushed_at":"2018-12-05T15:48:59Z","git_url":"git://github.com/apache/incubator-openwhisk.git","ssh_url":"git@github.com:apache/incubator-openwhisk.git","clone_url":"https://github.com/apache/incubator-openwhisk.git","svn_url":"https://github.com/apache/incubator-openwhisk","homepage":"https://openwhisk.apache.org/ ","size":63436,"stargazers_count":3661,"watchers_count":3661,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":696,"mirror_url":null,"archived":false,"open_issues_count":432,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":696,"open_issues":432,"watchers":3661,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/4159"},"html":{"href":"https://github.com/apache/incubator-openwhisk/pull/4159"},"issue":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/issues/4159"},"comments":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/issues/4159/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/4159/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/pulls/4159/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-openwhisk/statuses/76840f0df43feea9ae7720b0697d9024b5e130ca"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sven-lange-last"}}