{"action":"opened","number":1335,"pull_request":{"url":"https://api.github.com/repos/confluentinc/ksql/pulls/1335","id":189834336,"html_url":"https://github.com/confluentinc/ksql/pull/1335","diff_url":"https://github.com/confluentinc/ksql/pull/1335.diff","patch_url":"https://github.com/confluentinc/ksql/pull/1335.patch","issue_url":"https://api.github.com/repos/confluentinc/ksql/issues/1335","number":1335,"state":"open","locked":false,"title":"Don't ignore leading spaces when saving history","user":{"login":"apurvam","id":830220,"avatar_url":"https://avatars0.githubusercontent.com/u/830220?v=4","gravatar_id":"","url":"https://api.github.com/users/apurvam","html_url":"https://github.com/apurvam","followers_url":"https://api.github.com/users/apurvam/followers","following_url":"https://api.github.com/users/apurvam/following{/other_user}","gists_url":"https://api.github.com/users/apurvam/gists{/gist_id}","starred_url":"https://api.github.com/users/apurvam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apurvam/subscriptions","organizations_url":"https://api.github.com/users/apurvam/orgs","repos_url":"https://api.github.com/users/apurvam/repos","events_url":"https://api.github.com/users/apurvam/events{/privacy}","received_events_url":"https://api.github.com/users/apurvam/received_events","type":"User","site_admin":false},"body":"### Description \r\nCurrently we don't log commands starting with spaces to the CLI history. This is considered bad UX. This patch changes a setting in the underlying JLine3 library we use so that we log commands which start with a space.\r\n\r\n### Testing done \r\nAdded a test case which ensures that commands with a leading space are saved to history.\r\n\r\n### Reviewer checklist\r\n- [ ] Ensure docs are updated if necessary. (eg. if a user visible feature is being added or changed).\r\n- [ ] Ensure relevant issues are linked (description should include text like \"Fixes #<issue number>\")\r\n\r\n","created_at":"2018-05-23T01:33:44Z","updated_at":"2018-05-23T01:33:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/confluentinc/ksql/pulls/1335/commits","review_comments_url":"https://api.github.com/repos/confluentinc/ksql/pulls/1335/comments","review_comment_url":"https://api.github.com/repos/confluentinc/ksql/pulls/comments{/number}","comments_url":"https://api.github.com/repos/confluentinc/ksql/issues/1335/comments","statuses_url":"https://api.github.com/repos/confluentinc/ksql/statuses/34a2c441d0883cfe9e5688d177be35d7bdfa9cfe","head":{"label":"apurvam:dont-ignore-leading-space-when-saving-history","ref":"dont-ignore-leading-space-when-saving-history","sha":"34a2c441d0883cfe9e5688d177be35d7bdfa9cfe","user":{"login":"apurvam","id":830220,"avatar_url":"https://avatars0.githubusercontent.com/u/830220?v=4","gravatar_id":"","url":"https://api.github.com/users/apurvam","html_url":"https://github.com/apurvam","followers_url":"https://api.github.com/users/apurvam/followers","following_url":"https://api.github.com/users/apurvam/following{/other_user}","gists_url":"https://api.github.com/users/apurvam/gists{/gist_id}","starred_url":"https://api.github.com/users/apurvam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apurvam/subscriptions","organizations_url":"https://api.github.com/users/apurvam/orgs","repos_url":"https://api.github.com/users/apurvam/repos","events_url":"https://api.github.com/users/apurvam/events{/privacy}","received_events_url":"https://api.github.com/users/apurvam/received_events","type":"User","site_admin":false},"repo":{"id":106761843,"name":"ksql","full_name":"apurvam/ksql","owner":{"login":"apurvam","id":830220,"avatar_url":"https://avatars0.githubusercontent.com/u/830220?v=4","gravatar_id":"","url":"https://api.github.com/users/apurvam","html_url":"https://github.com/apurvam","followers_url":"https://api.github.com/users/apurvam/followers","following_url":"https://api.github.com/users/apurvam/following{/other_user}","gists_url":"https://api.github.com/users/apurvam/gists{/gist_id}","starred_url":"https://api.github.com/users/apurvam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apurvam/subscriptions","organizations_url":"https://api.github.com/users/apurvam/orgs","repos_url":"https://api.github.com/users/apurvam/repos","events_url":"https://api.github.com/users/apurvam/events{/privacy}","received_events_url":"https://api.github.com/users/apurvam/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/apurvam/ksql","description":"KSQL - a Streaming SQL Engine for Apache Kafka ","fork":true,"url":"https://api.github.com/repos/apurvam/ksql","forks_url":"https://api.github.com/repos/apurvam/ksql/forks","keys_url":"https://api.github.com/repos/apurvam/ksql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apurvam/ksql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apurvam/ksql/teams","hooks_url":"https://api.github.com/repos/apurvam/ksql/hooks","issue_events_url":"https://api.github.com/repos/apurvam/ksql/issues/events{/number}","events_url":"https://api.github.com/repos/apurvam/ksql/events","assignees_url":"https://api.github.com/repos/apurvam/ksql/assignees{/user}","branches_url":"https://api.github.com/repos/apurvam/ksql/branches{/branch}","tags_url":"https://api.github.com/repos/apurvam/ksql/tags","blobs_url":"https://api.github.com/repos/apurvam/ksql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apurvam/ksql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apurvam/ksql/git/refs{/sha}","trees_url":"https://api.github.com/repos/apurvam/ksql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apurvam/ksql/statuses/{sha}","languages_url":"https://api.github.com/repos/apurvam/ksql/languages","stargazers_url":"https://api.github.com/repos/apurvam/ksql/stargazers","contributors_url":"https://api.github.com/repos/apurvam/ksql/contributors","subscribers_url":"https://api.github.com/repos/apurvam/ksql/subscribers","subscription_url":"https://api.github.com/repos/apurvam/ksql/subscription","commits_url":"https://api.github.com/repos/apurvam/ksql/commits{/sha}","git_commits_url":"https://api.github.com/repos/apurvam/ksql/git/commits{/sha}","comments_url":"https://api.github.com/repos/apurvam/ksql/comments{/number}","issue_comment_url":"https://api.github.com/repos/apurvam/ksql/issues/comments{/number}","contents_url":"https://api.github.com/repos/apurvam/ksql/contents/{+path}","compare_url":"https://api.github.com/repos/apurvam/ksql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apurvam/ksql/merges","archive_url":"https://api.github.com/repos/apurvam/ksql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apurvam/ksql/downloads","issues_url":"https://api.github.com/repos/apurvam/ksql/issues{/number}","pulls_url":"https://api.github.com/repos/apurvam/ksql/pulls{/number}","milestones_url":"https://api.github.com/repos/apurvam/ksql/milestones{/number}","notifications_url":"https://api.github.com/repos/apurvam/ksql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apurvam/ksql/labels{/name}","releases_url":"https://api.github.com/repos/apurvam/ksql/releases{/id}","deployments_url":"https://api.github.com/repos/apurvam/ksql/deployments","created_at":"2017-10-13T01:11:55Z","updated_at":"2017-10-13T01:11:58Z","pushed_at":"2018-05-23T01:33:19Z","git_url":"git://github.com/apurvam/ksql.git","ssh_url":"git@github.com:apurvam/ksql.git","clone_url":"https://github.com/apurvam/ksql.git","svn_url":"https://github.com/apurvam/ksql","homepage":"","size":7258,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"0.1.x"}},"base":{"label":"confluentinc:master","ref":"master","sha":"2bd0be58535983efde6fc2089915894c8df0edf1","user":{"login":"confluentinc","id":9439498,"avatar_url":"https://avatars0.githubusercontent.com/u/9439498?v=4","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"repo":{"id":69400326,"name":"ksql","full_name":"confluentinc/ksql","owner":{"login":"confluentinc","id":9439498,"avatar_url":"https://avatars0.githubusercontent.com/u/9439498?v=4","gravatar_id":"","url":"https://api.github.com/users/confluentinc","html_url":"https://github.com/confluentinc","followers_url":"https://api.github.com/users/confluentinc/followers","following_url":"https://api.github.com/users/confluentinc/following{/other_user}","gists_url":"https://api.github.com/users/confluentinc/gists{/gist_id}","starred_url":"https://api.github.com/users/confluentinc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/confluentinc/subscriptions","organizations_url":"https://api.github.com/users/confluentinc/orgs","repos_url":"https://api.github.com/users/confluentinc/repos","events_url":"https://api.github.com/users/confluentinc/events{/privacy}","received_events_url":"https://api.github.com/users/confluentinc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/confluentinc/ksql","description":"KSQL - the Streaming SQL Engine for Apache Kafka ","fork":false,"url":"https://api.github.com/repos/confluentinc/ksql","forks_url":"https://api.github.com/repos/confluentinc/ksql/forks","keys_url":"https://api.github.com/repos/confluentinc/ksql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/confluentinc/ksql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/confluentinc/ksql/teams","hooks_url":"https://api.github.com/repos/confluentinc/ksql/hooks","issue_events_url":"https://api.github.com/repos/confluentinc/ksql/issues/events{/number}","events_url":"https://api.github.com/repos/confluentinc/ksql/events","assignees_url":"https://api.github.com/repos/confluentinc/ksql/assignees{/user}","branches_url":"https://api.github.com/repos/confluentinc/ksql/branches{/branch}","tags_url":"https://api.github.com/repos/confluentinc/ksql/tags","blobs_url":"https://api.github.com/repos/confluentinc/ksql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/confluentinc/ksql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/confluentinc/ksql/git/refs{/sha}","trees_url":"https://api.github.com/repos/confluentinc/ksql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/confluentinc/ksql/statuses/{sha}","languages_url":"https://api.github.com/repos/confluentinc/ksql/languages","stargazers_url":"https://api.github.com/repos/confluentinc/ksql/stargazers","contributors_url":"https://api.github.com/repos/confluentinc/ksql/contributors","subscribers_url":"https://api.github.com/repos/confluentinc/ksql/subscribers","subscription_url":"https://api.github.com/repos/confluentinc/ksql/subscription","commits_url":"https://api.github.com/repos/confluentinc/ksql/commits{/sha}","git_commits_url":"https://api.github.com/repos/confluentinc/ksql/git/commits{/sha}","comments_url":"https://api.github.com/repos/confluentinc/ksql/comments{/number}","issue_comment_url":"https://api.github.com/repos/confluentinc/ksql/issues/comments{/number}","contents_url":"https://api.github.com/repos/confluentinc/ksql/contents/{+path}","compare_url":"https://api.github.com/repos/confluentinc/ksql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/confluentinc/ksql/merges","archive_url":"https://api.github.com/repos/confluentinc/ksql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/confluentinc/ksql/downloads","issues_url":"https://api.github.com/repos/confluentinc/ksql/issues{/number}","pulls_url":"https://api.github.com/repos/confluentinc/ksql/pulls{/number}","milestones_url":"https://api.github.com/repos/confluentinc/ksql/milestones{/number}","notifications_url":"https://api.github.com/repos/confluentinc/ksql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/confluentinc/ksql/labels{/name}","releases_url":"https://api.github.com/repos/confluentinc/ksql/releases{/id}","deployments_url":"https://api.github.com/repos/confluentinc/ksql/deployments","created_at":"2016-09-27T21:30:15Z","updated_at":"2018-05-22T22:23:45Z","pushed_at":"2018-05-23T00:07:13Z","git_url":"git://github.com/confluentinc/ksql.git","ssh_url":"git@github.com:confluentinc/ksql.git","clone_url":"https://github.com/confluentinc/ksql.git","svn_url":"https://github.com/confluentinc/ksql","homepage":"","size":7396,"stargazers_count":1672,"watchers_count":1672,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":306,"mirror_url":null,"archived":false,"open_issues_count":294,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":306,"open_issues":294,"watchers":1672,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/1335"},"html":{"href":"https://github.com/confluentinc/ksql/pull/1335"},"issue":{"href":"https://api.github.com/repos/confluentinc/ksql/issues/1335"},"comments":{"href":"https://api.github.com/repos/confluentinc/ksql/issues/1335/comments"},"review_comments":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/1335/comments"},"review_comment":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/confluentinc/ksql/pulls/1335/commits"},"statuses":{"href":"https://api.github.com/repos/confluentinc/ksql/statuses/34a2c441d0883cfe9e5688d177be35d7bdfa9cfe"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":54,"deletions":9,"changed_files":3}}
{"actor":{"display_login":"apurvam"}}