{"action":"opened","number":274,"pull_request":{"url":"https://api.github.com/repos/AnalogJ/lexicon/pulls/274","id":207792647,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NzkyNjQ3","html_url":"https://github.com/AnalogJ/lexicon/pull/274","diff_url":"https://github.com/AnalogJ/lexicon/pull/274.diff","patch_url":"https://github.com/AnalogJ/lexicon/pull/274.patch","issue_url":"https://api.github.com/repos/AnalogJ/lexicon/issues/274","number":274,"state":"open","locked":false,"title":"Some corrections/evolutions for Gandi and OVH providers","user":{"login":"adferrand","id":9728851,"node_id":"MDQ6VXNlcjk3Mjg4NTE=","avatar_url":"https://avatars0.githubusercontent.com/u/9728851?v=4","gravatar_id":"","url":"https://api.github.com/users/adferrand","html_url":"https://github.com/adferrand","followers_url":"https://api.github.com/users/adferrand/followers","following_url":"https://api.github.com/users/adferrand/following{/other_user}","gists_url":"https://api.github.com/users/adferrand/gists{/gist_id}","starred_url":"https://api.github.com/users/adferrand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adferrand/subscriptions","organizations_url":"https://api.github.com/users/adferrand/orgs","repos_url":"https://api.github.com/users/adferrand/repos","events_url":"https://api.github.com/users/adferrand/events{/privacy}","received_events_url":"https://api.github.com/users/adferrand/received_events","type":"User","site_admin":false},"body":"About Gandi, following #171: I replaced the option `--api-protocol` by `--auth-api-protocol`. It allows this option, which drives which Gandi API is used, to be defined by an environment variable (here `LEXICON_GANDI_API_PROTOCOL` because only options formated as `--auth-something` can be handled with environment variables. For retro-compatibility, `--api-protocol` is still read but is invisible, and a warning is displayed to the user, indicating that `--auth-api-protocol` should be used for now on.\r\n\r\nAbout OVH, following certbot/certbot#6222: I moved the logic involving a request to the OVH API from the provider constructor to the authenticate method implemented by the provider. Indeed, unit tests done in certbot using lexicon require to mock the HTTP requests, but the logic inside the provider constructor cannot be mocked. Therefore, any unit tests for certbot executed on a machine without an internet access, were failing when OVH authenticator is invoked. This correction allows these requests to be correctly mocked, as they occur during the authentication phase.","created_at":"2018-08-11T21:08:06Z","updated_at":"2018-08-11T21:08:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/AnalogJ/lexicon/pulls/274/commits","review_comments_url":"https://api.github.com/repos/AnalogJ/lexicon/pulls/274/comments","review_comment_url":"https://api.github.com/repos/AnalogJ/lexicon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AnalogJ/lexicon/issues/274/comments","statuses_url":"https://api.github.com/repos/AnalogJ/lexicon/statuses/0c51eb0fc4069cd5cb8ea6a5fd8d3f4b12b11daa","head":{"label":"adferrand:gandi_ovh_corrections","ref":"gandi_ovh_corrections","sha":"0c51eb0fc4069cd5cb8ea6a5fd8d3f4b12b11daa","user":{"login":"adferrand","id":9728851,"node_id":"MDQ6VXNlcjk3Mjg4NTE=","avatar_url":"https://avatars0.githubusercontent.com/u/9728851?v=4","gravatar_id":"","url":"https://api.github.com/users/adferrand","html_url":"https://github.com/adferrand","followers_url":"https://api.github.com/users/adferrand/followers","following_url":"https://api.github.com/users/adferrand/following{/other_user}","gists_url":"https://api.github.com/users/adferrand/gists{/gist_id}","starred_url":"https://api.github.com/users/adferrand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adferrand/subscriptions","organizations_url":"https://api.github.com/users/adferrand/orgs","repos_url":"https://api.github.com/users/adferrand/repos","events_url":"https://api.github.com/users/adferrand/events{/privacy}","received_events_url":"https://api.github.com/users/adferrand/received_events","type":"User","site_admin":false},"repo":{"id":94221376,"node_id":"MDEwOlJlcG9zaXRvcnk5NDIyMTM3Ng==","name":"lexicon","full_name":"adferrand/lexicon","owner":{"login":"adferrand","id":9728851,"node_id":"MDQ6VXNlcjk3Mjg4NTE=","avatar_url":"https://avatars0.githubusercontent.com/u/9728851?v=4","gravatar_id":"","url":"https://api.github.com/users/adferrand","html_url":"https://github.com/adferrand","followers_url":"https://api.github.com/users/adferrand/followers","following_url":"https://api.github.com/users/adferrand/following{/other_user}","gists_url":"https://api.github.com/users/adferrand/gists{/gist_id}","starred_url":"https://api.github.com/users/adferrand/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adferrand/subscriptions","organizations_url":"https://api.github.com/users/adferrand/orgs","repos_url":"https://api.github.com/users/adferrand/repos","events_url":"https://api.github.com/users/adferrand/events{/privacy}","received_events_url":"https://api.github.com/users/adferrand/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adferrand/lexicon","description":"Manipulate DNS records on various DNS providers in a standardized way. ","fork":true,"url":"https://api.github.com/repos/adferrand/lexicon","forks_url":"https://api.github.com/repos/adferrand/lexicon/forks","keys_url":"https://api.github.com/repos/adferrand/lexicon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adferrand/lexicon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adferrand/lexicon/teams","hooks_url":"https://api.github.com/repos/adferrand/lexicon/hooks","issue_events_url":"https://api.github.com/repos/adferrand/lexicon/issues/events{/number}","events_url":"https://api.github.com/repos/adferrand/lexicon/events","assignees_url":"https://api.github.com/repos/adferrand/lexicon/assignees{/user}","branches_url":"https://api.github.com/repos/adferrand/lexicon/branches{/branch}","tags_url":"https://api.github.com/repos/adferrand/lexicon/tags","blobs_url":"https://api.github.com/repos/adferrand/lexicon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adferrand/lexicon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adferrand/lexicon/git/refs{/sha}","trees_url":"https://api.github.com/repos/adferrand/lexicon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adferrand/lexicon/statuses/{sha}","languages_url":"https://api.github.com/repos/adferrand/lexicon/languages","stargazers_url":"https://api.github.com/repos/adferrand/lexicon/stargazers","contributors_url":"https://api.github.com/repos/adferrand/lexicon/contributors","subscribers_url":"https://api.github.com/repos/adferrand/lexicon/subscribers","subscription_url":"https://api.github.com/repos/adferrand/lexicon/subscription","commits_url":"https://api.github.com/repos/adferrand/lexicon/commits{/sha}","git_commits_url":"https://api.github.com/repos/adferrand/lexicon/git/commits{/sha}","comments_url":"https://api.github.com/repos/adferrand/lexicon/comments{/number}","issue_comment_url":"https://api.github.com/repos/adferrand/lexicon/issues/comments{/number}","contents_url":"https://api.github.com/repos/adferrand/lexicon/contents/{+path}","compare_url":"https://api.github.com/repos/adferrand/lexicon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adferrand/lexicon/merges","archive_url":"https://api.github.com/repos/adferrand/lexicon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adferrand/lexicon/downloads","issues_url":"https://api.github.com/repos/adferrand/lexicon/issues{/number}","pulls_url":"https://api.github.com/repos/adferrand/lexicon/pulls{/number}","milestones_url":"https://api.github.com/repos/adferrand/lexicon/milestones{/number}","notifications_url":"https://api.github.com/repos/adferrand/lexicon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adferrand/lexicon/labels{/name}","releases_url":"https://api.github.com/repos/adferrand/lexicon/releases{/id}","deployments_url":"https://api.github.com/repos/adferrand/lexicon/deployments","created_at":"2017-06-13T14:22:51Z","updated_at":"2018-08-11T20:34:53Z","pushed_at":"2018-08-11T20:57:22Z","git_url":"git://github.com/adferrand/lexicon.git","ssh_url":"git@github.com:adferrand/lexicon.git","clone_url":"https://github.com/adferrand/lexicon.git","svn_url":"https://github.com/adferrand/lexicon","homepage":"","size":1508,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"AnalogJ:master","ref":"master","sha":"3e43404d35c9eb104966972e59937cf88797bc4c","user":{"login":"AnalogJ","id":891875,"node_id":"MDQ6VXNlcjg5MTg3NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/891875?v=4","gravatar_id":"","url":"https://api.github.com/users/AnalogJ","html_url":"https://github.com/AnalogJ","followers_url":"https://api.github.com/users/AnalogJ/followers","following_url":"https://api.github.com/users/AnalogJ/following{/other_user}","gists_url":"https://api.github.com/users/AnalogJ/gists{/gist_id}","starred_url":"https://api.github.com/users/AnalogJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnalogJ/subscriptions","organizations_url":"https://api.github.com/users/AnalogJ/orgs","repos_url":"https://api.github.com/users/AnalogJ/repos","events_url":"https://api.github.com/users/AnalogJ/events{/privacy}","received_events_url":"https://api.github.com/users/AnalogJ/received_events","type":"User","site_admin":false},"repo":{"id":50903853,"node_id":"MDEwOlJlcG9zaXRvcnk1MDkwMzg1Mw==","name":"lexicon","full_name":"AnalogJ/lexicon","owner":{"login":"AnalogJ","id":891875,"node_id":"MDQ6VXNlcjg5MTg3NQ==","avatar_url":"https://avatars1.githubusercontent.com/u/891875?v=4","gravatar_id":"","url":"https://api.github.com/users/AnalogJ","html_url":"https://github.com/AnalogJ","followers_url":"https://api.github.com/users/AnalogJ/followers","following_url":"https://api.github.com/users/AnalogJ/following{/other_user}","gists_url":"https://api.github.com/users/AnalogJ/gists{/gist_id}","starred_url":"https://api.github.com/users/AnalogJ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnalogJ/subscriptions","organizations_url":"https://api.github.com/users/AnalogJ/orgs","repos_url":"https://api.github.com/users/AnalogJ/repos","events_url":"https://api.github.com/users/AnalogJ/events{/privacy}","received_events_url":"https://api.github.com/users/AnalogJ/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AnalogJ/lexicon","description":"Manipulate DNS records on various DNS providers in a standardized way. ","fork":false,"url":"https://api.github.com/repos/AnalogJ/lexicon","forks_url":"https://api.github.com/repos/AnalogJ/lexicon/forks","keys_url":"https://api.github.com/repos/AnalogJ/lexicon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AnalogJ/lexicon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AnalogJ/lexicon/teams","hooks_url":"https://api.github.com/repos/AnalogJ/lexicon/hooks","issue_events_url":"https://api.github.com/repos/AnalogJ/lexicon/issues/events{/number}","events_url":"https://api.github.com/repos/AnalogJ/lexicon/events","assignees_url":"https://api.github.com/repos/AnalogJ/lexicon/assignees{/user}","branches_url":"https://api.github.com/repos/AnalogJ/lexicon/branches{/branch}","tags_url":"https://api.github.com/repos/AnalogJ/lexicon/tags","blobs_url":"https://api.github.com/repos/AnalogJ/lexicon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AnalogJ/lexicon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AnalogJ/lexicon/git/refs{/sha}","trees_url":"https://api.github.com/repos/AnalogJ/lexicon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AnalogJ/lexicon/statuses/{sha}","languages_url":"https://api.github.com/repos/AnalogJ/lexicon/languages","stargazers_url":"https://api.github.com/repos/AnalogJ/lexicon/stargazers","contributors_url":"https://api.github.com/repos/AnalogJ/lexicon/contributors","subscribers_url":"https://api.github.com/repos/AnalogJ/lexicon/subscribers","subscription_url":"https://api.github.com/repos/AnalogJ/lexicon/subscription","commits_url":"https://api.github.com/repos/AnalogJ/lexicon/commits{/sha}","git_commits_url":"https://api.github.com/repos/AnalogJ/lexicon/git/commits{/sha}","comments_url":"https://api.github.com/repos/AnalogJ/lexicon/comments{/number}","issue_comment_url":"https://api.github.com/repos/AnalogJ/lexicon/issues/comments{/number}","contents_url":"https://api.github.com/repos/AnalogJ/lexicon/contents/{+path}","compare_url":"https://api.github.com/repos/AnalogJ/lexicon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AnalogJ/lexicon/merges","archive_url":"https://api.github.com/repos/AnalogJ/lexicon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AnalogJ/lexicon/downloads","issues_url":"https://api.github.com/repos/AnalogJ/lexicon/issues{/number}","pulls_url":"https://api.github.com/repos/AnalogJ/lexicon/pulls{/number}","milestones_url":"https://api.github.com/repos/AnalogJ/lexicon/milestones{/number}","notifications_url":"https://api.github.com/repos/AnalogJ/lexicon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AnalogJ/lexicon/labels{/name}","releases_url":"https://api.github.com/repos/AnalogJ/lexicon/releases{/id}","deployments_url":"https://api.github.com/repos/AnalogJ/lexicon/deployments","created_at":"2016-02-02T07:53:04Z","updated_at":"2018-08-11T07:12:07Z","pushed_at":"2018-07-26T05:08:09Z","git_url":"git://github.com/AnalogJ/lexicon.git","ssh_url":"git@github.com:AnalogJ/lexicon.git","clone_url":"https://github.com/AnalogJ/lexicon.git","svn_url":"https://github.com/AnalogJ/lexicon","homepage":"","size":1589,"stargazers_count":386,"watchers_count":386,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":110,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":110,"open_issues":22,"watchers":386,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AnalogJ/lexicon/pulls/274"},"html":{"href":"https://github.com/AnalogJ/lexicon/pull/274"},"issue":{"href":"https://api.github.com/repos/AnalogJ/lexicon/issues/274"},"comments":{"href":"https://api.github.com/repos/AnalogJ/lexicon/issues/274/comments"},"review_comments":{"href":"https://api.github.com/repos/AnalogJ/lexicon/pulls/274/comments"},"review_comment":{"href":"https://api.github.com/repos/AnalogJ/lexicon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AnalogJ/lexicon/pulls/274/commits"},"statuses":{"href":"https://api.github.com/repos/AnalogJ/lexicon/statuses/0c51eb0fc4069cd5cb8ea6a5fd8d3f4b12b11daa"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":14,"deletions":5,"changed_files":3}}
{"actor":{"display_login":"adferrand"}}