{"action":"created","issue":{"url":"https://api.github.com/repos/jpetazzo/container.training/issues/197","repository_url":"https://api.github.com/repos/jpetazzo/container.training","labels_url":"https://api.github.com/repos/jpetazzo/container.training/issues/197/labels{/name}","comments_url":"https://api.github.com/repos/jpetazzo/container.training/issues/197/comments","events_url":"https://api.github.com/repos/jpetazzo/container.training/issues/197/events","html_url":"https://github.com/jpetazzo/container.training/pull/197","id":313550962,"number":197,"title":"Patch only daemonset pods","user":{"login":"bridgetkromhout","id":2104453,"avatar_url":"https://avatars2.githubusercontent.com/u/2104453?v=4","gravatar_id":"","url":"https://api.github.com/users/bridgetkromhout","html_url":"https://github.com/bridgetkromhout","followers_url":"https://api.github.com/users/bridgetkromhout/followers","following_url":"https://api.github.com/users/bridgetkromhout/following{/other_user}","gists_url":"https://api.github.com/users/bridgetkromhout/gists{/gist_id}","starred_url":"https://api.github.com/users/bridgetkromhout/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bridgetkromhout/subscriptions","organizations_url":"https://api.github.com/users/bridgetkromhout/orgs","repos_url":"https://api.github.com/users/bridgetkromhout/repos","events_url":"https://api.github.com/users/bridgetkromhout/events{/privacy}","received_events_url":"https://api.github.com/users/bridgetkromhout/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-12T02:13:22Z","updated_at":"2018-04-12T05:13:32Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/jpetazzo/container.training/pulls/197","html_url":"https://github.com/jpetazzo/container.training/pull/197","diff_url":"https://github.com/jpetazzo/container.training/pull/197.diff","patch_url":"https://github.com/jpetazzo/container.training/pull/197.patch"},"body":"When I tested this, I discovered that oops, we're actually patching both the daemonset and the deployment! I looked around for a plausible difference we could use to differentiate, and found one, but perhaps we want to do this a different way. We definitely have an error as it stands currently.\r\n\r\nEvidence that without this extra flag, the deployment also gets patched:\r\n```\r\n[52.186.28.163] (local) docker@node1 ~/container.training/stacks\r\n$ kubectl get pods -l run=rng -o name -l controller-revision-hash |\r\n>   xargs kubectl patch -p \"$PATCH\"\r\npod \"rng-4xwr9\" patched\r\npod \"rng-lhl7j\" patched\r\n[52.186.28.163] (local) docker@node1 ~/container.training/stacks\r\n$ kubectl get pods -l run=rng -o name  |   xargs kubectl patch -p \"$PATCH\"\r\npod \"rng-4xwr9\" not patched\r\npod \"rng-76b886bb88-pfqbd\" patched\r\npod \"rng-lhl7j\" not patched\r\nexit\r\nexit\r\n[52.186.28.163] (local) docker@node1 ~/container.training/stacks\r\n$ \r\n```"},"comment":{"url":"https://api.github.com/repos/jpetazzo/container.training/issues/comments/380680369","html_url":"https://github.com/jpetazzo/container.training/pull/197#issuecomment-380680369","issue_url":"https://api.github.com/repos/jpetazzo/container.training/issues/197","id":380680369,"user":{"login":"jpetazzo","id":171481,"avatar_url":"https://avatars0.githubusercontent.com/u/171481?v=4","gravatar_id":"","url":"https://api.github.com/users/jpetazzo","html_url":"https://github.com/jpetazzo","followers_url":"https://api.github.com/users/jpetazzo/followers","following_url":"https://api.github.com/users/jpetazzo/following{/other_user}","gists_url":"https://api.github.com/users/jpetazzo/gists{/gist_id}","starred_url":"https://api.github.com/users/jpetazzo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jpetazzo/subscriptions","organizations_url":"https://api.github.com/users/jpetazzo/orgs","repos_url":"https://api.github.com/users/jpetazzo/repos","events_url":"https://api.github.com/users/jpetazzo/events{/privacy}","received_events_url":"https://api.github.com/users/jpetazzo/received_events","type":"User","site_admin":false},"created_at":"2018-04-12T05:13:32Z","updated_at":"2018-04-12T05:13:32Z","author_association":"OWNER","body":"Absolutely; I considered this to be OK initially, but now that I think again, I see a good learning opportunity.\r\n\r\nHere's what I have in mind:\r\n- instead of patching resources right away, show how do a dry run\r\n- when doing the dry run, notice there is an additional pod\r\n- explain how to scope things more accurately\r\n\r\nDo you think it's worth it?\r\n\r\n(And I can totally write that content some time next week :))"}}
{"actor":{"display_login":"jpetazzo"}}