{"action":"created","issue":{"url":"https://api.github.com/repos/kiali/kiali-ui/issues/824","repository_url":"https://api.github.com/repos/kiali/kiali-ui","labels_url":"https://api.github.com/repos/kiali/kiali-ui/issues/824/labels{/name}","comments_url":"https://api.github.com/repos/kiali/kiali-ui/issues/824/comments","events_url":"https://api.github.com/repos/kiali/kiali-ui/issues/824/events","html_url":"https://github.com/kiali/kiali-ui/pull/824","id":380672628,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwODE0OTQ1","number":824,"title":"KIALI-1888 UXD: Update Missing Sidecars icons","user":{"login":"aljesusg","id":3019213,"node_id":"MDQ6VXNlcjMwMTkyMTM=","avatar_url":"https://avatars2.githubusercontent.com/u/3019213?v=4","gravatar_id":"","url":"https://api.github.com/users/aljesusg","html_url":"https://github.com/aljesusg","followers_url":"https://api.github.com/users/aljesusg/followers","following_url":"https://api.github.com/users/aljesusg/following{/other_user}","gists_url":"https://api.github.com/users/aljesusg/gists{/gist_id}","starred_url":"https://api.github.com/users/aljesusg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aljesusg/subscriptions","organizations_url":"https://api.github.com/users/aljesusg/orgs","repos_url":"https://api.github.com/users/aljesusg/repos","events_url":"https://api.github.com/users/aljesusg/events{/privacy}","received_events_url":"https://api.github.com/users/aljesusg/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":34,"created_at":"2018-11-14T12:18:31Z","updated_at":"2018-11-29T18:14:51Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/kiali/kiali-ui/pulls/824","html_url":"https://github.com/kiali/kiali-ui/pull/824","diff_url":"https://github.com/kiali/kiali-ui/pull/824.diff","patch_url":"https://github.com/kiali/kiali-ui/pull/824.patch"},"body":"** Describe the change **\r\n\r\nReplace IstioSidecar logo by Pficon Blueprint\r\n\r\n** Issue reference **\r\n\r\nJIRA: [KIALI-1888](https://issues.jboss.org/browse/KIALI-1888)\r\n\r\n** Screenshot **\r\n\r\n# Workload List\r\n![workloads](https://user-images.githubusercontent.com/3019213/48482016-c4e07d00-e80f-11e8-89cd-3dd83110e565.png)\r\n# Services list\r\n![services](https://user-images.githubusercontent.com/3019213/48481968-a084a080-e80f-11e8-9e43-3b1901f6359e.png)\r\n# Application List\r\n![app](https://user-images.githubusercontent.com/3019213/48481969-a084a080-e80f-11e8-90c3-2f505642690c.png)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/kiali/kiali-ui/issues/comments/442937151","html_url":"https://github.com/kiali/kiali-ui/pull/824#issuecomment-442937151","issue_url":"https://api.github.com/repos/kiali/kiali-ui/issues/824","id":442937151,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MjkzNzE1MQ==","user":{"login":"aljesusg","id":3019213,"node_id":"MDQ6VXNlcjMwMTkyMTM=","avatar_url":"https://avatars2.githubusercontent.com/u/3019213?v=4","gravatar_id":"","url":"https://api.github.com/users/aljesusg","html_url":"https://github.com/aljesusg","followers_url":"https://api.github.com/users/aljesusg/followers","following_url":"https://api.github.com/users/aljesusg/following{/other_user}","gists_url":"https://api.github.com/users/aljesusg/gists{/gist_id}","starred_url":"https://api.github.com/users/aljesusg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aljesusg/subscriptions","organizations_url":"https://api.github.com/users/aljesusg/orgs","repos_url":"https://api.github.com/users/aljesusg/repos","events_url":"https://api.github.com/users/aljesusg/events{/privacy}","received_events_url":"https://api.github.com/users/aljesusg/received_events","type":"User","site_admin":false},"created_at":"2018-11-29T18:14:51Z","updated_at":"2018-11-29T18:14:51Z","author_association":"CONTRIBUTOR","body":"> In Workloads section of Application details page it used to be old sidecar icon when it existed.\r\n> Now when sidecar does not exist, the missing sidecar icon is not shown.\r\n\r\nThe image has different Workloads. If the workload has missing sidecar so the missing sidecar icon is  shown.\r\n\r\nNow we don't see the Istio icon with workloads that have istio sidecar deployed, only in the workloads that have not the istio sidecar.\r\n\r\nAbout \"sublist\" inside a item like the pods inside of a service there is a JIRA https://issues.jboss.org/browse/KIALI-1200\r\n\r\n> Shouldn't it be there?\r\n> \r\n> Before:\r\n> ![screenshot from 2018-11-29 18-56-02](https://user-images.githubusercontent.com/604313/49241734-06c11400-f409-11e8-8c9d-3641e1d9d112.png)\r\n> \r\n> After:\r\n> ![screenshot from 2018-11-29 18-41-08](https://user-images.githubusercontent.com/604313/49241738-0c1e5e80-f409-11e8-8e43-37e0a2dba050.png)\r\n\r\n"}}
{"actor":{"display_login":"aljesusg"}}