{"action":"created","issue":{"url":"https://api.github.com/repos/LiaisonTechnologies/lein-protoc/issues/14","repository_url":"https://api.github.com/repos/LiaisonTechnologies/lein-protoc","labels_url":"https://api.github.com/repos/LiaisonTechnologies/lein-protoc/issues/14/labels{/name}","comments_url":"https://api.github.com/repos/LiaisonTechnologies/lein-protoc/issues/14/comments","events_url":"https://api.github.com/repos/LiaisonTechnologies/lein-protoc/issues/14/events","html_url":"https://github.com/LiaisonTechnologies/lein-protoc/pull/14","id":350836377,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4NTgzMTgy","number":14,"title":"Add the ability to specify dependencies to include proto files from","user":{"login":"pashields","id":170202,"node_id":"MDQ6VXNlcjE3MDIwMg==","avatar_url":"https://avatars1.githubusercontent.com/u/170202?v=4","gravatar_id":"","url":"https://api.github.com/users/pashields","html_url":"https://github.com/pashields","followers_url":"https://api.github.com/users/pashields/followers","following_url":"https://api.github.com/users/pashields/following{/other_user}","gists_url":"https://api.github.com/users/pashields/gists{/gist_id}","starred_url":"https://api.github.com/users/pashields/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pashields/subscriptions","organizations_url":"https://api.github.com/users/pashields/orgs","repos_url":"https://api.github.com/users/pashields/repos","events_url":"https://api.github.com/users/pashields/events{/privacy}","received_events_url":"https://api.github.com/users/pashields/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-08-15T14:43:17Z","updated_at":"2018-08-27T17:27:50Z","closed_at":"2018-08-27T13:40:14Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/LiaisonTechnologies/lein-protoc/pulls/14","html_url":"https://github.com/LiaisonTechnologies/lein-protoc/pull/14","diff_url":"https://github.com/LiaisonTechnologies/lein-protoc/pull/14.diff","patch_url":"https://github.com/LiaisonTechnologies/lein-protoc/pull/14.patch"},"body":"This will allow plugin users to import proto files from other dependencies in their local proto files. We could search all their deps, but this commit allows users to whitelist specific deps. This was mostly a performance concern.\r\n\r\nThe proto dependency files will not be compiled, but will be included during protoc invocation.\r\n\r\nAfter adding this support, I did a little refactoring to use the same machinery for finding the standard google proto files. There is no advantage to this way, but it keeps us from having to fix bugs in two places. I still left the addition of the builtin protos on their own b/c the error handling is naturally different."},"comment":{"url":"https://api.github.com/repos/LiaisonTechnologies/lein-protoc/issues/comments/416302617","html_url":"https://github.com/LiaisonTechnologies/lein-protoc/pull/14#issuecomment-416302617","issue_url":"https://api.github.com/repos/LiaisonTechnologies/lein-protoc/issues/14","id":416302617,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNjMwMjYxNw==","user":{"login":"pashields","id":170202,"node_id":"MDQ6VXNlcjE3MDIwMg==","avatar_url":"https://avatars1.githubusercontent.com/u/170202?v=4","gravatar_id":"","url":"https://api.github.com/users/pashields","html_url":"https://github.com/pashields","followers_url":"https://api.github.com/users/pashields/followers","following_url":"https://api.github.com/users/pashields/following{/other_user}","gists_url":"https://api.github.com/users/pashields/gists{/gist_id}","starred_url":"https://api.github.com/users/pashields/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pashields/subscriptions","organizations_url":"https://api.github.com/users/pashields/orgs","repos_url":"https://api.github.com/users/pashields/repos","events_url":"https://api.github.com/users/pashields/events{/privacy}","received_events_url":"https://api.github.com/users/pashields/received_events","type":"User","site_admin":false},"created_at":"2018-08-27T17:27:50Z","updated_at":"2018-08-27T17:27:50Z","author_association":"CONTRIBUTOR","body":"Hope things slow down soon! Thanks again."}}
{"actor":{"display_login":"pashields"}}