{"action":"created","comment":{"url":"https://api.github.com/repos/nctl144/scurl/pulls/comments/201456735","pull_request_review_id":135963366,"id":201456735,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTQ1NjczNQ==","diff_hunk":"@@ -15,8 +16,7 @@\n                   Please get the latest version of Cython and try again!')\n \n try:\n-    if (os.environ['TOX'] == 'true' and","path":"setup.py","position":null,"original_position":12,"commit_id":"965eb03d24c7afdb8466d01894b57bc5131ef102","original_commit_id":"965eb03d24c7afdb8466d01894b57bc5131ef102","user":{"login":"nctl144","id":17996166,"node_id":"MDQ6VXNlcjE3OTk2MTY2","avatar_url":"https://avatars3.githubusercontent.com/u/17996166?v=4","gravatar_id":"","url":"https://api.github.com/users/nctl144","html_url":"https://github.com/nctl144","followers_url":"https://api.github.com/users/nctl144/followers","following_url":"https://api.github.com/users/nctl144/following{/other_user}","gists_url":"https://api.github.com/users/nctl144/gists{/gist_id}","starred_url":"https://api.github.com/users/nctl144/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nctl144/subscriptions","organizations_url":"https://api.github.com/users/nctl144/orgs","repos_url":"https://api.github.com/users/nctl144/repos","events_url":"https://api.github.com/users/nctl144/events{/privacy}","received_events_url":"https://api.github.com/users/nctl144/received_events","type":"User","site_admin":false},"body":"I just found out that we can get the platform information with **platform.python_implementation()**, what do you think @lopuhin ?","created_at":"2018-07-10T18:55:20Z","updated_at":"2018-07-10T18:55:20Z","html_url":"https://github.com/nctl144/scurl/pull/32#discussion_r201456735","pull_request_url":"https://api.github.com/repos/nctl144/scurl/pulls/32","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/nctl144/scurl/pulls/comments/201456735"},"html":{"href":"https://github.com/nctl144/scurl/pull/32#discussion_r201456735"},"pull_request":{"href":"https://api.github.com/repos/nctl144/scurl/pulls/32"}},"in_reply_to_id":201456345},"pull_request":{"url":"https://api.github.com/repos/nctl144/scurl/pulls/32","id":200194746,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwMTk0NzQ2","html_url":"https://github.com/nctl144/scurl/pull/32","diff_url":"https://github.com/nctl144/scurl/pull/32.diff","patch_url":"https://github.com/nctl144/scurl/pull/32.patch","issue_url":"https://api.github.com/repos/nctl144/scurl/issues/32","number":32,"state":"open","locked":false,"title":"Support different versions of Python","user":{"login":"nctl144","id":17996166,"node_id":"MDQ6VXNlcjE3OTk2MTY2","avatar_url":"https://avatars3.githubusercontent.com/u/17996166?v=4","gravatar_id":"","url":"https://api.github.com/users/nctl144","html_url":"https://github.com/nctl144","followers_url":"https://api.github.com/users/nctl144/followers","following_url":"https://api.github.com/users/nctl144/following{/other_user}","gists_url":"https://api.github.com/users/nctl144/gists{/gist_id}","starred_url":"https://api.github.com/users/nctl144/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nctl144/subscriptions","organizations_url":"https://api.github.com/users/nctl144/orgs","repos_url":"https://api.github.com/users/nctl144/repos","events_url":"https://api.github.com/users/nctl144/events{/privacy}","received_events_url":"https://api.github.com/users/nctl144/received_events","type":"User","site_admin":false},"body":"In this PR, I added more py env to the library to make sure the library can support multiple python versions. Right now, it passes py27, py34, py35 and py36 tests. I will make more updates to this PR soon. For py34, the test file for urlparse is a little bit different but I just copied that from the [3.4 branch](https://github.com/python/cpython/blob/77c02cdce2d7b8360771be35b7676a4977e070c1/Lib/test/test_urlparse.py)","created_at":"2018-07-09T19:19:39Z","updated_at":"2018-07-10T18:55:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"80589ccc75d78cdaba20dd0288cc132b9dcb391a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nctl144/scurl/pulls/32/commits","review_comments_url":"https://api.github.com/repos/nctl144/scurl/pulls/32/comments","review_comment_url":"https://api.github.com/repos/nctl144/scurl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nctl144/scurl/issues/32/comments","statuses_url":"https://api.github.com/repos/nctl144/scurl/statuses/965eb03d24c7afdb8466d01894b57bc5131ef102","head":{"label":"nctl144:pysp","ref":"pysp","sha":"965eb03d24c7afdb8466d01894b57bc5131ef102","user":{"login":"nctl144","id":17996166,"node_id":"MDQ6VXNlcjE3OTk2MTY2","avatar_url":"https://avatars3.githubusercontent.com/u/17996166?v=4","gravatar_id":"","url":"https://api.github.com/users/nctl144","html_url":"https://github.com/nctl144","followers_url":"https://api.github.com/users/nctl144/followers","following_url":"https://api.github.com/users/nctl144/following{/other_user}","gists_url":"https://api.github.com/users/nctl144/gists{/gist_id}","starred_url":"https://api.github.com/users/nctl144/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nctl144/subscriptions","organizations_url":"https://api.github.com/users/nctl144/orgs","repos_url":"https://api.github.com/users/nctl144/repos","events_url":"https://api.github.com/users/nctl144/events{/privacy}","received_events_url":"https://api.github.com/users/nctl144/received_events","type":"User","site_admin":false},"repo":{"id":136387875,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYzODc4NzU=","name":"scurl","full_name":"nctl144/scurl","owner":{"login":"nctl144","id":17996166,"node_id":"MDQ6VXNlcjE3OTk2MTY2","avatar_url":"https://avatars3.githubusercontent.com/u/17996166?v=4","gravatar_id":"","url":"https://api.github.com/users/nctl144","html_url":"https://github.com/nctl144","followers_url":"https://api.github.com/users/nctl144/followers","following_url":"https://api.github.com/users/nctl144/following{/other_user}","gists_url":"https://api.github.com/users/nctl144/gists{/gist_id}","starred_url":"https://api.github.com/users/nctl144/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nctl144/subscriptions","organizations_url":"https://api.github.com/users/nctl144/orgs","repos_url":"https://api.github.com/users/nctl144/repos","events_url":"https://api.github.com/users/nctl144/events{/privacy}","received_events_url":"https://api.github.com/users/nctl144/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nctl144/scurl","description":"Performance-focused replacement for Python urllib :)","fork":false,"url":"https://api.github.com/repos/nctl144/scurl","forks_url":"https://api.github.com/repos/nctl144/scurl/forks","keys_url":"https://api.github.com/repos/nctl144/scurl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nctl144/scurl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nctl144/scurl/teams","hooks_url":"https://api.github.com/repos/nctl144/scurl/hooks","issue_events_url":"https://api.github.com/repos/nctl144/scurl/issues/events{/number}","events_url":"https://api.github.com/repos/nctl144/scurl/events","assignees_url":"https://api.github.com/repos/nctl144/scurl/assignees{/user}","branches_url":"https://api.github.com/repos/nctl144/scurl/branches{/branch}","tags_url":"https://api.github.com/repos/nctl144/scurl/tags","blobs_url":"https://api.github.com/repos/nctl144/scurl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nctl144/scurl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nctl144/scurl/git/refs{/sha}","trees_url":"https://api.github.com/repos/nctl144/scurl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nctl144/scurl/statuses/{sha}","languages_url":"https://api.github.com/repos/nctl144/scurl/languages","stargazers_url":"https://api.github.com/repos/nctl144/scurl/stargazers","contributors_url":"https://api.github.com/repos/nctl144/scurl/contributors","subscribers_url":"https://api.github.com/repos/nctl144/scurl/subscribers","subscription_url":"https://api.github.com/repos/nctl144/scurl/subscription","commits_url":"https://api.github.com/repos/nctl144/scurl/commits{/sha}","git_commits_url":"https://api.github.com/repos/nctl144/scurl/git/commits{/sha}","comments_url":"https://api.github.com/repos/nctl144/scurl/comments{/number}","issue_comment_url":"https://api.github.com/repos/nctl144/scurl/issues/comments{/number}","contents_url":"https://api.github.com/repos/nctl144/scurl/contents/{+path}","compare_url":"https://api.github.com/repos/nctl144/scurl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nctl144/scurl/merges","archive_url":"https://api.github.com/repos/nctl144/scurl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nctl144/scurl/downloads","issues_url":"https://api.github.com/repos/nctl144/scurl/issues{/number}","pulls_url":"https://api.github.com/repos/nctl144/scurl/pulls{/number}","milestones_url":"https://api.github.com/repos/nctl144/scurl/milestones{/number}","notifications_url":"https://api.github.com/repos/nctl144/scurl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nctl144/scurl/labels{/name}","releases_url":"https://api.github.com/repos/nctl144/scurl/releases{/id}","deployments_url":"https://api.github.com/repos/nctl144/scurl/deployments","created_at":"2018-06-06T21:26:14Z","updated_at":"2018-07-09T18:20:39Z","pushed_at":"2018-07-10T18:52:13Z","git_url":"git://github.com/nctl144/scurl.git","ssh_url":"git@github.com:nctl144/scurl.git","clone_url":"https://github.com/nctl144/scurl.git","svn_url":"https://github.com/nctl144/scurl","homepage":"","size":6742,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":9,"watchers":6,"default_branch":"master"}},"base":{"label":"nctl144:master","ref":"master","sha":"9264a1ed234a63ff720d6c9e68680fb3c7f044ca","user":{"login":"nctl144","id":17996166,"node_id":"MDQ6VXNlcjE3OTk2MTY2","avatar_url":"https://avatars3.githubusercontent.com/u/17996166?v=4","gravatar_id":"","url":"https://api.github.com/users/nctl144","html_url":"https://github.com/nctl144","followers_url":"https://api.github.com/users/nctl144/followers","following_url":"https://api.github.com/users/nctl144/following{/other_user}","gists_url":"https://api.github.com/users/nctl144/gists{/gist_id}","starred_url":"https://api.github.com/users/nctl144/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nctl144/subscriptions","organizations_url":"https://api.github.com/users/nctl144/orgs","repos_url":"https://api.github.com/users/nctl144/repos","events_url":"https://api.github.com/users/nctl144/events{/privacy}","received_events_url":"https://api.github.com/users/nctl144/received_events","type":"User","site_admin":false},"repo":{"id":136387875,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYzODc4NzU=","name":"scurl","full_name":"nctl144/scurl","owner":{"login":"nctl144","id":17996166,"node_id":"MDQ6VXNlcjE3OTk2MTY2","avatar_url":"https://avatars3.githubusercontent.com/u/17996166?v=4","gravatar_id":"","url":"https://api.github.com/users/nctl144","html_url":"https://github.com/nctl144","followers_url":"https://api.github.com/users/nctl144/followers","following_url":"https://api.github.com/users/nctl144/following{/other_user}","gists_url":"https://api.github.com/users/nctl144/gists{/gist_id}","starred_url":"https://api.github.com/users/nctl144/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nctl144/subscriptions","organizations_url":"https://api.github.com/users/nctl144/orgs","repos_url":"https://api.github.com/users/nctl144/repos","events_url":"https://api.github.com/users/nctl144/events{/privacy}","received_events_url":"https://api.github.com/users/nctl144/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nctl144/scurl","description":"Performance-focused replacement for Python urllib :)","fork":false,"url":"https://api.github.com/repos/nctl144/scurl","forks_url":"https://api.github.com/repos/nctl144/scurl/forks","keys_url":"https://api.github.com/repos/nctl144/scurl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nctl144/scurl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nctl144/scurl/teams","hooks_url":"https://api.github.com/repos/nctl144/scurl/hooks","issue_events_url":"https://api.github.com/repos/nctl144/scurl/issues/events{/number}","events_url":"https://api.github.com/repos/nctl144/scurl/events","assignees_url":"https://api.github.com/repos/nctl144/scurl/assignees{/user}","branches_url":"https://api.github.com/repos/nctl144/scurl/branches{/branch}","tags_url":"https://api.github.com/repos/nctl144/scurl/tags","blobs_url":"https://api.github.com/repos/nctl144/scurl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nctl144/scurl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nctl144/scurl/git/refs{/sha}","trees_url":"https://api.github.com/repos/nctl144/scurl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nctl144/scurl/statuses/{sha}","languages_url":"https://api.github.com/repos/nctl144/scurl/languages","stargazers_url":"https://api.github.com/repos/nctl144/scurl/stargazers","contributors_url":"https://api.github.com/repos/nctl144/scurl/contributors","subscribers_url":"https://api.github.com/repos/nctl144/scurl/subscribers","subscription_url":"https://api.github.com/repos/nctl144/scurl/subscription","commits_url":"https://api.github.com/repos/nctl144/scurl/commits{/sha}","git_commits_url":"https://api.github.com/repos/nctl144/scurl/git/commits{/sha}","comments_url":"https://api.github.com/repos/nctl144/scurl/comments{/number}","issue_comment_url":"https://api.github.com/repos/nctl144/scurl/issues/comments{/number}","contents_url":"https://api.github.com/repos/nctl144/scurl/contents/{+path}","compare_url":"https://api.github.com/repos/nctl144/scurl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nctl144/scurl/merges","archive_url":"https://api.github.com/repos/nctl144/scurl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nctl144/scurl/downloads","issues_url":"https://api.github.com/repos/nctl144/scurl/issues{/number}","pulls_url":"https://api.github.com/repos/nctl144/scurl/pulls{/number}","milestones_url":"https://api.github.com/repos/nctl144/scurl/milestones{/number}","notifications_url":"https://api.github.com/repos/nctl144/scurl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nctl144/scurl/labels{/name}","releases_url":"https://api.github.com/repos/nctl144/scurl/releases{/id}","deployments_url":"https://api.github.com/repos/nctl144/scurl/deployments","created_at":"2018-06-06T21:26:14Z","updated_at":"2018-07-09T18:20:39Z","pushed_at":"2018-07-10T18:52:13Z","git_url":"git://github.com/nctl144/scurl.git","ssh_url":"git@github.com:nctl144/scurl.git","clone_url":"https://github.com/nctl144/scurl.git","svn_url":"https://github.com/nctl144/scurl","homepage":"","size":6742,"stargazers_count":6,"watchers_count":6,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":9,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nctl144/scurl/pulls/32"},"html":{"href":"https://github.com/nctl144/scurl/pull/32"},"issue":{"href":"https://api.github.com/repos/nctl144/scurl/issues/32"},"comments":{"href":"https://api.github.com/repos/nctl144/scurl/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/nctl144/scurl/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/nctl144/scurl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nctl144/scurl/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/nctl144/scurl/statuses/965eb03d24c7afdb8466d01894b57bc5131ef102"}},"author_association":"OWNER"}}
{"actor":{"display_login":"nctl144"}}