{"action":"created","comment":{"url":"https://api.github.com/repos/blt/port_compiler/pulls/comments/168059277","pull_request_review_id":96365576,"id":168059277,"diff_hunk":"@@ -81,6 +81,19 @@ BELOW HERE BE DRAGONS\n %%                {ArchRegex, TargetFile, Sources}\n %%                {TargetFile, Sources}\n %%\n+%%                Note that if you want to use any of the rebar3 variables\n+%%                below you must MUST use a ${}-style to get the expansion\n+%%                to work. e.g. to expand REBAR_DEPS_DIR, do something like:\n+%%\n+%%                {port_specs, [{\"priv/nif.so\",\n+%%                               [\"c_src/nif.c\",\n+%%                                \"${REBAR_DEPS_DIR}/foo/bar.c\"]}]}.\n+%%\n+%%                This is a _very_ good way to be able to use you code both","path":"README.md","position":12,"original_position":12,"commit_id":"b5a4c87638b749377b98be42f4d8ad191c49b042","original_commit_id":"b5a4c87638b749377b98be42f4d8ad191c49b042","user":{"login":"tuncer","id":4232,"avatar_url":"https://avatars0.githubusercontent.com/u/4232?v=4","gravatar_id":"","url":"https://api.github.com/users/tuncer","html_url":"https://github.com/tuncer","followers_url":"https://api.github.com/users/tuncer/followers","following_url":"https://api.github.com/users/tuncer/following{/other_user}","gists_url":"https://api.github.com/users/tuncer/gists{/gist_id}","starred_url":"https://api.github.com/users/tuncer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuncer/subscriptions","organizations_url":"https://api.github.com/users/tuncer/orgs","repos_url":"https://api.github.com/users/tuncer/repos","events_url":"https://api.github.com/users/tuncer/events{/privacy}","received_events_url":"https://api.github.com/users/tuncer/received_events","type":"User","site_admin":false},"body":"Is this supposed to say _your code_?","created_at":"2018-02-14T01:54:50Z","updated_at":"2018-02-14T01:54:50Z","html_url":"https://github.com/blt/port_compiler/pull/38#discussion_r168059277","pull_request_url":"https://api.github.com/repos/blt/port_compiler/pulls/38","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/blt/port_compiler/pulls/comments/168059277"},"html":{"href":"https://github.com/blt/port_compiler/pull/38#discussion_r168059277"},"pull_request":{"href":"https://api.github.com/repos/blt/port_compiler/pulls/38"}}},"pull_request":{"url":"https://api.github.com/repos/blt/port_compiler/pulls/38","id":163999315,"html_url":"https://github.com/blt/port_compiler/pull/38","diff_url":"https://github.com/blt/port_compiler/pull/38.diff","patch_url":"https://github.com/blt/port_compiler/pull/38.patch","issue_url":"https://api.github.com/repos/blt/port_compiler/issues/38","number":38,"state":"open","locked":false,"title":"Expand env vars","user":{"login":"cjkjellander","id":596492,"avatar_url":"https://avatars0.githubusercontent.com/u/596492?v=4","gravatar_id":"","url":"https://api.github.com/users/cjkjellander","html_url":"https://github.com/cjkjellander","followers_url":"https://api.github.com/users/cjkjellander/followers","following_url":"https://api.github.com/users/cjkjellander/following{/other_user}","gists_url":"https://api.github.com/users/cjkjellander/gists{/gist_id}","starred_url":"https://api.github.com/users/cjkjellander/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjkjellander/subscriptions","organizations_url":"https://api.github.com/users/cjkjellander/orgs","repos_url":"https://api.github.com/users/cjkjellander/repos","events_url":"https://api.github.com/users/cjkjellander/events{/privacy}","received_events_url":"https://api.github.com/users/cjkjellander/received_events","type":"User","site_admin":false},"body":"This fixes https://github.com/blt/port_compiler/issues/30 and lets both env variables be exported and you can now use env variables from rebar3 inside port_specs, as they are expanded while evaluating the port_specs.\r\n\r\nIt depends on https://github.com/erlang/rebar3/pull/1706 which in turn depends on https://github.com/erlang/rebar3/pull/1698 but it is written so it shouldn't crash if using an older rebar3. Please check that it doesn't crash for you, before merge:ing.\r\n\r\nAlso I have updated the README to reflect how to use the env variables inside port_specs cause it depends on how rebar3 exports variables. Specifically, it needs ${} expansion, but at least it works.\r\n\r\n","created_at":"2018-01-19T15:37:24Z","updated_at":"2018-02-14T01:54:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"08deb730974273ab4a646ef3dd171c63076171dd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/blt/port_compiler/pulls/38/commits","review_comments_url":"https://api.github.com/repos/blt/port_compiler/pulls/38/comments","review_comment_url":"https://api.github.com/repos/blt/port_compiler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/blt/port_compiler/issues/38/comments","statuses_url":"https://api.github.com/repos/blt/port_compiler/statuses/b5a4c87638b749377b98be42f4d8ad191c49b042","head":{"label":"campanja-forks:expand_env_vars","ref":"expand_env_vars","sha":"b5a4c87638b749377b98be42f4d8ad191c49b042","user":{"login":"campanja-forks","id":10634329,"avatar_url":"https://avatars0.githubusercontent.com/u/10634329?v=4","gravatar_id":"","url":"https://api.github.com/users/campanja-forks","html_url":"https://github.com/campanja-forks","followers_url":"https://api.github.com/users/campanja-forks/followers","following_url":"https://api.github.com/users/campanja-forks/following{/other_user}","gists_url":"https://api.github.com/users/campanja-forks/gists{/gist_id}","starred_url":"https://api.github.com/users/campanja-forks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/campanja-forks/subscriptions","organizations_url":"https://api.github.com/users/campanja-forks/orgs","repos_url":"https://api.github.com/users/campanja-forks/repos","events_url":"https://api.github.com/users/campanja-forks/events{/privacy}","received_events_url":"https://api.github.com/users/campanja-forks/received_events","type":"Organization","site_admin":false},"repo":{"id":115627287,"name":"port_compiler","full_name":"campanja-forks/port_compiler","owner":{"login":"campanja-forks","id":10634329,"avatar_url":"https://avatars0.githubusercontent.com/u/10634329?v=4","gravatar_id":"","url":"https://api.github.com/users/campanja-forks","html_url":"https://github.com/campanja-forks","followers_url":"https://api.github.com/users/campanja-forks/followers","following_url":"https://api.github.com/users/campanja-forks/following{/other_user}","gists_url":"https://api.github.com/users/campanja-forks/gists{/gist_id}","starred_url":"https://api.github.com/users/campanja-forks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/campanja-forks/subscriptions","organizations_url":"https://api.github.com/users/campanja-forks/orgs","repos_url":"https://api.github.com/users/campanja-forks/repos","events_url":"https://api.github.com/users/campanja-forks/events{/privacy}","received_events_url":"https://api.github.com/users/campanja-forks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/campanja-forks/port_compiler","description":"A rebar3 port compiler","fork":true,"url":"https://api.github.com/repos/campanja-forks/port_compiler","forks_url":"https://api.github.com/repos/campanja-forks/port_compiler/forks","keys_url":"https://api.github.com/repos/campanja-forks/port_compiler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/campanja-forks/port_compiler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/campanja-forks/port_compiler/teams","hooks_url":"https://api.github.com/repos/campanja-forks/port_compiler/hooks","issue_events_url":"https://api.github.com/repos/campanja-forks/port_compiler/issues/events{/number}","events_url":"https://api.github.com/repos/campanja-forks/port_compiler/events","assignees_url":"https://api.github.com/repos/campanja-forks/port_compiler/assignees{/user}","branches_url":"https://api.github.com/repos/campanja-forks/port_compiler/branches{/branch}","tags_url":"https://api.github.com/repos/campanja-forks/port_compiler/tags","blobs_url":"https://api.github.com/repos/campanja-forks/port_compiler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/campanja-forks/port_compiler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/campanja-forks/port_compiler/git/refs{/sha}","trees_url":"https://api.github.com/repos/campanja-forks/port_compiler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/campanja-forks/port_compiler/statuses/{sha}","languages_url":"https://api.github.com/repos/campanja-forks/port_compiler/languages","stargazers_url":"https://api.github.com/repos/campanja-forks/port_compiler/stargazers","contributors_url":"https://api.github.com/repos/campanja-forks/port_compiler/contributors","subscribers_url":"https://api.github.com/repos/campanja-forks/port_compiler/subscribers","subscription_url":"https://api.github.com/repos/campanja-forks/port_compiler/subscription","commits_url":"https://api.github.com/repos/campanja-forks/port_compiler/commits{/sha}","git_commits_url":"https://api.github.com/repos/campanja-forks/port_compiler/git/commits{/sha}","comments_url":"https://api.github.com/repos/campanja-forks/port_compiler/comments{/number}","issue_comment_url":"https://api.github.com/repos/campanja-forks/port_compiler/issues/comments{/number}","contents_url":"https://api.github.com/repos/campanja-forks/port_compiler/contents/{+path}","compare_url":"https://api.github.com/repos/campanja-forks/port_compiler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/campanja-forks/port_compiler/merges","archive_url":"https://api.github.com/repos/campanja-forks/port_compiler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/campanja-forks/port_compiler/downloads","issues_url":"https://api.github.com/repos/campanja-forks/port_compiler/issues{/number}","pulls_url":"https://api.github.com/repos/campanja-forks/port_compiler/pulls{/number}","milestones_url":"https://api.github.com/repos/campanja-forks/port_compiler/milestones{/number}","notifications_url":"https://api.github.com/repos/campanja-forks/port_compiler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/campanja-forks/port_compiler/labels{/name}","releases_url":"https://api.github.com/repos/campanja-forks/port_compiler/releases{/id}","deployments_url":"https://api.github.com/repos/campanja-forks/port_compiler/deployments","created_at":"2017-12-28T13:45:31Z","updated_at":"2017-12-28T13:45:33Z","pushed_at":"2018-01-19T14:43:51Z","git_url":"git://github.com/campanja-forks/port_compiler.git","ssh_url":"git@github.com:campanja-forks/port_compiler.git","clone_url":"https://github.com/campanja-forks/port_compiler.git","svn_url":"https://github.com/campanja-forks/port_compiler","homepage":"","size":60,"stargazers_count":0,"watchers_count":0,"language":"Erlang","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"blt:master","ref":"master","sha":"01c51432769dd4e558af889a280374c4bb30d3ba","user":{"login":"blt","id":3579,"avatar_url":"https://avatars0.githubusercontent.com/u/3579?v=4","gravatar_id":"","url":"https://api.github.com/users/blt","html_url":"https://github.com/blt","followers_url":"https://api.github.com/users/blt/followers","following_url":"https://api.github.com/users/blt/following{/other_user}","gists_url":"https://api.github.com/users/blt/gists{/gist_id}","starred_url":"https://api.github.com/users/blt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blt/subscriptions","organizations_url":"https://api.github.com/users/blt/orgs","repos_url":"https://api.github.com/users/blt/repos","events_url":"https://api.github.com/users/blt/events{/privacy}","received_events_url":"https://api.github.com/users/blt/received_events","type":"User","site_admin":false},"repo":{"id":33048493,"name":"port_compiler","full_name":"blt/port_compiler","owner":{"login":"blt","id":3579,"avatar_url":"https://avatars0.githubusercontent.com/u/3579?v=4","gravatar_id":"","url":"https://api.github.com/users/blt","html_url":"https://github.com/blt","followers_url":"https://api.github.com/users/blt/followers","following_url":"https://api.github.com/users/blt/following{/other_user}","gists_url":"https://api.github.com/users/blt/gists{/gist_id}","starred_url":"https://api.github.com/users/blt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blt/subscriptions","organizations_url":"https://api.github.com/users/blt/orgs","repos_url":"https://api.github.com/users/blt/repos","events_url":"https://api.github.com/users/blt/events{/privacy}","received_events_url":"https://api.github.com/users/blt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/blt/port_compiler","description":"A rebar3 port compiler","fork":false,"url":"https://api.github.com/repos/blt/port_compiler","forks_url":"https://api.github.com/repos/blt/port_compiler/forks","keys_url":"https://api.github.com/repos/blt/port_compiler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/blt/port_compiler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/blt/port_compiler/teams","hooks_url":"https://api.github.com/repos/blt/port_compiler/hooks","issue_events_url":"https://api.github.com/repos/blt/port_compiler/issues/events{/number}","events_url":"https://api.github.com/repos/blt/port_compiler/events","assignees_url":"https://api.github.com/repos/blt/port_compiler/assignees{/user}","branches_url":"https://api.github.com/repos/blt/port_compiler/branches{/branch}","tags_url":"https://api.github.com/repos/blt/port_compiler/tags","blobs_url":"https://api.github.com/repos/blt/port_compiler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/blt/port_compiler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/blt/port_compiler/git/refs{/sha}","trees_url":"https://api.github.com/repos/blt/port_compiler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/blt/port_compiler/statuses/{sha}","languages_url":"https://api.github.com/repos/blt/port_compiler/languages","stargazers_url":"https://api.github.com/repos/blt/port_compiler/stargazers","contributors_url":"https://api.github.com/repos/blt/port_compiler/contributors","subscribers_url":"https://api.github.com/repos/blt/port_compiler/subscribers","subscription_url":"https://api.github.com/repos/blt/port_compiler/subscription","commits_url":"https://api.github.com/repos/blt/port_compiler/commits{/sha}","git_commits_url":"https://api.github.com/repos/blt/port_compiler/git/commits{/sha}","comments_url":"https://api.github.com/repos/blt/port_compiler/comments{/number}","issue_comment_url":"https://api.github.com/repos/blt/port_compiler/issues/comments{/number}","contents_url":"https://api.github.com/repos/blt/port_compiler/contents/{+path}","compare_url":"https://api.github.com/repos/blt/port_compiler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/blt/port_compiler/merges","archive_url":"https://api.github.com/repos/blt/port_compiler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/blt/port_compiler/downloads","issues_url":"https://api.github.com/repos/blt/port_compiler/issues{/number}","pulls_url":"https://api.github.com/repos/blt/port_compiler/pulls{/number}","milestones_url":"https://api.github.com/repos/blt/port_compiler/milestones{/number}","notifications_url":"https://api.github.com/repos/blt/port_compiler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/blt/port_compiler/labels{/name}","releases_url":"https://api.github.com/repos/blt/port_compiler/releases{/id}","deployments_url":"https://api.github.com/repos/blt/port_compiler/deployments","created_at":"2015-03-28T20:10:14Z","updated_at":"2018-01-01T20:08:25Z","pushed_at":"2018-02-13T22:23:02Z","git_url":"git://github.com/blt/port_compiler.git","ssh_url":"git@github.com:blt/port_compiler.git","clone_url":"https://github.com/blt/port_compiler.git","svn_url":"https://github.com/blt/port_compiler","homepage":"","size":55,"stargazers_count":28,"watchers_count":28,"language":"Erlang","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":14,"open_issues":9,"watchers":28,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/blt/port_compiler/pulls/38"},"html":{"href":"https://github.com/blt/port_compiler/pull/38"},"issue":{"href":"https://api.github.com/repos/blt/port_compiler/issues/38"},"comments":{"href":"https://api.github.com/repos/blt/port_compiler/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/blt/port_compiler/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/blt/port_compiler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/blt/port_compiler/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/blt/port_compiler/statuses/b5a4c87638b749377b98be42f4d8ad191c49b042"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tuncer"}}