{"action":"created","issue":{"url":"https://api.github.com/repos/cherow/cherow/issues/86","repository_url":"https://api.github.com/repos/cherow/cherow","labels_url":"https://api.github.com/repos/cherow/cherow/issues/86/labels{/name}","comments_url":"https://api.github.com/repos/cherow/cherow/issues/86/comments","events_url":"https://api.github.com/repos/cherow/cherow/issues/86/events","html_url":"https://github.com/cherow/cherow/issues/86","id":308915196,"number":86,"title":"Re-export all declarations in cherow.d.ts for better TypeScript support","user":{"login":"fkleuver","id":9655331,"avatar_url":"https://avatars1.githubusercontent.com/u/9655331?v=4","gravatar_id":"","url":"https://api.github.com/users/fkleuver","html_url":"https://github.com/fkleuver","followers_url":"https://api.github.com/users/fkleuver/followers","following_url":"https://api.github.com/users/fkleuver/following{/other_user}","gists_url":"https://api.github.com/users/fkleuver/gists{/gist_id}","starred_url":"https://api.github.com/users/fkleuver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fkleuver/subscriptions","organizations_url":"https://api.github.com/users/fkleuver/orgs","repos_url":"https://api.github.com/users/fkleuver/repos","events_url":"https://api.github.com/users/fkleuver/events{/privacy}","received_events_url":"https://api.github.com/users/fkleuver/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-27T10:42:18Z","updated_at":"2018-03-27T13:32:10Z","closed_at":null,"author_association":"NONE","body":"First of all, absolutely love this parser! Great job :)\r\n\r\nCurrently it's very tricky to get definitions like ESTree imported in TypeScript. By default the node module points to `cherow.d.ts` which only exports `parse`, `parseModule` and `parseScript`. It would require manual path mappings in tsconfig and whatnot to get access to the other `.d.ts` files.\r\n\r\nIf you did `export * from './estree'` (as well as for the other definition files), this would make things so much easier for TypeScript users.\r\n\r\nIs this an oversight or is this intentional for some particular reason? If so, what is currently the recommended way to get other definitions imported? If not, could the rest be re-exported in `cherow.d.ts` please?\r\n\r\nAppreciate your time!"},"comment":{"url":"https://api.github.com/repos/cherow/cherow/issues/comments/376525977","html_url":"https://github.com/cherow/cherow/issues/86#issuecomment-376525977","issue_url":"https://api.github.com/repos/cherow/cherow/issues/86","id":376525977,"user":{"login":"fkleuver","id":9655331,"avatar_url":"https://avatars1.githubusercontent.com/u/9655331?v=4","gravatar_id":"","url":"https://api.github.com/users/fkleuver","html_url":"https://github.com/fkleuver","followers_url":"https://api.github.com/users/fkleuver/followers","following_url":"https://api.github.com/users/fkleuver/following{/other_user}","gists_url":"https://api.github.com/users/fkleuver/gists{/gist_id}","starred_url":"https://api.github.com/users/fkleuver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fkleuver/subscriptions","organizations_url":"https://api.github.com/users/fkleuver/orgs","repos_url":"https://api.github.com/users/fkleuver/repos","events_url":"https://api.github.com/users/fkleuver/events{/privacy}","received_events_url":"https://api.github.com/users/fkleuver/received_events","type":"User","site_admin":false},"created_at":"2018-03-27T13:32:10Z","updated_at":"2018-03-27T13:32:10Z","author_association":"NONE","body":"Sure. There seems to be a name conflict though.\r\n\r\nBoth `estree.ts` and `flags.ts` have an export named `JSXElement` (the former is an interface, the latter is a const enum).\r\n\r\nWould it be an idea perhaps to rename the enum to something like `JSXElementKind` to resolve the conflict? Could also just export it with that as an alias, but some might consider that to be messy."}}
{"actor":{"display_login":"fkleuver"}}