{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/cluster-samples-operator/pulls/comments/219263343","pull_request_review_id":157398548,"id":219263343,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTI2MzM0Mw==","diff_hunk":"@@ -278,6 +281,32 @@ func (h *Handler) Handle(ctx context.Context, event sdk.Event) error {\n \t\t\tif newVersion <= currVersion {\n \t\t\t\treturn nil\n \t\t\t}\n+\t\t\tif len(srcfg.Spec.InstallType) == 0 &&\n+\t\t\t\th.samplesResource.Status.InstallType != v1alpha1.CentosSamplesDistribution {\n+\t\t\t\terr := fmt.Errorf(\"cannot change install type from %q to %q\",\n+\t\t\t\t\th.samplesResource.Status.InstallType, srcfg.Spec.InstallType)\n+\t\t\t\treturn h.processError(srcfg, v1alpha1.SamplesUpdateFailed, err, \"%v\")\n+\t\t\t}\n+\t\t\tif len(srcfg.Spec.InstallType) != 0 &&\n+\t\t\t\tsrcfg.Spec.InstallType != h.samplesResource.Status.InstallType {\n+\t\t\t\terr := fmt.Errorf(\"cannot change install type from %q to %q\",\n+\t\t\t\t\th.samplesResource.Status.InstallType, srcfg.Spec.InstallType)\n+\t\t\t\treturn h.processError(srcfg, v1alpha1.SamplesUpdateFailed, err, \"%v\")\n+\t\t\t}\n+\n+\t\t\tif len(srcfg.Spec.Architectures) == 0 &&\n+\t\t\t\t(len(h.samplesResource.Status.Architectures) != 1 ||\n+\t\t\t\t\th.samplesResource.Status.Architectures[0] != x86) {\n+\t\t\t\terr := fmt.Errorf(\"cannot change from architecture list %#v to %#v\",\n+\t\t\t\t\th.samplesResource.Status.Architectures, srcfg.Spec.Architectures)\n+\t\t\t\treturn h.processError(srcfg, v1alpha1.SamplesUpdateFailed, err, \"%v\")\n+\t\t\t}\n+\t\t\tif len(srcfg.Spec.Architectures) != 0 &&\n+\t\t\t\t!reflect.DeepEqual(srcfg.Spec.Architectures, h.samplesResource.Status.Architectures) {","path":"pkg/stub/handler.go","position":42,"original_position":42,"commit_id":"b76130ad51e457ab8d9737f5a027a8f8af0f2232","original_commit_id":"b76130ad51e457ab8d9737f5a027a8f8af0f2232","user":{"login":"gabemontero","id":3594868,"node_id":"MDQ6VXNlcjM1OTQ4Njg=","avatar_url":"https://avatars0.githubusercontent.com/u/3594868?v=4","gravatar_id":"","url":"https://api.github.com/users/gabemontero","html_url":"https://github.com/gabemontero","followers_url":"https://api.github.com/users/gabemontero/followers","following_url":"https://api.github.com/users/gabemontero/following{/other_user}","gists_url":"https://api.github.com/users/gabemontero/gists{/gist_id}","starred_url":"https://api.github.com/users/gabemontero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabemontero/subscriptions","organizations_url":"https://api.github.com/users/gabemontero/orgs","repos_url":"https://api.github.com/users/gabemontero/repos","events_url":"https://api.github.com/users/gabemontero/events{/privacy}","received_events_url":"https://api.github.com/users/gabemontero/received_events","type":"User","site_admin":false},"body":"ah gotcha \r\n\r\nand yep, a stackoverflow lead me to believe it would not matter, but just tried it in go playground and order does matter\r\n\r\nBut as I said before, I think the switch to configmap will negate this.","created_at":"2018-09-20T18:04:45Z","updated_at":"2018-09-20T18:04:45Z","html_url":"https://github.com/openshift/cluster-samples-operator/pull/15#discussion_r219263343","pull_request_url":"https://api.github.com/repos/openshift/cluster-samples-operator/pulls/15","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openshift/cluster-samples-operator/pulls/comments/219263343"},"html":{"href":"https://github.com/openshift/cluster-samples-operator/pull/15#discussion_r219263343"},"pull_request":{"href":"https://api.github.com/repos/openshift/cluster-samples-operator/pulls/15"}},"in_reply_to_id":219004893},"pull_request":{"url":"https://api.github.com/repos/openshift/cluster-samples-operator/pulls/15","id":216793882,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2NzkzODgy","html_url":"https://github.com/openshift/cluster-samples-operator/pull/15","diff_url":"https://github.com/openshift/cluster-samples-operator/pull/15.diff","patch_url":"https://github.com/openshift/cluster-samples-operator/pull/15.patch","issue_url":"https://api.github.com/repos/openshift/cluster-samples-operator/issues/15","number":15,"state":"open","locked":false,"title":"Group skip dir name","user":{"login":"gabemontero","id":3594868,"node_id":"MDQ6VXNlcjM1OTQ4Njg=","avatar_url":"https://avatars0.githubusercontent.com/u/3594868?v=4","gravatar_id":"","url":"https://api.github.com/users/gabemontero","html_url":"https://github.com/gabemontero","followers_url":"https://api.github.com/users/gabemontero/followers","following_url":"https://api.github.com/users/gabemontero/following{/other_user}","gists_url":"https://api.github.com/users/gabemontero/gists{/gist_id}","starred_url":"https://api.github.com/users/gabemontero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabemontero/subscriptions","organizations_url":"https://api.github.com/users/gabemontero/orgs","repos_url":"https://api.github.com/users/gabemontero/repos","events_url":"https://api.github.com/users/gabemontero/events{/privacy}","received_events_url":"https://api.github.com/users/gabemontero/received_events","type":"User","site_admin":false},"body":"@openshift/sig-developer-experience fyi/ptal\r\n\r\na collection of changes based on ideas of mine or discussions with @bparees on #aos-devexp","created_at":"2018-09-19T22:20:50Z","updated_at":"2018-09-20T18:04:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1f4061fd21951a3b992cdb1cd725f223992784b3","assignee":null,"assignees":[],"requested_reviewers":[{"login":"dmage","id":443137,"node_id":"MDQ6VXNlcjQ0MzEzNw==","avatar_url":"https://avatars0.githubusercontent.com/u/443137?v=4","gravatar_id":"","url":"https://api.github.com/users/dmage","html_url":"https://github.com/dmage","followers_url":"https://api.github.com/users/dmage/followers","following_url":"https://api.github.com/users/dmage/following{/other_user}","gists_url":"https://api.github.com/users/dmage/gists{/gist_id}","starred_url":"https://api.github.com/users/dmage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmage/subscriptions","organizations_url":"https://api.github.com/users/dmage/orgs","repos_url":"https://api.github.com/users/dmage/repos","events_url":"https://api.github.com/users/dmage/events{/privacy}","received_events_url":"https://api.github.com/users/dmage/received_events","type":"User","site_admin":false},{"login":"coreydaley","id":5060301,"node_id":"MDQ6VXNlcjUwNjAzMDE=","avatar_url":"https://avatars2.githubusercontent.com/u/5060301?v=4","gravatar_id":"","url":"https://api.github.com/users/coreydaley","html_url":"https://github.com/coreydaley","followers_url":"https://api.github.com/users/coreydaley/followers","following_url":"https://api.github.com/users/coreydaley/following{/other_user}","gists_url":"https://api.github.com/users/coreydaley/gists{/gist_id}","starred_url":"https://api.github.com/users/coreydaley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreydaley/subscriptions","organizations_url":"https://api.github.com/users/coreydaley/orgs","repos_url":"https://api.github.com/users/coreydaley/repos","events_url":"https://api.github.com/users/coreydaley/events{/privacy}","received_events_url":"https://api.github.com/users/coreydaley/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1027940881,"node_id":"MDU6TGFiZWwxMDI3OTQwODgx","url":"https://api.github.com/repos/openshift/cluster-samples-operator/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":1027939883,"node_id":"MDU6TGFiZWwxMDI3OTM5ODgz","url":"https://api.github.com/repos/openshift/cluster-samples-operator/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/cluster-samples-operator/pulls/15/commits","review_comments_url":"https://api.github.com/repos/openshift/cluster-samples-operator/pulls/15/comments","review_comment_url":"https://api.github.com/repos/openshift/cluster-samples-operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/cluster-samples-operator/issues/15/comments","statuses_url":"https://api.github.com/repos/openshift/cluster-samples-operator/statuses/b76130ad51e457ab8d9737f5a027a8f8af0f2232","head":{"label":"gabemontero:group-skip-dir-name","ref":"group-skip-dir-name","sha":"b76130ad51e457ab8d9737f5a027a8f8af0f2232","user":{"login":"gabemontero","id":3594868,"node_id":"MDQ6VXNlcjM1OTQ4Njg=","avatar_url":"https://avatars0.githubusercontent.com/u/3594868?v=4","gravatar_id":"","url":"https://api.github.com/users/gabemontero","html_url":"https://github.com/gabemontero","followers_url":"https://api.github.com/users/gabemontero/followers","following_url":"https://api.github.com/users/gabemontero/following{/other_user}","gists_url":"https://api.github.com/users/gabemontero/gists{/gist_id}","starred_url":"https://api.github.com/users/gabemontero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabemontero/subscriptions","organizations_url":"https://api.github.com/users/gabemontero/orgs","repos_url":"https://api.github.com/users/gabemontero/repos","events_url":"https://api.github.com/users/gabemontero/events{/privacy}","received_events_url":"https://api.github.com/users/gabemontero/received_events","type":"User","site_admin":false},"repo":{"id":145433942,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU0MzM5NDI=","name":"cluster-samples-operator","full_name":"gabemontero/cluster-samples-operator","private":false,"owner":{"login":"gabemontero","id":3594868,"node_id":"MDQ6VXNlcjM1OTQ4Njg=","avatar_url":"https://avatars0.githubusercontent.com/u/3594868?v=4","gravatar_id":"","url":"https://api.github.com/users/gabemontero","html_url":"https://github.com/gabemontero","followers_url":"https://api.github.com/users/gabemontero/followers","following_url":"https://api.github.com/users/gabemontero/following{/other_user}","gists_url":"https://api.github.com/users/gabemontero/gists{/gist_id}","starred_url":"https://api.github.com/users/gabemontero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gabemontero/subscriptions","organizations_url":"https://api.github.com/users/gabemontero/orgs","repos_url":"https://api.github.com/users/gabemontero/repos","events_url":"https://api.github.com/users/gabemontero/events{/privacy}","received_events_url":"https://api.github.com/users/gabemontero/received_events","type":"User","site_admin":false},"html_url":"https://github.com/gabemontero/cluster-samples-operator","description":"The samples operator installs+maintains the sample templates+imagestreams on a cluster","fork":true,"url":"https://api.github.com/repos/gabemontero/cluster-samples-operator","forks_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/forks","keys_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/teams","hooks_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/hooks","issue_events_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/issues/events{/number}","events_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/events","assignees_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/assignees{/user}","branches_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/branches{/branch}","tags_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/tags","blobs_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/languages","stargazers_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/stargazers","contributors_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/contributors","subscribers_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/subscribers","subscription_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/subscription","commits_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/contents/{+path}","compare_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/merges","archive_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/downloads","issues_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/issues{/number}","pulls_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/labels{/name}","releases_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/releases{/id}","deployments_url":"https://api.github.com/repos/gabemontero/cluster-samples-operator/deployments","created_at":"2018-08-20T15:12:46Z","updated_at":"2018-09-19T14:43:11Z","pushed_at":"2018-09-19T22:19:42Z","git_url":"git://github.com/gabemontero/cluster-samples-operator.git","ssh_url":"git@github.com:gabemontero/cluster-samples-operator.git","clone_url":"https://github.com/gabemontero/cluster-samples-operator.git","svn_url":"https://github.com/gabemontero/cluster-samples-operator","homepage":null,"size":21033,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"cdabf4b5c3660c813829b90a5108b76216a7d9c4","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":145157415,"node_id":"MDEwOlJlcG9zaXRvcnkxNDUxNTc0MTU=","name":"cluster-samples-operator","full_name":"openshift/cluster-samples-operator","private":false,"owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openshift/cluster-samples-operator","description":"The samples operator installs+maintains the sample templates+imagestreams on a cluster","fork":false,"url":"https://api.github.com/repos/openshift/cluster-samples-operator","forks_url":"https://api.github.com/repos/openshift/cluster-samples-operator/forks","keys_url":"https://api.github.com/repos/openshift/cluster-samples-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/cluster-samples-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/cluster-samples-operator/teams","hooks_url":"https://api.github.com/repos/openshift/cluster-samples-operator/hooks","issue_events_url":"https://api.github.com/repos/openshift/cluster-samples-operator/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/cluster-samples-operator/events","assignees_url":"https://api.github.com/repos/openshift/cluster-samples-operator/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/cluster-samples-operator/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/cluster-samples-operator/tags","blobs_url":"https://api.github.com/repos/openshift/cluster-samples-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/cluster-samples-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/cluster-samples-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/cluster-samples-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/cluster-samples-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/cluster-samples-operator/languages","stargazers_url":"https://api.github.com/repos/openshift/cluster-samples-operator/stargazers","contributors_url":"https://api.github.com/repos/openshift/cluster-samples-operator/contributors","subscribers_url":"https://api.github.com/repos/openshift/cluster-samples-operator/subscribers","subscription_url":"https://api.github.com/repos/openshift/cluster-samples-operator/subscription","commits_url":"https://api.github.com/repos/openshift/cluster-samples-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/cluster-samples-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/cluster-samples-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/cluster-samples-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/cluster-samples-operator/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/cluster-samples-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/cluster-samples-operator/merges","archive_url":"https://api.github.com/repos/openshift/cluster-samples-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/cluster-samples-operator/downloads","issues_url":"https://api.github.com/repos/openshift/cluster-samples-operator/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/cluster-samples-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/cluster-samples-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/cluster-samples-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/cluster-samples-operator/labels{/name}","releases_url":"https://api.github.com/repos/openshift/cluster-samples-operator/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/cluster-samples-operator/deployments","created_at":"2018-08-17T19:10:15Z","updated_at":"2018-09-19T14:45:40Z","pushed_at":"2018-09-19T22:20:51Z","git_url":"git://github.com/openshift/cluster-samples-operator.git","ssh_url":"git@github.com:openshift/cluster-samples-operator.git","clone_url":"https://github.com/openshift/cluster-samples-operator.git","svn_url":"https://github.com/openshift/cluster-samples-operator","homepage":null,"size":21085,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":3,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/cluster-samples-operator/pulls/15"},"html":{"href":"https://github.com/openshift/cluster-samples-operator/pull/15"},"issue":{"href":"https://api.github.com/repos/openshift/cluster-samples-operator/issues/15"},"comments":{"href":"https://api.github.com/repos/openshift/cluster-samples-operator/issues/15/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/cluster-samples-operator/pulls/15/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/cluster-samples-operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/cluster-samples-operator/pulls/15/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/cluster-samples-operator/statuses/b76130ad51e457ab8d9737f5a027a8f8af0f2232"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"gabemontero"}}