{"action":"opened","number":2577,"pull_request":{"url":"https://api.github.com/repos/zulip/zulip-mobile/pulls/2577","id":191006590,"html_url":"https://github.com/zulip/zulip-mobile/pull/2577","diff_url":"https://github.com/zulip/zulip-mobile/pull/2577.diff","patch_url":"https://github.com/zulip/zulip-mobile/pull/2577.patch","issue_url":"https://api.github.com/repos/zulip/zulip-mobile/issues/2577","number":2577,"state":"open","locked":false,"title":"refactor: Make sure `getMessageIdFromNode` returns `number`","user":{"login":"borisyankov","id":867242,"avatar_url":"https://avatars3.githubusercontent.com/u/867242?v=4","gravatar_id":"","url":"https://api.github.com/users/borisyankov","html_url":"https://github.com/borisyankov","followers_url":"https://api.github.com/users/borisyankov/followers","following_url":"https://api.github.com/users/borisyankov/following{/other_user}","gists_url":"https://api.github.com/users/borisyankov/gists{/gist_id}","starred_url":"https://api.github.com/users/borisyankov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borisyankov/subscriptions","organizations_url":"https://api.github.com/users/borisyankov/orgs","repos_url":"https://api.github.com/users/borisyankov/repos","events_url":"https://api.github.com/users/borisyankov/events{/privacy}","received_events_url":"https://api.github.com/users/borisyankov/received_events","type":"User","site_admin":false},"body":"When getting message id from an html element the value is returned\r\nas string. We used to convert it to `number` every time we needed it.\r\n\r\nInstead, we convert the value to number in one place and then we\r\ndo not need to convert it anywhere else.","created_at":"2018-05-28T23:18:41Z","updated_at":"2018-05-28T23:18:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/zulip/zulip-mobile/pulls/2577/commits","review_comments_url":"https://api.github.com/repos/zulip/zulip-mobile/pulls/2577/comments","review_comment_url":"https://api.github.com/repos/zulip/zulip-mobile/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zulip/zulip-mobile/issues/2577/comments","statuses_url":"https://api.github.com/repos/zulip/zulip-mobile/statuses/d9f493ac03429878b3955ab8b1647c124e2b2159","head":{"label":"borisyankov:getMessageIdFromNode-number","ref":"getMessageIdFromNode-number","sha":"d9f493ac03429878b3955ab8b1647c124e2b2159","user":{"login":"borisyankov","id":867242,"avatar_url":"https://avatars3.githubusercontent.com/u/867242?v=4","gravatar_id":"","url":"https://api.github.com/users/borisyankov","html_url":"https://github.com/borisyankov","followers_url":"https://api.github.com/users/borisyankov/followers","following_url":"https://api.github.com/users/borisyankov/following{/other_user}","gists_url":"https://api.github.com/users/borisyankov/gists{/gist_id}","starred_url":"https://api.github.com/users/borisyankov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borisyankov/subscriptions","organizations_url":"https://api.github.com/users/borisyankov/orgs","repos_url":"https://api.github.com/users/borisyankov/repos","events_url":"https://api.github.com/users/borisyankov/events{/privacy}","received_events_url":"https://api.github.com/users/borisyankov/received_events","type":"User","site_admin":false},"repo":{"id":68862567,"name":"zulip-mobile","full_name":"borisyankov/zulip-mobile","owner":{"login":"borisyankov","id":867242,"avatar_url":"https://avatars3.githubusercontent.com/u/867242?v=4","gravatar_id":"","url":"https://api.github.com/users/borisyankov","html_url":"https://github.com/borisyankov","followers_url":"https://api.github.com/users/borisyankov/followers","following_url":"https://api.github.com/users/borisyankov/following{/other_user}","gists_url":"https://api.github.com/users/borisyankov/gists{/gist_id}","starred_url":"https://api.github.com/users/borisyankov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borisyankov/subscriptions","organizations_url":"https://api.github.com/users/borisyankov/orgs","repos_url":"https://api.github.com/users/borisyankov/repos","events_url":"https://api.github.com/users/borisyankov/events{/privacy}","received_events_url":"https://api.github.com/users/borisyankov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/borisyankov/zulip-mobile","description":"Zulip mobile app using React Native","fork":true,"url":"https://api.github.com/repos/borisyankov/zulip-mobile","forks_url":"https://api.github.com/repos/borisyankov/zulip-mobile/forks","keys_url":"https://api.github.com/repos/borisyankov/zulip-mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/borisyankov/zulip-mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/borisyankov/zulip-mobile/teams","hooks_url":"https://api.github.com/repos/borisyankov/zulip-mobile/hooks","issue_events_url":"https://api.github.com/repos/borisyankov/zulip-mobile/issues/events{/number}","events_url":"https://api.github.com/repos/borisyankov/zulip-mobile/events","assignees_url":"https://api.github.com/repos/borisyankov/zulip-mobile/assignees{/user}","branches_url":"https://api.github.com/repos/borisyankov/zulip-mobile/branches{/branch}","tags_url":"https://api.github.com/repos/borisyankov/zulip-mobile/tags","blobs_url":"https://api.github.com/repos/borisyankov/zulip-mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/borisyankov/zulip-mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/borisyankov/zulip-mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/borisyankov/zulip-mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/borisyankov/zulip-mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/borisyankov/zulip-mobile/languages","stargazers_url":"https://api.github.com/repos/borisyankov/zulip-mobile/stargazers","contributors_url":"https://api.github.com/repos/borisyankov/zulip-mobile/contributors","subscribers_url":"https://api.github.com/repos/borisyankov/zulip-mobile/subscribers","subscription_url":"https://api.github.com/repos/borisyankov/zulip-mobile/subscription","commits_url":"https://api.github.com/repos/borisyankov/zulip-mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/borisyankov/zulip-mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/borisyankov/zulip-mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/borisyankov/zulip-mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/borisyankov/zulip-mobile/contents/{+path}","compare_url":"https://api.github.com/repos/borisyankov/zulip-mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/borisyankov/zulip-mobile/merges","archive_url":"https://api.github.com/repos/borisyankov/zulip-mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/borisyankov/zulip-mobile/downloads","issues_url":"https://api.github.com/repos/borisyankov/zulip-mobile/issues{/number}","pulls_url":"https://api.github.com/repos/borisyankov/zulip-mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/borisyankov/zulip-mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/borisyankov/zulip-mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/borisyankov/zulip-mobile/labels{/name}","releases_url":"https://api.github.com/repos/borisyankov/zulip-mobile/releases{/id}","deployments_url":"https://api.github.com/repos/borisyankov/zulip-mobile/deployments","created_at":"2016-09-21T22:23:02Z","updated_at":"2018-05-28T21:43:10Z","pushed_at":"2018-05-28T23:18:25Z","git_url":"git://github.com/borisyankov/zulip-mobile.git","ssh_url":"git@github.com:borisyankov/zulip-mobile.git","clone_url":"https://github.com/borisyankov/zulip-mobile.git","svn_url":"https://github.com/borisyankov/zulip-mobile","homepage":"","size":37534,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"zulip:master","ref":"master","sha":"a5fa4609c4d9fd02678ac35cdde7e27f7d347d26","user":{"login":"zulip","id":4921959,"avatar_url":"https://avatars2.githubusercontent.com/u/4921959?v=4","gravatar_id":"","url":"https://api.github.com/users/zulip","html_url":"https://github.com/zulip","followers_url":"https://api.github.com/users/zulip/followers","following_url":"https://api.github.com/users/zulip/following{/other_user}","gists_url":"https://api.github.com/users/zulip/gists{/gist_id}","starred_url":"https://api.github.com/users/zulip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zulip/subscriptions","organizations_url":"https://api.github.com/users/zulip/orgs","repos_url":"https://api.github.com/users/zulip/repos","events_url":"https://api.github.com/users/zulip/events{/privacy}","received_events_url":"https://api.github.com/users/zulip/received_events","type":"Organization","site_admin":false},"repo":{"id":58298428,"name":"zulip-mobile","full_name":"zulip/zulip-mobile","owner":{"login":"zulip","id":4921959,"avatar_url":"https://avatars2.githubusercontent.com/u/4921959?v=4","gravatar_id":"","url":"https://api.github.com/users/zulip","html_url":"https://github.com/zulip","followers_url":"https://api.github.com/users/zulip/followers","following_url":"https://api.github.com/users/zulip/following{/other_user}","gists_url":"https://api.github.com/users/zulip/gists{/gist_id}","starred_url":"https://api.github.com/users/zulip/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zulip/subscriptions","organizations_url":"https://api.github.com/users/zulip/orgs","repos_url":"https://api.github.com/users/zulip/repos","events_url":"https://api.github.com/users/zulip/events{/privacy}","received_events_url":"https://api.github.com/users/zulip/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zulip/zulip-mobile","description":"Zulip mobile app using React Native","fork":false,"url":"https://api.github.com/repos/zulip/zulip-mobile","forks_url":"https://api.github.com/repos/zulip/zulip-mobile/forks","keys_url":"https://api.github.com/repos/zulip/zulip-mobile/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zulip/zulip-mobile/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zulip/zulip-mobile/teams","hooks_url":"https://api.github.com/repos/zulip/zulip-mobile/hooks","issue_events_url":"https://api.github.com/repos/zulip/zulip-mobile/issues/events{/number}","events_url":"https://api.github.com/repos/zulip/zulip-mobile/events","assignees_url":"https://api.github.com/repos/zulip/zulip-mobile/assignees{/user}","branches_url":"https://api.github.com/repos/zulip/zulip-mobile/branches{/branch}","tags_url":"https://api.github.com/repos/zulip/zulip-mobile/tags","blobs_url":"https://api.github.com/repos/zulip/zulip-mobile/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zulip/zulip-mobile/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zulip/zulip-mobile/git/refs{/sha}","trees_url":"https://api.github.com/repos/zulip/zulip-mobile/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zulip/zulip-mobile/statuses/{sha}","languages_url":"https://api.github.com/repos/zulip/zulip-mobile/languages","stargazers_url":"https://api.github.com/repos/zulip/zulip-mobile/stargazers","contributors_url":"https://api.github.com/repos/zulip/zulip-mobile/contributors","subscribers_url":"https://api.github.com/repos/zulip/zulip-mobile/subscribers","subscription_url":"https://api.github.com/repos/zulip/zulip-mobile/subscription","commits_url":"https://api.github.com/repos/zulip/zulip-mobile/commits{/sha}","git_commits_url":"https://api.github.com/repos/zulip/zulip-mobile/git/commits{/sha}","comments_url":"https://api.github.com/repos/zulip/zulip-mobile/comments{/number}","issue_comment_url":"https://api.github.com/repos/zulip/zulip-mobile/issues/comments{/number}","contents_url":"https://api.github.com/repos/zulip/zulip-mobile/contents/{+path}","compare_url":"https://api.github.com/repos/zulip/zulip-mobile/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zulip/zulip-mobile/merges","archive_url":"https://api.github.com/repos/zulip/zulip-mobile/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zulip/zulip-mobile/downloads","issues_url":"https://api.github.com/repos/zulip/zulip-mobile/issues{/number}","pulls_url":"https://api.github.com/repos/zulip/zulip-mobile/pulls{/number}","milestones_url":"https://api.github.com/repos/zulip/zulip-mobile/milestones{/number}","notifications_url":"https://api.github.com/repos/zulip/zulip-mobile/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zulip/zulip-mobile/labels{/name}","releases_url":"https://api.github.com/repos/zulip/zulip-mobile/releases{/id}","deployments_url":"https://api.github.com/repos/zulip/zulip-mobile/deployments","created_at":"2016-05-08T05:41:48Z","updated_at":"2018-05-28T18:52:50Z","pushed_at":"2018-05-28T18:52:44Z","git_url":"git://github.com/zulip/zulip-mobile.git","ssh_url":"git@github.com:zulip/zulip-mobile.git","clone_url":"https://github.com/zulip/zulip-mobile.git","svn_url":"https://github.com/zulip/zulip-mobile","homepage":"","size":20067,"stargazers_count":334,"watchers_count":334,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":148,"mirror_url":null,"archived":false,"open_issues_count":127,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":148,"open_issues":127,"watchers":334,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zulip/zulip-mobile/pulls/2577"},"html":{"href":"https://github.com/zulip/zulip-mobile/pull/2577"},"issue":{"href":"https://api.github.com/repos/zulip/zulip-mobile/issues/2577"},"comments":{"href":"https://api.github.com/repos/zulip/zulip-mobile/issues/2577/comments"},"review_comments":{"href":"https://api.github.com/repos/zulip/zulip-mobile/pulls/2577/comments"},"review_comment":{"href":"https://api.github.com/repos/zulip/zulip-mobile/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zulip/zulip-mobile/pulls/2577/commits"},"statuses":{"href":"https://api.github.com/repos/zulip/zulip-mobile/statuses/d9f493ac03429878b3955ab8b1647c124e2b2159"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":15,"deletions":15,"changed_files":2}}
{"actor":{"display_login":"borisyankov"}}