{"action":"closed","number":3360,"pull_request":{"url":"https://api.github.com/repos/vim/vim/pulls/3360","id":210023659,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwMDIzNjU5","html_url":"https://github.com/vim/vim/pull/3360","diff_url":"https://github.com/vim/vim/pull/3360.diff","patch_url":"https://github.com/vim/vim/pull/3360.patch","issue_url":"https://api.github.com/repos/vim/vim/issues/3360","number":3360,"state":"closed","locked":false,"title":"Fix Test_getftype","user":{"login":"ichizok","id":943423,"node_id":"MDQ6VXNlcjk0MzQyMw==","avatar_url":"https://avatars2.githubusercontent.com/u/943423?v=4","gravatar_id":"","url":"https://api.github.com/users/ichizok","html_url":"https://github.com/ichizok","followers_url":"https://api.github.com/users/ichizok/followers","following_url":"https://api.github.com/users/ichizok/following{/other_user}","gists_url":"https://api.github.com/users/ichizok/gists{/gist_id}","starred_url":"https://api.github.com/users/ichizok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ichizok/subscriptions","organizations_url":"https://api.github.com/users/ichizok/orgs","repos_url":"https://api.github.com/users/ichizok/repos","events_url":"https://api.github.com/users/ichizok/events{/privacy}","received_events_url":"https://api.github.com/users/ichizok/received_events","type":"User","site_admin":false},"body":"## Problem\r\n\r\nIn GUI, the check for char-device file type in `Test_getftype()` fails.\r\n(GUI: Linux GVim, MacVim)\r\n\r\nExample:\r\nhttps://travis-ci.org/ichizok/vim/jobs/418035329\r\n(Changed .travis.yml to execute \"make -C src testgui\" on Linux)\r\n\r\n```\r\nFrom test_stat.vim:\r\nFound errors in Test_getftype():\r\nfunction RunTheTest[40]..Test_getftype line 19: Expected 'cdev' but got ''\r\n```\r\n\r\n## Cause\r\n\r\nIn GUI, `systemlist()` and `system()` create new pty for the executing command (when `guipty` is on or `guioptions` has `!`), so the command (`find`) returns the pty path and the pty is gone after the command finishes.\r\nThus `getftype()` for the pty returns empty string and test fails.\r\n\r\nGenerally, the filepath returned by the external command may have been lost before doing `getftype()`.\r\n\r\n## Solution\r\n\r\n* Check if file exists (the result of `getftype()` is not empty) before `assert_equal()`","created_at":"2018-08-22T05:29:14Z","updated_at":"2018-08-22T18:16:40Z","closed_at":"2018-08-22T18:16:40Z","merged_at":null,"merge_commit_sha":"03dbefa83c71ae6472c7818be07f97778a5d4f61","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/vim/vim/pulls/3360/commits","review_comments_url":"https://api.github.com/repos/vim/vim/pulls/3360/comments","review_comment_url":"https://api.github.com/repos/vim/vim/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vim/vim/issues/3360/comments","statuses_url":"https://api.github.com/repos/vim/vim/statuses/476e1fbe8889a2237ebe566fb1159e5d0cd14c16","head":{"label":"ichizok:fix/test_stat","ref":"fix/test_stat","sha":"476e1fbe8889a2237ebe566fb1159e5d0cd14c16","user":{"login":"ichizok","id":943423,"node_id":"MDQ6VXNlcjk0MzQyMw==","avatar_url":"https://avatars2.githubusercontent.com/u/943423?v=4","gravatar_id":"","url":"https://api.github.com/users/ichizok","html_url":"https://github.com/ichizok","followers_url":"https://api.github.com/users/ichizok/followers","following_url":"https://api.github.com/users/ichizok/following{/other_user}","gists_url":"https://api.github.com/users/ichizok/gists{/gist_id}","starred_url":"https://api.github.com/users/ichizok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ichizok/subscriptions","organizations_url":"https://api.github.com/users/ichizok/orgs","repos_url":"https://api.github.com/users/ichizok/repos","events_url":"https://api.github.com/users/ichizok/events{/privacy}","received_events_url":"https://api.github.com/users/ichizok/received_events","type":"User","site_admin":false},"repo":{"id":52954259,"node_id":"MDEwOlJlcG9zaXRvcnk1Mjk1NDI1OQ==","name":"vim","full_name":"ichizok/vim","owner":{"login":"ichizok","id":943423,"node_id":"MDQ6VXNlcjk0MzQyMw==","avatar_url":"https://avatars2.githubusercontent.com/u/943423?v=4","gravatar_id":"","url":"https://api.github.com/users/ichizok","html_url":"https://github.com/ichizok","followers_url":"https://api.github.com/users/ichizok/followers","following_url":"https://api.github.com/users/ichizok/following{/other_user}","gists_url":"https://api.github.com/users/ichizok/gists{/gist_id}","starred_url":"https://api.github.com/users/ichizok/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ichizok/subscriptions","organizations_url":"https://api.github.com/users/ichizok/orgs","repos_url":"https://api.github.com/users/ichizok/repos","events_url":"https://api.github.com/users/ichizok/events{/privacy}","received_events_url":"https://api.github.com/users/ichizok/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ichizok/vim","description":"The official Vim repository","fork":true,"url":"https://api.github.com/repos/ichizok/vim","forks_url":"https://api.github.com/repos/ichizok/vim/forks","keys_url":"https://api.github.com/repos/ichizok/vim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ichizok/vim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ichizok/vim/teams","hooks_url":"https://api.github.com/repos/ichizok/vim/hooks","issue_events_url":"https://api.github.com/repos/ichizok/vim/issues/events{/number}","events_url":"https://api.github.com/repos/ichizok/vim/events","assignees_url":"https://api.github.com/repos/ichizok/vim/assignees{/user}","branches_url":"https://api.github.com/repos/ichizok/vim/branches{/branch}","tags_url":"https://api.github.com/repos/ichizok/vim/tags","blobs_url":"https://api.github.com/repos/ichizok/vim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ichizok/vim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ichizok/vim/git/refs{/sha}","trees_url":"https://api.github.com/repos/ichizok/vim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ichizok/vim/statuses/{sha}","languages_url":"https://api.github.com/repos/ichizok/vim/languages","stargazers_url":"https://api.github.com/repos/ichizok/vim/stargazers","contributors_url":"https://api.github.com/repos/ichizok/vim/contributors","subscribers_url":"https://api.github.com/repos/ichizok/vim/subscribers","subscription_url":"https://api.github.com/repos/ichizok/vim/subscription","commits_url":"https://api.github.com/repos/ichizok/vim/commits{/sha}","git_commits_url":"https://api.github.com/repos/ichizok/vim/git/commits{/sha}","comments_url":"https://api.github.com/repos/ichizok/vim/comments{/number}","issue_comment_url":"https://api.github.com/repos/ichizok/vim/issues/comments{/number}","contents_url":"https://api.github.com/repos/ichizok/vim/contents/{+path}","compare_url":"https://api.github.com/repos/ichizok/vim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ichizok/vim/merges","archive_url":"https://api.github.com/repos/ichizok/vim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ichizok/vim/downloads","issues_url":"https://api.github.com/repos/ichizok/vim/issues{/number}","pulls_url":"https://api.github.com/repos/ichizok/vim/pulls{/number}","milestones_url":"https://api.github.com/repos/ichizok/vim/milestones{/number}","notifications_url":"https://api.github.com/repos/ichizok/vim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ichizok/vim/labels{/name}","releases_url":"https://api.github.com/repos/ichizok/vim/releases{/id}","deployments_url":"https://api.github.com/repos/ichizok/vim/deployments","created_at":"2016-03-02T10:26:12Z","updated_at":"2016-03-02T10:27:01Z","pushed_at":"2018-08-22T09:33:25Z","git_url":"git://github.com/ichizok/vim.git","ssh_url":"git@github.com:ichizok/vim.git","clone_url":"https://github.com/ichizok/vim.git","svn_url":"https://github.com/ichizok/vim","homepage":"http://www.vim.org","size":83707,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vim:master","ref":"master","sha":"4c5765bc47b2708075e8d8471e8d342079479777","user":{"login":"vim","id":11618545,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjE4NTQ1","avatar_url":"https://avatars3.githubusercontent.com/u/11618545?v=4","gravatar_id":"","url":"https://api.github.com/users/vim","html_url":"https://github.com/vim","followers_url":"https://api.github.com/users/vim/followers","following_url":"https://api.github.com/users/vim/following{/other_user}","gists_url":"https://api.github.com/users/vim/gists{/gist_id}","starred_url":"https://api.github.com/users/vim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vim/subscriptions","organizations_url":"https://api.github.com/users/vim/orgs","repos_url":"https://api.github.com/users/vim/repos","events_url":"https://api.github.com/users/vim/events{/privacy}","received_events_url":"https://api.github.com/users/vim/received_events","type":"Organization","site_admin":false},"repo":{"id":40997482,"node_id":"MDEwOlJlcG9zaXRvcnk0MDk5NzQ4Mg==","name":"vim","full_name":"vim/vim","owner":{"login":"vim","id":11618545,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNjE4NTQ1","avatar_url":"https://avatars3.githubusercontent.com/u/11618545?v=4","gravatar_id":"","url":"https://api.github.com/users/vim","html_url":"https://github.com/vim","followers_url":"https://api.github.com/users/vim/followers","following_url":"https://api.github.com/users/vim/following{/other_user}","gists_url":"https://api.github.com/users/vim/gists{/gist_id}","starred_url":"https://api.github.com/users/vim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vim/subscriptions","organizations_url":"https://api.github.com/users/vim/orgs","repos_url":"https://api.github.com/users/vim/repos","events_url":"https://api.github.com/users/vim/events{/privacy}","received_events_url":"https://api.github.com/users/vim/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/vim/vim","description":"The official Vim repository","fork":false,"url":"https://api.github.com/repos/vim/vim","forks_url":"https://api.github.com/repos/vim/vim/forks","keys_url":"https://api.github.com/repos/vim/vim/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vim/vim/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vim/vim/teams","hooks_url":"https://api.github.com/repos/vim/vim/hooks","issue_events_url":"https://api.github.com/repos/vim/vim/issues/events{/number}","events_url":"https://api.github.com/repos/vim/vim/events","assignees_url":"https://api.github.com/repos/vim/vim/assignees{/user}","branches_url":"https://api.github.com/repos/vim/vim/branches{/branch}","tags_url":"https://api.github.com/repos/vim/vim/tags","blobs_url":"https://api.github.com/repos/vim/vim/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vim/vim/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vim/vim/git/refs{/sha}","trees_url":"https://api.github.com/repos/vim/vim/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vim/vim/statuses/{sha}","languages_url":"https://api.github.com/repos/vim/vim/languages","stargazers_url":"https://api.github.com/repos/vim/vim/stargazers","contributors_url":"https://api.github.com/repos/vim/vim/contributors","subscribers_url":"https://api.github.com/repos/vim/vim/subscribers","subscription_url":"https://api.github.com/repos/vim/vim/subscription","commits_url":"https://api.github.com/repos/vim/vim/commits{/sha}","git_commits_url":"https://api.github.com/repos/vim/vim/git/commits{/sha}","comments_url":"https://api.github.com/repos/vim/vim/comments{/number}","issue_comment_url":"https://api.github.com/repos/vim/vim/issues/comments{/number}","contents_url":"https://api.github.com/repos/vim/vim/contents/{+path}","compare_url":"https://api.github.com/repos/vim/vim/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vim/vim/merges","archive_url":"https://api.github.com/repos/vim/vim/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vim/vim/downloads","issues_url":"https://api.github.com/repos/vim/vim/issues{/number}","pulls_url":"https://api.github.com/repos/vim/vim/pulls{/number}","milestones_url":"https://api.github.com/repos/vim/vim/milestones{/number}","notifications_url":"https://api.github.com/repos/vim/vim/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vim/vim/labels{/name}","releases_url":"https://api.github.com/repos/vim/vim/releases{/id}","deployments_url":"https://api.github.com/repos/vim/vim/deployments","created_at":"2015-08-18T21:03:56Z","updated_at":"2018-08-22T18:07:02Z","pushed_at":"2018-08-22T18:16:27Z","git_url":"git://github.com/vim/vim.git","ssh_url":"git@github.com:vim/vim.git","clone_url":"https://github.com/vim/vim.git","svn_url":"https://github.com/vim/vim","homepage":"http://www.vim.org","size":83411,"stargazers_count":13772,"watchers_count":13772,"language":"C","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1733,"mirror_url":null,"archived":false,"open_issues_count":783,"license":null,"forks":1733,"open_issues":783,"watchers":13772,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vim/vim/pulls/3360"},"html":{"href":"https://github.com/vim/vim/pull/3360"},"issue":{"href":"https://api.github.com/repos/vim/vim/issues/3360"},"comments":{"href":"https://api.github.com/repos/vim/vim/issues/3360/comments"},"review_comments":{"href":"https://api.github.com/repos/vim/vim/pulls/3360/comments"},"review_comment":{"href":"https://api.github.com/repos/vim/vim/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vim/vim/pulls/3360/commits"},"statuses":{"href":"https://api.github.com/repos/vim/vim/statuses/476e1fbe8889a2237ebe566fb1159e5d0cd14c16"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":12,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"brammool"}}