{"action":"created","comment":{"url":"https://api.github.com/repos/spotxmobile/spotx-prebid/pulls/comments/229524663","pull_request_review_id":170045904,"id":229524663,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTUyNDY2Mw==","diff_hunk":"@@ -244,7 +254,8 @@ export const spec = {\n                 player_height: request.video.ext.player_height,\n                 content_page_url: request.video.ext.content_page_url,\n                 outstream_static: request.video.ext.outstream_static,\n-                ad_mute: request.video.ext.ad_mute\n+                ad_mute: request.video.ext.ad_mute,\n+                outstreamFunction: request.video.ext.outstreamFunction","path":"bin/spotxBidAdapter.js","position":66,"original_position":75,"commit_id":"eafd148d0564fb6d9a1917853cbbc2670cd67d03","original_commit_id":"73d0f63ae7debf98e86d51dff4def8d52acf6fe8","user":{"login":"strider820","id":996869,"node_id":"MDQ6VXNlcjk5Njg2OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/996869?v=4","gravatar_id":"","url":"https://api.github.com/users/strider820","html_url":"https://github.com/strider820","followers_url":"https://api.github.com/users/strider820/followers","following_url":"https://api.github.com/users/strider820/following{/other_user}","gists_url":"https://api.github.com/users/strider820/gists{/gist_id}","starred_url":"https://api.github.com/users/strider820/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/strider820/subscriptions","organizations_url":"https://api.github.com/users/strider820/orgs","repos_url":"https://api.github.com/users/strider820/repos","events_url":"https://api.github.com/users/strider820/events{/privacy}","received_events_url":"https://api.github.com/users/strider820/received_events","type":"User","site_admin":false},"body":"If I'm understanding this correctly, I think my answer above applies here too. If the pub has a renderer, and we want to help them with that, that's fine, but we should assume that's not the case. I'm fine with leaving this option in here, and short circuiting the renderer that we had, but we should still support the pub not doing this, and not having a renderer.","created_at":"2018-10-30T23:43:05Z","updated_at":"2018-10-30T23:43:06Z","html_url":"https://github.com/spotxmobile/spotx-prebid/pull/5#discussion_r229524663","pull_request_url":"https://api.github.com/repos/spotxmobile/spotx-prebid/pulls/5","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/spotxmobile/spotx-prebid/pulls/comments/229524663"},"html":{"href":"https://github.com/spotxmobile/spotx-prebid/pull/5#discussion_r229524663"},"pull_request":{"href":"https://api.github.com/repos/spotxmobile/spotx-prebid/pulls/5"}},"in_reply_to_id":224563228},"pull_request":{"url":"https://api.github.com/repos/spotxmobile/spotx-prebid/pulls/5","id":220097051,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwMDk3MDUx","html_url":"https://github.com/spotxmobile/spotx-prebid/pull/5","diff_url":"https://github.com/spotxmobile/spotx-prebid/pull/5.diff","patch_url":"https://github.com/spotxmobile/spotx-prebid/pull/5.patch","issue_url":"https://api.github.com/repos/spotxmobile/spotx-prebid/issues/5","number":5,"state":"open","locked":false,"title":"Patch 2","user":{"login":"jmonbillard","id":16936161,"node_id":"MDQ6VXNlcjE2OTM2MTYx","avatar_url":"https://avatars1.githubusercontent.com/u/16936161?v=4","gravatar_id":"","url":"https://api.github.com/users/jmonbillard","html_url":"https://github.com/jmonbillard","followers_url":"https://api.github.com/users/jmonbillard/followers","following_url":"https://api.github.com/users/jmonbillard/following{/other_user}","gists_url":"https://api.github.com/users/jmonbillard/gists{/gist_id}","starred_url":"https://api.github.com/users/jmonbillard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmonbillard/subscriptions","organizations_url":"https://api.github.com/users/jmonbillard/orgs","repos_url":"https://api.github.com/users/jmonbillard/repos","events_url":"https://api.github.com/users/jmonbillard/events{/privacy}","received_events_url":"https://api.github.com/users/jmonbillard/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-03T16:15:14Z","updated_at":"2018-10-30T23:43:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a688e1925033aeb86324d94c867bbd74cfde0c47","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/spotxmobile/spotx-prebid/pulls/5/commits","review_comments_url":"https://api.github.com/repos/spotxmobile/spotx-prebid/pulls/5/comments","review_comment_url":"https://api.github.com/repos/spotxmobile/spotx-prebid/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spotxmobile/spotx-prebid/issues/5/comments","statuses_url":"https://api.github.com/repos/spotxmobile/spotx-prebid/statuses/eafd148d0564fb6d9a1917853cbbc2670cd67d03","head":{"label":"jmonbillard:patch-2","ref":"patch-2","sha":"eafd148d0564fb6d9a1917853cbbc2670cd67d03","user":{"login":"jmonbillard","id":16936161,"node_id":"MDQ6VXNlcjE2OTM2MTYx","avatar_url":"https://avatars1.githubusercontent.com/u/16936161?v=4","gravatar_id":"","url":"https://api.github.com/users/jmonbillard","html_url":"https://github.com/jmonbillard","followers_url":"https://api.github.com/users/jmonbillard/followers","following_url":"https://api.github.com/users/jmonbillard/following{/other_user}","gists_url":"https://api.github.com/users/jmonbillard/gists{/gist_id}","starred_url":"https://api.github.com/users/jmonbillard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmonbillard/subscriptions","organizations_url":"https://api.github.com/users/jmonbillard/orgs","repos_url":"https://api.github.com/users/jmonbillard/repos","events_url":"https://api.github.com/users/jmonbillard/events{/privacy}","received_events_url":"https://api.github.com/users/jmonbillard/received_events","type":"User","site_admin":false},"repo":{"id":147510466,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc1MTA0NjY=","name":"spotx-prebid","full_name":"jmonbillard/spotx-prebid","private":false,"owner":{"login":"jmonbillard","id":16936161,"node_id":"MDQ6VXNlcjE2OTM2MTYx","avatar_url":"https://avatars1.githubusercontent.com/u/16936161?v=4","gravatar_id":"","url":"https://api.github.com/users/jmonbillard","html_url":"https://github.com/jmonbillard","followers_url":"https://api.github.com/users/jmonbillard/followers","following_url":"https://api.github.com/users/jmonbillard/following{/other_user}","gists_url":"https://api.github.com/users/jmonbillard/gists{/gist_id}","starred_url":"https://api.github.com/users/jmonbillard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmonbillard/subscriptions","organizations_url":"https://api.github.com/users/jmonbillard/orgs","repos_url":"https://api.github.com/users/jmonbillard/repos","events_url":"https://api.github.com/users/jmonbillard/events{/privacy}","received_events_url":"https://api.github.com/users/jmonbillard/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jmonbillard/spotx-prebid","description":null,"fork":true,"url":"https://api.github.com/repos/jmonbillard/spotx-prebid","forks_url":"https://api.github.com/repos/jmonbillard/spotx-prebid/forks","keys_url":"https://api.github.com/repos/jmonbillard/spotx-prebid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmonbillard/spotx-prebid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmonbillard/spotx-prebid/teams","hooks_url":"https://api.github.com/repos/jmonbillard/spotx-prebid/hooks","issue_events_url":"https://api.github.com/repos/jmonbillard/spotx-prebid/issues/events{/number}","events_url":"https://api.github.com/repos/jmonbillard/spotx-prebid/events","assignees_url":"https://api.github.com/repos/jmonbillard/spotx-prebid/assignees{/user}","branches_url":"https://api.github.com/repos/jmonbillard/spotx-prebid/branches{/branch}","tags_url":"https://api.github.com/repos/jmonbillard/spotx-prebid/tags","blobs_url":"https://api.github.com/repos/jmonbillard/spotx-prebid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmonbillard/spotx-prebid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmonbillard/spotx-prebid/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmonbillard/spotx-prebid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmonbillard/spotx-prebid/statuses/{sha}","languages_url":"https://api.github.com/repos/jmonbillard/spotx-prebid/languages","stargazers_url":"https://api.github.com/repos/jmonbillard/spotx-prebid/stargazers","contributors_url":"https://api.github.com/repos/jmonbillard/spotx-prebid/contributors","subscribers_url":"https://api.github.com/repos/jmonbillard/spotx-prebid/subscribers","subscription_url":"https://api.github.com/repos/jmonbillard/spotx-prebid/subscription","commits_url":"https://api.github.com/repos/jmonbillard/spotx-prebid/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmonbillard/spotx-prebid/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmonbillard/spotx-prebid/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmonbillard/spotx-prebid/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmonbillard/spotx-prebid/contents/{+path}","compare_url":"https://api.github.com/repos/jmonbillard/spotx-prebid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmonbillard/spotx-prebid/merges","archive_url":"https://api.github.com/repos/jmonbillard/spotx-prebid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmonbillard/spotx-prebid/downloads","issues_url":"https://api.github.com/repos/jmonbillard/spotx-prebid/issues{/number}","pulls_url":"https://api.github.com/repos/jmonbillard/spotx-prebid/pulls{/number}","milestones_url":"https://api.github.com/repos/jmonbillard/spotx-prebid/milestones{/number}","notifications_url":"https://api.github.com/repos/jmonbillard/spotx-prebid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmonbillard/spotx-prebid/labels{/name}","releases_url":"https://api.github.com/repos/jmonbillard/spotx-prebid/releases{/id}","deployments_url":"https://api.github.com/repos/jmonbillard/spotx-prebid/deployments","created_at":"2018-09-05T11:56:48Z","updated_at":"2018-09-05T11:56:50Z","pushed_at":"2018-10-12T09:50:50Z","git_url":"git://github.com/jmonbillard/spotx-prebid.git","ssh_url":"git@github.com:jmonbillard/spotx-prebid.git","clone_url":"https://github.com/jmonbillard/spotx-prebid.git","svn_url":"https://github.com/jmonbillard/spotx-prebid","homepage":null,"size":140,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spotxmobile:master","ref":"master","sha":"c23d3b15f57a4b294e08c5fdf85fe9f0cbc4ccd4","user":{"login":"spotxmobile","id":11340510,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzQwNTEw","avatar_url":"https://avatars2.githubusercontent.com/u/11340510?v=4","gravatar_id":"","url":"https://api.github.com/users/spotxmobile","html_url":"https://github.com/spotxmobile","followers_url":"https://api.github.com/users/spotxmobile/followers","following_url":"https://api.github.com/users/spotxmobile/following{/other_user}","gists_url":"https://api.github.com/users/spotxmobile/gists{/gist_id}","starred_url":"https://api.github.com/users/spotxmobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotxmobile/subscriptions","organizations_url":"https://api.github.com/users/spotxmobile/orgs","repos_url":"https://api.github.com/users/spotxmobile/repos","events_url":"https://api.github.com/users/spotxmobile/events{/privacy}","received_events_url":"https://api.github.com/users/spotxmobile/received_events","type":"Organization","site_admin":false},"repo":{"id":108308034,"node_id":"MDEwOlJlcG9zaXRvcnkxMDgzMDgwMzQ=","name":"spotx-prebid","full_name":"spotxmobile/spotx-prebid","private":false,"owner":{"login":"spotxmobile","id":11340510,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzQwNTEw","avatar_url":"https://avatars2.githubusercontent.com/u/11340510?v=4","gravatar_id":"","url":"https://api.github.com/users/spotxmobile","html_url":"https://github.com/spotxmobile","followers_url":"https://api.github.com/users/spotxmobile/followers","following_url":"https://api.github.com/users/spotxmobile/following{/other_user}","gists_url":"https://api.github.com/users/spotxmobile/gists{/gist_id}","starred_url":"https://api.github.com/users/spotxmobile/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spotxmobile/subscriptions","organizations_url":"https://api.github.com/users/spotxmobile/orgs","repos_url":"https://api.github.com/users/spotxmobile/repos","events_url":"https://api.github.com/users/spotxmobile/events{/privacy}","received_events_url":"https://api.github.com/users/spotxmobile/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/spotxmobile/spotx-prebid","description":null,"fork":false,"url":"https://api.github.com/repos/spotxmobile/spotx-prebid","forks_url":"https://api.github.com/repos/spotxmobile/spotx-prebid/forks","keys_url":"https://api.github.com/repos/spotxmobile/spotx-prebid/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spotxmobile/spotx-prebid/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spotxmobile/spotx-prebid/teams","hooks_url":"https://api.github.com/repos/spotxmobile/spotx-prebid/hooks","issue_events_url":"https://api.github.com/repos/spotxmobile/spotx-prebid/issues/events{/number}","events_url":"https://api.github.com/repos/spotxmobile/spotx-prebid/events","assignees_url":"https://api.github.com/repos/spotxmobile/spotx-prebid/assignees{/user}","branches_url":"https://api.github.com/repos/spotxmobile/spotx-prebid/branches{/branch}","tags_url":"https://api.github.com/repos/spotxmobile/spotx-prebid/tags","blobs_url":"https://api.github.com/repos/spotxmobile/spotx-prebid/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spotxmobile/spotx-prebid/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spotxmobile/spotx-prebid/git/refs{/sha}","trees_url":"https://api.github.com/repos/spotxmobile/spotx-prebid/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spotxmobile/spotx-prebid/statuses/{sha}","languages_url":"https://api.github.com/repos/spotxmobile/spotx-prebid/languages","stargazers_url":"https://api.github.com/repos/spotxmobile/spotx-prebid/stargazers","contributors_url":"https://api.github.com/repos/spotxmobile/spotx-prebid/contributors","subscribers_url":"https://api.github.com/repos/spotxmobile/spotx-prebid/subscribers","subscription_url":"https://api.github.com/repos/spotxmobile/spotx-prebid/subscription","commits_url":"https://api.github.com/repos/spotxmobile/spotx-prebid/commits{/sha}","git_commits_url":"https://api.github.com/repos/spotxmobile/spotx-prebid/git/commits{/sha}","comments_url":"https://api.github.com/repos/spotxmobile/spotx-prebid/comments{/number}","issue_comment_url":"https://api.github.com/repos/spotxmobile/spotx-prebid/issues/comments{/number}","contents_url":"https://api.github.com/repos/spotxmobile/spotx-prebid/contents/{+path}","compare_url":"https://api.github.com/repos/spotxmobile/spotx-prebid/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spotxmobile/spotx-prebid/merges","archive_url":"https://api.github.com/repos/spotxmobile/spotx-prebid/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spotxmobile/spotx-prebid/downloads","issues_url":"https://api.github.com/repos/spotxmobile/spotx-prebid/issues{/number}","pulls_url":"https://api.github.com/repos/spotxmobile/spotx-prebid/pulls{/number}","milestones_url":"https://api.github.com/repos/spotxmobile/spotx-prebid/milestones{/number}","notifications_url":"https://api.github.com/repos/spotxmobile/spotx-prebid/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spotxmobile/spotx-prebid/labels{/name}","releases_url":"https://api.github.com/repos/spotxmobile/spotx-prebid/releases{/id}","deployments_url":"https://api.github.com/repos/spotxmobile/spotx-prebid/deployments","created_at":"2017-10-25T18:17:08Z","updated_at":"2018-10-08T16:41:43Z","pushed_at":"2018-10-12T09:50:51Z","git_url":"git://github.com/spotxmobile/spotx-prebid.git","ssh_url":"git@github.com:spotxmobile/spotx-prebid.git","clone_url":"https://github.com/spotxmobile/spotx-prebid.git","svn_url":"https://github.com/spotxmobile/spotx-prebid","homepage":null,"size":126,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spotxmobile/spotx-prebid/pulls/5"},"html":{"href":"https://github.com/spotxmobile/spotx-prebid/pull/5"},"issue":{"href":"https://api.github.com/repos/spotxmobile/spotx-prebid/issues/5"},"comments":{"href":"https://api.github.com/repos/spotxmobile/spotx-prebid/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/spotxmobile/spotx-prebid/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/spotxmobile/spotx-prebid/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spotxmobile/spotx-prebid/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/spotxmobile/spotx-prebid/statuses/eafd148d0564fb6d9a1917853cbbc2670cd67d03"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"strider820"}}