{"action":"created","comment":{"url":"https://api.github.com/repos/flow-typed/flow-typed/pulls/comments/210081794","pull_request_review_id":146224756,"id":210081794,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDA4MTc5NA==","diff_hunk":"@@ -57,7 +67,7 @@ declare module \"react-redux\" {\n     S: Object,\n     SP: Object,\n     RSP: Object,\n-    CP: $Diff<OmitDispatch<ElementConfig<Com>>, RSP>,\n+    CP: $Diff<ElementConfig<Com>, RSP>,","path":"definitions/npm/react-redux_v5.x.x/flow_v0.63.0-/react-redux_v5.x.x.js","position":null,"original_position":26,"commit_id":"c9ccc221474f0185bb38966f3cab478534b3dcfc","original_commit_id":"f7a8a8bcafdd478bf9bccd0866cfcc4943e6f09d","user":{"login":"LoganBarnett","id":27005,"node_id":"MDQ6VXNlcjI3MDA1","avatar_url":"https://avatars1.githubusercontent.com/u/27005?v=4","gravatar_id":"","url":"https://api.github.com/users/LoganBarnett","html_url":"https://github.com/LoganBarnett","followers_url":"https://api.github.com/users/LoganBarnett/followers","following_url":"https://api.github.com/users/LoganBarnett/following{/other_user}","gists_url":"https://api.github.com/users/LoganBarnett/gists{/gist_id}","starred_url":"https://api.github.com/users/LoganBarnett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LoganBarnett/subscriptions","organizations_url":"https://api.github.com/users/LoganBarnett/orgs","repos_url":"https://api.github.com/users/LoganBarnett/repos","events_url":"https://api.github.com/users/LoganBarnett/events{/privacy}","received_events_url":"https://api.github.com/users/LoganBarnett/received_events","type":"User","site_admin":false},"body":"@villesau got it - okay I've made that change. How is your codebase encountering this issue? I'd like to capture it in a test if possible.\r\n\r\nAlso, if you know of ways to capture type coverage itself as a test I'm all ears. So far it feels like I'm spitballing just to get these to add coverage and any changes in the future could just remove them without failing anything.","created_at":"2018-08-14T19:51:05Z","updated_at":"2018-08-14T19:51:05Z","html_url":"https://github.com/flow-typed/flow-typed/pull/2530#discussion_r210081794","pull_request_url":"https://api.github.com/repos/flow-typed/flow-typed/pulls/2530","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/flow-typed/flow-typed/pulls/comments/210081794"},"html":{"href":"https://github.com/flow-typed/flow-typed/pull/2530#discussion_r210081794"},"pull_request":{"href":"https://api.github.com/repos/flow-typed/flow-typed/pulls/2530"}},"in_reply_to_id":207058984},"pull_request":{"url":"https://api.github.com/repos/flow-typed/flow-typed/pulls/2530","id":203571083,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzNTcxMDgz","html_url":"https://github.com/flow-typed/flow-typed/pull/2530","diff_url":"https://github.com/flow-typed/flow-typed/pull/2530.diff","patch_url":"https://github.com/flow-typed/flow-typed/pull/2530.patch","issue_url":"https://api.github.com/repos/flow-typed/flow-typed/issues/2530","number":2530,"state":"open","locked":false,"title":"fix type coverage on react-redux's connect","user":{"login":"LoganBarnett","id":27005,"node_id":"MDQ6VXNlcjI3MDA1","avatar_url":"https://avatars1.githubusercontent.com/u/27005?v=4","gravatar_id":"","url":"https://api.github.com/users/LoganBarnett","html_url":"https://github.com/LoganBarnett","followers_url":"https://api.github.com/users/LoganBarnett/followers","following_url":"https://api.github.com/users/LoganBarnett/following{/other_user}","gists_url":"https://api.github.com/users/LoganBarnett/gists{/gist_id}","starred_url":"https://api.github.com/users/LoganBarnett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LoganBarnett/subscriptions","organizations_url":"https://api.github.com/users/LoganBarnett/orgs","repos_url":"https://api.github.com/users/LoganBarnett/repos","events_url":"https://api.github.com/users/LoganBarnett/events{/privacy}","received_events_url":"https://api.github.com/users/LoganBarnett/received_events","type":"User","site_admin":false},"body":"When I upgraded to `react-redux` to 5, we had a drop in type coverage on `connect`. From some experimentation I found that it's resulting from the type import within the libdef. The types imported from redux aren't overly complex and I understand them to be relatively stable, so I've copied them in directly.\r\n\r\nI've tested this on my internal repo and found the coverage is applied again. I don't know how to express that as a test in the `flow-typed` suite, however. I tried adding `flow-strict` to the test files as well as `[strict]` settings to `cli/.flow-config`, but still no joy. I'd love any other suggestions anyone can think of.","created_at":"2018-07-24T15:40:39Z","updated_at":"2018-08-14T19:51:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b60e2d454a96620bb434368725618d3dba72880d","assignee":{"login":"villesau","id":2647016,"node_id":"MDQ6VXNlcjI2NDcwMTY=","avatar_url":"https://avatars1.githubusercontent.com/u/2647016?v=4","gravatar_id":"","url":"https://api.github.com/users/villesau","html_url":"https://github.com/villesau","followers_url":"https://api.github.com/users/villesau/followers","following_url":"https://api.github.com/users/villesau/following{/other_user}","gists_url":"https://api.github.com/users/villesau/gists{/gist_id}","starred_url":"https://api.github.com/users/villesau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/villesau/subscriptions","organizations_url":"https://api.github.com/users/villesau/orgs","repos_url":"https://api.github.com/users/villesau/repos","events_url":"https://api.github.com/users/villesau/events{/privacy}","received_events_url":"https://api.github.com/users/villesau/received_events","type":"User","site_admin":false},"assignees":[{"login":"villesau","id":2647016,"node_id":"MDQ6VXNlcjI2NDcwMTY=","avatar_url":"https://avatars1.githubusercontent.com/u/2647016?v=4","gravatar_id":"","url":"https://api.github.com/users/villesau","html_url":"https://github.com/villesau","followers_url":"https://api.github.com/users/villesau/followers","following_url":"https://api.github.com/users/villesau/following{/other_user}","gists_url":"https://api.github.com/users/villesau/gists{/gist_id}","starred_url":"https://api.github.com/users/villesau/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/villesau/subscriptions","organizations_url":"https://api.github.com/users/villesau/orgs","repos_url":"https://api.github.com/users/villesau/repos","events_url":"https://api.github.com/users/villesau/events{/privacy}","received_events_url":"https://api.github.com/users/villesau/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":261936120,"node_id":"MDU6TGFiZWwyNjE5MzYxMjA=","url":"https://api.github.com/repos/flow-typed/flow-typed/labels/bug","name":"bug","color":"d93f0b","default":true},{"id":874822104,"node_id":"MDU6TGFiZWw4NzQ4MjIxMDQ=","url":"https://api.github.com/repos/flow-typed/flow-typed/labels/libdef","name":"libdef","color":"0052cc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/flow-typed/flow-typed/pulls/2530/commits","review_comments_url":"https://api.github.com/repos/flow-typed/flow-typed/pulls/2530/comments","review_comment_url":"https://api.github.com/repos/flow-typed/flow-typed/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flow-typed/flow-typed/issues/2530/comments","statuses_url":"https://api.github.com/repos/flow-typed/flow-typed/statuses/c9ccc221474f0185bb38966f3cab478534b3dcfc","head":{"label":"LoganBarnett:add-react-redux-coverage","ref":"add-react-redux-coverage","sha":"c9ccc221474f0185bb38966f3cab478534b3dcfc","user":{"login":"LoganBarnett","id":27005,"node_id":"MDQ6VXNlcjI3MDA1","avatar_url":"https://avatars1.githubusercontent.com/u/27005?v=4","gravatar_id":"","url":"https://api.github.com/users/LoganBarnett","html_url":"https://github.com/LoganBarnett","followers_url":"https://api.github.com/users/LoganBarnett/followers","following_url":"https://api.github.com/users/LoganBarnett/following{/other_user}","gists_url":"https://api.github.com/users/LoganBarnett/gists{/gist_id}","starred_url":"https://api.github.com/users/LoganBarnett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LoganBarnett/subscriptions","organizations_url":"https://api.github.com/users/LoganBarnett/orgs","repos_url":"https://api.github.com/users/LoganBarnett/repos","events_url":"https://api.github.com/users/LoganBarnett/events{/privacy}","received_events_url":"https://api.github.com/users/LoganBarnett/received_events","type":"User","site_admin":false},"repo":{"id":87586509,"node_id":"MDEwOlJlcG9zaXRvcnk4NzU4NjUwOQ==","name":"flow-typed","full_name":"LoganBarnett/flow-typed","owner":{"login":"LoganBarnett","id":27005,"node_id":"MDQ6VXNlcjI3MDA1","avatar_url":"https://avatars1.githubusercontent.com/u/27005?v=4","gravatar_id":"","url":"https://api.github.com/users/LoganBarnett","html_url":"https://github.com/LoganBarnett","followers_url":"https://api.github.com/users/LoganBarnett/followers","following_url":"https://api.github.com/users/LoganBarnett/following{/other_user}","gists_url":"https://api.github.com/users/LoganBarnett/gists{/gist_id}","starred_url":"https://api.github.com/users/LoganBarnett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LoganBarnett/subscriptions","organizations_url":"https://api.github.com/users/LoganBarnett/orgs","repos_url":"https://api.github.com/users/LoganBarnett/repos","events_url":"https://api.github.com/users/LoganBarnett/events{/privacy}","received_events_url":"https://api.github.com/users/LoganBarnett/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/LoganBarnett/flow-typed","description":"A central repository for Flow library definitions","fork":true,"url":"https://api.github.com/repos/LoganBarnett/flow-typed","forks_url":"https://api.github.com/repos/LoganBarnett/flow-typed/forks","keys_url":"https://api.github.com/repos/LoganBarnett/flow-typed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LoganBarnett/flow-typed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LoganBarnett/flow-typed/teams","hooks_url":"https://api.github.com/repos/LoganBarnett/flow-typed/hooks","issue_events_url":"https://api.github.com/repos/LoganBarnett/flow-typed/issues/events{/number}","events_url":"https://api.github.com/repos/LoganBarnett/flow-typed/events","assignees_url":"https://api.github.com/repos/LoganBarnett/flow-typed/assignees{/user}","branches_url":"https://api.github.com/repos/LoganBarnett/flow-typed/branches{/branch}","tags_url":"https://api.github.com/repos/LoganBarnett/flow-typed/tags","blobs_url":"https://api.github.com/repos/LoganBarnett/flow-typed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LoganBarnett/flow-typed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LoganBarnett/flow-typed/git/refs{/sha}","trees_url":"https://api.github.com/repos/LoganBarnett/flow-typed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LoganBarnett/flow-typed/statuses/{sha}","languages_url":"https://api.github.com/repos/LoganBarnett/flow-typed/languages","stargazers_url":"https://api.github.com/repos/LoganBarnett/flow-typed/stargazers","contributors_url":"https://api.github.com/repos/LoganBarnett/flow-typed/contributors","subscribers_url":"https://api.github.com/repos/LoganBarnett/flow-typed/subscribers","subscription_url":"https://api.github.com/repos/LoganBarnett/flow-typed/subscription","commits_url":"https://api.github.com/repos/LoganBarnett/flow-typed/commits{/sha}","git_commits_url":"https://api.github.com/repos/LoganBarnett/flow-typed/git/commits{/sha}","comments_url":"https://api.github.com/repos/LoganBarnett/flow-typed/comments{/number}","issue_comment_url":"https://api.github.com/repos/LoganBarnett/flow-typed/issues/comments{/number}","contents_url":"https://api.github.com/repos/LoganBarnett/flow-typed/contents/{+path}","compare_url":"https://api.github.com/repos/LoganBarnett/flow-typed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LoganBarnett/flow-typed/merges","archive_url":"https://api.github.com/repos/LoganBarnett/flow-typed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LoganBarnett/flow-typed/downloads","issues_url":"https://api.github.com/repos/LoganBarnett/flow-typed/issues{/number}","pulls_url":"https://api.github.com/repos/LoganBarnett/flow-typed/pulls{/number}","milestones_url":"https://api.github.com/repos/LoganBarnett/flow-typed/milestones{/number}","notifications_url":"https://api.github.com/repos/LoganBarnett/flow-typed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LoganBarnett/flow-typed/labels{/name}","releases_url":"https://api.github.com/repos/LoganBarnett/flow-typed/releases{/id}","deployments_url":"https://api.github.com/repos/LoganBarnett/flow-typed/deployments","created_at":"2017-04-07T20:59:18Z","updated_at":"2018-07-24T14:21:14Z","pushed_at":"2018-08-14T19:49:05Z","git_url":"git://github.com/LoganBarnett/flow-typed.git","ssh_url":"git@github.com:LoganBarnett/flow-typed.git","clone_url":"https://github.com/LoganBarnett/flow-typed.git","svn_url":"https://github.com/LoganBarnett/flow-typed","homepage":"","size":5021,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flow-typed:master","ref":"master","sha":"f7260937c8c06cc48768c7641ff22e89f0838aef","user":{"login":"flow-typed","id":40805164,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwODA1MTY0","avatar_url":"https://avatars2.githubusercontent.com/u/40805164?v=4","gravatar_id":"","url":"https://api.github.com/users/flow-typed","html_url":"https://github.com/flow-typed","followers_url":"https://api.github.com/users/flow-typed/followers","following_url":"https://api.github.com/users/flow-typed/following{/other_user}","gists_url":"https://api.github.com/users/flow-typed/gists{/gist_id}","starred_url":"https://api.github.com/users/flow-typed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flow-typed/subscriptions","organizations_url":"https://api.github.com/users/flow-typed/orgs","repos_url":"https://api.github.com/users/flow-typed/repos","events_url":"https://api.github.com/users/flow-typed/events{/privacy}","received_events_url":"https://api.github.com/users/flow-typed/received_events","type":"Organization","site_admin":false},"repo":{"id":42698429,"node_id":"MDEwOlJlcG9zaXRvcnk0MjY5ODQyOQ==","name":"flow-typed","full_name":"flow-typed/flow-typed","owner":{"login":"flow-typed","id":40805164,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwODA1MTY0","avatar_url":"https://avatars2.githubusercontent.com/u/40805164?v=4","gravatar_id":"","url":"https://api.github.com/users/flow-typed","html_url":"https://github.com/flow-typed","followers_url":"https://api.github.com/users/flow-typed/followers","following_url":"https://api.github.com/users/flow-typed/following{/other_user}","gists_url":"https://api.github.com/users/flow-typed/gists{/gist_id}","starred_url":"https://api.github.com/users/flow-typed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flow-typed/subscriptions","organizations_url":"https://api.github.com/users/flow-typed/orgs","repos_url":"https://api.github.com/users/flow-typed/repos","events_url":"https://api.github.com/users/flow-typed/events{/privacy}","received_events_url":"https://api.github.com/users/flow-typed/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/flow-typed/flow-typed","description":"A central repository for Flow library definitions","fork":false,"url":"https://api.github.com/repos/flow-typed/flow-typed","forks_url":"https://api.github.com/repos/flow-typed/flow-typed/forks","keys_url":"https://api.github.com/repos/flow-typed/flow-typed/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flow-typed/flow-typed/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flow-typed/flow-typed/teams","hooks_url":"https://api.github.com/repos/flow-typed/flow-typed/hooks","issue_events_url":"https://api.github.com/repos/flow-typed/flow-typed/issues/events{/number}","events_url":"https://api.github.com/repos/flow-typed/flow-typed/events","assignees_url":"https://api.github.com/repos/flow-typed/flow-typed/assignees{/user}","branches_url":"https://api.github.com/repos/flow-typed/flow-typed/branches{/branch}","tags_url":"https://api.github.com/repos/flow-typed/flow-typed/tags","blobs_url":"https://api.github.com/repos/flow-typed/flow-typed/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flow-typed/flow-typed/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flow-typed/flow-typed/git/refs{/sha}","trees_url":"https://api.github.com/repos/flow-typed/flow-typed/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flow-typed/flow-typed/statuses/{sha}","languages_url":"https://api.github.com/repos/flow-typed/flow-typed/languages","stargazers_url":"https://api.github.com/repos/flow-typed/flow-typed/stargazers","contributors_url":"https://api.github.com/repos/flow-typed/flow-typed/contributors","subscribers_url":"https://api.github.com/repos/flow-typed/flow-typed/subscribers","subscription_url":"https://api.github.com/repos/flow-typed/flow-typed/subscription","commits_url":"https://api.github.com/repos/flow-typed/flow-typed/commits{/sha}","git_commits_url":"https://api.github.com/repos/flow-typed/flow-typed/git/commits{/sha}","comments_url":"https://api.github.com/repos/flow-typed/flow-typed/comments{/number}","issue_comment_url":"https://api.github.com/repos/flow-typed/flow-typed/issues/comments{/number}","contents_url":"https://api.github.com/repos/flow-typed/flow-typed/contents/{+path}","compare_url":"https://api.github.com/repos/flow-typed/flow-typed/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flow-typed/flow-typed/merges","archive_url":"https://api.github.com/repos/flow-typed/flow-typed/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flow-typed/flow-typed/downloads","issues_url":"https://api.github.com/repos/flow-typed/flow-typed/issues{/number}","pulls_url":"https://api.github.com/repos/flow-typed/flow-typed/pulls{/number}","milestones_url":"https://api.github.com/repos/flow-typed/flow-typed/milestones{/number}","notifications_url":"https://api.github.com/repos/flow-typed/flow-typed/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flow-typed/flow-typed/labels{/name}","releases_url":"https://api.github.com/repos/flow-typed/flow-typed/releases{/id}","deployments_url":"https://api.github.com/repos/flow-typed/flow-typed/deployments","created_at":"2015-09-18T03:51:49Z","updated_at":"2018-08-14T08:24:58Z","pushed_at":"2018-08-14T19:49:07Z","git_url":"git://github.com/flow-typed/flow-typed.git","ssh_url":"git@github.com:flow-typed/flow-typed.git","clone_url":"https://github.com/flow-typed/flow-typed.git","svn_url":"https://github.com/flow-typed/flow-typed","homepage":"","size":5159,"stargazers_count":2792,"watchers_count":2792,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1064,"mirror_url":null,"archived":false,"open_issues_count":321,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1064,"open_issues":321,"watchers":2792,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flow-typed/flow-typed/pulls/2530"},"html":{"href":"https://github.com/flow-typed/flow-typed/pull/2530"},"issue":{"href":"https://api.github.com/repos/flow-typed/flow-typed/issues/2530"},"comments":{"href":"https://api.github.com/repos/flow-typed/flow-typed/issues/2530/comments"},"review_comments":{"href":"https://api.github.com/repos/flow-typed/flow-typed/pulls/2530/comments"},"review_comment":{"href":"https://api.github.com/repos/flow-typed/flow-typed/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flow-typed/flow-typed/pulls/2530/commits"},"statuses":{"href":"https://api.github.com/repos/flow-typed/flow-typed/statuses/c9ccc221474f0185bb38966f3cab478534b3dcfc"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"LoganBarnett"}}