{"action":"created","comment":{"url":"https://api.github.com/repos/linkerd/linkerd2/pulls/comments/218182887","pull_request_review_id":156065241,"id":218182887,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODE4Mjg4Nw==","diff_hunk":"@@ -130,7 +130,7 @@ const columnDefinitions = (resource, namespaces, onFilterClick, showNamespaceCol\n       className: \"numeric\",\n       width: smMetricColWidth,\n       sorter: (a, b) => numericSort(a.requestRate, b.requestRate),\n-      render: d => withTooltip(d, \"REQUEST_RATE\")\n+      render: d => withTooltip(d, \"REQUEST_RATE\", true)","path":"web/app/js/components/MetricsTable.jsx","position":20,"original_position":20,"commit_id":"8868d90f994231ea1cdcfc2ffa56bc424fa10b4a","original_commit_id":"8868d90f994231ea1cdcfc2ffa56bc424fa10b4a","user":{"login":"rmars","id":549258,"node_id":"MDQ6VXNlcjU0OTI1OA==","avatar_url":"https://avatars3.githubusercontent.com/u/549258?v=4","gravatar_id":"","url":"https://api.github.com/users/rmars","html_url":"https://github.com/rmars","followers_url":"https://api.github.com/users/rmars/followers","following_url":"https://api.github.com/users/rmars/following{/other_user}","gists_url":"https://api.github.com/users/rmars/gists{/gist_id}","starred_url":"https://api.github.com/users/rmars/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmars/subscriptions","organizations_url":"https://api.github.com/users/rmars/orgs","repos_url":"https://api.github.com/users/rmars/repos","events_url":"https://api.github.com/users/rmars/events{/privacy}","received_events_url":"https://api.github.com/users/rmars/received_events","type":"User","site_admin":false},"body":"the tooltip is intended to show the untruncated value of the number, but it doesn't appear to be super useful seeing as we're also just calculating this from total requests divided by time window, and we don't need this to be super accurate anyways. I can remove the tooltipping","created_at":"2018-09-17T18:43:33Z","updated_at":"2018-09-17T18:43:33Z","html_url":"https://github.com/linkerd/linkerd2/pull/1663#discussion_r218182887","pull_request_url":"https://api.github.com/repos/linkerd/linkerd2/pulls/1663","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/linkerd/linkerd2/pulls/comments/218182887"},"html":{"href":"https://github.com/linkerd/linkerd2/pull/1663#discussion_r218182887"},"pull_request":{"href":"https://api.github.com/repos/linkerd/linkerd2/pulls/1663"}},"in_reply_to_id":218178348},"pull_request":{"url":"https://api.github.com/repos/linkerd/linkerd2/pulls/1663","id":216067426,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2MDY3NDI2","html_url":"https://github.com/linkerd/linkerd2/pull/1663","diff_url":"https://github.com/linkerd/linkerd2/pull/1663.diff","patch_url":"https://github.com/linkerd/linkerd2/pull/1663.patch","issue_url":"https://api.github.com/repos/linkerd/linkerd2/issues/1663","number":1663,"state":"open","locked":false,"title":"Remove RPS unit, fix Tap and Top in sidebar","user":{"login":"rmars","id":549258,"node_id":"MDQ6VXNlcjU0OTI1OA==","avatar_url":"https://avatars3.githubusercontent.com/u/549258?v=4","gravatar_id":"","url":"https://api.github.com/users/rmars","html_url":"https://github.com/rmars","followers_url":"https://api.github.com/users/rmars/followers","following_url":"https://api.github.com/users/rmars/following{/other_user}","gists_url":"https://api.github.com/users/rmars/gists{/gist_id}","starred_url":"https://api.github.com/users/rmars/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmars/subscriptions","organizations_url":"https://api.github.com/users/rmars/orgs","repos_url":"https://api.github.com/users/rmars/repos","events_url":"https://api.github.com/users/rmars/events{/privacy}","received_events_url":"https://api.github.com/users/rmars/received_events","type":"User","site_admin":false},"body":"- Don't display RPS as a unit in RPS column\r\n- Fix tap and top sidebar items not being minimized correctly\r\n\r\nBefore:\r\n\r\n![screen shot 2018-09-17 at 11 02 47 am](https://user-images.githubusercontent.com/549258/45641216-b96c1200-ba69-11e8-8cab-e99174d02be5.png)\r\n![screen shot 2018-09-17 at 11 06 06 am](https://user-images.githubusercontent.com/549258/45641220-bc670280-ba69-11e8-9a82-6135656448b7.png)\r\n\r\n\r\nAfter:\r\n![screen shot 2018-09-17 at 11 04 23 am](https://user-images.githubusercontent.com/549258/45641226-bffa8980-ba69-11e8-9105-609673337cad.png)\r\n![screen shot 2018-09-17 at 11 02 02 am](https://user-images.githubusercontent.com/549258/45641232-c2f57a00-ba69-11e8-9598-87fc54f40110.png)\r\n\r\nFixes #1651 \r\n","created_at":"2018-09-17T18:07:22Z","updated_at":"2018-09-17T18:43:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a2032d6e637dc11bc79f3586935a5e81c1fbd117","assignee":{"login":"rmars","id":549258,"node_id":"MDQ6VXNlcjU0OTI1OA==","avatar_url":"https://avatars3.githubusercontent.com/u/549258?v=4","gravatar_id":"","url":"https://api.github.com/users/rmars","html_url":"https://github.com/rmars","followers_url":"https://api.github.com/users/rmars/followers","following_url":"https://api.github.com/users/rmars/following{/other_user}","gists_url":"https://api.github.com/users/rmars/gists{/gist_id}","starred_url":"https://api.github.com/users/rmars/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmars/subscriptions","organizations_url":"https://api.github.com/users/rmars/orgs","repos_url":"https://api.github.com/users/rmars/repos","events_url":"https://api.github.com/users/rmars/events{/privacy}","received_events_url":"https://api.github.com/users/rmars/received_events","type":"User","site_admin":false},"assignees":[{"login":"rmars","id":549258,"node_id":"MDQ6VXNlcjU0OTI1OA==","avatar_url":"https://avatars3.githubusercontent.com/u/549258?v=4","gravatar_id":"","url":"https://api.github.com/users/rmars","html_url":"https://github.com/rmars","followers_url":"https://api.github.com/users/rmars/followers","following_url":"https://api.github.com/users/rmars/following{/other_user}","gists_url":"https://api.github.com/users/rmars/gists{/gist_id}","starred_url":"https://api.github.com/users/rmars/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmars/subscriptions","organizations_url":"https://api.github.com/users/rmars/orgs","repos_url":"https://api.github.com/users/rmars/repos","events_url":"https://api.github.com/users/rmars/events{/privacy}","received_events_url":"https://api.github.com/users/rmars/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"klingerf","id":9226,"node_id":"MDQ6VXNlcjkyMjY=","avatar_url":"https://avatars0.githubusercontent.com/u/9226?v=4","gravatar_id":"","url":"https://api.github.com/users/klingerf","html_url":"https://github.com/klingerf","followers_url":"https://api.github.com/users/klingerf/followers","following_url":"https://api.github.com/users/klingerf/following{/other_user}","gists_url":"https://api.github.com/users/klingerf/gists{/gist_id}","starred_url":"https://api.github.com/users/klingerf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klingerf/subscriptions","organizations_url":"https://api.github.com/users/klingerf/orgs","repos_url":"https://api.github.com/users/klingerf/repos","events_url":"https://api.github.com/users/klingerf/events{/privacy}","received_events_url":"https://api.github.com/users/klingerf/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":777123402,"node_id":"MDU6TGFiZWw3NzcxMjM0MDI=","url":"https://api.github.com/repos/linkerd/linkerd2/labels/area/web","name":"area/web","color":"0052CC","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/linkerd/linkerd2/pulls/1663/commits","review_comments_url":"https://api.github.com/repos/linkerd/linkerd2/pulls/1663/comments","review_comment_url":"https://api.github.com/repos/linkerd/linkerd2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linkerd/linkerd2/issues/1663/comments","statuses_url":"https://api.github.com/repos/linkerd/linkerd2/statuses/8868d90f994231ea1cdcfc2ffa56bc424fa10b4a","head":{"label":"linkerd:rmars/small-fixes","ref":"rmars/small-fixes","sha":"8868d90f994231ea1cdcfc2ffa56bc424fa10b4a","user":{"login":"linkerd","id":25301026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzAxMDI2","avatar_url":"https://avatars3.githubusercontent.com/u/25301026?v=4","gravatar_id":"","url":"https://api.github.com/users/linkerd","html_url":"https://github.com/linkerd","followers_url":"https://api.github.com/users/linkerd/followers","following_url":"https://api.github.com/users/linkerd/following{/other_user}","gists_url":"https://api.github.com/users/linkerd/gists{/gist_id}","starred_url":"https://api.github.com/users/linkerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkerd/subscriptions","organizations_url":"https://api.github.com/users/linkerd/orgs","repos_url":"https://api.github.com/users/linkerd/repos","events_url":"https://api.github.com/users/linkerd/events{/privacy}","received_events_url":"https://api.github.com/users/linkerd/received_events","type":"Organization","site_admin":false},"repo":{"id":113106184,"node_id":"MDEwOlJlcG9zaXRvcnkxMTMxMDYxODQ=","name":"linkerd2","full_name":"linkerd/linkerd2","private":false,"owner":{"login":"linkerd","id":25301026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzAxMDI2","avatar_url":"https://avatars3.githubusercontent.com/u/25301026?v=4","gravatar_id":"","url":"https://api.github.com/users/linkerd","html_url":"https://github.com/linkerd","followers_url":"https://api.github.com/users/linkerd/followers","following_url":"https://api.github.com/users/linkerd/following{/other_user}","gists_url":"https://api.github.com/users/linkerd/gists{/gist_id}","starred_url":"https://api.github.com/users/linkerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkerd/subscriptions","organizations_url":"https://api.github.com/users/linkerd/orgs","repos_url":"https://api.github.com/users/linkerd/repos","events_url":"https://api.github.com/users/linkerd/events{/privacy}","received_events_url":"https://api.github.com/users/linkerd/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/linkerd/linkerd2","description":"Service sidecar and service mesh for Kubernetes and beyond","fork":false,"url":"https://api.github.com/repos/linkerd/linkerd2","forks_url":"https://api.github.com/repos/linkerd/linkerd2/forks","keys_url":"https://api.github.com/repos/linkerd/linkerd2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkerd/linkerd2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkerd/linkerd2/teams","hooks_url":"https://api.github.com/repos/linkerd/linkerd2/hooks","issue_events_url":"https://api.github.com/repos/linkerd/linkerd2/issues/events{/number}","events_url":"https://api.github.com/repos/linkerd/linkerd2/events","assignees_url":"https://api.github.com/repos/linkerd/linkerd2/assignees{/user}","branches_url":"https://api.github.com/repos/linkerd/linkerd2/branches{/branch}","tags_url":"https://api.github.com/repos/linkerd/linkerd2/tags","blobs_url":"https://api.github.com/repos/linkerd/linkerd2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkerd/linkerd2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkerd/linkerd2/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkerd/linkerd2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkerd/linkerd2/statuses/{sha}","languages_url":"https://api.github.com/repos/linkerd/linkerd2/languages","stargazers_url":"https://api.github.com/repos/linkerd/linkerd2/stargazers","contributors_url":"https://api.github.com/repos/linkerd/linkerd2/contributors","subscribers_url":"https://api.github.com/repos/linkerd/linkerd2/subscribers","subscription_url":"https://api.github.com/repos/linkerd/linkerd2/subscription","commits_url":"https://api.github.com/repos/linkerd/linkerd2/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkerd/linkerd2/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkerd/linkerd2/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkerd/linkerd2/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkerd/linkerd2/contents/{+path}","compare_url":"https://api.github.com/repos/linkerd/linkerd2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkerd/linkerd2/merges","archive_url":"https://api.github.com/repos/linkerd/linkerd2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkerd/linkerd2/downloads","issues_url":"https://api.github.com/repos/linkerd/linkerd2/issues{/number}","pulls_url":"https://api.github.com/repos/linkerd/linkerd2/pulls{/number}","milestones_url":"https://api.github.com/repos/linkerd/linkerd2/milestones{/number}","notifications_url":"https://api.github.com/repos/linkerd/linkerd2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkerd/linkerd2/labels{/name}","releases_url":"https://api.github.com/repos/linkerd/linkerd2/releases{/id}","deployments_url":"https://api.github.com/repos/linkerd/linkerd2/deployments","created_at":"2017-12-04T23:16:56Z","updated_at":"2018-09-17T18:34:27Z","pushed_at":"2018-09-17T18:31:14Z","git_url":"git://github.com/linkerd/linkerd2.git","ssh_url":"git@github.com:linkerd/linkerd2.git","clone_url":"https://github.com/linkerd/linkerd2.git","svn_url":"https://github.com/linkerd/linkerd2","homepage":"https://linkerd.io","size":7725,"stargazers_count":2413,"watchers_count":2413,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":150,"mirror_url":null,"archived":false,"open_issues_count":263,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":150,"open_issues":263,"watchers":2413,"default_branch":"master"}},"base":{"label":"linkerd:master","ref":"master","sha":"19d24eb898e09f6d45872d499f611d5f5ea8a190","user":{"login":"linkerd","id":25301026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzAxMDI2","avatar_url":"https://avatars3.githubusercontent.com/u/25301026?v=4","gravatar_id":"","url":"https://api.github.com/users/linkerd","html_url":"https://github.com/linkerd","followers_url":"https://api.github.com/users/linkerd/followers","following_url":"https://api.github.com/users/linkerd/following{/other_user}","gists_url":"https://api.github.com/users/linkerd/gists{/gist_id}","starred_url":"https://api.github.com/users/linkerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkerd/subscriptions","organizations_url":"https://api.github.com/users/linkerd/orgs","repos_url":"https://api.github.com/users/linkerd/repos","events_url":"https://api.github.com/users/linkerd/events{/privacy}","received_events_url":"https://api.github.com/users/linkerd/received_events","type":"Organization","site_admin":false},"repo":{"id":113106184,"node_id":"MDEwOlJlcG9zaXRvcnkxMTMxMDYxODQ=","name":"linkerd2","full_name":"linkerd/linkerd2","private":false,"owner":{"login":"linkerd","id":25301026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzAxMDI2","avatar_url":"https://avatars3.githubusercontent.com/u/25301026?v=4","gravatar_id":"","url":"https://api.github.com/users/linkerd","html_url":"https://github.com/linkerd","followers_url":"https://api.github.com/users/linkerd/followers","following_url":"https://api.github.com/users/linkerd/following{/other_user}","gists_url":"https://api.github.com/users/linkerd/gists{/gist_id}","starred_url":"https://api.github.com/users/linkerd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkerd/subscriptions","organizations_url":"https://api.github.com/users/linkerd/orgs","repos_url":"https://api.github.com/users/linkerd/repos","events_url":"https://api.github.com/users/linkerd/events{/privacy}","received_events_url":"https://api.github.com/users/linkerd/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/linkerd/linkerd2","description":"Service sidecar and service mesh for Kubernetes and beyond","fork":false,"url":"https://api.github.com/repos/linkerd/linkerd2","forks_url":"https://api.github.com/repos/linkerd/linkerd2/forks","keys_url":"https://api.github.com/repos/linkerd/linkerd2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkerd/linkerd2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkerd/linkerd2/teams","hooks_url":"https://api.github.com/repos/linkerd/linkerd2/hooks","issue_events_url":"https://api.github.com/repos/linkerd/linkerd2/issues/events{/number}","events_url":"https://api.github.com/repos/linkerd/linkerd2/events","assignees_url":"https://api.github.com/repos/linkerd/linkerd2/assignees{/user}","branches_url":"https://api.github.com/repos/linkerd/linkerd2/branches{/branch}","tags_url":"https://api.github.com/repos/linkerd/linkerd2/tags","blobs_url":"https://api.github.com/repos/linkerd/linkerd2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkerd/linkerd2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkerd/linkerd2/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkerd/linkerd2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkerd/linkerd2/statuses/{sha}","languages_url":"https://api.github.com/repos/linkerd/linkerd2/languages","stargazers_url":"https://api.github.com/repos/linkerd/linkerd2/stargazers","contributors_url":"https://api.github.com/repos/linkerd/linkerd2/contributors","subscribers_url":"https://api.github.com/repos/linkerd/linkerd2/subscribers","subscription_url":"https://api.github.com/repos/linkerd/linkerd2/subscription","commits_url":"https://api.github.com/repos/linkerd/linkerd2/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkerd/linkerd2/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkerd/linkerd2/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkerd/linkerd2/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkerd/linkerd2/contents/{+path}","compare_url":"https://api.github.com/repos/linkerd/linkerd2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkerd/linkerd2/merges","archive_url":"https://api.github.com/repos/linkerd/linkerd2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkerd/linkerd2/downloads","issues_url":"https://api.github.com/repos/linkerd/linkerd2/issues{/number}","pulls_url":"https://api.github.com/repos/linkerd/linkerd2/pulls{/number}","milestones_url":"https://api.github.com/repos/linkerd/linkerd2/milestones{/number}","notifications_url":"https://api.github.com/repos/linkerd/linkerd2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkerd/linkerd2/labels{/name}","releases_url":"https://api.github.com/repos/linkerd/linkerd2/releases{/id}","deployments_url":"https://api.github.com/repos/linkerd/linkerd2/deployments","created_at":"2017-12-04T23:16:56Z","updated_at":"2018-09-17T18:34:27Z","pushed_at":"2018-09-17T18:31:14Z","git_url":"git://github.com/linkerd/linkerd2.git","ssh_url":"git@github.com:linkerd/linkerd2.git","clone_url":"https://github.com/linkerd/linkerd2.git","svn_url":"https://github.com/linkerd/linkerd2","homepage":"https://linkerd.io","size":7725,"stargazers_count":2413,"watchers_count":2413,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":150,"mirror_url":null,"archived":false,"open_issues_count":263,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":150,"open_issues":263,"watchers":2413,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/linkerd/linkerd2/pulls/1663"},"html":{"href":"https://github.com/linkerd/linkerd2/pull/1663"},"issue":{"href":"https://api.github.com/repos/linkerd/linkerd2/issues/1663"},"comments":{"href":"https://api.github.com/repos/linkerd/linkerd2/issues/1663/comments"},"review_comments":{"href":"https://api.github.com/repos/linkerd/linkerd2/pulls/1663/comments"},"review_comment":{"href":"https://api.github.com/repos/linkerd/linkerd2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linkerd/linkerd2/pulls/1663/commits"},"statuses":{"href":"https://api.github.com/repos/linkerd/linkerd2/statuses/8868d90f994231ea1cdcfc2ffa56bc424fa10b4a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"rmars"}}