{"action":"created","issue":{"url":"https://api.github.com/repos/ceph/ceph/issues/25269","repository_url":"https://api.github.com/repos/ceph/ceph","labels_url":"https://api.github.com/repos/ceph/ceph/issues/25269/labels{/name}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/25269/comments","events_url":"https://api.github.com/repos/ceph/ceph/issues/25269/events","html_url":"https://github.com/ceph/ceph/pull/25269","id":384566009,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNzM5NDU5","number":25269,"title":"jfw-wip-rgw-VLAs","user":{"login":"chardan","id":1643380,"node_id":"MDQ6VXNlcjE2NDMzODA=","avatar_url":"https://avatars3.githubusercontent.com/u/1643380?v=4","gravatar_id":"","url":"https://api.github.com/users/chardan","html_url":"https://github.com/chardan","followers_url":"https://api.github.com/users/chardan/followers","following_url":"https://api.github.com/users/chardan/following{/other_user}","gists_url":"https://api.github.com/users/chardan/gists{/gist_id}","starred_url":"https://api.github.com/users/chardan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chardan/subscriptions","organizations_url":"https://api.github.com/users/chardan/orgs","repos_url":"https://api.github.com/users/chardan/repos","events_url":"https://api.github.com/users/chardan/events{/privacy}","received_events_url":"https://api.github.com/users/chardan/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"chardan","id":1643380,"node_id":"MDQ6VXNlcjE2NDMzODA=","avatar_url":"https://avatars3.githubusercontent.com/u/1643380?v=4","gravatar_id":"","url":"https://api.github.com/users/chardan","html_url":"https://github.com/chardan","followers_url":"https://api.github.com/users/chardan/followers","following_url":"https://api.github.com/users/chardan/following{/other_user}","gists_url":"https://api.github.com/users/chardan/gists{/gist_id}","starred_url":"https://api.github.com/users/chardan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chardan/subscriptions","organizations_url":"https://api.github.com/users/chardan/orgs","repos_url":"https://api.github.com/users/chardan/repos","events_url":"https://api.github.com/users/chardan/events{/privacy}","received_events_url":"https://api.github.com/users/chardan/received_events","type":"User","site_admin":false},"assignees":[{"login":"chardan","id":1643380,"node_id":"MDQ6VXNlcjE2NDMzODA=","avatar_url":"https://avatars3.githubusercontent.com/u/1643380?v=4","gravatar_id":"","url":"https://api.github.com/users/chardan","html_url":"https://github.com/chardan","followers_url":"https://api.github.com/users/chardan/followers","following_url":"https://api.github.com/users/chardan/following{/other_user}","gists_url":"https://api.github.com/users/chardan/gists{/gist_id}","starred_url":"https://api.github.com/users/chardan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chardan/subscriptions","organizations_url":"https://api.github.com/users/chardan/orgs","repos_url":"https://api.github.com/users/chardan/repos","events_url":"https://api.github.com/users/chardan/events{/privacy}","received_events_url":"https://api.github.com/users/chardan/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-11-27T00:17:22Z","updated_at":"2018-11-28T16:50:03Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/25269","html_url":"https://github.com/ceph/ceph/pull/25269","diff_url":"https://github.com/ceph/ceph/pull/25269.diff","patch_url":"https://github.com/ceph/ceph/pull/25269.patch"},"body":"These patches aim to begin removing C variable-length arrays (VLAs) from the Ceph code. RGW was chosen partly because it has a comparatively high number of VLA usages therefore can serve as a good study in ways of replacing VLAs with the standard library. \r\n\r\nIn the RGW code, overwhelmingly the most common usage of a VLA was as a buffer for string processing. Most of the time, it was straightforward to replace those usages with std::string.\r\n\r\nA few things to consider:\r\n* please look carefully for any errors I may have introduced, especially off-by-one errors (and, my apologies in advance!);\r\n* shall we consider involving a library such as fmt (\"https://github.com/fmtlib/fmt\") or perhaps even Boost format for cases where I wound up replacing printf()-family functions with a series of std::string::append() calls, or iostream? \r\n\r\nI hope that we can continue to incrementally replace VLAs in situations where they aren't absolutely needed, with the goal of enabling the \"-Wvla\" flag (\"-pedantic\" has also been suggested, this is also worth considering).\r\n\r\nThanks for your time and constructive feedback!\r\n"},"comment":{"url":"https://api.github.com/repos/ceph/ceph/issues/comments/442519216","html_url":"https://github.com/ceph/ceph/pull/25269#issuecomment-442519216","issue_url":"https://api.github.com/repos/ceph/ceph/issues/25269","id":442519216,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MjUxOTIxNg==","user":{"login":"adamemerson","id":458092,"node_id":"MDQ6VXNlcjQ1ODA5Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/458092?v=4","gravatar_id":"","url":"https://api.github.com/users/adamemerson","html_url":"https://github.com/adamemerson","followers_url":"https://api.github.com/users/adamemerson/followers","following_url":"https://api.github.com/users/adamemerson/following{/other_user}","gists_url":"https://api.github.com/users/adamemerson/gists{/gist_id}","starred_url":"https://api.github.com/users/adamemerson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamemerson/subscriptions","organizations_url":"https://api.github.com/users/adamemerson/orgs","repos_url":"https://api.github.com/users/adamemerson/repos","events_url":"https://api.github.com/users/adamemerson/events{/privacy}","received_events_url":"https://api.github.com/users/adamemerson/received_events","type":"User","site_admin":false},"created_at":"2018-11-28T16:50:03Z","updated_at":"2018-11-28T16:50:03Z","author_association":"CONTRIBUTOR","body":"@chardan We already have fmt in src/fmt, it looks like. So there's really no argument against using it here, to."}}
{"actor":{"display_login":"adamemerson"}}