{"push_id":2963435727,"size":10,"distinct_size":8,"ref":"refs/heads/backfill-submission-entry-management-charge","head":"834d5ed61e9d0d52d7251943b499205f3282d17e","before":"25ac244ddf8d6f920247dffb44659680422d5de8","commits":[{"sha":"fb9a92be68256a6da93d3d915c806121642a964b","author":{"name":"Tekin Suleyman","email":"1960665b789a54413d9da7eaa93a0e5f5b4672af@tekin.co.uk"},"message":"Add missing inactive customers\n\nIt looks like https://github.com/dxw/DataSubmissionServiceAPI/pull/80\nmissed the mark slightly, as a bunch of inactive customers were not\nincluded in the data migration.\n\nThis was noticed because the coda finance report was reporting numbers\nthat were slightly at odds to the managment charge totals for the entire\nsubmission. The report relies on the SubmissionEntry#central_government\nand SubmissionEntry#wider_public_sector scopes to grab entries for each\nsector. The problem is, if the entry has a customer URN that isn't in\nthe database it won't appear under either scope, resulting in it not\nappearing in either calculation, thus the under reporting.\n\nWe need to make sure that the ingest/validation process is tightened up\nsuch that this isn't possible in the future.","distinct":false,"url":"https://api.github.com/repos/dxw/DataSubmissionServiceAPI/commits/fb9a92be68256a6da93d3d915c806121642a964b"},{"sha":"6d16d7bc10af3989342de33112a4d0b295d7b587","author":{"name":"Tekin Suleyman","email":"1960665b789a54413d9da7eaa93a0e5f5b4672af@users.noreply.github.com"},"message":"Merge pull request #111 from dxw/add-missing-customers\n\nAdd missing inactive customers","distinct":false,"url":"https://api.github.com/repos/dxw/DataSubmissionServiceAPI/commits/6d16d7bc10af3989342de33112a4d0b295d7b587"},{"sha":"05561c77481887b8cf5e0302574d3b0b31e4651d","author":{"name":"Tekin Suleyman","email":"1960665b789a54413d9da7eaa93a0e5f5b4672af@tekin.co.uk"},"message":"Finance report uses submission_entries#total_value\n\nNow that we have an actual attribute representing the total value of the\nentry we can calculate the total sales with a database query and without\nhaving to map to the correct column name for the specific framework.","distinct":true,"url":"https://api.github.com/repos/dxw/DataSubmissionServiceAPI/commits/05561c77481887b8cf5e0302574d3b0b31e4651d"},{"sha":"1aa9f78297a5ba8178f1b9b83d62c064b8d2af9a","author":{"name":"Tekin Suleyman","email":"1960665b789a54413d9da7eaa93a0e5f5b4672af@tekin.co.uk"},"message":"Rake task for generating the coda finance report\n\nFor now we output to /tmp and include all the submissions ever.\nEventually this will form part of a scheduled process that will only\noutput newly completed submissions and put the file somewhere where CCS\nfinance can access it.","distinct":true,"url":"https://api.github.com/repos/dxw/DataSubmissionServiceAPI/commits/1aa9f78297a5ba8178f1b9b83d62c064b8d2af9a"},{"sha":"8864acb75c36dcef1f8d78e89e782c5bb5bb40bf","author":{"name":"Tekin Suleyman","email":"1960665b789a54413d9da7eaa93a0e5f5b4672af@tekin.co.uk"},"message":"Add submission_entries#management_charge column\n\nWe're moving towards a per-entry management charge calculation as a)\nthere are frameworks where the calculation varies per-row, and b)\nthe management charge needs to be rounded down, and calculating the\ncharge against the total would result in a significant difference in the\ncharge for submissions with large numbers of entries.\n\nNote that we're storing this value to 4 decimal places. This is to\nreplicated the existing behaviour in the current system (MISO).\n\nCo-authored-by: leeky <leeky@dxw.com>","distinct":true,"url":"https://api.github.com/repos/dxw/DataSubmissionServiceAPI/commits/8864acb75c36dcef1f8d78e89e782c5bb5bb40bf"},{"sha":"ff5584438f171e2d3bf6b0900e880d9e8ab814d9","author":{"name":"Tekin Suleyman","email":"1960665b789a54413d9da7eaa93a0e5f5b4672af@tekin.co.uk"},"message":"Rename parameters for clarity","distinct":true,"url":"https://api.github.com/repos/dxw/DataSubmissionServiceAPI/commits/ff5584438f171e2d3bf6b0900e880d9e8ab814d9"},{"sha":"9a80c6447b6db43c8e03edd6f6b4084fa32645fe","author":{"name":"Tekin Suleyman","email":"1960665b789a54413d9da7eaa93a0e5f5b4672af@tekin.co.uk"},"message":"Add management charge calculation to definitions\n\nThis feels like it's probably the right place to put this for now, but\nI'm not entirely comfortable with the location/organisation of the spec.\nWill need to be addressed sooner rather than later.\n\nNote that the calculation is being performed to 4 decimal places to\nreplicate the behaviour in the existing system (MISO).","distinct":true,"url":"https://api.github.com/repos/dxw/DataSubmissionServiceAPI/commits/9a80c6447b6db43c8e03edd6f6b4084fa32645fe"},{"sha":"8d2330f4b838488d3e588bb2a86df77c2becdf41","author":{"name":"Tekin Suleyman","email":"1960665b789a54413d9da7eaa93a0e5f5b4672af@tekin.co.uk"},"message":"Data migration to backfill management charges\n\nBackfills the management charge for all valid entries. Note the rescue,\nwhich I've added because it appears there is at least one valid\nsubmission entry in the production data set that looks like it's\ntest data.","distinct":true,"url":"https://api.github.com/repos/dxw/DataSubmissionServiceAPI/commits/8d2330f4b838488d3e588bb2a86df77c2becdf41"},{"sha":"cf99b800195690c6aebea748f8646322ac97aa6c","author":{"name":"Tekin Suleyman","email":"1960665b789a54413d9da7eaa93a0e5f5b4672af@tekin.co.uk"},"message":"CodaFinanceReport#row uses management_charge\n\nNow we have the management charge stored per-entry we can calculate the\nper-sector charges in the database.\n\nNote the expectations needed adjusting because we're now calculating the\nmanagement charge per-entry and also rounding the result down, which\nresults in a cumulative difference in the calculated results.","distinct":true,"url":"https://api.github.com/repos/dxw/DataSubmissionServiceAPI/commits/cf99b800195690c6aebea748f8646322ac97aa6c"},{"sha":"834d5ed61e9d0d52d7251943b499205f3282d17e","author":{"name":"Tekin Suleyman","email":"1960665b789a54413d9da7eaa93a0e5f5b4672af@tekin.co.uk"},"message":"Submission export uses db management charge calc\n\nNow we have the management charge stored per-entry the total charge for\nthe submission can be calculated as part of the database query.","distinct":true,"url":"https://api.github.com/repos/dxw/DataSubmissionServiceAPI/commits/834d5ed61e9d0d52d7251943b499205f3282d17e"}]}
{"actor":{"display_login":"tekin"}}