{"action":"created","comment":{"url":"https://api.github.com/repos/facebook/react-native/pulls/comments/208242810","pull_request_review_id":144010244,"id":208242810,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODI0MjgxMA==","diff_hunk":"@@ -293,30 +293,30 @@ android {\n }\n \n dependencies {\n-    compile fileTree(dir: 'src/main/third-party/java/infer-annotations/', include: ['*.jar'])\n-    compile 'javax.inject:javax.inject:1'\n-    compile 'com.android.support:appcompat-v7:26.1.0'\n-    compile 'com.facebook.fbui.textlayoutbuilder:textlayoutbuilder:1.0.0'\n-    compile 'com.facebook.fresco:fresco:1.10.0'\n-    compile 'com.facebook.fresco:imagepipeline-okhttp3:1.9.0'\n-    compile 'com.facebook.soloader:soloader:0.5.1'\n-    compile 'com.google.code.findbugs:jsr305:3.0.2'\n-    compile 'com.squareup.okhttp3:okhttp:3.10.0'\n-    compile 'com.squareup.okhttp3:okhttp-urlconnection:3.10.0'\n-    compile 'com.squareup.okio:okio:1.14.0'\n+    implementation fileTree(dir: 'src/main/third-party/java/infer-annotations/', include: ['*.jar'])\n+    implementation 'javax.inject:javax.inject:1'\n+    implementation 'com.android.support:appcompat-v7:27.1.1'\n+    implementation 'com.facebook.fbui.textlayoutbuilder:textlayoutbuilder:1.0.0'\n+    implementation 'com.facebook.fresco:fresco:1.10.0'\n+    implementation 'com.facebook.fresco:imagepipeline-okhttp3:1.10.0'\n+    implementation 'com.facebook.soloader:soloader:0.5.1'\n+    implementation 'com.google.code.findbugs:jsr305:3.0.2'\n+    implementation 'com.squareup.okhttp3:okhttp:3.10.0'\n+    implementation 'com.squareup.okhttp3:okhttp-urlconnection:3.10.0'\n+    implementation 'com.squareup.okio:okio:1.14.0'\n     compile 'org.webkit:android-jsc:r174650'","path":"ReactAndroid/build.gradle","position":37,"original_position":42,"commit_id":"c47349a8a1d2afa5eb3be9b28f88976d749776bb","original_commit_id":"b7ca7985c0ed222594c80c1af7471b3c2d13725c","user":{"login":"dulmandakh","id":178494,"node_id":"MDQ6VXNlcjE3ODQ5NA==","avatar_url":"https://avatars2.githubusercontent.com/u/178494?v=4","gravatar_id":"","url":"https://api.github.com/users/dulmandakh","html_url":"https://github.com/dulmandakh","followers_url":"https://api.github.com/users/dulmandakh/followers","following_url":"https://api.github.com/users/dulmandakh/following{/other_user}","gists_url":"https://api.github.com/users/dulmandakh/gists{/gist_id}","starred_url":"https://api.github.com/users/dulmandakh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dulmandakh/subscriptions","organizations_url":"https://api.github.com/users/dulmandakh/orgs","repos_url":"https://api.github.com/users/dulmandakh/repos","events_url":"https://api.github.com/users/dulmandakh/events{/privacy}","received_events_url":"https://api.github.com/users/dulmandakh/received_events","type":"User","site_admin":false},"body":"@gengjiawen yes, you're right. I'll make changes to use api instead of compile","created_at":"2018-08-07T14:02:34Z","updated_at":"2018-08-07T14:02:34Z","html_url":"https://github.com/facebook/react-native/pull/20026#discussion_r208242810","pull_request_url":"https://api.github.com/repos/facebook/react-native/pulls/20026","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments/208242810"},"html":{"href":"https://github.com/facebook/react-native/pull/20026#discussion_r208242810"},"pull_request":{"href":"https://api.github.com/repos/facebook/react-native/pulls/20026"}},"in_reply_to_id":208045214},"pull_request":{"url":"https://api.github.com/repos/facebook/react-native/pulls/20026","id":199218482,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5MjE4NDgy","html_url":"https://github.com/facebook/react-native/pull/20026","diff_url":"https://github.com/facebook/react-native/pull/20026.diff","patch_url":"https://github.com/facebook/react-native/pull/20026.patch","issue_url":"https://api.github.com/repos/facebook/react-native/issues/20026","number":20026,"state":"open","locked":false,"title":"Bump Android SDK to 28","user":{"login":"dulmandakh","id":178494,"node_id":"MDQ6VXNlcjE3ODQ5NA==","avatar_url":"https://avatars2.githubusercontent.com/u/178494?v=4","gravatar_id":"","url":"https://api.github.com/users/dulmandakh","html_url":"https://github.com/dulmandakh","followers_url":"https://api.github.com/users/dulmandakh/followers","following_url":"https://api.github.com/users/dulmandakh/following{/other_user}","gists_url":"https://api.github.com/users/dulmandakh/gists{/gist_id}","starred_url":"https://api.github.com/users/dulmandakh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dulmandakh/subscriptions","organizations_url":"https://api.github.com/users/dulmandakh/orgs","repos_url":"https://api.github.com/users/dulmandakh/repos","events_url":"https://api.github.com/users/dulmandakh/events{/privacy}","received_events_url":"https://api.github.com/users/dulmandakh/received_events","type":"User","site_admin":false},"body":"This PR will bump Android SDK to 28, build tools to 28.0.2 and support library to 27.1.1. But issue related to aapt2 is breaking RNTester app. \r\n\r\n## Solution\r\n\r\nAfter some research I found that we need to compile (or copy) resources using **aapt2 compile** command. **aapt2** is located in  **${sdkDir}/${buildToolsVersion}** directory.\r\n\r\nAnd resource bundling is handled in **copy** function of the **local-cli/bundle/saveAssets.js** file. In **react.gradle** file we can access **sdkDir** via **project.android.sdkDirectory**, **buildToolsVersion** via **project.android.sdkDirectory**.\r\n\r\nThe solution might be pass aapt2 path to bundler and use it to compile resources.\r\n\r\nI'm not proficient in gradle, and would like to discuss to find better solution.\r\n\r\nPlease help @gengjiawen @hramos @kelset \r\n\r\nResources\r\n* https://android.googlesource.com/platform/frameworks/base/+/master/tools/aapt2/readme.md\r\n* https://stackoverflow.com/questions/42082352/how-to-use-aapt2-where-is-the-documentation\r\n\r\nTest Plan:\r\n----------\r\n\r\nEverything should build and run as usual.\r\n\r\nRelease Notes:\r\n--------------\r\n[ANDROID] [ENHANCEMENT] [SDK] - Bump to 27","created_at":"2018-07-04T11:19:33Z","updated_at":"2018-08-07T14:02:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ef3f8af34f5feace2667a6b92ea8d1c6bb387d26","assignee":null,"assignees":[],"requested_reviewers":[{"login":"hramos","id":165856,"node_id":"MDQ6VXNlcjE2NTg1Ng==","avatar_url":"https://avatars3.githubusercontent.com/u/165856?v=4","gravatar_id":"","url":"https://api.github.com/users/hramos","html_url":"https://github.com/hramos","followers_url":"https://api.github.com/users/hramos/followers","following_url":"https://api.github.com/users/hramos/following{/other_user}","gists_url":"https://api.github.com/users/hramos/gists{/gist_id}","starred_url":"https://api.github.com/users/hramos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hramos/subscriptions","organizations_url":"https://api.github.com/users/hramos/orgs","repos_url":"https://api.github.com/users/hramos/repos","events_url":"https://api.github.com/users/hramos/events{/privacy}","received_events_url":"https://api.github.com/users/hramos/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":870851515,"node_id":"MDU6TGFiZWw4NzA4NTE1MTU=","url":"https://api.github.com/repos/facebook/react-native/labels/:large_blue_diamond:Android","name":":large_blue_diamond:Android","color":"bfd4f2","default":false},{"id":869759799,"node_id":"MDU6TGFiZWw4Njk3NTk3OTk=","url":"https://api.github.com/repos/facebook/react-native/labels/:white_check_mark:Release%20Notes","name":":white_check_mark:Release Notes","color":"0e8a16","default":false},{"id":934239421,"node_id":"MDU6TGFiZWw5MzQyMzk0MjE=","url":"https://api.github.com/repos/facebook/react-native/labels/:white_check_mark:Test%20Plan","name":":white_check_mark:Test Plan","color":"0e8a16","default":false},{"id":196858975,"node_id":"MDU6TGFiZWwxOTY4NTg5NzU=","url":"https://api.github.com/repos/facebook/react-native/labels/CLA%20Signed","name":"CLA Signed","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/facebook/react-native/pulls/20026/commits","review_comments_url":"https://api.github.com/repos/facebook/react-native/pulls/20026/comments","review_comment_url":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebook/react-native/issues/20026/comments","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/c47349a8a1d2afa5eb3be9b28f88976d749776bb","head":{"label":"dulmandakh:bump-sdk-27","ref":"bump-sdk-27","sha":"c47349a8a1d2afa5eb3be9b28f88976d749776bb","user":{"login":"dulmandakh","id":178494,"node_id":"MDQ6VXNlcjE3ODQ5NA==","avatar_url":"https://avatars2.githubusercontent.com/u/178494?v=4","gravatar_id":"","url":"https://api.github.com/users/dulmandakh","html_url":"https://github.com/dulmandakh","followers_url":"https://api.github.com/users/dulmandakh/followers","following_url":"https://api.github.com/users/dulmandakh/following{/other_user}","gists_url":"https://api.github.com/users/dulmandakh/gists{/gist_id}","starred_url":"https://api.github.com/users/dulmandakh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dulmandakh/subscriptions","organizations_url":"https://api.github.com/users/dulmandakh/orgs","repos_url":"https://api.github.com/users/dulmandakh/repos","events_url":"https://api.github.com/users/dulmandakh/events{/privacy}","received_events_url":"https://api.github.com/users/dulmandakh/received_events","type":"User","site_admin":false},"repo":{"id":126940689,"node_id":"MDEwOlJlcG9zaXRvcnkxMjY5NDA2ODk=","name":"react-native","full_name":"dulmandakh/react-native","owner":{"login":"dulmandakh","id":178494,"node_id":"MDQ6VXNlcjE3ODQ5NA==","avatar_url":"https://avatars2.githubusercontent.com/u/178494?v=4","gravatar_id":"","url":"https://api.github.com/users/dulmandakh","html_url":"https://github.com/dulmandakh","followers_url":"https://api.github.com/users/dulmandakh/followers","following_url":"https://api.github.com/users/dulmandakh/following{/other_user}","gists_url":"https://api.github.com/users/dulmandakh/gists{/gist_id}","starred_url":"https://api.github.com/users/dulmandakh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dulmandakh/subscriptions","organizations_url":"https://api.github.com/users/dulmandakh/orgs","repos_url":"https://api.github.com/users/dulmandakh/repos","events_url":"https://api.github.com/users/dulmandakh/events{/privacy}","received_events_url":"https://api.github.com/users/dulmandakh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dulmandakh/react-native","description":"A framework for building native apps with React.","fork":true,"url":"https://api.github.com/repos/dulmandakh/react-native","forks_url":"https://api.github.com/repos/dulmandakh/react-native/forks","keys_url":"https://api.github.com/repos/dulmandakh/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dulmandakh/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dulmandakh/react-native/teams","hooks_url":"https://api.github.com/repos/dulmandakh/react-native/hooks","issue_events_url":"https://api.github.com/repos/dulmandakh/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/dulmandakh/react-native/events","assignees_url":"https://api.github.com/repos/dulmandakh/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/dulmandakh/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/dulmandakh/react-native/tags","blobs_url":"https://api.github.com/repos/dulmandakh/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dulmandakh/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dulmandakh/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/dulmandakh/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dulmandakh/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/dulmandakh/react-native/languages","stargazers_url":"https://api.github.com/repos/dulmandakh/react-native/stargazers","contributors_url":"https://api.github.com/repos/dulmandakh/react-native/contributors","subscribers_url":"https://api.github.com/repos/dulmandakh/react-native/subscribers","subscription_url":"https://api.github.com/repos/dulmandakh/react-native/subscription","commits_url":"https://api.github.com/repos/dulmandakh/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/dulmandakh/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/dulmandakh/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/dulmandakh/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/dulmandakh/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/dulmandakh/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dulmandakh/react-native/merges","archive_url":"https://api.github.com/repos/dulmandakh/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dulmandakh/react-native/downloads","issues_url":"https://api.github.com/repos/dulmandakh/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/dulmandakh/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/dulmandakh/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/dulmandakh/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dulmandakh/react-native/labels{/name}","releases_url":"https://api.github.com/repos/dulmandakh/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/dulmandakh/react-native/deployments","created_at":"2018-03-27T06:40:08Z","updated_at":"2018-08-07T00:38:34Z","pushed_at":"2018-08-07T13:52:42Z","git_url":"git://github.com/dulmandakh/react-native.git","ssh_url":"git@github.com:dulmandakh/react-native.git","clone_url":"https://github.com/dulmandakh/react-native.git","svn_url":"https://github.com/dulmandakh/react-native","homepage":"http://facebook.github.io/react-native/","size":218378,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"facebook:master","ref":"master","sha":"151ec411aa54670254f6d4b732a389b79ddd2a36","user":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"repo":{"id":29028775,"node_id":"MDEwOlJlcG9zaXRvcnkyOTAyODc3NQ==","name":"react-native","full_name":"facebook/react-native","owner":{"login":"facebook","id":69631,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NjMx","avatar_url":"https://avatars3.githubusercontent.com/u/69631?v=4","gravatar_id":"","url":"https://api.github.com/users/facebook","html_url":"https://github.com/facebook","followers_url":"https://api.github.com/users/facebook/followers","following_url":"https://api.github.com/users/facebook/following{/other_user}","gists_url":"https://api.github.com/users/facebook/gists{/gist_id}","starred_url":"https://api.github.com/users/facebook/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebook/subscriptions","organizations_url":"https://api.github.com/users/facebook/orgs","repos_url":"https://api.github.com/users/facebook/repos","events_url":"https://api.github.com/users/facebook/events{/privacy}","received_events_url":"https://api.github.com/users/facebook/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/facebook/react-native","description":"A framework for building native apps with React.","fork":false,"url":"https://api.github.com/repos/facebook/react-native","forks_url":"https://api.github.com/repos/facebook/react-native/forks","keys_url":"https://api.github.com/repos/facebook/react-native/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebook/react-native/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebook/react-native/teams","hooks_url":"https://api.github.com/repos/facebook/react-native/hooks","issue_events_url":"https://api.github.com/repos/facebook/react-native/issues/events{/number}","events_url":"https://api.github.com/repos/facebook/react-native/events","assignees_url":"https://api.github.com/repos/facebook/react-native/assignees{/user}","branches_url":"https://api.github.com/repos/facebook/react-native/branches{/branch}","tags_url":"https://api.github.com/repos/facebook/react-native/tags","blobs_url":"https://api.github.com/repos/facebook/react-native/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebook/react-native/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebook/react-native/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebook/react-native/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebook/react-native/statuses/{sha}","languages_url":"https://api.github.com/repos/facebook/react-native/languages","stargazers_url":"https://api.github.com/repos/facebook/react-native/stargazers","contributors_url":"https://api.github.com/repos/facebook/react-native/contributors","subscribers_url":"https://api.github.com/repos/facebook/react-native/subscribers","subscription_url":"https://api.github.com/repos/facebook/react-native/subscription","commits_url":"https://api.github.com/repos/facebook/react-native/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebook/react-native/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebook/react-native/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebook/react-native/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebook/react-native/contents/{+path}","compare_url":"https://api.github.com/repos/facebook/react-native/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebook/react-native/merges","archive_url":"https://api.github.com/repos/facebook/react-native/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebook/react-native/downloads","issues_url":"https://api.github.com/repos/facebook/react-native/issues{/number}","pulls_url":"https://api.github.com/repos/facebook/react-native/pulls{/number}","milestones_url":"https://api.github.com/repos/facebook/react-native/milestones{/number}","notifications_url":"https://api.github.com/repos/facebook/react-native/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebook/react-native/labels{/name}","releases_url":"https://api.github.com/repos/facebook/react-native/releases{/id}","deployments_url":"https://api.github.com/repos/facebook/react-native/deployments","created_at":"2015-01-09T18:10:16Z","updated_at":"2018-08-07T13:59:09Z","pushed_at":"2018-08-07T13:52:48Z","git_url":"git://github.com/facebook/react-native.git","ssh_url":"git@github.com:facebook/react-native.git","clone_url":"https://github.com/facebook/react-native.git","svn_url":"https://github.com/facebook/react-native","homepage":"https://facebook.github.io/react-native/","size":254990,"stargazers_count":67217,"watchers_count":67217,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":15118,"mirror_url":null,"archived":false,"open_issues_count":907,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":15118,"open_issues":907,"watchers":67217,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebook/react-native/pulls/20026"},"html":{"href":"https://github.com/facebook/react-native/pull/20026"},"issue":{"href":"https://api.github.com/repos/facebook/react-native/issues/20026"},"comments":{"href":"https://api.github.com/repos/facebook/react-native/issues/20026/comments"},"review_comments":{"href":"https://api.github.com/repos/facebook/react-native/pulls/20026/comments"},"review_comment":{"href":"https://api.github.com/repos/facebook/react-native/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebook/react-native/pulls/20026/commits"},"statuses":{"href":"https://api.github.com/repos/facebook/react-native/statuses/c47349a8a1d2afa5eb3be9b28f88976d749776bb"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"dulmandakh"}}