{"action":"created","comment":{"url":"https://api.github.com/repos/VOID001/ssf2fcitx/pulls/comments/224516388","pull_request_review_id":163904746,"id":224516388,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDUxNjM4OA==","diff_hunk":"@@ -53,38 +57,37 @@ int main(int argc, char **argv) {\n                 break;\n         }\n     }\n-    if(src_file == NULL) {\n+    if (src_file == nullptr) {\n         fprintf(stderr, \"you must specify the ssf file to convert (see -h for options).\\n\");\n         return -1;\n     }\n-    if(dest_file == NULL) {\n+    if (dest_file == nullptr) {\n         // use the default option\n-        dest_file = (char *)default_dest;\n+        dest_file = (char *) default_dest;\n     }\n \n     FILE *fin = fopen(src_file, \"rb\");\n     if (!fin) {\n-        if(errno == ENOENT) {\n+        if (errno == ENOENT) {\n             fprintf(stderr, \"error opening file %s, %s\\n\", src_file, strerror(errno));\n             return -1;\n-        }\n-        else {\n+        } else {\n             fprintf(stderr, \"unknown error: %s\\n\", strerror(errno));\n             return -1;\n         }\n     }\n \n     unsigned char buf[MAX_BYTE];\n \n-    fread((void *)buf, sizeof(unsigned char), MAX_BYTE, fin);\n+    fread((void *) buf, sizeof(unsigned char), MAX_BYTE, fin);\n     fseek(fin, 0, SEEK_END);\n-    size_t file_size = ftell(fin);\n+    auto file_size = ftell(fin);\n     rewind(fin);\n     fclose(fin);\n \n     // First get the raw data pack\n     QByteArray unpacked;\n-    do_uncompress(buf, file_size, unpacked);","path":"main.cpp","position":88,"original_position":88,"commit_id":"6991851affcfc1a19ee7b22b9cbaeb96886934e6","original_commit_id":"6991851affcfc1a19ee7b22b9cbaeb96886934e6","user":{"login":"DuckSoft","id":7822648,"node_id":"MDQ6VXNlcjc4MjI2NDg=","avatar_url":"https://avatars2.githubusercontent.com/u/7822648?v=4","gravatar_id":"","url":"https://api.github.com/users/DuckSoft","html_url":"https://github.com/DuckSoft","followers_url":"https://api.github.com/users/DuckSoft/followers","following_url":"https://api.github.com/users/DuckSoft/following{/other_user}","gists_url":"https://api.github.com/users/DuckSoft/gists{/gist_id}","starred_url":"https://api.github.com/users/DuckSoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DuckSoft/subscriptions","organizations_url":"https://api.github.com/users/DuckSoft/orgs","repos_url":"https://api.github.com/users/DuckSoft/repos","events_url":"https://api.github.com/users/DuckSoft/events{/privacy}","received_events_url":"https://api.github.com/users/DuckSoft/received_events","type":"User","site_admin":false},"body":"implicit passing `long` through `int` without cast","created_at":"2018-10-11T16:27:40Z","updated_at":"2018-10-11T16:27:41Z","html_url":"https://github.com/VOID001/ssf2fcitx/pull/12#discussion_r224516388","pull_request_url":"https://api.github.com/repos/VOID001/ssf2fcitx/pulls/12","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/VOID001/ssf2fcitx/pulls/comments/224516388"},"html":{"href":"https://github.com/VOID001/ssf2fcitx/pull/12#discussion_r224516388"},"pull_request":{"href":"https://api.github.com/repos/VOID001/ssf2fcitx/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/VOID001/ssf2fcitx/pulls/12","id":222199965,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMTk5OTY1","html_url":"https://github.com/VOID001/ssf2fcitx/pull/12","diff_url":"https://github.com/VOID001/ssf2fcitx/pull/12.diff","patch_url":"https://github.com/VOID001/ssf2fcitx/pull/12.patch","issue_url":"https://api.github.com/repos/VOID001/ssf2fcitx/issues/12","number":12,"state":"open","locked":false,"title":"Code Cleanup","user":{"login":"DuckSoft","id":7822648,"node_id":"MDQ6VXNlcjc4MjI2NDg=","avatar_url":"https://avatars2.githubusercontent.com/u/7822648?v=4","gravatar_id":"","url":"https://api.github.com/users/DuckSoft","html_url":"https://github.com/DuckSoft","followers_url":"https://api.github.com/users/DuckSoft/followers","following_url":"https://api.github.com/users/DuckSoft/following{/other_user}","gists_url":"https://api.github.com/users/DuckSoft/gists{/gist_id}","starred_url":"https://api.github.com/users/DuckSoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DuckSoft/subscriptions","organizations_url":"https://api.github.com/users/DuckSoft/orgs","repos_url":"https://api.github.com/users/DuckSoft/repos","events_url":"https://api.github.com/users/DuckSoft/events{/privacy}","received_events_url":"https://api.github.com/users/DuckSoft/received_events","type":"User","site_admin":false},"body":"Very embarrassed, I only did a little work, thank you QuQ\r\n\r\nSigned-off-by: DuckSoft <ducksoft@foxmail.com>","created_at":"2018-10-11T16:21:47Z","updated_at":"2018-10-11T16:27:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"165937bb06dc537de7aad39513bce5408a71c8ed","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/VOID001/ssf2fcitx/pulls/12/commits","review_comments_url":"https://api.github.com/repos/VOID001/ssf2fcitx/pulls/12/comments","review_comment_url":"https://api.github.com/repos/VOID001/ssf2fcitx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/VOID001/ssf2fcitx/issues/12/comments","statuses_url":"https://api.github.com/repos/VOID001/ssf2fcitx/statuses/6991851affcfc1a19ee7b22b9cbaeb96886934e6","head":{"label":"DuckSoft:master","ref":"master","sha":"6991851affcfc1a19ee7b22b9cbaeb96886934e6","user":{"login":"DuckSoft","id":7822648,"node_id":"MDQ6VXNlcjc4MjI2NDg=","avatar_url":"https://avatars2.githubusercontent.com/u/7822648?v=4","gravatar_id":"","url":"https://api.github.com/users/DuckSoft","html_url":"https://github.com/DuckSoft","followers_url":"https://api.github.com/users/DuckSoft/followers","following_url":"https://api.github.com/users/DuckSoft/following{/other_user}","gists_url":"https://api.github.com/users/DuckSoft/gists{/gist_id}","starred_url":"https://api.github.com/users/DuckSoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DuckSoft/subscriptions","organizations_url":"https://api.github.com/users/DuckSoft/orgs","repos_url":"https://api.github.com/users/DuckSoft/repos","events_url":"https://api.github.com/users/DuckSoft/events{/privacy}","received_events_url":"https://api.github.com/users/DuckSoft/received_events","type":"User","site_admin":false},"repo":{"id":152583293,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI1ODMyOTM=","name":"ssf2fcitx","full_name":"DuckSoft/ssf2fcitx","private":false,"owner":{"login":"DuckSoft","id":7822648,"node_id":"MDQ6VXNlcjc4MjI2NDg=","avatar_url":"https://avatars2.githubusercontent.com/u/7822648?v=4","gravatar_id":"","url":"https://api.github.com/users/DuckSoft","html_url":"https://github.com/DuckSoft","followers_url":"https://api.github.com/users/DuckSoft/followers","following_url":"https://api.github.com/users/DuckSoft/following{/other_user}","gists_url":"https://api.github.com/users/DuckSoft/gists{/gist_id}","starred_url":"https://api.github.com/users/DuckSoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DuckSoft/subscriptions","organizations_url":"https://api.github.com/users/DuckSoft/orgs","repos_url":"https://api.github.com/users/DuckSoft/repos","events_url":"https://api.github.com/users/DuckSoft/events{/privacy}","received_events_url":"https://api.github.com/users/DuckSoft/received_events","type":"User","site_admin":false},"html_url":"https://github.com/DuckSoft/ssf2fcitx","description":"Automagically convert your favorite sogou-pinyin skin to fcitx skin","fork":true,"url":"https://api.github.com/repos/DuckSoft/ssf2fcitx","forks_url":"https://api.github.com/repos/DuckSoft/ssf2fcitx/forks","keys_url":"https://api.github.com/repos/DuckSoft/ssf2fcitx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DuckSoft/ssf2fcitx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DuckSoft/ssf2fcitx/teams","hooks_url":"https://api.github.com/repos/DuckSoft/ssf2fcitx/hooks","issue_events_url":"https://api.github.com/repos/DuckSoft/ssf2fcitx/issues/events{/number}","events_url":"https://api.github.com/repos/DuckSoft/ssf2fcitx/events","assignees_url":"https://api.github.com/repos/DuckSoft/ssf2fcitx/assignees{/user}","branches_url":"https://api.github.com/repos/DuckSoft/ssf2fcitx/branches{/branch}","tags_url":"https://api.github.com/repos/DuckSoft/ssf2fcitx/tags","blobs_url":"https://api.github.com/repos/DuckSoft/ssf2fcitx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DuckSoft/ssf2fcitx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DuckSoft/ssf2fcitx/git/refs{/sha}","trees_url":"https://api.github.com/repos/DuckSoft/ssf2fcitx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DuckSoft/ssf2fcitx/statuses/{sha}","languages_url":"https://api.github.com/repos/DuckSoft/ssf2fcitx/languages","stargazers_url":"https://api.github.com/repos/DuckSoft/ssf2fcitx/stargazers","contributors_url":"https://api.github.com/repos/DuckSoft/ssf2fcitx/contributors","subscribers_url":"https://api.github.com/repos/DuckSoft/ssf2fcitx/subscribers","subscription_url":"https://api.github.com/repos/DuckSoft/ssf2fcitx/subscription","commits_url":"https://api.github.com/repos/DuckSoft/ssf2fcitx/commits{/sha}","git_commits_url":"https://api.github.com/repos/DuckSoft/ssf2fcitx/git/commits{/sha}","comments_url":"https://api.github.com/repos/DuckSoft/ssf2fcitx/comments{/number}","issue_comment_url":"https://api.github.com/repos/DuckSoft/ssf2fcitx/issues/comments{/number}","contents_url":"https://api.github.com/repos/DuckSoft/ssf2fcitx/contents/{+path}","compare_url":"https://api.github.com/repos/DuckSoft/ssf2fcitx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DuckSoft/ssf2fcitx/merges","archive_url":"https://api.github.com/repos/DuckSoft/ssf2fcitx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DuckSoft/ssf2fcitx/downloads","issues_url":"https://api.github.com/repos/DuckSoft/ssf2fcitx/issues{/number}","pulls_url":"https://api.github.com/repos/DuckSoft/ssf2fcitx/pulls{/number}","milestones_url":"https://api.github.com/repos/DuckSoft/ssf2fcitx/milestones{/number}","notifications_url":"https://api.github.com/repos/DuckSoft/ssf2fcitx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DuckSoft/ssf2fcitx/labels{/name}","releases_url":"https://api.github.com/repos/DuckSoft/ssf2fcitx/releases{/id}","deployments_url":"https://api.github.com/repos/DuckSoft/ssf2fcitx/deployments","created_at":"2018-10-11T11:50:04Z","updated_at":"2018-10-11T16:19:39Z","pushed_at":"2018-10-11T16:19:38Z","git_url":"git://github.com/DuckSoft/ssf2fcitx.git","ssh_url":"git@github.com:DuckSoft/ssf2fcitx.git","clone_url":"https://github.com/DuckSoft/ssf2fcitx.git","svn_url":"https://github.com/DuckSoft/ssf2fcitx","homepage":null,"size":493,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"VOID001:master","ref":"master","sha":"78b0460214ae2555ae706e55e71234c17c0deddc","user":{"login":"VOID001","id":6134883,"node_id":"MDQ6VXNlcjYxMzQ4ODM=","avatar_url":"https://avatars3.githubusercontent.com/u/6134883?v=4","gravatar_id":"","url":"https://api.github.com/users/VOID001","html_url":"https://github.com/VOID001","followers_url":"https://api.github.com/users/VOID001/followers","following_url":"https://api.github.com/users/VOID001/following{/other_user}","gists_url":"https://api.github.com/users/VOID001/gists{/gist_id}","starred_url":"https://api.github.com/users/VOID001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VOID001/subscriptions","organizations_url":"https://api.github.com/users/VOID001/orgs","repos_url":"https://api.github.com/users/VOID001/repos","events_url":"https://api.github.com/users/VOID001/events{/privacy}","received_events_url":"https://api.github.com/users/VOID001/received_events","type":"User","site_admin":false},"repo":{"id":152001416,"node_id":"MDEwOlJlcG9zaXRvcnkxNTIwMDE0MTY=","name":"ssf2fcitx","full_name":"VOID001/ssf2fcitx","private":false,"owner":{"login":"VOID001","id":6134883,"node_id":"MDQ6VXNlcjYxMzQ4ODM=","avatar_url":"https://avatars3.githubusercontent.com/u/6134883?v=4","gravatar_id":"","url":"https://api.github.com/users/VOID001","html_url":"https://github.com/VOID001","followers_url":"https://api.github.com/users/VOID001/followers","following_url":"https://api.github.com/users/VOID001/following{/other_user}","gists_url":"https://api.github.com/users/VOID001/gists{/gist_id}","starred_url":"https://api.github.com/users/VOID001/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VOID001/subscriptions","organizations_url":"https://api.github.com/users/VOID001/orgs","repos_url":"https://api.github.com/users/VOID001/repos","events_url":"https://api.github.com/users/VOID001/events{/privacy}","received_events_url":"https://api.github.com/users/VOID001/received_events","type":"User","site_admin":false},"html_url":"https://github.com/VOID001/ssf2fcitx","description":"Automagically convert your favorite sogou-pinyin skin to fcitx skin","fork":false,"url":"https://api.github.com/repos/VOID001/ssf2fcitx","forks_url":"https://api.github.com/repos/VOID001/ssf2fcitx/forks","keys_url":"https://api.github.com/repos/VOID001/ssf2fcitx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VOID001/ssf2fcitx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VOID001/ssf2fcitx/teams","hooks_url":"https://api.github.com/repos/VOID001/ssf2fcitx/hooks","issue_events_url":"https://api.github.com/repos/VOID001/ssf2fcitx/issues/events{/number}","events_url":"https://api.github.com/repos/VOID001/ssf2fcitx/events","assignees_url":"https://api.github.com/repos/VOID001/ssf2fcitx/assignees{/user}","branches_url":"https://api.github.com/repos/VOID001/ssf2fcitx/branches{/branch}","tags_url":"https://api.github.com/repos/VOID001/ssf2fcitx/tags","blobs_url":"https://api.github.com/repos/VOID001/ssf2fcitx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VOID001/ssf2fcitx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VOID001/ssf2fcitx/git/refs{/sha}","trees_url":"https://api.github.com/repos/VOID001/ssf2fcitx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VOID001/ssf2fcitx/statuses/{sha}","languages_url":"https://api.github.com/repos/VOID001/ssf2fcitx/languages","stargazers_url":"https://api.github.com/repos/VOID001/ssf2fcitx/stargazers","contributors_url":"https://api.github.com/repos/VOID001/ssf2fcitx/contributors","subscribers_url":"https://api.github.com/repos/VOID001/ssf2fcitx/subscribers","subscription_url":"https://api.github.com/repos/VOID001/ssf2fcitx/subscription","commits_url":"https://api.github.com/repos/VOID001/ssf2fcitx/commits{/sha}","git_commits_url":"https://api.github.com/repos/VOID001/ssf2fcitx/git/commits{/sha}","comments_url":"https://api.github.com/repos/VOID001/ssf2fcitx/comments{/number}","issue_comment_url":"https://api.github.com/repos/VOID001/ssf2fcitx/issues/comments{/number}","contents_url":"https://api.github.com/repos/VOID001/ssf2fcitx/contents/{+path}","compare_url":"https://api.github.com/repos/VOID001/ssf2fcitx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VOID001/ssf2fcitx/merges","archive_url":"https://api.github.com/repos/VOID001/ssf2fcitx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VOID001/ssf2fcitx/downloads","issues_url":"https://api.github.com/repos/VOID001/ssf2fcitx/issues{/number}","pulls_url":"https://api.github.com/repos/VOID001/ssf2fcitx/pulls{/number}","milestones_url":"https://api.github.com/repos/VOID001/ssf2fcitx/milestones{/number}","notifications_url":"https://api.github.com/repos/VOID001/ssf2fcitx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VOID001/ssf2fcitx/labels{/name}","releases_url":"https://api.github.com/repos/VOID001/ssf2fcitx/releases{/id}","deployments_url":"https://api.github.com/repos/VOID001/ssf2fcitx/deployments","created_at":"2018-10-08T01:24:35Z","updated_at":"2018-10-11T15:24:54Z","pushed_at":"2018-10-11T16:21:47Z","git_url":"git://github.com/VOID001/ssf2fcitx.git","ssh_url":"git@github.com:VOID001/ssf2fcitx.git","clone_url":"https://github.com/VOID001/ssf2fcitx.git","svn_url":"https://github.com/VOID001/ssf2fcitx","homepage":null,"size":493,"stargazers_count":22,"watchers_count":22,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":10,"license":null,"forks":1,"open_issues":10,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/VOID001/ssf2fcitx/pulls/12"},"html":{"href":"https://github.com/VOID001/ssf2fcitx/pull/12"},"issue":{"href":"https://api.github.com/repos/VOID001/ssf2fcitx/issues/12"},"comments":{"href":"https://api.github.com/repos/VOID001/ssf2fcitx/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/VOID001/ssf2fcitx/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/VOID001/ssf2fcitx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/VOID001/ssf2fcitx/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/VOID001/ssf2fcitx/statuses/6991851affcfc1a19ee7b22b9cbaeb96886934e6"}},"author_association":"NONE"}}
{"actor":{"display_login":"DuckSoft"}}