{"action":"closed","number":865,"pull_request":{"url":"https://api.github.com/repos/angr/angr/pulls/865","id":169335558,"html_url":"https://github.com/angr/angr/pull/865","diff_url":"https://github.com/angr/angr/pull/865.diff","patch_url":"https://github.com/angr/angr/pull/865.patch","issue_url":"https://api.github.com/repos/angr/angr/issues/865","number":865,"state":"closed","locked":false,"title":"Removed 'else' from CFGFast._generate_cfgnode() to improve readability","user":{"login":"ArtemShypotilov","id":32328336,"avatar_url":"https://avatars2.githubusercontent.com/u/32328336?v=4","gravatar_id":"","url":"https://api.github.com/users/ArtemShypotilov","html_url":"https://github.com/ArtemShypotilov","followers_url":"https://api.github.com/users/ArtemShypotilov/followers","following_url":"https://api.github.com/users/ArtemShypotilov/following{/other_user}","gists_url":"https://api.github.com/users/ArtemShypotilov/gists{/gist_id}","starred_url":"https://api.github.com/users/ArtemShypotilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArtemShypotilov/subscriptions","organizations_url":"https://api.github.com/users/ArtemShypotilov/orgs","repos_url":"https://api.github.com/users/ArtemShypotilov/repos","events_url":"https://api.github.com/users/ArtemShypotilov/events{/privacy}","received_events_url":"https://api.github.com/users/ArtemShypotilov/received_events","type":"User","site_admin":false},"body":"As discussed per https://github.com/angr/angr/pull/858 removed 'else' from CFGFast._generate_cfgnode() to improve readability.\r\n\r\nPrevious method structure:\r\n\r\n```\r\ndef _generate_cfgnode():\r\ntry:\r\n    if ...\r\n        ...\r\n    else\r\n        ...\r\n    return ...\r\nexcept\r\n...\r\n```\r\n\r\nNow:\r\n\r\n```\r\ndef _generate_cfgnode():\r\ntry:\r\n    if ...\r\n        ...\r\n        return ...\r\n    ...\r\n    return ...\r\nexcept\r\n...\r\n```\r\n\r\nPlease consider this change. Thanks.","created_at":"2018-02-15T10:40:53Z","updated_at":"2018-02-15T13:59:34Z","closed_at":"2018-02-15T13:59:34Z","merged_at":"2018-02-15T13:59:34Z","merge_commit_sha":"cace1c6d22362f329cd79ad940190e362dca7630","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/angr/angr/pulls/865/commits","review_comments_url":"https://api.github.com/repos/angr/angr/pulls/865/comments","review_comment_url":"https://api.github.com/repos/angr/angr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angr/angr/issues/865/comments","statuses_url":"https://api.github.com/repos/angr/angr/statuses/6dc3e5a71e8c0e943d90ae6e941ec1ee8630136c","head":{"label":"ArtemShypotilov:gen_cfgnode_impr_v2","ref":"gen_cfgnode_impr_v2","sha":"6dc3e5a71e8c0e943d90ae6e941ec1ee8630136c","user":{"login":"ArtemShypotilov","id":32328336,"avatar_url":"https://avatars2.githubusercontent.com/u/32328336?v=4","gravatar_id":"","url":"https://api.github.com/users/ArtemShypotilov","html_url":"https://github.com/ArtemShypotilov","followers_url":"https://api.github.com/users/ArtemShypotilov/followers","following_url":"https://api.github.com/users/ArtemShypotilov/following{/other_user}","gists_url":"https://api.github.com/users/ArtemShypotilov/gists{/gist_id}","starred_url":"https://api.github.com/users/ArtemShypotilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArtemShypotilov/subscriptions","organizations_url":"https://api.github.com/users/ArtemShypotilov/orgs","repos_url":"https://api.github.com/users/ArtemShypotilov/repos","events_url":"https://api.github.com/users/ArtemShypotilov/events{/privacy}","received_events_url":"https://api.github.com/users/ArtemShypotilov/received_events","type":"User","site_admin":false},"repo":{"id":121410580,"name":"angr","full_name":"ArtemShypotilov/angr","owner":{"login":"ArtemShypotilov","id":32328336,"avatar_url":"https://avatars2.githubusercontent.com/u/32328336?v=4","gravatar_id":"","url":"https://api.github.com/users/ArtemShypotilov","html_url":"https://github.com/ArtemShypotilov","followers_url":"https://api.github.com/users/ArtemShypotilov/followers","following_url":"https://api.github.com/users/ArtemShypotilov/following{/other_user}","gists_url":"https://api.github.com/users/ArtemShypotilov/gists{/gist_id}","starred_url":"https://api.github.com/users/ArtemShypotilov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArtemShypotilov/subscriptions","organizations_url":"https://api.github.com/users/ArtemShypotilov/orgs","repos_url":"https://api.github.com/users/ArtemShypotilov/repos","events_url":"https://api.github.com/users/ArtemShypotilov/events{/privacy}","received_events_url":"https://api.github.com/users/ArtemShypotilov/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ArtemShypotilov/angr","description":"The next-generation binary analysis platform from UC Santa Barbara's Seclab!","fork":true,"url":"https://api.github.com/repos/ArtemShypotilov/angr","forks_url":"https://api.github.com/repos/ArtemShypotilov/angr/forks","keys_url":"https://api.github.com/repos/ArtemShypotilov/angr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ArtemShypotilov/angr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ArtemShypotilov/angr/teams","hooks_url":"https://api.github.com/repos/ArtemShypotilov/angr/hooks","issue_events_url":"https://api.github.com/repos/ArtemShypotilov/angr/issues/events{/number}","events_url":"https://api.github.com/repos/ArtemShypotilov/angr/events","assignees_url":"https://api.github.com/repos/ArtemShypotilov/angr/assignees{/user}","branches_url":"https://api.github.com/repos/ArtemShypotilov/angr/branches{/branch}","tags_url":"https://api.github.com/repos/ArtemShypotilov/angr/tags","blobs_url":"https://api.github.com/repos/ArtemShypotilov/angr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ArtemShypotilov/angr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ArtemShypotilov/angr/git/refs{/sha}","trees_url":"https://api.github.com/repos/ArtemShypotilov/angr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ArtemShypotilov/angr/statuses/{sha}","languages_url":"https://api.github.com/repos/ArtemShypotilov/angr/languages","stargazers_url":"https://api.github.com/repos/ArtemShypotilov/angr/stargazers","contributors_url":"https://api.github.com/repos/ArtemShypotilov/angr/contributors","subscribers_url":"https://api.github.com/repos/ArtemShypotilov/angr/subscribers","subscription_url":"https://api.github.com/repos/ArtemShypotilov/angr/subscription","commits_url":"https://api.github.com/repos/ArtemShypotilov/angr/commits{/sha}","git_commits_url":"https://api.github.com/repos/ArtemShypotilov/angr/git/commits{/sha}","comments_url":"https://api.github.com/repos/ArtemShypotilov/angr/comments{/number}","issue_comment_url":"https://api.github.com/repos/ArtemShypotilov/angr/issues/comments{/number}","contents_url":"https://api.github.com/repos/ArtemShypotilov/angr/contents/{+path}","compare_url":"https://api.github.com/repos/ArtemShypotilov/angr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ArtemShypotilov/angr/merges","archive_url":"https://api.github.com/repos/ArtemShypotilov/angr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ArtemShypotilov/angr/downloads","issues_url":"https://api.github.com/repos/ArtemShypotilov/angr/issues{/number}","pulls_url":"https://api.github.com/repos/ArtemShypotilov/angr/pulls{/number}","milestones_url":"https://api.github.com/repos/ArtemShypotilov/angr/milestones{/number}","notifications_url":"https://api.github.com/repos/ArtemShypotilov/angr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ArtemShypotilov/angr/labels{/name}","releases_url":"https://api.github.com/repos/ArtemShypotilov/angr/releases{/id}","deployments_url":"https://api.github.com/repos/ArtemShypotilov/angr/deployments","created_at":"2018-02-13T17:07:12Z","updated_at":"2018-02-13T17:07:15Z","pushed_at":"2018-02-15T10:29:27Z","git_url":"git://github.com/ArtemShypotilov/angr.git","ssh_url":"git@github.com:ArtemShypotilov/angr.git","clone_url":"https://github.com/ArtemShypotilov/angr.git","svn_url":"https://github.com/ArtemShypotilov/angr","homepage":null,"size":35890,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"angr:master","ref":"master","sha":"f19480ab187280fd22f4738104dd5d0e25e2e78e","user":{"login":"angr","id":12520807,"avatar_url":"https://avatars3.githubusercontent.com/u/12520807?v=4","gravatar_id":"","url":"https://api.github.com/users/angr","html_url":"https://github.com/angr","followers_url":"https://api.github.com/users/angr/followers","following_url":"https://api.github.com/users/angr/following{/other_user}","gists_url":"https://api.github.com/users/angr/gists{/gist_id}","starred_url":"https://api.github.com/users/angr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angr/subscriptions","organizations_url":"https://api.github.com/users/angr/orgs","repos_url":"https://api.github.com/users/angr/repos","events_url":"https://api.github.com/users/angr/events{/privacy}","received_events_url":"https://api.github.com/users/angr/received_events","type":"Organization","site_admin":false},"repo":{"id":40328394,"name":"angr","full_name":"angr/angr","owner":{"login":"angr","id":12520807,"avatar_url":"https://avatars3.githubusercontent.com/u/12520807?v=4","gravatar_id":"","url":"https://api.github.com/users/angr","html_url":"https://github.com/angr","followers_url":"https://api.github.com/users/angr/followers","following_url":"https://api.github.com/users/angr/following{/other_user}","gists_url":"https://api.github.com/users/angr/gists{/gist_id}","starred_url":"https://api.github.com/users/angr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angr/subscriptions","organizations_url":"https://api.github.com/users/angr/orgs","repos_url":"https://api.github.com/users/angr/repos","events_url":"https://api.github.com/users/angr/events{/privacy}","received_events_url":"https://api.github.com/users/angr/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angr/angr","description":"The next-generation binary analysis platform from UC Santa Barbara's Seclab!","fork":false,"url":"https://api.github.com/repos/angr/angr","forks_url":"https://api.github.com/repos/angr/angr/forks","keys_url":"https://api.github.com/repos/angr/angr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angr/angr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angr/angr/teams","hooks_url":"https://api.github.com/repos/angr/angr/hooks","issue_events_url":"https://api.github.com/repos/angr/angr/issues/events{/number}","events_url":"https://api.github.com/repos/angr/angr/events","assignees_url":"https://api.github.com/repos/angr/angr/assignees{/user}","branches_url":"https://api.github.com/repos/angr/angr/branches{/branch}","tags_url":"https://api.github.com/repos/angr/angr/tags","blobs_url":"https://api.github.com/repos/angr/angr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angr/angr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angr/angr/git/refs{/sha}","trees_url":"https://api.github.com/repos/angr/angr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angr/angr/statuses/{sha}","languages_url":"https://api.github.com/repos/angr/angr/languages","stargazers_url":"https://api.github.com/repos/angr/angr/stargazers","contributors_url":"https://api.github.com/repos/angr/angr/contributors","subscribers_url":"https://api.github.com/repos/angr/angr/subscribers","subscription_url":"https://api.github.com/repos/angr/angr/subscription","commits_url":"https://api.github.com/repos/angr/angr/commits{/sha}","git_commits_url":"https://api.github.com/repos/angr/angr/git/commits{/sha}","comments_url":"https://api.github.com/repos/angr/angr/comments{/number}","issue_comment_url":"https://api.github.com/repos/angr/angr/issues/comments{/number}","contents_url":"https://api.github.com/repos/angr/angr/contents/{+path}","compare_url":"https://api.github.com/repos/angr/angr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angr/angr/merges","archive_url":"https://api.github.com/repos/angr/angr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angr/angr/downloads","issues_url":"https://api.github.com/repos/angr/angr/issues{/number}","pulls_url":"https://api.github.com/repos/angr/angr/pulls{/number}","milestones_url":"https://api.github.com/repos/angr/angr/milestones{/number}","notifications_url":"https://api.github.com/repos/angr/angr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angr/angr/labels{/name}","releases_url":"https://api.github.com/repos/angr/angr/releases{/id}","deployments_url":"https://api.github.com/repos/angr/angr/deployments","created_at":"2015-08-06T21:46:55Z","updated_at":"2018-02-15T11:48:02Z","pushed_at":"2018-02-15T13:59:34Z","git_url":"git://github.com/angr/angr.git","ssh_url":"git@github.com:angr/angr.git","clone_url":"https://github.com/angr/angr.git","svn_url":"https://github.com/angr/angr","homepage":null,"size":35941,"stargazers_count":2194,"watchers_count":2194,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":404,"mirror_url":null,"archived":false,"open_issues_count":288,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause"},"forks":404,"open_issues":288,"watchers":2194,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angr/angr/pulls/865"},"html":{"href":"https://github.com/angr/angr/pull/865"},"issue":{"href":"https://api.github.com/repos/angr/angr/issues/865"},"comments":{"href":"https://api.github.com/repos/angr/angr/issues/865/comments"},"review_comments":{"href":"https://api.github.com/repos/angr/angr/pulls/865/comments"},"review_comment":{"href":"https://api.github.com/repos/angr/angr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angr/angr/pulls/865/commits"},"statuses":{"href":"https://api.github.com/repos/angr/angr/statuses/6dc3e5a71e8c0e943d90ae6e941ec1ee8630136c"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ltfish","id":5071575,"avatar_url":"https://avatars1.githubusercontent.com/u/5071575?v=4","gravatar_id":"","url":"https://api.github.com/users/ltfish","html_url":"https://github.com/ltfish","followers_url":"https://api.github.com/users/ltfish/followers","following_url":"https://api.github.com/users/ltfish/following{/other_user}","gists_url":"https://api.github.com/users/ltfish/gists{/gist_id}","starred_url":"https://api.github.com/users/ltfish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ltfish/subscriptions","organizations_url":"https://api.github.com/users/ltfish/orgs","repos_url":"https://api.github.com/users/ltfish/repos","events_url":"https://api.github.com/users/ltfish/events{/privacy}","received_events_url":"https://api.github.com/users/ltfish/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":92,"deletions":92,"changed_files":1}}
{"actor":{"display_login":"ltfish"}}