{"action":"created","issue":{"url":"https://api.github.com/repos/NREL/EnergyPlus/issues/6449","repository_url":"https://api.github.com/repos/NREL/EnergyPlus","labels_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/6449/labels{/name}","comments_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/6449/comments","events_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/6449/events","html_url":"https://github.com/NREL/EnergyPlus/pull/6449","id":292443828,"number":6449,"title":"Correct VS coil air flow and fan RTF calculations","user":{"login":"rraustad","id":5778156,"avatar_url":"https://avatars3.githubusercontent.com/u/5778156?v=4","gravatar_id":"","url":"https://api.github.com/users/rraustad","html_url":"https://github.com/rraustad","followers_url":"https://api.github.com/users/rraustad/followers","following_url":"https://api.github.com/users/rraustad/following{/other_user}","gists_url":"https://api.github.com/users/rraustad/gists{/gist_id}","starred_url":"https://api.github.com/users/rraustad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rraustad/subscriptions","organizations_url":"https://api.github.com/users/rraustad/orgs","repos_url":"https://api.github.com/users/rraustad/repos","events_url":"https://api.github.com/users/rraustad/events{/privacy}","received_events_url":"https://api.github.com/users/rraustad/received_events","type":"User","site_admin":false},"labels":[{"id":837087400,"url":"https://api.github.com/repos/NREL/EnergyPlus/labels/NotIDDChange","name":"NotIDDChange","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/NREL/EnergyPlus/milestones/7","html_url":"https://github.com/NREL/EnergyPlus/milestone/7","labels_url":"https://api.github.com/repos/NREL/EnergyPlus/milestones/7/labels","id":2668648,"number":7,"title":"EnergyPlus 8.9.0","description":"Tentative on the naming.","creator":{"login":"Myoldmopar","id":849824,"avatar_url":"https://avatars0.githubusercontent.com/u/849824?v=4","gravatar_id":"","url":"https://api.github.com/users/Myoldmopar","html_url":"https://github.com/Myoldmopar","followers_url":"https://api.github.com/users/Myoldmopar/followers","following_url":"https://api.github.com/users/Myoldmopar/following{/other_user}","gists_url":"https://api.github.com/users/Myoldmopar/gists{/gist_id}","starred_url":"https://api.github.com/users/Myoldmopar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Myoldmopar/subscriptions","organizations_url":"https://api.github.com/users/Myoldmopar/orgs","repos_url":"https://api.github.com/users/Myoldmopar/repos","events_url":"https://api.github.com/users/Myoldmopar/events{/privacy}","received_events_url":"https://api.github.com/users/Myoldmopar/received_events","type":"User","site_admin":false},"open_issues":47,"closed_issues":49,"state":"open","created_at":"2017-07-29T02:49:31Z","updated_at":"2018-03-01T13:22:12Z","due_on":"2018-03-31T07:00:00Z","closed_at":null},"comments":20,"created_at":"2018-01-29T15:15:09Z","updated_at":"2018-03-01T21:09:45Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/NREL/EnergyPlus/pulls/6449","html_url":"https://github.com/NREL/EnergyPlus/pull/6449","diff_url":"https://github.com/NREL/EnergyPlus/pull/6449.diff","patch_url":"https://github.com/NREL/EnergyPlus/pull/6449.patch"},"body":"Pull request overview\r\n---------------------\r\nThe VS coil model uses an idle air flow rate to select air flow when the compressor is off and the fan operates continuously. When cycling fan is used and the compressor operates at low speed, the off air flow rate should = 0. This change correctly uses 0 during cycling fan operation when low compressor speed is used. Cycling losses are also accounted for using the standard adjustment from part load ratio to runtime fraction as RTF = PLR / PLF, where PLF is the adjustment factor to account for cycling losses. This corrects issue #6448.\r\n\r\n### Work Checklist\r\nAdd to this list or remove from it as applicable.  This is a simple templated set of guidelines.\r\n - [ ] Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)\r\n - [ ] At least one of the following appropriate labels must be added to this PR to be consumed into the changelog:\r\n   - Defect: This pull request repairs a github defect issue.  The github issue should be referenced in the PR description\r\n   - Refactoring: This pull request includes code changes that don't change the functionality of the program, just perform refactoring\r\n   - NewFeature: This pull request includes code to add a new feature to EnergyPlus\r\n   - Performance: This pull request includes code changes that are directed at improving the runtime performance of EnergyPlus\r\n   - DoNoPublish: This pull request includes changes that shouldn't be included in the changelog\r\n\r\n### Review Checklist\r\nThis will not be exhaustively relevant to every PR.\r\n - [ ] Code style (parentheses padding, variable names)\r\n - [ ] Functional code review (it has to work!)\r\n - [ ] If defect, results of running current develop vs this branch should exhibit the fix\r\n - [ ] CI status: all green or justified\r\n - [ ] Performance: CI Linux results include performance check -- verify this\r\n - [ ] Unit Test(s)\r\n - C++ checks:\r\n   - [ ] Argument types\r\n   - [ ] If any virtual classes, ensure virtual destructor included, other things\r\n - IDD changes:\r\n   - [ ] Verify naming conventions and styles, memos and notes and defaults\r\n   - [ ] Open windows IDF Editor with modified IDD to check for errors\r\n   - [ ] If transition, add rules to spreadsheet\r\n   - [ ] If transition, add transition source\r\n   - [ ] If transition, update idfs\r\n - [ ] If new idf included, locally check the err file and other outputs\r\n - [ ] Documentation changes in place\r\n - [ ] Changed docs build successfully\r\n - [ ] ExpandObjects changes?\r\n - [ ] If output changes, including tabular output structure, add to output rules file for interfaces\r\n"},"comment":{"url":"https://api.github.com/repos/NREL/EnergyPlus/issues/comments/369731650","html_url":"https://github.com/NREL/EnergyPlus/pull/6449#issuecomment-369731650","issue_url":"https://api.github.com/repos/NREL/EnergyPlus/issues/6449","id":369731650,"user":{"login":"rraustad","id":5778156,"avatar_url":"https://avatars3.githubusercontent.com/u/5778156?v=4","gravatar_id":"","url":"https://api.github.com/users/rraustad","html_url":"https://github.com/rraustad","followers_url":"https://api.github.com/users/rraustad/followers","following_url":"https://api.github.com/users/rraustad/following{/other_user}","gists_url":"https://api.github.com/users/rraustad/gists{/gist_id}","starred_url":"https://api.github.com/users/rraustad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rraustad/subscriptions","organizations_url":"https://api.github.com/users/rraustad/orgs","repos_url":"https://api.github.com/users/rraustad/repos","events_url":"https://api.github.com/users/rraustad/events{/privacy}","received_events_url":"https://api.github.com/users/rraustad/received_events","type":"User","site_admin":false},"created_at":"2018-03-01T21:09:45Z","updated_at":"2018-03-01T21:09:45Z","author_association":"CONTRIBUTOR","body":"@Myoldmopar is something really happening on the MacOS or is the CI not working correctly there? All other tests pass as expected."}}
{"actor":{"display_login":"rraustad"}}