{"action":"created","issue":{"url":"https://api.github.com/repos/nteract/nteract/issues/3672","repository_url":"https://api.github.com/repos/nteract/nteract","labels_url":"https://api.github.com/repos/nteract/nteract/issues/3672/labels{/name}","comments_url":"https://api.github.com/repos/nteract/nteract/issues/3672/comments","events_url":"https://api.github.com/repos/nteract/nteract/issues/3672/events","html_url":"https://github.com/nteract/nteract/pull/3672","id":382016882,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxODI1MTY0","number":3672,"title":"Some data-explorer fixes","user":{"login":"BenRussert","id":10860657,"node_id":"MDQ6VXNlcjEwODYwNjU3","avatar_url":"https://avatars0.githubusercontent.com/u/10860657?v=4","gravatar_id":"","url":"https://api.github.com/users/BenRussert","html_url":"https://github.com/BenRussert","followers_url":"https://api.github.com/users/BenRussert/followers","following_url":"https://api.github.com/users/BenRussert/following{/other_user}","gists_url":"https://api.github.com/users/BenRussert/gists{/gist_id}","starred_url":"https://api.github.com/users/BenRussert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenRussert/subscriptions","organizations_url":"https://api.github.com/users/BenRussert/orgs","repos_url":"https://api.github.com/users/BenRussert/repos","events_url":"https://api.github.com/users/BenRussert/events{/privacy}","received_events_url":"https://api.github.com/users/BenRussert/received_events","type":"User","site_admin":false},"labels":[{"id":928134834,"node_id":"MDU6TGFiZWw5MjgxMzQ4MzQ=","url":"https://api.github.com/repos/nteract/nteract/labels/data-explorer","name":"data-explorer","color":"0d0f7a","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-19T00:08:40Z","updated_at":"2018-11-19T06:02:33Z","closed_at":"2018-11-19T02:39:00Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/nteract/nteract/pulls/3672","html_url":"https://github.com/nteract/nteract/pull/3672","diff_url":"https://github.com/nteract/nteract/pull/3672.diff","patch_url":"https://github.com/nteract/nteract/pull/3672.patch"},"body":"These are some changes to fix various console errors. More info in the commit comments."},"comment":{"url":"https://api.github.com/repos/nteract/nteract/issues/comments/439780822","html_url":"https://github.com/nteract/nteract/pull/3672#issuecomment-439780822","issue_url":"https://api.github.com/repos/nteract/nteract/issues/3672","id":439780822,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTc4MDgyMg==","user":{"login":"BenRussert","id":10860657,"node_id":"MDQ6VXNlcjEwODYwNjU3","avatar_url":"https://avatars0.githubusercontent.com/u/10860657?v=4","gravatar_id":"","url":"https://api.github.com/users/BenRussert","html_url":"https://github.com/BenRussert","followers_url":"https://api.github.com/users/BenRussert/followers","following_url":"https://api.github.com/users/BenRussert/following{/other_user}","gists_url":"https://api.github.com/users/BenRussert/gists{/gist_id}","starred_url":"https://api.github.com/users/BenRussert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BenRussert/subscriptions","organizations_url":"https://api.github.com/users/BenRussert/orgs","repos_url":"https://api.github.com/users/BenRussert/repos","events_url":"https://api.github.com/users/BenRussert/events{/privacy}","received_events_url":"https://api.github.com/users/BenRussert/received_events","type":"User","site_admin":false},"created_at":"2018-11-19T06:02:33Z","updated_at":"2018-11-19T06:02:33Z","author_association":"MEMBER","body":"> I thought doing the state update in componentWillMount rather than componentDidMount meant that we had one fewer render\r\n\r\nIt does, render will be called twice here. Though the [docs for `componentDidMount`](https://reactjs.org/docs/react-component.html#componentwillunmount) say that this happens before the browser updates the screen, so the user won't notice.\r\n\r\nAll we would need to eliminate the need for either lifecycle method is to initialize all state in the constructor. I have [a branch where I did this as an example](https://github.com/nteract/nteract/compare/master...BenRussert:example-initializing-all-state-in-constructor), but without some more refactoring I thought this looked worse than just using `componentDidMount`."}}
{"actor":{"display_login":"BenRussert"}}