{"action":"created","comment":{"url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/comments/230353676","pull_request_review_id":171075343,"id":230353676,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDM1MzY3Ng==","diff_hunk":"@@ -349,4 +349,7 @@ If the parameter can be null, ignore this inspection result; passing a null valu\n   <data name=\"AssignmentNotUsedInspection\" xml:space=\"preserve\">\n     <value>An assignment is immediately overridden by another assignment or is never referenced.</value>\n   </data>\n+  <data name=\"ExcelMemberMayReturnNothingInspection\" xml:space=\"preserve\">\n+    <value>A Function or Property returning a reference type that can be 'Nothing' should not have the return value used with a test for 'Is Nothing'. If the member does not return a valid object, attempting to use the return value will result in a run-time error 91 - \"Object variable or With block variable not set\".</value>","path":"Rubberduck.Resources/Inspections/InspectionInfo.resx","position":5,"original_position":5,"commit_id":"8094b70355dedcbcefae905323a87a2df33d4094","original_commit_id":"8094b70355dedcbcefae905323a87a2df33d4094","user":{"login":"comintern","id":8944005,"node_id":"MDQ6VXNlcjg5NDQwMDU=","avatar_url":"https://avatars2.githubusercontent.com/u/8944005?v=4","gravatar_id":"","url":"https://api.github.com/users/comintern","html_url":"https://github.com/comintern","followers_url":"https://api.github.com/users/comintern/followers","following_url":"https://api.github.com/users/comintern/following{/other_user}","gists_url":"https://api.github.com/users/comintern/gists{/gist_id}","starred_url":"https://api.github.com/users/comintern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/comintern/subscriptions","organizations_url":"https://api.github.com/users/comintern/orgs","repos_url":"https://api.github.com/users/comintern/repos","events_url":"https://api.github.com/users/comintern/events{/privacy}","received_events_url":"https://api.github.com/users/comintern/received_events","type":"User","site_admin":false},"body":"That should be \"without\", although I'm not sure how happy I am with this in general - it seems overly wordy.","created_at":"2018-11-02T12:13:15Z","updated_at":"2018-11-02T12:13:15Z","html_url":"https://github.com/rubberduck-vba/Rubberduck/pull/4483#discussion_r230353676","pull_request_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/4483","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/comments/230353676"},"html":{"href":"https://github.com/rubberduck-vba/Rubberduck/pull/4483#discussion_r230353676"},"pull_request":{"href":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/4483"}},"in_reply_to_id":230349637},"pull_request":{"url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/4483","id":227825219,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3ODI1MjE5","html_url":"https://github.com/rubberduck-vba/Rubberduck/pull/4483","diff_url":"https://github.com/rubberduck-vba/Rubberduck/pull/4483.diff","patch_url":"https://github.com/rubberduck-vba/Rubberduck/pull/4483.patch","issue_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/issues/4483","number":4483,"state":"open","locked":false,"title":"Add Inspection for members that can return Nothing. Ref #4440","user":{"login":"comintern","id":8944005,"node_id":"MDQ6VXNlcjg5NDQwMDU=","avatar_url":"https://avatars2.githubusercontent.com/u/8944005?v=4","gravatar_id":"","url":"https://api.github.com/users/comintern","html_url":"https://github.com/comintern","followers_url":"https://api.github.com/users/comintern/followers","following_url":"https://api.github.com/users/comintern/following{/other_user}","gists_url":"https://api.github.com/users/comintern/gists{/gist_id}","starred_url":"https://api.github.com/users/comintern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/comintern/subscriptions","organizations_url":"https://api.github.com/users/comintern/orgs","repos_url":"https://api.github.com/users/comintern/repos","events_url":"https://api.github.com/users/comintern/events{/privacy}","received_events_url":"https://api.github.com/users/comintern/received_events","type":"User","site_admin":false},"body":"This also unscrews the csproj that was preventing the resx files from generating the designers.\r\n\r\nNote that the members being inspected are not intended to be an exhaustive list at this point.\r\n","created_at":"2018-11-02T04:00:45Z","updated_at":"2018-11-02T12:13:15Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a1cc9c4bc17461b393c7edf30766712a6989c4b7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/4483/commits","review_comments_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/4483/comments","review_comment_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/issues/4483/comments","statuses_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/statuses/8094b70355dedcbcefae905323a87a2df33d4094","head":{"label":"comintern:inspections","ref":"inspections","sha":"8094b70355dedcbcefae905323a87a2df33d4094","user":{"login":"comintern","id":8944005,"node_id":"MDQ6VXNlcjg5NDQwMDU=","avatar_url":"https://avatars2.githubusercontent.com/u/8944005?v=4","gravatar_id":"","url":"https://api.github.com/users/comintern","html_url":"https://github.com/comintern","followers_url":"https://api.github.com/users/comintern/followers","following_url":"https://api.github.com/users/comintern/following{/other_user}","gists_url":"https://api.github.com/users/comintern/gists{/gist_id}","starred_url":"https://api.github.com/users/comintern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/comintern/subscriptions","organizations_url":"https://api.github.com/users/comintern/orgs","repos_url":"https://api.github.com/users/comintern/repos","events_url":"https://api.github.com/users/comintern/events{/privacy}","received_events_url":"https://api.github.com/users/comintern/received_events","type":"User","site_admin":false},"repo":{"id":55346398,"node_id":"MDEwOlJlcG9zaXRvcnk1NTM0NjM5OA==","name":"Rubberduck","full_name":"comintern/Rubberduck","private":false,"owner":{"login":"comintern","id":8944005,"node_id":"MDQ6VXNlcjg5NDQwMDU=","avatar_url":"https://avatars2.githubusercontent.com/u/8944005?v=4","gravatar_id":"","url":"https://api.github.com/users/comintern","html_url":"https://github.com/comintern","followers_url":"https://api.github.com/users/comintern/followers","following_url":"https://api.github.com/users/comintern/following{/other_user}","gists_url":"https://api.github.com/users/comintern/gists{/gist_id}","starred_url":"https://api.github.com/users/comintern/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/comintern/subscriptions","organizations_url":"https://api.github.com/users/comintern/orgs","repos_url":"https://api.github.com/users/comintern/repos","events_url":"https://api.github.com/users/comintern/events{/privacy}","received_events_url":"https://api.github.com/users/comintern/received_events","type":"User","site_admin":false},"html_url":"https://github.com/comintern/Rubberduck","description":"Every programmer needs a rubberduck. COM add-in for the VBA IDE (VBE).","fork":true,"url":"https://api.github.com/repos/comintern/Rubberduck","forks_url":"https://api.github.com/repos/comintern/Rubberduck/forks","keys_url":"https://api.github.com/repos/comintern/Rubberduck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/comintern/Rubberduck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/comintern/Rubberduck/teams","hooks_url":"https://api.github.com/repos/comintern/Rubberduck/hooks","issue_events_url":"https://api.github.com/repos/comintern/Rubberduck/issues/events{/number}","events_url":"https://api.github.com/repos/comintern/Rubberduck/events","assignees_url":"https://api.github.com/repos/comintern/Rubberduck/assignees{/user}","branches_url":"https://api.github.com/repos/comintern/Rubberduck/branches{/branch}","tags_url":"https://api.github.com/repos/comintern/Rubberduck/tags","blobs_url":"https://api.github.com/repos/comintern/Rubberduck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/comintern/Rubberduck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/comintern/Rubberduck/git/refs{/sha}","trees_url":"https://api.github.com/repos/comintern/Rubberduck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/comintern/Rubberduck/statuses/{sha}","languages_url":"https://api.github.com/repos/comintern/Rubberduck/languages","stargazers_url":"https://api.github.com/repos/comintern/Rubberduck/stargazers","contributors_url":"https://api.github.com/repos/comintern/Rubberduck/contributors","subscribers_url":"https://api.github.com/repos/comintern/Rubberduck/subscribers","subscription_url":"https://api.github.com/repos/comintern/Rubberduck/subscription","commits_url":"https://api.github.com/repos/comintern/Rubberduck/commits{/sha}","git_commits_url":"https://api.github.com/repos/comintern/Rubberduck/git/commits{/sha}","comments_url":"https://api.github.com/repos/comintern/Rubberduck/comments{/number}","issue_comment_url":"https://api.github.com/repos/comintern/Rubberduck/issues/comments{/number}","contents_url":"https://api.github.com/repos/comintern/Rubberduck/contents/{+path}","compare_url":"https://api.github.com/repos/comintern/Rubberduck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/comintern/Rubberduck/merges","archive_url":"https://api.github.com/repos/comintern/Rubberduck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/comintern/Rubberduck/downloads","issues_url":"https://api.github.com/repos/comintern/Rubberduck/issues{/number}","pulls_url":"https://api.github.com/repos/comintern/Rubberduck/pulls{/number}","milestones_url":"https://api.github.com/repos/comintern/Rubberduck/milestones{/number}","notifications_url":"https://api.github.com/repos/comintern/Rubberduck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/comintern/Rubberduck/labels{/name}","releases_url":"https://api.github.com/repos/comintern/Rubberduck/releases{/id}","deployments_url":"https://api.github.com/repos/comintern/Rubberduck/deployments","created_at":"2016-04-03T12:57:26Z","updated_at":"2018-10-29T22:21:26Z","pushed_at":"2018-11-02T03:58:35Z","git_url":"git://github.com/comintern/Rubberduck.git","ssh_url":"git@github.com:comintern/Rubberduck.git","clone_url":"https://github.com/comintern/Rubberduck.git","svn_url":"https://github.com/comintern/Rubberduck","homepage":"","size":75833,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"next"}},"base":{"label":"rubberduck-vba:next","ref":"next","sha":"0aaf7c1d7aa08a671de9b708958e1099cc2d954e","user":{"login":"rubberduck-vba","id":12832254,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODMyMjU0","avatar_url":"https://avatars0.githubusercontent.com/u/12832254?v=4","gravatar_id":"","url":"https://api.github.com/users/rubberduck-vba","html_url":"https://github.com/rubberduck-vba","followers_url":"https://api.github.com/users/rubberduck-vba/followers","following_url":"https://api.github.com/users/rubberduck-vba/following{/other_user}","gists_url":"https://api.github.com/users/rubberduck-vba/gists{/gist_id}","starred_url":"https://api.github.com/users/rubberduck-vba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubberduck-vba/subscriptions","organizations_url":"https://api.github.com/users/rubberduck-vba/orgs","repos_url":"https://api.github.com/users/rubberduck-vba/repos","events_url":"https://api.github.com/users/rubberduck-vba/events{/privacy}","received_events_url":"https://api.github.com/users/rubberduck-vba/received_events","type":"Organization","site_admin":false},"repo":{"id":25800128,"node_id":"MDEwOlJlcG9zaXRvcnkyNTgwMDEyOA==","name":"Rubberduck","full_name":"rubberduck-vba/Rubberduck","private":false,"owner":{"login":"rubberduck-vba","id":12832254,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyODMyMjU0","avatar_url":"https://avatars0.githubusercontent.com/u/12832254?v=4","gravatar_id":"","url":"https://api.github.com/users/rubberduck-vba","html_url":"https://github.com/rubberduck-vba","followers_url":"https://api.github.com/users/rubberduck-vba/followers","following_url":"https://api.github.com/users/rubberduck-vba/following{/other_user}","gists_url":"https://api.github.com/users/rubberduck-vba/gists{/gist_id}","starred_url":"https://api.github.com/users/rubberduck-vba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rubberduck-vba/subscriptions","organizations_url":"https://api.github.com/users/rubberduck-vba/orgs","repos_url":"https://api.github.com/users/rubberduck-vba/repos","events_url":"https://api.github.com/users/rubberduck-vba/events{/privacy}","received_events_url":"https://api.github.com/users/rubberduck-vba/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rubberduck-vba/Rubberduck","description":"Every programmer needs a rubberduck. COM add-in for the VBA IDE (VBE).","fork":false,"url":"https://api.github.com/repos/rubberduck-vba/Rubberduck","forks_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/forks","keys_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/teams","hooks_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/hooks","issue_events_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/issues/events{/number}","events_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/events","assignees_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/assignees{/user}","branches_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/branches{/branch}","tags_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/tags","blobs_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/git/refs{/sha}","trees_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/statuses/{sha}","languages_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/languages","stargazers_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/stargazers","contributors_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/contributors","subscribers_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/subscribers","subscription_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/subscription","commits_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/commits{/sha}","git_commits_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/git/commits{/sha}","comments_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/comments{/number}","issue_comment_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/issues/comments{/number}","contents_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/contents/{+path}","compare_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/merges","archive_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/downloads","issues_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/issues{/number}","pulls_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls{/number}","milestones_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/milestones{/number}","notifications_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/labels{/name}","releases_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/releases{/id}","deployments_url":"https://api.github.com/repos/rubberduck-vba/Rubberduck/deployments","created_at":"2014-10-27T02:35:11Z","updated_at":"2018-11-02T12:13:05Z","pushed_at":"2018-11-02T11:48:02Z","git_url":"git://github.com/rubberduck-vba/Rubberduck.git","ssh_url":"git@github.com:rubberduck-vba/Rubberduck.git","clone_url":"https://github.com/rubberduck-vba/Rubberduck.git","svn_url":"https://github.com/rubberduck-vba/Rubberduck","homepage":"","size":75476,"stargazers_count":680,"watchers_count":680,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":173,"mirror_url":null,"archived":false,"open_issues_count":729,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":173,"open_issues":729,"watchers":680,"default_branch":"next"}},"_links":{"self":{"href":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/4483"},"html":{"href":"https://github.com/rubberduck-vba/Rubberduck/pull/4483"},"issue":{"href":"https://api.github.com/repos/rubberduck-vba/Rubberduck/issues/4483"},"comments":{"href":"https://api.github.com/repos/rubberduck-vba/Rubberduck/issues/4483/comments"},"review_comments":{"href":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/4483/comments"},"review_comment":{"href":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rubberduck-vba/Rubberduck/pulls/4483/commits"},"statuses":{"href":"https://api.github.com/repos/rubberduck-vba/Rubberduck/statuses/8094b70355dedcbcefae905323a87a2df33d4094"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"comintern"}}