{"action":"created","issue":{"url":"https://api.github.com/repos/iiroj/styled-modal/issues/6","repository_url":"https://api.github.com/repos/iiroj/styled-modal","labels_url":"https://api.github.com/repos/iiroj/styled-modal/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/iiroj/styled-modal/issues/6/comments","events_url":"https://api.github.com/repos/iiroj/styled-modal/issues/6/events","html_url":"https://github.com/iiroj/styled-modal/pull/6","id":304248842,"number":6,"title":"Accessbility improvements","user":{"login":"iiroj","id":11628889,"avatar_url":"https://avatars0.githubusercontent.com/u/11628889?v=4","gravatar_id":"","url":"https://api.github.com/users/iiroj","html_url":"https://github.com/iiroj","followers_url":"https://api.github.com/users/iiroj/followers","following_url":"https://api.github.com/users/iiroj/following{/other_user}","gists_url":"https://api.github.com/users/iiroj/gists{/gist_id}","starred_url":"https://api.github.com/users/iiroj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iiroj/subscriptions","organizations_url":"https://api.github.com/users/iiroj/orgs","repos_url":"https://api.github.com/users/iiroj/repos","events_url":"https://api.github.com/users/iiroj/events{/privacy}","received_events_url":"https://api.github.com/users/iiroj/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-12T05:53:10Z","updated_at":"2018-03-12T05:53:22Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/iiroj/styled-modal/pulls/6","html_url":"https://github.com/iiroj/styled-modal/pull/6","diff_url":"https://github.com/iiroj/styled-modal/pull/6.diff","patch_url":"https://github.com/iiroj/styled-modal/pull/6.patch"},"body":"This PR continues on PR https://github.com/iiroj/styled-modal/pull/4 by adding improvements to accessibility of `<Modal />`:\r\n\r\n* Allow hiding of the React app with `aria-hidden=\"true\"` when Modal is open by supplying an `appId` prop.\r\n* Pass all other props to the modal container component, allowing one to set `aria-labelledby` and `aria-describedby`, for example\r\n\r\nIt also fixes some incorrect behaviour:\r\n* Side effects for opening the Modal were not run when the Modal mounted as open.\r\n\r\nLastly, there's an improvement on styling:\r\n* The components for backdrop and modal container are now evaluated in the `render` function and can thus change their styles on-the-fly."},"comment":{"url":"https://api.github.com/repos/iiroj/styled-modal/issues/comments/372200739","html_url":"https://github.com/iiroj/styled-modal/pull/6#issuecomment-372200739","issue_url":"https://api.github.com/repos/iiroj/styled-modal/issues/6","id":372200739,"user":{"login":"iiroj","id":11628889,"avatar_url":"https://avatars0.githubusercontent.com/u/11628889?v=4","gravatar_id":"","url":"https://api.github.com/users/iiroj","html_url":"https://github.com/iiroj","followers_url":"https://api.github.com/users/iiroj/followers","following_url":"https://api.github.com/users/iiroj/following{/other_user}","gists_url":"https://api.github.com/users/iiroj/gists{/gist_id}","starred_url":"https://api.github.com/users/iiroj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iiroj/subscriptions","organizations_url":"https://api.github.com/users/iiroj/orgs","repos_url":"https://api.github.com/users/iiroj/repos","events_url":"https://api.github.com/users/iiroj/events{/privacy}","received_events_url":"https://api.github.com/users/iiroj/received_events","type":"User","site_admin":false},"created_at":"2018-03-12T05:53:22Z","updated_at":"2018-03-12T05:53:22Z","author_association":"OWNER","body":"This PR closes issue https://github.com/iiroj/styled-modal/issues/2."}}
{"actor":{"display_login":"iiroj"}}