{"action":"created","comment":{"url":"https://api.github.com/repos/kochman/hotshots/pulls/comments/184216713","pull_request_review_id":115367804,"id":184216713,"diff_hunk":"@@ -43,6 +45,11 @@ func (r *remoteAPI) existingPhotos() ([]string, error) {\n \t\t\treturn []string{}, err\n \t\t}\n \n+\t\tif len(r.username) > 0 || len(r.password) > 0 {\n+\t\t\t// HTTP basic auth\n+\t\t\treq.SetBasicAuth(r.username, r.password)","path":"pusher/photoservice.go","position":17,"original_position":17,"commit_id":"59126a6df3b42232bb10a9d50b412996afa38880","original_commit_id":"59126a6df3b42232bb10a9d50b412996afa38880","user":{"login":"warrn","id":5667236,"avatar_url":"https://avatars2.githubusercontent.com/u/5667236?v=4","gravatar_id":"","url":"https://api.github.com/users/warrn","html_url":"https://github.com/warrn","followers_url":"https://api.github.com/users/warrn/followers","following_url":"https://api.github.com/users/warrn/following{/other_user}","gists_url":"https://api.github.com/users/warrn/gists{/gist_id}","starred_url":"https://api.github.com/users/warrn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/warrn/subscriptions","organizations_url":"https://api.github.com/users/warrn/orgs","repos_url":"https://api.github.com/users/warrn/repos","events_url":"https://api.github.com/users/warrn/events{/privacy}","received_events_url":"https://api.github.com/users/warrn/received_events","type":"User","site_admin":false},"body":"Digest utilizes MD5 which is not secure. Most authentication libraries wrap basic-auth by hashing the password clientside","created_at":"2018-04-25T21:51:05Z","updated_at":"2018-04-25T21:51:05Z","html_url":"https://github.com/kochman/hotshots/pull/38#discussion_r184216713","pull_request_url":"https://api.github.com/repos/kochman/hotshots/pulls/38","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/kochman/hotshots/pulls/comments/184216713"},"html":{"href":"https://github.com/kochman/hotshots/pull/38#discussion_r184216713"},"pull_request":{"href":"https://api.github.com/repos/kochman/hotshots/pulls/38"}},"in_reply_to_id":184214525},"pull_request":{"url":"https://api.github.com/repos/kochman/hotshots/pulls/38","id":183920567,"html_url":"https://github.com/kochman/hotshots/pull/38","diff_url":"https://github.com/kochman/hotshots/pull/38.diff","patch_url":"https://github.com/kochman/hotshots/pull/38.patch","issue_url":"https://api.github.com/repos/kochman/hotshots/issues/38","number":38,"state":"open","locked":false,"title":"HTTP basic authentication","user":{"login":"kochman","id":335234,"avatar_url":"https://avatars2.githubusercontent.com/u/335234?v=4","gravatar_id":"","url":"https://api.github.com/users/kochman","html_url":"https://github.com/kochman","followers_url":"https://api.github.com/users/kochman/followers","following_url":"https://api.github.com/users/kochman/following{/other_user}","gists_url":"https://api.github.com/users/kochman/gists{/gist_id}","starred_url":"https://api.github.com/users/kochman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kochman/subscriptions","organizations_url":"https://api.github.com/users/kochman/orgs","repos_url":"https://api.github.com/users/kochman/repos","events_url":"https://api.github.com/users/kochman/events{/privacy}","received_events_url":"https://api.github.com/users/kochman/received_events","type":"User","site_admin":false},"body":"There are two new environment variables: `HOTSHOTS_USERNAME` and `HOTSHOTS_PASSWORD`.\r\n\r\nIf they are set, the server will expect all requests to have matching HTTP basic authentication headers. The pusher will use them to add HTTP basic authentication to its requests.\r\n\r\nIf they are not set, no authentication is expected by the server or sent by the pusher.","created_at":"2018-04-25T04:09:02Z","updated_at":"2018-04-25T21:51:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f875349455a8b5cb442581aa8eecc8fed65a4532","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kochman/hotshots/pulls/38/commits","review_comments_url":"https://api.github.com/repos/kochman/hotshots/pulls/38/comments","review_comment_url":"https://api.github.com/repos/kochman/hotshots/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kochman/hotshots/issues/38/comments","statuses_url":"https://api.github.com/repos/kochman/hotshots/statuses/59126a6df3b42232bb10a9d50b412996afa38880","head":{"label":"kochman:http-auth","ref":"http-auth","sha":"59126a6df3b42232bb10a9d50b412996afa38880","user":{"login":"kochman","id":335234,"avatar_url":"https://avatars2.githubusercontent.com/u/335234?v=4","gravatar_id":"","url":"https://api.github.com/users/kochman","html_url":"https://github.com/kochman","followers_url":"https://api.github.com/users/kochman/followers","following_url":"https://api.github.com/users/kochman/following{/other_user}","gists_url":"https://api.github.com/users/kochman/gists{/gist_id}","starred_url":"https://api.github.com/users/kochman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kochman/subscriptions","organizations_url":"https://api.github.com/users/kochman/orgs","repos_url":"https://api.github.com/users/kochman/repos","events_url":"https://api.github.com/users/kochman/events{/privacy}","received_events_url":"https://api.github.com/users/kochman/received_events","type":"User","site_admin":false},"repo":{"id":119487211,"name":"hotshots","full_name":"kochman/hotshots","owner":{"login":"kochman","id":335234,"avatar_url":"https://avatars2.githubusercontent.com/u/335234?v=4","gravatar_id":"","url":"https://api.github.com/users/kochman","html_url":"https://github.com/kochman","followers_url":"https://api.github.com/users/kochman/followers","following_url":"https://api.github.com/users/kochman/following{/other_user}","gists_url":"https://api.github.com/users/kochman/gists{/gist_id}","starred_url":"https://api.github.com/users/kochman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kochman/subscriptions","organizations_url":"https://api.github.com/users/kochman/orgs","repos_url":"https://api.github.com/users/kochman/repos","events_url":"https://api.github.com/users/kochman/events{/privacy}","received_events_url":"https://api.github.com/users/kochman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kochman/hotshots","description":"Curate photos from remote cameras","fork":false,"url":"https://api.github.com/repos/kochman/hotshots","forks_url":"https://api.github.com/repos/kochman/hotshots/forks","keys_url":"https://api.github.com/repos/kochman/hotshots/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kochman/hotshots/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kochman/hotshots/teams","hooks_url":"https://api.github.com/repos/kochman/hotshots/hooks","issue_events_url":"https://api.github.com/repos/kochman/hotshots/issues/events{/number}","events_url":"https://api.github.com/repos/kochman/hotshots/events","assignees_url":"https://api.github.com/repos/kochman/hotshots/assignees{/user}","branches_url":"https://api.github.com/repos/kochman/hotshots/branches{/branch}","tags_url":"https://api.github.com/repos/kochman/hotshots/tags","blobs_url":"https://api.github.com/repos/kochman/hotshots/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kochman/hotshots/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kochman/hotshots/git/refs{/sha}","trees_url":"https://api.github.com/repos/kochman/hotshots/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kochman/hotshots/statuses/{sha}","languages_url":"https://api.github.com/repos/kochman/hotshots/languages","stargazers_url":"https://api.github.com/repos/kochman/hotshots/stargazers","contributors_url":"https://api.github.com/repos/kochman/hotshots/contributors","subscribers_url":"https://api.github.com/repos/kochman/hotshots/subscribers","subscription_url":"https://api.github.com/repos/kochman/hotshots/subscription","commits_url":"https://api.github.com/repos/kochman/hotshots/commits{/sha}","git_commits_url":"https://api.github.com/repos/kochman/hotshots/git/commits{/sha}","comments_url":"https://api.github.com/repos/kochman/hotshots/comments{/number}","issue_comment_url":"https://api.github.com/repos/kochman/hotshots/issues/comments{/number}","contents_url":"https://api.github.com/repos/kochman/hotshots/contents/{+path}","compare_url":"https://api.github.com/repos/kochman/hotshots/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kochman/hotshots/merges","archive_url":"https://api.github.com/repos/kochman/hotshots/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kochman/hotshots/downloads","issues_url":"https://api.github.com/repos/kochman/hotshots/issues{/number}","pulls_url":"https://api.github.com/repos/kochman/hotshots/pulls{/number}","milestones_url":"https://api.github.com/repos/kochman/hotshots/milestones{/number}","notifications_url":"https://api.github.com/repos/kochman/hotshots/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kochman/hotshots/labels{/name}","releases_url":"https://api.github.com/repos/kochman/hotshots/releases{/id}","deployments_url":"https://api.github.com/repos/kochman/hotshots/deployments","created_at":"2018-01-30T05:29:51Z","updated_at":"2018-04-25T21:40:11Z","pushed_at":"2018-04-25T21:40:13Z","git_url":"git://github.com/kochman/hotshots.git","ssh_url":"git@github.com:kochman/hotshots.git","clone_url":"https://github.com/kochman/hotshots.git","svn_url":"https://github.com/kochman/hotshots","homepage":null,"size":4749,"stargazers_count":4,"watchers_count":4,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":11,"watchers":4,"default_branch":"master"}},"base":{"label":"kochman:master","ref":"master","sha":"eaa420dd9783235274e65ca9172d84947d6eb95d","user":{"login":"kochman","id":335234,"avatar_url":"https://avatars2.githubusercontent.com/u/335234?v=4","gravatar_id":"","url":"https://api.github.com/users/kochman","html_url":"https://github.com/kochman","followers_url":"https://api.github.com/users/kochman/followers","following_url":"https://api.github.com/users/kochman/following{/other_user}","gists_url":"https://api.github.com/users/kochman/gists{/gist_id}","starred_url":"https://api.github.com/users/kochman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kochman/subscriptions","organizations_url":"https://api.github.com/users/kochman/orgs","repos_url":"https://api.github.com/users/kochman/repos","events_url":"https://api.github.com/users/kochman/events{/privacy}","received_events_url":"https://api.github.com/users/kochman/received_events","type":"User","site_admin":false},"repo":{"id":119487211,"name":"hotshots","full_name":"kochman/hotshots","owner":{"login":"kochman","id":335234,"avatar_url":"https://avatars2.githubusercontent.com/u/335234?v=4","gravatar_id":"","url":"https://api.github.com/users/kochman","html_url":"https://github.com/kochman","followers_url":"https://api.github.com/users/kochman/followers","following_url":"https://api.github.com/users/kochman/following{/other_user}","gists_url":"https://api.github.com/users/kochman/gists{/gist_id}","starred_url":"https://api.github.com/users/kochman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kochman/subscriptions","organizations_url":"https://api.github.com/users/kochman/orgs","repos_url":"https://api.github.com/users/kochman/repos","events_url":"https://api.github.com/users/kochman/events{/privacy}","received_events_url":"https://api.github.com/users/kochman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kochman/hotshots","description":"Curate photos from remote cameras","fork":false,"url":"https://api.github.com/repos/kochman/hotshots","forks_url":"https://api.github.com/repos/kochman/hotshots/forks","keys_url":"https://api.github.com/repos/kochman/hotshots/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kochman/hotshots/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kochman/hotshots/teams","hooks_url":"https://api.github.com/repos/kochman/hotshots/hooks","issue_events_url":"https://api.github.com/repos/kochman/hotshots/issues/events{/number}","events_url":"https://api.github.com/repos/kochman/hotshots/events","assignees_url":"https://api.github.com/repos/kochman/hotshots/assignees{/user}","branches_url":"https://api.github.com/repos/kochman/hotshots/branches{/branch}","tags_url":"https://api.github.com/repos/kochman/hotshots/tags","blobs_url":"https://api.github.com/repos/kochman/hotshots/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kochman/hotshots/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kochman/hotshots/git/refs{/sha}","trees_url":"https://api.github.com/repos/kochman/hotshots/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kochman/hotshots/statuses/{sha}","languages_url":"https://api.github.com/repos/kochman/hotshots/languages","stargazers_url":"https://api.github.com/repos/kochman/hotshots/stargazers","contributors_url":"https://api.github.com/repos/kochman/hotshots/contributors","subscribers_url":"https://api.github.com/repos/kochman/hotshots/subscribers","subscription_url":"https://api.github.com/repos/kochman/hotshots/subscription","commits_url":"https://api.github.com/repos/kochman/hotshots/commits{/sha}","git_commits_url":"https://api.github.com/repos/kochman/hotshots/git/commits{/sha}","comments_url":"https://api.github.com/repos/kochman/hotshots/comments{/number}","issue_comment_url":"https://api.github.com/repos/kochman/hotshots/issues/comments{/number}","contents_url":"https://api.github.com/repos/kochman/hotshots/contents/{+path}","compare_url":"https://api.github.com/repos/kochman/hotshots/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kochman/hotshots/merges","archive_url":"https://api.github.com/repos/kochman/hotshots/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kochman/hotshots/downloads","issues_url":"https://api.github.com/repos/kochman/hotshots/issues{/number}","pulls_url":"https://api.github.com/repos/kochman/hotshots/pulls{/number}","milestones_url":"https://api.github.com/repos/kochman/hotshots/milestones{/number}","notifications_url":"https://api.github.com/repos/kochman/hotshots/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kochman/hotshots/labels{/name}","releases_url":"https://api.github.com/repos/kochman/hotshots/releases{/id}","deployments_url":"https://api.github.com/repos/kochman/hotshots/deployments","created_at":"2018-01-30T05:29:51Z","updated_at":"2018-04-25T21:40:11Z","pushed_at":"2018-04-25T21:40:13Z","git_url":"git://github.com/kochman/hotshots.git","ssh_url":"git@github.com:kochman/hotshots.git","clone_url":"https://github.com/kochman/hotshots.git","svn_url":"https://github.com/kochman/hotshots","homepage":null,"size":4749,"stargazers_count":4,"watchers_count":4,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":11,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kochman/hotshots/pulls/38"},"html":{"href":"https://github.com/kochman/hotshots/pull/38"},"issue":{"href":"https://api.github.com/repos/kochman/hotshots/issues/38"},"comments":{"href":"https://api.github.com/repos/kochman/hotshots/issues/38/comments"},"review_comments":{"href":"https://api.github.com/repos/kochman/hotshots/pulls/38/comments"},"review_comment":{"href":"https://api.github.com/repos/kochman/hotshots/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kochman/hotshots/pulls/38/commits"},"statuses":{"href":"https://api.github.com/repos/kochman/hotshots/statuses/59126a6df3b42232bb10a9d50b412996afa38880"}},"author_association":"OWNER"}}
{"actor":{"display_login":"warrn"}}