{"action":"created","comment":{"url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/pulls/comments/199325489","pull_request_review_id":133429208,"id":199325489,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTMyNTQ4OQ==","diff_hunk":"@@ -36,31 +40,52 @@ function* recalculateAllQuests() {\n     const activeQuests: Quest[] = yield select(getActiveQuests);\n \n     for (let q of activeQuests) {\n-        let allTaskComplete = false;\n-        let totalProgress = 0;\n-        for (let t of q.tasks) {\n-            const progress: number = yield call(getTaskProgress, t);\n-            t.progress = progress;\n-            totalProgress += progress;\n-            if (progress === 100) {\n-                t.isCompleted = true;\n-            } else {\n-                allTaskComplete = false;\n+        if (q.isUnlocked && !q.isCompleted) {\n+            let allTaskComplete = false;\n+            let totalProgress = 0;\n+            for (let t of q.tasks) {\n+                const progress: number = yield call(getTaskProgress, t);\n+                t.progress = progress;\n+                totalProgress += progress;\n+                if (progress === 100) {\n+                    t.isCompleted = true;\n+                } else {\n+                    allTaskComplete = false;","path":"src/state/quests/questSaga.ts","position":56,"original_position":56,"commit_id":"154132a2b380726ee92a31ae03019a4269166171","original_commit_id":"154132a2b380726ee92a31ae03019a4269166171","user":{"login":"maracuja-juice","id":16801528,"node_id":"MDQ6VXNlcjE2ODAxNTI4","avatar_url":"https://avatars3.githubusercontent.com/u/16801528?v=4","gravatar_id":"","url":"https://api.github.com/users/maracuja-juice","html_url":"https://github.com/maracuja-juice","followers_url":"https://api.github.com/users/maracuja-juice/followers","following_url":"https://api.github.com/users/maracuja-juice/following{/other_user}","gists_url":"https://api.github.com/users/maracuja-juice/gists{/gist_id}","starred_url":"https://api.github.com/users/maracuja-juice/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maracuja-juice/subscriptions","organizations_url":"https://api.github.com/users/maracuja-juice/orgs","repos_url":"https://api.github.com/users/maracuja-juice/repos","events_url":"https://api.github.com/users/maracuja-juice/events{/privacy}","received_events_url":"https://api.github.com/users/maracuja-juice/received_events","type":"User","site_admin":false},"body":"wieso setzt du das nochmals? Isch doch bei 44 schon gsetzt und wird dann nicht verändert","created_at":"2018-06-30T15:42:04Z","updated_at":"2018-06-30T15:42:04Z","html_url":"https://github.com/stockmarkat/stockmarket-simulation/pull/65#discussion_r199325489","pull_request_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/pulls/65","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/pulls/comments/199325489"},"html":{"href":"https://github.com/stockmarkat/stockmarket-simulation/pull/65#discussion_r199325489"},"pull_request":{"href":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/pulls/65"}}},"pull_request":{"url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/pulls/65","id":198007485,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MDA3NDg1","html_url":"https://github.com/stockmarkat/stockmarket-simulation/pull/65","diff_url":"https://github.com/stockmarkat/stockmarket-simulation/pull/65.diff","patch_url":"https://github.com/stockmarkat/stockmarket-simulation/pull/65.patch","issue_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/issues/65","number":65,"state":"open","locked":false,"title":"Quest State","user":{"login":"RohrerF","id":20257550,"node_id":"MDQ6VXNlcjIwMjU3NTUw","avatar_url":"https://avatars0.githubusercontent.com/u/20257550?v=4","gravatar_id":"","url":"https://api.github.com/users/RohrerF","html_url":"https://github.com/RohrerF","followers_url":"https://api.github.com/users/RohrerF/followers","following_url":"https://api.github.com/users/RohrerF/following{/other_user}","gists_url":"https://api.github.com/users/RohrerF/gists{/gist_id}","starred_url":"https://api.github.com/users/RohrerF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RohrerF/subscriptions","organizations_url":"https://api.github.com/users/RohrerF/orgs","repos_url":"https://api.github.com/users/RohrerF/repos","events_url":"https://api.github.com/users/RohrerF/events{/privacy}","received_events_url":"https://api.github.com/users/RohrerF/received_events","type":"User","site_admin":false},"body":"Fixes #63 ","created_at":"2018-06-28T12:03:50Z","updated_at":"2018-06-30T15:42:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ef854fb07d80894fbf2f55dcb29b8ba589c8b840","assignee":{"login":"RohrerF","id":20257550,"node_id":"MDQ6VXNlcjIwMjU3NTUw","avatar_url":"https://avatars0.githubusercontent.com/u/20257550?v=4","gravatar_id":"","url":"https://api.github.com/users/RohrerF","html_url":"https://github.com/RohrerF","followers_url":"https://api.github.com/users/RohrerF/followers","following_url":"https://api.github.com/users/RohrerF/following{/other_user}","gists_url":"https://api.github.com/users/RohrerF/gists{/gist_id}","starred_url":"https://api.github.com/users/RohrerF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RohrerF/subscriptions","organizations_url":"https://api.github.com/users/RohrerF/orgs","repos_url":"https://api.github.com/users/RohrerF/repos","events_url":"https://api.github.com/users/RohrerF/events{/privacy}","received_events_url":"https://api.github.com/users/RohrerF/received_events","type":"User","site_admin":false},"assignees":[{"login":"RohrerF","id":20257550,"node_id":"MDQ6VXNlcjIwMjU3NTUw","avatar_url":"https://avatars0.githubusercontent.com/u/20257550?v=4","gravatar_id":"","url":"https://api.github.com/users/RohrerF","html_url":"https://github.com/RohrerF","followers_url":"https://api.github.com/users/RohrerF/followers","following_url":"https://api.github.com/users/RohrerF/following{/other_user}","gists_url":"https://api.github.com/users/RohrerF/gists{/gist_id}","starred_url":"https://api.github.com/users/RohrerF/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RohrerF/subscriptions","organizations_url":"https://api.github.com/users/RohrerF/orgs","repos_url":"https://api.github.com/users/RohrerF/repos","events_url":"https://api.github.com/users/RohrerF/events{/privacy}","received_events_url":"https://api.github.com/users/RohrerF/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/pulls/65/commits","review_comments_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/pulls/65/comments","review_comment_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/issues/65/comments","statuses_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/statuses/154132a2b380726ee92a31ae03019a4269166171","head":{"label":"stockmarkat:questState","ref":"questState","sha":"154132a2b380726ee92a31ae03019a4269166171","user":{"login":"stockmarkat","id":36041271,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDQxMjcx","avatar_url":"https://avatars0.githubusercontent.com/u/36041271?v=4","gravatar_id":"","url":"https://api.github.com/users/stockmarkat","html_url":"https://github.com/stockmarkat","followers_url":"https://api.github.com/users/stockmarkat/followers","following_url":"https://api.github.com/users/stockmarkat/following{/other_user}","gists_url":"https://api.github.com/users/stockmarkat/gists{/gist_id}","starred_url":"https://api.github.com/users/stockmarkat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stockmarkat/subscriptions","organizations_url":"https://api.github.com/users/stockmarkat/orgs","repos_url":"https://api.github.com/users/stockmarkat/repos","events_url":"https://api.github.com/users/stockmarkat/events{/privacy}","received_events_url":"https://api.github.com/users/stockmarkat/received_events","type":"Organization","site_admin":false},"repo":{"id":123436541,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM0MzY1NDE=","name":"stockmarket-simulation","full_name":"stockmarkat/stockmarket-simulation","owner":{"login":"stockmarkat","id":36041271,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDQxMjcx","avatar_url":"https://avatars0.githubusercontent.com/u/36041271?v=4","gravatar_id":"","url":"https://api.github.com/users/stockmarkat","html_url":"https://github.com/stockmarkat","followers_url":"https://api.github.com/users/stockmarkat/followers","following_url":"https://api.github.com/users/stockmarkat/following{/other_user}","gists_url":"https://api.github.com/users/stockmarkat/gists{/gist_id}","starred_url":"https://api.github.com/users/stockmarkat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stockmarkat/subscriptions","organizations_url":"https://api.github.com/users/stockmarkat/orgs","repos_url":"https://api.github.com/users/stockmarkat/repos","events_url":"https://api.github.com/users/stockmarkat/events{/privacy}","received_events_url":"https://api.github.com/users/stockmarkat/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stockmarkat/stockmarket-simulation","description":"A Stockmarket simulation 📈","fork":false,"url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation","forks_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/forks","keys_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/teams","hooks_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/hooks","issue_events_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/issues/events{/number}","events_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/events","assignees_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/assignees{/user}","branches_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/branches{/branch}","tags_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/tags","blobs_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/git/refs{/sha}","trees_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/statuses/{sha}","languages_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/languages","stargazers_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/stargazers","contributors_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/contributors","subscribers_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/subscribers","subscription_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/subscription","commits_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/commits{/sha}","git_commits_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/git/commits{/sha}","comments_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/comments{/number}","issue_comment_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/issues/comments{/number}","contents_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/contents/{+path}","compare_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/merges","archive_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/downloads","issues_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/issues{/number}","pulls_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/pulls{/number}","milestones_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/milestones{/number}","notifications_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/labels{/name}","releases_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/releases{/id}","deployments_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/deployments","created_at":"2018-03-01T13:10:46Z","updated_at":"2018-06-30T11:36:44Z","pushed_at":"2018-06-30T11:40:10Z","git_url":"git://github.com/stockmarkat/stockmarket-simulation.git","ssh_url":"git@github.com:stockmarkat/stockmarket-simulation.git","clone_url":"https://github.com/stockmarkat/stockmarket-simulation.git","svn_url":"https://github.com/stockmarkat/stockmarket-simulation","homepage":"https://stockmarkat.netlify.com","size":3511,"stargazers_count":2,"watchers_count":2,"language":"CSS","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":14,"watchers":2,"default_branch":"master"}},"base":{"label":"stockmarkat:master","ref":"master","sha":"7cc6061675ad4f66212ee3c6c7df12d89e98d6fe","user":{"login":"stockmarkat","id":36041271,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDQxMjcx","avatar_url":"https://avatars0.githubusercontent.com/u/36041271?v=4","gravatar_id":"","url":"https://api.github.com/users/stockmarkat","html_url":"https://github.com/stockmarkat","followers_url":"https://api.github.com/users/stockmarkat/followers","following_url":"https://api.github.com/users/stockmarkat/following{/other_user}","gists_url":"https://api.github.com/users/stockmarkat/gists{/gist_id}","starred_url":"https://api.github.com/users/stockmarkat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stockmarkat/subscriptions","organizations_url":"https://api.github.com/users/stockmarkat/orgs","repos_url":"https://api.github.com/users/stockmarkat/repos","events_url":"https://api.github.com/users/stockmarkat/events{/privacy}","received_events_url":"https://api.github.com/users/stockmarkat/received_events","type":"Organization","site_admin":false},"repo":{"id":123436541,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM0MzY1NDE=","name":"stockmarket-simulation","full_name":"stockmarkat/stockmarket-simulation","owner":{"login":"stockmarkat","id":36041271,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDQxMjcx","avatar_url":"https://avatars0.githubusercontent.com/u/36041271?v=4","gravatar_id":"","url":"https://api.github.com/users/stockmarkat","html_url":"https://github.com/stockmarkat","followers_url":"https://api.github.com/users/stockmarkat/followers","following_url":"https://api.github.com/users/stockmarkat/following{/other_user}","gists_url":"https://api.github.com/users/stockmarkat/gists{/gist_id}","starred_url":"https://api.github.com/users/stockmarkat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stockmarkat/subscriptions","organizations_url":"https://api.github.com/users/stockmarkat/orgs","repos_url":"https://api.github.com/users/stockmarkat/repos","events_url":"https://api.github.com/users/stockmarkat/events{/privacy}","received_events_url":"https://api.github.com/users/stockmarkat/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stockmarkat/stockmarket-simulation","description":"A Stockmarket simulation 📈","fork":false,"url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation","forks_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/forks","keys_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/teams","hooks_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/hooks","issue_events_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/issues/events{/number}","events_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/events","assignees_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/assignees{/user}","branches_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/branches{/branch}","tags_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/tags","blobs_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/git/refs{/sha}","trees_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/statuses/{sha}","languages_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/languages","stargazers_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/stargazers","contributors_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/contributors","subscribers_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/subscribers","subscription_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/subscription","commits_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/commits{/sha}","git_commits_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/git/commits{/sha}","comments_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/comments{/number}","issue_comment_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/issues/comments{/number}","contents_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/contents/{+path}","compare_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/merges","archive_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/downloads","issues_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/issues{/number}","pulls_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/pulls{/number}","milestones_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/milestones{/number}","notifications_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/labels{/name}","releases_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/releases{/id}","deployments_url":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/deployments","created_at":"2018-03-01T13:10:46Z","updated_at":"2018-06-30T11:36:44Z","pushed_at":"2018-06-30T11:40:10Z","git_url":"git://github.com/stockmarkat/stockmarket-simulation.git","ssh_url":"git@github.com:stockmarkat/stockmarket-simulation.git","clone_url":"https://github.com/stockmarkat/stockmarket-simulation.git","svn_url":"https://github.com/stockmarkat/stockmarket-simulation","homepage":"https://stockmarkat.netlify.com","size":3511,"stargazers_count":2,"watchers_count":2,"language":"CSS","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":14,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/pulls/65"},"html":{"href":"https://github.com/stockmarkat/stockmarket-simulation/pull/65"},"issue":{"href":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/issues/65"},"comments":{"href":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/issues/65/comments"},"review_comments":{"href":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/pulls/65/comments"},"review_comment":{"href":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/pulls/65/commits"},"statuses":{"href":"https://api.github.com/repos/stockmarkat/stockmarket-simulation/statuses/154132a2b380726ee92a31ae03019a4269166171"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"maracuja-juice"}}