{"action":"created","issue":{"url":"https://api.github.com/repos/DrylandEcology/rSFSW2/issues/254","repository_url":"https://api.github.com/repos/DrylandEcology/rSFSW2","labels_url":"https://api.github.com/repos/DrylandEcology/rSFSW2/issues/254/labels{/name}","comments_url":"https://api.github.com/repos/DrylandEcology/rSFSW2/issues/254/comments","events_url":"https://api.github.com/repos/DrylandEcology/rSFSW2/issues/254/events","html_url":"https://github.com/DrylandEcology/rSFSW2/issues/254","id":290096146,"number":254,"title":"Output water balance may not be closed","user":{"login":"dschlaep","id":4205019,"avatar_url":"https://avatars0.githubusercontent.com/u/4205019?v=4","gravatar_id":"","url":"https://api.github.com/users/dschlaep","html_url":"https://github.com/dschlaep","followers_url":"https://api.github.com/users/dschlaep/followers","following_url":"https://api.github.com/users/dschlaep/following{/other_user}","gists_url":"https://api.github.com/users/dschlaep/gists{/gist_id}","starred_url":"https://api.github.com/users/dschlaep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dschlaep/subscriptions","organizations_url":"https://api.github.com/users/dschlaep/orgs","repos_url":"https://api.github.com/users/dschlaep/repos","events_url":"https://api.github.com/users/dschlaep/events{/privacy}","received_events_url":"https://api.github.com/users/dschlaep/received_events","type":"User","site_admin":false},"labels":[{"id":36601911,"url":"https://api.github.com/repos/DrylandEcology/rSFSW2/labels/bug","name":"bug","color":"fc2929","default":true},{"id":640815860,"url":"https://api.github.com/repos/DrylandEcology/rSFSW2/labels/high%20priority","name":"high priority","color":"b60205","default":false},{"id":633203810,"url":"https://api.github.com/repos/DrylandEcology/rSFSW2/labels/in%20progress","name":"in progress","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":{"login":"dschlaep","id":4205019,"avatar_url":"https://avatars0.githubusercontent.com/u/4205019?v=4","gravatar_id":"","url":"https://api.github.com/users/dschlaep","html_url":"https://github.com/dschlaep","followers_url":"https://api.github.com/users/dschlaep/followers","following_url":"https://api.github.com/users/dschlaep/following{/other_user}","gists_url":"https://api.github.com/users/dschlaep/gists{/gist_id}","starred_url":"https://api.github.com/users/dschlaep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dschlaep/subscriptions","organizations_url":"https://api.github.com/users/dschlaep/orgs","repos_url":"https://api.github.com/users/dschlaep/repos","events_url":"https://api.github.com/users/dschlaep/events{/privacy}","received_events_url":"https://api.github.com/users/dschlaep/received_events","type":"User","site_admin":false},"assignees":[{"login":"dschlaep","id":4205019,"avatar_url":"https://avatars0.githubusercontent.com/u/4205019?v=4","gravatar_id":"","url":"https://api.github.com/users/dschlaep","html_url":"https://github.com/dschlaep","followers_url":"https://api.github.com/users/dschlaep/followers","following_url":"https://api.github.com/users/dschlaep/following{/other_user}","gists_url":"https://api.github.com/users/dschlaep/gists{/gist_id}","starred_url":"https://api.github.com/users/dschlaep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dschlaep/subscriptions","organizations_url":"https://api.github.com/users/dschlaep/orgs","repos_url":"https://api.github.com/users/dschlaep/repos","events_url":"https://api.github.com/users/dschlaep/events{/privacy}","received_events_url":"https://api.github.com/users/dschlaep/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/DrylandEcology/rSFSW2/milestones/7","html_url":"https://github.com/DrylandEcology/rSFSW2/milestone/7","labels_url":"https://api.github.com/repos/DrylandEcology/rSFSW2/milestones/7/labels","id":2695657,"number":7,"title":"master","description":"","creator":{"login":"Zachary-Kramer","id":16931318,"avatar_url":"https://avatars0.githubusercontent.com/u/16931318?v=4","gravatar_id":"","url":"https://api.github.com/users/Zachary-Kramer","html_url":"https://github.com/Zachary-Kramer","followers_url":"https://api.github.com/users/Zachary-Kramer/followers","following_url":"https://api.github.com/users/Zachary-Kramer/following{/other_user}","gists_url":"https://api.github.com/users/Zachary-Kramer/gists{/gist_id}","starred_url":"https://api.github.com/users/Zachary-Kramer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zachary-Kramer/subscriptions","organizations_url":"https://api.github.com/users/Zachary-Kramer/orgs","repos_url":"https://api.github.com/users/Zachary-Kramer/repos","events_url":"https://api.github.com/users/Zachary-Kramer/events{/privacy}","received_events_url":"https://api.github.com/users/Zachary-Kramer/received_events","type":"User","site_admin":false},"open_issues":12,"closed_issues":12,"state":"open","created_at":"2017-08-11T04:35:38Z","updated_at":"2018-02-05T18:36:44Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2018-01-19T20:22:13Z","updated_at":"2018-02-05T18:50:14Z","closed_at":null,"author_association":"OWNER","body":"```\r\nwith(x, plot(Evaporation_Total_mm_mean - (Evaporation_Soil_Total_mm_mean + Snowloss_mm_mean + Evaporation_InterceptedByVegetation_mm_mean + Evaporation_InterceptedByLitter_mm_mean), pch = 46, ylab = \"E - (E(soil) + E(snow) + E(veg) + E(litter))\", xlab = \"days\"))\r\n```\r\n\r\nNote: E(surface) is currently not outputted separately (see #253) -- It should be 0 for these simulations.\r\n\r\n![pastedgraphic-2](https://user-images.githubusercontent.com/4205019/35169924-55db3bb2-fd2c-11e7-8d1c-da93ce03d5b9.jpg)\r\n\r\n##\r\n```\r\nwith(x, plot(AET_mm_mean- (Transpiration_Total_mm_mean + Evaporation_Total_mm_mean), pch = 46, ylab = \"AET - (T + E)\", xlab = \"days\"))\r\n```\r\n![pastedgraphic-1](https://user-images.githubusercontent.com/4205019/35169892-3553519a-fd2c-11e7-9f1f-21c9e9769ada.jpg)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/DrylandEcology/rSFSW2/issues/comments/363182879","html_url":"https://github.com/DrylandEcology/rSFSW2/issues/254#issuecomment-363182879","issue_url":"https://api.github.com/repos/DrylandEcology/rSFSW2/issues/254","id":363182879,"user":{"login":"dschlaep","id":4205019,"avatar_url":"https://avatars0.githubusercontent.com/u/4205019?v=4","gravatar_id":"","url":"https://api.github.com/users/dschlaep","html_url":"https://github.com/dschlaep","followers_url":"https://api.github.com/users/dschlaep/followers","following_url":"https://api.github.com/users/dschlaep/following{/other_user}","gists_url":"https://api.github.com/users/dschlaep/gists{/gist_id}","starred_url":"https://api.github.com/users/dschlaep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dschlaep/subscriptions","organizations_url":"https://api.github.com/users/dschlaep/orgs","repos_url":"https://api.github.com/users/dschlaep/repos","events_url":"https://api.github.com/users/dschlaep/events{/privacy}","received_events_url":"https://api.github.com/users/dschlaep/received_events","type":"User","site_admin":false},"created_at":"2018-02-05T18:50:14Z","updated_at":"2018-02-05T18:50:14Z","author_association":"OWNER","body":"This error got fixed with the fixes to DrylandEcology/SOILWAT2#133 and DrylandEcology/rSOILWAT2#99:\r\n```\r\nlibrary(\"RSQLite\")\r\ncon <- dbConnect(SQLite(), \"tests/test_data/0_ReferenceOutput/dbTables_Test4_AllOverallAggregations_snow_v2.5.6.sqlite3\")\r\nx <- dbReadTable(con, \"aggregation_overall_mean\")\r\n\r\n# Checks from this issue:\r\n# Check: Etotal == (E(soil) + E(snow) + E(veg) + E(litter))\r\nwith(x, all.equal(Evaporation_Total_mm_mean, (Evaporation_Soil_Total_mm_mean + Snowloss_mm_mean + Evaporation_InterceptedByVegetation_mm_mean + Evaporation_InterceptedByLitter_mm_mean)))\r\n\r\n# Check: AET == (Ttotal + Etotal)\r\nwith(x, all.equal(AET_mm_mean, (Transpiration_Total_mm_mean + Evaporation_Total_mm_mean)))\r\n\r\ndbDisconnect(con)\r\n```\r\n\r\n> TRUE\r\n> TRUE"}}
{"actor":{"display_login":"dschlaep"}}