{"action":"created","comment":{"url":"https://api.github.com/repos/apache/carbondata/pulls/comments/227619046","pull_request_review_id":167701800,"id":227619046,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzYxOTA0Ng==","diff_hunk":"@@ -198,4 +219,48 @@ void fillColumnVectorDetails(CarbonColumnarBatch columnarBatch, int rowCounter,\n     }\n   }\n \n+  private void collectResultInColumnarBatchDirect(BlockletScannedResult scannedResult,","path":"core/src/main/java/org/apache/carbondata/core/scan/collector/impl/DictionaryBasedVectorResultCollector.java","position":109,"original_position":109,"commit_id":"7e3a7aef062f69f2d449641bb1600a25a802113e","original_commit_id":"7e3a7aef062f69f2d449641bb1600a25a802113e","user":{"login":"jackylk","id":6500698,"node_id":"MDQ6VXNlcjY1MDA2OTg=","avatar_url":"https://avatars3.githubusercontent.com/u/6500698?v=4","gravatar_id":"","url":"https://api.github.com/users/jackylk","html_url":"https://github.com/jackylk","followers_url":"https://api.github.com/users/jackylk/followers","following_url":"https://api.github.com/users/jackylk/following{/other_user}","gists_url":"https://api.github.com/users/jackylk/gists{/gist_id}","starred_url":"https://api.github.com/users/jackylk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jackylk/subscriptions","organizations_url":"https://api.github.com/users/jackylk/orgs","repos_url":"https://api.github.com/users/jackylk/repos","events_url":"https://api.github.com/users/jackylk/events{/privacy}","received_events_url":"https://api.github.com/users/jackylk/received_events","type":"User","site_admin":false},"body":"add comment for this function","created_at":"2018-10-24T01:42:07Z","updated_at":"2018-10-24T01:42:08Z","html_url":"https://github.com/apache/carbondata/pull/2819#discussion_r227619046","pull_request_url":"https://api.github.com/repos/apache/carbondata/pulls/2819","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/carbondata/pulls/comments/227619046"},"html":{"href":"https://github.com/apache/carbondata/pull/2819#discussion_r227619046"},"pull_request":{"href":"https://api.github.com/repos/apache/carbondata/pulls/2819"}}},"pull_request":{"url":"https://api.github.com/repos/apache/carbondata/pulls/2819","id":223142533,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzMTQyNTMz","html_url":"https://github.com/apache/carbondata/pull/2819","diff_url":"https://github.com/apache/carbondata/pull/2819.diff","patch_url":"https://github.com/apache/carbondata/pull/2819.patch","issue_url":"https://api.github.com/repos/apache/carbondata/issues/2819","number":2819,"state":"open","locked":false,"title":"[CARBONDATA-3012] Added support for full scan queries for vector direct fill.","user":{"login":"ravipesala","id":8134086,"node_id":"MDQ6VXNlcjgxMzQwODY=","avatar_url":"https://avatars2.githubusercontent.com/u/8134086?v=4","gravatar_id":"","url":"https://api.github.com/users/ravipesala","html_url":"https://github.com/ravipesala","followers_url":"https://api.github.com/users/ravipesala/followers","following_url":"https://api.github.com/users/ravipesala/following{/other_user}","gists_url":"https://api.github.com/users/ravipesala/gists{/gist_id}","starred_url":"https://api.github.com/users/ravipesala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravipesala/subscriptions","organizations_url":"https://api.github.com/users/ravipesala/orgs","repos_url":"https://api.github.com/users/ravipesala/repos","events_url":"https://api.github.com/users/ravipesala/events{/privacy}","received_events_url":"https://api.github.com/users/ravipesala/received_events","type":"User","site_admin":false},"body":"This PR depends on PR https://github.com/apache/carbondata/pull/2818\r\n\r\nAfter decompressing the page in our V3 reader we can immediately fill the data to a vector without any condition checks inside loops. So here complete column page data is set to column vector in a single batch and gives back data to Spark/Presto.\r\nFor this purpose, a new method is added in `ColumnPageDecoder`\r\n```\r\nColumnPage decodeAndFillVector(byte[] input, int offset, int length, ColumnVectorInfo vectorInfo,\r\n      BitSet nullBits, boolean isLVEncoded)\r\n```\r\nThe above method takes vector fill it in a single loop without any checks inside loop.\r\n\r\nAnd also added new method inside `DimensionDataChunkStore`\r\n\r\n```\r\n void fillVector(int[] invertedIndex, int[] invertedIndexReverse, byte[] data,\r\n      ColumnVectorInfo vectorInfo);\r\n```\r\nThe above method takes vector fill it in a single loop without any checks inside loop.\r\n\r\n\r\nBe sure to do all of the following checklist to help us incorporate \r\nyour contribution quickly and easily:\r\n\r\n - [ ] Any interfaces changed?\r\n \r\n - [ ] Any backward compatibility impacted?\r\n \r\n - [ ] Document update required?\r\n\r\n - [ ] Testing done\r\n        Please provide details on \r\n        - Whether new unit test cases have been added or why no new tests are required?\r\n        - How it is tested? Please attach test report.\r\n        - Is it a performance related change? Please attach the performance test report.\r\n        - Any additional information to help reviewers in testing this change.\r\n       \r\n - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA. \r\n\r\n","created_at":"2018-10-16T07:31:20Z","updated_at":"2018-10-24T01:42:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3cc191962a9695a478049c689f94771ce6be8b97","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/carbondata/pulls/2819/commits","review_comments_url":"https://api.github.com/repos/apache/carbondata/pulls/2819/comments","review_comment_url":"https://api.github.com/repos/apache/carbondata/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/carbondata/issues/2819/comments","statuses_url":"https://api.github.com/repos/apache/carbondata/statuses/7e3a7aef062f69f2d449641bb1600a25a802113e","head":{"label":"ravipesala:perf-full-scan","ref":"perf-full-scan","sha":"7e3a7aef062f69f2d449641bb1600a25a802113e","user":{"login":"ravipesala","id":8134086,"node_id":"MDQ6VXNlcjgxMzQwODY=","avatar_url":"https://avatars2.githubusercontent.com/u/8134086?v=4","gravatar_id":"","url":"https://api.github.com/users/ravipesala","html_url":"https://github.com/ravipesala","followers_url":"https://api.github.com/users/ravipesala/followers","following_url":"https://api.github.com/users/ravipesala/following{/other_user}","gists_url":"https://api.github.com/users/ravipesala/gists{/gist_id}","starred_url":"https://api.github.com/users/ravipesala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravipesala/subscriptions","organizations_url":"https://api.github.com/users/ravipesala/orgs","repos_url":"https://api.github.com/users/ravipesala/repos","events_url":"https://api.github.com/users/ravipesala/events{/privacy}","received_events_url":"https://api.github.com/users/ravipesala/received_events","type":"User","site_admin":false},"repo":{"id":62142167,"node_id":"MDEwOlJlcG9zaXRvcnk2MjE0MjE2Nw==","name":"incubator-carbondata","full_name":"ravipesala/incubator-carbondata","private":false,"owner":{"login":"ravipesala","id":8134086,"node_id":"MDQ6VXNlcjgxMzQwODY=","avatar_url":"https://avatars2.githubusercontent.com/u/8134086?v=4","gravatar_id":"","url":"https://api.github.com/users/ravipesala","html_url":"https://github.com/ravipesala","followers_url":"https://api.github.com/users/ravipesala/followers","following_url":"https://api.github.com/users/ravipesala/following{/other_user}","gists_url":"https://api.github.com/users/ravipesala/gists{/gist_id}","starred_url":"https://api.github.com/users/ravipesala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ravipesala/subscriptions","organizations_url":"https://api.github.com/users/ravipesala/orgs","repos_url":"https://api.github.com/users/ravipesala/repos","events_url":"https://api.github.com/users/ravipesala/events{/privacy}","received_events_url":"https://api.github.com/users/ravipesala/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ravipesala/incubator-carbondata","description":"Mirror of Apache CarbonData (Incubating)","fork":true,"url":"https://api.github.com/repos/ravipesala/incubator-carbondata","forks_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/forks","keys_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/teams","hooks_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/hooks","issue_events_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/issues/events{/number}","events_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/events","assignees_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/assignees{/user}","branches_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/branches{/branch}","tags_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/tags","blobs_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/git/refs{/sha}","trees_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/statuses/{sha}","languages_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/languages","stargazers_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/stargazers","contributors_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/contributors","subscribers_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/subscribers","subscription_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/subscription","commits_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/commits{/sha}","git_commits_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/git/commits{/sha}","comments_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/comments{/number}","issue_comment_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/issues/comments{/number}","contents_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/contents/{+path}","compare_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/merges","archive_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/downloads","issues_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/issues{/number}","pulls_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/pulls{/number}","milestones_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/milestones{/number}","notifications_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/labels{/name}","releases_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/releases{/id}","deployments_url":"https://api.github.com/repos/ravipesala/incubator-carbondata/deployments","created_at":"2016-06-28T13:16:56Z","updated_at":"2017-09-09T13:36:56Z","pushed_at":"2018-10-23T12:16:09Z","git_url":"git://github.com/ravipesala/incubator-carbondata.git","ssh_url":"git@github.com:ravipesala/incubator-carbondata.git","clone_url":"https://github.com/ravipesala/incubator-carbondata.git","svn_url":"https://github.com/ravipesala/incubator-carbondata","homepage":null,"size":187743,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"a9e405f47a58492837fd0d32cbd560ffcf46e4e9","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":62117818,"node_id":"MDEwOlJlcG9zaXRvcnk2MjExNzgxOA==","name":"carbondata","full_name":"apache/carbondata","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/carbondata","description":"Mirror of Apache CarbonData","fork":false,"url":"https://api.github.com/repos/apache/carbondata","forks_url":"https://api.github.com/repos/apache/carbondata/forks","keys_url":"https://api.github.com/repos/apache/carbondata/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/carbondata/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/carbondata/teams","hooks_url":"https://api.github.com/repos/apache/carbondata/hooks","issue_events_url":"https://api.github.com/repos/apache/carbondata/issues/events{/number}","events_url":"https://api.github.com/repos/apache/carbondata/events","assignees_url":"https://api.github.com/repos/apache/carbondata/assignees{/user}","branches_url":"https://api.github.com/repos/apache/carbondata/branches{/branch}","tags_url":"https://api.github.com/repos/apache/carbondata/tags","blobs_url":"https://api.github.com/repos/apache/carbondata/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/carbondata/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/carbondata/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/carbondata/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/carbondata/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/carbondata/languages","stargazers_url":"https://api.github.com/repos/apache/carbondata/stargazers","contributors_url":"https://api.github.com/repos/apache/carbondata/contributors","subscribers_url":"https://api.github.com/repos/apache/carbondata/subscribers","subscription_url":"https://api.github.com/repos/apache/carbondata/subscription","commits_url":"https://api.github.com/repos/apache/carbondata/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/carbondata/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/carbondata/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/carbondata/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/carbondata/contents/{+path}","compare_url":"https://api.github.com/repos/apache/carbondata/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/carbondata/merges","archive_url":"https://api.github.com/repos/apache/carbondata/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/carbondata/downloads","issues_url":"https://api.github.com/repos/apache/carbondata/issues{/number}","pulls_url":"https://api.github.com/repos/apache/carbondata/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/carbondata/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/carbondata/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/carbondata/labels{/name}","releases_url":"https://api.github.com/repos/apache/carbondata/releases{/id}","deployments_url":"https://api.github.com/repos/apache/carbondata/deployments","created_at":"2016-06-28T07:00:06Z","updated_at":"2018-10-23T11:29:55Z","pushed_at":"2018-10-24T01:34:30Z","git_url":"git://github.com/apache/carbondata.git","ssh_url":"git@github.com:apache/carbondata.git","clone_url":"https://github.com/apache/carbondata.git","svn_url":"https://github.com/apache/carbondata","homepage":"","size":64511,"stargazers_count":765,"watchers_count":765,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":463,"mirror_url":null,"archived":false,"open_issues_count":110,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":463,"open_issues":110,"watchers":765,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/carbondata/pulls/2819"},"html":{"href":"https://github.com/apache/carbondata/pull/2819"},"issue":{"href":"https://api.github.com/repos/apache/carbondata/issues/2819"},"comments":{"href":"https://api.github.com/repos/apache/carbondata/issues/2819/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/carbondata/pulls/2819/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/carbondata/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/carbondata/pulls/2819/commits"},"statuses":{"href":"https://api.github.com/repos/apache/carbondata/statuses/7e3a7aef062f69f2d449641bb1600a25a802113e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jackylk"}}