{"action":"created","comment":{"url":"https://api.github.com/repos/cylc/cylc/pulls/comments/233064026","pull_request_review_id":174395553,"id":233064026,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzA2NDAyNg==","diff_hunk":"@@ -106,10 +106,8 @@ def daemonize(server):\n             })\n             # exit parent 1\n             sys.exit(0)\n-    except OSError, exc:\n-        sys.stderr.write(\n-            \"fork #1 failed: %d (%s)\\n\" % (exc.errno, exc.strerror))\n-        sys.exit(1)\n+    except OSError as exc:","path":"lib/cylc/daemonize.py","position":8,"original_position":8,"commit_id":"80cfabff938a7c3c413607fe021cd2607f8bad60","original_commit_id":"80cfabff938a7c3c413607fe021cd2607f8bad60","user":{"login":"matthewrmshin","id":908613,"node_id":"MDQ6VXNlcjkwODYxMw==","avatar_url":"https://avatars3.githubusercontent.com/u/908613?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewrmshin","html_url":"https://github.com/matthewrmshin","followers_url":"https://api.github.com/users/matthewrmshin/followers","following_url":"https://api.github.com/users/matthewrmshin/following{/other_user}","gists_url":"https://api.github.com/users/matthewrmshin/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewrmshin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewrmshin/subscriptions","organizations_url":"https://api.github.com/users/matthewrmshin/orgs","repos_url":"https://api.github.com/users/matthewrmshin/repos","events_url":"https://api.github.com/users/matthewrmshin/events{/privacy}","received_events_url":"https://api.github.com/users/matthewrmshin/received_events","type":"User","site_admin":false},"body":"For Python 3 readiness.","created_at":"2018-11-13T14:41:21Z","updated_at":"2018-11-13T14:41:21Z","html_url":"https://github.com/cylc/cylc/pull/2854#discussion_r233064026","pull_request_url":"https://api.github.com/repos/cylc/cylc/pulls/2854","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/cylc/cylc/pulls/comments/233064026"},"html":{"href":"https://github.com/cylc/cylc/pull/2854#discussion_r233064026"},"pull_request":{"href":"https://api.github.com/repos/cylc/cylc/pulls/2854"}}},"pull_request":{"url":"https://api.github.com/repos/cylc/cylc/pulls/2854","id":230169306,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMTY5MzA2","html_url":"https://github.com/cylc/cylc/pull/2854","diff_url":"https://github.com/cylc/cylc/pull/2854.diff","patch_url":"https://github.com/cylc/cylc/pull/2854.patch","issue_url":"https://api.github.com/repos/cylc/cylc/issues/2854","number":2854,"state":"open","locked":false,"title":"Improve config deprecated upgrade log","user":{"login":"matthewrmshin","id":908613,"node_id":"MDQ6VXNlcjkwODYxMw==","avatar_url":"https://avatars3.githubusercontent.com/u/908613?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewrmshin","html_url":"https://github.com/matthewrmshin","followers_url":"https://api.github.com/users/matthewrmshin/followers","following_url":"https://api.github.com/users/matthewrmshin/following{/other_user}","gists_url":"https://api.github.com/users/matthewrmshin/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewrmshin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewrmshin/subscriptions","organizations_url":"https://api.github.com/users/matthewrmshin/orgs","repos_url":"https://api.github.com/users/matthewrmshin/repos","events_url":"https://api.github.com/users/matthewrmshin/events{/privacy}","received_events_url":"https://api.github.com/users/matthewrmshin/received_events","type":"User","site_admin":false},"body":"Use DEBUG level for site files - users may not be able to fix them\r\neasily. Use WARNING level for all other files to better alert users.\r\n* See also #2781 and metomi/rose#2257.\r\n\r\nRemove more `print` or `sys.std*.write` statements by converting them to use `logging`.\r\n* Remove some unnecessary diagnostics.\r\n* Remove some debug flag check in favour logging level check.\r\n* Exit with error message instead of `print` error then `sys.exit(1)`.","created_at":"2018-11-12T15:17:52Z","updated_at":"2018-11-13T14:41:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49ce24727b293e73368dbe0cbd7bac6db5307f22","assignee":{"login":"matthewrmshin","id":908613,"node_id":"MDQ6VXNlcjkwODYxMw==","avatar_url":"https://avatars3.githubusercontent.com/u/908613?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewrmshin","html_url":"https://github.com/matthewrmshin","followers_url":"https://api.github.com/users/matthewrmshin/followers","following_url":"https://api.github.com/users/matthewrmshin/following{/other_user}","gists_url":"https://api.github.com/users/matthewrmshin/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewrmshin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewrmshin/subscriptions","organizations_url":"https://api.github.com/users/matthewrmshin/orgs","repos_url":"https://api.github.com/users/matthewrmshin/repos","events_url":"https://api.github.com/users/matthewrmshin/events{/privacy}","received_events_url":"https://api.github.com/users/matthewrmshin/received_events","type":"User","site_admin":false},"assignees":[{"login":"matthewrmshin","id":908613,"node_id":"MDQ6VXNlcjkwODYxMw==","avatar_url":"https://avatars3.githubusercontent.com/u/908613?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewrmshin","html_url":"https://github.com/matthewrmshin","followers_url":"https://api.github.com/users/matthewrmshin/followers","following_url":"https://api.github.com/users/matthewrmshin/following{/other_user}","gists_url":"https://api.github.com/users/matthewrmshin/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewrmshin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewrmshin/subscriptions","organizations_url":"https://api.github.com/users/matthewrmshin/orgs","repos_url":"https://api.github.com/users/matthewrmshin/repos","events_url":"https://api.github.com/users/matthewrmshin/events{/privacy}","received_events_url":"https://api.github.com/users/matthewrmshin/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/cylc/cylc/milestones/70","html_url":"https://github.com/cylc/cylc/milestone/70","labels_url":"https://api.github.com/repos/cylc/cylc/milestones/70/labels","id":3364574,"node_id":"MDk6TWlsZXN0b25lMzM2NDU3NA==","number":70,"title":"next release","description":"cylc-7.8.0","creator":{"login":"hjoliver","id":2362137,"node_id":"MDQ6VXNlcjIzNjIxMzc=","avatar_url":"https://avatars0.githubusercontent.com/u/2362137?v=4","gravatar_id":"","url":"https://api.github.com/users/hjoliver","html_url":"https://github.com/hjoliver","followers_url":"https://api.github.com/users/hjoliver/followers","following_url":"https://api.github.com/users/hjoliver/following{/other_user}","gists_url":"https://api.github.com/users/hjoliver/gists{/gist_id}","starred_url":"https://api.github.com/users/hjoliver/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hjoliver/subscriptions","organizations_url":"https://api.github.com/users/hjoliver/orgs","repos_url":"https://api.github.com/users/hjoliver/repos","events_url":"https://api.github.com/users/hjoliver/events{/privacy}","received_events_url":"https://api.github.com/users/hjoliver/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":97,"state":"open","created_at":"2018-05-22T13:29:48Z","updated_at":"2018-11-13T12:35:33Z","due_on":"2018-11-30T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/cylc/cylc/pulls/2854/commits","review_comments_url":"https://api.github.com/repos/cylc/cylc/pulls/2854/comments","review_comment_url":"https://api.github.com/repos/cylc/cylc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cylc/cylc/issues/2854/comments","statuses_url":"https://api.github.com/repos/cylc/cylc/statuses/80cfabff938a7c3c413607fe021cd2607f8bad60","head":{"label":"matthewrmshin:improve-conf-deprecated-upgrade-logging","ref":"improve-conf-deprecated-upgrade-logging","sha":"80cfabff938a7c3c413607fe021cd2607f8bad60","user":{"login":"matthewrmshin","id":908613,"node_id":"MDQ6VXNlcjkwODYxMw==","avatar_url":"https://avatars3.githubusercontent.com/u/908613?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewrmshin","html_url":"https://github.com/matthewrmshin","followers_url":"https://api.github.com/users/matthewrmshin/followers","following_url":"https://api.github.com/users/matthewrmshin/following{/other_user}","gists_url":"https://api.github.com/users/matthewrmshin/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewrmshin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewrmshin/subscriptions","organizations_url":"https://api.github.com/users/matthewrmshin/orgs","repos_url":"https://api.github.com/users/matthewrmshin/repos","events_url":"https://api.github.com/users/matthewrmshin/events{/privacy}","received_events_url":"https://api.github.com/users/matthewrmshin/received_events","type":"User","site_admin":false},"repo":{"id":4710539,"node_id":"MDEwOlJlcG9zaXRvcnk0NzEwNTM5","name":"cylc","full_name":"matthewrmshin/cylc","private":false,"owner":{"login":"matthewrmshin","id":908613,"node_id":"MDQ6VXNlcjkwODYxMw==","avatar_url":"https://avatars3.githubusercontent.com/u/908613?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewrmshin","html_url":"https://github.com/matthewrmshin","followers_url":"https://api.github.com/users/matthewrmshin/followers","following_url":"https://api.github.com/users/matthewrmshin/following{/other_user}","gists_url":"https://api.github.com/users/matthewrmshin/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewrmshin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewrmshin/subscriptions","organizations_url":"https://api.github.com/users/matthewrmshin/orgs","repos_url":"https://api.github.com/users/matthewrmshin/repos","events_url":"https://api.github.com/users/matthewrmshin/events{/privacy}","received_events_url":"https://api.github.com/users/matthewrmshin/received_events","type":"User","site_admin":false},"html_url":"https://github.com/matthewrmshin/cylc","description":"Cylc: an engine for running meteorological suites","fork":true,"url":"https://api.github.com/repos/matthewrmshin/cylc","forks_url":"https://api.github.com/repos/matthewrmshin/cylc/forks","keys_url":"https://api.github.com/repos/matthewrmshin/cylc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/matthewrmshin/cylc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/matthewrmshin/cylc/teams","hooks_url":"https://api.github.com/repos/matthewrmshin/cylc/hooks","issue_events_url":"https://api.github.com/repos/matthewrmshin/cylc/issues/events{/number}","events_url":"https://api.github.com/repos/matthewrmshin/cylc/events","assignees_url":"https://api.github.com/repos/matthewrmshin/cylc/assignees{/user}","branches_url":"https://api.github.com/repos/matthewrmshin/cylc/branches{/branch}","tags_url":"https://api.github.com/repos/matthewrmshin/cylc/tags","blobs_url":"https://api.github.com/repos/matthewrmshin/cylc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/matthewrmshin/cylc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/matthewrmshin/cylc/git/refs{/sha}","trees_url":"https://api.github.com/repos/matthewrmshin/cylc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/matthewrmshin/cylc/statuses/{sha}","languages_url":"https://api.github.com/repos/matthewrmshin/cylc/languages","stargazers_url":"https://api.github.com/repos/matthewrmshin/cylc/stargazers","contributors_url":"https://api.github.com/repos/matthewrmshin/cylc/contributors","subscribers_url":"https://api.github.com/repos/matthewrmshin/cylc/subscribers","subscription_url":"https://api.github.com/repos/matthewrmshin/cylc/subscription","commits_url":"https://api.github.com/repos/matthewrmshin/cylc/commits{/sha}","git_commits_url":"https://api.github.com/repos/matthewrmshin/cylc/git/commits{/sha}","comments_url":"https://api.github.com/repos/matthewrmshin/cylc/comments{/number}","issue_comment_url":"https://api.github.com/repos/matthewrmshin/cylc/issues/comments{/number}","contents_url":"https://api.github.com/repos/matthewrmshin/cylc/contents/{+path}","compare_url":"https://api.github.com/repos/matthewrmshin/cylc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/matthewrmshin/cylc/merges","archive_url":"https://api.github.com/repos/matthewrmshin/cylc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/matthewrmshin/cylc/downloads","issues_url":"https://api.github.com/repos/matthewrmshin/cylc/issues{/number}","pulls_url":"https://api.github.com/repos/matthewrmshin/cylc/pulls{/number}","milestones_url":"https://api.github.com/repos/matthewrmshin/cylc/milestones{/number}","notifications_url":"https://api.github.com/repos/matthewrmshin/cylc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/matthewrmshin/cylc/labels{/name}","releases_url":"https://api.github.com/repos/matthewrmshin/cylc/releases{/id}","deployments_url":"https://api.github.com/repos/matthewrmshin/cylc/deployments","created_at":"2012-06-19T07:07:09Z","updated_at":"2018-11-12T11:25:46Z","pushed_at":"2018-11-13T13:10:21Z","git_url":"git://github.com/matthewrmshin/cylc.git","ssh_url":"git@github.com:matthewrmshin/cylc.git","clone_url":"https://github.com/matthewrmshin/cylc.git","svn_url":"https://github.com/matthewrmshin/cylc","homepage":"http://cylc.github.io/cylc/","size":73720,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"cylc:master","ref":"master","sha":"337f0938720d8210b1dfaeb430c105a824da97df","user":{"login":"cylc","id":824878,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNDg3OA==","avatar_url":"https://avatars1.githubusercontent.com/u/824878?v=4","gravatar_id":"","url":"https://api.github.com/users/cylc","html_url":"https://github.com/cylc","followers_url":"https://api.github.com/users/cylc/followers","following_url":"https://api.github.com/users/cylc/following{/other_user}","gists_url":"https://api.github.com/users/cylc/gists{/gist_id}","starred_url":"https://api.github.com/users/cylc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cylc/subscriptions","organizations_url":"https://api.github.com/users/cylc/orgs","repos_url":"https://api.github.com/users/cylc/repos","events_url":"https://api.github.com/users/cylc/events{/privacy}","received_events_url":"https://api.github.com/users/cylc/received_events","type":"Organization","site_admin":false},"repo":{"id":1836229,"node_id":"MDEwOlJlcG9zaXRvcnkxODM2MjI5","name":"cylc","full_name":"cylc/cylc","private":false,"owner":{"login":"cylc","id":824878,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgyNDg3OA==","avatar_url":"https://avatars1.githubusercontent.com/u/824878?v=4","gravatar_id":"","url":"https://api.github.com/users/cylc","html_url":"https://github.com/cylc","followers_url":"https://api.github.com/users/cylc/followers","following_url":"https://api.github.com/users/cylc/following{/other_user}","gists_url":"https://api.github.com/users/cylc/gists{/gist_id}","starred_url":"https://api.github.com/users/cylc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cylc/subscriptions","organizations_url":"https://api.github.com/users/cylc/orgs","repos_url":"https://api.github.com/users/cylc/repos","events_url":"https://api.github.com/users/cylc/events{/privacy}","received_events_url":"https://api.github.com/users/cylc/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cylc/cylc","description":"Cylc, a workflow engine for cycling (and non-cycling) systems.","fork":false,"url":"https://api.github.com/repos/cylc/cylc","forks_url":"https://api.github.com/repos/cylc/cylc/forks","keys_url":"https://api.github.com/repos/cylc/cylc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cylc/cylc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cylc/cylc/teams","hooks_url":"https://api.github.com/repos/cylc/cylc/hooks","issue_events_url":"https://api.github.com/repos/cylc/cylc/issues/events{/number}","events_url":"https://api.github.com/repos/cylc/cylc/events","assignees_url":"https://api.github.com/repos/cylc/cylc/assignees{/user}","branches_url":"https://api.github.com/repos/cylc/cylc/branches{/branch}","tags_url":"https://api.github.com/repos/cylc/cylc/tags","blobs_url":"https://api.github.com/repos/cylc/cylc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cylc/cylc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cylc/cylc/git/refs{/sha}","trees_url":"https://api.github.com/repos/cylc/cylc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cylc/cylc/statuses/{sha}","languages_url":"https://api.github.com/repos/cylc/cylc/languages","stargazers_url":"https://api.github.com/repos/cylc/cylc/stargazers","contributors_url":"https://api.github.com/repos/cylc/cylc/contributors","subscribers_url":"https://api.github.com/repos/cylc/cylc/subscribers","subscription_url":"https://api.github.com/repos/cylc/cylc/subscription","commits_url":"https://api.github.com/repos/cylc/cylc/commits{/sha}","git_commits_url":"https://api.github.com/repos/cylc/cylc/git/commits{/sha}","comments_url":"https://api.github.com/repos/cylc/cylc/comments{/number}","issue_comment_url":"https://api.github.com/repos/cylc/cylc/issues/comments{/number}","contents_url":"https://api.github.com/repos/cylc/cylc/contents/{+path}","compare_url":"https://api.github.com/repos/cylc/cylc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cylc/cylc/merges","archive_url":"https://api.github.com/repos/cylc/cylc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cylc/cylc/downloads","issues_url":"https://api.github.com/repos/cylc/cylc/issues{/number}","pulls_url":"https://api.github.com/repos/cylc/cylc/pulls{/number}","milestones_url":"https://api.github.com/repos/cylc/cylc/milestones{/number}","notifications_url":"https://api.github.com/repos/cylc/cylc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cylc/cylc/labels{/name}","releases_url":"https://api.github.com/repos/cylc/cylc/releases{/id}","deployments_url":"https://api.github.com/repos/cylc/cylc/deployments","created_at":"2011-06-02T08:31:49Z","updated_at":"2018-11-09T19:34:16Z","pushed_at":"2018-11-13T13:10:22Z","git_url":"git://github.com/cylc/cylc.git","ssh_url":"git@github.com:cylc/cylc.git","clone_url":"https://github.com/cylc/cylc.git","svn_url":"https://github.com/cylc/cylc","homepage":"https://cylc.github.io/cylc","size":130293,"stargazers_count":77,"watchers_count":77,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":55,"mirror_url":null,"archived":false,"open_issues_count":174,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":55,"open_issues":174,"watchers":77,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cylc/cylc/pulls/2854"},"html":{"href":"https://github.com/cylc/cylc/pull/2854"},"issue":{"href":"https://api.github.com/repos/cylc/cylc/issues/2854"},"comments":{"href":"https://api.github.com/repos/cylc/cylc/issues/2854/comments"},"review_comments":{"href":"https://api.github.com/repos/cylc/cylc/pulls/2854/comments"},"review_comment":{"href":"https://api.github.com/repos/cylc/cylc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cylc/cylc/pulls/2854/commits"},"statuses":{"href":"https://api.github.com/repos/cylc/cylc/statuses/80cfabff938a7c3c413607fe021cd2607f8bad60"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"matthewrmshin"}}