{"action":"created","comment":{"url":"https://api.github.com/repos/chainer/chainer/pulls/comments/243020714","pull_request_review_id":186679519,"id":243020714,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MzAyMDcxNA==","diff_hunk":"@@ -58,7 +58,7 @@ ArrayBodyPtr MakeArrayFromBuffer(py::buffer buffer, py::handle dtype, int64_t co\n         throw ChainerxError{\"offset must be non-negative and no greater than buffer length (\", n_bytes, \")\"};\n     }\n \n-    if (!internal::IsContiguous(Shape{info.shape}, Strides{info.strides}, info.itemsize)) {\n+    if (!internal::IsContiguous(Shape{info.shape.begin(), info.shape.end()}, Strides{info.strides.begin(), info.strides.end()}, info.itemsize)) {","path":"chainerx_cc/chainerx/python/routines.cc","position":5,"original_position":5,"commit_id":"681259ab29d91bcbb08fa481847a5ec995c1c2dd","original_commit_id":"681259ab29d91bcbb08fa481847a5ec995c1c2dd","user":{"login":"hvy","id":5983694,"node_id":"MDQ6VXNlcjU5ODM2OTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5983694?v=4","gravatar_id":"","url":"https://api.github.com/users/hvy","html_url":"https://github.com/hvy","followers_url":"https://api.github.com/users/hvy/followers","following_url":"https://api.github.com/users/hvy/following{/other_user}","gists_url":"https://api.github.com/users/hvy/gists{/gist_id}","starred_url":"https://api.github.com/users/hvy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hvy/subscriptions","organizations_url":"https://api.github.com/users/hvy/orgs","repos_url":"https://api.github.com/users/hvy/repos","events_url":"https://api.github.com/users/hvy/events{/privacy}","received_events_url":"https://api.github.com/users/hvy/received_events","type":"User","site_admin":false},"body":"Could you fix the format of this line? Seems like a line break is missing.","created_at":"2018-12-19T18:11:02Z","updated_at":"2018-12-19T18:11:02Z","html_url":"https://github.com/chainer/chainer/pull/5776#discussion_r243020714","pull_request_url":"https://api.github.com/repos/chainer/chainer/pulls/5776","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/chainer/chainer/pulls/comments/243020714"},"html":{"href":"https://github.com/chainer/chainer/pull/5776#discussion_r243020714"},"pull_request":{"href":"https://api.github.com/repos/chainer/chainer/pulls/5776"}}},"pull_request":{"url":"https://api.github.com/repos/chainer/chainer/pulls/5776","id":236065802,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2MDY1ODAy","html_url":"https://github.com/chainer/chainer/pull/5776","diff_url":"https://github.com/chainer/chainer/pull/5776.diff","patch_url":"https://github.com/chainer/chainer/pull/5776.patch","issue_url":"https://api.github.com/repos/chainer/chainer/issues/5776","number":5776,"state":"open","locked":false,"title":"Patch files for macOS","user":{"login":"ktnyt","id":1581965,"node_id":"MDQ6VXNlcjE1ODE5NjU=","avatar_url":"https://avatars3.githubusercontent.com/u/1581965?v=4","gravatar_id":"","url":"https://api.github.com/users/ktnyt","html_url":"https://github.com/ktnyt","followers_url":"https://api.github.com/users/ktnyt/followers","following_url":"https://api.github.com/users/ktnyt/following{/other_user}","gists_url":"https://api.github.com/users/ktnyt/gists{/gist_id}","starred_url":"https://api.github.com/users/ktnyt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktnyt/subscriptions","organizations_url":"https://api.github.com/users/ktnyt/orgs","repos_url":"https://api.github.com/users/ktnyt/repos","events_url":"https://api.github.com/users/ktnyt/events{/privacy}","received_events_url":"https://api.github.com/users/ktnyt/received_events","type":"User","site_admin":false},"body":"Attempt to fix issue #5773 \r\n\r\nChanges are as follows:\r\n- Remove `--(no-)whole-archive` when building on macOS platforms.\r\n- Change native memory allocation logic for macOS platforms.\r\n- Cosmetic changes so tests build successfully. (Will revert if necessary.)","created_at":"2018-12-05T06:56:03Z","updated_at":"2018-12-19T18:11:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2a2b421bb29f8e4bc00f4fd31f0ecc4690d474ed","assignee":{"login":"hvy","id":5983694,"node_id":"MDQ6VXNlcjU5ODM2OTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5983694?v=4","gravatar_id":"","url":"https://api.github.com/users/hvy","html_url":"https://github.com/hvy","followers_url":"https://api.github.com/users/hvy/followers","following_url":"https://api.github.com/users/hvy/following{/other_user}","gists_url":"https://api.github.com/users/hvy/gists{/gist_id}","starred_url":"https://api.github.com/users/hvy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hvy/subscriptions","organizations_url":"https://api.github.com/users/hvy/orgs","repos_url":"https://api.github.com/users/hvy/repos","events_url":"https://api.github.com/users/hvy/events{/privacy}","received_events_url":"https://api.github.com/users/hvy/received_events","type":"User","site_admin":false},"assignees":[{"login":"hvy","id":5983694,"node_id":"MDQ6VXNlcjU5ODM2OTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/5983694?v=4","gravatar_id":"","url":"https://api.github.com/users/hvy","html_url":"https://github.com/hvy","followers_url":"https://api.github.com/users/hvy/followers","following_url":"https://api.github.com/users/hvy/following{/other_user}","gists_url":"https://api.github.com/users/hvy/gists{/gist_id}","starred_url":"https://api.github.com/users/hvy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hvy/subscriptions","organizations_url":"https://api.github.com/users/hvy/orgs","repos_url":"https://api.github.com/users/hvy/repos","events_url":"https://api.github.com/users/hvy/events{/privacy}","received_events_url":"https://api.github.com/users/hvy/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1144360898,"node_id":"MDU6TGFiZWwxMTQ0MzYwODk4","url":"https://api.github.com/repos/chainer/chainer/labels/ChainerX","name":"ChainerX","color":"006b75","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/chainer/chainer/pulls/5776/commits","review_comments_url":"https://api.github.com/repos/chainer/chainer/pulls/5776/comments","review_comment_url":"https://api.github.com/repos/chainer/chainer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/chainer/chainer/issues/5776/comments","statuses_url":"https://api.github.com/repos/chainer/chainer/statuses/681259ab29d91bcbb08fa481847a5ec995c1c2dd","head":{"label":"ktnyt:chainerx_macos","ref":"chainerx_macos","sha":"681259ab29d91bcbb08fa481847a5ec995c1c2dd","user":{"login":"ktnyt","id":1581965,"node_id":"MDQ6VXNlcjE1ODE5NjU=","avatar_url":"https://avatars3.githubusercontent.com/u/1581965?v=4","gravatar_id":"","url":"https://api.github.com/users/ktnyt","html_url":"https://github.com/ktnyt","followers_url":"https://api.github.com/users/ktnyt/followers","following_url":"https://api.github.com/users/ktnyt/following{/other_user}","gists_url":"https://api.github.com/users/ktnyt/gists{/gist_id}","starred_url":"https://api.github.com/users/ktnyt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktnyt/subscriptions","organizations_url":"https://api.github.com/users/ktnyt/orgs","repos_url":"https://api.github.com/users/ktnyt/repos","events_url":"https://api.github.com/users/ktnyt/events{/privacy}","received_events_url":"https://api.github.com/users/ktnyt/received_events","type":"User","site_admin":false},"repo":{"id":37119128,"node_id":"MDEwOlJlcG9zaXRvcnkzNzExOTEyOA==","name":"chainer","full_name":"ktnyt/chainer","private":false,"owner":{"login":"ktnyt","id":1581965,"node_id":"MDQ6VXNlcjE1ODE5NjU=","avatar_url":"https://avatars3.githubusercontent.com/u/1581965?v=4","gravatar_id":"","url":"https://api.github.com/users/ktnyt","html_url":"https://github.com/ktnyt","followers_url":"https://api.github.com/users/ktnyt/followers","following_url":"https://api.github.com/users/ktnyt/following{/other_user}","gists_url":"https://api.github.com/users/ktnyt/gists{/gist_id}","starred_url":"https://api.github.com/users/ktnyt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ktnyt/subscriptions","organizations_url":"https://api.github.com/users/ktnyt/orgs","repos_url":"https://api.github.com/users/ktnyt/repos","events_url":"https://api.github.com/users/ktnyt/events{/privacy}","received_events_url":"https://api.github.com/users/ktnyt/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ktnyt/chainer","description":"A flexible framework of neural networks","fork":true,"url":"https://api.github.com/repos/ktnyt/chainer","forks_url":"https://api.github.com/repos/ktnyt/chainer/forks","keys_url":"https://api.github.com/repos/ktnyt/chainer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ktnyt/chainer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ktnyt/chainer/teams","hooks_url":"https://api.github.com/repos/ktnyt/chainer/hooks","issue_events_url":"https://api.github.com/repos/ktnyt/chainer/issues/events{/number}","events_url":"https://api.github.com/repos/ktnyt/chainer/events","assignees_url":"https://api.github.com/repos/ktnyt/chainer/assignees{/user}","branches_url":"https://api.github.com/repos/ktnyt/chainer/branches{/branch}","tags_url":"https://api.github.com/repos/ktnyt/chainer/tags","blobs_url":"https://api.github.com/repos/ktnyt/chainer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ktnyt/chainer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ktnyt/chainer/git/refs{/sha}","trees_url":"https://api.github.com/repos/ktnyt/chainer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ktnyt/chainer/statuses/{sha}","languages_url":"https://api.github.com/repos/ktnyt/chainer/languages","stargazers_url":"https://api.github.com/repos/ktnyt/chainer/stargazers","contributors_url":"https://api.github.com/repos/ktnyt/chainer/contributors","subscribers_url":"https://api.github.com/repos/ktnyt/chainer/subscribers","subscription_url":"https://api.github.com/repos/ktnyt/chainer/subscription","commits_url":"https://api.github.com/repos/ktnyt/chainer/commits{/sha}","git_commits_url":"https://api.github.com/repos/ktnyt/chainer/git/commits{/sha}","comments_url":"https://api.github.com/repos/ktnyt/chainer/comments{/number}","issue_comment_url":"https://api.github.com/repos/ktnyt/chainer/issues/comments{/number}","contents_url":"https://api.github.com/repos/ktnyt/chainer/contents/{+path}","compare_url":"https://api.github.com/repos/ktnyt/chainer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ktnyt/chainer/merges","archive_url":"https://api.github.com/repos/ktnyt/chainer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ktnyt/chainer/downloads","issues_url":"https://api.github.com/repos/ktnyt/chainer/issues{/number}","pulls_url":"https://api.github.com/repos/ktnyt/chainer/pulls{/number}","milestones_url":"https://api.github.com/repos/ktnyt/chainer/milestones{/number}","notifications_url":"https://api.github.com/repos/ktnyt/chainer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ktnyt/chainer/labels{/name}","releases_url":"https://api.github.com/repos/ktnyt/chainer/releases{/id}","deployments_url":"https://api.github.com/repos/ktnyt/chainer/deployments","created_at":"2015-06-09T08:09:49Z","updated_at":"2018-12-13T09:20:44Z","pushed_at":"2018-12-19T11:46:31Z","git_url":"git://github.com/ktnyt/chainer.git","ssh_url":"git@github.com:ktnyt/chainer.git","clone_url":"https://github.com/ktnyt/chainer.git","svn_url":"https://github.com/ktnyt/chainer","homepage":"http://chainer.org","size":43255,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"chainer:master","ref":"master","sha":"612751c59cf570492aaa327914db79a5441f5dcc","user":{"login":"chainer","id":23183003,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTgzMDAz","avatar_url":"https://avatars3.githubusercontent.com/u/23183003?v=4","gravatar_id":"","url":"https://api.github.com/users/chainer","html_url":"https://github.com/chainer","followers_url":"https://api.github.com/users/chainer/followers","following_url":"https://api.github.com/users/chainer/following{/other_user}","gists_url":"https://api.github.com/users/chainer/gists{/gist_id}","starred_url":"https://api.github.com/users/chainer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chainer/subscriptions","organizations_url":"https://api.github.com/users/chainer/orgs","repos_url":"https://api.github.com/users/chainer/repos","events_url":"https://api.github.com/users/chainer/events{/privacy}","received_events_url":"https://api.github.com/users/chainer/received_events","type":"Organization","site_admin":false},"repo":{"id":36914478,"node_id":"MDEwOlJlcG9zaXRvcnkzNjkxNDQ3OA==","name":"chainer","full_name":"chainer/chainer","private":false,"owner":{"login":"chainer","id":23183003,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIzMTgzMDAz","avatar_url":"https://avatars3.githubusercontent.com/u/23183003?v=4","gravatar_id":"","url":"https://api.github.com/users/chainer","html_url":"https://github.com/chainer","followers_url":"https://api.github.com/users/chainer/followers","following_url":"https://api.github.com/users/chainer/following{/other_user}","gists_url":"https://api.github.com/users/chainer/gists{/gist_id}","starred_url":"https://api.github.com/users/chainer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chainer/subscriptions","organizations_url":"https://api.github.com/users/chainer/orgs","repos_url":"https://api.github.com/users/chainer/repos","events_url":"https://api.github.com/users/chainer/events{/privacy}","received_events_url":"https://api.github.com/users/chainer/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/chainer/chainer","description":"A flexible framework of neural networks for deep learning","fork":false,"url":"https://api.github.com/repos/chainer/chainer","forks_url":"https://api.github.com/repos/chainer/chainer/forks","keys_url":"https://api.github.com/repos/chainer/chainer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chainer/chainer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chainer/chainer/teams","hooks_url":"https://api.github.com/repos/chainer/chainer/hooks","issue_events_url":"https://api.github.com/repos/chainer/chainer/issues/events{/number}","events_url":"https://api.github.com/repos/chainer/chainer/events","assignees_url":"https://api.github.com/repos/chainer/chainer/assignees{/user}","branches_url":"https://api.github.com/repos/chainer/chainer/branches{/branch}","tags_url":"https://api.github.com/repos/chainer/chainer/tags","blobs_url":"https://api.github.com/repos/chainer/chainer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chainer/chainer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chainer/chainer/git/refs{/sha}","trees_url":"https://api.github.com/repos/chainer/chainer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chainer/chainer/statuses/{sha}","languages_url":"https://api.github.com/repos/chainer/chainer/languages","stargazers_url":"https://api.github.com/repos/chainer/chainer/stargazers","contributors_url":"https://api.github.com/repos/chainer/chainer/contributors","subscribers_url":"https://api.github.com/repos/chainer/chainer/subscribers","subscription_url":"https://api.github.com/repos/chainer/chainer/subscription","commits_url":"https://api.github.com/repos/chainer/chainer/commits{/sha}","git_commits_url":"https://api.github.com/repos/chainer/chainer/git/commits{/sha}","comments_url":"https://api.github.com/repos/chainer/chainer/comments{/number}","issue_comment_url":"https://api.github.com/repos/chainer/chainer/issues/comments{/number}","contents_url":"https://api.github.com/repos/chainer/chainer/contents/{+path}","compare_url":"https://api.github.com/repos/chainer/chainer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chainer/chainer/merges","archive_url":"https://api.github.com/repos/chainer/chainer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chainer/chainer/downloads","issues_url":"https://api.github.com/repos/chainer/chainer/issues{/number}","pulls_url":"https://api.github.com/repos/chainer/chainer/pulls{/number}","milestones_url":"https://api.github.com/repos/chainer/chainer/milestones{/number}","notifications_url":"https://api.github.com/repos/chainer/chainer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chainer/chainer/labels{/name}","releases_url":"https://api.github.com/repos/chainer/chainer/releases{/id}","deployments_url":"https://api.github.com/repos/chainer/chainer/deployments","created_at":"2015-06-05T05:50:37Z","updated_at":"2018-12-19T15:28:18Z","pushed_at":"2018-12-19T15:44:32Z","git_url":"git://github.com/chainer/chainer.git","ssh_url":"git@github.com:chainer/chainer.git","clone_url":"https://github.com/chainer/chainer.git","svn_url":"https://github.com/chainer/chainer","homepage":"https://chainer.org","size":40461,"stargazers_count":4391,"watchers_count":4391,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1167,"mirror_url":null,"archived":false,"open_issues_count":275,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1167,"open_issues":275,"watchers":4391,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/chainer/chainer/pulls/5776"},"html":{"href":"https://github.com/chainer/chainer/pull/5776"},"issue":{"href":"https://api.github.com/repos/chainer/chainer/issues/5776"},"comments":{"href":"https://api.github.com/repos/chainer/chainer/issues/5776/comments"},"review_comments":{"href":"https://api.github.com/repos/chainer/chainer/pulls/5776/comments"},"review_comment":{"href":"https://api.github.com/repos/chainer/chainer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/chainer/chainer/pulls/5776/commits"},"statuses":{"href":"https://api.github.com/repos/chainer/chainer/statuses/681259ab29d91bcbb08fa481847a5ec995c1c2dd"}},"author_association":"NONE"}}
{"actor":{"display_login":"hvy"}}