{"action":"created","comment":{"url":"https://api.github.com/repos/kata-containers/runtime/pulls/comments/218696835","pull_request_review_id":156689294,"id":218696835,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxODY5NjgzNQ==","diff_hunk":"@@ -128,7 +128,7 @@ func NewVM(ctx context.Context, config VMConfig) (*VM, error) {\n \t// 2. setup agent\n \tagent := newAgent(config.AgentType)\n \tvmSharePath := buildVMSharePath(id)\n-\terr = agent.configure(hypervisor, id, vmSharePath, isProxyBuiltIn(config.ProxyType), config.AgentConfig)","path":"virtcontainers/vm.go","position":4,"original_position":4,"commit_id":"09b17dc236987d25841945cbdbcf81c275fd7808","original_commit_id":"09b17dc236987d25841945cbdbcf81c275fd7808","user":{"login":"lifupan","id":14800035,"node_id":"MDQ6VXNlcjE0ODAwMDM1","avatar_url":"https://avatars3.githubusercontent.com/u/14800035?v=4","gravatar_id":"","url":"https://api.github.com/users/lifupan","html_url":"https://github.com/lifupan","followers_url":"https://api.github.com/users/lifupan/followers","following_url":"https://api.github.com/users/lifupan/following{/other_user}","gists_url":"https://api.github.com/users/lifupan/gists{/gist_id}","starred_url":"https://api.github.com/users/lifupan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lifupan/subscriptions","organizations_url":"https://api.github.com/users/lifupan/orgs","repos_url":"https://api.github.com/users/lifupan/repos","events_url":"https://api.github.com/users/lifupan/events{/privacy}","received_events_url":"https://api.github.com/users/lifupan/received_events","type":"User","site_admin":false},"body":"It seems the vm factory only needs to set the builtin flag in the configure() method and\r\nthe proxy url will be set in the following setProxy(), so what I should do is just remove the \r\nproxy url initialization to fix this issue?\r\n","created_at":"2018-09-19T07:37:44Z","updated_at":"2018-09-19T07:37:44Z","html_url":"https://github.com/kata-containers/runtime/pull/757#discussion_r218696835","pull_request_url":"https://api.github.com/repos/kata-containers/runtime/pulls/757","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kata-containers/runtime/pulls/comments/218696835"},"html":{"href":"https://github.com/kata-containers/runtime/pull/757#discussion_r218696835"},"pull_request":{"href":"https://api.github.com/repos/kata-containers/runtime/pulls/757"}},"in_reply_to_id":218690937},"pull_request":{"url":"https://api.github.com/repos/kata-containers/runtime/pulls/757","id":216534328,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2NTM0MzI4","html_url":"https://github.com/kata-containers/runtime/pull/757","diff_url":"https://github.com/kata-containers/runtime/pull/757.diff","patch_url":"https://github.com/kata-containers/runtime/pull/757.patch","issue_url":"https://api.github.com/repos/kata-containers/runtime/issues/757","number":757,"state":"open","locked":false,"title":"virtcontainers: fix the issue of missing starting builtin proxy","user":{"login":"lifupan","id":14800035,"node_id":"MDQ6VXNlcjE0ODAwMDM1","avatar_url":"https://avatars3.githubusercontent.com/u/14800035?v=4","gravatar_id":"","url":"https://api.github.com/users/lifupan","html_url":"https://github.com/lifupan","followers_url":"https://api.github.com/users/lifupan/followers","following_url":"https://api.github.com/users/lifupan/following{/other_user}","gists_url":"https://api.github.com/users/lifupan/gists{/gist_id}","starred_url":"https://api.github.com/users/lifupan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lifupan/subscriptions","organizations_url":"https://api.github.com/users/lifupan/orgs","repos_url":"https://api.github.com/users/lifupan/repos","events_url":"https://api.github.com/users/lifupan/events{/privacy}","received_events_url":"https://api.github.com/users/lifupan/received_events","type":"User","site_admin":false},"body":"It shouldn't set kataAgent.state.URL in its configure() method\r\nfor builtin kata proxy, otherwise the following check of whether\r\nis it nil in startProxy() will return directly and failed to\r\nstart builtin proxy which will log the qemu's console.\r\n\r\nIn addition, the kataAgent.proxyBuiltIn has been initialized\r\nin its init() method, thus there is no need to reinitialized\r\nin configure() method.\r\n\r\nFixes: #756\r\n\r\nSigned-off-by: fupan <lifupan@gmail.com>","created_at":"2018-09-19T07:04:29Z","updated_at":"2018-09-19T07:37:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"348b5b4f6e55cee6e7eb2cde4488b69e3b476f93","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kata-containers/runtime/pulls/757/commits","review_comments_url":"https://api.github.com/repos/kata-containers/runtime/pulls/757/comments","review_comment_url":"https://api.github.com/repos/kata-containers/runtime/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kata-containers/runtime/issues/757/comments","statuses_url":"https://api.github.com/repos/kata-containers/runtime/statuses/09b17dc236987d25841945cbdbcf81c275fd7808","head":{"label":"lifupan:fixbuiltinproxy","ref":"fixbuiltinproxy","sha":"09b17dc236987d25841945cbdbcf81c275fd7808","user":{"login":"lifupan","id":14800035,"node_id":"MDQ6VXNlcjE0ODAwMDM1","avatar_url":"https://avatars3.githubusercontent.com/u/14800035?v=4","gravatar_id":"","url":"https://api.github.com/users/lifupan","html_url":"https://github.com/lifupan","followers_url":"https://api.github.com/users/lifupan/followers","following_url":"https://api.github.com/users/lifupan/following{/other_user}","gists_url":"https://api.github.com/users/lifupan/gists{/gist_id}","starred_url":"https://api.github.com/users/lifupan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lifupan/subscriptions","organizations_url":"https://api.github.com/users/lifupan/orgs","repos_url":"https://api.github.com/users/lifupan/repos","events_url":"https://api.github.com/users/lifupan/events{/privacy}","received_events_url":"https://api.github.com/users/lifupan/received_events","type":"User","site_admin":false},"repo":{"id":143377327,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMzNzczMjc=","name":"kata-runtime","full_name":"lifupan/kata-runtime","private":false,"owner":{"login":"lifupan","id":14800035,"node_id":"MDQ6VXNlcjE0ODAwMDM1","avatar_url":"https://avatars3.githubusercontent.com/u/14800035?v=4","gravatar_id":"","url":"https://api.github.com/users/lifupan","html_url":"https://github.com/lifupan","followers_url":"https://api.github.com/users/lifupan/followers","following_url":"https://api.github.com/users/lifupan/following{/other_user}","gists_url":"https://api.github.com/users/lifupan/gists{/gist_id}","starred_url":"https://api.github.com/users/lifupan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lifupan/subscriptions","organizations_url":"https://api.github.com/users/lifupan/orgs","repos_url":"https://api.github.com/users/lifupan/repos","events_url":"https://api.github.com/users/lifupan/events{/privacy}","received_events_url":"https://api.github.com/users/lifupan/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lifupan/kata-runtime","description":"Kata Containers runtime","fork":true,"url":"https://api.github.com/repos/lifupan/kata-runtime","forks_url":"https://api.github.com/repos/lifupan/kata-runtime/forks","keys_url":"https://api.github.com/repos/lifupan/kata-runtime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lifupan/kata-runtime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lifupan/kata-runtime/teams","hooks_url":"https://api.github.com/repos/lifupan/kata-runtime/hooks","issue_events_url":"https://api.github.com/repos/lifupan/kata-runtime/issues/events{/number}","events_url":"https://api.github.com/repos/lifupan/kata-runtime/events","assignees_url":"https://api.github.com/repos/lifupan/kata-runtime/assignees{/user}","branches_url":"https://api.github.com/repos/lifupan/kata-runtime/branches{/branch}","tags_url":"https://api.github.com/repos/lifupan/kata-runtime/tags","blobs_url":"https://api.github.com/repos/lifupan/kata-runtime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lifupan/kata-runtime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lifupan/kata-runtime/git/refs{/sha}","trees_url":"https://api.github.com/repos/lifupan/kata-runtime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lifupan/kata-runtime/statuses/{sha}","languages_url":"https://api.github.com/repos/lifupan/kata-runtime/languages","stargazers_url":"https://api.github.com/repos/lifupan/kata-runtime/stargazers","contributors_url":"https://api.github.com/repos/lifupan/kata-runtime/contributors","subscribers_url":"https://api.github.com/repos/lifupan/kata-runtime/subscribers","subscription_url":"https://api.github.com/repos/lifupan/kata-runtime/subscription","commits_url":"https://api.github.com/repos/lifupan/kata-runtime/commits{/sha}","git_commits_url":"https://api.github.com/repos/lifupan/kata-runtime/git/commits{/sha}","comments_url":"https://api.github.com/repos/lifupan/kata-runtime/comments{/number}","issue_comment_url":"https://api.github.com/repos/lifupan/kata-runtime/issues/comments{/number}","contents_url":"https://api.github.com/repos/lifupan/kata-runtime/contents/{+path}","compare_url":"https://api.github.com/repos/lifupan/kata-runtime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lifupan/kata-runtime/merges","archive_url":"https://api.github.com/repos/lifupan/kata-runtime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lifupan/kata-runtime/downloads","issues_url":"https://api.github.com/repos/lifupan/kata-runtime/issues{/number}","pulls_url":"https://api.github.com/repos/lifupan/kata-runtime/pulls{/number}","milestones_url":"https://api.github.com/repos/lifupan/kata-runtime/milestones{/number}","notifications_url":"https://api.github.com/repos/lifupan/kata-runtime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lifupan/kata-runtime/labels{/name}","releases_url":"https://api.github.com/repos/lifupan/kata-runtime/releases{/id}","deployments_url":"https://api.github.com/repos/lifupan/kata-runtime/deployments","created_at":"2018-08-03T04:23:46Z","updated_at":"2018-08-15T09:28:29Z","pushed_at":"2018-09-19T07:10:00Z","git_url":"git://github.com/lifupan/kata-runtime.git","ssh_url":"git@github.com:lifupan/kata-runtime.git","clone_url":"https://github.com/lifupan/kata-runtime.git","svn_url":"https://github.com/lifupan/kata-runtime","homepage":"","size":5174,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kata-containers:master","ref":"master","sha":"a8284f875bd74d0a4a0dc3c4f9fbceb395b0e949","user":{"login":"kata-containers","id":33289952,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMjg5OTUy","avatar_url":"https://avatars3.githubusercontent.com/u/33289952?v=4","gravatar_id":"","url":"https://api.github.com/users/kata-containers","html_url":"https://github.com/kata-containers","followers_url":"https://api.github.com/users/kata-containers/followers","following_url":"https://api.github.com/users/kata-containers/following{/other_user}","gists_url":"https://api.github.com/users/kata-containers/gists{/gist_id}","starred_url":"https://api.github.com/users/kata-containers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kata-containers/subscriptions","organizations_url":"https://api.github.com/users/kata-containers/orgs","repos_url":"https://api.github.com/users/kata-containers/repos","events_url":"https://api.github.com/users/kata-containers/events{/privacy}","received_events_url":"https://api.github.com/users/kata-containers/received_events","type":"Organization","site_admin":false},"repo":{"id":110539997,"node_id":"MDEwOlJlcG9zaXRvcnkxMTA1Mzk5OTc=","name":"runtime","full_name":"kata-containers/runtime","private":false,"owner":{"login":"kata-containers","id":33289952,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMzMjg5OTUy","avatar_url":"https://avatars3.githubusercontent.com/u/33289952?v=4","gravatar_id":"","url":"https://api.github.com/users/kata-containers","html_url":"https://github.com/kata-containers","followers_url":"https://api.github.com/users/kata-containers/followers","following_url":"https://api.github.com/users/kata-containers/following{/other_user}","gists_url":"https://api.github.com/users/kata-containers/gists{/gist_id}","starred_url":"https://api.github.com/users/kata-containers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kata-containers/subscriptions","organizations_url":"https://api.github.com/users/kata-containers/orgs","repos_url":"https://api.github.com/users/kata-containers/repos","events_url":"https://api.github.com/users/kata-containers/events{/privacy}","received_events_url":"https://api.github.com/users/kata-containers/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kata-containers/runtime","description":"Kata Containers runtime","fork":false,"url":"https://api.github.com/repos/kata-containers/runtime","forks_url":"https://api.github.com/repos/kata-containers/runtime/forks","keys_url":"https://api.github.com/repos/kata-containers/runtime/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kata-containers/runtime/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kata-containers/runtime/teams","hooks_url":"https://api.github.com/repos/kata-containers/runtime/hooks","issue_events_url":"https://api.github.com/repos/kata-containers/runtime/issues/events{/number}","events_url":"https://api.github.com/repos/kata-containers/runtime/events","assignees_url":"https://api.github.com/repos/kata-containers/runtime/assignees{/user}","branches_url":"https://api.github.com/repos/kata-containers/runtime/branches{/branch}","tags_url":"https://api.github.com/repos/kata-containers/runtime/tags","blobs_url":"https://api.github.com/repos/kata-containers/runtime/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kata-containers/runtime/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kata-containers/runtime/git/refs{/sha}","trees_url":"https://api.github.com/repos/kata-containers/runtime/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kata-containers/runtime/statuses/{sha}","languages_url":"https://api.github.com/repos/kata-containers/runtime/languages","stargazers_url":"https://api.github.com/repos/kata-containers/runtime/stargazers","contributors_url":"https://api.github.com/repos/kata-containers/runtime/contributors","subscribers_url":"https://api.github.com/repos/kata-containers/runtime/subscribers","subscription_url":"https://api.github.com/repos/kata-containers/runtime/subscription","commits_url":"https://api.github.com/repos/kata-containers/runtime/commits{/sha}","git_commits_url":"https://api.github.com/repos/kata-containers/runtime/git/commits{/sha}","comments_url":"https://api.github.com/repos/kata-containers/runtime/comments{/number}","issue_comment_url":"https://api.github.com/repos/kata-containers/runtime/issues/comments{/number}","contents_url":"https://api.github.com/repos/kata-containers/runtime/contents/{+path}","compare_url":"https://api.github.com/repos/kata-containers/runtime/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kata-containers/runtime/merges","archive_url":"https://api.github.com/repos/kata-containers/runtime/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kata-containers/runtime/downloads","issues_url":"https://api.github.com/repos/kata-containers/runtime/issues{/number}","pulls_url":"https://api.github.com/repos/kata-containers/runtime/pulls{/number}","milestones_url":"https://api.github.com/repos/kata-containers/runtime/milestones{/number}","notifications_url":"https://api.github.com/repos/kata-containers/runtime/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kata-containers/runtime/labels{/name}","releases_url":"https://api.github.com/repos/kata-containers/runtime/releases{/id}","deployments_url":"https://api.github.com/repos/kata-containers/runtime/deployments","created_at":"2017-11-13T11:29:03Z","updated_at":"2018-09-19T07:32:46Z","pushed_at":"2018-09-19T07:32:43Z","git_url":"git://github.com/kata-containers/runtime.git","ssh_url":"git@github.com:kata-containers/runtime.git","clone_url":"https://github.com/kata-containers/runtime.git","svn_url":"https://github.com/kata-containers/runtime","homepage":"","size":5226,"stargazers_count":506,"watchers_count":506,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":109,"mirror_url":null,"archived":false,"open_issues_count":172,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":109,"open_issues":172,"watchers":506,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kata-containers/runtime/pulls/757"},"html":{"href":"https://github.com/kata-containers/runtime/pull/757"},"issue":{"href":"https://api.github.com/repos/kata-containers/runtime/issues/757"},"comments":{"href":"https://api.github.com/repos/kata-containers/runtime/issues/757/comments"},"review_comments":{"href":"https://api.github.com/repos/kata-containers/runtime/pulls/757/comments"},"review_comment":{"href":"https://api.github.com/repos/kata-containers/runtime/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kata-containers/runtime/pulls/757/commits"},"statuses":{"href":"https://api.github.com/repos/kata-containers/runtime/statuses/09b17dc236987d25841945cbdbcf81c275fd7808"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"lifupan"}}