{"action":"created","issue":{"url":"https://api.github.com/repos/helm/charts/issues/7116","repository_url":"https://api.github.com/repos/helm/charts","labels_url":"https://api.github.com/repos/helm/charts/issues/7116/labels{/name}","comments_url":"https://api.github.com/repos/helm/charts/issues/7116/comments","events_url":"https://api.github.com/repos/helm/charts/issues/7116/events","html_url":"https://github.com/helm/charts/pull/7116","id":349328188,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NDcyNDk4","number":7116,"title":"[stable/prometheus]: add optional Prometheus StatefulSets","user":{"login":"giacomoguiulfo","id":22091600,"node_id":"MDQ6VXNlcjIyMDkxNjAw","avatar_url":"https://avatars1.githubusercontent.com/u/22091600?v=4","gravatar_id":"","url":"https://api.github.com/users/giacomoguiulfo","html_url":"https://github.com/giacomoguiulfo","followers_url":"https://api.github.com/users/giacomoguiulfo/followers","following_url":"https://api.github.com/users/giacomoguiulfo/following{/other_user}","gists_url":"https://api.github.com/users/giacomoguiulfo/gists{/gist_id}","starred_url":"https://api.github.com/users/giacomoguiulfo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giacomoguiulfo/subscriptions","organizations_url":"https://api.github.com/users/giacomoguiulfo/orgs","repos_url":"https://api.github.com/users/giacomoguiulfo/repos","events_url":"https://api.github.com/users/giacomoguiulfo/events{/privacy}","received_events_url":"https://api.github.com/users/giacomoguiulfo/received_events","type":"User","site_admin":false},"labels":[{"id":1037076588,"node_id":"MDU6TGFiZWwxMDM3MDc2NTg4","url":"https://api.github.com/repos/helm/charts/labels/Contribution%20Allowed","name":"Contribution Allowed","color":"3df47d","default":false},{"id":484586588,"node_id":"MDU6TGFiZWw0ODQ1ODY1ODg=","url":"https://api.github.com/repos/helm/charts/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":676596499,"node_id":"MDU6TGFiZWw2NzY1OTY0OTk=","url":"https://api.github.com/repos/helm/charts/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":{"login":"mgoodness","id":2781657,"node_id":"MDQ6VXNlcjI3ODE2NTc=","avatar_url":"https://avatars0.githubusercontent.com/u/2781657?v=4","gravatar_id":"","url":"https://api.github.com/users/mgoodness","html_url":"https://github.com/mgoodness","followers_url":"https://api.github.com/users/mgoodness/followers","following_url":"https://api.github.com/users/mgoodness/following{/other_user}","gists_url":"https://api.github.com/users/mgoodness/gists{/gist_id}","starred_url":"https://api.github.com/users/mgoodness/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgoodness/subscriptions","organizations_url":"https://api.github.com/users/mgoodness/orgs","repos_url":"https://api.github.com/users/mgoodness/repos","events_url":"https://api.github.com/users/mgoodness/events{/privacy}","received_events_url":"https://api.github.com/users/mgoodness/received_events","type":"User","site_admin":false},"assignees":[{"login":"unguiculus","id":925412,"node_id":"MDQ6VXNlcjkyNTQxMg==","avatar_url":"https://avatars1.githubusercontent.com/u/925412?v=4","gravatar_id":"","url":"https://api.github.com/users/unguiculus","html_url":"https://github.com/unguiculus","followers_url":"https://api.github.com/users/unguiculus/followers","following_url":"https://api.github.com/users/unguiculus/following{/other_user}","gists_url":"https://api.github.com/users/unguiculus/gists{/gist_id}","starred_url":"https://api.github.com/users/unguiculus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unguiculus/subscriptions","organizations_url":"https://api.github.com/users/unguiculus/orgs","repos_url":"https://api.github.com/users/unguiculus/repos","events_url":"https://api.github.com/users/unguiculus/events{/privacy}","received_events_url":"https://api.github.com/users/unguiculus/received_events","type":"User","site_admin":false},{"login":"mgoodness","id":2781657,"node_id":"MDQ6VXNlcjI3ODE2NTc=","avatar_url":"https://avatars0.githubusercontent.com/u/2781657?v=4","gravatar_id":"","url":"https://api.github.com/users/mgoodness","html_url":"https://github.com/mgoodness","followers_url":"https://api.github.com/users/mgoodness/followers","following_url":"https://api.github.com/users/mgoodness/following{/other_user}","gists_url":"https://api.github.com/users/mgoodness/gists{/gist_id}","starred_url":"https://api.github.com/users/mgoodness/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgoodness/subscriptions","organizations_url":"https://api.github.com/users/mgoodness/orgs","repos_url":"https://api.github.com/users/mgoodness/repos","events_url":"https://api.github.com/users/mgoodness/events{/privacy}","received_events_url":"https://api.github.com/users/mgoodness/received_events","type":"User","site_admin":false}],"milestone":null,"comments":25,"created_at":"2018-08-09T23:42:20Z","updated_at":"2018-11-13T18:06:25Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/helm/charts/pulls/7116","html_url":"https://github.com/helm/charts/pull/7116","diff_url":"https://github.com/helm/charts/pull/7116.diff","patch_url":"https://github.com/helm/charts/pull/7116.patch"},"body":"<!--\r\nThank you for contributing to kubernetes/charts. Before you submit this PR we'd like to\r\nmake sure you are aware of our technical requirements and best practices:\r\n\r\n* https://github.com/kubernetes/charts/blob/master/CONTRIBUTING.md#technical-requirements\r\n* https://github.com/kubernetes/helm/tree/master/docs/chart_best_practices\r\n\r\nFor a quick overview across what we will look at reviewing your PR, please read\r\nour review guidelines:\r\n\r\n* https://github.com/kubernetes/charts/blob/master/REVIEW_GUIDELINES.md\r\n\r\nFollowing our best practices right from the start will accelerate the review process and\r\nhelp get your PR merged quicker.\r\n\r\nWhen updates to your PR are requested, please add new commits and do not squash the\r\nhistory. This will make it easier to identify new changes. The PR will be squashed\r\nanyways when it is merged. Thanks.\r\n\r\nFor fast feedback, please @-mention maintainers that are listed in the Chart.yaml file.\r\n\r\nPlease make sure you test your changes before you push them. Once pushed, a CircleCI\r\nwill run across your changes and do some initial checks and linting. These checks run\r\nvery quickly. Please check the results. We would like these checks to pass before we\r\neven continue reviewing your changes.\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n\r\nCurrently, the Prometheus chart uses Deployments to manage its server and alertmanager pods, and each one of them can be configured to use Persistent Volume Claims. However, it is bad practice (in this case, not always) to use Deployments to manage pods that deal with PVCs (#1863) because it might prevent them from having more than 1 replica (again, this is the case for Prometheus). Also, when deployments are deleted, (by default) the `PVCs` are automatically deleted with it. With statefulsets this doesn't happen (which is better if data wants to be persisted).\r\n\r\nThis PR updates the chart to use StatefulSets instead of Deployments to manage the Prometheus server and alertmanager pods. \r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*:\r\n\r\nfixes #2346.\r\nfixes #8026.\r\nfixes #5115."},"comment":{"url":"https://api.github.com/repos/helm/charts/issues/comments/438376272","html_url":"https://github.com/helm/charts/pull/7116#issuecomment-438376272","issue_url":"https://api.github.com/repos/helm/charts/issues/7116","id":438376272,"node_id":"MDEyOklzc3VlQ29tbWVudDQzODM3NjI3Mg==","user":{"login":"giacomoguiulfo","id":22091600,"node_id":"MDQ6VXNlcjIyMDkxNjAw","avatar_url":"https://avatars1.githubusercontent.com/u/22091600?v=4","gravatar_id":"","url":"https://api.github.com/users/giacomoguiulfo","html_url":"https://github.com/giacomoguiulfo","followers_url":"https://api.github.com/users/giacomoguiulfo/followers","following_url":"https://api.github.com/users/giacomoguiulfo/following{/other_user}","gists_url":"https://api.github.com/users/giacomoguiulfo/gists{/gist_id}","starred_url":"https://api.github.com/users/giacomoguiulfo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giacomoguiulfo/subscriptions","organizations_url":"https://api.github.com/users/giacomoguiulfo/orgs","repos_url":"https://api.github.com/users/giacomoguiulfo/repos","events_url":"https://api.github.com/users/giacomoguiulfo/events{/privacy}","received_events_url":"https://api.github.com/users/giacomoguiulfo/received_events","type":"User","site_admin":false},"created_at":"2018-11-13T18:06:25Z","updated_at":"2018-11-13T18:06:25Z","author_association":"CONTRIBUTOR","body":"@gianrubio @unguiculus Any chance this can get in? Is there something else to work on? Thanks!"}}
{"actor":{"display_login":"giacomoguiulfo"}}