{"action":"created","comment":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/comments/244545145","pull_request_review_id":188450491,"id":244545145,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDU0NTE0NQ==","diff_hunk":"@@ -51,21 +51,69 @@ pub(super) struct NodeCollector<'a, 'hir> {\n \n     // We are collecting DepNode::HirBody hashes here so we can compute the\n     // crate hash from then later on.\n-    hir_body_nodes: Vec<(DefPathHash, DepNodeIndex)>,\n+    hir_body_nodes: Vec<(DefPathHash, Fingerprint)>,\n+}\n+\n+fn input_dep_node_and_hash<'a, I>(\n+    dep_graph: &DepGraph,\n+    hcx: &mut StableHashingContext<'a>,\n+    def_node: DepNode,","path":"src/librustc/hir/map/collector.rs","position":11,"original_position":11,"commit_id":"e2e471e0090b1d98bb0915945064f021306259a9","original_commit_id":"e2e471e0090b1d98bb0915945064f021306259a9","user":{"login":"michaelwoerister","id":1825894,"node_id":"MDQ6VXNlcjE4MjU4OTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1825894?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelwoerister","html_url":"https://github.com/michaelwoerister","followers_url":"https://api.github.com/users/michaelwoerister/followers","following_url":"https://api.github.com/users/michaelwoerister/following{/other_user}","gists_url":"https://api.github.com/users/michaelwoerister/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelwoerister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelwoerister/subscriptions","organizations_url":"https://api.github.com/users/michaelwoerister/orgs","repos_url":"https://api.github.com/users/michaelwoerister/repos","events_url":"https://api.github.com/users/michaelwoerister/events{/privacy}","received_events_url":"https://api.github.com/users/michaelwoerister/received_events","type":"User","site_admin":false},"body":"This should be `dep_node` I guess?","created_at":"2018-12-30T21:04:05Z","updated_at":"2018-12-30T21:43:13Z","html_url":"https://github.com/rust-lang/rust/pull/57061#discussion_r244545145","pull_request_url":"https://api.github.com/repos/rust-lang/rust/pulls/57061","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments/244545145"},"html":{"href":"https://github.com/rust-lang/rust/pull/57061#discussion_r244545145"},"pull_request":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/57061"}}},"pull_request":{"url":"https://api.github.com/repos/rust-lang/rust/pulls/57061","id":240633393,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwNjMzMzkz","html_url":"https://github.com/rust-lang/rust/pull/57061","diff_url":"https://github.com/rust-lang/rust/pull/57061.diff","patch_url":"https://github.com/rust-lang/rust/pull/57061.patch","issue_url":"https://api.github.com/repos/rust-lang/rust/issues/57061","number":57061,"state":"open","locked":false,"title":"Group dep node data into a single structure","user":{"login":"Zoxc","id":25784,"node_id":"MDQ6VXNlcjI1Nzg0","avatar_url":"https://avatars3.githubusercontent.com/u/25784?v=4","gravatar_id":"","url":"https://api.github.com/users/Zoxc","html_url":"https://github.com/Zoxc","followers_url":"https://api.github.com/users/Zoxc/followers","following_url":"https://api.github.com/users/Zoxc/following{/other_user}","gists_url":"https://api.github.com/users/Zoxc/gists{/gist_id}","starred_url":"https://api.github.com/users/Zoxc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zoxc/subscriptions","organizations_url":"https://api.github.com/users/Zoxc/orgs","repos_url":"https://api.github.com/users/Zoxc/repos","events_url":"https://api.github.com/users/Zoxc/events{/privacy}","received_events_url":"https://api.github.com/users/Zoxc/received_events","type":"User","site_admin":false},"body":"r? @michaelwoerister","created_at":"2018-12-22T12:51:35Z","updated_at":"2018-12-30T21:43:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b0eb2120b4ee8ef6ddd3a96304d259f734f8af01","assignee":{"login":"michaelwoerister","id":1825894,"node_id":"MDQ6VXNlcjE4MjU4OTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1825894?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelwoerister","html_url":"https://github.com/michaelwoerister","followers_url":"https://api.github.com/users/michaelwoerister/followers","following_url":"https://api.github.com/users/michaelwoerister/following{/other_user}","gists_url":"https://api.github.com/users/michaelwoerister/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelwoerister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelwoerister/subscriptions","organizations_url":"https://api.github.com/users/michaelwoerister/orgs","repos_url":"https://api.github.com/users/michaelwoerister/repos","events_url":"https://api.github.com/users/michaelwoerister/events{/privacy}","received_events_url":"https://api.github.com/users/michaelwoerister/received_events","type":"User","site_admin":false},"assignees":[{"login":"michaelwoerister","id":1825894,"node_id":"MDQ6VXNlcjE4MjU4OTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1825894?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelwoerister","html_url":"https://github.com/michaelwoerister","followers_url":"https://api.github.com/users/michaelwoerister/followers","following_url":"https://api.github.com/users/michaelwoerister/following{/other_user}","gists_url":"https://api.github.com/users/michaelwoerister/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelwoerister/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelwoerister/subscriptions","organizations_url":"https://api.github.com/users/michaelwoerister/orgs","repos_url":"https://api.github.com/users/michaelwoerister/repos","events_url":"https://api.github.com/users/michaelwoerister/events{/privacy}","received_events_url":"https://api.github.com/users/michaelwoerister/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":583426710,"node_id":"MDU6TGFiZWw1ODM0MjY3MTA=","url":"https://api.github.com/repos/rust-lang/rust/labels/S-waiting-on-review","name":"S-waiting-on-review","color":"d3dddd","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang/rust/pulls/57061/commits","review_comments_url":"https://api.github.com/repos/rust-lang/rust/pulls/57061/comments","review_comment_url":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/rust/issues/57061/comments","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/e2e471e0090b1d98bb0915945064f021306259a9","head":{"label":"Zoxc:graph-refactor","ref":"graph-refactor","sha":"e2e471e0090b1d98bb0915945064f021306259a9","user":{"login":"Zoxc","id":25784,"node_id":"MDQ6VXNlcjI1Nzg0","avatar_url":"https://avatars3.githubusercontent.com/u/25784?v=4","gravatar_id":"","url":"https://api.github.com/users/Zoxc","html_url":"https://github.com/Zoxc","followers_url":"https://api.github.com/users/Zoxc/followers","following_url":"https://api.github.com/users/Zoxc/following{/other_user}","gists_url":"https://api.github.com/users/Zoxc/gists{/gist_id}","starred_url":"https://api.github.com/users/Zoxc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zoxc/subscriptions","organizations_url":"https://api.github.com/users/Zoxc/orgs","repos_url":"https://api.github.com/users/Zoxc/repos","events_url":"https://api.github.com/users/Zoxc/events{/privacy}","received_events_url":"https://api.github.com/users/Zoxc/received_events","type":"User","site_admin":false},"repo":{"id":21868454,"node_id":"MDEwOlJlcG9zaXRvcnkyMTg2ODQ1NA==","name":"rust","full_name":"Zoxc/rust","private":false,"owner":{"login":"Zoxc","id":25784,"node_id":"MDQ6VXNlcjI1Nzg0","avatar_url":"https://avatars3.githubusercontent.com/u/25784?v=4","gravatar_id":"","url":"https://api.github.com/users/Zoxc","html_url":"https://github.com/Zoxc","followers_url":"https://api.github.com/users/Zoxc/followers","following_url":"https://api.github.com/users/Zoxc/following{/other_user}","gists_url":"https://api.github.com/users/Zoxc/gists{/gist_id}","starred_url":"https://api.github.com/users/Zoxc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Zoxc/subscriptions","organizations_url":"https://api.github.com/users/Zoxc/orgs","repos_url":"https://api.github.com/users/Zoxc/repos","events_url":"https://api.github.com/users/Zoxc/events{/privacy}","received_events_url":"https://api.github.com/users/Zoxc/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Zoxc/rust","description":"a safe, concurrent, practical language","fork":true,"url":"https://api.github.com/repos/Zoxc/rust","forks_url":"https://api.github.com/repos/Zoxc/rust/forks","keys_url":"https://api.github.com/repos/Zoxc/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Zoxc/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Zoxc/rust/teams","hooks_url":"https://api.github.com/repos/Zoxc/rust/hooks","issue_events_url":"https://api.github.com/repos/Zoxc/rust/issues/events{/number}","events_url":"https://api.github.com/repos/Zoxc/rust/events","assignees_url":"https://api.github.com/repos/Zoxc/rust/assignees{/user}","branches_url":"https://api.github.com/repos/Zoxc/rust/branches{/branch}","tags_url":"https://api.github.com/repos/Zoxc/rust/tags","blobs_url":"https://api.github.com/repos/Zoxc/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Zoxc/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Zoxc/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/Zoxc/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Zoxc/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/Zoxc/rust/languages","stargazers_url":"https://api.github.com/repos/Zoxc/rust/stargazers","contributors_url":"https://api.github.com/repos/Zoxc/rust/contributors","subscribers_url":"https://api.github.com/repos/Zoxc/rust/subscribers","subscription_url":"https://api.github.com/repos/Zoxc/rust/subscription","commits_url":"https://api.github.com/repos/Zoxc/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/Zoxc/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/Zoxc/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/Zoxc/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/Zoxc/rust/contents/{+path}","compare_url":"https://api.github.com/repos/Zoxc/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Zoxc/rust/merges","archive_url":"https://api.github.com/repos/Zoxc/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Zoxc/rust/downloads","issues_url":"https://api.github.com/repos/Zoxc/rust/issues{/number}","pulls_url":"https://api.github.com/repos/Zoxc/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/Zoxc/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/Zoxc/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Zoxc/rust/labels{/name}","releases_url":"https://api.github.com/repos/Zoxc/rust/releases{/id}","deployments_url":"https://api.github.com/repos/Zoxc/rust/deployments","created_at":"2014-07-15T17:08:44Z","updated_at":"2018-11-27T09:59:48Z","pushed_at":"2018-12-30T21:09:50Z","git_url":"git://github.com/Zoxc/rust.git","ssh_url":"git@github.com:Zoxc/rust.git","clone_url":"https://github.com/Zoxc/rust.git","svn_url":"https://github.com/Zoxc/rust","homepage":"http://www.rust-lang.org","size":408545,"stargazers_count":1,"watchers_count":1,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"9689ada83891f63164bf117af35cc0abc37daaf1","user":{"login":"rust-lang","id":5430905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MzA5MDU=","avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":724712,"node_id":"MDEwOlJlcG9zaXRvcnk3MjQ3MTI=","name":"rust","full_name":"rust-lang/rust","private":false,"owner":{"login":"rust-lang","id":5430905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MzA5MDU=","avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rust-lang/rust","description":"Empowering everyone to build reliable and efficient software.","fork":false,"url":"https://api.github.com/repos/rust-lang/rust","forks_url":"https://api.github.com/repos/rust-lang/rust/forks","keys_url":"https://api.github.com/repos/rust-lang/rust/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/rust/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/rust/teams","hooks_url":"https://api.github.com/repos/rust-lang/rust/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/rust/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/rust/events","assignees_url":"https://api.github.com/repos/rust-lang/rust/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/rust/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/rust/tags","blobs_url":"https://api.github.com/repos/rust-lang/rust/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/rust/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/rust/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/rust/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/rust/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/rust/languages","stargazers_url":"https://api.github.com/repos/rust-lang/rust/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/rust/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/rust/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/rust/subscription","commits_url":"https://api.github.com/repos/rust-lang/rust/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/rust/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/rust/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/rust/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/rust/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/rust/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/rust/merges","archive_url":"https://api.github.com/repos/rust-lang/rust/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/rust/downloads","issues_url":"https://api.github.com/repos/rust-lang/rust/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/rust/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/rust/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/rust/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/rust/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/rust/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/rust/deployments","created_at":"2010-06-16T20:39:03Z","updated_at":"2018-12-30T21:37:32Z","pushed_at":"2018-12-30T21:37:13Z","git_url":"git://github.com/rust-lang/rust.git","ssh_url":"git@github.com:rust-lang/rust.git","clone_url":"https://github.com/rust-lang/rust.git","svn_url":"https://github.com/rust-lang/rust","homepage":"https://www.rust-lang.org","size":412450,"stargazers_count":32790,"watchers_count":32790,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5422,"mirror_url":null,"archived":false,"open_issues_count":4742,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5422,"open_issues":4742,"watchers":32790,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/57061"},"html":{"href":"https://github.com/rust-lang/rust/pull/57061"},"issue":{"href":"https://api.github.com/repos/rust-lang/rust/issues/57061"},"comments":{"href":"https://api.github.com/repos/rust-lang/rust/issues/57061/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/57061/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/rust/pulls/57061/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/rust/statuses/e2e471e0090b1d98bb0915945064f021306259a9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"michaelwoerister"}}