{"action":"created","comment":{"url":"https://api.github.com/repos/spdx/tools-python/pulls/comments/172112086","pull_request_review_id":101073201,"id":172112086,"diff_hunk":"@@ -188,7 +188,7 @@ def test_write_document_tv_with_validate(self):\n         try:\n             temp_dir = tempfile.mkdtemp(prefix='test_spdx')\n             result_file = os.path.join(temp_dir, 'spdx-simple.tv')\n-            with open(result_file, 'wb') as output:\n+            with open(result_file, 'w') as output:","path":"tests/test_document.py","position":5,"original_position":5,"commit_id":"b13408ac71d693a15c63ab6c27228dd36c4ae915","original_commit_id":"6fecae34297a4de11a93d041ed74650c1abf7be3","user":{"login":"sschuberth","id":349154,"avatar_url":"https://avatars0.githubusercontent.com/u/349154?v=4","gravatar_id":"","url":"https://api.github.com/users/sschuberth","html_url":"https://github.com/sschuberth","followers_url":"https://api.github.com/users/sschuberth/followers","following_url":"https://api.github.com/users/sschuberth/following{/other_user}","gists_url":"https://api.github.com/users/sschuberth/gists{/gist_id}","starred_url":"https://api.github.com/users/sschuberth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sschuberth/subscriptions","organizations_url":"https://api.github.com/users/sschuberth/orgs","repos_url":"https://api.github.com/users/sschuberth/repos","events_url":"https://api.github.com/users/sschuberth/events{/privacy}","received_events_url":"https://api.github.com/users/sschuberth/received_events","type":"User","site_admin":false},"body":"Then I'm wondering why it ever worked for Python 3. Do you have any idea about that?","created_at":"2018-03-05T08:12:23Z","updated_at":"2018-03-05T08:12:24Z","html_url":"https://github.com/spdx/tools-python/pull/37#discussion_r172112086","pull_request_url":"https://api.github.com/repos/spdx/tools-python/pulls/37","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/spdx/tools-python/pulls/comments/172112086"},"html":{"href":"https://github.com/spdx/tools-python/pull/37#discussion_r172112086"},"pull_request":{"href":"https://api.github.com/repos/spdx/tools-python/pulls/37"}},"in_reply_to_id":172111393},"pull_request":{"url":"https://api.github.com/repos/spdx/tools-python/pulls/37","id":172712160,"html_url":"https://github.com/spdx/tools-python/pull/37","diff_url":"https://github.com/spdx/tools-python/pull/37.diff","patch_url":"https://github.com/spdx/tools-python/pull/37.patch","issue_url":"https://api.github.com/repos/spdx/tools-python/issues/37","number":37,"state":"open","locked":false,"title":"Fix build failure for Travis, Appveyor and Circle #36","user":{"login":"yash-nisar","id":14862976,"avatar_url":"https://avatars1.githubusercontent.com/u/14862976?v=4","gravatar_id":"","url":"https://api.github.com/users/yash-nisar","html_url":"https://github.com/yash-nisar","followers_url":"https://api.github.com/users/yash-nisar/followers","following_url":"https://api.github.com/users/yash-nisar/following{/other_user}","gists_url":"https://api.github.com/users/yash-nisar/gists{/gist_id}","starred_url":"https://api.github.com/users/yash-nisar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yash-nisar/subscriptions","organizations_url":"https://api.github.com/users/yash-nisar/orgs","repos_url":"https://api.github.com/users/yash-nisar/repos","events_url":"https://api.github.com/users/yash-nisar/events{/privacy}","received_events_url":"https://api.github.com/users/yash-nisar/received_events","type":"User","site_admin":false},"body":"Python3 returns 'bytes' and not 'str' when reading/writing\r\nto/from a binary stream. So, the files need to be opened in\r\ntext mode for `str` related operations.\r\n\r\nSigned-off-by: Yash Nisar <yash.nisar@somaiya.edu>\r\n\r\nCloses https://github.com/spdx/tools-python/issues/36","created_at":"2018-03-04T10:12:01Z","updated_at":"2018-03-05T08:12:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3575ab9d1a18327671cfb5533bc8d1c398447891","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/spdx/tools-python/pulls/37/commits","review_comments_url":"https://api.github.com/repos/spdx/tools-python/pulls/37/comments","review_comment_url":"https://api.github.com/repos/spdx/tools-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/spdx/tools-python/issues/37/comments","statuses_url":"https://api.github.com/repos/spdx/tools-python/statuses/b13408ac71d693a15c63ab6c27228dd36c4ae915","head":{"label":"yash-nisar:test_build","ref":"test_build","sha":"b13408ac71d693a15c63ab6c27228dd36c4ae915","user":{"login":"yash-nisar","id":14862976,"avatar_url":"https://avatars1.githubusercontent.com/u/14862976?v=4","gravatar_id":"","url":"https://api.github.com/users/yash-nisar","html_url":"https://github.com/yash-nisar","followers_url":"https://api.github.com/users/yash-nisar/followers","following_url":"https://api.github.com/users/yash-nisar/following{/other_user}","gists_url":"https://api.github.com/users/yash-nisar/gists{/gist_id}","starred_url":"https://api.github.com/users/yash-nisar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yash-nisar/subscriptions","organizations_url":"https://api.github.com/users/yash-nisar/orgs","repos_url":"https://api.github.com/users/yash-nisar/repos","events_url":"https://api.github.com/users/yash-nisar/events{/privacy}","received_events_url":"https://api.github.com/users/yash-nisar/received_events","type":"User","site_admin":false},"repo":{"id":121347978,"name":"tools-python","full_name":"yash-nisar/tools-python","owner":{"login":"yash-nisar","id":14862976,"avatar_url":"https://avatars1.githubusercontent.com/u/14862976?v=4","gravatar_id":"","url":"https://api.github.com/users/yash-nisar","html_url":"https://github.com/yash-nisar","followers_url":"https://api.github.com/users/yash-nisar/followers","following_url":"https://api.github.com/users/yash-nisar/following{/other_user}","gists_url":"https://api.github.com/users/yash-nisar/gists{/gist_id}","starred_url":"https://api.github.com/users/yash-nisar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yash-nisar/subscriptions","organizations_url":"https://api.github.com/users/yash-nisar/orgs","repos_url":"https://api.github.com/users/yash-nisar/repos","events_url":"https://api.github.com/users/yash-nisar/events{/privacy}","received_events_url":"https://api.github.com/users/yash-nisar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yash-nisar/tools-python","description":"An SPDX tag/values (and RDF) library to parse, validate and create SPDX documents in Python.","fork":true,"url":"https://api.github.com/repos/yash-nisar/tools-python","forks_url":"https://api.github.com/repos/yash-nisar/tools-python/forks","keys_url":"https://api.github.com/repos/yash-nisar/tools-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yash-nisar/tools-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yash-nisar/tools-python/teams","hooks_url":"https://api.github.com/repos/yash-nisar/tools-python/hooks","issue_events_url":"https://api.github.com/repos/yash-nisar/tools-python/issues/events{/number}","events_url":"https://api.github.com/repos/yash-nisar/tools-python/events","assignees_url":"https://api.github.com/repos/yash-nisar/tools-python/assignees{/user}","branches_url":"https://api.github.com/repos/yash-nisar/tools-python/branches{/branch}","tags_url":"https://api.github.com/repos/yash-nisar/tools-python/tags","blobs_url":"https://api.github.com/repos/yash-nisar/tools-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yash-nisar/tools-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yash-nisar/tools-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/yash-nisar/tools-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yash-nisar/tools-python/statuses/{sha}","languages_url":"https://api.github.com/repos/yash-nisar/tools-python/languages","stargazers_url":"https://api.github.com/repos/yash-nisar/tools-python/stargazers","contributors_url":"https://api.github.com/repos/yash-nisar/tools-python/contributors","subscribers_url":"https://api.github.com/repos/yash-nisar/tools-python/subscribers","subscription_url":"https://api.github.com/repos/yash-nisar/tools-python/subscription","commits_url":"https://api.github.com/repos/yash-nisar/tools-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/yash-nisar/tools-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/yash-nisar/tools-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/yash-nisar/tools-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/yash-nisar/tools-python/contents/{+path}","compare_url":"https://api.github.com/repos/yash-nisar/tools-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yash-nisar/tools-python/merges","archive_url":"https://api.github.com/repos/yash-nisar/tools-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yash-nisar/tools-python/downloads","issues_url":"https://api.github.com/repos/yash-nisar/tools-python/issues{/number}","pulls_url":"https://api.github.com/repos/yash-nisar/tools-python/pulls{/number}","milestones_url":"https://api.github.com/repos/yash-nisar/tools-python/milestones{/number}","notifications_url":"https://api.github.com/repos/yash-nisar/tools-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yash-nisar/tools-python/labels{/name}","releases_url":"https://api.github.com/repos/yash-nisar/tools-python/releases{/id}","deployments_url":"https://api.github.com/repos/yash-nisar/tools-python/deployments","created_at":"2018-02-13T06:38:57Z","updated_at":"2018-02-13T06:38:59Z","pushed_at":"2018-03-04T19:33:44Z","git_url":"git://github.com/yash-nisar/tools-python.git","ssh_url":"git@github.com:yash-nisar/tools-python.git","clone_url":"https://github.com/yash-nisar/tools-python.git","svn_url":"https://github.com/yash-nisar/tools-python","homepage":"http://spdx.org","size":346,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"spdx:master","ref":"master","sha":"a48022e65a8897d0e4f2e93d8e53695d2c13ea23","user":{"login":"spdx","id":11620174,"avatar_url":"https://avatars2.githubusercontent.com/u/11620174?v=4","gravatar_id":"","url":"https://api.github.com/users/spdx","html_url":"https://github.com/spdx","followers_url":"https://api.github.com/users/spdx/followers","following_url":"https://api.github.com/users/spdx/following{/other_user}","gists_url":"https://api.github.com/users/spdx/gists{/gist_id}","starred_url":"https://api.github.com/users/spdx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spdx/subscriptions","organizations_url":"https://api.github.com/users/spdx/orgs","repos_url":"https://api.github.com/users/spdx/repos","events_url":"https://api.github.com/users/spdx/events{/privacy}","received_events_url":"https://api.github.com/users/spdx/received_events","type":"Organization","site_admin":false},"repo":{"id":32761058,"name":"tools-python","full_name":"spdx/tools-python","owner":{"login":"spdx","id":11620174,"avatar_url":"https://avatars2.githubusercontent.com/u/11620174?v=4","gravatar_id":"","url":"https://api.github.com/users/spdx","html_url":"https://github.com/spdx","followers_url":"https://api.github.com/users/spdx/followers","following_url":"https://api.github.com/users/spdx/following{/other_user}","gists_url":"https://api.github.com/users/spdx/gists{/gist_id}","starred_url":"https://api.github.com/users/spdx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spdx/subscriptions","organizations_url":"https://api.github.com/users/spdx/orgs","repos_url":"https://api.github.com/users/spdx/repos","events_url":"https://api.github.com/users/spdx/events{/privacy}","received_events_url":"https://api.github.com/users/spdx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/spdx/tools-python","description":"An SPDX tag/values (and RDF) library to parse, validate and create SPDX documents in Python.","fork":false,"url":"https://api.github.com/repos/spdx/tools-python","forks_url":"https://api.github.com/repos/spdx/tools-python/forks","keys_url":"https://api.github.com/repos/spdx/tools-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spdx/tools-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spdx/tools-python/teams","hooks_url":"https://api.github.com/repos/spdx/tools-python/hooks","issue_events_url":"https://api.github.com/repos/spdx/tools-python/issues/events{/number}","events_url":"https://api.github.com/repos/spdx/tools-python/events","assignees_url":"https://api.github.com/repos/spdx/tools-python/assignees{/user}","branches_url":"https://api.github.com/repos/spdx/tools-python/branches{/branch}","tags_url":"https://api.github.com/repos/spdx/tools-python/tags","blobs_url":"https://api.github.com/repos/spdx/tools-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spdx/tools-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spdx/tools-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/spdx/tools-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spdx/tools-python/statuses/{sha}","languages_url":"https://api.github.com/repos/spdx/tools-python/languages","stargazers_url":"https://api.github.com/repos/spdx/tools-python/stargazers","contributors_url":"https://api.github.com/repos/spdx/tools-python/contributors","subscribers_url":"https://api.github.com/repos/spdx/tools-python/subscribers","subscription_url":"https://api.github.com/repos/spdx/tools-python/subscription","commits_url":"https://api.github.com/repos/spdx/tools-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/spdx/tools-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/spdx/tools-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/spdx/tools-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/spdx/tools-python/contents/{+path}","compare_url":"https://api.github.com/repos/spdx/tools-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spdx/tools-python/merges","archive_url":"https://api.github.com/repos/spdx/tools-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spdx/tools-python/downloads","issues_url":"https://api.github.com/repos/spdx/tools-python/issues{/number}","pulls_url":"https://api.github.com/repos/spdx/tools-python/pulls{/number}","milestones_url":"https://api.github.com/repos/spdx/tools-python/milestones{/number}","notifications_url":"https://api.github.com/repos/spdx/tools-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spdx/tools-python/labels{/name}","releases_url":"https://api.github.com/repos/spdx/tools-python/releases{/id}","deployments_url":"https://api.github.com/repos/spdx/tools-python/deployments","created_at":"2015-03-23T21:54:39Z","updated_at":"2018-02-26T07:00:33Z","pushed_at":"2018-03-04T19:33:45Z","git_url":"git://github.com/spdx/tools-python.git","ssh_url":"git@github.com:spdx/tools-python.git","clone_url":"https://github.com/spdx/tools-python.git","svn_url":"https://github.com/spdx/tools-python","homepage":"http://spdx.org","size":345,"stargazers_count":9,"watchers_count":9,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":16,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":16,"open_issues":15,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/spdx/tools-python/pulls/37"},"html":{"href":"https://github.com/spdx/tools-python/pull/37"},"issue":{"href":"https://api.github.com/repos/spdx/tools-python/issues/37"},"comments":{"href":"https://api.github.com/repos/spdx/tools-python/issues/37/comments"},"review_comments":{"href":"https://api.github.com/repos/spdx/tools-python/pulls/37/comments"},"review_comment":{"href":"https://api.github.com/repos/spdx/tools-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/spdx/tools-python/pulls/37/commits"},"statuses":{"href":"https://api.github.com/repos/spdx/tools-python/statuses/b13408ac71d693a15c63ab6c27228dd36c4ae915"}},"author_association":"NONE"}}
{"actor":{"display_login":"sschuberth"}}