{"action":"created","issue":{"url":"https://api.github.com/repos/sqlcollaborative/dbatools/issues/4427","repository_url":"https://api.github.com/repos/sqlcollaborative/dbatools","labels_url":"https://api.github.com/repos/sqlcollaborative/dbatools/issues/4427/labels{/name}","comments_url":"https://api.github.com/repos/sqlcollaborative/dbatools/issues/4427/comments","events_url":"https://api.github.com/repos/sqlcollaborative/dbatools/issues/4427/events","html_url":"https://github.com/sqlcollaborative/dbatools/pull/4427","id":378091732,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4ODgwMzk0","number":4427,"title":"Invoke-DbatoolsFormatter, aesthetic fixes","user":{"login":"niphlod","id":122119,"node_id":"MDQ6VXNlcjEyMjExOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/122119?v=4","gravatar_id":"","url":"https://api.github.com/users/niphlod","html_url":"https://github.com/niphlod","followers_url":"https://api.github.com/users/niphlod/followers","following_url":"https://api.github.com/users/niphlod/following{/other_user}","gists_url":"https://api.github.com/users/niphlod/gists{/gist_id}","starred_url":"https://api.github.com/users/niphlod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niphlod/subscriptions","organizations_url":"https://api.github.com/users/niphlod/orgs","repos_url":"https://api.github.com/users/niphlod/repos","events_url":"https://api.github.com/users/niphlod/events{/privacy}","received_events_url":"https://api.github.com/users/niphlod/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-07T00:27:58Z","updated_at":"2018-11-07T08:44:49Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/sqlcollaborative/dbatools/pulls/4427","html_url":"https://github.com/sqlcollaborative/dbatools/pull/4427","diff_url":"https://github.com/sqlcollaborative/dbatools/pull/4427.diff","patch_url":"https://github.com/sqlcollaborative/dbatools/pull/4427.patch"},"body":"## Type of Change\r\n<!-- What type of change does your code introduce -->\r\n - [x] Bug fix (non-breaking change, fixes #4409 and fixes #4373)\r\n - [ ] New feature (non-breaking change, adds functionality)\r\n - [ ] Breaking change (effects multiple commands or functionality)\r\n - [ ] Ran manual Pester test and has passed (`.\\tests\\manual.pester.ps1)\r\n - [ ] Adding code coverage to existing functionality\r\n - [ ] Pester test is included\r\n - [ ] Nunit test is included\r\n - [ ] Documentation\r\n - [ ] Build system\r\n \r\n\r\n### Purpose\r\nFix the reported bugs\r\n\r\n### Approach\r\nAnother bit of regexes involved\r\n\r\n@potatoqualitee : before doing a mass rewrite please check that the output is consistent with what you want. In any case these aesthetics won't - obviously - checked in CI. One thing is consistency, the other is fixation ^_^"},"comment":{"url":"https://api.github.com/repos/sqlcollaborative/dbatools/issues/comments/436548013","html_url":"https://github.com/sqlcollaborative/dbatools/pull/4427#issuecomment-436548013","issue_url":"https://api.github.com/repos/sqlcollaborative/dbatools/issues/4427","id":436548013,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNjU0ODAxMw==","user":{"login":"niphlod","id":122119,"node_id":"MDQ6VXNlcjEyMjExOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/122119?v=4","gravatar_id":"","url":"https://api.github.com/users/niphlod","html_url":"https://github.com/niphlod","followers_url":"https://api.github.com/users/niphlod/followers","following_url":"https://api.github.com/users/niphlod/following{/other_user}","gists_url":"https://api.github.com/users/niphlod/gists{/gist_id}","starred_url":"https://api.github.com/users/niphlod/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niphlod/subscriptions","organizations_url":"https://api.github.com/users/niphlod/orgs","repos_url":"https://api.github.com/users/niphlod/repos","events_url":"https://api.github.com/users/niphlod/events{/privacy}","received_events_url":"https://api.github.com/users/niphlod/received_events","type":"User","site_admin":false},"created_at":"2018-11-07T08:44:49Z","updated_at":"2018-11-07T08:44:49Z","author_association":"CONTRIBUTOR","body":"so, instead of\r\n```\r\n....CRLF\r\n}CRLF\r\n```\r\nyou want\r\n```\r\n....CRLF\r\n}\r\n```\r\n? is it reaaaaaally necessary to cut the last CRLF ?"}}
{"actor":{"display_login":"niphlod"}}