{"action":"closed","issue":{"url":"https://api.github.com/repos/vuejs/vue-test-utils/issues/440","repository_url":"https://api.github.com/repos/vuejs/vue-test-utils","labels_url":"https://api.github.com/repos/vuejs/vue-test-utils/issues/440/labels{/name}","comments_url":"https://api.github.com/repos/vuejs/vue-test-utils/issues/440/comments","events_url":"https://api.github.com/repos/vuejs/vue-test-utils/issues/440/events","html_url":"https://github.com/vuejs/vue-test-utils/issues/440","id":299355044,"number":440,"title":"Remove vue-server-renderer as a peer dependency","user":{"login":"eddyerburgh","id":13196123,"avatar_url":"https://avatars3.githubusercontent.com/u/13196123?v=4","gravatar_id":"","url":"https://api.github.com/users/eddyerburgh","html_url":"https://github.com/eddyerburgh","followers_url":"https://api.github.com/users/eddyerburgh/followers","following_url":"https://api.github.com/users/eddyerburgh/following{/other_user}","gists_url":"https://api.github.com/users/eddyerburgh/gists{/gist_id}","starred_url":"https://api.github.com/users/eddyerburgh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eddyerburgh/subscriptions","organizations_url":"https://api.github.com/users/eddyerburgh/orgs","repos_url":"https://api.github.com/users/eddyerburgh/repos","events_url":"https://api.github.com/users/eddyerburgh/events{/privacy}","received_events_url":"https://api.github.com/users/eddyerburgh/received_events","type":"User","site_admin":false},"labels":[{"id":734249215,"url":"https://api.github.com/repos/vuejs/vue-test-utils/labels/feature%20request","name":"feature request","color":"fbca04","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":15,"created_at":"2018-02-22T13:32:26Z","updated_at":"2018-03-26T12:50:53Z","closed_at":"2018-03-26T12:50:53Z","author_association":"MEMBER","body":"### What problem does this feature solve?\r\nrenderToString was added in beta.12 , which uses vue-server-renderer.\r\n\r\nI don't expect many users will call this method, as it's intended use is for testing server side code. Adding it as a peer dependency will warn users that they need to install it, even though they probably won't use the `renderToString` method.\r\n\r\n### What does the proposed API look like?\r\n\r\n1) Remove vue-server-renderer as a peer dependency and handle it ourselves, using something like ensureRequire—https://github.com/vuejs/vue-jest/blob/master/lib/compilers/haml-compiler.js#L6. Users will still need to add additional config to webpack, because webpack will try to bundle native node modules in vue-server-renderer.\r\n2) Split `@vue/test-utils`, and `@vue/server-test-utils`. `@vue/test-utils` will expose mount and shallow, `@vue/server-test-utils` will expose `renderToString`.\r\n\r\n<!-- generated by vue-issues. DO NOT REMOVE -->"}}
{"actor":{"display_login":"eddyerburgh"}}