{"action":"created","issue":{"url":"https://api.github.com/repos/gcp/leela-zero-server/issues/63","repository_url":"https://api.github.com/repos/gcp/leela-zero-server","labels_url":"https://api.github.com/repos/gcp/leela-zero-server/issues/63/labels{/name}","comments_url":"https://api.github.com/repos/gcp/leela-zero-server/issues/63/comments","events_url":"https://api.github.com/repos/gcp/leela-zero-server/issues/63/events","html_url":"https://github.com/gcp/leela-zero-server/issues/63","id":316495172,"number":63,"title":"Wins to PASS after match leaves queue don't promote?","user":{"login":"roy7","id":4165289,"avatar_url":"https://avatars0.githubusercontent.com/u/4165289?v=4","gravatar_id":"","url":"https://api.github.com/users/roy7","html_url":"https://github.com/roy7","followers_url":"https://api.github.com/users/roy7/followers","following_url":"https://api.github.com/users/roy7/following{/other_user}","gists_url":"https://api.github.com/users/roy7/gists{/gist_id}","starred_url":"https://api.github.com/users/roy7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/roy7/subscriptions","organizations_url":"https://api.github.com/users/roy7/orgs","repos_url":"https://api.github.com/users/roy7/repos","events_url":"https://api.github.com/users/roy7/events{/privacy}","received_events_url":"https://api.github.com/users/roy7/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-04-21T14:12:46Z","updated_at":"2018-04-21T16:50:07Z","closed_at":null,"author_association":"COLLABORATOR","body":"See discussion at https://github.com/gcp/leela-zero/issues/1229#issuecomment-383298609 and https://github.com/gcp/leela-zero/issues/1228#issue-316454330.\r\n\r\nIt appears a network that had sent out all pages and left pending matches queue had enough wins arrive to show PASS on the web site, but it didn't actually promote. The same SPRT()===true test is used to promote a late arrival match win and to decide to show PASS on web site. So I wonder if this is a bug that matches after the match has ended can't promote a network for some reason?\r\n\r\nJust looking at https://github.com/gcp/leela-zero-server/blob/next/server.js#L883 I don't see why it would fail however."},"comment":{"url":"https://api.github.com/repos/gcp/leela-zero-server/issues/comments/383312149","html_url":"https://github.com/gcp/leela-zero-server/issues/63#issuecomment-383312149","issue_url":"https://api.github.com/repos/gcp/leela-zero-server/issues/63","id":383312149,"user":{"login":"Dorus","id":4461459,"avatar_url":"https://avatars2.githubusercontent.com/u/4461459?v=4","gravatar_id":"","url":"https://api.github.com/users/Dorus","html_url":"https://github.com/Dorus","followers_url":"https://api.github.com/users/Dorus/followers","following_url":"https://api.github.com/users/Dorus/following{/other_user}","gists_url":"https://api.github.com/users/Dorus/gists{/gist_id}","starred_url":"https://api.github.com/users/Dorus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dorus/subscriptions","organizations_url":"https://api.github.com/users/Dorus/orgs","repos_url":"https://api.github.com/users/Dorus/repos","events_url":"https://api.github.com/users/Dorus/events{/privacy}","received_events_url":"https://api.github.com/users/Dorus/received_events","type":"User","site_admin":false},"created_at":"2018-04-21T16:50:07Z","updated_at":"2018-04-21T16:50:07Z","author_association":"CONTRIBUTOR","body":"@roy7 This line should kick in: https://github.com/gcp/leela-zero-server/blob/next/server.js#L304\r\n\r\n```js\r\nif(w+l>=max&&w/(w+l)>=(aim/max)) return true;\r\n```\r\nSo let\r\n```text\r\nw=223\r\nl=182\r\nmax=400\r\naim = max / 2 + 2 * stDev(max)=220\r\n```\r\nthen\r\n```text\r\nw+l>=max&&w/(w+l)>=(aim/max)\r\n405>=400 && 0.5506 >=0.55\r\ntrue && true\r\ntrue\r\n```\r\nQED\r\n\r\nI tried this in console and JS agrees with me, so this line isn't the problem. Must be elsewhere. I'll keep looking."}}
{"actor":{"display_login":"Dorus"}}