{"action":"created","comment":{"url":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/comments/230432610","pull_request_review_id":171175601,"id":230432610,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDQzMjYxMA==","diff_hunk":"@@ -121,13 +121,20 @@ namespace ngraph\n                                            const std::shared_ptr<Node> max_freezed_output,\n                                            const bool with_relu)\n         {\n+            bool is_output_signed = !with_relu;\n             float scale = builder::quantization_util::get_scale(min_input,\n                                                                 max_input,\n                                                                 min_filter,\n                                                                 max_filter,\n                                                                 min_freezed_output,\n-                                                                max_freezed_output);\n+                                                                max_freezed_output,\n+                                                                is_output_signed);\n             auto requantization_scale = op::Constant::create(element::f32, Shape{1}, {scale});\n+            float scale_bias = (bias->get_element_type() == element::i32)\n+                                   ? 1.0\n+                                   : builder::quantization_util::get_bias_scale(\n+                                         min_input, max_input, min_filter, max_filter);\n+            auto bias_scale = op::Constant::create(element::f32, Shape{1}, {scale_bias});","path":"src/ngraph/builder/quantization.cpp","position":18,"original_position":18,"commit_id":"cdaf30c0576122bb1350da0b3963f101e89c5a43","original_commit_id":"cdaf30c0576122bb1350da0b3963f101e89c5a43","user":{"login":"adstraw","id":26910851,"node_id":"MDQ6VXNlcjI2OTEwODUx","avatar_url":"https://avatars1.githubusercontent.com/u/26910851?v=4","gravatar_id":"","url":"https://api.github.com/users/adstraw","html_url":"https://github.com/adstraw","followers_url":"https://api.github.com/users/adstraw/followers","following_url":"https://api.github.com/users/adstraw/following{/other_user}","gists_url":"https://api.github.com/users/adstraw/gists{/gist_id}","starred_url":"https://api.github.com/users/adstraw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adstraw/subscriptions","organizations_url":"https://api.github.com/users/adstraw/orgs","repos_url":"https://api.github.com/users/adstraw/repos","events_url":"https://api.github.com/users/adstraw/events{/privacy}","received_events_url":"https://api.github.com/users/adstraw/received_events","type":"User","site_admin":false},"body":"@jbobba are you talking about an nGraph::op::Quantize?","created_at":"2018-11-02T16:22:39Z","updated_at":"2018-11-02T16:41:46Z","html_url":"https://github.com/NervanaSystems/ngraph/pull/1933#discussion_r230432610","pull_request_url":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/1933","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/comments/230432610"},"html":{"href":"https://github.com/NervanaSystems/ngraph/pull/1933#discussion_r230432610"},"pull_request":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/1933"}},"in_reply_to_id":229403472},"pull_request":{"url":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/1933","id":226349056,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MzQ5MDU2","html_url":"https://github.com/NervanaSystems/ngraph/pull/1933","diff_url":"https://github.com/NervanaSystems/ngraph/pull/1933.diff","patch_url":"https://github.com/NervanaSystems/ngraph/pull/1933.patch","issue_url":"https://api.github.com/repos/NervanaSystems/ngraph/issues/1933","number":1933,"state":"open","locked":false,"title":"Quantize(reorder) bias to int32 ","user":{"login":"nbpatel","id":22088168,"node_id":"MDQ6VXNlcjIyMDg4MTY4","avatar_url":"https://avatars3.githubusercontent.com/u/22088168?v=4","gravatar_id":"","url":"https://api.github.com/users/nbpatel","html_url":"https://github.com/nbpatel","followers_url":"https://api.github.com/users/nbpatel/followers","following_url":"https://api.github.com/users/nbpatel/following{/other_user}","gists_url":"https://api.github.com/users/nbpatel/gists{/gist_id}","starred_url":"https://api.github.com/users/nbpatel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nbpatel/subscriptions","organizations_url":"https://api.github.com/users/nbpatel/orgs","repos_url":"https://api.github.com/users/nbpatel/repos","events_url":"https://api.github.com/users/nbpatel/events{/privacy}","received_events_url":"https://api.github.com/users/nbpatel/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-28T07:39:00Z","updated_at":"2018-11-02T16:41:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e34541e7af62eefc3f46f41434a0252d845b2667","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/1933/commits","review_comments_url":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/1933/comments","review_comment_url":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NervanaSystems/ngraph/issues/1933/comments","statuses_url":"https://api.github.com/repos/NervanaSystems/ngraph/statuses/cdaf30c0576122bb1350da0b3963f101e89c5a43","head":{"label":"NervanaSystems:nishant_quantize_bias","ref":"nishant_quantize_bias","sha":"cdaf30c0576122bb1350da0b3963f101e89c5a43","user":{"login":"NervanaSystems","id":9260121,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyNjAxMjE=","avatar_url":"https://avatars2.githubusercontent.com/u/9260121?v=4","gravatar_id":"","url":"https://api.github.com/users/NervanaSystems","html_url":"https://github.com/NervanaSystems","followers_url":"https://api.github.com/users/NervanaSystems/followers","following_url":"https://api.github.com/users/NervanaSystems/following{/other_user}","gists_url":"https://api.github.com/users/NervanaSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/NervanaSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NervanaSystems/subscriptions","organizations_url":"https://api.github.com/users/NervanaSystems/orgs","repos_url":"https://api.github.com/users/NervanaSystems/repos","events_url":"https://api.github.com/users/NervanaSystems/events{/privacy}","received_events_url":"https://api.github.com/users/NervanaSystems/received_events","type":"Organization","site_admin":false},"repo":{"id":98252973,"node_id":"MDEwOlJlcG9zaXRvcnk5ODI1Mjk3Mw==","name":"ngraph","full_name":"NervanaSystems/ngraph","private":false,"owner":{"login":"NervanaSystems","id":9260121,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyNjAxMjE=","avatar_url":"https://avatars2.githubusercontent.com/u/9260121?v=4","gravatar_id":"","url":"https://api.github.com/users/NervanaSystems","html_url":"https://github.com/NervanaSystems","followers_url":"https://api.github.com/users/NervanaSystems/followers","following_url":"https://api.github.com/users/NervanaSystems/following{/other_user}","gists_url":"https://api.github.com/users/NervanaSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/NervanaSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NervanaSystems/subscriptions","organizations_url":"https://api.github.com/users/NervanaSystems/orgs","repos_url":"https://api.github.com/users/NervanaSystems/repos","events_url":"https://api.github.com/users/NervanaSystems/events{/privacy}","received_events_url":"https://api.github.com/users/NervanaSystems/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NervanaSystems/ngraph","description":"nGraph is an open source C++ library, compiler and runtime for Deep Learning frameworks","fork":false,"url":"https://api.github.com/repos/NervanaSystems/ngraph","forks_url":"https://api.github.com/repos/NervanaSystems/ngraph/forks","keys_url":"https://api.github.com/repos/NervanaSystems/ngraph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NervanaSystems/ngraph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NervanaSystems/ngraph/teams","hooks_url":"https://api.github.com/repos/NervanaSystems/ngraph/hooks","issue_events_url":"https://api.github.com/repos/NervanaSystems/ngraph/issues/events{/number}","events_url":"https://api.github.com/repos/NervanaSystems/ngraph/events","assignees_url":"https://api.github.com/repos/NervanaSystems/ngraph/assignees{/user}","branches_url":"https://api.github.com/repos/NervanaSystems/ngraph/branches{/branch}","tags_url":"https://api.github.com/repos/NervanaSystems/ngraph/tags","blobs_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/refs{/sha}","trees_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NervanaSystems/ngraph/statuses/{sha}","languages_url":"https://api.github.com/repos/NervanaSystems/ngraph/languages","stargazers_url":"https://api.github.com/repos/NervanaSystems/ngraph/stargazers","contributors_url":"https://api.github.com/repos/NervanaSystems/ngraph/contributors","subscribers_url":"https://api.github.com/repos/NervanaSystems/ngraph/subscribers","subscription_url":"https://api.github.com/repos/NervanaSystems/ngraph/subscription","commits_url":"https://api.github.com/repos/NervanaSystems/ngraph/commits{/sha}","git_commits_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/commits{/sha}","comments_url":"https://api.github.com/repos/NervanaSystems/ngraph/comments{/number}","issue_comment_url":"https://api.github.com/repos/NervanaSystems/ngraph/issues/comments{/number}","contents_url":"https://api.github.com/repos/NervanaSystems/ngraph/contents/{+path}","compare_url":"https://api.github.com/repos/NervanaSystems/ngraph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NervanaSystems/ngraph/merges","archive_url":"https://api.github.com/repos/NervanaSystems/ngraph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NervanaSystems/ngraph/downloads","issues_url":"https://api.github.com/repos/NervanaSystems/ngraph/issues{/number}","pulls_url":"https://api.github.com/repos/NervanaSystems/ngraph/pulls{/number}","milestones_url":"https://api.github.com/repos/NervanaSystems/ngraph/milestones{/number}","notifications_url":"https://api.github.com/repos/NervanaSystems/ngraph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NervanaSystems/ngraph/labels{/name}","releases_url":"https://api.github.com/repos/NervanaSystems/ngraph/releases{/id}","deployments_url":"https://api.github.com/repos/NervanaSystems/ngraph/deployments","created_at":"2017-07-25T02:02:38Z","updated_at":"2018-11-02T16:09:53Z","pushed_at":"2018-11-02T16:35:40Z","git_url":"git://github.com/NervanaSystems/ngraph.git","ssh_url":"git@github.com:NervanaSystems/ngraph.git","clone_url":"https://github.com/NervanaSystems/ngraph.git","svn_url":"https://github.com/NervanaSystems/ngraph","homepage":"http://ngraph.nervanasys.com/docs/latest","size":38347,"stargazers_count":649,"watchers_count":649,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":89,"mirror_url":null,"archived":false,"open_issues_count":66,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":89,"open_issues":66,"watchers":649,"default_branch":"master"}},"base":{"label":"NervanaSystems:master","ref":"master","sha":"ffa20eeed1d2534e058c9672b000eb38a455055f","user":{"login":"NervanaSystems","id":9260121,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyNjAxMjE=","avatar_url":"https://avatars2.githubusercontent.com/u/9260121?v=4","gravatar_id":"","url":"https://api.github.com/users/NervanaSystems","html_url":"https://github.com/NervanaSystems","followers_url":"https://api.github.com/users/NervanaSystems/followers","following_url":"https://api.github.com/users/NervanaSystems/following{/other_user}","gists_url":"https://api.github.com/users/NervanaSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/NervanaSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NervanaSystems/subscriptions","organizations_url":"https://api.github.com/users/NervanaSystems/orgs","repos_url":"https://api.github.com/users/NervanaSystems/repos","events_url":"https://api.github.com/users/NervanaSystems/events{/privacy}","received_events_url":"https://api.github.com/users/NervanaSystems/received_events","type":"Organization","site_admin":false},"repo":{"id":98252973,"node_id":"MDEwOlJlcG9zaXRvcnk5ODI1Mjk3Mw==","name":"ngraph","full_name":"NervanaSystems/ngraph","private":false,"owner":{"login":"NervanaSystems","id":9260121,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkyNjAxMjE=","avatar_url":"https://avatars2.githubusercontent.com/u/9260121?v=4","gravatar_id":"","url":"https://api.github.com/users/NervanaSystems","html_url":"https://github.com/NervanaSystems","followers_url":"https://api.github.com/users/NervanaSystems/followers","following_url":"https://api.github.com/users/NervanaSystems/following{/other_user}","gists_url":"https://api.github.com/users/NervanaSystems/gists{/gist_id}","starred_url":"https://api.github.com/users/NervanaSystems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NervanaSystems/subscriptions","organizations_url":"https://api.github.com/users/NervanaSystems/orgs","repos_url":"https://api.github.com/users/NervanaSystems/repos","events_url":"https://api.github.com/users/NervanaSystems/events{/privacy}","received_events_url":"https://api.github.com/users/NervanaSystems/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NervanaSystems/ngraph","description":"nGraph is an open source C++ library, compiler and runtime for Deep Learning frameworks","fork":false,"url":"https://api.github.com/repos/NervanaSystems/ngraph","forks_url":"https://api.github.com/repos/NervanaSystems/ngraph/forks","keys_url":"https://api.github.com/repos/NervanaSystems/ngraph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NervanaSystems/ngraph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NervanaSystems/ngraph/teams","hooks_url":"https://api.github.com/repos/NervanaSystems/ngraph/hooks","issue_events_url":"https://api.github.com/repos/NervanaSystems/ngraph/issues/events{/number}","events_url":"https://api.github.com/repos/NervanaSystems/ngraph/events","assignees_url":"https://api.github.com/repos/NervanaSystems/ngraph/assignees{/user}","branches_url":"https://api.github.com/repos/NervanaSystems/ngraph/branches{/branch}","tags_url":"https://api.github.com/repos/NervanaSystems/ngraph/tags","blobs_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/refs{/sha}","trees_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NervanaSystems/ngraph/statuses/{sha}","languages_url":"https://api.github.com/repos/NervanaSystems/ngraph/languages","stargazers_url":"https://api.github.com/repos/NervanaSystems/ngraph/stargazers","contributors_url":"https://api.github.com/repos/NervanaSystems/ngraph/contributors","subscribers_url":"https://api.github.com/repos/NervanaSystems/ngraph/subscribers","subscription_url":"https://api.github.com/repos/NervanaSystems/ngraph/subscription","commits_url":"https://api.github.com/repos/NervanaSystems/ngraph/commits{/sha}","git_commits_url":"https://api.github.com/repos/NervanaSystems/ngraph/git/commits{/sha}","comments_url":"https://api.github.com/repos/NervanaSystems/ngraph/comments{/number}","issue_comment_url":"https://api.github.com/repos/NervanaSystems/ngraph/issues/comments{/number}","contents_url":"https://api.github.com/repos/NervanaSystems/ngraph/contents/{+path}","compare_url":"https://api.github.com/repos/NervanaSystems/ngraph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NervanaSystems/ngraph/merges","archive_url":"https://api.github.com/repos/NervanaSystems/ngraph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NervanaSystems/ngraph/downloads","issues_url":"https://api.github.com/repos/NervanaSystems/ngraph/issues{/number}","pulls_url":"https://api.github.com/repos/NervanaSystems/ngraph/pulls{/number}","milestones_url":"https://api.github.com/repos/NervanaSystems/ngraph/milestones{/number}","notifications_url":"https://api.github.com/repos/NervanaSystems/ngraph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NervanaSystems/ngraph/labels{/name}","releases_url":"https://api.github.com/repos/NervanaSystems/ngraph/releases{/id}","deployments_url":"https://api.github.com/repos/NervanaSystems/ngraph/deployments","created_at":"2017-07-25T02:02:38Z","updated_at":"2018-11-02T16:09:53Z","pushed_at":"2018-11-02T16:35:40Z","git_url":"git://github.com/NervanaSystems/ngraph.git","ssh_url":"git@github.com:NervanaSystems/ngraph.git","clone_url":"https://github.com/NervanaSystems/ngraph.git","svn_url":"https://github.com/NervanaSystems/ngraph","homepage":"http://ngraph.nervanasys.com/docs/latest","size":38347,"stargazers_count":649,"watchers_count":649,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":89,"mirror_url":null,"archived":false,"open_issues_count":66,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":89,"open_issues":66,"watchers":649,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/1933"},"html":{"href":"https://github.com/NervanaSystems/ngraph/pull/1933"},"issue":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/issues/1933"},"comments":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/issues/1933/comments"},"review_comments":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/1933/comments"},"review_comment":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/pulls/1933/commits"},"statuses":{"href":"https://api.github.com/repos/NervanaSystems/ngraph/statuses/cdaf30c0576122bb1350da0b3963f101e89c5a43"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"adstraw"}}