{"action":"closed","issue":{"url":"https://api.github.com/repos/magefly/CodeIgniter-Aauth/issues/233","repository_url":"https://api.github.com/repos/magefly/CodeIgniter-Aauth","labels_url":"https://api.github.com/repos/magefly/CodeIgniter-Aauth/issues/233/labels{/name}","comments_url":"https://api.github.com/repos/magefly/CodeIgniter-Aauth/issues/233/comments","events_url":"https://api.github.com/repos/magefly/CodeIgniter-Aauth/issues/233/events","html_url":"https://github.com/magefly/CodeIgniter-Aauth/issues/233","id":330355703,"node_id":"MDU6SXNzdWUzMzAzNTU3MDM=","number":233,"title":"is_banned function issue","user":{"login":"jmikerq","id":7443287,"node_id":"MDQ6VXNlcjc0NDMyODc=","avatar_url":"https://avatars1.githubusercontent.com/u/7443287?v=4","gravatar_id":"","url":"https://api.github.com/users/jmikerq","html_url":"https://github.com/jmikerq","followers_url":"https://api.github.com/users/jmikerq/followers","following_url":"https://api.github.com/users/jmikerq/following{/other_user}","gists_url":"https://api.github.com/users/jmikerq/gists{/gist_id}","starred_url":"https://api.github.com/users/jmikerq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmikerq/subscriptions","organizations_url":"https://api.github.com/users/jmikerq/orgs","repos_url":"https://api.github.com/users/jmikerq/repos","events_url":"https://api.github.com/users/jmikerq/events{/privacy}","received_events_url":"https://api.github.com/users/jmikerq/received_events","type":"User","site_admin":false},"labels":[{"id":56950139,"node_id":"MDU6TGFiZWw1Njk1MDEzOQ==","url":"https://api.github.com/repos/magefly/CodeIgniter-Aauth/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-06-07T16:52:35Z","updated_at":"2018-11-11T20:40:30Z","closed_at":"2018-11-11T20:40:30Z","author_association":"NONE","body":"https://github.com/magefly/CodeIgniter-Aauth/blob/7ae5ef5fbc424b3e75bec3389a483d95e5cd5bc8/application/libraries/Aauth.php#L1072\r\n\r\nI understand that your is_banned function checks if an existing user is banned. However, in a case where if the user doesn't exist in the system, this function will return FALSE, which means this non-existing user is not banned. \r\n\r\nFor security, I think it would be better to return TRUE for all users not found. "}}
{"actor":{"display_login":"REJack"}}