{"action":"created","comment":{"url":"https://api.github.com/repos/material-components/material-components-ios/pulls/comments/167931132","pull_request_review_id":96218476,"id":167931132,"diff_hunk":"@@ -218,22 +221,31 @@ - (instancetype)initWithCoder:(NSCoder *)aDecoder {\n           decodeIntegerForKey:MDCTextInputControllerLegacyDefaultCharacterCountViewModeKey];\n     }\n     _disabledColor =\n-        [aDecoder decodeObjectForKey:MDCTextInputControllerLegacyDefaultDisabledColorKey];\n-    _errorColor = [aDecoder decodeObjectForKey:MDCTextInputControllerLegacyDefaultErrorColorKey];\n+        [aDecoder decodeObjectOfClass:[UIColor class]\n+                               forKey:MDCTextInputControllerLegacyDefaultDisabledColorKey];\n+    _errorColor = [aDecoder decodeObjectOfClass:[UIColor class]\n+                                         forKey:MDCTextInputControllerLegacyDefaultErrorColorKey];\n     _floatingEnabled =\n         [aDecoder decodeBoolForKey:MDCTextInputControllerLegacyDefaultFloatingEnabledKey];\n     _floatingPlaceholderNormalColor = [aDecoder\n-        decodeObjectForKey:MDCTextInputControllerLegacyDefaultFloatingPlaceholderNormalColorKey];\n+        decodeObjectOfClass:[UIColor class]\n+                     forKey:MDCTextInputControllerLegacyDefaultFloatingPlaceholderNormalColorKey];\n     _floatingPlaceholderScale = [aDecoder\n-        decodeObjectForKey:MDCTextInputControllerLegacyDefaultFloatingPlaceholderScaleKey];\n+        decodeObjectOfClass:[NSNumber class]\n+                     forKey:MDCTextInputControllerLegacyDefaultFloatingPlaceholderScaleKey];\n     _inlinePlaceholderColor =\n-        [aDecoder decodeObjectForKey:MDCTextInputControllerLegacyDefaultInlinePlaceholderColorKey];\n+        [aDecoder decodeObjectOfClass:[UIColor class]\n+                               forKey:MDCTextInputControllerLegacyDefaultInlinePlaceholderColorKey];\n     _leadingUnderlineLabelTextColor = [aDecoder\n-        decodeObjectForKey:MDCTextInputControllerLegacyDefaultLeadingUnderlineLabelTextColor];\n-    _normalColor = [aDecoder decodeObjectForKey:MDCTextInputControllerLegacyDefaultNormalColorKey];\n-    _textInput = [aDecoder decodeObjectForKey:MDCTextInputControllerLegacyDefaultTextInputKey];\n+        decodeObjectOfClass:[UIColor class]\n+                     forKey:MDCTextInputControllerLegacyDefaultFloatingPlaceholderNormalColorKey];","path":"components/TextFields/src/MDCTextInputControllerLegacyDefault.m","position":44,"original_position":44,"commit_id":"d87bd49eb6b5650a975d984dfe2ef778d4ba0d85","original_commit_id":"d87bd49eb6b5650a975d984dfe2ef778d4ba0d85","user":{"login":"yarneo","id":4066863,"avatar_url":"https://avatars2.githubusercontent.com/u/4066863?v=4","gravatar_id":"","url":"https://api.github.com/users/yarneo","html_url":"https://github.com/yarneo","followers_url":"https://api.github.com/users/yarneo/followers","following_url":"https://api.github.com/users/yarneo/following{/other_user}","gists_url":"https://api.github.com/users/yarneo/gists{/gist_id}","starred_url":"https://api.github.com/users/yarneo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarneo/subscriptions","organizations_url":"https://api.github.com/users/yarneo/orgs","repos_url":"https://api.github.com/users/yarneo/repos","events_url":"https://api.github.com/users/yarneo/events{/privacy}","received_events_url":"https://api.github.com/users/yarneo/received_events","type":"User","site_admin":false},"body":"This needs to be `MDCTextInputControllerLegacyDefaultLeadingUnderlineLabelTextColor`","created_at":"2018-02-13T16:58:42Z","updated_at":"2018-02-13T17:00:23Z","html_url":"https://github.com/material-components/material-components-ios/pull/2925#discussion_r167931132","pull_request_url":"https://api.github.com/repos/material-components/material-components-ios/pulls/2925","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/comments/167931132"},"html":{"href":"https://github.com/material-components/material-components-ios/pull/2925#discussion_r167931132"},"pull_request":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/2925"}}},"pull_request":{"url":"https://api.github.com/repos/material-components/material-components-ios/pulls/2925","id":168899049,"html_url":"https://github.com/material-components/material-components-ios/pull/2925","diff_url":"https://github.com/material-components/material-components-ios/pull/2925.diff","patch_url":"https://github.com/material-components/material-components-ios/pull/2925.patch","issue_url":"https://api.github.com/repos/material-components/material-components-ios/issues/2925","number":2925,"state":"open","locked":false,"title":"[TextFields] Converting NSCoding to NSSecureCoding","user":{"login":"willlarche","id":1271525,"avatar_url":"https://avatars1.githubusercontent.com/u/1271525?v=4","gravatar_id":"","url":"https://api.github.com/users/willlarche","html_url":"https://github.com/willlarche","followers_url":"https://api.github.com/users/willlarche/followers","following_url":"https://api.github.com/users/willlarche/following{/other_user}","gists_url":"https://api.github.com/users/willlarche/gists{/gist_id}","starred_url":"https://api.github.com/users/willlarche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willlarche/subscriptions","organizations_url":"https://api.github.com/users/willlarche/orgs","repos_url":"https://api.github.com/users/willlarche/repos","events_url":"https://api.github.com/users/willlarche/events{/privacy}","received_events_url":"https://api.github.com/users/willlarche/received_events","type":"User","site_admin":false},"body":"Closes #2837  \r\nCloses #2838 ","created_at":"2018-02-13T16:52:17Z","updated_at":"2018-02-13T17:00:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5abe42396a54d7a78ad52ba83e97f88e92c6d315","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":273191333,"url":"https://api.github.com/repos/material-components/material-components-ios/labels/cla:%20yes","name":"cla: yes","color":"4CAF50","default":false},{"id":466231317,"url":"https://api.github.com/repos/material-components/material-components-ios/labels/where:TextField","name":"where:TextField","color":"2196F3","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/material-components/material-components-ios/pulls/2925/commits","review_comments_url":"https://api.github.com/repos/material-components/material-components-ios/pulls/2925/comments","review_comment_url":"https://api.github.com/repos/material-components/material-components-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/material-components/material-components-ios/issues/2925/comments","statuses_url":"https://api.github.com/repos/material-components/material-components-ios/statuses/d87bd49eb6b5650a975d984dfe2ef778d4ba0d85","head":{"label":"willlarche:fix-textFields-coding-secure","ref":"fix-textFields-coding-secure","sha":"d87bd49eb6b5650a975d984dfe2ef778d4ba0d85","user":{"login":"willlarche","id":1271525,"avatar_url":"https://avatars1.githubusercontent.com/u/1271525?v=4","gravatar_id":"","url":"https://api.github.com/users/willlarche","html_url":"https://github.com/willlarche","followers_url":"https://api.github.com/users/willlarche/followers","following_url":"https://api.github.com/users/willlarche/following{/other_user}","gists_url":"https://api.github.com/users/willlarche/gists{/gist_id}","starred_url":"https://api.github.com/users/willlarche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willlarche/subscriptions","organizations_url":"https://api.github.com/users/willlarche/orgs","repos_url":"https://api.github.com/users/willlarche/repos","events_url":"https://api.github.com/users/willlarche/events{/privacy}","received_events_url":"https://api.github.com/users/willlarche/received_events","type":"User","site_admin":false},"repo":{"id":77475957,"name":"material-components-ios","full_name":"willlarche/material-components-ios","owner":{"login":"willlarche","id":1271525,"avatar_url":"https://avatars1.githubusercontent.com/u/1271525?v=4","gravatar_id":"","url":"https://api.github.com/users/willlarche","html_url":"https://github.com/willlarche","followers_url":"https://api.github.com/users/willlarche/followers","following_url":"https://api.github.com/users/willlarche/following{/other_user}","gists_url":"https://api.github.com/users/willlarche/gists{/gist_id}","starred_url":"https://api.github.com/users/willlarche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willlarche/subscriptions","organizations_url":"https://api.github.com/users/willlarche/orgs","repos_url":"https://api.github.com/users/willlarche/repos","events_url":"https://api.github.com/users/willlarche/events{/privacy}","received_events_url":"https://api.github.com/users/willlarche/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/willlarche/material-components-ios","description":"Modular and customizable Material Design UI components for iOS","fork":true,"url":"https://api.github.com/repos/willlarche/material-components-ios","forks_url":"https://api.github.com/repos/willlarche/material-components-ios/forks","keys_url":"https://api.github.com/repos/willlarche/material-components-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/willlarche/material-components-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/willlarche/material-components-ios/teams","hooks_url":"https://api.github.com/repos/willlarche/material-components-ios/hooks","issue_events_url":"https://api.github.com/repos/willlarche/material-components-ios/issues/events{/number}","events_url":"https://api.github.com/repos/willlarche/material-components-ios/events","assignees_url":"https://api.github.com/repos/willlarche/material-components-ios/assignees{/user}","branches_url":"https://api.github.com/repos/willlarche/material-components-ios/branches{/branch}","tags_url":"https://api.github.com/repos/willlarche/material-components-ios/tags","blobs_url":"https://api.github.com/repos/willlarche/material-components-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/willlarche/material-components-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/willlarche/material-components-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/willlarche/material-components-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/willlarche/material-components-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/willlarche/material-components-ios/languages","stargazers_url":"https://api.github.com/repos/willlarche/material-components-ios/stargazers","contributors_url":"https://api.github.com/repos/willlarche/material-components-ios/contributors","subscribers_url":"https://api.github.com/repos/willlarche/material-components-ios/subscribers","subscription_url":"https://api.github.com/repos/willlarche/material-components-ios/subscription","commits_url":"https://api.github.com/repos/willlarche/material-components-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/willlarche/material-components-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/willlarche/material-components-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/willlarche/material-components-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/willlarche/material-components-ios/contents/{+path}","compare_url":"https://api.github.com/repos/willlarche/material-components-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/willlarche/material-components-ios/merges","archive_url":"https://api.github.com/repos/willlarche/material-components-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/willlarche/material-components-ios/downloads","issues_url":"https://api.github.com/repos/willlarche/material-components-ios/issues{/number}","pulls_url":"https://api.github.com/repos/willlarche/material-components-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/willlarche/material-components-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/willlarche/material-components-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/willlarche/material-components-ios/labels{/name}","releases_url":"https://api.github.com/repos/willlarche/material-components-ios/releases{/id}","deployments_url":"https://api.github.com/repos/willlarche/material-components-ios/deployments","created_at":"2016-12-27T18:47:40Z","updated_at":"2017-05-25T09:42:48Z","pushed_at":"2018-02-13T16:50:45Z","git_url":"git://github.com/willlarche/material-components-ios.git","ssh_url":"git@github.com:willlarche/material-components-ios.git","clone_url":"https://github.com/willlarche/material-components-ios.git","svn_url":"https://github.com/willlarche/material-components-ios","homepage":"","size":444079,"stargazers_count":2,"watchers_count":2,"language":"Objective-C","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":2,"default_branch":"develop"}},"base":{"label":"material-components:develop","ref":"develop","sha":"c41bbdb1bc3acd899b9ca8e34512e337fe8fe8ba","user":{"login":"material-components","id":19478152,"avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"repo":{"id":43820219,"name":"material-components-ios","full_name":"material-components/material-components-ios","owner":{"login":"material-components","id":19478152,"avatar_url":"https://avatars3.githubusercontent.com/u/19478152?v=4","gravatar_id":"","url":"https://api.github.com/users/material-components","html_url":"https://github.com/material-components","followers_url":"https://api.github.com/users/material-components/followers","following_url":"https://api.github.com/users/material-components/following{/other_user}","gists_url":"https://api.github.com/users/material-components/gists{/gist_id}","starred_url":"https://api.github.com/users/material-components/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/material-components/subscriptions","organizations_url":"https://api.github.com/users/material-components/orgs","repos_url":"https://api.github.com/users/material-components/repos","events_url":"https://api.github.com/users/material-components/events{/privacy}","received_events_url":"https://api.github.com/users/material-components/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/material-components/material-components-ios","description":"Modular and customizable Material Design UI components for iOS","fork":false,"url":"https://api.github.com/repos/material-components/material-components-ios","forks_url":"https://api.github.com/repos/material-components/material-components-ios/forks","keys_url":"https://api.github.com/repos/material-components/material-components-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/material-components/material-components-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/material-components/material-components-ios/teams","hooks_url":"https://api.github.com/repos/material-components/material-components-ios/hooks","issue_events_url":"https://api.github.com/repos/material-components/material-components-ios/issues/events{/number}","events_url":"https://api.github.com/repos/material-components/material-components-ios/events","assignees_url":"https://api.github.com/repos/material-components/material-components-ios/assignees{/user}","branches_url":"https://api.github.com/repos/material-components/material-components-ios/branches{/branch}","tags_url":"https://api.github.com/repos/material-components/material-components-ios/tags","blobs_url":"https://api.github.com/repos/material-components/material-components-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/material-components/material-components-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/material-components/material-components-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/material-components/material-components-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/material-components/material-components-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/material-components/material-components-ios/languages","stargazers_url":"https://api.github.com/repos/material-components/material-components-ios/stargazers","contributors_url":"https://api.github.com/repos/material-components/material-components-ios/contributors","subscribers_url":"https://api.github.com/repos/material-components/material-components-ios/subscribers","subscription_url":"https://api.github.com/repos/material-components/material-components-ios/subscription","commits_url":"https://api.github.com/repos/material-components/material-components-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/material-components/material-components-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/material-components/material-components-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/material-components/material-components-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/material-components/material-components-ios/contents/{+path}","compare_url":"https://api.github.com/repos/material-components/material-components-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/material-components/material-components-ios/merges","archive_url":"https://api.github.com/repos/material-components/material-components-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/material-components/material-components-ios/downloads","issues_url":"https://api.github.com/repos/material-components/material-components-ios/issues{/number}","pulls_url":"https://api.github.com/repos/material-components/material-components-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/material-components/material-components-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/material-components/material-components-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/material-components/material-components-ios/labels{/name}","releases_url":"https://api.github.com/repos/material-components/material-components-ios/releases{/id}","deployments_url":"https://api.github.com/repos/material-components/material-components-ios/deployments","created_at":"2015-10-07T14:12:39Z","updated_at":"2018-02-13T16:15:09Z","pushed_at":"2018-02-13T16:52:18Z","git_url":"git://github.com/material-components/material-components-ios.git","ssh_url":"git@github.com:material-components/material-components-ios.git","clone_url":"https://github.com/material-components/material-components-ios.git","svn_url":"https://github.com/material-components/material-components-ios","homepage":"","size":95673,"stargazers_count":1966,"watchers_count":1966,"language":"Objective-C","has_issues":true,"has_projects":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":273,"mirror_url":null,"archived":false,"open_issues_count":491,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":273,"open_issues":491,"watchers":1966,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/2925"},"html":{"href":"https://github.com/material-components/material-components-ios/pull/2925"},"issue":{"href":"https://api.github.com/repos/material-components/material-components-ios/issues/2925"},"comments":{"href":"https://api.github.com/repos/material-components/material-components-ios/issues/2925/comments"},"review_comments":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/2925/comments"},"review_comment":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/material-components/material-components-ios/pulls/2925/commits"},"statuses":{"href":"https://api.github.com/repos/material-components/material-components-ios/statuses/d87bd49eb6b5650a975d984dfe2ef778d4ba0d85"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"yarneo"}}