{"action":"created","comment":{"url":"https://api.github.com/repos/DataDog/dd-trace-rb/pulls/comments/197409147","pull_request_review_id":131148077,"id":197409147,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NzQwOTE0Nw==","diff_hunk":"@@ -47,23 +61,30 @@\n       let(:timestamp) { Time.now }\n       let(:fields) { { time_started: Time.now, account_id: '1234' } }\n \n-      before(:each) do\n+      # Expect a deprecation warning to be output.\n+      it do","path":"spec/ddtrace/opentracer/span_spec.rb","position":65,"original_position":62,"commit_id":"8e369d524049311914cea4a28cf7dce2a7482466","original_commit_id":"c6d300746a08537d5699d426dc8ac46defe3198a","user":{"login":"pawelchcki","id":812891,"node_id":"MDQ6VXNlcjgxMjg5MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/812891?v=4","gravatar_id":"","url":"https://api.github.com/users/pawelchcki","html_url":"https://github.com/pawelchcki","followers_url":"https://api.github.com/users/pawelchcki/followers","following_url":"https://api.github.com/users/pawelchcki/following{/other_user}","gists_url":"https://api.github.com/users/pawelchcki/gists{/gist_id}","starred_url":"https://api.github.com/users/pawelchcki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pawelchcki/subscriptions","organizations_url":"https://api.github.com/users/pawelchcki/orgs","repos_url":"https://api.github.com/users/pawelchcki/repos","events_url":"https://api.github.com/users/pawelchcki/events{/privacy}","received_events_url":"https://api.github.com/users/pawelchcki/received_events","type":"User","site_admin":false},"body":"Not to bikesched too much. I have mixed feelings about using nameless examples. Having explicit name to a example most often than not makes it more clearer than the code itself.\r\n\r\nAnd while 1 line and relatively short  nameless examples are fine and easy to read most of the time. \r\nHowever examples like:\r\n```\r\nit do\r\n expect {x}.to change {z}\r\nend\r\n```\r\nlook like a exception from this rule. \r\n\r\nHowever since beauty lies in the eye of beholder I'm fine with both :). \r\n\r\nLets come back ot this discussion a bit later when working on Rubocop rules","created_at":"2018-06-22T10:37:25Z","updated_at":"2018-06-22T10:37:26Z","html_url":"https://github.com/DataDog/dd-trace-rb/pull/472#discussion_r197409147","pull_request_url":"https://api.github.com/repos/DataDog/dd-trace-rb/pulls/472","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/DataDog/dd-trace-rb/pulls/comments/197409147"},"html":{"href":"https://github.com/DataDog/dd-trace-rb/pull/472#discussion_r197409147"},"pull_request":{"href":"https://api.github.com/repos/DataDog/dd-trace-rb/pulls/472"}},"in_reply_to_id":197193179},"pull_request":{"url":"https://api.github.com/repos/DataDog/dd-trace-rb/pulls/472","id":196278602,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2Mjc4NjAy","html_url":"https://github.com/DataDog/dd-trace-rb/pull/472","diff_url":"https://github.com/DataDog/dd-trace-rb/pull/472.diff","patch_url":"https://github.com/DataDog/dd-trace-rb/pull/472.patch","issue_url":"https://api.github.com/repos/DataDog/dd-trace-rb/issues/472","number":472,"state":"open","locked":false,"title":"[OpenTracing] Span and SpanContext implementation","user":{"login":"delner","id":3237131,"node_id":"MDQ6VXNlcjMyMzcxMzE=","avatar_url":"https://avatars1.githubusercontent.com/u/3237131?v=4","gravatar_id":"","url":"https://api.github.com/users/delner","html_url":"https://github.com/delner","followers_url":"https://api.github.com/users/delner/followers","following_url":"https://api.github.com/users/delner/following{/other_user}","gists_url":"https://api.github.com/users/delner/gists{/gist_id}","starred_url":"https://api.github.com/users/delner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/delner/subscriptions","organizations_url":"https://api.github.com/users/delner/orgs","repos_url":"https://api.github.com/users/delner/repos","events_url":"https://api.github.com/users/delner/events{/privacy}","received_events_url":"https://api.github.com/users/delner/received_events","type":"User","site_admin":false},"body":"This pull request implements the OpenTracing `Span` and `SpanContext`. In their current forms, they are very simple, and may not represent the full scope of what will ultimately be supported.\r\n\r\nSome worthwhile notes:\r\n\r\n - The constructors for `Span` and `SpanContext` are still somewhat undetermined. They may require changes depending on how and where we actually construct and configure spans. The current plan is that they are treated like simple data structs, that are not responsible for building sophisticated Spans or SpanContexts. That logic is anticipated to be a part of the Tracer, or some kind of factory pattern.\r\n - There's some ambiguity as to how `log` and `log_kv` should be implemented. For now, they simply set errors, if provided with one. Otherwise they do nothing. We didn't interpret these functions to have responsibilities beyond setting some \"debug tags\", as opposed to doing logging in the traditional sense.\r\n - We might want to add `span_id` and `trace_id` to the `SpanContext`, since this object is meant to be a serializable layer of data for sharing trace data across process boundaries (particularly for the purposes of distributed tracing.)","created_at":"2018-06-20T21:32:34Z","updated_at":"2018-06-22T10:37:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3adfa14567201dcdedbe8d30349033e83fea9a1a","assignee":{"login":"delner","id":3237131,"node_id":"MDQ6VXNlcjMyMzcxMzE=","avatar_url":"https://avatars1.githubusercontent.com/u/3237131?v=4","gravatar_id":"","url":"https://api.github.com/users/delner","html_url":"https://github.com/delner","followers_url":"https://api.github.com/users/delner/followers","following_url":"https://api.github.com/users/delner/following{/other_user}","gists_url":"https://api.github.com/users/delner/gists{/gist_id}","starred_url":"https://api.github.com/users/delner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/delner/subscriptions","organizations_url":"https://api.github.com/users/delner/orgs","repos_url":"https://api.github.com/users/delner/repos","events_url":"https://api.github.com/users/delner/events{/privacy}","received_events_url":"https://api.github.com/users/delner/received_events","type":"User","site_admin":false},"assignees":[{"login":"delner","id":3237131,"node_id":"MDQ6VXNlcjMyMzcxMzE=","avatar_url":"https://avatars1.githubusercontent.com/u/3237131?v=4","gravatar_id":"","url":"https://api.github.com/users/delner","html_url":"https://github.com/delner","followers_url":"https://api.github.com/users/delner/followers","following_url":"https://api.github.com/users/delner/following{/other_user}","gists_url":"https://api.github.com/users/delner/gists{/gist_id}","starred_url":"https://api.github.com/users/delner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/delner/subscriptions","organizations_url":"https://api.github.com/users/delner/orgs","repos_url":"https://api.github.com/users/delner/repos","events_url":"https://api.github.com/users/delner/events{/privacy}","received_events_url":"https://api.github.com/users/delner/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":454754024,"node_id":"MDU6TGFiZWw0NTQ3NTQwMjQ=","url":"https://api.github.com/repos/DataDog/dd-trace-rb/labels/core","name":"core","color":"e39551","default":false},{"id":827835713,"node_id":"MDU6TGFiZWw4Mjc4MzU3MTM=","url":"https://api.github.com/repos/DataDog/dd-trace-rb/labels/feature","name":"feature","color":"7851e2","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/DataDog/dd-trace-rb/pulls/472/commits","review_comments_url":"https://api.github.com/repos/DataDog/dd-trace-rb/pulls/472/comments","review_comment_url":"https://api.github.com/repos/DataDog/dd-trace-rb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DataDog/dd-trace-rb/issues/472/comments","statuses_url":"https://api.github.com/repos/DataDog/dd-trace-rb/statuses/8e369d524049311914cea4a28cf7dce2a7482466","head":{"label":"DataDog:feature/opentracing_span_and_span_context","ref":"feature/opentracing_span_and_span_context","sha":"8e369d524049311914cea4a28cf7dce2a7482466","user":{"login":"DataDog","id":365230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTIzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"repo":{"id":66497320,"node_id":"MDEwOlJlcG9zaXRvcnk2NjQ5NzMyMA==","name":"dd-trace-rb","full_name":"DataDog/dd-trace-rb","owner":{"login":"DataDog","id":365230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTIzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DataDog/dd-trace-rb","description":"Datadog Tracing Ruby Client","fork":false,"url":"https://api.github.com/repos/DataDog/dd-trace-rb","forks_url":"https://api.github.com/repos/DataDog/dd-trace-rb/forks","keys_url":"https://api.github.com/repos/DataDog/dd-trace-rb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataDog/dd-trace-rb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataDog/dd-trace-rb/teams","hooks_url":"https://api.github.com/repos/DataDog/dd-trace-rb/hooks","issue_events_url":"https://api.github.com/repos/DataDog/dd-trace-rb/issues/events{/number}","events_url":"https://api.github.com/repos/DataDog/dd-trace-rb/events","assignees_url":"https://api.github.com/repos/DataDog/dd-trace-rb/assignees{/user}","branches_url":"https://api.github.com/repos/DataDog/dd-trace-rb/branches{/branch}","tags_url":"https://api.github.com/repos/DataDog/dd-trace-rb/tags","blobs_url":"https://api.github.com/repos/DataDog/dd-trace-rb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataDog/dd-trace-rb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataDog/dd-trace-rb/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataDog/dd-trace-rb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataDog/dd-trace-rb/statuses/{sha}","languages_url":"https://api.github.com/repos/DataDog/dd-trace-rb/languages","stargazers_url":"https://api.github.com/repos/DataDog/dd-trace-rb/stargazers","contributors_url":"https://api.github.com/repos/DataDog/dd-trace-rb/contributors","subscribers_url":"https://api.github.com/repos/DataDog/dd-trace-rb/subscribers","subscription_url":"https://api.github.com/repos/DataDog/dd-trace-rb/subscription","commits_url":"https://api.github.com/repos/DataDog/dd-trace-rb/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataDog/dd-trace-rb/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataDog/dd-trace-rb/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataDog/dd-trace-rb/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataDog/dd-trace-rb/contents/{+path}","compare_url":"https://api.github.com/repos/DataDog/dd-trace-rb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataDog/dd-trace-rb/merges","archive_url":"https://api.github.com/repos/DataDog/dd-trace-rb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataDog/dd-trace-rb/downloads","issues_url":"https://api.github.com/repos/DataDog/dd-trace-rb/issues{/number}","pulls_url":"https://api.github.com/repos/DataDog/dd-trace-rb/pulls{/number}","milestones_url":"https://api.github.com/repos/DataDog/dd-trace-rb/milestones{/number}","notifications_url":"https://api.github.com/repos/DataDog/dd-trace-rb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataDog/dd-trace-rb/labels{/name}","releases_url":"https://api.github.com/repos/DataDog/dd-trace-rb/releases{/id}","deployments_url":"https://api.github.com/repos/DataDog/dd-trace-rb/deployments","created_at":"2016-08-24T20:30:56Z","updated_at":"2018-06-21T08:03:27Z","pushed_at":"2018-06-22T10:05:01Z","git_url":"git://github.com/DataDog/dd-trace-rb.git","ssh_url":"git@github.com:DataDog/dd-trace-rb.git","clone_url":"https://github.com/DataDog/dd-trace-rb.git","svn_url":"https://github.com/DataDog/dd-trace-rb","homepage":"https://docs.datadoghq.com/tracing/","size":2114,"stargazers_count":41,"watchers_count":41,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":74,"mirror_url":null,"archived":false,"open_issues_count":42,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":74,"open_issues":42,"watchers":41,"default_branch":"master"}},"base":{"label":"DataDog:feature/opentracing","ref":"feature/opentracing","sha":"d7313692d7f291aea5f29618683ecf3eb57a5442","user":{"login":"DataDog","id":365230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTIzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"repo":{"id":66497320,"node_id":"MDEwOlJlcG9zaXRvcnk2NjQ5NzMyMA==","name":"dd-trace-rb","full_name":"DataDog/dd-trace-rb","owner":{"login":"DataDog","id":365230,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTIzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/365230?v=4","gravatar_id":"","url":"https://api.github.com/users/DataDog","html_url":"https://github.com/DataDog","followers_url":"https://api.github.com/users/DataDog/followers","following_url":"https://api.github.com/users/DataDog/following{/other_user}","gists_url":"https://api.github.com/users/DataDog/gists{/gist_id}","starred_url":"https://api.github.com/users/DataDog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DataDog/subscriptions","organizations_url":"https://api.github.com/users/DataDog/orgs","repos_url":"https://api.github.com/users/DataDog/repos","events_url":"https://api.github.com/users/DataDog/events{/privacy}","received_events_url":"https://api.github.com/users/DataDog/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DataDog/dd-trace-rb","description":"Datadog Tracing Ruby Client","fork":false,"url":"https://api.github.com/repos/DataDog/dd-trace-rb","forks_url":"https://api.github.com/repos/DataDog/dd-trace-rb/forks","keys_url":"https://api.github.com/repos/DataDog/dd-trace-rb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DataDog/dd-trace-rb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DataDog/dd-trace-rb/teams","hooks_url":"https://api.github.com/repos/DataDog/dd-trace-rb/hooks","issue_events_url":"https://api.github.com/repos/DataDog/dd-trace-rb/issues/events{/number}","events_url":"https://api.github.com/repos/DataDog/dd-trace-rb/events","assignees_url":"https://api.github.com/repos/DataDog/dd-trace-rb/assignees{/user}","branches_url":"https://api.github.com/repos/DataDog/dd-trace-rb/branches{/branch}","tags_url":"https://api.github.com/repos/DataDog/dd-trace-rb/tags","blobs_url":"https://api.github.com/repos/DataDog/dd-trace-rb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DataDog/dd-trace-rb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DataDog/dd-trace-rb/git/refs{/sha}","trees_url":"https://api.github.com/repos/DataDog/dd-trace-rb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DataDog/dd-trace-rb/statuses/{sha}","languages_url":"https://api.github.com/repos/DataDog/dd-trace-rb/languages","stargazers_url":"https://api.github.com/repos/DataDog/dd-trace-rb/stargazers","contributors_url":"https://api.github.com/repos/DataDog/dd-trace-rb/contributors","subscribers_url":"https://api.github.com/repos/DataDog/dd-trace-rb/subscribers","subscription_url":"https://api.github.com/repos/DataDog/dd-trace-rb/subscription","commits_url":"https://api.github.com/repos/DataDog/dd-trace-rb/commits{/sha}","git_commits_url":"https://api.github.com/repos/DataDog/dd-trace-rb/git/commits{/sha}","comments_url":"https://api.github.com/repos/DataDog/dd-trace-rb/comments{/number}","issue_comment_url":"https://api.github.com/repos/DataDog/dd-trace-rb/issues/comments{/number}","contents_url":"https://api.github.com/repos/DataDog/dd-trace-rb/contents/{+path}","compare_url":"https://api.github.com/repos/DataDog/dd-trace-rb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DataDog/dd-trace-rb/merges","archive_url":"https://api.github.com/repos/DataDog/dd-trace-rb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DataDog/dd-trace-rb/downloads","issues_url":"https://api.github.com/repos/DataDog/dd-trace-rb/issues{/number}","pulls_url":"https://api.github.com/repos/DataDog/dd-trace-rb/pulls{/number}","milestones_url":"https://api.github.com/repos/DataDog/dd-trace-rb/milestones{/number}","notifications_url":"https://api.github.com/repos/DataDog/dd-trace-rb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DataDog/dd-trace-rb/labels{/name}","releases_url":"https://api.github.com/repos/DataDog/dd-trace-rb/releases{/id}","deployments_url":"https://api.github.com/repos/DataDog/dd-trace-rb/deployments","created_at":"2016-08-24T20:30:56Z","updated_at":"2018-06-21T08:03:27Z","pushed_at":"2018-06-22T10:05:01Z","git_url":"git://github.com/DataDog/dd-trace-rb.git","ssh_url":"git@github.com:DataDog/dd-trace-rb.git","clone_url":"https://github.com/DataDog/dd-trace-rb.git","svn_url":"https://github.com/DataDog/dd-trace-rb","homepage":"https://docs.datadoghq.com/tracing/","size":2114,"stargazers_count":41,"watchers_count":41,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":74,"mirror_url":null,"archived":false,"open_issues_count":42,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":74,"open_issues":42,"watchers":41,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DataDog/dd-trace-rb/pulls/472"},"html":{"href":"https://github.com/DataDog/dd-trace-rb/pull/472"},"issue":{"href":"https://api.github.com/repos/DataDog/dd-trace-rb/issues/472"},"comments":{"href":"https://api.github.com/repos/DataDog/dd-trace-rb/issues/472/comments"},"review_comments":{"href":"https://api.github.com/repos/DataDog/dd-trace-rb/pulls/472/comments"},"review_comment":{"href":"https://api.github.com/repos/DataDog/dd-trace-rb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DataDog/dd-trace-rb/pulls/472/commits"},"statuses":{"href":"https://api.github.com/repos/DataDog/dd-trace-rb/statuses/8e369d524049311914cea4a28cf7dce2a7482466"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pawelchcki"}}