{"action":"opened","number":103,"pull_request":{"url":"https://api.github.com/repos/kurasu/surge/pulls/103","id":239662526,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5NjYyNTI2","html_url":"https://github.com/kurasu/surge/pull/103","diff_url":"https://github.com/kurasu/surge/pull/103.diff","patch_url":"https://github.com/kurasu/surge/pull/103.patch","issue_url":"https://api.github.com/repos/kurasu/surge/issues/103","number":103,"state":"open","locked":false,"title":"Xcode9.2 and packaging fixes","user":{"login":"asimilon","id":5970482,"node_id":"MDQ6VXNlcjU5NzA0ODI=","avatar_url":"https://avatars0.githubusercontent.com/u/5970482?v=4","gravatar_id":"","url":"https://api.github.com/users/asimilon","html_url":"https://github.com/asimilon","followers_url":"https://api.github.com/users/asimilon/followers","following_url":"https://api.github.com/users/asimilon/following{/other_user}","gists_url":"https://api.github.com/users/asimilon/gists{/gist_id}","starred_url":"https://api.github.com/users/asimilon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asimilon/subscriptions","organizations_url":"https://api.github.com/users/asimilon/orgs","repos_url":"https://api.github.com/users/asimilon/repos","events_url":"https://api.github.com/users/asimilon/events{/privacy}","received_events_url":"https://api.github.com/users/asimilon/received_events","type":"User","site_admin":false},"body":"Default clang for XCode 9.2 (last version possible in Sierra 10.12.6) complains about C++17.\r\nIt is possible to build without error if that is rolled back to C++14, however using Homebrew clang works fine and doesn't impose that restriction.\r\n\r\nI updated the packaging scripts to copy the resource files and not the whole `data` folder into the bundle, as this was then being copied by the plugin into `~/Library/Application Support/Surge` as is (i.e. `configuration.xml` was at `~/Library/Application Support/Surge/data/configuration.xml` and not the parent where it should be, causing error when loading the plugin).\r\n\r\nI also fixed the `premake5.lua` to remove the `targetextension` directive for VST3, as this was being honoured by XCode10, yet the package script expects the target file to be named `Surge.dylib`.  As XCode9.2 is *not* honouring this directive and outputting `Surge.dylib` regardless, I thought this is the best solution.","created_at":"2018-12-18T23:11:39Z","updated_at":"2018-12-18T23:11:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kurasu/surge/pulls/103/commits","review_comments_url":"https://api.github.com/repos/kurasu/surge/pulls/103/comments","review_comment_url":"https://api.github.com/repos/kurasu/surge/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kurasu/surge/issues/103/comments","statuses_url":"https://api.github.com/repos/kurasu/surge/statuses/de95fc448f9c3ff80b6c21a3dc00f0141c057127","head":{"label":"asimilon:xcode9.2","ref":"xcode9.2","sha":"de95fc448f9c3ff80b6c21a3dc00f0141c057127","user":{"login":"asimilon","id":5970482,"node_id":"MDQ6VXNlcjU5NzA0ODI=","avatar_url":"https://avatars0.githubusercontent.com/u/5970482?v=4","gravatar_id":"","url":"https://api.github.com/users/asimilon","html_url":"https://github.com/asimilon","followers_url":"https://api.github.com/users/asimilon/followers","following_url":"https://api.github.com/users/asimilon/following{/other_user}","gists_url":"https://api.github.com/users/asimilon/gists{/gist_id}","starred_url":"https://api.github.com/users/asimilon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asimilon/subscriptions","organizations_url":"https://api.github.com/users/asimilon/orgs","repos_url":"https://api.github.com/users/asimilon/repos","events_url":"https://api.github.com/users/asimilon/events{/privacy}","received_events_url":"https://api.github.com/users/asimilon/received_events","type":"User","site_admin":false},"repo":{"id":162348785,"node_id":"MDEwOlJlcG9zaXRvcnkxNjIzNDg3ODU=","name":"surge","full_name":"asimilon/surge","private":false,"owner":{"login":"asimilon","id":5970482,"node_id":"MDQ6VXNlcjU5NzA0ODI=","avatar_url":"https://avatars0.githubusercontent.com/u/5970482?v=4","gravatar_id":"","url":"https://api.github.com/users/asimilon","html_url":"https://github.com/asimilon","followers_url":"https://api.github.com/users/asimilon/followers","following_url":"https://api.github.com/users/asimilon/following{/other_user}","gists_url":"https://api.github.com/users/asimilon/gists{/gist_id}","starred_url":"https://api.github.com/users/asimilon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asimilon/subscriptions","organizations_url":"https://api.github.com/users/asimilon/orgs","repos_url":"https://api.github.com/users/asimilon/repos","events_url":"https://api.github.com/users/asimilon/events{/privacy}","received_events_url":"https://api.github.com/users/asimilon/received_events","type":"User","site_admin":false},"html_url":"https://github.com/asimilon/surge","description":"Synthesizer plug-in (previously released as Vember Audio Surge)","fork":true,"url":"https://api.github.com/repos/asimilon/surge","forks_url":"https://api.github.com/repos/asimilon/surge/forks","keys_url":"https://api.github.com/repos/asimilon/surge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/asimilon/surge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/asimilon/surge/teams","hooks_url":"https://api.github.com/repos/asimilon/surge/hooks","issue_events_url":"https://api.github.com/repos/asimilon/surge/issues/events{/number}","events_url":"https://api.github.com/repos/asimilon/surge/events","assignees_url":"https://api.github.com/repos/asimilon/surge/assignees{/user}","branches_url":"https://api.github.com/repos/asimilon/surge/branches{/branch}","tags_url":"https://api.github.com/repos/asimilon/surge/tags","blobs_url":"https://api.github.com/repos/asimilon/surge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/asimilon/surge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/asimilon/surge/git/refs{/sha}","trees_url":"https://api.github.com/repos/asimilon/surge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/asimilon/surge/statuses/{sha}","languages_url":"https://api.github.com/repos/asimilon/surge/languages","stargazers_url":"https://api.github.com/repos/asimilon/surge/stargazers","contributors_url":"https://api.github.com/repos/asimilon/surge/contributors","subscribers_url":"https://api.github.com/repos/asimilon/surge/subscribers","subscription_url":"https://api.github.com/repos/asimilon/surge/subscription","commits_url":"https://api.github.com/repos/asimilon/surge/commits{/sha}","git_commits_url":"https://api.github.com/repos/asimilon/surge/git/commits{/sha}","comments_url":"https://api.github.com/repos/asimilon/surge/comments{/number}","issue_comment_url":"https://api.github.com/repos/asimilon/surge/issues/comments{/number}","contents_url":"https://api.github.com/repos/asimilon/surge/contents/{+path}","compare_url":"https://api.github.com/repos/asimilon/surge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/asimilon/surge/merges","archive_url":"https://api.github.com/repos/asimilon/surge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/asimilon/surge/downloads","issues_url":"https://api.github.com/repos/asimilon/surge/issues{/number}","pulls_url":"https://api.github.com/repos/asimilon/surge/pulls{/number}","milestones_url":"https://api.github.com/repos/asimilon/surge/milestones{/number}","notifications_url":"https://api.github.com/repos/asimilon/surge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/asimilon/surge/labels{/name}","releases_url":"https://api.github.com/repos/asimilon/surge/releases{/id}","deployments_url":"https://api.github.com/repos/asimilon/surge/deployments","created_at":"2018-12-18T21:44:39Z","updated_at":"2018-12-18T21:44:42Z","pushed_at":"2018-12-18T23:11:27Z","git_url":"git://github.com/asimilon/surge.git","ssh_url":"git@github.com:asimilon/surge.git","clone_url":"https://github.com/asimilon/surge.git","svn_url":"https://github.com/asimilon/surge","homepage":null,"size":18742,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kurasu:master","ref":"master","sha":"9fa511b0b33ad187d7f5727fa095cd005c6ed207","user":{"login":"kurasu","id":7871411,"node_id":"MDQ6VXNlcjc4NzE0MTE=","avatar_url":"https://avatars1.githubusercontent.com/u/7871411?v=4","gravatar_id":"","url":"https://api.github.com/users/kurasu","html_url":"https://github.com/kurasu","followers_url":"https://api.github.com/users/kurasu/followers","following_url":"https://api.github.com/users/kurasu/following{/other_user}","gists_url":"https://api.github.com/users/kurasu/gists{/gist_id}","starred_url":"https://api.github.com/users/kurasu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kurasu/subscriptions","organizations_url":"https://api.github.com/users/kurasu/orgs","repos_url":"https://api.github.com/users/kurasu/repos","events_url":"https://api.github.com/users/kurasu/events{/privacy}","received_events_url":"https://api.github.com/users/kurasu/received_events","type":"User","site_admin":false},"repo":{"id":149678202,"node_id":"MDEwOlJlcG9zaXRvcnkxNDk2NzgyMDI=","name":"surge","full_name":"kurasu/surge","private":false,"owner":{"login":"kurasu","id":7871411,"node_id":"MDQ6VXNlcjc4NzE0MTE=","avatar_url":"https://avatars1.githubusercontent.com/u/7871411?v=4","gravatar_id":"","url":"https://api.github.com/users/kurasu","html_url":"https://github.com/kurasu","followers_url":"https://api.github.com/users/kurasu/followers","following_url":"https://api.github.com/users/kurasu/following{/other_user}","gists_url":"https://api.github.com/users/kurasu/gists{/gist_id}","starred_url":"https://api.github.com/users/kurasu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kurasu/subscriptions","organizations_url":"https://api.github.com/users/kurasu/orgs","repos_url":"https://api.github.com/users/kurasu/repos","events_url":"https://api.github.com/users/kurasu/events{/privacy}","received_events_url":"https://api.github.com/users/kurasu/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kurasu/surge","description":"Synthesizer plug-in (previously released as Vember Audio Surge)","fork":false,"url":"https://api.github.com/repos/kurasu/surge","forks_url":"https://api.github.com/repos/kurasu/surge/forks","keys_url":"https://api.github.com/repos/kurasu/surge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kurasu/surge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kurasu/surge/teams","hooks_url":"https://api.github.com/repos/kurasu/surge/hooks","issue_events_url":"https://api.github.com/repos/kurasu/surge/issues/events{/number}","events_url":"https://api.github.com/repos/kurasu/surge/events","assignees_url":"https://api.github.com/repos/kurasu/surge/assignees{/user}","branches_url":"https://api.github.com/repos/kurasu/surge/branches{/branch}","tags_url":"https://api.github.com/repos/kurasu/surge/tags","blobs_url":"https://api.github.com/repos/kurasu/surge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kurasu/surge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kurasu/surge/git/refs{/sha}","trees_url":"https://api.github.com/repos/kurasu/surge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kurasu/surge/statuses/{sha}","languages_url":"https://api.github.com/repos/kurasu/surge/languages","stargazers_url":"https://api.github.com/repos/kurasu/surge/stargazers","contributors_url":"https://api.github.com/repos/kurasu/surge/contributors","subscribers_url":"https://api.github.com/repos/kurasu/surge/subscribers","subscription_url":"https://api.github.com/repos/kurasu/surge/subscription","commits_url":"https://api.github.com/repos/kurasu/surge/commits{/sha}","git_commits_url":"https://api.github.com/repos/kurasu/surge/git/commits{/sha}","comments_url":"https://api.github.com/repos/kurasu/surge/comments{/number}","issue_comment_url":"https://api.github.com/repos/kurasu/surge/issues/comments{/number}","contents_url":"https://api.github.com/repos/kurasu/surge/contents/{+path}","compare_url":"https://api.github.com/repos/kurasu/surge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kurasu/surge/merges","archive_url":"https://api.github.com/repos/kurasu/surge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kurasu/surge/downloads","issues_url":"https://api.github.com/repos/kurasu/surge/issues{/number}","pulls_url":"https://api.github.com/repos/kurasu/surge/pulls{/number}","milestones_url":"https://api.github.com/repos/kurasu/surge/milestones{/number}","notifications_url":"https://api.github.com/repos/kurasu/surge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kurasu/surge/labels{/name}","releases_url":"https://api.github.com/repos/kurasu/surge/releases{/id}","deployments_url":"https://api.github.com/repos/kurasu/surge/deployments","created_at":"2018-09-20T22:32:25Z","updated_at":"2018-12-18T21:38:43Z","pushed_at":"2018-12-18T22:28:11Z","git_url":"git://github.com/kurasu/surge.git","ssh_url":"git@github.com:kurasu/surge.git","clone_url":"https://github.com/kurasu/surge.git","svn_url":"https://github.com/kurasu/surge","homepage":null,"size":19627,"stargazers_count":278,"watchers_count":278,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":41,"mirror_url":null,"archived":false,"open_issues_count":32,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":41,"open_issues":32,"watchers":278,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kurasu/surge/pulls/103"},"html":{"href":"https://github.com/kurasu/surge/pull/103"},"issue":{"href":"https://api.github.com/repos/kurasu/surge/issues/103"},"comments":{"href":"https://api.github.com/repos/kurasu/surge/issues/103/comments"},"review_comments":{"href":"https://api.github.com/repos/kurasu/surge/pulls/103/comments"},"review_comment":{"href":"https://api.github.com/repos/kurasu/surge/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kurasu/surge/pulls/103/commits"},"statuses":{"href":"https://api.github.com/repos/kurasu/surge/statuses/de95fc448f9c3ff80b6c21a3dc00f0141c057127"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":3,"additions":40,"deletions":8,"changed_files":5}}
{"actor":{"display_login":"asimilon"}}