{"action":"created","comment":{"url":"https://api.github.com/repos/webpack/webpack-cli/pulls/comments/190474869","pull_request_review_id":122856102,"id":190474869,"diff_hunk":"@@ -25,3 +25,55 @@ defineTest(\n \t},\n \t\"init\"\n );\n+\n+// Tests for _add_ command\n+defineTest(\n+\t__dirname,\n+\t\"entry\",\n+\t\"fixture-2\",\n+\t{\n+\t\tobjects: \"are\",\n+\t\tsuper: [\n+\t\t\t\"yeah\",\n+\t\t\t{\n+\t\t\t\ttest: new RegExp(/\\.(js|vue)$/),\n+\t\t\t\tloader: \"'eslint-loader'\",\n+\t\t\t\tenforce: \"'pre'\",\n+\t\t\t\tinclude: [\"customObj\", \"'Stringy'\"],\n+\t\t\t\toptions: {\n+\t\t\t\t\tformatter: \"'someOption'\"\n+\t\t\t\t}\n+\t\t\t}\n+\t\t],\n+\t\tnice: \"':)'\",","path":"packages/utils/recursive-parser.test.js","position":24,"original_position":24,"commit_id":"e4d80be7fe76c72e73c159733afae323adb490a3","original_commit_id":"e4d80be7fe76c72e73c159733afae323adb490a3","user":{"login":"ematipico","id":602478,"avatar_url":"https://avatars3.githubusercontent.com/u/602478?v=4","gravatar_id":"","url":"https://api.github.com/users/ematipico","html_url":"https://github.com/ematipico","followers_url":"https://api.github.com/users/ematipico/followers","following_url":"https://api.github.com/users/ematipico/following{/other_user}","gists_url":"https://api.github.com/users/ematipico/gists{/gist_id}","starred_url":"https://api.github.com/users/ematipico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ematipico/subscriptions","organizations_url":"https://api.github.com/users/ematipico/orgs","repos_url":"https://api.github.com/users/ematipico/repos","events_url":"https://api.github.com/users/ematipico/events{/privacy}","received_events_url":"https://api.github.com/users/ematipico/received_events","type":"User","site_admin":false},"body":"Could you also adda a `Promise` to the test? Just to make sure that we cover every case\r\n```js\r\n{\r\n  foo: Promise.resolve()\r\n}\r\n```","created_at":"2018-05-24T06:12:55Z","updated_at":"2018-05-24T06:12:56Z","html_url":"https://github.com/webpack/webpack-cli/pull/456#discussion_r190474869","pull_request_url":"https://api.github.com/repos/webpack/webpack-cli/pulls/456","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/webpack/webpack-cli/pulls/comments/190474869"},"html":{"href":"https://github.com/webpack/webpack-cli/pull/456#discussion_r190474869"},"pull_request":{"href":"https://api.github.com/repos/webpack/webpack-cli/pulls/456"}}},"pull_request":{"url":"https://api.github.com/repos/webpack/webpack-cli/pulls/456","id":189243867,"html_url":"https://github.com/webpack/webpack-cli/pull/456","diff_url":"https://github.com/webpack/webpack-cli/pull/456.diff","patch_url":"https://github.com/webpack/webpack-cli/pull/456.patch","issue_url":"https://api.github.com/repos/webpack/webpack-cli/issues/456","number":456,"state":"open","locked":false,"title":"[WIP] ast(parser): add","user":{"login":"dhruvdutt","id":5961873,"avatar_url":"https://avatars0.githubusercontent.com/u/5961873?v=4","gravatar_id":"","url":"https://api.github.com/users/dhruvdutt","html_url":"https://github.com/dhruvdutt","followers_url":"https://api.github.com/users/dhruvdutt/followers","following_url":"https://api.github.com/users/dhruvdutt/following{/other_user}","gists_url":"https://api.github.com/users/dhruvdutt/gists{/gist_id}","starred_url":"https://api.github.com/users/dhruvdutt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhruvdutt/subscriptions","organizations_url":"https://api.github.com/users/dhruvdutt/orgs","repos_url":"https://api.github.com/users/dhruvdutt/repos","events_url":"https://api.github.com/users/dhruvdutt/events{/privacy}","received_events_url":"https://api.github.com/users/dhruvdutt/received_events","type":"User","site_admin":false},"body":"<!-- Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. -->\r\n\r\n**What kind of change does this PR introduce?**\r\nFeature\r\n\r\n**Did you add tests for your changes?**\r\nYes\r\n\r\n**If relevant, did you update the documentation?**\r\nNo\r\n\r\n**Summary**\r\nInitial WIP for adding AST support for add commands.\r\n\r\n- [x] Create util function for update AST node\r\n- [x] Add support for all node types (right-hand side)\r\n- [x] For nested objects, only update the required key, not replace the entire object (keep existing nested object keys uneffected)\r\n- [x] Add tests\r\n\r\n**Does this PR introduce a breaking change?**\r\nNo\r\n<!-- If this PR introduces a breaking change, please describe the impact and a migration path for existing applications. -->\r\n\r\n","created_at":"2018-05-20T17:38:14Z","updated_at":"2018-05-24T06:12:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c8ca271f970d4507805e350174a93caee7a35657","assignee":{"login":"dhruvdutt","id":5961873,"avatar_url":"https://avatars0.githubusercontent.com/u/5961873?v=4","gravatar_id":"","url":"https://api.github.com/users/dhruvdutt","html_url":"https://github.com/dhruvdutt","followers_url":"https://api.github.com/users/dhruvdutt/followers","following_url":"https://api.github.com/users/dhruvdutt/following{/other_user}","gists_url":"https://api.github.com/users/dhruvdutt/gists{/gist_id}","starred_url":"https://api.github.com/users/dhruvdutt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhruvdutt/subscriptions","organizations_url":"https://api.github.com/users/dhruvdutt/orgs","repos_url":"https://api.github.com/users/dhruvdutt/repos","events_url":"https://api.github.com/users/dhruvdutt/events{/privacy}","received_events_url":"https://api.github.com/users/dhruvdutt/received_events","type":"User","site_admin":false},"assignees":[{"login":"dhruvdutt","id":5961873,"avatar_url":"https://avatars0.githubusercontent.com/u/5961873?v=4","gravatar_id":"","url":"https://api.github.com/users/dhruvdutt","html_url":"https://github.com/dhruvdutt","followers_url":"https://api.github.com/users/dhruvdutt/followers","following_url":"https://api.github.com/users/dhruvdutt/following{/other_user}","gists_url":"https://api.github.com/users/dhruvdutt/gists{/gist_id}","starred_url":"https://api.github.com/users/dhruvdutt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhruvdutt/subscriptions","organizations_url":"https://api.github.com/users/dhruvdutt/orgs","repos_url":"https://api.github.com/users/dhruvdutt/repos","events_url":"https://api.github.com/users/dhruvdutt/events{/privacy}","received_events_url":"https://api.github.com/users/dhruvdutt/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":796805035,"url":"https://api.github.com/repos/webpack/webpack-cli/labels/PR:%20review-outdated","name":"PR: review-outdated","color":"d93f0b","default":false},{"id":891044554,"url":"https://api.github.com/repos/webpack/webpack-cli/labels/Semver:%20minor%20%E2%9A%99%EF%B8%8F","name":"Semver: minor ⚙️","color":"f9d1a2","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/webpack/webpack-cli/pulls/456/commits","review_comments_url":"https://api.github.com/repos/webpack/webpack-cli/pulls/456/comments","review_comment_url":"https://api.github.com/repos/webpack/webpack-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/webpack/webpack-cli/issues/456/comments","statuses_url":"https://api.github.com/repos/webpack/webpack-cli/statuses/e4d80be7fe76c72e73c159733afae323adb490a3","head":{"label":"dhruvdutt:next","ref":"next","sha":"e4d80be7fe76c72e73c159733afae323adb490a3","user":{"login":"dhruvdutt","id":5961873,"avatar_url":"https://avatars0.githubusercontent.com/u/5961873?v=4","gravatar_id":"","url":"https://api.github.com/users/dhruvdutt","html_url":"https://github.com/dhruvdutt","followers_url":"https://api.github.com/users/dhruvdutt/followers","following_url":"https://api.github.com/users/dhruvdutt/following{/other_user}","gists_url":"https://api.github.com/users/dhruvdutt/gists{/gist_id}","starred_url":"https://api.github.com/users/dhruvdutt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhruvdutt/subscriptions","organizations_url":"https://api.github.com/users/dhruvdutt/orgs","repos_url":"https://api.github.com/users/dhruvdutt/repos","events_url":"https://api.github.com/users/dhruvdutt/events{/privacy}","received_events_url":"https://api.github.com/users/dhruvdutt/received_events","type":"User","site_admin":false},"repo":{"id":122456309,"name":"webpack-cli","full_name":"dhruvdutt/webpack-cli","owner":{"login":"dhruvdutt","id":5961873,"avatar_url":"https://avatars0.githubusercontent.com/u/5961873?v=4","gravatar_id":"","url":"https://api.github.com/users/dhruvdutt","html_url":"https://github.com/dhruvdutt","followers_url":"https://api.github.com/users/dhruvdutt/followers","following_url":"https://api.github.com/users/dhruvdutt/following{/other_user}","gists_url":"https://api.github.com/users/dhruvdutt/gists{/gist_id}","starred_url":"https://api.github.com/users/dhruvdutt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dhruvdutt/subscriptions","organizations_url":"https://api.github.com/users/dhruvdutt/orgs","repos_url":"https://api.github.com/users/dhruvdutt/repos","events_url":"https://api.github.com/users/dhruvdutt/events{/privacy}","received_events_url":"https://api.github.com/users/dhruvdutt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dhruvdutt/webpack-cli","description":"Webpack's Command Line Interface","fork":true,"url":"https://api.github.com/repos/dhruvdutt/webpack-cli","forks_url":"https://api.github.com/repos/dhruvdutt/webpack-cli/forks","keys_url":"https://api.github.com/repos/dhruvdutt/webpack-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dhruvdutt/webpack-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dhruvdutt/webpack-cli/teams","hooks_url":"https://api.github.com/repos/dhruvdutt/webpack-cli/hooks","issue_events_url":"https://api.github.com/repos/dhruvdutt/webpack-cli/issues/events{/number}","events_url":"https://api.github.com/repos/dhruvdutt/webpack-cli/events","assignees_url":"https://api.github.com/repos/dhruvdutt/webpack-cli/assignees{/user}","branches_url":"https://api.github.com/repos/dhruvdutt/webpack-cli/branches{/branch}","tags_url":"https://api.github.com/repos/dhruvdutt/webpack-cli/tags","blobs_url":"https://api.github.com/repos/dhruvdutt/webpack-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dhruvdutt/webpack-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dhruvdutt/webpack-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/dhruvdutt/webpack-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dhruvdutt/webpack-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/dhruvdutt/webpack-cli/languages","stargazers_url":"https://api.github.com/repos/dhruvdutt/webpack-cli/stargazers","contributors_url":"https://api.github.com/repos/dhruvdutt/webpack-cli/contributors","subscribers_url":"https://api.github.com/repos/dhruvdutt/webpack-cli/subscribers","subscription_url":"https://api.github.com/repos/dhruvdutt/webpack-cli/subscription","commits_url":"https://api.github.com/repos/dhruvdutt/webpack-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/dhruvdutt/webpack-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/dhruvdutt/webpack-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/dhruvdutt/webpack-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/dhruvdutt/webpack-cli/contents/{+path}","compare_url":"https://api.github.com/repos/dhruvdutt/webpack-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dhruvdutt/webpack-cli/merges","archive_url":"https://api.github.com/repos/dhruvdutt/webpack-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dhruvdutt/webpack-cli/downloads","issues_url":"https://api.github.com/repos/dhruvdutt/webpack-cli/issues{/number}","pulls_url":"https://api.github.com/repos/dhruvdutt/webpack-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/dhruvdutt/webpack-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/dhruvdutt/webpack-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dhruvdutt/webpack-cli/labels{/name}","releases_url":"https://api.github.com/repos/dhruvdutt/webpack-cli/releases{/id}","deployments_url":"https://api.github.com/repos/dhruvdutt/webpack-cli/deployments","created_at":"2018-02-22T09:21:59Z","updated_at":"2018-03-23T09:57:59Z","pushed_at":"2018-05-23T18:38:16Z","git_url":"git://github.com/dhruvdutt/webpack-cli.git","ssh_url":"git@github.com:dhruvdutt/webpack-cli.git","clone_url":"https://github.com/dhruvdutt/webpack-cli.git","svn_url":"https://github.com/dhruvdutt/webpack-cli","homepage":"https://webpack.js.org/api/cli/","size":3875,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"webpack:next","ref":"next","sha":"8e48e376f3b9377b71d0fa2de294bd0e077ab20a","user":{"login":"webpack","id":2105791,"avatar_url":"https://avatars2.githubusercontent.com/u/2105791?v=4","gravatar_id":"","url":"https://api.github.com/users/webpack","html_url":"https://github.com/webpack","followers_url":"https://api.github.com/users/webpack/followers","following_url":"https://api.github.com/users/webpack/following{/other_user}","gists_url":"https://api.github.com/users/webpack/gists{/gist_id}","starred_url":"https://api.github.com/users/webpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpack/subscriptions","organizations_url":"https://api.github.com/users/webpack/orgs","repos_url":"https://api.github.com/users/webpack/repos","events_url":"https://api.github.com/users/webpack/events{/privacy}","received_events_url":"https://api.github.com/users/webpack/received_events","type":"Organization","site_admin":false},"repo":{"id":76603199,"name":"webpack-cli","full_name":"webpack/webpack-cli","owner":{"login":"webpack","id":2105791,"avatar_url":"https://avatars2.githubusercontent.com/u/2105791?v=4","gravatar_id":"","url":"https://api.github.com/users/webpack","html_url":"https://github.com/webpack","followers_url":"https://api.github.com/users/webpack/followers","following_url":"https://api.github.com/users/webpack/following{/other_user}","gists_url":"https://api.github.com/users/webpack/gists{/gist_id}","starred_url":"https://api.github.com/users/webpack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/webpack/subscriptions","organizations_url":"https://api.github.com/users/webpack/orgs","repos_url":"https://api.github.com/users/webpack/repos","events_url":"https://api.github.com/users/webpack/events{/privacy}","received_events_url":"https://api.github.com/users/webpack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/webpack/webpack-cli","description":"Webpack's Command Line Interface","fork":false,"url":"https://api.github.com/repos/webpack/webpack-cli","forks_url":"https://api.github.com/repos/webpack/webpack-cli/forks","keys_url":"https://api.github.com/repos/webpack/webpack-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/webpack/webpack-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/webpack/webpack-cli/teams","hooks_url":"https://api.github.com/repos/webpack/webpack-cli/hooks","issue_events_url":"https://api.github.com/repos/webpack/webpack-cli/issues/events{/number}","events_url":"https://api.github.com/repos/webpack/webpack-cli/events","assignees_url":"https://api.github.com/repos/webpack/webpack-cli/assignees{/user}","branches_url":"https://api.github.com/repos/webpack/webpack-cli/branches{/branch}","tags_url":"https://api.github.com/repos/webpack/webpack-cli/tags","blobs_url":"https://api.github.com/repos/webpack/webpack-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/webpack/webpack-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/webpack/webpack-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/webpack/webpack-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/webpack/webpack-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/webpack/webpack-cli/languages","stargazers_url":"https://api.github.com/repos/webpack/webpack-cli/stargazers","contributors_url":"https://api.github.com/repos/webpack/webpack-cli/contributors","subscribers_url":"https://api.github.com/repos/webpack/webpack-cli/subscribers","subscription_url":"https://api.github.com/repos/webpack/webpack-cli/subscription","commits_url":"https://api.github.com/repos/webpack/webpack-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/webpack/webpack-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/webpack/webpack-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/webpack/webpack-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/webpack/webpack-cli/contents/{+path}","compare_url":"https://api.github.com/repos/webpack/webpack-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/webpack/webpack-cli/merges","archive_url":"https://api.github.com/repos/webpack/webpack-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/webpack/webpack-cli/downloads","issues_url":"https://api.github.com/repos/webpack/webpack-cli/issues{/number}","pulls_url":"https://api.github.com/repos/webpack/webpack-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/webpack/webpack-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/webpack/webpack-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/webpack/webpack-cli/labels{/name}","releases_url":"https://api.github.com/repos/webpack/webpack-cli/releases{/id}","deployments_url":"https://api.github.com/repos/webpack/webpack-cli/deployments","created_at":"2016-12-15T23:05:08Z","updated_at":"2018-05-23T16:06:50Z","pushed_at":"2018-05-23T18:39:40Z","git_url":"git://github.com/webpack/webpack-cli.git","ssh_url":"git@github.com:webpack/webpack-cli.git","clone_url":"https://github.com/webpack/webpack-cli.git","svn_url":"https://github.com/webpack/webpack-cli","homepage":"https://webpack.js.org/api/cli/","size":3718,"stargazers_count":847,"watchers_count":847,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":125,"mirror_url":null,"archived":false,"open_issues_count":24,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":125,"open_issues":24,"watchers":847,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/webpack/webpack-cli/pulls/456"},"html":{"href":"https://github.com/webpack/webpack-cli/pull/456"},"issue":{"href":"https://api.github.com/repos/webpack/webpack-cli/issues/456"},"comments":{"href":"https://api.github.com/repos/webpack/webpack-cli/issues/456/comments"},"review_comments":{"href":"https://api.github.com/repos/webpack/webpack-cli/pulls/456/comments"},"review_comment":{"href":"https://api.github.com/repos/webpack/webpack-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/webpack/webpack-cli/pulls/456/commits"},"statuses":{"href":"https://api.github.com/repos/webpack/webpack-cli/statuses/e4d80be7fe76c72e73c159733afae323adb490a3"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ematipico"}}