{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/docs/issues/2930","repository_url":"https://api.github.com/repos/cockroachdb/docs","labels_url":"https://api.github.com/repos/cockroachdb/docs/issues/2930/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/docs/issues/2930/comments","events_url":"https://api.github.com/repos/cockroachdb/docs/issues/2930/events","html_url":"https://github.com/cockroachdb/docs/pull/2930","id":314799382,"number":2930,"title":"Add docs for SHOW EXPERIMENTAL_RANGES","user":{"login":"rmloveland","id":1312291,"avatar_url":"https://avatars3.githubusercontent.com/u/1312291?v=4","gravatar_id":"","url":"https://api.github.com/users/rmloveland","html_url":"https://github.com/rmloveland","followers_url":"https://api.github.com/users/rmloveland/followers","following_url":"https://api.github.com/users/rmloveland/following{/other_user}","gists_url":"https://api.github.com/users/rmloveland/gists{/gist_id}","starred_url":"https://api.github.com/users/rmloveland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmloveland/subscriptions","organizations_url":"https://api.github.com/users/rmloveland/orgs","repos_url":"https://api.github.com/users/rmloveland/repos","events_url":"https://api.github.com/users/rmloveland/events{/privacy}","received_events_url":"https://api.github.com/users/rmloveland/received_events","type":"User","site_admin":false},"labels":[{"id":808984040,"url":"https://api.github.com/repos/cockroachdb/docs/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-04-16T20:08:57Z","updated_at":"2018-04-18T18:56:59Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/cockroachdb/docs/pulls/2930","html_url":"https://github.com/cockroachdb/docs/pull/2930","diff_url":"https://github.com/cockroachdb/docs/pull/2930.diff","patch_url":"https://github.com/cockroachdb/docs/pull/2930.patch"},"body":"Fixes #2282 \r\n\r\nRelated:\r\n- https://github.com/cockroachdb/cockroach/pull/14390\r\n- https://github.com/cockroachdb/cockroach/pull/24696\r\n\r\nSpecific changes:\r\n\r\n- Add a statement page for `SHOW EXPERIMENTAL_RANGES`\r\n\r\n- `s/TESTING_RANGES/EXPERIMENTAL_RANGES/g` wherever it was previously\r\n  mentioned, such as in `SPLIT AT`, partitioning docs, and some of the\r\n  trainings\r\n\r\n- Add `SHOW EXPERIMENTAL_RANGES` page(s) to sidebar nav\r\n\r\n- Had to update full SQL diagram so the link to the `show_stmt_ranges`\r\n  nonterminal would work properly\r\n\r\n- Finally, replicated all changes into v2.1 folder"},"comment":{"url":"https://api.github.com/repos/cockroachdb/docs/issues/comments/382493074","html_url":"https://github.com/cockroachdb/docs/pull/2930#issuecomment-382493074","issue_url":"https://api.github.com/repos/cockroachdb/docs/issues/2930","id":382493074,"user":{"login":"lhirata","id":15386648,"avatar_url":"https://avatars0.githubusercontent.com/u/15386648?v=4","gravatar_id":"","url":"https://api.github.com/users/lhirata","html_url":"https://github.com/lhirata","followers_url":"https://api.github.com/users/lhirata/followers","following_url":"https://api.github.com/users/lhirata/following{/other_user}","gists_url":"https://api.github.com/users/lhirata/gists{/gist_id}","starred_url":"https://api.github.com/users/lhirata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lhirata/subscriptions","organizations_url":"https://api.github.com/users/lhirata/orgs","repos_url":"https://api.github.com/users/lhirata/repos","events_url":"https://api.github.com/users/lhirata/events{/privacy}","received_events_url":"https://api.github.com/users/lhirata/received_events","type":"User","site_admin":false},"created_at":"2018-04-18T18:56:59Z","updated_at":"2018-04-18T18:56:59Z","author_association":"CONTRIBUTOR","body":"\n\n\n\nReview status: 0 of 18 files reviewed at latest revision, 15 unresolved discussions, all commit checks successful.\n\n---\n\n*[_includes/sql/v2.0/diagrams/show_ranges.html, line 10 at r1](https://beta.reviewable.io/reviews/cockroachdb/docs/2930#-LANzNTMDPpZ6L582sws:-LAP5Zu2E2THRWfic3Kq:bqqmp3s) ([raw file](https://github.com/cockroachdb/docs/blob/8cae2ccb19160300a0270baa7269d8ccab18d405/_includes/sql/v2.0/diagrams/show_ranges.html#L10)):*\n<details><summary><i>Previously, lhirata wrote…</i></summary><blockquote>\n\nAhh, SQL Railroad diagram rejiggering fun. Let me see if I can explain myself here; otherwise, we can chat.\n\n1. You're correct, the link works as expected and points to the correct statement block.  My thought is that we inline (re: \"pull\" or \"surface\") the EXPERIMENTAL_RANGES and TESTING_RANGES blocks into the show_ranges diagram so that it looks something like:\n\n                 EXPERIMENTAL_RANGES\nSHOW <                                              > FROM TABLE [...]\n                     TESTING_RANGES\n\nIf you inline the two ranges, you would then need to hide TESTING_RANGES (it doesn't show up now currently - I meant it hypothetically). The end result would be SHOW EXPERIMENTAL_RANGES FROM TABLE [...]\n\nTo do this, you add inline and exclude lines in diagrams.go to the show_ranges_stmt object:\n\n```inline: []string{\"ranges_kw\"},\nexclude: []*regexp.Regexp{regexp.MustCompile(\"'TESTING_RANGES'\")},\n</blockquote></details>\n\nblah, my comment didn't seem to render correctly:\n\n```\n                   EXPERIMENTAL_RANGES\nSHOW <                                                  > FROM TABLE table [...]\n                       TESTING_RANGES\n```\n\nTo do this, you add inline and exclude lines in diagrams.go to the show_ranges_stmt object:\n\n```\n\ninline: []string{\"ranges_kw\"},\nexclude: []*regexp.Regexp{regexp.MustCompile(\"'TESTING_RANGES'\")},\n\n```\n\n---\n\n\n*Comments from [Reviewable](https://beta.reviewable.io/reviews/cockroachdb/docs/2930)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"lhirata"}}