{"action":"opened","number":68979,"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/68979","id":217473181,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NDczMTgx","html_url":"https://github.com/kubernetes/kubernetes/pull/68979","diff_url":"https://github.com/kubernetes/kubernetes/pull/68979.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/68979.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/68979","number":68979,"state":"open","locked":false,"title":"Return error from NodeGetInfo","user":{"login":"xing-yang","id":1185309,"node_id":"MDQ6VXNlcjExODUzMDk=","avatar_url":"https://avatars1.githubusercontent.com/u/1185309?v=4","gravatar_id":"","url":"https://api.github.com/users/xing-yang","html_url":"https://github.com/xing-yang","followers_url":"https://api.github.com/users/xing-yang/followers","following_url":"https://api.github.com/users/xing-yang/following{/other_user}","gists_url":"https://api.github.com/users/xing-yang/gists{/gist_id}","starred_url":"https://api.github.com/users/xing-yang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xing-yang/subscriptions","organizations_url":"https://api.github.com/users/xing-yang/orgs","repos_url":"https://api.github.com/users/xing-yang/repos","events_url":"https://api.github.com/users/xing-yang/events{/privacy}","received_events_url":"https://api.github.com/users/xing-yang/received_events","type":"User","site_admin":false},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/guide#your-first-contribution and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/guide/release-notes.md\r\n4. If the PR is unfinished, see how to mark it: https://git.k8s.io/community/contributors/guide/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\nThis PR checks if NodeGetInfo returns error. If so, it returns\r\nthe error.\r\n\r\nWithout this change, it always returns no error (nil)\r\nregardless of whether NodeGetInfo returns error.\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\n\r\n```\r\n","created_at":"2018-09-22T19:05:43Z","updated_at":"2018-09-22T19:05:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/68979/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/68979/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/68979/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/0a140867920a92e226b6ec0c7d698c850a9fe212","head":{"label":"xing-yang:nodeinfo","ref":"nodeinfo","sha":"0a140867920a92e226b6ec0c7d698c850a9fe212","user":{"login":"xing-yang","id":1185309,"node_id":"MDQ6VXNlcjExODUzMDk=","avatar_url":"https://avatars1.githubusercontent.com/u/1185309?v=4","gravatar_id":"","url":"https://api.github.com/users/xing-yang","html_url":"https://github.com/xing-yang","followers_url":"https://api.github.com/users/xing-yang/followers","following_url":"https://api.github.com/users/xing-yang/following{/other_user}","gists_url":"https://api.github.com/users/xing-yang/gists{/gist_id}","starred_url":"https://api.github.com/users/xing-yang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xing-yang/subscriptions","organizations_url":"https://api.github.com/users/xing-yang/orgs","repos_url":"https://api.github.com/users/xing-yang/repos","events_url":"https://api.github.com/users/xing-yang/events{/privacy}","received_events_url":"https://api.github.com/users/xing-yang/received_events","type":"User","site_admin":false},"repo":{"id":127035774,"node_id":"MDEwOlJlcG9zaXRvcnkxMjcwMzU3NzQ=","name":"kubernetes","full_name":"xing-yang/kubernetes","private":false,"owner":{"login":"xing-yang","id":1185309,"node_id":"MDQ6VXNlcjExODUzMDk=","avatar_url":"https://avatars1.githubusercontent.com/u/1185309?v=4","gravatar_id":"","url":"https://api.github.com/users/xing-yang","html_url":"https://github.com/xing-yang","followers_url":"https://api.github.com/users/xing-yang/followers","following_url":"https://api.github.com/users/xing-yang/following{/other_user}","gists_url":"https://api.github.com/users/xing-yang/gists{/gist_id}","starred_url":"https://api.github.com/users/xing-yang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xing-yang/subscriptions","organizations_url":"https://api.github.com/users/xing-yang/orgs","repos_url":"https://api.github.com/users/xing-yang/repos","events_url":"https://api.github.com/users/xing-yang/events{/privacy}","received_events_url":"https://api.github.com/users/xing-yang/received_events","type":"User","site_admin":false},"html_url":"https://github.com/xing-yang/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/xing-yang/kubernetes","forks_url":"https://api.github.com/repos/xing-yang/kubernetes/forks","keys_url":"https://api.github.com/repos/xing-yang/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xing-yang/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xing-yang/kubernetes/teams","hooks_url":"https://api.github.com/repos/xing-yang/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/xing-yang/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/xing-yang/kubernetes/events","assignees_url":"https://api.github.com/repos/xing-yang/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/xing-yang/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/xing-yang/kubernetes/tags","blobs_url":"https://api.github.com/repos/xing-yang/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xing-yang/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xing-yang/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/xing-yang/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xing-yang/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/xing-yang/kubernetes/languages","stargazers_url":"https://api.github.com/repos/xing-yang/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/xing-yang/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/xing-yang/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/xing-yang/kubernetes/subscription","commits_url":"https://api.github.com/repos/xing-yang/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/xing-yang/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/xing-yang/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/xing-yang/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/xing-yang/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/xing-yang/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xing-yang/kubernetes/merges","archive_url":"https://api.github.com/repos/xing-yang/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xing-yang/kubernetes/downloads","issues_url":"https://api.github.com/repos/xing-yang/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/xing-yang/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/xing-yang/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/xing-yang/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xing-yang/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/xing-yang/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/xing-yang/kubernetes/deployments","created_at":"2018-03-27T19:26:20Z","updated_at":"2018-03-27T19:26:53Z","pushed_at":"2018-09-22T19:03:16Z","git_url":"git://github.com/xing-yang/kubernetes.git","ssh_url":"git@github.com:xing-yang/kubernetes.git","clone_url":"https://github.com/xing-yang/kubernetes.git","svn_url":"https://github.com/xing-yang/kubernetes","homepage":"http://kubernetes.io","size":586543,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"488f0fcda3f9baaab560435488ec9fd0a83401b1","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"node_id":"MDEwOlJlcG9zaXRvcnkyMDU4MDQ5OA==","name":"kubernetes","full_name":"kubernetes/kubernetes","private":false,"owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2018-09-22T18:00:18Z","pushed_at":"2018-09-22T18:22:48Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":809652,"stargazers_count":41705,"watchers_count":41705,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14480,"mirror_url":null,"archived":false,"open_issues_count":3274,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":14480,"open_issues":3274,"watchers":41705,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/68979"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/68979"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/68979"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/68979/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/68979/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/68979/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/0a140867920a92e226b6ec0c7d698c850a9fe212"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":4,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"xing-yang"}}