{"action":"created","comment":{"url":"https://api.github.com/repos/Deducteam/Dedukti/pulls/comments/216257498","pull_request_review_id":153694740,"id":216257498,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjI1NzQ5OA==","diff_hunk":"@@ -29,7 +37,11 @@ val default_cfg : red_cfg\n *)\n \n val reduction : red_cfg -> Signature.t -> term -> term\n-(** [reduction sg red te] reduces the term [te] following the strategy [red]\n+(** [reduction cfg sg te] reduces the term [te] following the configuration [cfg]\n+    and using the signature [sg]. *)\n+\n+val quick_reduction : red_target -> Signature.t -> term -> term","path":"kernel/reduction.mli","position":51,"original_position":51,"commit_id":"d50cb36f3c6f72f42f092655a65cf4156944855e","original_commit_id":"d50cb36f3c6f72f42f092655a65cf4156944855e","user":{"login":"Gaspi","id":3737683,"node_id":"MDQ6VXNlcjM3Mzc2ODM=","avatar_url":"https://avatars0.githubusercontent.com/u/3737683?v=4","gravatar_id":"","url":"https://api.github.com/users/Gaspi","html_url":"https://github.com/Gaspi","followers_url":"https://api.github.com/users/Gaspi/followers","following_url":"https://api.github.com/users/Gaspi/following{/other_user}","gists_url":"https://api.github.com/users/Gaspi/gists{/gist_id}","starred_url":"https://api.github.com/users/Gaspi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gaspi/subscriptions","organizations_url":"https://api.github.com/users/Gaspi/orgs","repos_url":"https://api.github.com/users/Gaspi/repos","events_url":"https://api.github.com/users/Gaspi/events{/privacy}","received_events_url":"https://api.github.com/users/Gaspi/received_events","type":"User","site_admin":false},"body":"It's not exactly the same, this version is slightly more efficient (hence the \"quick\" keyword which should actually have rather been \"fast\") because it relies on a stripped down version of state_whnf/snf that doesn't remember current rewriting position and doesn't try to log anything.","created_at":"2018-09-10T09:36:36Z","updated_at":"2018-09-10T09:36:36Z","html_url":"https://github.com/Deducteam/Dedukti/pull/117#discussion_r216257498","pull_request_url":"https://api.github.com/repos/Deducteam/Dedukti/pulls/117","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Deducteam/Dedukti/pulls/comments/216257498"},"html":{"href":"https://github.com/Deducteam/Dedukti/pull/117#discussion_r216257498"},"pull_request":{"href":"https://api.github.com/repos/Deducteam/Dedukti/pulls/117"}},"in_reply_to_id":216238334},"pull_request":{"url":"https://api.github.com/repos/Deducteam/Dedukti/pulls/117","id":213238913,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzMjM4OTEz","html_url":"https://github.com/Deducteam/Dedukti/pull/117","diff_url":"https://github.com/Deducteam/Dedukti/pull/117.diff","patch_url":"https://github.com/Deducteam/Dedukti/pull/117.patch","issue_url":"https://api.github.com/repos/Deducteam/Dedukti/issues/117","number":117,"state":"open","locked":false,"title":"New reduction engine","user":{"login":"Gaspi","id":3737683,"node_id":"MDQ6VXNlcjM3Mzc2ODM=","avatar_url":"https://avatars0.githubusercontent.com/u/3737683?v=4","gravatar_id":"","url":"https://api.github.com/users/Gaspi","html_url":"https://github.com/Gaspi","followers_url":"https://api.github.com/users/Gaspi/followers","following_url":"https://api.github.com/users/Gaspi/following{/other_user}","gists_url":"https://api.github.com/users/Gaspi/gists{/gist_id}","starred_url":"https://api.github.com/users/Gaspi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gaspi/subscriptions","organizations_url":"https://api.github.com/users/Gaspi/orgs","repos_url":"https://api.github.com/users/Gaspi/repos","events_url":"https://api.github.com/users/Gaspi/events{/privacy}","received_events_url":"https://api.github.com/users/Gaspi/received_events","type":"User","site_admin":false},"body":"Re-implementing API's reduction engine to allow:\r\n- Made the distinction between *strategy* (call-by-value, call-by-name, etc) and *target* (WHNF, SNF, etc)\r\n- Allowed to custom-log all reduction steps (subterm position, rule name, reduct)\r\n- Removed HNF","created_at":"2018-09-05T10:09:58Z","updated_at":"2018-09-10T09:36:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"560a4c62891a27d2e177c6d07a519d66f1fb8533","assignee":{"login":"Gaspi","id":3737683,"node_id":"MDQ6VXNlcjM3Mzc2ODM=","avatar_url":"https://avatars0.githubusercontent.com/u/3737683?v=4","gravatar_id":"","url":"https://api.github.com/users/Gaspi","html_url":"https://github.com/Gaspi","followers_url":"https://api.github.com/users/Gaspi/followers","following_url":"https://api.github.com/users/Gaspi/following{/other_user}","gists_url":"https://api.github.com/users/Gaspi/gists{/gist_id}","starred_url":"https://api.github.com/users/Gaspi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gaspi/subscriptions","organizations_url":"https://api.github.com/users/Gaspi/orgs","repos_url":"https://api.github.com/users/Gaspi/repos","events_url":"https://api.github.com/users/Gaspi/events{/privacy}","received_events_url":"https://api.github.com/users/Gaspi/received_events","type":"User","site_admin":false},"assignees":[{"login":"Gaspi","id":3737683,"node_id":"MDQ6VXNlcjM3Mzc2ODM=","avatar_url":"https://avatars0.githubusercontent.com/u/3737683?v=4","gravatar_id":"","url":"https://api.github.com/users/Gaspi","html_url":"https://github.com/Gaspi","followers_url":"https://api.github.com/users/Gaspi/followers","following_url":"https://api.github.com/users/Gaspi/following{/other_user}","gists_url":"https://api.github.com/users/Gaspi/gists{/gist_id}","starred_url":"https://api.github.com/users/Gaspi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Gaspi/subscriptions","organizations_url":"https://api.github.com/users/Gaspi/orgs","repos_url":"https://api.github.com/users/Gaspi/repos","events_url":"https://api.github.com/users/Gaspi/events{/privacy}","received_events_url":"https://api.github.com/users/Gaspi/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Deducteam/Dedukti/pulls/117/commits","review_comments_url":"https://api.github.com/repos/Deducteam/Dedukti/pulls/117/comments","review_comment_url":"https://api.github.com/repos/Deducteam/Dedukti/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Deducteam/Dedukti/issues/117/comments","statuses_url":"https://api.github.com/repos/Deducteam/Dedukti/statuses/d50cb36f3c6f72f42f092655a65cf4156944855e","head":{"label":"Deducteam:reduction-logger","ref":"reduction-logger","sha":"d50cb36f3c6f72f42f092655a65cf4156944855e","user":{"login":"Deducteam","id":32068788,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMDY4Nzg4","avatar_url":"https://avatars0.githubusercontent.com/u/32068788?v=4","gravatar_id":"","url":"https://api.github.com/users/Deducteam","html_url":"https://github.com/Deducteam","followers_url":"https://api.github.com/users/Deducteam/followers","following_url":"https://api.github.com/users/Deducteam/following{/other_user}","gists_url":"https://api.github.com/users/Deducteam/gists{/gist_id}","starred_url":"https://api.github.com/users/Deducteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Deducteam/subscriptions","organizations_url":"https://api.github.com/users/Deducteam/orgs","repos_url":"https://api.github.com/users/Deducteam/repos","events_url":"https://api.github.com/users/Deducteam/events{/privacy}","received_events_url":"https://api.github.com/users/Deducteam/received_events","type":"Organization","site_admin":false},"repo":{"id":110989039,"node_id":"MDEwOlJlcG9zaXRvcnkxMTA5ODkwMzk=","name":"Dedukti","full_name":"Deducteam/Dedukti","owner":{"login":"Deducteam","id":32068788,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMDY4Nzg4","avatar_url":"https://avatars0.githubusercontent.com/u/32068788?v=4","gravatar_id":"","url":"https://api.github.com/users/Deducteam","html_url":"https://github.com/Deducteam","followers_url":"https://api.github.com/users/Deducteam/followers","following_url":"https://api.github.com/users/Deducteam/following{/other_user}","gists_url":"https://api.github.com/users/Deducteam/gists{/gist_id}","starred_url":"https://api.github.com/users/Deducteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Deducteam/subscriptions","organizations_url":"https://api.github.com/users/Deducteam/orgs","repos_url":"https://api.github.com/users/Deducteam/repos","events_url":"https://api.github.com/users/Deducteam/events{/privacy}","received_events_url":"https://api.github.com/users/Deducteam/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Deducteam/Dedukti","description":"Implementation of the λΠ-calculus modulo rewriting","fork":false,"url":"https://api.github.com/repos/Deducteam/Dedukti","forks_url":"https://api.github.com/repos/Deducteam/Dedukti/forks","keys_url":"https://api.github.com/repos/Deducteam/Dedukti/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Deducteam/Dedukti/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Deducteam/Dedukti/teams","hooks_url":"https://api.github.com/repos/Deducteam/Dedukti/hooks","issue_events_url":"https://api.github.com/repos/Deducteam/Dedukti/issues/events{/number}","events_url":"https://api.github.com/repos/Deducteam/Dedukti/events","assignees_url":"https://api.github.com/repos/Deducteam/Dedukti/assignees{/user}","branches_url":"https://api.github.com/repos/Deducteam/Dedukti/branches{/branch}","tags_url":"https://api.github.com/repos/Deducteam/Dedukti/tags","blobs_url":"https://api.github.com/repos/Deducteam/Dedukti/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Deducteam/Dedukti/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Deducteam/Dedukti/git/refs{/sha}","trees_url":"https://api.github.com/repos/Deducteam/Dedukti/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Deducteam/Dedukti/statuses/{sha}","languages_url":"https://api.github.com/repos/Deducteam/Dedukti/languages","stargazers_url":"https://api.github.com/repos/Deducteam/Dedukti/stargazers","contributors_url":"https://api.github.com/repos/Deducteam/Dedukti/contributors","subscribers_url":"https://api.github.com/repos/Deducteam/Dedukti/subscribers","subscription_url":"https://api.github.com/repos/Deducteam/Dedukti/subscription","commits_url":"https://api.github.com/repos/Deducteam/Dedukti/commits{/sha}","git_commits_url":"https://api.github.com/repos/Deducteam/Dedukti/git/commits{/sha}","comments_url":"https://api.github.com/repos/Deducteam/Dedukti/comments{/number}","issue_comment_url":"https://api.github.com/repos/Deducteam/Dedukti/issues/comments{/number}","contents_url":"https://api.github.com/repos/Deducteam/Dedukti/contents/{+path}","compare_url":"https://api.github.com/repos/Deducteam/Dedukti/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Deducteam/Dedukti/merges","archive_url":"https://api.github.com/repos/Deducteam/Dedukti/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Deducteam/Dedukti/downloads","issues_url":"https://api.github.com/repos/Deducteam/Dedukti/issues{/number}","pulls_url":"https://api.github.com/repos/Deducteam/Dedukti/pulls{/number}","milestones_url":"https://api.github.com/repos/Deducteam/Dedukti/milestones{/number}","notifications_url":"https://api.github.com/repos/Deducteam/Dedukti/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Deducteam/Dedukti/labels{/name}","releases_url":"https://api.github.com/repos/Deducteam/Dedukti/releases{/id}","deployments_url":"https://api.github.com/repos/Deducteam/Dedukti/deployments","created_at":"2017-11-16T15:34:07Z","updated_at":"2018-09-08T05:19:32Z","pushed_at":"2018-09-10T08:58:33Z","git_url":"git://github.com/Deducteam/Dedukti.git","ssh_url":"git@github.com:Deducteam/Dedukti.git","clone_url":"https://github.com/Deducteam/Dedukti.git","svn_url":"https://github.com/Deducteam/Dedukti","homepage":"https://deducteam.github.io","size":5333,"stargazers_count":37,"watchers_count":37,"language":"OCaml","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":40,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":7,"open_issues":40,"watchers":37,"default_branch":"master"}},"base":{"label":"Deducteam:master","ref":"master","sha":"b81518a3572583df74185ce6651c15445263ce87","user":{"login":"Deducteam","id":32068788,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMDY4Nzg4","avatar_url":"https://avatars0.githubusercontent.com/u/32068788?v=4","gravatar_id":"","url":"https://api.github.com/users/Deducteam","html_url":"https://github.com/Deducteam","followers_url":"https://api.github.com/users/Deducteam/followers","following_url":"https://api.github.com/users/Deducteam/following{/other_user}","gists_url":"https://api.github.com/users/Deducteam/gists{/gist_id}","starred_url":"https://api.github.com/users/Deducteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Deducteam/subscriptions","organizations_url":"https://api.github.com/users/Deducteam/orgs","repos_url":"https://api.github.com/users/Deducteam/repos","events_url":"https://api.github.com/users/Deducteam/events{/privacy}","received_events_url":"https://api.github.com/users/Deducteam/received_events","type":"Organization","site_admin":false},"repo":{"id":110989039,"node_id":"MDEwOlJlcG9zaXRvcnkxMTA5ODkwMzk=","name":"Dedukti","full_name":"Deducteam/Dedukti","owner":{"login":"Deducteam","id":32068788,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMyMDY4Nzg4","avatar_url":"https://avatars0.githubusercontent.com/u/32068788?v=4","gravatar_id":"","url":"https://api.github.com/users/Deducteam","html_url":"https://github.com/Deducteam","followers_url":"https://api.github.com/users/Deducteam/followers","following_url":"https://api.github.com/users/Deducteam/following{/other_user}","gists_url":"https://api.github.com/users/Deducteam/gists{/gist_id}","starred_url":"https://api.github.com/users/Deducteam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Deducteam/subscriptions","organizations_url":"https://api.github.com/users/Deducteam/orgs","repos_url":"https://api.github.com/users/Deducteam/repos","events_url":"https://api.github.com/users/Deducteam/events{/privacy}","received_events_url":"https://api.github.com/users/Deducteam/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Deducteam/Dedukti","description":"Implementation of the λΠ-calculus modulo rewriting","fork":false,"url":"https://api.github.com/repos/Deducteam/Dedukti","forks_url":"https://api.github.com/repos/Deducteam/Dedukti/forks","keys_url":"https://api.github.com/repos/Deducteam/Dedukti/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Deducteam/Dedukti/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Deducteam/Dedukti/teams","hooks_url":"https://api.github.com/repos/Deducteam/Dedukti/hooks","issue_events_url":"https://api.github.com/repos/Deducteam/Dedukti/issues/events{/number}","events_url":"https://api.github.com/repos/Deducteam/Dedukti/events","assignees_url":"https://api.github.com/repos/Deducteam/Dedukti/assignees{/user}","branches_url":"https://api.github.com/repos/Deducteam/Dedukti/branches{/branch}","tags_url":"https://api.github.com/repos/Deducteam/Dedukti/tags","blobs_url":"https://api.github.com/repos/Deducteam/Dedukti/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Deducteam/Dedukti/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Deducteam/Dedukti/git/refs{/sha}","trees_url":"https://api.github.com/repos/Deducteam/Dedukti/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Deducteam/Dedukti/statuses/{sha}","languages_url":"https://api.github.com/repos/Deducteam/Dedukti/languages","stargazers_url":"https://api.github.com/repos/Deducteam/Dedukti/stargazers","contributors_url":"https://api.github.com/repos/Deducteam/Dedukti/contributors","subscribers_url":"https://api.github.com/repos/Deducteam/Dedukti/subscribers","subscription_url":"https://api.github.com/repos/Deducteam/Dedukti/subscription","commits_url":"https://api.github.com/repos/Deducteam/Dedukti/commits{/sha}","git_commits_url":"https://api.github.com/repos/Deducteam/Dedukti/git/commits{/sha}","comments_url":"https://api.github.com/repos/Deducteam/Dedukti/comments{/number}","issue_comment_url":"https://api.github.com/repos/Deducteam/Dedukti/issues/comments{/number}","contents_url":"https://api.github.com/repos/Deducteam/Dedukti/contents/{+path}","compare_url":"https://api.github.com/repos/Deducteam/Dedukti/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Deducteam/Dedukti/merges","archive_url":"https://api.github.com/repos/Deducteam/Dedukti/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Deducteam/Dedukti/downloads","issues_url":"https://api.github.com/repos/Deducteam/Dedukti/issues{/number}","pulls_url":"https://api.github.com/repos/Deducteam/Dedukti/pulls{/number}","milestones_url":"https://api.github.com/repos/Deducteam/Dedukti/milestones{/number}","notifications_url":"https://api.github.com/repos/Deducteam/Dedukti/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Deducteam/Dedukti/labels{/name}","releases_url":"https://api.github.com/repos/Deducteam/Dedukti/releases{/id}","deployments_url":"https://api.github.com/repos/Deducteam/Dedukti/deployments","created_at":"2017-11-16T15:34:07Z","updated_at":"2018-09-08T05:19:32Z","pushed_at":"2018-09-10T08:58:33Z","git_url":"git://github.com/Deducteam/Dedukti.git","ssh_url":"git@github.com:Deducteam/Dedukti.git","clone_url":"https://github.com/Deducteam/Dedukti.git","svn_url":"https://github.com/Deducteam/Dedukti","homepage":"https://deducteam.github.io","size":5333,"stargazers_count":37,"watchers_count":37,"language":"OCaml","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":40,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":7,"open_issues":40,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Deducteam/Dedukti/pulls/117"},"html":{"href":"https://github.com/Deducteam/Dedukti/pull/117"},"issue":{"href":"https://api.github.com/repos/Deducteam/Dedukti/issues/117"},"comments":{"href":"https://api.github.com/repos/Deducteam/Dedukti/issues/117/comments"},"review_comments":{"href":"https://api.github.com/repos/Deducteam/Dedukti/pulls/117/comments"},"review_comment":{"href":"https://api.github.com/repos/Deducteam/Dedukti/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Deducteam/Dedukti/pulls/117/commits"},"statuses":{"href":"https://api.github.com/repos/Deducteam/Dedukti/statuses/d50cb36f3c6f72f42f092655a65cf4156944855e"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"Gaspi"}}