{"action":"opened","issue":{"url":"https://api.github.com/repos/inadarei/rfc-healthcheck/issues/22","repository_url":"https://api.github.com/repos/inadarei/rfc-healthcheck","labels_url":"https://api.github.com/repos/inadarei/rfc-healthcheck/issues/22/labels{/name}","comments_url":"https://api.github.com/repos/inadarei/rfc-healthcheck/issues/22/comments","events_url":"https://api.github.com/repos/inadarei/rfc-healthcheck/issues/22/events","html_url":"https://github.com/inadarei/rfc-healthcheck/issues/22","id":369468760,"node_id":"MDU6SXNzdWUzNjk0Njg3NjA=","number":22,"title":"Minor feedback","user":{"login":"taliaga","id":4542117,"node_id":"MDQ6VXNlcjQ1NDIxMTc=","avatar_url":"https://avatars1.githubusercontent.com/u/4542117?v=4","gravatar_id":"","url":"https://api.github.com/users/taliaga","html_url":"https://github.com/taliaga","followers_url":"https://api.github.com/users/taliaga/followers","following_url":"https://api.github.com/users/taliaga/following{/other_user}","gists_url":"https://api.github.com/users/taliaga/gists{/gist_id}","starred_url":"https://api.github.com/users/taliaga/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/taliaga/subscriptions","organizations_url":"https://api.github.com/users/taliaga/orgs","repos_url":"https://api.github.com/users/taliaga/repos","events_url":"https://api.github.com/users/taliaga/events{/privacy}","received_events_url":"https://api.github.com/users/taliaga/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-12T09:21:39Z","updated_at":"2018-10-12T09:21:39Z","closed_at":null,"author_association":"NONE","body":"Hi, nice initiative!\r\n\r\nFwiw, here some minor observations from my experience trying your proposal:\r\n\r\n- There's a typo in section 4 (value eside).\r\n- When talking about status:\r\n  - 'warn' is mentioned with a MUST and later with a SHOULD. \r\n  - It may be time-saving for the reader to give some specific examples of which HTTP codes could be used in the returns. It could say 207 for 'warn' and 424 for 'fail' maybe? It's an example of course, but saves time having to go an read all http codes.\r\n- In details, take \"cassandra:connections\" for example. It may be an overkill to use arrays. I believe if this proposal promotes \"hierarchies\" of health reports, then \"cassandra:connections\" should be responsible for aggregating the health of its upstream dependencies. Otherwise it may bring  duplication and/or risk inconsistencies, wouldn't it?\r\n\r\nCheers!"}}
{"actor":{"display_login":"taliaga"}}