{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/maker-bundle/pulls/comments/217590428","pull_request_review_id":155337938,"id":217590428,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzU5MDQyOA==","diff_hunk":"@@ -107,14 +166,62 @@ public function generate(InputInterface $input, ConsoleStyle $io, Generator $gen\n                     $this->fileManager->getFileContents($path),\n                     $input->getOption('firewall-name'),\n                     $input->getOption('entry-point'),\n-                    $classNameDetails->getFullName()\n+                    $input->getArgument('authenticator-class')\n                 );\n                 $generator->dumpFile($path, $newYaml);\n                 $securityYamlUpdated = true;\n             } catch (YamlManipulationFailedException $e) {\n             }\n         }\n \n+        if (self::AUTH_TYPE_FORM_LOGIN === $input->getArgument('authenticator-type')) {","path":"src/Maker/MakeAuthenticator.php","position":186,"original_position":186,"commit_id":"20062fd7cb09c4f46c7b37de8bdc1bbf193c9103","original_commit_id":"20062fd7cb09c4f46c7b37de8bdc1bbf193c9103","user":{"login":"weaverryan","id":121003,"node_id":"MDQ6VXNlcjEyMTAwMw==","avatar_url":"https://avatars1.githubusercontent.com/u/121003?v=4","gravatar_id":"","url":"https://api.github.com/users/weaverryan","html_url":"https://github.com/weaverryan","followers_url":"https://api.github.com/users/weaverryan/followers","following_url":"https://api.github.com/users/weaverryan/following{/other_user}","gists_url":"https://api.github.com/users/weaverryan/gists{/gist_id}","starred_url":"https://api.github.com/users/weaverryan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weaverryan/subscriptions","organizations_url":"https://api.github.com/users/weaverryan/orgs","repos_url":"https://api.github.com/users/weaverryan/repos","events_url":"https://api.github.com/users/weaverryan/events{/privacy}","received_events_url":"https://api.github.com/users/weaverryan/received_events","type":"User","site_admin":false},"body":"Let's put the body of all of this into a private function for readability - e.g. `$this->generateLoginForm(...);`","created_at":"2018-09-14T03:08:14Z","updated_at":"2018-09-14T03:52:49Z","html_url":"https://github.com/symfony/maker-bundle/pull/266#discussion_r217590428","pull_request_url":"https://api.github.com/repos/symfony/maker-bundle/pulls/266","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/symfony/maker-bundle/pulls/comments/217590428"},"html":{"href":"https://github.com/symfony/maker-bundle/pull/266#discussion_r217590428"},"pull_request":{"href":"https://api.github.com/repos/symfony/maker-bundle/pulls/266"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/maker-bundle/pulls/266","id":214708757,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0NzA4NzU3","html_url":"https://github.com/symfony/maker-bundle/pull/266","diff_url":"https://github.com/symfony/maker-bundle/pull/266.diff","patch_url":"https://github.com/symfony/maker-bundle/pull/266.patch","issue_url":"https://api.github.com/repos/symfony/maker-bundle/issues/266","number":266,"state":"open","locked":false,"title":"Make login form","user":{"login":"nikophil","id":10139766,"node_id":"MDQ6VXNlcjEwMTM5NzY2","avatar_url":"https://avatars0.githubusercontent.com/u/10139766?v=4","gravatar_id":"","url":"https://api.github.com/users/nikophil","html_url":"https://github.com/nikophil","followers_url":"https://api.github.com/users/nikophil/followers","following_url":"https://api.github.com/users/nikophil/following{/other_user}","gists_url":"https://api.github.com/users/nikophil/gists{/gist_id}","starred_url":"https://api.github.com/users/nikophil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikophil/subscriptions","organizations_url":"https://api.github.com/users/nikophil/orgs","repos_url":"https://api.github.com/users/nikophil/repos","events_url":"https://api.github.com/users/nikophil/events{/privacy}","received_events_url":"https://api.github.com/users/nikophil/received_events","type":"User","site_admin":false},"body":"Improvements for the command `make:auth` in order to create a form login.\r\nNow, the `make:auth` command asks if the user wants an empty authenticator or a form login.\r\nIf \"form login\" is chosen, the user  is asked for the security controller name, and for the user class, if needed.\r\nIf the controller already exists, the command adds the login / logout methods in the existing controller.\r\n","created_at":"2018-09-11T17:31:05Z","updated_at":"2018-09-14T03:52:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"48791945eb2fe725419b72d3222ebdc89183da99","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/symfony/maker-bundle/pulls/266/commits","review_comments_url":"https://api.github.com/repos/symfony/maker-bundle/pulls/266/comments","review_comment_url":"https://api.github.com/repos/symfony/maker-bundle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/maker-bundle/issues/266/comments","statuses_url":"https://api.github.com/repos/symfony/maker-bundle/statuses/20062fd7cb09c4f46c7b37de8bdc1bbf193c9103","head":{"label":"nikophil:make-login-form","ref":"make-login-form","sha":"20062fd7cb09c4f46c7b37de8bdc1bbf193c9103","user":{"login":"nikophil","id":10139766,"node_id":"MDQ6VXNlcjEwMTM5NzY2","avatar_url":"https://avatars0.githubusercontent.com/u/10139766?v=4","gravatar_id":"","url":"https://api.github.com/users/nikophil","html_url":"https://github.com/nikophil","followers_url":"https://api.github.com/users/nikophil/followers","following_url":"https://api.github.com/users/nikophil/following{/other_user}","gists_url":"https://api.github.com/users/nikophil/gists{/gist_id}","starred_url":"https://api.github.com/users/nikophil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikophil/subscriptions","organizations_url":"https://api.github.com/users/nikophil/orgs","repos_url":"https://api.github.com/users/nikophil/repos","events_url":"https://api.github.com/users/nikophil/events{/privacy}","received_events_url":"https://api.github.com/users/nikophil/received_events","type":"User","site_admin":false},"repo":{"id":144296007,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQyOTYwMDc=","name":"maker-bundle","full_name":"nikophil/maker-bundle","owner":{"login":"nikophil","id":10139766,"node_id":"MDQ6VXNlcjEwMTM5NzY2","avatar_url":"https://avatars0.githubusercontent.com/u/10139766?v=4","gravatar_id":"","url":"https://api.github.com/users/nikophil","html_url":"https://github.com/nikophil","followers_url":"https://api.github.com/users/nikophil/followers","following_url":"https://api.github.com/users/nikophil/following{/other_user}","gists_url":"https://api.github.com/users/nikophil/gists{/gist_id}","starred_url":"https://api.github.com/users/nikophil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikophil/subscriptions","organizations_url":"https://api.github.com/users/nikophil/orgs","repos_url":"https://api.github.com/users/nikophil/repos","events_url":"https://api.github.com/users/nikophil/events{/privacy}","received_events_url":"https://api.github.com/users/nikophil/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nikophil/maker-bundle","description":"Symfony Maker Bundle","fork":true,"url":"https://api.github.com/repos/nikophil/maker-bundle","forks_url":"https://api.github.com/repos/nikophil/maker-bundle/forks","keys_url":"https://api.github.com/repos/nikophil/maker-bundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nikophil/maker-bundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nikophil/maker-bundle/teams","hooks_url":"https://api.github.com/repos/nikophil/maker-bundle/hooks","issue_events_url":"https://api.github.com/repos/nikophil/maker-bundle/issues/events{/number}","events_url":"https://api.github.com/repos/nikophil/maker-bundle/events","assignees_url":"https://api.github.com/repos/nikophil/maker-bundle/assignees{/user}","branches_url":"https://api.github.com/repos/nikophil/maker-bundle/branches{/branch}","tags_url":"https://api.github.com/repos/nikophil/maker-bundle/tags","blobs_url":"https://api.github.com/repos/nikophil/maker-bundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nikophil/maker-bundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nikophil/maker-bundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/nikophil/maker-bundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nikophil/maker-bundle/statuses/{sha}","languages_url":"https://api.github.com/repos/nikophil/maker-bundle/languages","stargazers_url":"https://api.github.com/repos/nikophil/maker-bundle/stargazers","contributors_url":"https://api.github.com/repos/nikophil/maker-bundle/contributors","subscribers_url":"https://api.github.com/repos/nikophil/maker-bundle/subscribers","subscription_url":"https://api.github.com/repos/nikophil/maker-bundle/subscription","commits_url":"https://api.github.com/repos/nikophil/maker-bundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/nikophil/maker-bundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/nikophil/maker-bundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/nikophil/maker-bundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/nikophil/maker-bundle/contents/{+path}","compare_url":"https://api.github.com/repos/nikophil/maker-bundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nikophil/maker-bundle/merges","archive_url":"https://api.github.com/repos/nikophil/maker-bundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nikophil/maker-bundle/downloads","issues_url":"https://api.github.com/repos/nikophil/maker-bundle/issues{/number}","pulls_url":"https://api.github.com/repos/nikophil/maker-bundle/pulls{/number}","milestones_url":"https://api.github.com/repos/nikophil/maker-bundle/milestones{/number}","notifications_url":"https://api.github.com/repos/nikophil/maker-bundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nikophil/maker-bundle/labels{/name}","releases_url":"https://api.github.com/repos/nikophil/maker-bundle/releases{/id}","deployments_url":"https://api.github.com/repos/nikophil/maker-bundle/deployments","created_at":"2018-08-10T14:26:04Z","updated_at":"2018-08-10T14:28:49Z","pushed_at":"2018-09-13T13:39:25Z","git_url":"git://github.com/nikophil/maker-bundle.git","ssh_url":"git@github.com:nikophil/maker-bundle.git","clone_url":"https://github.com/nikophil/maker-bundle.git","svn_url":"https://github.com/nikophil/maker-bundle","homepage":"https://symfony.com/","size":713,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"7fd05809b178c45a9eb12d8f0dd2a47c59aa57ac","user":{"login":"symfony","id":143937,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzkzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/143937?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":109984157,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk5ODQxNTc=","name":"maker-bundle","full_name":"symfony/maker-bundle","owner":{"login":"symfony","id":143937,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzkzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/143937?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/maker-bundle","description":"Symfony Maker Bundle","fork":false,"url":"https://api.github.com/repos/symfony/maker-bundle","forks_url":"https://api.github.com/repos/symfony/maker-bundle/forks","keys_url":"https://api.github.com/repos/symfony/maker-bundle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/maker-bundle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/maker-bundle/teams","hooks_url":"https://api.github.com/repos/symfony/maker-bundle/hooks","issue_events_url":"https://api.github.com/repos/symfony/maker-bundle/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/maker-bundle/events","assignees_url":"https://api.github.com/repos/symfony/maker-bundle/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/maker-bundle/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/maker-bundle/tags","blobs_url":"https://api.github.com/repos/symfony/maker-bundle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/maker-bundle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/maker-bundle/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/maker-bundle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/maker-bundle/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/maker-bundle/languages","stargazers_url":"https://api.github.com/repos/symfony/maker-bundle/stargazers","contributors_url":"https://api.github.com/repos/symfony/maker-bundle/contributors","subscribers_url":"https://api.github.com/repos/symfony/maker-bundle/subscribers","subscription_url":"https://api.github.com/repos/symfony/maker-bundle/subscription","commits_url":"https://api.github.com/repos/symfony/maker-bundle/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/maker-bundle/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/maker-bundle/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/maker-bundle/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/maker-bundle/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/maker-bundle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/maker-bundle/merges","archive_url":"https://api.github.com/repos/symfony/maker-bundle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/maker-bundle/downloads","issues_url":"https://api.github.com/repos/symfony/maker-bundle/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/maker-bundle/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/maker-bundle/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/maker-bundle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/maker-bundle/labels{/name}","releases_url":"https://api.github.com/repos/symfony/maker-bundle/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/maker-bundle/deployments","created_at":"2017-11-08T14:10:03Z","updated_at":"2018-09-14T03:33:32Z","pushed_at":"2018-09-14T02:34:17Z","git_url":"git://github.com/symfony/maker-bundle.git","ssh_url":"git@github.com:symfony/maker-bundle.git","clone_url":"https://github.com/symfony/maker-bundle.git","svn_url":"https://github.com/symfony/maker-bundle","homepage":"https://symfony.com/","size":708,"stargazers_count":1133,"watchers_count":1133,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":84,"mirror_url":null,"archived":false,"open_issues_count":55,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":84,"open_issues":55,"watchers":1133,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/maker-bundle/pulls/266"},"html":{"href":"https://github.com/symfony/maker-bundle/pull/266"},"issue":{"href":"https://api.github.com/repos/symfony/maker-bundle/issues/266"},"comments":{"href":"https://api.github.com/repos/symfony/maker-bundle/issues/266/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/maker-bundle/pulls/266/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/maker-bundle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/maker-bundle/pulls/266/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/maker-bundle/statuses/20062fd7cb09c4f46c7b37de8bdc1bbf193c9103"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"weaverryan"}}