{"action":"closed","number":11030,"pull_request":{"url":"https://api.github.com/repos/opencv/opencv/pulls/11030","id":173474063,"html_url":"https://github.com/opencv/opencv/pull/11030","diff_url":"https://github.com/opencv/opencv/pull/11030.diff","patch_url":"https://github.com/opencv/opencv/pull/11030.patch","issue_url":"https://api.github.com/repos/opencv/opencv/issues/11030","number":11030,"state":"closed","locked":false,"title":"Update OpenCVDownload.cmake to fix log crash","user":{"login":"jchazalon","id":6526137,"avatar_url":"https://avatars3.githubusercontent.com/u/6526137?v=4","gravatar_id":"","url":"https://api.github.com/users/jchazalon","html_url":"https://github.com/jchazalon","followers_url":"https://api.github.com/users/jchazalon/followers","following_url":"https://api.github.com/users/jchazalon/following{/other_user}","gists_url":"https://api.github.com/users/jchazalon/gists{/gist_id}","starred_url":"https://api.github.com/users/jchazalon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jchazalon/subscriptions","organizations_url":"https://api.github.com/users/jchazalon/orgs","repos_url":"https://api.github.com/users/jchazalon/repos","events_url":"https://api.github.com/users/jchazalon/events{/privacy}","received_events_url":"https://api.github.com/users/jchazalon/received_events","type":"User","site_admin":false},"body":"<!-- Please use this line to close one or multiple issues when this pullrequest gets merged\r\nYou can add another line right under the first one:\r\nresolves #1234\r\nresolves #1235\r\n-->\r\n\r\n\r\n### This pullrequest changes\r\n\r\n<!-- Please describe what your pullrequest is changing -->\r\nThis PR changes the file `opencv-3.4.1/cmake/OpenCVDownload.cmake`. \r\nIt suppresses the interpretation of string literals by switching `ocv_download_log` from a macro to a function.\r\n\r\nThis avoid the interpretation of string literals, which is one of the root causes for build errors in opencv_contrib because the output of libcurl (used to download extra files) can contain characters like `\\,`which get interpreted and produce errors.\r\n\r\nMore information about the difference between cmake macros and functions is available here:\r\n\r\n- https://stackoverflow.com/questions/14112279/cmake-parse-error-invalid-escape-sequence-o/14113153#14113153\r\n- https://cmake.org/cmake/help/v2.8.10/cmake.html#command%3amacro\r\n- https://cmake.org/cmake/help/v2.8.10/cmake.html#command%3afunction\r\n\r\nMore details about the problem this PR fixes are available at:\r\n\r\n- https://github.com/opencv/opencv_contrib/issues/1131\r\n","created_at":"2018-03-07T14:50:16Z","updated_at":"2018-03-08T17:54:33Z","closed_at":"2018-03-08T17:54:33Z","merged_at":"2018-03-08T17:54:33Z","merge_commit_sha":"bf5f7380cff389033e03700960f86fdcea52b390","assignee":{"login":"alalek","id":4981219,"avatar_url":"https://avatars0.githubusercontent.com/u/4981219?v=4","gravatar_id":"","url":"https://api.github.com/users/alalek","html_url":"https://github.com/alalek","followers_url":"https://api.github.com/users/alalek/followers","following_url":"https://api.github.com/users/alalek/following{/other_user}","gists_url":"https://api.github.com/users/alalek/gists{/gist_id}","starred_url":"https://api.github.com/users/alalek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alalek/subscriptions","organizations_url":"https://api.github.com/users/alalek/orgs","repos_url":"https://api.github.com/users/alalek/repos","events_url":"https://api.github.com/users/alalek/events{/privacy}","received_events_url":"https://api.github.com/users/alalek/received_events","type":"User","site_admin":false},"assignees":[{"login":"alalek","id":4981219,"avatar_url":"https://avatars0.githubusercontent.com/u/4981219?v=4","gravatar_id":"","url":"https://api.github.com/users/alalek","html_url":"https://github.com/alalek","followers_url":"https://api.github.com/users/alalek/followers","following_url":"https://api.github.com/users/alalek/following{/other_user}","gists_url":"https://api.github.com/users/alalek/gists{/gist_id}","starred_url":"https://api.github.com/users/alalek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alalek/subscriptions","organizations_url":"https://api.github.com/users/alalek/orgs","repos_url":"https://api.github.com/users/alalek/repos","events_url":"https://api.github.com/users/alalek/events{/privacy}","received_events_url":"https://api.github.com/users/alalek/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/opencv/opencv/pulls/11030/commits","review_comments_url":"https://api.github.com/repos/opencv/opencv/pulls/11030/comments","review_comment_url":"https://api.github.com/repos/opencv/opencv/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opencv/opencv/issues/11030/comments","statuses_url":"https://api.github.com/repos/opencv/opencv/statuses/bf5f7380cff389033e03700960f86fdcea52b390","head":{"label":"jchazalon:patch-1","ref":"patch-1","sha":"bf5f7380cff389033e03700960f86fdcea52b390","user":{"login":"jchazalon","id":6526137,"avatar_url":"https://avatars3.githubusercontent.com/u/6526137?v=4","gravatar_id":"","url":"https://api.github.com/users/jchazalon","html_url":"https://github.com/jchazalon","followers_url":"https://api.github.com/users/jchazalon/followers","following_url":"https://api.github.com/users/jchazalon/following{/other_user}","gists_url":"https://api.github.com/users/jchazalon/gists{/gist_id}","starred_url":"https://api.github.com/users/jchazalon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jchazalon/subscriptions","organizations_url":"https://api.github.com/users/jchazalon/orgs","repos_url":"https://api.github.com/users/jchazalon/repos","events_url":"https://api.github.com/users/jchazalon/events{/privacy}","received_events_url":"https://api.github.com/users/jchazalon/received_events","type":"User","site_admin":false},"repo":{"id":124247263,"name":"opencv","full_name":"jchazalon/opencv","owner":{"login":"jchazalon","id":6526137,"avatar_url":"https://avatars3.githubusercontent.com/u/6526137?v=4","gravatar_id":"","url":"https://api.github.com/users/jchazalon","html_url":"https://github.com/jchazalon","followers_url":"https://api.github.com/users/jchazalon/followers","following_url":"https://api.github.com/users/jchazalon/following{/other_user}","gists_url":"https://api.github.com/users/jchazalon/gists{/gist_id}","starred_url":"https://api.github.com/users/jchazalon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jchazalon/subscriptions","organizations_url":"https://api.github.com/users/jchazalon/orgs","repos_url":"https://api.github.com/users/jchazalon/repos","events_url":"https://api.github.com/users/jchazalon/events{/privacy}","received_events_url":"https://api.github.com/users/jchazalon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jchazalon/opencv","description":"Open Source Computer Vision Library","fork":true,"url":"https://api.github.com/repos/jchazalon/opencv","forks_url":"https://api.github.com/repos/jchazalon/opencv/forks","keys_url":"https://api.github.com/repos/jchazalon/opencv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jchazalon/opencv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jchazalon/opencv/teams","hooks_url":"https://api.github.com/repos/jchazalon/opencv/hooks","issue_events_url":"https://api.github.com/repos/jchazalon/opencv/issues/events{/number}","events_url":"https://api.github.com/repos/jchazalon/opencv/events","assignees_url":"https://api.github.com/repos/jchazalon/opencv/assignees{/user}","branches_url":"https://api.github.com/repos/jchazalon/opencv/branches{/branch}","tags_url":"https://api.github.com/repos/jchazalon/opencv/tags","blobs_url":"https://api.github.com/repos/jchazalon/opencv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jchazalon/opencv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jchazalon/opencv/git/refs{/sha}","trees_url":"https://api.github.com/repos/jchazalon/opencv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jchazalon/opencv/statuses/{sha}","languages_url":"https://api.github.com/repos/jchazalon/opencv/languages","stargazers_url":"https://api.github.com/repos/jchazalon/opencv/stargazers","contributors_url":"https://api.github.com/repos/jchazalon/opencv/contributors","subscribers_url":"https://api.github.com/repos/jchazalon/opencv/subscribers","subscription_url":"https://api.github.com/repos/jchazalon/opencv/subscription","commits_url":"https://api.github.com/repos/jchazalon/opencv/commits{/sha}","git_commits_url":"https://api.github.com/repos/jchazalon/opencv/git/commits{/sha}","comments_url":"https://api.github.com/repos/jchazalon/opencv/comments{/number}","issue_comment_url":"https://api.github.com/repos/jchazalon/opencv/issues/comments{/number}","contents_url":"https://api.github.com/repos/jchazalon/opencv/contents/{+path}","compare_url":"https://api.github.com/repos/jchazalon/opencv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jchazalon/opencv/merges","archive_url":"https://api.github.com/repos/jchazalon/opencv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jchazalon/opencv/downloads","issues_url":"https://api.github.com/repos/jchazalon/opencv/issues{/number}","pulls_url":"https://api.github.com/repos/jchazalon/opencv/pulls{/number}","milestones_url":"https://api.github.com/repos/jchazalon/opencv/milestones{/number}","notifications_url":"https://api.github.com/repos/jchazalon/opencv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jchazalon/opencv/labels{/name}","releases_url":"https://api.github.com/repos/jchazalon/opencv/releases{/id}","deployments_url":"https://api.github.com/repos/jchazalon/opencv/deployments","created_at":"2018-03-07T14:24:31Z","updated_at":"2018-03-07T14:24:48Z","pushed_at":"2018-03-07T14:35:38Z","git_url":"git://github.com/jchazalon/opencv.git","ssh_url":"git@github.com:jchazalon/opencv.git","clone_url":"https://github.com/jchazalon/opencv.git","svn_url":"https://github.com/jchazalon/opencv","homepage":"https://opencv.org","size":450811,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opencv:master","ref":"master","sha":"8edc2e5aaffa8c349ff9184ae77b3cccdea7cf6e","user":{"login":"opencv","id":5009934,"avatar_url":"https://avatars3.githubusercontent.com/u/5009934?v=4","gravatar_id":"","url":"https://api.github.com/users/opencv","html_url":"https://github.com/opencv","followers_url":"https://api.github.com/users/opencv/followers","following_url":"https://api.github.com/users/opencv/following{/other_user}","gists_url":"https://api.github.com/users/opencv/gists{/gist_id}","starred_url":"https://api.github.com/users/opencv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencv/subscriptions","organizations_url":"https://api.github.com/users/opencv/orgs","repos_url":"https://api.github.com/users/opencv/repos","events_url":"https://api.github.com/users/opencv/events{/privacy}","received_events_url":"https://api.github.com/users/opencv/received_events","type":"Organization","site_admin":false},"repo":{"id":5108051,"name":"opencv","full_name":"opencv/opencv","owner":{"login":"opencv","id":5009934,"avatar_url":"https://avatars3.githubusercontent.com/u/5009934?v=4","gravatar_id":"","url":"https://api.github.com/users/opencv","html_url":"https://github.com/opencv","followers_url":"https://api.github.com/users/opencv/followers","following_url":"https://api.github.com/users/opencv/following{/other_user}","gists_url":"https://api.github.com/users/opencv/gists{/gist_id}","starred_url":"https://api.github.com/users/opencv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencv/subscriptions","organizations_url":"https://api.github.com/users/opencv/orgs","repos_url":"https://api.github.com/users/opencv/repos","events_url":"https://api.github.com/users/opencv/events{/privacy}","received_events_url":"https://api.github.com/users/opencv/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opencv/opencv","description":"Open Source Computer Vision Library","fork":false,"url":"https://api.github.com/repos/opencv/opencv","forks_url":"https://api.github.com/repos/opencv/opencv/forks","keys_url":"https://api.github.com/repos/opencv/opencv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opencv/opencv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opencv/opencv/teams","hooks_url":"https://api.github.com/repos/opencv/opencv/hooks","issue_events_url":"https://api.github.com/repos/opencv/opencv/issues/events{/number}","events_url":"https://api.github.com/repos/opencv/opencv/events","assignees_url":"https://api.github.com/repos/opencv/opencv/assignees{/user}","branches_url":"https://api.github.com/repos/opencv/opencv/branches{/branch}","tags_url":"https://api.github.com/repos/opencv/opencv/tags","blobs_url":"https://api.github.com/repos/opencv/opencv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opencv/opencv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opencv/opencv/git/refs{/sha}","trees_url":"https://api.github.com/repos/opencv/opencv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opencv/opencv/statuses/{sha}","languages_url":"https://api.github.com/repos/opencv/opencv/languages","stargazers_url":"https://api.github.com/repos/opencv/opencv/stargazers","contributors_url":"https://api.github.com/repos/opencv/opencv/contributors","subscribers_url":"https://api.github.com/repos/opencv/opencv/subscribers","subscription_url":"https://api.github.com/repos/opencv/opencv/subscription","commits_url":"https://api.github.com/repos/opencv/opencv/commits{/sha}","git_commits_url":"https://api.github.com/repos/opencv/opencv/git/commits{/sha}","comments_url":"https://api.github.com/repos/opencv/opencv/comments{/number}","issue_comment_url":"https://api.github.com/repos/opencv/opencv/issues/comments{/number}","contents_url":"https://api.github.com/repos/opencv/opencv/contents/{+path}","compare_url":"https://api.github.com/repos/opencv/opencv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opencv/opencv/merges","archive_url":"https://api.github.com/repos/opencv/opencv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opencv/opencv/downloads","issues_url":"https://api.github.com/repos/opencv/opencv/issues{/number}","pulls_url":"https://api.github.com/repos/opencv/opencv/pulls{/number}","milestones_url":"https://api.github.com/repos/opencv/opencv/milestones{/number}","notifications_url":"https://api.github.com/repos/opencv/opencv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opencv/opencv/labels{/name}","releases_url":"https://api.github.com/repos/opencv/opencv/releases{/id}","deployments_url":"https://api.github.com/repos/opencv/opencv/deployments","created_at":"2012-07-19T09:40:17Z","updated_at":"2018-03-08T16:28:01Z","pushed_at":"2018-03-08T17:54:18Z","git_url":"git://github.com/opencv/opencv.git","ssh_url":"git@github.com:opencv/opencv.git","clone_url":"https://github.com/opencv/opencv.git","svn_url":"https://github.com/opencv/opencv","homepage":"https://opencv.org","size":450812,"stargazers_count":22724,"watchers_count":22724,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":16364,"mirror_url":null,"archived":false,"open_issues_count":1369,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":16364,"open_issues":1369,"watchers":22724,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opencv/opencv/pulls/11030"},"html":{"href":"https://github.com/opencv/opencv/pull/11030"},"issue":{"href":"https://api.github.com/repos/opencv/opencv/issues/11030"},"comments":{"href":"https://api.github.com/repos/opencv/opencv/issues/11030/comments"},"review_comments":{"href":"https://api.github.com/repos/opencv/opencv/pulls/11030/comments"},"review_comment":{"href":"https://api.github.com/repos/opencv/opencv/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opencv/opencv/pulls/11030/commits"},"statuses":{"href":"https://api.github.com/repos/opencv/opencv/statuses/bf5f7380cff389033e03700960f86fdcea52b390"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"opencv-pushbot","id":2051563,"avatar_url":"https://avatars1.githubusercontent.com/u/2051563?v=4","gravatar_id":"","url":"https://api.github.com/users/opencv-pushbot","html_url":"https://github.com/opencv-pushbot","followers_url":"https://api.github.com/users/opencv-pushbot/followers","following_url":"https://api.github.com/users/opencv-pushbot/following{/other_user}","gists_url":"https://api.github.com/users/opencv-pushbot/gists{/gist_id}","starred_url":"https://api.github.com/users/opencv-pushbot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencv-pushbot/subscriptions","organizations_url":"https://api.github.com/users/opencv-pushbot/orgs","repos_url":"https://api.github.com/users/opencv-pushbot/repos","events_url":"https://api.github.com/users/opencv-pushbot/events{/privacy}","received_events_url":"https://api.github.com/users/opencv-pushbot/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":2,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"opencv-pushbot"}}