{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/pulls/comments/192162001","pull_request_review_id":124875110,"id":192162001,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjE2MjAwMQ==","diff_hunk":"@@ -12,6 +12,12 @@ namespace Microsoft.Azure.WebJobs.Extensions.DurableTask\n     [DataContract]\n     internal class StatusResponsePayload\n     {\n+        /// <summary>\n+        /// InstanceId.\n+        /// </summary>\n+        [DataMember(Name = \"instanceId\")]\n+        public JToken InstanceId { get; set; }","path":"src/WebJobs.Extensions.DurableTask/StatusResponsePayload.cs","position":8,"original_position":8,"commit_id":"264cb55270d38d88496cbee1be686e2034c32076","original_commit_id":"264cb55270d38d88496cbee1be686e2034c32076","user":{"login":"cgillum","id":2704139,"node_id":"MDQ6VXNlcjI3MDQxMzk=","avatar_url":"https://avatars2.githubusercontent.com/u/2704139?v=4","gravatar_id":"","url":"https://api.github.com/users/cgillum","html_url":"https://github.com/cgillum","followers_url":"https://api.github.com/users/cgillum/followers","following_url":"https://api.github.com/users/cgillum/following{/other_user}","gists_url":"https://api.github.com/users/cgillum/gists{/gist_id}","starred_url":"https://api.github.com/users/cgillum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cgillum/subscriptions","organizations_url":"https://api.github.com/users/cgillum/orgs","repos_url":"https://api.github.com/users/cgillum/repos","events_url":"https://api.github.com/users/cgillum/events{/privacy}","received_events_url":"https://api.github.com/users/cgillum/received_events","type":"User","site_admin":false},"body":"This should be `string`, not `JToken`.","created_at":"2018-05-31T16:36:59Z","updated_at":"2018-05-31T16:48:03Z","html_url":"https://github.com/Azure/azure-functions-durable-extension/pull/323#discussion_r192162001","pull_request_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/pulls/323","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-functions-durable-extension/pulls/comments/192162001"},"html":{"href":"https://github.com/Azure/azure-functions-durable-extension/pull/323#discussion_r192162001"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-functions-durable-extension/pulls/323"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/pulls/323","id":191394375,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxMzk0Mzc1","html_url":"https://github.com/Azure/azure-functions-durable-extension/pull/323","diff_url":"https://github.com/Azure/azure-functions-durable-extension/pull/323.diff","patch_url":"https://github.com/Azure/azure-functions-durable-extension/pull/323.patch","issue_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/issues/323","number":323,"state":"open","locked":false,"title":"APIs to enumerate all orchestration instances","user":{"login":"TsuyoshiUshio","id":1390976,"node_id":"MDQ6VXNlcjEzOTA5NzY=","avatar_url":"https://avatars0.githubusercontent.com/u/1390976?v=4","gravatar_id":"","url":"https://api.github.com/users/TsuyoshiUshio","html_url":"https://github.com/TsuyoshiUshio","followers_url":"https://api.github.com/users/TsuyoshiUshio/followers","following_url":"https://api.github.com/users/TsuyoshiUshio/following{/other_user}","gists_url":"https://api.github.com/users/TsuyoshiUshio/gists{/gist_id}","starred_url":"https://api.github.com/users/TsuyoshiUshio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TsuyoshiUshio/subscriptions","organizations_url":"https://api.github.com/users/TsuyoshiUshio/orgs","repos_url":"https://api.github.com/users/TsuyoshiUshio/repos","events_url":"https://api.github.com/users/TsuyoshiUshio/events{/privacy}","received_events_url":"https://api.github.com/users/TsuyoshiUshio/received_events","type":"User","site_admin":false},"body":"Hi @cgillum \r\n\r\nI start this pull request to start conversation. \r\nThis pull request is for this issue. \r\n\r\nhttps://github.com/Azure/azure-functions-durable-extension/issues/316\r\n\r\nAlso, related this pull request for DurableTask\r\n\r\nhttps://github.com/Azure/durabletask/pull/187\r\n\r\n# NOTE\r\n\r\nIf you do CI for this pull request, currently it must fail.   This fix need the code change of the durable task pull request. I write a code with the nuget packages of DurableTask.AzureStorage (2.0.0.5) I don't include  csproj file since it is changed to load local file.\r\n\r\nI have some questions for you. \r\n\r\n* Should I change the version of the DurableTaskStorage? or leave it to you?\r\n* For writing test, we need to add method to the DurableOrchestrationClientMock.cs. However, it is just mplement DurableOrchestrationClientBase. As we discuss, currently, I use cast for avoiding change of DurableTask.Core. I can't change the mock. Should I leave test? then implement after change the TaskHubClient? \r\n\r\nAnyway, this is the first steps. :) Please review this before go deep. :)","created_at":"2018-05-30T09:48:06Z","updated_at":"2018-05-31T16:48:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6d2ab1225f027fe42de22e2dc02aabe02ef9186b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/pulls/323/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/pulls/323/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/issues/323/comments","statuses_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/statuses/264cb55270d38d88496cbee1be686e2034c32076","head":{"label":"TsuyoshiUshio:onthefly-instances","ref":"onthefly-instances","sha":"264cb55270d38d88496cbee1be686e2034c32076","user":{"login":"TsuyoshiUshio","id":1390976,"node_id":"MDQ6VXNlcjEzOTA5NzY=","avatar_url":"https://avatars0.githubusercontent.com/u/1390976?v=4","gravatar_id":"","url":"https://api.github.com/users/TsuyoshiUshio","html_url":"https://github.com/TsuyoshiUshio","followers_url":"https://api.github.com/users/TsuyoshiUshio/followers","following_url":"https://api.github.com/users/TsuyoshiUshio/following{/other_user}","gists_url":"https://api.github.com/users/TsuyoshiUshio/gists{/gist_id}","starred_url":"https://api.github.com/users/TsuyoshiUshio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TsuyoshiUshio/subscriptions","organizations_url":"https://api.github.com/users/TsuyoshiUshio/orgs","repos_url":"https://api.github.com/users/TsuyoshiUshio/repos","events_url":"https://api.github.com/users/TsuyoshiUshio/events{/privacy}","received_events_url":"https://api.github.com/users/TsuyoshiUshio/received_events","type":"User","site_admin":false},"repo":{"id":135406030,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU0MDYwMzA=","name":"azure-functions-durable-extension","full_name":"TsuyoshiUshio/azure-functions-durable-extension","owner":{"login":"TsuyoshiUshio","id":1390976,"node_id":"MDQ6VXNlcjEzOTA5NzY=","avatar_url":"https://avatars0.githubusercontent.com/u/1390976?v=4","gravatar_id":"","url":"https://api.github.com/users/TsuyoshiUshio","html_url":"https://github.com/TsuyoshiUshio","followers_url":"https://api.github.com/users/TsuyoshiUshio/followers","following_url":"https://api.github.com/users/TsuyoshiUshio/following{/other_user}","gists_url":"https://api.github.com/users/TsuyoshiUshio/gists{/gist_id}","starred_url":"https://api.github.com/users/TsuyoshiUshio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TsuyoshiUshio/subscriptions","organizations_url":"https://api.github.com/users/TsuyoshiUshio/orgs","repos_url":"https://api.github.com/users/TsuyoshiUshio/repos","events_url":"https://api.github.com/users/TsuyoshiUshio/events{/privacy}","received_events_url":"https://api.github.com/users/TsuyoshiUshio/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/TsuyoshiUshio/azure-functions-durable-extension","description":"Durable Task Framework extension for Azure Functions","fork":true,"url":"https://api.github.com/repos/TsuyoshiUshio/azure-functions-durable-extension","forks_url":"https://api.github.com/repos/TsuyoshiUshio/azure-functions-durable-extension/forks","keys_url":"https://api.github.com/repos/TsuyoshiUshio/azure-functions-durable-extension/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TsuyoshiUshio/azure-functions-durable-extension/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TsuyoshiUshio/azure-functions-durable-extension/teams","hooks_url":"https://api.github.com/repos/TsuyoshiUshio/azure-functions-durable-extension/hooks","issue_events_url":"https://api.github.com/repos/TsuyoshiUshio/azure-functions-durable-extension/issues/events{/number}","events_url":"https://api.github.com/repos/TsuyoshiUshio/azure-functions-durable-extension/events","assignees_url":"https://api.github.com/repos/TsuyoshiUshio/azure-functions-durable-extension/assignees{/user}","branches_url":"https://api.github.com/repos/TsuyoshiUshio/azure-functions-durable-extension/branches{/branch}","tags_url":"https://api.github.com/repos/TsuyoshiUshio/azure-functions-durable-extension/tags","blobs_url":"https://api.github.com/repos/TsuyoshiUshio/azure-functions-durable-extension/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TsuyoshiUshio/azure-functions-durable-extension/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TsuyoshiUshio/azure-functions-durable-extension/git/refs{/sha}","trees_url":"https://api.github.com/repos/TsuyoshiUshio/azure-functions-durable-extension/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TsuyoshiUshio/azure-functions-durable-extension/statuses/{sha}","languages_url":"https://api.github.com/repos/TsuyoshiUshio/azure-functions-durable-extension/languages","stargazers_url":"https://api.github.com/repos/TsuyoshiUshio/azure-functions-durable-extension/stargazers","contributors_url":"https://api.github.com/repos/TsuyoshiUshio/azure-functions-durable-extension/contributors","subscribers_url":"https://api.github.com/repos/TsuyoshiUshio/azure-functions-durable-extension/subscribers","subscription_url":"https://api.github.com/repos/TsuyoshiUshio/azure-functions-durable-extension/subscription","commits_url":"https://api.github.com/repos/TsuyoshiUshio/azure-functions-durable-extension/commits{/sha}","git_commits_url":"https://api.github.com/repos/TsuyoshiUshio/azure-functions-durable-extension/git/commits{/sha}","comments_url":"https://api.github.com/repos/TsuyoshiUshio/azure-functions-durable-extension/comments{/number}","issue_comment_url":"https://api.github.com/repos/TsuyoshiUshio/azure-functions-durable-extension/issues/comments{/number}","contents_url":"https://api.github.com/repos/TsuyoshiUshio/azure-functions-durable-extension/contents/{+path}","compare_url":"https://api.github.com/repos/TsuyoshiUshio/azure-functions-durable-extension/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TsuyoshiUshio/azure-functions-durable-extension/merges","archive_url":"https://api.github.com/repos/TsuyoshiUshio/azure-functions-durable-extension/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TsuyoshiUshio/azure-functions-durable-extension/downloads","issues_url":"https://api.github.com/repos/TsuyoshiUshio/azure-functions-durable-extension/issues{/number}","pulls_url":"https://api.github.com/repos/TsuyoshiUshio/azure-functions-durable-extension/pulls{/number}","milestones_url":"https://api.github.com/repos/TsuyoshiUshio/azure-functions-durable-extension/milestones{/number}","notifications_url":"https://api.github.com/repos/TsuyoshiUshio/azure-functions-durable-extension/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TsuyoshiUshio/azure-functions-durable-extension/labels{/name}","releases_url":"https://api.github.com/repos/TsuyoshiUshio/azure-functions-durable-extension/releases{/id}","deployments_url":"https://api.github.com/repos/TsuyoshiUshio/azure-functions-durable-extension/deployments","created_at":"2018-05-30T07:36:20Z","updated_at":"2018-05-30T07:36:22Z","pushed_at":"2018-05-31T11:21:12Z","git_url":"git://github.com/TsuyoshiUshio/azure-functions-durable-extension.git","ssh_url":"git@github.com:TsuyoshiUshio/azure-functions-durable-extension.git","clone_url":"https://github.com/TsuyoshiUshio/azure-functions-durable-extension.git","svn_url":"https://github.com/TsuyoshiUshio/azure-functions-durable-extension","homepage":null,"size":9695,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:dev","ref":"dev","sha":"078d4301bdc577dedd4daa487df4b241f5897ffc","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":93190658,"node_id":"MDEwOlJlcG9zaXRvcnk5MzE5MDY1OA==","name":"azure-functions-durable-extension","full_name":"Azure/azure-functions-durable-extension","owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-functions-durable-extension","description":"Durable Task Framework extension for Azure Functions","fork":false,"url":"https://api.github.com/repos/Azure/azure-functions-durable-extension","forks_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/forks","keys_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/teams","hooks_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/events","assignees_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/tags","blobs_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/subscription","commits_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/merges","archive_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/downloads","issues_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-functions-durable-extension/deployments","created_at":"2017-06-02T17:51:30Z","updated_at":"2018-05-31T16:17:06Z","pushed_at":"2018-05-31T11:21:14Z","git_url":"git://github.com/Azure/azure-functions-durable-extension.git","ssh_url":"git@github.com:Azure/azure-functions-durable-extension.git","clone_url":"https://github.com/Azure/azure-functions-durable-extension.git","svn_url":"https://github.com/Azure/azure-functions-durable-extension","homepage":null,"size":9691,"stargazers_count":124,"watchers_count":124,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":49,"mirror_url":null,"archived":false,"open_issues_count":45,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":49,"open_issues":45,"watchers":124,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-functions-durable-extension/pulls/323"},"html":{"href":"https://github.com/Azure/azure-functions-durable-extension/pull/323"},"issue":{"href":"https://api.github.com/repos/Azure/azure-functions-durable-extension/issues/323"},"comments":{"href":"https://api.github.com/repos/Azure/azure-functions-durable-extension/issues/323/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-functions-durable-extension/pulls/323/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-functions-durable-extension/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-functions-durable-extension/pulls/323/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-functions-durable-extension/statuses/264cb55270d38d88496cbee1be686e2034c32076"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"cgillum"}}