{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/178611928","pull_request_review_id":108691851,"id":178611928,"diff_hunk":"@@ -0,0 +1,76 @@\n+---\n+# Note: this required ansible-galaxy install Azure.azure_modules\n+\n+- import_playbook: prerequisites.yml\n+\n+# create all the items necessary to make the VM\n+- name: \"Create resource group\"\n+  hosts: localhost\n+  gather_facts: no\n+  tasks:\n+  - name: \"provision public ip address\"\n+    import_role:\n+      name: openshift_azure\n+      tasks_from: provision_instance.yml\n+    vars:\n+      openshift_azure_vm_base_image:\n+        name: '{{ openshift_azure_root_image }}'\n+        resource_group: '{{ openshift_azure_root_image_ns }}'\n+\n+- name: update OS and install packages\n+  hosts: azure\n+  gather_facts: yes\n+  remote_user: \"{{ openshift_azure_vm_admin_username }}\"\n+  become: True\n+  tasks:\n+  - name: lay down yum certs\n+    copy:\n+      content: \"{{ item.content }}\"\n+      dest: \"/var/lib/yum/{{ item.name }}\"\n+    with_items:\n+    - name: client-cert.pem\n+      content: \"{{ yum_client_cert_contents }}\"\n+    - name: client-key.pem\n+      content: \"{{ yum_client_key_contents }}\"\n+\n+  - name: update our /var\n+    mount:\n+      boot: yes\n+      fstype: xfs\n+      path: /var\n+      state: mounted\n+      src: /dev/mapper/rootvg-var\n+      opts: rw,relatime,seclabel,attr2,inode64,grpquota\n+\n+  - name: setup yum repositories\n+    import_role:\n+      name: openshift_repos\n+\n+  - name: update OS\n+    import_role:\n+      name: os_update_latest\n+    vars:\n+      os_update_latest_reboot: True","path":"playbooks/azure/openshift-cluster/build_base_image.yml","position":53,"original_position":53,"commit_id":"760b08324a96a4e07e03fbdba67b98cf6b081d8d","original_commit_id":"760b08324a96a4e07e03fbdba67b98cf6b081d8d","user":{"login":"jim-minter","id":1038301,"avatar_url":"https://avatars2.githubusercontent.com/u/1038301?v=4","gravatar_id":"","url":"https://api.github.com/users/jim-minter","html_url":"https://github.com/jim-minter","followers_url":"https://api.github.com/users/jim-minter/followers","following_url":"https://api.github.com/users/jim-minter/following{/other_user}","gists_url":"https://api.github.com/users/jim-minter/gists{/gist_id}","starred_url":"https://api.github.com/users/jim-minter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jim-minter/subscriptions","organizations_url":"https://api.github.com/users/jim-minter/orgs","repos_url":"https://api.github.com/users/jim-minter/repos","events_url":"https://api.github.com/users/jim-minter/events{/privacy}","received_events_url":"https://api.github.com/users/jim-minter/received_events","type":"User","site_admin":false},"body":"why is this needed?","created_at":"2018-04-02T18:25:52Z","updated_at":"2018-04-02T18:57:01Z","html_url":"https://github.com/openshift/openshift-ansible/pull/7690#discussion_r178611928","pull_request_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/7690","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments/178611928"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/7690#discussion_r178611928"},"pull_request":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/7690"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/7690","id":178063433,"html_url":"https://github.com/openshift/openshift-ansible/pull/7690","diff_url":"https://github.com/openshift/openshift-ansible/pull/7690.diff","patch_url":"https://github.com/openshift/openshift-ansible/pull/7690.patch","issue_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/7690","number":7690,"state":"open","locked":false,"title":"[WIP] Azure image building and initial provisioning.","user":{"login":"kwoodson","id":1385770,"avatar_url":"https://avatars2.githubusercontent.com/u/1385770?v=4","gravatar_id":"","url":"https://api.github.com/users/kwoodson","html_url":"https://github.com/kwoodson","followers_url":"https://api.github.com/users/kwoodson/followers","following_url":"https://api.github.com/users/kwoodson/following{/other_user}","gists_url":"https://api.github.com/users/kwoodson/gists{/gist_id}","starred_url":"https://api.github.com/users/kwoodson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwoodson/subscriptions","organizations_url":"https://api.github.com/users/kwoodson/orgs","repos_url":"https://api.github.com/users/kwoodson/repos","events_url":"https://api.github.com/users/kwoodson/events{/privacy}","received_events_url":"https://api.github.com/users/kwoodson/received_events","type":"User","site_admin":false},"body":"@jim-minter @pweil- @pschiffe @kargakis @sdodson @smarterclayton \r\n\r\nHere is the initial azure provisioning work.  The main pieces here are in two sections that mirror the aws and gcp work. \r\n\r\nAreas:\r\n- playbooks/azure/openshift-cluster/\r\n- roles/openshift_azure\r\n- images/installer\r\n- inventory/dynamic/azure\r\n\r\nThe playbooks section has support for creating and updating a base image as well as building an openshift image.  These playbooks consume the openshift_azure role.\r\n\r\nThe images and inventory work provides us the ability to deploy using the CI so we can start testing image builds.\r\n","created_at":"2018-03-28T14:46:18Z","updated_at":"2018-04-02T18:57:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bd7d27e696fdaf325955a3f81aa63d9637fe38da","assignee":null,"assignees":[],"requested_reviewers":[{"login":"smarterclayton","id":1163175,"avatar_url":"https://avatars0.githubusercontent.com/u/1163175?v=4","gravatar_id":"","url":"https://api.github.com/users/smarterclayton","html_url":"https://github.com/smarterclayton","followers_url":"https://api.github.com/users/smarterclayton/followers","following_url":"https://api.github.com/users/smarterclayton/following{/other_user}","gists_url":"https://api.github.com/users/smarterclayton/gists{/gist_id}","starred_url":"https://api.github.com/users/smarterclayton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smarterclayton/subscriptions","organizations_url":"https://api.github.com/users/smarterclayton/orgs","repos_url":"https://api.github.com/users/smarterclayton/repos","events_url":"https://api.github.com/users/smarterclayton/events{/privacy}","received_events_url":"https://api.github.com/users/smarterclayton/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":687182579,"url":"https://api.github.com/repos/openshift/openshift-ansible/labels/do-not-merge/work-in-progress","name":"do-not-merge/work-in-progress","color":"e11d21","default":false},{"id":681652779,"url":"https://api.github.com/repos/openshift/openshift-ansible/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/7690/commits","review_comments_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/7690/comments","review_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/7690/comments","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/760b08324a96a4e07e03fbdba67b98cf6b081d8d","head":{"label":"kwoodson:azure_prov","ref":"azure_prov","sha":"760b08324a96a4e07e03fbdba67b98cf6b081d8d","user":{"login":"kwoodson","id":1385770,"avatar_url":"https://avatars2.githubusercontent.com/u/1385770?v=4","gravatar_id":"","url":"https://api.github.com/users/kwoodson","html_url":"https://github.com/kwoodson","followers_url":"https://api.github.com/users/kwoodson/followers","following_url":"https://api.github.com/users/kwoodson/following{/other_user}","gists_url":"https://api.github.com/users/kwoodson/gists{/gist_id}","starred_url":"https://api.github.com/users/kwoodson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwoodson/subscriptions","organizations_url":"https://api.github.com/users/kwoodson/orgs","repos_url":"https://api.github.com/users/kwoodson/repos","events_url":"https://api.github.com/users/kwoodson/events{/privacy}","received_events_url":"https://api.github.com/users/kwoodson/received_events","type":"User","site_admin":false},"repo":{"id":27775666,"name":"openshift-ansible","full_name":"kwoodson/openshift-ansible","owner":{"login":"kwoodson","id":1385770,"avatar_url":"https://avatars2.githubusercontent.com/u/1385770?v=4","gravatar_id":"","url":"https://api.github.com/users/kwoodson","html_url":"https://github.com/kwoodson","followers_url":"https://api.github.com/users/kwoodson/followers","following_url":"https://api.github.com/users/kwoodson/following{/other_user}","gists_url":"https://api.github.com/users/kwoodson/gists{/gist_id}","starred_url":"https://api.github.com/users/kwoodson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kwoodson/subscriptions","organizations_url":"https://api.github.com/users/kwoodson/orgs","repos_url":"https://api.github.com/users/kwoodson/repos","events_url":"https://api.github.com/users/kwoodson/events{/privacy}","received_events_url":"https://api.github.com/users/kwoodson/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kwoodson/openshift-ansible","description":"OpenShift Online's Ansible Code","fork":true,"url":"https://api.github.com/repos/kwoodson/openshift-ansible","forks_url":"https://api.github.com/repos/kwoodson/openshift-ansible/forks","keys_url":"https://api.github.com/repos/kwoodson/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kwoodson/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kwoodson/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/kwoodson/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/kwoodson/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/kwoodson/openshift-ansible/events","assignees_url":"https://api.github.com/repos/kwoodson/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/kwoodson/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/kwoodson/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/kwoodson/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kwoodson/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kwoodson/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/kwoodson/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kwoodson/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/kwoodson/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/kwoodson/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/kwoodson/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/kwoodson/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/kwoodson/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/kwoodson/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/kwoodson/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/kwoodson/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/kwoodson/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/kwoodson/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/kwoodson/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kwoodson/openshift-ansible/merges","archive_url":"https://api.github.com/repos/kwoodson/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kwoodson/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/kwoodson/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/kwoodson/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/kwoodson/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/kwoodson/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kwoodson/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/kwoodson/openshift-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/kwoodson/openshift-ansible/deployments","created_at":"2014-12-09T16:28:41Z","updated_at":"2018-03-28T13:50:23Z","pushed_at":"2018-03-29T18:29:29Z","git_url":"git://github.com/kwoodson/openshift-ansible.git","ssh_url":"git@github.com:kwoodson/openshift-ansible.git","clone_url":"https://github.com/kwoodson/openshift-ansible.git","svn_url":"https://github.com/kwoodson/openshift-ansible","homepage":"","size":26456,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"8a0fde1c2d8bb05407f137d2e23d8eb4dbb7d3c5","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":24109199,"name":"openshift-ansible","full_name":"openshift/openshift-ansible","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/openshift-ansible","description":"OpenShift Installation and Configuration Management","fork":false,"url":"https://api.github.com/repos/openshift/openshift-ansible","forks_url":"https://api.github.com/repos/openshift/openshift-ansible/forks","keys_url":"https://api.github.com/repos/openshift/openshift-ansible/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/openshift-ansible/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/openshift-ansible/teams","hooks_url":"https://api.github.com/repos/openshift/openshift-ansible/hooks","issue_events_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/openshift-ansible/events","assignees_url":"https://api.github.com/repos/openshift/openshift-ansible/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/openshift-ansible/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/openshift-ansible/tags","blobs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/openshift-ansible/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/openshift-ansible/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/openshift-ansible/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/openshift-ansible/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/openshift-ansible/languages","stargazers_url":"https://api.github.com/repos/openshift/openshift-ansible/stargazers","contributors_url":"https://api.github.com/repos/openshift/openshift-ansible/contributors","subscribers_url":"https://api.github.com/repos/openshift/openshift-ansible/subscribers","subscription_url":"https://api.github.com/repos/openshift/openshift-ansible/subscription","commits_url":"https://api.github.com/repos/openshift/openshift-ansible/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/openshift-ansible/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/openshift-ansible/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/openshift-ansible/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/openshift-ansible/merges","archive_url":"https://api.github.com/repos/openshift/openshift-ansible/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/openshift-ansible/downloads","issues_url":"https://api.github.com/repos/openshift/openshift-ansible/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/openshift-ansible/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/openshift-ansible/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/openshift-ansible/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/openshift-ansible/labels{/name}","releases_url":"https://api.github.com/repos/openshift/openshift-ansible/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/openshift-ansible/deployments","created_at":"2014-09-16T17:07:51Z","updated_at":"2018-04-02T18:28:14Z","pushed_at":"2018-04-02T18:27:45Z","git_url":"git://github.com/openshift/openshift-ansible.git","ssh_url":"git@github.com:openshift/openshift-ansible.git","clone_url":"https://github.com/openshift/openshift-ansible.git","svn_url":"https://github.com/openshift/openshift-ansible","homepage":"https://install.openshift.com","size":26688,"stargazers_count":848,"watchers_count":848,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1257,"mirror_url":null,"archived":false,"open_issues_count":857,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1257,"open_issues":857,"watchers":848,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/7690"},"html":{"href":"https://github.com/openshift/openshift-ansible/pull/7690"},"issue":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/7690"},"comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/issues/7690/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/7690/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/openshift-ansible/pulls/7690/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/openshift-ansible/statuses/760b08324a96a4e07e03fbdba67b98cf6b081d8d"}},"author_association":"OWNER"}}
{"actor":{"display_login":"jim-minter"}}