{"action":"created","comment":{"url":"https://api.github.com/repos/lsst/obs_lsstCam/pulls/comments/234059025","pull_request_review_id":175620199,"id":234059025,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDA1OTAyNQ==","diff_hunk":"@@ -108,14 +108,13 @@ def callback(im, ccd, imageSource):\n                     if md:\n                         afwGeom.makeSkyWcs(md, strip=True)  # strip WCS cards; they're invalidated by binning\n                     try:\n-                        binned_im = bi.getCcdImage(ccd, binSize=self.config.sensorBinSize)[0]\n+                        binned_im = bi.getCcdImage(ccd, binSize=self.config.sensorBinSize,\n+                                                   as_masked_image=True)[0]\n                         binned_im = rotateImageBy90(binned_im, ccd.getOrientation().getNQuarter())\n                         if self.config.putFullSensors:\n-                            binned_dim = afwImage.DecoratedImageF(binned_im)\n-                            if md:\n-                                binned_dim.setMetadata(md)\n-\n-                            butler.put(binned_dim, 'binned_sensor_fits', **dataId, dstype=dstype)\n+                            # binned_mim = afwImage.MaskedImageF(binned_im, metadata=md)","path":"bin.src/makeFpSummary.py","position":14,"original_position":14,"commit_id":"13bc61d2358917735466d6e35310f4ef353a6715","original_commit_id":"13bc61d2358917735466d6e35310f4ef353a6715","user":{"login":"TallJimbo","id":1330720,"node_id":"MDQ6VXNlcjEzMzA3MjA=","avatar_url":"https://avatars0.githubusercontent.com/u/1330720?v=4","gravatar_id":"","url":"https://api.github.com/users/TallJimbo","html_url":"https://github.com/TallJimbo","followers_url":"https://api.github.com/users/TallJimbo/followers","following_url":"https://api.github.com/users/TallJimbo/following{/other_user}","gists_url":"https://api.github.com/users/TallJimbo/gists{/gist_id}","starred_url":"https://api.github.com/users/TallJimbo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TallJimbo/subscriptions","organizations_url":"https://api.github.com/users/TallJimbo/orgs","repos_url":"https://api.github.com/users/TallJimbo/repos","events_url":"https://api.github.com/users/TallJimbo/events{/privacy}","received_events_url":"https://api.github.com/users/TallJimbo/received_events","type":"User","site_admin":false},"body":"Ah, I understand now - the `metadata` argument isn't allowed at all when the other argument is a `MaskedImage` (it's only relevant when you pass in a filename to read from disk).  When you pass in another `MaskedImage`, the only other argument you can provide is `deep`, to set whether to do a deep copy or not.","created_at":"2018-11-16T00:45:24Z","updated_at":"2018-11-16T00:45:25Z","html_url":"https://github.com/lsst/obs_lsstCam/pull/40#discussion_r234059025","pull_request_url":"https://api.github.com/repos/lsst/obs_lsstCam/pulls/40","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/lsst/obs_lsstCam/pulls/comments/234059025"},"html":{"href":"https://github.com/lsst/obs_lsstCam/pull/40#discussion_r234059025"},"pull_request":{"href":"https://api.github.com/repos/lsst/obs_lsstCam/pulls/40"}},"in_reply_to_id":234055067},"pull_request":{"url":"https://api.github.com/repos/lsst/obs_lsstCam/pulls/40","id":231377430,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMzc3NDMw","html_url":"https://github.com/lsst/obs_lsstCam/pull/40","diff_url":"https://github.com/lsst/obs_lsstCam/pull/40.diff","patch_url":"https://github.com/lsst/obs_lsstCam/pull/40.patch","issue_url":"https://api.github.com/repos/lsst/obs_lsstCam/issues/40","number":40,"state":"open","locked":false,"title":"switch from DecoratedImage to MaskedImage in makeFpSummary.py","user":{"login":"jchiang87","id":1994473,"node_id":"MDQ6VXNlcjE5OTQ0NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/1994473?v=4","gravatar_id":"","url":"https://api.github.com/users/jchiang87","html_url":"https://github.com/jchiang87","followers_url":"https://api.github.com/users/jchiang87/followers","following_url":"https://api.github.com/users/jchiang87/following{/other_user}","gists_url":"https://api.github.com/users/jchiang87/gists{/gist_id}","starred_url":"https://api.github.com/users/jchiang87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jchiang87/subscriptions","organizations_url":"https://api.github.com/users/jchiang87/orgs","repos_url":"https://api.github.com/users/jchiang87/repos","events_url":"https://api.github.com/users/jchiang87/events{/privacy}","received_events_url":"https://api.github.com/users/jchiang87/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-16T00:14:52Z","updated_at":"2018-11-16T00:45:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b823b74038ff6b5fdf77c99fab2bfaad48eb757d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/lsst/obs_lsstCam/pulls/40/commits","review_comments_url":"https://api.github.com/repos/lsst/obs_lsstCam/pulls/40/comments","review_comment_url":"https://api.github.com/repos/lsst/obs_lsstCam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lsst/obs_lsstCam/issues/40/comments","statuses_url":"https://api.github.com/repos/lsst/obs_lsstCam/statuses/13bc61d2358917735466d6e35310f4ef353a6715","head":{"label":"lsst:u/jchiang/fp_summary_mask_fix","ref":"u/jchiang/fp_summary_mask_fix","sha":"13bc61d2358917735466d6e35310f4ef353a6715","user":{"login":"lsst","id":1134504,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzQ1MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1134504?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"repo":{"id":137966515,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc5NjY1MTU=","name":"obs_lsstCam","full_name":"lsst/obs_lsstCam","private":false,"owner":{"login":"lsst","id":1134504,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzQ1MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1134504?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/lsst/obs_lsstCam","description":"The obs model for the LSST 3.2GPixel camera","fork":false,"url":"https://api.github.com/repos/lsst/obs_lsstCam","forks_url":"https://api.github.com/repos/lsst/obs_lsstCam/forks","keys_url":"https://api.github.com/repos/lsst/obs_lsstCam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst/obs_lsstCam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst/obs_lsstCam/teams","hooks_url":"https://api.github.com/repos/lsst/obs_lsstCam/hooks","issue_events_url":"https://api.github.com/repos/lsst/obs_lsstCam/issues/events{/number}","events_url":"https://api.github.com/repos/lsst/obs_lsstCam/events","assignees_url":"https://api.github.com/repos/lsst/obs_lsstCam/assignees{/user}","branches_url":"https://api.github.com/repos/lsst/obs_lsstCam/branches{/branch}","tags_url":"https://api.github.com/repos/lsst/obs_lsstCam/tags","blobs_url":"https://api.github.com/repos/lsst/obs_lsstCam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst/obs_lsstCam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst/obs_lsstCam/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst/obs_lsstCam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst/obs_lsstCam/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst/obs_lsstCam/languages","stargazers_url":"https://api.github.com/repos/lsst/obs_lsstCam/stargazers","contributors_url":"https://api.github.com/repos/lsst/obs_lsstCam/contributors","subscribers_url":"https://api.github.com/repos/lsst/obs_lsstCam/subscribers","subscription_url":"https://api.github.com/repos/lsst/obs_lsstCam/subscription","commits_url":"https://api.github.com/repos/lsst/obs_lsstCam/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst/obs_lsstCam/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst/obs_lsstCam/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst/obs_lsstCam/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst/obs_lsstCam/contents/{+path}","compare_url":"https://api.github.com/repos/lsst/obs_lsstCam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst/obs_lsstCam/merges","archive_url":"https://api.github.com/repos/lsst/obs_lsstCam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst/obs_lsstCam/downloads","issues_url":"https://api.github.com/repos/lsst/obs_lsstCam/issues{/number}","pulls_url":"https://api.github.com/repos/lsst/obs_lsstCam/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst/obs_lsstCam/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst/obs_lsstCam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst/obs_lsstCam/labels{/name}","releases_url":"https://api.github.com/repos/lsst/obs_lsstCam/releases{/id}","deployments_url":"https://api.github.com/repos/lsst/obs_lsstCam/deployments","created_at":"2018-06-20T01:53:45Z","updated_at":"2018-11-15T22:32:56Z","pushed_at":"2018-11-16T00:14:53Z","git_url":"git://github.com/lsst/obs_lsstCam.git","ssh_url":"git@github.com:lsst/obs_lsstCam.git","clone_url":"https://github.com/lsst/obs_lsstCam.git","svn_url":"https://github.com/lsst/obs_lsstCam","homepage":null,"size":292,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":1,"open_issues":3,"watchers":1,"default_branch":"master"}},"base":{"label":"lsst:master","ref":"master","sha":"5c12b06e6427d6d9935c4cdf487afa16683e264f","user":{"login":"lsst","id":1134504,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzQ1MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1134504?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"repo":{"id":137966515,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc5NjY1MTU=","name":"obs_lsstCam","full_name":"lsst/obs_lsstCam","private":false,"owner":{"login":"lsst","id":1134504,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMzQ1MDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1134504?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/lsst/obs_lsstCam","description":"The obs model for the LSST 3.2GPixel camera","fork":false,"url":"https://api.github.com/repos/lsst/obs_lsstCam","forks_url":"https://api.github.com/repos/lsst/obs_lsstCam/forks","keys_url":"https://api.github.com/repos/lsst/obs_lsstCam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst/obs_lsstCam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst/obs_lsstCam/teams","hooks_url":"https://api.github.com/repos/lsst/obs_lsstCam/hooks","issue_events_url":"https://api.github.com/repos/lsst/obs_lsstCam/issues/events{/number}","events_url":"https://api.github.com/repos/lsst/obs_lsstCam/events","assignees_url":"https://api.github.com/repos/lsst/obs_lsstCam/assignees{/user}","branches_url":"https://api.github.com/repos/lsst/obs_lsstCam/branches{/branch}","tags_url":"https://api.github.com/repos/lsst/obs_lsstCam/tags","blobs_url":"https://api.github.com/repos/lsst/obs_lsstCam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst/obs_lsstCam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst/obs_lsstCam/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst/obs_lsstCam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst/obs_lsstCam/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst/obs_lsstCam/languages","stargazers_url":"https://api.github.com/repos/lsst/obs_lsstCam/stargazers","contributors_url":"https://api.github.com/repos/lsst/obs_lsstCam/contributors","subscribers_url":"https://api.github.com/repos/lsst/obs_lsstCam/subscribers","subscription_url":"https://api.github.com/repos/lsst/obs_lsstCam/subscription","commits_url":"https://api.github.com/repos/lsst/obs_lsstCam/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst/obs_lsstCam/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst/obs_lsstCam/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst/obs_lsstCam/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst/obs_lsstCam/contents/{+path}","compare_url":"https://api.github.com/repos/lsst/obs_lsstCam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst/obs_lsstCam/merges","archive_url":"https://api.github.com/repos/lsst/obs_lsstCam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst/obs_lsstCam/downloads","issues_url":"https://api.github.com/repos/lsst/obs_lsstCam/issues{/number}","pulls_url":"https://api.github.com/repos/lsst/obs_lsstCam/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst/obs_lsstCam/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst/obs_lsstCam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst/obs_lsstCam/labels{/name}","releases_url":"https://api.github.com/repos/lsst/obs_lsstCam/releases{/id}","deployments_url":"https://api.github.com/repos/lsst/obs_lsstCam/deployments","created_at":"2018-06-20T01:53:45Z","updated_at":"2018-11-15T22:32:56Z","pushed_at":"2018-11-16T00:14:53Z","git_url":"git://github.com/lsst/obs_lsstCam.git","ssh_url":"git@github.com:lsst/obs_lsstCam.git","clone_url":"https://github.com/lsst/obs_lsstCam.git","svn_url":"https://github.com/lsst/obs_lsstCam","homepage":null,"size":292,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":3,"license":null,"forks":1,"open_issues":3,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lsst/obs_lsstCam/pulls/40"},"html":{"href":"https://github.com/lsst/obs_lsstCam/pull/40"},"issue":{"href":"https://api.github.com/repos/lsst/obs_lsstCam/issues/40"},"comments":{"href":"https://api.github.com/repos/lsst/obs_lsstCam/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/lsst/obs_lsstCam/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/lsst/obs_lsstCam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lsst/obs_lsstCam/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/lsst/obs_lsstCam/statuses/13bc61d2358917735466d6e35310f4ef353a6715"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"TallJimbo"}}