{"action":"created","issue":{"url":"https://api.github.com/repos/valor-software/ngm-cli/issues/26","repository_url":"https://api.github.com/repos/valor-software/ngm-cli","labels_url":"https://api.github.com/repos/valor-software/ngm-cli/issues/26/labels{/name}","comments_url":"https://api.github.com/repos/valor-software/ngm-cli/issues/26/comments","events_url":"https://api.github.com/repos/valor-software/ngm-cli/issues/26/events","html_url":"https://github.com/valor-software/ngm-cli/pull/26","id":330101818,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzMTkyODM2","number":26,"title":"Do not overwrite user tsconfig","user":{"login":"JLHwung","id":3607926,"node_id":"MDQ6VXNlcjM2MDc5MjY=","avatar_url":"https://avatars0.githubusercontent.com/u/3607926?v=4","gravatar_id":"","url":"https://api.github.com/users/JLHwung","html_url":"https://github.com/JLHwung","followers_url":"https://api.github.com/users/JLHwung/followers","following_url":"https://api.github.com/users/JLHwung/following{/other_user}","gists_url":"https://api.github.com/users/JLHwung/gists{/gist_id}","starred_url":"https://api.github.com/users/JLHwung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JLHwung/subscriptions","organizations_url":"https://api.github.com/users/JLHwung/orgs","repos_url":"https://api.github.com/users/JLHwung/repos","events_url":"https://api.github.com/users/JLHwung/events{/privacy}","received_events_url":"https://api.github.com/users/JLHwung/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-06-07T03:14:29Z","updated_at":"2018-08-09T02:29:37Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/valor-software/ngm-cli/pulls/26","html_url":"https://github.com/valor-software/ngm-cli/pull/26","diff_url":"https://github.com/valor-software/ngm-cli/pull/26.diff","patch_url":"https://github.com/valor-software/ngm-cli/pull/26.patch"},"body":"## Motivation\r\n\r\nWe use `jest` to unit test Angular components with `ngx-bootstrap` 3.0.0 imports. The test will fail with\r\n```\r\nCan't resolve all parameters for ComponentLoaderFactory: (?, ?, ?, ?, ?)\r\n```\r\nsince the decorate metadata is not emitted on the umd build of `ngx-bootstrap` even if the tsconfig of `ngx-bootstrap` declares `emitDecoratorMetadata: true`.\r\n\r\nThe bug is introduced in 03769f234ab4871353eaaa6062225ab7383858e9 so `ngx-bootstrap` 2.0 is untouched.\r\n\r\nwebpack does not complain about metadata missing since webpack can use `module` field in `package.json` to resolve `ngx-bootstrap`. However, jest does not support this feature yet, so jest will use `main` field to resolve. When the umd build is lack of decorate metadata, it will fail with angular JIT compiler.\r\n\r\n## Workaround\r\n\r\n(before this PR gets merged and `ngx-bootstrap` is re-bundled by updated `ngm-cli`)\r\n\r\nAdd the following line to `jest.config.js`\r\n```js\r\nmoduleNameMapper: {\r\n    \"ngx-bootstrap\": \"<rootDir>/node_modules/ngx-bootstrap/bundles/ngx-bootstrap.es2015.js\"\r\n},\r\n```"},"comment":{"url":"https://api.github.com/repos/valor-software/ngm-cli/issues/comments/411616831","html_url":"https://github.com/valor-software/ngm-cli/pull/26#issuecomment-411616831","issue_url":"https://api.github.com/repos/valor-software/ngm-cli/issues/26","id":411616831,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMTYxNjgzMQ==","user":{"login":"JLHwung","id":3607926,"node_id":"MDQ6VXNlcjM2MDc5MjY=","avatar_url":"https://avatars0.githubusercontent.com/u/3607926?v=4","gravatar_id":"","url":"https://api.github.com/users/JLHwung","html_url":"https://github.com/JLHwung","followers_url":"https://api.github.com/users/JLHwung/followers","following_url":"https://api.github.com/users/JLHwung/following{/other_user}","gists_url":"https://api.github.com/users/JLHwung/gists{/gist_id}","starred_url":"https://api.github.com/users/JLHwung/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JLHwung/subscriptions","organizations_url":"https://api.github.com/users/JLHwung/orgs","repos_url":"https://api.github.com/users/JLHwung/repos","events_url":"https://api.github.com/users/JLHwung/events{/privacy}","received_events_url":"https://api.github.com/users/JLHwung/received_events","type":"User","site_admin":false},"created_at":"2018-08-09T02:29:37Z","updated_at":"2018-08-09T02:29:37Z","author_association":"NONE","body":"ping @valorkin "}}
{"actor":{"display_login":"JLHwung"}}