{"action":"created","issue":{"url":"https://api.github.com/repos/appcelerator/titanium_mobile/issues/10405","repository_url":"https://api.github.com/repos/appcelerator/titanium_mobile","labels_url":"https://api.github.com/repos/appcelerator/titanium_mobile/issues/10405/labels{/name}","comments_url":"https://api.github.com/repos/appcelerator/titanium_mobile/issues/10405/comments","events_url":"https://api.github.com/repos/appcelerator/titanium_mobile/issues/10405/events","html_url":"https://github.com/appcelerator/titanium_mobile/pull/10405","id":374572109,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MjQ1MTQ5","number":10405,"title":"[TIMOB-25678] Android: Amend hasActivityTransitions() for transitions","user":{"login":"garymathews","id":8366993,"node_id":"MDQ6VXNlcjgzNjY5OTM=","avatar_url":"https://avatars3.githubusercontent.com/u/8366993?v=4","gravatar_id":"","url":"https://api.github.com/users/garymathews","html_url":"https://github.com/garymathews","followers_url":"https://api.github.com/users/garymathews/followers","following_url":"https://api.github.com/users/garymathews/following{/other_user}","gists_url":"https://api.github.com/users/garymathews/gists{/gist_id}","starred_url":"https://api.github.com/users/garymathews/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garymathews/subscriptions","organizations_url":"https://api.github.com/users/garymathews/orgs","repos_url":"https://api.github.com/users/garymathews/repos","events_url":"https://api.github.com/users/garymathews/events{/privacy}","received_events_url":"https://api.github.com/users/garymathews/received_events","type":"User","site_admin":false},"labels":[{"id":319882185,"node_id":"MDU6TGFiZWwzMTk4ODIxODU=","url":"https://api.github.com/repos/appcelerator/titanium_mobile/labels/android","name":"android","color":"006b75","default":false},{"id":319882979,"node_id":"MDU6TGFiZWwzMTk4ODI5Nzk=","url":"https://api.github.com/repos/appcelerator/titanium_mobile/labels/bug%20%F0%9F%90%9C","name":"bug 🐜","color":"e11d21","default":false},{"id":771521575,"node_id":"MDU6TGFiZWw3NzE1MjE1NzU=","url":"https://api.github.com/repos/appcelerator/titanium_mobile/labels/no%20tests","name":"no tests","color":"d93f0b","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/appcelerator/titanium_mobile/milestones/18","html_url":"https://github.com/appcelerator/titanium_mobile/milestone/18","labels_url":"https://api.github.com/repos/appcelerator/titanium_mobile/milestones/18/labels","id":2949858,"node_id":"MDk6TWlsZXN0b25lMjk0OTg1OA==","number":18,"title":"8.0.0","description":"","creator":{"login":"sgtcoolguy","id":3252,"node_id":"MDQ6VXNlcjMyNTI=","avatar_url":"https://avatars0.githubusercontent.com/u/3252?v=4","gravatar_id":"","url":"https://api.github.com/users/sgtcoolguy","html_url":"https://github.com/sgtcoolguy","followers_url":"https://api.github.com/users/sgtcoolguy/followers","following_url":"https://api.github.com/users/sgtcoolguy/following{/other_user}","gists_url":"https://api.github.com/users/sgtcoolguy/gists{/gist_id}","starred_url":"https://api.github.com/users/sgtcoolguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sgtcoolguy/subscriptions","organizations_url":"https://api.github.com/users/sgtcoolguy/orgs","repos_url":"https://api.github.com/users/sgtcoolguy/repos","events_url":"https://api.github.com/users/sgtcoolguy/events{/privacy}","received_events_url":"https://api.github.com/users/sgtcoolguy/received_events","type":"User","site_admin":false},"open_issues":23,"closed_issues":24,"state":"open","created_at":"2017-11-30T20:32:53Z","updated_at":"2018-11-02T19:28:31Z","due_on":"2018-11-28T08:00:00Z","closed_at":null},"comments":1,"created_at":"2018-10-26T22:48:59Z","updated_at":"2018-11-02T21:38:40Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/appcelerator/titanium_mobile/pulls/10405","html_url":"https://github.com/appcelerator/titanium_mobile/pull/10405","diff_url":"https://github.com/appcelerator/titanium_mobile/pull/10405.diff","patch_url":"https://github.com/appcelerator/titanium_mobile/pull/10405.patch"},"body":"- Fix `hasActivityTransitions()` to allow transitions when a `sharedElement` has not been specified\r\n\r\n###### TEST CASE\r\n```JS\r\nvar win = Ti.UI.createWindow({\r\n        backgroundColor: 'blue',\r\n        layout: 'vertical'\r\n    }),\r\n    lbl = Ti.UI.createLabel({\r\n        left: 5,\r\n        text: 'TEST LABEL',\r\n        transitionName: 'lbl'\r\n    }),\r\n    btn = Ti.UI.createButton({\r\n        title: 'OPEN'\r\n    });\r\n\r\nbtn.addEventListener('click', function () {\r\n    var win2 = Ti.UI.createWindow({\r\n            backgroundColor: 'red',\r\n            layout: 'vertical',\r\n            activityEnterTransition: Titanium.UI.Android.TRANSITION_SLIDE_RIGHT\r\n        }),\r\n        lbl2 = Ti.UI.createLabel({\r\n            right: 5,\r\n            text: 'TEST LABEL',\r\n            transitionName: 'lbl'\r\n        }),\r\n        btn2 = Ti.UI.createButton({\r\n            title: 'CLOSE'\r\n        });\r\n\r\n    btn2.addEventListener('click', function () {\r\n        win2.close();\r\n    });\r\n\r\n    win2.add([lbl2, btn2]);\r\n    // win2.addSharedElement(lbl, 'lbl'); // this should not need uncommenting to see a Window transition\r\n\r\n    win2.open();\r\n});\r\n\r\nwin.add([lbl, btn]);\r\nwin.open();\r\n```\r\n\r\n[JIRA Ticket](https://jira.appcelerator.org/browse/TIMOB-25678)"},"comment":{"url":"https://api.github.com/repos/appcelerator/titanium_mobile/issues/comments/435516918","html_url":"https://github.com/appcelerator/titanium_mobile/pull/10405#issuecomment-435516918","issue_url":"https://api.github.com/repos/appcelerator/titanium_mobile/issues/10405","id":435516918,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTUxNjkxOA==","user":{"login":"build","id":125029,"node_id":"MDQ6VXNlcjEyNTAyOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/125029?v=4","gravatar_id":"","url":"https://api.github.com/users/build","html_url":"https://github.com/build","followers_url":"https://api.github.com/users/build/followers","following_url":"https://api.github.com/users/build/following{/other_user}","gists_url":"https://api.github.com/users/build/gists{/gist_id}","starred_url":"https://api.github.com/users/build/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/build/subscriptions","organizations_url":"https://api.github.com/users/build/orgs","repos_url":"https://api.github.com/users/build/repos","events_url":"https://api.github.com/users/build/events{/privacy}","received_events_url":"https://api.github.com/users/build/received_events","type":"User","site_admin":false},"created_at":"2018-11-02T21:38:40Z","updated_at":"2018-11-02T21:38:40Z","author_association":"COLLABORATOR","body":"\n<!--\n  0 failure: \n  0 warning: \n  1 messages\n  \n  DangerID: danger-id-default;\n-->\n\n\n\n<table>\n  <thead>\n    <tr>\n      <th width=\"50\"></th>\n      <th width=\"100%\" data-danger-table=\"true\">Messages</th>\n    </tr>\n  </thead>\n  <tbody><tr>\n      <td>:book:</td>\n      <td>\n\n  :floppy_disk: <a href=\"https://jenkins.appcelerator.org/job/titanium-sdk/job/titanium_mobile/job/PR-10405/49/artifact/dist/mobilesdk-8.0.0.v20181102141648-osx.zip\">Here's the generated SDK zipfile</a>.\n  </td>\n    </tr>\n  </tbody>\n</table>\n\n\n<p align=\"right\">\n  Generated by :no_entry_sign: <a href=\"http://github.com/danger/danger-js/\">dangerJS</a>\n</p>\n"}}
{"actor":{"display_login":"build"}}