{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/202640522","pull_request_review_id":137376088,"id":202640522,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjY0MDUyMg==","diff_hunk":"@@ -425,6 +429,12 @@ wconf() {\n \tfi\n }\n \n+get_nvmeserialnumber() {","path":"src/vstart.sh","position":22,"original_position":22,"commit_id":"2416fccde16190afab5e4e063e9a9e84423a13ff","original_commit_id":"2416fccde16190afab5e4e063e9a9e84423a13ff","user":{"login":"tone-zhang","id":19795045,"node_id":"MDQ6VXNlcjE5Nzk1MDQ1","avatar_url":"https://avatars2.githubusercontent.com/u/19795045?v=4","gravatar_id":"","url":"https://api.github.com/users/tone-zhang","html_url":"https://github.com/tone-zhang","followers_url":"https://api.github.com/users/tone-zhang/followers","following_url":"https://api.github.com/users/tone-zhang/following{/other_user}","gists_url":"https://api.github.com/users/tone-zhang/gists{/gist_id}","starred_url":"https://api.github.com/users/tone-zhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tone-zhang/subscriptions","organizations_url":"https://api.github.com/users/tone-zhang/orgs","repos_url":"https://api.github.com/users/tone-zhang/repos","events_url":"https://api.github.com/users/tone-zhang/events{/privacy}","received_events_url":"https://api.github.com/users/tone-zhang/received_events","type":"User","site_admin":false},"body":"Thanks. The name is better. :)","created_at":"2018-07-16T10:49:20Z","updated_at":"2018-07-16T10:49:20Z","html_url":"https://github.com/ceph/ceph/pull/22975#discussion_r202640522","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/22975","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/202640522"},"html":{"href":"https://github.com/ceph/ceph/pull/22975#discussion_r202640522"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/22975"}},"in_reply_to_id":202636769},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/22975","id":200570162,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNTcwMTYy","html_url":"https://github.com/ceph/ceph/pull/22975","diff_url":"https://github.com/ceph/ceph/pull/22975.diff","patch_url":"https://github.com/ceph/ceph/pull/22975.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/22975","number":22975,"state":"open","locked":false,"title":"vstart.sh: Support SPDK in Ceph development deployment","user":{"login":"tone-zhang","id":19795045,"node_id":"MDQ6VXNlcjE5Nzk1MDQ1","avatar_url":"https://avatars2.githubusercontent.com/u/19795045?v=4","gravatar_id":"","url":"https://api.github.com/users/tone-zhang","html_url":"https://github.com/tone-zhang","followers_url":"https://api.github.com/users/tone-zhang/followers","following_url":"https://api.github.com/users/tone-zhang/following{/other_user}","gists_url":"https://api.github.com/users/tone-zhang/gists{/gist_id}","starred_url":"https://api.github.com/users/tone-zhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tone-zhang/subscriptions","organizations_url":"https://api.github.com/users/tone-zhang/orgs","repos_url":"https://api.github.com/users/tone-zhang/repos","events_url":"https://api.github.com/users/tone-zhang/events{/privacy}","received_events_url":"https://api.github.com/users/tone-zhang/received_events","type":"User","site_admin":false},"body":"Support SPDK in vstart.sh, the developer can debug SPDK within\r\ndevelopment deployment with option \"-S\".\r\n\r\nSigned-off-by: tone.zhang <tone.zhang@arm.com>","created_at":"2018-07-11T02:21:23Z","updated_at":"2018-07-16T10:49:20Z","closed_at":null,"merged_at":null,"merge_commit_sha":"efbaee4666cbaf272b50cf786dc1ada89b91dde6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":144329561,"node_id":"MDU6TGFiZWwxNDQzMjk1NjE=","url":"https://api.github.com/repos/ceph/ceph/labels/core","name":"core","color":"0041a2","default":false},{"id":340048817,"node_id":"MDU6TGFiZWwzNDAwNDg4MTc=","url":"https://api.github.com/repos/ceph/ceph/labels/needs-review","name":"needs-review","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/22975/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/22975/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/22975/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/2416fccde16190afab5e4e063e9a9e84423a13ff","head":{"label":"tone-zhang:vstart-spdk","ref":"vstart-spdk","sha":"2416fccde16190afab5e4e063e9a9e84423a13ff","user":{"login":"tone-zhang","id":19795045,"node_id":"MDQ6VXNlcjE5Nzk1MDQ1","avatar_url":"https://avatars2.githubusercontent.com/u/19795045?v=4","gravatar_id":"","url":"https://api.github.com/users/tone-zhang","html_url":"https://github.com/tone-zhang","followers_url":"https://api.github.com/users/tone-zhang/followers","following_url":"https://api.github.com/users/tone-zhang/following{/other_user}","gists_url":"https://api.github.com/users/tone-zhang/gists{/gist_id}","starred_url":"https://api.github.com/users/tone-zhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tone-zhang/subscriptions","organizations_url":"https://api.github.com/users/tone-zhang/orgs","repos_url":"https://api.github.com/users/tone-zhang/repos","events_url":"https://api.github.com/users/tone-zhang/events{/privacy}","received_events_url":"https://api.github.com/users/tone-zhang/received_events","type":"User","site_admin":false},"repo":{"id":60598768,"node_id":"MDEwOlJlcG9zaXRvcnk2MDU5ODc2OA==","name":"ceph","full_name":"tone-zhang/ceph","owner":{"login":"tone-zhang","id":19795045,"node_id":"MDQ6VXNlcjE5Nzk1MDQ1","avatar_url":"https://avatars2.githubusercontent.com/u/19795045?v=4","gravatar_id":"","url":"https://api.github.com/users/tone-zhang","html_url":"https://github.com/tone-zhang","followers_url":"https://api.github.com/users/tone-zhang/followers","following_url":"https://api.github.com/users/tone-zhang/following{/other_user}","gists_url":"https://api.github.com/users/tone-zhang/gists{/gist_id}","starred_url":"https://api.github.com/users/tone-zhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tone-zhang/subscriptions","organizations_url":"https://api.github.com/users/tone-zhang/orgs","repos_url":"https://api.github.com/users/tone-zhang/repos","events_url":"https://api.github.com/users/tone-zhang/events{/privacy}","received_events_url":"https://api.github.com/users/tone-zhang/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tone-zhang/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/tone-zhang/ceph","forks_url":"https://api.github.com/repos/tone-zhang/ceph/forks","keys_url":"https://api.github.com/repos/tone-zhang/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tone-zhang/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tone-zhang/ceph/teams","hooks_url":"https://api.github.com/repos/tone-zhang/ceph/hooks","issue_events_url":"https://api.github.com/repos/tone-zhang/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/tone-zhang/ceph/events","assignees_url":"https://api.github.com/repos/tone-zhang/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/tone-zhang/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/tone-zhang/ceph/tags","blobs_url":"https://api.github.com/repos/tone-zhang/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tone-zhang/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tone-zhang/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/tone-zhang/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tone-zhang/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/tone-zhang/ceph/languages","stargazers_url":"https://api.github.com/repos/tone-zhang/ceph/stargazers","contributors_url":"https://api.github.com/repos/tone-zhang/ceph/contributors","subscribers_url":"https://api.github.com/repos/tone-zhang/ceph/subscribers","subscription_url":"https://api.github.com/repos/tone-zhang/ceph/subscription","commits_url":"https://api.github.com/repos/tone-zhang/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/tone-zhang/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/tone-zhang/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/tone-zhang/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/tone-zhang/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/tone-zhang/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tone-zhang/ceph/merges","archive_url":"https://api.github.com/repos/tone-zhang/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tone-zhang/ceph/downloads","issues_url":"https://api.github.com/repos/tone-zhang/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/tone-zhang/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/tone-zhang/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/tone-zhang/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tone-zhang/ceph/labels{/name}","releases_url":"https://api.github.com/repos/tone-zhang/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/tone-zhang/ceph/deployments","created_at":"2016-06-07T09:06:17Z","updated_at":"2018-07-11T02:14:11Z","pushed_at":"2018-07-11T02:20:37Z","git_url":"git://github.com/tone-zhang/ceph.git","ssh_url":"git@github.com:tone-zhang/ceph.git","clone_url":"https://github.com/tone-zhang/ceph.git","svn_url":"https://github.com/tone-zhang/ceph","homepage":"http://ceph.com","size":284691,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"c05a7473d02fa9c8d3caa6cfe621089d5bfdd6a3","user":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"node_id":"MDEwOlJlcG9zaXRvcnkyMzEwNDk1","name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2018-07-16T05:15:31Z","pushed_at":"2018-07-16T09:59:38Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":298535,"stargazers_count":4792,"watchers_count":4792,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2525,"mirror_url":null,"archived":false,"open_issues_count":747,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2525,"open_issues":747,"watchers":4792,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/22975"},"html":{"href":"https://github.com/ceph/ceph/pull/22975"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/22975"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/22975/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/22975/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/22975/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/2416fccde16190afab5e4e063e9a9e84423a13ff"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tone-zhang"}}