{"push_id":2388879747,"size":62,"distinct_size":1,"ref":"refs/heads/5.5.x","head":"9773e403b7eea7da9a5dac5979c02cec4211069c","before":"e9d9eb1bc83061adfe3e9cf0f688ad4dc36889ee","commits":[{"sha":"bbba8b997342fe357c652fc5e88cca8bc60cad68","author":{"name":"Patrick Carlisle","email":"ea5ba7229c4af92826dc8eb9a8fa8fd4c9c8afd7@puppet.com"},"message":"(maint) Don't depend on os-specific args in yum test\n\nThe debug option varies depending on the version of the OS, causing this test to\nfail on older redhat systems or newer non-redhat systems with lower version\nnumbers. It's not relevant to the test so don't check that part.","distinct":false,"url":"https://api.github.com/repos/puppetlabs/puppet/commits/bbba8b997342fe357c652fc5e88cca8bc60cad68"},{"sha":"e67786aba1e1adc558310349c16bd99f650e64c6","author":{"name":"Ethan J. Brown","email":"c37eab130cb6de1e5c0aca22254f3dca4188c6dc@github"},"message":"Revert \"Merge pull request #6680 from puppetlabs/revert-6647-PUP-7326-handle-unresolvable-SIDs-in-Windows-group\"\n\nThis reverts commit 62547f9969ba413f3f865f366ae5a8777b220aef, reversing\nchanges made to f4955e6d289551f9d6ba098afbbc5210648e7dc1.","distinct":false,"url":"https://api.github.com/repos/puppetlabs/puppet/commits/e67786aba1e1adc558310349c16bd99f650e64c6"},{"sha":"45af1c5c5eefa03414c462680163462a631b3fe3","author":{"name":"Jenkins CI","email":"ea125c00642277991785d4f46d514c725076a465@puppet.com"},"message":"(packaging) Updating the puppet.pot file","distinct":false,"url":"https://api.github.com/repos/puppetlabs/puppet/commits/45af1c5c5eefa03414c462680163462a631b3fe3"},{"sha":"e58df5f7b483658491868d91b861acd7b741c4bb","author":{"name":"Jenkins CI","email":"ea125c00642277991785d4f46d514c725076a465@puppet.com"},"message":"(packaging) Updating manpage file for 5.4.x","distinct":false,"url":"https://api.github.com/repos/puppetlabs/puppet/commits/e58df5f7b483658491868d91b861acd7b741c4bb"},{"sha":"1e63ef6c923d02c1c8779806769af52f42532845","author":{"name":"Josh Cooper","email":"2d27c8320aa3eefe09ead96ce62c361629bc5ad6@puppet.com"},"message":"Merge pull request #6675 from pcarlisle/fix-yum-test\n\n(maint) Don't depend on os-specific args in yum test","distinct":false,"url":"https://api.github.com/repos/puppetlabs/puppet/commits/1e63ef6c923d02c1c8779806769af52f42532845"},{"sha":"d919ceed21548369f6da288d6024752b120adf68","author":{"name":"Ethan J. Brown","email":"c37eab130cb6de1e5c0aca22254f3dca4188c6dc@github"},"message":"(PUP-7326) Fix bad data in ADSI spec\n\n - 64209e4b6a5afe0456cb3730e3f019e187bd3a52 introduced new code for\n   handling unresolvable SIDs, but contained some test data that\n   mocked ADsUser instances, but mismatched the objectSID and Name\n   values.\n\n   The SID bytes in the ADSI spec had a string equivalent ending in\n   -1112, not -1111. Update the spec accordingly.","distinct":false,"url":"https://api.github.com/repos/puppetlabs/puppet/commits/d919ceed21548369f6da288d6024752b120adf68"},{"sha":"6d119897695362c095edb722b459798a9ef0d95c","author":{"name":"Ethan J. Brown","email":"c37eab130cb6de1e5c0aca22254f3dca4188c6dc@github"},"message":"(PUP-7326) Add to Windows account lookup fail msgs\n\n - When account lookup failures occur, the failure may occur within a\n   list of possible SID bytes or account names.\n\n   Improve the error messages by adding the passed data to the error\n   message.","distinct":false,"url":"https://api.github.com/repos/puppetlabs/puppet/commits/6d119897695362c095edb722b459798a9ef0d95c"},{"sha":"975fab3e8f0aa873372d6f9495ecbee1a7da416b","author":{"name":"Eric Delaney","email":"fc654c8dfe75e595e3c879c6b3d231bf04110968@puppet.com"},"message":"(PUP-8459) add do..end's and |result| where appropriate","distinct":false,"url":"https://api.github.com/repos/puppetlabs/puppet/commits/975fab3e8f0aa873372d6f9495ecbee1a7da416b"},{"sha":"0a2364ea65963e376b1448117f09d0299bb90df4","author":{"name":"Eric Delaney","email":"fc654c8dfe75e595e3c879c6b3d231bf04110968@puppet.com"},"message":"(PUP-8459) auto-indent the updated tests (only whitespace changes)","distinct":false,"url":"https://api.github.com/repos/puppetlabs/puppet/commits/0a2364ea65963e376b1448117f09d0299bb90df4"},{"sha":"91b7301eb1b049eeca617019438c089e56ad6049","author":{"name":"Eric Delaney","email":"fc654c8dfe75e595e3c879c6b3d231bf04110968@puppet.com"},"message":"(PUP-8459) add ()'s to calls, quoting, and a couple code readability\n\nAdded ()'s to calls to be more consistent\nAdded single quotes around paths that will be shell interpreted\nConverted a couple remove's to teardown calls\nFixed a line length and readability issue","distinct":false,"url":"https://api.github.com/repos/puppetlabs/puppet/commits/91b7301eb1b049eeca617019438c089e56ad6049"},{"sha":"dbbf7a89f17d885f2f5e50b8b18e1001cb435cbc","author":{"name":"Eric Delaney","email":"fc654c8dfe75e595e3c879c6b3d231bf04110968@puppet.com"},"message":"(PUP-8459) add check for catalog compilation count\n\nAdd a test that we only compile and cache the catalog once for this test\nto ensure that that we aren't doing extra work switching environments.","distinct":false,"url":"https://api.github.com/repos/puppetlabs/puppet/commits/dbbf7a89f17d885f2f5e50b8b18e1001cb435cbc"},{"sha":"df7a68561ff00a9afbe27d40f9b65ea9392879c0","author":{"name":"Ethan J. Brown","email":"c37eab130cb6de1e5c0aca22254f3dca4188c6dc@github"},"message":"(PUP-7326) octet_string_to_sid_string accessibility\n\n - `private` doesn't do anything in modules, and this method is fine\n   to be marked public","distinct":false,"url":"https://api.github.com/repos/puppetlabs/puppet/commits/df7a68561ff00a9afbe27d40f9b65ea9392879c0"},{"sha":"5b1d3aaa11e251cd6f034ecd2af1987a1997c7a9","author":{"name":"Ethan J. Brown","email":"c37eab130cb6de1e5c0aca22254f3dca4188c6dc@github"},"message":"(PUP-7326) Windows ads_to_principal error handling\n\n - Previously there were 3 criteria which would consider a ADsUser\n   object as unresolvable but valid:\n\n   * LookupAccountSidW returns ERROR_NONE_MAPPED\n   * ValidSidW return TRUE\n   * ConvertSidToStringSidW for the ADsUser objectSID value, matches\n     its Name value\n\n   However, the error handling responsible for raising sane errors\n   didn't differentiate failure conditions. Change it so that:\n\n   * When a failure occurs that is not ERROR_NONE_MAPPED, raise it\n   * If a mapping failure occurs, but ValidSidW returns FALSE OR\n     ConvertSidToStringSidW yields a different value from the ADsUser\n     objectSID than it's Name, wrap the mapping error with a more\n     descriptive error\n\n - Cleanup rescue block with introduction of new helper method to\n   build a Principal representing an unresolvable SID","distinct":false,"url":"https://api.github.com/repos/puppetlabs/puppet/commits/5b1d3aaa11e251cd6f034ecd2af1987a1997c7a9"},{"sha":"addf82ad5b9a43ef9e4330ebd6796bbf7c4d8105","author":{"name":"Glenn Sarti","email":"900edb71f3a42fb982755727aa85ef464ad14b72@users.noreply.github.com"},"message":"Merge pull request #6687 from Iristyle/PUP-7326-handle-unresolvable-SIDs-in-Windows-group-redux\n\n(PUP-7326) Handle unresolvable SIDs in Windows groups","distinct":false,"url":"https://api.github.com/repos/puppetlabs/puppet/commits/addf82ad5b9a43ef9e4330ebd6796bbf7c4d8105"},{"sha":"ed204ce33cdd24eb616279a33e3f10aa82de3db6","author":{"name":"Jenkins CI","email":"ea125c00642277991785d4f46d514c725076a465@puppet.com"},"message":"(packaging) Updating manpage file for 4.10.x","distinct":false,"url":"https://api.github.com/repos/puppetlabs/puppet/commits/ed204ce33cdd24eb616279a33e3f10aa82de3db6"},{"sha":"92191ac1fb1fc91902c81cd71585326ca2a7604e","author":{"name":"Iristyle","email":"c37eab130cb6de1e5c0aca22254f3dca4188c6dc@github"},"message":"(PUP-7326) Add ADSI / Principal localizations\n\n - Add _() calls for localizable strings, so that it will be easier\n   after the next merge (which will have a few easily resolved\n   merge conflicts) to perform automated merge-ups","distinct":false,"url":"https://api.github.com/repos/puppetlabs/puppet/commits/92191ac1fb1fc91902c81cd71585326ca2a7604e"},{"sha":"2278c10f34c69aae1edbe639d3e5aed283fded3d","author":{"name":"Eric Delaney","email":"fc654c8dfe75e595e3c879c6b3d231bf04110968@puppet.com"},"message":"(PUP-8505) add do..end's and |results| to the tests","distinct":false,"url":"https://api.github.com/repos/puppetlabs/puppet/commits/2278c10f34c69aae1edbe639d3e5aed283fded3d"},{"sha":"7895d36ba8f22c0b5a869a341ab19e75cb43a926","author":{"name":"Eric Delaney","email":"fc654c8dfe75e595e3c879c6b3d231bf04110968@puppet.com"},"message":"(PUP-8505) reformated the files with RubyMine (only whitespace changed)","distinct":false,"url":"https://api.github.com/repos/puppetlabs/puppet/commits/7895d36ba8f22c0b5a869a341ab19e75cb43a926"},{"sha":"5353c2030f9284ded03bfd2105b210ac87db5a9f","author":{"name":"Eric Delaney","email":"fc654c8dfe75e595e3c879c6b3d231bf04110968@puppet.com"},"message":"(PUP-8505) joined separate lines into fewer lines","distinct":false,"url":"https://api.github.com/repos/puppetlabs/puppet/commits/5353c2030f9284ded03bfd2105b210ac87db5a9f"},{"sha":"70ada99403eb31cbe1f9aeb8ace18ae6e7fe93b8","author":{"name":"Glenn Sarti","email":"900edb71f3a42fb982755727aa85ef464ad14b72@users.noreply.github.com"},"message":"Merge pull request #6695 from Iristyle/ticket/4.10.x/PUP-7326-localize-strings\n\n(PUP-7326) Add ADSI / Principal localizations","distinct":false,"url":"https://api.github.com/repos/puppetlabs/puppet/commits/70ada99403eb31cbe1f9aeb8ace18ae6e7fe93b8"}]}
{"actor":{"display_login":"joshcooper"}}