{"action":"created","issue":{"url":"https://api.github.com/repos/Kong/kong/issues/3924","repository_url":"https://api.github.com/repos/Kong/kong","labels_url":"https://api.github.com/repos/Kong/kong/issues/3924/labels{/name}","comments_url":"https://api.github.com/repos/Kong/kong/issues/3924/comments","events_url":"https://api.github.com/repos/Kong/kong/issues/3924/events","html_url":"https://github.com/Kong/kong/issues/3924","id":374855273,"node_id":"MDU6SXNzdWUzNzQ4NTUyNzM=","number":3924,"title":"Kong 1.0rc2 migrations from 0.14.1 to 1.0rc2 issues","user":{"login":"jeremyjpj0916","id":31913027,"node_id":"MDQ6VXNlcjMxOTEzMDI3","avatar_url":"https://avatars1.githubusercontent.com/u/31913027?v=4","gravatar_id":"","url":"https://api.github.com/users/jeremyjpj0916","html_url":"https://github.com/jeremyjpj0916","followers_url":"https://api.github.com/users/jeremyjpj0916/followers","following_url":"https://api.github.com/users/jeremyjpj0916/following{/other_user}","gists_url":"https://api.github.com/users/jeremyjpj0916/gists{/gist_id}","starred_url":"https://api.github.com/users/jeremyjpj0916/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeremyjpj0916/subscriptions","organizations_url":"https://api.github.com/users/jeremyjpj0916/orgs","repos_url":"https://api.github.com/users/jeremyjpj0916/repos","events_url":"https://api.github.com/users/jeremyjpj0916/events{/privacy}","received_events_url":"https://api.github.com/users/jeremyjpj0916/received_events","type":"User","site_admin":false},"labels":[{"id":148836422,"node_id":"MDU6TGFiZWwxNDg4MzY0MjI=","url":"https://api.github.com/repos/Kong/kong/labels/task/bug","name":"task/bug","color":"b60205","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":18,"created_at":"2018-10-29T04:35:41Z","updated_at":"2018-11-07T18:16:47Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Figured Kong may want some external feedback on what migrations looks like from an outside user. So here is my initial thought based on what I see: \r\n\r\n### Summary\r\nGenerally I expect conclusive results at the end of a migrations informing me everything completed successfully or not. My first run of the migrations from a Cassandra database running the 0.14.1 Kong using Cassandra 3.11.x seems to have some mixed bag of results. Log detailed below\r\n\r\n```\r\n2018/10/29 04:22:23 [verbose] Kong: 1.0.0rc2\r\n2018/10/29 04:22:23 [debug] ngx_lua: 10013\r\n2018/10/29 04:22:23 [debug] nginx: 1013006\r\n2018/10/29 04:22:23 [debug] Lua: LuaJIT 2.1.0-beta3\r\n2018/10/29 04:22:23 [verbose] no config file found at /etc/kong/kong.conf\r\n2018/10/29 04:22:23 [verbose] no config file found at /etc/kong.conf\r\n2018/10/29 04:22:23 [verbose] no config file, skip loading\r\n2018/10/29 04:22:23 [debug] reading environment variables\r\n2018/10/29 04:22:23 [debug] KONG_CASSANDRA_USERNAME ENV found with \"dbUsername\"\r\n2018/10/29 04:22:23 [debug] KONG_PG_USER ENV found with \"\"\r\n2018/10/29 04:22:23 [debug] KONG_CASSANDRA_DATA_CENTERS ENV found with \"DC1:3,DC2:3\"\r\n2018/10/29 04:22:23 [debug] KONG_CASSANDRA_PASSWORD ENV found with \"******\"\r\n2018/10/29 04:22:23 [debug] KONG_PG_HOST ENV found with \"\"\r\n2018/10/29 04:22:23 [debug] KONG_CASSANDRA_SSL ENV found with \"on\"\r\n2018/10/29 04:22:23 [debug] KONG_CASSANDRA_PORT ENV found with \"9042\"\r\n2018/10/29 04:22:23 [debug] KONG_DATABASE ENV found with \"cassandra\"\r\n2018/10/29 04:22:23 [debug] KONG_PG_DATABASE ENV found with \"\"\r\n2018/10/29 04:22:23 [debug] KONG_CASSANDRA_LOCAL_DATACENTER ENV found with \"DC1\"\r\n2018/10/29 04:22:23 [debug] KONG_CASSANDRA_CONSISTENCY ENV found with \"LOCAL_QUORUM\"\r\n2018/10/29 04:22:23 [debug] KONG_PG_SSL_VERIFY ENV found with \"\"\r\n2018/10/29 04:22:23 [debug] KONG_PG_SSL ENV found with \"off\"\r\n2018/10/29 04:22:23 [debug] KONG_CASSANDRA_REPL_STRATEGY ENV found with \"NetworkTopologyStrategy\"\r\n2018/10/29 04:22:23 [debug] KONG_CASSANDRA_SCHEMA_CONSENSUS_TIMEOUT ENV found with \"120000\"\r\n2018/10/29 04:22:23 [debug] KONG_CASSANDRA_TIMEOUT ENV found with \"20000\"\r\n2018/10/29 04:22:23 [debug] KONG_CASSANDRA_SSL_VERIFY ENV found with \"on\"\r\n2018/10/29 04:22:23 [debug] KONG_CASSANDRA_CONTACT_POINTS ENV found with \"server00467\"\r\n2018/10/29 04:22:23 [debug] KONG_PG_PASSWORD ENV found with \"******\"\r\n2018/10/29 04:22:23 [debug] KONG_LUA_SSL_VERIFY_DEPTH ENV found with \"3\"\r\n2018/10/29 04:22:23 [debug] KONG_PG_PORT ENV found with \"\"\r\n2018/10/29 04:22:23 [debug] KONG_LUA_SSL_TRUSTED_CERTIFICATE ENV found with \"/usr/local/kong/ssl/kongcert.pem\"\r\n2018/10/29 04:22:23 [warn] You are using Cassandra but your 'db_update_propagation' setting is set to '0' (default). Due to the distributed nature of Cassandra, you should increase this value.\r\n2018/10/29 04:22:23 [debug] KONG_CASSANDRA_LB_POLICY ENV found with \"RequestDCAwareRoundRobin\"\r\n2018/10/29 04:22:23 [debug] KONG_CASSANDRA_REPL_FACTOR ENV found with \"3\"\r\n2018/10/29 04:22:23 [debug] KONG_CASSANDRA_KEYSPACE ENV found with \"kong_dev\"\r\n2018/10/29 04:22:23 [debug] KONG_NGINX_DAEMON ENV found with \"off\"\r\n2018/10/29 04:22:23 [debug] admin_access_log = \"logs/admin_access.log\"\r\n2018/10/29 04:22:23 [debug] admin_error_log = \"logs/error.log\"\r\n2018/10/29 04:22:23 [debug] admin_listen = {\"127.0.0.1:8001\",\"127.0.0.1:8444 ssl\"}\r\n2018/10/29 04:22:23 [debug] anonymous_reports = true\r\n2018/10/29 04:22:23 [debug] cassandra_consistency = \"LOCAL_QUORUM\"\r\n2018/10/29 04:22:23 [debug] cassandra_contact_points = {\"server00467\"}\r\n2018/10/29 04:22:23 [debug] cassandra_data_centers = {\"DC1:3\",\"DC2:3\"}\r\n2018/10/29 04:22:23 [debug] cassandra_keyspace = \"kong_dev\"\r\n2018/10/29 04:22:23 [debug] cassandra_lb_policy = \"RequestDCAwareRoundRobin\"\r\n2018/10/29 04:22:23 [debug] cassandra_local_datacenter = \"DC1\"\r\n2018/10/29 04:22:23 [debug] cassandra_password = \"******\"\r\n2018/10/29 04:22:23 [debug] cassandra_port = 9042\r\n2018/10/29 04:22:23 [debug] cassandra_repl_factor = 3\r\n2018/10/29 04:22:23 [debug] cassandra_repl_strategy = \"NetworkTopologyStrategy\"\r\n2018/10/29 04:22:23 [debug] cassandra_schema_consensus_timeout = 120000\r\n2018/10/29 04:22:23 [debug] cassandra_ssl = true\r\n2018/10/29 04:22:23 [debug] cassandra_ssl_verify = true\r\n2018/10/29 04:22:23 [debug] cassandra_timeout = 20000\r\n2018/10/29 04:22:23 [debug] cassandra_username = \"dbUsername\"\r\n2018/10/29 04:22:23 [debug] client_body_buffer_size = \"8k\"\r\n2018/10/29 04:22:23 [debug] client_max_body_size = \"0\"\r\n2018/10/29 04:22:23 [debug] client_ssl = false\r\n2018/10/29 04:22:23 [debug] custom_plugins = {}\r\n2018/10/29 04:22:23 [debug] database = \"cassandra\"\r\n2018/10/29 04:22:23 [debug] db_cache_ttl = 0\r\n2018/10/29 04:22:23 [debug] db_resurrect_ttl = 30\r\n2018/10/29 04:22:23 [debug] db_update_frequency = 5\r\n2018/10/29 04:22:23 [debug] db_update_propagation = 0\r\n2018/10/29 04:22:23 [debug] dns_error_ttl = 1\r\n2018/10/29 04:22:23 [debug] dns_hostsfile = \"/etc/hosts\"\r\n2018/10/29 04:22:23 [debug] dns_no_sync = false\r\n2018/10/29 04:22:23 [debug] dns_not_found_ttl = 30\r\n2018/10/29 04:22:23 [debug] dns_order = {\"LAST\",\"SRV\",\"A\",\"CNAME\"}\r\n2018/10/29 04:22:23 [debug] dns_resolver = {}\r\n2018/10/29 04:22:23 [debug] dns_stale_ttl = 4\r\n2018/10/29 04:22:23 [debug] error_default_type = \"text/plain\"\r\n2018/10/29 04:22:23 [debug] headers = {\"server_tokens\",\"latency_tokens\"}\r\n2018/10/29 04:22:23 [debug] log_level = \"notice\"\r\n2018/10/29 04:22:23 [debug] lua_package_cpath = \"\"\r\n2018/10/29 04:22:23 [debug] lua_package_path = \"./?.lua;./?/init.lua;\"\r\n2018/10/29 04:22:23 [debug] lua_socket_pool_size = 30\r\n2018/10/29 04:22:23 [debug] lua_ssl_trusted_certificate = \"/usr/local/kong/ssl/kongcert.pem\"\r\n2018/10/29 04:22:23 [debug] lua_ssl_verify_depth = 3\r\n2018/10/29 04:22:23 [debug] mem_cache_size = \"128m\"\r\n2018/10/29 04:22:23 [debug] nginx_admin_directives = {}\r\n2018/10/29 04:22:23 [debug] nginx_daemon = \"off\"\r\n2018/10/29 04:22:23 [debug] nginx_http_directives = {}\r\n2018/10/29 04:22:23 [debug] nginx_optimizations = true\r\n2018/10/29 04:22:23 [debug] nginx_proxy_directives = {}\r\n2018/10/29 04:22:23 [debug] nginx_user = \"nobody nobody\"\r\n2018/10/29 04:22:23 [debug] nginx_worker_processes = \"auto\"\r\n2018/10/29 04:22:23 [debug] origins = {}\r\n2018/10/29 04:22:23 [debug] pg_ssl = false\r\n2018/10/29 04:22:23 [debug] pg_ssl_verify = false\r\n2018/10/29 04:22:23 [debug] pg_timeout = 5000\r\n2018/10/29 04:22:23 [debug] plugins = {\"bundled\"}\r\n2018/10/29 04:22:23 [debug] prefix = \"/usr/local/kong/\"\r\n2018/10/29 04:22:23 [debug] proxy_access_log = \"logs/access.log\"\r\n2018/10/29 04:22:23 [debug] proxy_error_log = \"logs/error.log\"\r\n2018/10/29 04:22:23 [debug] proxy_listen = {\"0.0.0.0:8000\",\"0.0.0.0:8443 ssl\"}\r\n2018/10/29 04:22:23 [debug] real_ip_header = \"X-Real-IP\"\r\n2018/10/29 04:22:23 [debug] real_ip_recursive = \"off\"\r\n2018/10/29 04:22:23 [debug] ssl_cipher_suite = \"modern\"\r\n2018/10/29 04:22:23 [debug] ssl_ciphers = \"ECDHE-ECDSA-AES256-GCM-SHA384:ECDHE-RSA-AES256-GCM-SHA384:ECDHE-ECDSA-CHACHA20-POLY1305:ECDHE-RSA-CHACHA20-POLY1305:ECDHE-ECDSA-AES128-GCM-SHA256:ECDHE-RSA-AES128-GCM-SHA256:ECDHE-ECDSA-AES256-SHA384:ECDHE-RSA-AES256-SHA384:ECDHE-ECDSA-AES128-SHA256:ECDHE-RSA-AES128-SHA256\"\r\n2018/10/29 04:22:23 [debug] trusted_ips = {}\r\n2018/10/29 04:22:23 [debug] upstream_keepalive = 60\r\n2018/10/29 04:22:23 [verbose] prefix in use: /usr/local/kong\r\n2018/10/29 04:22:24 [debug] loading subsystems migrations...\r\n2018/10/29 04:22:24 [verbose] retrieving keyspace schema state...\r\n2018/10/29 04:22:24 [verbose] schema state retrieved\r\n2018/10/29 04:22:24 [info] upgrading from 0.14, bootstrapping database...\r\n2018/10/29 04:22:24 [debug] creating 'kong_dev' keyspace if not existing...\r\n2018/10/29 04:22:24 [debug] successfully created 'kong_dev' keyspace\r\n2018/10/29 04:22:24 [debug] creating 'schema_meta' table if not existing...\r\n2018/10/29 04:22:25 [debug] successfully created 'schema_meta' table\r\n2018/10/29 04:22:25 [debug] creating 'locks' table if not existing...\r\n2018/10/29 04:22:25 [debug] successfully created 'locks' table\r\n2018/10/29 04:22:25 [verbose] waiting for Cassandra schema consensus (60000ms timeout)...\r\n2018/10/29 04:22:26 [verbose] Cassandra schema consensus: reached\r\n2018/10/29 04:22:26 [debug] loading subsystems migrations...\r\n2018/10/29 04:22:26 [verbose] retrieving keyspace schema state...\r\n2018/10/29 04:22:27 [verbose] schema state retrieved\r\n2018/10/29 04:22:27 [debug] migrations to run:\r\ncore: 000_base, 001_14_to_15\r\noauth2: 000_base_oauth2, 001_14_to_15\r\nacl: 000_base_acl, 001_14_to_15\r\njwt: 000_base_jwt, 001_14_to_15\r\nbasic-auth: 000_base_basic_auth, 001_14_to_15\r\nkey-auth: 000_base_key_auth, 001_14_to_15\r\nrate-limiting: 000_base_rate_limiting, 001_14_to_15\r\nhmac-auth: 000_base_hmac_auth, 001_14_to_15\r\nresponse-ratelimiting: 000_base_response_rate_limiting, 001_14_to_15\r\n2018/10/29 04:22:27 [info] migrating core on keyspace 'kong_dev'...\r\n2018/10/29 04:22:27 [debug] running migration: 000_base\r\n2018/10/29 04:22:27 [info] core migrated up to: 000_base (executed)\r\n2018/10/29 04:22:27 [debug] running migration: 001_14_to_15\r\n2018/10/29 04:22:27 [info] core migrated up to: 001_14_to_15 (pending)\r\n2018/10/29 04:22:27 [info] migrating oauth2 on keyspace 'kong_dev'...\r\n2018/10/29 04:22:27 [debug] running migration: 000_base_oauth2\r\n2018/10/29 04:22:27 [info] oauth2 migrated up to: 000_base_oauth2 (executed)\r\n2018/10/29 04:22:27 [debug] running migration: 001_14_to_15\r\n2018/10/29 04:22:27 [info] oauth2 migrated up to: 001_14_to_15 (pending)\r\n2018/10/29 04:22:27 [info] migrating acl on keyspace 'kong_dev'...\r\n2018/10/29 04:22:27 [debug] running migration: 000_base_acl\r\n2018/10/29 04:22:27 [info] acl migrated up to: 000_base_acl (executed)\r\n2018/10/29 04:22:27 [debug] running migration: 001_14_to_15\r\n2018/10/29 04:22:28 [info] acl migrated up to: 001_14_to_15 (pending)\r\n2018/10/29 04:22:28 [info] migrating jwt on keyspace 'kong_dev'...\r\n2018/10/29 04:22:28 [debug] running migration: 000_base_jwt\r\n2018/10/29 04:22:28 [info] jwt migrated up to: 000_base_jwt (executed)\r\n2018/10/29 04:22:28 [debug] running migration: 001_14_to_15\r\n2018/10/29 04:22:28 [info] jwt migrated up to: 001_14_to_15 (executed)\r\n2018/10/29 04:22:28 [info] migrating basic-auth on keyspace 'kong_dev'...\r\n2018/10/29 04:22:28 [debug] running migration: 000_base_basic_auth\r\n2018/10/29 04:22:28 [info] basic-auth migrated up to: 000_base_basic_auth (executed)\r\n2018/10/29 04:22:28 [debug] running migration: 001_14_to_15\r\n2018/10/29 04:22:28 [info] basic-auth migrated up to: 001_14_to_15 (executed)\r\n2018/10/29 04:22:28 [info] migrating key-auth on keyspace 'kong_dev'...\r\n2018/10/29 04:22:28 [debug] running migration: 000_base_key_auth\r\n2018/10/29 04:22:28 [info] key-auth migrated up to: 000_base_key_auth (executed)\r\n2018/10/29 04:22:28 [debug] running migration: 001_14_to_15\r\n2018/10/29 04:22:28 [info] key-auth migrated up to: 001_14_to_15 (executed)\r\n2018/10/29 04:22:28 [info] migrating rate-limiting on keyspace 'kong_dev'...\r\n2018/10/29 04:22:28 [debug] running migration: 000_base_rate_limiting\r\n2018/10/29 04:22:28 [info] rate-limiting migrated up to: 000_base_rate_limiting (executed)\r\n2018/10/29 04:22:28 [debug] running migration: 001_14_to_15\r\n2018/10/29 04:22:28 [info] rate-limiting migrated up to: 001_14_to_15 (executed)\r\n2018/10/29 04:22:28 [info] migrating hmac-auth on keyspace 'kong_dev'...\r\n2018/10/29 04:22:28 [debug] running migration: 000_base_hmac_auth\r\n2018/10/29 04:22:28 [info] hmac-auth migrated up to: 000_base_hmac_auth (executed)\r\n2018/10/29 04:22:28 [debug] running migration: 001_14_to_15\r\n2018/10/29 04:22:28 [info] hmac-auth migrated up to: 001_14_to_15 (executed)\r\n2018/10/29 04:22:28 [info] migrating response-ratelimiting on keyspace 'kong_dev'...\r\n2018/10/29 04:22:28 [debug] running migration: 000_base_response_rate_limiting\r\n2018/10/29 04:22:28 [info] response-ratelimiting migrated up to: 000_base_response_rate_limiting (executed)\r\n2018/10/29 04:22:28 [debug] running migration: 001_14_to_15\r\n2018/10/29 04:22:28 [info] response-ratelimiting migrated up to: 001_14_to_15 (executed)\r\n2018/10/29 04:22:28 [info] 18 migrations processed\r\n2018/10/29 04:22:28 [info] 15 executed\r\n2018/10/29 04:22:28 [info] 3 pending\r\n```\r\n\r\nPrior migrations have usually finalized themselves with a comment of \r\n\r\n```\r\nCassandra schema consensus: reached (which you can see halfway down the migrations page at one point). \r\n```\r\n\r\nWith no further details. This migrations ran through till OpenShift reports \"completed\" so the ```kong migrations up``` command returned success on execution, but the logs leave me scratching my head as it says 3 things are pending as the last known info?\r\n\r\nI am about to attempt a rerun of the migrations one more time to see if it reveals any extra detail or says everything looks good (and will return to post back 2nd migrations execution results). Regardless this may be a point in the migration process Kong could clean up so its clear to the end user the result."},"comment":{"url":"https://api.github.com/repos/Kong/kong/issues/comments/436724092","html_url":"https://github.com/Kong/kong/issues/3924#issuecomment-436724092","issue_url":"https://api.github.com/repos/Kong/kong/issues/3924","id":436724092,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNjcyNDA5Mg==","user":{"login":"bungle","id":983257,"node_id":"MDQ6VXNlcjk4MzI1Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/983257?v=4","gravatar_id":"","url":"https://api.github.com/users/bungle","html_url":"https://github.com/bungle","followers_url":"https://api.github.com/users/bungle/followers","following_url":"https://api.github.com/users/bungle/following{/other_user}","gists_url":"https://api.github.com/users/bungle/gists{/gist_id}","starred_url":"https://api.github.com/users/bungle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bungle/subscriptions","organizations_url":"https://api.github.com/users/bungle/orgs","repos_url":"https://api.github.com/users/bungle/repos","events_url":"https://api.github.com/users/bungle/events{/privacy}","received_events_url":"https://api.github.com/users/bungle/received_events","type":"User","site_admin":false},"created_at":"2018-11-07T18:16:47Z","updated_at":"2018-11-07T18:16:47Z","author_association":"MEMBER","body":"@thibaultcha comments shows the problem with `nil` semantics there. It is not clear if `set_header(\"x\", nil)` will just return early or if it should actually remove the existing header.  I guess whatever we decide, there can be confusion, and we get \"i thought it would remove the header\" or \"i thought it will skip setting anything because there is nothing to set\". The current design is immune to this."}}
{"actor":{"display_login":"bungle"}}