{"action":"created","issue":{"url":"https://api.github.com/repos/influxdata/platform/issues/648","repository_url":"https://api.github.com/repos/influxdata/platform","labels_url":"https://api.github.com/repos/influxdata/platform/issues/648/labels{/name}","comments_url":"https://api.github.com/repos/influxdata/platform/issues/648/comments","events_url":"https://api.github.com/repos/influxdata/platform/issues/648/events","html_url":"https://github.com/influxdata/platform/pull/648","id":351314931,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4OTQyODk1","number":648,"title":"Using query request struct to query resources","user":{"login":"fntlnz","id":3083633,"node_id":"MDQ6VXNlcjMwODM2MzM=","avatar_url":"https://avatars1.githubusercontent.com/u/3083633?v=4","gravatar_id":"","url":"https://api.github.com/users/fntlnz","html_url":"https://github.com/fntlnz","followers_url":"https://api.github.com/users/fntlnz/followers","following_url":"https://api.github.com/users/fntlnz/following{/other_user}","gists_url":"https://api.github.com/users/fntlnz/gists{/gist_id}","starred_url":"https://api.github.com/users/fntlnz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fntlnz/subscriptions","organizations_url":"https://api.github.com/users/fntlnz/orgs","repos_url":"https://api.github.com/users/fntlnz/repos","events_url":"https://api.github.com/users/fntlnz/events{/privacy}","received_events_url":"https://api.github.com/users/fntlnz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-08-16T18:18:14Z","updated_at":"2018-08-23T13:57:18Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/influxdata/platform/pulls/648","html_url":"https://github.com/influxdata/platform/pull/648","diff_url":"https://github.com/influxdata/platform/pull/648.diff","patch_url":"https://github.com/influxdata/platform/pull/648.patch"},"body":"TODO:\r\n- [x] Use the query.Request struct for query requests to sources\r\n- [x] Add Flux and spec mappings \r\n- [x] SourceQueryService skeleton \r\n- [x] Implement the `Query` function in the `SourceQueryService` to proxy to the external sources\r\n~- [ ] Debug on `query/query.go:203` - dialect non taken from the request body for some reason.~\r\n~- [ ] Check if the reworked external query handler still works and respect requirements `http/external_query_handler.go:44`~\r\n~- [ ] Support for influxql mappingsnot yet done `http/source_service.go:94`~\r\n- [ ] Work on the specific ProxyQueryServices as summarized [here](https://github.com/influxdata/platform/pull/648/commits/fbe18aa14181bd8c7e558164b271c0a746398ee9)\r\n\r\nSigned-off-by: Lorenzo Fontana <lo@linux.com>\r\n\r\nCloses #594\r\n\r\n\r\n  - [ ] CHANGELOG.md updated with a link to the PR (not the Issue)\r\n  - [x] Rebased/mergeable\r\n  - [x] Tests pass\r\n  - [ ] swagger.json updated (if modified Go structs or API)\r\n  - [x] Sign [CLA](https://influxdata.com/community/cla/) (if not already signed)"},"comment":{"url":"https://api.github.com/repos/influxdata/platform/issues/comments/415423173","html_url":"https://github.com/influxdata/platform/pull/648#issuecomment-415423173","issue_url":"https://api.github.com/repos/influxdata/platform/issues/648","id":415423173,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNTQyMzE3Mw==","user":{"login":"goller","id":1922921,"node_id":"MDQ6VXNlcjE5MjI5MjE=","avatar_url":"https://avatars2.githubusercontent.com/u/1922921?v=4","gravatar_id":"","url":"https://api.github.com/users/goller","html_url":"https://github.com/goller","followers_url":"https://api.github.com/users/goller/followers","following_url":"https://api.github.com/users/goller/following{/other_user}","gists_url":"https://api.github.com/users/goller/gists{/gist_id}","starred_url":"https://api.github.com/users/goller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goller/subscriptions","organizations_url":"https://api.github.com/users/goller/orgs","repos_url":"https://api.github.com/users/goller/repos","events_url":"https://api.github.com/users/goller/events{/privacy}","received_events_url":"https://api.github.com/users/goller/received_events","type":"User","site_admin":false},"created_at":"2018-08-23T13:57:18Z","updated_at":"2018-08-23T13:57:18Z","author_association":"CONTRIBUTOR","body":"Ok, I’d like this to be switched to just the query parameter \n\n> On Aug 23, 2018, at 3:46 AM, Lorenzo Fontana <notifications@github.com> wrote:\n> \n> @fntlnz commented on this pull request.\n> \n> In http/external_query_handler.go:\n> \n> > -\t\t\treturn fmt.Errorf(\"invalid dialect delimeter: must be length  1\")\n> -\t\t}\n> -\t\tfor _, a := range request.Dialect.Annotations {\n> -\t\t\tswitch a {\n> -\t\t\tcase \"group\", \"datatype\", \"default\":\n> -\t\t\tdefault:\n> -\t\t\t\treturn fmt.Errorf(`unknown dialect annotation type: %s`, a)\n> -\t\t\t}\n> -\t\t}\n> -\n> -\t\tswitch request.Dialect.DateTimeFormat {\n> -\t\tcase \"RFC3339\", \"RFC3339Nano\":\n> -\t\tdefault:\n> -\t\t\treturn fmt.Errorf(`unknown dialect date time format: %s`, request.Dialect.DateTimeFormat)\n> +\tdefault:\n> +\t\torgName := r.FormValue(\"organization\")\n> This is only triggered when the message is not a application/json. The code is not original from me, if you look at the diff it is the same behavior as it was before my change, I only changed the application/json behavior to support the query.ProxyRequest struct.\n> \n> —\n> You are receiving this because your review was requested.\n> Reply to this email directly, view it on GitHub, or mute the thread.\n"}}
{"actor":{"display_login":"goller"}}