{"action":"created","issue":{"url":"https://api.github.com/repos/ctz/rustls/issues/168","repository_url":"https://api.github.com/repos/ctz/rustls","labels_url":"https://api.github.com/repos/ctz/rustls/issues/168/labels{/name}","comments_url":"https://api.github.com/repos/ctz/rustls/issues/168/comments","events_url":"https://api.github.com/repos/ctz/rustls/issues/168/events","html_url":"https://github.com/ctz/rustls/pull/168","id":315835535,"number":168,"title":"Allow passing extra extensions to the Client, to be added to the handshake","user":{"login":"djc","id":158471,"avatar_url":"https://avatars0.githubusercontent.com/u/158471?v=4","gravatar_id":"","url":"https://api.github.com/users/djc","html_url":"https://github.com/djc","followers_url":"https://api.github.com/users/djc/followers","following_url":"https://api.github.com/users/djc/following{/other_user}","gists_url":"https://api.github.com/users/djc/gists{/gist_id}","starred_url":"https://api.github.com/users/djc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djc/subscriptions","organizations_url":"https://api.github.com/users/djc/orgs","repos_url":"https://api.github.com/users/djc/repos","events_url":"https://api.github.com/users/djc/events{/privacy}","received_events_url":"https://api.github.com/users/djc/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-04-19T11:25:04Z","updated_at":"2018-04-28T17:59:30Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ctz/rustls/pulls/168","html_url":"https://github.com/ctz/rustls/pull/168","diff_url":"https://github.com/ctz/rustls/pull/168.diff","patch_url":"https://github.com/ctz/rustls/pull/168.patch"},"body":"This is what I've been using with my QUIC implementation; seems to work.\r\n\r\nAs a next step, we could pull out the `TransportParameters` code again, and I could just pass in an `UnknownExtension`, but I wanted to run this by you first.\r\n\r\nThe clone is a bit ugly, but I'm not sure there is a better way right now. I suppose there could be a second `ext_refs` that copies a ref from the locally-created extensions, which we could then add the externally-added extensions to. There is also the risk of code size bulking from the extra impls, not sure how concerning that is to you."},"comment":{"url":"https://api.github.com/repos/ctz/rustls/issues/comments/385194538","html_url":"https://github.com/ctz/rustls/pull/168#issuecomment-385194538","issue_url":"https://api.github.com/repos/ctz/rustls/issues/168","id":385194538,"user":{"login":"Ralith","id":104558,"avatar_url":"https://avatars2.githubusercontent.com/u/104558?v=4","gravatar_id":"","url":"https://api.github.com/users/Ralith","html_url":"https://github.com/Ralith","followers_url":"https://api.github.com/users/Ralith/followers","following_url":"https://api.github.com/users/Ralith/following{/other_user}","gists_url":"https://api.github.com/users/Ralith/gists{/gist_id}","starred_url":"https://api.github.com/users/Ralith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ralith/subscriptions","organizations_url":"https://api.github.com/users/Ralith/orgs","repos_url":"https://api.github.com/users/Ralith/repos","events_url":"https://api.github.com/users/Ralith/events{/privacy}","received_events_url":"https://api.github.com/users/Ralith/received_events","type":"User","site_admin":false},"created_at":"2018-04-28T17:59:30Z","updated_at":"2018-04-28T17:59:30Z","author_association":"NONE","body":"It should also be easy (and otherwise necessary) for us as QUIC implementers to do the `write_tls`, `process_new_packets`, `read_tls` dance ourselves, so I don't think there's a need for the `quic::ClientSession`/`quic::ServerSession` interfaces proposed by the current form of this PR at all."}}
{"actor":{"display_login":"Ralith"}}