{"action":"created","comment":{"url":"https://api.github.com/repos/opencog/atomspace/pulls/comments/243744210","pull_request_review_id":187600811,"id":243744210,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0Mzc0NDIxMA==","diff_hunk":"@@ -237,10 +237,13 @@ void Rule::add(AtomSpace& as)\n \tif (!_rule)\n \t\treturn;\n \n-\tHandleSeq outgoings;\n-\tfor (const Handle& h : _rule->getOutgoingSet())\n-\t\toutgoings.push_back(as.add_atom(h));\n-\t_rule = createBindLink(outgoings);\n+\t// XXX FIXME ... this seems wrong ... why would we EVER create\n+\t// a BindLink, and NOT put it in the atomspace?  The correct\n+\t// fix would seem to be to say\n+\t// _rule = BindLinkCast(as.add_link(BIND_LINK, _rule->getOutgoingSet()));\n+\t// but doing this causes BackwardChainerUTest to consistently crash.\n+\t// This sure smells like a bug, somewhere, to me.","path":"opencog/rule-engine/Rule.cc","position":13,"original_position":13,"commit_id":"c532fc39db93d381af5b52b8c4b5ecb5be6e55e1","original_commit_id":"c532fc39db93d381af5b52b8c4b5ecb5be6e55e1","user":{"login":"ngeiswei","id":819225,"node_id":"MDQ6VXNlcjgxOTIyNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/819225?v=4","gravatar_id":"","url":"https://api.github.com/users/ngeiswei","html_url":"https://github.com/ngeiswei","followers_url":"https://api.github.com/users/ngeiswei/followers","following_url":"https://api.github.com/users/ngeiswei/following{/other_user}","gists_url":"https://api.github.com/users/ngeiswei/gists{/gist_id}","starred_url":"https://api.github.com/users/ngeiswei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngeiswei/subscriptions","organizations_url":"https://api.github.com/users/ngeiswei/orgs","repos_url":"https://api.github.com/users/ngeiswei/repos","events_url":"https://api.github.com/users/ngeiswei/events{/privacy}","received_events_url":"https://api.github.com/users/ngeiswei/received_events","type":"User","site_admin":false},"body":"Now I remember why I don't do the alpha-conversion during expansion. Unification also requires alpha-conversion. I have to carry out unification to check rule validity (if 2 jigsaw puzzle pieces match, one jigsaw piece = inference tree premise or conclusion, another jigsaw piece = rule premise or conclusion, a rule conclusion must match an inference tree premise and such). So after unification I already have an alpha-converted rule that I can pass to the inference tree expansion procedure, by not inserting it to the atomspace I avoid the cost of redoing the alpha-conversion.","created_at":"2018-12-22T19:20:59Z","updated_at":"2018-12-22T19:20:59Z","html_url":"https://github.com/opencog/atomspace/pull/1966#discussion_r243744210","pull_request_url":"https://api.github.com/repos/opencog/atomspace/pulls/1966","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/opencog/atomspace/pulls/comments/243744210"},"html":{"href":"https://github.com/opencog/atomspace/pull/1966#discussion_r243744210"},"pull_request":{"href":"https://api.github.com/repos/opencog/atomspace/pulls/1966"}},"in_reply_to_id":243743761},"pull_request":{"url":"https://api.github.com/repos/opencog/atomspace/pulls/1966","id":240643110,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwNjQzMTEw","html_url":"https://github.com/opencog/atomspace/pull/1966","diff_url":"https://github.com/opencog/atomspace/pull/1966.diff","patch_url":"https://github.com/opencog/atomspace/pull/1966.patch","issue_url":"https://api.github.com/repos/opencog/atomspace/issues/1966","number":1966,"state":"closed","locked":false,"title":"Attempt to avoid minor inefficiencies","user":{"login":"linas","id":94368,"node_id":"MDQ6VXNlcjk0MzY4","avatar_url":"https://avatars2.githubusercontent.com/u/94368?v=4","gravatar_id":"","url":"https://api.github.com/users/linas","html_url":"https://github.com/linas","followers_url":"https://api.github.com/users/linas/followers","following_url":"https://api.github.com/users/linas/following{/other_user}","gists_url":"https://api.github.com/users/linas/gists{/gist_id}","starred_url":"https://api.github.com/users/linas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linas/subscriptions","organizations_url":"https://api.github.com/users/linas/orgs","repos_url":"https://api.github.com/users/linas/repos","events_url":"https://api.github.com/users/linas/events{/privacy}","received_events_url":"https://api.github.com/users/linas/received_events","type":"User","site_admin":false},"body":"There's a functional change in here, too. It doesn't affect the unit tests, but .. it still smells fishy.","created_at":"2018-12-22T16:31:26Z","updated_at":"2018-12-22T19:20:59Z","closed_at":"2018-12-22T19:08:15Z","merged_at":"2018-12-22T19:08:15Z","merge_commit_sha":"220b472539d03e3b56942cb99d9fec6b6f731ca0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/opencog/atomspace/pulls/1966/commits","review_comments_url":"https://api.github.com/repos/opencog/atomspace/pulls/1966/comments","review_comment_url":"https://api.github.com/repos/opencog/atomspace/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opencog/atomspace/issues/1966/comments","statuses_url":"https://api.github.com/repos/opencog/atomspace/statuses/c532fc39db93d381af5b52b8c4b5ecb5be6e55e1","head":{"label":"linas:ru","ref":"ru","sha":"c532fc39db93d381af5b52b8c4b5ecb5be6e55e1","user":{"login":"linas","id":94368,"node_id":"MDQ6VXNlcjk0MzY4","avatar_url":"https://avatars2.githubusercontent.com/u/94368?v=4","gravatar_id":"","url":"https://api.github.com/users/linas","html_url":"https://github.com/linas","followers_url":"https://api.github.com/users/linas/followers","following_url":"https://api.github.com/users/linas/following{/other_user}","gists_url":"https://api.github.com/users/linas/gists{/gist_id}","starred_url":"https://api.github.com/users/linas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linas/subscriptions","organizations_url":"https://api.github.com/users/linas/orgs","repos_url":"https://api.github.com/users/linas/repos","events_url":"https://api.github.com/users/linas/events{/privacy}","received_events_url":"https://api.github.com/users/linas/received_events","type":"User","site_admin":false},"repo":{"id":34914155,"node_id":"MDEwOlJlcG9zaXRvcnkzNDkxNDE1NQ==","name":"atomspace","full_name":"linas/atomspace","private":false,"owner":{"login":"linas","id":94368,"node_id":"MDQ6VXNlcjk0MzY4","avatar_url":"https://avatars2.githubusercontent.com/u/94368?v=4","gravatar_id":"","url":"https://api.github.com/users/linas","html_url":"https://github.com/linas","followers_url":"https://api.github.com/users/linas/followers","following_url":"https://api.github.com/users/linas/following{/other_user}","gists_url":"https://api.github.com/users/linas/gists{/gist_id}","starred_url":"https://api.github.com/users/linas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linas/subscriptions","organizations_url":"https://api.github.com/users/linas/orgs","repos_url":"https://api.github.com/users/linas/repos","events_url":"https://api.github.com/users/linas/events{/privacy}","received_events_url":"https://api.github.com/users/linas/received_events","type":"User","site_admin":false},"html_url":"https://github.com/linas/atomspace","description":"The OpenCog hypergraph database and logic (reasoning) engine","fork":true,"url":"https://api.github.com/repos/linas/atomspace","forks_url":"https://api.github.com/repos/linas/atomspace/forks","keys_url":"https://api.github.com/repos/linas/atomspace/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linas/atomspace/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linas/atomspace/teams","hooks_url":"https://api.github.com/repos/linas/atomspace/hooks","issue_events_url":"https://api.github.com/repos/linas/atomspace/issues/events{/number}","events_url":"https://api.github.com/repos/linas/atomspace/events","assignees_url":"https://api.github.com/repos/linas/atomspace/assignees{/user}","branches_url":"https://api.github.com/repos/linas/atomspace/branches{/branch}","tags_url":"https://api.github.com/repos/linas/atomspace/tags","blobs_url":"https://api.github.com/repos/linas/atomspace/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linas/atomspace/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linas/atomspace/git/refs{/sha}","trees_url":"https://api.github.com/repos/linas/atomspace/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linas/atomspace/statuses/{sha}","languages_url":"https://api.github.com/repos/linas/atomspace/languages","stargazers_url":"https://api.github.com/repos/linas/atomspace/stargazers","contributors_url":"https://api.github.com/repos/linas/atomspace/contributors","subscribers_url":"https://api.github.com/repos/linas/atomspace/subscribers","subscription_url":"https://api.github.com/repos/linas/atomspace/subscription","commits_url":"https://api.github.com/repos/linas/atomspace/commits{/sha}","git_commits_url":"https://api.github.com/repos/linas/atomspace/git/commits{/sha}","comments_url":"https://api.github.com/repos/linas/atomspace/comments{/number}","issue_comment_url":"https://api.github.com/repos/linas/atomspace/issues/comments{/number}","contents_url":"https://api.github.com/repos/linas/atomspace/contents/{+path}","compare_url":"https://api.github.com/repos/linas/atomspace/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linas/atomspace/merges","archive_url":"https://api.github.com/repos/linas/atomspace/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linas/atomspace/downloads","issues_url":"https://api.github.com/repos/linas/atomspace/issues{/number}","pulls_url":"https://api.github.com/repos/linas/atomspace/pulls{/number}","milestones_url":"https://api.github.com/repos/linas/atomspace/milestones{/number}","notifications_url":"https://api.github.com/repos/linas/atomspace/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linas/atomspace/labels{/name}","releases_url":"https://api.github.com/repos/linas/atomspace/releases{/id}","deployments_url":"https://api.github.com/repos/linas/atomspace/deployments","created_at":"2015-05-01T17:20:30Z","updated_at":"2018-12-21T18:04:23Z","pushed_at":"2018-12-22T16:29:41Z","git_url":"git://github.com/linas/atomspace.git","ssh_url":"git@github.com:linas/atomspace.git","clone_url":"https://github.com/linas/atomspace.git","svn_url":"https://github.com/linas/atomspace","homepage":"","size":152691,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opencog:master","ref":"master","sha":"e47dc46daa278c22cf3ba0c503e12b0e1e9b025d","user":{"login":"opencog","id":2109913,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDk5MTM=","avatar_url":"https://avatars1.githubusercontent.com/u/2109913?v=4","gravatar_id":"","url":"https://api.github.com/users/opencog","html_url":"https://github.com/opencog","followers_url":"https://api.github.com/users/opencog/followers","following_url":"https://api.github.com/users/opencog/following{/other_user}","gists_url":"https://api.github.com/users/opencog/gists{/gist_id}","starred_url":"https://api.github.com/users/opencog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencog/subscriptions","organizations_url":"https://api.github.com/users/opencog/orgs","repos_url":"https://api.github.com/users/opencog/repos","events_url":"https://api.github.com/users/opencog/events{/privacy}","received_events_url":"https://api.github.com/users/opencog/received_events","type":"Organization","site_admin":false},"repo":{"id":34678084,"node_id":"MDEwOlJlcG9zaXRvcnkzNDY3ODA4NA==","name":"atomspace","full_name":"opencog/atomspace","private":false,"owner":{"login":"opencog","id":2109913,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIxMDk5MTM=","avatar_url":"https://avatars1.githubusercontent.com/u/2109913?v=4","gravatar_id":"","url":"https://api.github.com/users/opencog","html_url":"https://github.com/opencog","followers_url":"https://api.github.com/users/opencog/followers","following_url":"https://api.github.com/users/opencog/following{/other_user}","gists_url":"https://api.github.com/users/opencog/gists{/gist_id}","starred_url":"https://api.github.com/users/opencog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opencog/subscriptions","organizations_url":"https://api.github.com/users/opencog/orgs","repos_url":"https://api.github.com/users/opencog/repos","events_url":"https://api.github.com/users/opencog/events{/privacy}","received_events_url":"https://api.github.com/users/opencog/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/opencog/atomspace","description":"The OpenCog hypergraph database, query system and rule engine","fork":false,"url":"https://api.github.com/repos/opencog/atomspace","forks_url":"https://api.github.com/repos/opencog/atomspace/forks","keys_url":"https://api.github.com/repos/opencog/atomspace/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opencog/atomspace/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opencog/atomspace/teams","hooks_url":"https://api.github.com/repos/opencog/atomspace/hooks","issue_events_url":"https://api.github.com/repos/opencog/atomspace/issues/events{/number}","events_url":"https://api.github.com/repos/opencog/atomspace/events","assignees_url":"https://api.github.com/repos/opencog/atomspace/assignees{/user}","branches_url":"https://api.github.com/repos/opencog/atomspace/branches{/branch}","tags_url":"https://api.github.com/repos/opencog/atomspace/tags","blobs_url":"https://api.github.com/repos/opencog/atomspace/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opencog/atomspace/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opencog/atomspace/git/refs{/sha}","trees_url":"https://api.github.com/repos/opencog/atomspace/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opencog/atomspace/statuses/{sha}","languages_url":"https://api.github.com/repos/opencog/atomspace/languages","stargazers_url":"https://api.github.com/repos/opencog/atomspace/stargazers","contributors_url":"https://api.github.com/repos/opencog/atomspace/contributors","subscribers_url":"https://api.github.com/repos/opencog/atomspace/subscribers","subscription_url":"https://api.github.com/repos/opencog/atomspace/subscription","commits_url":"https://api.github.com/repos/opencog/atomspace/commits{/sha}","git_commits_url":"https://api.github.com/repos/opencog/atomspace/git/commits{/sha}","comments_url":"https://api.github.com/repos/opencog/atomspace/comments{/number}","issue_comment_url":"https://api.github.com/repos/opencog/atomspace/issues/comments{/number}","contents_url":"https://api.github.com/repos/opencog/atomspace/contents/{+path}","compare_url":"https://api.github.com/repos/opencog/atomspace/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opencog/atomspace/merges","archive_url":"https://api.github.com/repos/opencog/atomspace/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opencog/atomspace/downloads","issues_url":"https://api.github.com/repos/opencog/atomspace/issues{/number}","pulls_url":"https://api.github.com/repos/opencog/atomspace/pulls{/number}","milestones_url":"https://api.github.com/repos/opencog/atomspace/milestones{/number}","notifications_url":"https://api.github.com/repos/opencog/atomspace/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opencog/atomspace/labels{/name}","releases_url":"https://api.github.com/repos/opencog/atomspace/releases{/id}","deployments_url":"https://api.github.com/repos/opencog/atomspace/deployments","created_at":"2015-04-27T16:32:57Z","updated_at":"2018-12-22T19:08:17Z","pushed_at":"2018-12-22T19:08:15Z","git_url":"git://github.com/opencog/atomspace.git","ssh_url":"git@github.com:opencog/atomspace.git","clone_url":"https://github.com/opencog/atomspace.git","svn_url":"https://github.com/opencog/atomspace","homepage":"","size":152591,"stargazers_count":225,"watchers_count":225,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":141,"mirror_url":null,"archived":false,"open_issues_count":88,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":141,"open_issues":88,"watchers":225,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opencog/atomspace/pulls/1966"},"html":{"href":"https://github.com/opencog/atomspace/pull/1966"},"issue":{"href":"https://api.github.com/repos/opencog/atomspace/issues/1966"},"comments":{"href":"https://api.github.com/repos/opencog/atomspace/issues/1966/comments"},"review_comments":{"href":"https://api.github.com/repos/opencog/atomspace/pulls/1966/comments"},"review_comment":{"href":"https://api.github.com/repos/opencog/atomspace/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opencog/atomspace/pulls/1966/commits"},"statuses":{"href":"https://api.github.com/repos/opencog/atomspace/statuses/c532fc39db93d381af5b52b8c4b5ecb5be6e55e1"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ngeiswei"}}