{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/183518304","pull_request_review_id":114532321,"id":183518304,"diff_hunk":"@@ -53,6 +54,8 @@ type RequestScope struct {\n \tTyper           runtime.ObjectTyper\n \tUnsafeConvertor runtime.ObjectConvertor\n \n+\tOpenAPISpecGetter openapi.SpecGetter","path":"staging/src/k8s.io/apiserver/pkg/endpoints/handlers/rest.go","position":12,"original_position":12,"commit_id":"5863eee74c25b86f4957931e3108e01932460beb","original_commit_id":"5863eee74c25b86f4957931e3108e01932460beb","user":{"login":"deads2k","id":8225098,"avatar_url":"https://avatars0.githubusercontent.com/u/8225098?v=4","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false},"body":"> Merging (only apply)\r\n\r\nLooks specific to the feature branch.  I'm not seeing why we'd merge this piece into master.  This isn't a general improvement, it's a new piece of plumbing that you only need in the feature branch.  \r\n\r\n> Validation automation (any mutating request)\r\n\r\nI don't recognize this feature.  I don't think a feature we don't have is a reason for the change in master.\r\n\r\nIf you want to have a separate feature for it in master, that's certainly a piece we can break off and talk about adding.  It's much smaller than apply and I think most of the concern would be around compatibility and tightly bounding the information about openapi.\r\n","created_at":"2018-04-23T19:56:22Z","updated_at":"2018-04-23T19:56:22Z","html_url":"https://github.com/kubernetes/kubernetes/pull/62918#discussion_r183518304","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/62918","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/183518304"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/62918#discussion_r183518304"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/62918"}},"in_reply_to_id":183378273},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/62918","id":183162038,"html_url":"https://github.com/kubernetes/kubernetes/pull/62918","diff_url":"https://github.com/kubernetes/kubernetes/pull/62918.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/62918.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/62918","number":62918,"state":"open","locked":false,"title":"Expose openapi spec to API handlers","user":{"login":"jennybuckley","id":31416425,"avatar_url":"https://avatars2.githubusercontent.com/u/31416425?v=4","gravatar_id":"","url":"https://api.github.com/users/jennybuckley","html_url":"https://github.com/jennybuckley","followers_url":"https://api.github.com/users/jennybuckley/followers","following_url":"https://api.github.com/users/jennybuckley/following{/other_user}","gists_url":"https://api.github.com/users/jennybuckley/gists{/gist_id}","starred_url":"https://api.github.com/users/jennybuckley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jennybuckley/subscriptions","organizations_url":"https://api.github.com/users/jennybuckley/orgs","repos_url":"https://api.github.com/users/jennybuckley/repos","events_url":"https://api.github.com/users/jennybuckley/events{/privacy}","received_events_url":"https://api.github.com/users/jennybuckley/received_events","type":"User","site_admin":false},"body":"**What this PR does / why we need it**:\r\nGives read access to the root openapi spec to all the API handlers by OpenAPISpecGetter to RequestScope. The new Patch handler will need this to perform the type of merge needed for apply.\r\n\r\n```release-note\r\nNONE\r\n```\r\n\r\n/cc @lavalamp @apelisse @seans3 @mbohlool","created_at":"2018-04-20T20:24:17Z","updated_at":"2018-04-23T19:56:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0d5ba25be611f22ebf9778b5a5cb272125b0f022","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sttts","id":730123,"avatar_url":"https://avatars0.githubusercontent.com/u/730123?v=4","gravatar_id":"","url":"https://api.github.com/users/sttts","html_url":"https://github.com/sttts","followers_url":"https://api.github.com/users/sttts/followers","following_url":"https://api.github.com/users/sttts/following{/other_user}","gists_url":"https://api.github.com/users/sttts/gists{/gist_id}","starred_url":"https://api.github.com/users/sttts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sttts/subscriptions","organizations_url":"https://api.github.com/users/sttts/orgs","repos_url":"https://api.github.com/users/sttts/repos","events_url":"https://api.github.com/users/sttts/events{/privacy}","received_events_url":"https://api.github.com/users/sttts/received_events","type":"User","site_admin":false},{"login":"mbohlool","id":1613024,"avatar_url":"https://avatars3.githubusercontent.com/u/1613024?v=4","gravatar_id":"","url":"https://api.github.com/users/mbohlool","html_url":"https://github.com/mbohlool","followers_url":"https://api.github.com/users/mbohlool/followers","following_url":"https://api.github.com/users/mbohlool/following{/other_user}","gists_url":"https://api.github.com/users/mbohlool/gists{/gist_id}","starred_url":"https://api.github.com/users/mbohlool/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbohlool/subscriptions","organizations_url":"https://api.github.com/users/mbohlool/orgs","repos_url":"https://api.github.com/users/mbohlool/repos","events_url":"https://api.github.com/users/mbohlool/events{/privacy}","received_events_url":"https://api.github.com/users/mbohlool/received_events","type":"User","site_admin":false},{"login":"hzxuzhonghu","id":13374016,"avatar_url":"https://avatars3.githubusercontent.com/u/13374016?v=4","gravatar_id":"","url":"https://api.github.com/users/hzxuzhonghu","html_url":"https://github.com/hzxuzhonghu","followers_url":"https://api.github.com/users/hzxuzhonghu/followers","following_url":"https://api.github.com/users/hzxuzhonghu/following{/other_user}","gists_url":"https://api.github.com/users/hzxuzhonghu/gists{/gist_id}","starred_url":"https://api.github.com/users/hzxuzhonghu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hzxuzhonghu/subscriptions","organizations_url":"https://api.github.com/users/hzxuzhonghu/orgs","repos_url":"https://api.github.com/users/hzxuzhonghu/repos","events_url":"https://api.github.com/users/hzxuzhonghu/events{/privacy}","received_events_url":"https://api.github.com/users/hzxuzhonghu/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":349530249,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":253450978,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/62918/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/62918/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/62918/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/5863eee74c25b86f4957931e3108e01932460beb","head":{"label":"jennybuckley:expose-openapi-to-registry","ref":"expose-openapi-to-registry","sha":"5863eee74c25b86f4957931e3108e01932460beb","user":{"login":"jennybuckley","id":31416425,"avatar_url":"https://avatars2.githubusercontent.com/u/31416425?v=4","gravatar_id":"","url":"https://api.github.com/users/jennybuckley","html_url":"https://github.com/jennybuckley","followers_url":"https://api.github.com/users/jennybuckley/followers","following_url":"https://api.github.com/users/jennybuckley/following{/other_user}","gists_url":"https://api.github.com/users/jennybuckley/gists{/gist_id}","starred_url":"https://api.github.com/users/jennybuckley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jennybuckley/subscriptions","organizations_url":"https://api.github.com/users/jennybuckley/orgs","repos_url":"https://api.github.com/users/jennybuckley/repos","events_url":"https://api.github.com/users/jennybuckley/events{/privacy}","received_events_url":"https://api.github.com/users/jennybuckley/received_events","type":"User","site_admin":false},"repo":{"id":101671907,"name":"kubernetes","full_name":"jennybuckley/kubernetes","owner":{"login":"jennybuckley","id":31416425,"avatar_url":"https://avatars2.githubusercontent.com/u/31416425?v=4","gravatar_id":"","url":"https://api.github.com/users/jennybuckley","html_url":"https://github.com/jennybuckley","followers_url":"https://api.github.com/users/jennybuckley/followers","following_url":"https://api.github.com/users/jennybuckley/following{/other_user}","gists_url":"https://api.github.com/users/jennybuckley/gists{/gist_id}","starred_url":"https://api.github.com/users/jennybuckley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jennybuckley/subscriptions","organizations_url":"https://api.github.com/users/jennybuckley/orgs","repos_url":"https://api.github.com/users/jennybuckley/repos","events_url":"https://api.github.com/users/jennybuckley/events{/privacy}","received_events_url":"https://api.github.com/users/jennybuckley/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jennybuckley/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/jennybuckley/kubernetes","forks_url":"https://api.github.com/repos/jennybuckley/kubernetes/forks","keys_url":"https://api.github.com/repos/jennybuckley/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jennybuckley/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jennybuckley/kubernetes/teams","hooks_url":"https://api.github.com/repos/jennybuckley/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/jennybuckley/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/jennybuckley/kubernetes/events","assignees_url":"https://api.github.com/repos/jennybuckley/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/jennybuckley/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/jennybuckley/kubernetes/tags","blobs_url":"https://api.github.com/repos/jennybuckley/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jennybuckley/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jennybuckley/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/jennybuckley/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jennybuckley/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/jennybuckley/kubernetes/languages","stargazers_url":"https://api.github.com/repos/jennybuckley/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/jennybuckley/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/jennybuckley/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/jennybuckley/kubernetes/subscription","commits_url":"https://api.github.com/repos/jennybuckley/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/jennybuckley/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/jennybuckley/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/jennybuckley/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/jennybuckley/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/jennybuckley/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jennybuckley/kubernetes/merges","archive_url":"https://api.github.com/repos/jennybuckley/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jennybuckley/kubernetes/downloads","issues_url":"https://api.github.com/repos/jennybuckley/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/jennybuckley/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/jennybuckley/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/jennybuckley/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jennybuckley/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/jennybuckley/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/jennybuckley/kubernetes/deployments","created_at":"2017-08-28T18:02:24Z","updated_at":"2018-04-17T18:12:45Z","pushed_at":"2018-04-23T19:29:45Z","git_url":"git://github.com/jennybuckley/kubernetes.git","ssh_url":"git@github.com:jennybuckley/kubernetes.git","clone_url":"https://github.com/jennybuckley/kubernetes.git","svn_url":"https://github.com/jennybuckley/kubernetes","homepage":"http://kubernetes.io","size":551870,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:feature-serverside-apply","ref":"feature-serverside-apply","sha":"b398409bb5addbf04657f752f6f71735b830c6a9","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2018-04-23T19:37:57Z","pushed_at":"2018-04-23T19:53:31Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":772135,"stargazers_count":35435,"watchers_count":35435,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12536,"mirror_url":null,"archived":false,"open_issues_count":3444,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":12536,"open_issues":3444,"watchers":35435,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/62918"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/62918"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/62918"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/62918/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/62918/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/62918/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/5863eee74c25b86f4957931e3108e01932460beb"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"deads2k"}}