{"action":"opened","number":3464,"pull_request":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/3464","id":189801093,"html_url":"https://github.com/envoyproxy/envoy/pull/3464","diff_url":"https://github.com/envoyproxy/envoy/pull/3464.diff","patch_url":"https://github.com/envoyproxy/envoy/pull/3464.patch","issue_url":"https://api.github.com/repos/envoyproxy/envoy/issues/3464","number":3464,"state":"open","locked":false,"title":"util: replace all std::mutex and std::condition_variable with wrapped absl equivalents.","user":{"login":"jmarantz","id":1942589,"avatar_url":"https://avatars3.githubusercontent.com/u/1942589?v=4","gravatar_id":"","url":"https://api.github.com/users/jmarantz","html_url":"https://github.com/jmarantz","followers_url":"https://api.github.com/users/jmarantz/followers","following_url":"https://api.github.com/users/jmarantz/following{/other_user}","gists_url":"https://api.github.com/users/jmarantz/gists{/gist_id}","starred_url":"https://api.github.com/users/jmarantz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmarantz/subscriptions","organizations_url":"https://api.github.com/users/jmarantz/orgs","repos_url":"https://api.github.com/users/jmarantz/repos","events_url":"https://api.github.com/users/jmarantz/events{/privacy}","received_events_url":"https://api.github.com/users/jmarantz/received_events","type":"User","site_admin":false},"body":"*Description*:\r\n>Completely removes dependence on std::mutex and std::condition_variable from envoy test/ and source/.  This enables compile-time enforcement of thread-annotations throughout the codebase, though not all possible annotations have been added yet.\r\n\r\nFollow-up PRs will come to add annotations, and to enforce with check_format that std::mutex and std::condition_variable should not re-appear.\r\n\r\n*Risk Level*: Low \r\n*Testing*: //test/...\r\n*Docs Changes*: N/A\r\n*Release Notes*: N/A","created_at":"2018-05-22T21:44:06Z","updated_at":"2018-05-22T21:44:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/3464/commits","review_comments_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/3464/comments","review_comment_url":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/issues/3464/comments","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/c564511be110381467c34404df7e347b9bb28554","head":{"label":"jmarantz:test-mutex-conversions","ref":"test-mutex-conversions","sha":"c564511be110381467c34404df7e347b9bb28554","user":{"login":"jmarantz","id":1942589,"avatar_url":"https://avatars3.githubusercontent.com/u/1942589?v=4","gravatar_id":"","url":"https://api.github.com/users/jmarantz","html_url":"https://github.com/jmarantz","followers_url":"https://api.github.com/users/jmarantz/followers","following_url":"https://api.github.com/users/jmarantz/following{/other_user}","gists_url":"https://api.github.com/users/jmarantz/gists{/gist_id}","starred_url":"https://api.github.com/users/jmarantz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmarantz/subscriptions","organizations_url":"https://api.github.com/users/jmarantz/orgs","repos_url":"https://api.github.com/users/jmarantz/repos","events_url":"https://api.github.com/users/jmarantz/events{/privacy}","received_events_url":"https://api.github.com/users/jmarantz/received_events","type":"User","site_admin":false},"repo":{"id":109787330,"name":"envoy","full_name":"jmarantz/envoy","owner":{"login":"jmarantz","id":1942589,"avatar_url":"https://avatars3.githubusercontent.com/u/1942589?v=4","gravatar_id":"","url":"https://api.github.com/users/jmarantz","html_url":"https://github.com/jmarantz","followers_url":"https://api.github.com/users/jmarantz/followers","following_url":"https://api.github.com/users/jmarantz/following{/other_user}","gists_url":"https://api.github.com/users/jmarantz/gists{/gist_id}","starred_url":"https://api.github.com/users/jmarantz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmarantz/subscriptions","organizations_url":"https://api.github.com/users/jmarantz/orgs","repos_url":"https://api.github.com/users/jmarantz/repos","events_url":"https://api.github.com/users/jmarantz/events{/privacy}","received_events_url":"https://api.github.com/users/jmarantz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jmarantz/envoy","description":"C++ front/service proxy","fork":true,"url":"https://api.github.com/repos/jmarantz/envoy","forks_url":"https://api.github.com/repos/jmarantz/envoy/forks","keys_url":"https://api.github.com/repos/jmarantz/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jmarantz/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jmarantz/envoy/teams","hooks_url":"https://api.github.com/repos/jmarantz/envoy/hooks","issue_events_url":"https://api.github.com/repos/jmarantz/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/jmarantz/envoy/events","assignees_url":"https://api.github.com/repos/jmarantz/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/jmarantz/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/jmarantz/envoy/tags","blobs_url":"https://api.github.com/repos/jmarantz/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jmarantz/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jmarantz/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/jmarantz/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jmarantz/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/jmarantz/envoy/languages","stargazers_url":"https://api.github.com/repos/jmarantz/envoy/stargazers","contributors_url":"https://api.github.com/repos/jmarantz/envoy/contributors","subscribers_url":"https://api.github.com/repos/jmarantz/envoy/subscribers","subscription_url":"https://api.github.com/repos/jmarantz/envoy/subscription","commits_url":"https://api.github.com/repos/jmarantz/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/jmarantz/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/jmarantz/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/jmarantz/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/jmarantz/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/jmarantz/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jmarantz/envoy/merges","archive_url":"https://api.github.com/repos/jmarantz/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jmarantz/envoy/downloads","issues_url":"https://api.github.com/repos/jmarantz/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/jmarantz/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/jmarantz/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/jmarantz/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jmarantz/envoy/labels{/name}","releases_url":"https://api.github.com/repos/jmarantz/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/jmarantz/envoy/deployments","created_at":"2017-11-07T04:36:02Z","updated_at":"2018-05-22T20:02:22Z","pushed_at":"2018-05-22T21:40:31Z","git_url":"git://github.com/jmarantz/envoy.git","ssh_url":"git@github.com:jmarantz/envoy.git","clone_url":"https://github.com/jmarantz/envoy.git","svn_url":"https://github.com/jmarantz/envoy","homepage":"https://envoyproxy.github.io/","size":57375,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"envoyproxy:master","ref":"master","sha":"e06d2fb1a87af60c62fcc999d64538a07b7b436b","user":{"login":"envoyproxy","id":30125649,"avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"repo":{"id":65214191,"name":"envoy","full_name":"envoyproxy/envoy","owner":{"login":"envoyproxy","id":30125649,"avatar_url":"https://avatars1.githubusercontent.com/u/30125649?v=4","gravatar_id":"","url":"https://api.github.com/users/envoyproxy","html_url":"https://github.com/envoyproxy","followers_url":"https://api.github.com/users/envoyproxy/followers","following_url":"https://api.github.com/users/envoyproxy/following{/other_user}","gists_url":"https://api.github.com/users/envoyproxy/gists{/gist_id}","starred_url":"https://api.github.com/users/envoyproxy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/envoyproxy/subscriptions","organizations_url":"https://api.github.com/users/envoyproxy/orgs","repos_url":"https://api.github.com/users/envoyproxy/repos","events_url":"https://api.github.com/users/envoyproxy/events{/privacy}","received_events_url":"https://api.github.com/users/envoyproxy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/envoyproxy/envoy","description":"C++ front/service proxy","fork":false,"url":"https://api.github.com/repos/envoyproxy/envoy","forks_url":"https://api.github.com/repos/envoyproxy/envoy/forks","keys_url":"https://api.github.com/repos/envoyproxy/envoy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/envoyproxy/envoy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/envoyproxy/envoy/teams","hooks_url":"https://api.github.com/repos/envoyproxy/envoy/hooks","issue_events_url":"https://api.github.com/repos/envoyproxy/envoy/issues/events{/number}","events_url":"https://api.github.com/repos/envoyproxy/envoy/events","assignees_url":"https://api.github.com/repos/envoyproxy/envoy/assignees{/user}","branches_url":"https://api.github.com/repos/envoyproxy/envoy/branches{/branch}","tags_url":"https://api.github.com/repos/envoyproxy/envoy/tags","blobs_url":"https://api.github.com/repos/envoyproxy/envoy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/envoyproxy/envoy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/envoyproxy/envoy/git/refs{/sha}","trees_url":"https://api.github.com/repos/envoyproxy/envoy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/envoyproxy/envoy/statuses/{sha}","languages_url":"https://api.github.com/repos/envoyproxy/envoy/languages","stargazers_url":"https://api.github.com/repos/envoyproxy/envoy/stargazers","contributors_url":"https://api.github.com/repos/envoyproxy/envoy/contributors","subscribers_url":"https://api.github.com/repos/envoyproxy/envoy/subscribers","subscription_url":"https://api.github.com/repos/envoyproxy/envoy/subscription","commits_url":"https://api.github.com/repos/envoyproxy/envoy/commits{/sha}","git_commits_url":"https://api.github.com/repos/envoyproxy/envoy/git/commits{/sha}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/comments{/number}","issue_comment_url":"https://api.github.com/repos/envoyproxy/envoy/issues/comments{/number}","contents_url":"https://api.github.com/repos/envoyproxy/envoy/contents/{+path}","compare_url":"https://api.github.com/repos/envoyproxy/envoy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/envoyproxy/envoy/merges","archive_url":"https://api.github.com/repos/envoyproxy/envoy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/envoyproxy/envoy/downloads","issues_url":"https://api.github.com/repos/envoyproxy/envoy/issues{/number}","pulls_url":"https://api.github.com/repos/envoyproxy/envoy/pulls{/number}","milestones_url":"https://api.github.com/repos/envoyproxy/envoy/milestones{/number}","notifications_url":"https://api.github.com/repos/envoyproxy/envoy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/envoyproxy/envoy/labels{/name}","releases_url":"https://api.github.com/repos/envoyproxy/envoy/releases{/id}","deployments_url":"https://api.github.com/repos/envoyproxy/envoy/deployments","created_at":"2016-08-08T15:07:24Z","updated_at":"2018-05-22T21:32:26Z","pushed_at":"2018-05-22T21:32:21Z","git_url":"git://github.com/envoyproxy/envoy.git","ssh_url":"git@github.com:envoyproxy/envoy.git","clone_url":"https://github.com/envoyproxy/envoy.git","svn_url":"https://github.com/envoyproxy/envoy","homepage":"https://www.envoyproxy.io","size":15722,"stargazers_count":4983,"watchers_count":4983,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":636,"mirror_url":null,"archived":false,"open_issues_count":310,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":636,"open_issues":310,"watchers":4983,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/3464"},"html":{"href":"https://github.com/envoyproxy/envoy/pull/3464"},"issue":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/3464"},"comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/issues/3464/comments"},"review_comments":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/3464/comments"},"review_comment":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/envoyproxy/envoy/pulls/3464/commits"},"statuses":{"href":"https://api.github.com/repos/envoyproxy/envoy/statuses/c564511be110381467c34404df7e347b9bb28554"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":4,"additions":162,"deletions":137,"changed_files":14}}
{"actor":{"display_login":"jmarantz"}}