{"action":"created","comment":{"url":"https://api.github.com/repos/ethereumjs/ethrpc/pulls/comments/186342141","pull_request_review_id":117900060,"id":186342141,"diff_hunk":"@@ -6,17 +6,17 @@\n   \"license\": \"MIT\",\n   \"main\": \"src/index.js\",\n   \"scripts\": {\n-    \"test\": \"mocha test/*.js test/block-management test/raw-transactions test/reducers test/transport test/utils\",\n-    \"lint\": \"eslint src test/*.js test/block-management test/raw-transactions test/reducers test/transport test/utils\",\n+    \"test\": \"mocha test\",\n+    \"lint\": \"eslint src test\",\n     \"coverage\": \"istanbul cover --include-all-sources --root ./src ./node_modules/mocha/bin/_mocha test/\",\n     \"link\": \"npm link speedomatic ethereumjs-blockstream\",\n     \"genversion\": \"genversion src/version.js\",\n     \"build\": \"mkdirp dist && browserify ./exports.js -o ./dist/ethrpc.js && uglifyjs ./dist/ethrpc.js -o ./dist/ethrpc.min.js\",\n-    \"build:tests\": \"browserify ./test/reducers/*.js -o ./test/browser/bundle.js\",\n     \"postinstall\": \"postinstall-build --only-as-dependency dist\",\n     \"prepublishOnly\": \"postinstall-build dist\",\n     \"preversion\": \"npm test\",\n-    \"version\": \"npm run genversion && git add src/version.js\"\n+    \"version\": \"npm run genversion && git add src/version.js\",\n+    \"testwhy\": \"wtfnode ./node_modules/mocha/bin/_mocha --timeout 5000 ./test/stub-node-only.js\"","path":"package.json","position":18,"original_position":18,"commit_id":"c60aff4dbb5af9d508d163c71b533e49016fc188","original_commit_id":"c60aff4dbb5af9d508d163c71b533e49016fc188","user":{"login":"MicahZoltu","id":886059,"avatar_url":"https://avatars2.githubusercontent.com/u/886059?v=4","gravatar_id":"","url":"https://api.github.com/users/MicahZoltu","html_url":"https://github.com/MicahZoltu","followers_url":"https://api.github.com/users/MicahZoltu/followers","following_url":"https://api.github.com/users/MicahZoltu/following{/other_user}","gists_url":"https://api.github.com/users/MicahZoltu/gists{/gist_id}","starred_url":"https://api.github.com/users/MicahZoltu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MicahZoltu/subscriptions","organizations_url":"https://api.github.com/users/MicahZoltu/orgs","repos_url":"https://api.github.com/users/MicahZoltu/repos","events_url":"https://api.github.com/users/MicahZoltu/events{/privacy}","received_events_url":"https://api.github.com/users/MicahZoltu/received_events","type":"User","site_admin":false},"body":"This could use some documentation (a comment somewhere indicating what this does, why it exists, etc.)","created_at":"2018-05-07T07:06:48Z","updated_at":"2018-05-07T07:06:48Z","html_url":"https://github.com/ethereumjs/ethrpc/pull/67#discussion_r186342141","pull_request_url":"https://api.github.com/repos/ethereumjs/ethrpc/pulls/67","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ethereumjs/ethrpc/pulls/comments/186342141"},"html":{"href":"https://github.com/ethereumjs/ethrpc/pull/67#discussion_r186342141"},"pull_request":{"href":"https://api.github.com/repos/ethereumjs/ethrpc/pulls/67"}}},"pull_request":{"url":"https://api.github.com/repos/ethereumjs/ethrpc/pulls/67","id":186245683,"html_url":"https://github.com/ethereumjs/ethrpc/pull/67","diff_url":"https://github.com/ethereumjs/ethrpc/pull/67.diff","patch_url":"https://github.com/ethereumjs/ethrpc/pull/67.patch","issue_url":"https://api.github.com/repos/ethereumjs/ethrpc/issues/67","number":67,"state":"open","locked":false,"title":"Tinybike/ch9853/new blocks are being processed twice","user":{"login":"tinybike","id":2637020,"avatar_url":"https://avatars2.githubusercontent.com/u/2637020?v=4","gravatar_id":"","url":"https://api.github.com/users/tinybike","html_url":"https://github.com/tinybike","followers_url":"https://api.github.com/users/tinybike/followers","following_url":"https://api.github.com/users/tinybike/following{/other_user}","gists_url":"https://api.github.com/users/tinybike/gists{/gist_id}","starred_url":"https://api.github.com/users/tinybike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tinybike/subscriptions","organizations_url":"https://api.github.com/users/tinybike/orgs","repos_url":"https://api.github.com/users/tinybike/repos","events_url":"https://api.github.com/users/tinybike/events{/privacy}","received_events_url":"https://api.github.com/users/tinybike/received_events","type":"User","site_admin":false},"body":"Resolves [ch9853](https://app.clubhouse.io/augur/story/9853/new-blocks-are-being-processed-twice).\r\n\r\nI couldn't figure out what was causing the race condition described in 9853, due largely to the complexity of ethrpc's old block-management module.  I ended up just reimplementing the block-management module, and AFAICT the race condition(s) are no longer present.  @epheph please test-drive this PR and double-check that all's in good working order, since quite a few lines of code were changed here...","created_at":"2018-05-07T03:05:22Z","updated_at":"2018-05-07T07:06:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e83feb9e93e1c2b8208b93843255a32cd447167b","assignee":{"login":"epheph","id":361654,"avatar_url":"https://avatars1.githubusercontent.com/u/361654?v=4","gravatar_id":"","url":"https://api.github.com/users/epheph","html_url":"https://github.com/epheph","followers_url":"https://api.github.com/users/epheph/followers","following_url":"https://api.github.com/users/epheph/following{/other_user}","gists_url":"https://api.github.com/users/epheph/gists{/gist_id}","starred_url":"https://api.github.com/users/epheph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/epheph/subscriptions","organizations_url":"https://api.github.com/users/epheph/orgs","repos_url":"https://api.github.com/users/epheph/repos","events_url":"https://api.github.com/users/epheph/events{/privacy}","received_events_url":"https://api.github.com/users/epheph/received_events","type":"User","site_admin":false},"assignees":[{"login":"epheph","id":361654,"avatar_url":"https://avatars1.githubusercontent.com/u/361654?v=4","gravatar_id":"","url":"https://api.github.com/users/epheph","html_url":"https://github.com/epheph","followers_url":"https://api.github.com/users/epheph/followers","following_url":"https://api.github.com/users/epheph/following{/other_user}","gists_url":"https://api.github.com/users/epheph/gists{/gist_id}","starred_url":"https://api.github.com/users/epheph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/epheph/subscriptions","organizations_url":"https://api.github.com/users/epheph/orgs","repos_url":"https://api.github.com/users/epheph/repos","events_url":"https://api.github.com/users/epheph/events{/privacy}","received_events_url":"https://api.github.com/users/epheph/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"epheph","id":361654,"avatar_url":"https://avatars1.githubusercontent.com/u/361654?v=4","gravatar_id":"","url":"https://api.github.com/users/epheph","html_url":"https://github.com/epheph","followers_url":"https://api.github.com/users/epheph/followers","following_url":"https://api.github.com/users/epheph/following{/other_user}","gists_url":"https://api.github.com/users/epheph/gists{/gist_id}","starred_url":"https://api.github.com/users/epheph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/epheph/subscriptions","organizations_url":"https://api.github.com/users/epheph/orgs","repos_url":"https://api.github.com/users/epheph/repos","events_url":"https://api.github.com/users/epheph/events{/privacy}","received_events_url":"https://api.github.com/users/epheph/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ethereumjs/ethrpc/pulls/67/commits","review_comments_url":"https://api.github.com/repos/ethereumjs/ethrpc/pulls/67/comments","review_comment_url":"https://api.github.com/repos/ethereumjs/ethrpc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereumjs/ethrpc/issues/67/comments","statuses_url":"https://api.github.com/repos/ethereumjs/ethrpc/statuses/c60aff4dbb5af9d508d163c71b533e49016fc188","head":{"label":"ethereumjs:tinybike/ch9853/new-blocks-are-being-processed-twice","ref":"tinybike/ch9853/new-blocks-are-being-processed-twice","sha":"c60aff4dbb5af9d508d163c71b533e49016fc188","user":{"login":"ethereumjs","id":16297473,"avatar_url":"https://avatars0.githubusercontent.com/u/16297473?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereumjs","html_url":"https://github.com/ethereumjs","followers_url":"https://api.github.com/users/ethereumjs/followers","following_url":"https://api.github.com/users/ethereumjs/following{/other_user}","gists_url":"https://api.github.com/users/ethereumjs/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereumjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereumjs/subscriptions","organizations_url":"https://api.github.com/users/ethereumjs/orgs","repos_url":"https://api.github.com/users/ethereumjs/repos","events_url":"https://api.github.com/users/ethereumjs/events{/privacy}","received_events_url":"https://api.github.com/users/ethereumjs/received_events","type":"Organization","site_admin":false},"repo":{"id":41285236,"name":"ethrpc","full_name":"ethereumjs/ethrpc","owner":{"login":"ethereumjs","id":16297473,"avatar_url":"https://avatars0.githubusercontent.com/u/16297473?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereumjs","html_url":"https://github.com/ethereumjs","followers_url":"https://api.github.com/users/ethereumjs/followers","following_url":"https://api.github.com/users/ethereumjs/following{/other_user}","gists_url":"https://api.github.com/users/ethereumjs/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereumjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereumjs/subscriptions","organizations_url":"https://api.github.com/users/ethereumjs/orgs","repos_url":"https://api.github.com/users/ethereumjs/repos","events_url":"https://api.github.com/users/ethereumjs/events{/privacy}","received_events_url":"https://api.github.com/users/ethereumjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereumjs/ethrpc","description":"Maximal RPC wrapper","fork":false,"url":"https://api.github.com/repos/ethereumjs/ethrpc","forks_url":"https://api.github.com/repos/ethereumjs/ethrpc/forks","keys_url":"https://api.github.com/repos/ethereumjs/ethrpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereumjs/ethrpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereumjs/ethrpc/teams","hooks_url":"https://api.github.com/repos/ethereumjs/ethrpc/hooks","issue_events_url":"https://api.github.com/repos/ethereumjs/ethrpc/issues/events{/number}","events_url":"https://api.github.com/repos/ethereumjs/ethrpc/events","assignees_url":"https://api.github.com/repos/ethereumjs/ethrpc/assignees{/user}","branches_url":"https://api.github.com/repos/ethereumjs/ethrpc/branches{/branch}","tags_url":"https://api.github.com/repos/ethereumjs/ethrpc/tags","blobs_url":"https://api.github.com/repos/ethereumjs/ethrpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereumjs/ethrpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereumjs/ethrpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereumjs/ethrpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereumjs/ethrpc/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereumjs/ethrpc/languages","stargazers_url":"https://api.github.com/repos/ethereumjs/ethrpc/stargazers","contributors_url":"https://api.github.com/repos/ethereumjs/ethrpc/contributors","subscribers_url":"https://api.github.com/repos/ethereumjs/ethrpc/subscribers","subscription_url":"https://api.github.com/repos/ethereumjs/ethrpc/subscription","commits_url":"https://api.github.com/repos/ethereumjs/ethrpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereumjs/ethrpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereumjs/ethrpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereumjs/ethrpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereumjs/ethrpc/contents/{+path}","compare_url":"https://api.github.com/repos/ethereumjs/ethrpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereumjs/ethrpc/merges","archive_url":"https://api.github.com/repos/ethereumjs/ethrpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereumjs/ethrpc/downloads","issues_url":"https://api.github.com/repos/ethereumjs/ethrpc/issues{/number}","pulls_url":"https://api.github.com/repos/ethereumjs/ethrpc/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereumjs/ethrpc/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereumjs/ethrpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereumjs/ethrpc/labels{/name}","releases_url":"https://api.github.com/repos/ethereumjs/ethrpc/releases{/id}","deployments_url":"https://api.github.com/repos/ethereumjs/ethrpc/deployments","created_at":"2015-08-24T06:04:19Z","updated_at":"2018-05-05T14:11:07Z","pushed_at":"2018-05-07T03:05:23Z","git_url":"git://github.com/ethereumjs/ethrpc.git","ssh_url":"git@github.com:ethereumjs/ethrpc.git","clone_url":"https://github.com/ethereumjs/ethrpc.git","svn_url":"https://github.com/ethereumjs/ethrpc","homepage":"","size":9196,"stargazers_count":84,"watchers_count":84,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":23,"open_issues":2,"watchers":84,"default_branch":"master"}},"base":{"label":"ethereumjs:master","ref":"master","sha":"2a8f97fbd9cbb953e17509ca79bb2ce39146fc32","user":{"login":"ethereumjs","id":16297473,"avatar_url":"https://avatars0.githubusercontent.com/u/16297473?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereumjs","html_url":"https://github.com/ethereumjs","followers_url":"https://api.github.com/users/ethereumjs/followers","following_url":"https://api.github.com/users/ethereumjs/following{/other_user}","gists_url":"https://api.github.com/users/ethereumjs/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereumjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereumjs/subscriptions","organizations_url":"https://api.github.com/users/ethereumjs/orgs","repos_url":"https://api.github.com/users/ethereumjs/repos","events_url":"https://api.github.com/users/ethereumjs/events{/privacy}","received_events_url":"https://api.github.com/users/ethereumjs/received_events","type":"Organization","site_admin":false},"repo":{"id":41285236,"name":"ethrpc","full_name":"ethereumjs/ethrpc","owner":{"login":"ethereumjs","id":16297473,"avatar_url":"https://avatars0.githubusercontent.com/u/16297473?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereumjs","html_url":"https://github.com/ethereumjs","followers_url":"https://api.github.com/users/ethereumjs/followers","following_url":"https://api.github.com/users/ethereumjs/following{/other_user}","gists_url":"https://api.github.com/users/ethereumjs/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereumjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereumjs/subscriptions","organizations_url":"https://api.github.com/users/ethereumjs/orgs","repos_url":"https://api.github.com/users/ethereumjs/repos","events_url":"https://api.github.com/users/ethereumjs/events{/privacy}","received_events_url":"https://api.github.com/users/ethereumjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereumjs/ethrpc","description":"Maximal RPC wrapper","fork":false,"url":"https://api.github.com/repos/ethereumjs/ethrpc","forks_url":"https://api.github.com/repos/ethereumjs/ethrpc/forks","keys_url":"https://api.github.com/repos/ethereumjs/ethrpc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereumjs/ethrpc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereumjs/ethrpc/teams","hooks_url":"https://api.github.com/repos/ethereumjs/ethrpc/hooks","issue_events_url":"https://api.github.com/repos/ethereumjs/ethrpc/issues/events{/number}","events_url":"https://api.github.com/repos/ethereumjs/ethrpc/events","assignees_url":"https://api.github.com/repos/ethereumjs/ethrpc/assignees{/user}","branches_url":"https://api.github.com/repos/ethereumjs/ethrpc/branches{/branch}","tags_url":"https://api.github.com/repos/ethereumjs/ethrpc/tags","blobs_url":"https://api.github.com/repos/ethereumjs/ethrpc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereumjs/ethrpc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereumjs/ethrpc/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereumjs/ethrpc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereumjs/ethrpc/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereumjs/ethrpc/languages","stargazers_url":"https://api.github.com/repos/ethereumjs/ethrpc/stargazers","contributors_url":"https://api.github.com/repos/ethereumjs/ethrpc/contributors","subscribers_url":"https://api.github.com/repos/ethereumjs/ethrpc/subscribers","subscription_url":"https://api.github.com/repos/ethereumjs/ethrpc/subscription","commits_url":"https://api.github.com/repos/ethereumjs/ethrpc/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereumjs/ethrpc/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereumjs/ethrpc/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereumjs/ethrpc/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereumjs/ethrpc/contents/{+path}","compare_url":"https://api.github.com/repos/ethereumjs/ethrpc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereumjs/ethrpc/merges","archive_url":"https://api.github.com/repos/ethereumjs/ethrpc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereumjs/ethrpc/downloads","issues_url":"https://api.github.com/repos/ethereumjs/ethrpc/issues{/number}","pulls_url":"https://api.github.com/repos/ethereumjs/ethrpc/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereumjs/ethrpc/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereumjs/ethrpc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereumjs/ethrpc/labels{/name}","releases_url":"https://api.github.com/repos/ethereumjs/ethrpc/releases{/id}","deployments_url":"https://api.github.com/repos/ethereumjs/ethrpc/deployments","created_at":"2015-08-24T06:04:19Z","updated_at":"2018-05-05T14:11:07Z","pushed_at":"2018-05-07T03:05:23Z","git_url":"git://github.com/ethereumjs/ethrpc.git","ssh_url":"git@github.com:ethereumjs/ethrpc.git","clone_url":"https://github.com/ethereumjs/ethrpc.git","svn_url":"https://github.com/ethereumjs/ethrpc","homepage":"","size":9196,"stargazers_count":84,"watchers_count":84,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":23,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":23,"open_issues":2,"watchers":84,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereumjs/ethrpc/pulls/67"},"html":{"href":"https://github.com/ethereumjs/ethrpc/pull/67"},"issue":{"href":"https://api.github.com/repos/ethereumjs/ethrpc/issues/67"},"comments":{"href":"https://api.github.com/repos/ethereumjs/ethrpc/issues/67/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereumjs/ethrpc/pulls/67/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereumjs/ethrpc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereumjs/ethrpc/pulls/67/commits"},"statuses":{"href":"https://api.github.com/repos/ethereumjs/ethrpc/statuses/c60aff4dbb5af9d508d163c71b533e49016fc188"}},"author_association":"OWNER"}}
{"actor":{"display_login":"MicahZoltu"}}