{"action":"created","comment":{"url":"https://api.github.com/repos/trufflesuite/ganache/pulls/comments/199596207","pull_request_review_id":133746504,"id":199596207,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5OTU5NjIwNw==","diff_hunk":"@@ -1,14 +1,10 @@\n-import { ipcRenderer } from 'electron'\n-\n-import * as Web3 from '../Actions/Web3'\n import * as Core from '../Actions/Core'\n-import * as Accounts from '../Actions/Accounts'\n-import * as Logs from '../Actions/Logs'\n-import * as Config from '../Actions/Config'\n-\n-import * as ErrorHandler from './ErrorHandler'\n \n import { initAutoUpdates } from '../Init/Renderer/AutoUpdate'\n+import { initCore } from '../Init/Renderer/Core'","path":"src/Kernel/ready.js","position":null,"original_position":12,"commit_id":"e0b52a0dbbb8bfcdae82b062580890ad1c1a194a","original_commit_id":"e72d98193cbf26a2529cc24feb4e0129bd9f26ad","user":{"login":"benjamincburns","id":803016,"node_id":"MDQ6VXNlcjgwMzAxNg==","avatar_url":"https://avatars1.githubusercontent.com/u/803016?v=4","gravatar_id":"","url":"https://api.github.com/users/benjamincburns","html_url":"https://github.com/benjamincburns","followers_url":"https://api.github.com/users/benjamincburns/followers","following_url":"https://api.github.com/users/benjamincburns/following{/other_user}","gists_url":"https://api.github.com/users/benjamincburns/gists{/gist_id}","starred_url":"https://api.github.com/users/benjamincburns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjamincburns/subscriptions","organizations_url":"https://api.github.com/users/benjamincburns/orgs","repos_url":"https://api.github.com/users/benjamincburns/repos","events_url":"https://api.github.com/users/benjamincburns/events{/privacy}","received_events_url":"https://api.github.com/users/benjamincburns/received_events","type":"User","site_admin":false},"body":"Since `ready.js` is the renderer initialization entrypoint (unless I'm mistaken) perhaps it should be moved to `src/Init/Renderer/index.js`?\r\n\r\nIdeally the `Kernel` directory wouldn't have continued to exist after this commit.","created_at":"2018-07-02T19:20:11Z","updated_at":"2018-07-02T19:21:44Z","html_url":"https://github.com/trufflesuite/ganache/pull/712#discussion_r199596207","pull_request_url":"https://api.github.com/repos/trufflesuite/ganache/pulls/712","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/trufflesuite/ganache/pulls/comments/199596207"},"html":{"href":"https://github.com/trufflesuite/ganache/pull/712#discussion_r199596207"},"pull_request":{"href":"https://api.github.com/repos/trufflesuite/ganache/pulls/712"}}},"pull_request":{"url":"https://api.github.com/repos/trufflesuite/ganache/pulls/712","id":193478016,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNDc4MDE2","html_url":"https://github.com/trufflesuite/ganache/pull/712","diff_url":"https://github.com/trufflesuite/ganache/pull/712.diff","patch_url":"https://github.com/trufflesuite/ganache/pull/712.patch","issue_url":"https://api.github.com/repos/trufflesuite/ganache/issues/712","number":712,"state":"open","locked":false,"title":"Handle Startup Errors","user":{"login":"seesemichaelj","id":549323,"node_id":"MDQ6VXNlcjU0OTMyMw==","avatar_url":"https://avatars2.githubusercontent.com/u/549323?v=4","gravatar_id":"","url":"https://api.github.com/users/seesemichaelj","html_url":"https://github.com/seesemichaelj","followers_url":"https://api.github.com/users/seesemichaelj/followers","following_url":"https://api.github.com/users/seesemichaelj/following{/other_user}","gists_url":"https://api.github.com/users/seesemichaelj/gists{/gist_id}","starred_url":"https://api.github.com/users/seesemichaelj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seesemichaelj/subscriptions","organizations_url":"https://api.github.com/users/seesemichaelj/orgs","repos_url":"https://api.github.com/users/seesemichaelj/repos","events_url":"https://api.github.com/users/seesemichaelj/events{/privacy}","received_events_url":"https://api.github.com/users/seesemichaelj/received_events","type":"User","site_admin":false},"body":"This PR fixes #627, fixes #665, fixes #666, and fixes #710. Known system errors will now go directly to the settings page, prompting the user to fix the issue on the appropriate setting.\r\n\r\nThis PR also implements some fixes to prevent the issues that caused #665 and #666:\r\n- The `RELAUNCH` button on the system error modal dialog would keep a lingering chain process, causing the port to stay bound, causing #665 \r\n- The `Hostname` field was a textbox, allowing arbitrary input. This field can only be IP addresses of the network interfaces. This PR changes this field to a dropdown of  those IP addresses, preventing #666","created_at":"2018-06-08T00:02:36Z","updated_at":"2018-07-02T19:21:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3361f0962f211719d0ef5f8016bedccf9f63620a","assignee":{"login":"seesemichaelj","id":549323,"node_id":"MDQ6VXNlcjU0OTMyMw==","avatar_url":"https://avatars2.githubusercontent.com/u/549323?v=4","gravatar_id":"","url":"https://api.github.com/users/seesemichaelj","html_url":"https://github.com/seesemichaelj","followers_url":"https://api.github.com/users/seesemichaelj/followers","following_url":"https://api.github.com/users/seesemichaelj/following{/other_user}","gists_url":"https://api.github.com/users/seesemichaelj/gists{/gist_id}","starred_url":"https://api.github.com/users/seesemichaelj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seesemichaelj/subscriptions","organizations_url":"https://api.github.com/users/seesemichaelj/orgs","repos_url":"https://api.github.com/users/seesemichaelj/repos","events_url":"https://api.github.com/users/seesemichaelj/events{/privacy}","received_events_url":"https://api.github.com/users/seesemichaelj/received_events","type":"User","site_admin":false},"assignees":[{"login":"seesemichaelj","id":549323,"node_id":"MDQ6VXNlcjU0OTMyMw==","avatar_url":"https://avatars2.githubusercontent.com/u/549323?v=4","gravatar_id":"","url":"https://api.github.com/users/seesemichaelj","html_url":"https://github.com/seesemichaelj","followers_url":"https://api.github.com/users/seesemichaelj/followers","following_url":"https://api.github.com/users/seesemichaelj/following{/other_user}","gists_url":"https://api.github.com/users/seesemichaelj/gists{/gist_id}","starred_url":"https://api.github.com/users/seesemichaelj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/seesemichaelj/subscriptions","organizations_url":"https://api.github.com/users/seesemichaelj/orgs","repos_url":"https://api.github.com/users/seesemichaelj/repos","events_url":"https://api.github.com/users/seesemichaelj/events{/privacy}","received_events_url":"https://api.github.com/users/seesemichaelj/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/trufflesuite/ganache/pulls/712/commits","review_comments_url":"https://api.github.com/repos/trufflesuite/ganache/pulls/712/comments","review_comment_url":"https://api.github.com/repos/trufflesuite/ganache/pulls/comments{/number}","comments_url":"https://api.github.com/repos/trufflesuite/ganache/issues/712/comments","statuses_url":"https://api.github.com/repos/trufflesuite/ganache/statuses/e0b52a0dbbb8bfcdae82b062580890ad1c1a194a","head":{"label":"trufflesuite:handle-startup-errors-correctly","ref":"handle-startup-errors-correctly","sha":"e0b52a0dbbb8bfcdae82b062580890ad1c1a194a","user":{"login":"trufflesuite","id":22205159,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMjA1MTU5","avatar_url":"https://avatars1.githubusercontent.com/u/22205159?v=4","gravatar_id":"","url":"https://api.github.com/users/trufflesuite","html_url":"https://github.com/trufflesuite","followers_url":"https://api.github.com/users/trufflesuite/followers","following_url":"https://api.github.com/users/trufflesuite/following{/other_user}","gists_url":"https://api.github.com/users/trufflesuite/gists{/gist_id}","starred_url":"https://api.github.com/users/trufflesuite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trufflesuite/subscriptions","organizations_url":"https://api.github.com/users/trufflesuite/orgs","repos_url":"https://api.github.com/users/trufflesuite/repos","events_url":"https://api.github.com/users/trufflesuite/events{/privacy}","received_events_url":"https://api.github.com/users/trufflesuite/received_events","type":"Organization","site_admin":false},"repo":{"id":79269625,"node_id":"MDEwOlJlcG9zaXRvcnk3OTI2OTYyNQ==","name":"ganache","full_name":"trufflesuite/ganache","owner":{"login":"trufflesuite","id":22205159,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMjA1MTU5","avatar_url":"https://avatars1.githubusercontent.com/u/22205159?v=4","gravatar_id":"","url":"https://api.github.com/users/trufflesuite","html_url":"https://github.com/trufflesuite","followers_url":"https://api.github.com/users/trufflesuite/followers","following_url":"https://api.github.com/users/trufflesuite/following{/other_user}","gists_url":"https://api.github.com/users/trufflesuite/gists{/gist_id}","starred_url":"https://api.github.com/users/trufflesuite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trufflesuite/subscriptions","organizations_url":"https://api.github.com/users/trufflesuite/orgs","repos_url":"https://api.github.com/users/trufflesuite/repos","events_url":"https://api.github.com/users/trufflesuite/events{/privacy}","received_events_url":"https://api.github.com/users/trufflesuite/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/trufflesuite/ganache","description":"Personal blockchain for Ethereum development","fork":false,"url":"https://api.github.com/repos/trufflesuite/ganache","forks_url":"https://api.github.com/repos/trufflesuite/ganache/forks","keys_url":"https://api.github.com/repos/trufflesuite/ganache/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trufflesuite/ganache/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trufflesuite/ganache/teams","hooks_url":"https://api.github.com/repos/trufflesuite/ganache/hooks","issue_events_url":"https://api.github.com/repos/trufflesuite/ganache/issues/events{/number}","events_url":"https://api.github.com/repos/trufflesuite/ganache/events","assignees_url":"https://api.github.com/repos/trufflesuite/ganache/assignees{/user}","branches_url":"https://api.github.com/repos/trufflesuite/ganache/branches{/branch}","tags_url":"https://api.github.com/repos/trufflesuite/ganache/tags","blobs_url":"https://api.github.com/repos/trufflesuite/ganache/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trufflesuite/ganache/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trufflesuite/ganache/git/refs{/sha}","trees_url":"https://api.github.com/repos/trufflesuite/ganache/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trufflesuite/ganache/statuses/{sha}","languages_url":"https://api.github.com/repos/trufflesuite/ganache/languages","stargazers_url":"https://api.github.com/repos/trufflesuite/ganache/stargazers","contributors_url":"https://api.github.com/repos/trufflesuite/ganache/contributors","subscribers_url":"https://api.github.com/repos/trufflesuite/ganache/subscribers","subscription_url":"https://api.github.com/repos/trufflesuite/ganache/subscription","commits_url":"https://api.github.com/repos/trufflesuite/ganache/commits{/sha}","git_commits_url":"https://api.github.com/repos/trufflesuite/ganache/git/commits{/sha}","comments_url":"https://api.github.com/repos/trufflesuite/ganache/comments{/number}","issue_comment_url":"https://api.github.com/repos/trufflesuite/ganache/issues/comments{/number}","contents_url":"https://api.github.com/repos/trufflesuite/ganache/contents/{+path}","compare_url":"https://api.github.com/repos/trufflesuite/ganache/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trufflesuite/ganache/merges","archive_url":"https://api.github.com/repos/trufflesuite/ganache/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trufflesuite/ganache/downloads","issues_url":"https://api.github.com/repos/trufflesuite/ganache/issues{/number}","pulls_url":"https://api.github.com/repos/trufflesuite/ganache/pulls{/number}","milestones_url":"https://api.github.com/repos/trufflesuite/ganache/milestones{/number}","notifications_url":"https://api.github.com/repos/trufflesuite/ganache/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trufflesuite/ganache/labels{/name}","releases_url":"https://api.github.com/repos/trufflesuite/ganache/releases{/id}","deployments_url":"https://api.github.com/repos/trufflesuite/ganache/deployments","created_at":"2017-01-17T20:39:11Z","updated_at":"2018-07-01T19:49:50Z","pushed_at":"2018-07-02T19:13:14Z","git_url":"git://github.com/trufflesuite/ganache.git","ssh_url":"git@github.com:trufflesuite/ganache.git","clone_url":"https://github.com/trufflesuite/ganache.git","svn_url":"https://github.com/trufflesuite/ganache","homepage":"http://truffleframework.com/ganache","size":15879,"stargazers_count":979,"watchers_count":979,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":150,"mirror_url":null,"archived":false,"open_issues_count":103,"license":null,"forks":150,"open_issues":103,"watchers":979,"default_branch":"develop"}},"base":{"label":"trufflesuite:develop","ref":"develop","sha":"23dd5ca309f589544242d7ebd00479f595aa0d7b","user":{"login":"trufflesuite","id":22205159,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMjA1MTU5","avatar_url":"https://avatars1.githubusercontent.com/u/22205159?v=4","gravatar_id":"","url":"https://api.github.com/users/trufflesuite","html_url":"https://github.com/trufflesuite","followers_url":"https://api.github.com/users/trufflesuite/followers","following_url":"https://api.github.com/users/trufflesuite/following{/other_user}","gists_url":"https://api.github.com/users/trufflesuite/gists{/gist_id}","starred_url":"https://api.github.com/users/trufflesuite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trufflesuite/subscriptions","organizations_url":"https://api.github.com/users/trufflesuite/orgs","repos_url":"https://api.github.com/users/trufflesuite/repos","events_url":"https://api.github.com/users/trufflesuite/events{/privacy}","received_events_url":"https://api.github.com/users/trufflesuite/received_events","type":"Organization","site_admin":false},"repo":{"id":79269625,"node_id":"MDEwOlJlcG9zaXRvcnk3OTI2OTYyNQ==","name":"ganache","full_name":"trufflesuite/ganache","owner":{"login":"trufflesuite","id":22205159,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMjA1MTU5","avatar_url":"https://avatars1.githubusercontent.com/u/22205159?v=4","gravatar_id":"","url":"https://api.github.com/users/trufflesuite","html_url":"https://github.com/trufflesuite","followers_url":"https://api.github.com/users/trufflesuite/followers","following_url":"https://api.github.com/users/trufflesuite/following{/other_user}","gists_url":"https://api.github.com/users/trufflesuite/gists{/gist_id}","starred_url":"https://api.github.com/users/trufflesuite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trufflesuite/subscriptions","organizations_url":"https://api.github.com/users/trufflesuite/orgs","repos_url":"https://api.github.com/users/trufflesuite/repos","events_url":"https://api.github.com/users/trufflesuite/events{/privacy}","received_events_url":"https://api.github.com/users/trufflesuite/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/trufflesuite/ganache","description":"Personal blockchain for Ethereum development","fork":false,"url":"https://api.github.com/repos/trufflesuite/ganache","forks_url":"https://api.github.com/repos/trufflesuite/ganache/forks","keys_url":"https://api.github.com/repos/trufflesuite/ganache/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trufflesuite/ganache/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trufflesuite/ganache/teams","hooks_url":"https://api.github.com/repos/trufflesuite/ganache/hooks","issue_events_url":"https://api.github.com/repos/trufflesuite/ganache/issues/events{/number}","events_url":"https://api.github.com/repos/trufflesuite/ganache/events","assignees_url":"https://api.github.com/repos/trufflesuite/ganache/assignees{/user}","branches_url":"https://api.github.com/repos/trufflesuite/ganache/branches{/branch}","tags_url":"https://api.github.com/repos/trufflesuite/ganache/tags","blobs_url":"https://api.github.com/repos/trufflesuite/ganache/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trufflesuite/ganache/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trufflesuite/ganache/git/refs{/sha}","trees_url":"https://api.github.com/repos/trufflesuite/ganache/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trufflesuite/ganache/statuses/{sha}","languages_url":"https://api.github.com/repos/trufflesuite/ganache/languages","stargazers_url":"https://api.github.com/repos/trufflesuite/ganache/stargazers","contributors_url":"https://api.github.com/repos/trufflesuite/ganache/contributors","subscribers_url":"https://api.github.com/repos/trufflesuite/ganache/subscribers","subscription_url":"https://api.github.com/repos/trufflesuite/ganache/subscription","commits_url":"https://api.github.com/repos/trufflesuite/ganache/commits{/sha}","git_commits_url":"https://api.github.com/repos/trufflesuite/ganache/git/commits{/sha}","comments_url":"https://api.github.com/repos/trufflesuite/ganache/comments{/number}","issue_comment_url":"https://api.github.com/repos/trufflesuite/ganache/issues/comments{/number}","contents_url":"https://api.github.com/repos/trufflesuite/ganache/contents/{+path}","compare_url":"https://api.github.com/repos/trufflesuite/ganache/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trufflesuite/ganache/merges","archive_url":"https://api.github.com/repos/trufflesuite/ganache/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trufflesuite/ganache/downloads","issues_url":"https://api.github.com/repos/trufflesuite/ganache/issues{/number}","pulls_url":"https://api.github.com/repos/trufflesuite/ganache/pulls{/number}","milestones_url":"https://api.github.com/repos/trufflesuite/ganache/milestones{/number}","notifications_url":"https://api.github.com/repos/trufflesuite/ganache/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trufflesuite/ganache/labels{/name}","releases_url":"https://api.github.com/repos/trufflesuite/ganache/releases{/id}","deployments_url":"https://api.github.com/repos/trufflesuite/ganache/deployments","created_at":"2017-01-17T20:39:11Z","updated_at":"2018-07-01T19:49:50Z","pushed_at":"2018-07-02T19:13:14Z","git_url":"git://github.com/trufflesuite/ganache.git","ssh_url":"git@github.com:trufflesuite/ganache.git","clone_url":"https://github.com/trufflesuite/ganache.git","svn_url":"https://github.com/trufflesuite/ganache","homepage":"http://truffleframework.com/ganache","size":15879,"stargazers_count":979,"watchers_count":979,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":150,"mirror_url":null,"archived":false,"open_issues_count":103,"license":null,"forks":150,"open_issues":103,"watchers":979,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/trufflesuite/ganache/pulls/712"},"html":{"href":"https://github.com/trufflesuite/ganache/pull/712"},"issue":{"href":"https://api.github.com/repos/trufflesuite/ganache/issues/712"},"comments":{"href":"https://api.github.com/repos/trufflesuite/ganache/issues/712/comments"},"review_comments":{"href":"https://api.github.com/repos/trufflesuite/ganache/pulls/712/comments"},"review_comment":{"href":"https://api.github.com/repos/trufflesuite/ganache/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/trufflesuite/ganache/pulls/712/commits"},"statuses":{"href":"https://api.github.com/repos/trufflesuite/ganache/statuses/e0b52a0dbbb8bfcdae82b062580890ad1c1a194a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"benjamincburns"}}