{"action":"closed","number":9976,"pull_request":{"url":"https://api.github.com/repos/radare/radare2/pulls/9976","id":184779359,"html_url":"https://github.com/radare/radare2/pull/9976","diff_url":"https://github.com/radare/radare2/pull/9976.diff","patch_url":"https://github.com/radare/radare2/pull/9976.patch","issue_url":"https://api.github.com/repos/radare/radare2/issues/9976","number":9976,"state":"closed","locked":false,"title":"fixed windows crash in ROP search","user":{"login":"fcasal","id":17139618,"avatar_url":"https://avatars2.githubusercontent.com/u/17139618?v=4","gravatar_id":"","url":"https://api.github.com/users/fcasal","html_url":"https://github.com/fcasal","followers_url":"https://api.github.com/users/fcasal/followers","following_url":"https://api.github.com/users/fcasal/following{/other_user}","gists_url":"https://api.github.com/users/fcasal/gists{/gist_id}","starred_url":"https://api.github.com/users/fcasal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fcasal/subscriptions","organizations_url":"https://api.github.com/users/fcasal/orgs","repos_url":"https://api.github.com/users/fcasal/repos","events_url":"https://api.github.com/users/fcasal/events{/privacy}","received_events_url":"https://api.github.com/users/fcasal/received_events","type":"User","site_admin":false},"body":"Fixes issue https://github.com/radareorg/cutter/issues/454.\r\n\r\nThe crash was caused by the free of a strdup'ed variable in https://github.com/radare/radare2/blob/eff427e59109f74ab3292d71c21682f158a0fb21/libr/core/cmd_search.c#L1521 and only occurred in Windows. Apparently there are some issues with strdup and free in windows.\r\n\r\n@pelijah ping","created_at":"2018-04-28T10:49:50Z","updated_at":"2018-05-02T07:41:01Z","closed_at":"2018-05-02T07:41:01Z","merged_at":null,"merge_commit_sha":"3b7d95001c159c9876d48b58edc8488d18f8f405","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/radare/radare2/pulls/9976/commits","review_comments_url":"https://api.github.com/repos/radare/radare2/pulls/9976/comments","review_comment_url":"https://api.github.com/repos/radare/radare2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/radare/radare2/issues/9976/comments","statuses_url":"https://api.github.com/repos/radare/radare2/statuses/404006acb6bf09c109688186f6c4c8e5b7ca922c","head":{"label":"fcasal:master","ref":"master","sha":"404006acb6bf09c109688186f6c4c8e5b7ca922c","user":{"login":"fcasal","id":17139618,"avatar_url":"https://avatars2.githubusercontent.com/u/17139618?v=4","gravatar_id":"","url":"https://api.github.com/users/fcasal","html_url":"https://github.com/fcasal","followers_url":"https://api.github.com/users/fcasal/followers","following_url":"https://api.github.com/users/fcasal/following{/other_user}","gists_url":"https://api.github.com/users/fcasal/gists{/gist_id}","starred_url":"https://api.github.com/users/fcasal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fcasal/subscriptions","organizations_url":"https://api.github.com/users/fcasal/orgs","repos_url":"https://api.github.com/users/fcasal/repos","events_url":"https://api.github.com/users/fcasal/events{/privacy}","received_events_url":"https://api.github.com/users/fcasal/received_events","type":"User","site_admin":false},"repo":{"id":121125026,"name":"radare2","full_name":"fcasal/radare2","owner":{"login":"fcasal","id":17139618,"avatar_url":"https://avatars2.githubusercontent.com/u/17139618?v=4","gravatar_id":"","url":"https://api.github.com/users/fcasal","html_url":"https://github.com/fcasal","followers_url":"https://api.github.com/users/fcasal/followers","following_url":"https://api.github.com/users/fcasal/following{/other_user}","gists_url":"https://api.github.com/users/fcasal/gists{/gist_id}","starred_url":"https://api.github.com/users/fcasal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fcasal/subscriptions","organizations_url":"https://api.github.com/users/fcasal/orgs","repos_url":"https://api.github.com/users/fcasal/repos","events_url":"https://api.github.com/users/fcasal/events{/privacy}","received_events_url":"https://api.github.com/users/fcasal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fcasal/radare2","description":"unix-like reverse engineering framework and commandline tools","fork":true,"url":"https://api.github.com/repos/fcasal/radare2","forks_url":"https://api.github.com/repos/fcasal/radare2/forks","keys_url":"https://api.github.com/repos/fcasal/radare2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fcasal/radare2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fcasal/radare2/teams","hooks_url":"https://api.github.com/repos/fcasal/radare2/hooks","issue_events_url":"https://api.github.com/repos/fcasal/radare2/issues/events{/number}","events_url":"https://api.github.com/repos/fcasal/radare2/events","assignees_url":"https://api.github.com/repos/fcasal/radare2/assignees{/user}","branches_url":"https://api.github.com/repos/fcasal/radare2/branches{/branch}","tags_url":"https://api.github.com/repos/fcasal/radare2/tags","blobs_url":"https://api.github.com/repos/fcasal/radare2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fcasal/radare2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fcasal/radare2/git/refs{/sha}","trees_url":"https://api.github.com/repos/fcasal/radare2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fcasal/radare2/statuses/{sha}","languages_url":"https://api.github.com/repos/fcasal/radare2/languages","stargazers_url":"https://api.github.com/repos/fcasal/radare2/stargazers","contributors_url":"https://api.github.com/repos/fcasal/radare2/contributors","subscribers_url":"https://api.github.com/repos/fcasal/radare2/subscribers","subscription_url":"https://api.github.com/repos/fcasal/radare2/subscription","commits_url":"https://api.github.com/repos/fcasal/radare2/commits{/sha}","git_commits_url":"https://api.github.com/repos/fcasal/radare2/git/commits{/sha}","comments_url":"https://api.github.com/repos/fcasal/radare2/comments{/number}","issue_comment_url":"https://api.github.com/repos/fcasal/radare2/issues/comments{/number}","contents_url":"https://api.github.com/repos/fcasal/radare2/contents/{+path}","compare_url":"https://api.github.com/repos/fcasal/radare2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fcasal/radare2/merges","archive_url":"https://api.github.com/repos/fcasal/radare2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fcasal/radare2/downloads","issues_url":"https://api.github.com/repos/fcasal/radare2/issues{/number}","pulls_url":"https://api.github.com/repos/fcasal/radare2/pulls{/number}","milestones_url":"https://api.github.com/repos/fcasal/radare2/milestones{/number}","notifications_url":"https://api.github.com/repos/fcasal/radare2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fcasal/radare2/labels{/name}","releases_url":"https://api.github.com/repos/fcasal/radare2/releases{/id}","deployments_url":"https://api.github.com/repos/fcasal/radare2/deployments","created_at":"2018-02-11T13:15:33Z","updated_at":"2018-04-28T10:36:27Z","pushed_at":"2018-04-28T10:36:26Z","git_url":"git://github.com/fcasal/radare2.git","ssh_url":"git@github.com:fcasal/radare2.git","clone_url":"https://github.com/fcasal/radare2.git","svn_url":"https://github.com/fcasal/radare2","homepage":"http://www.radare.org/","size":83211,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"radare:master","ref":"master","sha":"eff427e59109f74ab3292d71c21682f158a0fb21","user":{"login":"radare","id":917142,"avatar_url":"https://avatars1.githubusercontent.com/u/917142?v=4","gravatar_id":"","url":"https://api.github.com/users/radare","html_url":"https://github.com/radare","followers_url":"https://api.github.com/users/radare/followers","following_url":"https://api.github.com/users/radare/following{/other_user}","gists_url":"https://api.github.com/users/radare/gists{/gist_id}","starred_url":"https://api.github.com/users/radare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radare/subscriptions","organizations_url":"https://api.github.com/users/radare/orgs","repos_url":"https://api.github.com/users/radare/repos","events_url":"https://api.github.com/users/radare/events{/privacy}","received_events_url":"https://api.github.com/users/radare/received_events","type":"User","site_admin":false},"repo":{"id":4869294,"name":"radare2","full_name":"radare/radare2","owner":{"login":"radare","id":917142,"avatar_url":"https://avatars1.githubusercontent.com/u/917142?v=4","gravatar_id":"","url":"https://api.github.com/users/radare","html_url":"https://github.com/radare","followers_url":"https://api.github.com/users/radare/followers","following_url":"https://api.github.com/users/radare/following{/other_user}","gists_url":"https://api.github.com/users/radare/gists{/gist_id}","starred_url":"https://api.github.com/users/radare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/radare/subscriptions","organizations_url":"https://api.github.com/users/radare/orgs","repos_url":"https://api.github.com/users/radare/repos","events_url":"https://api.github.com/users/radare/events{/privacy}","received_events_url":"https://api.github.com/users/radare/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/radare/radare2","description":"unix-like reverse engineering framework and commandline tools security","fork":false,"url":"https://api.github.com/repos/radare/radare2","forks_url":"https://api.github.com/repos/radare/radare2/forks","keys_url":"https://api.github.com/repos/radare/radare2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/radare/radare2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/radare/radare2/teams","hooks_url":"https://api.github.com/repos/radare/radare2/hooks","issue_events_url":"https://api.github.com/repos/radare/radare2/issues/events{/number}","events_url":"https://api.github.com/repos/radare/radare2/events","assignees_url":"https://api.github.com/repos/radare/radare2/assignees{/user}","branches_url":"https://api.github.com/repos/radare/radare2/branches{/branch}","tags_url":"https://api.github.com/repos/radare/radare2/tags","blobs_url":"https://api.github.com/repos/radare/radare2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/radare/radare2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/radare/radare2/git/refs{/sha}","trees_url":"https://api.github.com/repos/radare/radare2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/radare/radare2/statuses/{sha}","languages_url":"https://api.github.com/repos/radare/radare2/languages","stargazers_url":"https://api.github.com/repos/radare/radare2/stargazers","contributors_url":"https://api.github.com/repos/radare/radare2/contributors","subscribers_url":"https://api.github.com/repos/radare/radare2/subscribers","subscription_url":"https://api.github.com/repos/radare/radare2/subscription","commits_url":"https://api.github.com/repos/radare/radare2/commits{/sha}","git_commits_url":"https://api.github.com/repos/radare/radare2/git/commits{/sha}","comments_url":"https://api.github.com/repos/radare/radare2/comments{/number}","issue_comment_url":"https://api.github.com/repos/radare/radare2/issues/comments{/number}","contents_url":"https://api.github.com/repos/radare/radare2/contents/{+path}","compare_url":"https://api.github.com/repos/radare/radare2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/radare/radare2/merges","archive_url":"https://api.github.com/repos/radare/radare2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/radare/radare2/downloads","issues_url":"https://api.github.com/repos/radare/radare2/issues{/number}","pulls_url":"https://api.github.com/repos/radare/radare2/pulls{/number}","milestones_url":"https://api.github.com/repos/radare/radare2/milestones{/number}","notifications_url":"https://api.github.com/repos/radare/radare2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/radare/radare2/labels{/name}","releases_url":"https://api.github.com/repos/radare/radare2/releases{/id}","deployments_url":"https://api.github.com/repos/radare/radare2/deployments","created_at":"2012-07-03T07:42:26Z","updated_at":"2018-05-02T07:36:05Z","pushed_at":"2018-05-01T22:24:39Z","git_url":"git://github.com/radare/radare2.git","ssh_url":"git@github.com:radare/radare2.git","clone_url":"https://github.com/radare/radare2.git","svn_url":"https://github.com/radare/radare2","homepage":"http://www.radare.org/","size":83309,"stargazers_count":7273,"watchers_count":7273,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1441,"mirror_url":null,"archived":false,"open_issues_count":878,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0"},"forks":1441,"open_issues":878,"watchers":7273,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/radare/radare2/pulls/9976"},"html":{"href":"https://github.com/radare/radare2/pull/9976"},"issue":{"href":"https://api.github.com/repos/radare/radare2/issues/9976"},"comments":{"href":"https://api.github.com/repos/radare/radare2/issues/9976/comments"},"review_comments":{"href":"https://api.github.com/repos/radare/radare2/pulls/9976/comments"},"review_comment":{"href":"https://api.github.com/repos/radare/radare2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/radare/radare2/pulls/9976/commits"},"statuses":{"href":"https://api.github.com/repos/radare/radare2/statuses/404006acb6bf09c109688186f6c4c8e5b7ca922c"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":11,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":2,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"xarkes"}}