{"action":"created","issue":{"url":"https://api.github.com/repos/firewalld/firewalld/issues/363","repository_url":"https://api.github.com/repos/firewalld/firewalld","labels_url":"https://api.github.com/repos/firewalld/firewalld/issues/363/labels{/name}","comments_url":"https://api.github.com/repos/firewalld/firewalld/issues/363/comments","events_url":"https://api.github.com/repos/firewalld/firewalld/issues/363/events","html_url":"https://github.com/firewalld/firewalld/issues/363","id":347646083,"node_id":"MDU6SXNzdWUzNDc2NDYwODM=","number":363,"title":"file xxx.at included several times","user":{"login":"mbiebl","id":3609611,"node_id":"MDQ6VXNlcjM2MDk2MTE=","avatar_url":"https://avatars1.githubusercontent.com/u/3609611?v=4","gravatar_id":"","url":"https://api.github.com/users/mbiebl","html_url":"https://github.com/mbiebl","followers_url":"https://api.github.com/users/mbiebl/followers","following_url":"https://api.github.com/users/mbiebl/following{/other_user}","gists_url":"https://api.github.com/users/mbiebl/gists{/gist_id}","starred_url":"https://api.github.com/users/mbiebl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbiebl/subscriptions","organizations_url":"https://api.github.com/users/mbiebl/orgs","repos_url":"https://api.github.com/users/mbiebl/repos","events_url":"https://api.github.com/users/mbiebl/events{/privacy}","received_events_url":"https://api.github.com/users/mbiebl/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-04T20:27:20Z","updated_at":"2018-08-07T14:59:54Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"While running the test-suite, I get multiple warnings on stderror:\r\n```\r\ntestsuite.at:8: warning: file `firewall-cmd.at' included several times\r\ntestsuite.at:8: warning: file `regression.at' included several times\r\nregression.at:2: warning: file `regression/rhbz1514043.at' included several times\r\nregression.at:3: warning: file `regression/rhbz1498923.at' included several times\r\nregression.at:4: warning: file `regression/pr181.at' included several times\r\nregression.at:5: warning: file `regression/gh287.at' included several times\r\nregression.at:6: warning: file `regression/individual_calls.at' included several times\r\nregression.at:7: warning: file `regression/rhbz1534571.at' included several times\r\nregression.at:8: warning: file `regression/gh290.at' included several times\r\nregression.at:9: warning: file `regression/icmp_block_in_forward_chain.at' included several times\r\nregression.at:10: warning: file `regression/pr323.at' included several times\r\nregression.at:11: warning: file `regression/rhbz1506742.at' included several times\r\ntestsuite.at:8: warning: file `python.at' included several times\r\n```\r\n\r\nAfaics, this is caused by https://github.com/firewalld/firewalld/blob/master/src/tests/testsuite.at#L8 which includes the .at files twice, once for nftables and once for iptables. \r\nNot sure why that is necessary"},"comment":{"url":"https://api.github.com/repos/firewalld/firewalld/issues/comments/411087547","html_url":"https://github.com/firewalld/firewalld/issues/363#issuecomment-411087547","issue_url":"https://api.github.com/repos/firewalld/firewalld/issues/363","id":411087547,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMTA4NzU0Nw==","user":{"login":"erig0","id":313253,"node_id":"MDQ6VXNlcjMxMzI1Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/313253?v=4","gravatar_id":"","url":"https://api.github.com/users/erig0","html_url":"https://github.com/erig0","followers_url":"https://api.github.com/users/erig0/followers","following_url":"https://api.github.com/users/erig0/following{/other_user}","gists_url":"https://api.github.com/users/erig0/gists{/gist_id}","starred_url":"https://api.github.com/users/erig0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/erig0/subscriptions","organizations_url":"https://api.github.com/users/erig0/orgs","repos_url":"https://api.github.com/users/erig0/repos","events_url":"https://api.github.com/users/erig0/events{/privacy}","received_events_url":"https://api.github.com/users/erig0/received_events","type":"User","site_admin":false},"created_at":"2018-08-07T14:59:54Z","updated_at":"2018-08-07T14:59:54Z","author_association":"COLLABORATOR","body":"It's intentional because firewalld runs a subset of the testsuite twice - once for each firewall backend (nftables and iptables). This is done to avoid duplicating the same tests and to also make sure new tests are added for all backends. I don't think autotest provides a way to mask the warning.\r\n\r\nOne way to avoid these is to add another set of makefiles in subdirectories; `src/tests/nftables`, `src/tests/iptables`, `src/tests/offline`. Then they can each include the .at files without throwing a warning. But that also means you have multiple tests with the same number. All of them would have a test numbered \"1\". So running the following to reproduce a failure\r\n\r\n    # make check TESTSUITEFLAGS=\"1 -v -d\"\r\n\r\nwill actually run 3 different tests. I'm not sure that is worth avoiding a harmless warning. To run a individual test you need to do\r\n\r\n    # make -C src/tests/iptables check-local TESTSUITEFLAGS=\"1 -v -d\"\r\n\r\nDo you have any better ideas?"}}
{"actor":{"display_login":"erig0"}}