{"action":"created","issue":{"url":"https://api.github.com/repos/bhilburn/powerlevel9k/issues/825","repository_url":"https://api.github.com/repos/bhilburn/powerlevel9k","labels_url":"https://api.github.com/repos/bhilburn/powerlevel9k/issues/825/labels{/name}","comments_url":"https://api.github.com/repos/bhilburn/powerlevel9k/issues/825/comments","events_url":"https://api.github.com/repos/bhilburn/powerlevel9k/issues/825/events","html_url":"https://github.com/bhilburn/powerlevel9k/issues/825","id":320499036,"node_id":"MDU6SXNzdWUzMjA0OTkwMzY=","number":825,"title":"[Bug] Duplicate Color Codes","user":{"login":"onaforeignshore","id":704406,"node_id":"MDQ6VXNlcjcwNDQwNg==","avatar_url":"https://avatars3.githubusercontent.com/u/704406?v=4","gravatar_id":"","url":"https://api.github.com/users/onaforeignshore","html_url":"https://github.com/onaforeignshore","followers_url":"https://api.github.com/users/onaforeignshore/followers","following_url":"https://api.github.com/users/onaforeignshore/following{/other_user}","gists_url":"https://api.github.com/users/onaforeignshore/gists{/gist_id}","starred_url":"https://api.github.com/users/onaforeignshore/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/onaforeignshore/subscriptions","organizations_url":"https://api.github.com/users/onaforeignshore/orgs","repos_url":"https://api.github.com/users/onaforeignshore/repos","events_url":"https://api.github.com/users/onaforeignshore/events{/privacy}","received_events_url":"https://api.github.com/users/onaforeignshore/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-05-05T10:39:36Z","updated_at":"2018-08-06T23:10:59Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Whilst working through various updates, I have found that the color definitions in `functions/colors.zsh` contain many duplicates. They are listed below:\r\n```\r\ncodes[aquamarine1]=086\r\ncodes[aquamarine1]=122\r\ncodes[blue3]=019\r\ncodes[blue3]=020\r\ncodes[cadetblue]=072\r\ncodes[cadetblue]=073\r\ncodes[chartreuse2]=082\r\ncodes[chartreuse2]=112\r\ncodes[chartreuse3]=070\r\ncodes[chartreuse3]=076\r\ncodes[darkmagenta]=090\r\ncodes[darkmagenta]=091\r\ncodes[darkolivegreen1]=191\r\ncodes[darkolivegreen1]=192\r\ncodes[darkolivegreen3]=107\r\ncodes[darkolivegreen3]=113\r\ncodes[darkolivegreen3]=149\r\ncodes[darkorange3]=130\r\ncodes[darkorange3]=166\r\ncodes[darkred]=052\r\ncodes[darkred]=088\r\ncodes[darkseagreen1]=158\r\ncodes[darkseagreen1]=193\r\ncodes[darkseagreen2]=151\r\ncodes[darkseagreen2]=157\r\ncodes[darkseagreen3]=115\r\ncodes[darkseagreen3]=150\r\ncodes[darkseagreen4]=065\r\ncodes[darkseagreen4]=071\r\ncodes[darkviolet]=092\r\ncodes[darkviolet]=128\r\ncodes[deeppink1]=198\r\ncodes[deeppink1]=199\r\ncodes[deeppink3]=161\r\ncodes[deeppink3]=162\r\ncodes[deeppink4]=053\r\ncodes[deeppink4]=089\r\ncodes[deeppink4]=125\r\ncodes[deepskyblue3]=031\r\ncodes[deepskyblue3]=032\r\ncodes[deepskyblue4]=023\r\ncodes[deepskyblue4]=024\r\ncodes[deepskyblue4]=025\r\ncodes[gold3]=142\r\ncodes[gold3]=178\r\ncodes[green3]=034\r\ncodes[green3]=040\r\ncodes[hotpink3]=132\r\ncodes[hotpink3]=168\r\ncodes[hotpink]=205\r\ncodes[hotpink]=206\r\ncodes[indianred1]=203\r\ncodes[indianred1]=204\r\ncodes[indianred]=131\r\ncodes[indianred]=167\r\ncodes[lightgoldenrod2]=186\r\ncodes[lightgoldenrod2]=221\r\ncodes[lightgoldenrod2]=222\r\ncodes[lightgreen]=119\r\ncodes[lightgreen]=120\r\ncodes[lightpink1]=217\r\ncodes[lightpink3]=174\r\ncodes[lightpink4]=095\r\ncodes[lightsalmon3]=137\r\ncodes[lightsalmon3]=173\r\ncodes[lightskyblue3]=109\r\ncodes[lightskyblue3]=110\r\ncodes[magenta2]=165\r\ncodes[magenta2]=200\r\ncodes[magenta3]=127\r\ncodes[magenta3]=163\r\ncodes[magenta3]=164\r\ncodes[mediumorchid1]=171\r\ncodes[mediumorchid1]=207\r\ncodes[mediumpurple2]=135\r\ncodes[mediumpurple2]=140\r\ncodes[mediumpurple3]=097\r\ncodes[mediumpurple3]=098\r\ncodes[orange4]=058\r\ncodes[orange4]=094\r\ncodes[palegreen1]=121\r\ncodes[palegreen1]=156\r\ncodes[palegreen3]=077\r\ncodes[palegreen3]=114\r\ncodes[purple4]=054\r\ncodes[purple4]=055\r\ncodes[purple]=005\r\ncodes[purple]=093\r\ncodes[purple]=129\r\ncodes[red3]=124\r\ncodes[red3]=160\r\ncodes[seagreen1]=084\r\ncodes[seagreen1]=085\r\ncodes[silver]=007\r\ncodes[slateblue3]=061\r\ncodes[slateblue3]=062\r\ncodes[springgreen2]=042\r\ncodes[springgreen2]=047\r\ncodes[springgreen3]=035\r\ncodes[springgreen3]=041\r\ncodes[steelblue1]=075\r\ncodes[steelblue1]=081\r\ncodes[yellow3]=148\r\ncodes[yellow3]=184\r\ncodes[yellow4]=100\r\ncodes[yellow4]=106\r\n```\r\nSince this is a known issue, we should decide on which one would be the specific color (at the moment it is the last one defined). See [here](https://jonasjacek.github.io/colors/) and [here](https://en.wikipedia.org/wiki/X11_color_names#Derived_lists)"},"comment":{"url":"https://api.github.com/repos/bhilburn/powerlevel9k/issues/comments/410881255","html_url":"https://github.com/bhilburn/powerlevel9k/issues/825#issuecomment-410881255","issue_url":"https://api.github.com/repos/bhilburn/powerlevel9k/issues/825","id":410881255,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMDg4MTI1NQ==","user":{"login":"dritter","id":1544760,"node_id":"MDQ6VXNlcjE1NDQ3NjA=","avatar_url":"https://avatars2.githubusercontent.com/u/1544760?v=4","gravatar_id":"","url":"https://api.github.com/users/dritter","html_url":"https://github.com/dritter","followers_url":"https://api.github.com/users/dritter/followers","following_url":"https://api.github.com/users/dritter/following{/other_user}","gists_url":"https://api.github.com/users/dritter/gists{/gist_id}","starred_url":"https://api.github.com/users/dritter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dritter/subscriptions","organizations_url":"https://api.github.com/users/dritter/orgs","repos_url":"https://api.github.com/users/dritter/repos","events_url":"https://api.github.com/users/dritter/events{/privacy}","received_events_url":"https://api.github.com/users/dritter/received_events","type":"User","site_admin":false},"created_at":"2018-08-06T23:10:59Z","updated_at":"2018-08-06T23:10:59Z","author_association":"COLLABORATOR","body":"I think the duplicates are especially a problem, when check if two colors are the same. That might cause trouble if at some point we have translated a named color to its color code and have, on the other hand, a color code..\r\n\r\nNot sure if it is a good way to change the names to arbitrary strings. Probably users are relying on color names they got from somewhere else.\r\n\r\nAnd about the bright color part: This code is reaaally old. The commit is 0e37d8ef865daddd6af02ba78b4a3bb86fd5917e. Yes, indeed it is about bright colors. I think I wrote it that way, because the bright colors did not work on my machine, and I assumed it would be better to handle them if they were normal colors. This code could be removed IMHO."}}
{"actor":{"display_login":"dritter"}}