{"action":"created","comment":{"url":"https://api.github.com/repos/dcos/dcos-mesos-modules/pulls/comments/209788308","pull_request_review_id":145781712,"id":209788308,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTc4ODMwOA==","diff_hunk":"@@ -221,16 +221,65 @@ class MetricsIsolatorProcess\n     return Nothing();\n   }\n \n+  // Let the metrics service know about the container being launched.\n+  // In the response, grab the STATSD_UDP_HOST and STATSD_UDP_PORT\n+  // pair being returned and set it in the environment of the\n+  // `ContainerLaunchInfo` returned from this function.\n   virtual Future<Option<ContainerLaunchInfo>> prepare(\n       const ContainerID& containerId,\n       const slave::ContainerConfig& containerConfig)\n   {\n-    // Let the metrics service know about the container being\n-    // launched via an HTTP request. In the response, grab the\n-    // STATSD_UDP_HOST and STATSD_UDP_PORT pair being returned and set\n-    // it in the environment of the `ContainerLaunchInfo` returned\n-    // from this function. On any errors, return a `Failure()`.\n+    ContainerStartRequest containerStartRequest;\n+    containerStartRequest.set_container_id(containerId.value());\n+\n+    Try<http::Response> response = send(containerStartRequest);\n+    if (response.isError()) {\n+      return Failure(\"Error posting 'containerStartRequest' for container\"\n+                     \" '\" + containerId.value() + \"': \" + response.error());\n+    }\n+\n+    if (response->code == http::Status::NO_CONTENT) {\n+        return ContainerLaunchInfo();","path":"metrics/isolator.cpp","position":null,"original_position":27,"commit_id":"f7718a9195a7df5316cd7c509ecffd7d55bef30a","original_commit_id":"a215798887813ecc7f37af077591ff8af7b8bc9d","user":{"login":"greggomann","id":954725,"node_id":"MDQ6VXNlcjk1NDcyNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/954725?v=4","gravatar_id":"","url":"https://api.github.com/users/greggomann","html_url":"https://github.com/greggomann","followers_url":"https://api.github.com/users/greggomann/followers","following_url":"https://api.github.com/users/greggomann/following{/other_user}","gists_url":"https://api.github.com/users/greggomann/gists{/gist_id}","starred_url":"https://api.github.com/users/greggomann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greggomann/subscriptions","organizations_url":"https://api.github.com/users/greggomann/orgs","repos_url":"https://api.github.com/users/greggomann/repos","events_url":"https://api.github.com/users/greggomann/events{/privacy}","received_events_url":"https://api.github.com/users/greggomann/received_events","type":"User","site_admin":false},"body":"Can we return `None()` here?","created_at":"2018-08-13T23:18:28Z","updated_at":"2018-08-13T23:38:53Z","html_url":"https://github.com/dcos/dcos-mesos-modules/pull/54#discussion_r209788308","pull_request_url":"https://api.github.com/repos/dcos/dcos-mesos-modules/pulls/54","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dcos/dcos-mesos-modules/pulls/comments/209788308"},"html":{"href":"https://github.com/dcos/dcos-mesos-modules/pull/54#discussion_r209788308"},"pull_request":{"href":"https://api.github.com/repos/dcos/dcos-mesos-modules/pulls/54"}}},"pull_request":{"url":"https://api.github.com/repos/dcos/dcos-mesos-modules/pulls/54","id":208064949,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MDY0OTQ5","html_url":"https://github.com/dcos/dcos-mesos-modules/pull/54","diff_url":"https://github.com/dcos/dcos-mesos-modules/pull/54.diff","patch_url":"https://github.com/dcos/dcos-mesos-modules/pull/54.patch","issue_url":"https://api.github.com/repos/dcos/dcos-mesos-modules/issues/54","number":54,"state":"open","locked":false,"title":"WIP: add Metrics Module 2.0","user":{"login":"greggomann","id":954725,"node_id":"MDQ6VXNlcjk1NDcyNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/954725?v=4","gravatar_id":"","url":"https://api.github.com/users/greggomann","html_url":"https://github.com/greggomann","followers_url":"https://api.github.com/users/greggomann/followers","following_url":"https://api.github.com/users/greggomann/following{/other_user}","gists_url":"https://api.github.com/users/greggomann/gists{/gist_id}","starred_url":"https://api.github.com/users/greggomann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greggomann/subscriptions","organizations_url":"https://api.github.com/users/greggomann/orgs","repos_url":"https://api.github.com/users/greggomann/repos","events_url":"https://api.github.com/users/greggomann/events{/privacy}","received_events_url":"https://api.github.com/users/greggomann/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-13T18:33:43Z","updated_at":"2018-08-13T23:38:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7709fdf90d3455eb144345438f2e004c49fb88f0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dcos/dcos-mesos-modules/pulls/54/commits","review_comments_url":"https://api.github.com/repos/dcos/dcos-mesos-modules/pulls/54/comments","review_comment_url":"https://api.github.com/repos/dcos/dcos-mesos-modules/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dcos/dcos-mesos-modules/issues/54/comments","statuses_url":"https://api.github.com/repos/dcos/dcos-mesos-modules/statuses/f7718a9195a7df5316cd7c509ecffd7d55bef30a","head":{"label":"klueska-mesosphere:klueska/add-metrics-module-2.0","ref":"klueska/add-metrics-module-2.0","sha":"f7718a9195a7df5316cd7c509ecffd7d55bef30a","user":{"login":"klueska-mesosphere","id":14319002,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzE5MDAy","avatar_url":"https://avatars2.githubusercontent.com/u/14319002?v=4","gravatar_id":"","url":"https://api.github.com/users/klueska-mesosphere","html_url":"https://github.com/klueska-mesosphere","followers_url":"https://api.github.com/users/klueska-mesosphere/followers","following_url":"https://api.github.com/users/klueska-mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/klueska-mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/klueska-mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klueska-mesosphere/subscriptions","organizations_url":"https://api.github.com/users/klueska-mesosphere/orgs","repos_url":"https://api.github.com/users/klueska-mesosphere/repos","events_url":"https://api.github.com/users/klueska-mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/klueska-mesosphere/received_events","type":"Organization","site_admin":false},"repo":{"id":83391934,"node_id":"MDEwOlJlcG9zaXRvcnk4MzM5MTkzNA==","name":"dcos-mesos-modules","full_name":"klueska-mesosphere/dcos-mesos-modules","owner":{"login":"klueska-mesosphere","id":14319002,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzE5MDAy","avatar_url":"https://avatars2.githubusercontent.com/u/14319002?v=4","gravatar_id":"","url":"https://api.github.com/users/klueska-mesosphere","html_url":"https://github.com/klueska-mesosphere","followers_url":"https://api.github.com/users/klueska-mesosphere/followers","following_url":"https://api.github.com/users/klueska-mesosphere/following{/other_user}","gists_url":"https://api.github.com/users/klueska-mesosphere/gists{/gist_id}","starred_url":"https://api.github.com/users/klueska-mesosphere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/klueska-mesosphere/subscriptions","organizations_url":"https://api.github.com/users/klueska-mesosphere/orgs","repos_url":"https://api.github.com/users/klueska-mesosphere/repos","events_url":"https://api.github.com/users/klueska-mesosphere/events{/privacy}","received_events_url":"https://api.github.com/users/klueska-mesosphere/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/klueska-mesosphere/dcos-mesos-modules","description":"Mesos Modules used in DC/OS","fork":true,"url":"https://api.github.com/repos/klueska-mesosphere/dcos-mesos-modules","forks_url":"https://api.github.com/repos/klueska-mesosphere/dcos-mesos-modules/forks","keys_url":"https://api.github.com/repos/klueska-mesosphere/dcos-mesos-modules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/klueska-mesosphere/dcos-mesos-modules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/klueska-mesosphere/dcos-mesos-modules/teams","hooks_url":"https://api.github.com/repos/klueska-mesosphere/dcos-mesos-modules/hooks","issue_events_url":"https://api.github.com/repos/klueska-mesosphere/dcos-mesos-modules/issues/events{/number}","events_url":"https://api.github.com/repos/klueska-mesosphere/dcos-mesos-modules/events","assignees_url":"https://api.github.com/repos/klueska-mesosphere/dcos-mesos-modules/assignees{/user}","branches_url":"https://api.github.com/repos/klueska-mesosphere/dcos-mesos-modules/branches{/branch}","tags_url":"https://api.github.com/repos/klueska-mesosphere/dcos-mesos-modules/tags","blobs_url":"https://api.github.com/repos/klueska-mesosphere/dcos-mesos-modules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/klueska-mesosphere/dcos-mesos-modules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/klueska-mesosphere/dcos-mesos-modules/git/refs{/sha}","trees_url":"https://api.github.com/repos/klueska-mesosphere/dcos-mesos-modules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/klueska-mesosphere/dcos-mesos-modules/statuses/{sha}","languages_url":"https://api.github.com/repos/klueska-mesosphere/dcos-mesos-modules/languages","stargazers_url":"https://api.github.com/repos/klueska-mesosphere/dcos-mesos-modules/stargazers","contributors_url":"https://api.github.com/repos/klueska-mesosphere/dcos-mesos-modules/contributors","subscribers_url":"https://api.github.com/repos/klueska-mesosphere/dcos-mesos-modules/subscribers","subscription_url":"https://api.github.com/repos/klueska-mesosphere/dcos-mesos-modules/subscription","commits_url":"https://api.github.com/repos/klueska-mesosphere/dcos-mesos-modules/commits{/sha}","git_commits_url":"https://api.github.com/repos/klueska-mesosphere/dcos-mesos-modules/git/commits{/sha}","comments_url":"https://api.github.com/repos/klueska-mesosphere/dcos-mesos-modules/comments{/number}","issue_comment_url":"https://api.github.com/repos/klueska-mesosphere/dcos-mesos-modules/issues/comments{/number}","contents_url":"https://api.github.com/repos/klueska-mesosphere/dcos-mesos-modules/contents/{+path}","compare_url":"https://api.github.com/repos/klueska-mesosphere/dcos-mesos-modules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/klueska-mesosphere/dcos-mesos-modules/merges","archive_url":"https://api.github.com/repos/klueska-mesosphere/dcos-mesos-modules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/klueska-mesosphere/dcos-mesos-modules/downloads","issues_url":"https://api.github.com/repos/klueska-mesosphere/dcos-mesos-modules/issues{/number}","pulls_url":"https://api.github.com/repos/klueska-mesosphere/dcos-mesos-modules/pulls{/number}","milestones_url":"https://api.github.com/repos/klueska-mesosphere/dcos-mesos-modules/milestones{/number}","notifications_url":"https://api.github.com/repos/klueska-mesosphere/dcos-mesos-modules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/klueska-mesosphere/dcos-mesos-modules/labels{/name}","releases_url":"https://api.github.com/repos/klueska-mesosphere/dcos-mesos-modules/releases{/id}","deployments_url":"https://api.github.com/repos/klueska-mesosphere/dcos-mesos-modules/deployments","created_at":"2017-02-28T05:07:53Z","updated_at":"2017-02-28T05:07:54Z","pushed_at":"2018-08-10T14:04:29Z","git_url":"git://github.com/klueska-mesosphere/dcos-mesos-modules.git","ssh_url":"git@github.com:klueska-mesosphere/dcos-mesos-modules.git","clone_url":"https://github.com/klueska-mesosphere/dcos-mesos-modules.git","svn_url":"https://github.com/klueska-mesosphere/dcos-mesos-modules","homepage":null,"size":654,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dcos:master","ref":"master","sha":"26d11daee118055ab0975b0eaa0a25b6cf1a35c3","user":{"login":"dcos","id":17648048,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NjQ4MDQ4","avatar_url":"https://avatars1.githubusercontent.com/u/17648048?v=4","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"repo":{"id":64402116,"node_id":"MDEwOlJlcG9zaXRvcnk2NDQwMjExNg==","name":"dcos-mesos-modules","full_name":"dcos/dcos-mesos-modules","owner":{"login":"dcos","id":17648048,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NjQ4MDQ4","avatar_url":"https://avatars1.githubusercontent.com/u/17648048?v=4","gravatar_id":"","url":"https://api.github.com/users/dcos","html_url":"https://github.com/dcos","followers_url":"https://api.github.com/users/dcos/followers","following_url":"https://api.github.com/users/dcos/following{/other_user}","gists_url":"https://api.github.com/users/dcos/gists{/gist_id}","starred_url":"https://api.github.com/users/dcos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dcos/subscriptions","organizations_url":"https://api.github.com/users/dcos/orgs","repos_url":"https://api.github.com/users/dcos/repos","events_url":"https://api.github.com/users/dcos/events{/privacy}","received_events_url":"https://api.github.com/users/dcos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dcos/dcos-mesos-modules","description":"Mesos Modules used in DC/OS","fork":false,"url":"https://api.github.com/repos/dcos/dcos-mesos-modules","forks_url":"https://api.github.com/repos/dcos/dcos-mesos-modules/forks","keys_url":"https://api.github.com/repos/dcos/dcos-mesos-modules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dcos/dcos-mesos-modules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dcos/dcos-mesos-modules/teams","hooks_url":"https://api.github.com/repos/dcos/dcos-mesos-modules/hooks","issue_events_url":"https://api.github.com/repos/dcos/dcos-mesos-modules/issues/events{/number}","events_url":"https://api.github.com/repos/dcos/dcos-mesos-modules/events","assignees_url":"https://api.github.com/repos/dcos/dcos-mesos-modules/assignees{/user}","branches_url":"https://api.github.com/repos/dcos/dcos-mesos-modules/branches{/branch}","tags_url":"https://api.github.com/repos/dcos/dcos-mesos-modules/tags","blobs_url":"https://api.github.com/repos/dcos/dcos-mesos-modules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dcos/dcos-mesos-modules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dcos/dcos-mesos-modules/git/refs{/sha}","trees_url":"https://api.github.com/repos/dcos/dcos-mesos-modules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dcos/dcos-mesos-modules/statuses/{sha}","languages_url":"https://api.github.com/repos/dcos/dcos-mesos-modules/languages","stargazers_url":"https://api.github.com/repos/dcos/dcos-mesos-modules/stargazers","contributors_url":"https://api.github.com/repos/dcos/dcos-mesos-modules/contributors","subscribers_url":"https://api.github.com/repos/dcos/dcos-mesos-modules/subscribers","subscription_url":"https://api.github.com/repos/dcos/dcos-mesos-modules/subscription","commits_url":"https://api.github.com/repos/dcos/dcos-mesos-modules/commits{/sha}","git_commits_url":"https://api.github.com/repos/dcos/dcos-mesos-modules/git/commits{/sha}","comments_url":"https://api.github.com/repos/dcos/dcos-mesos-modules/comments{/number}","issue_comment_url":"https://api.github.com/repos/dcos/dcos-mesos-modules/issues/comments{/number}","contents_url":"https://api.github.com/repos/dcos/dcos-mesos-modules/contents/{+path}","compare_url":"https://api.github.com/repos/dcos/dcos-mesos-modules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dcos/dcos-mesos-modules/merges","archive_url":"https://api.github.com/repos/dcos/dcos-mesos-modules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dcos/dcos-mesos-modules/downloads","issues_url":"https://api.github.com/repos/dcos/dcos-mesos-modules/issues{/number}","pulls_url":"https://api.github.com/repos/dcos/dcos-mesos-modules/pulls{/number}","milestones_url":"https://api.github.com/repos/dcos/dcos-mesos-modules/milestones{/number}","notifications_url":"https://api.github.com/repos/dcos/dcos-mesos-modules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dcos/dcos-mesos-modules/labels{/name}","releases_url":"https://api.github.com/repos/dcos/dcos-mesos-modules/releases{/id}","deployments_url":"https://api.github.com/repos/dcos/dcos-mesos-modules/deployments","created_at":"2016-07-28T14:26:25Z","updated_at":"2018-07-24T18:59:21Z","pushed_at":"2018-08-13T18:33:43Z","git_url":"git://github.com/dcos/dcos-mesos-modules.git","ssh_url":"git@github.com:dcos/dcos-mesos-modules.git","clone_url":"https://github.com/dcos/dcos-mesos-modules.git","svn_url":"https://github.com/dcos/dcos-mesos-modules","homepage":null,"size":676,"stargazers_count":17,"watchers_count":17,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":19,"open_issues":1,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dcos/dcos-mesos-modules/pulls/54"},"html":{"href":"https://github.com/dcos/dcos-mesos-modules/pull/54"},"issue":{"href":"https://api.github.com/repos/dcos/dcos-mesos-modules/issues/54"},"comments":{"href":"https://api.github.com/repos/dcos/dcos-mesos-modules/issues/54/comments"},"review_comments":{"href":"https://api.github.com/repos/dcos/dcos-mesos-modules/pulls/54/comments"},"review_comment":{"href":"https://api.github.com/repos/dcos/dcos-mesos-modules/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dcos/dcos-mesos-modules/pulls/54/commits"},"statuses":{"href":"https://api.github.com/repos/dcos/dcos-mesos-modules/statuses/f7718a9195a7df5316cd7c509ecffd7d55bef30a"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"greggomann"}}