{"action":"created","comment":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/222740271","pull_request_review_id":161700957,"id":222740271,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjc0MDI3MQ==","diff_hunk":"@@ -256,36 +239,35 @@ void Procedural::prepare(gpu::Batch& batch,\n         }\n \n         // Build the fragment shader\n-        std::string opaqueShaderSource = replaceProceduralBlock(_opaquefragmentSource.getCode());\n-        auto opaqueReflection = _opaquefragmentSource.getReflection();\n-        auto& opaqueUniforms = opaqueReflection[gpu::Shader::BindingType::UNIFORM];\n-        std::string transparentShaderSource = replaceProceduralBlock(_transparentfragmentSource.getCode());\n-        auto transparentReflection = _transparentfragmentSource.getReflection();\n-        auto& transparentUniforms = transparentReflection[gpu::Shader::BindingType::UNIFORM];\n+        _opaqueFragmentSource.replacements.clear();\n+        if (_data.version == 1) {\n+            _opaqueFragmentSource.replacements[PROCEDURAL_VERSION] = \"#define PROCEDURAL_V1 1\";\n+        } else if (_data.version == 2) {\n+            _opaqueFragmentSource.replacements[PROCEDURAL_VERSION] = \"#define PROCEDURAL_V2 1\";\n+        }\n+        _opaqueFragmentSource.replacements[PROCEDURAL_BLOCK] = _shaderSource.toStdString();\n+        _transparentFragmentSource.replacements = _opaqueFragmentSource.replacements;\n+\n+        // auto& opaqueUniforms = opaqueReflection[gpu::Shader::BindingType::UNIFORM];\n+        // auto& transparentUniforms = transparentReflection[gpu::Shader::BindingType::UNIFORM];","path":"libraries/procedural/src/procedural/Procedural.cpp","position":91,"original_position":91,"commit_id":"985fce6b2fbb5963cc38726c5c45cb0c918a5570","original_commit_id":"985fce6b2fbb5963cc38726c5c45cb0c918a5570","user":{"login":"jherico","id":1533642,"node_id":"MDQ6VXNlcjE1MzM2NDI=","avatar_url":"https://avatars1.githubusercontent.com/u/1533642?v=4","gravatar_id":"","url":"https://api.github.com/users/jherico","html_url":"https://github.com/jherico","followers_url":"https://api.github.com/users/jherico/followers","following_url":"https://api.github.com/users/jherico/following{/other_user}","gists_url":"https://api.github.com/users/jherico/gists{/gist_id}","starred_url":"https://api.github.com/users/jherico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jherico/subscriptions","organizations_url":"https://api.github.com/users/jherico/orgs","repos_url":"https://api.github.com/users/jherico/repos","events_url":"https://api.github.com/users/jherico/events{/privacy}","received_events_url":"https://api.github.com/users/jherico/received_events","type":"User","site_admin":false},"body":"done","created_at":"2018-10-04T16:28:23Z","updated_at":"2018-10-04T16:28:23Z","html_url":"https://github.com/highfidelity/hifi/pull/13951#discussion_r222740271","pull_request_url":"https://api.github.com/repos/highfidelity/hifi/pulls/13951","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments/222740271"},"html":{"href":"https://github.com/highfidelity/hifi/pull/13951#discussion_r222740271"},"pull_request":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/13951"}},"in_reply_to_id":222481440},"pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/13951","id":213674333,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNjc0MzMz","html_url":"https://github.com/highfidelity/hifi/pull/13951","diff_url":"https://github.com/highfidelity/hifi/pull/13951.diff","patch_url":"https://github.com/highfidelity/hifi/pull/13951.patch","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/13951","number":13951,"state":"open","locked":false,"title":"Updating our shader tool chain to enable SPIRV optimization ","user":{"login":"jherico","id":1533642,"node_id":"MDQ6VXNlcjE1MzM2NDI=","avatar_url":"https://avatars1.githubusercontent.com/u/1533642?v=4","gravatar_id":"","url":"https://api.github.com/users/jherico","html_url":"https://github.com/jherico","followers_url":"https://api.github.com/users/jherico/followers","following_url":"https://api.github.com/users/jherico/following{/other_user}","gists_url":"https://api.github.com/users/jherico/gists{/gist_id}","starred_url":"https://api.github.com/users/jherico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jherico/subscriptions","organizations_url":"https://api.github.com/users/jherico/orgs","repos_url":"https://api.github.com/users/jherico/repos","events_url":"https://api.github.com/users/jherico/events{/privacy}","received_events_url":"https://api.github.com/users/jherico/received_events","type":"User","site_admin":false},"body":"\r\n## Testing\r\n\r\nFull regression of rendering\r\n\r\n","created_at":"2018-09-06T16:14:22Z","updated_at":"2018-10-04T16:28:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4fbee4ea193d91935a9a122d9345c56bdbfe907f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":907795710,"node_id":"MDU6TGFiZWw5MDc3OTU3MTA=","url":"https://api.github.com/repos/highfidelity/hifi/labels/Android%20Smoke%20Required","name":"Android Smoke Required","color":"fbca04","default":false},{"id":675876856,"node_id":"MDU6TGFiZWw2NzU4NzY4NTY=","url":"https://api.github.com/repos/highfidelity/hifi/labels/Engine","name":"Engine","color":"A2277C","default":false}],"milestone":{"url":"https://api.github.com/repos/highfidelity/hifi/milestones/35","html_url":"https://github.com/highfidelity/hifi/milestone/35","labels_url":"https://api.github.com/repos/highfidelity/hifi/milestones/35/labels","id":3290834,"node_id":"MDk6TWlsZXN0b25lMzI5MDgzNA==","number":35,"title":"v0.75.0","description":"","creator":{"login":"conklin94122","id":12115653,"node_id":"MDQ6VXNlcjEyMTE1NjUz","avatar_url":"https://avatars2.githubusercontent.com/u/12115653?v=4","gravatar_id":"","url":"https://api.github.com/users/conklin94122","html_url":"https://github.com/conklin94122","followers_url":"https://api.github.com/users/conklin94122/followers","following_url":"https://api.github.com/users/conklin94122/following{/other_user}","gists_url":"https://api.github.com/users/conklin94122/gists{/gist_id}","starred_url":"https://api.github.com/users/conklin94122/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conklin94122/subscriptions","organizations_url":"https://api.github.com/users/conklin94122/orgs","repos_url":"https://api.github.com/users/conklin94122/repos","events_url":"https://api.github.com/users/conklin94122/events{/privacy}","received_events_url":"https://api.github.com/users/conklin94122/received_events","type":"User","site_admin":false},"open_issues":32,"closed_issues":2,"state":"open","created_at":"2018-04-23T19:27:18Z","updated_at":"2018-10-04T00:21:47Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/highfidelity/hifi/pulls/13951/commits","review_comments_url":"https://api.github.com/repos/highfidelity/hifi/pulls/13951/comments","review_comment_url":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/13951/comments","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/985fce6b2fbb5963cc38726c5c45cb0c918a5570","head":{"label":"jherico:feature/spirv","ref":"feature/spirv","sha":"985fce6b2fbb5963cc38726c5c45cb0c918a5570","user":{"login":"jherico","id":1533642,"node_id":"MDQ6VXNlcjE1MzM2NDI=","avatar_url":"https://avatars1.githubusercontent.com/u/1533642?v=4","gravatar_id":"","url":"https://api.github.com/users/jherico","html_url":"https://github.com/jherico","followers_url":"https://api.github.com/users/jherico/followers","following_url":"https://api.github.com/users/jherico/following{/other_user}","gists_url":"https://api.github.com/users/jherico/gists{/gist_id}","starred_url":"https://api.github.com/users/jherico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jherico/subscriptions","organizations_url":"https://api.github.com/users/jherico/orgs","repos_url":"https://api.github.com/users/jherico/repos","events_url":"https://api.github.com/users/jherico/events{/privacy}","received_events_url":"https://api.github.com/users/jherico/received_events","type":"User","site_admin":false},"repo":{"id":29566286,"node_id":"MDEwOlJlcG9zaXRvcnkyOTU2NjI4Ng==","name":"hifi","full_name":"jherico/hifi","private":false,"owner":{"login":"jherico","id":1533642,"node_id":"MDQ6VXNlcjE1MzM2NDI=","avatar_url":"https://avatars1.githubusercontent.com/u/1533642?v=4","gravatar_id":"","url":"https://api.github.com/users/jherico","html_url":"https://github.com/jherico","followers_url":"https://api.github.com/users/jherico/followers","following_url":"https://api.github.com/users/jherico/following{/other_user}","gists_url":"https://api.github.com/users/jherico/gists{/gist_id}","starred_url":"https://api.github.com/users/jherico/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jherico/subscriptions","organizations_url":"https://api.github.com/users/jherico/orgs","repos_url":"https://api.github.com/users/jherico/repos","events_url":"https://api.github.com/users/jherico/events{/privacy}","received_events_url":"https://api.github.com/users/jherico/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jherico/hifi","description":"Open, decentralized virtual worlds using sensors to control avatars and dynamically assigned devices as servers.  San Francisco based startup, we are hiring: http://highfidelity.io/jobs  Documentation at http://docs.highfidelity.io  Contribute by reporting bugs & doing jobs on http://worklist.net","fork":true,"url":"https://api.github.com/repos/jherico/hifi","forks_url":"https://api.github.com/repos/jherico/hifi/forks","keys_url":"https://api.github.com/repos/jherico/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jherico/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jherico/hifi/teams","hooks_url":"https://api.github.com/repos/jherico/hifi/hooks","issue_events_url":"https://api.github.com/repos/jherico/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/jherico/hifi/events","assignees_url":"https://api.github.com/repos/jherico/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/jherico/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/jherico/hifi/tags","blobs_url":"https://api.github.com/repos/jherico/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jherico/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jherico/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/jherico/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jherico/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/jherico/hifi/languages","stargazers_url":"https://api.github.com/repos/jherico/hifi/stargazers","contributors_url":"https://api.github.com/repos/jherico/hifi/contributors","subscribers_url":"https://api.github.com/repos/jherico/hifi/subscribers","subscription_url":"https://api.github.com/repos/jherico/hifi/subscription","commits_url":"https://api.github.com/repos/jherico/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/jherico/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/jherico/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/jherico/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/jherico/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/jherico/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jherico/hifi/merges","archive_url":"https://api.github.com/repos/jherico/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jherico/hifi/downloads","issues_url":"https://api.github.com/repos/jherico/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/jherico/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/jherico/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/jherico/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jherico/hifi/labels{/name}","releases_url":"https://api.github.com/repos/jherico/hifi/releases{/id}","deployments_url":"https://api.github.com/repos/jherico/hifi/deployments","created_at":"2015-01-21T02:11:03Z","updated_at":"2018-09-25T00:25:41Z","pushed_at":"2018-10-02T23:31:35Z","git_url":"git://github.com/jherico/hifi.git","ssh_url":"git@github.com:jherico/hifi.git","clone_url":"https://github.com/jherico/hifi.git","svn_url":"https://github.com/jherico/hifi","homepage":"","size":563344,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"highfidelity:master","ref":"master","sha":"19438d143e4f07ffdfe8b9f407df21a2d804f4cd","user":{"login":"highfidelity","id":1565370,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjUzNzA=","avatar_url":"https://avatars0.githubusercontent.com/u/1565370?v=4","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"repo":{"id":5372872,"node_id":"MDEwOlJlcG9zaXRvcnk1MzcyODcy","name":"hifi","full_name":"highfidelity/hifi","private":false,"owner":{"login":"highfidelity","id":1565370,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjUzNzA=","avatar_url":"https://avatars0.githubusercontent.com/u/1565370?v=4","gravatar_id":"","url":"https://api.github.com/users/highfidelity","html_url":"https://github.com/highfidelity","followers_url":"https://api.github.com/users/highfidelity/followers","following_url":"https://api.github.com/users/highfidelity/following{/other_user}","gists_url":"https://api.github.com/users/highfidelity/gists{/gist_id}","starred_url":"https://api.github.com/users/highfidelity/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/highfidelity/subscriptions","organizations_url":"https://api.github.com/users/highfidelity/orgs","repos_url":"https://api.github.com/users/highfidelity/repos","events_url":"https://api.github.com/users/highfidelity/events{/privacy}","received_events_url":"https://api.github.com/users/highfidelity/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/highfidelity/hifi","description":"Open source client/server software for creating shared VR environments.  Docs at http://docs.highfidelity.com  We are hiring: http://highfidelity.com/jobs  Also, PT work available at http://worklist.net","fork":false,"url":"https://api.github.com/repos/highfidelity/hifi","forks_url":"https://api.github.com/repos/highfidelity/hifi/forks","keys_url":"https://api.github.com/repos/highfidelity/hifi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/highfidelity/hifi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/highfidelity/hifi/teams","hooks_url":"https://api.github.com/repos/highfidelity/hifi/hooks","issue_events_url":"https://api.github.com/repos/highfidelity/hifi/issues/events{/number}","events_url":"https://api.github.com/repos/highfidelity/hifi/events","assignees_url":"https://api.github.com/repos/highfidelity/hifi/assignees{/user}","branches_url":"https://api.github.com/repos/highfidelity/hifi/branches{/branch}","tags_url":"https://api.github.com/repos/highfidelity/hifi/tags","blobs_url":"https://api.github.com/repos/highfidelity/hifi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/highfidelity/hifi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/highfidelity/hifi/git/refs{/sha}","trees_url":"https://api.github.com/repos/highfidelity/hifi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/highfidelity/hifi/statuses/{sha}","languages_url":"https://api.github.com/repos/highfidelity/hifi/languages","stargazers_url":"https://api.github.com/repos/highfidelity/hifi/stargazers","contributors_url":"https://api.github.com/repos/highfidelity/hifi/contributors","subscribers_url":"https://api.github.com/repos/highfidelity/hifi/subscribers","subscription_url":"https://api.github.com/repos/highfidelity/hifi/subscription","commits_url":"https://api.github.com/repos/highfidelity/hifi/commits{/sha}","git_commits_url":"https://api.github.com/repos/highfidelity/hifi/git/commits{/sha}","comments_url":"https://api.github.com/repos/highfidelity/hifi/comments{/number}","issue_comment_url":"https://api.github.com/repos/highfidelity/hifi/issues/comments{/number}","contents_url":"https://api.github.com/repos/highfidelity/hifi/contents/{+path}","compare_url":"https://api.github.com/repos/highfidelity/hifi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/highfidelity/hifi/merges","archive_url":"https://api.github.com/repos/highfidelity/hifi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/highfidelity/hifi/downloads","issues_url":"https://api.github.com/repos/highfidelity/hifi/issues{/number}","pulls_url":"https://api.github.com/repos/highfidelity/hifi/pulls{/number}","milestones_url":"https://api.github.com/repos/highfidelity/hifi/milestones{/number}","notifications_url":"https://api.github.com/repos/highfidelity/hifi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/highfidelity/hifi/labels{/name}","releases_url":"https://api.github.com/repos/highfidelity/hifi/releases{/id}","deployments_url":"https://api.github.com/repos/highfidelity/hifi/deployments","created_at":"2012-08-10T18:26:22Z","updated_at":"2018-10-04T13:19:32Z","pushed_at":"2018-10-04T16:00:27Z","git_url":"git://github.com/highfidelity/hifi.git","ssh_url":"git@github.com:highfidelity/hifi.git","clone_url":"https://github.com/highfidelity/hifi.git","svn_url":"https://github.com/highfidelity/hifi","homepage":"","size":562487,"stargazers_count":649,"watchers_count":649,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":417,"mirror_url":null,"archived":false,"open_issues_count":195,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":417,"open_issues":195,"watchers":649,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/13951"},"html":{"href":"https://github.com/highfidelity/hifi/pull/13951"},"issue":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/13951"},"comments":{"href":"https://api.github.com/repos/highfidelity/hifi/issues/13951/comments"},"review_comments":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/13951/comments"},"review_comment":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/highfidelity/hifi/pulls/13951/commits"},"statuses":{"href":"https://api.github.com/repos/highfidelity/hifi/statuses/985fce6b2fbb5963cc38726c5c45cb0c918a5570"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jherico"}}