{"action":"created","issue":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/23278","repository_url":"https://api.github.com/repos/cockroachdb/cockroach","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/23278/labels{/name}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/23278/comments","events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/23278/events","html_url":"https://github.com/cockroachdb/cockroach/pull/23278","id":301526075,"number":23278,"title":"sql: tag crash reports with relevant statement","user":{"login":"solongordon","id":679246,"avatar_url":"https://avatars1.githubusercontent.com/u/679246?v=4","gravatar_id":"","url":"https://api.github.com/users/solongordon","html_url":"https://github.com/solongordon","followers_url":"https://api.github.com/users/solongordon/followers","following_url":"https://api.github.com/users/solongordon/following{/other_user}","gists_url":"https://api.github.com/users/solongordon/gists{/gist_id}","starred_url":"https://api.github.com/users/solongordon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/solongordon/subscriptions","organizations_url":"https://api.github.com/users/solongordon/orgs","repos_url":"https://api.github.com/users/solongordon/repos","events_url":"https://api.github.com/users/solongordon/events{/privacy}","received_events_url":"https://api.github.com/users/solongordon/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-03-01T19:17:16Z","updated_at":"2018-03-05T18:42:51Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/23278","html_url":"https://github.com/cockroachdb/cockroach/pull/23278","diff_url":"https://github.com/cockroachdb/cockroach/pull/23278.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/23278.patch"},"body":"Our Sentry reports now include an anonymized version of the relevant SQL\r\nstatement if it is set in the context, and I modified connExecutor to\r\nadd the statement to the context whenever curStmt is set. This means\r\nthat \"unexpected leftover bytes\" reports now include the statement\r\nagain. (The statement stopped being reported when we changed that from a\r\npanic to a warning in 91ed508.)\r\n\r\nFixes #22865\r\n\r\nRelease note: None"},"comment":{"url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments/370520268","html_url":"https://github.com/cockroachdb/cockroach/pull/23278#issuecomment-370520268","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/23278","id":370520268,"user":{"login":"andreimatei","id":377201,"avatar_url":"https://avatars1.githubusercontent.com/u/377201?v=4","gravatar_id":"","url":"https://api.github.com/users/andreimatei","html_url":"https://github.com/andreimatei","followers_url":"https://api.github.com/users/andreimatei/followers","following_url":"https://api.github.com/users/andreimatei/following{/other_user}","gists_url":"https://api.github.com/users/andreimatei/gists{/gist_id}","starred_url":"https://api.github.com/users/andreimatei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreimatei/subscriptions","organizations_url":"https://api.github.com/users/andreimatei/orgs","repos_url":"https://api.github.com/users/andreimatei/repos","events_url":"https://api.github.com/users/andreimatei/events{/privacy}","received_events_url":"https://api.github.com/users/andreimatei/received_events","type":"User","site_admin":false},"created_at":"2018-03-05T18:42:51Z","updated_at":"2018-03-05T18:42:51Z","author_association":"OWNER","body":"\n\n\n\nReview status: 0 of 2 files reviewed at latest revision, 5 unresolved discussions, all commit checks successful.\n\n---\n\n*[pkg/sql/conn_executor.go, line 505 at r1](https://reviewable.io:443/reviews/cockroachdb/cockroach/23278#-L6Xzwnzd_f--zdjmOgq:-L6rT1Qwrki1frpFQMBG:b-bhramp) ([raw file](https://github.com/cockroachdb/cockroach/blob/32de3bcad975a5fd6bbf28fd9ebf40ba5beb4fe1/pkg/sql/conn_executor.go#L505)):*\n<details><summary><i>Previously, solongordon wrote…</i></summary><blockquote>\n\nI remember now that this doesn't work because the context passed to `execStmt` isn't the one which is used to stop the BytesMonitor:\nhttps://github.com/cockroachdb/cockroach/blob/3e28ade818825d6aac302840864925c0e106166b/pkg/sql/txn_state.go#L217-L218\n\nI'll look for another solution though since it's clear that mutating `ex.state.Ctx` is no good.\n</blockquote></details>\n\nIf you want, I'll be in the office tomorrow and we can talk about things. I have a bunch of context management stuff paged in, so I'm probably a good person to talk about it with.\n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/cockroachdb/cockroach/23278)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"andreimatei"}}