{"action":"created","issue":{"url":"https://api.github.com/repos/cloudfoundry/bosh/issues/2077","repository_url":"https://api.github.com/repos/cloudfoundry/bosh","labels_url":"https://api.github.com/repos/cloudfoundry/bosh/issues/2077/labels{/name}","comments_url":"https://api.github.com/repos/cloudfoundry/bosh/issues/2077/comments","events_url":"https://api.github.com/repos/cloudfoundry/bosh/issues/2077/events","html_url":"https://github.com/cloudfoundry/bosh/pull/2077","id":377107721,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MTQ5ODQ4","number":2077,"title":"custom tags may be attached to DataDog healthmonitor metrics","user":{"login":"rosenhouse","id":4128521,"node_id":"MDQ6VXNlcjQxMjg1MjE=","avatar_url":"https://avatars0.githubusercontent.com/u/4128521?v=4","gravatar_id":"","url":"https://api.github.com/users/rosenhouse","html_url":"https://github.com/rosenhouse","followers_url":"https://api.github.com/users/rosenhouse/followers","following_url":"https://api.github.com/users/rosenhouse/following{/other_user}","gists_url":"https://api.github.com/users/rosenhouse/gists{/gist_id}","starred_url":"https://api.github.com/users/rosenhouse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rosenhouse/subscriptions","organizations_url":"https://api.github.com/users/rosenhouse/orgs","repos_url":"https://api.github.com/users/rosenhouse/repos","events_url":"https://api.github.com/users/rosenhouse/events{/privacy}","received_events_url":"https://api.github.com/users/rosenhouse/received_events","type":"User","site_admin":false},"labels":[{"id":1010871347,"node_id":"MDU6TGFiZWwxMDEwODcxMzQ3","url":"https://api.github.com/repos/cloudfoundry/bosh/labels/unscheduled","name":"unscheduled","color":"D9D9D9","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-11-04T00:36:18Z","updated_at":"2018-11-21T01:07:34Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/cloudfoundry/bosh/pulls/2077","html_url":"https://github.com/cloudfoundry/bosh/pull/2077","diff_url":"https://github.com/cloudfoundry/bosh/pull/2077.diff","patch_url":"https://github.com/cloudfoundry/bosh/pull/2077.patch"},"body":"### What is this change about?\r\n\r\nDataDog allows tags to be attached to metrics.  BOSH healthmonitor attaches some tags, e.g. the deployment that originated the metric.  This is great.\r\n\r\nBut if you've got multiple directors, each with similar-looking deployments, all forwarding metrics to the same DataDog account, then all those metrics get mixed together: There isn't a straightforward way to distinguish metrics based on the originating director.  So, for example, it is tough to make a dashboard showing metrics from only one director, or to compare the same metrics across different directors.\r\n\r\nThis change allows an operator to set custom tags on the director, which get set on all metrics that the director emits.\r\n\r\nThis way, you can set different tags on different directors, and thus distinguish between those directors in your datadog dashboards.\r\n\r\n### Please provide contextual information.\r\n\r\nWe've got [this story](https://www.pivotaltracker.com/story/show/161104272).  The only way we see to make it work today is to discover the director's `cid` value after it is deployed, and then populate our datadog templates with that dynamically-generated value.  The `cid` changes on every re-deploy of the director (which our CI pipelines do every night).   So that means we'd need to update our datadog templates after every deploy.  Not great.\r\n\r\n\r\n### What tests have you run against this PR?\r\n\r\n```\r\ncd src\r\nbundle exec rspec ../spec\r\ncd bosh-monitor\r\nbundle exec rspec\r\n```\r\n\r\n### How should this change be described in bosh release notes?\r\n\r\nMaybe the commit message?\r\n\r\n> Custom tags may be attached to DataDog healthmonitor metrics\r\n\r\n\r\n### Does this PR introduce a breaking change?\r\n\r\nNo.\r\n"},"comment":{"url":"https://api.github.com/repos/cloudfoundry/bosh/issues/comments/440490304","html_url":"https://github.com/cloudfoundry/bosh/pull/2077#issuecomment-440490304","issue_url":"https://api.github.com/repos/cloudfoundry/bosh/issues/2077","id":440490304,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MDQ5MDMwNA==","user":{"login":"dpb587-pivotal","id":16127344,"node_id":"MDQ6VXNlcjE2MTI3MzQ0","avatar_url":"https://avatars2.githubusercontent.com/u/16127344?v=4","gravatar_id":"","url":"https://api.github.com/users/dpb587-pivotal","html_url":"https://github.com/dpb587-pivotal","followers_url":"https://api.github.com/users/dpb587-pivotal/followers","following_url":"https://api.github.com/users/dpb587-pivotal/following{/other_user}","gists_url":"https://api.github.com/users/dpb587-pivotal/gists{/gist_id}","starred_url":"https://api.github.com/users/dpb587-pivotal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dpb587-pivotal/subscriptions","organizations_url":"https://api.github.com/users/dpb587-pivotal/orgs","repos_url":"https://api.github.com/users/dpb587-pivotal/repos","events_url":"https://api.github.com/users/dpb587-pivotal/events{/privacy}","received_events_url":"https://api.github.com/users/dpb587-pivotal/received_events","type":"User","site_admin":false},"created_at":"2018-11-21T01:07:34Z","updated_at":"2018-11-21T01:07:34Z","author_association":"MEMBER","body":"I think this pull request makes sense. I like the hash syntax with support for more than just an env/landscape name in it.\r\n\r\nSome historical, related requests around this sort of functionality (I don't they should block a merge of this):\r\n\r\n * forward deployment-level tags thru these plugins\r\n * a shared health monitor tags property which applies to all plugins\r\n\r\n@mfine30 this seems like a fairly cheap thing for us to merge/prioritize."}}
{"actor":{"display_login":"dpb587-pivotal"}}