{"action":"created","issue":{"url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/4508","repository_url":"https://api.github.com/repos/FreeRDP/FreeRDP","labels_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/4508/labels{/name}","comments_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/4508/comments","events_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/4508/events","html_url":"https://github.com/FreeRDP/FreeRDP/pull/4508","id":307334961,"number":4508,"title":"Fix ccache support","user":{"login":"h3xx","id":615684,"avatar_url":"https://avatars0.githubusercontent.com/u/615684?v=4","gravatar_id":"","url":"https://api.github.com/users/h3xx","html_url":"https://github.com/h3xx","followers_url":"https://api.github.com/users/h3xx/followers","following_url":"https://api.github.com/users/h3xx/following{/other_user}","gists_url":"https://api.github.com/users/h3xx/gists{/gist_id}","starred_url":"https://api.github.com/users/h3xx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/h3xx/subscriptions","organizations_url":"https://api.github.com/users/h3xx/orgs","repos_url":"https://api.github.com/users/h3xx/repos","events_url":"https://api.github.com/users/h3xx/events{/privacy}","received_events_url":"https://api.github.com/users/h3xx/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-03-21T17:01:53Z","updated_at":"2018-03-21T17:36:54Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/4508","html_url":"https://github.com/FreeRDP/FreeRDP/pull/4508","diff_url":"https://github.com/FreeRDP/FreeRDP/pull/4508.diff","patch_url":"https://github.com/FreeRDP/FreeRDP/pull/4508.patch"},"body":"Setting the compiler launcher to \"ccache\" is the recommended way of enabling ccache for the build.\r\n\r\nIf cmake is run with it defined, it causes an error when ccache tries to run:\r\n\r\n    ccache: error: Recursive invocation (the name of the ccache binary must be \"ccache\")\r\n\r\nThis was because the compiler was getting invoked as `ccache ccache [COMPILER]`\r\n\r\nReproduced by running cmake:\r\n\r\n    mkdir BUILD && cd BUILD &&\r\n    cmake \\\r\n        -DCMAKE_C_COMPILER_LAUNCHER=ccache \\\r\n        -DCMAKE_CXX_COMPILER_LAUNCHER=ccache \\\r\n        ..\r\n    make\r\n\r\nThis results in the following error:\r\n\r\n    $ make\r\n    Scanning dependencies of target winpr\r\n    [  0%] Building C object winpr/libwinpr/CMakeFiles/winpr.dir/synch/address.c.o\r\n    ccache: error: Recursive invocation (the name of the ccache binary must be \"ccache\")\r\n    make[2]: *** [winpr/libwinpr/CMakeFiles/winpr.dir/build.make:63: winpr/libwinpr/CMakeFiles/winpr.dir/synch/address.c.o] Error 1\r\n    make[1]: *** [CMakeFiles/Makefile2:250: winpr/libwinpr/CMakeFiles/winpr.dir/all] Error 2\r\n    make: *** [Makefile:152: all] Error 2\r\n\r\n(This patch also takes into account the fact there might be ccache alternatives in the future, or even crazy custom settings like `distcc` & `ccache` somehow working together via the compiler launcher)"},"comment":{"url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/comments/375031612","html_url":"https://github.com/FreeRDP/FreeRDP/pull/4508#issuecomment-375031612","issue_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/4508","id":375031612,"user":{"login":"akallabeth","id":3472254,"avatar_url":"https://avatars2.githubusercontent.com/u/3472254?v=4","gravatar_id":"","url":"https://api.github.com/users/akallabeth","html_url":"https://github.com/akallabeth","followers_url":"https://api.github.com/users/akallabeth/followers","following_url":"https://api.github.com/users/akallabeth/following{/other_user}","gists_url":"https://api.github.com/users/akallabeth/gists{/gist_id}","starred_url":"https://api.github.com/users/akallabeth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akallabeth/subscriptions","organizations_url":"https://api.github.com/users/akallabeth/orgs","repos_url":"https://api.github.com/users/akallabeth/repos","events_url":"https://api.github.com/users/akallabeth/events{/privacy}","received_events_url":"https://api.github.com/users/akallabeth/received_events","type":"User","site_admin":false},"created_at":"2018-03-21T17:36:54Z","updated_at":"2018-03-21T17:36:54Z","author_association":"CONTRIBUTOR","body":"@freerdp-bot test\r\n@h3xx Do you have a link at hand, can not find the proper documentation for the variable in the `CMake` docs\r\nAll I can find are mailing list entries that are at most 2 years old, so this most likely needs some compatibility for `CMake-2.8` versions"}}
{"actor":{"display_login":"akallabeth"}}