{"action":"created","comment":{"url":"https://api.github.com/repos/zcash/zcash/pulls/comments/186653849","pull_request_review_id":118272062,"id":186653849,"diff_hunk":"@@ -1099,6 +1103,22 @@ uint256 GetJoinSplitsHash(const CTransaction& txTo) {\n     return ss.GetHash();\n }\n \n+uint256 GetShieldedSpendsHash(const CTransaction& txTo) {\n+    CBLAKE2bWriter ss(SER_GETHASH, 0, ZCASH_SHIELDED_SPENDS_HASH_PERSONALIZATION);\n+    for (unsigned int n = 0; n < txTo.vShieldedSpend.size(); n++) {\n+        ss << txTo.vShieldedSpend[n];","path":"src/script/interpreter.cpp","position":18,"original_position":18,"commit_id":"33eadbe4e954ca561863080f2beeb311cb654dee","original_commit_id":"33eadbe4e954ca561863080f2beeb311cb654dee","user":{"login":"ebfull","id":3794471,"avatar_url":"https://avatars1.githubusercontent.com/u/3794471?v=4","gravatar_id":"","url":"https://api.github.com/users/ebfull","html_url":"https://github.com/ebfull","followers_url":"https://api.github.com/users/ebfull/followers","following_url":"https://api.github.com/users/ebfull/following{/other_user}","gists_url":"https://api.github.com/users/ebfull/gists{/gist_id}","starred_url":"https://api.github.com/users/ebfull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebfull/subscriptions","organizations_url":"https://api.github.com/users/ebfull/orgs","repos_url":"https://api.github.com/users/ebfull/repos","events_url":"https://api.github.com/users/ebfull/events{/privacy}","received_events_url":"https://api.github.com/users/ebfull/received_events","type":"User","site_admin":false},"body":"I'm confused... this seems to cover the signature inside the shielded spend. That isn't right, is it?","created_at":"2018-05-08T08:35:10Z","updated_at":"2018-05-08T08:35:13Z","html_url":"https://github.com/zcash/zcash/pull/3233#discussion_r186653849","pull_request_url":"https://api.github.com/repos/zcash/zcash/pulls/3233","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/zcash/zcash/pulls/comments/186653849"},"html":{"href":"https://github.com/zcash/zcash/pull/3233#discussion_r186653849"},"pull_request":{"href":"https://api.github.com/repos/zcash/zcash/pulls/3233"}}},"pull_request":{"url":"https://api.github.com/repos/zcash/zcash/pulls/3233","id":185296896,"html_url":"https://github.com/zcash/zcash/pull/3233","diff_url":"https://github.com/zcash/zcash/pull/3233.diff","patch_url":"https://github.com/zcash/zcash/pull/3233.patch","issue_url":"https://api.github.com/repos/zcash/zcash/issues/3233","number":3233,"state":"open","locked":false,"title":"ZIP 243: Sapling SignatureHash","user":{"login":"str4d","id":4993799,"avatar_url":"https://avatars0.githubusercontent.com/u/4993799?v=4","gravatar_id":"","url":"https://api.github.com/users/str4d","html_url":"https://github.com/str4d","followers_url":"https://api.github.com/users/str4d/followers","following_url":"https://api.github.com/users/str4d/following{/other_user}","gists_url":"https://api.github.com/users/str4d/gists{/gist_id}","starred_url":"https://api.github.com/users/str4d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/str4d/subscriptions","organizations_url":"https://api.github.com/users/str4d/orgs","repos_url":"https://api.github.com/users/str4d/repos","events_url":"https://api.github.com/users/str4d/events{/privacy}","received_events_url":"https://api.github.com/users/str4d/received_events","type":"User","site_admin":false},"body":"Closes #3164.","created_at":"2018-05-01T22:58:23Z","updated_at":"2018-05-08T08:35:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"decca7802407ac7215045b5814b6fc1c2f9d30d0","assignee":null,"assignees":[],"requested_reviewers":[{"login":"gtank","id":622063,"avatar_url":"https://avatars2.githubusercontent.com/u/622063?v=4","gravatar_id":"","url":"https://api.github.com/users/gtank","html_url":"https://github.com/gtank","followers_url":"https://api.github.com/users/gtank/followers","following_url":"https://api.github.com/users/gtank/following{/other_user}","gists_url":"https://api.github.com/users/gtank/gists{/gist_id}","starred_url":"https://api.github.com/users/gtank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gtank/subscriptions","organizations_url":"https://api.github.com/users/gtank/orgs","repos_url":"https://api.github.com/users/gtank/repos","events_url":"https://api.github.com/users/gtank/events{/privacy}","received_events_url":"https://api.github.com/users/gtank/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":179182764,"url":"https://api.github.com/repos/zcash/zcash/labels/consensus%20protocol","name":"consensus protocol","color":"f766c7","default":false}],"milestone":{"url":"https://api.github.com/repos/zcash/zcash/milestones/71","html_url":"https://github.com/zcash/zcash/milestone/71","labels_url":"https://api.github.com/repos/zcash/zcash/milestones/71/labels","id":3101045,"number":71,"title":"v1.1.1","description":"","creator":{"login":"str4d","id":4993799,"avatar_url":"https://avatars0.githubusercontent.com/u/4993799?v=4","gravatar_id":"","url":"https://api.github.com/users/str4d","html_url":"https://github.com/str4d","followers_url":"https://api.github.com/users/str4d/followers","following_url":"https://api.github.com/users/str4d/following{/other_user}","gists_url":"https://api.github.com/users/str4d/gists{/gist_id}","starred_url":"https://api.github.com/users/str4d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/str4d/subscriptions","organizations_url":"https://api.github.com/users/str4d/orgs","repos_url":"https://api.github.com/users/str4d/repos","events_url":"https://api.github.com/users/str4d/events{/privacy}","received_events_url":"https://api.github.com/users/str4d/received_events","type":"User","site_admin":false},"open_issues":57,"closed_issues":46,"state":"open","created_at":"2018-02-08T20:36:49Z","updated_at":"2018-05-08T05:12:20Z","due_on":"2018-05-21T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/zcash/zcash/pulls/3233/commits","review_comments_url":"https://api.github.com/repos/zcash/zcash/pulls/3233/comments","review_comment_url":"https://api.github.com/repos/zcash/zcash/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zcash/zcash/issues/3233/comments","statuses_url":"https://api.github.com/repos/zcash/zcash/statuses/33eadbe4e954ca561863080f2beeb311cb654dee","head":{"label":"str4d:3164-sapling-sighash","ref":"3164-sapling-sighash","sha":"33eadbe4e954ca561863080f2beeb311cb654dee","user":{"login":"str4d","id":4993799,"avatar_url":"https://avatars0.githubusercontent.com/u/4993799?v=4","gravatar_id":"","url":"https://api.github.com/users/str4d","html_url":"https://github.com/str4d","followers_url":"https://api.github.com/users/str4d/followers","following_url":"https://api.github.com/users/str4d/following{/other_user}","gists_url":"https://api.github.com/users/str4d/gists{/gist_id}","starred_url":"https://api.github.com/users/str4d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/str4d/subscriptions","organizations_url":"https://api.github.com/users/str4d/orgs","repos_url":"https://api.github.com/users/str4d/repos","events_url":"https://api.github.com/users/str4d/events{/privacy}","received_events_url":"https://api.github.com/users/str4d/received_events","type":"User","site_admin":false},"repo":{"id":52462432,"name":"zcash","full_name":"str4d/zcash","owner":{"login":"str4d","id":4993799,"avatar_url":"https://avatars0.githubusercontent.com/u/4993799?v=4","gravatar_id":"","url":"https://api.github.com/users/str4d","html_url":"https://github.com/str4d","followers_url":"https://api.github.com/users/str4d/followers","following_url":"https://api.github.com/users/str4d/following{/other_user}","gists_url":"https://api.github.com/users/str4d/gists{/gist_id}","starred_url":"https://api.github.com/users/str4d/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/str4d/subscriptions","organizations_url":"https://api.github.com/users/str4d/orgs","repos_url":"https://api.github.com/users/str4d/repos","events_url":"https://api.github.com/users/str4d/events{/privacy}","received_events_url":"https://api.github.com/users/str4d/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/str4d/zcash","description":"zcash","fork":true,"url":"https://api.github.com/repos/str4d/zcash","forks_url":"https://api.github.com/repos/str4d/zcash/forks","keys_url":"https://api.github.com/repos/str4d/zcash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/str4d/zcash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/str4d/zcash/teams","hooks_url":"https://api.github.com/repos/str4d/zcash/hooks","issue_events_url":"https://api.github.com/repos/str4d/zcash/issues/events{/number}","events_url":"https://api.github.com/repos/str4d/zcash/events","assignees_url":"https://api.github.com/repos/str4d/zcash/assignees{/user}","branches_url":"https://api.github.com/repos/str4d/zcash/branches{/branch}","tags_url":"https://api.github.com/repos/str4d/zcash/tags","blobs_url":"https://api.github.com/repos/str4d/zcash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/str4d/zcash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/str4d/zcash/git/refs{/sha}","trees_url":"https://api.github.com/repos/str4d/zcash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/str4d/zcash/statuses/{sha}","languages_url":"https://api.github.com/repos/str4d/zcash/languages","stargazers_url":"https://api.github.com/repos/str4d/zcash/stargazers","contributors_url":"https://api.github.com/repos/str4d/zcash/contributors","subscribers_url":"https://api.github.com/repos/str4d/zcash/subscribers","subscription_url":"https://api.github.com/repos/str4d/zcash/subscription","commits_url":"https://api.github.com/repos/str4d/zcash/commits{/sha}","git_commits_url":"https://api.github.com/repos/str4d/zcash/git/commits{/sha}","comments_url":"https://api.github.com/repos/str4d/zcash/comments{/number}","issue_comment_url":"https://api.github.com/repos/str4d/zcash/issues/comments{/number}","contents_url":"https://api.github.com/repos/str4d/zcash/contents/{+path}","compare_url":"https://api.github.com/repos/str4d/zcash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/str4d/zcash/merges","archive_url":"https://api.github.com/repos/str4d/zcash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/str4d/zcash/downloads","issues_url":"https://api.github.com/repos/str4d/zcash/issues{/number}","pulls_url":"https://api.github.com/repos/str4d/zcash/pulls{/number}","milestones_url":"https://api.github.com/repos/str4d/zcash/milestones{/number}","notifications_url":"https://api.github.com/repos/str4d/zcash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/str4d/zcash/labels{/name}","releases_url":"https://api.github.com/repos/str4d/zcash/releases{/id}","deployments_url":"https://api.github.com/repos/str4d/zcash/deployments","created_at":"2016-02-24T17:50:40Z","updated_at":"2018-04-05T14:40:00Z","pushed_at":"2018-05-08T08:12:03Z","git_url":"git://github.com/str4d/zcash.git","ssh_url":"git@github.com:str4d/zcash.git","clone_url":"https://github.com/str4d/zcash.git","svn_url":"https://github.com/str4d/zcash","homepage":"https://z.cash/","size":71942,"stargazers_count":30,"watchers_count":30,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":18,"open_issues":0,"watchers":30,"default_branch":"master"}},"base":{"label":"zcash:master","ref":"master","sha":"53fa6f131545a464b6aaf19500694946508270b3","user":{"login":"zcash","id":16122764,"avatar_url":"https://avatars2.githubusercontent.com/u/16122764?v=4","gravatar_id":"","url":"https://api.github.com/users/zcash","html_url":"https://github.com/zcash","followers_url":"https://api.github.com/users/zcash/followers","following_url":"https://api.github.com/users/zcash/following{/other_user}","gists_url":"https://api.github.com/users/zcash/gists{/gist_id}","starred_url":"https://api.github.com/users/zcash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zcash/subscriptions","organizations_url":"https://api.github.com/users/zcash/orgs","repos_url":"https://api.github.com/users/zcash/repos","events_url":"https://api.github.com/users/zcash/events{/privacy}","received_events_url":"https://api.github.com/users/zcash/received_events","type":"Organization","site_admin":false},"repo":{"id":26987049,"name":"zcash","full_name":"zcash/zcash","owner":{"login":"zcash","id":16122764,"avatar_url":"https://avatars2.githubusercontent.com/u/16122764?v=4","gravatar_id":"","url":"https://api.github.com/users/zcash","html_url":"https://github.com/zcash","followers_url":"https://api.github.com/users/zcash/followers","following_url":"https://api.github.com/users/zcash/following{/other_user}","gists_url":"https://api.github.com/users/zcash/gists{/gist_id}","starred_url":"https://api.github.com/users/zcash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zcash/subscriptions","organizations_url":"https://api.github.com/users/zcash/orgs","repos_url":"https://api.github.com/users/zcash/repos","events_url":"https://api.github.com/users/zcash/events{/privacy}","received_events_url":"https://api.github.com/users/zcash/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zcash/zcash","description":"Zcash - Internet Money","fork":false,"url":"https://api.github.com/repos/zcash/zcash","forks_url":"https://api.github.com/repos/zcash/zcash/forks","keys_url":"https://api.github.com/repos/zcash/zcash/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zcash/zcash/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zcash/zcash/teams","hooks_url":"https://api.github.com/repos/zcash/zcash/hooks","issue_events_url":"https://api.github.com/repos/zcash/zcash/issues/events{/number}","events_url":"https://api.github.com/repos/zcash/zcash/events","assignees_url":"https://api.github.com/repos/zcash/zcash/assignees{/user}","branches_url":"https://api.github.com/repos/zcash/zcash/branches{/branch}","tags_url":"https://api.github.com/repos/zcash/zcash/tags","blobs_url":"https://api.github.com/repos/zcash/zcash/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zcash/zcash/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zcash/zcash/git/refs{/sha}","trees_url":"https://api.github.com/repos/zcash/zcash/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zcash/zcash/statuses/{sha}","languages_url":"https://api.github.com/repos/zcash/zcash/languages","stargazers_url":"https://api.github.com/repos/zcash/zcash/stargazers","contributors_url":"https://api.github.com/repos/zcash/zcash/contributors","subscribers_url":"https://api.github.com/repos/zcash/zcash/subscribers","subscription_url":"https://api.github.com/repos/zcash/zcash/subscription","commits_url":"https://api.github.com/repos/zcash/zcash/commits{/sha}","git_commits_url":"https://api.github.com/repos/zcash/zcash/git/commits{/sha}","comments_url":"https://api.github.com/repos/zcash/zcash/comments{/number}","issue_comment_url":"https://api.github.com/repos/zcash/zcash/issues/comments{/number}","contents_url":"https://api.github.com/repos/zcash/zcash/contents/{+path}","compare_url":"https://api.github.com/repos/zcash/zcash/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zcash/zcash/merges","archive_url":"https://api.github.com/repos/zcash/zcash/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zcash/zcash/downloads","issues_url":"https://api.github.com/repos/zcash/zcash/issues{/number}","pulls_url":"https://api.github.com/repos/zcash/zcash/pulls{/number}","milestones_url":"https://api.github.com/repos/zcash/zcash/milestones{/number}","notifications_url":"https://api.github.com/repos/zcash/zcash/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zcash/zcash/labels{/name}","releases_url":"https://api.github.com/repos/zcash/zcash/releases{/id}","deployments_url":"https://api.github.com/repos/zcash/zcash/deployments","created_at":"2014-11-22T03:13:10Z","updated_at":"2018-05-08T07:53:38Z","pushed_at":"2018-05-08T08:18:11Z","git_url":"git://github.com/zcash/zcash.git","ssh_url":"git@github.com:zcash/zcash.git","clone_url":"https://github.com/zcash/zcash.git","svn_url":"https://github.com/zcash/zcash","homepage":"https://z.cash/","size":60609,"stargazers_count":3660,"watchers_count":3660,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1187,"mirror_url":null,"archived":false,"open_issues_count":786,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1187,"open_issues":786,"watchers":3660,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zcash/zcash/pulls/3233"},"html":{"href":"https://github.com/zcash/zcash/pull/3233"},"issue":{"href":"https://api.github.com/repos/zcash/zcash/issues/3233"},"comments":{"href":"https://api.github.com/repos/zcash/zcash/issues/3233/comments"},"review_comments":{"href":"https://api.github.com/repos/zcash/zcash/pulls/3233/comments"},"review_comment":{"href":"https://api.github.com/repos/zcash/zcash/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zcash/zcash/pulls/3233/commits"},"statuses":{"href":"https://api.github.com/repos/zcash/zcash/statuses/33eadbe4e954ca561863080f2beeb311cb654dee"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ebfull"}}