{"action":"created","issue":{"url":"https://api.github.com/repos/trilinos/Trilinos/issues/3381","repository_url":"https://api.github.com/repos/trilinos/Trilinos","labels_url":"https://api.github.com/repos/trilinos/Trilinos/issues/3381/labels{/name}","comments_url":"https://api.github.com/repos/trilinos/Trilinos/issues/3381/comments","events_url":"https://api.github.com/repos/trilinos/Trilinos/issues/3381/events","html_url":"https://github.com/trilinos/Trilinos/pull/3381","id":356466284,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNzE4OTA5","number":3381,"title":"EpetraExt: Recursively check for existing HDF5 groups","user":{"login":"Sbte","id":454803,"node_id":"MDQ6VXNlcjQ1NDgwMw==","avatar_url":"https://avatars3.githubusercontent.com/u/454803?v=4","gravatar_id":"","url":"https://api.github.com/users/Sbte","html_url":"https://github.com/Sbte","followers_url":"https://api.github.com/users/Sbte/followers","following_url":"https://api.github.com/users/Sbte/following{/other_user}","gists_url":"https://api.github.com/users/Sbte/gists{/gist_id}","starred_url":"https://api.github.com/users/Sbte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Sbte/subscriptions","organizations_url":"https://api.github.com/users/Sbte/orgs","repos_url":"https://api.github.com/users/Sbte/repos","events_url":"https://api.github.com/users/Sbte/events{/privacy}","received_events_url":"https://api.github.com/users/Sbte/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-03T11:24:58Z","updated_at":"2018-09-03T11:28:55Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/trilinos/Trilinos/pulls/3381","html_url":"https://github.com/trilinos/Trilinos/pull/3381","diff_url":"https://github.com/trilinos/Trilinos/pull/3381.diff","patch_url":"https://github.com/trilinos/Trilinos/pull/3381.patch"},"body":"@trilinos/EpetraExt\r\n\r\n## Description\r\nNested groups are not handled correctly in EpetraExt_HDF5. These groups are denoted by `/Group A/Group B/Group C/data`. Writing and reading from these groups actually works fine, just the `IsContained` method, which only does some safety checks, does not handle them correctly.\r\n\r\nI also added a missing const while I was working on the code anyway.\r\n\r\n## Motivation and Context\r\nReason why one might need this is when writing a data structure which contains an array of `Epetra_Vectors`. Doing this without nested groups would look like a mess since all data is sorted alphabetically.\r\n\r\n## How Has This Been Tested?\r\nSince there are appear to be no unit tests for EpetraExt_HDF5, I tested this only with my own code.\r\n\r\n## Checklist\r\n\r\n- [ ] My commit messages mention the appropriate GitHub issue numbers.\r\n- [x] My code follows the code style of the affected package(s).\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [x] I have read the [code contribution guidelines](../blob/master/CONTRIBUTING.md) for this project.\r\n- [ ] I have added tests to cover my changes.\r\n- [ ] All new and existing tests passed.\r\n- [x] No new compiler warnings were introduced.\r\n- [ ] These changes break backwards compatibility.\r\n"},"comment":{"url":"https://api.github.com/repos/trilinos/Trilinos/issues/comments/418087317","html_url":"https://github.com/trilinos/Trilinos/pull/3381#issuecomment-418087317","issue_url":"https://api.github.com/repos/trilinos/Trilinos/issues/3381","id":418087317,"node_id":"MDEyOklzc3VlQ29tbWVudDQxODA4NzMxNw==","user":{"login":"trilinos-autotester","id":26070492,"node_id":"MDQ6VXNlcjI2MDcwNDky","avatar_url":"https://avatars2.githubusercontent.com/u/26070492?v=4","gravatar_id":"","url":"https://api.github.com/users/trilinos-autotester","html_url":"https://github.com/trilinos-autotester","followers_url":"https://api.github.com/users/trilinos-autotester/followers","following_url":"https://api.github.com/users/trilinos-autotester/following{/other_user}","gists_url":"https://api.github.com/users/trilinos-autotester/gists{/gist_id}","starred_url":"https://api.github.com/users/trilinos-autotester/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trilinos-autotester/subscriptions","organizations_url":"https://api.github.com/users/trilinos-autotester/orgs","repos_url":"https://api.github.com/users/trilinos-autotester/repos","events_url":"https://api.github.com/users/trilinos-autotester/events{/privacy}","received_events_url":"https://api.github.com/users/trilinos-autotester/received_events","type":"User","site_admin":false},"created_at":"2018-09-03T11:28:55Z","updated_at":"2018-09-03T11:28:55Z","author_association":"CONTRIBUTOR","body":"Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging\n           WARNING: NO REVIEWERS HAVE BEEN REQUESTED FOR THIS PULL REQUEST!"}}
{"actor":{"display_login":"trilinos-autotester"}}