{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq-providers-amazon/issues/434","repository_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-amazon","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-amazon/issues/434/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-amazon/issues/434/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-amazon/issues/434/events","html_url":"https://github.com/ManageIQ/manageiq-providers-amazon/pull/434","id":315615871,"number":434,"title":"Add specs to confirm aws-sdk-core monkey patch is still valid","user":{"login":"NickLaMuro","id":314014,"avatar_url":"https://avatars0.githubusercontent.com/u/314014?v=4","gravatar_id":"","url":"https://api.github.com/users/NickLaMuro","html_url":"https://github.com/NickLaMuro","followers_url":"https://api.github.com/users/NickLaMuro/followers","following_url":"https://api.github.com/users/NickLaMuro/following{/other_user}","gists_url":"https://api.github.com/users/NickLaMuro/gists{/gist_id}","starred_url":"https://api.github.com/users/NickLaMuro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickLaMuro/subscriptions","organizations_url":"https://api.github.com/users/NickLaMuro/orgs","repos_url":"https://api.github.com/users/NickLaMuro/repos","events_url":"https://api.github.com/users/NickLaMuro/events{/privacy}","received_events_url":"https://api.github.com/users/NickLaMuro/received_events","type":"User","site_admin":false},"labels":[{"id":403364735,"url":"https://api.github.com/repos/ManageIQ/manageiq-providers-amazon/labels/test","name":"test","color":"bfe5bf","default":false}],"state":"closed","locked":false,"assignee":{"login":"Fryguy","id":52120,"avatar_url":"https://avatars3.githubusercontent.com/u/52120?v=4","gravatar_id":"","url":"https://api.github.com/users/Fryguy","html_url":"https://github.com/Fryguy","followers_url":"https://api.github.com/users/Fryguy/followers","following_url":"https://api.github.com/users/Fryguy/following{/other_user}","gists_url":"https://api.github.com/users/Fryguy/gists{/gist_id}","starred_url":"https://api.github.com/users/Fryguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fryguy/subscriptions","organizations_url":"https://api.github.com/users/Fryguy/orgs","repos_url":"https://api.github.com/users/Fryguy/repos","events_url":"https://api.github.com/users/Fryguy/events{/privacy}","received_events_url":"https://api.github.com/users/Fryguy/received_events","type":"User","site_admin":false},"assignees":[{"login":"Fryguy","id":52120,"avatar_url":"https://avatars3.githubusercontent.com/u/52120?v=4","gravatar_id":"","url":"https://api.github.com/users/Fryguy","html_url":"https://github.com/Fryguy","followers_url":"https://api.github.com/users/Fryguy/followers","following_url":"https://api.github.com/users/Fryguy/following{/other_user}","gists_url":"https://api.github.com/users/Fryguy/gists{/gist_id}","starred_url":"https://api.github.com/users/Fryguy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Fryguy/subscriptions","organizations_url":"https://api.github.com/users/Fryguy/orgs","repos_url":"https://api.github.com/users/Fryguy/repos","events_url":"https://api.github.com/users/Fryguy/events{/privacy}","received_events_url":"https://api.github.com/users/Fryguy/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/ManageIQ/manageiq-providers-amazon/milestones/34","html_url":"https://github.com/ManageIQ/manageiq-providers-amazon/milestone/34","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-amazon/milestones/34/labels","id":3364865,"number":34,"title":"Sprint 87 Ending Jun 4, 2018","description":null,"creator":{"login":"chessbyte","id":82161,"avatar_url":"https://avatars2.githubusercontent.com/u/82161?v=4","gravatar_id":"","url":"https://api.github.com/users/chessbyte","html_url":"https://github.com/chessbyte","followers_url":"https://api.github.com/users/chessbyte/followers","following_url":"https://api.github.com/users/chessbyte/following{/other_user}","gists_url":"https://api.github.com/users/chessbyte/gists{/gist_id}","starred_url":"https://api.github.com/users/chessbyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chessbyte/subscriptions","organizations_url":"https://api.github.com/users/chessbyte/orgs","repos_url":"https://api.github.com/users/chessbyte/repos","events_url":"https://api.github.com/users/chessbyte/events{/privacy}","received_events_url":"https://api.github.com/users/chessbyte/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":3,"state":"open","created_at":"2018-05-22T14:32:54Z","updated_at":"2018-05-24T15:23:55Z","due_on":"2018-06-04T07:00:00Z","closed_at":null},"comments":8,"created_at":"2018-04-18T19:41:48Z","updated_at":"2018-05-24T15:32:05Z","closed_at":"2018-05-24T15:23:40Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq-providers-amazon/pulls/434","html_url":"https://github.com/ManageIQ/manageiq-providers-amazon/pull/434","diff_url":"https://github.com/ManageIQ/manageiq-providers-amazon/pull/434.diff","patch_url":"https://github.com/ManageIQ/manageiq-providers-amazon/pull/434.patch"},"body":"This adds two specs to the repo to test this:\r\n\r\n* The first simply confirms the monkey patch is still valid.\r\n* The second confirms only the minimal amount of changes are necessary to make the patch.\r\n\r\nCompared to https://github.com/ManageIQ/manageiq-providers-amazon/pull/433 , this should only fail when changes are necessary, and not just when the version changes.\r\n\r\n\r\nLinks\r\n-----\r\n\r\n* Original Attempt:  https://github.com/ManageIQ/manageiq-providers-amazon/pull/433\r\n* Applicable for:    https://github.com/ManageIQ/manageiq-providers-amazon/pull/432\r\n* Upstream patch PR:  https://github.com/aws/aws-sdk-ruby/pull/1760"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq-providers-amazon/issues/comments/391758403","html_url":"https://github.com/ManageIQ/manageiq-providers-amazon/pull/434#issuecomment-391758403","issue_url":"https://api.github.com/repos/ManageIQ/manageiq-providers-amazon/issues/434","id":391758403,"user":{"login":"NickLaMuro","id":314014,"avatar_url":"https://avatars0.githubusercontent.com/u/314014?v=4","gravatar_id":"","url":"https://api.github.com/users/NickLaMuro","html_url":"https://github.com/NickLaMuro","followers_url":"https://api.github.com/users/NickLaMuro/followers","following_url":"https://api.github.com/users/NickLaMuro/following{/other_user}","gists_url":"https://api.github.com/users/NickLaMuro/gists{/gist_id}","starred_url":"https://api.github.com/users/NickLaMuro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickLaMuro/subscriptions","organizations_url":"https://api.github.com/users/NickLaMuro/orgs","repos_url":"https://api.github.com/users/NickLaMuro/repos","events_url":"https://api.github.com/users/NickLaMuro/events{/privacy}","received_events_url":"https://api.github.com/users/NickLaMuro/received_events","type":"User","site_admin":false},"created_at":"2018-05-24T15:32:05Z","updated_at":"2018-05-24T15:32:05Z","author_association":"MEMBER","body":"@bronaghs I think since https://github.com/ManageIQ/manageiq-providers-amazon/pull/432 was, so I would be tempted to say \"yes\" as well, since if/when the changes to the aws-sdk get pushed, we may or may not make that change to the G branch, and having these tests would keep us from merging without removing this patch.\r\n\r\n* * *\r\n\r\nExtra info about the \"may or may not\" backport the `aws-sdk` changes when they are applied.\r\n\r\nThe current master of `aws-sdk-ruby` is on version 3.0.1 of the gem, and we are currently using `2.9.x`, so my guess is that we won't be upgrading the gem a major version as part of a patch release on the G release, and the change will only get into master.  That said, if I am wrong in that assumption, it might not hurt having these specs there just in case."}}
{"actor":{"display_login":"NickLaMuro"}}