{"action":"created","comment":{"url":"https://api.github.com/repos/stellar/go/pulls/comments/221022299","pull_request_review_id":159571383,"id":221022299,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTAyMjI5OQ==","diff_hunk":"@@ -95,7 +95,7 @@ func (base *Base) Execute(action interface{}) {\n \n \t\t\tselect {\n \t\t\tcase <-ctx.Done():\n-\t\t\t\tstream.Done()\n+\t\t\t\tstream.Done() // Call Done on the stream so that it doesn't send any more heartbeats.","path":"services/horizon/internal/actions/base.go","position":14,"original_position":14,"commit_id":"ff59e1707fca2c9122db784d9df6a183d4963735","original_commit_id":"6a8ddc8d0fc0b178377e3ad1cbafa9b425a6a0f0","user":{"login":"bartekn","id":464938,"node_id":"MDQ6VXNlcjQ2NDkzOA==","avatar_url":"https://avatars1.githubusercontent.com/u/464938?v=4","gravatar_id":"","url":"https://api.github.com/users/bartekn","html_url":"https://github.com/bartekn","followers_url":"https://api.github.com/users/bartekn/followers","following_url":"https://api.github.com/users/bartekn/following{/other_user}","gists_url":"https://api.github.com/users/bartekn/gists{/gist_id}","starred_url":"https://api.github.com/users/bartekn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartekn/subscriptions","organizations_url":"https://api.github.com/users/bartekn/orgs","repos_url":"https://api.github.com/users/bartekn/repos","events_url":"https://api.github.com/users/bartekn/events{/privacy}","received_events_url":"https://api.github.com/users/bartekn/received_events","type":"User","site_admin":false},"body":"Sorry my bad, somehow I thought that heartbeat routing checks `s.done` instead of `s.IsDone`. Need to check PRs earlier in a day 😉 .","created_at":"2018-09-27T18:04:00Z","updated_at":"2018-09-27T18:04:00Z","html_url":"https://github.com/stellar/go/pull/692#discussion_r221022299","pull_request_url":"https://api.github.com/repos/stellar/go/pulls/692","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/stellar/go/pulls/comments/221022299"},"html":{"href":"https://github.com/stellar/go/pull/692#discussion_r221022299"},"pull_request":{"href":"https://api.github.com/repos/stellar/go/pulls/692"}},"in_reply_to_id":221002481},"pull_request":{"url":"https://api.github.com/repos/stellar/go/pulls/692","id":218143852,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4MTQzODUy","html_url":"https://github.com/stellar/go/pull/692","diff_url":"https://github.com/stellar/go/pull/692.diff","patch_url":"https://github.com/stellar/go/pull/692.patch","issue_url":"https://api.github.com/repos/stellar/go/issues/692","number":692,"state":"open","locked":false,"title":"Add heartbeat to sse","user":{"login":"lechengfan","id":6279364,"node_id":"MDQ6VXNlcjYyNzkzNjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6279364?v=4","gravatar_id":"","url":"https://api.github.com/users/lechengfan","html_url":"https://github.com/lechengfan","followers_url":"https://api.github.com/users/lechengfan/followers","following_url":"https://api.github.com/users/lechengfan/following{/other_user}","gists_url":"https://api.github.com/users/lechengfan/gists{/gist_id}","starred_url":"https://api.github.com/users/lechengfan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lechengfan/subscriptions","organizations_url":"https://api.github.com/users/lechengfan/orgs","repos_url":"https://api.github.com/users/lechengfan/repos","events_url":"https://api.github.com/users/lechengfan/events{/privacy}","received_events_url":"https://api.github.com/users/lechengfan/received_events","type":"User","site_admin":false},"body":"- After merging in #691, we can add heartbeats to SSE\r\n- Same functionality as originally addressed in #678 ","created_at":"2018-09-25T22:59:26Z","updated_at":"2018-09-27T18:04:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"43b62fd385680d50712a452636a7127657f8f03f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":709066444,"node_id":"MDU6TGFiZWw3MDkwNjY0NDQ=","url":"https://api.github.com/repos/stellar/go/labels/horizon","name":"horizon","color":"1d76db","default":false}],"milestone":{"url":"https://api.github.com/repos/stellar/go/milestones/4","html_url":"https://github.com/stellar/go/milestone/4","labels_url":"https://api.github.com/repos/stellar/go/milestones/4/labels","id":3621614,"node_id":"MDk6TWlsZXN0b25lMzYyMTYxNA==","number":4,"title":"Horizon v0.15.0","description":"","creator":{"login":"bartekn","id":464938,"node_id":"MDQ6VXNlcjQ2NDkzOA==","avatar_url":"https://avatars1.githubusercontent.com/u/464938?v=4","gravatar_id":"","url":"https://api.github.com/users/bartekn","html_url":"https://github.com/bartekn","followers_url":"https://api.github.com/users/bartekn/followers","following_url":"https://api.github.com/users/bartekn/following{/other_user}","gists_url":"https://api.github.com/users/bartekn/gists{/gist_id}","starred_url":"https://api.github.com/users/bartekn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bartekn/subscriptions","organizations_url":"https://api.github.com/users/bartekn/orgs","repos_url":"https://api.github.com/users/bartekn/repos","events_url":"https://api.github.com/users/bartekn/events{/privacy}","received_events_url":"https://api.github.com/users/bartekn/received_events","type":"User","site_admin":false},"open_issues":8,"closed_issues":6,"state":"open","created_at":"2018-09-04T16:51:45Z","updated_at":"2018-09-27T16:54:06Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/stellar/go/pulls/692/commits","review_comments_url":"https://api.github.com/repos/stellar/go/pulls/692/comments","review_comment_url":"https://api.github.com/repos/stellar/go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stellar/go/issues/692/comments","statuses_url":"https://api.github.com/repos/stellar/go/statuses/ff59e1707fca2c9122db784d9df6a183d4963735","head":{"label":"lechengfan:add-heartbeat-to-sse","ref":"add-heartbeat-to-sse","sha":"ff59e1707fca2c9122db784d9df6a183d4963735","user":{"login":"lechengfan","id":6279364,"node_id":"MDQ6VXNlcjYyNzkzNjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6279364?v=4","gravatar_id":"","url":"https://api.github.com/users/lechengfan","html_url":"https://github.com/lechengfan","followers_url":"https://api.github.com/users/lechengfan/followers","following_url":"https://api.github.com/users/lechengfan/following{/other_user}","gists_url":"https://api.github.com/users/lechengfan/gists{/gist_id}","starred_url":"https://api.github.com/users/lechengfan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lechengfan/subscriptions","organizations_url":"https://api.github.com/users/lechengfan/orgs","repos_url":"https://api.github.com/users/lechengfan/repos","events_url":"https://api.github.com/users/lechengfan/events{/privacy}","received_events_url":"https://api.github.com/users/lechengfan/received_events","type":"User","site_admin":false},"repo":{"id":147591355,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc1OTEzNTU=","name":"go","full_name":"lechengfan/go","private":false,"owner":{"login":"lechengfan","id":6279364,"node_id":"MDQ6VXNlcjYyNzkzNjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/6279364?v=4","gravatar_id":"","url":"https://api.github.com/users/lechengfan","html_url":"https://github.com/lechengfan","followers_url":"https://api.github.com/users/lechengfan/followers","following_url":"https://api.github.com/users/lechengfan/following{/other_user}","gists_url":"https://api.github.com/users/lechengfan/gists{/gist_id}","starred_url":"https://api.github.com/users/lechengfan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lechengfan/subscriptions","organizations_url":"https://api.github.com/users/lechengfan/orgs","repos_url":"https://api.github.com/users/lechengfan/repos","events_url":"https://api.github.com/users/lechengfan/events{/privacy}","received_events_url":"https://api.github.com/users/lechengfan/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lechengfan/go","description":"Stellar's public monorepo of go code","fork":true,"url":"https://api.github.com/repos/lechengfan/go","forks_url":"https://api.github.com/repos/lechengfan/go/forks","keys_url":"https://api.github.com/repos/lechengfan/go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lechengfan/go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lechengfan/go/teams","hooks_url":"https://api.github.com/repos/lechengfan/go/hooks","issue_events_url":"https://api.github.com/repos/lechengfan/go/issues/events{/number}","events_url":"https://api.github.com/repos/lechengfan/go/events","assignees_url":"https://api.github.com/repos/lechengfan/go/assignees{/user}","branches_url":"https://api.github.com/repos/lechengfan/go/branches{/branch}","tags_url":"https://api.github.com/repos/lechengfan/go/tags","blobs_url":"https://api.github.com/repos/lechengfan/go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lechengfan/go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lechengfan/go/git/refs{/sha}","trees_url":"https://api.github.com/repos/lechengfan/go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lechengfan/go/statuses/{sha}","languages_url":"https://api.github.com/repos/lechengfan/go/languages","stargazers_url":"https://api.github.com/repos/lechengfan/go/stargazers","contributors_url":"https://api.github.com/repos/lechengfan/go/contributors","subscribers_url":"https://api.github.com/repos/lechengfan/go/subscribers","subscription_url":"https://api.github.com/repos/lechengfan/go/subscription","commits_url":"https://api.github.com/repos/lechengfan/go/commits{/sha}","git_commits_url":"https://api.github.com/repos/lechengfan/go/git/commits{/sha}","comments_url":"https://api.github.com/repos/lechengfan/go/comments{/number}","issue_comment_url":"https://api.github.com/repos/lechengfan/go/issues/comments{/number}","contents_url":"https://api.github.com/repos/lechengfan/go/contents/{+path}","compare_url":"https://api.github.com/repos/lechengfan/go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lechengfan/go/merges","archive_url":"https://api.github.com/repos/lechengfan/go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lechengfan/go/downloads","issues_url":"https://api.github.com/repos/lechengfan/go/issues{/number}","pulls_url":"https://api.github.com/repos/lechengfan/go/pulls{/number}","milestones_url":"https://api.github.com/repos/lechengfan/go/milestones{/number}","notifications_url":"https://api.github.com/repos/lechengfan/go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lechengfan/go/labels{/name}","releases_url":"https://api.github.com/repos/lechengfan/go/releases{/id}","deployments_url":"https://api.github.com/repos/lechengfan/go/deployments","created_at":"2018-09-05T23:34:27Z","updated_at":"2018-09-25T22:49:13Z","pushed_at":"2018-09-27T17:44:32Z","git_url":"git://github.com/lechengfan/go.git","ssh_url":"git@github.com:lechengfan/go.git","clone_url":"https://github.com/lechengfan/go.git","svn_url":"https://github.com/lechengfan/go","homepage":"https://stellar.org/developers","size":17772,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"stellar:horizon-0.15.0","ref":"horizon-0.15.0","sha":"b61485827ceba5ae95fd2b20925e2c78ff22b838","user":{"login":"stellar","id":7386716,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczODY3MTY=","avatar_url":"https://avatars3.githubusercontent.com/u/7386716?v=4","gravatar_id":"","url":"https://api.github.com/users/stellar","html_url":"https://github.com/stellar","followers_url":"https://api.github.com/users/stellar/followers","following_url":"https://api.github.com/users/stellar/following{/other_user}","gists_url":"https://api.github.com/users/stellar/gists{/gist_id}","starred_url":"https://api.github.com/users/stellar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stellar/subscriptions","organizations_url":"https://api.github.com/users/stellar/orgs","repos_url":"https://api.github.com/users/stellar/repos","events_url":"https://api.github.com/users/stellar/events{/privacy}","received_events_url":"https://api.github.com/users/stellar/received_events","type":"Organization","site_admin":false},"repo":{"id":64954128,"node_id":"MDEwOlJlcG9zaXRvcnk2NDk1NDEyOA==","name":"go","full_name":"stellar/go","private":false,"owner":{"login":"stellar","id":7386716,"node_id":"MDEyOk9yZ2FuaXphdGlvbjczODY3MTY=","avatar_url":"https://avatars3.githubusercontent.com/u/7386716?v=4","gravatar_id":"","url":"https://api.github.com/users/stellar","html_url":"https://github.com/stellar","followers_url":"https://api.github.com/users/stellar/followers","following_url":"https://api.github.com/users/stellar/following{/other_user}","gists_url":"https://api.github.com/users/stellar/gists{/gist_id}","starred_url":"https://api.github.com/users/stellar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stellar/subscriptions","organizations_url":"https://api.github.com/users/stellar/orgs","repos_url":"https://api.github.com/users/stellar/repos","events_url":"https://api.github.com/users/stellar/events{/privacy}","received_events_url":"https://api.github.com/users/stellar/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/stellar/go","description":"Stellar's public monorepo of go code","fork":false,"url":"https://api.github.com/repos/stellar/go","forks_url":"https://api.github.com/repos/stellar/go/forks","keys_url":"https://api.github.com/repos/stellar/go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stellar/go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stellar/go/teams","hooks_url":"https://api.github.com/repos/stellar/go/hooks","issue_events_url":"https://api.github.com/repos/stellar/go/issues/events{/number}","events_url":"https://api.github.com/repos/stellar/go/events","assignees_url":"https://api.github.com/repos/stellar/go/assignees{/user}","branches_url":"https://api.github.com/repos/stellar/go/branches{/branch}","tags_url":"https://api.github.com/repos/stellar/go/tags","blobs_url":"https://api.github.com/repos/stellar/go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stellar/go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stellar/go/git/refs{/sha}","trees_url":"https://api.github.com/repos/stellar/go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stellar/go/statuses/{sha}","languages_url":"https://api.github.com/repos/stellar/go/languages","stargazers_url":"https://api.github.com/repos/stellar/go/stargazers","contributors_url":"https://api.github.com/repos/stellar/go/contributors","subscribers_url":"https://api.github.com/repos/stellar/go/subscribers","subscription_url":"https://api.github.com/repos/stellar/go/subscription","commits_url":"https://api.github.com/repos/stellar/go/commits{/sha}","git_commits_url":"https://api.github.com/repos/stellar/go/git/commits{/sha}","comments_url":"https://api.github.com/repos/stellar/go/comments{/number}","issue_comment_url":"https://api.github.com/repos/stellar/go/issues/comments{/number}","contents_url":"https://api.github.com/repos/stellar/go/contents/{+path}","compare_url":"https://api.github.com/repos/stellar/go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stellar/go/merges","archive_url":"https://api.github.com/repos/stellar/go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stellar/go/downloads","issues_url":"https://api.github.com/repos/stellar/go/issues{/number}","pulls_url":"https://api.github.com/repos/stellar/go/pulls{/number}","milestones_url":"https://api.github.com/repos/stellar/go/milestones{/number}","notifications_url":"https://api.github.com/repos/stellar/go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stellar/go/labels{/name}","releases_url":"https://api.github.com/repos/stellar/go/releases{/id}","deployments_url":"https://api.github.com/repos/stellar/go/deployments","created_at":"2016-08-04T17:27:50Z","updated_at":"2018-09-27T11:52:16Z","pushed_at":"2018-09-27T17:44:34Z","git_url":"git://github.com/stellar/go.git","ssh_url":"git@github.com:stellar/go.git","clone_url":"https://github.com/stellar/go.git","svn_url":"https://github.com/stellar/go","homepage":"https://stellar.org/developers","size":16449,"stargazers_count":373,"watchers_count":373,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":192,"mirror_url":null,"archived":false,"open_issues_count":153,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":192,"open_issues":153,"watchers":373,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stellar/go/pulls/692"},"html":{"href":"https://github.com/stellar/go/pull/692"},"issue":{"href":"https://api.github.com/repos/stellar/go/issues/692"},"comments":{"href":"https://api.github.com/repos/stellar/go/issues/692/comments"},"review_comments":{"href":"https://api.github.com/repos/stellar/go/pulls/692/comments"},"review_comment":{"href":"https://api.github.com/repos/stellar/go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stellar/go/pulls/692/commits"},"statuses":{"href":"https://api.github.com/repos/stellar/go/statuses/ff59e1707fca2c9122db784d9df6a183d4963735"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bartekn"}}