{"action":"closed","issue":{"url":"https://api.github.com/repos/guyellis/plant/issues/1408","repository_url":"https://api.github.com/repos/guyellis/plant","labels_url":"https://api.github.com/repos/guyellis/plant/issues/1408/labels{/name}","comments_url":"https://api.github.com/repos/guyellis/plant/issues/1408/comments","events_url":"https://api.github.com/repos/guyellis/plant/issues/1408/events","html_url":"https://github.com/guyellis/plant/issues/1408","id":269178070,"number":1408,"title":"Speed up Plant/Note render without images","user":{"login":"guyellis","id":2047725,"avatar_url":"https://avatars2.githubusercontent.com/u/2047725?v=4","gravatar_id":"","url":"https://api.github.com/users/guyellis","html_url":"https://github.com/guyellis","followers_url":"https://api.github.com/users/guyellis/followers","following_url":"https://api.github.com/users/guyellis/following{/other_user}","gists_url":"https://api.github.com/users/guyellis/gists{/gist_id}","starred_url":"https://api.github.com/users/guyellis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guyellis/subscriptions","organizations_url":"https://api.github.com/users/guyellis/orgs","repos_url":"https://api.github.com/users/guyellis/repos","events_url":"https://api.github.com/users/guyellis/events{/privacy}","received_events_url":"https://api.github.com/users/guyellis/received_events","type":"User","site_admin":false},"labels":[{"id":249293029,"url":"https://api.github.com/repos/guyellis/plant/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2017-10-27T17:19:30Z","updated_at":"2018-03-19T13:00:45Z","closed_at":"2018-03-19T13:00:45Z","author_association":"OWNER","body":"Rendering a Plant with many Notes and images over a slow connection creates a poor user experience.\r\n\r\nThe ideal solution would show low fidelity images with a click to pull the high fidelity version.\r\n\r\nAn interim solution is to show buttons that allow for the loading of the images on a Plant/Note:\r\n\r\n(Loading images is simply a matter of replacing the buttons in the post with image tags.)\r\n\r\n- [ ] User's Preferences determine if images are always shown or not shown. This configuration defaults to not-shown and is saved in Browser's local storage because the user may want not-shown on mobile device and shown on desktop.\r\n- [ ] Button (and text) at top of plant render giving user the option to show all images. Text should tell user that they can render images per note as well.\r\n- [x] Button on Note to render all images for that Note.\r\n- [ ] Each image in the Note has a render button so that each one can enable individual rendering. (Not sure if this is going to be useful. Let's say that there are 5 images. All the user will see are generically marked buttons with `Image #1` to `Image #5`. They won't know what those images are because there's no low fidelity image. They are likely to want to render all images for a Note.) I think that this item should be optional.\r\n\r\n## Server Side\r\n\r\nNeed to think about this for server side rendering as well. For example if the Google/Facebook crawler requests the markup for a plant then we should absolutely include the image tags and not buttons.\r\n\r\nFor a user this might be different. This is where defaulting to the low fidelity image for a user would be better.\r\n\r\n## RSS Feed\r\n\r\nHow will this impact the Notes that are rendered to the RSS Feed?\r\n\r\n"}}
{"actor":{"display_login":"guyellis"}}