{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/178235967","pull_request_review_id":108265463,"id":178235967,"diff_hunk":"@@ -157,10 +158,120 @@ func TestMapLoadBalancerNameToVMSet(t *testing.T) {\n \t\t\tclusterName:   \"azure\",\n \t\t\texpectedVMSet: \"azuretest\",\n \t\t},\n+\t\t{\n+\t\t\tdescription:   \"default standard external LB should map to empty string\",\n+\t\t\tlbName:        \"azure\",\n+\t\t\tuseStandardLB: true,\n+\t\t\tclusterName:   \"azure\",\n+\t\t\texpectedVMSet: \"\",\n+\t\t},\n+\t\t{\n+\t\t\tdescription:   \"default standard internal LB should map to empty string\",\n+\t\t\tlbName:        \"azure-internal\",\n+\t\t\tuseStandardLB: true,\n+\t\t\tclusterName:   \"azure\",\n+\t\t\texpectedVMSet: \"\",\n+\t\t},\n+\t\t{\n+\t\t\tdescription:   \"non-default standard external LB should map to empty string\",\n+\t\t\tlbName:        \"azuretest-internal\",\n+\t\t\tuseStandardLB: true,\n+\t\t\tclusterName:   \"azure\",\n+\t\t\texpectedVMSet: \"\",\n+\t\t},\n+\t\t{\n+\t\t\tdescription:   \"non-default standard internal LB should map to empty string\",\n+\t\t\tlbName:        \"azuretest-internal\",\n+\t\t\tuseStandardLB: true,\n+\t\t\tclusterName:   \"azure\",\n+\t\t\texpectedVMSet: \"\",\n+\t\t},\n \t}\n \n \tfor _, c := range cases {\n+\t\tif c.useStandardLB {\n+\t\t\taz.Config.LoadBalancerSku = loadBalancerSkuStandard\n+\t\t}\n \t\tvmset := az.mapLoadBalancerNameToVMSet(c.lbName, c.clusterName)\n \t\tassert.Equal(t, c.expectedVMSet, vmset, c.description)\n \t}\n }\n+\n+func TestGetLoadBalancerName(t *testing.T) {\n+\taz := getTestCloud()\n+\taz.PrimaryAvailabilitySetName = \"primary\"\n+\n+\tcases := []struct {\n+\t\tdescription   string\n+\t\tvmSet         string\n+\t\tisInternal    bool\n+\t\tuseStandardLB bool\n+\t\tclusterName   string\n+\t\texpected      string\n+\t}{\n+\t\t{\n+\t\t\tdescription: \"default external LB should get primary vmset\",\n+\t\t\tvmSet:       \"primary\",\n+\t\t\tclusterName: \"azure\",\n+\t\t\texpected:    \"azure\",\n+\t\t},\n+\t\t{\n+\t\t\tdescription: \"default internal LB should get primary vmset\",\n+\t\t\tvmSet:       \"primary\",\n+\t\t\tclusterName: \"azure\",\n+\t\t\tisInternal:  true,\n+\t\t\texpected:    \"azure-internal\",\n+\t\t},\n+\t\t{\n+\t\t\tdescription: \"non-default external LB should get its own vmset\",\n+\t\t\tvmSet:       \"as\",\n+\t\t\tclusterName: \"azure\",\n+\t\t\texpected:    \"as\",\n+\t\t},\n+\t\t{\n+\t\t\tdescription: \"non-default internal LB should get its own vmset\",\n+\t\t\tvmSet:       \"as\",\n+\t\t\tclusterName: \"azure\",\n+\t\t\tisInternal:  true,\n+\t\t\texpected:    \"as-internal\",\n+\t\t},\n+\t\t{\n+\t\t\tdescription:   \"default standard external LB should get cluster name\",\n+\t\t\tvmSet:         \"primary\",\n+\t\t\tuseStandardLB: true,\n+\t\t\tclusterName:   \"azure\",\n+\t\t\texpected:      \"azure\",\n+\t\t},\n+\t\t{\n+\t\t\tdescription:   \"default standard internal LB should get cluster name\",\n+\t\t\tvmSet:         \"primary\",\n+\t\t\tuseStandardLB: true,\n+\t\t\tisInternal:    true,\n+\t\t\tclusterName:   \"azure\",\n+\t\t\texpected:      \"azure-internal\",\n+\t\t},\n+\t\t{\n+\t\t\tdescription:   \"non-default standard external LB should get cluster-name\",\n+\t\t\tvmSet:         \"as\",\n+\t\t\tuseStandardLB: true,\n+\t\t\tclusterName:   \"azure\",\n+\t\t\texpected:      \"azure\",\n+\t\t},\n+\t\t{\n+\t\t\tdescription:   \"non-default standard internal LB should get cluster-name\",\n+\t\t\tvmSet:         \"as\",\n+\t\t\tuseStandardLB: true,\n+\t\t\tisInternal:    true,\n+\t\t\tclusterName:   \"azure\",\n+\t\t\texpected:      \"azure-internal\",\n+\t\t},\n+\t}\n+\n+\tfor _, c := range cases {\n+\t\tif c.useStandardLB {\n+\t\t\taz.Config.LoadBalancerSku = loadBalancerSkuStandard\n+\t\t}","path":"pkg/cloudprovider/providers/azure/azure_standard_test.go","position":124,"original_position":124,"commit_id":"892d608db8d1e4410c948025b13598b94209b478","original_commit_id":"892d608db8d1e4410c948025b13598b94209b478","user":{"login":"karataliu","id":10071498,"avatar_url":"https://avatars2.githubusercontent.com/u/10071498?v=4","gravatar_id":"","url":"https://api.github.com/users/karataliu","html_url":"https://github.com/karataliu","followers_url":"https://api.github.com/users/karataliu/followers","following_url":"https://api.github.com/users/karataliu/following{/other_user}","gists_url":"https://api.github.com/users/karataliu/gists{/gist_id}","starred_url":"https://api.github.com/users/karataliu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karataliu/subscriptions","organizations_url":"https://api.github.com/users/karataliu/orgs","repos_url":"https://api.github.com/users/karataliu/repos","events_url":"https://api.github.com/users/karataliu/events{/privacy}","received_events_url":"https://api.github.com/users/karataliu/received_events","type":"User","site_admin":false},"body":"Also, switch back for !useStandardLB","created_at":"2018-03-30T05:43:56Z","updated_at":"2018-03-30T05:45:39Z","html_url":"https://github.com/kubernetes/kubernetes/pull/61884#discussion_r178235967","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/61884","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/178235967"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/61884#discussion_r178235967"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/61884"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/61884","id":178270549,"html_url":"https://github.com/kubernetes/kubernetes/pull/61884","diff_url":"https://github.com/kubernetes/kubernetes/pull/61884.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/61884.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/61884","number":61884,"state":"open","locked":false,"title":" Add support of Azure standard load balancer and public IP","user":{"login":"feiskyer","id":676637,"avatar_url":"https://avatars2.githubusercontent.com/u/676637?v=4","gravatar_id":"","url":"https://api.github.com/users/feiskyer","html_url":"https://github.com/feiskyer","followers_url":"https://api.github.com/users/feiskyer/followers","following_url":"https://api.github.com/users/feiskyer/following{/other_user}","gists_url":"https://api.github.com/users/feiskyer/gists{/gist_id}","starred_url":"https://api.github.com/users/feiskyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feiskyer/subscriptions","organizations_url":"https://api.github.com/users/feiskyer/orgs","repos_url":"https://api.github.com/users/feiskyer/repos","events_url":"https://api.github.com/users/feiskyer/events{/privacy}","received_events_url":"https://api.github.com/users/feiskyer/received_events","type":"User","site_admin":false},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/devel/pull-requests.md#the-pr-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed\r\n4. If the PR is unfinished, see how to mark it: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n\r\nThis PR adds a new configure `loadBalancerSku` and `excludeMasterFromStandardLB` to support Azure standard load balancer and public IP.\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFirst step of #60485\r\n\r\n**Special notes for your reviewer**:\r\n\r\nThis is the first step of #60485, and only VMAS is supported yet. VMSS support will be added in a following PR.\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\nAzure cloud provider now supports standard SKU load balancer and public IP. To use it, set cloud provider config with\r\n{\r\n  \"loadBalancerSku\": \"standard\",\r\n  \"excludeMasterFromStandardLB\": true,\r\n}\r\n\r\nIf excludeMasterFromStandardLB is not set, master nodes are also added to the backend of standard LB.\r\n```\r\n","created_at":"2018-03-29T09:15:57Z","updated_at":"2018-03-30T05:45:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"368b330f4dd66fa983577595d2fe9a2a37ff8019","assignee":null,"assignees":[],"requested_reviewers":[{"login":"andyzhangx","id":4178417,"avatar_url":"https://avatars1.githubusercontent.com/u/4178417?v=4","gravatar_id":"","url":"https://api.github.com/users/andyzhangx","html_url":"https://github.com/andyzhangx","followers_url":"https://api.github.com/users/andyzhangx/followers","following_url":"https://api.github.com/users/andyzhangx/following{/other_user}","gists_url":"https://api.github.com/users/andyzhangx/gists{/gist_id}","starred_url":"https://api.github.com/users/andyzhangx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andyzhangx/subscriptions","organizations_url":"https://api.github.com/users/andyzhangx/orgs","repos_url":"https://api.github.com/users/andyzhangx/repos","events_url":"https://api.github.com/users/andyzhangx/events{/privacy}","received_events_url":"https://api.github.com/users/andyzhangx/received_events","type":"User","site_admin":false},{"login":"brendandburns","id":5751682,"avatar_url":"https://avatars2.githubusercontent.com/u/5751682?v=4","gravatar_id":"","url":"https://api.github.com/users/brendandburns","html_url":"https://github.com/brendandburns","followers_url":"https://api.github.com/users/brendandburns/followers","following_url":"https://api.github.com/users/brendandburns/following{/other_user}","gists_url":"https://api.github.com/users/brendandburns/gists{/gist_id}","starred_url":"https://api.github.com/users/brendandburns/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brendandburns/subscriptions","organizations_url":"https://api.github.com/users/brendandburns/orgs","repos_url":"https://api.github.com/users/brendandburns/repos","events_url":"https://api.github.com/users/brendandburns/events{/privacy}","received_events_url":"https://api.github.com/users/brendandburns/received_events","type":"User","site_admin":false},{"login":"khenidak","id":10683203,"avatar_url":"https://avatars2.githubusercontent.com/u/10683203?v=4","gravatar_id":"","url":"https://api.github.com/users/khenidak","html_url":"https://github.com/khenidak","followers_url":"https://api.github.com/users/khenidak/followers","following_url":"https://api.github.com/users/khenidak/following{/other_user}","gists_url":"https://api.github.com/users/khenidak/gists{/gist_id}","starred_url":"https://api.github.com/users/khenidak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/khenidak/subscriptions","organizations_url":"https://api.github.com/users/khenidak/orgs","repos_url":"https://api.github.com/users/khenidak/repos","events_url":"https://api.github.com/users/khenidak/events{/privacy}","received_events_url":"https://api.github.com/users/khenidak/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":414883982,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":200149833,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":621158926,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/azure","name":"sig/azure","color":"d2b48c","default":false},{"id":253450978,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/61884/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/61884/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/61884/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/892d608db8d1e4410c948025b13598b94209b478","head":{"label":"feiskyer:standard","ref":"standard","sha":"892d608db8d1e4410c948025b13598b94209b478","user":{"login":"feiskyer","id":676637,"avatar_url":"https://avatars2.githubusercontent.com/u/676637?v=4","gravatar_id":"","url":"https://api.github.com/users/feiskyer","html_url":"https://github.com/feiskyer","followers_url":"https://api.github.com/users/feiskyer/followers","following_url":"https://api.github.com/users/feiskyer/following{/other_user}","gists_url":"https://api.github.com/users/feiskyer/gists{/gist_id}","starred_url":"https://api.github.com/users/feiskyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feiskyer/subscriptions","organizations_url":"https://api.github.com/users/feiskyer/orgs","repos_url":"https://api.github.com/users/feiskyer/repos","events_url":"https://api.github.com/users/feiskyer/events{/privacy}","received_events_url":"https://api.github.com/users/feiskyer/received_events","type":"User","site_admin":false},"repo":{"id":39993689,"name":"kubernetes","full_name":"feiskyer/kubernetes","owner":{"login":"feiskyer","id":676637,"avatar_url":"https://avatars2.githubusercontent.com/u/676637?v=4","gravatar_id":"","url":"https://api.github.com/users/feiskyer","html_url":"https://github.com/feiskyer","followers_url":"https://api.github.com/users/feiskyer/followers","following_url":"https://api.github.com/users/feiskyer/following{/other_user}","gists_url":"https://api.github.com/users/feiskyer/gists{/gist_id}","starred_url":"https://api.github.com/users/feiskyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feiskyer/subscriptions","organizations_url":"https://api.github.com/users/feiskyer/orgs","repos_url":"https://api.github.com/users/feiskyer/repos","events_url":"https://api.github.com/users/feiskyer/events{/privacy}","received_events_url":"https://api.github.com/users/feiskyer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/feiskyer/kubernetes","description":"Container Cluster Manager from Google","fork":true,"url":"https://api.github.com/repos/feiskyer/kubernetes","forks_url":"https://api.github.com/repos/feiskyer/kubernetes/forks","keys_url":"https://api.github.com/repos/feiskyer/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/feiskyer/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/feiskyer/kubernetes/teams","hooks_url":"https://api.github.com/repos/feiskyer/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/feiskyer/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/feiskyer/kubernetes/events","assignees_url":"https://api.github.com/repos/feiskyer/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/feiskyer/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/feiskyer/kubernetes/tags","blobs_url":"https://api.github.com/repos/feiskyer/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/feiskyer/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/feiskyer/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/feiskyer/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/feiskyer/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/feiskyer/kubernetes/languages","stargazers_url":"https://api.github.com/repos/feiskyer/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/feiskyer/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/feiskyer/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/feiskyer/kubernetes/subscription","commits_url":"https://api.github.com/repos/feiskyer/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/feiskyer/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/feiskyer/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/feiskyer/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/feiskyer/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/feiskyer/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/feiskyer/kubernetes/merges","archive_url":"https://api.github.com/repos/feiskyer/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/feiskyer/kubernetes/downloads","issues_url":"https://api.github.com/repos/feiskyer/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/feiskyer/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/feiskyer/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/feiskyer/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/feiskyer/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/feiskyer/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/feiskyer/kubernetes/deployments","created_at":"2015-07-31T07:53:03Z","updated_at":"2018-03-27T05:50:50Z","pushed_at":"2018-03-30T04:36:19Z","git_url":"git://github.com/feiskyer/kubernetes.git","ssh_url":"git@github.com:feiskyer/kubernetes.git","clone_url":"https://github.com/feiskyer/kubernetes.git","svn_url":"https://github.com/feiskyer/kubernetes","homepage":"http://kubernetes.io","size":550899,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"5ae7bba496f33a4ba087a61f114f792050bad3c5","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2018-03-30T05:04:31Z","pushed_at":"2018-03-30T05:02:02Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":767643,"stargazers_count":34437,"watchers_count":34437,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12194,"mirror_url":null,"archived":false,"open_issues_count":3501,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":12194,"open_issues":3501,"watchers":34437,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/61884"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/61884"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/61884"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/61884/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/61884/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/61884/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/892d608db8d1e4410c948025b13598b94209b478"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"karataliu"}}