{"action":"created","comment":{"url":"https://api.github.com/repos/tock/tock/pulls/comments/201016461","pull_request_review_id":135434411,"id":201016461,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTAxNjQ2MQ==","diff_hunk":"@@ -6,22 +6,24 @@ PLATFORM=nrf51dk\n \n include ../../Makefile.common\n \n-.PHONY: apps/$(APP)/build/$(TOCK_ARCH)/app.bin\n-apps/$(APP)/build/$(TOCK_ARCH)/app.bin:\n-\t@make -C apps/$(APP) TOCK_ARCH=$(TOCK_ARCH)\n+TOCKLOADER=tockloader\n \n-target/$(TARGET)/release/nrf51dk-$(APP).hex: target/$(TARGET)/release/nrf51dk-$(APP)\n-\t@$(OBJCOPY) -Oihex $^ $@\n+# Where in the nrf51 flash to load the kernel with `tockloader`\n+KERNEL_ADDRESS=0x00000\n \n-JLINK=JLinkExe\n-JLINK_OPTIONS+=-device nrf51422 -if swd -speed 1200 -AutoConnect 1\n-JLINK_SCRIPTS_DIR=jtag/\n+# Upload programs over uart with tockloader\n+ifdef PORT\n+  TOCKLOADER_GENERAL_FLAGS += --port $(PORT)\n+endif","path":"boards/nordic/nrf51dk/Makefile","position":20,"original_position":20,"commit_id":"e356517fb60ea2648c01d64efdf762f7d8f7a18d","original_commit_id":"e356517fb60ea2648c01d64efdf762f7d8f7a18d","user":{"login":"alevy","id":4689,"node_id":"MDQ6VXNlcjQ2ODk=","avatar_url":"https://avatars1.githubusercontent.com/u/4689?v=4","gravatar_id":"","url":"https://api.github.com/users/alevy","html_url":"https://github.com/alevy","followers_url":"https://api.github.com/users/alevy/followers","following_url":"https://api.github.com/users/alevy/following{/other_user}","gists_url":"https://api.github.com/users/alevy/gists{/gist_id}","starred_url":"https://api.github.com/users/alevy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alevy/subscriptions","organizations_url":"https://api.github.com/users/alevy/orgs","repos_url":"https://api.github.com/users/alevy/repos","events_url":"https://api.github.com/users/alevy/events{/privacy}","received_events_url":"https://api.github.com/users/alevy/received_events","type":"User","site_admin":false},"body":"It's not terrible right now, though it's still more complex than I would like (again, I suspect switching to LLVM will let us simplify the common Makefile significantly).\r\n\r\nAdding `tockloader` stuff to the common Makefile feels board specific to me---not all boards will use tockloader, and certainly most early ones won't. If tockloader is that simple to use (I think it's either there or getting there for the boards it supports), it should be at least as easy and readable to write the one liner `tockloader` rule directly in the board Makefile as it is to rely on a particular structure and API that the common Makefile exports.\r\n\r\nThat's all. And it's really just a feeling. Like, had the PR added this option to the common Makefile instead of the board Makefile I likely wouldn't have objected (if I even noticed).","created_at":"2018-07-09T14:11:47Z","updated_at":"2018-07-09T14:11:48Z","html_url":"https://github.com/tock/tock/pull/1094#discussion_r201016461","pull_request_url":"https://api.github.com/repos/tock/tock/pulls/1094","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/tock/tock/pulls/comments/201016461"},"html":{"href":"https://github.com/tock/tock/pull/1094#discussion_r201016461"},"pull_request":{"href":"https://api.github.com/repos/tock/tock/pulls/1094"}},"in_reply_to_id":200818913},"pull_request":{"url":"https://api.github.com/repos/tock/tock/pulls/1094","id":199903959,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5OTAzOTU5","html_url":"https://github.com/tock/tock/pull/1094","diff_url":"https://github.com/tock/tock/pull/1094.diff","patch_url":"https://github.com/tock/tock/pull/1094.patch","issue_url":"https://api.github.com/repos/tock/tock/issues/1094","number":1094,"state":"closed","locked":false,"title":"Fix flashing problem on `nRF51DK` & `nRF52DK`","user":{"login":"niklasad1","id":14157425,"node_id":"MDQ6VXNlcjE0MTU3NDI1","avatar_url":"https://avatars1.githubusercontent.com/u/14157425?v=4","gravatar_id":"","url":"https://api.github.com/users/niklasad1","html_url":"https://github.com/niklasad1","followers_url":"https://api.github.com/users/niklasad1/followers","following_url":"https://api.github.com/users/niklasad1/following{/other_user}","gists_url":"https://api.github.com/users/niklasad1/gists{/gist_id}","starred_url":"https://api.github.com/users/niklasad1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niklasad1/subscriptions","organizations_url":"https://api.github.com/users/niklasad1/orgs","repos_url":"https://api.github.com/users/niklasad1/repos","events_url":"https://api.github.com/users/niklasad1/events{/privacy}","received_events_url":"https://api.github.com/users/niklasad1/received_events","type":"User","site_admin":false},"body":"### Pull Request Overview\r\n\r\nThis pull request closes #1093 \r\n\r\n\r\n### Testing Strategy\r\n\r\nTested on both boards!\r\n\r\n\r\n### TODO or Help Wanted\r\n\r\nN/A\r\n\r\n\r\n### Documentation Updated\r\n\r\n~- [ ] Updated the relevant files in `/docs`, or no updates are required.~\r\n\r\n### Formatting\r\n\r\n~- [ ] Ran `make formatall`.~\r\n","created_at":"2018-07-07T16:31:42Z","updated_at":"2018-07-09T14:11:48Z","closed_at":"2018-07-07T19:48:44Z","merged_at":"2018-07-07T19:48:44Z","merge_commit_sha":"c7f008a6b903801baa75000343e63452f12cbba7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tock/tock/pulls/1094/commits","review_comments_url":"https://api.github.com/repos/tock/tock/pulls/1094/comments","review_comment_url":"https://api.github.com/repos/tock/tock/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tock/tock/issues/1094/comments","statuses_url":"https://api.github.com/repos/tock/tock/statuses/e356517fb60ea2648c01d64efdf762f7d8f7a18d","head":{"label":"tock:fix-build-nrf52dk-nrf51dk","ref":"fix-build-nrf52dk-nrf51dk","sha":"e356517fb60ea2648c01d64efdf762f7d8f7a18d","user":{"login":"tock","id":34076064,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MDc2MDY0","avatar_url":"https://avatars1.githubusercontent.com/u/34076064?v=4","gravatar_id":"","url":"https://api.github.com/users/tock","html_url":"https://github.com/tock","followers_url":"https://api.github.com/users/tock/followers","following_url":"https://api.github.com/users/tock/following{/other_user}","gists_url":"https://api.github.com/users/tock/gists{/gist_id}","starred_url":"https://api.github.com/users/tock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tock/subscriptions","organizations_url":"https://api.github.com/users/tock/orgs","repos_url":"https://api.github.com/users/tock/repos","events_url":"https://api.github.com/users/tock/events{/privacy}","received_events_url":"https://api.github.com/users/tock/received_events","type":"Organization","site_admin":false},"repo":{"id":36428094,"node_id":"MDEwOlJlcG9zaXRvcnkzNjQyODA5NA==","name":"tock","full_name":"tock/tock","owner":{"login":"tock","id":34076064,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MDc2MDY0","avatar_url":"https://avatars1.githubusercontent.com/u/34076064?v=4","gravatar_id":"","url":"https://api.github.com/users/tock","html_url":"https://github.com/tock","followers_url":"https://api.github.com/users/tock/followers","following_url":"https://api.github.com/users/tock/following{/other_user}","gists_url":"https://api.github.com/users/tock/gists{/gist_id}","starred_url":"https://api.github.com/users/tock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tock/subscriptions","organizations_url":"https://api.github.com/users/tock/orgs","repos_url":"https://api.github.com/users/tock/repos","events_url":"https://api.github.com/users/tock/events{/privacy}","received_events_url":"https://api.github.com/users/tock/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tock/tock","description":"A secure embedded operating system for Cortex-M based microcontrollers","fork":false,"url":"https://api.github.com/repos/tock/tock","forks_url":"https://api.github.com/repos/tock/tock/forks","keys_url":"https://api.github.com/repos/tock/tock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tock/tock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tock/tock/teams","hooks_url":"https://api.github.com/repos/tock/tock/hooks","issue_events_url":"https://api.github.com/repos/tock/tock/issues/events{/number}","events_url":"https://api.github.com/repos/tock/tock/events","assignees_url":"https://api.github.com/repos/tock/tock/assignees{/user}","branches_url":"https://api.github.com/repos/tock/tock/branches{/branch}","tags_url":"https://api.github.com/repos/tock/tock/tags","blobs_url":"https://api.github.com/repos/tock/tock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tock/tock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tock/tock/git/refs{/sha}","trees_url":"https://api.github.com/repos/tock/tock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tock/tock/statuses/{sha}","languages_url":"https://api.github.com/repos/tock/tock/languages","stargazers_url":"https://api.github.com/repos/tock/tock/stargazers","contributors_url":"https://api.github.com/repos/tock/tock/contributors","subscribers_url":"https://api.github.com/repos/tock/tock/subscribers","subscription_url":"https://api.github.com/repos/tock/tock/subscription","commits_url":"https://api.github.com/repos/tock/tock/commits{/sha}","git_commits_url":"https://api.github.com/repos/tock/tock/git/commits{/sha}","comments_url":"https://api.github.com/repos/tock/tock/comments{/number}","issue_comment_url":"https://api.github.com/repos/tock/tock/issues/comments{/number}","contents_url":"https://api.github.com/repos/tock/tock/contents/{+path}","compare_url":"https://api.github.com/repos/tock/tock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tock/tock/merges","archive_url":"https://api.github.com/repos/tock/tock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tock/tock/downloads","issues_url":"https://api.github.com/repos/tock/tock/issues{/number}","pulls_url":"https://api.github.com/repos/tock/tock/pulls{/number}","milestones_url":"https://api.github.com/repos/tock/tock/milestones{/number}","notifications_url":"https://api.github.com/repos/tock/tock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tock/tock/labels{/name}","releases_url":"https://api.github.com/repos/tock/tock/releases{/id}","deployments_url":"https://api.github.com/repos/tock/tock/deployments","created_at":"2015-05-28T09:26:47Z","updated_at":"2018-07-09T10:58:25Z","pushed_at":"2018-07-09T13:54:48Z","git_url":"git://github.com/tock/tock.git","ssh_url":"git@github.com:tock/tock.git","clone_url":"https://github.com/tock/tock.git","svn_url":"https://github.com/tock/tock","homepage":"https://www.tockos.org","size":135716,"stargazers_count":928,"watchers_count":928,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":118,"mirror_url":null,"archived":false,"open_issues_count":61,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":118,"open_issues":61,"watchers":928,"default_branch":"master"}},"base":{"label":"tock:master","ref":"master","sha":"e5465c253e3a62f89fb393b6db194918aced5a59","user":{"login":"tock","id":34076064,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MDc2MDY0","avatar_url":"https://avatars1.githubusercontent.com/u/34076064?v=4","gravatar_id":"","url":"https://api.github.com/users/tock","html_url":"https://github.com/tock","followers_url":"https://api.github.com/users/tock/followers","following_url":"https://api.github.com/users/tock/following{/other_user}","gists_url":"https://api.github.com/users/tock/gists{/gist_id}","starred_url":"https://api.github.com/users/tock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tock/subscriptions","organizations_url":"https://api.github.com/users/tock/orgs","repos_url":"https://api.github.com/users/tock/repos","events_url":"https://api.github.com/users/tock/events{/privacy}","received_events_url":"https://api.github.com/users/tock/received_events","type":"Organization","site_admin":false},"repo":{"id":36428094,"node_id":"MDEwOlJlcG9zaXRvcnkzNjQyODA5NA==","name":"tock","full_name":"tock/tock","owner":{"login":"tock","id":34076064,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0MDc2MDY0","avatar_url":"https://avatars1.githubusercontent.com/u/34076064?v=4","gravatar_id":"","url":"https://api.github.com/users/tock","html_url":"https://github.com/tock","followers_url":"https://api.github.com/users/tock/followers","following_url":"https://api.github.com/users/tock/following{/other_user}","gists_url":"https://api.github.com/users/tock/gists{/gist_id}","starred_url":"https://api.github.com/users/tock/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tock/subscriptions","organizations_url":"https://api.github.com/users/tock/orgs","repos_url":"https://api.github.com/users/tock/repos","events_url":"https://api.github.com/users/tock/events{/privacy}","received_events_url":"https://api.github.com/users/tock/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tock/tock","description":"A secure embedded operating system for Cortex-M based microcontrollers","fork":false,"url":"https://api.github.com/repos/tock/tock","forks_url":"https://api.github.com/repos/tock/tock/forks","keys_url":"https://api.github.com/repos/tock/tock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tock/tock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tock/tock/teams","hooks_url":"https://api.github.com/repos/tock/tock/hooks","issue_events_url":"https://api.github.com/repos/tock/tock/issues/events{/number}","events_url":"https://api.github.com/repos/tock/tock/events","assignees_url":"https://api.github.com/repos/tock/tock/assignees{/user}","branches_url":"https://api.github.com/repos/tock/tock/branches{/branch}","tags_url":"https://api.github.com/repos/tock/tock/tags","blobs_url":"https://api.github.com/repos/tock/tock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tock/tock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tock/tock/git/refs{/sha}","trees_url":"https://api.github.com/repos/tock/tock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tock/tock/statuses/{sha}","languages_url":"https://api.github.com/repos/tock/tock/languages","stargazers_url":"https://api.github.com/repos/tock/tock/stargazers","contributors_url":"https://api.github.com/repos/tock/tock/contributors","subscribers_url":"https://api.github.com/repos/tock/tock/subscribers","subscription_url":"https://api.github.com/repos/tock/tock/subscription","commits_url":"https://api.github.com/repos/tock/tock/commits{/sha}","git_commits_url":"https://api.github.com/repos/tock/tock/git/commits{/sha}","comments_url":"https://api.github.com/repos/tock/tock/comments{/number}","issue_comment_url":"https://api.github.com/repos/tock/tock/issues/comments{/number}","contents_url":"https://api.github.com/repos/tock/tock/contents/{+path}","compare_url":"https://api.github.com/repos/tock/tock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tock/tock/merges","archive_url":"https://api.github.com/repos/tock/tock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tock/tock/downloads","issues_url":"https://api.github.com/repos/tock/tock/issues{/number}","pulls_url":"https://api.github.com/repos/tock/tock/pulls{/number}","milestones_url":"https://api.github.com/repos/tock/tock/milestones{/number}","notifications_url":"https://api.github.com/repos/tock/tock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tock/tock/labels{/name}","releases_url":"https://api.github.com/repos/tock/tock/releases{/id}","deployments_url":"https://api.github.com/repos/tock/tock/deployments","created_at":"2015-05-28T09:26:47Z","updated_at":"2018-07-09T10:58:25Z","pushed_at":"2018-07-09T13:54:48Z","git_url":"git://github.com/tock/tock.git","ssh_url":"git@github.com:tock/tock.git","clone_url":"https://github.com/tock/tock.git","svn_url":"https://github.com/tock/tock","homepage":"https://www.tockos.org","size":135716,"stargazers_count":928,"watchers_count":928,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":118,"mirror_url":null,"archived":false,"open_issues_count":61,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":118,"open_issues":61,"watchers":928,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tock/tock/pulls/1094"},"html":{"href":"https://github.com/tock/tock/pull/1094"},"issue":{"href":"https://api.github.com/repos/tock/tock/issues/1094"},"comments":{"href":"https://api.github.com/repos/tock/tock/issues/1094/comments"},"review_comments":{"href":"https://api.github.com/repos/tock/tock/pulls/1094/comments"},"review_comment":{"href":"https://api.github.com/repos/tock/tock/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tock/tock/pulls/1094/commits"},"statuses":{"href":"https://api.github.com/repos/tock/tock/statuses/e356517fb60ea2648c01d64efdf762f7d8f7a18d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"alevy"}}