{"action":"created","issue":{"url":"https://api.github.com/repos/Valloric/ycmd/issues/995","repository_url":"https://api.github.com/repos/Valloric/ycmd","labels_url":"https://api.github.com/repos/Valloric/ycmd/issues/995/labels{/name}","comments_url":"https://api.github.com/repos/Valloric/ycmd/issues/995/comments","events_url":"https://api.github.com/repos/Valloric/ycmd/issues/995/events","html_url":"https://github.com/Valloric/ycmd/pull/995","id":312994507,"number":995,"title":"Clang-tidy - HICPP style fixes","user":{"login":"bstaletic","id":7791699,"avatar_url":"https://avatars3.githubusercontent.com/u/7791699?v=4","gravatar_id":"","url":"https://api.github.com/users/bstaletic","html_url":"https://github.com/bstaletic","followers_url":"https://api.github.com/users/bstaletic/followers","following_url":"https://api.github.com/users/bstaletic/following{/other_user}","gists_url":"https://api.github.com/users/bstaletic/gists{/gist_id}","starred_url":"https://api.github.com/users/bstaletic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bstaletic/subscriptions","organizations_url":"https://api.github.com/users/bstaletic/orgs","repos_url":"https://api.github.com/users/bstaletic/repos","events_url":"https://api.github.com/users/bstaletic/events{/privacy}","received_events_url":"https://api.github.com/users/bstaletic/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-04-10T16:16:13Z","updated_at":"2018-04-11T03:59:30Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/Valloric/ycmd/pulls/995","html_url":"https://github.com/Valloric/ycmd/pull/995","diff_url":"https://github.com/Valloric/ycmd/pull/995.diff","patch_url":"https://github.com/Valloric/ycmd/pull/995.patch"},"body":"- Implemented\r\n  - Use emplace_back instead of push_back\r\n  - Use = default; instead of {}; in constructors\r\n  - Remove useless std::move\r\n  - Some member initialisations\r\n- Implemented by other checks\r\n  - Braces around blocks\r\n- False positive\r\n  - Candidate.cpp:70:1: warning: constructor does not initialize these fields: text_is_lowercase_\r\n\r\n- Weird mess in `ycm_core.cpp` caused by boost::python, clean with pybind11.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/valloric/ycmd/995)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/Valloric/ycmd/issues/comments/380319816","html_url":"https://github.com/Valloric/ycmd/pull/995#issuecomment-380319816","issue_url":"https://api.github.com/repos/Valloric/ycmd/issues/995","id":380319816,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-04-11T03:59:30Z","updated_at":"2018-04-11T03:59:30Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/Valloric/ycmd/pull/995?src=pr&el=h1) Report\n> Merging [#995](https://codecov.io/gh/Valloric/ycmd/pull/995?src=pr&el=desc) into [master](https://codecov.io/gh/Valloric/ycmd/commit/28f46bd815a51c8c673983065843b73dcf67b95a?src=pr&el=desc) will **increase** coverage by `<.01%`.\n> The diff coverage is `100%`.\n\n\n```diff\n@@            Coverage Diff             @@\n##           master     #995      +/-   ##\n==========================================\n+ Coverage   96.61%   96.61%   +<.01%     \n==========================================\n  Files          90       90              \n  Lines        6943     6945       +2     \n==========================================\n+ Hits         6708     6710       +2     \n  Misses        235      235\n```\n\n\n"}}
{"actor":{"display_login":"codecov-io"}}