{"action":"created","issue":{"url":"https://api.github.com/repos/bitwarden/web/issues/233","repository_url":"https://api.github.com/repos/bitwarden/web","labels_url":"https://api.github.com/repos/bitwarden/web/issues/233/labels{/name}","comments_url":"https://api.github.com/repos/bitwarden/web/issues/233/comments","events_url":"https://api.github.com/repos/bitwarden/web/issues/233/events","html_url":"https://github.com/bitwarden/web/pull/233","id":346194972,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MTE4MjM4","number":233,"title":"Removed requirement to load JavaScript from js.braintreegateway.com","user":{"login":"lightswitch05","id":598803,"node_id":"MDQ6VXNlcjU5ODgwMw==","avatar_url":"https://avatars2.githubusercontent.com/u/598803?v=4","gravatar_id":"","url":"https://api.github.com/users/lightswitch05","html_url":"https://github.com/lightswitch05","followers_url":"https://api.github.com/users/lightswitch05/followers","following_url":"https://api.github.com/users/lightswitch05/following{/other_user}","gists_url":"https://api.github.com/users/lightswitch05/gists{/gist_id}","starred_url":"https://api.github.com/users/lightswitch05/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lightswitch05/subscriptions","organizations_url":"https://api.github.com/users/lightswitch05/orgs","repos_url":"https://api.github.com/users/lightswitch05/repos","events_url":"https://api.github.com/users/lightswitch05/events{/privacy}","received_events_url":"https://api.github.com/users/lightswitch05/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-07-31T13:46:01Z","updated_at":"2018-07-31T16:01:58Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/bitwarden/web/pulls/233","html_url":"https://github.com/bitwarden/web/pull/233","diff_url":"https://github.com/bitwarden/web/pull/233.diff","patch_url":"https://github.com/bitwarden/web/pull/233.patch"},"body":"I removed the requirement to load JavaScript from js.braintreegateway.com by adding that javascript file to be hosted within your own domain. The logic to only load the JavaScript file as needed remains. I believe this improves security and stability since the file is now hosted within your own domain and modifications to it should only occur during upgrades.\r\n\r\npackage-lock.json had a lot more changes then I expected from this update. The change goes from exact dependency versions in to ranges instead. I'm not sure what caused this, I have NPM version 6.2.0"},"comment":{"url":"https://api.github.com/repos/bitwarden/web/issues/comments/409274718","html_url":"https://github.com/bitwarden/web/pull/233#issuecomment-409274718","issue_url":"https://api.github.com/repos/bitwarden/web/issues/233","id":409274718,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTI3NDcxOA==","user":{"login":"kspearrin","id":1190944,"node_id":"MDQ6VXNlcjExOTA5NDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1190944?v=4","gravatar_id":"","url":"https://api.github.com/users/kspearrin","html_url":"https://github.com/kspearrin","followers_url":"https://api.github.com/users/kspearrin/followers","following_url":"https://api.github.com/users/kspearrin/following{/other_user}","gists_url":"https://api.github.com/users/kspearrin/gists{/gist_id}","starred_url":"https://api.github.com/users/kspearrin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kspearrin/subscriptions","organizations_url":"https://api.github.com/users/kspearrin/orgs","repos_url":"https://api.github.com/users/kspearrin/repos","events_url":"https://api.github.com/users/kspearrin/events{/privacy}","received_events_url":"https://api.github.com/users/kspearrin/received_events","type":"User","site_admin":false},"created_at":"2018-07-31T16:01:58Z","updated_at":"2018-07-31T16:01:58Z","author_association":"COLLABORATOR","body":"Yes, I am aware of that, which is why they don't have SRI hashes today. It might be possible for Braintree since they are versioned, but won't be possible with Stripe since they manage versioning internally and you never know when the script gets updated. I've already talked to their dev team. This is how they require the script to be used."}}
{"actor":{"display_login":"kspearrin"}}