{"action":"created","comment":{"url":"https://api.github.com/repos/owncloud/user_management/pulls/comments/235759560","pull_request_review_id":177700053,"id":235759560,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTc1OTU2MA==","diff_hunk":"@@ -269,22 +269,25 @@ GroupList = {\n \t\tGroupDeleteHandler = new DeleteHandler('/apps/user_management/groups', 'groupname',\n \t\t\tGroupList.hide, GroupList.remove);\n \n-\t\t//configure undo\n-\t\tOC.Notification.hide();\n \t\tvar msg = escapeHTML(t('user_management', 'deleted {groupName}', {groupName: '%oid'})) + '<span class=\"undo\">' +\n \t\t\tescapeHTML(t('user_management', 'undo')) + '</span>';\n \t\tGroupDeleteHandler.setNotification(OC.Notification, 'deletegroup', msg,\n-\t\t\tGroupList.show);\n+\t\t\tGroupList.remove);\n \n \t\t//when to mark user for delete\n \t\t$userGroupList.on('click', '.delete', function () {\n \t\t\t// Call function for handling delete/undo\n-\t\t\tGroupDeleteHandler.mark(encodeURIComponent(GroupList.getElementGID(this)).toString());\n-\t\t});\n-\n-\t\t//delete a marked user when leaving the page\n-\t\t$(window).on('beforeunload', function () {\n-\t\t\tGroupDeleteHandler.deleteEntry();\n+\t\t\tvar groupName = encodeURIComponent(GroupList.getElementGID(this)).toString();\n+\t\t\tOC.dialogs.confirm(\n+\t\t\t\tt('user_management', 'You are about to delete a group. This action can\\'t be undone and is permanent. Are you sure that you want to permanently delete {groupName}?', {groupName: decodeURIComponent(groupName)}),","path":"js/groups.js","position":23,"original_position":23,"commit_id":"c7e94483c42c3dd9c133b25be87fb68aa8496566","original_commit_id":"c7e94483c42c3dd9c133b25be87fb68aa8496566","user":{"login":"PVince81","id":277525,"node_id":"MDQ6VXNlcjI3NzUyNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/277525?v=4","gravatar_id":"","url":"https://api.github.com/users/PVince81","html_url":"https://github.com/PVince81","followers_url":"https://api.github.com/users/PVince81/followers","following_url":"https://api.github.com/users/PVince81/following{/other_user}","gists_url":"https://api.github.com/users/PVince81/gists{/gist_id}","starred_url":"https://api.github.com/users/PVince81/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PVince81/subscriptions","organizations_url":"https://api.github.com/users/PVince81/orgs","repos_url":"https://api.github.com/users/PVince81/repos","events_url":"https://api.github.com/users/PVince81/events{/privacy}","received_events_url":"https://api.github.com/users/PVince81/received_events","type":"User","site_admin":false},"body":"never mind... I just checked the l10n files and apparently there is never a space.\r\n\r\nso I've been doing this wrong all these years ?\r\nin some languages you need a space there","created_at":"2018-11-22T15:17:42Z","updated_at":"2018-11-22T15:17:42Z","html_url":"https://github.com/owncloud/user_management/pull/94#discussion_r235759560","pull_request_url":"https://api.github.com/repos/owncloud/user_management/pulls/94","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/owncloud/user_management/pulls/comments/235759560"},"html":{"href":"https://github.com/owncloud/user_management/pull/94#discussion_r235759560"},"pull_request":{"href":"https://api.github.com/repos/owncloud/user_management/pulls/94"}},"in_reply_to_id":235757070},"pull_request":{"url":"https://api.github.com/repos/owncloud/user_management/pulls/94","id":227248263,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3MjQ4MjYz","html_url":"https://github.com/owncloud/user_management/pull/94","diff_url":"https://github.com/owncloud/user_management/pull/94.diff","patch_url":"https://github.com/owncloud/user_management/pull/94.patch","issue_url":"https://api.github.com/repos/owncloud/user_management/issues/94","number":94,"state":"closed","locked":false,"title":"Replace notification with confirm dialog for user deletion","user":{"login":"sharidas","id":3600427,"node_id":"MDQ6VXNlcjM2MDA0Mjc=","avatar_url":"https://avatars1.githubusercontent.com/u/3600427?v=4","gravatar_id":"","url":"https://api.github.com/users/sharidas","html_url":"https://github.com/sharidas","followers_url":"https://api.github.com/users/sharidas/followers","following_url":"https://api.github.com/users/sharidas/following{/other_user}","gists_url":"https://api.github.com/users/sharidas/gists{/gist_id}","starred_url":"https://api.github.com/users/sharidas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharidas/subscriptions","organizations_url":"https://api.github.com/users/sharidas/orgs","repos_url":"https://api.github.com/users/sharidas/repos","events_url":"https://api.github.com/users/sharidas/events{/privacy}","received_events_url":"https://api.github.com/users/sharidas/received_events","type":"User","site_admin":false},"body":"Replace notification with confirm dialog for user\r\ndeletion from UI.\r\n\r\nSigned-off-by: Sujith H <sharidasan@owncloud.com>","created_at":"2018-10-31T11:23:13Z","updated_at":"2018-11-22T15:17:42Z","closed_at":"2018-11-22T12:01:41Z","merged_at":"2018-11-22T12:01:41Z","merge_commit_sha":"e44b8d0eb0777b6e9e29f10a4186e50c33e3e688","assignee":{"login":"sharidas","id":3600427,"node_id":"MDQ6VXNlcjM2MDA0Mjc=","avatar_url":"https://avatars1.githubusercontent.com/u/3600427?v=4","gravatar_id":"","url":"https://api.github.com/users/sharidas","html_url":"https://github.com/sharidas","followers_url":"https://api.github.com/users/sharidas/followers","following_url":"https://api.github.com/users/sharidas/following{/other_user}","gists_url":"https://api.github.com/users/sharidas/gists{/gist_id}","starred_url":"https://api.github.com/users/sharidas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharidas/subscriptions","organizations_url":"https://api.github.com/users/sharidas/orgs","repos_url":"https://api.github.com/users/sharidas/repos","events_url":"https://api.github.com/users/sharidas/events{/privacy}","received_events_url":"https://api.github.com/users/sharidas/received_events","type":"User","site_admin":false},"assignees":[{"login":"sharidas","id":3600427,"node_id":"MDQ6VXNlcjM2MDA0Mjc=","avatar_url":"https://avatars1.githubusercontent.com/u/3600427?v=4","gravatar_id":"","url":"https://api.github.com/users/sharidas","html_url":"https://github.com/sharidas","followers_url":"https://api.github.com/users/sharidas/followers","following_url":"https://api.github.com/users/sharidas/following{/other_user}","gists_url":"https://api.github.com/users/sharidas/gists{/gist_id}","starred_url":"https://api.github.com/users/sharidas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharidas/subscriptions","organizations_url":"https://api.github.com/users/sharidas/orgs","repos_url":"https://api.github.com/users/sharidas/repos","events_url":"https://api.github.com/users/sharidas/events{/privacy}","received_events_url":"https://api.github.com/users/sharidas/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/owncloud/user_management/milestones/1","html_url":"https://github.com/owncloud/user_management/milestone/1","labels_url":"https://api.github.com/repos/owncloud/user_management/milestones/1/labels","id":3165071,"node_id":"MDk6TWlsZXN0b25lMzE2NTA3MQ==","number":1,"title":"development","description":null,"creator":{"login":"DeepDiver1975","id":1005065,"node_id":"MDQ6VXNlcjEwMDUwNjU=","avatar_url":"https://avatars2.githubusercontent.com/u/1005065?v=4","gravatar_id":"","url":"https://api.github.com/users/DeepDiver1975","html_url":"https://github.com/DeepDiver1975","followers_url":"https://api.github.com/users/DeepDiver1975/followers","following_url":"https://api.github.com/users/DeepDiver1975/following{/other_user}","gists_url":"https://api.github.com/users/DeepDiver1975/gists{/gist_id}","starred_url":"https://api.github.com/users/DeepDiver1975/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DeepDiver1975/subscriptions","organizations_url":"https://api.github.com/users/DeepDiver1975/orgs","repos_url":"https://api.github.com/users/DeepDiver1975/repos","events_url":"https://api.github.com/users/DeepDiver1975/events{/privacy}","received_events_url":"https://api.github.com/users/DeepDiver1975/received_events","type":"User","site_admin":false},"open_issues":3,"closed_issues":59,"state":"open","created_at":"2018-03-06T11:17:43Z","updated_at":"2018-11-22T12:01:41Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/owncloud/user_management/pulls/94/commits","review_comments_url":"https://api.github.com/repos/owncloud/user_management/pulls/94/comments","review_comment_url":"https://api.github.com/repos/owncloud/user_management/pulls/comments{/number}","comments_url":"https://api.github.com/repos/owncloud/user_management/issues/94/comments","statuses_url":"https://api.github.com/repos/owncloud/user_management/statuses/c7e94483c42c3dd9c133b25be87fb68aa8496566","head":{"label":"owncloud:delete-with-confirmationdialog","ref":"delete-with-confirmationdialog","sha":"c7e94483c42c3dd9c133b25be87fb68aa8496566","user":{"login":"owncloud","id":1645051,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDUwNTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1645051?v=4","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":123587039,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM1ODcwMzk=","name":"user_management","full_name":"owncloud/user_management","private":false,"owner":{"login":"owncloud","id":1645051,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDUwNTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1645051?v=4","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/owncloud/user_management","description":null,"fork":false,"url":"https://api.github.com/repos/owncloud/user_management","forks_url":"https://api.github.com/repos/owncloud/user_management/forks","keys_url":"https://api.github.com/repos/owncloud/user_management/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/user_management/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/user_management/teams","hooks_url":"https://api.github.com/repos/owncloud/user_management/hooks","issue_events_url":"https://api.github.com/repos/owncloud/user_management/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/user_management/events","assignees_url":"https://api.github.com/repos/owncloud/user_management/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/user_management/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/user_management/tags","blobs_url":"https://api.github.com/repos/owncloud/user_management/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/user_management/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/user_management/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/user_management/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/user_management/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/user_management/languages","stargazers_url":"https://api.github.com/repos/owncloud/user_management/stargazers","contributors_url":"https://api.github.com/repos/owncloud/user_management/contributors","subscribers_url":"https://api.github.com/repos/owncloud/user_management/subscribers","subscription_url":"https://api.github.com/repos/owncloud/user_management/subscription","commits_url":"https://api.github.com/repos/owncloud/user_management/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/user_management/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/user_management/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/user_management/issues/comments{/number}","contents_url":"https://api.github.com/repos/owncloud/user_management/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/user_management/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/user_management/merges","archive_url":"https://api.github.com/repos/owncloud/user_management/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/user_management/downloads","issues_url":"https://api.github.com/repos/owncloud/user_management/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/user_management/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/user_management/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/user_management/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/user_management/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/user_management/releases{/id}","deployments_url":"https://api.github.com/repos/owncloud/user_management/deployments","created_at":"2018-03-02T14:10:55Z","updated_at":"2018-11-22T12:43:13Z","pushed_at":"2018-11-22T12:43:11Z","git_url":"git://github.com/owncloud/user_management.git","ssh_url":"git@github.com:owncloud/user_management.git","clone_url":"https://github.com/owncloud/user_management.git","svn_url":"https://github.com/owncloud/user_management","homepage":null,"size":607,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":2,"open_issues":16,"watchers":0,"default_branch":"master"}},"base":{"label":"owncloud:master","ref":"master","sha":"60faa88dc64d18e83782a83b6b555604c4fbf367","user":{"login":"owncloud","id":1645051,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDUwNTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1645051?v=4","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"repo":{"id":123587039,"node_id":"MDEwOlJlcG9zaXRvcnkxMjM1ODcwMzk=","name":"user_management","full_name":"owncloud/user_management","private":false,"owner":{"login":"owncloud","id":1645051,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDUwNTE=","avatar_url":"https://avatars3.githubusercontent.com/u/1645051?v=4","gravatar_id":"","url":"https://api.github.com/users/owncloud","html_url":"https://github.com/owncloud","followers_url":"https://api.github.com/users/owncloud/followers","following_url":"https://api.github.com/users/owncloud/following{/other_user}","gists_url":"https://api.github.com/users/owncloud/gists{/gist_id}","starred_url":"https://api.github.com/users/owncloud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/owncloud/subscriptions","organizations_url":"https://api.github.com/users/owncloud/orgs","repos_url":"https://api.github.com/users/owncloud/repos","events_url":"https://api.github.com/users/owncloud/events{/privacy}","received_events_url":"https://api.github.com/users/owncloud/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/owncloud/user_management","description":null,"fork":false,"url":"https://api.github.com/repos/owncloud/user_management","forks_url":"https://api.github.com/repos/owncloud/user_management/forks","keys_url":"https://api.github.com/repos/owncloud/user_management/keys{/key_id}","collaborators_url":"https://api.github.com/repos/owncloud/user_management/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/owncloud/user_management/teams","hooks_url":"https://api.github.com/repos/owncloud/user_management/hooks","issue_events_url":"https://api.github.com/repos/owncloud/user_management/issues/events{/number}","events_url":"https://api.github.com/repos/owncloud/user_management/events","assignees_url":"https://api.github.com/repos/owncloud/user_management/assignees{/user}","branches_url":"https://api.github.com/repos/owncloud/user_management/branches{/branch}","tags_url":"https://api.github.com/repos/owncloud/user_management/tags","blobs_url":"https://api.github.com/repos/owncloud/user_management/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/owncloud/user_management/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/owncloud/user_management/git/refs{/sha}","trees_url":"https://api.github.com/repos/owncloud/user_management/git/trees{/sha}","statuses_url":"https://api.github.com/repos/owncloud/user_management/statuses/{sha}","languages_url":"https://api.github.com/repos/owncloud/user_management/languages","stargazers_url":"https://api.github.com/repos/owncloud/user_management/stargazers","contributors_url":"https://api.github.com/repos/owncloud/user_management/contributors","subscribers_url":"https://api.github.com/repos/owncloud/user_management/subscribers","subscription_url":"https://api.github.com/repos/owncloud/user_management/subscription","commits_url":"https://api.github.com/repos/owncloud/user_management/commits{/sha}","git_commits_url":"https://api.github.com/repos/owncloud/user_management/git/commits{/sha}","comments_url":"https://api.github.com/repos/owncloud/user_management/comments{/number}","issue_comment_url":"https://api.github.com/repos/owncloud/user_management/issues/comments{/number}","contents_url":"https://api.github.com/repos/owncloud/user_management/contents/{+path}","compare_url":"https://api.github.com/repos/owncloud/user_management/compare/{base}...{head}","merges_url":"https://api.github.com/repos/owncloud/user_management/merges","archive_url":"https://api.github.com/repos/owncloud/user_management/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/owncloud/user_management/downloads","issues_url":"https://api.github.com/repos/owncloud/user_management/issues{/number}","pulls_url":"https://api.github.com/repos/owncloud/user_management/pulls{/number}","milestones_url":"https://api.github.com/repos/owncloud/user_management/milestones{/number}","notifications_url":"https://api.github.com/repos/owncloud/user_management/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/owncloud/user_management/labels{/name}","releases_url":"https://api.github.com/repos/owncloud/user_management/releases{/id}","deployments_url":"https://api.github.com/repos/owncloud/user_management/deployments","created_at":"2018-03-02T14:10:55Z","updated_at":"2018-11-22T12:43:13Z","pushed_at":"2018-11-22T12:43:11Z","git_url":"git://github.com/owncloud/user_management.git","ssh_url":"git@github.com:owncloud/user_management.git","clone_url":"https://github.com/owncloud/user_management.git","svn_url":"https://github.com/owncloud/user_management","homepage":null,"size":607,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":2,"open_issues":16,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/owncloud/user_management/pulls/94"},"html":{"href":"https://github.com/owncloud/user_management/pull/94"},"issue":{"href":"https://api.github.com/repos/owncloud/user_management/issues/94"},"comments":{"href":"https://api.github.com/repos/owncloud/user_management/issues/94/comments"},"review_comments":{"href":"https://api.github.com/repos/owncloud/user_management/pulls/94/comments"},"review_comment":{"href":"https://api.github.com/repos/owncloud/user_management/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/owncloud/user_management/pulls/94/commits"},"statuses":{"href":"https://api.github.com/repos/owncloud/user_management/statuses/c7e94483c42c3dd9c133b25be87fb68aa8496566"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"PVince81"}}