{"action":"created","issue":{"url":"https://api.github.com/repos/paypal/downshift/issues/265","repository_url":"https://api.github.com/repos/paypal/downshift","labels_url":"https://api.github.com/repos/paypal/downshift/issues/265/labels{/name}","comments_url":"https://api.github.com/repos/paypal/downshift/issues/265/comments","events_url":"https://api.github.com/repos/paypal/downshift/issues/265/events","html_url":"https://github.com/paypal/downshift/pull/265","id":277159169,"number":265,"title":"[WIP] Add support for React Native as a target","user":{"login":"eliperkins","id":1051453,"avatar_url":"https://avatars2.githubusercontent.com/u/1051453?v=4","gravatar_id":"","url":"https://api.github.com/users/eliperkins","html_url":"https://github.com/eliperkins","followers_url":"https://api.github.com/users/eliperkins/followers","following_url":"https://api.github.com/users/eliperkins/following{/other_user}","gists_url":"https://api.github.com/users/eliperkins/gists{/gist_id}","starred_url":"https://api.github.com/users/eliperkins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eliperkins/subscriptions","organizations_url":"https://api.github.com/users/eliperkins/orgs","repos_url":"https://api.github.com/users/eliperkins/repos","events_url":"https://api.github.com/users/eliperkins/events{/privacy}","received_events_url":"https://api.github.com/users/eliperkins/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":31,"created_at":"2017-11-27T20:32:14Z","updated_at":"2018-02-06T21:12:26Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/paypal/downshift/pulls/265","html_url":"https://github.com/paypal/downshift/pull/265","diff_url":"https://github.com/paypal/downshift/pull/265.diff","patch_url":"https://github.com/paypal/downshift/pull/265.patch"},"body":"<!-- What changes are being made? (What feature/bug is being fixed here?) -->\r\n**What**: Adds support for using 🏎 in React Native. Closes #185.\r\n\r\n<!-- Why are these changes necessary? -->\r\n**Why**: Prior to this, React Native could not be targeted, as there are DOM-specific codepaths. This ensures those codepaths are not followed on React Native.\r\n\r\n<!-- How were these changes implemented? -->\r\n**How**: Added the basic `downshift` implementation into a React Native app and started hammering out errors, stripping away DOM-related code.\r\n\r\n<!-- Have you done all of these things?  -->\r\n**Checklist**:\r\n\r\nNone of these are done yet! This is a work-in-progress. Putting this up for review as a check to make sure I'm headed in the right direction.\r\n\r\n<!-- add \"N/A\" to the end of each line that's irrelevant to your changes -->\r\n<!-- to check an item, place an \"x\" in the box like so: \"- [x] Documentation\" -->\r\n- [ ] Documentation\r\n- [ ] Tests\r\n- [ ] Ready to be merged <!-- In your opinion, is this ready to be merged as soon as it's reviewed? -->\r\n- [ ] Added myself to contributors table <!-- this is optional, see the contributing guidelines for instructions -->\r\n\r\n<!-- feel free to add additional comments -->\r\n"},"comment":{"url":"https://api.github.com/repos/paypal/downshift/issues/comments/363566082","html_url":"https://github.com/paypal/downshift/pull/265#issuecomment-363566082","issue_url":"https://api.github.com/repos/paypal/downshift/issues/265","id":363566082,"user":{"login":"kentcdodds","id":1500684,"avatar_url":"https://avatars0.githubusercontent.com/u/1500684?v=4","gravatar_id":"","url":"https://api.github.com/users/kentcdodds","html_url":"https://github.com/kentcdodds","followers_url":"https://api.github.com/users/kentcdodds/followers","following_url":"https://api.github.com/users/kentcdodds/following{/other_user}","gists_url":"https://api.github.com/users/kentcdodds/gists{/gist_id}","starred_url":"https://api.github.com/users/kentcdodds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kentcdodds/subscriptions","organizations_url":"https://api.github.com/users/kentcdodds/orgs","repos_url":"https://api.github.com/users/kentcdodds/repos","events_url":"https://api.github.com/users/kentcdodds/events{/privacy}","received_events_url":"https://api.github.com/users/kentcdodds/received_events","type":"User","site_admin":false},"created_at":"2018-02-06T21:12:26Z","updated_at":"2018-02-06T21:12:26Z","author_association":"MEMBER","body":"The thing is we want to use `process.env.NODE_ENV` for some things: https://github.com/paypal/downshift/blob/531bd8ea83ae5ecc3c163357ac9be4dc721d2060/src/downshift.js#L78\r\n\r\nI imagine we'll want to use it in the future as well. Currently the UMD bundle replaces that (`development` for umd and `production` for umd.min), but for cjs and esm we want to leave those as-is. But honestly those are probably the only ones we'd care to leave as-is so we can probably make that work :+1:\r\n\r\nI agree that should not hold up this PR.\r\n\r\nIs this ready to merge then?"}}
{"actor":{"display_login":"kentcdodds"}}