{"action":"created","issue":{"url":"https://api.github.com/repos/LBNL-UCB-STI/beam/issues/630","repository_url":"https://api.github.com/repos/LBNL-UCB-STI/beam","labels_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/issues/630/labels{/name}","comments_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/issues/630/comments","events_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/issues/630/events","html_url":"https://github.com/LBNL-UCB-STI/beam/pull/630","id":363232557,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NzIyMTI4","number":630,"title":"Fdariasm/#433 fix to refactor vehicle types 4ci","user":{"login":"fdariasm","id":15900393,"node_id":"MDQ6VXNlcjE1OTAwMzkz","avatar_url":"https://avatars2.githubusercontent.com/u/15900393?v=4","gravatar_id":"","url":"https://api.github.com/users/fdariasm","html_url":"https://github.com/fdariasm","followers_url":"https://api.github.com/users/fdariasm/followers","following_url":"https://api.github.com/users/fdariasm/following{/other_user}","gists_url":"https://api.github.com/users/fdariasm/gists{/gist_id}","starred_url":"https://api.github.com/users/fdariasm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fdariasm/subscriptions","organizations_url":"https://api.github.com/users/fdariasm/orgs","repos_url":"https://api.github.com/users/fdariasm/repos","events_url":"https://api.github.com/users/fdariasm/events{/privacy}","received_events_url":"https://api.github.com/users/fdariasm/received_events","type":"User","site_admin":false},"labels":[{"id":991098998,"node_id":"MDU6TGFiZWw5OTEwOTg5OTg=","url":"https://api.github.com/repos/LBNL-UCB-STI/beam/labels/review","name":"review","color":"ededed","default":false}],"state":"open","locked":false,"assignee":{"login":"fdariasm","id":15900393,"node_id":"MDQ6VXNlcjE1OTAwMzkz","avatar_url":"https://avatars2.githubusercontent.com/u/15900393?v=4","gravatar_id":"","url":"https://api.github.com/users/fdariasm","html_url":"https://github.com/fdariasm","followers_url":"https://api.github.com/users/fdariasm/followers","following_url":"https://api.github.com/users/fdariasm/following{/other_user}","gists_url":"https://api.github.com/users/fdariasm/gists{/gist_id}","starred_url":"https://api.github.com/users/fdariasm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fdariasm/subscriptions","organizations_url":"https://api.github.com/users/fdariasm/orgs","repos_url":"https://api.github.com/users/fdariasm/repos","events_url":"https://api.github.com/users/fdariasm/events{/privacy}","received_events_url":"https://api.github.com/users/fdariasm/received_events","type":"User","site_admin":false},"assignees":[{"login":"fdariasm","id":15900393,"node_id":"MDQ6VXNlcjE1OTAwMzkz","avatar_url":"https://avatars2.githubusercontent.com/u/15900393?v=4","gravatar_id":"","url":"https://api.github.com/users/fdariasm","html_url":"https://github.com/fdariasm","followers_url":"https://api.github.com/users/fdariasm/followers","following_url":"https://api.github.com/users/fdariasm/following{/other_user}","gists_url":"https://api.github.com/users/fdariasm/gists{/gist_id}","starred_url":"https://api.github.com/users/fdariasm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fdariasm/subscriptions","organizations_url":"https://api.github.com/users/fdariasm/orgs","repos_url":"https://api.github.com/users/fdariasm/repos","events_url":"https://api.github.com/users/fdariasm/events{/privacy}","received_events_url":"https://api.github.com/users/fdariasm/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-09-24T16:54:07Z","updated_at":"2018-10-04T22:36:45Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/LBNL-UCB-STI/beam/pulls/630","html_url":"https://github.com/LBNL-UCB-STI/beam/pull/630","diff_url":"https://github.com/LBNL-UCB-STI/beam/pull/630.diff","patch_url":"https://github.com/LBNL-UCB-STI/beam/pull/630.patch"},"body":"This PR covers comments about vehicle types refactoring for #433 :\r\n\r\n - Fuel type and other properties should be None or unset for all vehicle types. We are not modeling Plug-in Hybrid Electric vehicles yet.\r\n - Do not use Strings for categorical fields. Use a sealed trait plus case objects like what we did for ParkingType\r\n - Values fixed for primaryFuelConsumptionInJoulePerMeter based on vehicles.xml data.\r\n - Values fixed for primaryFuelCapacityInJoule based on production vehicleTypes.csv\r\n - Update to matsim conversion tool.\r\n - Update to beam documentation, matsim conversion instructions\r\n\r\n<!-- Reviewable:start -->\r\n---\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/lbnl-ucb-sti/beam/630)\r\n<!-- Reviewable:end -->\r\n"},"comment":{"url":"https://api.github.com/repos/LBNL-UCB-STI/beam/issues/comments/427191728","html_url":"https://github.com/LBNL-UCB-STI/beam/pull/630#issuecomment-427191728","issue_url":"https://api.github.com/repos/LBNL-UCB-STI/beam/issues/630","id":427191728,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzE5MTcyOA==","user":{"login":"fdariasm","id":15900393,"node_id":"MDQ6VXNlcjE1OTAwMzkz","avatar_url":"https://avatars2.githubusercontent.com/u/15900393?v=4","gravatar_id":"","url":"https://api.github.com/users/fdariasm","html_url":"https://github.com/fdariasm","followers_url":"https://api.github.com/users/fdariasm/followers","following_url":"https://api.github.com/users/fdariasm/following{/other_user}","gists_url":"https://api.github.com/users/fdariasm/gists{/gist_id}","starred_url":"https://api.github.com/users/fdariasm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fdariasm/subscriptions","organizations_url":"https://api.github.com/users/fdariasm/orgs","repos_url":"https://api.github.com/users/fdariasm/repos","events_url":"https://api.github.com/users/fdariasm/events{/privacy}","received_events_url":"https://api.github.com/users/fdariasm/received_events","type":"User","site_admin":false},"created_at":"2018-10-04T22:36:45Z","updated_at":"2018-10-04T22:36:45Z","author_association":"COLLABORATOR","body":"@colinsheppard please check commit d00c46e for changes after review"}}
{"actor":{"display_login":"fdariasm"}}