{"action":"created","comment":{"url":"https://api.github.com/repos/cleandart/react-dart/pulls/comments/226131069","pull_request_review_id":165880695,"id":226131069,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjEzMTA2OQ==","diff_hunk":"@@ -59,21 +59,39 @@ abstract class ReactComponentFactoryProxy implements Function {\n   ///\n   /// We need a concrete implementation of this, as opposed to it just being handled by [noSuchMethod],\n   /// in order to work around DDC issue <https://github.com/dart-lang/sdk/issues/29917>.\n-  ReactElement call(Map props, [dynamic children]) => build(props, [children]);\n-\n-  @override\n-  dynamic noSuchMethod(Invocation invocation) {\n-    if (invocation.memberName == #call && invocation.isMethod) {\n-      Map props = invocation.positionalArguments[0];\n-      List children = invocation.positionalArguments.sublist(1);\n-\n-      return build(props, children);\n+  ReactElement call(Map props, [c1 = _notSpecified, c2 = _notSpecified, c3 = _notSpecified, c4 = _notSpecified, c5 = _notSpecified, c6 = _notSpecified, c7 = _notSpecified, c8 = _notSpecified, c9 = _notSpecified, c10 = _notSpecified, c11 = _notSpecified, c12 = _notSpecified, c13 = _notSpecified, c14 = _notSpecified, c15 = _notSpecified, c16 = _notSpecified, c17 = _notSpecified, c18 = _notSpecified, c19 = _notSpecified, c20 = _notSpecified, c21 = _notSpecified, c22 = _notSpecified, c23 = _notSpecified, c24 = _notSpecified, c25 = _notSpecified, c26 = _notSpecified, c27 = _notSpecified, c28 = _notSpecified, c29 = _notSpecified, c30 = _notSpecified, c31 = _notSpecified, c32 = _notSpecified, c33 = _notSpecified, c34 = _notSpecified, c35 = _notSpecified, c36 = _notSpecified, c37 = _notSpecified, c38 = _notSpecified, c39 = _notSpecified, c40 = _notSpecified, c41 = _notSpecified, c42 = _notSpecified, c43 = _notSpecified, c44 = _notSpecified, c45 = _notSpecified, c46 = _notSpecified, c47 = _notSpecified, c48 = _notSpecified, c49 = _notSpecified, c50 = _notSpecified, c51 = _notSpecified, c52 = _notSpecified]) {","path":"lib/react_client.dart","position":13,"original_position":13,"commit_id":"8db740ea3c70c41c884989667dcbf0d0f123b8ef","original_commit_id":"8db740ea3c70c41c884989667dcbf0d0f123b8ef","user":{"login":"greglittlefield-wf","id":1713967,"node_id":"MDQ6VXNlcjE3MTM5Njc=","avatar_url":"https://avatars0.githubusercontent.com/u/1713967?v=4","gravatar_id":"","url":"https://api.github.com/users/greglittlefield-wf","html_url":"https://github.com/greglittlefield-wf","followers_url":"https://api.github.com/users/greglittlefield-wf/followers","following_url":"https://api.github.com/users/greglittlefield-wf/following{/other_user}","gists_url":"https://api.github.com/users/greglittlefield-wf/gists{/gist_id}","starred_url":"https://api.github.com/users/greglittlefield-wf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greglittlefield-wf/subscriptions","organizations_url":"https://api.github.com/users/greglittlefield-wf/orgs","repos_url":"https://api.github.com/users/greglittlefield-wf/repos","events_url":"https://api.github.com/users/greglittlefield-wf/events{/privacy}","received_events_url":"https://api.github.com/users/greglittlefield-wf/received_events","type":"User","site_admin":false},"body":"It looks like a fix to that bug was released in Dart 1.16.0, so we're good! https://github.com/dart-lang/sdk/pull/26032\r\n\r\nI do think we should keep OverReact at 40 (or whatever it is in master) to avoid avoid any abstract declarations of `call` in subclasses from causing type errors. That shouldn't be a problem for this class, though.","created_at":"2018-10-17T23:53:48Z","updated_at":"2018-10-17T23:53:48Z","html_url":"https://github.com/cleandart/react-dart/pull/149#discussion_r226131069","pull_request_url":"https://api.github.com/repos/cleandart/react-dart/pulls/149","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cleandart/react-dart/pulls/comments/226131069"},"html":{"href":"https://github.com/cleandart/react-dart/pull/149#discussion_r226131069"},"pull_request":{"href":"https://api.github.com/repos/cleandart/react-dart/pulls/149"}},"in_reply_to_id":226097433},"pull_request":{"url":"https://api.github.com/repos/cleandart/react-dart/pulls/149","id":223752056,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzNzUyMDU2","html_url":"https://github.com/cleandart/react-dart/pull/149","diff_url":"https://github.com/cleandart/react-dart/pull/149.diff","patch_url":"https://github.com/cleandart/react-dart/pull/149.patch","issue_url":"https://api.github.com/repos/cleandart/react-dart/issues/149","number":149,"state":"open","locked":false,"title":"React 5.0.0-dev.0 RC 1 (Dart 2 Compatibility)","user":{"login":"aaronlademann-wf","id":1750797,"node_id":"MDQ6VXNlcjE3NTA3OTc=","avatar_url":"https://avatars3.githubusercontent.com/u/1750797?v=4","gravatar_id":"","url":"https://api.github.com/users/aaronlademann-wf","html_url":"https://github.com/aaronlademann-wf","followers_url":"https://api.github.com/users/aaronlademann-wf/followers","following_url":"https://api.github.com/users/aaronlademann-wf/following{/other_user}","gists_url":"https://api.github.com/users/aaronlademann-wf/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronlademann-wf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronlademann-wf/subscriptions","organizations_url":"https://api.github.com/users/aaronlademann-wf/orgs","repos_url":"https://api.github.com/users/aaronlademann-wf/repos","events_url":"https://api.github.com/users/aaronlademann-wf/events{/privacy}","received_events_url":"https://api.github.com/users/aaronlademann-wf/received_events","type":"User","site_admin":false},"body":"Big changes (see commits for full list)\r\n\r\n* [x] https://github.com/cleandart/react-dart/pull/149/commits/729a7e6d9b71f17c6b9ffb68852b28c0759aaf78 Make variadic children / `noSuchMethod` dart 2 friendly\r\n* [x] https://github.com/cleandart/react-dart/pull/149/commits/7d0b5cb67cbd17dafd5a797487289f5f4b91ab2b Update deps to utilize dart 2 friendly stuff\r\n* [x] Bump upper SDK bound to `<3.0.0`, lower bound to `>=1.24.3`\r\n\r\n### Testing Suggestions\r\n\r\n1. Pull this branch\r\n2. Switch to the dart 2 sdk locally, and run `pub get`\r\n    1. Run `pub run build_runner test -- -p vm -p chrome`\r\n    All tests should pass\r\n3. Switch to Dart 1.24.3, and run `pub get`\r\n    1. Run `pub run test -p vm -p content-shell`\r\n    All tests should pass.\r\n\r\n---\r\n\r\n@greglittlefield-wf @robbecker-wf @evanweible-wf @corwinsheahan-wf","created_at":"2018-10-17T21:01:09Z","updated_at":"2018-10-17T23:53:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"01255d304017d9ab9b93df0bdd73c103da6f7f5e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cleandart/react-dart/pulls/149/commits","review_comments_url":"https://api.github.com/repos/cleandart/react-dart/pulls/149/comments","review_comment_url":"https://api.github.com/repos/cleandart/react-dart/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cleandart/react-dart/issues/149/comments","statuses_url":"https://api.github.com/repos/cleandart/react-dart/statuses/8db740ea3c70c41c884989667dcbf0d0f123b8ef","head":{"label":"aaronlademann-wf:5.0.0-dev__rc","ref":"5.0.0-dev__rc","sha":"8db740ea3c70c41c884989667dcbf0d0f123b8ef","user":{"login":"aaronlademann-wf","id":1750797,"node_id":"MDQ6VXNlcjE3NTA3OTc=","avatar_url":"https://avatars3.githubusercontent.com/u/1750797?v=4","gravatar_id":"","url":"https://api.github.com/users/aaronlademann-wf","html_url":"https://github.com/aaronlademann-wf","followers_url":"https://api.github.com/users/aaronlademann-wf/followers","following_url":"https://api.github.com/users/aaronlademann-wf/following{/other_user}","gists_url":"https://api.github.com/users/aaronlademann-wf/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronlademann-wf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronlademann-wf/subscriptions","organizations_url":"https://api.github.com/users/aaronlademann-wf/orgs","repos_url":"https://api.github.com/users/aaronlademann-wf/repos","events_url":"https://api.github.com/users/aaronlademann-wf/events{/privacy}","received_events_url":"https://api.github.com/users/aaronlademann-wf/received_events","type":"User","site_admin":false},"repo":{"id":52880424,"node_id":"MDEwOlJlcG9zaXRvcnk1Mjg4MDQyNA==","name":"react-dart","full_name":"aaronlademann-wf/react-dart","private":false,"owner":{"login":"aaronlademann-wf","id":1750797,"node_id":"MDQ6VXNlcjE3NTA3OTc=","avatar_url":"https://avatars3.githubusercontent.com/u/1750797?v=4","gravatar_id":"","url":"https://api.github.com/users/aaronlademann-wf","html_url":"https://github.com/aaronlademann-wf","followers_url":"https://api.github.com/users/aaronlademann-wf/followers","following_url":"https://api.github.com/users/aaronlademann-wf/following{/other_user}","gists_url":"https://api.github.com/users/aaronlademann-wf/gists{/gist_id}","starred_url":"https://api.github.com/users/aaronlademann-wf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaronlademann-wf/subscriptions","organizations_url":"https://api.github.com/users/aaronlademann-wf/orgs","repos_url":"https://api.github.com/users/aaronlademann-wf/repos","events_url":"https://api.github.com/users/aaronlademann-wf/events{/privacy}","received_events_url":"https://api.github.com/users/aaronlademann-wf/received_events","type":"User","site_admin":false},"html_url":"https://github.com/aaronlademann-wf/react-dart","description":"Bindings for React to Dart","fork":true,"url":"https://api.github.com/repos/aaronlademann-wf/react-dart","forks_url":"https://api.github.com/repos/aaronlademann-wf/react-dart/forks","keys_url":"https://api.github.com/repos/aaronlademann-wf/react-dart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aaronlademann-wf/react-dart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aaronlademann-wf/react-dart/teams","hooks_url":"https://api.github.com/repos/aaronlademann-wf/react-dart/hooks","issue_events_url":"https://api.github.com/repos/aaronlademann-wf/react-dart/issues/events{/number}","events_url":"https://api.github.com/repos/aaronlademann-wf/react-dart/events","assignees_url":"https://api.github.com/repos/aaronlademann-wf/react-dart/assignees{/user}","branches_url":"https://api.github.com/repos/aaronlademann-wf/react-dart/branches{/branch}","tags_url":"https://api.github.com/repos/aaronlademann-wf/react-dart/tags","blobs_url":"https://api.github.com/repos/aaronlademann-wf/react-dart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aaronlademann-wf/react-dart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aaronlademann-wf/react-dart/git/refs{/sha}","trees_url":"https://api.github.com/repos/aaronlademann-wf/react-dart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aaronlademann-wf/react-dart/statuses/{sha}","languages_url":"https://api.github.com/repos/aaronlademann-wf/react-dart/languages","stargazers_url":"https://api.github.com/repos/aaronlademann-wf/react-dart/stargazers","contributors_url":"https://api.github.com/repos/aaronlademann-wf/react-dart/contributors","subscribers_url":"https://api.github.com/repos/aaronlademann-wf/react-dart/subscribers","subscription_url":"https://api.github.com/repos/aaronlademann-wf/react-dart/subscription","commits_url":"https://api.github.com/repos/aaronlademann-wf/react-dart/commits{/sha}","git_commits_url":"https://api.github.com/repos/aaronlademann-wf/react-dart/git/commits{/sha}","comments_url":"https://api.github.com/repos/aaronlademann-wf/react-dart/comments{/number}","issue_comment_url":"https://api.github.com/repos/aaronlademann-wf/react-dart/issues/comments{/number}","contents_url":"https://api.github.com/repos/aaronlademann-wf/react-dart/contents/{+path}","compare_url":"https://api.github.com/repos/aaronlademann-wf/react-dart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aaronlademann-wf/react-dart/merges","archive_url":"https://api.github.com/repos/aaronlademann-wf/react-dart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aaronlademann-wf/react-dart/downloads","issues_url":"https://api.github.com/repos/aaronlademann-wf/react-dart/issues{/number}","pulls_url":"https://api.github.com/repos/aaronlademann-wf/react-dart/pulls{/number}","milestones_url":"https://api.github.com/repos/aaronlademann-wf/react-dart/milestones{/number}","notifications_url":"https://api.github.com/repos/aaronlademann-wf/react-dart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aaronlademann-wf/react-dart/labels{/name}","releases_url":"https://api.github.com/repos/aaronlademann-wf/react-dart/releases{/id}","deployments_url":"https://api.github.com/repos/aaronlademann-wf/react-dart/deployments","created_at":"2016-03-01T13:54:03Z","updated_at":"2016-03-01T13:54:04Z","pushed_at":"2018-10-17T20:54:12Z","git_url":"git://github.com/aaronlademann-wf/react-dart.git","ssh_url":"git@github.com:aaronlademann-wf/react-dart.git","clone_url":"https://github.com/aaronlademann-wf/react-dart.git","svn_url":"https://github.com/aaronlademann-wf/react-dart","homepage":null,"size":2627,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cleandart:master","ref":"master","sha":"b868bb8fb42774d5963606d4462af8d10dcd2795","user":{"login":"cleandart","id":5911236,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5MTEyMzY=","avatar_url":"https://avatars1.githubusercontent.com/u/5911236?v=4","gravatar_id":"","url":"https://api.github.com/users/cleandart","html_url":"https://github.com/cleandart","followers_url":"https://api.github.com/users/cleandart/followers","following_url":"https://api.github.com/users/cleandart/following{/other_user}","gists_url":"https://api.github.com/users/cleandart/gists{/gist_id}","starred_url":"https://api.github.com/users/cleandart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cleandart/subscriptions","organizations_url":"https://api.github.com/users/cleandart/orgs","repos_url":"https://api.github.com/users/cleandart/repos","events_url":"https://api.github.com/users/cleandart/events{/privacy}","received_events_url":"https://api.github.com/users/cleandart/received_events","type":"Organization","site_admin":false},"repo":{"id":13674420,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY3NDQyMA==","name":"react-dart","full_name":"cleandart/react-dart","private":false,"owner":{"login":"cleandart","id":5911236,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5MTEyMzY=","avatar_url":"https://avatars1.githubusercontent.com/u/5911236?v=4","gravatar_id":"","url":"https://api.github.com/users/cleandart","html_url":"https://github.com/cleandart","followers_url":"https://api.github.com/users/cleandart/followers","following_url":"https://api.github.com/users/cleandart/following{/other_user}","gists_url":"https://api.github.com/users/cleandart/gists{/gist_id}","starred_url":"https://api.github.com/users/cleandart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cleandart/subscriptions","organizations_url":"https://api.github.com/users/cleandart/orgs","repos_url":"https://api.github.com/users/cleandart/repos","events_url":"https://api.github.com/users/cleandart/events{/privacy}","received_events_url":"https://api.github.com/users/cleandart/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/cleandart/react-dart","description":"Bindings for React to Dart","fork":false,"url":"https://api.github.com/repos/cleandart/react-dart","forks_url":"https://api.github.com/repos/cleandart/react-dart/forks","keys_url":"https://api.github.com/repos/cleandart/react-dart/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cleandart/react-dart/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cleandart/react-dart/teams","hooks_url":"https://api.github.com/repos/cleandart/react-dart/hooks","issue_events_url":"https://api.github.com/repos/cleandart/react-dart/issues/events{/number}","events_url":"https://api.github.com/repos/cleandart/react-dart/events","assignees_url":"https://api.github.com/repos/cleandart/react-dart/assignees{/user}","branches_url":"https://api.github.com/repos/cleandart/react-dart/branches{/branch}","tags_url":"https://api.github.com/repos/cleandart/react-dart/tags","blobs_url":"https://api.github.com/repos/cleandart/react-dart/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cleandart/react-dart/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cleandart/react-dart/git/refs{/sha}","trees_url":"https://api.github.com/repos/cleandart/react-dart/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cleandart/react-dart/statuses/{sha}","languages_url":"https://api.github.com/repos/cleandart/react-dart/languages","stargazers_url":"https://api.github.com/repos/cleandart/react-dart/stargazers","contributors_url":"https://api.github.com/repos/cleandart/react-dart/contributors","subscribers_url":"https://api.github.com/repos/cleandart/react-dart/subscribers","subscription_url":"https://api.github.com/repos/cleandart/react-dart/subscription","commits_url":"https://api.github.com/repos/cleandart/react-dart/commits{/sha}","git_commits_url":"https://api.github.com/repos/cleandart/react-dart/git/commits{/sha}","comments_url":"https://api.github.com/repos/cleandart/react-dart/comments{/number}","issue_comment_url":"https://api.github.com/repos/cleandart/react-dart/issues/comments{/number}","contents_url":"https://api.github.com/repos/cleandart/react-dart/contents/{+path}","compare_url":"https://api.github.com/repos/cleandart/react-dart/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cleandart/react-dart/merges","archive_url":"https://api.github.com/repos/cleandart/react-dart/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cleandart/react-dart/downloads","issues_url":"https://api.github.com/repos/cleandart/react-dart/issues{/number}","pulls_url":"https://api.github.com/repos/cleandart/react-dart/pulls{/number}","milestones_url":"https://api.github.com/repos/cleandart/react-dart/milestones{/number}","notifications_url":"https://api.github.com/repos/cleandart/react-dart/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cleandart/react-dart/labels{/name}","releases_url":"https://api.github.com/repos/cleandart/react-dart/releases{/id}","deployments_url":"https://api.github.com/repos/cleandart/react-dart/deployments","created_at":"2013-10-18T09:40:45Z","updated_at":"2018-09-25T02:30:20Z","pushed_at":"2018-10-17T21:01:10Z","git_url":"git://github.com/cleandart/react-dart.git","ssh_url":"git@github.com:cleandart/react-dart.git","clone_url":"https://github.com/cleandart/react-dart.git","svn_url":"https://github.com/cleandart/react-dart","homepage":null,"size":2794,"stargazers_count":185,"watchers_count":185,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":44,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause","node_id":"MDc6TGljZW5zZTQ="},"forks":44,"open_issues":14,"watchers":185,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cleandart/react-dart/pulls/149"},"html":{"href":"https://github.com/cleandart/react-dart/pull/149"},"issue":{"href":"https://api.github.com/repos/cleandart/react-dart/issues/149"},"comments":{"href":"https://api.github.com/repos/cleandart/react-dart/issues/149/comments"},"review_comments":{"href":"https://api.github.com/repos/cleandart/react-dart/pulls/149/comments"},"review_comment":{"href":"https://api.github.com/repos/cleandart/react-dart/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cleandart/react-dart/pulls/149/commits"},"statuses":{"href":"https://api.github.com/repos/cleandart/react-dart/statuses/8db740ea3c70c41c884989667dcbf0d0f123b8ef"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"greglittlefield-wf"}}