{"action":"created","issue":{"url":"https://api.github.com/repos/YugaByte/yugabyte-db/issues/429","repository_url":"https://api.github.com/repos/YugaByte/yugabyte-db","labels_url":"https://api.github.com/repos/YugaByte/yugabyte-db/issues/429/labels{/name}","comments_url":"https://api.github.com/repos/YugaByte/yugabyte-db/issues/429/comments","events_url":"https://api.github.com/repos/YugaByte/yugabyte-db/issues/429/events","html_url":"https://github.com/YugaByte/yugabyte-db/pull/429","id":349192930,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MzY3Mjk3","number":429,"title":"add SimpleQueryTest CQL testsuite","user":{"login":"ananyaks","id":23710311,"node_id":"MDQ6VXNlcjIzNzEwMzEx","avatar_url":"https://avatars0.githubusercontent.com/u/23710311?v=4","gravatar_id":"","url":"https://api.github.com/users/ananyaks","html_url":"https://github.com/ananyaks","followers_url":"https://api.github.com/users/ananyaks/followers","following_url":"https://api.github.com/users/ananyaks/following{/other_user}","gists_url":"https://api.github.com/users/ananyaks/gists{/gist_id}","starred_url":"https://api.github.com/users/ananyaks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ananyaks/subscriptions","organizations_url":"https://api.github.com/users/ananyaks/orgs","repos_url":"https://api.github.com/users/ananyaks/repos","events_url":"https://api.github.com/users/ananyaks/events{/privacy}","received_events_url":"https://api.github.com/users/ananyaks/received_events","type":"User","site_admin":false},"labels":[{"id":711841624,"node_id":"MDU6TGFiZWw3MTE4NDE2MjQ=","url":"https://api.github.com/repos/YugaByte/yugabyte-db/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2018-08-09T16:05:10Z","updated_at":"2018-08-15T05:02:33Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/YugaByte/yugabyte-db/pulls/429","html_url":"https://github.com/YugaByte/yugabyte-db/pull/429","diff_url":"https://github.com/YugaByte/yugabyte-db/pull/429.diff","patch_url":"https://github.com/YugaByte/yugabyte-db/pull/429.patch"},"body":"This pull request is for adding SimpleQueryTest suite to Yugabyte-DB's CQL testsuite. I have successfully run the first 7 tests of Cassandra's CQL test suite SimpleQueryTest.java (under Apache license) with Yugabyte-DB. The changes I had to make are as follows:\r\n\r\n**SimpleQueryTest.java**  \r\n\r\nThis is a testsuite with many individual tests. The first 7 tests currently run fine, the rest are commented out for now. Goal was to keep the changes to this file to the minimum so that new individual tests can be run easily. The changes to this file are:\r\n\r\n- replaced the inclusion of cassandra package with org.yb.cql\r\n- calls to flush() has been commented out, as I do not know the equivalent in Yugabyte-DB. The flush() in Cassandra's testsuite is a public method of CQLTester base class that calls the ColumnFamilyStore method forceBlockingFlush()\r\n\r\n**CQLTester.java**\r\nThe class SimpleQueryTest inherits from CQLTester. I modified CQLTester.java (also under Apache license) much more to only include the minimum necessary to successfully compile and run SimpleQueryTest. These modifications were important for  keeping the changes in SimpleQueryTest to be minimum. The CQLTester.java changes are:\r\n\r\n- import yugabyte-db relevant classes/package\r\n- made CQLTester a sub-class of BaseCQLTest to pull in yugabyte-db boilerplate\r\n- modified createTable and execute methods to provide the behavior expected by the individual tests in SimpleQueryTest. For example, the individual tests do not hardcode the table name instead it gets generated. During execution of statements (e.g. select, insert) the CQL statement string gets built with the looked up table name\r\n- modified assertRows() methods which is an easy way to verify the rows inserted/deleted match the rows selected. This method required more modifications\r\n- a comparison with Cassandra's CQLTester.java can be used to understand the modifications\r\n\r\nThanks!"},"comment":{"url":"https://api.github.com/repos/YugaByte/yugabyte-db/issues/comments/413094935","html_url":"https://github.com/YugaByte/yugabyte-db/pull/429#issuecomment-413094935","issue_url":"https://api.github.com/repos/YugaByte/yugabyte-db/issues/429","id":413094935,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMzA5NDkzNQ==","user":{"login":"ananyaks","id":23710311,"node_id":"MDQ6VXNlcjIzNzEwMzEx","avatar_url":"https://avatars0.githubusercontent.com/u/23710311?v=4","gravatar_id":"","url":"https://api.github.com/users/ananyaks","html_url":"https://github.com/ananyaks","followers_url":"https://api.github.com/users/ananyaks/followers","following_url":"https://api.github.com/users/ananyaks/following{/other_user}","gists_url":"https://api.github.com/users/ananyaks/gists{/gist_id}","starred_url":"https://api.github.com/users/ananyaks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ananyaks/subscriptions","organizations_url":"https://api.github.com/users/ananyaks/orgs","repos_url":"https://api.github.com/users/ananyaks/repos","events_url":"https://api.github.com/users/ananyaks/events{/privacy}","received_events_url":"https://api.github.com/users/ananyaks/received_events","type":"User","site_admin":false},"created_at":"2018-08-15T05:02:33Z","updated_at":"2018-08-15T05:02:33Z","author_association":"NONE","body":"Hi @mbautin, I have signed the CLA.\r\nThanks!"}}
{"actor":{"display_login":"ananyaks"}}