{"action":"created","comment":{"url":"https://api.github.com/repos/unlock-protocol/unlock/pulls/comments/226285767","pull_request_review_id":166068460,"id":226285767,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjI4NTc2Nw==","diff_hunk":"@@ -3,19 +3,24 @@\n   \"version\": \"0.1.0\",\n   \"private\": true,\n   \"dependencies\": {\n+    \"@babel/core\": \"^7.1.2\",","path":"unlock-app/package.json","position":4,"original_position":4,"commit_id":"0943222d2ab841453c4cbc0952de0f039d413aec","original_commit_id":"0943222d2ab841453c4cbc0952de0f039d413aec","user":{"login":"asood123","id":6106941,"node_id":"MDQ6VXNlcjYxMDY5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/6106941?v=4","gravatar_id":"","url":"https://api.github.com/users/asood123","html_url":"https://github.com/asood123","followers_url":"https://api.github.com/users/asood123/followers","following_url":"https://api.github.com/users/asood123/following{/other_user}","gists_url":"https://api.github.com/users/asood123/gists{/gist_id}","starred_url":"https://api.github.com/users/asood123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asood123/subscriptions","organizations_url":"https://api.github.com/users/asood123/orgs","repos_url":"https://api.github.com/users/asood123/repos","events_url":"https://api.github.com/users/asood123/events{/privacy}","received_events_url":"https://api.github.com/users/asood123/received_events","type":"User","site_admin":false},"body":"FYI, have generally found that locking in version numbers (by removing carat) saves a lot of hassle later when a random package will upgrade itself on a deployment and cause unknown issues.","created_at":"2018-10-18T12:33:57Z","updated_at":"2018-10-18T12:33:58Z","html_url":"https://github.com/unlock-protocol/unlock/pull/352#discussion_r226285767","pull_request_url":"https://api.github.com/repos/unlock-protocol/unlock/pulls/352","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/unlock-protocol/unlock/pulls/comments/226285767"},"html":{"href":"https://github.com/unlock-protocol/unlock/pull/352#discussion_r226285767"},"pull_request":{"href":"https://api.github.com/repos/unlock-protocol/unlock/pulls/352"}}},"pull_request":{"url":"https://api.github.com/repos/unlock-protocol/unlock/pulls/352","id":222675830,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNjc1ODMw","html_url":"https://github.com/unlock-protocol/unlock/pull/352","diff_url":"https://github.com/unlock-protocol/unlock/pull/352.diff","patch_url":"https://github.com/unlock-protocol/unlock/pull/352.patch","issue_url":"https://api.github.com/repos/unlock-protocol/unlock/issues/352","number":352,"state":"open","locked":false,"title":"Migrate to Next.js","user":{"login":"hakimelek","id":1974993,"node_id":"MDQ6VXNlcjE5NzQ5OTM=","avatar_url":"https://avatars1.githubusercontent.com/u/1974993?v=4","gravatar_id":"","url":"https://api.github.com/users/hakimelek","html_url":"https://github.com/hakimelek","followers_url":"https://api.github.com/users/hakimelek/followers","following_url":"https://api.github.com/users/hakimelek/following{/other_user}","gists_url":"https://api.github.com/users/hakimelek/gists{/gist_id}","starred_url":"https://api.github.com/users/hakimelek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hakimelek/subscriptions","organizations_url":"https://api.github.com/users/hakimelek/orgs","repos_url":"https://api.github.com/users/hakimelek/repos","events_url":"https://api.github.com/users/hakimelek/events{/privacy}","received_events_url":"https://api.github.com/users/hakimelek/received_events","type":"User","site_admin":false},"body":"This PR should add support for SSR and some other features, it should resolve #310.\r\n\r\nIt should do the following:\r\n- [X] Replace create-react-app with Next.js.\r\n- [X] Move page components into `pages` folder structure.\r\n- [X] Replace all `Link` from react-router to Next.js.\r\n- [X] Move static file from `public` to `static` folder as recommended by Next.\r\n- [X] Main routes are rendering fine.\r\n- [X] Redux integration.\r\n- [X] Network dependent components are not being rendered on the server. \r\n- [X] Working production build.\r\n- [x] Dynamic routes such as `/lock/:lockaddress` are working\r\n- [x] All tests are passing.\r\n- [x] Stories in storybook are working fine.\r\n- [ ] Add withConfig tests.","created_at":"2018-10-13T21:03:26Z","updated_at":"2018-10-18T12:33:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3f111d51002d6a4c4a7811ca78495444863b74fb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/unlock-protocol/unlock/pulls/352/commits","review_comments_url":"https://api.github.com/repos/unlock-protocol/unlock/pulls/352/comments","review_comment_url":"https://api.github.com/repos/unlock-protocol/unlock/pulls/comments{/number}","comments_url":"https://api.github.com/repos/unlock-protocol/unlock/issues/352/comments","statuses_url":"https://api.github.com/repos/unlock-protocol/unlock/statuses/0943222d2ab841453c4cbc0952de0f039d413aec","head":{"label":"hakimelek:feat/nextjs","ref":"feat/nextjs","sha":"0943222d2ab841453c4cbc0952de0f039d413aec","user":{"login":"hakimelek","id":1974993,"node_id":"MDQ6VXNlcjE5NzQ5OTM=","avatar_url":"https://avatars1.githubusercontent.com/u/1974993?v=4","gravatar_id":"","url":"https://api.github.com/users/hakimelek","html_url":"https://github.com/hakimelek","followers_url":"https://api.github.com/users/hakimelek/followers","following_url":"https://api.github.com/users/hakimelek/following{/other_user}","gists_url":"https://api.github.com/users/hakimelek/gists{/gist_id}","starred_url":"https://api.github.com/users/hakimelek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hakimelek/subscriptions","organizations_url":"https://api.github.com/users/hakimelek/orgs","repos_url":"https://api.github.com/users/hakimelek/repos","events_url":"https://api.github.com/users/hakimelek/events{/privacy}","received_events_url":"https://api.github.com/users/hakimelek/received_events","type":"User","site_admin":false},"repo":{"id":152820284,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI4MjAyODQ=","name":"unlock","full_name":"hakimelek/unlock","private":false,"owner":{"login":"hakimelek","id":1974993,"node_id":"MDQ6VXNlcjE5NzQ5OTM=","avatar_url":"https://avatars1.githubusercontent.com/u/1974993?v=4","gravatar_id":"","url":"https://api.github.com/users/hakimelek","html_url":"https://github.com/hakimelek","followers_url":"https://api.github.com/users/hakimelek/followers","following_url":"https://api.github.com/users/hakimelek/following{/other_user}","gists_url":"https://api.github.com/users/hakimelek/gists{/gist_id}","starred_url":"https://api.github.com/users/hakimelek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hakimelek/subscriptions","organizations_url":"https://api.github.com/users/hakimelek/orgs","repos_url":"https://api.github.com/users/hakimelek/repos","events_url":"https://api.github.com/users/hakimelek/events{/privacy}","received_events_url":"https://api.github.com/users/hakimelek/received_events","type":"User","site_admin":false},"html_url":"https://github.com/hakimelek/unlock","description":"Unlock is the web's new business model","fork":true,"url":"https://api.github.com/repos/hakimelek/unlock","forks_url":"https://api.github.com/repos/hakimelek/unlock/forks","keys_url":"https://api.github.com/repos/hakimelek/unlock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hakimelek/unlock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hakimelek/unlock/teams","hooks_url":"https://api.github.com/repos/hakimelek/unlock/hooks","issue_events_url":"https://api.github.com/repos/hakimelek/unlock/issues/events{/number}","events_url":"https://api.github.com/repos/hakimelek/unlock/events","assignees_url":"https://api.github.com/repos/hakimelek/unlock/assignees{/user}","branches_url":"https://api.github.com/repos/hakimelek/unlock/branches{/branch}","tags_url":"https://api.github.com/repos/hakimelek/unlock/tags","blobs_url":"https://api.github.com/repos/hakimelek/unlock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hakimelek/unlock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hakimelek/unlock/git/refs{/sha}","trees_url":"https://api.github.com/repos/hakimelek/unlock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hakimelek/unlock/statuses/{sha}","languages_url":"https://api.github.com/repos/hakimelek/unlock/languages","stargazers_url":"https://api.github.com/repos/hakimelek/unlock/stargazers","contributors_url":"https://api.github.com/repos/hakimelek/unlock/contributors","subscribers_url":"https://api.github.com/repos/hakimelek/unlock/subscribers","subscription_url":"https://api.github.com/repos/hakimelek/unlock/subscription","commits_url":"https://api.github.com/repos/hakimelek/unlock/commits{/sha}","git_commits_url":"https://api.github.com/repos/hakimelek/unlock/git/commits{/sha}","comments_url":"https://api.github.com/repos/hakimelek/unlock/comments{/number}","issue_comment_url":"https://api.github.com/repos/hakimelek/unlock/issues/comments{/number}","contents_url":"https://api.github.com/repos/hakimelek/unlock/contents/{+path}","compare_url":"https://api.github.com/repos/hakimelek/unlock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hakimelek/unlock/merges","archive_url":"https://api.github.com/repos/hakimelek/unlock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hakimelek/unlock/downloads","issues_url":"https://api.github.com/repos/hakimelek/unlock/issues{/number}","pulls_url":"https://api.github.com/repos/hakimelek/unlock/pulls{/number}","milestones_url":"https://api.github.com/repos/hakimelek/unlock/milestones{/number}","notifications_url":"https://api.github.com/repos/hakimelek/unlock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hakimelek/unlock/labels{/name}","releases_url":"https://api.github.com/repos/hakimelek/unlock/releases{/id}","deployments_url":"https://api.github.com/repos/hakimelek/unlock/deployments","created_at":"2018-10-13T00:21:53Z","updated_at":"2018-10-13T00:21:56Z","pushed_at":"2018-10-18T01:43:34Z","git_url":"git://github.com/hakimelek/unlock.git","ssh_url":"git@github.com:hakimelek/unlock.git","clone_url":"https://github.com/hakimelek/unlock.git","svn_url":"https://github.com/hakimelek/unlock","homepage":"https://unlock-protocol.com","size":8051,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"unlock-protocol:master","ref":"master","sha":"daf8d3b1769e3f989e1c0c81ab38443adf51f881","user":{"login":"unlock-protocol","id":36645693,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NjQ1Njkz","avatar_url":"https://avatars2.githubusercontent.com/u/36645693?v=4","gravatar_id":"","url":"https://api.github.com/users/unlock-protocol","html_url":"https://github.com/unlock-protocol","followers_url":"https://api.github.com/users/unlock-protocol/followers","following_url":"https://api.github.com/users/unlock-protocol/following{/other_user}","gists_url":"https://api.github.com/users/unlock-protocol/gists{/gist_id}","starred_url":"https://api.github.com/users/unlock-protocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unlock-protocol/subscriptions","organizations_url":"https://api.github.com/users/unlock-protocol/orgs","repos_url":"https://api.github.com/users/unlock-protocol/repos","events_url":"https://api.github.com/users/unlock-protocol/events{/privacy}","received_events_url":"https://api.github.com/users/unlock-protocol/received_events","type":"Organization","site_admin":false},"repo":{"id":112683472,"node_id":"MDEwOlJlcG9zaXRvcnkxMTI2ODM0NzI=","name":"unlock","full_name":"unlock-protocol/unlock","private":false,"owner":{"login":"unlock-protocol","id":36645693,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NjQ1Njkz","avatar_url":"https://avatars2.githubusercontent.com/u/36645693?v=4","gravatar_id":"","url":"https://api.github.com/users/unlock-protocol","html_url":"https://github.com/unlock-protocol","followers_url":"https://api.github.com/users/unlock-protocol/followers","following_url":"https://api.github.com/users/unlock-protocol/following{/other_user}","gists_url":"https://api.github.com/users/unlock-protocol/gists{/gist_id}","starred_url":"https://api.github.com/users/unlock-protocol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/unlock-protocol/subscriptions","organizations_url":"https://api.github.com/users/unlock-protocol/orgs","repos_url":"https://api.github.com/users/unlock-protocol/repos","events_url":"https://api.github.com/users/unlock-protocol/events{/privacy}","received_events_url":"https://api.github.com/users/unlock-protocol/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/unlock-protocol/unlock","description":"Unlock is the web's new business model","fork":false,"url":"https://api.github.com/repos/unlock-protocol/unlock","forks_url":"https://api.github.com/repos/unlock-protocol/unlock/forks","keys_url":"https://api.github.com/repos/unlock-protocol/unlock/keys{/key_id}","collaborators_url":"https://api.github.com/repos/unlock-protocol/unlock/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/unlock-protocol/unlock/teams","hooks_url":"https://api.github.com/repos/unlock-protocol/unlock/hooks","issue_events_url":"https://api.github.com/repos/unlock-protocol/unlock/issues/events{/number}","events_url":"https://api.github.com/repos/unlock-protocol/unlock/events","assignees_url":"https://api.github.com/repos/unlock-protocol/unlock/assignees{/user}","branches_url":"https://api.github.com/repos/unlock-protocol/unlock/branches{/branch}","tags_url":"https://api.github.com/repos/unlock-protocol/unlock/tags","blobs_url":"https://api.github.com/repos/unlock-protocol/unlock/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/unlock-protocol/unlock/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/unlock-protocol/unlock/git/refs{/sha}","trees_url":"https://api.github.com/repos/unlock-protocol/unlock/git/trees{/sha}","statuses_url":"https://api.github.com/repos/unlock-protocol/unlock/statuses/{sha}","languages_url":"https://api.github.com/repos/unlock-protocol/unlock/languages","stargazers_url":"https://api.github.com/repos/unlock-protocol/unlock/stargazers","contributors_url":"https://api.github.com/repos/unlock-protocol/unlock/contributors","subscribers_url":"https://api.github.com/repos/unlock-protocol/unlock/subscribers","subscription_url":"https://api.github.com/repos/unlock-protocol/unlock/subscription","commits_url":"https://api.github.com/repos/unlock-protocol/unlock/commits{/sha}","git_commits_url":"https://api.github.com/repos/unlock-protocol/unlock/git/commits{/sha}","comments_url":"https://api.github.com/repos/unlock-protocol/unlock/comments{/number}","issue_comment_url":"https://api.github.com/repos/unlock-protocol/unlock/issues/comments{/number}","contents_url":"https://api.github.com/repos/unlock-protocol/unlock/contents/{+path}","compare_url":"https://api.github.com/repos/unlock-protocol/unlock/compare/{base}...{head}","merges_url":"https://api.github.com/repos/unlock-protocol/unlock/merges","archive_url":"https://api.github.com/repos/unlock-protocol/unlock/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/unlock-protocol/unlock/downloads","issues_url":"https://api.github.com/repos/unlock-protocol/unlock/issues{/number}","pulls_url":"https://api.github.com/repos/unlock-protocol/unlock/pulls{/number}","milestones_url":"https://api.github.com/repos/unlock-protocol/unlock/milestones{/number}","notifications_url":"https://api.github.com/repos/unlock-protocol/unlock/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/unlock-protocol/unlock/labels{/name}","releases_url":"https://api.github.com/repos/unlock-protocol/unlock/releases{/id}","deployments_url":"https://api.github.com/repos/unlock-protocol/unlock/deployments","created_at":"2017-12-01T02:08:01Z","updated_at":"2018-10-17T13:38:51Z","pushed_at":"2018-10-18T01:43:36Z","git_url":"git://github.com/unlock-protocol/unlock.git","ssh_url":"git@github.com:unlock-protocol/unlock.git","clone_url":"https://github.com/unlock-protocol/unlock.git","svn_url":"https://github.com/unlock-protocol/unlock","homepage":"https://unlock-protocol.com","size":7868,"stargazers_count":35,"watchers_count":35,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":30,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":13,"open_issues":30,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/unlock-protocol/unlock/pulls/352"},"html":{"href":"https://github.com/unlock-protocol/unlock/pull/352"},"issue":{"href":"https://api.github.com/repos/unlock-protocol/unlock/issues/352"},"comments":{"href":"https://api.github.com/repos/unlock-protocol/unlock/issues/352/comments"},"review_comments":{"href":"https://api.github.com/repos/unlock-protocol/unlock/pulls/352/comments"},"review_comment":{"href":"https://api.github.com/repos/unlock-protocol/unlock/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/unlock-protocol/unlock/pulls/352/commits"},"statuses":{"href":"https://api.github.com/repos/unlock-protocol/unlock/statuses/0943222d2ab841453c4cbc0952de0f039d413aec"}},"author_association":"NONE"}}
{"actor":{"display_login":"asood123"}}