{"action":"created","comment":{"url":"https://api.github.com/repos/PolymathNetwork/polymath-core/pulls/comments/240522159","pull_request_review_id":183568944,"id":240522159,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDUyMjE1OQ==","diff_hunk":"@@ -19,20 +19,19 @@ contract ManualApprovalTransferManager is ITransferManager {\n \n     //Manual approval is an allowance (that has been approved) with an expiry time\n     struct ManualApproval {\n+        address from;\n+        address to;\n         uint256 allowance;\n         uint256 expiryTime;\n-    }\n-\n-    //Manual blocking allows you to specify a list of blocked address pairs with an associated expiry time for the block\n-    struct ManualBlocking {\n-        uint256 expiryTime;\n+        bytes32 description;","path":"contracts/modules/TransferManager/ManualApprovalTransferManager.sol","position":22,"original_position":22,"commit_id":"46c9cddd561f1072abac4d409d5c5998becca2f3","original_commit_id":"46c9cddd561f1072abac4d409d5c5998becca2f3","user":{"login":"satyamakgec","id":14581509,"node_id":"MDQ6VXNlcjE0NTgxNTA5","avatar_url":"https://avatars1.githubusercontent.com/u/14581509?v=4","gravatar_id":"","url":"https://api.github.com/users/satyamakgec","html_url":"https://github.com/satyamakgec","followers_url":"https://api.github.com/users/satyamakgec/followers","following_url":"https://api.github.com/users/satyamakgec/following{/other_user}","gists_url":"https://api.github.com/users/satyamakgec/gists{/gist_id}","starred_url":"https://api.github.com/users/satyamakgec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/satyamakgec/subscriptions","organizations_url":"https://api.github.com/users/satyamakgec/orgs","repos_url":"https://api.github.com/users/satyamakgec/repos","events_url":"https://api.github.com/users/satyamakgec/events{/privacy}","received_events_url":"https://api.github.com/users/satyamakgec/received_events","type":"User","site_admin":false},"body":"I already changed it to string during improving the test cases","created_at":"2018-12-11T09:07:24Z","updated_at":"2018-12-11T09:07:24Z","html_url":"https://github.com/PolymathNetwork/polymath-core/pull/450#discussion_r240522159","pull_request_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/pulls/450","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/PolymathNetwork/polymath-core/pulls/comments/240522159"},"html":{"href":"https://github.com/PolymathNetwork/polymath-core/pull/450#discussion_r240522159"},"pull_request":{"href":"https://api.github.com/repos/PolymathNetwork/polymath-core/pulls/450"}},"in_reply_to_id":240514120},"pull_request":{"url":"https://api.github.com/repos/PolymathNetwork/polymath-core/pulls/450","id":235407094,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1NDA3MDk0","html_url":"https://github.com/PolymathNetwork/polymath-core/pull/450","diff_url":"https://github.com/PolymathNetwork/polymath-core/pull/450.diff","patch_url":"https://github.com/PolymathNetwork/polymath-core/pull/450.patch","issue_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/issues/450","number":450,"state":"open","locked":false,"title":"Remove blocking matm","user":{"login":"comeonbuddy","id":13462174,"node_id":"MDQ6VXNlcjEzNDYyMTc0","avatar_url":"https://avatars3.githubusercontent.com/u/13462174?v=4","gravatar_id":"","url":"https://api.github.com/users/comeonbuddy","html_url":"https://github.com/comeonbuddy","followers_url":"https://api.github.com/users/comeonbuddy/followers","following_url":"https://api.github.com/users/comeonbuddy/following{/other_user}","gists_url":"https://api.github.com/users/comeonbuddy/gists{/gist_id}","starred_url":"https://api.github.com/users/comeonbuddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/comeonbuddy/subscriptions","organizations_url":"https://api.github.com/users/comeonbuddy/orgs","repos_url":"https://api.github.com/users/comeonbuddy/repos","events_url":"https://api.github.com/users/comeonbuddy/events{/privacy}","received_events_url":"https://api.github.com/users/comeonbuddy/received_events","type":"User","site_admin":false},"body":"### Please check if the PR fulfills these requirements\r\n- [ x] The commit message follows our Submission guidelines\r\n- [ x] Tests for the changes have been added (for bug fixes / features)\r\n- [ ] Docs have been added / updated (for bug fixes / features)\r\n\r\n\r\n### What kind of change does this PR introduce? \r\nremove all the blocking related functions and events in MATM\r\n\r\n\r\n### What is the current behavior? \r\ncurrently allows blocking a pair of address from transacting\r\n\r\n\r\n### What is the new behavior?\r\nremove the blocking function\r\n\r\n### Does this PR introduce a breaking change?\r\nno\r\n\r\n\r\n### Any Other information:\r\n","created_at":"2018-12-03T11:06:20Z","updated_at":"2018-12-11T09:07:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aa6a6cbd8641ea9a79a12f3cb69637c7b4c992c1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/pulls/450/commits","review_comments_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/pulls/450/comments","review_comment_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/issues/450/comments","statuses_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/statuses/46c9cddd561f1072abac4d409d5c5998becca2f3","head":{"label":"PolymathNetwork:remove-blocking-MATM","ref":"remove-blocking-MATM","sha":"46c9cddd561f1072abac4d409d5c5998becca2f3","user":{"login":"PolymathNetwork","id":30353617,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMzUzNjE3","avatar_url":"https://avatars0.githubusercontent.com/u/30353617?v=4","gravatar_id":"","url":"https://api.github.com/users/PolymathNetwork","html_url":"https://github.com/PolymathNetwork","followers_url":"https://api.github.com/users/PolymathNetwork/followers","following_url":"https://api.github.com/users/PolymathNetwork/following{/other_user}","gists_url":"https://api.github.com/users/PolymathNetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymathNetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymathNetwork/subscriptions","organizations_url":"https://api.github.com/users/PolymathNetwork/orgs","repos_url":"https://api.github.com/users/PolymathNetwork/repos","events_url":"https://api.github.com/users/PolymathNetwork/events{/privacy}","received_events_url":"https://api.github.com/users/PolymathNetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":124091457,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQwOTE0NTc=","name":"polymath-core","full_name":"PolymathNetwork/polymath-core","private":false,"owner":{"login":"PolymathNetwork","id":30353617,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMzUzNjE3","avatar_url":"https://avatars0.githubusercontent.com/u/30353617?v=4","gravatar_id":"","url":"https://api.github.com/users/PolymathNetwork","html_url":"https://github.com/PolymathNetwork","followers_url":"https://api.github.com/users/PolymathNetwork/followers","following_url":"https://api.github.com/users/PolymathNetwork/following{/other_user}","gists_url":"https://api.github.com/users/PolymathNetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymathNetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymathNetwork/subscriptions","organizations_url":"https://api.github.com/users/PolymathNetwork/orgs","repos_url":"https://api.github.com/users/PolymathNetwork/repos","events_url":"https://api.github.com/users/PolymathNetwork/events{/privacy}","received_events_url":"https://api.github.com/users/PolymathNetwork/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PolymathNetwork/polymath-core","description":"Core Ethereum Smart Contracts for Polymath - The Securities Token Platform","fork":false,"url":"https://api.github.com/repos/PolymathNetwork/polymath-core","forks_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/forks","keys_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/teams","hooks_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/hooks","issue_events_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/issues/events{/number}","events_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/events","assignees_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/assignees{/user}","branches_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/branches{/branch}","tags_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/tags","blobs_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/statuses/{sha}","languages_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/languages","stargazers_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/stargazers","contributors_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/contributors","subscribers_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/subscribers","subscription_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/subscription","commits_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/contents/{+path}","compare_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/merges","archive_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/downloads","issues_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/issues{/number}","pulls_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/pulls{/number}","milestones_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/milestones{/number}","notifications_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/labels{/name}","releases_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/releases{/id}","deployments_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/deployments","created_at":"2018-03-06T14:37:11Z","updated_at":"2018-12-10T05:35:41Z","pushed_at":"2018-12-11T05:57:06Z","git_url":"git://github.com/PolymathNetwork/polymath-core.git","ssh_url":"git@github.com:PolymathNetwork/polymath-core.git","clone_url":"https://github.com/PolymathNetwork/polymath-core.git","svn_url":"https://github.com/PolymathNetwork/polymath-core","homepage":"http://polymath.network","size":8055,"stargazers_count":180,"watchers_count":180,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":70,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":70,"open_issues":28,"watchers":180,"default_branch":"master"}},"base":{"label":"PolymathNetwork:dev-2.1.0","ref":"dev-2.1.0","sha":"f2a1ccebaf32655c73803b1a20d353693fa9e3e8","user":{"login":"PolymathNetwork","id":30353617,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMzUzNjE3","avatar_url":"https://avatars0.githubusercontent.com/u/30353617?v=4","gravatar_id":"","url":"https://api.github.com/users/PolymathNetwork","html_url":"https://github.com/PolymathNetwork","followers_url":"https://api.github.com/users/PolymathNetwork/followers","following_url":"https://api.github.com/users/PolymathNetwork/following{/other_user}","gists_url":"https://api.github.com/users/PolymathNetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymathNetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymathNetwork/subscriptions","organizations_url":"https://api.github.com/users/PolymathNetwork/orgs","repos_url":"https://api.github.com/users/PolymathNetwork/repos","events_url":"https://api.github.com/users/PolymathNetwork/events{/privacy}","received_events_url":"https://api.github.com/users/PolymathNetwork/received_events","type":"Organization","site_admin":false},"repo":{"id":124091457,"node_id":"MDEwOlJlcG9zaXRvcnkxMjQwOTE0NTc=","name":"polymath-core","full_name":"PolymathNetwork/polymath-core","private":false,"owner":{"login":"PolymathNetwork","id":30353617,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwMzUzNjE3","avatar_url":"https://avatars0.githubusercontent.com/u/30353617?v=4","gravatar_id":"","url":"https://api.github.com/users/PolymathNetwork","html_url":"https://github.com/PolymathNetwork","followers_url":"https://api.github.com/users/PolymathNetwork/followers","following_url":"https://api.github.com/users/PolymathNetwork/following{/other_user}","gists_url":"https://api.github.com/users/PolymathNetwork/gists{/gist_id}","starred_url":"https://api.github.com/users/PolymathNetwork/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PolymathNetwork/subscriptions","organizations_url":"https://api.github.com/users/PolymathNetwork/orgs","repos_url":"https://api.github.com/users/PolymathNetwork/repos","events_url":"https://api.github.com/users/PolymathNetwork/events{/privacy}","received_events_url":"https://api.github.com/users/PolymathNetwork/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PolymathNetwork/polymath-core","description":"Core Ethereum Smart Contracts for Polymath - The Securities Token Platform","fork":false,"url":"https://api.github.com/repos/PolymathNetwork/polymath-core","forks_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/forks","keys_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/teams","hooks_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/hooks","issue_events_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/issues/events{/number}","events_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/events","assignees_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/assignees{/user}","branches_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/branches{/branch}","tags_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/tags","blobs_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/statuses/{sha}","languages_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/languages","stargazers_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/stargazers","contributors_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/contributors","subscribers_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/subscribers","subscription_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/subscription","commits_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/contents/{+path}","compare_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/merges","archive_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/downloads","issues_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/issues{/number}","pulls_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/pulls{/number}","milestones_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/milestones{/number}","notifications_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/labels{/name}","releases_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/releases{/id}","deployments_url":"https://api.github.com/repos/PolymathNetwork/polymath-core/deployments","created_at":"2018-03-06T14:37:11Z","updated_at":"2018-12-10T05:35:41Z","pushed_at":"2018-12-11T05:57:06Z","git_url":"git://github.com/PolymathNetwork/polymath-core.git","ssh_url":"git@github.com:PolymathNetwork/polymath-core.git","clone_url":"https://github.com/PolymathNetwork/polymath-core.git","svn_url":"https://github.com/PolymathNetwork/polymath-core","homepage":"http://polymath.network","size":8055,"stargazers_count":180,"watchers_count":180,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":70,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":70,"open_issues":28,"watchers":180,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PolymathNetwork/polymath-core/pulls/450"},"html":{"href":"https://github.com/PolymathNetwork/polymath-core/pull/450"},"issue":{"href":"https://api.github.com/repos/PolymathNetwork/polymath-core/issues/450"},"comments":{"href":"https://api.github.com/repos/PolymathNetwork/polymath-core/issues/450/comments"},"review_comments":{"href":"https://api.github.com/repos/PolymathNetwork/polymath-core/pulls/450/comments"},"review_comment":{"href":"https://api.github.com/repos/PolymathNetwork/polymath-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PolymathNetwork/polymath-core/pulls/450/commits"},"statuses":{"href":"https://api.github.com/repos/PolymathNetwork/polymath-core/statuses/46c9cddd561f1072abac4d409d5c5998becca2f3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"satyamakgec"}}