{"action":"created","issue":{"url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/issues/6712","repository_url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs","labels_url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/issues/6712/labels{/name}","comments_url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/issues/6712/comments","events_url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/issues/6712/events","html_url":"https://github.com/easybuilders/easybuild-easyconfigs/pull/6712","id":351111616,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4Nzg2Njg1","number":6712,"title":"add Java 1.8 easyconfig that can be updated in-place to more recent JDK 1.8.x","user":{"login":"boegel","id":620876,"node_id":"MDQ6VXNlcjYyMDg3Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/620876?v=4","gravatar_id":"","url":"https://api.github.com/users/boegel","html_url":"https://github.com/boegel","followers_url":"https://api.github.com/users/boegel/followers","following_url":"https://api.github.com/users/boegel/following{/other_user}","gists_url":"https://api.github.com/users/boegel/gists{/gist_id}","starred_url":"https://api.github.com/users/boegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boegel/subscriptions","organizations_url":"https://api.github.com/users/boegel/orgs","repos_url":"https://api.github.com/users/boegel/repos","events_url":"https://api.github.com/users/boegel/events{/privacy}","received_events_url":"https://api.github.com/users/boegel/received_events","type":"User","site_admin":false},"labels":[{"id":735127607,"node_id":"MDU6TGFiZWw3MzUxMjc2MDc=","url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/labels/change","name":"change","color":"ffdb4d","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/milestones/53","html_url":"https://github.com/easybuilders/easybuild-easyconfigs/milestone/53","labels_url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/milestones/53/labels","id":3477811,"node_id":"MDk6TWlsZXN0b25lMzQ3NzgxMQ==","number":53,"title":"3.7.0","description":"","creator":{"login":"boegel","id":620876,"node_id":"MDQ6VXNlcjYyMDg3Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/620876?v=4","gravatar_id":"","url":"https://api.github.com/users/boegel","html_url":"https://github.com/boegel","followers_url":"https://api.github.com/users/boegel/followers","following_url":"https://api.github.com/users/boegel/following{/other_user}","gists_url":"https://api.github.com/users/boegel/gists{/gist_id}","starred_url":"https://api.github.com/users/boegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boegel/subscriptions","organizations_url":"https://api.github.com/users/boegel/orgs","repos_url":"https://api.github.com/users/boegel/repos","events_url":"https://api.github.com/users/boegel/events{/privacy}","received_events_url":"https://api.github.com/users/boegel/received_events","type":"User","site_admin":false},"open_issues":51,"closed_issues":154,"state":"open","created_at":"2018-07-06T08:57:05Z","updated_at":"2018-08-23T19:13:35Z","due_on":"2018-09-05T07:00:00Z","closed_at":null},"comments":8,"created_at":"2018-08-16T08:47:39Z","updated_at":"2018-08-23T20:02:55Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/pulls/6712","html_url":"https://github.com/easybuilders/easybuild-easyconfigs/pull/6712","diff_url":"https://github.com/easybuilders/easybuild-easyconfigs/pull/6712.diff","patch_url":"https://github.com/easybuilders/easybuild-easyconfigs/pull/6712.patch"},"body":"cfr. discussion in #5203\r\n\r\nI feel we should use this approach going forward (starting with the `*2018b*` toolchain generation), but we shouldn't change older easyconfigs to also adapt to this policy since that will lead to too much confusion.\r\nWe can easily switch to this policy for the `2018b` toolchain generation since currently only 1 easyconfig already merged in `develop` is affected (`Bazel`), and it wasn't included in an EasyBuild release yet.\r\n\r\ncc @JackPerdue \r\n\r\n@verdurin, @vanzod: Since you were critical about following this approach, I'd like to hear back from you before this gets merged..."},"comment":{"url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/issues/comments/415553159","html_url":"https://github.com/easybuilders/easybuild-easyconfigs/pull/6712#issuecomment-415553159","issue_url":"https://api.github.com/repos/easybuilders/easybuild-easyconfigs/issues/6712","id":415553159,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNTU1MzE1OQ==","user":{"login":"boegel","id":620876,"node_id":"MDQ6VXNlcjYyMDg3Ng==","avatar_url":"https://avatars1.githubusercontent.com/u/620876?v=4","gravatar_id":"","url":"https://api.github.com/users/boegel","html_url":"https://github.com/boegel","followers_url":"https://api.github.com/users/boegel/followers","following_url":"https://api.github.com/users/boegel/following{/other_user}","gists_url":"https://api.github.com/users/boegel/gists{/gist_id}","starred_url":"https://api.github.com/users/boegel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boegel/subscriptions","organizations_url":"https://api.github.com/users/boegel/orgs","repos_url":"https://api.github.com/users/boegel/repos","events_url":"https://api.github.com/users/boegel/events{/privacy}","received_events_url":"https://api.github.com/users/boegel/received_events","type":"User","site_admin":false},"created_at":"2018-08-23T20:02:55Z","updated_at":"2018-08-23T20:02:55Z","author_association":"MEMBER","body":"@JackPerdue We can't change the policy w.r.t. how we deal with `Java` as a dependency at any random moment, part of the reason why this took so long to be picked up is because we have a window of opportunity now to take the approach you suggested for the `2018b` toolchain generation & beyond.\r\nThat, and the fact that we're all struggling to find time to work on things like this unfortunately led to where we are now w.r.t. time...\r\n\r\nI consider the problem that @vanzod brought up w.r.t. module collections a blocker for going through with the wrapper approach: this would hit any user relying on module collections as soon as the `Java` wrapper is updated in-place, which is not acceptable imho. Especially because a user could restore a collections weeks or months after the `Java` wrapper was updated in place, so there's no correlation time-wise between the update & the `ml restore` failure...\r\n\r\nWe can let @rtmclay pitch in on this, but I'm not sure it matters too much: the check that Lmod does makes sense to me, since the user can't restore the module collection anymore exactly as it was saved...\r\n\r\nAs already mentioned, the other option we have is to simply change the versioning scheme of the `Java` easyconfigs to only use the major version (e.g. `8` or `10` in the near future) in `version`, but use a fully specified version in `sources` and update that over time, and then let sites do a forced reinstall of `Java` whenever they see fit.\r\n\r\nYour suggested approach is better since it only involves rewriting a module file for the wrapper, so it's fast, while now updating `Java` in place involves an actual re-installation. But (re-)installing `Java` is fast enough that this is mostly a non-argument imho...\r\n\r\nCome to think of it, another downside of going forward without the wrapper is that we'll effectively be *removing* an existing `Java` installation, so the impact is potentially more dramatic compared to just changing a wrapper (where no actual software installations are removed), in the sense that it may affect running jobs that all of a sudden can't find `java` anymore for a couple of seconds.\r\n\r\nThat may just be an academic concern though, reinstalling `Java` takes about 3 seconds on an (fairly old) Intel Sandy Bridge system, I just timed that...\r\n"}}
{"actor":{"display_login":"boegel"}}