{"action":"closed","number":15887,"pull_request":{"url":"https://api.github.com/repos/rancher/rancher/pulls/15887","id":219460445,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NDYwNDQ1","html_url":"https://github.com/rancher/rancher/pull/15887","diff_url":"https://github.com/rancher/rancher/pull/15887.diff","patch_url":"https://github.com/rancher/rancher/pull/15887.patch","issue_url":"https://api.github.com/repos/rancher/rancher/issues/15887","number":15887,"state":"closed","locked":false,"title":"Update vendor for Private EKS Cluster","user":{"login":"nathan-jenan-rancher","id":35039081,"node_id":"MDQ6VXNlcjM1MDM5MDgx","avatar_url":"https://avatars1.githubusercontent.com/u/35039081?v=4","gravatar_id":"","url":"https://api.github.com/users/nathan-jenan-rancher","html_url":"https://github.com/nathan-jenan-rancher","followers_url":"https://api.github.com/users/nathan-jenan-rancher/followers","following_url":"https://api.github.com/users/nathan-jenan-rancher/following{/other_user}","gists_url":"https://api.github.com/users/nathan-jenan-rancher/gists{/gist_id}","starred_url":"https://api.github.com/users/nathan-jenan-rancher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathan-jenan-rancher/subscriptions","organizations_url":"https://api.github.com/users/nathan-jenan-rancher/orgs","repos_url":"https://api.github.com/users/nathan-jenan-rancher/repos","events_url":"https://api.github.com/users/nathan-jenan-rancher/events{/privacy}","received_events_url":"https://api.github.com/users/nathan-jenan-rancher/received_events","type":"User","site_admin":false},"body":"This change adds a formatter to default the AssociateWorkerPublicIPAddress\r\nto true if it is set to nil.  This is because that field must be true to\r\nallow the default vpc and subnets to work.\r\n\r\nAlso adds tests to check that the validation around eks driver works.\r\n\r\nIssue:\r\n#15419 \r\n\r\nDepends on:\r\nhttps://github.com/rancher/kontainer-engine/pull/89\r\nhttps://github.com/rancher/types/pull/591","created_at":"2018-10-01T17:49:09Z","updated_at":"2018-10-11T22:39:40Z","closed_at":"2018-10-11T22:39:40Z","merged_at":"2018-10-11T22:39:40Z","merge_commit_sha":"2b2ee67423b4d0ef2394fb2c154fdbb422cb8a6e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rancher/rancher/pulls/15887/commits","review_comments_url":"https://api.github.com/repos/rancher/rancher/pulls/15887/comments","review_comment_url":"https://api.github.com/repos/rancher/rancher/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rancher/rancher/issues/15887/comments","statuses_url":"https://api.github.com/repos/rancher/rancher/statuses/b6a50367ad744db76fd908aab20ad8c7e462f643","head":{"label":"nathan-jenan-rancher:eks-private-cluster","ref":"eks-private-cluster","sha":"b6a50367ad744db76fd908aab20ad8c7e462f643","user":{"login":"nathan-jenan-rancher","id":35039081,"node_id":"MDQ6VXNlcjM1MDM5MDgx","avatar_url":"https://avatars1.githubusercontent.com/u/35039081?v=4","gravatar_id":"","url":"https://api.github.com/users/nathan-jenan-rancher","html_url":"https://github.com/nathan-jenan-rancher","followers_url":"https://api.github.com/users/nathan-jenan-rancher/followers","following_url":"https://api.github.com/users/nathan-jenan-rancher/following{/other_user}","gists_url":"https://api.github.com/users/nathan-jenan-rancher/gists{/gist_id}","starred_url":"https://api.github.com/users/nathan-jenan-rancher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathan-jenan-rancher/subscriptions","organizations_url":"https://api.github.com/users/nathan-jenan-rancher/orgs","repos_url":"https://api.github.com/users/nathan-jenan-rancher/repos","events_url":"https://api.github.com/users/nathan-jenan-rancher/events{/privacy}","received_events_url":"https://api.github.com/users/nathan-jenan-rancher/received_events","type":"User","site_admin":false},"repo":{"id":119731348,"node_id":"MDEwOlJlcG9zaXRvcnkxMTk3MzEzNDg=","name":"rancher","full_name":"nathan-jenan-rancher/rancher","private":false,"owner":{"login":"nathan-jenan-rancher","id":35039081,"node_id":"MDQ6VXNlcjM1MDM5MDgx","avatar_url":"https://avatars1.githubusercontent.com/u/35039081?v=4","gravatar_id":"","url":"https://api.github.com/users/nathan-jenan-rancher","html_url":"https://github.com/nathan-jenan-rancher","followers_url":"https://api.github.com/users/nathan-jenan-rancher/followers","following_url":"https://api.github.com/users/nathan-jenan-rancher/following{/other_user}","gists_url":"https://api.github.com/users/nathan-jenan-rancher/gists{/gist_id}","starred_url":"https://api.github.com/users/nathan-jenan-rancher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nathan-jenan-rancher/subscriptions","organizations_url":"https://api.github.com/users/nathan-jenan-rancher/orgs","repos_url":"https://api.github.com/users/nathan-jenan-rancher/repos","events_url":"https://api.github.com/users/nathan-jenan-rancher/events{/privacy}","received_events_url":"https://api.github.com/users/nathan-jenan-rancher/received_events","type":"User","site_admin":false},"html_url":"https://github.com/nathan-jenan-rancher/rancher","description":"Complete container management platform","fork":true,"url":"https://api.github.com/repos/nathan-jenan-rancher/rancher","forks_url":"https://api.github.com/repos/nathan-jenan-rancher/rancher/forks","keys_url":"https://api.github.com/repos/nathan-jenan-rancher/rancher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nathan-jenan-rancher/rancher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nathan-jenan-rancher/rancher/teams","hooks_url":"https://api.github.com/repos/nathan-jenan-rancher/rancher/hooks","issue_events_url":"https://api.github.com/repos/nathan-jenan-rancher/rancher/issues/events{/number}","events_url":"https://api.github.com/repos/nathan-jenan-rancher/rancher/events","assignees_url":"https://api.github.com/repos/nathan-jenan-rancher/rancher/assignees{/user}","branches_url":"https://api.github.com/repos/nathan-jenan-rancher/rancher/branches{/branch}","tags_url":"https://api.github.com/repos/nathan-jenan-rancher/rancher/tags","blobs_url":"https://api.github.com/repos/nathan-jenan-rancher/rancher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nathan-jenan-rancher/rancher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nathan-jenan-rancher/rancher/git/refs{/sha}","trees_url":"https://api.github.com/repos/nathan-jenan-rancher/rancher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nathan-jenan-rancher/rancher/statuses/{sha}","languages_url":"https://api.github.com/repos/nathan-jenan-rancher/rancher/languages","stargazers_url":"https://api.github.com/repos/nathan-jenan-rancher/rancher/stargazers","contributors_url":"https://api.github.com/repos/nathan-jenan-rancher/rancher/contributors","subscribers_url":"https://api.github.com/repos/nathan-jenan-rancher/rancher/subscribers","subscription_url":"https://api.github.com/repos/nathan-jenan-rancher/rancher/subscription","commits_url":"https://api.github.com/repos/nathan-jenan-rancher/rancher/commits{/sha}","git_commits_url":"https://api.github.com/repos/nathan-jenan-rancher/rancher/git/commits{/sha}","comments_url":"https://api.github.com/repos/nathan-jenan-rancher/rancher/comments{/number}","issue_comment_url":"https://api.github.com/repos/nathan-jenan-rancher/rancher/issues/comments{/number}","contents_url":"https://api.github.com/repos/nathan-jenan-rancher/rancher/contents/{+path}","compare_url":"https://api.github.com/repos/nathan-jenan-rancher/rancher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nathan-jenan-rancher/rancher/merges","archive_url":"https://api.github.com/repos/nathan-jenan-rancher/rancher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nathan-jenan-rancher/rancher/downloads","issues_url":"https://api.github.com/repos/nathan-jenan-rancher/rancher/issues{/number}","pulls_url":"https://api.github.com/repos/nathan-jenan-rancher/rancher/pulls{/number}","milestones_url":"https://api.github.com/repos/nathan-jenan-rancher/rancher/milestones{/number}","notifications_url":"https://api.github.com/repos/nathan-jenan-rancher/rancher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nathan-jenan-rancher/rancher/labels{/name}","releases_url":"https://api.github.com/repos/nathan-jenan-rancher/rancher/releases{/id}","deployments_url":"https://api.github.com/repos/nathan-jenan-rancher/rancher/deployments","created_at":"2018-01-31T19:13:23Z","updated_at":"2018-10-10T16:34:05Z","pushed_at":"2018-10-11T22:33:46Z","git_url":"git://github.com/nathan-jenan-rancher/rancher.git","ssh_url":"git@github.com:nathan-jenan-rancher/rancher.git","clone_url":"https://github.com/nathan-jenan-rancher/rancher.git","svn_url":"https://github.com/nathan-jenan-rancher/rancher","homepage":"http://rancher.com","size":40531,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rancher:master","ref":"master","sha":"37dd1ecaa14a4cbe691cf961030588f36d5b402a","user":{"login":"rancher","id":9343010,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkzNDMwMTA=","avatar_url":"https://avatars3.githubusercontent.com/u/9343010?v=4","gravatar_id":"","url":"https://api.github.com/users/rancher","html_url":"https://github.com/rancher","followers_url":"https://api.github.com/users/rancher/followers","following_url":"https://api.github.com/users/rancher/following{/other_user}","gists_url":"https://api.github.com/users/rancher/gists{/gist_id}","starred_url":"https://api.github.com/users/rancher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rancher/subscriptions","organizations_url":"https://api.github.com/users/rancher/orgs","repos_url":"https://api.github.com/users/rancher/repos","events_url":"https://api.github.com/users/rancher/events{/privacy}","received_events_url":"https://api.github.com/users/rancher/received_events","type":"Organization","site_admin":false},"repo":{"id":26337322,"node_id":"MDEwOlJlcG9zaXRvcnkyNjMzNzMyMg==","name":"rancher","full_name":"rancher/rancher","private":false,"owner":{"login":"rancher","id":9343010,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkzNDMwMTA=","avatar_url":"https://avatars3.githubusercontent.com/u/9343010?v=4","gravatar_id":"","url":"https://api.github.com/users/rancher","html_url":"https://github.com/rancher","followers_url":"https://api.github.com/users/rancher/followers","following_url":"https://api.github.com/users/rancher/following{/other_user}","gists_url":"https://api.github.com/users/rancher/gists{/gist_id}","starred_url":"https://api.github.com/users/rancher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rancher/subscriptions","organizations_url":"https://api.github.com/users/rancher/orgs","repos_url":"https://api.github.com/users/rancher/repos","events_url":"https://api.github.com/users/rancher/events{/privacy}","received_events_url":"https://api.github.com/users/rancher/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/rancher/rancher","description":"Complete container management platform","fork":false,"url":"https://api.github.com/repos/rancher/rancher","forks_url":"https://api.github.com/repos/rancher/rancher/forks","keys_url":"https://api.github.com/repos/rancher/rancher/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rancher/rancher/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rancher/rancher/teams","hooks_url":"https://api.github.com/repos/rancher/rancher/hooks","issue_events_url":"https://api.github.com/repos/rancher/rancher/issues/events{/number}","events_url":"https://api.github.com/repos/rancher/rancher/events","assignees_url":"https://api.github.com/repos/rancher/rancher/assignees{/user}","branches_url":"https://api.github.com/repos/rancher/rancher/branches{/branch}","tags_url":"https://api.github.com/repos/rancher/rancher/tags","blobs_url":"https://api.github.com/repos/rancher/rancher/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rancher/rancher/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rancher/rancher/git/refs{/sha}","trees_url":"https://api.github.com/repos/rancher/rancher/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rancher/rancher/statuses/{sha}","languages_url":"https://api.github.com/repos/rancher/rancher/languages","stargazers_url":"https://api.github.com/repos/rancher/rancher/stargazers","contributors_url":"https://api.github.com/repos/rancher/rancher/contributors","subscribers_url":"https://api.github.com/repos/rancher/rancher/subscribers","subscription_url":"https://api.github.com/repos/rancher/rancher/subscription","commits_url":"https://api.github.com/repos/rancher/rancher/commits{/sha}","git_commits_url":"https://api.github.com/repos/rancher/rancher/git/commits{/sha}","comments_url":"https://api.github.com/repos/rancher/rancher/comments{/number}","issue_comment_url":"https://api.github.com/repos/rancher/rancher/issues/comments{/number}","contents_url":"https://api.github.com/repos/rancher/rancher/contents/{+path}","compare_url":"https://api.github.com/repos/rancher/rancher/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rancher/rancher/merges","archive_url":"https://api.github.com/repos/rancher/rancher/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rancher/rancher/downloads","issues_url":"https://api.github.com/repos/rancher/rancher/issues{/number}","pulls_url":"https://api.github.com/repos/rancher/rancher/pulls{/number}","milestones_url":"https://api.github.com/repos/rancher/rancher/milestones{/number}","notifications_url":"https://api.github.com/repos/rancher/rancher/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rancher/rancher/labels{/name}","releases_url":"https://api.github.com/repos/rancher/rancher/releases{/id}","deployments_url":"https://api.github.com/repos/rancher/rancher/deployments","created_at":"2014-11-07T20:49:31Z","updated_at":"2018-10-11T17:50:53Z","pushed_at":"2018-10-11T22:39:40Z","git_url":"git://github.com/rancher/rancher.git","ssh_url":"git@github.com:rancher/rancher.git","clone_url":"https://github.com/rancher/rancher.git","svn_url":"https://github.com/rancher/rancher","homepage":"http://rancher.com","size":40760,"stargazers_count":9671,"watchers_count":9671,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":998,"mirror_url":null,"archived":false,"open_issues_count":1314,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":998,"open_issues":1314,"watchers":9671,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rancher/rancher/pulls/15887"},"html":{"href":"https://github.com/rancher/rancher/pull/15887"},"issue":{"href":"https://api.github.com/repos/rancher/rancher/issues/15887"},"comments":{"href":"https://api.github.com/repos/rancher/rancher/issues/15887/comments"},"review_comments":{"href":"https://api.github.com/repos/rancher/rancher/pulls/15887/comments"},"review_comment":{"href":"https://api.github.com/repos/rancher/rancher/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rancher/rancher/pulls/15887/commits"},"statuses":{"href":"https://api.github.com/repos/rancher/rancher/statuses/b6a50367ad744db76fd908aab20ad8c7e462f643"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"cjellick","id":2473240,"node_id":"MDQ6VXNlcjI0NzMyNDA=","avatar_url":"https://avatars1.githubusercontent.com/u/2473240?v=4","gravatar_id":"","url":"https://api.github.com/users/cjellick","html_url":"https://github.com/cjellick","followers_url":"https://api.github.com/users/cjellick/followers","following_url":"https://api.github.com/users/cjellick/following{/other_user}","gists_url":"https://api.github.com/users/cjellick/gists{/gist_id}","starred_url":"https://api.github.com/users/cjellick/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cjellick/subscriptions","organizations_url":"https://api.github.com/users/cjellick/orgs","repos_url":"https://api.github.com/users/cjellick/repos","events_url":"https://api.github.com/users/cjellick/events{/privacy}","received_events_url":"https://api.github.com/users/cjellick/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":1086,"deletions":143,"changed_files":39}}
{"actor":{"display_login":"cjellick"}}