{"action":"closed","issue":{"url":"https://api.github.com/repos/PAYONE-GmbH/oxid-6/issues/48","repository_url":"https://api.github.com/repos/PAYONE-GmbH/oxid-6","labels_url":"https://api.github.com/repos/PAYONE-GmbH/oxid-6/issues/48/labels{/name}","comments_url":"https://api.github.com/repos/PAYONE-GmbH/oxid-6/issues/48/comments","events_url":"https://api.github.com/repos/PAYONE-GmbH/oxid-6/issues/48/events","html_url":"https://github.com/PAYONE-GmbH/oxid-6/issues/48","id":340142266,"node_id":"MDU6SXNzdWUzNDAxNDIyNjY=","number":48,"title":"bad compatibility with child themes","user":{"login":"vanilla-thunder","id":1874024,"node_id":"MDQ6VXNlcjE4NzQwMjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1874024?v=4","gravatar_id":"","url":"https://api.github.com/users/vanilla-thunder","html_url":"https://github.com/vanilla-thunder","followers_url":"https://api.github.com/users/vanilla-thunder/followers","following_url":"https://api.github.com/users/vanilla-thunder/following{/other_user}","gists_url":"https://api.github.com/users/vanilla-thunder/gists{/gist_id}","starred_url":"https://api.github.com/users/vanilla-thunder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vanilla-thunder/subscriptions","organizations_url":"https://api.github.com/users/vanilla-thunder/orgs","repos_url":"https://api.github.com/users/vanilla-thunder/repos","events_url":"https://api.github.com/users/vanilla-thunder/events{/privacy}","received_events_url":"https://api.github.com/users/vanilla-thunder/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-07-11T08:32:02Z","updated_at":"2018-08-07T13:59:13Z","closed_at":"2018-08-07T13:59:13Z","author_association":"NONE","body":"in ``out/blocks/fcpo_payment_select_override.tpl`` there is an if-else statement for choosing flow or azure templates:\r\n````\r\n[{if method_exists($oViewConf, 'getActiveTheme') && $oViewConf->getActiveTheme() == 'flow'}]\r\n    [{assign var=\"sFcPoTemplatePath\" value='flow'}]\r\n[{else}]\r\n    [{assign var=\"sFcPoTemplatePath\" value='azure'}]\r\n[{/if}]\r\n````\r\nThe way its done, all flow child themes will get templates for azure. sincce their name is not \"flow\".\r\n\r\n1) The best solution would be adding module setting and let customer pick wherever he wants flow or azure module templates. This will also work with 3rd party themes like roxive.\r\n\r\n2) Another possible solution could be something like this: \r\n````\r\n[{if method_exists($oViewConf, 'getActiveTheme') && $oViewConf->getActiveTheme()|strpos:'flow' !== false}]\r\n    [{assign var=\"sFcPoTemplatePath\" value='flow'}]\r\n[{else}]\r\n    [{assign var=\"sFcPoTemplatePath\" value='azure'}]\r\n[{/if}]\r\n`````\r\nThis way at least all themes that contain \"flow\" in their names will get flow templates (since many people name their child themes something like \"flow\"+\"shop name\")\r\n\r\nYou should also apply this fix to the module for oxid v4/v5.\r\nI also would like to mention, that there is no azure in v6 anymore and this code is actually obsolete.\r\n\r\ncheers\r\n\r\n"}}
{"actor":{"display_login":"fjbender"}}