{"action":"created","issue":{"url":"https://api.github.com/repos/junit-team/junit5/issues/1705","repository_url":"https://api.github.com/repos/junit-team/junit5","labels_url":"https://api.github.com/repos/junit-team/junit5/issues/1705/labels{/name}","comments_url":"https://api.github.com/repos/junit-team/junit5/issues/1705/comments","events_url":"https://api.github.com/repos/junit-team/junit5/issues/1705/events","html_url":"https://github.com/junit-team/junit5/pull/1705","id":392576095,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM5ODE2NDQy","number":1705,"title":"Add around() to Node to allow intercepting the whole execution","user":{"login":"leonard84","id":1151511,"node_id":"MDQ6VXNlcjExNTE1MTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1151511?v=4","gravatar_id":"","url":"https://api.github.com/users/leonard84","html_url":"https://github.com/leonard84","followers_url":"https://api.github.com/users/leonard84/followers","following_url":"https://api.github.com/users/leonard84/following{/other_user}","gists_url":"https://api.github.com/users/leonard84/gists{/gist_id}","starred_url":"https://api.github.com/users/leonard84/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leonard84/subscriptions","organizations_url":"https://api.github.com/users/leonard84/orgs","repos_url":"https://api.github.com/users/leonard84/repos","events_url":"https://api.github.com/users/leonard84/events{/privacy}","received_events_url":"https://api.github.com/users/leonard84/received_events","type":"User","site_admin":false},"labels":[{"id":420912036,"node_id":"MDU6TGFiZWw0MjA5MTIwMzY=","url":"https://api.github.com/repos/junit-team/junit5/labels/component:%20Platform","name":"component: Platform","color":"11dd99","default":false},{"id":294412858,"node_id":"MDU6TGFiZWwyOTQ0MTI4NTg=","url":"https://api.github.com/repos/junit-team/junit5/labels/status:%20in%20progress","name":"status: in progress","color":"ffbb00","default":false},{"id":309743833,"node_id":"MDU6TGFiZWwzMDk3NDM4MzM=","url":"https://api.github.com/repos/junit-team/junit5/labels/status:%20team%20discussion","name":"status: team discussion","color":"207de5","default":false},{"id":293488747,"node_id":"MDU6TGFiZWwyOTM0ODg3NDc=","url":"https://api.github.com/repos/junit-team/junit5/labels/theme:%20execution","name":"theme: execution","color":"fbca04","default":false},{"id":1041356926,"node_id":"MDU6TGFiZWwxMDQxMzU2OTI2","url":"https://api.github.com/repos/junit-team/junit5/labels/type:%20new%20feature","name":"type: new feature","color":"85d31f","default":false}],"state":"open","locked":false,"assignee":{"login":"leonard84","id":1151511,"node_id":"MDQ6VXNlcjExNTE1MTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1151511?v=4","gravatar_id":"","url":"https://api.github.com/users/leonard84","html_url":"https://github.com/leonard84","followers_url":"https://api.github.com/users/leonard84/followers","following_url":"https://api.github.com/users/leonard84/following{/other_user}","gists_url":"https://api.github.com/users/leonard84/gists{/gist_id}","starred_url":"https://api.github.com/users/leonard84/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leonard84/subscriptions","organizations_url":"https://api.github.com/users/leonard84/orgs","repos_url":"https://api.github.com/users/leonard84/repos","events_url":"https://api.github.com/users/leonard84/events{/privacy}","received_events_url":"https://api.github.com/users/leonard84/received_events","type":"User","site_admin":false},"assignees":[{"login":"leonard84","id":1151511,"node_id":"MDQ6VXNlcjExNTE1MTE=","avatar_url":"https://avatars2.githubusercontent.com/u/1151511?v=4","gravatar_id":"","url":"https://api.github.com/users/leonard84","html_url":"https://github.com/leonard84","followers_url":"https://api.github.com/users/leonard84/followers","following_url":"https://api.github.com/users/leonard84/following{/other_user}","gists_url":"https://api.github.com/users/leonard84/gists{/gist_id}","starred_url":"https://api.github.com/users/leonard84/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leonard84/subscriptions","organizations_url":"https://api.github.com/users/leonard84/orgs","repos_url":"https://api.github.com/users/leonard84/repos","events_url":"https://api.github.com/users/leonard84/events{/privacy}","received_events_url":"https://api.github.com/users/leonard84/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/junit-team/junit5/milestones/29","html_url":"https://github.com/junit-team/junit5/milestone/29","labels_url":"https://api.github.com/repos/junit-team/junit5/milestones/29/labels","id":3544234,"node_id":"MDk6TWlsZXN0b25lMzU0NDIzNA==","number":29,"title":"5.4 M1","description":"*Scope:* XML report generating listener, Test Kit for testing engines and extensions, new\r\n`junit-jupiter` dependency aggregating artifact for simplified dependency management in\r\nbuild tools, `TempDirectory` extension, display name generator API, test execution order\r\nAPI, JUnit 4 `@Ignore` migration support, improved diagnostics and error reporting,\r\ndiscontinuation of the `junit-platform-surefire-provider`, as well as various minor\r\nimprovements and bug fixes.\r\n","creator":{"login":"marcphilipp","id":214207,"node_id":"MDQ6VXNlcjIxNDIwNw==","avatar_url":"https://avatars2.githubusercontent.com/u/214207?v=4","gravatar_id":"","url":"https://api.github.com/users/marcphilipp","html_url":"https://github.com/marcphilipp","followers_url":"https://api.github.com/users/marcphilipp/followers","following_url":"https://api.github.com/users/marcphilipp/following{/other_user}","gists_url":"https://api.github.com/users/marcphilipp/gists{/gist_id}","starred_url":"https://api.github.com/users/marcphilipp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcphilipp/subscriptions","organizations_url":"https://api.github.com/users/marcphilipp/orgs","repos_url":"https://api.github.com/users/marcphilipp/repos","events_url":"https://api.github.com/users/marcphilipp/events{/privacy}","received_events_url":"https://api.github.com/users/marcphilipp/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":51,"state":"open","created_at":"2018-08-03T10:12:37Z","updated_at":"2018-12-19T15:18:16Z","due_on":"2018-12-23T08:00:00Z","closed_at":null},"comments":7,"created_at":"2018-12-19T12:20:50Z","updated_at":"2018-12-19T15:32:37Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/junit-team/junit5/pulls/1705","html_url":"https://github.com/junit-team/junit5/pull/1705","diff_url":"https://github.com/junit-team/junit5/pull/1705.diff","patch_url":"https://github.com/junit-team/junit5/pull/1705.patch"},"body":"## Overview\r\n\r\nas discussed with @marcphilipp \r\n\r\n---\r\n\r\nI hereby agree to the terms of the [JUnit Contributor License Agreement](https://github.com/junit-team/junit5/blob/002a0052926ddee57cf90580fa49bc37e5a72427/CONTRIBUTING.md#junit-contributor-license-agreement).\r\n\r\n---\r\n\r\n### Definition of Done\r\n\r\n- [x] There are no TODOs left in the code\r\n- [x] Method [preconditions](http://junit.org/junit5/docs/snapshot/api/org/junit/platform/commons/util/Preconditions.html) are checked and documented in the method's Javadoc\r\n- [x] [Coding conventions](https://github.com/junit-team/junit5/blob/master/CONTRIBUTING.md#coding-conventions) (e.g. for logging) have been followed\r\n- [x] Change is covered by [automated tests](https://github.com/junit-team/junit5/blob/master/CONTRIBUTING.md#tests) including corner cases, errors, and exception handling\r\n- [x] Public API has [Javadoc](https://github.com/junit-team/junit5/blob/master/CONTRIBUTING.md#javadoc) and [`@API` annotations](https://apiguardian-team.github.io/apiguardian/docs/current/api/org/apiguardian/api/API.html)\r\n- [ ] Change is documented in the [User Guide](http://junit.org/junit5/docs/snapshot/user-guide/) and [Release Notes](http://junit.org/junit5/docs/snapshot/user-guide/#release-notes)\r\n- [ ] All [continuous integration builds](https://github.com/junit-team/junit5#continuous-integration-builds) pass\r\n"},"comment":{"url":"https://api.github.com/repos/junit-team/junit5/issues/comments/448636817","html_url":"https://github.com/junit-team/junit5/pull/1705#issuecomment-448636817","issue_url":"https://api.github.com/repos/junit-team/junit5/issues/1705","id":448636817,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0ODYzNjgxNw==","user":{"login":"sbrannen","id":104798,"node_id":"MDQ6VXNlcjEwNDc5OA==","avatar_url":"https://avatars0.githubusercontent.com/u/104798?v=4","gravatar_id":"","url":"https://api.github.com/users/sbrannen","html_url":"https://github.com/sbrannen","followers_url":"https://api.github.com/users/sbrannen/followers","following_url":"https://api.github.com/users/sbrannen/following{/other_user}","gists_url":"https://api.github.com/users/sbrannen/gists{/gist_id}","starred_url":"https://api.github.com/users/sbrannen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbrannen/subscriptions","organizations_url":"https://api.github.com/users/sbrannen/orgs","repos_url":"https://api.github.com/users/sbrannen/repos","events_url":"https://api.github.com/users/sbrannen/events{/privacy}","received_events_url":"https://api.github.com/users/sbrannen/received_events","type":"User","site_admin":false},"created_at":"2018-12-19T15:32:37Z","updated_at":"2018-12-19T15:32:37Z","author_association":"MEMBER","body":"> The rationale is to support Spock's extension model that allows to intercept, i.e. wrap, the whole execution of a test class, method, or invocation.\r\n\r\nOK. Thanks for the background.\r\n\r\nBut... doesn't this change then relate to #80 and #157?\r\n\r\nAnd if so, has there been any effort made to ensure that this change would work nicely with those (once implemented)?"}}
{"actor":{"display_login":"sbrannen"}}