{"action":"created","issue":{"url":"https://api.github.com/repos/StaticCube/python-synology/issues/6","repository_url":"https://api.github.com/repos/StaticCube/python-synology","labels_url":"https://api.github.com/repos/StaticCube/python-synology/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/StaticCube/python-synology/issues/6/comments","events_url":"https://api.github.com/repos/StaticCube/python-synology/issues/6/events","html_url":"https://github.com/StaticCube/python-synology/pull/6","id":337621553,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NzU4MTk2","number":6,"title":"Added support to HTTPS URLs and for special characters in the username or password","user":{"login":"tchellomello","id":809840,"node_id":"MDQ6VXNlcjgwOTg0MA==","avatar_url":"https://avatars1.githubusercontent.com/u/809840?v=4","gravatar_id":"","url":"https://api.github.com/users/tchellomello","html_url":"https://github.com/tchellomello","followers_url":"https://api.github.com/users/tchellomello/followers","following_url":"https://api.github.com/users/tchellomello/following{/other_user}","gists_url":"https://api.github.com/users/tchellomello/gists{/gist_id}","starred_url":"https://api.github.com/users/tchellomello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchellomello/subscriptions","organizations_url":"https://api.github.com/users/tchellomello/orgs","repos_url":"https://api.github.com/users/tchellomello/repos","events_url":"https://api.github.com/users/tchellomello/events{/privacy}","received_events_url":"https://api.github.com/users/tchellomello/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-07-02T18:37:24Z","updated_at":"2018-07-02T20:17:07Z","closed_at":"2018-07-02T19:54:44Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/StaticCube/python-synology/pulls/6","html_url":"https://github.com/StaticCube/python-synology/pull/6","diff_url":"https://github.com/StaticCube/python-synology/pull/6.diff","patch_url":"https://github.com/StaticCube/python-synology/pull/6.patch"},"body":"This PR added support to HTTPS URLs and also support special characters in the user's password such as '#' or '!'\r\n\r\nHere below an example of using HTTPS and encoding a password\r\n\r\n```python\r\nIn [1]: from SynologyDSM import SynologyDSM\r\n\r\nIn [2]: api5 = SynologyDSM('192.168.0.1', 5001, 'admin', 'secret#qq', debugmode=True, use_https=True)\r\n\r\nIn [3]: api5.storage.volumes\r\nDEBUG: Creating New Session\r\nDEBUG: Requesting URL: 'https://192.168.0.1:5001/webapi/auth.cgi?api=SYNO.API.Auth&version=2&method=login&account=admin&passwd=secret#%23qq&session=Core&format=cookie'\r\nDEBUG: Request executed: 200\r\nDEBUG: Succesfull returning data\r\nDEBUG: {'data': {'sid': 'jCXsRpHIK9999999'}, 'success': True}\r\nDEBUG: Authentication Succesfull, token: jCXsRpHIK9999999\r\nDEBUG: Requesting URL: 'https://192.168.0.1:5001/webapi/entry.cgi?api=SYNO.Storage.CGI.Storage&version=1&method=load_info'\r\nDEBUG: Appending access_token (SID: jCXsRpHIK9999999) to url\r\nDEBUG: Request executed: 200\r\nDEBUG: Succesfull returning data\r\nDEBUG: {'data': {'disks': [{'adv_progress': '', 'adv_status': 'not_support',  [.... SNIP...]  'success': True}\r\nOut[4]: ['volume_1']\r\n```\r\n\r\nSee also: \r\n* https://github.com/home-assistant/home-assistant/pull/15270\r\n* https://github.com/home-assistant/home-assistant/issues/15269\r\n"},"comment":{"url":"https://api.github.com/repos/StaticCube/python-synology/issues/comments/401921033","html_url":"https://github.com/StaticCube/python-synology/pull/6#issuecomment-401921033","issue_url":"https://api.github.com/repos/StaticCube/python-synology/issues/6","id":401921033,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMTkyMTAzMw==","user":{"login":"tchellomello","id":809840,"node_id":"MDQ6VXNlcjgwOTg0MA==","avatar_url":"https://avatars1.githubusercontent.com/u/809840?v=4","gravatar_id":"","url":"https://api.github.com/users/tchellomello","html_url":"https://github.com/tchellomello","followers_url":"https://api.github.com/users/tchellomello/followers","following_url":"https://api.github.com/users/tchellomello/following{/other_user}","gists_url":"https://api.github.com/users/tchellomello/gists{/gist_id}","starred_url":"https://api.github.com/users/tchellomello/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchellomello/subscriptions","organizations_url":"https://api.github.com/users/tchellomello/orgs","repos_url":"https://api.github.com/users/tchellomello/repos","events_url":"https://api.github.com/users/tchellomello/events{/privacy}","received_events_url":"https://api.github.com/users/tchellomello/received_events","type":"User","site_admin":false},"created_at":"2018-07-02T20:17:07Z","updated_at":"2018-07-02T20:17:07Z","author_association":"CONTRIBUTOR","body":"Thanks @StaticCube !"}}
{"actor":{"display_login":"tchellomello"}}