{"action":"created","comment":{"url":"https://api.github.com/repos/Azure/azure-cli/pulls/comments/201485209","pull_request_review_id":135995526,"id":201485209,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTQ4NTIwOQ==","diff_hunk":"@@ -665,42 +668,47 @@ def handler(args):\n     context._cli_command(name, handler=handler, argument_loader=generic_wait_arguments_loader, **kwargs)  # pylint: disable=protected-access\n \n \n-def _cli_generic_show_command(context, name, getter_op, **kwargs):\n+def _cli_generic_show_command(context, name, getter_op, custom_command=False, **kwargs):","path":"src/azure-cli-core/azure/cli/core/commands/arm.py","position":104,"original_position":104,"commit_id":"bd7bbad81d4a748594244adb4344dd13cc615b92","original_commit_id":"bd7bbad81d4a748594244adb4344dd13cc615b92","user":{"login":"tjprescott","id":5723682,"node_id":"MDQ6VXNlcjU3MjM2ODI=","avatar_url":"https://avatars2.githubusercontent.com/u/5723682?v=4","gravatar_id":"","url":"https://api.github.com/users/tjprescott","html_url":"https://github.com/tjprescott","followers_url":"https://api.github.com/users/tjprescott/followers","following_url":"https://api.github.com/users/tjprescott/following{/other_user}","gists_url":"https://api.github.com/users/tjprescott/gists{/gist_id}","starred_url":"https://api.github.com/users/tjprescott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tjprescott/subscriptions","organizations_url":"https://api.github.com/users/tjprescott/orgs","repos_url":"https://api.github.com/users/tjprescott/repos","events_url":"https://api.github.com/users/tjprescott/events{/privacy}","received_events_url":"https://api.github.com/users/tjprescott/received_events","type":"User","site_admin":false},"body":"Yes, make this accept `source_kwarg` (no default) and have show_command pass 'command_type' and custom_show_command pass 'custom_command_type'.  It will simplify your code. Ditto for the private wait command.","created_at":"2018-07-10T20:34:58Z","updated_at":"2018-07-10T20:41:26Z","html_url":"https://github.com/Azure/azure-cli/pull/6740#discussion_r201485209","pull_request_url":"https://api.github.com/repos/Azure/azure-cli/pulls/6740","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/comments/201485209"},"html":{"href":"https://github.com/Azure/azure-cli/pull/6740#discussion_r201485209"},"pull_request":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/6740"}}},"pull_request":{"url":"https://api.github.com/repos/Azure/azure-cli/pulls/6740","id":199850451,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5ODUwNDUx","html_url":"https://github.com/Azure/azure-cli/pull/6740","diff_url":"https://github.com/Azure/azure-cli/pull/6740.diff","patch_url":"https://github.com/Azure/azure-cli/pull/6740.patch","issue_url":"https://api.github.com/repos/Azure/azure-cli/issues/6740","number":6740,"state":"open","locked":false,"title":"Update show commands to exit with code 3 upon a 404.","user":{"login":"williexu","id":8580552,"node_id":"MDQ6VXNlcjg1ODA1NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/8580552?v=4","gravatar_id":"","url":"https://api.github.com/users/williexu","html_url":"https://github.com/williexu","followers_url":"https://api.github.com/users/williexu/followers","following_url":"https://api.github.com/users/williexu/following{/other_user}","gists_url":"https://api.github.com/users/williexu/gists{/gist_id}","starred_url":"https://api.github.com/users/williexu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/williexu/subscriptions","organizations_url":"https://api.github.com/users/williexu/orgs","repos_url":"https://api.github.com/users/williexu/repos","events_url":"https://api.github.com/users/williexu/events{/privacy}","received_events_url":"https://api.github.com/users/williexu/received_events","type":"User","site_admin":false},"body":"---\r\nCloses: https://github.com/Azure/azure-cli/issues/6612\r\nCloses: https://github.com/Azure/azure-cli/issues/5006\r\n\r\nThis checklist is used to make sure that common guidelines for a pull request are followed.\r\n\r\n- [x] The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see [Modifying change log](https://github.com/Azure/azure-cli/tree/master/doc/authoring_command_modules#modify-change-log)).\r\n\r\n- [x] I adhere to the [Command Guidelines](https://github.com/Azure/azure-cli/blob/dev/doc/command_guidelines.md).\r\n","created_at":"2018-07-06T21:23:46Z","updated_at":"2018-07-10T20:41:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"78c41a5b5ab6eccd7501aae378f5c216f43930d1","assignee":null,"assignees":[],"requested_reviewers":[{"login":"troydai","id":1329240,"node_id":"MDQ6VXNlcjEzMjkyNDA=","avatar_url":"https://avatars2.githubusercontent.com/u/1329240?v=4","gravatar_id":"","url":"https://api.github.com/users/troydai","html_url":"https://github.com/troydai","followers_url":"https://api.github.com/users/troydai/followers","following_url":"https://api.github.com/users/troydai/following{/other_user}","gists_url":"https://api.github.com/users/troydai/gists{/gist_id}","starred_url":"https://api.github.com/users/troydai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/troydai/subscriptions","organizations_url":"https://api.github.com/users/troydai/orgs","repos_url":"https://api.github.com/users/troydai/repos","events_url":"https://api.github.com/users/troydai/events{/privacy}","received_events_url":"https://api.github.com/users/troydai/received_events","type":"User","site_admin":false},{"login":"yugangw-msft","id":6014209,"node_id":"MDQ6VXNlcjYwMTQyMDk=","avatar_url":"https://avatars1.githubusercontent.com/u/6014209?v=4","gravatar_id":"","url":"https://api.github.com/users/yugangw-msft","html_url":"https://github.com/yugangw-msft","followers_url":"https://api.github.com/users/yugangw-msft/followers","following_url":"https://api.github.com/users/yugangw-msft/following{/other_user}","gists_url":"https://api.github.com/users/yugangw-msft/gists{/gist_id}","starred_url":"https://api.github.com/users/yugangw-msft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yugangw-msft/subscriptions","organizations_url":"https://api.github.com/users/yugangw-msft/orgs","repos_url":"https://api.github.com/users/yugangw-msft/repos","events_url":"https://api.github.com/users/yugangw-msft/events{/privacy}","received_events_url":"https://api.github.com/users/yugangw-msft/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":483128192,"node_id":"MDU6TGFiZWw0ODMxMjgxOTI=","url":"https://api.github.com/repos/Azure/azure-cli/labels/Breaking%20Change","name":"Breaking Change","color":"0052cc","default":false},{"id":546452782,"node_id":"MDU6TGFiZWw1NDY0NTI3ODI=","url":"https://api.github.com/repos/Azure/azure-cli/labels/Infrastructure","name":"Infrastructure","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Azure/azure-cli/pulls/6740/commits","review_comments_url":"https://api.github.com/repos/Azure/azure-cli/pulls/6740/comments","review_comment_url":"https://api.github.com/repos/Azure/azure-cli/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Azure/azure-cli/issues/6740/comments","statuses_url":"https://api.github.com/repos/Azure/azure-cli/statuses/bd7bbad81d4a748594244adb4344dd13cc615b92","head":{"label":"williexu:generic_show","ref":"generic_show","sha":"bd7bbad81d4a748594244adb4344dd13cc615b92","user":{"login":"williexu","id":8580552,"node_id":"MDQ6VXNlcjg1ODA1NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/8580552?v=4","gravatar_id":"","url":"https://api.github.com/users/williexu","html_url":"https://github.com/williexu","followers_url":"https://api.github.com/users/williexu/followers","following_url":"https://api.github.com/users/williexu/following{/other_user}","gists_url":"https://api.github.com/users/williexu/gists{/gist_id}","starred_url":"https://api.github.com/users/williexu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/williexu/subscriptions","organizations_url":"https://api.github.com/users/williexu/orgs","repos_url":"https://api.github.com/users/williexu/repos","events_url":"https://api.github.com/users/williexu/events{/privacy}","received_events_url":"https://api.github.com/users/williexu/received_events","type":"User","site_admin":false},"repo":{"id":100400046,"node_id":"MDEwOlJlcG9zaXRvcnkxMDA0MDAwNDY=","name":"azure-cli","full_name":"williexu/azure-cli","owner":{"login":"williexu","id":8580552,"node_id":"MDQ6VXNlcjg1ODA1NTI=","avatar_url":"https://avatars2.githubusercontent.com/u/8580552?v=4","gravatar_id":"","url":"https://api.github.com/users/williexu","html_url":"https://github.com/williexu","followers_url":"https://api.github.com/users/williexu/followers","following_url":"https://api.github.com/users/williexu/following{/other_user}","gists_url":"https://api.github.com/users/williexu/gists{/gist_id}","starred_url":"https://api.github.com/users/williexu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/williexu/subscriptions","organizations_url":"https://api.github.com/users/williexu/orgs","repos_url":"https://api.github.com/users/williexu/repos","events_url":"https://api.github.com/users/williexu/events{/privacy}","received_events_url":"https://api.github.com/users/williexu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/williexu/azure-cli","description":"Command-line tools for Azure.","fork":true,"url":"https://api.github.com/repos/williexu/azure-cli","forks_url":"https://api.github.com/repos/williexu/azure-cli/forks","keys_url":"https://api.github.com/repos/williexu/azure-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/williexu/azure-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/williexu/azure-cli/teams","hooks_url":"https://api.github.com/repos/williexu/azure-cli/hooks","issue_events_url":"https://api.github.com/repos/williexu/azure-cli/issues/events{/number}","events_url":"https://api.github.com/repos/williexu/azure-cli/events","assignees_url":"https://api.github.com/repos/williexu/azure-cli/assignees{/user}","branches_url":"https://api.github.com/repos/williexu/azure-cli/branches{/branch}","tags_url":"https://api.github.com/repos/williexu/azure-cli/tags","blobs_url":"https://api.github.com/repos/williexu/azure-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/williexu/azure-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/williexu/azure-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/williexu/azure-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/williexu/azure-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/williexu/azure-cli/languages","stargazers_url":"https://api.github.com/repos/williexu/azure-cli/stargazers","contributors_url":"https://api.github.com/repos/williexu/azure-cli/contributors","subscribers_url":"https://api.github.com/repos/williexu/azure-cli/subscribers","subscription_url":"https://api.github.com/repos/williexu/azure-cli/subscription","commits_url":"https://api.github.com/repos/williexu/azure-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/williexu/azure-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/williexu/azure-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/williexu/azure-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/williexu/azure-cli/contents/{+path}","compare_url":"https://api.github.com/repos/williexu/azure-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/williexu/azure-cli/merges","archive_url":"https://api.github.com/repos/williexu/azure-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/williexu/azure-cli/downloads","issues_url":"https://api.github.com/repos/williexu/azure-cli/issues{/number}","pulls_url":"https://api.github.com/repos/williexu/azure-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/williexu/azure-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/williexu/azure-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/williexu/azure-cli/labels{/name}","releases_url":"https://api.github.com/repos/williexu/azure-cli/releases{/id}","deployments_url":"https://api.github.com/repos/williexu/azure-cli/deployments","created_at":"2017-08-15T17:03:52Z","updated_at":"2017-08-15T17:03:59Z","pushed_at":"2018-07-10T19:12:30Z","git_url":"git://github.com/williexu/azure-cli.git","ssh_url":"git@github.com:williexu/azure-cli.git","clone_url":"https://github.com/williexu/azure-cli.git","svn_url":"https://github.com/williexu/azure-cli","homepage":null,"size":45389,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"Azure:dev","ref":"dev","sha":"1378c1ccb2a7598c661ed930472de407630cf9f1","user":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"repo":{"id":51040886,"node_id":"MDEwOlJlcG9zaXRvcnk1MTA0MDg4Ng==","name":"azure-cli","full_name":"Azure/azure-cli","owner":{"login":"Azure","id":6844498,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY4NDQ0OTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6844498?v=4","gravatar_id":"","url":"https://api.github.com/users/Azure","html_url":"https://github.com/Azure","followers_url":"https://api.github.com/users/Azure/followers","following_url":"https://api.github.com/users/Azure/following{/other_user}","gists_url":"https://api.github.com/users/Azure/gists{/gist_id}","starred_url":"https://api.github.com/users/Azure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Azure/subscriptions","organizations_url":"https://api.github.com/users/Azure/orgs","repos_url":"https://api.github.com/users/Azure/repos","events_url":"https://api.github.com/users/Azure/events{/privacy}","received_events_url":"https://api.github.com/users/Azure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Azure/azure-cli","description":"Command-line tools for Azure.","fork":false,"url":"https://api.github.com/repos/Azure/azure-cli","forks_url":"https://api.github.com/repos/Azure/azure-cli/forks","keys_url":"https://api.github.com/repos/Azure/azure-cli/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Azure/azure-cli/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Azure/azure-cli/teams","hooks_url":"https://api.github.com/repos/Azure/azure-cli/hooks","issue_events_url":"https://api.github.com/repos/Azure/azure-cli/issues/events{/number}","events_url":"https://api.github.com/repos/Azure/azure-cli/events","assignees_url":"https://api.github.com/repos/Azure/azure-cli/assignees{/user}","branches_url":"https://api.github.com/repos/Azure/azure-cli/branches{/branch}","tags_url":"https://api.github.com/repos/Azure/azure-cli/tags","blobs_url":"https://api.github.com/repos/Azure/azure-cli/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Azure/azure-cli/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Azure/azure-cli/git/refs{/sha}","trees_url":"https://api.github.com/repos/Azure/azure-cli/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Azure/azure-cli/statuses/{sha}","languages_url":"https://api.github.com/repos/Azure/azure-cli/languages","stargazers_url":"https://api.github.com/repos/Azure/azure-cli/stargazers","contributors_url":"https://api.github.com/repos/Azure/azure-cli/contributors","subscribers_url":"https://api.github.com/repos/Azure/azure-cli/subscribers","subscription_url":"https://api.github.com/repos/Azure/azure-cli/subscription","commits_url":"https://api.github.com/repos/Azure/azure-cli/commits{/sha}","git_commits_url":"https://api.github.com/repos/Azure/azure-cli/git/commits{/sha}","comments_url":"https://api.github.com/repos/Azure/azure-cli/comments{/number}","issue_comment_url":"https://api.github.com/repos/Azure/azure-cli/issues/comments{/number}","contents_url":"https://api.github.com/repos/Azure/azure-cli/contents/{+path}","compare_url":"https://api.github.com/repos/Azure/azure-cli/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Azure/azure-cli/merges","archive_url":"https://api.github.com/repos/Azure/azure-cli/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Azure/azure-cli/downloads","issues_url":"https://api.github.com/repos/Azure/azure-cli/issues{/number}","pulls_url":"https://api.github.com/repos/Azure/azure-cli/pulls{/number}","milestones_url":"https://api.github.com/repos/Azure/azure-cli/milestones{/number}","notifications_url":"https://api.github.com/repos/Azure/azure-cli/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Azure/azure-cli/labels{/name}","releases_url":"https://api.github.com/repos/Azure/azure-cli/releases{/id}","deployments_url":"https://api.github.com/repos/Azure/azure-cli/deployments","created_at":"2016-02-04T00:21:51Z","updated_at":"2018-07-10T17:24:55Z","pushed_at":"2018-07-10T20:33:13Z","git_url":"git://github.com/Azure/azure-cli.git","ssh_url":"git@github.com:Azure/azure-cli.git","clone_url":"https://github.com/Azure/azure-cli.git","svn_url":"https://github.com/Azure/azure-cli","homepage":null,"size":47723,"stargazers_count":806,"watchers_count":806,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":509,"mirror_url":null,"archived":false,"open_issues_count":777,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":509,"open_issues":777,"watchers":806,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/6740"},"html":{"href":"https://github.com/Azure/azure-cli/pull/6740"},"issue":{"href":"https://api.github.com/repos/Azure/azure-cli/issues/6740"},"comments":{"href":"https://api.github.com/repos/Azure/azure-cli/issues/6740/comments"},"review_comments":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/6740/comments"},"review_comment":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Azure/azure-cli/pulls/6740/commits"},"statuses":{"href":"https://api.github.com/repos/Azure/azure-cli/statuses/bd7bbad81d4a748594244adb4344dd13cc615b92"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tjprescott"}}