{"action":"closed","number":752,"pull_request":{"url":"https://api.github.com/repos/xoseperez/espurna/pulls/752","id":179435888,"html_url":"https://github.com/xoseperez/espurna/pull/752","diff_url":"https://github.com/xoseperez/espurna/pull/752.diff","patch_url":"https://github.com/xoseperez/espurna/pull/752.patch","issue_url":"https://api.github.com/repos/xoseperez/espurna/issues/752","number":752,"state":"closed","locked":false,"title":"WebUI url parsing","user":{"login":"mcspr","id":132763,"avatar_url":"https://avatars2.githubusercontent.com/u/132763?v=4","gravatar_id":"","url":"https://api.github.com/users/mcspr","html_url":"https://github.com/mcspr","followers_url":"https://api.github.com/users/mcspr/followers","following_url":"https://api.github.com/users/mcspr/following{/other_user}","gists_url":"https://api.github.com/users/mcspr/gists{/gist_id}","starred_url":"https://api.github.com/users/mcspr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcspr/subscriptions","organizations_url":"https://api.github.com/users/mcspr/orgs","repos_url":"https://api.github.com/users/mcspr/repos","events_url":"https://api.github.com/users/mcspr/events{/privacy}","received_events_url":"https://api.github.com/users/mcspr/received_events","type":"User","site_admin":false},"body":"Before looking into separate urls for menu I wanted to fix this interaction with menu button on mobile.\r\n- Remove `#menu` from menu button href\r\nGoing to web page on mobile and pressing menu button once locks url with `#menu`\r\nRefreshing without pressing any menu item or just pressing menu again breaks `connect()` - websocket tries to open `ws://<ip>/menuws`\r\n- Using URL API to get `/config`, `/ws` and `/upgrade` urls\r\nJust to be safe\r\n`new URL()` already skips hash from inherited root and is easier to read than string manipulation.","created_at":"2018-04-04T15:53:29Z","updated_at":"2018-04-11T12:11:03Z","closed_at":"2018-04-11T12:11:03Z","merged_at":"2018-04-11T12:11:03Z","merge_commit_sha":"f1ab288cc8b961245f05544f0989a00061a1ed63","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/xoseperez/espurna/pulls/752/commits","review_comments_url":"https://api.github.com/repos/xoseperez/espurna/pulls/752/comments","review_comment_url":"https://api.github.com/repos/xoseperez/espurna/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xoseperez/espurna/issues/752/comments","statuses_url":"https://api.github.com/repos/xoseperez/espurna/statuses/10c19793f50ea08b7fd57e4fed80ff61b3e0fb2b","head":{"label":"mcspr:webui-host","ref":"webui-host","sha":"10c19793f50ea08b7fd57e4fed80ff61b3e0fb2b","user":{"login":"mcspr","id":132763,"avatar_url":"https://avatars2.githubusercontent.com/u/132763?v=4","gravatar_id":"","url":"https://api.github.com/users/mcspr","html_url":"https://github.com/mcspr","followers_url":"https://api.github.com/users/mcspr/followers","following_url":"https://api.github.com/users/mcspr/following{/other_user}","gists_url":"https://api.github.com/users/mcspr/gists{/gist_id}","starred_url":"https://api.github.com/users/mcspr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcspr/subscriptions","organizations_url":"https://api.github.com/users/mcspr/orgs","repos_url":"https://api.github.com/users/mcspr/repos","events_url":"https://api.github.com/users/mcspr/events{/privacy}","received_events_url":"https://api.github.com/users/mcspr/received_events","type":"User","site_admin":false},"repo":{"id":120152536,"name":"espurna","full_name":"mcspr/espurna","owner":{"login":"mcspr","id":132763,"avatar_url":"https://avatars2.githubusercontent.com/u/132763?v=4","gravatar_id":"","url":"https://api.github.com/users/mcspr","html_url":"https://github.com/mcspr","followers_url":"https://api.github.com/users/mcspr/followers","following_url":"https://api.github.com/users/mcspr/following{/other_user}","gists_url":"https://api.github.com/users/mcspr/gists{/gist_id}","starred_url":"https://api.github.com/users/mcspr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcspr/subscriptions","organizations_url":"https://api.github.com/users/mcspr/orgs","repos_url":"https://api.github.com/users/mcspr/repos","events_url":"https://api.github.com/users/mcspr/events{/privacy}","received_events_url":"https://api.github.com/users/mcspr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mcspr/espurna","description":"Home automation firmware for ESP8266-based devices","fork":true,"url":"https://api.github.com/repos/mcspr/espurna","forks_url":"https://api.github.com/repos/mcspr/espurna/forks","keys_url":"https://api.github.com/repos/mcspr/espurna/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mcspr/espurna/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mcspr/espurna/teams","hooks_url":"https://api.github.com/repos/mcspr/espurna/hooks","issue_events_url":"https://api.github.com/repos/mcspr/espurna/issues/events{/number}","events_url":"https://api.github.com/repos/mcspr/espurna/events","assignees_url":"https://api.github.com/repos/mcspr/espurna/assignees{/user}","branches_url":"https://api.github.com/repos/mcspr/espurna/branches{/branch}","tags_url":"https://api.github.com/repos/mcspr/espurna/tags","blobs_url":"https://api.github.com/repos/mcspr/espurna/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mcspr/espurna/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mcspr/espurna/git/refs{/sha}","trees_url":"https://api.github.com/repos/mcspr/espurna/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mcspr/espurna/statuses/{sha}","languages_url":"https://api.github.com/repos/mcspr/espurna/languages","stargazers_url":"https://api.github.com/repos/mcspr/espurna/stargazers","contributors_url":"https://api.github.com/repos/mcspr/espurna/contributors","subscribers_url":"https://api.github.com/repos/mcspr/espurna/subscribers","subscription_url":"https://api.github.com/repos/mcspr/espurna/subscription","commits_url":"https://api.github.com/repos/mcspr/espurna/commits{/sha}","git_commits_url":"https://api.github.com/repos/mcspr/espurna/git/commits{/sha}","comments_url":"https://api.github.com/repos/mcspr/espurna/comments{/number}","issue_comment_url":"https://api.github.com/repos/mcspr/espurna/issues/comments{/number}","contents_url":"https://api.github.com/repos/mcspr/espurna/contents/{+path}","compare_url":"https://api.github.com/repos/mcspr/espurna/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mcspr/espurna/merges","archive_url":"https://api.github.com/repos/mcspr/espurna/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mcspr/espurna/downloads","issues_url":"https://api.github.com/repos/mcspr/espurna/issues{/number}","pulls_url":"https://api.github.com/repos/mcspr/espurna/pulls{/number}","milestones_url":"https://api.github.com/repos/mcspr/espurna/milestones{/number}","notifications_url":"https://api.github.com/repos/mcspr/espurna/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mcspr/espurna/labels{/name}","releases_url":"https://api.github.com/repos/mcspr/espurna/releases{/id}","deployments_url":"https://api.github.com/repos/mcspr/espurna/deployments","created_at":"2018-02-04T03:47:07Z","updated_at":"2018-02-04T03:47:10Z","pushed_at":"2018-04-04T19:32:21Z","git_url":"git://github.com/mcspr/espurna.git","ssh_url":"git@github.com:mcspr/espurna.git","clone_url":"https://github.com/mcspr/espurna.git","svn_url":"https://github.com/mcspr/espurna","homepage":"http://tinkerman.cat","size":42960,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"xoseperez:dev","ref":"dev","sha":"fa20c47f2905c46628cbdde475e899ecc30368a3","user":{"login":"xoseperez","id":706487,"avatar_url":"https://avatars3.githubusercontent.com/u/706487?v=4","gravatar_id":"","url":"https://api.github.com/users/xoseperez","html_url":"https://github.com/xoseperez","followers_url":"https://api.github.com/users/xoseperez/followers","following_url":"https://api.github.com/users/xoseperez/following{/other_user}","gists_url":"https://api.github.com/users/xoseperez/gists{/gist_id}","starred_url":"https://api.github.com/users/xoseperez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xoseperez/subscriptions","organizations_url":"https://api.github.com/users/xoseperez/orgs","repos_url":"https://api.github.com/users/xoseperez/repos","events_url":"https://api.github.com/users/xoseperez/events{/privacy}","received_events_url":"https://api.github.com/users/xoseperez/received_events","type":"User","site_admin":false},"repo":{"id":118768875,"name":"espurna","full_name":"xoseperez/espurna","owner":{"login":"xoseperez","id":706487,"avatar_url":"https://avatars3.githubusercontent.com/u/706487?v=4","gravatar_id":"","url":"https://api.github.com/users/xoseperez","html_url":"https://github.com/xoseperez","followers_url":"https://api.github.com/users/xoseperez/followers","following_url":"https://api.github.com/users/xoseperez/following{/other_user}","gists_url":"https://api.github.com/users/xoseperez/gists{/gist_id}","starred_url":"https://api.github.com/users/xoseperez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xoseperez/subscriptions","organizations_url":"https://api.github.com/users/xoseperez/orgs","repos_url":"https://api.github.com/users/xoseperez/repos","events_url":"https://api.github.com/users/xoseperez/events{/privacy}","received_events_url":"https://api.github.com/users/xoseperez/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xoseperez/espurna","description":"Home automation firmware for ESP8266-based devices","fork":false,"url":"https://api.github.com/repos/xoseperez/espurna","forks_url":"https://api.github.com/repos/xoseperez/espurna/forks","keys_url":"https://api.github.com/repos/xoseperez/espurna/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xoseperez/espurna/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xoseperez/espurna/teams","hooks_url":"https://api.github.com/repos/xoseperez/espurna/hooks","issue_events_url":"https://api.github.com/repos/xoseperez/espurna/issues/events{/number}","events_url":"https://api.github.com/repos/xoseperez/espurna/events","assignees_url":"https://api.github.com/repos/xoseperez/espurna/assignees{/user}","branches_url":"https://api.github.com/repos/xoseperez/espurna/branches{/branch}","tags_url":"https://api.github.com/repos/xoseperez/espurna/tags","blobs_url":"https://api.github.com/repos/xoseperez/espurna/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xoseperez/espurna/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xoseperez/espurna/git/refs{/sha}","trees_url":"https://api.github.com/repos/xoseperez/espurna/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xoseperez/espurna/statuses/{sha}","languages_url":"https://api.github.com/repos/xoseperez/espurna/languages","stargazers_url":"https://api.github.com/repos/xoseperez/espurna/stargazers","contributors_url":"https://api.github.com/repos/xoseperez/espurna/contributors","subscribers_url":"https://api.github.com/repos/xoseperez/espurna/subscribers","subscription_url":"https://api.github.com/repos/xoseperez/espurna/subscription","commits_url":"https://api.github.com/repos/xoseperez/espurna/commits{/sha}","git_commits_url":"https://api.github.com/repos/xoseperez/espurna/git/commits{/sha}","comments_url":"https://api.github.com/repos/xoseperez/espurna/comments{/number}","issue_comment_url":"https://api.github.com/repos/xoseperez/espurna/issues/comments{/number}","contents_url":"https://api.github.com/repos/xoseperez/espurna/contents/{+path}","compare_url":"https://api.github.com/repos/xoseperez/espurna/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xoseperez/espurna/merges","archive_url":"https://api.github.com/repos/xoseperez/espurna/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xoseperez/espurna/downloads","issues_url":"https://api.github.com/repos/xoseperez/espurna/issues{/number}","pulls_url":"https://api.github.com/repos/xoseperez/espurna/pulls{/number}","milestones_url":"https://api.github.com/repos/xoseperez/espurna/milestones{/number}","notifications_url":"https://api.github.com/repos/xoseperez/espurna/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xoseperez/espurna/labels{/name}","releases_url":"https://api.github.com/repos/xoseperez/espurna/releases{/id}","deployments_url":"https://api.github.com/repos/xoseperez/espurna/deployments","created_at":"2018-01-24T13:26:57Z","updated_at":"2018-04-11T12:03:21Z","pushed_at":"2018-04-11T12:11:02Z","git_url":"git://github.com/xoseperez/espurna.git","ssh_url":"git@github.com:xoseperez/espurna.git","clone_url":"https://github.com/xoseperez/espurna.git","svn_url":"https://github.com/xoseperez/espurna","homepage":"http://tinkerman.cat","size":44792,"stargazers_count":388,"watchers_count":388,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":81,"mirror_url":null,"archived":false,"open_issues_count":189,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":81,"open_issues":189,"watchers":388,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/xoseperez/espurna/pulls/752"},"html":{"href":"https://github.com/xoseperez/espurna/pull/752"},"issue":{"href":"https://api.github.com/repos/xoseperez/espurna/issues/752"},"comments":{"href":"https://api.github.com/repos/xoseperez/espurna/issues/752/comments"},"review_comments":{"href":"https://api.github.com/repos/xoseperez/espurna/pulls/752/comments"},"review_comment":{"href":"https://api.github.com/repos/xoseperez/espurna/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xoseperez/espurna/pulls/752/commits"},"statuses":{"href":"https://api.github.com/repos/xoseperez/espurna/statuses/10c19793f50ea08b7fd57e4fed80ff61b3e0fb2b"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"xoseperez","id":706487,"avatar_url":"https://avatars3.githubusercontent.com/u/706487?v=4","gravatar_id":"","url":"https://api.github.com/users/xoseperez","html_url":"https://github.com/xoseperez","followers_url":"https://api.github.com/users/xoseperez/followers","following_url":"https://api.github.com/users/xoseperez/following{/other_user}","gists_url":"https://api.github.com/users/xoseperez/gists{/gist_id}","starred_url":"https://api.github.com/users/xoseperez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xoseperez/subscriptions","organizations_url":"https://api.github.com/users/xoseperez/orgs","repos_url":"https://api.github.com/users/xoseperez/repos","events_url":"https://api.github.com/users/xoseperez/events{/privacy}","received_events_url":"https://api.github.com/users/xoseperez/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":34,"deletions":17,"changed_files":2}}
{"actor":{"display_login":"xoseperez"}}