{"action":"created","comment":{"url":"https://api.github.com/repos/Testy/TestyTs/pulls/comments/239947996","pull_request_review_id":182875825,"id":239947996,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTk0Nzk5Ng==","diff_hunk":"@@ -0,0 +1,19 @@\n+import { TestsVisitor } from '../testVisitor';\n+import { Test } from '../../test';\n+import { TestSuite } from '../../testSuite';\n+\n+export abstract class TestsVisitorDecorator<T> implements TestsVisitor<T> {\n+    protected baseVisitTest: (testSuite: Test) => Promise<T>;\n+    protected baseVisitTestSuite: (testSuite: TestSuite) => Promise<T>;\n+\n+    constructor(private baseVisitor: TestsVisitor<T>) {\n+        this.baseVisitTest = baseVisitor.visitTest.bind(baseVisitor);\n+        this.baseVisitTestSuite = baseVisitor.visitTestSuite.bind(baseVisitor);\n+\n+        this.baseVisitor.visitTest = this.visitTest.bind(this);\n+        this.baseVisitor.visitTestSuite = this.visitTestSuite.bind(this);","path":"src/lib/tests/visitors/decorators/testsVisitorDecorator.ts","position":14,"original_position":14,"commit_id":"02b3f1f7c49e322125b81a7c54c9af2bfb4f7687","original_commit_id":"02b3f1f7c49e322125b81a7c54c9af2bfb4f7687","user":{"login":"Aboisier","id":6698529,"node_id":"MDQ6VXNlcjY2OTg1Mjk=","avatar_url":"https://avatars0.githubusercontent.com/u/6698529?v=4","gravatar_id":"","url":"https://api.github.com/users/Aboisier","html_url":"https://github.com/Aboisier","followers_url":"https://api.github.com/users/Aboisier/followers","following_url":"https://api.github.com/users/Aboisier/following{/other_user}","gists_url":"https://api.github.com/users/Aboisier/gists{/gist_id}","starred_url":"https://api.github.com/users/Aboisier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aboisier/subscriptions","organizations_url":"https://api.github.com/users/Aboisier/orgs","repos_url":"https://api.github.com/users/Aboisier/repos","events_url":"https://api.github.com/users/Aboisier/events{/privacy}","received_events_url":"https://api.github.com/users/Aboisier/received_events","type":"User","site_admin":false},"body":"Okay so moving back the iteration inside the tree creates more problems (aka handling before/after methods execution, filtering the nodes, etc.). The hack doesn't seem that ugly after all. Will continue thinking about this.","created_at":"2018-12-07T21:14:07Z","updated_at":"2018-12-07T21:14:12Z","html_url":"https://github.com/Testy/TestyTs/pull/4#discussion_r239947996","pull_request_url":"https://api.github.com/repos/Testy/TestyTs/pulls/4","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Testy/TestyTs/pulls/comments/239947996"},"html":{"href":"https://github.com/Testy/TestyTs/pull/4#discussion_r239947996"},"pull_request":{"href":"https://api.github.com/repos/Testy/TestyTs/pulls/4"}},"in_reply_to_id":239810694},"pull_request":{"url":"https://api.github.com/repos/Testy/TestyTs/pulls/4","id":236267903,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2MjY3OTAz","html_url":"https://github.com/Testy/TestyTs/pull/4","diff_url":"https://github.com/Testy/TestyTs/pull/4.diff","patch_url":"https://github.com/Testy/TestyTs/pull/4.patch","issue_url":"https://api.github.com/repos/Testy/TestyTs/issues/4","number":4,"state":"open","locked":false,"title":"Test visitor decorators","user":{"login":"Aboisier","id":6698529,"node_id":"MDQ6VXNlcjY2OTg1Mjk=","avatar_url":"https://avatars0.githubusercontent.com/u/6698529?v=4","gravatar_id":"","url":"https://api.github.com/users/Aboisier","html_url":"https://github.com/Aboisier","followers_url":"https://api.github.com/users/Aboisier/followers","following_url":"https://api.github.com/users/Aboisier/following{/other_user}","gists_url":"https://api.github.com/users/Aboisier/gists{/gist_id}","starred_url":"https://api.github.com/users/Aboisier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aboisier/subscriptions","organizations_url":"https://api.github.com/users/Aboisier/orgs","repos_url":"https://api.github.com/users/Aboisier/repos","events_url":"https://api.github.com/users/Aboisier/events{/privacy}","received_events_url":"https://api.github.com/users/Aboisier/received_events","type":"User","site_admin":false},"body":"The current test runner is not extensible. For example, the test reporting is embedded in the test runner class. Implementing the Visual Studio Code adapter involved a full re-implementation of the test runner. \r\n\r\nI believe using a decorator pattern would allow extending the test runner (and eventually other test visitors) more easily.\r\n\r\n![untitled diagram](https://user-images.githubusercontent.com/6698529/49521228-fda1ce00-f872-11e8-8051-ffa11771d21a.png)\r\n\r\nSolves #3 \r\n","created_at":"2018-12-05T17:54:31Z","updated_at":"2018-12-07T21:14:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"10debb277a42cf33b0a19d883408e9089eb93fd2","assignee":{"login":"Aboisier","id":6698529,"node_id":"MDQ6VXNlcjY2OTg1Mjk=","avatar_url":"https://avatars0.githubusercontent.com/u/6698529?v=4","gravatar_id":"","url":"https://api.github.com/users/Aboisier","html_url":"https://github.com/Aboisier","followers_url":"https://api.github.com/users/Aboisier/followers","following_url":"https://api.github.com/users/Aboisier/following{/other_user}","gists_url":"https://api.github.com/users/Aboisier/gists{/gist_id}","starred_url":"https://api.github.com/users/Aboisier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aboisier/subscriptions","organizations_url":"https://api.github.com/users/Aboisier/orgs","repos_url":"https://api.github.com/users/Aboisier/repos","events_url":"https://api.github.com/users/Aboisier/events{/privacy}","received_events_url":"https://api.github.com/users/Aboisier/received_events","type":"User","site_admin":false},"assignees":[{"login":"Aboisier","id":6698529,"node_id":"MDQ6VXNlcjY2OTg1Mjk=","avatar_url":"https://avatars0.githubusercontent.com/u/6698529?v=4","gravatar_id":"","url":"https://api.github.com/users/Aboisier","html_url":"https://github.com/Aboisier","followers_url":"https://api.github.com/users/Aboisier/followers","following_url":"https://api.github.com/users/Aboisier/following{/other_user}","gists_url":"https://api.github.com/users/Aboisier/gists{/gist_id}","starred_url":"https://api.github.com/users/Aboisier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aboisier/subscriptions","organizations_url":"https://api.github.com/users/Aboisier/orgs","repos_url":"https://api.github.com/users/Aboisier/repos","events_url":"https://api.github.com/users/Aboisier/events{/privacy}","received_events_url":"https://api.github.com/users/Aboisier/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Testy/TestyTs/pulls/4/commits","review_comments_url":"https://api.github.com/repos/Testy/TestyTs/pulls/4/comments","review_comment_url":"https://api.github.com/repos/Testy/TestyTs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Testy/TestyTs/issues/4/comments","statuses_url":"https://api.github.com/repos/Testy/TestyTs/statuses/02b3f1f7c49e322125b81a7c54c9af2bfb4f7687","head":{"label":"Testy:test-visitor-decorators","ref":"test-visitor-decorators","sha":"02b3f1f7c49e322125b81a7c54c9af2bfb4f7687","user":{"login":"Testy","id":45183254,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1MTgzMjU0","avatar_url":"https://avatars2.githubusercontent.com/u/45183254?v=4","gravatar_id":"","url":"https://api.github.com/users/Testy","html_url":"https://github.com/Testy","followers_url":"https://api.github.com/users/Testy/followers","following_url":"https://api.github.com/users/Testy/following{/other_user}","gists_url":"https://api.github.com/users/Testy/gists{/gist_id}","starred_url":"https://api.github.com/users/Testy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Testy/subscriptions","organizations_url":"https://api.github.com/users/Testy/orgs","repos_url":"https://api.github.com/users/Testy/repos","events_url":"https://api.github.com/users/Testy/events{/privacy}","received_events_url":"https://api.github.com/users/Testy/received_events","type":"Organization","site_admin":false},"repo":{"id":152934879,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI5MzQ4Nzk=","name":"TestyTs","full_name":"Testy/TestyTs","private":false,"owner":{"login":"Testy","id":45183254,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1MTgzMjU0","avatar_url":"https://avatars2.githubusercontent.com/u/45183254?v=4","gravatar_id":"","url":"https://api.github.com/users/Testy","html_url":"https://github.com/Testy","followers_url":"https://api.github.com/users/Testy/followers","following_url":"https://api.github.com/users/Testy/following{/other_user}","gists_url":"https://api.github.com/users/Testy/gists{/gist_id}","starred_url":"https://api.github.com/users/Testy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Testy/subscriptions","organizations_url":"https://api.github.com/users/Testy/orgs","repos_url":"https://api.github.com/users/Testy/repos","events_url":"https://api.github.com/users/Testy/events{/privacy}","received_events_url":"https://api.github.com/users/Testy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Testy/TestyTs","description":"Modern testing framework for TypeScript.","fork":false,"url":"https://api.github.com/repos/Testy/TestyTs","forks_url":"https://api.github.com/repos/Testy/TestyTs/forks","keys_url":"https://api.github.com/repos/Testy/TestyTs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Testy/TestyTs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Testy/TestyTs/teams","hooks_url":"https://api.github.com/repos/Testy/TestyTs/hooks","issue_events_url":"https://api.github.com/repos/Testy/TestyTs/issues/events{/number}","events_url":"https://api.github.com/repos/Testy/TestyTs/events","assignees_url":"https://api.github.com/repos/Testy/TestyTs/assignees{/user}","branches_url":"https://api.github.com/repos/Testy/TestyTs/branches{/branch}","tags_url":"https://api.github.com/repos/Testy/TestyTs/tags","blobs_url":"https://api.github.com/repos/Testy/TestyTs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Testy/TestyTs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Testy/TestyTs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Testy/TestyTs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Testy/TestyTs/statuses/{sha}","languages_url":"https://api.github.com/repos/Testy/TestyTs/languages","stargazers_url":"https://api.github.com/repos/Testy/TestyTs/stargazers","contributors_url":"https://api.github.com/repos/Testy/TestyTs/contributors","subscribers_url":"https://api.github.com/repos/Testy/TestyTs/subscribers","subscription_url":"https://api.github.com/repos/Testy/TestyTs/subscription","commits_url":"https://api.github.com/repos/Testy/TestyTs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Testy/TestyTs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Testy/TestyTs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Testy/TestyTs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Testy/TestyTs/contents/{+path}","compare_url":"https://api.github.com/repos/Testy/TestyTs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Testy/TestyTs/merges","archive_url":"https://api.github.com/repos/Testy/TestyTs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Testy/TestyTs/downloads","issues_url":"https://api.github.com/repos/Testy/TestyTs/issues{/number}","pulls_url":"https://api.github.com/repos/Testy/TestyTs/pulls{/number}","milestones_url":"https://api.github.com/repos/Testy/TestyTs/milestones{/number}","notifications_url":"https://api.github.com/repos/Testy/TestyTs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Testy/TestyTs/labels{/name}","releases_url":"https://api.github.com/repos/Testy/TestyTs/releases{/id}","deployments_url":"https://api.github.com/repos/Testy/TestyTs/deployments","created_at":"2018-10-14T03:12:58Z","updated_at":"2018-12-03T16:55:34Z","pushed_at":"2018-12-07T13:37:54Z","git_url":"git://github.com/Testy/TestyTs.git","ssh_url":"git@github.com:Testy/TestyTs.git","clone_url":"https://github.com/Testy/TestyTs.git","svn_url":"https://github.com/Testy/TestyTs","homepage":"","size":242,"stargazers_count":4,"watchers_count":4,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc","node_id":"MDc6TGljZW5zZTEw"},"forks":2,"open_issues":4,"watchers":4,"default_branch":"master"}},"base":{"label":"Testy:master","ref":"master","sha":"d15bcac9f4e84daf4c1e45b2a37368584c9a5ce5","user":{"login":"Testy","id":45183254,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1MTgzMjU0","avatar_url":"https://avatars2.githubusercontent.com/u/45183254?v=4","gravatar_id":"","url":"https://api.github.com/users/Testy","html_url":"https://github.com/Testy","followers_url":"https://api.github.com/users/Testy/followers","following_url":"https://api.github.com/users/Testy/following{/other_user}","gists_url":"https://api.github.com/users/Testy/gists{/gist_id}","starred_url":"https://api.github.com/users/Testy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Testy/subscriptions","organizations_url":"https://api.github.com/users/Testy/orgs","repos_url":"https://api.github.com/users/Testy/repos","events_url":"https://api.github.com/users/Testy/events{/privacy}","received_events_url":"https://api.github.com/users/Testy/received_events","type":"Organization","site_admin":false},"repo":{"id":152934879,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI5MzQ4Nzk=","name":"TestyTs","full_name":"Testy/TestyTs","private":false,"owner":{"login":"Testy","id":45183254,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ1MTgzMjU0","avatar_url":"https://avatars2.githubusercontent.com/u/45183254?v=4","gravatar_id":"","url":"https://api.github.com/users/Testy","html_url":"https://github.com/Testy","followers_url":"https://api.github.com/users/Testy/followers","following_url":"https://api.github.com/users/Testy/following{/other_user}","gists_url":"https://api.github.com/users/Testy/gists{/gist_id}","starred_url":"https://api.github.com/users/Testy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Testy/subscriptions","organizations_url":"https://api.github.com/users/Testy/orgs","repos_url":"https://api.github.com/users/Testy/repos","events_url":"https://api.github.com/users/Testy/events{/privacy}","received_events_url":"https://api.github.com/users/Testy/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Testy/TestyTs","description":"Modern testing framework for TypeScript.","fork":false,"url":"https://api.github.com/repos/Testy/TestyTs","forks_url":"https://api.github.com/repos/Testy/TestyTs/forks","keys_url":"https://api.github.com/repos/Testy/TestyTs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Testy/TestyTs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Testy/TestyTs/teams","hooks_url":"https://api.github.com/repos/Testy/TestyTs/hooks","issue_events_url":"https://api.github.com/repos/Testy/TestyTs/issues/events{/number}","events_url":"https://api.github.com/repos/Testy/TestyTs/events","assignees_url":"https://api.github.com/repos/Testy/TestyTs/assignees{/user}","branches_url":"https://api.github.com/repos/Testy/TestyTs/branches{/branch}","tags_url":"https://api.github.com/repos/Testy/TestyTs/tags","blobs_url":"https://api.github.com/repos/Testy/TestyTs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Testy/TestyTs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Testy/TestyTs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Testy/TestyTs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Testy/TestyTs/statuses/{sha}","languages_url":"https://api.github.com/repos/Testy/TestyTs/languages","stargazers_url":"https://api.github.com/repos/Testy/TestyTs/stargazers","contributors_url":"https://api.github.com/repos/Testy/TestyTs/contributors","subscribers_url":"https://api.github.com/repos/Testy/TestyTs/subscribers","subscription_url":"https://api.github.com/repos/Testy/TestyTs/subscription","commits_url":"https://api.github.com/repos/Testy/TestyTs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Testy/TestyTs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Testy/TestyTs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Testy/TestyTs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Testy/TestyTs/contents/{+path}","compare_url":"https://api.github.com/repos/Testy/TestyTs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Testy/TestyTs/merges","archive_url":"https://api.github.com/repos/Testy/TestyTs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Testy/TestyTs/downloads","issues_url":"https://api.github.com/repos/Testy/TestyTs/issues{/number}","pulls_url":"https://api.github.com/repos/Testy/TestyTs/pulls{/number}","milestones_url":"https://api.github.com/repos/Testy/TestyTs/milestones{/number}","notifications_url":"https://api.github.com/repos/Testy/TestyTs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Testy/TestyTs/labels{/name}","releases_url":"https://api.github.com/repos/Testy/TestyTs/releases{/id}","deployments_url":"https://api.github.com/repos/Testy/TestyTs/deployments","created_at":"2018-10-14T03:12:58Z","updated_at":"2018-12-03T16:55:34Z","pushed_at":"2018-12-07T13:37:54Z","git_url":"git://github.com/Testy/TestyTs.git","ssh_url":"git@github.com:Testy/TestyTs.git","clone_url":"https://github.com/Testy/TestyTs.git","svn_url":"https://github.com/Testy/TestyTs","homepage":"","size":242,"stargazers_count":4,"watchers_count":4,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"isc","name":"ISC License","spdx_id":"ISC","url":"https://api.github.com/licenses/isc","node_id":"MDc6TGljZW5zZTEw"},"forks":2,"open_issues":4,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Testy/TestyTs/pulls/4"},"html":{"href":"https://github.com/Testy/TestyTs/pull/4"},"issue":{"href":"https://api.github.com/repos/Testy/TestyTs/issues/4"},"comments":{"href":"https://api.github.com/repos/Testy/TestyTs/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/Testy/TestyTs/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/Testy/TestyTs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Testy/TestyTs/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/Testy/TestyTs/statuses/02b3f1f7c49e322125b81a7c54c9af2bfb4f7687"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"Aboisier"}}