{"action":"created","issue":{"url":"https://api.github.com/repos/highfidelity/hifi/issues/14126","repository_url":"https://api.github.com/repos/highfidelity/hifi","labels_url":"https://api.github.com/repos/highfidelity/hifi/issues/14126/labels{/name}","comments_url":"https://api.github.com/repos/highfidelity/hifi/issues/14126/comments","events_url":"https://api.github.com/repos/highfidelity/hifi/issues/14126/events","html_url":"https://github.com/highfidelity/hifi/pull/14126","id":365699450,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NTU4MDMz","number":14126,"title":"Sit State for the seated user in HMD:  Squatty Potty Fix","user":{"login":"amantley","id":22531620,"node_id":"MDQ6VXNlcjIyNTMxNjIw","avatar_url":"https://avatars0.githubusercontent.com/u/22531620?v=4","gravatar_id":"","url":"https://api.github.com/users/amantley","html_url":"https://github.com/amantley","followers_url":"https://api.github.com/users/amantley/followers","following_url":"https://api.github.com/users/amantley/following{/other_user}","gists_url":"https://api.github.com/users/amantley/gists{/gist_id}","starred_url":"https://api.github.com/users/amantley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amantley/subscriptions","organizations_url":"https://api.github.com/users/amantley/orgs","repos_url":"https://api.github.com/users/amantley/repos","events_url":"https://api.github.com/users/amantley/events{/privacy}","received_events_url":"https://api.github.com/users/amantley/received_events","type":"User","site_admin":false},"labels":[{"id":837498945,"node_id":"MDU6TGFiZWw4Mzc0OTg5NDU=","url":"https://api.github.com/repos/highfidelity/hifi/labels/Avatar","name":"Avatar","color":"fcc4dc","default":false},{"id":278736632,"node_id":"MDU6TGFiZWwyNzg3MzY2MzI=","url":"https://api.github.com/repos/highfidelity/hifi/labels/DO%20NOT%20MERGE","name":"DO NOT MERGE","color":"e11d21","default":false},{"id":278749229,"node_id":"MDU6TGFiZWwyNzg3NDkyMjk=","url":"https://api.github.com/repos/highfidelity/hifi/labels/Feedback%20Welcome","name":"Feedback Welcome","color":"cafc94","default":false},{"id":461634431,"node_id":"MDU6TGFiZWw0NjE2MzQ0MzE=","url":"https://api.github.com/repos/highfidelity/hifi/labels/HMD%20required","name":"HMD required","color":"d4c5f9","default":false},{"id":733764234,"node_id":"MDU6TGFiZWw3MzM3NjQyMzQ=","url":"https://api.github.com/repos/highfidelity/hifi/labels/Project%20Approved","name":"Project Approved","color":"009800","default":false},{"id":313595519,"node_id":"MDU6TGFiZWwzMTM1OTU1MTk=","url":"https://api.github.com/repos/highfidelity/hifi/labels/QA%20Ready","name":"QA Ready","color":"bfd4f2","default":false}],"state":"open","locked":false,"assignee":{"login":"amantley","id":22531620,"node_id":"MDQ6VXNlcjIyNTMxNjIw","avatar_url":"https://avatars0.githubusercontent.com/u/22531620?v=4","gravatar_id":"","url":"https://api.github.com/users/amantley","html_url":"https://github.com/amantley","followers_url":"https://api.github.com/users/amantley/followers","following_url":"https://api.github.com/users/amantley/following{/other_user}","gists_url":"https://api.github.com/users/amantley/gists{/gist_id}","starred_url":"https://api.github.com/users/amantley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amantley/subscriptions","organizations_url":"https://api.github.com/users/amantley/orgs","repos_url":"https://api.github.com/users/amantley/repos","events_url":"https://api.github.com/users/amantley/events{/privacy}","received_events_url":"https://api.github.com/users/amantley/received_events","type":"User","site_admin":false},"assignees":[{"login":"amantley","id":22531620,"node_id":"MDQ6VXNlcjIyNTMxNjIw","avatar_url":"https://avatars0.githubusercontent.com/u/22531620?v=4","gravatar_id":"","url":"https://api.github.com/users/amantley","html_url":"https://github.com/amantley","followers_url":"https://api.github.com/users/amantley/followers","following_url":"https://api.github.com/users/amantley/following{/other_user}","gists_url":"https://api.github.com/users/amantley/gists{/gist_id}","starred_url":"https://api.github.com/users/amantley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/amantley/subscriptions","organizations_url":"https://api.github.com/users/amantley/orgs","repos_url":"https://api.github.com/users/amantley/repos","events_url":"https://api.github.com/users/amantley/events{/privacy}","received_events_url":"https://api.github.com/users/amantley/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/highfidelity/hifi/milestones/35","html_url":"https://github.com/highfidelity/hifi/milestone/35","labels_url":"https://api.github.com/repos/highfidelity/hifi/milestones/35/labels","id":3290834,"node_id":"MDk6TWlsZXN0b25lMzI5MDgzNA==","number":35,"title":"v0.75.0","description":"","creator":{"login":"conklin94122","id":12115653,"node_id":"MDQ6VXNlcjEyMTE1NjUz","avatar_url":"https://avatars2.githubusercontent.com/u/12115653?v=4","gravatar_id":"","url":"https://api.github.com/users/conklin94122","html_url":"https://github.com/conklin94122","followers_url":"https://api.github.com/users/conklin94122/followers","following_url":"https://api.github.com/users/conklin94122/following{/other_user}","gists_url":"https://api.github.com/users/conklin94122/gists{/gist_id}","starred_url":"https://api.github.com/users/conklin94122/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/conklin94122/subscriptions","organizations_url":"https://api.github.com/users/conklin94122/orgs","repos_url":"https://api.github.com/users/conklin94122/repos","events_url":"https://api.github.com/users/conklin94122/events{/privacy}","received_events_url":"https://api.github.com/users/conklin94122/received_events","type":"User","site_admin":false},"open_issues":24,"closed_issues":74,"state":"open","created_at":"2018-04-23T19:27:18Z","updated_at":"2018-10-23T00:24:23Z","due_on":null,"closed_at":null},"comments":86,"created_at":"2018-10-02T01:01:44Z","updated_at":"2018-10-23T06:17:16Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/highfidelity/hifi/pulls/14126","html_url":"https://github.com/highfidelity/hifi/pull/14126","diff_url":"https://github.com/highfidelity/hifi/pull/14126.diff","patch_url":"https://github.com/highfidelity/hifi/pull/14126.patch"},"body":"**This pr addresses the Manuscript case 17185 [squattypotty](https://highfidelity.manuscript.com/f/cases/17185/Courtney-often-seemed-to-be-bowing-during-the-event) that can occur for the seated user who is wearing an HMD.**  \r\n\r\nThe approach is to create a separate state, sitting that treats re-centering differently from our normal standing mode.  In sitting,  horizontal and vertical re-centering are triggered more easily to stop awkward poses.  The algorithm evaluates the start state of the user in hmd mode based on their input height data. When that is missing, we use the default user height to make the best guess.   \r\n\r\nChanges in state from sitting to standing are automatically detected and trigger a snap re-centering.  The transition to sitting is delayed by 4 seconds to allow for the user to reach down and pick things up off the ground without changing state.\r\n\r\nThe user may also force the state to be locked to sit or stand in the avatar app. \r\n\r\nThis pr also includes a squat detection when in standing mode that means if bent knees are happening for 30 seconds, and the spine is relatively straight (within 30 degrees of the vertical), then a vertical recenter will straighten the knees.\r\n\r\nA script that displays a green box for stand state and a red box for sit state is [here](http://hifi-content.s3.amazonaws.com/angus/sitStandState/signalSitting.js) \r\n\r\n### Test plan:\r\n\r\n### Setup:\r\n1) Start Interface and load the [signalSitting.js](http://hifi-content.s3.amazonaws.com/angus/sitStandState/signalSitting.js) script.\r\n2) If you are in away mode then the box in front of you should be green.\r\n3) In both the Vive and the Oculus put on the head set and make sure the hands are following the controllers.  \r\n4) You should either be in front of a mirror or put yourself in 3rd person to view the effects.\r\n\r\n### Test: \r\n1) With the headset on if you are starting sitting, the box should now be red in front of you.\r\n2) With the headset on if you are standing the box should be green in front of you.\r\n3) You should be able to sit and stand and watch the box go from green to red.\r\n4) When you sit there should be a 4 second delay before the box turns red.  Then there should be a snap vertical recentering and your avatar should look like it is standing even though you are sitting\r\n5) When you stand the change to green should be almost instantaneous.  There should be a snap vertical recenter where the floor comes up to the level of your avatar's feet.\r\n6) You should not see a green box when you are sittting in the real world or a red box when you are standing in the real world.\r\n7) In sitting state (red) you should be able to lean back or to the side in your chair and your avatar will move left right and back but not exhibit any squatting behavior.\r\n8) In standing state (green) you should see that your avatar is able to lean forward and left and right following the old center of gravity leaning behavior.\r\n9) In standing state (green) you should be able to lean or squat down and pick up something with out changing to sit state(red).  If this does change to red you should switch back to standing (green) upon standing.\r\n10) When you are in stand state, if you squat enough to bend the knees and stay that way for 30 seconds, then you should see your avatar recenter vertically and stop squatting.\r\n"},"comment":{"url":"https://api.github.com/repos/highfidelity/hifi/issues/comments/432107998","html_url":"https://github.com/highfidelity/hifi/pull/14126#issuecomment-432107998","issue_url":"https://api.github.com/repos/highfidelity/hifi/issues/14126","id":432107998,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMjEwNzk5OA==","user":{"login":"hifi-gustavo","id":4554450,"node_id":"MDQ6VXNlcjQ1NTQ0NTA=","avatar_url":"https://avatars0.githubusercontent.com/u/4554450?v=4","gravatar_id":"","url":"https://api.github.com/users/hifi-gustavo","html_url":"https://github.com/hifi-gustavo","followers_url":"https://api.github.com/users/hifi-gustavo/followers","following_url":"https://api.github.com/users/hifi-gustavo/following{/other_user}","gists_url":"https://api.github.com/users/hifi-gustavo/gists{/gist_id}","starred_url":"https://api.github.com/users/hifi-gustavo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hifi-gustavo/subscriptions","organizations_url":"https://api.github.com/users/hifi-gustavo/orgs","repos_url":"https://api.github.com/users/hifi-gustavo/repos","events_url":"https://api.github.com/users/hifi-gustavo/events{/privacy}","received_events_url":"https://api.github.com/users/hifi-gustavo/received_events","type":"User","site_admin":false},"created_at":"2018-10-23T06:17:16Z","updated_at":"2018-10-23T06:17:16Z","author_association":"NONE","body":"Mac OS X build is available at: https://deployment.highfidelity.com/jobs/pr-build/label%3Dmacos/14282/HighFidelity-Beta-PR14126-3e8663f.dmg"}}
{"actor":{"display_login":"hifi-gustavo"}}