{"action":"created","issue":{"url":"https://api.github.com/repos/ddnexus/pagy-extras/issues/2","repository_url":"https://api.github.com/repos/ddnexus/pagy-extras","labels_url":"https://api.github.com/repos/ddnexus/pagy-extras/issues/2/labels{/name}","comments_url":"https://api.github.com/repos/ddnexus/pagy-extras/issues/2/comments","events_url":"https://api.github.com/repos/ddnexus/pagy-extras/issues/2/events","html_url":"https://github.com/ddnexus/pagy-extras/pull/2","id":326769517,"number":2,"title":"Add proper 'prev'/'next' classes to Bootstrap compact","user":{"login":"cseelus","id":3188392,"avatar_url":"https://avatars0.githubusercontent.com/u/3188392?v=4","gravatar_id":"","url":"https://api.github.com/users/cseelus","html_url":"https://github.com/cseelus","followers_url":"https://api.github.com/users/cseelus/followers","following_url":"https://api.github.com/users/cseelus/following{/other_user}","gists_url":"https://api.github.com/users/cseelus/gists{/gist_id}","starred_url":"https://api.github.com/users/cseelus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cseelus/subscriptions","organizations_url":"https://api.github.com/users/cseelus/orgs","repos_url":"https://api.github.com/users/cseelus/repos","events_url":"https://api.github.com/users/cseelus/events{/privacy}","received_events_url":"https://api.github.com/users/cseelus/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-26T21:47:48Z","updated_at":"2018-05-27T12:45:29Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/ddnexus/pagy-extras/pulls/2","html_url":"https://github.com/ddnexus/pagy-extras/pull/2","diff_url":"https://github.com/ddnexus/pagy-extras/pull/2.diff","patch_url":"https://github.com/ddnexus/pagy-extras/pull/2.patch"},"body":"This PR adds classes to the prev/next buttons, that enable differentiating those buttons in the DOM and to better target these buttons via CSS and JS."},"comment":{"url":"https://api.github.com/repos/ddnexus/pagy-extras/issues/comments/392328513","html_url":"https://github.com/ddnexus/pagy-extras/pull/2#issuecomment-392328513","issue_url":"https://api.github.com/repos/ddnexus/pagy-extras/issues/2","id":392328513,"user":{"login":"cseelus","id":3188392,"avatar_url":"https://avatars0.githubusercontent.com/u/3188392?v=4","gravatar_id":"","url":"https://api.github.com/users/cseelus","html_url":"https://github.com/cseelus","followers_url":"https://api.github.com/users/cseelus/followers","following_url":"https://api.github.com/users/cseelus/following{/other_user}","gists_url":"https://api.github.com/users/cseelus/gists{/gist_id}","starred_url":"https://api.github.com/users/cseelus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cseelus/subscriptions","organizations_url":"https://api.github.com/users/cseelus/orgs","repos_url":"https://api.github.com/users/cseelus/repos","events_url":"https://api.github.com/users/cseelus/events{/privacy}","received_events_url":"https://api.github.com/users/cseelus/received_events","type":"User","site_admin":false},"created_at":"2018-05-27T12:45:29Z","updated_at":"2018-05-27T12:45:29Z","author_association":"NONE","body":"Hi @ddnexus,\r\n\r\nthanks for the quick response.\r\n\r\n1. Will change to just 'prev' and 'next'. One use case we implemented, is to cleanly access those links via JS to implement keyboard navigation. Also projects like [CSS Zen Garden](https://en.wikipedia.org/wiki/CSS_Zen_Garden) and practical experience thought me that its always a good idea to mark up your HTML in a way that the styling can be changed without touching the HTML later, which means using expressive class or id names that allow targeting elements individually. In our project we replaced the prev/next buttons content with Fontawesome chevron icons via CSS: <img width=\"389\" alt=\"screen shot 2018-05-27 at 14 43 09\" src=\"https://user-images.githubusercontent.com/3188392/40586072-4fda2576-61bc-11e8-98bd-759b2d11211c.png\">\r\n2. How would you go about adding those classes then?\r\n3. The [HTML5 spec](https://www.w3.org/TR/2012/WD-html5-20120329/the-button-element.html#the-button-element) states that `<button>`s may only contain phrasing content (\"Phrasing content is the text of the document, as well as elements that mark up that text at the intra-paragraph level.\")."}}
{"actor":{"display_login":"cseelus"}}