{"action":"created","comment":{"url":"https://api.github.com/repos/portworx/px-docs/pulls/comments/233350679","pull_request_review_id":174741294,"id":233350679,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzM1MDY3OQ==","diff_hunk":"@@ -11,50 +11,58 @@ meta-description: \"Find out how to easily deploy Elasticsearch and Kibana on Kub\n \n These below instructions will provide you with a step by step guide in deploying the Elasticstack (Elastic Search, Logstash, Kibana) with Portworx on Kubernetes.\n \n-Elasticsearch creates a cluster based on the cluster name property specified in the configuration. Each node within the cluster can forward client requests to the appropriate node and also knows about every other node in the cluster. \n+Elasticsearch creates a cluster based on the cluster name property specified in the configuration. Each node within the cluster can forward client requests to the appropriate node and also knows about every other node in the cluster.\n \n-An Elasticsearch cluster node can have one or more purposes. \n+An Elasticsearch cluster node can have one or more purposes.\n - Master-eligible node\n-\tA node that has node.master set to true (default), which makes it eligible to be elected as the master node, which controls the cluster.\n+    A node that has node.master set to true (default), which makes it eligible to be elected as the master node, which controls the cluster.\n - Data node\n-\tA node that has node.data set to true (default). Data nodes hold data and perform data related operations such as CRUD, search, and aggregations.\n-- Client node\n-\tA node which only routes requests, handles the search reduce phase, and distributes bulk indexing. Consumers of the elastic search cluster interact with the client nodes.\n-\n+    A node that has node.data set to true (default). Data nodes hold data and perform data related operations such as CRUD, search, and aggregations.\n+- Coordinating node\n+    A node which only routes requests, handles the search reduce phase, and distributes bulk indexing. Consumers of the elastic search cluster interact with the coordinator nodes.\n \n ## Prerequisites\n--\tA running Kubernetes cluster with v 1.6+\n--\tAll the kubernetes nodes should allow [shared mount propagation](https://docs.portworx.com/knowledgebase/shared-mount-propagation.html). PX requires this since it provisions volumes in containers.\n--\t[Deploy Portworx on your kubernetes cluster](https://docs.portworx.com/scheduler/kubernetes/install.html). PX runs on each node of your kubernetes cluster as a daemonset.\n+-    A running Kubernetes cluster with v 1.6+\n+-    All the kubernetes nodes should allow [shared mount propagation](https://docs.portworx.com/knowledgebase/shared-mount-propagation.html). PX requires this since it provisions volumes in containers.","path":"scheduler/kubernetes/elasticstack-kibana-k8s.md","position":26,"original_position":26,"commit_id":"fdd798ea6f542d54eb341107be2834cd38bd3aa4","original_commit_id":"fdd798ea6f542d54eb341107be2834cd38bd3aa4","user":{"login":"harsh-px","id":26801153,"node_id":"MDQ6VXNlcjI2ODAxMTUz","avatar_url":"https://avatars1.githubusercontent.com/u/26801153?v=4","gravatar_id":"","url":"https://api.github.com/users/harsh-px","html_url":"https://github.com/harsh-px","followers_url":"https://api.github.com/users/harsh-px/followers","following_url":"https://api.github.com/users/harsh-px/following{/other_user}","gists_url":"https://api.github.com/users/harsh-px/gists{/gist_id}","starred_url":"https://api.github.com/users/harsh-px/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/harsh-px/subscriptions","organizations_url":"https://api.github.com/users/harsh-px/orgs","repos_url":"https://api.github.com/users/harsh-px/repos","events_url":"https://api.github.com/users/harsh-px/events{/privacy}","received_events_url":"https://api.github.com/users/harsh-px/received_events","type":"User","site_admin":false},"body":"this can be removed","created_at":"2018-11-14T08:29:05Z","updated_at":"2018-11-14T08:36:33Z","html_url":"https://github.com/portworx/px-docs/pull/502#discussion_r233350679","pull_request_url":"https://api.github.com/repos/portworx/px-docs/pulls/502","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/portworx/px-docs/pulls/comments/233350679"},"html":{"href":"https://github.com/portworx/px-docs/pull/502#discussion_r233350679"},"pull_request":{"href":"https://api.github.com/repos/portworx/px-docs/pulls/502"}}},"pull_request":{"url":"https://api.github.com/repos/portworx/px-docs/pulls/502","id":230274880,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMjc0ODgw","html_url":"https://github.com/portworx/px-docs/pull/502","diff_url":"https://github.com/portworx/px-docs/pull/502.diff","patch_url":"https://github.com/portworx/px-docs/pull/502.patch","issue_url":"https://api.github.com/repos/portworx/px-docs/issues/502","number":502,"state":"open","locked":false,"title":"Fix elastic search docs","user":{"login":"disrani-px","id":25230810,"node_id":"MDQ6VXNlcjI1MjMwODEw","avatar_url":"https://avatars3.githubusercontent.com/u/25230810?v=4","gravatar_id":"","url":"https://api.github.com/users/disrani-px","html_url":"https://github.com/disrani-px","followers_url":"https://api.github.com/users/disrani-px/followers","following_url":"https://api.github.com/users/disrani-px/following{/other_user}","gists_url":"https://api.github.com/users/disrani-px/gists{/gist_id}","starred_url":"https://api.github.com/users/disrani-px/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/disrani-px/subscriptions","organizations_url":"https://api.github.com/users/disrani-px/orgs","repos_url":"https://api.github.com/users/disrani-px/repos","events_url":"https://api.github.com/users/disrani-px/events{/privacy}","received_events_url":"https://api.github.com/users/disrani-px/received_events","type":"User","site_admin":false},"body":"- Replace client nodes with coordinator nodes. There is no such thing as a \"client node\" in\r\n  elastic search.\r\n- Add storage class to be used for master nodes.\r\n- Update master node to use a stateful set instead of a deployment. They need persistent\r\n  storage too.\r\n- Update to use elastic v6.3.2 images\r\n- Use elasticseach svc dns name instead of clusterIP","created_at":"2018-11-12T21:32:12Z","updated_at":"2018-11-14T08:36:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a64a1721957fe04393008e596c50cd872f9910c0","assignee":null,"assignees":[],"requested_reviewers":[{"login":"venkatpx","id":25569725,"node_id":"MDQ6VXNlcjI1NTY5NzI1","avatar_url":"https://avatars1.githubusercontent.com/u/25569725?v=4","gravatar_id":"","url":"https://api.github.com/users/venkatpx","html_url":"https://github.com/venkatpx","followers_url":"https://api.github.com/users/venkatpx/followers","following_url":"https://api.github.com/users/venkatpx/following{/other_user}","gists_url":"https://api.github.com/users/venkatpx/gists{/gist_id}","starred_url":"https://api.github.com/users/venkatpx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/venkatpx/subscriptions","organizations_url":"https://api.github.com/users/venkatpx/orgs","repos_url":"https://api.github.com/users/venkatpx/repos","events_url":"https://api.github.com/users/venkatpx/events{/privacy}","received_events_url":"https://api.github.com/users/venkatpx/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/portworx/px-docs/pulls/502/commits","review_comments_url":"https://api.github.com/repos/portworx/px-docs/pulls/502/comments","review_comment_url":"https://api.github.com/repos/portworx/px-docs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/portworx/px-docs/issues/502/comments","statuses_url":"https://api.github.com/repos/portworx/px-docs/statuses/fdd798ea6f542d54eb341107be2834cd38bd3aa4","head":{"label":"portworx:elasticsearch_docs_fix","ref":"elasticsearch_docs_fix","sha":"fdd798ea6f542d54eb341107be2834cd38bd3aa4","user":{"login":"portworx","id":12014092,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMDE0MDky","avatar_url":"https://avatars3.githubusercontent.com/u/12014092?v=4","gravatar_id":"","url":"https://api.github.com/users/portworx","html_url":"https://github.com/portworx","followers_url":"https://api.github.com/users/portworx/followers","following_url":"https://api.github.com/users/portworx/following{/other_user}","gists_url":"https://api.github.com/users/portworx/gists{/gist_id}","starred_url":"https://api.github.com/users/portworx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/portworx/subscriptions","organizations_url":"https://api.github.com/users/portworx/orgs","repos_url":"https://api.github.com/users/portworx/repos","events_url":"https://api.github.com/users/portworx/events{/privacy}","received_events_url":"https://api.github.com/users/portworx/received_events","type":"Organization","site_admin":false},"repo":{"id":64517329,"node_id":"MDEwOlJlcG9zaXRvcnk2NDUxNzMyOQ==","name":"px-docs","full_name":"portworx/px-docs","private":false,"owner":{"login":"portworx","id":12014092,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMDE0MDky","avatar_url":"https://avatars3.githubusercontent.com/u/12014092?v=4","gravatar_id":"","url":"https://api.github.com/users/portworx","html_url":"https://github.com/portworx","followers_url":"https://api.github.com/users/portworx/followers","following_url":"https://api.github.com/users/portworx/following{/other_user}","gists_url":"https://api.github.com/users/portworx/gists{/gist_id}","starred_url":"https://api.github.com/users/portworx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/portworx/subscriptions","organizations_url":"https://api.github.com/users/portworx/orgs","repos_url":"https://api.github.com/users/portworx/repos","events_url":"https://api.github.com/users/portworx/events{/privacy}","received_events_url":"https://api.github.com/users/portworx/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/portworx/px-docs","description":"View Portworx Documentation at","fork":false,"url":"https://api.github.com/repos/portworx/px-docs","forks_url":"https://api.github.com/repos/portworx/px-docs/forks","keys_url":"https://api.github.com/repos/portworx/px-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/portworx/px-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/portworx/px-docs/teams","hooks_url":"https://api.github.com/repos/portworx/px-docs/hooks","issue_events_url":"https://api.github.com/repos/portworx/px-docs/issues/events{/number}","events_url":"https://api.github.com/repos/portworx/px-docs/events","assignees_url":"https://api.github.com/repos/portworx/px-docs/assignees{/user}","branches_url":"https://api.github.com/repos/portworx/px-docs/branches{/branch}","tags_url":"https://api.github.com/repos/portworx/px-docs/tags","blobs_url":"https://api.github.com/repos/portworx/px-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/portworx/px-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/portworx/px-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/portworx/px-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/portworx/px-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/portworx/px-docs/languages","stargazers_url":"https://api.github.com/repos/portworx/px-docs/stargazers","contributors_url":"https://api.github.com/repos/portworx/px-docs/contributors","subscribers_url":"https://api.github.com/repos/portworx/px-docs/subscribers","subscription_url":"https://api.github.com/repos/portworx/px-docs/subscription","commits_url":"https://api.github.com/repos/portworx/px-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/portworx/px-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/portworx/px-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/portworx/px-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/portworx/px-docs/contents/{+path}","compare_url":"https://api.github.com/repos/portworx/px-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/portworx/px-docs/merges","archive_url":"https://api.github.com/repos/portworx/px-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/portworx/px-docs/downloads","issues_url":"https://api.github.com/repos/portworx/px-docs/issues{/number}","pulls_url":"https://api.github.com/repos/portworx/px-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/portworx/px-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/portworx/px-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/portworx/px-docs/labels{/name}","releases_url":"https://api.github.com/repos/portworx/px-docs/releases{/id}","deployments_url":"https://api.github.com/repos/portworx/px-docs/deployments","created_at":"2016-07-30T00:08:49Z","updated_at":"2018-11-14T05:52:47Z","pushed_at":"2018-11-14T01:12:19Z","git_url":"git://github.com/portworx/px-docs.git","ssh_url":"git@github.com:portworx/px-docs.git","clone_url":"https://github.com/portworx/px-docs.git","svn_url":"https://github.com/portworx/px-docs","homepage":"http://docs.portworx.com","size":44088,"stargazers_count":20,"watchers_count":20,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":41,"mirror_url":null,"archived":false,"open_issues_count":16,"license":null,"forks":41,"open_issues":16,"watchers":20,"default_branch":"gh-pages"}},"base":{"label":"portworx:gh-pages","ref":"gh-pages","sha":"d2f5605fd01ef386bd425e157cab2f6350622ec9","user":{"login":"portworx","id":12014092,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMDE0MDky","avatar_url":"https://avatars3.githubusercontent.com/u/12014092?v=4","gravatar_id":"","url":"https://api.github.com/users/portworx","html_url":"https://github.com/portworx","followers_url":"https://api.github.com/users/portworx/followers","following_url":"https://api.github.com/users/portworx/following{/other_user}","gists_url":"https://api.github.com/users/portworx/gists{/gist_id}","starred_url":"https://api.github.com/users/portworx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/portworx/subscriptions","organizations_url":"https://api.github.com/users/portworx/orgs","repos_url":"https://api.github.com/users/portworx/repos","events_url":"https://api.github.com/users/portworx/events{/privacy}","received_events_url":"https://api.github.com/users/portworx/received_events","type":"Organization","site_admin":false},"repo":{"id":64517329,"node_id":"MDEwOlJlcG9zaXRvcnk2NDUxNzMyOQ==","name":"px-docs","full_name":"portworx/px-docs","private":false,"owner":{"login":"portworx","id":12014092,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyMDE0MDky","avatar_url":"https://avatars3.githubusercontent.com/u/12014092?v=4","gravatar_id":"","url":"https://api.github.com/users/portworx","html_url":"https://github.com/portworx","followers_url":"https://api.github.com/users/portworx/followers","following_url":"https://api.github.com/users/portworx/following{/other_user}","gists_url":"https://api.github.com/users/portworx/gists{/gist_id}","starred_url":"https://api.github.com/users/portworx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/portworx/subscriptions","organizations_url":"https://api.github.com/users/portworx/orgs","repos_url":"https://api.github.com/users/portworx/repos","events_url":"https://api.github.com/users/portworx/events{/privacy}","received_events_url":"https://api.github.com/users/portworx/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/portworx/px-docs","description":"View Portworx Documentation at","fork":false,"url":"https://api.github.com/repos/portworx/px-docs","forks_url":"https://api.github.com/repos/portworx/px-docs/forks","keys_url":"https://api.github.com/repos/portworx/px-docs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/portworx/px-docs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/portworx/px-docs/teams","hooks_url":"https://api.github.com/repos/portworx/px-docs/hooks","issue_events_url":"https://api.github.com/repos/portworx/px-docs/issues/events{/number}","events_url":"https://api.github.com/repos/portworx/px-docs/events","assignees_url":"https://api.github.com/repos/portworx/px-docs/assignees{/user}","branches_url":"https://api.github.com/repos/portworx/px-docs/branches{/branch}","tags_url":"https://api.github.com/repos/portworx/px-docs/tags","blobs_url":"https://api.github.com/repos/portworx/px-docs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/portworx/px-docs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/portworx/px-docs/git/refs{/sha}","trees_url":"https://api.github.com/repos/portworx/px-docs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/portworx/px-docs/statuses/{sha}","languages_url":"https://api.github.com/repos/portworx/px-docs/languages","stargazers_url":"https://api.github.com/repos/portworx/px-docs/stargazers","contributors_url":"https://api.github.com/repos/portworx/px-docs/contributors","subscribers_url":"https://api.github.com/repos/portworx/px-docs/subscribers","subscription_url":"https://api.github.com/repos/portworx/px-docs/subscription","commits_url":"https://api.github.com/repos/portworx/px-docs/commits{/sha}","git_commits_url":"https://api.github.com/repos/portworx/px-docs/git/commits{/sha}","comments_url":"https://api.github.com/repos/portworx/px-docs/comments{/number}","issue_comment_url":"https://api.github.com/repos/portworx/px-docs/issues/comments{/number}","contents_url":"https://api.github.com/repos/portworx/px-docs/contents/{+path}","compare_url":"https://api.github.com/repos/portworx/px-docs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/portworx/px-docs/merges","archive_url":"https://api.github.com/repos/portworx/px-docs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/portworx/px-docs/downloads","issues_url":"https://api.github.com/repos/portworx/px-docs/issues{/number}","pulls_url":"https://api.github.com/repos/portworx/px-docs/pulls{/number}","milestones_url":"https://api.github.com/repos/portworx/px-docs/milestones{/number}","notifications_url":"https://api.github.com/repos/portworx/px-docs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/portworx/px-docs/labels{/name}","releases_url":"https://api.github.com/repos/portworx/px-docs/releases{/id}","deployments_url":"https://api.github.com/repos/portworx/px-docs/deployments","created_at":"2016-07-30T00:08:49Z","updated_at":"2018-11-14T05:52:47Z","pushed_at":"2018-11-14T01:12:19Z","git_url":"git://github.com/portworx/px-docs.git","ssh_url":"git@github.com:portworx/px-docs.git","clone_url":"https://github.com/portworx/px-docs.git","svn_url":"https://github.com/portworx/px-docs","homepage":"http://docs.portworx.com","size":44088,"stargazers_count":20,"watchers_count":20,"language":"CSS","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":41,"mirror_url":null,"archived":false,"open_issues_count":16,"license":null,"forks":41,"open_issues":16,"watchers":20,"default_branch":"gh-pages"}},"_links":{"self":{"href":"https://api.github.com/repos/portworx/px-docs/pulls/502"},"html":{"href":"https://github.com/portworx/px-docs/pull/502"},"issue":{"href":"https://api.github.com/repos/portworx/px-docs/issues/502"},"comments":{"href":"https://api.github.com/repos/portworx/px-docs/issues/502/comments"},"review_comments":{"href":"https://api.github.com/repos/portworx/px-docs/pulls/502/comments"},"review_comment":{"href":"https://api.github.com/repos/portworx/px-docs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/portworx/px-docs/pulls/502/commits"},"statuses":{"href":"https://api.github.com/repos/portworx/px-docs/statuses/fdd798ea6f542d54eb341107be2834cd38bd3aa4"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"harsh-px"}}