{"action":"closed","number":133,"pull_request":{"url":"https://api.github.com/repos/m3db/m3x/pulls/133","id":176659442,"html_url":"https://github.com/m3db/m3x/pull/133","diff_url":"https://github.com/m3db/m3x/pull/133.diff","patch_url":"https://github.com/m3db/m3x/pull/133.patch","issue_url":"https://api.github.com/repos/m3db/m3x/issues/133","number":133,"state":"closed","locked":false,"title":"Add generic value type map for ident.ID and []byte key based maps","user":{"login":"robskillington","id":339615,"avatar_url":"https://avatars1.githubusercontent.com/u/339615?v=4","gravatar_id":"","url":"https://api.github.com/users/robskillington","html_url":"https://github.com/robskillington","followers_url":"https://api.github.com/users/robskillington/followers","following_url":"https://api.github.com/users/robskillington/following{/other_user}","gists_url":"https://api.github.com/users/robskillington/gists{/gist_id}","starred_url":"https://api.github.com/users/robskillington/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robskillington/subscriptions","organizations_url":"https://api.github.com/users/robskillington/orgs","repos_url":"https://api.github.com/users/robskillington/repos","events_url":"https://api.github.com/users/robskillington/events{/privacy}","received_events_url":"https://api.github.com/users/robskillington/received_events","type":"User","site_admin":false},"body":"This adds a generic value type map that we can use for anything package using the `ident.ID` type.\r\n\r\nYou can generate the source for the map using:\r\n```sh\r\nVALUE_TYPE=AnyType go generate\r\n```\r\n\r\ncc @jeromefroe @prateek @xichen2020 ","created_at":"2018-03-22T02:28:19Z","updated_at":"2018-03-27T17:58:53Z","closed_at":"2018-03-27T17:58:53Z","merged_at":"2018-03-27T17:58:53Z","merge_commit_sha":"d0873c0b327bee1a4a47f1d84263a6edaebbbf66","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/m3db/m3x/pulls/133/commits","review_comments_url":"https://api.github.com/repos/m3db/m3x/pulls/133/comments","review_comment_url":"https://api.github.com/repos/m3db/m3x/pulls/comments{/number}","comments_url":"https://api.github.com/repos/m3db/m3x/issues/133/comments","statuses_url":"https://api.github.com/repos/m3db/m3x/statuses/cc07318f1dbaf04344f8d83028d2a3b9738a5db2","head":{"label":"m3db:r/add-generic-map","ref":"r/add-generic-map","sha":"cc07318f1dbaf04344f8d83028d2a3b9738a5db2","user":{"login":"m3db","id":19937171,"avatar_url":"https://avatars0.githubusercontent.com/u/19937171?v=4","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"repo":{"id":64251470,"name":"m3x","full_name":"m3db/m3x","owner":{"login":"m3db","id":19937171,"avatar_url":"https://avatars0.githubusercontent.com/u/19937171?v=4","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/m3db/m3x","description":"Packages part of the M3DB project but outside the main tree with loose compatibility requirements","fork":false,"url":"https://api.github.com/repos/m3db/m3x","forks_url":"https://api.github.com/repos/m3db/m3x/forks","keys_url":"https://api.github.com/repos/m3db/m3x/keys{/key_id}","collaborators_url":"https://api.github.com/repos/m3db/m3x/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/m3db/m3x/teams","hooks_url":"https://api.github.com/repos/m3db/m3x/hooks","issue_events_url":"https://api.github.com/repos/m3db/m3x/issues/events{/number}","events_url":"https://api.github.com/repos/m3db/m3x/events","assignees_url":"https://api.github.com/repos/m3db/m3x/assignees{/user}","branches_url":"https://api.github.com/repos/m3db/m3x/branches{/branch}","tags_url":"https://api.github.com/repos/m3db/m3x/tags","blobs_url":"https://api.github.com/repos/m3db/m3x/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/m3db/m3x/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/m3db/m3x/git/refs{/sha}","trees_url":"https://api.github.com/repos/m3db/m3x/git/trees{/sha}","statuses_url":"https://api.github.com/repos/m3db/m3x/statuses/{sha}","languages_url":"https://api.github.com/repos/m3db/m3x/languages","stargazers_url":"https://api.github.com/repos/m3db/m3x/stargazers","contributors_url":"https://api.github.com/repos/m3db/m3x/contributors","subscribers_url":"https://api.github.com/repos/m3db/m3x/subscribers","subscription_url":"https://api.github.com/repos/m3db/m3x/subscription","commits_url":"https://api.github.com/repos/m3db/m3x/commits{/sha}","git_commits_url":"https://api.github.com/repos/m3db/m3x/git/commits{/sha}","comments_url":"https://api.github.com/repos/m3db/m3x/comments{/number}","issue_comment_url":"https://api.github.com/repos/m3db/m3x/issues/comments{/number}","contents_url":"https://api.github.com/repos/m3db/m3x/contents/{+path}","compare_url":"https://api.github.com/repos/m3db/m3x/compare/{base}...{head}","merges_url":"https://api.github.com/repos/m3db/m3x/merges","archive_url":"https://api.github.com/repos/m3db/m3x/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/m3db/m3x/downloads","issues_url":"https://api.github.com/repos/m3db/m3x/issues{/number}","pulls_url":"https://api.github.com/repos/m3db/m3x/pulls{/number}","milestones_url":"https://api.github.com/repos/m3db/m3x/milestones{/number}","notifications_url":"https://api.github.com/repos/m3db/m3x/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/m3db/m3x/labels{/name}","releases_url":"https://api.github.com/repos/m3db/m3x/releases{/id}","deployments_url":"https://api.github.com/repos/m3db/m3x/deployments","created_at":"2016-07-26T20:16:52Z","updated_at":"2018-03-27T01:44:58Z","pushed_at":"2018-03-27T17:58:53Z","git_url":"git://github.com/m3db/m3x.git","ssh_url":"git@github.com:m3db/m3x.git","clone_url":"https://github.com/m3db/m3x.git","svn_url":"https://github.com/m3db/m3x","homepage":"","size":406,"stargazers_count":5,"watchers_count":5,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":2,"watchers":5,"default_branch":"master"}},"base":{"label":"m3db:master","ref":"master","sha":"8bfb57c2e1a57770262378f26833110fbd029d94","user":{"login":"m3db","id":19937171,"avatar_url":"https://avatars0.githubusercontent.com/u/19937171?v=4","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"repo":{"id":64251470,"name":"m3x","full_name":"m3db/m3x","owner":{"login":"m3db","id":19937171,"avatar_url":"https://avatars0.githubusercontent.com/u/19937171?v=4","gravatar_id":"","url":"https://api.github.com/users/m3db","html_url":"https://github.com/m3db","followers_url":"https://api.github.com/users/m3db/followers","following_url":"https://api.github.com/users/m3db/following{/other_user}","gists_url":"https://api.github.com/users/m3db/gists{/gist_id}","starred_url":"https://api.github.com/users/m3db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3db/subscriptions","organizations_url":"https://api.github.com/users/m3db/orgs","repos_url":"https://api.github.com/users/m3db/repos","events_url":"https://api.github.com/users/m3db/events{/privacy}","received_events_url":"https://api.github.com/users/m3db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/m3db/m3x","description":"Packages part of the M3DB project but outside the main tree with loose compatibility requirements","fork":false,"url":"https://api.github.com/repos/m3db/m3x","forks_url":"https://api.github.com/repos/m3db/m3x/forks","keys_url":"https://api.github.com/repos/m3db/m3x/keys{/key_id}","collaborators_url":"https://api.github.com/repos/m3db/m3x/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/m3db/m3x/teams","hooks_url":"https://api.github.com/repos/m3db/m3x/hooks","issue_events_url":"https://api.github.com/repos/m3db/m3x/issues/events{/number}","events_url":"https://api.github.com/repos/m3db/m3x/events","assignees_url":"https://api.github.com/repos/m3db/m3x/assignees{/user}","branches_url":"https://api.github.com/repos/m3db/m3x/branches{/branch}","tags_url":"https://api.github.com/repos/m3db/m3x/tags","blobs_url":"https://api.github.com/repos/m3db/m3x/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/m3db/m3x/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/m3db/m3x/git/refs{/sha}","trees_url":"https://api.github.com/repos/m3db/m3x/git/trees{/sha}","statuses_url":"https://api.github.com/repos/m3db/m3x/statuses/{sha}","languages_url":"https://api.github.com/repos/m3db/m3x/languages","stargazers_url":"https://api.github.com/repos/m3db/m3x/stargazers","contributors_url":"https://api.github.com/repos/m3db/m3x/contributors","subscribers_url":"https://api.github.com/repos/m3db/m3x/subscribers","subscription_url":"https://api.github.com/repos/m3db/m3x/subscription","commits_url":"https://api.github.com/repos/m3db/m3x/commits{/sha}","git_commits_url":"https://api.github.com/repos/m3db/m3x/git/commits{/sha}","comments_url":"https://api.github.com/repos/m3db/m3x/comments{/number}","issue_comment_url":"https://api.github.com/repos/m3db/m3x/issues/comments{/number}","contents_url":"https://api.github.com/repos/m3db/m3x/contents/{+path}","compare_url":"https://api.github.com/repos/m3db/m3x/compare/{base}...{head}","merges_url":"https://api.github.com/repos/m3db/m3x/merges","archive_url":"https://api.github.com/repos/m3db/m3x/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/m3db/m3x/downloads","issues_url":"https://api.github.com/repos/m3db/m3x/issues{/number}","pulls_url":"https://api.github.com/repos/m3db/m3x/pulls{/number}","milestones_url":"https://api.github.com/repos/m3db/m3x/milestones{/number}","notifications_url":"https://api.github.com/repos/m3db/m3x/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/m3db/m3x/labels{/name}","releases_url":"https://api.github.com/repos/m3db/m3x/releases{/id}","deployments_url":"https://api.github.com/repos/m3db/m3x/deployments","created_at":"2016-07-26T20:16:52Z","updated_at":"2018-03-27T01:44:58Z","pushed_at":"2018-03-27T17:58:53Z","git_url":"git://github.com/m3db/m3x.git","ssh_url":"git@github.com:m3db/m3x.git","clone_url":"https://github.com/m3db/m3x.git","svn_url":"https://github.com/m3db/m3x","homepage":"","size":406,"stargazers_count":5,"watchers_count":5,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":2,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/m3db/m3x/pulls/133"},"html":{"href":"https://github.com/m3db/m3x/pull/133"},"issue":{"href":"https://api.github.com/repos/m3db/m3x/issues/133"},"comments":{"href":"https://api.github.com/repos/m3db/m3x/issues/133/comments"},"review_comments":{"href":"https://api.github.com/repos/m3db/m3x/pulls/133/comments"},"review_comment":{"href":"https://api.github.com/repos/m3db/m3x/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/m3db/m3x/pulls/133/commits"},"statuses":{"href":"https://api.github.com/repos/m3db/m3x/statuses/cc07318f1dbaf04344f8d83028d2a3b9738a5db2"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"robskillington","id":339615,"avatar_url":"https://avatars1.githubusercontent.com/u/339615?v=4","gravatar_id":"","url":"https://api.github.com/users/robskillington","html_url":"https://github.com/robskillington","followers_url":"https://api.github.com/users/robskillington/followers","following_url":"https://api.github.com/users/robskillington/following{/other_user}","gists_url":"https://api.github.com/users/robskillington/gists{/gist_id}","starred_url":"https://api.github.com/users/robskillington/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robskillington/subscriptions","organizations_url":"https://api.github.com/users/robskillington/orgs","repos_url":"https://api.github.com/users/robskillington/repos","events_url":"https://api.github.com/users/robskillington/events{/privacy}","received_events_url":"https://api.github.com/users/robskillington/received_events","type":"User","site_admin":false},"comments":1,"review_comments":45,"maintainer_can_modify":false,"commits":7,"additions":1683,"deletions":494,"changed_files":26}}
{"actor":{"display_login":"robskillington"}}