{"action":"closed","number":16895,"pull_request":{"url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/16895","id":218351287,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4MzUxMjg3","html_url":"https://github.com/home-assistant/home-assistant/pull/16895","diff_url":"https://github.com/home-assistant/home-assistant/pull/16895.diff","patch_url":"https://github.com/home-assistant/home-assistant/pull/16895.patch","issue_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/16895","number":16895,"state":"closed","locked":false,"title":"[WIP] Implement Device Registry for MQTT Entities","user":{"login":"OttoWinter","id":6833237,"node_id":"MDQ6VXNlcjY4MzMyMzc=","avatar_url":"https://avatars1.githubusercontent.com/u/6833237?v=4","gravatar_id":"","url":"https://api.github.com/users/OttoWinter","html_url":"https://github.com/OttoWinter","followers_url":"https://api.github.com/users/OttoWinter/followers","following_url":"https://api.github.com/users/OttoWinter/following{/other_user}","gists_url":"https://api.github.com/users/OttoWinter/gists{/gist_id}","starred_url":"https://api.github.com/users/OttoWinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OttoWinter/subscriptions","organizations_url":"https://api.github.com/users/OttoWinter/orgs","repos_url":"https://api.github.com/users/OttoWinter/repos","events_url":"https://api.github.com/users/OttoWinter/events{/privacy}","received_events_url":"https://api.github.com/users/OttoWinter/received_events","type":"User","site_admin":false},"body":"## Description:\r\n\r\nRFC for implementing the device registry for MQTT entities, here first implemented for sensors.\r\n\r\nThere are a couple of open questions with this approach. As the device registry only works with entities created through config entries, the discovery loading process needs to be changed a bit. The whole config entry process (especially with \"forwarding\") still confuses me a bit, so please feel free to comment on that and all `TODOs` I've left in the code.\r\n\r\nThe discovery payload would look like this (I kept it to the device registry format as close as possible, but that also makes it a bit long):\r\n\r\n```json\r\n{\r\n  \"name\": \"...\",\r\n  ...\r\n  \"device\": {\r\n    \"identifiers\": [\"my_unique_id\"],\r\n    \"connections\": [{\r\n        \"type\": \"mac\",\r\n        \"identifier\": \"F7:19:18:29:93:1A\"\r\n    }],\r\n    \"manufacturer\": \"espressif\",\r\n    \"model\": \"ESP32\",\r\n    \"name\": \"Cabinet\",\r\n    \"sw_version\": \"1.8.0\"\r\n  }\r\n}\r\n```\r\n\r\ntests, docs and other platforms will follow.\r\n\r\n**Pull request in [home-assistant.io](https://github.com/home-assistant/home-assistant.io) with documentation (if applicable):** home-assistant/home-assistant.io#TODO\r\n\r\n## Checklist:\r\n  - [x] The code change is tested and works locally.\r\n  - [ ] Local tests pass with `tox`. **Your PR cannot be merged unless tests pass**\r\n\r\nIf user exposed functionality or configuration variables are added/changed:\r\n  - [ ] Documentation added/updated in [home-assistant.io](https://github.com/home-assistant/home-assistant.io)\r\n\r\nIf the code does not interact with devices:\r\n  - [ ] Tests have been added to verify that the new code works.\r\n\r\n[ex-requir]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L14\r\n[ex-import]: https://github.com/home-assistant/home-assistant/blob/dev/homeassistant/components/keyboard.py#L54\r\n","created_at":"2018-09-26T15:02:30Z","updated_at":"2018-09-26T19:45:54Z","closed_at":"2018-09-26T19:45:54Z","merged_at":null,"merge_commit_sha":"7f3d26852d9cf7462cc93762dde9bb1d90345099","assignee":{"login":"OttoWinter","id":6833237,"node_id":"MDQ6VXNlcjY4MzMyMzc=","avatar_url":"https://avatars1.githubusercontent.com/u/6833237?v=4","gravatar_id":"","url":"https://api.github.com/users/OttoWinter","html_url":"https://github.com/OttoWinter","followers_url":"https://api.github.com/users/OttoWinter/followers","following_url":"https://api.github.com/users/OttoWinter/following{/other_user}","gists_url":"https://api.github.com/users/OttoWinter/gists{/gist_id}","starred_url":"https://api.github.com/users/OttoWinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OttoWinter/subscriptions","organizations_url":"https://api.github.com/users/OttoWinter/orgs","repos_url":"https://api.github.com/users/OttoWinter/repos","events_url":"https://api.github.com/users/OttoWinter/events{/privacy}","received_events_url":"https://api.github.com/users/OttoWinter/received_events","type":"User","site_admin":false},"assignees":[{"login":"OttoWinter","id":6833237,"node_id":"MDQ6VXNlcjY4MzMyMzc=","avatar_url":"https://avatars1.githubusercontent.com/u/6833237?v=4","gravatar_id":"","url":"https://api.github.com/users/OttoWinter","html_url":"https://github.com/OttoWinter","followers_url":"https://api.github.com/users/OttoWinter/followers","following_url":"https://api.github.com/users/OttoWinter/following{/other_user}","gists_url":"https://api.github.com/users/OttoWinter/gists{/gist_id}","starred_url":"https://api.github.com/users/OttoWinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OttoWinter/subscriptions","organizations_url":"https://api.github.com/users/OttoWinter/orgs","repos_url":"https://api.github.com/users/OttoWinter/repos","events_url":"https://api.github.com/users/OttoWinter/events{/privacy}","received_events_url":"https://api.github.com/users/OttoWinter/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":527871105,"node_id":"MDU6TGFiZWw1Mjc4NzExMDU=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/cla-signed","name":"cla-signed","color":"008000","default":false},{"id":530940759,"node_id":"MDU6TGFiZWw1MzA5NDA3NTk=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/component:%20mqtt","name":"component: mqtt","color":"ededed","default":false},{"id":451931292,"node_id":"MDU6TGFiZWw0NTE5MzEyOTI=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/core","name":"core","color":"c5def5","default":false},{"id":955422305,"node_id":"MDU6TGFiZWw5NTU0MjIzMDU=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/in%20progress","name":"in progress","color":"ededed","default":false},{"id":538826025,"node_id":"MDU6TGFiZWw1Mzg4MjYwMjU=","url":"https://api.github.com/repos/home-assistant/home-assistant/labels/platform:%20sensor.mqtt","name":"platform: sensor.mqtt","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/16895/commits","review_comments_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/16895/comments","review_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/16895/comments","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/f3ad613750fda55d15d63cd6f479d54995dd8e33","head":{"label":"OttoWinter:mqtt-device-registry","ref":"mqtt-device-registry","sha":"f3ad613750fda55d15d63cd6f479d54995dd8e33","user":{"login":"OttoWinter","id":6833237,"node_id":"MDQ6VXNlcjY4MzMyMzc=","avatar_url":"https://avatars1.githubusercontent.com/u/6833237?v=4","gravatar_id":"","url":"https://api.github.com/users/OttoWinter","html_url":"https://github.com/OttoWinter","followers_url":"https://api.github.com/users/OttoWinter/followers","following_url":"https://api.github.com/users/OttoWinter/following{/other_user}","gists_url":"https://api.github.com/users/OttoWinter/gists{/gist_id}","starred_url":"https://api.github.com/users/OttoWinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OttoWinter/subscriptions","organizations_url":"https://api.github.com/users/OttoWinter/orgs","repos_url":"https://api.github.com/users/OttoWinter/repos","events_url":"https://api.github.com/users/OttoWinter/events{/privacy}","received_events_url":"https://api.github.com/users/OttoWinter/received_events","type":"User","site_admin":false},"repo":{"id":81717015,"node_id":"MDEwOlJlcG9zaXRvcnk4MTcxNzAxNQ==","name":"home-assistant","full_name":"OttoWinter/home-assistant","private":false,"owner":{"login":"OttoWinter","id":6833237,"node_id":"MDQ6VXNlcjY4MzMyMzc=","avatar_url":"https://avatars1.githubusercontent.com/u/6833237?v=4","gravatar_id":"","url":"https://api.github.com/users/OttoWinter","html_url":"https://github.com/OttoWinter","followers_url":"https://api.github.com/users/OttoWinter/followers","following_url":"https://api.github.com/users/OttoWinter/following{/other_user}","gists_url":"https://api.github.com/users/OttoWinter/gists{/gist_id}","starred_url":"https://api.github.com/users/OttoWinter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OttoWinter/subscriptions","organizations_url":"https://api.github.com/users/OttoWinter/orgs","repos_url":"https://api.github.com/users/OttoWinter/repos","events_url":"https://api.github.com/users/OttoWinter/events{/privacy}","received_events_url":"https://api.github.com/users/OttoWinter/received_events","type":"User","site_admin":false},"html_url":"https://github.com/OttoWinter/home-assistant","description":":house_with_garden: Open-source home automation platform running on Python 3","fork":true,"url":"https://api.github.com/repos/OttoWinter/home-assistant","forks_url":"https://api.github.com/repos/OttoWinter/home-assistant/forks","keys_url":"https://api.github.com/repos/OttoWinter/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OttoWinter/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OttoWinter/home-assistant/teams","hooks_url":"https://api.github.com/repos/OttoWinter/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/OttoWinter/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/OttoWinter/home-assistant/events","assignees_url":"https://api.github.com/repos/OttoWinter/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/OttoWinter/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/OttoWinter/home-assistant/tags","blobs_url":"https://api.github.com/repos/OttoWinter/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OttoWinter/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OttoWinter/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/OttoWinter/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OttoWinter/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/OttoWinter/home-assistant/languages","stargazers_url":"https://api.github.com/repos/OttoWinter/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/OttoWinter/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/OttoWinter/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/OttoWinter/home-assistant/subscription","commits_url":"https://api.github.com/repos/OttoWinter/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/OttoWinter/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/OttoWinter/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/OttoWinter/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/OttoWinter/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/OttoWinter/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OttoWinter/home-assistant/merges","archive_url":"https://api.github.com/repos/OttoWinter/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OttoWinter/home-assistant/downloads","issues_url":"https://api.github.com/repos/OttoWinter/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/OttoWinter/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/OttoWinter/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/OttoWinter/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OttoWinter/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/OttoWinter/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/OttoWinter/home-assistant/deployments","created_at":"2017-02-12T10:00:20Z","updated_at":"2018-05-06T17:46:52Z","pushed_at":"2018-09-26T19:33:12Z","git_url":"git://github.com/OttoWinter/home-assistant.git","ssh_url":"git@github.com:OttoWinter/home-assistant.git","clone_url":"https://github.com/OttoWinter/home-assistant.git","svn_url":"https://github.com/OttoWinter/home-assistant","homepage":"https://home-assistant.io","size":89254,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"dev"}},"base":{"label":"home-assistant:dev","ref":"dev","sha":"732009c6689ff645e7a16717e6804e5b5a4374b5","user":{"login":"home-assistant","id":13844975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODQ0OTc1","avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"repo":{"id":12888993,"node_id":"MDEwOlJlcG9zaXRvcnkxMjg4ODk5Mw==","name":"home-assistant","full_name":"home-assistant/home-assistant","private":false,"owner":{"login":"home-assistant","id":13844975,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODQ0OTc1","avatar_url":"https://avatars3.githubusercontent.com/u/13844975?v=4","gravatar_id":"","url":"https://api.github.com/users/home-assistant","html_url":"https://github.com/home-assistant","followers_url":"https://api.github.com/users/home-assistant/followers","following_url":"https://api.github.com/users/home-assistant/following{/other_user}","gists_url":"https://api.github.com/users/home-assistant/gists{/gist_id}","starred_url":"https://api.github.com/users/home-assistant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/home-assistant/subscriptions","organizations_url":"https://api.github.com/users/home-assistant/orgs","repos_url":"https://api.github.com/users/home-assistant/repos","events_url":"https://api.github.com/users/home-assistant/events{/privacy}","received_events_url":"https://api.github.com/users/home-assistant/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/home-assistant/home-assistant","description":":house_with_garden: Open source home automation that puts local control and privacy first","fork":false,"url":"https://api.github.com/repos/home-assistant/home-assistant","forks_url":"https://api.github.com/repos/home-assistant/home-assistant/forks","keys_url":"https://api.github.com/repos/home-assistant/home-assistant/keys{/key_id}","collaborators_url":"https://api.github.com/repos/home-assistant/home-assistant/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/home-assistant/home-assistant/teams","hooks_url":"https://api.github.com/repos/home-assistant/home-assistant/hooks","issue_events_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/events{/number}","events_url":"https://api.github.com/repos/home-assistant/home-assistant/events","assignees_url":"https://api.github.com/repos/home-assistant/home-assistant/assignees{/user}","branches_url":"https://api.github.com/repos/home-assistant/home-assistant/branches{/branch}","tags_url":"https://api.github.com/repos/home-assistant/home-assistant/tags","blobs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/home-assistant/home-assistant/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/home-assistant/home-assistant/git/refs{/sha}","trees_url":"https://api.github.com/repos/home-assistant/home-assistant/git/trees{/sha}","statuses_url":"https://api.github.com/repos/home-assistant/home-assistant/statuses/{sha}","languages_url":"https://api.github.com/repos/home-assistant/home-assistant/languages","stargazers_url":"https://api.github.com/repos/home-assistant/home-assistant/stargazers","contributors_url":"https://api.github.com/repos/home-assistant/home-assistant/contributors","subscribers_url":"https://api.github.com/repos/home-assistant/home-assistant/subscribers","subscription_url":"https://api.github.com/repos/home-assistant/home-assistant/subscription","commits_url":"https://api.github.com/repos/home-assistant/home-assistant/commits{/sha}","git_commits_url":"https://api.github.com/repos/home-assistant/home-assistant/git/commits{/sha}","comments_url":"https://api.github.com/repos/home-assistant/home-assistant/comments{/number}","issue_comment_url":"https://api.github.com/repos/home-assistant/home-assistant/issues/comments{/number}","contents_url":"https://api.github.com/repos/home-assistant/home-assistant/contents/{+path}","compare_url":"https://api.github.com/repos/home-assistant/home-assistant/compare/{base}...{head}","merges_url":"https://api.github.com/repos/home-assistant/home-assistant/merges","archive_url":"https://api.github.com/repos/home-assistant/home-assistant/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/home-assistant/home-assistant/downloads","issues_url":"https://api.github.com/repos/home-assistant/home-assistant/issues{/number}","pulls_url":"https://api.github.com/repos/home-assistant/home-assistant/pulls{/number}","milestones_url":"https://api.github.com/repos/home-assistant/home-assistant/milestones{/number}","notifications_url":"https://api.github.com/repos/home-assistant/home-assistant/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/home-assistant/home-assistant/labels{/name}","releases_url":"https://api.github.com/repos/home-assistant/home-assistant/releases{/id}","deployments_url":"https://api.github.com/repos/home-assistant/home-assistant/deployments","created_at":"2013-09-17T07:29:48Z","updated_at":"2018-09-26T19:30:59Z","pushed_at":"2018-09-26T19:45:01Z","git_url":"git://github.com/home-assistant/home-assistant.git","ssh_url":"git@github.com:home-assistant/home-assistant.git","clone_url":"https://github.com/home-assistant/home-assistant.git","svn_url":"https://github.com/home-assistant/home-assistant","homepage":"https://www.home-assistant.io","size":90006,"stargazers_count":16991,"watchers_count":16991,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4993,"mirror_url":null,"archived":false,"open_issues_count":874,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4993,"open_issues":874,"watchers":16991,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/16895"},"html":{"href":"https://github.com/home-assistant/home-assistant/pull/16895"},"issue":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/16895"},"comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/issues/16895/comments"},"review_comments":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/16895/comments"},"review_comment":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/home-assistant/home-assistant/pulls/16895/commits"},"statuses":{"href":"https://api.github.com/repos/home-assistant/home-assistant/statuses/f3ad613750fda55d15d63cd6f479d54995dd8e33"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":3,"review_comments":25,"maintainer_can_modify":false,"commits":3,"additions":131,"deletions":19,"changed_files":4}}
{"actor":{"display_login":"OttoWinter"}}