{"action":"created","comment":{"url":"https://api.github.com/repos/php/php-src/pulls/comments/220124749","pull_request_review_id":158457019,"id":220124749,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDEyNDc0OQ==","diff_hunk":"@@ -3,23 +3,15 @@\n ARG_WITH(\"pdo-sqlite\", \"for pdo_sqlite support\", \"no\");\n \n if (PHP_PDO_SQLITE != \"no\") {\n-\tEXTENSION(\"pdo_sqlite\", \"pdo_sqlite.c sqlite_driver.c sqlite_statement.c\", null, \"/DSQLITE_THREADSAFE=\" + (PHP_ZTS == \"yes\" ? \"1\" : \"0\") + \" /D SQLITE_ENABLE_FTS3=1 /D SQLITE_ENABLE_FTS4=1 /D SQLITE_ENABLE_FTS5=1 /D SQLITE_ENABLE_JSON1=1 /D SQLITE_ENABLE_COLUMN_METADATA=1 /D SQLITE_CORE=1 /I\" + configure_module_dirname + \"/../sqlite3/libsqlite /I\" + configure_module_dirname);\n-\t\n-\tADD_EXTENSION_DEP('pdo_sqlite', 'pdo');\n-\t// If pdo_sqlite is static, and sqlite3 is also static, then we don't add a second copy of the sqlite3 libs\n-\tif (PHP_PDO_SQLITE_SHARED || PHP_SQLITE3_SHARED || PHP_SQLITE3 == 'no') {\n-\t\tADD_SOURCES(configure_module_dirname + \"/../sqlite3/libsqlite\", \"sqlite3.c\", \"pdo_sqlite\");\n-\t}\n-}\n+\tif (CHECK_LIB(\"libsqlite3_a.lib;libsqlite3.lib\", \"pdo_sqlite\", PHP_PDO_SQLITE) &&\n+\t\tCHECK_HEADER_ADD_INCLUDE(\"sqlite3.h\", \"CFLAGS_PDO_SQLITE\") &&\n+\t\tCHECK_HEADER_ADD_INCLUDE(\"sqlite3ext.h\", \"CFLAGS_PDO_SQLITE\")","path":"ext/pdo_sqlite/config.w32","position":14,"original_position":14,"commit_id":"9153b36ff067a171225f4da55f78184c671ec0fd","original_commit_id":"9153b36ff067a171225f4da55f78184c671ec0fd","user":{"login":"cmb69","id":2306138,"node_id":"MDQ6VXNlcjIzMDYxMzg=","avatar_url":"https://avatars1.githubusercontent.com/u/2306138?v=4","gravatar_id":"","url":"https://api.github.com/users/cmb69","html_url":"https://github.com/cmb69","followers_url":"https://api.github.com/users/cmb69/followers","following_url":"https://api.github.com/users/cmb69/following{/other_user}","gists_url":"https://api.github.com/users/cmb69/gists{/gist_id}","starred_url":"https://api.github.com/users/cmb69/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmb69/subscriptions","organizations_url":"https://api.github.com/users/cmb69/orgs","repos_url":"https://api.github.com/users/cmb69/repos","events_url":"https://api.github.com/users/cmb69/events{/privacy}","received_events_url":"https://api.github.com/users/cmb69/received_events","type":"User","site_admin":false},"body":"Makes sense. I'll see to it.","created_at":"2018-09-25T09:41:57Z","updated_at":"2018-09-25T09:41:57Z","html_url":"https://github.com/php/php-src/pull/3548#discussion_r220124749","pull_request_url":"https://api.github.com/repos/php/php-src/pulls/3548","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/php/php-src/pulls/comments/220124749"},"html":{"href":"https://github.com/php/php-src/pull/3548#discussion_r220124749"},"pull_request":{"href":"https://api.github.com/repos/php/php-src/pulls/3548"}},"in_reply_to_id":219706608},"pull_request":{"url":"https://api.github.com/repos/php/php-src/pulls/3548","id":217507680,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NTA3Njgw","html_url":"https://github.com/php/php-src/pull/3548","diff_url":"https://github.com/php/php-src/pull/3548.diff","patch_url":"https://github.com/php/php-src/pull/3548.patch","issue_url":"https://api.github.com/repos/php/php-src/issues/3548","number":3548,"state":"open","locked":false,"title":"Unbundle libsqlite3","user":{"login":"cmb69","id":2306138,"node_id":"MDQ6VXNlcjIzMDYxMzg=","avatar_url":"https://avatars1.githubusercontent.com/u/2306138?v=4","gravatar_id":"","url":"https://api.github.com/users/cmb69","html_url":"https://github.com/cmb69","followers_url":"https://api.github.com/users/cmb69/followers","following_url":"https://api.github.com/users/cmb69/following{/other_user}","gists_url":"https://api.github.com/users/cmb69/gists{/gist_id}","starred_url":"https://api.github.com/users/cmb69/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmb69/subscriptions","organizations_url":"https://api.github.com/users/cmb69/orgs","repos_url":"https://api.github.com/users/cmb69/repos","events_url":"https://api.github.com/users/cmb69/events{/privacy}","received_events_url":"https://api.github.com/users/cmb69/received_events","type":"User","site_admin":false},"body":"Since there is no need to patch libsqlite3 for our purposes, and since\r\nlibsqlite3 ≥ 3.3.9 (which is our current requirement) is widely\r\navailable on distros, there is no reason anymore to bundle the library.\r\n\r\nBesides removing the bundled libsqlite, and adapting the configuration\r\nrespectively, we also fix the use of the SQLITE_ENABLE_COLUMN_METADATA\r\ncompile time constant to detect whether sqlite3_column_table_name() is\r\navailable by a working feature detection (otherwise bug_42589.phpt\r\nwould fail).\r\n\r\nWe also completely drop support for the obscure pdo_sqlite_external\r\nextension (which could have been enabled on Windows only by passing\r\n`--pdo-sqlite-external` to configure), since it is not needed anymore.","created_at":"2018-09-23T12:32:10Z","updated_at":"2018-09-25T09:41:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d6f4cfbd80b8138f281fddc452f71b49fda8920d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/php/php-src/pulls/3548/commits","review_comments_url":"https://api.github.com/repos/php/php-src/pulls/3548/comments","review_comment_url":"https://api.github.com/repos/php/php-src/pulls/comments{/number}","comments_url":"https://api.github.com/repos/php/php-src/issues/3548/comments","statuses_url":"https://api.github.com/repos/php/php-src/statuses/9153b36ff067a171225f4da55f78184c671ec0fd","head":{"label":"cmb69:unbundle-libsqlite","ref":"unbundle-libsqlite","sha":"9153b36ff067a171225f4da55f78184c671ec0fd","user":{"login":"cmb69","id":2306138,"node_id":"MDQ6VXNlcjIzMDYxMzg=","avatar_url":"https://avatars1.githubusercontent.com/u/2306138?v=4","gravatar_id":"","url":"https://api.github.com/users/cmb69","html_url":"https://github.com/cmb69","followers_url":"https://api.github.com/users/cmb69/followers","following_url":"https://api.github.com/users/cmb69/following{/other_user}","gists_url":"https://api.github.com/users/cmb69/gists{/gist_id}","starred_url":"https://api.github.com/users/cmb69/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmb69/subscriptions","organizations_url":"https://api.github.com/users/cmb69/orgs","repos_url":"https://api.github.com/users/cmb69/repos","events_url":"https://api.github.com/users/cmb69/events{/privacy}","received_events_url":"https://api.github.com/users/cmb69/received_events","type":"User","site_admin":false},"repo":{"id":31046791,"node_id":"MDEwOlJlcG9zaXRvcnkzMTA0Njc5MQ==","name":"php-src","full_name":"cmb69/php-src","private":false,"owner":{"login":"cmb69","id":2306138,"node_id":"MDQ6VXNlcjIzMDYxMzg=","avatar_url":"https://avatars1.githubusercontent.com/u/2306138?v=4","gravatar_id":"","url":"https://api.github.com/users/cmb69","html_url":"https://github.com/cmb69","followers_url":"https://api.github.com/users/cmb69/followers","following_url":"https://api.github.com/users/cmb69/following{/other_user}","gists_url":"https://api.github.com/users/cmb69/gists{/gist_id}","starred_url":"https://api.github.com/users/cmb69/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmb69/subscriptions","organizations_url":"https://api.github.com/users/cmb69/orgs","repos_url":"https://api.github.com/users/cmb69/repos","events_url":"https://api.github.com/users/cmb69/events{/privacy}","received_events_url":"https://api.github.com/users/cmb69/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cmb69/php-src","description":"The PHP Interpreter","fork":true,"url":"https://api.github.com/repos/cmb69/php-src","forks_url":"https://api.github.com/repos/cmb69/php-src/forks","keys_url":"https://api.github.com/repos/cmb69/php-src/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cmb69/php-src/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cmb69/php-src/teams","hooks_url":"https://api.github.com/repos/cmb69/php-src/hooks","issue_events_url":"https://api.github.com/repos/cmb69/php-src/issues/events{/number}","events_url":"https://api.github.com/repos/cmb69/php-src/events","assignees_url":"https://api.github.com/repos/cmb69/php-src/assignees{/user}","branches_url":"https://api.github.com/repos/cmb69/php-src/branches{/branch}","tags_url":"https://api.github.com/repos/cmb69/php-src/tags","blobs_url":"https://api.github.com/repos/cmb69/php-src/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cmb69/php-src/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cmb69/php-src/git/refs{/sha}","trees_url":"https://api.github.com/repos/cmb69/php-src/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cmb69/php-src/statuses/{sha}","languages_url":"https://api.github.com/repos/cmb69/php-src/languages","stargazers_url":"https://api.github.com/repos/cmb69/php-src/stargazers","contributors_url":"https://api.github.com/repos/cmb69/php-src/contributors","subscribers_url":"https://api.github.com/repos/cmb69/php-src/subscribers","subscription_url":"https://api.github.com/repos/cmb69/php-src/subscription","commits_url":"https://api.github.com/repos/cmb69/php-src/commits{/sha}","git_commits_url":"https://api.github.com/repos/cmb69/php-src/git/commits{/sha}","comments_url":"https://api.github.com/repos/cmb69/php-src/comments{/number}","issue_comment_url":"https://api.github.com/repos/cmb69/php-src/issues/comments{/number}","contents_url":"https://api.github.com/repos/cmb69/php-src/contents/{+path}","compare_url":"https://api.github.com/repos/cmb69/php-src/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cmb69/php-src/merges","archive_url":"https://api.github.com/repos/cmb69/php-src/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cmb69/php-src/downloads","issues_url":"https://api.github.com/repos/cmb69/php-src/issues{/number}","pulls_url":"https://api.github.com/repos/cmb69/php-src/pulls{/number}","milestones_url":"https://api.github.com/repos/cmb69/php-src/milestones{/number}","notifications_url":"https://api.github.com/repos/cmb69/php-src/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cmb69/php-src/labels{/name}","releases_url":"https://api.github.com/repos/cmb69/php-src/releases{/id}","deployments_url":"https://api.github.com/repos/cmb69/php-src/deployments","created_at":"2015-02-20T01:46:37Z","updated_at":"2018-09-23T12:26:22Z","pushed_at":"2018-09-23T13:30:13Z","git_url":"git://github.com/cmb69/php-src.git","ssh_url":"git@github.com:cmb69/php-src.git","clone_url":"https://github.com/cmb69/php-src.git","svn_url":"https://github.com/cmb69/php-src","homepage":"http://www.php.net","size":320702,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"php:master","ref":"master","sha":"e8538b9f2759d220a354a223762b5a037e00f3a2","user":{"login":"php","id":25158,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTU4","avatar_url":"https://avatars2.githubusercontent.com/u/25158?v=4","gravatar_id":"","url":"https://api.github.com/users/php","html_url":"https://github.com/php","followers_url":"https://api.github.com/users/php/followers","following_url":"https://api.github.com/users/php/following{/other_user}","gists_url":"https://api.github.com/users/php/gists{/gist_id}","starred_url":"https://api.github.com/users/php/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php/subscriptions","organizations_url":"https://api.github.com/users/php/orgs","repos_url":"https://api.github.com/users/php/repos","events_url":"https://api.github.com/users/php/events{/privacy}","received_events_url":"https://api.github.com/users/php/received_events","type":"Organization","site_admin":false},"repo":{"id":1903522,"node_id":"MDEwOlJlcG9zaXRvcnkxOTAzNTIy","name":"php-src","full_name":"php/php-src","private":false,"owner":{"login":"php","id":25158,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MTU4","avatar_url":"https://avatars2.githubusercontent.com/u/25158?v=4","gravatar_id":"","url":"https://api.github.com/users/php","html_url":"https://github.com/php","followers_url":"https://api.github.com/users/php/followers","following_url":"https://api.github.com/users/php/following{/other_user}","gists_url":"https://api.github.com/users/php/gists{/gist_id}","starred_url":"https://api.github.com/users/php/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/php/subscriptions","organizations_url":"https://api.github.com/users/php/orgs","repos_url":"https://api.github.com/users/php/repos","events_url":"https://api.github.com/users/php/events{/privacy}","received_events_url":"https://api.github.com/users/php/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/php/php-src","description":"The PHP Interpreter","fork":false,"url":"https://api.github.com/repos/php/php-src","forks_url":"https://api.github.com/repos/php/php-src/forks","keys_url":"https://api.github.com/repos/php/php-src/keys{/key_id}","collaborators_url":"https://api.github.com/repos/php/php-src/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/php/php-src/teams","hooks_url":"https://api.github.com/repos/php/php-src/hooks","issue_events_url":"https://api.github.com/repos/php/php-src/issues/events{/number}","events_url":"https://api.github.com/repos/php/php-src/events","assignees_url":"https://api.github.com/repos/php/php-src/assignees{/user}","branches_url":"https://api.github.com/repos/php/php-src/branches{/branch}","tags_url":"https://api.github.com/repos/php/php-src/tags","blobs_url":"https://api.github.com/repos/php/php-src/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/php/php-src/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/php/php-src/git/refs{/sha}","trees_url":"https://api.github.com/repos/php/php-src/git/trees{/sha}","statuses_url":"https://api.github.com/repos/php/php-src/statuses/{sha}","languages_url":"https://api.github.com/repos/php/php-src/languages","stargazers_url":"https://api.github.com/repos/php/php-src/stargazers","contributors_url":"https://api.github.com/repos/php/php-src/contributors","subscribers_url":"https://api.github.com/repos/php/php-src/subscribers","subscription_url":"https://api.github.com/repos/php/php-src/subscription","commits_url":"https://api.github.com/repos/php/php-src/commits{/sha}","git_commits_url":"https://api.github.com/repos/php/php-src/git/commits{/sha}","comments_url":"https://api.github.com/repos/php/php-src/comments{/number}","issue_comment_url":"https://api.github.com/repos/php/php-src/issues/comments{/number}","contents_url":"https://api.github.com/repos/php/php-src/contents/{+path}","compare_url":"https://api.github.com/repos/php/php-src/compare/{base}...{head}","merges_url":"https://api.github.com/repos/php/php-src/merges","archive_url":"https://api.github.com/repos/php/php-src/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/php/php-src/downloads","issues_url":"https://api.github.com/repos/php/php-src/issues{/number}","pulls_url":"https://api.github.com/repos/php/php-src/pulls{/number}","milestones_url":"https://api.github.com/repos/php/php-src/milestones{/number}","notifications_url":"https://api.github.com/repos/php/php-src/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/php/php-src/labels{/name}","releases_url":"https://api.github.com/repos/php/php-src/releases{/id}","deployments_url":"https://api.github.com/repos/php/php-src/deployments","created_at":"2011-06-16T01:52:25Z","updated_at":"2018-09-25T09:31:52Z","pushed_at":"2018-09-25T09:31:36Z","git_url":"git://github.com/php/php-src.git","ssh_url":"git@github.com:php/php-src.git","clone_url":"https://github.com/php/php-src.git","svn_url":"https://github.com/php/php-src","homepage":"http://www.php.net","size":322858,"stargazers_count":19527,"watchers_count":19527,"language":"C","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4992,"mirror_url":null,"archived":false,"open_issues_count":169,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4992,"open_issues":169,"watchers":19527,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/php/php-src/pulls/3548"},"html":{"href":"https://github.com/php/php-src/pull/3548"},"issue":{"href":"https://api.github.com/repos/php/php-src/issues/3548"},"comments":{"href":"https://api.github.com/repos/php/php-src/issues/3548/comments"},"review_comments":{"href":"https://api.github.com/repos/php/php-src/pulls/3548/comments"},"review_comment":{"href":"https://api.github.com/repos/php/php-src/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/php/php-src/pulls/3548/commits"},"statuses":{"href":"https://api.github.com/repos/php/php-src/statuses/9153b36ff067a171225f4da55f78184c671ec0fd"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"cmb69"}}