{"action":"created","issue":{"url":"https://api.github.com/repos/magento/magento2/issues/10881","repository_url":"https://api.github.com/repos/magento/magento2","labels_url":"https://api.github.com/repos/magento/magento2/issues/10881/labels{/name}","comments_url":"https://api.github.com/repos/magento/magento2/issues/10881/comments","events_url":"https://api.github.com/repos/magento/magento2/issues/10881/events","html_url":"https://github.com/magento/magento2/issues/10881","id":257638301,"node_id":"MDU6SXNzdWUyNTc2MzgzMDE=","number":10881,"title":"Redis password not used when trying to validate the connection during install.","user":{"login":"romainruaud","id":15340849,"node_id":"MDQ6VXNlcjE1MzQwODQ5","avatar_url":"https://avatars2.githubusercontent.com/u/15340849?v=4","gravatar_id":"","url":"https://api.github.com/users/romainruaud","html_url":"https://github.com/romainruaud","followers_url":"https://api.github.com/users/romainruaud/followers","following_url":"https://api.github.com/users/romainruaud/following{/other_user}","gists_url":"https://api.github.com/users/romainruaud/gists{/gist_id}","starred_url":"https://api.github.com/users/romainruaud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/romainruaud/subscriptions","organizations_url":"https://api.github.com/users/romainruaud/orgs","repos_url":"https://api.github.com/users/romainruaud/repos","events_url":"https://api.github.com/users/romainruaud/events{/privacy}","received_events_url":"https://api.github.com/users/romainruaud/received_events","type":"User","site_admin":false},"labels":[{"id":686420665,"node_id":"MDU6TGFiZWw2ODY0MjA2NjU=","url":"https://api.github.com/repos/magento/magento2/labels/Issue:%20Clear%20Description","name":"Issue: Clear Description","color":"0e8a16","default":false},{"id":686476746,"node_id":"MDU6TGFiZWw2ODY0NzY3NDY=","url":"https://api.github.com/repos/magento/magento2/labels/Issue:%20Confirmed","name":"Issue: Confirmed","color":"0e8a16","default":false},{"id":688811200,"node_id":"MDU6TGFiZWw2ODg4MTEyMDA=","url":"https://api.github.com/repos/magento/magento2/labels/Issue:%20Format%20is%20valid","name":"Issue: Format is valid","color":"0e8a16","default":false},{"id":21716835,"node_id":"MDU6TGFiZWwyMTcxNjgzNQ==","url":"https://api.github.com/repos/magento/magento2/labels/Issue:%20Ready%20for%20Work","name":"Issue: Ready for Work","color":"0e8a16","default":false},{"id":686477069,"node_id":"MDU6TGFiZWw2ODY0NzcwNjk=","url":"https://api.github.com/repos/magento/magento2/labels/Reproduced%20on%202.1.x","name":"Reproduced on 2.1.x","color":"e99695","default":false},{"id":686477126,"node_id":"MDU6TGFiZWw2ODY0NzcxMjY=","url":"https://api.github.com/repos/magento/magento2/labels/Reproduced%20on%202.2.x","name":"Reproduced on 2.2.x","color":"e99695","default":false}],"state":"open","locked":false,"assignee":{"login":"engcom-backlog-andrii","id":41946904,"node_id":"MDQ6VXNlcjQxOTQ2OTA0","avatar_url":"https://avatars1.githubusercontent.com/u/41946904?v=4","gravatar_id":"","url":"https://api.github.com/users/engcom-backlog-andrii","html_url":"https://github.com/engcom-backlog-andrii","followers_url":"https://api.github.com/users/engcom-backlog-andrii/followers","following_url":"https://api.github.com/users/engcom-backlog-andrii/following{/other_user}","gists_url":"https://api.github.com/users/engcom-backlog-andrii/gists{/gist_id}","starred_url":"https://api.github.com/users/engcom-backlog-andrii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/engcom-backlog-andrii/subscriptions","organizations_url":"https://api.github.com/users/engcom-backlog-andrii/orgs","repos_url":"https://api.github.com/users/engcom-backlog-andrii/repos","events_url":"https://api.github.com/users/engcom-backlog-andrii/events{/privacy}","received_events_url":"https://api.github.com/users/engcom-backlog-andrii/received_events","type":"User","site_admin":false},"assignees":[{"login":"engcom-backlog-andrii","id":41946904,"node_id":"MDQ6VXNlcjQxOTQ2OTA0","avatar_url":"https://avatars1.githubusercontent.com/u/41946904?v=4","gravatar_id":"","url":"https://api.github.com/users/engcom-backlog-andrii","html_url":"https://github.com/engcom-backlog-andrii","followers_url":"https://api.github.com/users/engcom-backlog-andrii/followers","following_url":"https://api.github.com/users/engcom-backlog-andrii/following{/other_user}","gists_url":"https://api.github.com/users/engcom-backlog-andrii/gists{/gist_id}","starred_url":"https://api.github.com/users/engcom-backlog-andrii/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/engcom-backlog-andrii/subscriptions","organizations_url":"https://api.github.com/users/engcom-backlog-andrii/orgs","repos_url":"https://api.github.com/users/engcom-backlog-andrii/repos","events_url":"https://api.github.com/users/engcom-backlog-andrii/events{/privacy}","received_events_url":"https://api.github.com/users/engcom-backlog-andrii/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2017-09-14T08:36:55Z","updated_at":"2018-12-21T15:56:43Z","closed_at":null,"author_association":"COLLABORATOR","body":"<!--- Provide a general summary of the issue in the Title above -->\r\n<!--- Before adding new issues, please, check this article https://github.com/magento/magento2/wiki/Issue-reporting-guidelines-->\r\n\r\nI am using Magento 2 (2.1 and 2.2-rc23) in a container architecture platform proceeding automatic deployments.\r\n\r\nTherefore, I have an already provisioned env.php file stating to use a password in order to connect to my Redis instance.\r\n\r\nThe first step of my deployment is to install Magento.\r\n\r\nHere is the sample env.file (note the password to redis is properly set) : \r\n\r\n```\r\n\r\narray (\r\n--\r\n  | 'cache_types' =>\r\n  | array (\r\n  | 'compiled_config' => 1,\r\n  | ),\r\n  | 'session' =>\r\n  | array (\r\n  | 'save' => 'redis',\r\n  | 'redis' =>\r\n  | array (\r\n  | 'host' => 'magento2-redis',\r\n  | 'port' => '6379',\r\n  | 'database' => '0',\r\n  | 'password' => 'bVdTpAniegamcXKF',\r\n  | ),\r\n  | ),\r\n  | 'cache' =>\r\n  | array (\r\n  | 'frontend' =>\r\n  | array (\r\n  | 'default' =>\r\n  | array (\r\n  | 'backend' => 'Cm_Cache_Backend_Redis',\r\n  | 'backend_options' =>\r\n  | array (\r\n  | 'server' => 'magento2-redis',\r\n  | 'port' => '6379',\r\n  | 'database' => '1',\r\n  | 'compress_data' => 0,\r\n  | 'password' => 'bVdTpAniegamcXKF',\r\n  | ),\r\n  | ),\r\n  | 'page_cache' =>\r\n  | array (\r\n  | 'backend' => 'Cm_Cache_Backend_Redis',\r\n  | 'backend_options' =>\r\n  | array (\r\n  | 'server' => 'magento2-redis',\r\n  | 'port' => '6379',\r\n  | 'database' => '2',\r\n  | 'compress_data' => 0,\r\n  | 'password' => 'bVdTpAniegamcXKF',\r\n  | ),\r\n  | ),\r\n  | ),\r\n  | ),\r\n  | 'db' =>\r\n  | array (\r\n  | 'connection' =>\r\n  | array (\r\n  | 'default' =>\r\n  | array (\r\n  | 'host' => 'galera',\r\n  | 'dbname' => 'magento',\r\n  | 'username' => 'user',\r\n  | 'password' => '4d3KVsW6PpsD',\r\n  | 'model' => 'mysql4',\r\n  | 'engine' => 'innodb',\r\n  | 'initStatements' => 'SET NAMES utf8;',\r\n  | 'active' => '1',\r\n  | ),\r\n  | 'indexer' =>\r\n  | array (\r\n  | 'host' => 'galera',\r\n  | 'dbname' => 'magento',\r\n  | 'username' => 'user',\r\n  | 'password' => '4d3KVsW6PpsD',\r\n  | 'model' => 'mysql4',\r\n  | 'engine' => 'innodb',\r\n  | 'initStatements' => 'SET NAMES utf8;',\r\n  | 'active' => '1',\r\n  | ),\r\n  | ),\r\n  | ),\r\n  | 'system' =>\r\n  | array (\r\n  | 'default' =>\r\n  | array (\r\n  | 'smile_elasticsuite_core_base_settings' =>\r\n  | array (\r\n  | 'es_client' =>\r\n  | array (\r\n  | 'servers' => 'magento2-elasticsearch:9200',\r\n  | ),\r\n  | ),\r\n  | ),\r\n  | ),\r\n  | 'backend' =>\r\n  | array (\r\n  | 'frontName' => 'admin',\r\n  | ),\r\n  | )\r\n\r\n\r\n```\r\n\r\n### Preconditions\r\n<!--- Provide a more detailed information of environment you use -->\r\n<!--- Magento version, tag, HEAD, etc., PHP & MySQL version, etc.. -->\r\n1. Magento 2.1 and 2.2-rc23\r\n2. \r\n\r\n### Steps to reproduce\r\n<!--- Provide a set of unambiguous steps to reproduce this bug include code, if relevant  -->\r\n1. Having an already provisioned env file as above.\r\n2. Run the command ``` php bin/magento setup:install                    --admin-firstname=Admin                 --admin-lastname=Smile                   --admin-email=myproject@smile.fr                         --admin-user=admin_smile                           --admin-password=Fe7vMUDU4437                   --backend-frontname=admin             --db-host=galera                          --db-name=magento                          --db-user=user                              --db-password=4d3KVsW6PpsD                      --base-url=http://mymagento.url                               --use-rewrites=1                                   --cleanup-database                                 --magento-init-params=MAGE_MODE=production```\r\n3. \r\n\r\n### Expected result\r\n<!--- Tell us what should happen -->\r\n1. Magento should install properly\r\n\r\n### Actual result\r\n<!--- Tell us what happens instead -->\r\n1. Install fails : \r\n\r\n```\r\nInvalid Redis configuration. Could not connect to Redis server.\r\n```\r\n\r\n<!--- (This may be platform independent comment) -->\r\n\r\nFor me, the problem is located here : https://github.com/magento/magento2/blob/develop/setup/src/Magento/Setup/Model/ConfigOptionsList/Cache.php#L169\r\n\r\nThis function does not read the password from the deploymentConfig !\r\n\r\nThen the password is defaulted to null : https://github.com/magento/magento2/blob/develop/setup/src/Magento/Setup/Validator/RedisConnectionValidator.php#L26\r\n\r\nAnd it fails to test the Redis connection ....\r\n\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/magento/magento2/issues/comments/449425440","html_url":"https://github.com/magento/magento2/issues/10881#issuecomment-449425440","issue_url":"https://api.github.com/repos/magento/magento2/issues/10881","id":449425440,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0OTQyNTQ0MA==","user":{"login":"magento-engcom-team","id":31669971,"node_id":"MDQ6VXNlcjMxNjY5OTcx","avatar_url":"https://avatars1.githubusercontent.com/u/31669971?v=4","gravatar_id":"","url":"https://api.github.com/users/magento-engcom-team","html_url":"https://github.com/magento-engcom-team","followers_url":"https://api.github.com/users/magento-engcom-team/followers","following_url":"https://api.github.com/users/magento-engcom-team/following{/other_user}","gists_url":"https://api.github.com/users/magento-engcom-team/gists{/gist_id}","starred_url":"https://api.github.com/users/magento-engcom-team/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento-engcom-team/subscriptions","organizations_url":"https://api.github.com/users/magento-engcom-team/orgs","repos_url":"https://api.github.com/users/magento-engcom-team/repos","events_url":"https://api.github.com/users/magento-engcom-team/events{/privacy}","received_events_url":"https://api.github.com/users/magento-engcom-team/received_events","type":"User","site_admin":false},"created_at":"2018-12-21T15:56:43Z","updated_at":"2018-12-21T15:56:43Z","author_association":"CONTRIBUTOR","body":"Hi @engcom-backlog-andrii. Thank you for working on this issue. \nLooks like this issue is already verified and confirmed. But if your want to validate it one more time, please, go though the following instruction:\n- [ ] 1. Add/Edit `Component: XXXXX` label(s) to the ticket, indicating the components it may be related to.\n\n- [ ] 2. Verify that the issue is reproducible on `2.3-develop` branch<details><summary>Details</summary>- Add the comment `@magento-engcom-team give me 2.3-develop instance` to deploy test instance on Magento infrastructure. <br/> - If the issue is reproducible on `2.3-develop` branch, please, add the label `Reproduced on 2.3.x`.<br/>- If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and **_stop verification process here_**!\n</details>\n\n- [ ] 3. Verify that the issue is reproducible on `2.2-develop` branch. <details><summary>Details</summary>- Add the comment `@magento-engcom-team give me 2.2-develop instance` to deploy test instance on Magento infrastructure. <br/>- If the issue is reproducible on `2.2-develop` branch, please add the label `Reproduced on 2.2.x`</details>\n\n- [ ] 4. If the issue is not relevant or is not reproducible any more, feel free to close it.\n"}}
{"actor":{"display_login":"magento-engcom-team"}}