{"action":"created","issue":{"url":"https://api.github.com/repos/apollographql/apollo-client/issues/3957","repository_url":"https://api.github.com/repos/apollographql/apollo-client","labels_url":"https://api.github.com/repos/apollographql/apollo-client/issues/3957/labels{/name}","comments_url":"https://api.github.com/repos/apollographql/apollo-client/issues/3957/comments","events_url":"https://api.github.com/repos/apollographql/apollo-client/issues/3957/events","html_url":"https://github.com/apollographql/apollo-client/pull/3957","id":364642776,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4NzgwNjMw","number":3957,"title":"Fix ReadQueryOptions type fields store & variables","user":{"login":"jmanlapid","id":5409443,"node_id":"MDQ6VXNlcjU0MDk0NDM=","avatar_url":"https://avatars1.githubusercontent.com/u/5409443?v=4","gravatar_id":"","url":"https://api.github.com/users/jmanlapid","html_url":"https://github.com/jmanlapid","followers_url":"https://api.github.com/users/jmanlapid/followers","following_url":"https://api.github.com/users/jmanlapid/following{/other_user}","gists_url":"https://api.github.com/users/jmanlapid/gists{/gist_id}","starred_url":"https://api.github.com/users/jmanlapid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmanlapid/subscriptions","organizations_url":"https://api.github.com/users/jmanlapid/orgs","repos_url":"https://api.github.com/users/jmanlapid/repos","events_url":"https://api.github.com/users/jmanlapid/events{/privacy}","received_events_url":"https://api.github.com/users/jmanlapid/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-09-27T20:34:12Z","updated_at":"2018-09-27T20:52:08Z","closed_at":"2018-09-27T20:52:08Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/apollographql/apollo-client/pulls/3957","html_url":"https://github.com/apollographql/apollo-client/pull/3957","diff_url":"https://github.com/apollographql/apollo-client/pull/3957.diff","patch_url":"https://github.com/apollographql/apollo-client/pull/3957.patch"},"body":"1) Property `store` is not required. I'm using apollo-link-state and I don't have to explicitly declare store when declaring options for cache.readQuery. The documentation also reflects that [here](https://www.apollographql.com/docs/link/links/state.html#write-query).\r\n\r\n2) Property `variables` should use TypeScript `object` non-primitive instead of `Object` as encouraged [here](https://www.typescriptlang.org/docs/handbook/declaration-files/do-s-and-don-ts.html)"},"comment":{"url":"https://api.github.com/repos/apollographql/apollo-client/issues/comments/425239017","html_url":"https://github.com/apollographql/apollo-client/pull/3957#issuecomment-425239017","issue_url":"https://api.github.com/repos/apollographql/apollo-client/issues/3957","id":425239017,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNTIzOTAxNw==","user":{"login":"jmanlapid","id":5409443,"node_id":"MDQ6VXNlcjU0MDk0NDM=","avatar_url":"https://avatars1.githubusercontent.com/u/5409443?v=4","gravatar_id":"","url":"https://api.github.com/users/jmanlapid","html_url":"https://github.com/jmanlapid","followers_url":"https://api.github.com/users/jmanlapid/followers","following_url":"https://api.github.com/users/jmanlapid/following{/other_user}","gists_url":"https://api.github.com/users/jmanlapid/gists{/gist_id}","starred_url":"https://api.github.com/users/jmanlapid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmanlapid/subscriptions","organizations_url":"https://api.github.com/users/jmanlapid/orgs","repos_url":"https://api.github.com/users/jmanlapid/repos","events_url":"https://api.github.com/users/jmanlapid/events{/privacy}","received_events_url":"https://api.github.com/users/jmanlapid/received_events","type":"User","site_admin":false},"created_at":"2018-09-27T20:52:08Z","updated_at":"2018-09-27T20:52:08Z","author_association":"NONE","body":"Woops - didn't realize I needed to use `DataProxy` instead from `apollo-cache` "}}
{"actor":{"display_login":"jmanlapid"}}