{"action":"created","issue":{"url":"https://api.github.com/repos/nanoframework/Home/issues/315","repository_url":"https://api.github.com/repos/nanoframework/Home","labels_url":"https://api.github.com/repos/nanoframework/Home/issues/315/labels{/name}","comments_url":"https://api.github.com/repos/nanoframework/Home/issues/315/comments","events_url":"https://api.github.com/repos/nanoframework/Home/issues/315/events","html_url":"https://github.com/nanoframework/Home/issues/315","id":319278387,"number":315,"title":"Native stubs not getting generated for custom nanoFramework libraries","user":{"login":"sharmavishnu","id":26829246,"avatar_url":"https://avatars2.githubusercontent.com/u/26829246?v=4","gravatar_id":"","url":"https://api.github.com/users/sharmavishnu","html_url":"https://github.com/sharmavishnu","followers_url":"https://api.github.com/users/sharmavishnu/followers","following_url":"https://api.github.com/users/sharmavishnu/following{/other_user}","gists_url":"https://api.github.com/users/sharmavishnu/gists{/gist_id}","starred_url":"https://api.github.com/users/sharmavishnu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharmavishnu/subscriptions","organizations_url":"https://api.github.com/users/sharmavishnu/orgs","repos_url":"https://api.github.com/users/sharmavishnu/repos","events_url":"https://api.github.com/users/sharmavishnu/events{/privacy}","received_events_url":"https://api.github.com/users/sharmavishnu/received_events","type":"User","site_admin":false},"labels":[{"id":679797825,"url":"https://api.github.com/repos/nanoframework/Home/labels/area-Tools","name":"area-Tools","color":"d4c5f9","default":false},{"id":679797294,"url":"https://api.github.com/repos/nanoframework/Home/labels/area-VS-extension","name":"area-VS-extension","color":"d4c5f9","default":false},{"id":679124366,"url":"https://api.github.com/repos/nanoframework/Home/labels/bug","name":"bug","color":"ee0701","default":true},{"id":679761242,"url":"https://api.github.com/repos/nanoframework/Home/labels/non%20trivial","name":"non trivial","color":"eb6420","default":false},{"id":679750628,"url":"https://api.github.com/repos/nanoframework/Home/labels/up-for-grabs","name":"up-for-grabs","color":"4CFF00","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/nanoframework/Home/milestones/3","html_url":"https://github.com/nanoframework/Home/milestone/3","labels_url":"https://api.github.com/repos/nanoframework/Home/milestones/3/labels","id":2773525,"number":3,"title":"Second Preview","description":"","creator":{"login":"networkfusion","id":11439699,"avatar_url":"https://avatars0.githubusercontent.com/u/11439699?v=4","gravatar_id":"","url":"https://api.github.com/users/networkfusion","html_url":"https://github.com/networkfusion","followers_url":"https://api.github.com/users/networkfusion/followers","following_url":"https://api.github.com/users/networkfusion/following{/other_user}","gists_url":"https://api.github.com/users/networkfusion/gists{/gist_id}","starred_url":"https://api.github.com/users/networkfusion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/networkfusion/subscriptions","organizations_url":"https://api.github.com/users/networkfusion/orgs","repos_url":"https://api.github.com/users/networkfusion/repos","events_url":"https://api.github.com/users/networkfusion/events{/privacy}","received_events_url":"https://api.github.com/users/networkfusion/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":4,"state":"open","created_at":"2017-09-18T09:52:14Z","updated_at":"2018-05-01T18:43:25Z","due_on":null,"closed_at":null},"comments":2,"created_at":"2018-05-01T18:14:40Z","updated_at":"2018-05-04T22:40:50Z","closed_at":null,"author_association":"NONE","body":"Steps to reproduce:\r\n1. Create a new nanoFramework library project\r\n2. Create a class and add a method with [MethodImplAttribute(MethodImplOptions.InternalCall)] attribute\r\n3. Enable \"Generate stub files\" option and build the project\r\n\r\nResult:\r\nNo sub files get generated\r\n\r\nObservations:\r\n1. If you download and build any of the core libraries from this repository (e.g. nanoFramework.Runtime.Events), the stubs are correctly generated\r\n2. The project file for the core libraries is different from the project file of custom libraries that you create using the VS nanoFramework extension.\r\n3. One needs to select \"No (True)\" for \"Generate stub files\" for enabling stub file generation. This is confusing. Needs to be corrected.\r\n\r\nEnvironment:\r\n1. Windows 10 PC with Visual Studio 2017 and nanoFramework extension 0.3.8.51"},"comment":{"url":"https://api.github.com/repos/nanoframework/Home/issues/comments/386752889","html_url":"https://github.com/nanoframework/Home/issues/315#issuecomment-386752889","issue_url":"https://api.github.com/repos/nanoframework/Home/issues/315","id":386752889,"user":{"login":"sharmavishnu","id":26829246,"avatar_url":"https://avatars2.githubusercontent.com/u/26829246?v=4","gravatar_id":"","url":"https://api.github.com/users/sharmavishnu","html_url":"https://github.com/sharmavishnu","followers_url":"https://api.github.com/users/sharmavishnu/followers","following_url":"https://api.github.com/users/sharmavishnu/following{/other_user}","gists_url":"https://api.github.com/users/sharmavishnu/gists{/gist_id}","starred_url":"https://api.github.com/users/sharmavishnu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharmavishnu/subscriptions","organizations_url":"https://api.github.com/users/sharmavishnu/orgs","repos_url":"https://api.github.com/users/sharmavishnu/repos","events_url":"https://api.github.com/users/sharmavishnu/events{/privacy}","received_events_url":"https://api.github.com/users/sharmavishnu/received_events","type":"User","site_admin":false},"created_at":"2018-05-04T22:40:50Z","updated_at":"2018-05-04T22:40:50Z","author_association":"NONE","body":"I have been struggling since morning to get my build environment right to look at this bug, but no success as yet. Keep getting one build issue after another. \r\n\r\nLooking at the source code so far, here is my understanding:\r\n1. It seems, in the file NFProjectSystem.MDP.targets, line 192 with the statement \r\n<CallTarget Targets=\"GenerateStubs\" Condition=\"'$(NF_GenerateStubs)'=='true'\" /> fails, because $(NF_GenerateStubs) is never getting set. \r\n2. It does not seem like that $(NF_GenerateStubs) is getting set anywhere\r\n3. If we look at the UI (xaml), the property that gets set is NFMDP_STUB_SKIP\r\n\r\nSo just asking, shouldn't the line 192 in file NFProjectSystem.MDP.targets be\r\n\r\n<CallTarget Targets=\"GenerateStubs\" Condition=\"'$(NFMDP_STUB_SKIP)'=='true'\" />"}}
{"actor":{"display_login":"sharmavishnu"}}