{"action":"created","comment":{"url":"https://api.github.com/repos/apache/groovy/pulls/comments/225298000","pull_request_review_id":164866355,"id":225298000,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTI5ODAwMA==","diff_hunk":"@@ -18,14 +18,78 @@\n  */\n package org.codehaus.groovy.vmplugin.v9;\n \n+import org.codehaus.groovy.GroovyBugError;\n import org.codehaus.groovy.vmplugin.v8.Java8;\n \n+import java.lang.invoke.MethodHandles;\n+import java.lang.reflect.Constructor;\n+import java.lang.reflect.InvocationTargetException;\n+import java.lang.reflect.Method;\n+\n /**\n- * Java 9 based functions will be added here if needed.\n+ * Additional Java 9 based functions will be added here as needed.\n  */\n public class Java9 extends Java8 {\n+\n+    private static class LookupHolder {\n+        private static final Method PRIVATE_LOOKUP;\n+        private static final Constructor<MethodHandles.Lookup> LOOKUP_Constructor;\n+        static {\n+            Constructor<MethodHandles.Lookup> lookup = null;\n+            Method privateLookup = null;\n+            try { // java 9\n+                privateLookup = MethodHandles.class.getMethod(\"privateLookupIn\", Class.class, MethodHandles.Lookup.class);\n+            } catch (final NoSuchMethodException e) { // java 8\n+                try {\n+                    lookup = MethodHandles.Lookup.class.getDeclaredConstructor(Class.class, Integer.TYPE);\n+                    if (!lookup.isAccessible()) {","path":"src/main/java/org/codehaus/groovy/vmplugin/v9/Java9.java","position":29,"original_position":29,"commit_id":"521532204f1f2f8997cf7811f509d86afeff6f7d","original_commit_id":"521532204f1f2f8997cf7811f509d86afeff6f7d","user":{"login":"blackdrag","id":470278,"node_id":"MDQ6VXNlcjQ3MDI3OA==","avatar_url":"https://avatars0.githubusercontent.com/u/470278?v=4","gravatar_id":"","url":"https://api.github.com/users/blackdrag","html_url":"https://github.com/blackdrag","followers_url":"https://api.github.com/users/blackdrag/followers","following_url":"https://api.github.com/users/blackdrag/following{/other_user}","gists_url":"https://api.github.com/users/blackdrag/gists{/gist_id}","starred_url":"https://api.github.com/users/blackdrag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blackdrag/subscriptions","organizations_url":"https://api.github.com/users/blackdrag/orgs","repos_url":"https://api.github.com/users/blackdrag/repos","events_url":"https://api.github.com/users/blackdrag/events{/privacy}","received_events_url":"https://api.github.com/users/blackdrag/received_events","type":"User","site_admin":false},"body":"we can actually not rely on this being accessible... I am missing the IllegalAccessException and InaccessibleObjectException handling here... ","created_at":"2018-10-15T20:02:52Z","updated_at":"2018-10-15T20:10:08Z","html_url":"https://github.com/apache/groovy/pull/811#discussion_r225298000","pull_request_url":"https://api.github.com/repos/apache/groovy/pulls/811","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/groovy/pulls/comments/225298000"},"html":{"href":"https://github.com/apache/groovy/pull/811#discussion_r225298000"},"pull_request":{"href":"https://api.github.com/repos/apache/groovy/pulls/811"}}},"pull_request":{"url":"https://api.github.com/repos/apache/groovy/pulls/811","id":222817799,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyODE3Nzk5","html_url":"https://github.com/apache/groovy/pull/811","diff_url":"https://github.com/apache/groovy/pull/811.diff","patch_url":"https://github.com/apache/groovy/pull/811.patch","issue_url":"https://api.github.com/repos/apache/groovy/issues/811","number":811,"state":"open","locked":false,"title":"GROOVY-8843: Fix illegal reflective access within o.c.g.vmplugin.v7.J…","user":{"login":"paulk-asert","id":280016,"node_id":"MDQ6VXNlcjI4MDAxNg==","avatar_url":"https://avatars3.githubusercontent.com/u/280016?v=4","gravatar_id":"","url":"https://api.github.com/users/paulk-asert","html_url":"https://github.com/paulk-asert","followers_url":"https://api.github.com/users/paulk-asert/followers","following_url":"https://api.github.com/users/paulk-asert/following{/other_user}","gists_url":"https://api.github.com/users/paulk-asert/gists{/gist_id}","starred_url":"https://api.github.com/users/paulk-asert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulk-asert/subscriptions","organizations_url":"https://api.github.com/users/paulk-asert/orgs","repos_url":"https://api.github.com/users/paulk-asert/repos","events_url":"https://api.github.com/users/paulk-asert/events{/privacy}","received_events_url":"https://api.github.com/users/paulk-asert/received_events","type":"User","site_admin":false},"body":"…ava7","created_at":"2018-10-15T08:15:53Z","updated_at":"2018-10-15T20:10:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8d8e6eac0a0f00af61e0f3d83b0eaf88e1ae4eed","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/groovy/pulls/811/commits","review_comments_url":"https://api.github.com/repos/apache/groovy/pulls/811/comments","review_comment_url":"https://api.github.com/repos/apache/groovy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/groovy/issues/811/comments","statuses_url":"https://api.github.com/repos/apache/groovy/statuses/521532204f1f2f8997cf7811f509d86afeff6f7d","head":{"label":"paulk-asert:groovy8843","ref":"groovy8843","sha":"521532204f1f2f8997cf7811f509d86afeff6f7d","user":{"login":"paulk-asert","id":280016,"node_id":"MDQ6VXNlcjI4MDAxNg==","avatar_url":"https://avatars3.githubusercontent.com/u/280016?v=4","gravatar_id":"","url":"https://api.github.com/users/paulk-asert","html_url":"https://github.com/paulk-asert","followers_url":"https://api.github.com/users/paulk-asert/followers","following_url":"https://api.github.com/users/paulk-asert/following{/other_user}","gists_url":"https://api.github.com/users/paulk-asert/gists{/gist_id}","starred_url":"https://api.github.com/users/paulk-asert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulk-asert/subscriptions","organizations_url":"https://api.github.com/users/paulk-asert/orgs","repos_url":"https://api.github.com/users/paulk-asert/repos","events_url":"https://api.github.com/users/paulk-asert/events{/privacy}","received_events_url":"https://api.github.com/users/paulk-asert/received_events","type":"User","site_admin":false},"repo":{"id":34248558,"node_id":"MDEwOlJlcG9zaXRvcnkzNDI0ODU1OA==","name":"groovy","full_name":"paulk-asert/groovy","private":false,"owner":{"login":"paulk-asert","id":280016,"node_id":"MDQ6VXNlcjI4MDAxNg==","avatar_url":"https://avatars3.githubusercontent.com/u/280016?v=4","gravatar_id":"","url":"https://api.github.com/users/paulk-asert","html_url":"https://github.com/paulk-asert","followers_url":"https://api.github.com/users/paulk-asert/followers","following_url":"https://api.github.com/users/paulk-asert/following{/other_user}","gists_url":"https://api.github.com/users/paulk-asert/gists{/gist_id}","starred_url":"https://api.github.com/users/paulk-asert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paulk-asert/subscriptions","organizations_url":"https://api.github.com/users/paulk-asert/orgs","repos_url":"https://api.github.com/users/paulk-asert/repos","events_url":"https://api.github.com/users/paulk-asert/events{/privacy}","received_events_url":"https://api.github.com/users/paulk-asert/received_events","type":"User","site_admin":false},"html_url":"https://github.com/paulk-asert/groovy","description":"Mirror of Apache Groovy","fork":true,"url":"https://api.github.com/repos/paulk-asert/groovy","forks_url":"https://api.github.com/repos/paulk-asert/groovy/forks","keys_url":"https://api.github.com/repos/paulk-asert/groovy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paulk-asert/groovy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paulk-asert/groovy/teams","hooks_url":"https://api.github.com/repos/paulk-asert/groovy/hooks","issue_events_url":"https://api.github.com/repos/paulk-asert/groovy/issues/events{/number}","events_url":"https://api.github.com/repos/paulk-asert/groovy/events","assignees_url":"https://api.github.com/repos/paulk-asert/groovy/assignees{/user}","branches_url":"https://api.github.com/repos/paulk-asert/groovy/branches{/branch}","tags_url":"https://api.github.com/repos/paulk-asert/groovy/tags","blobs_url":"https://api.github.com/repos/paulk-asert/groovy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paulk-asert/groovy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paulk-asert/groovy/git/refs{/sha}","trees_url":"https://api.github.com/repos/paulk-asert/groovy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paulk-asert/groovy/statuses/{sha}","languages_url":"https://api.github.com/repos/paulk-asert/groovy/languages","stargazers_url":"https://api.github.com/repos/paulk-asert/groovy/stargazers","contributors_url":"https://api.github.com/repos/paulk-asert/groovy/contributors","subscribers_url":"https://api.github.com/repos/paulk-asert/groovy/subscribers","subscription_url":"https://api.github.com/repos/paulk-asert/groovy/subscription","commits_url":"https://api.github.com/repos/paulk-asert/groovy/commits{/sha}","git_commits_url":"https://api.github.com/repos/paulk-asert/groovy/git/commits{/sha}","comments_url":"https://api.github.com/repos/paulk-asert/groovy/comments{/number}","issue_comment_url":"https://api.github.com/repos/paulk-asert/groovy/issues/comments{/number}","contents_url":"https://api.github.com/repos/paulk-asert/groovy/contents/{+path}","compare_url":"https://api.github.com/repos/paulk-asert/groovy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paulk-asert/groovy/merges","archive_url":"https://api.github.com/repos/paulk-asert/groovy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paulk-asert/groovy/downloads","issues_url":"https://api.github.com/repos/paulk-asert/groovy/issues{/number}","pulls_url":"https://api.github.com/repos/paulk-asert/groovy/pulls{/number}","milestones_url":"https://api.github.com/repos/paulk-asert/groovy/milestones{/number}","notifications_url":"https://api.github.com/repos/paulk-asert/groovy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paulk-asert/groovy/labels{/name}","releases_url":"https://api.github.com/repos/paulk-asert/groovy/releases{/id}","deployments_url":"https://api.github.com/repos/paulk-asert/groovy/deployments","created_at":"2015-04-20T08:35:22Z","updated_at":"2017-03-07T21:21:59Z","pushed_at":"2018-10-15T08:13:33Z","git_url":"git://github.com/paulk-asert/groovy.git","ssh_url":"git@github.com:paulk-asert/groovy.git","clone_url":"https://github.com/paulk-asert/groovy.git","svn_url":"https://github.com/paulk-asert/groovy","homepage":"","size":171951,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"bff16d510cb817e663a944d4f28bf306248dc74c","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":34039690,"node_id":"MDEwOlJlcG9zaXRvcnkzNDAzOTY5MA==","name":"groovy","full_name":"apache/groovy","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/groovy","description":"Mirror of Apache Groovy","fork":false,"url":"https://api.github.com/repos/apache/groovy","forks_url":"https://api.github.com/repos/apache/groovy/forks","keys_url":"https://api.github.com/repos/apache/groovy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/groovy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/groovy/teams","hooks_url":"https://api.github.com/repos/apache/groovy/hooks","issue_events_url":"https://api.github.com/repos/apache/groovy/issues/events{/number}","events_url":"https://api.github.com/repos/apache/groovy/events","assignees_url":"https://api.github.com/repos/apache/groovy/assignees{/user}","branches_url":"https://api.github.com/repos/apache/groovy/branches{/branch}","tags_url":"https://api.github.com/repos/apache/groovy/tags","blobs_url":"https://api.github.com/repos/apache/groovy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/groovy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/groovy/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/groovy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/groovy/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/groovy/languages","stargazers_url":"https://api.github.com/repos/apache/groovy/stargazers","contributors_url":"https://api.github.com/repos/apache/groovy/contributors","subscribers_url":"https://api.github.com/repos/apache/groovy/subscribers","subscription_url":"https://api.github.com/repos/apache/groovy/subscription","commits_url":"https://api.github.com/repos/apache/groovy/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/groovy/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/groovy/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/groovy/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/groovy/contents/{+path}","compare_url":"https://api.github.com/repos/apache/groovy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/groovy/merges","archive_url":"https://api.github.com/repos/apache/groovy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/groovy/downloads","issues_url":"https://api.github.com/repos/apache/groovy/issues{/number}","pulls_url":"https://api.github.com/repos/apache/groovy/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/groovy/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/groovy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/groovy/labels{/name}","releases_url":"https://api.github.com/repos/apache/groovy/releases{/id}","deployments_url":"https://api.github.com/repos/apache/groovy/deployments","created_at":"2015-04-16T07:00:05Z","updated_at":"2018-10-15T09:43:57Z","pushed_at":"2018-10-15T11:05:20Z","git_url":"git://github.com/apache/groovy.git","ssh_url":"git@github.com:apache/groovy.git","clone_url":"https://github.com/apache/groovy.git","svn_url":"https://github.com/apache/groovy","homepage":"","size":178094,"stargazers_count":2844,"watchers_count":2844,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1090,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1090,"open_issues":19,"watchers":2844,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/groovy/pulls/811"},"html":{"href":"https://github.com/apache/groovy/pull/811"},"issue":{"href":"https://api.github.com/repos/apache/groovy/issues/811"},"comments":{"href":"https://api.github.com/repos/apache/groovy/issues/811/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/groovy/pulls/811/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/groovy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/groovy/pulls/811/commits"},"statuses":{"href":"https://api.github.com/repos/apache/groovy/statuses/521532204f1f2f8997cf7811f509d86afeff6f7d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"blackdrag"}}