{"action":"created","issue":{"url":"https://api.github.com/repos/sethgrid/pester/issues/33","repository_url":"https://api.github.com/repos/sethgrid/pester","labels_url":"https://api.github.com/repos/sethgrid/pester/issues/33/labels{/name}","comments_url":"https://api.github.com/repos/sethgrid/pester/issues/33/comments","events_url":"https://api.github.com/repos/sethgrid/pester/issues/33/events","html_url":"https://github.com/sethgrid/pester/issues/33","id":317658783,"number":33,"title":"Use crypto/rand instead of math/rand","user":{"login":"adamo57","id":7308278,"avatar_url":"https://avatars2.githubusercontent.com/u/7308278?v=4","gravatar_id":"","url":"https://api.github.com/users/adamo57","html_url":"https://github.com/adamo57","followers_url":"https://api.github.com/users/adamo57/followers","following_url":"https://api.github.com/users/adamo57/following{/other_user}","gists_url":"https://api.github.com/users/adamo57/gists{/gist_id}","starred_url":"https://api.github.com/users/adamo57/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adamo57/subscriptions","organizations_url":"https://api.github.com/users/adamo57/orgs","repos_url":"https://api.github.com/users/adamo57/repos","events_url":"https://api.github.com/users/adamo57/events{/privacy}","received_events_url":"https://api.github.com/users/adamo57/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-25T14:40:15Z","updated_at":"2018-04-25T20:44:43Z","closed_at":null,"author_association":"NONE","body":"https://github.com/golang/go/issues/11871 states that math/rand is not secure. It would be wise to have this package to use crypto/rand instead"},"comment":{"url":"https://api.github.com/repos/sethgrid/pester/issues/comments/384427938","html_url":"https://github.com/sethgrid/pester/issues/33#issuecomment-384427938","issue_url":"https://api.github.com/repos/sethgrid/pester/issues/33","id":384427938,"user":{"login":"sethgrid","id":989820,"avatar_url":"https://avatars2.githubusercontent.com/u/989820?v=4","gravatar_id":"","url":"https://api.github.com/users/sethgrid","html_url":"https://github.com/sethgrid","followers_url":"https://api.github.com/users/sethgrid/followers","following_url":"https://api.github.com/users/sethgrid/following{/other_user}","gists_url":"https://api.github.com/users/sethgrid/gists{/gist_id}","starred_url":"https://api.github.com/users/sethgrid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sethgrid/subscriptions","organizations_url":"https://api.github.com/users/sethgrid/orgs","repos_url":"https://api.github.com/users/sethgrid/repos","events_url":"https://api.github.com/users/sethgrid/events{/privacy}","received_events_url":"https://api.github.com/users/sethgrid/received_events","type":"User","site_admin":false},"created_at":"2018-04-25T20:44:43Z","updated_at":"2018-04-25T20:44:43Z","author_association":"OWNER","body":"Hi @adamo57 ! \r\nI understand that anything security related should use crypto/rand. Can you help me to understand why that could be important the way it is used in this library?\r\n\r\nThe offending code:\r\n```\r\nms += random.Intn(2*maxJitter) - maxJitter\r\n```\r\nIt is used to spread out requests to help prevent too many requests coming in at the same time to an http resource. Value collisions or deterministic values should not be an issue. At least, I don't think they should be an issue :)\r\n\r\nAny insight into an advantage in changing is appreciated. "}}
{"actor":{"display_login":"sethgrid"}}