{"action":"created","comment":{"url":"https://api.github.com/repos/keon/algorithms/pulls/comments/222072073","pull_request_review_id":160873419,"id":222072073,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjA3MjA3Mw==","diff_hunk":"@@ -20,10 +20,11 @@ def swap(i, j):\n     iteration = 0\n     if simulation:\n         print(\"iteration\",iteration,\":\",*arr)\n-    \n+    x=-1","path":"algorithms/sort/bubble_sort.py","position":5,"original_position":5,"commit_id":"35ef3ce454db6513d60f16eca9f7c1a4941d9cf1","original_commit_id":"35ef3ce454db6513d60f16eca9f7c1a4941d9cf1","user":{"login":"goswami-rahul","id":30523092,"node_id":"MDQ6VXNlcjMwNTIzMDky","avatar_url":"https://avatars1.githubusercontent.com/u/30523092?v=4","gravatar_id":"","url":"https://api.github.com/users/goswami-rahul","html_url":"https://github.com/goswami-rahul","followers_url":"https://api.github.com/users/goswami-rahul/followers","following_url":"https://api.github.com/users/goswami-rahul/following{/other_user}","gists_url":"https://api.github.com/users/goswami-rahul/gists{/gist_id}","starred_url":"https://api.github.com/users/goswami-rahul/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goswami-rahul/subscriptions","organizations_url":"https://api.github.com/users/goswami-rahul/orgs","repos_url":"https://api.github.com/users/goswami-rahul/repos","events_url":"https://api.github.com/users/goswami-rahul/events{/privacy}","received_events_url":"https://api.github.com/users/goswami-rahul/received_events","type":"User","site_admin":false},"body":"please use spaces before and after `=` following PEP guide.","created_at":"2018-10-02T18:56:32Z","updated_at":"2018-10-02T18:56:32Z","html_url":"https://github.com/keon/algorithms/pull/417#discussion_r222072073","pull_request_url":"https://api.github.com/repos/keon/algorithms/pulls/417","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/keon/algorithms/pulls/comments/222072073"},"html":{"href":"https://github.com/keon/algorithms/pull/417#discussion_r222072073"},"pull_request":{"href":"https://api.github.com/repos/keon/algorithms/pulls/417"}}},"pull_request":{"url":"https://api.github.com/repos/keon/algorithms/pulls/417","id":219676623,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5Njc2NjIz","html_url":"https://github.com/keon/algorithms/pull/417","diff_url":"https://github.com/keon/algorithms/pull/417.diff","patch_url":"https://github.com/keon/algorithms/pull/417.patch","issue_url":"https://api.github.com/repos/keon/algorithms/issues/417","number":417,"state":"open","locked":false,"title":"Optimize bubbe sort","user":{"login":"VARoDeK","id":29409497,"node_id":"MDQ6VXNlcjI5NDA5NDk3","avatar_url":"https://avatars0.githubusercontent.com/u/29409497?v=4","gravatar_id":"","url":"https://api.github.com/users/VARoDeK","html_url":"https://github.com/VARoDeK","followers_url":"https://api.github.com/users/VARoDeK/followers","following_url":"https://api.github.com/users/VARoDeK/following{/other_user}","gists_url":"https://api.github.com/users/VARoDeK/gists{/gist_id}","starred_url":"https://api.github.com/users/VARoDeK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VARoDeK/subscriptions","organizations_url":"https://api.github.com/users/VARoDeK/orgs","repos_url":"https://api.github.com/users/VARoDeK/repos","events_url":"https://api.github.com/users/VARoDeK/events{/privacy}","received_events_url":"https://api.github.com/users/VARoDeK/received_events","type":"User","site_admin":false},"body":"- as after each step of 'outer-loop', one number reaches to its right position. Thus inner loop does not need to run for 'n' times in every cycle of 'outer-loop'.\r\n\r\n(Put an `X` inside the `[ ]` to denote check mark `[X]`.)\r\n\r\n\r\n- [ ] **If creating a new file :**\r\n  - [ ] added links to it in the README files ?\r\n  - [ ] included tests with it ?\r\n  - [ ] added description (overview of algorithm, time and space compleixty, and possible edge case) in docstrings ?\r\n\r\n- [ x] **if done some changes :**\r\n  - [ x] wrote short description in the PR explaining what the changes do ?\r\n  - [ x] Fixes #[issue number] if related to any issue\r\n\r\n- [ ] **other**\r\n","created_at":"2018-10-02T11:54:45Z","updated_at":"2018-10-02T18:56:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d88879b6989d5c7566baf9a0b9bad9bbe7cafb06","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/keon/algorithms/pulls/417/commits","review_comments_url":"https://api.github.com/repos/keon/algorithms/pulls/417/comments","review_comment_url":"https://api.github.com/repos/keon/algorithms/pulls/comments{/number}","comments_url":"https://api.github.com/repos/keon/algorithms/issues/417/comments","statuses_url":"https://api.github.com/repos/keon/algorithms/statuses/35ef3ce454db6513d60f16eca9f7c1a4941d9cf1","head":{"label":"VARoDeK:master","ref":"master","sha":"35ef3ce454db6513d60f16eca9f7c1a4941d9cf1","user":{"login":"VARoDeK","id":29409497,"node_id":"MDQ6VXNlcjI5NDA5NDk3","avatar_url":"https://avatars0.githubusercontent.com/u/29409497?v=4","gravatar_id":"","url":"https://api.github.com/users/VARoDeK","html_url":"https://github.com/VARoDeK","followers_url":"https://api.github.com/users/VARoDeK/followers","following_url":"https://api.github.com/users/VARoDeK/following{/other_user}","gists_url":"https://api.github.com/users/VARoDeK/gists{/gist_id}","starred_url":"https://api.github.com/users/VARoDeK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VARoDeK/subscriptions","organizations_url":"https://api.github.com/users/VARoDeK/orgs","repos_url":"https://api.github.com/users/VARoDeK/repos","events_url":"https://api.github.com/users/VARoDeK/events{/privacy}","received_events_url":"https://api.github.com/users/VARoDeK/received_events","type":"User","site_admin":false},"repo":{"id":151245562,"node_id":"MDEwOlJlcG9zaXRvcnkxNTEyNDU1NjI=","name":"algorithms","full_name":"VARoDeK/algorithms","private":false,"owner":{"login":"VARoDeK","id":29409497,"node_id":"MDQ6VXNlcjI5NDA5NDk3","avatar_url":"https://avatars0.githubusercontent.com/u/29409497?v=4","gravatar_id":"","url":"https://api.github.com/users/VARoDeK","html_url":"https://github.com/VARoDeK","followers_url":"https://api.github.com/users/VARoDeK/followers","following_url":"https://api.github.com/users/VARoDeK/following{/other_user}","gists_url":"https://api.github.com/users/VARoDeK/gists{/gist_id}","starred_url":"https://api.github.com/users/VARoDeK/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VARoDeK/subscriptions","organizations_url":"https://api.github.com/users/VARoDeK/orgs","repos_url":"https://api.github.com/users/VARoDeK/repos","events_url":"https://api.github.com/users/VARoDeK/events{/privacy}","received_events_url":"https://api.github.com/users/VARoDeK/received_events","type":"User","site_admin":false},"html_url":"https://github.com/VARoDeK/algorithms","description":"Minimal examples of data structures and algorithms in Python","fork":true,"url":"https://api.github.com/repos/VARoDeK/algorithms","forks_url":"https://api.github.com/repos/VARoDeK/algorithms/forks","keys_url":"https://api.github.com/repos/VARoDeK/algorithms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VARoDeK/algorithms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VARoDeK/algorithms/teams","hooks_url":"https://api.github.com/repos/VARoDeK/algorithms/hooks","issue_events_url":"https://api.github.com/repos/VARoDeK/algorithms/issues/events{/number}","events_url":"https://api.github.com/repos/VARoDeK/algorithms/events","assignees_url":"https://api.github.com/repos/VARoDeK/algorithms/assignees{/user}","branches_url":"https://api.github.com/repos/VARoDeK/algorithms/branches{/branch}","tags_url":"https://api.github.com/repos/VARoDeK/algorithms/tags","blobs_url":"https://api.github.com/repos/VARoDeK/algorithms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VARoDeK/algorithms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VARoDeK/algorithms/git/refs{/sha}","trees_url":"https://api.github.com/repos/VARoDeK/algorithms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VARoDeK/algorithms/statuses/{sha}","languages_url":"https://api.github.com/repos/VARoDeK/algorithms/languages","stargazers_url":"https://api.github.com/repos/VARoDeK/algorithms/stargazers","contributors_url":"https://api.github.com/repos/VARoDeK/algorithms/contributors","subscribers_url":"https://api.github.com/repos/VARoDeK/algorithms/subscribers","subscription_url":"https://api.github.com/repos/VARoDeK/algorithms/subscription","commits_url":"https://api.github.com/repos/VARoDeK/algorithms/commits{/sha}","git_commits_url":"https://api.github.com/repos/VARoDeK/algorithms/git/commits{/sha}","comments_url":"https://api.github.com/repos/VARoDeK/algorithms/comments{/number}","issue_comment_url":"https://api.github.com/repos/VARoDeK/algorithms/issues/comments{/number}","contents_url":"https://api.github.com/repos/VARoDeK/algorithms/contents/{+path}","compare_url":"https://api.github.com/repos/VARoDeK/algorithms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VARoDeK/algorithms/merges","archive_url":"https://api.github.com/repos/VARoDeK/algorithms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VARoDeK/algorithms/downloads","issues_url":"https://api.github.com/repos/VARoDeK/algorithms/issues{/number}","pulls_url":"https://api.github.com/repos/VARoDeK/algorithms/pulls{/number}","milestones_url":"https://api.github.com/repos/VARoDeK/algorithms/milestones{/number}","notifications_url":"https://api.github.com/repos/VARoDeK/algorithms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VARoDeK/algorithms/labels{/name}","releases_url":"https://api.github.com/repos/VARoDeK/algorithms/releases{/id}","deployments_url":"https://api.github.com/repos/VARoDeK/algorithms/deployments","created_at":"2018-10-02T11:46:18Z","updated_at":"2018-10-02T11:51:30Z","pushed_at":"2018-10-02T11:51:25Z","git_url":"git://github.com/VARoDeK/algorithms.git","ssh_url":"git@github.com:VARoDeK/algorithms.git","clone_url":"https://github.com/VARoDeK/algorithms.git","svn_url":"https://github.com/VARoDeK/algorithms","homepage":"","size":1178,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"keon:master","ref":"master","sha":"30ca4ae2e6133bbfa0120feeda2066647132a19e","user":{"login":"keon","id":10793962,"node_id":"MDQ6VXNlcjEwNzkzOTYy","avatar_url":"https://avatars0.githubusercontent.com/u/10793962?v=4","gravatar_id":"","url":"https://api.github.com/users/keon","html_url":"https://github.com/keon","followers_url":"https://api.github.com/users/keon/followers","following_url":"https://api.github.com/users/keon/following{/other_user}","gists_url":"https://api.github.com/users/keon/gists{/gist_id}","starred_url":"https://api.github.com/users/keon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keon/subscriptions","organizations_url":"https://api.github.com/users/keon/orgs","repos_url":"https://api.github.com/users/keon/repos","events_url":"https://api.github.com/users/keon/events{/privacy}","received_events_url":"https://api.github.com/users/keon/received_events","type":"User","site_admin":false},"repo":{"id":74073233,"node_id":"MDEwOlJlcG9zaXRvcnk3NDA3MzIzMw==","name":"algorithms","full_name":"keon/algorithms","private":false,"owner":{"login":"keon","id":10793962,"node_id":"MDQ6VXNlcjEwNzkzOTYy","avatar_url":"https://avatars0.githubusercontent.com/u/10793962?v=4","gravatar_id":"","url":"https://api.github.com/users/keon","html_url":"https://github.com/keon","followers_url":"https://api.github.com/users/keon/followers","following_url":"https://api.github.com/users/keon/following{/other_user}","gists_url":"https://api.github.com/users/keon/gists{/gist_id}","starred_url":"https://api.github.com/users/keon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keon/subscriptions","organizations_url":"https://api.github.com/users/keon/orgs","repos_url":"https://api.github.com/users/keon/repos","events_url":"https://api.github.com/users/keon/events{/privacy}","received_events_url":"https://api.github.com/users/keon/received_events","type":"User","site_admin":false},"html_url":"https://github.com/keon/algorithms","description":"Minimal examples of data structures and algorithms in Python","fork":false,"url":"https://api.github.com/repos/keon/algorithms","forks_url":"https://api.github.com/repos/keon/algorithms/forks","keys_url":"https://api.github.com/repos/keon/algorithms/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keon/algorithms/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keon/algorithms/teams","hooks_url":"https://api.github.com/repos/keon/algorithms/hooks","issue_events_url":"https://api.github.com/repos/keon/algorithms/issues/events{/number}","events_url":"https://api.github.com/repos/keon/algorithms/events","assignees_url":"https://api.github.com/repos/keon/algorithms/assignees{/user}","branches_url":"https://api.github.com/repos/keon/algorithms/branches{/branch}","tags_url":"https://api.github.com/repos/keon/algorithms/tags","blobs_url":"https://api.github.com/repos/keon/algorithms/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keon/algorithms/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keon/algorithms/git/refs{/sha}","trees_url":"https://api.github.com/repos/keon/algorithms/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keon/algorithms/statuses/{sha}","languages_url":"https://api.github.com/repos/keon/algorithms/languages","stargazers_url":"https://api.github.com/repos/keon/algorithms/stargazers","contributors_url":"https://api.github.com/repos/keon/algorithms/contributors","subscribers_url":"https://api.github.com/repos/keon/algorithms/subscribers","subscription_url":"https://api.github.com/repos/keon/algorithms/subscription","commits_url":"https://api.github.com/repos/keon/algorithms/commits{/sha}","git_commits_url":"https://api.github.com/repos/keon/algorithms/git/commits{/sha}","comments_url":"https://api.github.com/repos/keon/algorithms/comments{/number}","issue_comment_url":"https://api.github.com/repos/keon/algorithms/issues/comments{/number}","contents_url":"https://api.github.com/repos/keon/algorithms/contents/{+path}","compare_url":"https://api.github.com/repos/keon/algorithms/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keon/algorithms/merges","archive_url":"https://api.github.com/repos/keon/algorithms/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keon/algorithms/downloads","issues_url":"https://api.github.com/repos/keon/algorithms/issues{/number}","pulls_url":"https://api.github.com/repos/keon/algorithms/pulls{/number}","milestones_url":"https://api.github.com/repos/keon/algorithms/milestones{/number}","notifications_url":"https://api.github.com/repos/keon/algorithms/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keon/algorithms/labels{/name}","releases_url":"https://api.github.com/repos/keon/algorithms/releases{/id}","deployments_url":"https://api.github.com/repos/keon/algorithms/deployments","created_at":"2016-11-17T22:32:08Z","updated_at":"2018-10-02T17:51:54Z","pushed_at":"2018-10-02T17:25:50Z","git_url":"git://github.com/keon/algorithms.git","ssh_url":"git@github.com:keon/algorithms.git","clone_url":"https://github.com/keon/algorithms.git","svn_url":"https://github.com/keon/algorithms","homepage":"","size":1172,"stargazers_count":12935,"watchers_count":12935,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2237,"mirror_url":null,"archived":false,"open_issues_count":30,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2237,"open_issues":30,"watchers":12935,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/keon/algorithms/pulls/417"},"html":{"href":"https://github.com/keon/algorithms/pull/417"},"issue":{"href":"https://api.github.com/repos/keon/algorithms/issues/417"},"comments":{"href":"https://api.github.com/repos/keon/algorithms/issues/417/comments"},"review_comments":{"href":"https://api.github.com/repos/keon/algorithms/pulls/417/comments"},"review_comment":{"href":"https://api.github.com/repos/keon/algorithms/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/keon/algorithms/pulls/417/commits"},"statuses":{"href":"https://api.github.com/repos/keon/algorithms/statuses/35ef3ce454db6513d60f16eca9f7c1a4941d9cf1"}},"author_association":"NONE"}}
{"actor":{"display_login":"goswami-rahul"}}