{"action":"created","comment":{"url":"https://api.github.com/repos/vaadin/vaadin-overlay/pulls/comments/234550652","pull_request_review_id":176211554,"id":234550652,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNDU1MDY1Mg==","diff_hunk":"@@ -527,6 +527,7 @@\n         }\n \n         if (opened) {\n+          this.__previouslyFocusedElement = document.activeElement;","path":"src/vaadin-overlay.html","position":4,"original_position":4,"commit_id":"2495d4d88481a06de89ed9605bde57aff58f7dad","original_commit_id":"2495d4d88481a06de89ed9605bde57aff58f7dad","user":{"login":"tomivirkki","id":1222264,"node_id":"MDQ6VXNlcjEyMjIyNjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1222264?v=4","gravatar_id":"","url":"https://api.github.com/users/tomivirkki","html_url":"https://github.com/tomivirkki","followers_url":"https://api.github.com/users/tomivirkki/followers","following_url":"https://api.github.com/users/tomivirkki/following{/other_user}","gists_url":"https://api.github.com/users/tomivirkki/gists{/gist_id}","starred_url":"https://api.github.com/users/tomivirkki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tomivirkki/subscriptions","organizations_url":"https://api.github.com/users/tomivirkki/orgs","repos_url":"https://api.github.com/users/tomivirkki/repos","events_url":"https://api.github.com/users/tomivirkki/events{/privacy}","received_events_url":"https://api.github.com/users/tomivirkki/received_events","type":"User","site_admin":false},"body":"`document.activeElement` wouldn't work inside a shadow root. Need to use `getRootNode().activeElement`. Add a test for this case also.","created_at":"2018-11-19T09:45:47Z","updated_at":"2018-11-19T09:45:47Z","html_url":"https://github.com/vaadin/vaadin-overlay/pull/132#discussion_r234550652","pull_request_url":"https://api.github.com/repos/vaadin/vaadin-overlay/pulls/132","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/vaadin/vaadin-overlay/pulls/comments/234550652"},"html":{"href":"https://github.com/vaadin/vaadin-overlay/pull/132#discussion_r234550652"},"pull_request":{"href":"https://api.github.com/repos/vaadin/vaadin-overlay/pulls/132"}}},"pull_request":{"url":"https://api.github.com/repos/vaadin/vaadin-overlay/pulls/132","id":231786791,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNzg2Nzkx","html_url":"https://github.com/vaadin/vaadin-overlay/pull/132","diff_url":"https://github.com/vaadin/vaadin-overlay/pull/132.diff","patch_url":"https://github.com/vaadin/vaadin-overlay/pull/132.patch","issue_url":"https://api.github.com/repos/vaadin/vaadin-overlay/issues/132","number":132,"state":"open","locked":false,"title":"Focus last active element on close","user":{"login":"samiheikki","id":8615573,"node_id":"MDQ6VXNlcjg2MTU1NzM=","avatar_url":"https://avatars1.githubusercontent.com/u/8615573?v=4","gravatar_id":"","url":"https://api.github.com/users/samiheikki","html_url":"https://github.com/samiheikki","followers_url":"https://api.github.com/users/samiheikki/followers","following_url":"https://api.github.com/users/samiheikki/following{/other_user}","gists_url":"https://api.github.com/users/samiheikki/gists{/gist_id}","starred_url":"https://api.github.com/users/samiheikki/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samiheikki/subscriptions","organizations_url":"https://api.github.com/users/samiheikki/orgs","repos_url":"https://api.github.com/users/samiheikki/repos","events_url":"https://api.github.com/users/samiheikki/events{/privacy}","received_events_url":"https://api.github.com/users/samiheikki/received_events","type":"User","site_admin":false},"body":"Fixes #23\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/vaadin/vaadin-overlay/132)\n<!-- Reviewable:end -->\n","created_at":"2018-11-18T12:59:30Z","updated_at":"2018-11-19T09:45:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3b266c44ed22ab0c0ee9cdf919a9d3b8969472b5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":691433766,"node_id":"MDU6TGFiZWw2OTE0MzM3NjY=","url":"https://api.github.com/repos/vaadin/vaadin-overlay/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/vaadin/vaadin-overlay/pulls/132/commits","review_comments_url":"https://api.github.com/repos/vaadin/vaadin-overlay/pulls/132/comments","review_comment_url":"https://api.github.com/repos/vaadin/vaadin-overlay/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vaadin/vaadin-overlay/issues/132/comments","statuses_url":"https://api.github.com/repos/vaadin/vaadin-overlay/statuses/2495d4d88481a06de89ed9605bde57aff58f7dad","head":{"label":"vaadin:fix/focus-previous-element-on-close","ref":"fix/focus-previous-element-on-close","sha":"2495d4d88481a06de89ed9605bde57aff58f7dad","user":{"login":"vaadin","id":1171922,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzE5MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/1171922?v=4","gravatar_id":"","url":"https://api.github.com/users/vaadin","html_url":"https://github.com/vaadin","followers_url":"https://api.github.com/users/vaadin/followers","following_url":"https://api.github.com/users/vaadin/following{/other_user}","gists_url":"https://api.github.com/users/vaadin/gists{/gist_id}","starred_url":"https://api.github.com/users/vaadin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaadin/subscriptions","organizations_url":"https://api.github.com/users/vaadin/orgs","repos_url":"https://api.github.com/users/vaadin/repos","events_url":"https://api.github.com/users/vaadin/events{/privacy}","received_events_url":"https://api.github.com/users/vaadin/received_events","type":"Organization","site_admin":false},"repo":{"id":95084908,"node_id":"MDEwOlJlcG9zaXRvcnk5NTA4NDkwOA==","name":"vaadin-overlay","full_name":"vaadin/vaadin-overlay","private":false,"owner":{"login":"vaadin","id":1171922,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzE5MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/1171922?v=4","gravatar_id":"","url":"https://api.github.com/users/vaadin","html_url":"https://github.com/vaadin","followers_url":"https://api.github.com/users/vaadin/followers","following_url":"https://api.github.com/users/vaadin/following{/other_user}","gists_url":"https://api.github.com/users/vaadin/gists{/gist_id}","starred_url":"https://api.github.com/users/vaadin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaadin/subscriptions","organizations_url":"https://api.github.com/users/vaadin/orgs","repos_url":"https://api.github.com/users/vaadin/repos","events_url":"https://api.github.com/users/vaadin/events{/privacy}","received_events_url":"https://api.github.com/users/vaadin/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/vaadin/vaadin-overlay","description":"The home for <vaadin-overlay>","fork":false,"url":"https://api.github.com/repos/vaadin/vaadin-overlay","forks_url":"https://api.github.com/repos/vaadin/vaadin-overlay/forks","keys_url":"https://api.github.com/repos/vaadin/vaadin-overlay/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vaadin/vaadin-overlay/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vaadin/vaadin-overlay/teams","hooks_url":"https://api.github.com/repos/vaadin/vaadin-overlay/hooks","issue_events_url":"https://api.github.com/repos/vaadin/vaadin-overlay/issues/events{/number}","events_url":"https://api.github.com/repos/vaadin/vaadin-overlay/events","assignees_url":"https://api.github.com/repos/vaadin/vaadin-overlay/assignees{/user}","branches_url":"https://api.github.com/repos/vaadin/vaadin-overlay/branches{/branch}","tags_url":"https://api.github.com/repos/vaadin/vaadin-overlay/tags","blobs_url":"https://api.github.com/repos/vaadin/vaadin-overlay/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vaadin/vaadin-overlay/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vaadin/vaadin-overlay/git/refs{/sha}","trees_url":"https://api.github.com/repos/vaadin/vaadin-overlay/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vaadin/vaadin-overlay/statuses/{sha}","languages_url":"https://api.github.com/repos/vaadin/vaadin-overlay/languages","stargazers_url":"https://api.github.com/repos/vaadin/vaadin-overlay/stargazers","contributors_url":"https://api.github.com/repos/vaadin/vaadin-overlay/contributors","subscribers_url":"https://api.github.com/repos/vaadin/vaadin-overlay/subscribers","subscription_url":"https://api.github.com/repos/vaadin/vaadin-overlay/subscription","commits_url":"https://api.github.com/repos/vaadin/vaadin-overlay/commits{/sha}","git_commits_url":"https://api.github.com/repos/vaadin/vaadin-overlay/git/commits{/sha}","comments_url":"https://api.github.com/repos/vaadin/vaadin-overlay/comments{/number}","issue_comment_url":"https://api.github.com/repos/vaadin/vaadin-overlay/issues/comments{/number}","contents_url":"https://api.github.com/repos/vaadin/vaadin-overlay/contents/{+path}","compare_url":"https://api.github.com/repos/vaadin/vaadin-overlay/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vaadin/vaadin-overlay/merges","archive_url":"https://api.github.com/repos/vaadin/vaadin-overlay/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vaadin/vaadin-overlay/downloads","issues_url":"https://api.github.com/repos/vaadin/vaadin-overlay/issues{/number}","pulls_url":"https://api.github.com/repos/vaadin/vaadin-overlay/pulls{/number}","milestones_url":"https://api.github.com/repos/vaadin/vaadin-overlay/milestones{/number}","notifications_url":"https://api.github.com/repos/vaadin/vaadin-overlay/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vaadin/vaadin-overlay/labels{/name}","releases_url":"https://api.github.com/repos/vaadin/vaadin-overlay/releases{/id}","deployments_url":"https://api.github.com/repos/vaadin/vaadin-overlay/deployments","created_at":"2017-06-22T07:00:46Z","updated_at":"2018-11-18T13:54:10Z","pushed_at":"2018-11-19T05:35:36Z","git_url":"git://github.com/vaadin/vaadin-overlay.git","ssh_url":"git@github.com:vaadin/vaadin-overlay.git","clone_url":"https://github.com/vaadin/vaadin-overlay.git","svn_url":"https://github.com/vaadin/vaadin-overlay","homepage":null,"size":1005,"stargazers_count":4,"watchers_count":4,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":13,"watchers":4,"default_branch":"master"}},"base":{"label":"vaadin:master","ref":"master","sha":"0bc377a06f8407d4504a541e1abeee117503ba24","user":{"login":"vaadin","id":1171922,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzE5MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/1171922?v=4","gravatar_id":"","url":"https://api.github.com/users/vaadin","html_url":"https://github.com/vaadin","followers_url":"https://api.github.com/users/vaadin/followers","following_url":"https://api.github.com/users/vaadin/following{/other_user}","gists_url":"https://api.github.com/users/vaadin/gists{/gist_id}","starred_url":"https://api.github.com/users/vaadin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaadin/subscriptions","organizations_url":"https://api.github.com/users/vaadin/orgs","repos_url":"https://api.github.com/users/vaadin/repos","events_url":"https://api.github.com/users/vaadin/events{/privacy}","received_events_url":"https://api.github.com/users/vaadin/received_events","type":"Organization","site_admin":false},"repo":{"id":95084908,"node_id":"MDEwOlJlcG9zaXRvcnk5NTA4NDkwOA==","name":"vaadin-overlay","full_name":"vaadin/vaadin-overlay","private":false,"owner":{"login":"vaadin","id":1171922,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNzE5MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/1171922?v=4","gravatar_id":"","url":"https://api.github.com/users/vaadin","html_url":"https://github.com/vaadin","followers_url":"https://api.github.com/users/vaadin/followers","following_url":"https://api.github.com/users/vaadin/following{/other_user}","gists_url":"https://api.github.com/users/vaadin/gists{/gist_id}","starred_url":"https://api.github.com/users/vaadin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaadin/subscriptions","organizations_url":"https://api.github.com/users/vaadin/orgs","repos_url":"https://api.github.com/users/vaadin/repos","events_url":"https://api.github.com/users/vaadin/events{/privacy}","received_events_url":"https://api.github.com/users/vaadin/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/vaadin/vaadin-overlay","description":"The home for <vaadin-overlay>","fork":false,"url":"https://api.github.com/repos/vaadin/vaadin-overlay","forks_url":"https://api.github.com/repos/vaadin/vaadin-overlay/forks","keys_url":"https://api.github.com/repos/vaadin/vaadin-overlay/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vaadin/vaadin-overlay/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vaadin/vaadin-overlay/teams","hooks_url":"https://api.github.com/repos/vaadin/vaadin-overlay/hooks","issue_events_url":"https://api.github.com/repos/vaadin/vaadin-overlay/issues/events{/number}","events_url":"https://api.github.com/repos/vaadin/vaadin-overlay/events","assignees_url":"https://api.github.com/repos/vaadin/vaadin-overlay/assignees{/user}","branches_url":"https://api.github.com/repos/vaadin/vaadin-overlay/branches{/branch}","tags_url":"https://api.github.com/repos/vaadin/vaadin-overlay/tags","blobs_url":"https://api.github.com/repos/vaadin/vaadin-overlay/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vaadin/vaadin-overlay/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vaadin/vaadin-overlay/git/refs{/sha}","trees_url":"https://api.github.com/repos/vaadin/vaadin-overlay/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vaadin/vaadin-overlay/statuses/{sha}","languages_url":"https://api.github.com/repos/vaadin/vaadin-overlay/languages","stargazers_url":"https://api.github.com/repos/vaadin/vaadin-overlay/stargazers","contributors_url":"https://api.github.com/repos/vaadin/vaadin-overlay/contributors","subscribers_url":"https://api.github.com/repos/vaadin/vaadin-overlay/subscribers","subscription_url":"https://api.github.com/repos/vaadin/vaadin-overlay/subscription","commits_url":"https://api.github.com/repos/vaadin/vaadin-overlay/commits{/sha}","git_commits_url":"https://api.github.com/repos/vaadin/vaadin-overlay/git/commits{/sha}","comments_url":"https://api.github.com/repos/vaadin/vaadin-overlay/comments{/number}","issue_comment_url":"https://api.github.com/repos/vaadin/vaadin-overlay/issues/comments{/number}","contents_url":"https://api.github.com/repos/vaadin/vaadin-overlay/contents/{+path}","compare_url":"https://api.github.com/repos/vaadin/vaadin-overlay/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vaadin/vaadin-overlay/merges","archive_url":"https://api.github.com/repos/vaadin/vaadin-overlay/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vaadin/vaadin-overlay/downloads","issues_url":"https://api.github.com/repos/vaadin/vaadin-overlay/issues{/number}","pulls_url":"https://api.github.com/repos/vaadin/vaadin-overlay/pulls{/number}","milestones_url":"https://api.github.com/repos/vaadin/vaadin-overlay/milestones{/number}","notifications_url":"https://api.github.com/repos/vaadin/vaadin-overlay/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vaadin/vaadin-overlay/labels{/name}","releases_url":"https://api.github.com/repos/vaadin/vaadin-overlay/releases{/id}","deployments_url":"https://api.github.com/repos/vaadin/vaadin-overlay/deployments","created_at":"2017-06-22T07:00:46Z","updated_at":"2018-11-18T13:54:10Z","pushed_at":"2018-11-19T05:35:36Z","git_url":"git://github.com/vaadin/vaadin-overlay.git","ssh_url":"git@github.com:vaadin/vaadin-overlay.git","clone_url":"https://github.com/vaadin/vaadin-overlay.git","svn_url":"https://github.com/vaadin/vaadin-overlay","homepage":null,"size":1005,"stargazers_count":4,"watchers_count":4,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":13,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vaadin/vaadin-overlay/pulls/132"},"html":{"href":"https://github.com/vaadin/vaadin-overlay/pull/132"},"issue":{"href":"https://api.github.com/repos/vaadin/vaadin-overlay/issues/132"},"comments":{"href":"https://api.github.com/repos/vaadin/vaadin-overlay/issues/132/comments"},"review_comments":{"href":"https://api.github.com/repos/vaadin/vaadin-overlay/pulls/132/comments"},"review_comment":{"href":"https://api.github.com/repos/vaadin/vaadin-overlay/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vaadin/vaadin-overlay/pulls/132/commits"},"statuses":{"href":"https://api.github.com/repos/vaadin/vaadin-overlay/statuses/2495d4d88481a06de89ed9605bde57aff58f7dad"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"tomivirkki"}}