{"action":"opened","number":450,"pull_request":{"url":"https://api.github.com/repos/bosnet/sebak/pulls/450","id":218479918,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4NDc5OTE4","html_url":"https://github.com/bosnet/sebak/pull/450","diff_url":"https://github.com/bosnet/sebak/pull/450.diff","patch_url":"https://github.com/bosnet/sebak/pull/450.patch","issue_url":"https://api.github.com/repos/bosnet/sebak/issues/450","number":450,"state":"open","locked":false,"title":"`--publish` new `node run` option, can set the publish endpoint","user":{"login":"spikeekips","id":174565,"node_id":"MDQ6VXNlcjE3NDU2NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/174565?v=4","gravatar_id":"","url":"https://api.github.com/users/spikeekips","html_url":"https://github.com/spikeekips","followers_url":"https://api.github.com/users/spikeekips/followers","following_url":"https://api.github.com/users/spikeekips/following{/other_user}","gists_url":"https://api.github.com/users/spikeekips/gists{/gist_id}","starred_url":"https://api.github.com/users/spikeekips/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spikeekips/subscriptions","organizations_url":"https://api.github.com/users/spikeekips/orgs","repos_url":"https://api.github.com/users/spikeekips/repos","events_url":"https://api.github.com/users/spikeekips/events{/privacy}","received_events_url":"https://api.github.com/users/spikeekips/received_events","type":"User","site_admin":false},"body":"### Github Issue\r\n\r\nresolves #400 \r\n\r\n### Background\r\n\r\nThe previous `--endpoint` option can set the bind address of network and also be the node's endpoint. This endpoint URL is published thru `/node/` to the other nodes. The problem is `--endpoint` is just used for binding, not real URL address to connect.\r\n\r\n### Solution\r\n\r\nThe changes are simple.\r\n\r\n* `--endpoint` option was removed\r\n* `--bind` and `--publish` options were added\r\n* `--bind` set the binding URL. The default is `defaultBindURL   string      = \"https://0.0.0.0:12345\"`\r\n* `--publish` set the published URL address of node\r\n* `--publish` is not set, `/node/` will use `http.Request` information; check out `common.RequestURLFromRequest()`\r\n\r\n### Possible Drawbacks\r\n\r\nPlease update your `$ sebak node run` options :)","created_at":"2018-09-26T23:05:53Z","updated_at":"2018-09-26T23:05:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"spikeekips","id":174565,"node_id":"MDQ6VXNlcjE3NDU2NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/174565?v=4","gravatar_id":"","url":"https://api.github.com/users/spikeekips","html_url":"https://github.com/spikeekips","followers_url":"https://api.github.com/users/spikeekips/followers","following_url":"https://api.github.com/users/spikeekips/following{/other_user}","gists_url":"https://api.github.com/users/spikeekips/gists{/gist_id}","starred_url":"https://api.github.com/users/spikeekips/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spikeekips/subscriptions","organizations_url":"https://api.github.com/users/spikeekips/orgs","repos_url":"https://api.github.com/users/spikeekips/repos","events_url":"https://api.github.com/users/spikeekips/events{/privacy}","received_events_url":"https://api.github.com/users/spikeekips/received_events","type":"User","site_admin":false},"assignees":[{"login":"spikeekips","id":174565,"node_id":"MDQ6VXNlcjE3NDU2NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/174565?v=4","gravatar_id":"","url":"https://api.github.com/users/spikeekips","html_url":"https://github.com/spikeekips","followers_url":"https://api.github.com/users/spikeekips/followers","following_url":"https://api.github.com/users/spikeekips/following{/other_user}","gists_url":"https://api.github.com/users/spikeekips/gists{/gist_id}","starred_url":"https://api.github.com/users/spikeekips/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spikeekips/subscriptions","organizations_url":"https://api.github.com/users/spikeekips/orgs","repos_url":"https://api.github.com/users/spikeekips/repos","events_url":"https://api.github.com/users/spikeekips/events{/privacy}","received_events_url":"https://api.github.com/users/spikeekips/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bosnet/sebak/pulls/450/commits","review_comments_url":"https://api.github.com/repos/bosnet/sebak/pulls/450/comments","review_comment_url":"https://api.github.com/repos/bosnet/sebak/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bosnet/sebak/issues/450/comments","statuses_url":"https://api.github.com/repos/bosnet/sebak/statuses/9d8da7f28c20e38e96db9aa3873212e9e81c872f","head":{"label":"spikeekips:400-bind-and-publish","ref":"400-bind-and-publish","sha":"9d8da7f28c20e38e96db9aa3873212e9e81c872f","user":{"login":"spikeekips","id":174565,"node_id":"MDQ6VXNlcjE3NDU2NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/174565?v=4","gravatar_id":"","url":"https://api.github.com/users/spikeekips","html_url":"https://github.com/spikeekips","followers_url":"https://api.github.com/users/spikeekips/followers","following_url":"https://api.github.com/users/spikeekips/following{/other_user}","gists_url":"https://api.github.com/users/spikeekips/gists{/gist_id}","starred_url":"https://api.github.com/users/spikeekips/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spikeekips/subscriptions","organizations_url":"https://api.github.com/users/spikeekips/orgs","repos_url":"https://api.github.com/users/spikeekips/repos","events_url":"https://api.github.com/users/spikeekips/events{/privacy}","received_events_url":"https://api.github.com/users/spikeekips/received_events","type":"User","site_admin":false},"repo":{"id":137310734,"node_id":"MDEwOlJlcG9zaXRvcnkxMzczMTA3MzQ=","name":"sebak","full_name":"spikeekips/sebak","private":false,"owner":{"login":"spikeekips","id":174565,"node_id":"MDQ6VXNlcjE3NDU2NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/174565?v=4","gravatar_id":"","url":"https://api.github.com/users/spikeekips","html_url":"https://github.com/spikeekips","followers_url":"https://api.github.com/users/spikeekips/followers","following_url":"https://api.github.com/users/spikeekips/following{/other_user}","gists_url":"https://api.github.com/users/spikeekips/gists{/gist_id}","starred_url":"https://api.github.com/users/spikeekips/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spikeekips/subscriptions","organizations_url":"https://api.github.com/users/spikeekips/orgs","repos_url":"https://api.github.com/users/spikeekips/repos","events_url":"https://api.github.com/users/spikeekips/events{/privacy}","received_events_url":"https://api.github.com/users/spikeekips/received_events","type":"User","site_admin":false},"html_url":"https://github.com/spikeekips/sebak","description":"SEBAK, the next BOScoin Tokennet with ISAAC consensus protocol","fork":true,"url":"https://api.github.com/repos/spikeekips/sebak","forks_url":"https://api.github.com/repos/spikeekips/sebak/forks","keys_url":"https://api.github.com/repos/spikeekips/sebak/keys{/key_id}","collaborators_url":"https://api.github.com/repos/spikeekips/sebak/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/spikeekips/sebak/teams","hooks_url":"https://api.github.com/repos/spikeekips/sebak/hooks","issue_events_url":"https://api.github.com/repos/spikeekips/sebak/issues/events{/number}","events_url":"https://api.github.com/repos/spikeekips/sebak/events","assignees_url":"https://api.github.com/repos/spikeekips/sebak/assignees{/user}","branches_url":"https://api.github.com/repos/spikeekips/sebak/branches{/branch}","tags_url":"https://api.github.com/repos/spikeekips/sebak/tags","blobs_url":"https://api.github.com/repos/spikeekips/sebak/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/spikeekips/sebak/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/spikeekips/sebak/git/refs{/sha}","trees_url":"https://api.github.com/repos/spikeekips/sebak/git/trees{/sha}","statuses_url":"https://api.github.com/repos/spikeekips/sebak/statuses/{sha}","languages_url":"https://api.github.com/repos/spikeekips/sebak/languages","stargazers_url":"https://api.github.com/repos/spikeekips/sebak/stargazers","contributors_url":"https://api.github.com/repos/spikeekips/sebak/contributors","subscribers_url":"https://api.github.com/repos/spikeekips/sebak/subscribers","subscription_url":"https://api.github.com/repos/spikeekips/sebak/subscription","commits_url":"https://api.github.com/repos/spikeekips/sebak/commits{/sha}","git_commits_url":"https://api.github.com/repos/spikeekips/sebak/git/commits{/sha}","comments_url":"https://api.github.com/repos/spikeekips/sebak/comments{/number}","issue_comment_url":"https://api.github.com/repos/spikeekips/sebak/issues/comments{/number}","contents_url":"https://api.github.com/repos/spikeekips/sebak/contents/{+path}","compare_url":"https://api.github.com/repos/spikeekips/sebak/compare/{base}...{head}","merges_url":"https://api.github.com/repos/spikeekips/sebak/merges","archive_url":"https://api.github.com/repos/spikeekips/sebak/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/spikeekips/sebak/downloads","issues_url":"https://api.github.com/repos/spikeekips/sebak/issues{/number}","pulls_url":"https://api.github.com/repos/spikeekips/sebak/pulls{/number}","milestones_url":"https://api.github.com/repos/spikeekips/sebak/milestones{/number}","notifications_url":"https://api.github.com/repos/spikeekips/sebak/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/spikeekips/sebak/labels{/name}","releases_url":"https://api.github.com/repos/spikeekips/sebak/releases{/id}","deployments_url":"https://api.github.com/repos/spikeekips/sebak/deployments","created_at":"2018-06-14T05:35:40Z","updated_at":"2018-09-20T23:35:07Z","pushed_at":"2018-09-26T23:03:55Z","git_url":"git://github.com/spikeekips/sebak.git","ssh_url":"git@github.com:spikeekips/sebak.git","clone_url":"https://github.com/spikeekips/sebak.git","svn_url":"https://github.com/spikeekips/sebak","homepage":"https://boscoin.io","size":1234,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"bosnet:master","ref":"master","sha":"248e902b2cb666f9287251e1a37bbb0f451a896d","user":{"login":"bosnet","id":37893578,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3ODkzNTc4","avatar_url":"https://avatars1.githubusercontent.com/u/37893578?v=4","gravatar_id":"","url":"https://api.github.com/users/bosnet","html_url":"https://github.com/bosnet","followers_url":"https://api.github.com/users/bosnet/followers","following_url":"https://api.github.com/users/bosnet/following{/other_user}","gists_url":"https://api.github.com/users/bosnet/gists{/gist_id}","starred_url":"https://api.github.com/users/bosnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bosnet/subscriptions","organizations_url":"https://api.github.com/users/bosnet/orgs","repos_url":"https://api.github.com/users/bosnet/repos","events_url":"https://api.github.com/users/bosnet/events{/privacy}","received_events_url":"https://api.github.com/users/bosnet/received_events","type":"Organization","site_admin":false},"repo":{"id":129848943,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk4NDg5NDM=","name":"sebak","full_name":"bosnet/sebak","private":false,"owner":{"login":"bosnet","id":37893578,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3ODkzNTc4","avatar_url":"https://avatars1.githubusercontent.com/u/37893578?v=4","gravatar_id":"","url":"https://api.github.com/users/bosnet","html_url":"https://github.com/bosnet","followers_url":"https://api.github.com/users/bosnet/followers","following_url":"https://api.github.com/users/bosnet/following{/other_user}","gists_url":"https://api.github.com/users/bosnet/gists{/gist_id}","starred_url":"https://api.github.com/users/bosnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bosnet/subscriptions","organizations_url":"https://api.github.com/users/bosnet/orgs","repos_url":"https://api.github.com/users/bosnet/repos","events_url":"https://api.github.com/users/bosnet/events{/privacy}","received_events_url":"https://api.github.com/users/bosnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/bosnet/sebak","description":"SEBAK, the next BOScoin Tokennet with ISAAC consensus protocol","fork":false,"url":"https://api.github.com/repos/bosnet/sebak","forks_url":"https://api.github.com/repos/bosnet/sebak/forks","keys_url":"https://api.github.com/repos/bosnet/sebak/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bosnet/sebak/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bosnet/sebak/teams","hooks_url":"https://api.github.com/repos/bosnet/sebak/hooks","issue_events_url":"https://api.github.com/repos/bosnet/sebak/issues/events{/number}","events_url":"https://api.github.com/repos/bosnet/sebak/events","assignees_url":"https://api.github.com/repos/bosnet/sebak/assignees{/user}","branches_url":"https://api.github.com/repos/bosnet/sebak/branches{/branch}","tags_url":"https://api.github.com/repos/bosnet/sebak/tags","blobs_url":"https://api.github.com/repos/bosnet/sebak/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bosnet/sebak/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bosnet/sebak/git/refs{/sha}","trees_url":"https://api.github.com/repos/bosnet/sebak/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bosnet/sebak/statuses/{sha}","languages_url":"https://api.github.com/repos/bosnet/sebak/languages","stargazers_url":"https://api.github.com/repos/bosnet/sebak/stargazers","contributors_url":"https://api.github.com/repos/bosnet/sebak/contributors","subscribers_url":"https://api.github.com/repos/bosnet/sebak/subscribers","subscription_url":"https://api.github.com/repos/bosnet/sebak/subscription","commits_url":"https://api.github.com/repos/bosnet/sebak/commits{/sha}","git_commits_url":"https://api.github.com/repos/bosnet/sebak/git/commits{/sha}","comments_url":"https://api.github.com/repos/bosnet/sebak/comments{/number}","issue_comment_url":"https://api.github.com/repos/bosnet/sebak/issues/comments{/number}","contents_url":"https://api.github.com/repos/bosnet/sebak/contents/{+path}","compare_url":"https://api.github.com/repos/bosnet/sebak/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bosnet/sebak/merges","archive_url":"https://api.github.com/repos/bosnet/sebak/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bosnet/sebak/downloads","issues_url":"https://api.github.com/repos/bosnet/sebak/issues{/number}","pulls_url":"https://api.github.com/repos/bosnet/sebak/pulls{/number}","milestones_url":"https://api.github.com/repos/bosnet/sebak/milestones{/number}","notifications_url":"https://api.github.com/repos/bosnet/sebak/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bosnet/sebak/labels{/name}","releases_url":"https://api.github.com/repos/bosnet/sebak/releases{/id}","deployments_url":"https://api.github.com/repos/bosnet/sebak/deployments","created_at":"2018-04-17T05:05:34Z","updated_at":"2018-09-22T05:35:29Z","pushed_at":"2018-09-25T23:00:54Z","git_url":"git://github.com/bosnet/sebak.git","ssh_url":"git@github.com:bosnet/sebak.git","clone_url":"https://github.com/bosnet/sebak.git","svn_url":"https://github.com/bosnet/sebak","homepage":"https://boscoin.io","size":1052,"stargazers_count":36,"watchers_count":36,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":84,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":14,"open_issues":84,"watchers":36,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bosnet/sebak/pulls/450"},"html":{"href":"https://github.com/bosnet/sebak/pull/450"},"issue":{"href":"https://api.github.com/repos/bosnet/sebak/issues/450"},"comments":{"href":"https://api.github.com/repos/bosnet/sebak/issues/450/comments"},"review_comments":{"href":"https://api.github.com/repos/bosnet/sebak/pulls/450/comments"},"review_comment":{"href":"https://api.github.com/repos/bosnet/sebak/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bosnet/sebak/pulls/450/commits"},"statuses":{"href":"https://api.github.com/repos/bosnet/sebak/statuses/9d8da7f28c20e38e96db9aa3873212e9e81c872f"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":243,"deletions":71,"changed_files":9}}
{"actor":{"display_login":"spikeekips"}}