{"action":"opened","number":1660,"pull_request":{"url":"https://api.github.com/repos/aspnet/SignalR/pulls/1660","id":176113904,"html_url":"https://github.com/aspnet/SignalR/pull/1660","diff_url":"https://github.com/aspnet/SignalR/pull/1660.diff","patch_url":"https://github.com/aspnet/SignalR/pull/1660.patch","issue_url":"https://api.github.com/repos/aspnet/SignalR/issues/1660","number":1660,"state":"open","locked":false,"title":"Improved allocations and throughput for broadcast scenarios","user":{"login":"davidfowl","id":95136,"avatar_url":"https://avatars3.githubusercontent.com/u/95136?v=4","gravatar_id":"","url":"https://api.github.com/users/davidfowl","html_url":"https://github.com/davidfowl","followers_url":"https://api.github.com/users/davidfowl/followers","following_url":"https://api.github.com/users/davidfowl/following{/other_user}","gists_url":"https://api.github.com/users/davidfowl/gists{/gist_id}","starred_url":"https://api.github.com/users/davidfowl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidfowl/subscriptions","organizations_url":"https://api.github.com/users/davidfowl/orgs","repos_url":"https://api.github.com/users/davidfowl/repos","events_url":"https://api.github.com/users/davidfowl/events{/privacy}","received_events_url":"https://api.github.com/users/davidfowl/received_events","type":"User","site_admin":false},"body":"- Don't allocate when enumerating connections\r\n- Don't allocate tasks unless we truly go async\r\n- Don't get the timestamp, just write the pings always (if there's no ongoing write)\r\n- Track the time since last keep alive write instead of the last write (this needs some reviewing)\r\n\r\n## Old\r\n\r\n![image](https://user-images.githubusercontent.com/95136/37571804-d1745c1c-2abe-11e8-8e3a-904bc6b6d8bb.png)\r\n\r\n```\r\n       Method | Connections | Protocol |         Mean |       Error |        StdDev |      Op/s |   Gen 0 |  Gen 1 | Allocated |\r\n------------- |------------ |--------- |-------------:|------------:|--------------:|----------:|--------:|-------:|----------:|\r\n SendAsyncAll |           1 |     json |     7.545 us |   0.4048 us |     1.1936 us | 132,532.1 |  0.3204 |      - |   6.62 KB |\r\n SendAsyncAll |           1 |  msgpack |     5.492 us |   0.2845 us |     0.8343 us | 182,092.0 |  0.0610 |      - |   1.53 KB |\r\n SendAsyncAll |          10 |     json |    24.614 us |   1.3042 us |     3.7421 us |  40,626.6 |  0.2747 |      - |   7.27 KB |\r\n SendAsyncAll |          10 |  msgpack |    17.706 us |   0.3166 us |     0.3769 us |  56,476.9 |  0.0916 |      - |   2.17 KB |\r\n SendAsyncAll |        1000 |     json | 3,620.429 us | 371.4354 us | 1,095.1858 us |     276.2 | 11.7188 | 3.9063 |  593.6 KB |\r\n SendAsyncAll |        1000 |  msgpack | 2,705.518 us | 103.2645 us |   291.2594 us |     369.6 | 15.6250 | 3.9063 | 516.87 KB |\r\n```\r\n\r\n## New\r\n\r\n![image](https://user-images.githubusercontent.com/95136/37569110-e9963654-2a9a-11e8-94ca-0557912d8447.png)\r\n\r\n```\r\n        Method | Connections | Protocol |         Mean |       Error |      StdDev |       Median |      Op/s |   Gen 0 |  Gen 1 | Allocated |\r\n------------- |------------ |--------- |-------------:|------------:|------------:|-------------:|----------:|--------:|-------:|----------:|\r\n SendAsyncAll |           1 |     json |     6.614 us |   0.5787 us |   1.7064 us |     6.025 us | 151,184.7 |  0.3052 |      - |   6.33 KB |\r\n SendAsyncAll |           1 |  msgpack |     3.705 us |   0.1580 us |   0.4585 us |     3.576 us | 269,920.6 |  0.0496 |      - |   1.24 KB |\r\n SendAsyncAll |          10 |     json |    16.866 us |   0.9062 us |   2.6292 us |    17.083 us |  59,291.6 |  0.2899 | 0.0153 |   6.73 KB |\r\n SendAsyncAll |          10 |  msgpack |    14.836 us |   0.5637 us |   1.6443 us |    14.572 us |  67,403.7 |  0.0458 |      - |   1.36 KB |\r\n SendAsyncAll |        1000 |     json | 2,291.156 us |  75.0624 us | 212.9395 us | 2,282.967 us |     436.5 | 11.7188 | 3.9063 | 404.08 KB |\r\n SendAsyncAll |        1000 |  msgpack | 2,310.744 us | 116.0950 us | 333.0982 us | 2,209.508 us |     432.8 |  7.8125 |      - | 262.68 KB |\r\n```","created_at":"2018-03-20T08:06:29Z","updated_at":"2018-03-20T08:06:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/SignalR/pulls/1660/commits","review_comments_url":"https://api.github.com/repos/aspnet/SignalR/pulls/1660/comments","review_comment_url":"https://api.github.com/repos/aspnet/SignalR/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/SignalR/issues/1660/comments","statuses_url":"https://api.github.com/repos/aspnet/SignalR/statuses/c2c1d052cb3780c69eae85d72e8edebdb5b9fb5a","head":{"label":"aspnet:davidfowl/broadcast-allocs","ref":"davidfowl/broadcast-allocs","sha":"c2c1d052cb3780c69eae85d72e8edebdb5b9fb5a","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":71159589,"name":"SignalR","full_name":"aspnet/SignalR","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/SignalR","description":"Incredibly simple real-time web for ASP.NET Core","fork":false,"url":"https://api.github.com/repos/aspnet/SignalR","forks_url":"https://api.github.com/repos/aspnet/SignalR/forks","keys_url":"https://api.github.com/repos/aspnet/SignalR/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/SignalR/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/SignalR/teams","hooks_url":"https://api.github.com/repos/aspnet/SignalR/hooks","issue_events_url":"https://api.github.com/repos/aspnet/SignalR/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/SignalR/events","assignees_url":"https://api.github.com/repos/aspnet/SignalR/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/SignalR/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/SignalR/tags","blobs_url":"https://api.github.com/repos/aspnet/SignalR/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/SignalR/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/SignalR/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/SignalR/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/SignalR/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/SignalR/languages","stargazers_url":"https://api.github.com/repos/aspnet/SignalR/stargazers","contributors_url":"https://api.github.com/repos/aspnet/SignalR/contributors","subscribers_url":"https://api.github.com/repos/aspnet/SignalR/subscribers","subscription_url":"https://api.github.com/repos/aspnet/SignalR/subscription","commits_url":"https://api.github.com/repos/aspnet/SignalR/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/SignalR/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/SignalR/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/SignalR/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/SignalR/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/SignalR/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/SignalR/merges","archive_url":"https://api.github.com/repos/aspnet/SignalR/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/SignalR/downloads","issues_url":"https://api.github.com/repos/aspnet/SignalR/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/SignalR/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/SignalR/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/SignalR/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/SignalR/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/SignalR/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/SignalR/deployments","created_at":"2016-10-17T16:39:15Z","updated_at":"2018-03-20T05:03:05Z","pushed_at":"2018-03-20T07:12:06Z","git_url":"git://github.com/aspnet/SignalR.git","ssh_url":"git@github.com:aspnet/SignalR.git","clone_url":"https://github.com/aspnet/SignalR.git","svn_url":"https://github.com/aspnet/SignalR","homepage":null,"size":5051,"stargazers_count":1550,"watchers_count":1550,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":262,"mirror_url":null,"archived":false,"open_issues_count":136,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":262,"open_issues":136,"watchers":1550,"default_branch":"dev"}},"base":{"label":"aspnet:release/2.1","ref":"release/2.1","sha":"b91499b2fc0f52ec6e9b8d03f4e707bb27499c6f","user":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":71159589,"name":"SignalR","full_name":"aspnet/SignalR","owner":{"login":"aspnet","id":6476660,"avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/SignalR","description":"Incredibly simple real-time web for ASP.NET Core","fork":false,"url":"https://api.github.com/repos/aspnet/SignalR","forks_url":"https://api.github.com/repos/aspnet/SignalR/forks","keys_url":"https://api.github.com/repos/aspnet/SignalR/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/SignalR/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/SignalR/teams","hooks_url":"https://api.github.com/repos/aspnet/SignalR/hooks","issue_events_url":"https://api.github.com/repos/aspnet/SignalR/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/SignalR/events","assignees_url":"https://api.github.com/repos/aspnet/SignalR/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/SignalR/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/SignalR/tags","blobs_url":"https://api.github.com/repos/aspnet/SignalR/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/SignalR/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/SignalR/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/SignalR/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/SignalR/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/SignalR/languages","stargazers_url":"https://api.github.com/repos/aspnet/SignalR/stargazers","contributors_url":"https://api.github.com/repos/aspnet/SignalR/contributors","subscribers_url":"https://api.github.com/repos/aspnet/SignalR/subscribers","subscription_url":"https://api.github.com/repos/aspnet/SignalR/subscription","commits_url":"https://api.github.com/repos/aspnet/SignalR/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/SignalR/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/SignalR/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/SignalR/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/SignalR/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/SignalR/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/SignalR/merges","archive_url":"https://api.github.com/repos/aspnet/SignalR/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/SignalR/downloads","issues_url":"https://api.github.com/repos/aspnet/SignalR/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/SignalR/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/SignalR/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/SignalR/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/SignalR/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/SignalR/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/SignalR/deployments","created_at":"2016-10-17T16:39:15Z","updated_at":"2018-03-20T05:03:05Z","pushed_at":"2018-03-20T07:12:06Z","git_url":"git://github.com/aspnet/SignalR.git","ssh_url":"git@github.com:aspnet/SignalR.git","clone_url":"https://github.com/aspnet/SignalR.git","svn_url":"https://github.com/aspnet/SignalR","homepage":null,"size":5051,"stargazers_count":1550,"watchers_count":1550,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":262,"mirror_url":null,"archived":false,"open_issues_count":136,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":262,"open_issues":136,"watchers":1550,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/SignalR/pulls/1660"},"html":{"href":"https://github.com/aspnet/SignalR/pull/1660"},"issue":{"href":"https://api.github.com/repos/aspnet/SignalR/issues/1660"},"comments":{"href":"https://api.github.com/repos/aspnet/SignalR/issues/1660/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/SignalR/pulls/1660/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/SignalR/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/SignalR/pulls/1660/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/SignalR/statuses/c2c1d052cb3780c69eae85d72e8edebdb5b9fb5a"}},"author_association":"OWNER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":191,"deletions":56,"changed_files":4}}
{"actor":{"display_login":"davidfowl"}}