{"action":"created","comment":{"url":"https://api.github.com/repos/openssl/openssl/pulls/comments/189466890","pull_request_review_id":121651594,"id":189466890,"diff_hunk":"@@ -3,14 +3,16 @@\n ##\n ## {- join(\"\\n## \", @autowarntext) -}\n {-\n+\n+ our $lib_suffix = $target{lib_suffix} || \"\";\n  our $objext = $target{obj_extension} || \".obj\";\n  our $resext = $target{res_extension} || \".res\";\n  our $depext = $target{dep_extension} || \".d\";\n  our $exeext = $target{exe_extension} || \".exe\";\n- our $libext = $target{lib_extension} || \".lib\";\n- our $shlibext = $target{shared_extension} || \".dll\";\n- our $shlibextimport = $target{shared_import_extension} || \".lib\";\n- our $dsoext = $target{dso_extension} || \".dll\";\n+ our $libext = $lib_suffix . ($target{lib_extension} || \".lib\");\n+ our $shlibext = $lib_suffix . ($target{shared_extension} || \".dll\");\n+ our $shlibextimport = $lib_suffix . ($target{shared_import_extension} || \".lib\");\n+ our $dsoext = $lib_suffix . ($target{dso_extension} || \".dll\");","path":"Configurations/windows-makefile.tmpl","position":17,"original_position":17,"commit_id":"0ca0a435a83b1215af128c807ef9f99ac51332ea","original_commit_id":"0ca0a435a83b1215af128c807ef9f99ac51332ea","user":{"login":"dot-asm","id":9038069,"avatar_url":"https://avatars2.githubusercontent.com/u/9038069?v=4","gravatar_id":"","url":"https://api.github.com/users/dot-asm","html_url":"https://github.com/dot-asm","followers_url":"https://api.github.com/users/dot-asm/followers","following_url":"https://api.github.com/users/dot-asm/following{/other_user}","gists_url":"https://api.github.com/users/dot-asm/gists{/gist_id}","starred_url":"https://api.github.com/users/dot-asm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dot-asm/subscriptions","organizations_url":"https://api.github.com/users/dot-asm/orgs","repos_url":"https://api.github.com/users/dot-asm/repos","events_url":"https://api.github.com/users/dot-asm/events{/privacy}","received_events_url":"https://api.github.com/users/dot-asm/received_events","type":"User","site_admin":false},"body":"I haven't tested this, but if this line means that even engine dlls will get addendum in its name, then one has to recognize that when you ask to load engine X, the name is composed according to platform-specific predefined rules, so there is no place for name customization...","created_at":"2018-05-20T18:44:33Z","updated_at":"2018-05-20T18:44:34Z","html_url":"https://github.com/openssl/openssl/pull/6305#discussion_r189466890","pull_request_url":"https://api.github.com/repos/openssl/openssl/pulls/6305","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openssl/openssl/pulls/comments/189466890"},"html":{"href":"https://github.com/openssl/openssl/pull/6305#discussion_r189466890"},"pull_request":{"href":"https://api.github.com/repos/openssl/openssl/pulls/6305"}}},"pull_request":{"url":"https://api.github.com/repos/openssl/openssl/pulls/6305","id":189183553,"html_url":"https://github.com/openssl/openssl/pull/6305","diff_url":"https://github.com/openssl/openssl/pull/6305.diff","patch_url":"https://github.com/openssl/openssl/pull/6305.patch","issue_url":"https://api.github.com/repos/openssl/openssl/issues/6305","number":6305,"state":"open","locked":false,"title":"Add optional lib_suffix","user":{"login":"ObiWahn","id":741109,"avatar_url":"https://avatars1.githubusercontent.com/u/741109?v=4","gravatar_id":"","url":"https://api.github.com/users/ObiWahn","html_url":"https://github.com/ObiWahn","followers_url":"https://api.github.com/users/ObiWahn/followers","following_url":"https://api.github.com/users/ObiWahn/following{/other_user}","gists_url":"https://api.github.com/users/ObiWahn/gists{/gist_id}","starred_url":"https://api.github.com/users/ObiWahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ObiWahn/subscriptions","organizations_url":"https://api.github.com/users/ObiWahn/orgs","repos_url":"https://api.github.com/users/ObiWahn/repos","events_url":"https://api.github.com/users/ObiWahn/events{/privacy}","received_events_url":"https://api.github.com/users/ObiWahn/received_events","type":"User","site_admin":false},"body":"**What:**\r\n\r\nThis patch should allow for easier building of openssl windows libraries like they can be found on:\r\nhttps://www.npcglib.org/~stathis/blog/precompiled-openssl/\r\n\r\n**Why:**\r\n\r\nWe have currently the situation that we want to use a recent windows lib that is build with Visual Studio 2017. But there are only precompiled libraries that are not up to date or not compiled with Visual Studio 2017. First\r\nI tried to apply the patches provided by _stathis_ (in the link above) to a more recent version but failed. So I came up with this patch that seems to solve our problem but most probably still needs a lot of reviewing and work to get it in the official repository.\r\n\r\nI think it is important that people are able to build and use a recent openssl versions on windows that works together with tools like CMake. Of course I could have changed https://github.com/Kitware/CMake/blob/master/Modules/FindOpenSSL.cmake and introduced more places openssl is searched for. I did decide against it because the situation on windows concerning library locations is bad enough.\r\n\r\nPlease let me know what needs to be changed. Please note that I am a total perl newbie:)","created_at":"2018-05-19T11:12:11Z","updated_at":"2018-05-20T18:44:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a7d6c4d81b3f866d54c93a86cef30d187c1df456","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openssl/openssl/pulls/6305/commits","review_comments_url":"https://api.github.com/repos/openssl/openssl/pulls/6305/comments","review_comment_url":"https://api.github.com/repos/openssl/openssl/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openssl/openssl/issues/6305/comments","statuses_url":"https://api.github.com/repos/openssl/openssl/statuses/0ca0a435a83b1215af128c807ef9f99ac51332ea","head":{"label":"ObiWahn:master","ref":"master","sha":"0ca0a435a83b1215af128c807ef9f99ac51332ea","user":{"login":"ObiWahn","id":741109,"avatar_url":"https://avatars1.githubusercontent.com/u/741109?v=4","gravatar_id":"","url":"https://api.github.com/users/ObiWahn","html_url":"https://github.com/ObiWahn","followers_url":"https://api.github.com/users/ObiWahn/followers","following_url":"https://api.github.com/users/ObiWahn/following{/other_user}","gists_url":"https://api.github.com/users/ObiWahn/gists{/gist_id}","starred_url":"https://api.github.com/users/ObiWahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ObiWahn/subscriptions","organizations_url":"https://api.github.com/users/ObiWahn/orgs","repos_url":"https://api.github.com/users/ObiWahn/repos","events_url":"https://api.github.com/users/ObiWahn/events{/privacy}","received_events_url":"https://api.github.com/users/ObiWahn/received_events","type":"User","site_admin":false},"repo":{"id":133763231,"name":"openssl","full_name":"ObiWahn/openssl","owner":{"login":"ObiWahn","id":741109,"avatar_url":"https://avatars1.githubusercontent.com/u/741109?v=4","gravatar_id":"","url":"https://api.github.com/users/ObiWahn","html_url":"https://github.com/ObiWahn","followers_url":"https://api.github.com/users/ObiWahn/followers","following_url":"https://api.github.com/users/ObiWahn/following{/other_user}","gists_url":"https://api.github.com/users/ObiWahn/gists{/gist_id}","starred_url":"https://api.github.com/users/ObiWahn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ObiWahn/subscriptions","organizations_url":"https://api.github.com/users/ObiWahn/orgs","repos_url":"https://api.github.com/users/ObiWahn/repos","events_url":"https://api.github.com/users/ObiWahn/events{/privacy}","received_events_url":"https://api.github.com/users/ObiWahn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ObiWahn/openssl","description":"TLS/SSL and crypto library","fork":true,"url":"https://api.github.com/repos/ObiWahn/openssl","forks_url":"https://api.github.com/repos/ObiWahn/openssl/forks","keys_url":"https://api.github.com/repos/ObiWahn/openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ObiWahn/openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ObiWahn/openssl/teams","hooks_url":"https://api.github.com/repos/ObiWahn/openssl/hooks","issue_events_url":"https://api.github.com/repos/ObiWahn/openssl/issues/events{/number}","events_url":"https://api.github.com/repos/ObiWahn/openssl/events","assignees_url":"https://api.github.com/repos/ObiWahn/openssl/assignees{/user}","branches_url":"https://api.github.com/repos/ObiWahn/openssl/branches{/branch}","tags_url":"https://api.github.com/repos/ObiWahn/openssl/tags","blobs_url":"https://api.github.com/repos/ObiWahn/openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ObiWahn/openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ObiWahn/openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/ObiWahn/openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ObiWahn/openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/ObiWahn/openssl/languages","stargazers_url":"https://api.github.com/repos/ObiWahn/openssl/stargazers","contributors_url":"https://api.github.com/repos/ObiWahn/openssl/contributors","subscribers_url":"https://api.github.com/repos/ObiWahn/openssl/subscribers","subscription_url":"https://api.github.com/repos/ObiWahn/openssl/subscription","commits_url":"https://api.github.com/repos/ObiWahn/openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/ObiWahn/openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/ObiWahn/openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/ObiWahn/openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/ObiWahn/openssl/contents/{+path}","compare_url":"https://api.github.com/repos/ObiWahn/openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ObiWahn/openssl/merges","archive_url":"https://api.github.com/repos/ObiWahn/openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ObiWahn/openssl/downloads","issues_url":"https://api.github.com/repos/ObiWahn/openssl/issues{/number}","pulls_url":"https://api.github.com/repos/ObiWahn/openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/ObiWahn/openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/ObiWahn/openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ObiWahn/openssl/labels{/name}","releases_url":"https://api.github.com/repos/ObiWahn/openssl/releases{/id}","deployments_url":"https://api.github.com/repos/ObiWahn/openssl/deployments","created_at":"2018-05-17T05:30:43Z","updated_at":"2018-05-20T18:13:48Z","pushed_at":"2018-05-20T18:13:46Z","git_url":"git://github.com/ObiWahn/openssl.git","ssh_url":"git@github.com:ObiWahn/openssl.git","clone_url":"https://github.com/ObiWahn/openssl.git","svn_url":"https://github.com/ObiWahn/openssl","homepage":"https://www.openssl.org","size":147237,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openssl:master","ref":"master","sha":"246bd8fd0507f4555432c148eed5a9322c113bf5","user":{"login":"openssl","id":3279138,"avatar_url":"https://avatars2.githubusercontent.com/u/3279138?v=4","gravatar_id":"","url":"https://api.github.com/users/openssl","html_url":"https://github.com/openssl","followers_url":"https://api.github.com/users/openssl/followers","following_url":"https://api.github.com/users/openssl/following{/other_user}","gists_url":"https://api.github.com/users/openssl/gists{/gist_id}","starred_url":"https://api.github.com/users/openssl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openssl/subscriptions","organizations_url":"https://api.github.com/users/openssl/orgs","repos_url":"https://api.github.com/users/openssl/repos","events_url":"https://api.github.com/users/openssl/events{/privacy}","received_events_url":"https://api.github.com/users/openssl/received_events","type":"Organization","site_admin":false},"repo":{"id":7634677,"name":"openssl","full_name":"openssl/openssl","owner":{"login":"openssl","id":3279138,"avatar_url":"https://avatars2.githubusercontent.com/u/3279138?v=4","gravatar_id":"","url":"https://api.github.com/users/openssl","html_url":"https://github.com/openssl","followers_url":"https://api.github.com/users/openssl/followers","following_url":"https://api.github.com/users/openssl/following{/other_user}","gists_url":"https://api.github.com/users/openssl/gists{/gist_id}","starred_url":"https://api.github.com/users/openssl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openssl/subscriptions","organizations_url":"https://api.github.com/users/openssl/orgs","repos_url":"https://api.github.com/users/openssl/repos","events_url":"https://api.github.com/users/openssl/events{/privacy}","received_events_url":"https://api.github.com/users/openssl/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openssl/openssl","description":"TLS/SSL and crypto library","fork":false,"url":"https://api.github.com/repos/openssl/openssl","forks_url":"https://api.github.com/repos/openssl/openssl/forks","keys_url":"https://api.github.com/repos/openssl/openssl/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openssl/openssl/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openssl/openssl/teams","hooks_url":"https://api.github.com/repos/openssl/openssl/hooks","issue_events_url":"https://api.github.com/repos/openssl/openssl/issues/events{/number}","events_url":"https://api.github.com/repos/openssl/openssl/events","assignees_url":"https://api.github.com/repos/openssl/openssl/assignees{/user}","branches_url":"https://api.github.com/repos/openssl/openssl/branches{/branch}","tags_url":"https://api.github.com/repos/openssl/openssl/tags","blobs_url":"https://api.github.com/repos/openssl/openssl/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openssl/openssl/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openssl/openssl/git/refs{/sha}","trees_url":"https://api.github.com/repos/openssl/openssl/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openssl/openssl/statuses/{sha}","languages_url":"https://api.github.com/repos/openssl/openssl/languages","stargazers_url":"https://api.github.com/repos/openssl/openssl/stargazers","contributors_url":"https://api.github.com/repos/openssl/openssl/contributors","subscribers_url":"https://api.github.com/repos/openssl/openssl/subscribers","subscription_url":"https://api.github.com/repos/openssl/openssl/subscription","commits_url":"https://api.github.com/repos/openssl/openssl/commits{/sha}","git_commits_url":"https://api.github.com/repos/openssl/openssl/git/commits{/sha}","comments_url":"https://api.github.com/repos/openssl/openssl/comments{/number}","issue_comment_url":"https://api.github.com/repos/openssl/openssl/issues/comments{/number}","contents_url":"https://api.github.com/repos/openssl/openssl/contents/{+path}","compare_url":"https://api.github.com/repos/openssl/openssl/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openssl/openssl/merges","archive_url":"https://api.github.com/repos/openssl/openssl/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openssl/openssl/downloads","issues_url":"https://api.github.com/repos/openssl/openssl/issues{/number}","pulls_url":"https://api.github.com/repos/openssl/openssl/pulls{/number}","milestones_url":"https://api.github.com/repos/openssl/openssl/milestones{/number}","notifications_url":"https://api.github.com/repos/openssl/openssl/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openssl/openssl/labels{/name}","releases_url":"https://api.github.com/repos/openssl/openssl/releases{/id}","deployments_url":"https://api.github.com/repos/openssl/openssl/deployments","created_at":"2013-01-15T22:34:48Z","updated_at":"2018-05-20T17:56:55Z","pushed_at":"2018-05-20T18:13:48Z","git_url":"git://github.com/openssl/openssl.git","ssh_url":"git@github.com:openssl/openssl.git","clone_url":"https://github.com/openssl/openssl.git","svn_url":"https://github.com/openssl/openssl","homepage":"https://www.openssl.org","size":147578,"stargazers_count":7141,"watchers_count":7141,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3455,"mirror_url":null,"archived":false,"open_issues_count":379,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":3455,"open_issues":379,"watchers":7141,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openssl/openssl/pulls/6305"},"html":{"href":"https://github.com/openssl/openssl/pull/6305"},"issue":{"href":"https://api.github.com/repos/openssl/openssl/issues/6305"},"comments":{"href":"https://api.github.com/repos/openssl/openssl/issues/6305/comments"},"review_comments":{"href":"https://api.github.com/repos/openssl/openssl/pulls/6305/comments"},"review_comment":{"href":"https://api.github.com/repos/openssl/openssl/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openssl/openssl/pulls/6305/commits"},"statuses":{"href":"https://api.github.com/repos/openssl/openssl/statuses/0ca0a435a83b1215af128c807ef9f99ac51332ea"}},"author_association":"NONE"}}
{"actor":{"display_login":"dot-asm"}}