{"action":"created","comment":{"url":"https://api.github.com/repos/jhump/protoreflect/pulls/comments/204811569","pull_request_review_id":139958397,"id":204811569,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDgxMTU2OQ==","diff_hunk":"@@ -1154,7 +1154,7 @@ func (r *parseResult) generateSourceCodeInfoForEnum(sci *sourceCodeInfo, enum *d\n \t\tevPath := append(path, internal.Enum_valuesTag, int32(j))\n \t\tsci.newLoc(evn, evPath)\n \t\tsci.newLoc(evn.name, append(evPath, internal.EnumVal_nameTag))\n-\t\tsci.newLoc(evn.number, append(evPath, internal.EnumVal_numberTag))\n+\t\tsci.newLoc(evn.getNumber(), append(evPath, internal.EnumVal_numberTag))","path":"desc/protoparse/parser.go","position":16,"original_position":16,"commit_id":"b994d0243c1146892f9efdc3f317ca9217bc9f2c","original_commit_id":"b994d0243c1146892f9efdc3f317ca9217bc9f2c","user":{"login":"jhump","id":2035234,"node_id":"MDQ6VXNlcjIwMzUyMzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2035234?v=4","gravatar_id":"","url":"https://api.github.com/users/jhump","html_url":"https://github.com/jhump","followers_url":"https://api.github.com/users/jhump/followers","following_url":"https://api.github.com/users/jhump/following{/other_user}","gists_url":"https://api.github.com/users/jhump/gists{/gist_id}","starred_url":"https://api.github.com/users/jhump/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhump/subscriptions","organizations_url":"https://api.github.com/users/jhump/orgs","repos_url":"https://api.github.com/users/jhump/repos","events_url":"https://api.github.com/users/jhump/events{/privacy}","received_events_url":"https://api.github.com/users/jhump/received_events","type":"User","site_admin":false},"body":"The actual fix, as proposed in #139.","created_at":"2018-07-24T15:51:08Z","updated_at":"2018-07-24T15:52:31Z","html_url":"https://github.com/jhump/protoreflect/pull/140#discussion_r204811569","pull_request_url":"https://api.github.com/repos/jhump/protoreflect/pulls/140","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/jhump/protoreflect/pulls/comments/204811569"},"html":{"href":"https://github.com/jhump/protoreflect/pull/140#discussion_r204811569"},"pull_request":{"href":"https://api.github.com/repos/jhump/protoreflect/pulls/140"}}},"pull_request":{"url":"https://api.github.com/repos/jhump/protoreflect/pulls/140","id":203574106,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzNTc0MTA2","html_url":"https://github.com/jhump/protoreflect/pull/140","diff_url":"https://github.com/jhump/protoreflect/pull/140.diff","patch_url":"https://github.com/jhump/protoreflect/pull/140.patch","issue_url":"https://api.github.com/repos/jhump/protoreflect/issues/140","number":140,"state":"open","locked":false,"title":"fix panic in protoparse","user":{"login":"jhump","id":2035234,"node_id":"MDQ6VXNlcjIwMzUyMzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2035234?v=4","gravatar_id":"","url":"https://api.github.com/users/jhump","html_url":"https://github.com/jhump","followers_url":"https://api.github.com/users/jhump/followers","following_url":"https://api.github.com/users/jhump/following{/other_user}","gists_url":"https://api.github.com/users/jhump/gists{/gist_id}","starred_url":"https://api.github.com/users/jhump/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhump/subscriptions","organizations_url":"https://api.github.com/users/jhump/orgs","repos_url":"https://api.github.com/users/jhump/repos","events_url":"https://api.github.com/users/jhump/events{/privacy}","received_events_url":"https://api.github.com/users/jhump/received_events","type":"User","site_admin":false},"body":"When computing source code info for enum values with a negative numeric value, the `protoparse` package would panic due to a nil de-reference. This fixes that and adds a negative value to a proto to make sure the code and the fix are exercised during tests.\r\n\r\nResolves #139 ","created_at":"2018-07-24T15:49:59Z","updated_at":"2018-07-24T15:52:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"21ae3c9de058e26fed26e23b82b43a6c3c175b1e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jhump/protoreflect/pulls/140/commits","review_comments_url":"https://api.github.com/repos/jhump/protoreflect/pulls/140/comments","review_comment_url":"https://api.github.com/repos/jhump/protoreflect/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jhump/protoreflect/issues/140/comments","statuses_url":"https://api.github.com/repos/jhump/protoreflect/statuses/b994d0243c1146892f9efdc3f317ca9217bc9f2c","head":{"label":"jhump:jh/fix-panic-in-protoparse-for-negative-enum-vals","ref":"jh/fix-panic-in-protoparse-for-negative-enum-vals","sha":"b994d0243c1146892f9efdc3f317ca9217bc9f2c","user":{"login":"jhump","id":2035234,"node_id":"MDQ6VXNlcjIwMzUyMzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2035234?v=4","gravatar_id":"","url":"https://api.github.com/users/jhump","html_url":"https://github.com/jhump","followers_url":"https://api.github.com/users/jhump/followers","following_url":"https://api.github.com/users/jhump/following{/other_user}","gists_url":"https://api.github.com/users/jhump/gists{/gist_id}","starred_url":"https://api.github.com/users/jhump/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhump/subscriptions","organizations_url":"https://api.github.com/users/jhump/orgs","repos_url":"https://api.github.com/users/jhump/repos","events_url":"https://api.github.com/users/jhump/events{/privacy}","received_events_url":"https://api.github.com/users/jhump/received_events","type":"User","site_admin":false},"repo":{"id":81850273,"node_id":"MDEwOlJlcG9zaXRvcnk4MTg1MDI3Mw==","name":"protoreflect","full_name":"jhump/protoreflect","owner":{"login":"jhump","id":2035234,"node_id":"MDQ6VXNlcjIwMzUyMzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2035234?v=4","gravatar_id":"","url":"https://api.github.com/users/jhump","html_url":"https://github.com/jhump","followers_url":"https://api.github.com/users/jhump/followers","following_url":"https://api.github.com/users/jhump/following{/other_user}","gists_url":"https://api.github.com/users/jhump/gists{/gist_id}","starred_url":"https://api.github.com/users/jhump/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhump/subscriptions","organizations_url":"https://api.github.com/users/jhump/orgs","repos_url":"https://api.github.com/users/jhump/repos","events_url":"https://api.github.com/users/jhump/events{/privacy}","received_events_url":"https://api.github.com/users/jhump/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jhump/protoreflect","description":"Reflection (Rich Descriptors) for Go Protocol Buffers","fork":false,"url":"https://api.github.com/repos/jhump/protoreflect","forks_url":"https://api.github.com/repos/jhump/protoreflect/forks","keys_url":"https://api.github.com/repos/jhump/protoreflect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jhump/protoreflect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jhump/protoreflect/teams","hooks_url":"https://api.github.com/repos/jhump/protoreflect/hooks","issue_events_url":"https://api.github.com/repos/jhump/protoreflect/issues/events{/number}","events_url":"https://api.github.com/repos/jhump/protoreflect/events","assignees_url":"https://api.github.com/repos/jhump/protoreflect/assignees{/user}","branches_url":"https://api.github.com/repos/jhump/protoreflect/branches{/branch}","tags_url":"https://api.github.com/repos/jhump/protoreflect/tags","blobs_url":"https://api.github.com/repos/jhump/protoreflect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jhump/protoreflect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jhump/protoreflect/git/refs{/sha}","trees_url":"https://api.github.com/repos/jhump/protoreflect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jhump/protoreflect/statuses/{sha}","languages_url":"https://api.github.com/repos/jhump/protoreflect/languages","stargazers_url":"https://api.github.com/repos/jhump/protoreflect/stargazers","contributors_url":"https://api.github.com/repos/jhump/protoreflect/contributors","subscribers_url":"https://api.github.com/repos/jhump/protoreflect/subscribers","subscription_url":"https://api.github.com/repos/jhump/protoreflect/subscription","commits_url":"https://api.github.com/repos/jhump/protoreflect/commits{/sha}","git_commits_url":"https://api.github.com/repos/jhump/protoreflect/git/commits{/sha}","comments_url":"https://api.github.com/repos/jhump/protoreflect/comments{/number}","issue_comment_url":"https://api.github.com/repos/jhump/protoreflect/issues/comments{/number}","contents_url":"https://api.github.com/repos/jhump/protoreflect/contents/{+path}","compare_url":"https://api.github.com/repos/jhump/protoreflect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jhump/protoreflect/merges","archive_url":"https://api.github.com/repos/jhump/protoreflect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jhump/protoreflect/downloads","issues_url":"https://api.github.com/repos/jhump/protoreflect/issues{/number}","pulls_url":"https://api.github.com/repos/jhump/protoreflect/pulls{/number}","milestones_url":"https://api.github.com/repos/jhump/protoreflect/milestones{/number}","notifications_url":"https://api.github.com/repos/jhump/protoreflect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jhump/protoreflect/labels{/name}","releases_url":"https://api.github.com/repos/jhump/protoreflect/releases{/id}","deployments_url":"https://api.github.com/repos/jhump/protoreflect/deployments","created_at":"2017-02-13T17:11:38Z","updated_at":"2018-07-24T05:57:11Z","pushed_at":"2018-07-24T15:50:00Z","git_url":"git://github.com/jhump/protoreflect.git","ssh_url":"git@github.com:jhump/protoreflect.git","clone_url":"https://github.com/jhump/protoreflect.git","svn_url":"https://github.com/jhump/protoreflect","homepage":"","size":1182,"stargazers_count":90,"watchers_count":90,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":19,"open_issues":4,"watchers":90,"default_branch":"master"}},"base":{"label":"jhump:master","ref":"master","sha":"dec7efff960aff9689f61d913a23286a260ac875","user":{"login":"jhump","id":2035234,"node_id":"MDQ6VXNlcjIwMzUyMzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2035234?v=4","gravatar_id":"","url":"https://api.github.com/users/jhump","html_url":"https://github.com/jhump","followers_url":"https://api.github.com/users/jhump/followers","following_url":"https://api.github.com/users/jhump/following{/other_user}","gists_url":"https://api.github.com/users/jhump/gists{/gist_id}","starred_url":"https://api.github.com/users/jhump/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhump/subscriptions","organizations_url":"https://api.github.com/users/jhump/orgs","repos_url":"https://api.github.com/users/jhump/repos","events_url":"https://api.github.com/users/jhump/events{/privacy}","received_events_url":"https://api.github.com/users/jhump/received_events","type":"User","site_admin":false},"repo":{"id":81850273,"node_id":"MDEwOlJlcG9zaXRvcnk4MTg1MDI3Mw==","name":"protoreflect","full_name":"jhump/protoreflect","owner":{"login":"jhump","id":2035234,"node_id":"MDQ6VXNlcjIwMzUyMzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2035234?v=4","gravatar_id":"","url":"https://api.github.com/users/jhump","html_url":"https://github.com/jhump","followers_url":"https://api.github.com/users/jhump/followers","following_url":"https://api.github.com/users/jhump/following{/other_user}","gists_url":"https://api.github.com/users/jhump/gists{/gist_id}","starred_url":"https://api.github.com/users/jhump/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhump/subscriptions","organizations_url":"https://api.github.com/users/jhump/orgs","repos_url":"https://api.github.com/users/jhump/repos","events_url":"https://api.github.com/users/jhump/events{/privacy}","received_events_url":"https://api.github.com/users/jhump/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jhump/protoreflect","description":"Reflection (Rich Descriptors) for Go Protocol Buffers","fork":false,"url":"https://api.github.com/repos/jhump/protoreflect","forks_url":"https://api.github.com/repos/jhump/protoreflect/forks","keys_url":"https://api.github.com/repos/jhump/protoreflect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jhump/protoreflect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jhump/protoreflect/teams","hooks_url":"https://api.github.com/repos/jhump/protoreflect/hooks","issue_events_url":"https://api.github.com/repos/jhump/protoreflect/issues/events{/number}","events_url":"https://api.github.com/repos/jhump/protoreflect/events","assignees_url":"https://api.github.com/repos/jhump/protoreflect/assignees{/user}","branches_url":"https://api.github.com/repos/jhump/protoreflect/branches{/branch}","tags_url":"https://api.github.com/repos/jhump/protoreflect/tags","blobs_url":"https://api.github.com/repos/jhump/protoreflect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jhump/protoreflect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jhump/protoreflect/git/refs{/sha}","trees_url":"https://api.github.com/repos/jhump/protoreflect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jhump/protoreflect/statuses/{sha}","languages_url":"https://api.github.com/repos/jhump/protoreflect/languages","stargazers_url":"https://api.github.com/repos/jhump/protoreflect/stargazers","contributors_url":"https://api.github.com/repos/jhump/protoreflect/contributors","subscribers_url":"https://api.github.com/repos/jhump/protoreflect/subscribers","subscription_url":"https://api.github.com/repos/jhump/protoreflect/subscription","commits_url":"https://api.github.com/repos/jhump/protoreflect/commits{/sha}","git_commits_url":"https://api.github.com/repos/jhump/protoreflect/git/commits{/sha}","comments_url":"https://api.github.com/repos/jhump/protoreflect/comments{/number}","issue_comment_url":"https://api.github.com/repos/jhump/protoreflect/issues/comments{/number}","contents_url":"https://api.github.com/repos/jhump/protoreflect/contents/{+path}","compare_url":"https://api.github.com/repos/jhump/protoreflect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jhump/protoreflect/merges","archive_url":"https://api.github.com/repos/jhump/protoreflect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jhump/protoreflect/downloads","issues_url":"https://api.github.com/repos/jhump/protoreflect/issues{/number}","pulls_url":"https://api.github.com/repos/jhump/protoreflect/pulls{/number}","milestones_url":"https://api.github.com/repos/jhump/protoreflect/milestones{/number}","notifications_url":"https://api.github.com/repos/jhump/protoreflect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jhump/protoreflect/labels{/name}","releases_url":"https://api.github.com/repos/jhump/protoreflect/releases{/id}","deployments_url":"https://api.github.com/repos/jhump/protoreflect/deployments","created_at":"2017-02-13T17:11:38Z","updated_at":"2018-07-24T05:57:11Z","pushed_at":"2018-07-24T15:50:00Z","git_url":"git://github.com/jhump/protoreflect.git","ssh_url":"git@github.com:jhump/protoreflect.git","clone_url":"https://github.com/jhump/protoreflect.git","svn_url":"https://github.com/jhump/protoreflect","homepage":"","size":1182,"stargazers_count":90,"watchers_count":90,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":19,"open_issues":4,"watchers":90,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jhump/protoreflect/pulls/140"},"html":{"href":"https://github.com/jhump/protoreflect/pull/140"},"issue":{"href":"https://api.github.com/repos/jhump/protoreflect/issues/140"},"comments":{"href":"https://api.github.com/repos/jhump/protoreflect/issues/140/comments"},"review_comments":{"href":"https://api.github.com/repos/jhump/protoreflect/pulls/140/comments"},"review_comment":{"href":"https://api.github.com/repos/jhump/protoreflect/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jhump/protoreflect/pulls/140/commits"},"statuses":{"href":"https://api.github.com/repos/jhump/protoreflect/statuses/b994d0243c1146892f9efdc3f317ca9217bc9f2c"}},"author_association":"OWNER"}}
{"actor":{"display_login":"jhump"}}