{"action":"created","comment":{"url":"https://api.github.com/repos/AppImage/libappimage/pulls/comments/230997940","pull_request_review_id":171862736,"id":230997940,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDk5Nzk0MA==","diff_hunk":"@@ -0,0 +1,185 @@\n+// library headers\n+#include <glib.h>\n+#include <gtest/gtest.h>\n+#include <glib/gstdio.h>\n+#include <appimage/appimage.h>\n+#include <fcntl.h>\n+extern \"C\" {\n+#include <unistd.h>\n+}\n+\n+#include \"desktop_integration.h\"\n+#include \"file_management_utils.hpp\"\n+\n+class DesktopIntegrationTests : public ::testing::Test {\n+protected:\n+    std::string appdir_path;\n+    std::string user_dir_path;\n+    char* appimage_path;\n+\n+    virtual void SetUp() {\n+        appimage_path = g_strjoin(\"/\", TEST_DATA_DIR, \"Echo-x86_64.AppImage\", NULL);\n+\n+        appdir_path = createTempDir(\"libappimage-di-appdir\");\n+        user_dir_path = createTempDir(\"libappimage-di-user-dir\");\n+\n+        ASSERT_FALSE(appdir_path.empty());\n+        ASSERT_FALSE(user_dir_path.empty());\n+    }\n+\n+    virtual void TearDown() {\n+        removeDirRecursively(appdir_path);","path":"tests/test_desktop_integration.cpp","position":32,"original_position":31,"commit_id":"22dde049fa603b0626c4620931aa526f957612de","original_commit_id":"5be8781becca276467bf81ae667c51529d240694","user":{"login":"azubieta","id":1138094,"node_id":"MDQ6VXNlcjExMzgwOTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1138094?v=4","gravatar_id":"","url":"https://api.github.com/users/azubieta","html_url":"https://github.com/azubieta","followers_url":"https://api.github.com/users/azubieta/followers","following_url":"https://api.github.com/users/azubieta/following{/other_user}","gists_url":"https://api.github.com/users/azubieta/gists{/gist_id}","starred_url":"https://api.github.com/users/azubieta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azubieta/subscriptions","organizations_url":"https://api.github.com/users/azubieta/orgs","repos_url":"https://api.github.com/users/azubieta/repos","events_url":"https://api.github.com/users/azubieta/events{/privacy}","received_events_url":"https://api.github.com/users/azubieta/received_events","type":"User","site_admin":false},"body":"Teste here: https://github.com/AppImage/libappimage/blob/06bc4d3cebdde4557ab4459c079c58759d7488c5/tests/test_desktop_integration.cpp#L65\r\nI guess that it could be used in another place and mixing it with the test code will limit that.","created_at":"2018-11-06T04:44:37Z","updated_at":"2018-11-06T04:44:38Z","html_url":"https://github.com/AppImage/libappimage/pull/14#discussion_r230997940","pull_request_url":"https://api.github.com/repos/AppImage/libappimage/pulls/14","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/AppImage/libappimage/pulls/comments/230997940"},"html":{"href":"https://github.com/AppImage/libappimage/pull/14#discussion_r230997940"},"pull_request":{"href":"https://api.github.com/repos/AppImage/libappimage/pulls/14"}},"in_reply_to_id":230736870},"pull_request":{"url":"https://api.github.com/repos/AppImage/libappimage/pulls/14","id":225521615,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1NTIxNjE1","html_url":"https://github.com/AppImage/libappimage/pull/14","diff_url":"https://github.com/AppImage/libappimage/pull/14.diff","patch_url":"https://github.com/AppImage/libappimage/pull/14.patch","issue_url":"https://api.github.com/repos/AppImage/libappimage/issues/14","number":14,"state":"open","locked":false,"title":"Improve desktop integration functions","user":{"login":"azubieta","id":1138094,"node_id":"MDQ6VXNlcjExMzgwOTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1138094?v=4","gravatar_id":"","url":"https://api.github.com/users/azubieta","html_url":"https://github.com/azubieta","followers_url":"https://api.github.com/users/azubieta/followers","following_url":"https://api.github.com/users/azubieta/following{/other_user}","gists_url":"https://api.github.com/users/azubieta/gists{/gist_id}","starred_url":"https://api.github.com/users/azubieta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/azubieta/subscriptions","organizations_url":"https://api.github.com/users/azubieta/orgs","repos_url":"https://api.github.com/users/azubieta/repos","events_url":"https://api.github.com/users/azubieta/events{/privacy}","received_events_url":"https://api.github.com/users/azubieta/received_events","type":"User","site_admin":false},"body":"Remake of the desktop integration functions.\r\n    \r\nCreate an alternative implementation using the travese appimage algorithm to abstract the desktop integration logic from the AppImage management.\r\nFunctions included:\r\n - extract desktop integration relevant files (.desktop, icons)\r\n - modify desktop file to be deployed.\r\n - deploy modified desktop file\r\n - deploy icons\r\n\r\nMissing:\r\n - deploy mime-types","created_at":"2018-10-24T19:25:16Z","updated_at":"2018-11-06T04:44:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"851feccc518081c36e6a7988a611057759efd2e2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/AppImage/libappimage/pulls/14/commits","review_comments_url":"https://api.github.com/repos/AppImage/libappimage/pulls/14/comments","review_comment_url":"https://api.github.com/repos/AppImage/libappimage/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AppImage/libappimage/issues/14/comments","statuses_url":"https://api.github.com/repos/AppImage/libappimage/statuses/22dde049fa603b0626c4620931aa526f957612de","head":{"label":"AppImage:improve_desktop_integration_functions","ref":"improve_desktop_integration_functions","sha":"22dde049fa603b0626c4620931aa526f957612de","user":{"login":"AppImage","id":16617932,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NjE3OTMy","avatar_url":"https://avatars0.githubusercontent.com/u/16617932?v=4","gravatar_id":"","url":"https://api.github.com/users/AppImage","html_url":"https://github.com/AppImage","followers_url":"https://api.github.com/users/AppImage/followers","following_url":"https://api.github.com/users/AppImage/following{/other_user}","gists_url":"https://api.github.com/users/AppImage/gists{/gist_id}","starred_url":"https://api.github.com/users/AppImage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AppImage/subscriptions","organizations_url":"https://api.github.com/users/AppImage/orgs","repos_url":"https://api.github.com/users/AppImage/repos","events_url":"https://api.github.com/users/AppImage/events{/privacy}","received_events_url":"https://api.github.com/users/AppImage/received_events","type":"Organization","site_admin":false},"repo":{"id":145175345,"node_id":"MDEwOlJlcG9zaXRvcnkxNDUxNzUzNDU=","name":"libappimage","full_name":"AppImage/libappimage","private":false,"owner":{"login":"AppImage","id":16617932,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NjE3OTMy","avatar_url":"https://avatars0.githubusercontent.com/u/16617932?v=4","gravatar_id":"","url":"https://api.github.com/users/AppImage","html_url":"https://github.com/AppImage","followers_url":"https://api.github.com/users/AppImage/followers","following_url":"https://api.github.com/users/AppImage/following{/other_user}","gists_url":"https://api.github.com/users/AppImage/gists{/gist_id}","starred_url":"https://api.github.com/users/AppImage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AppImage/subscriptions","organizations_url":"https://api.github.com/users/AppImage/orgs","repos_url":"https://api.github.com/users/AppImage/repos","events_url":"https://api.github.com/users/AppImage/events{/privacy}","received_events_url":"https://api.github.com/users/AppImage/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/AppImage/libappimage","description":"Core library of the AppImage project. Reference implementation of the AppImage specification.","fork":false,"url":"https://api.github.com/repos/AppImage/libappimage","forks_url":"https://api.github.com/repos/AppImage/libappimage/forks","keys_url":"https://api.github.com/repos/AppImage/libappimage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AppImage/libappimage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AppImage/libappimage/teams","hooks_url":"https://api.github.com/repos/AppImage/libappimage/hooks","issue_events_url":"https://api.github.com/repos/AppImage/libappimage/issues/events{/number}","events_url":"https://api.github.com/repos/AppImage/libappimage/events","assignees_url":"https://api.github.com/repos/AppImage/libappimage/assignees{/user}","branches_url":"https://api.github.com/repos/AppImage/libappimage/branches{/branch}","tags_url":"https://api.github.com/repos/AppImage/libappimage/tags","blobs_url":"https://api.github.com/repos/AppImage/libappimage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AppImage/libappimage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AppImage/libappimage/git/refs{/sha}","trees_url":"https://api.github.com/repos/AppImage/libappimage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AppImage/libappimage/statuses/{sha}","languages_url":"https://api.github.com/repos/AppImage/libappimage/languages","stargazers_url":"https://api.github.com/repos/AppImage/libappimage/stargazers","contributors_url":"https://api.github.com/repos/AppImage/libappimage/contributors","subscribers_url":"https://api.github.com/repos/AppImage/libappimage/subscribers","subscription_url":"https://api.github.com/repos/AppImage/libappimage/subscription","commits_url":"https://api.github.com/repos/AppImage/libappimage/commits{/sha}","git_commits_url":"https://api.github.com/repos/AppImage/libappimage/git/commits{/sha}","comments_url":"https://api.github.com/repos/AppImage/libappimage/comments{/number}","issue_comment_url":"https://api.github.com/repos/AppImage/libappimage/issues/comments{/number}","contents_url":"https://api.github.com/repos/AppImage/libappimage/contents/{+path}","compare_url":"https://api.github.com/repos/AppImage/libappimage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AppImage/libappimage/merges","archive_url":"https://api.github.com/repos/AppImage/libappimage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AppImage/libappimage/downloads","issues_url":"https://api.github.com/repos/AppImage/libappimage/issues{/number}","pulls_url":"https://api.github.com/repos/AppImage/libappimage/pulls{/number}","milestones_url":"https://api.github.com/repos/AppImage/libappimage/milestones{/number}","notifications_url":"https://api.github.com/repos/AppImage/libappimage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AppImage/libappimage/labels{/name}","releases_url":"https://api.github.com/repos/AppImage/libappimage/releases{/id}","deployments_url":"https://api.github.com/repos/AppImage/libappimage/deployments","created_at":"2018-08-17T23:42:06Z","updated_at":"2018-11-01T14:55:16Z","pushed_at":"2018-11-06T04:40:28Z","git_url":"git://github.com/AppImage/libappimage.git","ssh_url":"git@github.com:AppImage/libappimage.git","clone_url":"https://github.com/AppImage/libappimage.git","svn_url":"https://github.com/AppImage/libappimage","homepage":"https://appimage.org","size":1541,"stargazers_count":3,"watchers_count":3,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":0,"open_issues":5,"watchers":3,"default_branch":"master"}},"base":{"label":"AppImage:master","ref":"master","sha":"9047dfcbcdee417d84e7d32d70352dcc9e47cd70","user":{"login":"AppImage","id":16617932,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NjE3OTMy","avatar_url":"https://avatars0.githubusercontent.com/u/16617932?v=4","gravatar_id":"","url":"https://api.github.com/users/AppImage","html_url":"https://github.com/AppImage","followers_url":"https://api.github.com/users/AppImage/followers","following_url":"https://api.github.com/users/AppImage/following{/other_user}","gists_url":"https://api.github.com/users/AppImage/gists{/gist_id}","starred_url":"https://api.github.com/users/AppImage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AppImage/subscriptions","organizations_url":"https://api.github.com/users/AppImage/orgs","repos_url":"https://api.github.com/users/AppImage/repos","events_url":"https://api.github.com/users/AppImage/events{/privacy}","received_events_url":"https://api.github.com/users/AppImage/received_events","type":"Organization","site_admin":false},"repo":{"id":145175345,"node_id":"MDEwOlJlcG9zaXRvcnkxNDUxNzUzNDU=","name":"libappimage","full_name":"AppImage/libappimage","private":false,"owner":{"login":"AppImage","id":16617932,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NjE3OTMy","avatar_url":"https://avatars0.githubusercontent.com/u/16617932?v=4","gravatar_id":"","url":"https://api.github.com/users/AppImage","html_url":"https://github.com/AppImage","followers_url":"https://api.github.com/users/AppImage/followers","following_url":"https://api.github.com/users/AppImage/following{/other_user}","gists_url":"https://api.github.com/users/AppImage/gists{/gist_id}","starred_url":"https://api.github.com/users/AppImage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AppImage/subscriptions","organizations_url":"https://api.github.com/users/AppImage/orgs","repos_url":"https://api.github.com/users/AppImage/repos","events_url":"https://api.github.com/users/AppImage/events{/privacy}","received_events_url":"https://api.github.com/users/AppImage/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/AppImage/libappimage","description":"Core library of the AppImage project. Reference implementation of the AppImage specification.","fork":false,"url":"https://api.github.com/repos/AppImage/libappimage","forks_url":"https://api.github.com/repos/AppImage/libappimage/forks","keys_url":"https://api.github.com/repos/AppImage/libappimage/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AppImage/libappimage/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AppImage/libappimage/teams","hooks_url":"https://api.github.com/repos/AppImage/libappimage/hooks","issue_events_url":"https://api.github.com/repos/AppImage/libappimage/issues/events{/number}","events_url":"https://api.github.com/repos/AppImage/libappimage/events","assignees_url":"https://api.github.com/repos/AppImage/libappimage/assignees{/user}","branches_url":"https://api.github.com/repos/AppImage/libappimage/branches{/branch}","tags_url":"https://api.github.com/repos/AppImage/libappimage/tags","blobs_url":"https://api.github.com/repos/AppImage/libappimage/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AppImage/libappimage/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AppImage/libappimage/git/refs{/sha}","trees_url":"https://api.github.com/repos/AppImage/libappimage/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AppImage/libappimage/statuses/{sha}","languages_url":"https://api.github.com/repos/AppImage/libappimage/languages","stargazers_url":"https://api.github.com/repos/AppImage/libappimage/stargazers","contributors_url":"https://api.github.com/repos/AppImage/libappimage/contributors","subscribers_url":"https://api.github.com/repos/AppImage/libappimage/subscribers","subscription_url":"https://api.github.com/repos/AppImage/libappimage/subscription","commits_url":"https://api.github.com/repos/AppImage/libappimage/commits{/sha}","git_commits_url":"https://api.github.com/repos/AppImage/libappimage/git/commits{/sha}","comments_url":"https://api.github.com/repos/AppImage/libappimage/comments{/number}","issue_comment_url":"https://api.github.com/repos/AppImage/libappimage/issues/comments{/number}","contents_url":"https://api.github.com/repos/AppImage/libappimage/contents/{+path}","compare_url":"https://api.github.com/repos/AppImage/libappimage/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AppImage/libappimage/merges","archive_url":"https://api.github.com/repos/AppImage/libappimage/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AppImage/libappimage/downloads","issues_url":"https://api.github.com/repos/AppImage/libappimage/issues{/number}","pulls_url":"https://api.github.com/repos/AppImage/libappimage/pulls{/number}","milestones_url":"https://api.github.com/repos/AppImage/libappimage/milestones{/number}","notifications_url":"https://api.github.com/repos/AppImage/libappimage/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AppImage/libappimage/labels{/name}","releases_url":"https://api.github.com/repos/AppImage/libappimage/releases{/id}","deployments_url":"https://api.github.com/repos/AppImage/libappimage/deployments","created_at":"2018-08-17T23:42:06Z","updated_at":"2018-11-01T14:55:16Z","pushed_at":"2018-11-06T04:40:28Z","git_url":"git://github.com/AppImage/libappimage.git","ssh_url":"git@github.com:AppImage/libappimage.git","clone_url":"https://github.com/AppImage/libappimage.git","svn_url":"https://github.com/AppImage/libappimage","homepage":"https://appimage.org","size":1541,"stargazers_count":3,"watchers_count":3,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":0,"open_issues":5,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AppImage/libappimage/pulls/14"},"html":{"href":"https://github.com/AppImage/libappimage/pull/14"},"issue":{"href":"https://api.github.com/repos/AppImage/libappimage/issues/14"},"comments":{"href":"https://api.github.com/repos/AppImage/libappimage/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/AppImage/libappimage/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/AppImage/libappimage/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AppImage/libappimage/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/AppImage/libappimage/statuses/22dde049fa603b0626c4620931aa526f957612de"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"azubieta"}}