{"action":"created","comment":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/194064194","pull_request_review_id":127169957,"id":194064194,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDA2NDE5NA==","diff_hunk":"@@ -270,37 +271,27 @@ std::vector<std::pair<int, int> > GEMSimpleModel::simulateClustering(const GEMEt\n \t\t\t\t\t\t\t\t     const PSimHit* simHit, const int bx, \n \t\t\t\t\t\t\t\t     CLHEP::HepRandomEngine* engine)\n {\n-  const StripTopology& topology = roll->specificTopology(); // const LocalPoint& entry(simHit->entryPoint());\n-  const LocalPoint& hit_position(simHit->localPosition());\n-  const int nstrips(roll->nstrips());\n-  int centralStrip = 0;\n-  if (!(topology.channel(hit_position) + 1 > nstrips))\n-    centralStrip = topology.channel(hit_position) + 1;\n-  else\n-    centralStrip = topology.channel(hit_position);\n-  const GlobalPoint& pointSimHit = roll->toGlobal(hit_position);\n-  const GlobalPoint& pointDigiHit = roll->toGlobal(roll->centreOfStrip(centralStrip));\n-  double deltaX = pointSimHit.x() - pointDigiHit.x();\n+  const LocalPoint& hit_entry(simHit->entryPoint());\n+  const LocalPoint& hit_exit(simHit->exitPoint());\n+\n+  float hit_entry_smeardX = hit_entry.x()-fabs(CLHEP::RandGaussQ::shoot(0, resolutionX_));","path":"SimMuon/GEMDigitizer/src/GEMSimpleModel.cc","position":null,"original_position":26,"commit_id":"9515e12e705c9c047e5b33e315bfb36f3ab4865d","original_commit_id":"9e1e0c5e99b4361e614f1c715d944bcae0b9bdae","user":{"login":"tt8888tt","id":8747087,"node_id":"MDQ6VXNlcjg3NDcwODc=","avatar_url":"https://avatars3.githubusercontent.com/u/8747087?v=4","gravatar_id":"","url":"https://api.github.com/users/tt8888tt","html_url":"https://github.com/tt8888tt","followers_url":"https://api.github.com/users/tt8888tt/followers","following_url":"https://api.github.com/users/tt8888tt/following{/other_user}","gists_url":"https://api.github.com/users/tt8888tt/gists{/gist_id}","starred_url":"https://api.github.com/users/tt8888tt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tt8888tt/subscriptions","organizations_url":"https://api.github.com/users/tt8888tt/orgs","repos_url":"https://api.github.com/users/tt8888tt/repos","events_url":"https://api.github.com/users/tt8888tt/events{/privacy}","received_events_url":"https://api.github.com/users/tt8888tt/received_events","type":"User","site_admin":false},"body":"I've fixed and pushed","created_at":"2018-06-08T13:52:55Z","updated_at":"2018-06-08T13:52:55Z","html_url":"https://github.com/cms-sw/cmssw/pull/23530#discussion_r194064194","pull_request_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/23530","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments/194064194"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/23530#discussion_r194064194"},"pull_request":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/23530"}},"in_reply_to_id":194057085},"pull_request":{"url":"https://api.github.com/repos/cms-sw/cmssw/pulls/23530","id":193611869,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNjExODY5","html_url":"https://github.com/cms-sw/cmssw/pull/23530","diff_url":"https://github.com/cms-sw/cmssw/pull/23530.diff","patch_url":"https://github.com/cms-sw/cmssw/pull/23530.patch","issue_url":"https://api.github.com/repos/cms-sw/cmssw/issues/23530","number":23530,"state":"open","locked":false,"title":"GEM realistic digitiser","user":{"login":"tt8888tt","id":8747087,"node_id":"MDQ6VXNlcjg3NDcwODc=","avatar_url":"https://avatars3.githubusercontent.com/u/8747087?v=4","gravatar_id":"","url":"https://api.github.com/users/tt8888tt","html_url":"https://github.com/tt8888tt","followers_url":"https://api.github.com/users/tt8888tt/followers","following_url":"https://api.github.com/users/tt8888tt/following{/other_user}","gists_url":"https://api.github.com/users/tt8888tt/gists{/gist_id}","starred_url":"https://api.github.com/users/tt8888tt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tt8888tt/subscriptions","organizations_url":"https://api.github.com/users/tt8888tt/orgs","repos_url":"https://api.github.com/users/tt8888tt/repos","events_url":"https://api.github.com/users/tt8888tt/events{/privacy}","received_events_url":"https://api.github.com/users/tt8888tt/received_events","type":"User","site_admin":false},"body":"Update of the GEM digitiser\r\nMore realistic digi cluster distribution matching test beam results.\r\nhttps://indico.cern.ch/event/734135/contributions/3027758/attachments/1663982/2667113/rechit_cluster_size_per_ieta.pdf\r\n\r\n@jshlee \r\n","created_at":"2018-06-08T13:20:04Z","updated_at":"2018-06-08T13:52:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c90ae7c7f1b53a69bb7333cb989694a06e2fa7f5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":673935047,"node_id":"MDU6TGFiZWw2NzM5MzUwNDc=","url":"https://api.github.com/repos/cms-sw/cmssw/labels/code-checks-approved","name":"code-checks-approved","color":"2cbe4e","default":false},{"id":88653795,"node_id":"MDU6TGFiZWw4ODY1Mzc5NQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/comparison-pending","name":"comparison-pending","color":"fbca04","default":false},{"id":56953091,"node_id":"MDU6TGFiZWw1Njk1MzA5MQ==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/orp-pending","name":"orp-pending","color":"fbca04","default":false},{"id":53167770,"node_id":"MDU6TGFiZWw1MzE2Nzc3MA==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/pending-signatures","name":"pending-signatures","color":"ff8000","default":false},{"id":52820523,"node_id":"MDU6TGFiZWw1MjgyMDUyMw==","url":"https://api.github.com/repos/cms-sw/cmssw/labels/simulation-pending","name":"simulation-pending","color":"fbca04","default":false},{"id":170521617,"node_id":"MDU6TGFiZWwxNzA1MjE2MTc=","url":"https://api.github.com/repos/cms-sw/cmssw/labels/tests-started","name":"tests-started","color":"ff8000","default":false},{"id":530655448,"node_id":"MDU6TGFiZWw1MzA2NTU0NDg=","url":"https://api.github.com/repos/cms-sw/cmssw/labels/upgrade-pending","name":"upgrade-pending","color":"fbca04","default":false}],"milestone":{"url":"https://api.github.com/repos/cms-sw/cmssw/milestones/76","html_url":"https://github.com/cms-sw/cmssw/milestone/76","labels_url":"https://api.github.com/repos/cms-sw/cmssw/milestones/76/labels","id":3227631,"node_id":"MDk6TWlsZXN0b25lMzIyNzYzMQ==","number":76,"title":"CMSSW_10_2_X","description":null,"creator":{"login":"smuzaffar","id":4115138,"node_id":"MDQ6VXNlcjQxMTUxMzg=","avatar_url":"https://avatars3.githubusercontent.com/u/4115138?v=4","gravatar_id":"","url":"https://api.github.com/users/smuzaffar","html_url":"https://github.com/smuzaffar","followers_url":"https://api.github.com/users/smuzaffar/followers","following_url":"https://api.github.com/users/smuzaffar/following{/other_user}","gists_url":"https://api.github.com/users/smuzaffar/gists{/gist_id}","starred_url":"https://api.github.com/users/smuzaffar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smuzaffar/subscriptions","organizations_url":"https://api.github.com/users/smuzaffar/orgs","repos_url":"https://api.github.com/users/smuzaffar/repos","events_url":"https://api.github.com/users/smuzaffar/events{/privacy}","received_events_url":"https://api.github.com/users/smuzaffar/received_events","type":"User","site_admin":false},"open_issues":52,"closed_issues":536,"state":"open","created_at":"2018-03-29T07:57:10Z","updated_at":"2018-06-08T13:20:18Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/23530/commits","review_comments_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/23530/comments","review_comment_url":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/issues/23530/comments","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/9515e12e705c9c047e5b33e315bfb36f3ab4865d","head":{"label":"tt8888tt:gemDigitser10x","ref":"gemDigitser10x","sha":"9515e12e705c9c047e5b33e315bfb36f3ab4865d","user":{"login":"tt8888tt","id":8747087,"node_id":"MDQ6VXNlcjg3NDcwODc=","avatar_url":"https://avatars3.githubusercontent.com/u/8747087?v=4","gravatar_id":"","url":"https://api.github.com/users/tt8888tt","html_url":"https://github.com/tt8888tt","followers_url":"https://api.github.com/users/tt8888tt/followers","following_url":"https://api.github.com/users/tt8888tt/following{/other_user}","gists_url":"https://api.github.com/users/tt8888tt/gists{/gist_id}","starred_url":"https://api.github.com/users/tt8888tt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tt8888tt/subscriptions","organizations_url":"https://api.github.com/users/tt8888tt/orgs","repos_url":"https://api.github.com/users/tt8888tt/repos","events_url":"https://api.github.com/users/tt8888tt/events{/privacy}","received_events_url":"https://api.github.com/users/tt8888tt/received_events","type":"User","site_admin":false},"repo":{"id":136604909,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY2MDQ5MDk=","name":"cmssw","full_name":"tt8888tt/cmssw","owner":{"login":"tt8888tt","id":8747087,"node_id":"MDQ6VXNlcjg3NDcwODc=","avatar_url":"https://avatars3.githubusercontent.com/u/8747087?v=4","gravatar_id":"","url":"https://api.github.com/users/tt8888tt","html_url":"https://github.com/tt8888tt","followers_url":"https://api.github.com/users/tt8888tt/followers","following_url":"https://api.github.com/users/tt8888tt/following{/other_user}","gists_url":"https://api.github.com/users/tt8888tt/gists{/gist_id}","starred_url":"https://api.github.com/users/tt8888tt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tt8888tt/subscriptions","organizations_url":"https://api.github.com/users/tt8888tt/orgs","repos_url":"https://api.github.com/users/tt8888tt/repos","events_url":"https://api.github.com/users/tt8888tt/events{/privacy}","received_events_url":"https://api.github.com/users/tt8888tt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tt8888tt/cmssw","description":"CMS Offline Software","fork":true,"url":"https://api.github.com/repos/tt8888tt/cmssw","forks_url":"https://api.github.com/repos/tt8888tt/cmssw/forks","keys_url":"https://api.github.com/repos/tt8888tt/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tt8888tt/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tt8888tt/cmssw/teams","hooks_url":"https://api.github.com/repos/tt8888tt/cmssw/hooks","issue_events_url":"https://api.github.com/repos/tt8888tt/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/tt8888tt/cmssw/events","assignees_url":"https://api.github.com/repos/tt8888tt/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/tt8888tt/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/tt8888tt/cmssw/tags","blobs_url":"https://api.github.com/repos/tt8888tt/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tt8888tt/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tt8888tt/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/tt8888tt/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tt8888tt/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/tt8888tt/cmssw/languages","stargazers_url":"https://api.github.com/repos/tt8888tt/cmssw/stargazers","contributors_url":"https://api.github.com/repos/tt8888tt/cmssw/contributors","subscribers_url":"https://api.github.com/repos/tt8888tt/cmssw/subscribers","subscription_url":"https://api.github.com/repos/tt8888tt/cmssw/subscription","commits_url":"https://api.github.com/repos/tt8888tt/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/tt8888tt/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/tt8888tt/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/tt8888tt/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/tt8888tt/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/tt8888tt/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tt8888tt/cmssw/merges","archive_url":"https://api.github.com/repos/tt8888tt/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tt8888tt/cmssw/downloads","issues_url":"https://api.github.com/repos/tt8888tt/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/tt8888tt/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/tt8888tt/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/tt8888tt/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tt8888tt/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/tt8888tt/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/tt8888tt/cmssw/deployments","created_at":"2018-06-08T10:32:44Z","updated_at":"2018-06-08T10:35:10Z","pushed_at":"2018-06-08T13:42:36Z","git_url":"git://github.com/tt8888tt/cmssw.git","ssh_url":"git@github.com:tt8888tt/cmssw.git","clone_url":"https://github.com/tt8888tt/cmssw.git","svn_url":"https://github.com/tt8888tt/cmssw","homepage":"http://cms-sw.github.io/","size":1002908,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cms-sw:master","ref":"master","sha":"4696340fbef11fc757767e002a4df2aa9ae36c5e","user":{"login":"cms-sw","id":3863500,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NjM1MDA=","avatar_url":"https://avatars0.githubusercontent.com/u/3863500?v=4","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"repo":{"id":10969551,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk2OTU1MQ==","name":"cmssw","full_name":"cms-sw/cmssw","owner":{"login":"cms-sw","id":3863500,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4NjM1MDA=","avatar_url":"https://avatars0.githubusercontent.com/u/3863500?v=4","gravatar_id":"","url":"https://api.github.com/users/cms-sw","html_url":"https://github.com/cms-sw","followers_url":"https://api.github.com/users/cms-sw/followers","following_url":"https://api.github.com/users/cms-sw/following{/other_user}","gists_url":"https://api.github.com/users/cms-sw/gists{/gist_id}","starred_url":"https://api.github.com/users/cms-sw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cms-sw/subscriptions","organizations_url":"https://api.github.com/users/cms-sw/orgs","repos_url":"https://api.github.com/users/cms-sw/repos","events_url":"https://api.github.com/users/cms-sw/events{/privacy}","received_events_url":"https://api.github.com/users/cms-sw/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cms-sw/cmssw","description":"CMS Offline Software","fork":false,"url":"https://api.github.com/repos/cms-sw/cmssw","forks_url":"https://api.github.com/repos/cms-sw/cmssw/forks","keys_url":"https://api.github.com/repos/cms-sw/cmssw/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cms-sw/cmssw/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cms-sw/cmssw/teams","hooks_url":"https://api.github.com/repos/cms-sw/cmssw/hooks","issue_events_url":"https://api.github.com/repos/cms-sw/cmssw/issues/events{/number}","events_url":"https://api.github.com/repos/cms-sw/cmssw/events","assignees_url":"https://api.github.com/repos/cms-sw/cmssw/assignees{/user}","branches_url":"https://api.github.com/repos/cms-sw/cmssw/branches{/branch}","tags_url":"https://api.github.com/repos/cms-sw/cmssw/tags","blobs_url":"https://api.github.com/repos/cms-sw/cmssw/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cms-sw/cmssw/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cms-sw/cmssw/git/refs{/sha}","trees_url":"https://api.github.com/repos/cms-sw/cmssw/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cms-sw/cmssw/statuses/{sha}","languages_url":"https://api.github.com/repos/cms-sw/cmssw/languages","stargazers_url":"https://api.github.com/repos/cms-sw/cmssw/stargazers","contributors_url":"https://api.github.com/repos/cms-sw/cmssw/contributors","subscribers_url":"https://api.github.com/repos/cms-sw/cmssw/subscribers","subscription_url":"https://api.github.com/repos/cms-sw/cmssw/subscription","commits_url":"https://api.github.com/repos/cms-sw/cmssw/commits{/sha}","git_commits_url":"https://api.github.com/repos/cms-sw/cmssw/git/commits{/sha}","comments_url":"https://api.github.com/repos/cms-sw/cmssw/comments{/number}","issue_comment_url":"https://api.github.com/repos/cms-sw/cmssw/issues/comments{/number}","contents_url":"https://api.github.com/repos/cms-sw/cmssw/contents/{+path}","compare_url":"https://api.github.com/repos/cms-sw/cmssw/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cms-sw/cmssw/merges","archive_url":"https://api.github.com/repos/cms-sw/cmssw/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cms-sw/cmssw/downloads","issues_url":"https://api.github.com/repos/cms-sw/cmssw/issues{/number}","pulls_url":"https://api.github.com/repos/cms-sw/cmssw/pulls{/number}","milestones_url":"https://api.github.com/repos/cms-sw/cmssw/milestones{/number}","notifications_url":"https://api.github.com/repos/cms-sw/cmssw/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cms-sw/cmssw/labels{/name}","releases_url":"https://api.github.com/repos/cms-sw/cmssw/releases{/id}","deployments_url":"https://api.github.com/repos/cms-sw/cmssw/deployments","created_at":"2013-06-26T14:09:07Z","updated_at":"2018-06-08T08:18:11Z","pushed_at":"2018-06-08T13:42:42Z","git_url":"git://github.com/cms-sw/cmssw.git","ssh_url":"git@github.com:cms-sw/cmssw.git","clone_url":"https://github.com/cms-sw/cmssw.git","svn_url":"https://github.com/cms-sw/cmssw","homepage":"http://cms-sw.github.io/","size":1004197,"stargazers_count":556,"watchers_count":556,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2588,"mirror_url":null,"archived":false,"open_issues_count":454,"license":null,"forks":2588,"open_issues":454,"watchers":556,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/23530"},"html":{"href":"https://github.com/cms-sw/cmssw/pull/23530"},"issue":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/23530"},"comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/issues/23530/comments"},"review_comments":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/23530/comments"},"review_comment":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cms-sw/cmssw/pulls/23530/commits"},"statuses":{"href":"https://api.github.com/repos/cms-sw/cmssw/statuses/9515e12e705c9c047e5b33e315bfb36f3ab4865d"}},"author_association":"NONE"}}
{"actor":{"display_login":"tt8888tt"}}