{"action":"created","comment":{"url":"https://api.github.com/repos/platform9/qbertconfig/pulls/comments/232898065","pull_request_review_id":174191339,"id":232898065,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjg5ODA2NQ==","diff_hunk":"@@ -15,18 +15,21 @@\n import sys\n import argparse\n import logging\n-import os_client_config\n+import openstack\n from keystoneauth1.exceptions import MissingRequiredOptions\n \n # local imports\n-from qbertconfig.Kubeconfig import Kubeconfig\n+from qbertconfig.QbertConfig import QbertConfig","path":"qbertconfig/cli/main.py","position":10,"original_position":10,"commit_id":"967090a208bbf6fdcd22c70d99e69aa2b51db972","original_commit_id":"967090a208bbf6fdcd22c70d99e69aa2b51db972","user":{"login":"agrahamlincoln","id":8289990,"node_id":"MDQ6VXNlcjgyODk5OTA=","avatar_url":"https://avatars3.githubusercontent.com/u/8289990?v=4","gravatar_id":"","url":"https://api.github.com/users/agrahamlincoln","html_url":"https://github.com/agrahamlincoln","followers_url":"https://api.github.com/users/agrahamlincoln/followers","following_url":"https://api.github.com/users/agrahamlincoln/following{/other_user}","gists_url":"https://api.github.com/users/agrahamlincoln/gists{/gist_id}","starred_url":"https://api.github.com/users/agrahamlincoln/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/agrahamlincoln/subscriptions","organizations_url":"https://api.github.com/users/agrahamlincoln/orgs","repos_url":"https://api.github.com/users/agrahamlincoln/repos","events_url":"https://api.github.com/users/agrahamlincoln/events{/privacy}","received_events_url":"https://api.github.com/users/agrahamlincoln/received_events","type":"User","site_admin":false},"body":"Nice! Two birds one stone","created_at":"2018-11-13T05:02:51Z","updated_at":"2018-11-13T05:14:09Z","html_url":"https://github.com/platform9/qbertconfig/pull/10#discussion_r232898065","pull_request_url":"https://api.github.com/repos/platform9/qbertconfig/pulls/10","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/platform9/qbertconfig/pulls/comments/232898065"},"html":{"href":"https://github.com/platform9/qbertconfig/pull/10#discussion_r232898065"},"pull_request":{"href":"https://api.github.com/repos/platform9/qbertconfig/pulls/10"}}},"pull_request":{"url":"https://api.github.com/repos/platform9/qbertconfig/pulls/10","id":230338509,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMzM4NTA5","html_url":"https://github.com/platform9/qbertconfig/pull/10","diff_url":"https://github.com/platform9/qbertconfig/pull/10.diff","patch_url":"https://github.com/platform9/qbertconfig/pull/10.patch","issue_url":"https://api.github.com/repos/platform9/qbertconfig/issues/10","number":10,"state":"open","locked":false,"title":"Separate QbertClient and Kubeconfig from each other","user":{"login":"CamelCaseNotation","id":3120774,"node_id":"MDQ6VXNlcjMxMjA3NzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/3120774?v=4","gravatar_id":"","url":"https://api.github.com/users/CamelCaseNotation","html_url":"https://github.com/CamelCaseNotation","followers_url":"https://api.github.com/users/CamelCaseNotation/followers","following_url":"https://api.github.com/users/CamelCaseNotation/following{/other_user}","gists_url":"https://api.github.com/users/CamelCaseNotation/gists{/gist_id}","starred_url":"https://api.github.com/users/CamelCaseNotation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CamelCaseNotation/subscriptions","organizations_url":"https://api.github.com/users/CamelCaseNotation/orgs","repos_url":"https://api.github.com/users/CamelCaseNotation/repos","events_url":"https://api.github.com/users/CamelCaseNotation/events{/privacy}","received_events_url":"https://api.github.com/users/CamelCaseNotation/received_events","type":"User","site_admin":false},"body":"Remove use of QbertClient within any methods of Kubeconfig.\r\n\r\nCreate new QbertConfig class which accepts a cloud object, or creates\r\none if one isn't given. The cloud object that's created follows the\r\ntypical openstacksdk ordering for loading credentials.\r\n\r\nCLI entrypoint uses QbertConfig module\r\n\r\nMaybe move QbertConfig class into 'qbertconfig' dir's __init__??","created_at":"2018-11-13T03:43:05Z","updated_at":"2018-11-13T05:14:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ee6c210f74786368bd45f43f7d5e42d3c249f223","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/platform9/qbertconfig/pulls/10/commits","review_comments_url":"https://api.github.com/repos/platform9/qbertconfig/pulls/10/comments","review_comment_url":"https://api.github.com/repos/platform9/qbertconfig/pulls/comments{/number}","comments_url":"https://api.github.com/repos/platform9/qbertconfig/issues/10/comments","statuses_url":"https://api.github.com/repos/platform9/qbertconfig/statuses/967090a208bbf6fdcd22c70d99e69aa2b51db972","head":{"label":"CamelCaseNotation:master","ref":"master","sha":"967090a208bbf6fdcd22c70d99e69aa2b51db972","user":{"login":"CamelCaseNotation","id":3120774,"node_id":"MDQ6VXNlcjMxMjA3NzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/3120774?v=4","gravatar_id":"","url":"https://api.github.com/users/CamelCaseNotation","html_url":"https://github.com/CamelCaseNotation","followers_url":"https://api.github.com/users/CamelCaseNotation/followers","following_url":"https://api.github.com/users/CamelCaseNotation/following{/other_user}","gists_url":"https://api.github.com/users/CamelCaseNotation/gists{/gist_id}","starred_url":"https://api.github.com/users/CamelCaseNotation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CamelCaseNotation/subscriptions","organizations_url":"https://api.github.com/users/CamelCaseNotation/orgs","repos_url":"https://api.github.com/users/CamelCaseNotation/repos","events_url":"https://api.github.com/users/CamelCaseNotation/events{/privacy}","received_events_url":"https://api.github.com/users/CamelCaseNotation/received_events","type":"User","site_admin":false},"repo":{"id":157263158,"node_id":"MDEwOlJlcG9zaXRvcnkxNTcyNjMxNTg=","name":"qbertconfig","full_name":"CamelCaseNotation/qbertconfig","private":false,"owner":{"login":"CamelCaseNotation","id":3120774,"node_id":"MDQ6VXNlcjMxMjA3NzQ=","avatar_url":"https://avatars0.githubusercontent.com/u/3120774?v=4","gravatar_id":"","url":"https://api.github.com/users/CamelCaseNotation","html_url":"https://github.com/CamelCaseNotation","followers_url":"https://api.github.com/users/CamelCaseNotation/followers","following_url":"https://api.github.com/users/CamelCaseNotation/following{/other_user}","gists_url":"https://api.github.com/users/CamelCaseNotation/gists{/gist_id}","starred_url":"https://api.github.com/users/CamelCaseNotation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CamelCaseNotation/subscriptions","organizations_url":"https://api.github.com/users/CamelCaseNotation/orgs","repos_url":"https://api.github.com/users/CamelCaseNotation/repos","events_url":"https://api.github.com/users/CamelCaseNotation/events{/privacy}","received_events_url":"https://api.github.com/users/CamelCaseNotation/received_events","type":"User","site_admin":false},"html_url":"https://github.com/CamelCaseNotation/qbertconfig","description":"Fetches kubeconfig from qbert API","fork":true,"url":"https://api.github.com/repos/CamelCaseNotation/qbertconfig","forks_url":"https://api.github.com/repos/CamelCaseNotation/qbertconfig/forks","keys_url":"https://api.github.com/repos/CamelCaseNotation/qbertconfig/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CamelCaseNotation/qbertconfig/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CamelCaseNotation/qbertconfig/teams","hooks_url":"https://api.github.com/repos/CamelCaseNotation/qbertconfig/hooks","issue_events_url":"https://api.github.com/repos/CamelCaseNotation/qbertconfig/issues/events{/number}","events_url":"https://api.github.com/repos/CamelCaseNotation/qbertconfig/events","assignees_url":"https://api.github.com/repos/CamelCaseNotation/qbertconfig/assignees{/user}","branches_url":"https://api.github.com/repos/CamelCaseNotation/qbertconfig/branches{/branch}","tags_url":"https://api.github.com/repos/CamelCaseNotation/qbertconfig/tags","blobs_url":"https://api.github.com/repos/CamelCaseNotation/qbertconfig/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CamelCaseNotation/qbertconfig/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CamelCaseNotation/qbertconfig/git/refs{/sha}","trees_url":"https://api.github.com/repos/CamelCaseNotation/qbertconfig/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CamelCaseNotation/qbertconfig/statuses/{sha}","languages_url":"https://api.github.com/repos/CamelCaseNotation/qbertconfig/languages","stargazers_url":"https://api.github.com/repos/CamelCaseNotation/qbertconfig/stargazers","contributors_url":"https://api.github.com/repos/CamelCaseNotation/qbertconfig/contributors","subscribers_url":"https://api.github.com/repos/CamelCaseNotation/qbertconfig/subscribers","subscription_url":"https://api.github.com/repos/CamelCaseNotation/qbertconfig/subscription","commits_url":"https://api.github.com/repos/CamelCaseNotation/qbertconfig/commits{/sha}","git_commits_url":"https://api.github.com/repos/CamelCaseNotation/qbertconfig/git/commits{/sha}","comments_url":"https://api.github.com/repos/CamelCaseNotation/qbertconfig/comments{/number}","issue_comment_url":"https://api.github.com/repos/CamelCaseNotation/qbertconfig/issues/comments{/number}","contents_url":"https://api.github.com/repos/CamelCaseNotation/qbertconfig/contents/{+path}","compare_url":"https://api.github.com/repos/CamelCaseNotation/qbertconfig/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CamelCaseNotation/qbertconfig/merges","archive_url":"https://api.github.com/repos/CamelCaseNotation/qbertconfig/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CamelCaseNotation/qbertconfig/downloads","issues_url":"https://api.github.com/repos/CamelCaseNotation/qbertconfig/issues{/number}","pulls_url":"https://api.github.com/repos/CamelCaseNotation/qbertconfig/pulls{/number}","milestones_url":"https://api.github.com/repos/CamelCaseNotation/qbertconfig/milestones{/number}","notifications_url":"https://api.github.com/repos/CamelCaseNotation/qbertconfig/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CamelCaseNotation/qbertconfig/labels{/name}","releases_url":"https://api.github.com/repos/CamelCaseNotation/qbertconfig/releases{/id}","deployments_url":"https://api.github.com/repos/CamelCaseNotation/qbertconfig/deployments","created_at":"2018-11-12T19:12:57Z","updated_at":"2018-11-13T04:46:06Z","pushed_at":"2018-11-13T04:46:04Z","git_url":"git://github.com/CamelCaseNotation/qbertconfig.git","ssh_url":"git@github.com:CamelCaseNotation/qbertconfig.git","clone_url":"https://github.com/CamelCaseNotation/qbertconfig.git","svn_url":"https://github.com/CamelCaseNotation/qbertconfig","homepage":null,"size":54,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"platform9:master","ref":"master","sha":"e3f6fe4064a0e2418cca9f6f0958849f4645124e","user":{"login":"platform9","id":2824585,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MjQ1ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/2824585?v=4","gravatar_id":"","url":"https://api.github.com/users/platform9","html_url":"https://github.com/platform9","followers_url":"https://api.github.com/users/platform9/followers","following_url":"https://api.github.com/users/platform9/following{/other_user}","gists_url":"https://api.github.com/users/platform9/gists{/gist_id}","starred_url":"https://api.github.com/users/platform9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/platform9/subscriptions","organizations_url":"https://api.github.com/users/platform9/orgs","repos_url":"https://api.github.com/users/platform9/repos","events_url":"https://api.github.com/users/platform9/events{/privacy}","received_events_url":"https://api.github.com/users/platform9/received_events","type":"Organization","site_admin":false},"repo":{"id":155939520,"node_id":"MDEwOlJlcG9zaXRvcnkxNTU5Mzk1MjA=","name":"qbertconfig","full_name":"platform9/qbertconfig","private":false,"owner":{"login":"platform9","id":2824585,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4MjQ1ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/2824585?v=4","gravatar_id":"","url":"https://api.github.com/users/platform9","html_url":"https://github.com/platform9","followers_url":"https://api.github.com/users/platform9/followers","following_url":"https://api.github.com/users/platform9/following{/other_user}","gists_url":"https://api.github.com/users/platform9/gists{/gist_id}","starred_url":"https://api.github.com/users/platform9/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/platform9/subscriptions","organizations_url":"https://api.github.com/users/platform9/orgs","repos_url":"https://api.github.com/users/platform9/repos","events_url":"https://api.github.com/users/platform9/events{/privacy}","received_events_url":"https://api.github.com/users/platform9/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/platform9/qbertconfig","description":"Fetches kubeconfig from qbert API","fork":false,"url":"https://api.github.com/repos/platform9/qbertconfig","forks_url":"https://api.github.com/repos/platform9/qbertconfig/forks","keys_url":"https://api.github.com/repos/platform9/qbertconfig/keys{/key_id}","collaborators_url":"https://api.github.com/repos/platform9/qbertconfig/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/platform9/qbertconfig/teams","hooks_url":"https://api.github.com/repos/platform9/qbertconfig/hooks","issue_events_url":"https://api.github.com/repos/platform9/qbertconfig/issues/events{/number}","events_url":"https://api.github.com/repos/platform9/qbertconfig/events","assignees_url":"https://api.github.com/repos/platform9/qbertconfig/assignees{/user}","branches_url":"https://api.github.com/repos/platform9/qbertconfig/branches{/branch}","tags_url":"https://api.github.com/repos/platform9/qbertconfig/tags","blobs_url":"https://api.github.com/repos/platform9/qbertconfig/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/platform9/qbertconfig/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/platform9/qbertconfig/git/refs{/sha}","trees_url":"https://api.github.com/repos/platform9/qbertconfig/git/trees{/sha}","statuses_url":"https://api.github.com/repos/platform9/qbertconfig/statuses/{sha}","languages_url":"https://api.github.com/repos/platform9/qbertconfig/languages","stargazers_url":"https://api.github.com/repos/platform9/qbertconfig/stargazers","contributors_url":"https://api.github.com/repos/platform9/qbertconfig/contributors","subscribers_url":"https://api.github.com/repos/platform9/qbertconfig/subscribers","subscription_url":"https://api.github.com/repos/platform9/qbertconfig/subscription","commits_url":"https://api.github.com/repos/platform9/qbertconfig/commits{/sha}","git_commits_url":"https://api.github.com/repos/platform9/qbertconfig/git/commits{/sha}","comments_url":"https://api.github.com/repos/platform9/qbertconfig/comments{/number}","issue_comment_url":"https://api.github.com/repos/platform9/qbertconfig/issues/comments{/number}","contents_url":"https://api.github.com/repos/platform9/qbertconfig/contents/{+path}","compare_url":"https://api.github.com/repos/platform9/qbertconfig/compare/{base}...{head}","merges_url":"https://api.github.com/repos/platform9/qbertconfig/merges","archive_url":"https://api.github.com/repos/platform9/qbertconfig/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/platform9/qbertconfig/downloads","issues_url":"https://api.github.com/repos/platform9/qbertconfig/issues{/number}","pulls_url":"https://api.github.com/repos/platform9/qbertconfig/pulls{/number}","milestones_url":"https://api.github.com/repos/platform9/qbertconfig/milestones{/number}","notifications_url":"https://api.github.com/repos/platform9/qbertconfig/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/platform9/qbertconfig/labels{/name}","releases_url":"https://api.github.com/repos/platform9/qbertconfig/releases{/id}","deployments_url":"https://api.github.com/repos/platform9/qbertconfig/deployments","created_at":"2018-11-03T01:41:17Z","updated_at":"2018-11-13T01:37:53Z","pushed_at":"2018-11-13T04:46:05Z","git_url":"git://github.com/platform9/qbertconfig.git","ssh_url":"git@github.com:platform9/qbertconfig.git","clone_url":"https://github.com/platform9/qbertconfig.git","svn_url":"https://github.com/platform9/qbertconfig","homepage":null,"size":54,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":7,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/platform9/qbertconfig/pulls/10"},"html":{"href":"https://github.com/platform9/qbertconfig/pull/10"},"issue":{"href":"https://api.github.com/repos/platform9/qbertconfig/issues/10"},"comments":{"href":"https://api.github.com/repos/platform9/qbertconfig/issues/10/comments"},"review_comments":{"href":"https://api.github.com/repos/platform9/qbertconfig/pulls/10/comments"},"review_comment":{"href":"https://api.github.com/repos/platform9/qbertconfig/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/platform9/qbertconfig/pulls/10/commits"},"statuses":{"href":"https://api.github.com/repos/platform9/qbertconfig/statuses/967090a208bbf6fdcd22c70d99e69aa2b51db972"}},"author_association":"NONE"}}
{"actor":{"display_login":"agrahamlincoln"}}