{"action":"created","comment":{"url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/comments/235716661","pull_request_review_id":177645873,"id":235716661,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTcxNjY2MQ==","diff_hunk":"@@ -327,6 +327,7 @@ sub addboot {\n }\n \n sub select_first_hard_disk {\n+    return send_key $cmd{next} if (check_screen('select-hard-disks-one-selected', 0));\n     my $matched_needle = assert_screen [qw(existing-partitions hard-disk-dev-sdb-selected hard-disk-dev-non-sda-selected)];","path":"lib/partition_setup.pm","position":null,"original_position":5,"commit_id":"a32b1dbba5023a9168e1d2fa70f273e92feab3f3","original_commit_id":"a9a5fdc8d760194ef0f8f819853c2a65caa55da6","user":{"login":"jknphy","id":31735282,"node_id":"MDQ6VXNlcjMxNzM1Mjgy","avatar_url":"https://avatars0.githubusercontent.com/u/31735282?v=4","gravatar_id":"","url":"https://api.github.com/users/jknphy","html_url":"https://github.com/jknphy","followers_url":"https://api.github.com/users/jknphy/followers","following_url":"https://api.github.com/users/jknphy/following{/other_user}","gists_url":"https://api.github.com/users/jknphy/gists{/gist_id}","starred_url":"https://api.github.com/users/jknphy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jknphy/subscriptions","organizations_url":"https://api.github.com/users/jknphy/orgs","repos_url":"https://api.github.com/users/jknphy/repos","events_url":"https://api.github.com/users/jknphy/events{/privacy}","received_events_url":"https://api.github.com/users/jknphy/received_events","type":"User","site_admin":false},"body":"you're right, this two returns in the same function would not smell good neither, but in another subroutine should be better.","created_at":"2018-11-22T12:59:00Z","updated_at":"2018-11-22T12:59:00Z","html_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/6261#discussion_r235716661","pull_request_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/6261","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/comments/235716661"},"html":{"href":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/6261#discussion_r235716661"},"pull_request":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/6261"}},"in_reply_to_id":235676668},"pull_request":{"url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/6261","id":232887100,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyODg3MTAw","html_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/6261","diff_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/6261.diff","patch_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/6261.patch","issue_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/6261","number":6261,"state":"open","locked":false,"title":"Fix selection of first hd when pre-selected","user":{"login":"jknphy","id":31735282,"node_id":"MDQ6VXNlcjMxNzM1Mjgy","avatar_url":"https://avatars0.githubusercontent.com/u/31735282?v=4","gravatar_id":"","url":"https://api.github.com/users/jknphy","html_url":"https://github.com/jknphy","followers_url":"https://api.github.com/users/jknphy/followers","following_url":"https://api.github.com/users/jknphy/following{/other_user}","gists_url":"https://api.github.com/users/jknphy/gists{/gist_id}","starred_url":"https://api.github.com/users/jknphy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jknphy/subscriptions","organizations_url":"https://api.github.com/users/jknphy/orgs","repos_url":"https://api.github.com/users/jknphy/repos","events_url":"https://api.github.com/users/jknphy/events{/privacy}","received_events_url":"https://api.github.com/users/jknphy/received_events","type":"User","site_admin":false},"body":"In case the first disk is pre-selected (is the only one selected), skip the logic for deselection of the rest of hds.\r\n~Also increase timeout for ipmi due to partition proposal has change and it seems that we try to `check_screen` too fast.~ Agreed to pull out this for a better approach in future.\r\n\r\n- Related ticket: https://progress.opensuse.org/issues/44024\r\n- Verification run: [Tumbleweed-select_disk](http://dhcp42.suse.cz/tests/957#step/partitioning_firstdisk/6)\r\n","created_at":"2018-11-22T07:55:18Z","updated_at":"2018-11-22T12:59:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2f70096e5d47c2d0c5c0194a380d4c89ebb9c348","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/6261/commits","review_comments_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/6261/comments","review_comment_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/comments{/number}","comments_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/6261/comments","statuses_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/statuses/a32b1dbba5023a9168e1d2fa70f273e92feab3f3","head":{"label":"jknphy:fix_select_first_hd","ref":"fix_select_first_hd","sha":"a32b1dbba5023a9168e1d2fa70f273e92feab3f3","user":{"login":"jknphy","id":31735282,"node_id":"MDQ6VXNlcjMxNzM1Mjgy","avatar_url":"https://avatars0.githubusercontent.com/u/31735282?v=4","gravatar_id":"","url":"https://api.github.com/users/jknphy","html_url":"https://github.com/jknphy","followers_url":"https://api.github.com/users/jknphy/followers","following_url":"https://api.github.com/users/jknphy/following{/other_user}","gists_url":"https://api.github.com/users/jknphy/gists{/gist_id}","starred_url":"https://api.github.com/users/jknphy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jknphy/subscriptions","organizations_url":"https://api.github.com/users/jknphy/orgs","repos_url":"https://api.github.com/users/jknphy/repos","events_url":"https://api.github.com/users/jknphy/events{/privacy}","received_events_url":"https://api.github.com/users/jknphy/received_events","type":"User","site_admin":false},"repo":{"id":102743269,"node_id":"MDEwOlJlcG9zaXRvcnkxMDI3NDMyNjk=","name":"os-autoinst-distri-opensuse","full_name":"jknphy/os-autoinst-distri-opensuse","private":false,"owner":{"login":"jknphy","id":31735282,"node_id":"MDQ6VXNlcjMxNzM1Mjgy","avatar_url":"https://avatars0.githubusercontent.com/u/31735282?v=4","gravatar_id":"","url":"https://api.github.com/users/jknphy","html_url":"https://github.com/jknphy","followers_url":"https://api.github.com/users/jknphy/followers","following_url":"https://api.github.com/users/jknphy/following{/other_user}","gists_url":"https://api.github.com/users/jknphy/gists{/gist_id}","starred_url":"https://api.github.com/users/jknphy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jknphy/subscriptions","organizations_url":"https://api.github.com/users/jknphy/orgs","repos_url":"https://api.github.com/users/jknphy/repos","events_url":"https://api.github.com/users/jknphy/events{/privacy}","received_events_url":"https://api.github.com/users/jknphy/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jknphy/os-autoinst-distri-opensuse","description":"os-autoinst test cases for openSUSE","fork":true,"url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse","forks_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/forks","keys_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/teams","hooks_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/hooks","issue_events_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/issues/events{/number}","events_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/events","assignees_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/assignees{/user}","branches_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/branches{/branch}","tags_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/tags","blobs_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/git/refs{/sha}","trees_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/statuses/{sha}","languages_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/languages","stargazers_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/stargazers","contributors_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/contributors","subscribers_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/subscribers","subscription_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/subscription","commits_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/commits{/sha}","git_commits_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/git/commits{/sha}","comments_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/comments{/number}","issue_comment_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/issues/comments{/number}","contents_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/contents/{+path}","compare_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/merges","archive_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/downloads","issues_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/issues{/number}","pulls_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/pulls{/number}","milestones_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/milestones{/number}","notifications_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/labels{/name}","releases_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/releases{/id}","deployments_url":"https://api.github.com/repos/jknphy/os-autoinst-distri-opensuse/deployments","created_at":"2017-09-07T13:55:24Z","updated_at":"2018-08-31T12:46:53Z","pushed_at":"2018-11-22T12:57:35Z","git_url":"git://github.com/jknphy/os-autoinst-distri-opensuse.git","ssh_url":"git@github.com:jknphy/os-autoinst-distri-opensuse.git","clone_url":"https://github.com/jknphy/os-autoinst-distri-opensuse.git","svn_url":"https://github.com/jknphy/os-autoinst-distri-opensuse","homepage":"https://progress.opensuse.org/projects/openqatests/issues","size":98588,"stargazers_count":0,"watchers_count":0,"language":"Perl","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"os-autoinst:master","ref":"master","sha":"ed0b5d6f4c1ab7e9ce696976574bb162eb03b10b","user":{"login":"os-autoinst","id":6918706,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5MTg3MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/6918706?v=4","gravatar_id":"","url":"https://api.github.com/users/os-autoinst","html_url":"https://github.com/os-autoinst","followers_url":"https://api.github.com/users/os-autoinst/followers","following_url":"https://api.github.com/users/os-autoinst/following{/other_user}","gists_url":"https://api.github.com/users/os-autoinst/gists{/gist_id}","starred_url":"https://api.github.com/users/os-autoinst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/os-autoinst/subscriptions","organizations_url":"https://api.github.com/users/os-autoinst/orgs","repos_url":"https://api.github.com/users/os-autoinst/repos","events_url":"https://api.github.com/users/os-autoinst/events{/privacy}","received_events_url":"https://api.github.com/users/os-autoinst/received_events","type":"Organization","site_admin":false},"repo":{"id":17630288,"node_id":"MDEwOlJlcG9zaXRvcnkxNzYzMDI4OA==","name":"os-autoinst-distri-opensuse","full_name":"os-autoinst/os-autoinst-distri-opensuse","private":false,"owner":{"login":"os-autoinst","id":6918706,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5MTg3MDY=","avatar_url":"https://avatars2.githubusercontent.com/u/6918706?v=4","gravatar_id":"","url":"https://api.github.com/users/os-autoinst","html_url":"https://github.com/os-autoinst","followers_url":"https://api.github.com/users/os-autoinst/followers","following_url":"https://api.github.com/users/os-autoinst/following{/other_user}","gists_url":"https://api.github.com/users/os-autoinst/gists{/gist_id}","starred_url":"https://api.github.com/users/os-autoinst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/os-autoinst/subscriptions","organizations_url":"https://api.github.com/users/os-autoinst/orgs","repos_url":"https://api.github.com/users/os-autoinst/repos","events_url":"https://api.github.com/users/os-autoinst/events{/privacy}","received_events_url":"https://api.github.com/users/os-autoinst/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse","description":"os-autoinst test cases for openSUSE","fork":false,"url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse","forks_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/forks","keys_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/keys{/key_id}","collaborators_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/teams","hooks_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/hooks","issue_events_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/events{/number}","events_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/events","assignees_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/assignees{/user}","branches_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/branches{/branch}","tags_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/tags","blobs_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/git/refs{/sha}","trees_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/git/trees{/sha}","statuses_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/statuses/{sha}","languages_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/languages","stargazers_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/stargazers","contributors_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/contributors","subscribers_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/subscribers","subscription_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/subscription","commits_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/commits{/sha}","git_commits_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/git/commits{/sha}","comments_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/comments{/number}","issue_comment_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/comments{/number}","contents_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/contents/{+path}","compare_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/compare/{base}...{head}","merges_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/merges","archive_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/downloads","issues_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues{/number}","pulls_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls{/number}","milestones_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/milestones{/number}","notifications_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/labels{/name}","releases_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/releases{/id}","deployments_url":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/deployments","created_at":"2014-03-11T12:54:42Z","updated_at":"2018-11-22T12:39:13Z","pushed_at":"2018-11-22T12:57:37Z","git_url":"git://github.com/os-autoinst/os-autoinst-distri-opensuse.git","ssh_url":"git@github.com:os-autoinst/os-autoinst-distri-opensuse.git","clone_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse.git","svn_url":"https://github.com/os-autoinst/os-autoinst-distri-opensuse","homepage":"https://progress.opensuse.org/projects/openqatests/issues","size":98621,"stargazers_count":34,"watchers_count":34,"language":"Perl","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":156,"mirror_url":null,"archived":false,"open_issues_count":65,"license":null,"forks":156,"open_issues":65,"watchers":34,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/6261"},"html":{"href":"https://github.com/os-autoinst/os-autoinst-distri-opensuse/pull/6261"},"issue":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/6261"},"comments":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/issues/6261/comments"},"review_comments":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/6261/comments"},"review_comment":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/pulls/6261/commits"},"statuses":{"href":"https://api.github.com/repos/os-autoinst/os-autoinst-distri-opensuse/statuses/a32b1dbba5023a9168e1d2fa70f273e92feab3f3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jknphy"}}