{"action":"created","comment":{"url":"https://api.github.com/repos/brightcove/PHP-API-Wrapper/pulls/comments/200267457","pull_request_review_id":134547968,"id":200267457,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDI2NzQ1Nw==","diff_hunk":"@@ -19,10 +19,10 @@\n     }\n   ],\n   \"require-dev\": {\n-    \"phpunit/phpunit\": \"4.5.*\"\n+    \"phpunit/phpunit\": \"7.2.*\"\n   },\n   \"require\": {\n-    \"php\": \">=5.5.0\"\n+    \"php\": \">=7.0\"","path":"composer.json","position":9,"original_position":9,"commit_id":"98cf36701270ec7738c407b96da4c011b793243e","original_commit_id":"98cf36701270ec7738c407b96da4c011b793243e","user":{"login":"tamasd","id":40811,"node_id":"MDQ6VXNlcjQwODEx","avatar_url":"https://avatars0.githubusercontent.com/u/40811?v=4","gravatar_id":"","url":"https://api.github.com/users/tamasd","html_url":"https://github.com/tamasd","followers_url":"https://api.github.com/users/tamasd/followers","following_url":"https://api.github.com/users/tamasd/following{/other_user}","gists_url":"https://api.github.com/users/tamasd/gists{/gist_id}","starred_url":"https://api.github.com/users/tamasd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tamasd/subscriptions","organizations_url":"https://api.github.com/users/tamasd/orgs","repos_url":"https://api.github.com/users/tamasd/repos","events_url":"https://api.github.com/users/tamasd/events{/privacy}","received_events_url":"https://api.github.com/users/tamasd/received_events","type":"User","site_admin":false},"body":"I disagree with this one. I'd support bumping this to 5.6, but not 7 yet. We still have clients running PHP 5, using the Brightcove module with Drupal 7.","created_at":"2018-07-05T08:20:16Z","updated_at":"2018-07-05T08:20:56Z","html_url":"https://github.com/brightcove/PHP-API-Wrapper/pull/35#discussion_r200267457","pull_request_url":"https://api.github.com/repos/brightcove/PHP-API-Wrapper/pulls/35","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/brightcove/PHP-API-Wrapper/pulls/comments/200267457"},"html":{"href":"https://github.com/brightcove/PHP-API-Wrapper/pull/35#discussion_r200267457"},"pull_request":{"href":"https://api.github.com/repos/brightcove/PHP-API-Wrapper/pulls/35"}}},"pull_request":{"url":"https://api.github.com/repos/brightcove/PHP-API-Wrapper/pulls/35","id":192724340,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyNzI0MzQw","html_url":"https://github.com/brightcove/PHP-API-Wrapper/pull/35","diff_url":"https://github.com/brightcove/PHP-API-Wrapper/pull/35.diff","patch_url":"https://github.com/brightcove/PHP-API-Wrapper/pull/35.patch","issue_url":"https://api.github.com/repos/brightcove/PHP-API-Wrapper/issues/35","number":35,"state":"open","locked":false,"title":"Feature/php72 compatibility","user":{"login":"chibani","id":1182895,"node_id":"MDQ6VXNlcjExODI4OTU=","avatar_url":"https://avatars3.githubusercontent.com/u/1182895?v=4","gravatar_id":"","url":"https://api.github.com/users/chibani","html_url":"https://github.com/chibani","followers_url":"https://api.github.com/users/chibani/followers","following_url":"https://api.github.com/users/chibani/following{/other_user}","gists_url":"https://api.github.com/users/chibani/gists{/gist_id}","starred_url":"https://api.github.com/users/chibani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chibani/subscriptions","organizations_url":"https://api.github.com/users/chibani/orgs","repos_url":"https://api.github.com/users/chibani/repos","events_url":"https://api.github.com/users/chibani/events{/privacy}","received_events_url":"https://api.github.com/users/chibani/received_events","type":"User","site_admin":false},"body":"PHP 7.2 adds a new reserved keyword that is used in the lib namespaces : \"object\".\r\nCurrently, PHP 7.2 allows to use it in namespaces, but it will be forbidden in future released...\r\nSo, I've renamed \"Object\" to \"Item\", to keep a generic naming.\r\n\r\nAlso, I've updated PHPUnit to support PHP >=7.1 (as PHP 7.0 won't be maintained soon).\r\n\r\nThanks.","created_at":"2018-06-05T14:20:03Z","updated_at":"2018-07-05T08:20:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"20bfca1017831dab2e09f4c044a6d9af1a4ef968","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/brightcove/PHP-API-Wrapper/pulls/35/commits","review_comments_url":"https://api.github.com/repos/brightcove/PHP-API-Wrapper/pulls/35/comments","review_comment_url":"https://api.github.com/repos/brightcove/PHP-API-Wrapper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/brightcove/PHP-API-Wrapper/issues/35/comments","statuses_url":"https://api.github.com/repos/brightcove/PHP-API-Wrapper/statuses/98cf36701270ec7738c407b96da4c011b793243e","head":{"label":"chibani:feature/PHP72-compatibility","ref":"feature/PHP72-compatibility","sha":"98cf36701270ec7738c407b96da4c011b793243e","user":{"login":"chibani","id":1182895,"node_id":"MDQ6VXNlcjExODI4OTU=","avatar_url":"https://avatars3.githubusercontent.com/u/1182895?v=4","gravatar_id":"","url":"https://api.github.com/users/chibani","html_url":"https://github.com/chibani","followers_url":"https://api.github.com/users/chibani/followers","following_url":"https://api.github.com/users/chibani/following{/other_user}","gists_url":"https://api.github.com/users/chibani/gists{/gist_id}","starred_url":"https://api.github.com/users/chibani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chibani/subscriptions","organizations_url":"https://api.github.com/users/chibani/orgs","repos_url":"https://api.github.com/users/chibani/repos","events_url":"https://api.github.com/users/chibani/events{/privacy}","received_events_url":"https://api.github.com/users/chibani/received_events","type":"User","site_admin":false},"repo":{"id":136180680,"node_id":"MDEwOlJlcG9zaXRvcnkxMzYxODA2ODA=","name":"PHP-API-Wrapper","full_name":"chibani/PHP-API-Wrapper","owner":{"login":"chibani","id":1182895,"node_id":"MDQ6VXNlcjExODI4OTU=","avatar_url":"https://avatars3.githubusercontent.com/u/1182895?v=4","gravatar_id":"","url":"https://api.github.com/users/chibani","html_url":"https://github.com/chibani","followers_url":"https://api.github.com/users/chibani/followers","following_url":"https://api.github.com/users/chibani/following{/other_user}","gists_url":"https://api.github.com/users/chibani/gists{/gist_id}","starred_url":"https://api.github.com/users/chibani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chibani/subscriptions","organizations_url":"https://api.github.com/users/chibani/orgs","repos_url":"https://api.github.com/users/chibani/repos","events_url":"https://api.github.com/users/chibani/events{/privacy}","received_events_url":"https://api.github.com/users/chibani/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/chibani/PHP-API-Wrapper","description":"This project provides a starting point for integrating the Brightcove CMS API into your application. It provides simple ways to interact with the API, as well as a long list of helper functions.","fork":true,"url":"https://api.github.com/repos/chibani/PHP-API-Wrapper","forks_url":"https://api.github.com/repos/chibani/PHP-API-Wrapper/forks","keys_url":"https://api.github.com/repos/chibani/PHP-API-Wrapper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/chibani/PHP-API-Wrapper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/chibani/PHP-API-Wrapper/teams","hooks_url":"https://api.github.com/repos/chibani/PHP-API-Wrapper/hooks","issue_events_url":"https://api.github.com/repos/chibani/PHP-API-Wrapper/issues/events{/number}","events_url":"https://api.github.com/repos/chibani/PHP-API-Wrapper/events","assignees_url":"https://api.github.com/repos/chibani/PHP-API-Wrapper/assignees{/user}","branches_url":"https://api.github.com/repos/chibani/PHP-API-Wrapper/branches{/branch}","tags_url":"https://api.github.com/repos/chibani/PHP-API-Wrapper/tags","blobs_url":"https://api.github.com/repos/chibani/PHP-API-Wrapper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/chibani/PHP-API-Wrapper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/chibani/PHP-API-Wrapper/git/refs{/sha}","trees_url":"https://api.github.com/repos/chibani/PHP-API-Wrapper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/chibani/PHP-API-Wrapper/statuses/{sha}","languages_url":"https://api.github.com/repos/chibani/PHP-API-Wrapper/languages","stargazers_url":"https://api.github.com/repos/chibani/PHP-API-Wrapper/stargazers","contributors_url":"https://api.github.com/repos/chibani/PHP-API-Wrapper/contributors","subscribers_url":"https://api.github.com/repos/chibani/PHP-API-Wrapper/subscribers","subscription_url":"https://api.github.com/repos/chibani/PHP-API-Wrapper/subscription","commits_url":"https://api.github.com/repos/chibani/PHP-API-Wrapper/commits{/sha}","git_commits_url":"https://api.github.com/repos/chibani/PHP-API-Wrapper/git/commits{/sha}","comments_url":"https://api.github.com/repos/chibani/PHP-API-Wrapper/comments{/number}","issue_comment_url":"https://api.github.com/repos/chibani/PHP-API-Wrapper/issues/comments{/number}","contents_url":"https://api.github.com/repos/chibani/PHP-API-Wrapper/contents/{+path}","compare_url":"https://api.github.com/repos/chibani/PHP-API-Wrapper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/chibani/PHP-API-Wrapper/merges","archive_url":"https://api.github.com/repos/chibani/PHP-API-Wrapper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/chibani/PHP-API-Wrapper/downloads","issues_url":"https://api.github.com/repos/chibani/PHP-API-Wrapper/issues{/number}","pulls_url":"https://api.github.com/repos/chibani/PHP-API-Wrapper/pulls{/number}","milestones_url":"https://api.github.com/repos/chibani/PHP-API-Wrapper/milestones{/number}","notifications_url":"https://api.github.com/repos/chibani/PHP-API-Wrapper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/chibani/PHP-API-Wrapper/labels{/name}","releases_url":"https://api.github.com/repos/chibani/PHP-API-Wrapper/releases{/id}","deployments_url":"https://api.github.com/repos/chibani/PHP-API-Wrapper/deployments","created_at":"2018-06-05T13:21:12Z","updated_at":"2018-06-05T13:21:14Z","pushed_at":"2018-06-05T13:25:15Z","git_url":"git://github.com/chibani/PHP-API-Wrapper.git","ssh_url":"git@github.com:chibani/PHP-API-Wrapper.git","clone_url":"https://github.com/chibani/PHP-API-Wrapper.git","svn_url":"https://github.com/chibani/PHP-API-Wrapper","homepage":null,"size":188,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"brightcove:master","ref":"master","sha":"74be1403745544b2761dbea00bb7ba36a4fc105d","user":{"login":"brightcove","id":277032,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NzAzMg==","avatar_url":"https://avatars0.githubusercontent.com/u/277032?v=4","gravatar_id":"","url":"https://api.github.com/users/brightcove","html_url":"https://github.com/brightcove","followers_url":"https://api.github.com/users/brightcove/followers","following_url":"https://api.github.com/users/brightcove/following{/other_user}","gists_url":"https://api.github.com/users/brightcove/gists{/gist_id}","starred_url":"https://api.github.com/users/brightcove/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brightcove/subscriptions","organizations_url":"https://api.github.com/users/brightcove/orgs","repos_url":"https://api.github.com/users/brightcove/repos","events_url":"https://api.github.com/users/brightcove/events{/privacy}","received_events_url":"https://api.github.com/users/brightcove/received_events","type":"Organization","site_admin":false},"repo":{"id":34743373,"node_id":"MDEwOlJlcG9zaXRvcnkzNDc0MzM3Mw==","name":"PHP-API-Wrapper","full_name":"brightcove/PHP-API-Wrapper","owner":{"login":"brightcove","id":277032,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI3NzAzMg==","avatar_url":"https://avatars0.githubusercontent.com/u/277032?v=4","gravatar_id":"","url":"https://api.github.com/users/brightcove","html_url":"https://github.com/brightcove","followers_url":"https://api.github.com/users/brightcove/followers","following_url":"https://api.github.com/users/brightcove/following{/other_user}","gists_url":"https://api.github.com/users/brightcove/gists{/gist_id}","starred_url":"https://api.github.com/users/brightcove/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brightcove/subscriptions","organizations_url":"https://api.github.com/users/brightcove/orgs","repos_url":"https://api.github.com/users/brightcove/repos","events_url":"https://api.github.com/users/brightcove/events{/privacy}","received_events_url":"https://api.github.com/users/brightcove/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/brightcove/PHP-API-Wrapper","description":"This project provides a starting point for integrating the Brightcove CMS API into your application. It provides simple ways to interact with the API, as well as a long list of helper functions.","fork":false,"url":"https://api.github.com/repos/brightcove/PHP-API-Wrapper","forks_url":"https://api.github.com/repos/brightcove/PHP-API-Wrapper/forks","keys_url":"https://api.github.com/repos/brightcove/PHP-API-Wrapper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brightcove/PHP-API-Wrapper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brightcove/PHP-API-Wrapper/teams","hooks_url":"https://api.github.com/repos/brightcove/PHP-API-Wrapper/hooks","issue_events_url":"https://api.github.com/repos/brightcove/PHP-API-Wrapper/issues/events{/number}","events_url":"https://api.github.com/repos/brightcove/PHP-API-Wrapper/events","assignees_url":"https://api.github.com/repos/brightcove/PHP-API-Wrapper/assignees{/user}","branches_url":"https://api.github.com/repos/brightcove/PHP-API-Wrapper/branches{/branch}","tags_url":"https://api.github.com/repos/brightcove/PHP-API-Wrapper/tags","blobs_url":"https://api.github.com/repos/brightcove/PHP-API-Wrapper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brightcove/PHP-API-Wrapper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brightcove/PHP-API-Wrapper/git/refs{/sha}","trees_url":"https://api.github.com/repos/brightcove/PHP-API-Wrapper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brightcove/PHP-API-Wrapper/statuses/{sha}","languages_url":"https://api.github.com/repos/brightcove/PHP-API-Wrapper/languages","stargazers_url":"https://api.github.com/repos/brightcove/PHP-API-Wrapper/stargazers","contributors_url":"https://api.github.com/repos/brightcove/PHP-API-Wrapper/contributors","subscribers_url":"https://api.github.com/repos/brightcove/PHP-API-Wrapper/subscribers","subscription_url":"https://api.github.com/repos/brightcove/PHP-API-Wrapper/subscription","commits_url":"https://api.github.com/repos/brightcove/PHP-API-Wrapper/commits{/sha}","git_commits_url":"https://api.github.com/repos/brightcove/PHP-API-Wrapper/git/commits{/sha}","comments_url":"https://api.github.com/repos/brightcove/PHP-API-Wrapper/comments{/number}","issue_comment_url":"https://api.github.com/repos/brightcove/PHP-API-Wrapper/issues/comments{/number}","contents_url":"https://api.github.com/repos/brightcove/PHP-API-Wrapper/contents/{+path}","compare_url":"https://api.github.com/repos/brightcove/PHP-API-Wrapper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brightcove/PHP-API-Wrapper/merges","archive_url":"https://api.github.com/repos/brightcove/PHP-API-Wrapper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brightcove/PHP-API-Wrapper/downloads","issues_url":"https://api.github.com/repos/brightcove/PHP-API-Wrapper/issues{/number}","pulls_url":"https://api.github.com/repos/brightcove/PHP-API-Wrapper/pulls{/number}","milestones_url":"https://api.github.com/repos/brightcove/PHP-API-Wrapper/milestones{/number}","notifications_url":"https://api.github.com/repos/brightcove/PHP-API-Wrapper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brightcove/PHP-API-Wrapper/labels{/name}","releases_url":"https://api.github.com/repos/brightcove/PHP-API-Wrapper/releases{/id}","deployments_url":"https://api.github.com/repos/brightcove/PHP-API-Wrapper/deployments","created_at":"2015-04-28T16:46:51Z","updated_at":"2018-03-08T23:52:33Z","pushed_at":"2018-06-05T14:20:04Z","git_url":"git://github.com/brightcove/PHP-API-Wrapper.git","ssh_url":"git@github.com:brightcove/PHP-API-Wrapper.git","clone_url":"https://github.com/brightcove/PHP-API-Wrapper.git","svn_url":"https://github.com/brightcove/PHP-API-Wrapper","homepage":null,"size":161,"stargazers_count":17,"watchers_count":17,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":10,"license":null,"forks":26,"open_issues":10,"watchers":17,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/brightcove/PHP-API-Wrapper/pulls/35"},"html":{"href":"https://github.com/brightcove/PHP-API-Wrapper/pull/35"},"issue":{"href":"https://api.github.com/repos/brightcove/PHP-API-Wrapper/issues/35"},"comments":{"href":"https://api.github.com/repos/brightcove/PHP-API-Wrapper/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/brightcove/PHP-API-Wrapper/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/brightcove/PHP-API-Wrapper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/brightcove/PHP-API-Wrapper/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/brightcove/PHP-API-Wrapper/statuses/98cf36701270ec7738c407b96da4c011b793243e"}},"author_association":"NONE"}}
{"actor":{"display_login":"tamasd"}}