{"action":"created","issue":{"url":"https://api.github.com/repos/OXID-eSales/oxideshop_ce/issues/639","repository_url":"https://api.github.com/repos/OXID-eSales/oxideshop_ce","labels_url":"https://api.github.com/repos/OXID-eSales/oxideshop_ce/issues/639/labels{/name}","comments_url":"https://api.github.com/repos/OXID-eSales/oxideshop_ce/issues/639/comments","events_url":"https://api.github.com/repos/OXID-eSales/oxideshop_ce/issues/639/events","html_url":"https://github.com/OXID-eSales/oxideshop_ce/pull/639","id":307947917,"number":639,"title":"Doctrine's QueryBuilder feature","user":{"login":"tmloberon","id":28302826,"avatar_url":"https://avatars0.githubusercontent.com/u/28302826?v=4","gravatar_id":"","url":"https://api.github.com/users/tmloberon","html_url":"https://github.com/tmloberon","followers_url":"https://api.github.com/users/tmloberon/followers","following_url":"https://api.github.com/users/tmloberon/following{/other_user}","gists_url":"https://api.github.com/users/tmloberon/gists{/gist_id}","starred_url":"https://api.github.com/users/tmloberon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmloberon/subscriptions","organizations_url":"https://api.github.com/users/tmloberon/orgs","repos_url":"https://api.github.com/users/tmloberon/repos","events_url":"https://api.github.com/users/tmloberon/events{/privacy}","received_events_url":"https://api.github.com/users/tmloberon/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-03-23T09:01:08Z","updated_at":"2018-05-18T07:35:59Z","closed_at":"2018-04-12T09:12:19Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/OXID-eSales/oxideshop_ce/pulls/639","html_url":"https://github.com/OXID-eSales/oxideshop_ce/pull/639","diff_url":"https://github.com/OXID-eSales/oxideshop_ce/pull/639.diff","patch_url":"https://github.com/OXID-eSales/oxideshop_ce/pull/639.patch"},"body":"Open [QueryBuilder feature](http://docs.doctrine-project.org/projects/doctrine-dbal/en/latest/reference/query-builder.html) of Doctrine, please!\r\n\r\nThan we can write code like:\r\n\r\n```php\r\n$database     = DatabaseProvider::getDb(DatabaseProvider::FETCH_MODE_ASSOC);\r\n$flexibleSql = $database->createQueryBuilder();\r\n\r\n$flexibleSql->select('*')\r\n            ->from(getViewName('oxarticles'))\r\n            ->where('oxtitle like :value')\r\n            ->setParameter(':value', \"%Sessel%\");\r\n\r\n$result = $database->getAll($flexibleSql->getSQL(), $flexibleSql->getParameters());\r\n```\r\n\r\nWe have a flexible sql object. To change it easy in other function like:\r\n\r\n```php\r\n...\r\naddActiveSnippet($flexibleSql);\r\n...\r\n$result = $database->getAll($flexibleSql->getSQL(), $flexibleSql->getParameters());\r\n\r\nfunction addActiveSnippet(QueryBuilder $flexibleSql) {\r\n    $flexibleSql->andWhere('oxactive = 1');\r\n}\r\n```\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/OXID-eSales/oxideshop_ce/issues/comments/390121960","html_url":"https://github.com/OXID-eSales/oxideshop_ce/pull/639#issuecomment-390121960","issue_url":"https://api.github.com/repos/OXID-eSales/oxideshop_ce/issues/639","id":390121960,"user":{"login":"Betazoid","id":7984982,"avatar_url":"https://avatars2.githubusercontent.com/u/7984982?v=4","gravatar_id":"","url":"https://api.github.com/users/Betazoid","html_url":"https://github.com/Betazoid","followers_url":"https://api.github.com/users/Betazoid/followers","following_url":"https://api.github.com/users/Betazoid/following{/other_user}","gists_url":"https://api.github.com/users/Betazoid/gists{/gist_id}","starred_url":"https://api.github.com/users/Betazoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Betazoid/subscriptions","organizations_url":"https://api.github.com/users/Betazoid/orgs","repos_url":"https://api.github.com/users/Betazoid/repos","events_url":"https://api.github.com/users/Betazoid/events{/privacy}","received_events_url":"https://api.github.com/users/Betazoid/received_events","type":"User","site_admin":false},"created_at":"2018-05-18T07:35:59Z","updated_at":"2018-05-18T07:35:59Z","author_association":"NONE","body":"> you will have two different ResultSet objects in the code, that behave differently\r\nHow about documenting different behaviour? Cross-reference and emphasize it. This isn't unusual in projects maintaining compatibility while moving forward. \r\n\r\n> Yes, for the moment it would just add behaviour. But if you add behaviour, it will be used.\r\nWhat do you mean by this? Isn't this a big part of the definition of _feature_ and _improvement_?\r\n\r\nClosing, this a really poor excuse.\r\n"}}
{"actor":{"display_login":"Betazoid"}}