{"action":"created","comment":{"url":"https://api.github.com/repos/iotaledger/iri-regression/pulls/comments/211659571","pull_request_review_id":148128423,"id":211659571,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTY1OTU3MQ==","diff_hunk":"@@ -1,21 +1,66 @@\n from aloe import *\n-from iota import Iota\n+from iota import Iota, ProposedTransaction, Address\n from iota.commands.core import add_neighbors\n from util import static_vals\n+from util.test_logic import api_test_logic\n+from yaml import load, Loader\n+\n+import logging \n+logging.basicConfig(level=logging.INFO)\n+logger = logging.getLogger(__name__)\n+\n+tests = api_test_logic\n \n neighbors = static_vals.TEST_NEIGHBORS\n testHash = static_vals.TEST_HASH\n testTrytes = static_vals.TEST_TRYTES\n \n config = {}\n-responses = {'getNodeInfo':{},'getNeighbors':{},'getTips':{},'getTrytes':{}}   \n+responses = {'getNodeInfo':{},'getNeighbors':{},'getTips':{},'getTransactionsToApprove':{},'getTrytes':{}}   \n+\n+yamlPaths = [\"./tests/features/machine1/output.yml\",\"./tests/features/machine2/output.yml\",\n+             \"./tests/features/machine3/output.yml\"]\n+\n+#Configuration\n+@before.all\n+def configuration():\n+    logger.info('Start Node Configuration')\n+    machines = {}  \n+    count = 1  \n+    for i in range(len(yamlPaths)):\n+        stream = open(yamlPaths[i],'r')\n+        machine = load(stream,Loader=Loader)\n+        world.seeds = machine.get('seeds')  \n+        nodes_final = {}\n+        keys = machine.keys()   \n+        logger.debug('Keys: %s',keys) \n+        for i in keys:\n+            if i == 'nodes':\n+                for x in machine[i]:\n+                    name = x\n+                    host = machine[i][x]['host']\n+                    port = machine[i][x]['ports']['api']\n+                    udpPort = machine[i][x]['ports']['gossip-udp']\n+                    logger.info(host + \":\" + str(port))\n+                    nodes_final[name] = {'host': host, 'port': str(port), 'udpPort': str(udpPort)}\n+                    logger.info('%s configured', name)\n+\n+        machine_tag = 'machine'+str(count)\n+        machines[machine_tag] = nodes_final\n+        logger.info('Machine %d configured', count)  \n+        count += 1\n+\n+              \n+    world.machines = machines\n+    logger.info('Node Configuration Complete')\n \n ###\n #Register API call    \n @step(r'\"([^\"]*)\" is called on \"([^\"]*)\"')","path":"PythonRegression/tests/features/steps/api_test_steps.py","position":61,"original_position":61,"commit_id":"4cb92013efed4a0c2f9d094bc93c6d4d04a1b94a","original_commit_id":"4cb92013efed4a0c2f9d094bc93c6d4d04a1b94a","user":{"login":"karimodm","id":1577639,"node_id":"MDQ6VXNlcjE1Nzc2Mzk=","avatar_url":"https://avatars2.githubusercontent.com/u/1577639?v=4","gravatar_id":"","url":"https://api.github.com/users/karimodm","html_url":"https://github.com/karimodm","followers_url":"https://api.github.com/users/karimodm/followers","following_url":"https://api.github.com/users/karimodm/following{/other_user}","gists_url":"https://api.github.com/users/karimodm/gists{/gist_id}","starred_url":"https://api.github.com/users/karimodm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karimodm/subscriptions","organizations_url":"https://api.github.com/users/karimodm/orgs","repos_url":"https://api.github.com/users/karimodm/repos","events_url":"https://api.github.com/users/karimodm/events{/privacy}","received_events_url":"https://api.github.com/users/karimodm/received_events","type":"User","site_admin":false},"body":"I would like at least a comment to make sure this is an API call","created_at":"2018-08-21T15:50:51Z","updated_at":"2018-08-21T15:50:51Z","html_url":"https://github.com/iotaledger/iri-regression/pull/26#discussion_r211659571","pull_request_url":"https://api.github.com/repos/iotaledger/iri-regression/pulls/26","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/iotaledger/iri-regression/pulls/comments/211659571"},"html":{"href":"https://github.com/iotaledger/iri-regression/pull/26#discussion_r211659571"},"pull_request":{"href":"https://api.github.com/repos/iotaledger/iri-regression/pulls/26"}},"in_reply_to_id":211611609},"pull_request":{"url":"https://api.github.com/repos/iotaledger/iri-regression/pulls/26","id":209720654,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5NzIwNjU0","html_url":"https://github.com/iotaledger/iri-regression/pull/26","diff_url":"https://github.com/iotaledger/iri-regression/pull/26.diff","patch_url":"https://github.com/iotaledger/iri-regression/pull/26.patch","issue_url":"https://api.github.com/repos/iotaledger/iri-regression/issues/26","number":26,"state":"open","locked":false,"title":"Blowball Testing","user":{"login":"DyrellC","id":34013004,"node_id":"MDQ6VXNlcjM0MDEzMDA0","avatar_url":"https://avatars2.githubusercontent.com/u/34013004?v=4","gravatar_id":"","url":"https://api.github.com/users/DyrellC","html_url":"https://github.com/DyrellC","followers_url":"https://api.github.com/users/DyrellC/followers","following_url":"https://api.github.com/users/DyrellC/following{/other_user}","gists_url":"https://api.github.com/users/DyrellC/gists{/gist_id}","starred_url":"https://api.github.com/users/DyrellC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DyrellC/subscriptions","organizations_url":"https://api.github.com/users/DyrellC/orgs","repos_url":"https://api.github.com/users/DyrellC/repos","events_url":"https://api.github.com/users/DyrellC/events{/privacy}","received_events_url":"https://api.github.com/users/DyrellC/received_events","type":"User","site_admin":false},"body":"Initial commits for blowball testing on 1.4.2 and 1.5.0 nodes. \r\n\r\nThis PR includes: \r\n1. A new machine3 directory and feature file \r\n2. Blowball testing steps\r\n\r\nThe test descriptions can be found in the `Scenario` section within the feature file. These tests are intended to confirm previous errors in the tip selection algorithms.   ","created_at":"2018-08-21T06:29:14Z","updated_at":"2018-08-21T15:50:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"171489870ae9bae44fd5e47697bd272034522b94","assignee":null,"assignees":[],"requested_reviewers":[{"login":"jakubcech","id":3016965,"node_id":"MDQ6VXNlcjMwMTY5NjU=","avatar_url":"https://avatars0.githubusercontent.com/u/3016965?v=4","gravatar_id":"","url":"https://api.github.com/users/jakubcech","html_url":"https://github.com/jakubcech","followers_url":"https://api.github.com/users/jakubcech/followers","following_url":"https://api.github.com/users/jakubcech/following{/other_user}","gists_url":"https://api.github.com/users/jakubcech/gists{/gist_id}","starred_url":"https://api.github.com/users/jakubcech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakubcech/subscriptions","organizations_url":"https://api.github.com/users/jakubcech/orgs","repos_url":"https://api.github.com/users/jakubcech/repos","events_url":"https://api.github.com/users/jakubcech/events{/privacy}","received_events_url":"https://api.github.com/users/jakubcech/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/iotaledger/iri-regression/pulls/26/commits","review_comments_url":"https://api.github.com/repos/iotaledger/iri-regression/pulls/26/comments","review_comment_url":"https://api.github.com/repos/iotaledger/iri-regression/pulls/comments{/number}","comments_url":"https://api.github.com/repos/iotaledger/iri-regression/issues/26/comments","statuses_url":"https://api.github.com/repos/iotaledger/iri-regression/statuses/4cb92013efed4a0c2f9d094bc93c6d4d04a1b94a","head":{"label":"iotaledger:blowball-testing","ref":"blowball-testing","sha":"4cb92013efed4a0c2f9d094bc93c6d4d04a1b94a","user":{"login":"iotaledger","id":20126597,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMTI2NTk3","avatar_url":"https://avatars3.githubusercontent.com/u/20126597?v=4","gravatar_id":"","url":"https://api.github.com/users/iotaledger","html_url":"https://github.com/iotaledger","followers_url":"https://api.github.com/users/iotaledger/followers","following_url":"https://api.github.com/users/iotaledger/following{/other_user}","gists_url":"https://api.github.com/users/iotaledger/gists{/gist_id}","starred_url":"https://api.github.com/users/iotaledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iotaledger/subscriptions","organizations_url":"https://api.github.com/users/iotaledger/orgs","repos_url":"https://api.github.com/users/iotaledger/repos","events_url":"https://api.github.com/users/iotaledger/events{/privacy}","received_events_url":"https://api.github.com/users/iotaledger/received_events","type":"Organization","site_admin":false},"repo":{"id":139697734,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk2OTc3MzQ=","name":"iri-regression","full_name":"iotaledger/iri-regression","owner":{"login":"iotaledger","id":20126597,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMTI2NTk3","avatar_url":"https://avatars3.githubusercontent.com/u/20126597?v=4","gravatar_id":"","url":"https://api.github.com/users/iotaledger","html_url":"https://github.com/iotaledger","followers_url":"https://api.github.com/users/iotaledger/followers","following_url":"https://api.github.com/users/iotaledger/following{/other_user}","gists_url":"https://api.github.com/users/iotaledger/gists{/gist_id}","starred_url":"https://api.github.com/users/iotaledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iotaledger/subscriptions","organizations_url":"https://api.github.com/users/iotaledger/orgs","repos_url":"https://api.github.com/users/iotaledger/repos","events_url":"https://api.github.com/users/iotaledger/events{/privacy}","received_events_url":"https://api.github.com/users/iotaledger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iotaledger/iri-regression","description":null,"fork":false,"url":"https://api.github.com/repos/iotaledger/iri-regression","forks_url":"https://api.github.com/repos/iotaledger/iri-regression/forks","keys_url":"https://api.github.com/repos/iotaledger/iri-regression/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iotaledger/iri-regression/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iotaledger/iri-regression/teams","hooks_url":"https://api.github.com/repos/iotaledger/iri-regression/hooks","issue_events_url":"https://api.github.com/repos/iotaledger/iri-regression/issues/events{/number}","events_url":"https://api.github.com/repos/iotaledger/iri-regression/events","assignees_url":"https://api.github.com/repos/iotaledger/iri-regression/assignees{/user}","branches_url":"https://api.github.com/repos/iotaledger/iri-regression/branches{/branch}","tags_url":"https://api.github.com/repos/iotaledger/iri-regression/tags","blobs_url":"https://api.github.com/repos/iotaledger/iri-regression/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iotaledger/iri-regression/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iotaledger/iri-regression/git/refs{/sha}","trees_url":"https://api.github.com/repos/iotaledger/iri-regression/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iotaledger/iri-regression/statuses/{sha}","languages_url":"https://api.github.com/repos/iotaledger/iri-regression/languages","stargazers_url":"https://api.github.com/repos/iotaledger/iri-regression/stargazers","contributors_url":"https://api.github.com/repos/iotaledger/iri-regression/contributors","subscribers_url":"https://api.github.com/repos/iotaledger/iri-regression/subscribers","subscription_url":"https://api.github.com/repos/iotaledger/iri-regression/subscription","commits_url":"https://api.github.com/repos/iotaledger/iri-regression/commits{/sha}","git_commits_url":"https://api.github.com/repos/iotaledger/iri-regression/git/commits{/sha}","comments_url":"https://api.github.com/repos/iotaledger/iri-regression/comments{/number}","issue_comment_url":"https://api.github.com/repos/iotaledger/iri-regression/issues/comments{/number}","contents_url":"https://api.github.com/repos/iotaledger/iri-regression/contents/{+path}","compare_url":"https://api.github.com/repos/iotaledger/iri-regression/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iotaledger/iri-regression/merges","archive_url":"https://api.github.com/repos/iotaledger/iri-regression/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iotaledger/iri-regression/downloads","issues_url":"https://api.github.com/repos/iotaledger/iri-regression/issues{/number}","pulls_url":"https://api.github.com/repos/iotaledger/iri-regression/pulls{/number}","milestones_url":"https://api.github.com/repos/iotaledger/iri-regression/milestones{/number}","notifications_url":"https://api.github.com/repos/iotaledger/iri-regression/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iotaledger/iri-regression/labels{/name}","releases_url":"https://api.github.com/repos/iotaledger/iri-regression/releases{/id}","deployments_url":"https://api.github.com/repos/iotaledger/iri-regression/deployments","created_at":"2018-07-04T09:09:21Z","updated_at":"2018-07-19T08:16:44Z","pushed_at":"2018-08-21T06:29:15Z","git_url":"git://github.com/iotaledger/iri-regression.git","ssh_url":"git@github.com:iotaledger/iri-regression.git","clone_url":"https://github.com/iotaledger/iri-regression.git","svn_url":"https://github.com/iotaledger/iri-regression","homepage":null,"size":106,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":24,"license":null,"forks":1,"open_issues":24,"watchers":0,"default_branch":"master"}},"base":{"label":"iotaledger:dev","ref":"dev","sha":"4b5d2f2e2a07c2a6ade5f590a31cafadbf177e1e","user":{"login":"iotaledger","id":20126597,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMTI2NTk3","avatar_url":"https://avatars3.githubusercontent.com/u/20126597?v=4","gravatar_id":"","url":"https://api.github.com/users/iotaledger","html_url":"https://github.com/iotaledger","followers_url":"https://api.github.com/users/iotaledger/followers","following_url":"https://api.github.com/users/iotaledger/following{/other_user}","gists_url":"https://api.github.com/users/iotaledger/gists{/gist_id}","starred_url":"https://api.github.com/users/iotaledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iotaledger/subscriptions","organizations_url":"https://api.github.com/users/iotaledger/orgs","repos_url":"https://api.github.com/users/iotaledger/repos","events_url":"https://api.github.com/users/iotaledger/events{/privacy}","received_events_url":"https://api.github.com/users/iotaledger/received_events","type":"Organization","site_admin":false},"repo":{"id":139697734,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk2OTc3MzQ=","name":"iri-regression","full_name":"iotaledger/iri-regression","owner":{"login":"iotaledger","id":20126597,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMTI2NTk3","avatar_url":"https://avatars3.githubusercontent.com/u/20126597?v=4","gravatar_id":"","url":"https://api.github.com/users/iotaledger","html_url":"https://github.com/iotaledger","followers_url":"https://api.github.com/users/iotaledger/followers","following_url":"https://api.github.com/users/iotaledger/following{/other_user}","gists_url":"https://api.github.com/users/iotaledger/gists{/gist_id}","starred_url":"https://api.github.com/users/iotaledger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iotaledger/subscriptions","organizations_url":"https://api.github.com/users/iotaledger/orgs","repos_url":"https://api.github.com/users/iotaledger/repos","events_url":"https://api.github.com/users/iotaledger/events{/privacy}","received_events_url":"https://api.github.com/users/iotaledger/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/iotaledger/iri-regression","description":null,"fork":false,"url":"https://api.github.com/repos/iotaledger/iri-regression","forks_url":"https://api.github.com/repos/iotaledger/iri-regression/forks","keys_url":"https://api.github.com/repos/iotaledger/iri-regression/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iotaledger/iri-regression/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iotaledger/iri-regression/teams","hooks_url":"https://api.github.com/repos/iotaledger/iri-regression/hooks","issue_events_url":"https://api.github.com/repos/iotaledger/iri-regression/issues/events{/number}","events_url":"https://api.github.com/repos/iotaledger/iri-regression/events","assignees_url":"https://api.github.com/repos/iotaledger/iri-regression/assignees{/user}","branches_url":"https://api.github.com/repos/iotaledger/iri-regression/branches{/branch}","tags_url":"https://api.github.com/repos/iotaledger/iri-regression/tags","blobs_url":"https://api.github.com/repos/iotaledger/iri-regression/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iotaledger/iri-regression/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iotaledger/iri-regression/git/refs{/sha}","trees_url":"https://api.github.com/repos/iotaledger/iri-regression/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iotaledger/iri-regression/statuses/{sha}","languages_url":"https://api.github.com/repos/iotaledger/iri-regression/languages","stargazers_url":"https://api.github.com/repos/iotaledger/iri-regression/stargazers","contributors_url":"https://api.github.com/repos/iotaledger/iri-regression/contributors","subscribers_url":"https://api.github.com/repos/iotaledger/iri-regression/subscribers","subscription_url":"https://api.github.com/repos/iotaledger/iri-regression/subscription","commits_url":"https://api.github.com/repos/iotaledger/iri-regression/commits{/sha}","git_commits_url":"https://api.github.com/repos/iotaledger/iri-regression/git/commits{/sha}","comments_url":"https://api.github.com/repos/iotaledger/iri-regression/comments{/number}","issue_comment_url":"https://api.github.com/repos/iotaledger/iri-regression/issues/comments{/number}","contents_url":"https://api.github.com/repos/iotaledger/iri-regression/contents/{+path}","compare_url":"https://api.github.com/repos/iotaledger/iri-regression/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iotaledger/iri-regression/merges","archive_url":"https://api.github.com/repos/iotaledger/iri-regression/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iotaledger/iri-regression/downloads","issues_url":"https://api.github.com/repos/iotaledger/iri-regression/issues{/number}","pulls_url":"https://api.github.com/repos/iotaledger/iri-regression/pulls{/number}","milestones_url":"https://api.github.com/repos/iotaledger/iri-regression/milestones{/number}","notifications_url":"https://api.github.com/repos/iotaledger/iri-regression/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iotaledger/iri-regression/labels{/name}","releases_url":"https://api.github.com/repos/iotaledger/iri-regression/releases{/id}","deployments_url":"https://api.github.com/repos/iotaledger/iri-regression/deployments","created_at":"2018-07-04T09:09:21Z","updated_at":"2018-07-19T08:16:44Z","pushed_at":"2018-08-21T06:29:15Z","git_url":"git://github.com/iotaledger/iri-regression.git","ssh_url":"git@github.com:iotaledger/iri-regression.git","clone_url":"https://github.com/iotaledger/iri-regression.git","svn_url":"https://github.com/iotaledger/iri-regression","homepage":null,"size":106,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":24,"license":null,"forks":1,"open_issues":24,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/iotaledger/iri-regression/pulls/26"},"html":{"href":"https://github.com/iotaledger/iri-regression/pull/26"},"issue":{"href":"https://api.github.com/repos/iotaledger/iri-regression/issues/26"},"comments":{"href":"https://api.github.com/repos/iotaledger/iri-regression/issues/26/comments"},"review_comments":{"href":"https://api.github.com/repos/iotaledger/iri-regression/pulls/26/comments"},"review_comment":{"href":"https://api.github.com/repos/iotaledger/iri-regression/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/iotaledger/iri-regression/pulls/26/commits"},"statuses":{"href":"https://api.github.com/repos/iotaledger/iri-regression/statuses/4cb92013efed4a0c2f9d094bc93c6d4d04a1b94a"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"karimodm"}}