{"action":"closed","number":75,"pull_request":{"url":"https://api.github.com/repos/Vinno97/prism/pulls/75","id":235230854,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1MjMwODU0","html_url":"https://github.com/Vinno97/prism/pull/75","diff_url":"https://github.com/Vinno97/prism/pull/75.diff","patch_url":"https://github.com/Vinno97/prism/pull/75.patch","issue_url":"https://api.github.com/repos/Vinno97/prism/issues/75","number":75,"state":"closed","locked":false,"title":"Entity manager overhaul","user":{"login":"Vinno97","id":9059378,"node_id":"MDQ6VXNlcjkwNTkzNzg=","avatar_url":"https://avatars2.githubusercontent.com/u/9059378?v=4","gravatar_id":"","url":"https://api.github.com/users/Vinno97","html_url":"https://github.com/Vinno97","followers_url":"https://api.github.com/users/Vinno97/followers","following_url":"https://api.github.com/users/Vinno97/following{/other_user}","gists_url":"https://api.github.com/users/Vinno97/gists{/gist_id}","starred_url":"https://api.github.com/users/Vinno97/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vinno97/subscriptions","organizations_url":"https://api.github.com/users/Vinno97/orgs","repos_url":"https://api.github.com/users/Vinno97/repos","events_url":"https://api.github.com/users/Vinno97/events{/privacy}","received_events_url":"https://api.github.com/users/Vinno97/received_events","type":"User","site_admin":false},"body":"Dit is een groot PR dat veel Technical debt oplost.\r\n\r\nIs i.v.m. eerdere optimalisaties gebaseerd op patch/CollisionFPS\r\n\r\nChanges in de EntityManager:\r\n* Ophalen van components gaat nu meerdere malen sneller.\r\n* Er wordt geen stroom van verborgen exceptions meer gegooid (fixes #66).\r\n* API is nu fluent (resolves #65).\r\n* `addComponentToEntity` is nu ook te gebruiken met perfect forwarding.\r\n* Intern worden nu unique pointers gebruikt (resolves #63).\r\n* `enable_if` uitgeschakeld bij templates.\r\n\r\nVerdere changes:\r\n* Meerdere malen `using namespace` verwijderd uit headers.\r\n* `Component::clone()` is nu `const` (fixes #45).\r\n* `Component::clone()` is returnt nu een unique pointer.\r\n* Alle variabelen in Components geïnitialiseerd\r\n* `EntityBuilder` aangemaakt om eenvoudiger meerdere componenten aan een entity te koppelen.\r\n* Alle functies in `EntityFactory` const gemaakt.\r\n* Entity id's consistent unsigned integers gemaakt.\r\n* Null-check toegevoegd aan `AppearanceComponent::clone()`\r\n","created_at":"2018-12-02T01:31:04Z","updated_at":"2018-12-03T13:45:01Z","closed_at":"2018-12-03T13:45:01Z","merged_at":"2018-12-03T13:45:00Z","merge_commit_sha":"452efed86d31e74cf12cbf327e7e14eecb5d7036","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Vinno97/prism/pulls/75/commits","review_comments_url":"https://api.github.com/repos/Vinno97/prism/pulls/75/comments","review_comment_url":"https://api.github.com/repos/Vinno97/prism/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Vinno97/prism/issues/75/comments","statuses_url":"https://api.github.com/repos/Vinno97/prism/statuses/5d189daad89a2fff473ccfcf5fe0439bdb1f25f4","head":{"label":"Vinno97:entity-manager-overhaul","ref":"entity-manager-overhaul","sha":"5d189daad89a2fff473ccfcf5fe0439bdb1f25f4","user":{"login":"Vinno97","id":9059378,"node_id":"MDQ6VXNlcjkwNTkzNzg=","avatar_url":"https://avatars2.githubusercontent.com/u/9059378?v=4","gravatar_id":"","url":"https://api.github.com/users/Vinno97","html_url":"https://github.com/Vinno97","followers_url":"https://api.github.com/users/Vinno97/followers","following_url":"https://api.github.com/users/Vinno97/following{/other_user}","gists_url":"https://api.github.com/users/Vinno97/gists{/gist_id}","starred_url":"https://api.github.com/users/Vinno97/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vinno97/subscriptions","organizations_url":"https://api.github.com/users/Vinno97/orgs","repos_url":"https://api.github.com/users/Vinno97/repos","events_url":"https://api.github.com/users/Vinno97/events{/privacy}","received_events_url":"https://api.github.com/users/Vinno97/received_events","type":"User","site_admin":false},"repo":{"id":147668071,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc2NjgwNzE=","name":"prism","full_name":"Vinno97/prism","private":false,"owner":{"login":"Vinno97","id":9059378,"node_id":"MDQ6VXNlcjkwNTkzNzg=","avatar_url":"https://avatars2.githubusercontent.com/u/9059378?v=4","gravatar_id":"","url":"https://api.github.com/users/Vinno97","html_url":"https://github.com/Vinno97","followers_url":"https://api.github.com/users/Vinno97/followers","following_url":"https://api.github.com/users/Vinno97/following{/other_user}","gists_url":"https://api.github.com/users/Vinno97/gists{/gist_id}","starred_url":"https://api.github.com/users/Vinno97/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vinno97/subscriptions","organizations_url":"https://api.github.com/users/Vinno97/orgs","repos_url":"https://api.github.com/users/Vinno97/repos","events_url":"https://api.github.com/users/Vinno97/events{/privacy}","received_events_url":"https://api.github.com/users/Vinno97/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Vinno97/prism","description":null,"fork":false,"url":"https://api.github.com/repos/Vinno97/prism","forks_url":"https://api.github.com/repos/Vinno97/prism/forks","keys_url":"https://api.github.com/repos/Vinno97/prism/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Vinno97/prism/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Vinno97/prism/teams","hooks_url":"https://api.github.com/repos/Vinno97/prism/hooks","issue_events_url":"https://api.github.com/repos/Vinno97/prism/issues/events{/number}","events_url":"https://api.github.com/repos/Vinno97/prism/events","assignees_url":"https://api.github.com/repos/Vinno97/prism/assignees{/user}","branches_url":"https://api.github.com/repos/Vinno97/prism/branches{/branch}","tags_url":"https://api.github.com/repos/Vinno97/prism/tags","blobs_url":"https://api.github.com/repos/Vinno97/prism/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Vinno97/prism/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Vinno97/prism/git/refs{/sha}","trees_url":"https://api.github.com/repos/Vinno97/prism/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Vinno97/prism/statuses/{sha}","languages_url":"https://api.github.com/repos/Vinno97/prism/languages","stargazers_url":"https://api.github.com/repos/Vinno97/prism/stargazers","contributors_url":"https://api.github.com/repos/Vinno97/prism/contributors","subscribers_url":"https://api.github.com/repos/Vinno97/prism/subscribers","subscription_url":"https://api.github.com/repos/Vinno97/prism/subscription","commits_url":"https://api.github.com/repos/Vinno97/prism/commits{/sha}","git_commits_url":"https://api.github.com/repos/Vinno97/prism/git/commits{/sha}","comments_url":"https://api.github.com/repos/Vinno97/prism/comments{/number}","issue_comment_url":"https://api.github.com/repos/Vinno97/prism/issues/comments{/number}","contents_url":"https://api.github.com/repos/Vinno97/prism/contents/{+path}","compare_url":"https://api.github.com/repos/Vinno97/prism/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Vinno97/prism/merges","archive_url":"https://api.github.com/repos/Vinno97/prism/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Vinno97/prism/downloads","issues_url":"https://api.github.com/repos/Vinno97/prism/issues{/number}","pulls_url":"https://api.github.com/repos/Vinno97/prism/pulls{/number}","milestones_url":"https://api.github.com/repos/Vinno97/prism/milestones{/number}","notifications_url":"https://api.github.com/repos/Vinno97/prism/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Vinno97/prism/labels{/name}","releases_url":"https://api.github.com/repos/Vinno97/prism/releases{/id}","deployments_url":"https://api.github.com/repos/Vinno97/prism/deployments","created_at":"2018-09-06T12:10:47Z","updated_at":"2018-11-29T12:53:56Z","pushed_at":"2018-12-03T13:45:00Z","git_url":"git://github.com/Vinno97/prism.git","ssh_url":"git@github.com:Vinno97/prism.git","clone_url":"https://github.com/Vinno97/prism.git","svn_url":"https://github.com/Vinno97/prism","homepage":null,"size":187754,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":16,"license":null,"forks":0,"open_issues":16,"watchers":0,"default_branch":"master"}},"base":{"label":"Vinno97:development","ref":"development","sha":"40984f9df8fa79c3b2fbc4031e2b0ff863c59717","user":{"login":"Vinno97","id":9059378,"node_id":"MDQ6VXNlcjkwNTkzNzg=","avatar_url":"https://avatars2.githubusercontent.com/u/9059378?v=4","gravatar_id":"","url":"https://api.github.com/users/Vinno97","html_url":"https://github.com/Vinno97","followers_url":"https://api.github.com/users/Vinno97/followers","following_url":"https://api.github.com/users/Vinno97/following{/other_user}","gists_url":"https://api.github.com/users/Vinno97/gists{/gist_id}","starred_url":"https://api.github.com/users/Vinno97/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vinno97/subscriptions","organizations_url":"https://api.github.com/users/Vinno97/orgs","repos_url":"https://api.github.com/users/Vinno97/repos","events_url":"https://api.github.com/users/Vinno97/events{/privacy}","received_events_url":"https://api.github.com/users/Vinno97/received_events","type":"User","site_admin":false},"repo":{"id":147668071,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc2NjgwNzE=","name":"prism","full_name":"Vinno97/prism","private":false,"owner":{"login":"Vinno97","id":9059378,"node_id":"MDQ6VXNlcjkwNTkzNzg=","avatar_url":"https://avatars2.githubusercontent.com/u/9059378?v=4","gravatar_id":"","url":"https://api.github.com/users/Vinno97","html_url":"https://github.com/Vinno97","followers_url":"https://api.github.com/users/Vinno97/followers","following_url":"https://api.github.com/users/Vinno97/following{/other_user}","gists_url":"https://api.github.com/users/Vinno97/gists{/gist_id}","starred_url":"https://api.github.com/users/Vinno97/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vinno97/subscriptions","organizations_url":"https://api.github.com/users/Vinno97/orgs","repos_url":"https://api.github.com/users/Vinno97/repos","events_url":"https://api.github.com/users/Vinno97/events{/privacy}","received_events_url":"https://api.github.com/users/Vinno97/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Vinno97/prism","description":null,"fork":false,"url":"https://api.github.com/repos/Vinno97/prism","forks_url":"https://api.github.com/repos/Vinno97/prism/forks","keys_url":"https://api.github.com/repos/Vinno97/prism/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Vinno97/prism/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Vinno97/prism/teams","hooks_url":"https://api.github.com/repos/Vinno97/prism/hooks","issue_events_url":"https://api.github.com/repos/Vinno97/prism/issues/events{/number}","events_url":"https://api.github.com/repos/Vinno97/prism/events","assignees_url":"https://api.github.com/repos/Vinno97/prism/assignees{/user}","branches_url":"https://api.github.com/repos/Vinno97/prism/branches{/branch}","tags_url":"https://api.github.com/repos/Vinno97/prism/tags","blobs_url":"https://api.github.com/repos/Vinno97/prism/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Vinno97/prism/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Vinno97/prism/git/refs{/sha}","trees_url":"https://api.github.com/repos/Vinno97/prism/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Vinno97/prism/statuses/{sha}","languages_url":"https://api.github.com/repos/Vinno97/prism/languages","stargazers_url":"https://api.github.com/repos/Vinno97/prism/stargazers","contributors_url":"https://api.github.com/repos/Vinno97/prism/contributors","subscribers_url":"https://api.github.com/repos/Vinno97/prism/subscribers","subscription_url":"https://api.github.com/repos/Vinno97/prism/subscription","commits_url":"https://api.github.com/repos/Vinno97/prism/commits{/sha}","git_commits_url":"https://api.github.com/repos/Vinno97/prism/git/commits{/sha}","comments_url":"https://api.github.com/repos/Vinno97/prism/comments{/number}","issue_comment_url":"https://api.github.com/repos/Vinno97/prism/issues/comments{/number}","contents_url":"https://api.github.com/repos/Vinno97/prism/contents/{+path}","compare_url":"https://api.github.com/repos/Vinno97/prism/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Vinno97/prism/merges","archive_url":"https://api.github.com/repos/Vinno97/prism/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Vinno97/prism/downloads","issues_url":"https://api.github.com/repos/Vinno97/prism/issues{/number}","pulls_url":"https://api.github.com/repos/Vinno97/prism/pulls{/number}","milestones_url":"https://api.github.com/repos/Vinno97/prism/milestones{/number}","notifications_url":"https://api.github.com/repos/Vinno97/prism/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Vinno97/prism/labels{/name}","releases_url":"https://api.github.com/repos/Vinno97/prism/releases{/id}","deployments_url":"https://api.github.com/repos/Vinno97/prism/deployments","created_at":"2018-09-06T12:10:47Z","updated_at":"2018-11-29T12:53:56Z","pushed_at":"2018-12-03T13:45:00Z","git_url":"git://github.com/Vinno97/prism.git","ssh_url":"git@github.com:Vinno97/prism.git","clone_url":"https://github.com/Vinno97/prism.git","svn_url":"https://github.com/Vinno97/prism","homepage":null,"size":187754,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":16,"license":null,"forks":0,"open_issues":16,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Vinno97/prism/pulls/75"},"html":{"href":"https://github.com/Vinno97/prism/pull/75"},"issue":{"href":"https://api.github.com/repos/Vinno97/prism/issues/75"},"comments":{"href":"https://api.github.com/repos/Vinno97/prism/issues/75/comments"},"review_comments":{"href":"https://api.github.com/repos/Vinno97/prism/pulls/75/comments"},"review_comment":{"href":"https://api.github.com/repos/Vinno97/prism/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Vinno97/prism/pulls/75/commits"},"statuses":{"href":"https://api.github.com/repos/Vinno97/prism/statuses/5d189daad89a2fff473ccfcf5fe0439bdb1f25f4"}},"author_association":"OWNER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"Vinno97","id":9059378,"node_id":"MDQ6VXNlcjkwNTkzNzg=","avatar_url":"https://avatars2.githubusercontent.com/u/9059378?v=4","gravatar_id":"","url":"https://api.github.com/users/Vinno97","html_url":"https://github.com/Vinno97","followers_url":"https://api.github.com/users/Vinno97/followers","following_url":"https://api.github.com/users/Vinno97/following{/other_user}","gists_url":"https://api.github.com/users/Vinno97/gists{/gist_id}","starred_url":"https://api.github.com/users/Vinno97/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Vinno97/subscriptions","organizations_url":"https://api.github.com/users/Vinno97/orgs","repos_url":"https://api.github.com/users/Vinno97/repos","events_url":"https://api.github.com/users/Vinno97/events{/privacy}","received_events_url":"https://api.github.com/users/Vinno97/received_events","type":"User","site_admin":false},"comments":0,"review_comments":1,"maintainer_can_modify":false,"commits":20,"additions":728,"deletions":611,"changed_files":64}}
{"actor":{"display_login":"Vinno97"}}