{"action":"created","issue":{"url":"https://api.github.com/repos/websockets-rs/rust-websocket/issues/192","repository_url":"https://api.github.com/repos/websockets-rs/rust-websocket","labels_url":"https://api.github.com/repos/websockets-rs/rust-websocket/issues/192/labels{/name}","comments_url":"https://api.github.com/repos/websockets-rs/rust-websocket/issues/192/comments","events_url":"https://api.github.com/repos/websockets-rs/rust-websocket/issues/192/events","html_url":"https://github.com/websockets-rs/rust-websocket/issues/192","id":371386259,"node_id":"MDU6SXNzdWUzNzEzODYyNTk=","number":192,"title":"Merge changes from enzious/rust-websocket","user":{"login":"marcelbuesing","id":5637837,"node_id":"MDQ6VXNlcjU2Mzc4Mzc=","avatar_url":"https://avatars3.githubusercontent.com/u/5637837?v=4","gravatar_id":"","url":"https://api.github.com/users/marcelbuesing","html_url":"https://github.com/marcelbuesing","followers_url":"https://api.github.com/users/marcelbuesing/followers","following_url":"https://api.github.com/users/marcelbuesing/following{/other_user}","gists_url":"https://api.github.com/users/marcelbuesing/gists{/gist_id}","starred_url":"https://api.github.com/users/marcelbuesing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcelbuesing/subscriptions","organizations_url":"https://api.github.com/users/marcelbuesing/orgs","repos_url":"https://api.github.com/users/marcelbuesing/repos","events_url":"https://api.github.com/users/marcelbuesing/events{/privacy}","received_events_url":"https://api.github.com/users/marcelbuesing/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-10-18T06:56:36Z","updated_at":"2018-10-19T13:39:12Z","closed_at":null,"author_association":"NONE","body":"I think it would be great to have the changes from [enzious/rust-websocket](https://github.com/enzious/rust-websocket) back in websockets-rs/rust-websocket and published as a new crate version.\r\n\r\nMajor benefit is it contains the tokio reform changes. \r\n\r\nBefore being merged I think this still needs https://github.com/enzious/rust-websocket/pull/5/files to remove the dependency to `git = \"https://github.com/enzious/tokio-tls\"`.\r\n\r\nI have also created an issue within the project but there appears to be no response.\r\nhttps://github.com/enzious/rust-websocket/issues/6"},"comment":{"url":"https://api.github.com/repos/websockets-rs/rust-websocket/issues/comments/431366360","html_url":"https://github.com/websockets-rs/rust-websocket/issues/192#issuecomment-431366360","issue_url":"https://api.github.com/repos/websockets-rs/rust-websocket/issues/192","id":431366360,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMTM2NjM2MA==","user":{"login":"marcelbuesing","id":5637837,"node_id":"MDQ6VXNlcjU2Mzc4Mzc=","avatar_url":"https://avatars3.githubusercontent.com/u/5637837?v=4","gravatar_id":"","url":"https://api.github.com/users/marcelbuesing","html_url":"https://github.com/marcelbuesing","followers_url":"https://api.github.com/users/marcelbuesing/followers","following_url":"https://api.github.com/users/marcelbuesing/following{/other_user}","gists_url":"https://api.github.com/users/marcelbuesing/gists{/gist_id}","starred_url":"https://api.github.com/users/marcelbuesing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcelbuesing/subscriptions","organizations_url":"https://api.github.com/users/marcelbuesing/orgs","repos_url":"https://api.github.com/users/marcelbuesing/repos","events_url":"https://api.github.com/users/marcelbuesing/events{/privacy}","received_events_url":"https://api.github.com/users/marcelbuesing/received_events","type":"User","site_admin":false},"created_at":"2018-10-19T13:39:12Z","updated_at":"2018-10-19T13:39:12Z","author_association":"NONE","body":"@enzious thanks for that! Just to mention that the *http* changes are due hyper v12 using the http types right? So this is another great feature in the merge request. I'll try to find some time to look deeper into those changes.\r\n> replace types with those from http crate (3cd48b45) \r\n[Hyper Changelog](https://github.com/hyperium/hyper/blob/master/CHANGELOG.md)"}}
{"actor":{"display_login":"marcelbuesing"}}