{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/245491555","pull_request_review_id":189611668,"id":245491555,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTQ5MTU1NQ==","diff_hunk":"@@ -1,8 +1,9 @@\n { stdenv, fetchurl, pkgconfig, freetype, lcms, libtiff, libxml2\n , libart_lgpl, qt4, python2, cups, fontconfig, libjpeg\n-, zlib, libpng, xorg, cairo, podofo, aspell, boost, cmake }:\n+, zlib, libpng, xorg, cairo, podofo, aspell, boost, cmake, imagemagick }:\n \n let\n+  icon = ./icon.svg;","path":"pkgs/applications/office/scribus/default.nix","position":7,"original_position":7,"commit_id":"ee4f73c472ae2b40845bf44a2f45ea2a44997d29","original_commit_id":"ee4f73c472ae2b40845bf44a2f45ea2a44997d29","user":{"login":"matthewbauer","id":19036,"node_id":"MDQ6VXNlcjE5MDM2","avatar_url":"https://avatars0.githubusercontent.com/u/19036?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewbauer","html_url":"https://github.com/matthewbauer","followers_url":"https://api.github.com/users/matthewbauer/followers","following_url":"https://api.github.com/users/matthewbauer/following{/other_user}","gists_url":"https://api.github.com/users/matthewbauer/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewbauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewbauer/subscriptions","organizations_url":"https://api.github.com/users/matthewbauer/orgs","repos_url":"https://api.github.com/users/matthewbauer/repos","events_url":"https://api.github.com/users/matthewbauer/events{/privacy}","received_events_url":"https://api.github.com/users/matthewbauer/received_events","type":"User","site_admin":false},"body":"Can we download this from somewhere? Ideally it would be included in the the src","created_at":"2019-01-05T23:21:07Z","updated_at":"2019-01-05T23:21:07Z","html_url":"https://github.com/NixOS/nixpkgs/pull/53456#discussion_r245491555","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/53456","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/245491555"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/53456#discussion_r245491555"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/53456"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/53456","id":242453636,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQyNDUzNjM2","html_url":"https://github.com/NixOS/nixpkgs/pull/53456","diff_url":"https://github.com/NixOS/nixpkgs/pull/53456.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/53456.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/53456","number":53456,"state":"open","locked":false,"title":"scribus: Add an icon","user":{"login":"ejpcmac","id":6207605,"node_id":"MDQ6VXNlcjYyMDc2MDU=","avatar_url":"https://avatars2.githubusercontent.com/u/6207605?v=4","gravatar_id":"","url":"https://api.github.com/users/ejpcmac","html_url":"https://github.com/ejpcmac","followers_url":"https://api.github.com/users/ejpcmac/followers","following_url":"https://api.github.com/users/ejpcmac/following{/other_user}","gists_url":"https://api.github.com/users/ejpcmac/gists{/gist_id}","starred_url":"https://api.github.com/users/ejpcmac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ejpcmac/subscriptions","organizations_url":"https://api.github.com/users/ejpcmac/orgs","repos_url":"https://api.github.com/users/ejpcmac/repos","events_url":"https://api.github.com/users/ejpcmac/events{/privacy}","received_events_url":"https://api.github.com/users/ejpcmac/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\n\r\nScribus has no desktop icon currently. I’ve checked in the source tarball, and there is nothing good here: only a low-res icon.\r\n\r\n###### Things done\r\n\r\nI’ve got a SVG file from [this page](https://wiki.scribus.net/canvas/Promotion_material) on the Scribus Wiki and edited it a bit to get a square file and center the circle. Since the icon is not present in the source tarball, I’ve put this resource in `nixpkgs`. I’m not sure if it is a good thing or not, let me know if you have a better idea on how to do this.\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [ ] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [x] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)\r\n- [ ] Assured whether relevant documentation is up to date\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\nI have also checked the possibility to backport it to `release-18.09`: it would require one more action to create the `.desktop` file since Scribus 1.4.6 does not include one. I have already defined one for a wrapper in my [Nix channel](https://github.com/ejpcmac/jpc-nix/blob/master/pkgs/scribus-with-icon/default.nix#L6-L13) so I could port it easily to `release-18.09` if it is OK to proceed.","created_at":"2019-01-05T18:26:43Z","updated_at":"2019-01-05T23:21:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"869cc9643862d6ee2814505b04ad790dc6e02820","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":737642262,"node_id":"MDU6TGFiZWw3Mzc2NDIyNjI=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%200","name":"10.rebuild-darwin: 0","color":"eeffee","default":false},{"id":731733923,"node_id":"MDU6TGFiZWw3MzE3MzM5MjM=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%201-10","name":"10.rebuild-linux: 1-10","color":"eeffee","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/53456/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/53456/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/53456/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/ee4f73c472ae2b40845bf44a2f45ea2a44997d29","head":{"label":"ejpcmac:fix-scribus-icon","ref":"fix-scribus-icon","sha":"ee4f73c472ae2b40845bf44a2f45ea2a44997d29","user":{"login":"ejpcmac","id":6207605,"node_id":"MDQ6VXNlcjYyMDc2MDU=","avatar_url":"https://avatars2.githubusercontent.com/u/6207605?v=4","gravatar_id":"","url":"https://api.github.com/users/ejpcmac","html_url":"https://github.com/ejpcmac","followers_url":"https://api.github.com/users/ejpcmac/followers","following_url":"https://api.github.com/users/ejpcmac/following{/other_user}","gists_url":"https://api.github.com/users/ejpcmac/gists{/gist_id}","starred_url":"https://api.github.com/users/ejpcmac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ejpcmac/subscriptions","organizations_url":"https://api.github.com/users/ejpcmac/orgs","repos_url":"https://api.github.com/users/ejpcmac/repos","events_url":"https://api.github.com/users/ejpcmac/events{/privacy}","received_events_url":"https://api.github.com/users/ejpcmac/received_events","type":"User","site_admin":false},"repo":{"id":145604133,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU2MDQxMzM=","name":"nixpkgs","full_name":"ejpcmac/nixpkgs","private":false,"owner":{"login":"ejpcmac","id":6207605,"node_id":"MDQ6VXNlcjYyMDc2MDU=","avatar_url":"https://avatars2.githubusercontent.com/u/6207605?v=4","gravatar_id":"","url":"https://api.github.com/users/ejpcmac","html_url":"https://github.com/ejpcmac","followers_url":"https://api.github.com/users/ejpcmac/followers","following_url":"https://api.github.com/users/ejpcmac/following{/other_user}","gists_url":"https://api.github.com/users/ejpcmac/gists{/gist_id}","starred_url":"https://api.github.com/users/ejpcmac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ejpcmac/subscriptions","organizations_url":"https://api.github.com/users/ejpcmac/orgs","repos_url":"https://api.github.com/users/ejpcmac/repos","events_url":"https://api.github.com/users/ejpcmac/events{/privacy}","received_events_url":"https://api.github.com/users/ejpcmac/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ejpcmac/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/ejpcmac/nixpkgs","forks_url":"https://api.github.com/repos/ejpcmac/nixpkgs/forks","keys_url":"https://api.github.com/repos/ejpcmac/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ejpcmac/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ejpcmac/nixpkgs/teams","hooks_url":"https://api.github.com/repos/ejpcmac/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/ejpcmac/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/ejpcmac/nixpkgs/events","assignees_url":"https://api.github.com/repos/ejpcmac/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/ejpcmac/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/ejpcmac/nixpkgs/tags","blobs_url":"https://api.github.com/repos/ejpcmac/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ejpcmac/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ejpcmac/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ejpcmac/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ejpcmac/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/ejpcmac/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/ejpcmac/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/ejpcmac/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/ejpcmac/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/ejpcmac/nixpkgs/subscription","commits_url":"https://api.github.com/repos/ejpcmac/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ejpcmac/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ejpcmac/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ejpcmac/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ejpcmac/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/ejpcmac/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ejpcmac/nixpkgs/merges","archive_url":"https://api.github.com/repos/ejpcmac/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ejpcmac/nixpkgs/downloads","issues_url":"https://api.github.com/repos/ejpcmac/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/ejpcmac/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/ejpcmac/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/ejpcmac/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ejpcmac/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/ejpcmac/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/ejpcmac/nixpkgs/deployments","created_at":"2018-08-21T18:33:10Z","updated_at":"2019-01-05T17:04:28Z","pushed_at":"2019-01-05T17:16:18Z","git_url":"git://github.com/ejpcmac/nixpkgs.git","ssh_url":"git@github.com:ejpcmac/nixpkgs.git","clone_url":"https://github.com/ejpcmac/nixpkgs.git","svn_url":"https://github.com/ejpcmac/nixpkgs","homepage":null,"size":849659,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"e5512a158c96d370f6ee5b54c6f2e66e5b900b0f","user":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"node_id":"MDEwOlJlcG9zaXRvcnk0NTQyNzE2","name":"nixpkgs","full_name":"NixOS/nixpkgs","private":false,"owner":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2019-01-05T22:13:09Z","pushed_at":"2019-01-05T23:10:07Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":907679,"stargazers_count":3149,"watchers_count":3149,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3307,"mirror_url":null,"archived":false,"open_issues_count":3579,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3307,"open_issues":3579,"watchers":3149,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/53456"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/53456"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/53456"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/53456/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/53456/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/53456/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/ee4f73c472ae2b40845bf44a2f45ea2a44997d29"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"matthewbauer"}}