{"action":"created","comment":{"url":"https://api.github.com/repos/opentracing/opentracing-javascript/pulls/comments/170459690","pull_request_review_id":99149412,"id":170459690,"diff_hunk":"@@ -14,7 +15,7 @@ export interface ApiCompatibilityChecksOptions {\n  * @param {object} createTracer - a factory function that allocates a tracer.\n  * @param {object} [options] - the options to be set on api compatibility\n  */\n-export function apiCompatibilityChecks(createTracer = () => new Tracer(), options: ApiCompatibilityChecksOptions = {}): void {\n+function apiCompatibilityChecks(createTracer = () => new Tracer(), options: ApiCompatibilityChecksOptions = {checkInjectBehaviour: true}): void {","path":"src/test/api_compatibility.ts","position":16,"original_position":16,"commit_id":"e1a5dd0aa3a385ef52d41a5493382a904aef30bb","original_commit_id":"e1a5dd0aa3a385ef52d41a5493382a904aef30bb","user":{"login":"yurishkuro","id":3523016,"avatar_url":"https://avatars2.githubusercontent.com/u/3523016?v=4","gravatar_id":"","url":"https://api.github.com/users/yurishkuro","html_url":"https://github.com/yurishkuro","followers_url":"https://api.github.com/users/yurishkuro/followers","following_url":"https://api.github.com/users/yurishkuro/following{/other_user}","gists_url":"https://api.github.com/users/yurishkuro/gists{/gist_id}","starred_url":"https://api.github.com/users/yurishkuro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yurishkuro/subscriptions","organizations_url":"https://api.github.com/users/yurishkuro/orgs","repos_url":"https://api.github.com/users/yurishkuro/repos","events_url":"https://api.github.com/users/yurishkuro/events{/privacy}","received_events_url":"https://api.github.com/users/yurishkuro/received_events","type":"User","site_admin":false},"body":"`{checkInjectBehaviour: true}` - this is not sufficient. If someone overrides the Options for another reason, e.g. to skip baggage checks, the default for `checkInjectBehaviour` again reverts to false. That's why it should be a property with a negative name, i.e. `skipXyzChecks`, so that only when someone explicitly opts-in the checks will be skipped.\r\n\r\nSame applies to baggage, we should rename it to `skipBaggageChecks`","created_at":"2018-02-25T17:20:45Z","updated_at":"2018-02-25T17:25:09Z","html_url":"https://github.com/opentracing/opentracing-javascript/pull/98#discussion_r170459690","pull_request_url":"https://api.github.com/repos/opentracing/opentracing-javascript/pulls/98","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/opentracing/opentracing-javascript/pulls/comments/170459690"},"html":{"href":"https://github.com/opentracing/opentracing-javascript/pull/98#discussion_r170459690"},"pull_request":{"href":"https://api.github.com/repos/opentracing/opentracing-javascript/pulls/98"}}},"pull_request":{"url":"https://api.github.com/repos/opentracing/opentracing-javascript/pulls/98","id":171173509,"html_url":"https://github.com/opentracing/opentracing-javascript/pull/98","diff_url":"https://github.com/opentracing/opentracing-javascript/pull/98.diff","patch_url":"https://github.com/opentracing/opentracing-javascript/pull/98.patch","issue_url":"https://api.github.com/repos/opentracing/opentracing-javascript/issues/98","number":98,"state":"open","locked":false,"title":"export mock tracer via standard package","user":{"login":"AloisReitbauer","id":478193,"avatar_url":"https://avatars1.githubusercontent.com/u/478193?v=4","gravatar_id":"","url":"https://api.github.com/users/AloisReitbauer","html_url":"https://github.com/AloisReitbauer","followers_url":"https://api.github.com/users/AloisReitbauer/followers","following_url":"https://api.github.com/users/AloisReitbauer/following{/other_user}","gists_url":"https://api.github.com/users/AloisReitbauer/gists{/gist_id}","starred_url":"https://api.github.com/users/AloisReitbauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AloisReitbauer/subscriptions","organizations_url":"https://api.github.com/users/AloisReitbauer/orgs","repos_url":"https://api.github.com/users/AloisReitbauer/repos","events_url":"https://api.github.com/users/AloisReitbauer/events{/privacy}","received_events_url":"https://api.github.com/users/AloisReitbauer/received_events","type":"User","site_admin":false},"body":"fixed issue #96 ","created_at":"2018-02-24T10:48:43Z","updated_at":"2018-02-25T17:25:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2d9cdbaeb1c59df256460df1a8ed62b3c0abfbaa","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/opentracing/opentracing-javascript/pulls/98/commits","review_comments_url":"https://api.github.com/repos/opentracing/opentracing-javascript/pulls/98/comments","review_comment_url":"https://api.github.com/repos/opentracing/opentracing-javascript/pulls/comments{/number}","comments_url":"https://api.github.com/repos/opentracing/opentracing-javascript/issues/98/comments","statuses_url":"https://api.github.com/repos/opentracing/opentracing-javascript/statuses/e1a5dd0aa3a385ef52d41a5493382a904aef30bb","head":{"label":"AloisReitbauer:master","ref":"master","sha":"e1a5dd0aa3a385ef52d41a5493382a904aef30bb","user":{"login":"AloisReitbauer","id":478193,"avatar_url":"https://avatars1.githubusercontent.com/u/478193?v=4","gravatar_id":"","url":"https://api.github.com/users/AloisReitbauer","html_url":"https://github.com/AloisReitbauer","followers_url":"https://api.github.com/users/AloisReitbauer/followers","following_url":"https://api.github.com/users/AloisReitbauer/following{/other_user}","gists_url":"https://api.github.com/users/AloisReitbauer/gists{/gist_id}","starred_url":"https://api.github.com/users/AloisReitbauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AloisReitbauer/subscriptions","organizations_url":"https://api.github.com/users/AloisReitbauer/orgs","repos_url":"https://api.github.com/users/AloisReitbauer/repos","events_url":"https://api.github.com/users/AloisReitbauer/events{/privacy}","received_events_url":"https://api.github.com/users/AloisReitbauer/received_events","type":"User","site_admin":false},"repo":{"id":122730994,"name":"opentracing-javascript","full_name":"AloisReitbauer/opentracing-javascript","owner":{"login":"AloisReitbauer","id":478193,"avatar_url":"https://avatars1.githubusercontent.com/u/478193?v=4","gravatar_id":"","url":"https://api.github.com/users/AloisReitbauer","html_url":"https://github.com/AloisReitbauer","followers_url":"https://api.github.com/users/AloisReitbauer/followers","following_url":"https://api.github.com/users/AloisReitbauer/following{/other_user}","gists_url":"https://api.github.com/users/AloisReitbauer/gists{/gist_id}","starred_url":"https://api.github.com/users/AloisReitbauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AloisReitbauer/subscriptions","organizations_url":"https://api.github.com/users/AloisReitbauer/orgs","repos_url":"https://api.github.com/users/AloisReitbauer/repos","events_url":"https://api.github.com/users/AloisReitbauer/events{/privacy}","received_events_url":"https://api.github.com/users/AloisReitbauer/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AloisReitbauer/opentracing-javascript","description":"OpenTracing API for Javascript (both Node and browser)","fork":true,"url":"https://api.github.com/repos/AloisReitbauer/opentracing-javascript","forks_url":"https://api.github.com/repos/AloisReitbauer/opentracing-javascript/forks","keys_url":"https://api.github.com/repos/AloisReitbauer/opentracing-javascript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AloisReitbauer/opentracing-javascript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AloisReitbauer/opentracing-javascript/teams","hooks_url":"https://api.github.com/repos/AloisReitbauer/opentracing-javascript/hooks","issue_events_url":"https://api.github.com/repos/AloisReitbauer/opentracing-javascript/issues/events{/number}","events_url":"https://api.github.com/repos/AloisReitbauer/opentracing-javascript/events","assignees_url":"https://api.github.com/repos/AloisReitbauer/opentracing-javascript/assignees{/user}","branches_url":"https://api.github.com/repos/AloisReitbauer/opentracing-javascript/branches{/branch}","tags_url":"https://api.github.com/repos/AloisReitbauer/opentracing-javascript/tags","blobs_url":"https://api.github.com/repos/AloisReitbauer/opentracing-javascript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AloisReitbauer/opentracing-javascript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AloisReitbauer/opentracing-javascript/git/refs{/sha}","trees_url":"https://api.github.com/repos/AloisReitbauer/opentracing-javascript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AloisReitbauer/opentracing-javascript/statuses/{sha}","languages_url":"https://api.github.com/repos/AloisReitbauer/opentracing-javascript/languages","stargazers_url":"https://api.github.com/repos/AloisReitbauer/opentracing-javascript/stargazers","contributors_url":"https://api.github.com/repos/AloisReitbauer/opentracing-javascript/contributors","subscribers_url":"https://api.github.com/repos/AloisReitbauer/opentracing-javascript/subscribers","subscription_url":"https://api.github.com/repos/AloisReitbauer/opentracing-javascript/subscription","commits_url":"https://api.github.com/repos/AloisReitbauer/opentracing-javascript/commits{/sha}","git_commits_url":"https://api.github.com/repos/AloisReitbauer/opentracing-javascript/git/commits{/sha}","comments_url":"https://api.github.com/repos/AloisReitbauer/opentracing-javascript/comments{/number}","issue_comment_url":"https://api.github.com/repos/AloisReitbauer/opentracing-javascript/issues/comments{/number}","contents_url":"https://api.github.com/repos/AloisReitbauer/opentracing-javascript/contents/{+path}","compare_url":"https://api.github.com/repos/AloisReitbauer/opentracing-javascript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AloisReitbauer/opentracing-javascript/merges","archive_url":"https://api.github.com/repos/AloisReitbauer/opentracing-javascript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AloisReitbauer/opentracing-javascript/downloads","issues_url":"https://api.github.com/repos/AloisReitbauer/opentracing-javascript/issues{/number}","pulls_url":"https://api.github.com/repos/AloisReitbauer/opentracing-javascript/pulls{/number}","milestones_url":"https://api.github.com/repos/AloisReitbauer/opentracing-javascript/milestones{/number}","notifications_url":"https://api.github.com/repos/AloisReitbauer/opentracing-javascript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AloisReitbauer/opentracing-javascript/labels{/name}","releases_url":"https://api.github.com/repos/AloisReitbauer/opentracing-javascript/releases{/id}","deployments_url":"https://api.github.com/repos/AloisReitbauer/opentracing-javascript/deployments","created_at":"2018-02-24T10:38:08Z","updated_at":"2018-02-24T10:38:10Z","pushed_at":"2018-02-25T16:39:38Z","git_url":"git://github.com/AloisReitbauer/opentracing-javascript.git","ssh_url":"git@github.com:AloisReitbauer/opentracing-javascript.git","clone_url":"https://github.com/AloisReitbauer/opentracing-javascript.git","svn_url":"https://github.com/AloisReitbauer/opentracing-javascript","homepage":"http://opentracing.io","size":287,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"opentracing:master","ref":"master","sha":"1f32ae4aa77b866dce23ef6e33a3b9b08d458171","user":{"login":"opentracing","id":15482765,"avatar_url":"https://avatars1.githubusercontent.com/u/15482765?v=4","gravatar_id":"","url":"https://api.github.com/users/opentracing","html_url":"https://github.com/opentracing","followers_url":"https://api.github.com/users/opentracing/followers","following_url":"https://api.github.com/users/opentracing/following{/other_user}","gists_url":"https://api.github.com/users/opentracing/gists{/gist_id}","starred_url":"https://api.github.com/users/opentracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentracing/subscriptions","organizations_url":"https://api.github.com/users/opentracing/orgs","repos_url":"https://api.github.com/users/opentracing/repos","events_url":"https://api.github.com/users/opentracing/events{/privacy}","received_events_url":"https://api.github.com/users/opentracing/received_events","type":"Organization","site_admin":false},"repo":{"id":49756910,"name":"opentracing-javascript","full_name":"opentracing/opentracing-javascript","owner":{"login":"opentracing","id":15482765,"avatar_url":"https://avatars1.githubusercontent.com/u/15482765?v=4","gravatar_id":"","url":"https://api.github.com/users/opentracing","html_url":"https://github.com/opentracing","followers_url":"https://api.github.com/users/opentracing/followers","following_url":"https://api.github.com/users/opentracing/following{/other_user}","gists_url":"https://api.github.com/users/opentracing/gists{/gist_id}","starred_url":"https://api.github.com/users/opentracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/opentracing/subscriptions","organizations_url":"https://api.github.com/users/opentracing/orgs","repos_url":"https://api.github.com/users/opentracing/repos","events_url":"https://api.github.com/users/opentracing/events{/privacy}","received_events_url":"https://api.github.com/users/opentracing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/opentracing/opentracing-javascript","description":"OpenTracing API for Javascript (both Node and browser)","fork":false,"url":"https://api.github.com/repos/opentracing/opentracing-javascript","forks_url":"https://api.github.com/repos/opentracing/opentracing-javascript/forks","keys_url":"https://api.github.com/repos/opentracing/opentracing-javascript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/opentracing/opentracing-javascript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/opentracing/opentracing-javascript/teams","hooks_url":"https://api.github.com/repos/opentracing/opentracing-javascript/hooks","issue_events_url":"https://api.github.com/repos/opentracing/opentracing-javascript/issues/events{/number}","events_url":"https://api.github.com/repos/opentracing/opentracing-javascript/events","assignees_url":"https://api.github.com/repos/opentracing/opentracing-javascript/assignees{/user}","branches_url":"https://api.github.com/repos/opentracing/opentracing-javascript/branches{/branch}","tags_url":"https://api.github.com/repos/opentracing/opentracing-javascript/tags","blobs_url":"https://api.github.com/repos/opentracing/opentracing-javascript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/opentracing/opentracing-javascript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/opentracing/opentracing-javascript/git/refs{/sha}","trees_url":"https://api.github.com/repos/opentracing/opentracing-javascript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/opentracing/opentracing-javascript/statuses/{sha}","languages_url":"https://api.github.com/repos/opentracing/opentracing-javascript/languages","stargazers_url":"https://api.github.com/repos/opentracing/opentracing-javascript/stargazers","contributors_url":"https://api.github.com/repos/opentracing/opentracing-javascript/contributors","subscribers_url":"https://api.github.com/repos/opentracing/opentracing-javascript/subscribers","subscription_url":"https://api.github.com/repos/opentracing/opentracing-javascript/subscription","commits_url":"https://api.github.com/repos/opentracing/opentracing-javascript/commits{/sha}","git_commits_url":"https://api.github.com/repos/opentracing/opentracing-javascript/git/commits{/sha}","comments_url":"https://api.github.com/repos/opentracing/opentracing-javascript/comments{/number}","issue_comment_url":"https://api.github.com/repos/opentracing/opentracing-javascript/issues/comments{/number}","contents_url":"https://api.github.com/repos/opentracing/opentracing-javascript/contents/{+path}","compare_url":"https://api.github.com/repos/opentracing/opentracing-javascript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/opentracing/opentracing-javascript/merges","archive_url":"https://api.github.com/repos/opentracing/opentracing-javascript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/opentracing/opentracing-javascript/downloads","issues_url":"https://api.github.com/repos/opentracing/opentracing-javascript/issues{/number}","pulls_url":"https://api.github.com/repos/opentracing/opentracing-javascript/pulls{/number}","milestones_url":"https://api.github.com/repos/opentracing/opentracing-javascript/milestones{/number}","notifications_url":"https://api.github.com/repos/opentracing/opentracing-javascript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/opentracing/opentracing-javascript/labels{/name}","releases_url":"https://api.github.com/repos/opentracing/opentracing-javascript/releases{/id}","deployments_url":"https://api.github.com/repos/opentracing/opentracing-javascript/deployments","created_at":"2016-01-16T03:04:55Z","updated_at":"2018-02-25T15:28:34Z","pushed_at":"2018-02-25T16:39:39Z","git_url":"git://github.com/opentracing/opentracing-javascript.git","ssh_url":"git@github.com:opentracing/opentracing-javascript.git","clone_url":"https://github.com/opentracing/opentracing-javascript.git","svn_url":"https://github.com/opentracing/opentracing-javascript","homepage":"http://opentracing.io","size":256,"stargazers_count":369,"watchers_count":369,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":40,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":40,"open_issues":20,"watchers":369,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/opentracing/opentracing-javascript/pulls/98"},"html":{"href":"https://github.com/opentracing/opentracing-javascript/pull/98"},"issue":{"href":"https://api.github.com/repos/opentracing/opentracing-javascript/issues/98"},"comments":{"href":"https://api.github.com/repos/opentracing/opentracing-javascript/issues/98/comments"},"review_comments":{"href":"https://api.github.com/repos/opentracing/opentracing-javascript/pulls/98/comments"},"review_comment":{"href":"https://api.github.com/repos/opentracing/opentracing-javascript/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/opentracing/opentracing-javascript/pulls/98/commits"},"statuses":{"href":"https://api.github.com/repos/opentracing/opentracing-javascript/statuses/e1a5dd0aa3a385ef52d41a5493382a904aef30bb"}},"author_association":"NONE"}}
{"actor":{"display_login":"yurishkuro"}}