{"action":"closed","number":1665,"pull_request":{"url":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/1665","id":214576748,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0NTc2NzQ4","html_url":"https://github.com/Subsurface-divelog/subsurface/pull/1665","diff_url":"https://github.com/Subsurface-divelog/subsurface/pull/1665.diff","patch_url":"https://github.com/Subsurface-divelog/subsurface/pull/1665.patch","issue_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/1665","number":1665,"state":"closed","locked":false,"title":"test: remove git_local_only from qml test","user":{"login":"janiversen","id":6185391,"node_id":"MDQ6VXNlcjYxODUzOTE=","avatar_url":"https://avatars3.githubusercontent.com/u/6185391?v=4","gravatar_id":"","url":"https://api.github.com/users/janiversen","html_url":"https://github.com/janiversen","followers_url":"https://api.github.com/users/janiversen/followers","following_url":"https://api.github.com/users/janiversen/following{/other_user}","gists_url":"https://api.github.com/users/janiversen/gists{/gist_id}","starred_url":"https://api.github.com/users/janiversen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janiversen/subscriptions","organizations_url":"https://api.github.com/users/janiversen/orgs","repos_url":"https://api.github.com/users/janiversen/repos","events_url":"https://api.github.com/users/janiversen/events{/privacy}","received_events_url":"https://api.github.com/users/janiversen/received_events","type":"User","site_admin":false},"body":"tst_qPrefCloudStorage.qml still refered to git_local_ony, remove it\r\n\r\nSigned-off-by: Jan Iversen <jani@apache.org>\r\n\r\n<!-- Lines like this one are comments and will not be shown in the final output. -->\r\n<!-- Make sure that you have read the \"Contributing\" section of the README and also the notes in CodingStyle. -->\r\n<!-- If you are a collaborator, please add labels and assign other collaborators for a review. -->\r\n\r\n### Describe the pull request:\r\n<!-- Replace [ ] with [x] to select options. -->\r\n- [x] Bug fix\r\n- [ ] Functional change\r\n- [ ] New feature\r\n- [ ] Code cleanup\r\n- [ ] Build system change\r\n- [ ] Documentation change\r\n- [ ] Language translation\r\n\r\n### Pull request long description:\r\n<!-- Describe your pull request in detail. -->\r\nI wonder why travis passed, without this fix.\r\n\r\n### Changes made:\r\n<!-- Enumerate the changes with 1), 2), 3) etc. -->\r\n<!-- Ensure the test cases are updated if needed. -->\r\n\r\n### Related issues:\r\n<!-- Reference issues with #<issue-num>. -->\r\n<!-- Write \"Fixes #<issue-num\" to notify Github that this PR fixes an issue. -->\r\n\r\n### Additional information:\r\n<!-- Include sample dive log or other relevant information to allow testing the change where feasible. -->\r\n\r\n### Release note:\r\n<!-- Describe if this change needs a release note present in CHANGELOG.md. -->\r\n<!-- Also, please make sure to add the release note on top of the file CHANGELOG.md. -->\r\n\r\n### Documentation change:\r\n<!-- If this PR makes changes to user functionality, then the documentation has to be updated too. -->\r\n<!-- Please, briefly outline here what has changed in terms of the user experience (UX). -->\r\n<!-- If UX changes have been made, a maintainer should apply the 'needs-documentation-change' label. -->\r\n\r\n### Mentions:\r\n<!-- Mention users that you want to review your pull request with @<user-name>. Leave empty if not sure. -->\r\n@dirkhh \r\n","created_at":"2018-09-11T09:57:00Z","updated_at":"2018-09-11T18:54:09Z","closed_at":"2018-09-11T18:54:09Z","merged_at":"2018-09-11T18:54:09Z","merge_commit_sha":"62a8bc73911ec70de3182126cd2bc013226de6e6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/1665/commits","review_comments_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/1665/comments","review_comment_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/1665/comments","statuses_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/statuses/a8756509a2ee2e146fdab4c5bcea2a542220145e","head":{"label":"janiversen:git_local_fail","ref":"git_local_fail","sha":"a8756509a2ee2e146fdab4c5bcea2a542220145e","user":{"login":"janiversen","id":6185391,"node_id":"MDQ6VXNlcjYxODUzOTE=","avatar_url":"https://avatars3.githubusercontent.com/u/6185391?v=4","gravatar_id":"","url":"https://api.github.com/users/janiversen","html_url":"https://github.com/janiversen","followers_url":"https://api.github.com/users/janiversen/followers","following_url":"https://api.github.com/users/janiversen/following{/other_user}","gists_url":"https://api.github.com/users/janiversen/gists{/gist_id}","starred_url":"https://api.github.com/users/janiversen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janiversen/subscriptions","organizations_url":"https://api.github.com/users/janiversen/orgs","repos_url":"https://api.github.com/users/janiversen/repos","events_url":"https://api.github.com/users/janiversen/events{/privacy}","received_events_url":"https://api.github.com/users/janiversen/received_events","type":"User","site_admin":false},"repo":{"id":130397967,"node_id":"MDEwOlJlcG9zaXRvcnkxMzAzOTc5Njc=","name":"subsurface","full_name":"janiversen/subsurface","owner":{"login":"janiversen","id":6185391,"node_id":"MDQ6VXNlcjYxODUzOTE=","avatar_url":"https://avatars3.githubusercontent.com/u/6185391?v=4","gravatar_id":"","url":"https://api.github.com/users/janiversen","html_url":"https://github.com/janiversen","followers_url":"https://api.github.com/users/janiversen/followers","following_url":"https://api.github.com/users/janiversen/following{/other_user}","gists_url":"https://api.github.com/users/janiversen/gists{/gist_id}","starred_url":"https://api.github.com/users/janiversen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janiversen/subscriptions","organizations_url":"https://api.github.com/users/janiversen/orgs","repos_url":"https://api.github.com/users/janiversen/repos","events_url":"https://api.github.com/users/janiversen/events{/privacy}","received_events_url":"https://api.github.com/users/janiversen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/janiversen/subsurface","description":"This is the official upstream of the Subsurface divelog program","fork":true,"url":"https://api.github.com/repos/janiversen/subsurface","forks_url":"https://api.github.com/repos/janiversen/subsurface/forks","keys_url":"https://api.github.com/repos/janiversen/subsurface/keys{/key_id}","collaborators_url":"https://api.github.com/repos/janiversen/subsurface/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/janiversen/subsurface/teams","hooks_url":"https://api.github.com/repos/janiversen/subsurface/hooks","issue_events_url":"https://api.github.com/repos/janiversen/subsurface/issues/events{/number}","events_url":"https://api.github.com/repos/janiversen/subsurface/events","assignees_url":"https://api.github.com/repos/janiversen/subsurface/assignees{/user}","branches_url":"https://api.github.com/repos/janiversen/subsurface/branches{/branch}","tags_url":"https://api.github.com/repos/janiversen/subsurface/tags","blobs_url":"https://api.github.com/repos/janiversen/subsurface/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/janiversen/subsurface/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/janiversen/subsurface/git/refs{/sha}","trees_url":"https://api.github.com/repos/janiversen/subsurface/git/trees{/sha}","statuses_url":"https://api.github.com/repos/janiversen/subsurface/statuses/{sha}","languages_url":"https://api.github.com/repos/janiversen/subsurface/languages","stargazers_url":"https://api.github.com/repos/janiversen/subsurface/stargazers","contributors_url":"https://api.github.com/repos/janiversen/subsurface/contributors","subscribers_url":"https://api.github.com/repos/janiversen/subsurface/subscribers","subscription_url":"https://api.github.com/repos/janiversen/subsurface/subscription","commits_url":"https://api.github.com/repos/janiversen/subsurface/commits{/sha}","git_commits_url":"https://api.github.com/repos/janiversen/subsurface/git/commits{/sha}","comments_url":"https://api.github.com/repos/janiversen/subsurface/comments{/number}","issue_comment_url":"https://api.github.com/repos/janiversen/subsurface/issues/comments{/number}","contents_url":"https://api.github.com/repos/janiversen/subsurface/contents/{+path}","compare_url":"https://api.github.com/repos/janiversen/subsurface/compare/{base}...{head}","merges_url":"https://api.github.com/repos/janiversen/subsurface/merges","archive_url":"https://api.github.com/repos/janiversen/subsurface/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/janiversen/subsurface/downloads","issues_url":"https://api.github.com/repos/janiversen/subsurface/issues{/number}","pulls_url":"https://api.github.com/repos/janiversen/subsurface/pulls{/number}","milestones_url":"https://api.github.com/repos/janiversen/subsurface/milestones{/number}","notifications_url":"https://api.github.com/repos/janiversen/subsurface/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/janiversen/subsurface/labels{/name}","releases_url":"https://api.github.com/repos/janiversen/subsurface/releases{/id}","deployments_url":"https://api.github.com/repos/janiversen/subsurface/deployments","created_at":"2018-04-20T18:11:15Z","updated_at":"2018-09-10T12:23:10Z","pushed_at":"2018-09-11T18:53:06Z","git_url":"git://github.com/janiversen/subsurface.git","ssh_url":"git@github.com:janiversen/subsurface.git","clone_url":"https://github.com/janiversen/subsurface.git","svn_url":"https://github.com/janiversen/subsurface","homepage":"https://subsurface-divelog.org","size":96407,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Subsurface-divelog:master","ref":"master","sha":"619a52635a7f4ac850fad63c8f8eb7e0dd958f35","user":{"login":"Subsurface-divelog","id":24829199,"node_id":"MDQ6VXNlcjI0ODI5MTk5","avatar_url":"https://avatars1.githubusercontent.com/u/24829199?v=4","gravatar_id":"","url":"https://api.github.com/users/Subsurface-divelog","html_url":"https://github.com/Subsurface-divelog","followers_url":"https://api.github.com/users/Subsurface-divelog/followers","following_url":"https://api.github.com/users/Subsurface-divelog/following{/other_user}","gists_url":"https://api.github.com/users/Subsurface-divelog/gists{/gist_id}","starred_url":"https://api.github.com/users/Subsurface-divelog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Subsurface-divelog/subscriptions","organizations_url":"https://api.github.com/users/Subsurface-divelog/orgs","repos_url":"https://api.github.com/users/Subsurface-divelog/repos","events_url":"https://api.github.com/users/Subsurface-divelog/events{/privacy}","received_events_url":"https://api.github.com/users/Subsurface-divelog/received_events","type":"User","site_admin":false},"repo":{"id":2319498,"node_id":"MDEwOlJlcG9zaXRvcnkyMzE5NDk4","name":"subsurface","full_name":"Subsurface-divelog/subsurface","owner":{"login":"Subsurface-divelog","id":24829199,"node_id":"MDQ6VXNlcjI0ODI5MTk5","avatar_url":"https://avatars1.githubusercontent.com/u/24829199?v=4","gravatar_id":"","url":"https://api.github.com/users/Subsurface-divelog","html_url":"https://github.com/Subsurface-divelog","followers_url":"https://api.github.com/users/Subsurface-divelog/followers","following_url":"https://api.github.com/users/Subsurface-divelog/following{/other_user}","gists_url":"https://api.github.com/users/Subsurface-divelog/gists{/gist_id}","starred_url":"https://api.github.com/users/Subsurface-divelog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Subsurface-divelog/subscriptions","organizations_url":"https://api.github.com/users/Subsurface-divelog/orgs","repos_url":"https://api.github.com/users/Subsurface-divelog/repos","events_url":"https://api.github.com/users/Subsurface-divelog/events{/privacy}","received_events_url":"https://api.github.com/users/Subsurface-divelog/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Subsurface-divelog/subsurface","description":"This is the official upstream of the Subsurface divelog program","fork":false,"url":"https://api.github.com/repos/Subsurface-divelog/subsurface","forks_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/forks","keys_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/teams","hooks_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/hooks","issue_events_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/events{/number}","events_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/events","assignees_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/assignees{/user}","branches_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/branches{/branch}","tags_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/tags","blobs_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/git/refs{/sha}","trees_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/statuses/{sha}","languages_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/languages","stargazers_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/stargazers","contributors_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/contributors","subscribers_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/subscribers","subscription_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/subscription","commits_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/commits{/sha}","git_commits_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/git/commits{/sha}","comments_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/comments{/number}","issue_comment_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/comments{/number}","contents_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/contents/{+path}","compare_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/merges","archive_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/downloads","issues_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues{/number}","pulls_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls{/number}","milestones_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/milestones{/number}","notifications_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/labels{/name}","releases_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/releases{/id}","deployments_url":"https://api.github.com/repos/Subsurface-divelog/subsurface/deployments","created_at":"2011-09-03T15:27:51Z","updated_at":"2018-09-11T16:49:56Z","pushed_at":"2018-09-11T18:54:09Z","git_url":"git://github.com/Subsurface-divelog/subsurface.git","ssh_url":"git@github.com:Subsurface-divelog/subsurface.git","clone_url":"https://github.com/Subsurface-divelog/subsurface.git","svn_url":"https://github.com/Subsurface-divelog/subsurface","homepage":"https://subsurface-divelog.org","size":96393,"stargazers_count":1425,"watchers_count":1425,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":359,"mirror_url":null,"archived":false,"open_issues_count":99,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":359,"open_issues":99,"watchers":1425,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/1665"},"html":{"href":"https://github.com/Subsurface-divelog/subsurface/pull/1665"},"issue":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/1665"},"comments":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/issues/1665/comments"},"review_comments":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/1665/comments"},"review_comment":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/pulls/1665/commits"},"statuses":{"href":"https://api.github.com/repos/Subsurface-divelog/subsurface/statuses/a8756509a2ee2e146fdab4c5bcea2a542220145e"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"dirkhh","id":237471,"node_id":"MDQ6VXNlcjIzNzQ3MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/237471?v=4","gravatar_id":"","url":"https://api.github.com/users/dirkhh","html_url":"https://github.com/dirkhh","followers_url":"https://api.github.com/users/dirkhh/followers","following_url":"https://api.github.com/users/dirkhh/following{/other_user}","gists_url":"https://api.github.com/users/dirkhh/gists{/gist_id}","starred_url":"https://api.github.com/users/dirkhh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dirkhh/subscriptions","organizations_url":"https://api.github.com/users/dirkhh/orgs","repos_url":"https://api.github.com/users/dirkhh/repos","events_url":"https://api.github.com/users/dirkhh/events{/privacy}","received_events_url":"https://api.github.com/users/dirkhh/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":0,"deletions":4,"changed_files":1}}
{"actor":{"display_login":"dirkhh"}}