{"action":"created","comment":{"url":"https://api.github.com/repos/ray-project/ray/pulls/comments/215820416","pull_request_review_id":153173668,"id":215820416,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTgyMDQxNg==","diff_hunk":"@@ -111,6 +111,12 @@ class WorkerPool {\n   /// \\return The total count of all workers (actor and non-actor) in the pool.\n   uint32_t Size(const Language &language) const;\n \n+  /// Get all the workers for a particular driver.\n+  ///\n+  /// \\param job_id The job ID.\n+  /// \\return A list containing all the workers for a driver.\n+  std::vector<std::shared_ptr<Worker>> GetDriverWorkers(const DriverID &driver_id) const;","path":"src/ray/raylet/worker_pool.h","position":8,"original_position":8,"commit_id":"3089d8045221d13dfedd14513616c5c187eb6ea8","original_commit_id":"edc3599a324b77ed2c8fcac45e17717d8dc9330d","user":{"login":"zhijunfu","id":37800433,"node_id":"MDQ6VXNlcjM3ODAwNDMz","avatar_url":"https://avatars2.githubusercontent.com/u/37800433?v=4","gravatar_id":"","url":"https://api.github.com/users/zhijunfu","html_url":"https://github.com/zhijunfu","followers_url":"https://api.github.com/users/zhijunfu/followers","following_url":"https://api.github.com/users/zhijunfu/following{/other_user}","gists_url":"https://api.github.com/users/zhijunfu/gists{/gist_id}","starred_url":"https://api.github.com/users/zhijunfu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhijunfu/subscriptions","organizations_url":"https://api.github.com/users/zhijunfu/orgs","repos_url":"https://api.github.com/users/zhijunfu/repos","events_url":"https://api.github.com/users/zhijunfu/events{/privacy}","received_events_url":"https://api.github.com/users/zhijunfu/received_events","type":"User","site_admin":false},"body":"Yes it's better to rename to avoid possible confusion. ","created_at":"2018-09-07T01:05:57Z","updated_at":"2018-09-07T01:05:57Z","html_url":"https://github.com/ray-project/ray/pull/2826#discussion_r215820416","pull_request_url":"https://api.github.com/repos/ray-project/ray/pulls/2826","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ray-project/ray/pulls/comments/215820416"},"html":{"href":"https://github.com/ray-project/ray/pull/2826#discussion_r215820416"},"pull_request":{"href":"https://api.github.com/repos/ray-project/ray/pulls/2826"}},"in_reply_to_id":215753751},"pull_request":{"url":"https://api.github.com/repos/ray-project/ray/pulls/2826","id":213160757,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzMTYwNzU3","html_url":"https://github.com/ray-project/ray/pull/2826","diff_url":"https://github.com/ray-project/ray/pull/2826.diff","patch_url":"https://github.com/ray-project/ray/pull/2826.patch","issue_url":"https://api.github.com/repos/ray-project/ray/issues/2826","number":2826,"state":"open","locked":false,"title":"[Issue 2809][xray] Cleanup on driver detach","user":{"login":"zhijunfu","id":37800433,"node_id":"MDQ6VXNlcjM3ODAwNDMz","avatar_url":"https://avatars2.githubusercontent.com/u/37800433?v=4","gravatar_id":"","url":"https://api.github.com/users/zhijunfu","html_url":"https://github.com/zhijunfu","followers_url":"https://api.github.com/users/zhijunfu/followers","following_url":"https://api.github.com/users/zhijunfu/following{/other_user}","gists_url":"https://api.github.com/users/zhijunfu/gists{/gist_id}","starred_url":"https://api.github.com/users/zhijunfu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zhijunfu/subscriptions","organizations_url":"https://api.github.com/users/zhijunfu/orgs","repos_url":"https://api.github.com/users/zhijunfu/repos","events_url":"https://api.github.com/users/zhijunfu/events{/privacy}","received_events_url":"https://api.github.com/users/zhijunfu/received_events","type":"User","site_admin":false},"body":"This change addresses issue #2809. Test #2797 has been enabled for raylet and can pass.\r\n\r\n@robertnishihara @pcmoritz @elibol \r\nMay you please help to take a look?\r\n\r\nThanks\r\n\r\n---------------------------------------------------------------------------------\r\nThe following should happen when a driver exits (either gracefully or ungracefully).\r\n\r\n#2797 should be enabled and pass.\r\nAny actors created by the driver that are still running should be killed.\r\nAny workers running tasks for the driver should be killed.\r\nAny tasks for the driver in any node_manager queues should be removed.\r\nAny future tasks received by a node manager for the driver should be ignored.\r\nThe driver death notification should only be received once.\r\n","created_at":"2018-09-05T03:38:56Z","updated_at":"2018-09-07T01:05:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"23747df9f81653424dd825ce66f60b6e7349ffa5","assignee":null,"assignees":[],"requested_reviewers":[{"login":"pcmoritz","id":113316,"node_id":"MDQ6VXNlcjExMzMxNg==","avatar_url":"https://avatars1.githubusercontent.com/u/113316?v=4","gravatar_id":"","url":"https://api.github.com/users/pcmoritz","html_url":"https://github.com/pcmoritz","followers_url":"https://api.github.com/users/pcmoritz/followers","following_url":"https://api.github.com/users/pcmoritz/following{/other_user}","gists_url":"https://api.github.com/users/pcmoritz/gists{/gist_id}","starred_url":"https://api.github.com/users/pcmoritz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcmoritz/subscriptions","organizations_url":"https://api.github.com/users/pcmoritz/orgs","repos_url":"https://api.github.com/users/pcmoritz/repos","events_url":"https://api.github.com/users/pcmoritz/events{/privacy}","received_events_url":"https://api.github.com/users/pcmoritz/received_events","type":"User","site_admin":false},{"login":"elibol","id":1884921,"node_id":"MDQ6VXNlcjE4ODQ5MjE=","avatar_url":"https://avatars1.githubusercontent.com/u/1884921?v=4","gravatar_id":"","url":"https://api.github.com/users/elibol","html_url":"https://github.com/elibol","followers_url":"https://api.github.com/users/elibol/followers","following_url":"https://api.github.com/users/elibol/following{/other_user}","gists_url":"https://api.github.com/users/elibol/gists{/gist_id}","starred_url":"https://api.github.com/users/elibol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elibol/subscriptions","organizations_url":"https://api.github.com/users/elibol/orgs","repos_url":"https://api.github.com/users/elibol/repos","events_url":"https://api.github.com/users/elibol/events{/privacy}","received_events_url":"https://api.github.com/users/elibol/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ray-project/ray/pulls/2826/commits","review_comments_url":"https://api.github.com/repos/ray-project/ray/pulls/2826/comments","review_comment_url":"https://api.github.com/repos/ray-project/ray/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ray-project/ray/issues/2826/comments","statuses_url":"https://api.github.com/repos/ray-project/ray/statuses/3089d8045221d13dfedd14513616c5c187eb6ea8","head":{"label":"ant-tech-alliance:cleanup-on-driver-detach","ref":"cleanup-on-driver-detach","sha":"3089d8045221d13dfedd14513616c5c187eb6ea8","user":{"login":"ant-tech-alliance","id":29560905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NTYwOTA1","avatar_url":"https://avatars3.githubusercontent.com/u/29560905?v=4","gravatar_id":"","url":"https://api.github.com/users/ant-tech-alliance","html_url":"https://github.com/ant-tech-alliance","followers_url":"https://api.github.com/users/ant-tech-alliance/followers","following_url":"https://api.github.com/users/ant-tech-alliance/following{/other_user}","gists_url":"https://api.github.com/users/ant-tech-alliance/gists{/gist_id}","starred_url":"https://api.github.com/users/ant-tech-alliance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ant-tech-alliance/subscriptions","organizations_url":"https://api.github.com/users/ant-tech-alliance/orgs","repos_url":"https://api.github.com/users/ant-tech-alliance/repos","events_url":"https://api.github.com/users/ant-tech-alliance/events{/privacy}","received_events_url":"https://api.github.com/users/ant-tech-alliance/received_events","type":"Organization","site_admin":false},"repo":{"id":125461261,"node_id":"MDEwOlJlcG9zaXRvcnkxMjU0NjEyNjE=","name":"ray","full_name":"ant-tech-alliance/ray","owner":{"login":"ant-tech-alliance","id":29560905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5NTYwOTA1","avatar_url":"https://avatars3.githubusercontent.com/u/29560905?v=4","gravatar_id":"","url":"https://api.github.com/users/ant-tech-alliance","html_url":"https://github.com/ant-tech-alliance","followers_url":"https://api.github.com/users/ant-tech-alliance/followers","following_url":"https://api.github.com/users/ant-tech-alliance/following{/other_user}","gists_url":"https://api.github.com/users/ant-tech-alliance/gists{/gist_id}","starred_url":"https://api.github.com/users/ant-tech-alliance/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ant-tech-alliance/subscriptions","organizations_url":"https://api.github.com/users/ant-tech-alliance/orgs","repos_url":"https://api.github.com/users/ant-tech-alliance/repos","events_url":"https://api.github.com/users/ant-tech-alliance/events{/privacy}","received_events_url":"https://api.github.com/users/ant-tech-alliance/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ant-tech-alliance/ray","description":"A high-performance distributed execution engine","fork":true,"url":"https://api.github.com/repos/ant-tech-alliance/ray","forks_url":"https://api.github.com/repos/ant-tech-alliance/ray/forks","keys_url":"https://api.github.com/repos/ant-tech-alliance/ray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ant-tech-alliance/ray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ant-tech-alliance/ray/teams","hooks_url":"https://api.github.com/repos/ant-tech-alliance/ray/hooks","issue_events_url":"https://api.github.com/repos/ant-tech-alliance/ray/issues/events{/number}","events_url":"https://api.github.com/repos/ant-tech-alliance/ray/events","assignees_url":"https://api.github.com/repos/ant-tech-alliance/ray/assignees{/user}","branches_url":"https://api.github.com/repos/ant-tech-alliance/ray/branches{/branch}","tags_url":"https://api.github.com/repos/ant-tech-alliance/ray/tags","blobs_url":"https://api.github.com/repos/ant-tech-alliance/ray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ant-tech-alliance/ray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ant-tech-alliance/ray/git/refs{/sha}","trees_url":"https://api.github.com/repos/ant-tech-alliance/ray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ant-tech-alliance/ray/statuses/{sha}","languages_url":"https://api.github.com/repos/ant-tech-alliance/ray/languages","stargazers_url":"https://api.github.com/repos/ant-tech-alliance/ray/stargazers","contributors_url":"https://api.github.com/repos/ant-tech-alliance/ray/contributors","subscribers_url":"https://api.github.com/repos/ant-tech-alliance/ray/subscribers","subscription_url":"https://api.github.com/repos/ant-tech-alliance/ray/subscription","commits_url":"https://api.github.com/repos/ant-tech-alliance/ray/commits{/sha}","git_commits_url":"https://api.github.com/repos/ant-tech-alliance/ray/git/commits{/sha}","comments_url":"https://api.github.com/repos/ant-tech-alliance/ray/comments{/number}","issue_comment_url":"https://api.github.com/repos/ant-tech-alliance/ray/issues/comments{/number}","contents_url":"https://api.github.com/repos/ant-tech-alliance/ray/contents/{+path}","compare_url":"https://api.github.com/repos/ant-tech-alliance/ray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ant-tech-alliance/ray/merges","archive_url":"https://api.github.com/repos/ant-tech-alliance/ray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ant-tech-alliance/ray/downloads","issues_url":"https://api.github.com/repos/ant-tech-alliance/ray/issues{/number}","pulls_url":"https://api.github.com/repos/ant-tech-alliance/ray/pulls{/number}","milestones_url":"https://api.github.com/repos/ant-tech-alliance/ray/milestones{/number}","notifications_url":"https://api.github.com/repos/ant-tech-alliance/ray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ant-tech-alliance/ray/labels{/name}","releases_url":"https://api.github.com/repos/ant-tech-alliance/ray/releases{/id}","deployments_url":"https://api.github.com/repos/ant-tech-alliance/ray/deployments","created_at":"2018-03-16T03:58:55Z","updated_at":"2018-09-06T08:57:11Z","pushed_at":"2018-09-06T20:15:07Z","git_url":"git://github.com/ant-tech-alliance/ray.git","ssh_url":"git@github.com:ant-tech-alliance/ray.git","clone_url":"https://github.com/ant-tech-alliance/ray.git","svn_url":"https://github.com/ant-tech-alliance/ray","homepage":"","size":16052,"stargazers_count":8,"watchers_count":8,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":6,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":6,"open_issues":9,"watchers":8,"default_branch":"master"}},"base":{"label":"ray-project:master","ref":"master","sha":"72542c9016c19005807fad45fc0dccaf41052b33","user":{"login":"ray-project","id":22125274,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTI1Mjc0","avatar_url":"https://avatars3.githubusercontent.com/u/22125274?v=4","gravatar_id":"","url":"https://api.github.com/users/ray-project","html_url":"https://github.com/ray-project","followers_url":"https://api.github.com/users/ray-project/followers","following_url":"https://api.github.com/users/ray-project/following{/other_user}","gists_url":"https://api.github.com/users/ray-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ray-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ray-project/subscriptions","organizations_url":"https://api.github.com/users/ray-project/orgs","repos_url":"https://api.github.com/users/ray-project/repos","events_url":"https://api.github.com/users/ray-project/events{/privacy}","received_events_url":"https://api.github.com/users/ray-project/received_events","type":"Organization","site_admin":false},"repo":{"id":71932349,"node_id":"MDEwOlJlcG9zaXRvcnk3MTkzMjM0OQ==","name":"ray","full_name":"ray-project/ray","owner":{"login":"ray-project","id":22125274,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTI1Mjc0","avatar_url":"https://avatars3.githubusercontent.com/u/22125274?v=4","gravatar_id":"","url":"https://api.github.com/users/ray-project","html_url":"https://github.com/ray-project","followers_url":"https://api.github.com/users/ray-project/followers","following_url":"https://api.github.com/users/ray-project/following{/other_user}","gists_url":"https://api.github.com/users/ray-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ray-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ray-project/subscriptions","organizations_url":"https://api.github.com/users/ray-project/orgs","repos_url":"https://api.github.com/users/ray-project/repos","events_url":"https://api.github.com/users/ray-project/events{/privacy}","received_events_url":"https://api.github.com/users/ray-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ray-project/ray","description":"A high-performance distributed execution engine","fork":false,"url":"https://api.github.com/repos/ray-project/ray","forks_url":"https://api.github.com/repos/ray-project/ray/forks","keys_url":"https://api.github.com/repos/ray-project/ray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ray-project/ray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ray-project/ray/teams","hooks_url":"https://api.github.com/repos/ray-project/ray/hooks","issue_events_url":"https://api.github.com/repos/ray-project/ray/issues/events{/number}","events_url":"https://api.github.com/repos/ray-project/ray/events","assignees_url":"https://api.github.com/repos/ray-project/ray/assignees{/user}","branches_url":"https://api.github.com/repos/ray-project/ray/branches{/branch}","tags_url":"https://api.github.com/repos/ray-project/ray/tags","blobs_url":"https://api.github.com/repos/ray-project/ray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ray-project/ray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ray-project/ray/git/refs{/sha}","trees_url":"https://api.github.com/repos/ray-project/ray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ray-project/ray/statuses/{sha}","languages_url":"https://api.github.com/repos/ray-project/ray/languages","stargazers_url":"https://api.github.com/repos/ray-project/ray/stargazers","contributors_url":"https://api.github.com/repos/ray-project/ray/contributors","subscribers_url":"https://api.github.com/repos/ray-project/ray/subscribers","subscription_url":"https://api.github.com/repos/ray-project/ray/subscription","commits_url":"https://api.github.com/repos/ray-project/ray/commits{/sha}","git_commits_url":"https://api.github.com/repos/ray-project/ray/git/commits{/sha}","comments_url":"https://api.github.com/repos/ray-project/ray/comments{/number}","issue_comment_url":"https://api.github.com/repos/ray-project/ray/issues/comments{/number}","contents_url":"https://api.github.com/repos/ray-project/ray/contents/{+path}","compare_url":"https://api.github.com/repos/ray-project/ray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ray-project/ray/merges","archive_url":"https://api.github.com/repos/ray-project/ray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ray-project/ray/downloads","issues_url":"https://api.github.com/repos/ray-project/ray/issues{/number}","pulls_url":"https://api.github.com/repos/ray-project/ray/pulls{/number}","milestones_url":"https://api.github.com/repos/ray-project/ray/milestones{/number}","notifications_url":"https://api.github.com/repos/ray-project/ray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ray-project/ray/labels{/name}","releases_url":"https://api.github.com/repos/ray-project/ray/releases{/id}","deployments_url":"https://api.github.com/repos/ray-project/ray/deployments","created_at":"2016-10-25T19:38:30Z","updated_at":"2018-09-06T21:24:32Z","pushed_at":"2018-09-06T23:38:15Z","git_url":"git://github.com/ray-project/ray.git","ssh_url":"git@github.com:ray-project/ray.git","clone_url":"https://github.com/ray-project/ray.git","svn_url":"https://github.com/ray-project/ray","homepage":"","size":14820,"stargazers_count":4149,"watchers_count":4149,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":562,"mirror_url":null,"archived":false,"open_issues_count":412,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":562,"open_issues":412,"watchers":4149,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ray-project/ray/pulls/2826"},"html":{"href":"https://github.com/ray-project/ray/pull/2826"},"issue":{"href":"https://api.github.com/repos/ray-project/ray/issues/2826"},"comments":{"href":"https://api.github.com/repos/ray-project/ray/issues/2826/comments"},"review_comments":{"href":"https://api.github.com/repos/ray-project/ray/pulls/2826/comments"},"review_comment":{"href":"https://api.github.com/repos/ray-project/ray/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ray-project/ray/pulls/2826/commits"},"statuses":{"href":"https://api.github.com/repos/ray-project/ray/statuses/3089d8045221d13dfedd14513616c5c187eb6ea8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"zhijunfu"}}