{"action":"created","comment":{"url":"https://api.github.com/repos/dmlc/tvm/pulls/comments/193917122","pull_request_review_id":126990827,"id":193917122,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MzkxNzEyMg==","diff_hunk":"@@ -194,7 +194,11 @@ def call_handler(self, args):\n             key = args[1]\n             port, matchkey = args[2]\n             self.pending_matchkeys.add(matchkey)\n-            self._tracker.put(key, (self, self._addr[0], port, matchkey))\n+            # got custom address (from rpc server)\n+            if args[3] is not None:\n+                self._tracker.put(key, (self, args[3], port, matchkey))","path":"python/tvm/contrib/rpc/tracker.py","position":7,"original_position":7,"commit_id":"c9af5c099115562ea164ebe0184aacdf4254c9ea","original_commit_id":"c9af5c099115562ea164ebe0184aacdf4254c9ea","user":{"login":"tqchen","id":2577440,"node_id":"MDQ6VXNlcjI1Nzc0NDA=","avatar_url":"https://avatars3.githubusercontent.com/u/2577440?v=4","gravatar_id":"","url":"https://api.github.com/users/tqchen","html_url":"https://github.com/tqchen","followers_url":"https://api.github.com/users/tqchen/followers","following_url":"https://api.github.com/users/tqchen/following{/other_user}","gists_url":"https://api.github.com/users/tqchen/gists{/gist_id}","starred_url":"https://api.github.com/users/tqchen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tqchen/subscriptions","organizations_url":"https://api.github.com/users/tqchen/orgs","repos_url":"https://api.github.com/users/tqchen/repos","events_url":"https://api.github.com/users/tqchen/events{/privacy}","received_events_url":"https://api.github.com/users/tqchen/received_events","type":"User","site_admin":false},"body":"can we directly also put None in here?","created_at":"2018-06-07T23:29:37Z","updated_at":"2018-06-07T23:29:40Z","html_url":"https://github.com/dmlc/tvm/pull/1243#discussion_r193917122","pull_request_url":"https://api.github.com/repos/dmlc/tvm/pulls/1243","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dmlc/tvm/pulls/comments/193917122"},"html":{"href":"https://github.com/dmlc/tvm/pull/1243#discussion_r193917122"},"pull_request":{"href":"https://api.github.com/repos/dmlc/tvm/pulls/1243"}}},"pull_request":{"url":"https://api.github.com/repos/dmlc/tvm/pulls/1243","id":193158559,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzMTU4NTU5","html_url":"https://github.com/dmlc/tvm/pull/1243","diff_url":"https://github.com/dmlc/tvm/pull/1243.diff","patch_url":"https://github.com/dmlc/tvm/pull/1243.patch","issue_url":"https://api.github.com/repos/dmlc/tvm/issues/1243","number":1243,"state":"open","locked":false,"title":"support custom IP address from rpc server to tracker (PUT)","user":{"login":"eqy","id":2239616,"node_id":"MDQ6VXNlcjIyMzk2MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/2239616?v=4","gravatar_id":"","url":"https://api.github.com/users/eqy","html_url":"https://github.com/eqy","followers_url":"https://api.github.com/users/eqy/followers","following_url":"https://api.github.com/users/eqy/following{/other_user}","gists_url":"https://api.github.com/users/eqy/gists{/gist_id}","starred_url":"https://api.github.com/users/eqy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eqy/subscriptions","organizations_url":"https://api.github.com/users/eqy/orgs","repos_url":"https://api.github.com/users/eqy/repos","events_url":"https://api.github.com/users/eqy/events{/privacy}","received_events_url":"https://api.github.com/users/eqy/received_events","type":"User","site_admin":false},"body":"Currently the tracker uses the IP address of the connection when a new rpc server registers.\r\nIn the case of a network topology where the tracker is behind a NAT/firewall, the registering RPC server's connection will appear to come from another device from within the NAT (e.g., if we use an ssh tunnel).\r\nThis PR allows the registering RPC server to specify a custom IP at `PUT` time so RPC requests to the tracker can receive the actual address of the server.","created_at":"2018-06-06T22:30:47Z","updated_at":"2018-06-07T23:29:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"398f8794ebc54101f05bbf39a6f05fcadb89a039","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dmlc/tvm/pulls/1243/commits","review_comments_url":"https://api.github.com/repos/dmlc/tvm/pulls/1243/comments","review_comment_url":"https://api.github.com/repos/dmlc/tvm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dmlc/tvm/issues/1243/comments","statuses_url":"https://api.github.com/repos/dmlc/tvm/statuses/c9af5c099115562ea164ebe0184aacdf4254c9ea","head":{"label":"eqy:eqy-rpc","ref":"eqy-rpc","sha":"c9af5c099115562ea164ebe0184aacdf4254c9ea","user":{"login":"eqy","id":2239616,"node_id":"MDQ6VXNlcjIyMzk2MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/2239616?v=4","gravatar_id":"","url":"https://api.github.com/users/eqy","html_url":"https://github.com/eqy","followers_url":"https://api.github.com/users/eqy/followers","following_url":"https://api.github.com/users/eqy/following{/other_user}","gists_url":"https://api.github.com/users/eqy/gists{/gist_id}","starred_url":"https://api.github.com/users/eqy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eqy/subscriptions","organizations_url":"https://api.github.com/users/eqy/orgs","repos_url":"https://api.github.com/users/eqy/repos","events_url":"https://api.github.com/users/eqy/events{/privacy}","received_events_url":"https://api.github.com/users/eqy/received_events","type":"User","site_admin":false},"repo":{"id":109762891,"node_id":"MDEwOlJlcG9zaXRvcnkxMDk3NjI4OTE=","name":"tvm","full_name":"eqy/tvm","owner":{"login":"eqy","id":2239616,"node_id":"MDQ6VXNlcjIyMzk2MTY=","avatar_url":"https://avatars2.githubusercontent.com/u/2239616?v=4","gravatar_id":"","url":"https://api.github.com/users/eqy","html_url":"https://github.com/eqy","followers_url":"https://api.github.com/users/eqy/followers","following_url":"https://api.github.com/users/eqy/following{/other_user}","gists_url":"https://api.github.com/users/eqy/gists{/gist_id}","starred_url":"https://api.github.com/users/eqy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eqy/subscriptions","organizations_url":"https://api.github.com/users/eqy/orgs","repos_url":"https://api.github.com/users/eqy/repos","events_url":"https://api.github.com/users/eqy/events{/privacy}","received_events_url":"https://api.github.com/users/eqy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/eqy/tvm","description":"End to end Tensor IR/DSL stack for deploying deep learning workloads to hardwares","fork":true,"url":"https://api.github.com/repos/eqy/tvm","forks_url":"https://api.github.com/repos/eqy/tvm/forks","keys_url":"https://api.github.com/repos/eqy/tvm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eqy/tvm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eqy/tvm/teams","hooks_url":"https://api.github.com/repos/eqy/tvm/hooks","issue_events_url":"https://api.github.com/repos/eqy/tvm/issues/events{/number}","events_url":"https://api.github.com/repos/eqy/tvm/events","assignees_url":"https://api.github.com/repos/eqy/tvm/assignees{/user}","branches_url":"https://api.github.com/repos/eqy/tvm/branches{/branch}","tags_url":"https://api.github.com/repos/eqy/tvm/tags","blobs_url":"https://api.github.com/repos/eqy/tvm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eqy/tvm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eqy/tvm/git/refs{/sha}","trees_url":"https://api.github.com/repos/eqy/tvm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eqy/tvm/statuses/{sha}","languages_url":"https://api.github.com/repos/eqy/tvm/languages","stargazers_url":"https://api.github.com/repos/eqy/tvm/stargazers","contributors_url":"https://api.github.com/repos/eqy/tvm/contributors","subscribers_url":"https://api.github.com/repos/eqy/tvm/subscribers","subscription_url":"https://api.github.com/repos/eqy/tvm/subscription","commits_url":"https://api.github.com/repos/eqy/tvm/commits{/sha}","git_commits_url":"https://api.github.com/repos/eqy/tvm/git/commits{/sha}","comments_url":"https://api.github.com/repos/eqy/tvm/comments{/number}","issue_comment_url":"https://api.github.com/repos/eqy/tvm/issues/comments{/number}","contents_url":"https://api.github.com/repos/eqy/tvm/contents/{+path}","compare_url":"https://api.github.com/repos/eqy/tvm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eqy/tvm/merges","archive_url":"https://api.github.com/repos/eqy/tvm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eqy/tvm/downloads","issues_url":"https://api.github.com/repos/eqy/tvm/issues{/number}","pulls_url":"https://api.github.com/repos/eqy/tvm/pulls{/number}","milestones_url":"https://api.github.com/repos/eqy/tvm/milestones{/number}","notifications_url":"https://api.github.com/repos/eqy/tvm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eqy/tvm/labels{/name}","releases_url":"https://api.github.com/repos/eqy/tvm/releases{/id}","deployments_url":"https://api.github.com/repos/eqy/tvm/deployments","created_at":"2017-11-06T23:40:07Z","updated_at":"2018-06-06T21:49:07Z","pushed_at":"2018-06-07T20:22:28Z","git_url":"git://github.com/eqy/tvm.git","ssh_url":"git@github.com:eqy/tvm.git","clone_url":"https://github.com/eqy/tvm.git","svn_url":"https://github.com/eqy/tvm","homepage":"","size":5120,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dmlc:master","ref":"master","sha":"f4532773a577f1d6bbafe2a30e25ff104b52d00a","user":{"login":"dmlc","id":11508361,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTA4MzYx","avatar_url":"https://avatars2.githubusercontent.com/u/11508361?v=4","gravatar_id":"","url":"https://api.github.com/users/dmlc","html_url":"https://github.com/dmlc","followers_url":"https://api.github.com/users/dmlc/followers","following_url":"https://api.github.com/users/dmlc/following{/other_user}","gists_url":"https://api.github.com/users/dmlc/gists{/gist_id}","starred_url":"https://api.github.com/users/dmlc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmlc/subscriptions","organizations_url":"https://api.github.com/users/dmlc/orgs","repos_url":"https://api.github.com/users/dmlc/repos","events_url":"https://api.github.com/users/dmlc/events{/privacy}","received_events_url":"https://api.github.com/users/dmlc/received_events","type":"Organization","site_admin":false},"repo":{"id":70746484,"node_id":"MDEwOlJlcG9zaXRvcnk3MDc0NjQ4NA==","name":"tvm","full_name":"dmlc/tvm","owner":{"login":"dmlc","id":11508361,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExNTA4MzYx","avatar_url":"https://avatars2.githubusercontent.com/u/11508361?v=4","gravatar_id":"","url":"https://api.github.com/users/dmlc","html_url":"https://github.com/dmlc","followers_url":"https://api.github.com/users/dmlc/followers","following_url":"https://api.github.com/users/dmlc/following{/other_user}","gists_url":"https://api.github.com/users/dmlc/gists{/gist_id}","starred_url":"https://api.github.com/users/dmlc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmlc/subscriptions","organizations_url":"https://api.github.com/users/dmlc/orgs","repos_url":"https://api.github.com/users/dmlc/repos","events_url":"https://api.github.com/users/dmlc/events{/privacy}","received_events_url":"https://api.github.com/users/dmlc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dmlc/tvm","description":"Open deep learning compiler stack for cpu, gpu and specialized accelerators","fork":false,"url":"https://api.github.com/repos/dmlc/tvm","forks_url":"https://api.github.com/repos/dmlc/tvm/forks","keys_url":"https://api.github.com/repos/dmlc/tvm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dmlc/tvm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dmlc/tvm/teams","hooks_url":"https://api.github.com/repos/dmlc/tvm/hooks","issue_events_url":"https://api.github.com/repos/dmlc/tvm/issues/events{/number}","events_url":"https://api.github.com/repos/dmlc/tvm/events","assignees_url":"https://api.github.com/repos/dmlc/tvm/assignees{/user}","branches_url":"https://api.github.com/repos/dmlc/tvm/branches{/branch}","tags_url":"https://api.github.com/repos/dmlc/tvm/tags","blobs_url":"https://api.github.com/repos/dmlc/tvm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dmlc/tvm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dmlc/tvm/git/refs{/sha}","trees_url":"https://api.github.com/repos/dmlc/tvm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dmlc/tvm/statuses/{sha}","languages_url":"https://api.github.com/repos/dmlc/tvm/languages","stargazers_url":"https://api.github.com/repos/dmlc/tvm/stargazers","contributors_url":"https://api.github.com/repos/dmlc/tvm/contributors","subscribers_url":"https://api.github.com/repos/dmlc/tvm/subscribers","subscription_url":"https://api.github.com/repos/dmlc/tvm/subscription","commits_url":"https://api.github.com/repos/dmlc/tvm/commits{/sha}","git_commits_url":"https://api.github.com/repos/dmlc/tvm/git/commits{/sha}","comments_url":"https://api.github.com/repos/dmlc/tvm/comments{/number}","issue_comment_url":"https://api.github.com/repos/dmlc/tvm/issues/comments{/number}","contents_url":"https://api.github.com/repos/dmlc/tvm/contents/{+path}","compare_url":"https://api.github.com/repos/dmlc/tvm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dmlc/tvm/merges","archive_url":"https://api.github.com/repos/dmlc/tvm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dmlc/tvm/downloads","issues_url":"https://api.github.com/repos/dmlc/tvm/issues{/number}","pulls_url":"https://api.github.com/repos/dmlc/tvm/pulls{/number}","milestones_url":"https://api.github.com/repos/dmlc/tvm/milestones{/number}","notifications_url":"https://api.github.com/repos/dmlc/tvm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dmlc/tvm/labels{/name}","releases_url":"https://api.github.com/repos/dmlc/tvm/releases{/id}","deployments_url":"https://api.github.com/repos/dmlc/tvm/deployments","created_at":"2016-10-12T22:20:28Z","updated_at":"2018-06-07T23:29:01Z","pushed_at":"2018-06-07T23:28:56Z","git_url":"git://github.com/dmlc/tvm.git","ssh_url":"git@github.com:dmlc/tvm.git","clone_url":"https://github.com/dmlc/tvm.git","svn_url":"https://github.com/dmlc/tvm","homepage":"https://tvm.ai","size":5113,"stargazers_count":1513,"watchers_count":1513,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":317,"mirror_url":null,"archived":false,"open_issues_count":41,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":317,"open_issues":41,"watchers":1513,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dmlc/tvm/pulls/1243"},"html":{"href":"https://github.com/dmlc/tvm/pull/1243"},"issue":{"href":"https://api.github.com/repos/dmlc/tvm/issues/1243"},"comments":{"href":"https://api.github.com/repos/dmlc/tvm/issues/1243/comments"},"review_comments":{"href":"https://api.github.com/repos/dmlc/tvm/pulls/1243/comments"},"review_comment":{"href":"https://api.github.com/repos/dmlc/tvm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dmlc/tvm/pulls/1243/commits"},"statuses":{"href":"https://api.github.com/repos/dmlc/tvm/statuses/c9af5c099115562ea164ebe0184aacdf4254c9ea"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tqchen"}}