{"action":"created","issue":{"url":"https://api.github.com/repos/pingcap/tidb/issues/6543","repository_url":"https://api.github.com/repos/pingcap/tidb","labels_url":"https://api.github.com/repos/pingcap/tidb/issues/6543/labels{/name}","comments_url":"https://api.github.com/repos/pingcap/tidb/issues/6543/comments","events_url":"https://api.github.com/repos/pingcap/tidb/issues/6543/events","html_url":"https://github.com/pingcap/tidb/pull/6543","id":322475700,"number":6543,"title":"executor: rewrite TestNotFillCacheFlag to avoid data race in CI","user":{"login":"tiancaiamao","id":1420062,"avatar_url":"https://avatars2.githubusercontent.com/u/1420062?v=4","gravatar_id":"","url":"https://api.github.com/users/tiancaiamao","html_url":"https://github.com/tiancaiamao","followers_url":"https://api.github.com/users/tiancaiamao/followers","following_url":"https://api.github.com/users/tiancaiamao/following{/other_user}","gists_url":"https://api.github.com/users/tiancaiamao/gists{/gist_id}","starred_url":"https://api.github.com/users/tiancaiamao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiancaiamao/subscriptions","organizations_url":"https://api.github.com/users/tiancaiamao/orgs","repos_url":"https://api.github.com/users/tiancaiamao/repos","events_url":"https://api.github.com/users/tiancaiamao/events{/privacy}","received_events_url":"https://api.github.com/users/tiancaiamao/received_events","type":"User","site_admin":false},"labels":[{"id":564600738,"url":"https://api.github.com/repos/pingcap/tidb/labels/LGT2","name":"LGT2","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-12T02:30:41Z","updated_at":"2018-05-18T06:47:19Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/pingcap/tidb/pulls/6543","html_url":"https://github.com/pingcap/tidb/pull/6543","diff_url":"https://github.com/pingcap/tidb/pull/6543.diff","patch_url":"https://github.com/pingcap/tidb/pull/6543.patch"},"body":"The old test use a user-defined client to check request, but data race is detected in  `checkRequestClient.notFillCache`\r\n`checkRequestClient` is a global instance used by all goroutine, that's bad.\r\n\r\nI rewrite this test case to use `CheckSelectRequestHook` so the CI could be more stable.\r\n\r\n@XuHuaiyu @winkyao "},"comment":{"url":"https://api.github.com/repos/pingcap/tidb/issues/comments/390111455","html_url":"https://github.com/pingcap/tidb/pull/6543#issuecomment-390111455","issue_url":"https://api.github.com/repos/pingcap/tidb/issues/6543","id":390111455,"user":{"login":"tiancaiamao","id":1420062,"avatar_url":"https://avatars2.githubusercontent.com/u/1420062?v=4","gravatar_id":"","url":"https://api.github.com/users/tiancaiamao","html_url":"https://github.com/tiancaiamao","followers_url":"https://api.github.com/users/tiancaiamao/followers","following_url":"https://api.github.com/users/tiancaiamao/following{/other_user}","gists_url":"https://api.github.com/users/tiancaiamao/gists{/gist_id}","starred_url":"https://api.github.com/users/tiancaiamao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiancaiamao/subscriptions","organizations_url":"https://api.github.com/users/tiancaiamao/orgs","repos_url":"https://api.github.com/users/tiancaiamao/repos","events_url":"https://api.github.com/users/tiancaiamao/events{/privacy}","received_events_url":"https://api.github.com/users/tiancaiamao/received_events","type":"User","site_admin":false},"created_at":"2018-05-18T06:47:19Z","updated_at":"2018-05-18T06:47:19Z","author_association":"CONTRIBUTOR","body":"/run-common-test"}}
{"actor":{"display_login":"tiancaiamao"}}