{"action":"created","issue":{"url":"https://api.github.com/repos/GPflow/GPflow/issues/807","repository_url":"https://api.github.com/repos/GPflow/GPflow","labels_url":"https://api.github.com/repos/GPflow/GPflow/issues/807/labels{/name}","comments_url":"https://api.github.com/repos/GPflow/GPflow/issues/807/comments","events_url":"https://api.github.com/repos/GPflow/GPflow/issues/807/events","html_url":"https://github.com/GPflow/GPflow/pull/807","id":336980736,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4MzAzMzc0","number":807,"title":"Fixed discovered problem with the monitor, in particular with TensorBoard tasks","user":{"login":"ahsimb","id":21054992,"node_id":"MDQ6VXNlcjIxMDU0OTky","avatar_url":"https://avatars1.githubusercontent.com/u/21054992?v=4","gravatar_id":"","url":"https://api.github.com/users/ahsimb","html_url":"https://github.com/ahsimb","followers_url":"https://api.github.com/users/ahsimb/followers","following_url":"https://api.github.com/users/ahsimb/following{/other_user}","gists_url":"https://api.github.com/users/ahsimb/gists{/gist_id}","starred_url":"https://api.github.com/users/ahsimb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahsimb/subscriptions","organizations_url":"https://api.github.com/users/ahsimb/orgs","repos_url":"https://api.github.com/users/ahsimb/repos","events_url":"https://api.github.com/users/ahsimb/events{/privacy}","received_events_url":"https://api.github.com/users/ahsimb/received_events","type":"User","site_admin":false},"labels":[{"id":439536903,"node_id":"MDU6TGFiZWw0Mzk1MzY5MDM=","url":"https://api.github.com/repos/GPflow/GPflow/labels/discussion","name":"discussion","color":"0e8a16","default":false},{"id":894489160,"node_id":"MDU6TGFiZWw4OTQ0ODkxNjA=","url":"https://api.github.com/repos/GPflow/GPflow/labels/in%20review","name":"in review","color":"e280e5","default":false},{"id":663741448,"node_id":"MDU6TGFiZWw2NjM3NDE0NDg=","url":"https://api.github.com/repos/GPflow/GPflow/labels/not%20ready%20for%20merge","name":"not ready for merge","color":"b60205","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2018-06-29T12:30:26Z","updated_at":"2018-07-05T07:55:58Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/GPflow/GPflow/pulls/807","html_url":"https://github.com/GPflow/GPflow/pull/807","diff_url":"https://github.com/GPflow/GPflow/pull/807.diff","patch_url":"https://github.com/GPflow/GPflow/pull/807.patch"},"body":"## Fixed issues with the monitor, in particular with TensorBoard tasks.\r\n\r\n### Description\r\n\r\nAddressed remaining comments in the initial PR\r\n\r\nFixed the problem with the TensorBoard tasks writing to the same location. Since the tf.summary.FileWriter doesn't allow shared access only one task was able to write events into the location. Made the tasks sharing the FileWriter in case they use the same location.\r\n\r\nFixed a bug with ImageToTensorBoardTask. It's now closing the Figure objects. \r\n\r\n### Minimal working example\r\n\r\nSee monitor-tensorboard notebook. Now TensorBoard should have all created elements.\r\n"},"comment":{"url":"https://api.github.com/repos/GPflow/GPflow/issues/comments/402637293","html_url":"https://github.com/GPflow/GPflow/pull/807#issuecomment-402637293","issue_url":"https://api.github.com/repos/GPflow/GPflow/issues/807","id":402637293,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMjYzNzI5Mw==","user":{"login":"ahsimb","id":21054992,"node_id":"MDQ6VXNlcjIxMDU0OTky","avatar_url":"https://avatars1.githubusercontent.com/u/21054992?v=4","gravatar_id":"","url":"https://api.github.com/users/ahsimb","html_url":"https://github.com/ahsimb","followers_url":"https://api.github.com/users/ahsimb/followers","following_url":"https://api.github.com/users/ahsimb/following{/other_user}","gists_url":"https://api.github.com/users/ahsimb/gists{/gist_id}","starred_url":"https://api.github.com/users/ahsimb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ahsimb/subscriptions","organizations_url":"https://api.github.com/users/ahsimb/orgs","repos_url":"https://api.github.com/users/ahsimb/repos","events_url":"https://api.github.com/users/ahsimb/events{/privacy}","received_events_url":"https://api.github.com/users/ahsimb/received_events","type":"User","site_admin":false},"created_at":"2018-07-05T07:55:58Z","updated_at":"2018-07-05T07:55:58Z","author_association":"CONTRIBUTOR","body":"Sounds like a good compromise to me. I would just always throw an error. If the user wants to reuse the location he/she must close the TensorboardWriter (or better yet use it in `with`). In the `close` method we will remove the path from the collection.\r\n\r\nWe don't actually worry about GC (real one), it's just the @awav allegoric comparison, since both GC and the writer cache I made do reference counting."}}
{"actor":{"display_login":"ahsimb"}}