{"action":"created","comment":{"url":"https://api.github.com/repos/fortanix/rust-mbedtls/pulls/comments/236010854","pull_request_review_id":178015000,"id":236010854,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjAxMDg1NA==","diff_hunk":"@@ -37,37 +86,31 @@ impl super::BuildConfig {\n \n         let include = self.mbedtls_src.join(\"include\");\n \n-        let logger = StderrLogger;\n-        let mut bindgen = bindgen::Builder::new(header.into_os_string().into_string().unwrap());\n-        let bindings = bindgen\n-            .log(&logger)\n+        let bindings = bindgen::builder()\n             .clang_arg(\"-Dmbedtls_t_udbl=mbedtls_t_udbl;\") // bindgen can't handle unused uint128\n             .clang_arg(format!(\n                 \"-DMBEDTLS_CONFIG_FILE=<{}>\",\n                 self.config_h.to_str().expect(\"config.h UTF-8 error\")\n             )).clang_arg(format!(\n                 \"-I{}\",\n                 include.to_str().expect(\"include/ UTF-8 error\")\n-            )).match_pat(include.to_str().expect(\"include/ UTF-8 error\"))\n-            .match_pat(self.config_h.to_str().expect(\"config.h UTF-8 error\"))\n-            .use_core(true)\n+            )).header(\n+                header\n+                    .to_str()\n+                    .expect(\"failed to convert header path to string\"),\n+            ).use_core()\n             .derive_debug(false) // buggy :(\n-            .ctypes_prefix(vec![\"types\".to_owned(), \"raw_types\".to_owned()])\n-            .remove_prefix(\"mbedtls_\")\n-            .rust_enums(false)\n-            .convert_macros(true)\n-            .macro_int_types(\n-                vec![\n-                    \"sint\",\n-                    \"sint\",\n-                    \"sint\",\n-                    \"slonglong\",\n-                    \"sint\",\n-                    \"sint\",\n-                    \"sint\",\n-                    \"slonglong\",\n-                ].into_iter(),\n-            ).generate()\n+            .disable_name_namespacing()\n+            .prepend_enum_name(false)\n+            .ctypes_prefix(\"raw_types\")\n+            .parse_callbacks(Box::new(ParseCallbacks{}))\n+            // max_align_t is causing bindgen generated tests to fail an alignment check and\n+            // is not needed by the bindings.\n+            .blacklist_type(\"max_align_t\")\n+            // Including the comments breaks the generated code because it contains formatting\n+            // that is interpreted as escaped characters.","path":"mbedtls-sys/build/bindgen.rs","position":127,"original_position":127,"commit_id":"cc9e0bfac4bab6c768ac1e89b7c407329056a207","original_commit_id":"cc9e0bfac4bab6c768ac1e89b7c407329056a207","user":{"login":"jethrogb","id":1132307,"node_id":"MDQ6VXNlcjExMzIzMDc=","avatar_url":"https://avatars0.githubusercontent.com/u/1132307?v=4","gravatar_id":"","url":"https://api.github.com/users/jethrogb","html_url":"https://github.com/jethrogb","followers_url":"https://api.github.com/users/jethrogb/followers","following_url":"https://api.github.com/users/jethrogb/following{/other_user}","gists_url":"https://api.github.com/users/jethrogb/gists{/gist_id}","starred_url":"https://api.github.com/users/jethrogb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jethrogb/subscriptions","organizations_url":"https://api.github.com/users/jethrogb/orgs","repos_url":"https://api.github.com/users/jethrogb/repos","events_url":"https://api.github.com/users/jethrogb/events{/privacy}","received_events_url":"https://api.github.com/users/jethrogb/received_events","type":"User","site_admin":false},"body":"Ok, that's fine. Don't worry about it.","created_at":"2018-11-23T19:35:22Z","updated_at":"2018-11-23T19:35:22Z","html_url":"https://github.com/fortanix/rust-mbedtls/pull/14#discussion_r236010854","pull_request_url":"https://api.github.com/repos/fortanix/rust-mbedtls/pulls/14","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/fortanix/rust-mbedtls/pulls/comments/236010854"},"html":{"href":"https://github.com/fortanix/rust-mbedtls/pull/14#discussion_r236010854"},"pull_request":{"href":"https://api.github.com/repos/fortanix/rust-mbedtls/pulls/14"}},"in_reply_to_id":236010169},"pull_request":{"url":"https://api.github.com/repos/fortanix/rust-mbedtls/pulls/14","id":233264543,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMjY0NTQz","html_url":"https://github.com/fortanix/rust-mbedtls/pull/14","diff_url":"https://github.com/fortanix/rust-mbedtls/pull/14.diff","patch_url":"https://github.com/fortanix/rust-mbedtls/pull/14.patch","issue_url":"https://api.github.com/repos/fortanix/rust-mbedtls/issues/14","number":14,"state":"open","locked":false,"title":"Upgrade bindgen to 0.43","user":{"login":"ekse","id":77594,"node_id":"MDQ6VXNlcjc3NTk0","avatar_url":"https://avatars1.githubusercontent.com/u/77594?v=4","gravatar_id":"","url":"https://api.github.com/users/ekse","html_url":"https://github.com/ekse","followers_url":"https://api.github.com/users/ekse/followers","following_url":"https://api.github.com/users/ekse/following{/other_user}","gists_url":"https://api.github.com/users/ekse/gists{/gist_id}","starred_url":"https://api.github.com/users/ekse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekse/subscriptions","organizations_url":"https://api.github.com/users/ekse/orgs","repos_url":"https://api.github.com/users/ekse/repos","events_url":"https://api.github.com/users/ekse/events{/privacy}","received_events_url":"https://api.github.com/users/ekse/received_events","type":"User","site_admin":false},"body":"The rust-bindgen package is not yet updated to 0.43.2 on crates.io, so this PR currently gets it from github. We can wait for the update before merging.","created_at":"2018-11-23T18:41:19Z","updated_at":"2018-11-23T19:35:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3e9403c2bf95853033adc8465272102cdd38a96a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fortanix/rust-mbedtls/pulls/14/commits","review_comments_url":"https://api.github.com/repos/fortanix/rust-mbedtls/pulls/14/comments","review_comment_url":"https://api.github.com/repos/fortanix/rust-mbedtls/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fortanix/rust-mbedtls/issues/14/comments","statuses_url":"https://api.github.com/repos/fortanix/rust-mbedtls/statuses/cc9e0bfac4bab6c768ac1e89b7c407329056a207","head":{"label":"ekse:bindgen-upgrade-v2","ref":"bindgen-upgrade-v2","sha":"cc9e0bfac4bab6c768ac1e89b7c407329056a207","user":{"login":"ekse","id":77594,"node_id":"MDQ6VXNlcjc3NTk0","avatar_url":"https://avatars1.githubusercontent.com/u/77594?v=4","gravatar_id":"","url":"https://api.github.com/users/ekse","html_url":"https://github.com/ekse","followers_url":"https://api.github.com/users/ekse/followers","following_url":"https://api.github.com/users/ekse/following{/other_user}","gists_url":"https://api.github.com/users/ekse/gists{/gist_id}","starred_url":"https://api.github.com/users/ekse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekse/subscriptions","organizations_url":"https://api.github.com/users/ekse/orgs","repos_url":"https://api.github.com/users/ekse/repos","events_url":"https://api.github.com/users/ekse/events{/privacy}","received_events_url":"https://api.github.com/users/ekse/received_events","type":"User","site_admin":false},"repo":{"id":155618778,"node_id":"MDEwOlJlcG9zaXRvcnkxNTU2MTg3Nzg=","name":"rust-mbedtls","full_name":"ekse/rust-mbedtls","private":false,"owner":{"login":"ekse","id":77594,"node_id":"MDQ6VXNlcjc3NTk0","avatar_url":"https://avatars1.githubusercontent.com/u/77594?v=4","gravatar_id":"","url":"https://api.github.com/users/ekse","html_url":"https://github.com/ekse","followers_url":"https://api.github.com/users/ekse/followers","following_url":"https://api.github.com/users/ekse/following{/other_user}","gists_url":"https://api.github.com/users/ekse/gists{/gist_id}","starred_url":"https://api.github.com/users/ekse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ekse/subscriptions","organizations_url":"https://api.github.com/users/ekse/orgs","repos_url":"https://api.github.com/users/ekse/repos","events_url":"https://api.github.com/users/ekse/events{/privacy}","received_events_url":"https://api.github.com/users/ekse/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ekse/rust-mbedtls","description":null,"fork":true,"url":"https://api.github.com/repos/ekse/rust-mbedtls","forks_url":"https://api.github.com/repos/ekse/rust-mbedtls/forks","keys_url":"https://api.github.com/repos/ekse/rust-mbedtls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ekse/rust-mbedtls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ekse/rust-mbedtls/teams","hooks_url":"https://api.github.com/repos/ekse/rust-mbedtls/hooks","issue_events_url":"https://api.github.com/repos/ekse/rust-mbedtls/issues/events{/number}","events_url":"https://api.github.com/repos/ekse/rust-mbedtls/events","assignees_url":"https://api.github.com/repos/ekse/rust-mbedtls/assignees{/user}","branches_url":"https://api.github.com/repos/ekse/rust-mbedtls/branches{/branch}","tags_url":"https://api.github.com/repos/ekse/rust-mbedtls/tags","blobs_url":"https://api.github.com/repos/ekse/rust-mbedtls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ekse/rust-mbedtls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ekse/rust-mbedtls/git/refs{/sha}","trees_url":"https://api.github.com/repos/ekse/rust-mbedtls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ekse/rust-mbedtls/statuses/{sha}","languages_url":"https://api.github.com/repos/ekse/rust-mbedtls/languages","stargazers_url":"https://api.github.com/repos/ekse/rust-mbedtls/stargazers","contributors_url":"https://api.github.com/repos/ekse/rust-mbedtls/contributors","subscribers_url":"https://api.github.com/repos/ekse/rust-mbedtls/subscribers","subscription_url":"https://api.github.com/repos/ekse/rust-mbedtls/subscription","commits_url":"https://api.github.com/repos/ekse/rust-mbedtls/commits{/sha}","git_commits_url":"https://api.github.com/repos/ekse/rust-mbedtls/git/commits{/sha}","comments_url":"https://api.github.com/repos/ekse/rust-mbedtls/comments{/number}","issue_comment_url":"https://api.github.com/repos/ekse/rust-mbedtls/issues/comments{/number}","contents_url":"https://api.github.com/repos/ekse/rust-mbedtls/contents/{+path}","compare_url":"https://api.github.com/repos/ekse/rust-mbedtls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ekse/rust-mbedtls/merges","archive_url":"https://api.github.com/repos/ekse/rust-mbedtls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ekse/rust-mbedtls/downloads","issues_url":"https://api.github.com/repos/ekse/rust-mbedtls/issues{/number}","pulls_url":"https://api.github.com/repos/ekse/rust-mbedtls/pulls{/number}","milestones_url":"https://api.github.com/repos/ekse/rust-mbedtls/milestones{/number}","notifications_url":"https://api.github.com/repos/ekse/rust-mbedtls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ekse/rust-mbedtls/labels{/name}","releases_url":"https://api.github.com/repos/ekse/rust-mbedtls/releases{/id}","deployments_url":"https://api.github.com/repos/ekse/rust-mbedtls/deployments","created_at":"2018-10-31T20:24:10Z","updated_at":"2018-10-31T20:24:13Z","pushed_at":"2018-11-23T18:38:23Z","git_url":"git://github.com/ekse/rust-mbedtls.git","ssh_url":"git@github.com:ekse/rust-mbedtls.git","clone_url":"https://github.com/ekse/rust-mbedtls.git","svn_url":"https://github.com/ekse/rust-mbedtls","homepage":null,"size":2835,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fortanix:master","ref":"master","sha":"014e850df60aad8a1413fefd3f732858d51d66b3","user":{"login":"fortanix","id":25450966,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NDUwOTY2","avatar_url":"https://avatars2.githubusercontent.com/u/25450966?v=4","gravatar_id":"","url":"https://api.github.com/users/fortanix","html_url":"https://github.com/fortanix","followers_url":"https://api.github.com/users/fortanix/followers","following_url":"https://api.github.com/users/fortanix/following{/other_user}","gists_url":"https://api.github.com/users/fortanix/gists{/gist_id}","starred_url":"https://api.github.com/users/fortanix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fortanix/subscriptions","organizations_url":"https://api.github.com/users/fortanix/orgs","repos_url":"https://api.github.com/users/fortanix/repos","events_url":"https://api.github.com/users/fortanix/events{/privacy}","received_events_url":"https://api.github.com/users/fortanix/received_events","type":"Organization","site_admin":false},"repo":{"id":72390806,"node_id":"MDEwOlJlcG9zaXRvcnk3MjM5MDgwNg==","name":"rust-mbedtls","full_name":"fortanix/rust-mbedtls","private":false,"owner":{"login":"fortanix","id":25450966,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NDUwOTY2","avatar_url":"https://avatars2.githubusercontent.com/u/25450966?v=4","gravatar_id":"","url":"https://api.github.com/users/fortanix","html_url":"https://github.com/fortanix","followers_url":"https://api.github.com/users/fortanix/followers","following_url":"https://api.github.com/users/fortanix/following{/other_user}","gists_url":"https://api.github.com/users/fortanix/gists{/gist_id}","starred_url":"https://api.github.com/users/fortanix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fortanix/subscriptions","organizations_url":"https://api.github.com/users/fortanix/orgs","repos_url":"https://api.github.com/users/fortanix/repos","events_url":"https://api.github.com/users/fortanix/events{/privacy}","received_events_url":"https://api.github.com/users/fortanix/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/fortanix/rust-mbedtls","description":"Idiomatic Rust wrapper for MbedTLS","fork":false,"url":"https://api.github.com/repos/fortanix/rust-mbedtls","forks_url":"https://api.github.com/repos/fortanix/rust-mbedtls/forks","keys_url":"https://api.github.com/repos/fortanix/rust-mbedtls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fortanix/rust-mbedtls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fortanix/rust-mbedtls/teams","hooks_url":"https://api.github.com/repos/fortanix/rust-mbedtls/hooks","issue_events_url":"https://api.github.com/repos/fortanix/rust-mbedtls/issues/events{/number}","events_url":"https://api.github.com/repos/fortanix/rust-mbedtls/events","assignees_url":"https://api.github.com/repos/fortanix/rust-mbedtls/assignees{/user}","branches_url":"https://api.github.com/repos/fortanix/rust-mbedtls/branches{/branch}","tags_url":"https://api.github.com/repos/fortanix/rust-mbedtls/tags","blobs_url":"https://api.github.com/repos/fortanix/rust-mbedtls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fortanix/rust-mbedtls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fortanix/rust-mbedtls/git/refs{/sha}","trees_url":"https://api.github.com/repos/fortanix/rust-mbedtls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fortanix/rust-mbedtls/statuses/{sha}","languages_url":"https://api.github.com/repos/fortanix/rust-mbedtls/languages","stargazers_url":"https://api.github.com/repos/fortanix/rust-mbedtls/stargazers","contributors_url":"https://api.github.com/repos/fortanix/rust-mbedtls/contributors","subscribers_url":"https://api.github.com/repos/fortanix/rust-mbedtls/subscribers","subscription_url":"https://api.github.com/repos/fortanix/rust-mbedtls/subscription","commits_url":"https://api.github.com/repos/fortanix/rust-mbedtls/commits{/sha}","git_commits_url":"https://api.github.com/repos/fortanix/rust-mbedtls/git/commits{/sha}","comments_url":"https://api.github.com/repos/fortanix/rust-mbedtls/comments{/number}","issue_comment_url":"https://api.github.com/repos/fortanix/rust-mbedtls/issues/comments{/number}","contents_url":"https://api.github.com/repos/fortanix/rust-mbedtls/contents/{+path}","compare_url":"https://api.github.com/repos/fortanix/rust-mbedtls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fortanix/rust-mbedtls/merges","archive_url":"https://api.github.com/repos/fortanix/rust-mbedtls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fortanix/rust-mbedtls/downloads","issues_url":"https://api.github.com/repos/fortanix/rust-mbedtls/issues{/number}","pulls_url":"https://api.github.com/repos/fortanix/rust-mbedtls/pulls{/number}","milestones_url":"https://api.github.com/repos/fortanix/rust-mbedtls/milestones{/number}","notifications_url":"https://api.github.com/repos/fortanix/rust-mbedtls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fortanix/rust-mbedtls/labels{/name}","releases_url":"https://api.github.com/repos/fortanix/rust-mbedtls/releases{/id}","deployments_url":"https://api.github.com/repos/fortanix/rust-mbedtls/deployments","created_at":"2016-10-31T02:25:25Z","updated_at":"2018-11-23T05:59:36Z","pushed_at":"2018-11-23T18:41:20Z","git_url":"git://github.com/fortanix/rust-mbedtls.git","ssh_url":"git@github.com:fortanix/rust-mbedtls.git","clone_url":"https://github.com/fortanix/rust-mbedtls.git","svn_url":"https://github.com/fortanix/rust-mbedtls","homepage":"","size":2807,"stargazers_count":5,"watchers_count":5,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5,"open_issues":11,"watchers":5,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fortanix/rust-mbedtls/pulls/14"},"html":{"href":"https://github.com/fortanix/rust-mbedtls/pull/14"},"issue":{"href":"https://api.github.com/repos/fortanix/rust-mbedtls/issues/14"},"comments":{"href":"https://api.github.com/repos/fortanix/rust-mbedtls/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/fortanix/rust-mbedtls/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/fortanix/rust-mbedtls/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fortanix/rust-mbedtls/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/fortanix/rust-mbedtls/statuses/cc9e0bfac4bab6c768ac1e89b7c407329056a207"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jethrogb"}}