{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/openshift-ansible/issues/7288","repository_url":"https://api.github.com/repos/openshift/openshift-ansible","labels_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/7288/labels{/name}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/7288/comments","events_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/7288/events","html_url":"https://github.com/openshift/openshift-ansible/pull/7288","id":300243343,"number":7288,"title":"Remove no_log: True from openshift_version calls","user":{"login":"sdodson","id":48161,"avatar_url":"https://avatars2.githubusercontent.com/u/48161?v=4","gravatar_id":"","url":"https://api.github.com/users/sdodson","html_url":"https://github.com/sdodson","followers_url":"https://api.github.com/users/sdodson/followers","following_url":"https://api.github.com/users/sdodson/following{/other_user}","gists_url":"https://api.github.com/users/sdodson/gists{/gist_id}","starred_url":"https://api.github.com/users/sdodson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sdodson/subscriptions","organizations_url":"https://api.github.com/users/sdodson/orgs","repos_url":"https://api.github.com/users/sdodson/repos","events_url":"https://api.github.com/users/sdodson/events{/privacy}","received_events_url":"https://api.github.com/users/sdodson/received_events","type":"User","site_admin":false},"labels":[{"id":681664198,"url":"https://api.github.com/repos/openshift/openshift-ansible/labels/size/XS","name":"size/XS","color":"009900","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-02-26T13:44:00Z","updated_at":"2018-02-26T14:33:09Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/openshift/openshift-ansible/pulls/7288","html_url":"https://github.com/openshift/openshift-ansible/pull/7288","diff_url":"https://github.com/openshift/openshift-ansible/pull/7288.diff","patch_url":"https://github.com/openshift/openshift-ansible/pull/7288.patch"},"body":"#6519 set `no_log: True` on several plays and tasks in order to prevent logging credentials that come over from the inventory. However that's led to openshift_version role being invoked in a manner that it omits required debugging information like the following. I think we need to be very careful not to apply `no_log: True` at the playbook level and instead only use it on specific tasks that are known to emit sensitive information.\r\n\r\nI think it's also worth considering that the ansible logs simply need to be treated as sensitive data and handled appropriately rather than omitting potentially useful debugging data.\r\n\r\n```\r\n# ansible-playbook /usr/share/ansible/openshift-ansible/playbooks/byo/openshift-cluster/upgrades/v3_9/upgrade.yml\r\n\r\nTASK [openshift_version : Get available atomic-openshift version] *************************************************************************************************************************************************\r\ntask path: /usr/share/ansible/openshift-ansible/roles/openshift_version/tasks/check_available_rpms.yml:2\r\nUsing module file /usr/share/ansible/openshift-ansible/roles/lib_utils/library/repoquery.py\r\n\r\nTASK [openshift_version : fail] ***********************************************************************************************************************************************************************************\r\ntask path: /usr/share/ansible/openshift-ansible/roles/openshift_version/tasks/check_available_rpms.yml:8\r\nfatal: [host-xxxx.redhat.com]: FAILED! => {\r\n    \"censored\": \"the output has been hidden due to the fact that 'no_log: true' was specified for this result\", \r\n    \"changed\": false\r\n}\r\n```"},"comment":{"url":"https://api.github.com/repos/openshift/openshift-ansible/issues/comments/368521853","html_url":"https://github.com/openshift/openshift-ansible/pull/7288#issuecomment-368521853","issue_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/7288","id":368521853,"user":{"login":"openshift-ci-robot","id":30189103,"avatar_url":"https://avatars1.githubusercontent.com/u/30189103?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift-ci-robot","html_url":"https://github.com/openshift-ci-robot","followers_url":"https://api.github.com/users/openshift-ci-robot/followers","following_url":"https://api.github.com/users/openshift-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/openshift-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/openshift-ci-robot/orgs","repos_url":"https://api.github.com/users/openshift-ci-robot/repos","events_url":"https://api.github.com/users/openshift-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/openshift-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-02-26T14:33:09Z","updated_at":"2018-02-26T14:33:09Z","author_association":"NONE","body":"@sdodson: The following test **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\nci/openshift-jenkins/system-containers | 0a5f4dcba7f67e6203380c0c340e962bfde3a2ff | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/openshift_openshift-ansible/7288/test_pull_request_openshift_ansible_extended_conformance_install_system_containers/5425/) | `/test system-containers`\n\n[Full PR test history](https://openshift-gce-devel.appspot.com/pr/openshift_openshift-ansible/7288). [Your PR dashboard](https://openshift-gce-devel.appspot.com/pr/sdodson). Please help us cut down on flakes by [linking to](https://github.com/kubernetes/community/blob/master/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/openshift/openshift-ansible/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/devel/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"openshift-ci-robot"}}