{"action":"created","comment":{"url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/pulls/comments/183254045","pull_request_review_id":114217220,"id":183254045,"diff_hunk":"@@ -40,8 +40,12 @@ class SendTransactionCoordinator {\n                 case .success(let count):\n                     let transaction = self.appendNonce(to: transaction, currentNonce: count)\n                     self.signAndSend(transaction: transaction, completion: completion)\n+                    // analytics event for succesfully sent transaction from wallet\n+                    Analytics.track(.sentTransactionFromWallet)\n                 case .failure(let error):\n                     completion(.failure(AnyError(error)))\n+                    // analytics event for failed sent transaction from wallet\n+                    Analytics.track(.failedTransactionFromWallet)","path":"Trust/Transfer/Coordinators/SendTransactionCoordinator.swift","position":9,"original_position":9,"commit_id":"ae68197b55fe1f6f1532d8dfd8d9da01f5ecd971","original_commit_id":"ae68197b55fe1f6f1532d8dfd8d9da01f5ecd971","user":{"login":"vikmeup","id":1641795,"avatar_url":"https://avatars0.githubusercontent.com/u/1641795?v=4","gravatar_id":"","url":"https://api.github.com/users/vikmeup","html_url":"https://github.com/vikmeup","followers_url":"https://api.github.com/users/vikmeup/followers","following_url":"https://api.github.com/users/vikmeup/following{/other_user}","gists_url":"https://api.github.com/users/vikmeup/gists{/gist_id}","starred_url":"https://api.github.com/users/vikmeup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vikmeup/subscriptions","organizations_url":"https://api.github.com/users/vikmeup/orgs","repos_url":"https://api.github.com/users/vikmeup/repos","events_url":"https://api.github.com/users/vikmeup/events{/privacy}","received_events_url":"https://api.github.com/users/vikmeup/received_events","type":"User","site_admin":false},"body":"@slgraham once we sign transaction we broadcast it to the network, I think we should be fine for now","created_at":"2018-04-22T22:31:51Z","updated_at":"2018-04-22T22:31:51Z","html_url":"https://github.com/TrustWallet/trust-wallet-ios/pull/659#discussion_r183254045","pull_request_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/pulls/659","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/pulls/comments/183254045"},"html":{"href":"https://github.com/TrustWallet/trust-wallet-ios/pull/659#discussion_r183254045"},"pull_request":{"href":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/pulls/659"}},"in_reply_to_id":183252398},"pull_request":{"url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/pulls/659","id":183284133,"html_url":"https://github.com/TrustWallet/trust-wallet-ios/pull/659","diff_url":"https://github.com/TrustWallet/trust-wallet-ios/pull/659.diff","patch_url":"https://github.com/TrustWallet/trust-wallet-ios/pull/659.patch","issue_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/issues/659","number":659,"state":"open","locked":false,"title":"Initial firebase analytics","user":{"login":"slgraham","id":13247381,"avatar_url":"https://avatars2.githubusercontent.com/u/13247381?v=4","gravatar_id":"","url":"https://api.github.com/users/slgraham","html_url":"https://github.com/slgraham","followers_url":"https://api.github.com/users/slgraham/followers","following_url":"https://api.github.com/users/slgraham/following{/other_user}","gists_url":"https://api.github.com/users/slgraham/gists{/gist_id}","starred_url":"https://api.github.com/users/slgraham/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slgraham/subscriptions","organizations_url":"https://api.github.com/users/slgraham/orgs","repos_url":"https://api.github.com/users/slgraham/repos","events_url":"https://api.github.com/users/slgraham/events{/privacy}","received_events_url":"https://api.github.com/users/slgraham/received_events","type":"User","site_admin":false},"body":"A few things I'm not 100% sure about:\r\n\r\n- I put some of the events in coordinators\r\n- I created both success and failure events, but I'm not sure exactly what the failure cases will tell us since I'm not familiar with what might cause them\r\n- I didn't include a parameter for transaction type in completedTransactionFromBrowser since there wasn't a global variable for type there, but it would be helpful to know when the transaction was a signed vs. sent transaction\r\n\r\nLet me know what you think.","created_at":"2018-04-22T17:25:03Z","updated_at":"2018-04-22T22:31:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0ec52b97c378f1ceb36e7dd080eb5a1e4d78c687","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":910259453,"url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/labels/analytics","name":"analytics","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/pulls/659/commits","review_comments_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/pulls/659/comments","review_comment_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/issues/659/comments","statuses_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/statuses/ae68197b55fe1f6f1532d8dfd8d9da01f5ecd971","head":{"label":"TrustWallet:BasicAnalytics","ref":"BasicAnalytics","sha":"ae68197b55fe1f6f1532d8dfd8d9da01f5ecd971","user":{"login":"TrustWallet","id":32179889,"avatar_url":"https://avatars2.githubusercontent.com/u/32179889?v=4","gravatar_id":"","url":"https://api.github.com/users/TrustWallet","html_url":"https://github.com/TrustWallet","followers_url":"https://api.github.com/users/TrustWallet/followers","following_url":"https://api.github.com/users/TrustWallet/following{/other_user}","gists_url":"https://api.github.com/users/TrustWallet/gists{/gist_id}","starred_url":"https://api.github.com/users/TrustWallet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrustWallet/subscriptions","organizations_url":"https://api.github.com/users/TrustWallet/orgs","repos_url":"https://api.github.com/users/TrustWallet/repos","events_url":"https://api.github.com/users/TrustWallet/events{/privacy}","received_events_url":"https://api.github.com/users/TrustWallet/received_events","type":"Organization","site_admin":false},"repo":{"id":104401601,"name":"trust-wallet-ios","full_name":"TrustWallet/trust-wallet-ios","owner":{"login":"TrustWallet","id":32179889,"avatar_url":"https://avatars2.githubusercontent.com/u/32179889?v=4","gravatar_id":"","url":"https://api.github.com/users/TrustWallet","html_url":"https://github.com/TrustWallet","followers_url":"https://api.github.com/users/TrustWallet/followers","following_url":"https://api.github.com/users/TrustWallet/following{/other_user}","gists_url":"https://api.github.com/users/TrustWallet/gists{/gist_id}","starred_url":"https://api.github.com/users/TrustWallet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrustWallet/subscriptions","organizations_url":"https://api.github.com/users/TrustWallet/orgs","repos_url":"https://api.github.com/users/TrustWallet/repos","events_url":"https://api.github.com/users/TrustWallet/events{/privacy}","received_events_url":"https://api.github.com/users/TrustWallet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TrustWallet/trust-wallet-ios","description":":iphone: Trust - Ethereum Wallet and Web3 DApp Browser for iOS","fork":false,"url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios","forks_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/forks","keys_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/teams","hooks_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/hooks","issue_events_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/issues/events{/number}","events_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/events","assignees_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/assignees{/user}","branches_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/branches{/branch}","tags_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/tags","blobs_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/languages","stargazers_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/stargazers","contributors_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/contributors","subscribers_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/subscribers","subscription_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/subscription","commits_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/contents/{+path}","compare_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/merges","archive_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/downloads","issues_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/issues{/number}","pulls_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/labels{/name}","releases_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/releases{/id}","deployments_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/deployments","created_at":"2017-09-21T21:40:02Z","updated_at":"2018-04-22T15:28:42Z","pushed_at":"2018-04-22T17:35:12Z","git_url":"git://github.com/TrustWallet/trust-wallet-ios.git","ssh_url":"git@github.com:TrustWallet/trust-wallet-ios.git","clone_url":"https://github.com/TrustWallet/trust-wallet-ios.git","svn_url":"https://github.com/TrustWallet/trust-wallet-ios","homepage":"https://trustwalletapp.com","size":11414,"stargazers_count":552,"watchers_count":552,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":137,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":137,"open_issues":35,"watchers":552,"default_branch":"master"}},"base":{"label":"TrustWallet:master","ref":"master","sha":"45db1d0417ea478e8b883762d5b0fa03d4876a7f","user":{"login":"TrustWallet","id":32179889,"avatar_url":"https://avatars2.githubusercontent.com/u/32179889?v=4","gravatar_id":"","url":"https://api.github.com/users/TrustWallet","html_url":"https://github.com/TrustWallet","followers_url":"https://api.github.com/users/TrustWallet/followers","following_url":"https://api.github.com/users/TrustWallet/following{/other_user}","gists_url":"https://api.github.com/users/TrustWallet/gists{/gist_id}","starred_url":"https://api.github.com/users/TrustWallet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrustWallet/subscriptions","organizations_url":"https://api.github.com/users/TrustWallet/orgs","repos_url":"https://api.github.com/users/TrustWallet/repos","events_url":"https://api.github.com/users/TrustWallet/events{/privacy}","received_events_url":"https://api.github.com/users/TrustWallet/received_events","type":"Organization","site_admin":false},"repo":{"id":104401601,"name":"trust-wallet-ios","full_name":"TrustWallet/trust-wallet-ios","owner":{"login":"TrustWallet","id":32179889,"avatar_url":"https://avatars2.githubusercontent.com/u/32179889?v=4","gravatar_id":"","url":"https://api.github.com/users/TrustWallet","html_url":"https://github.com/TrustWallet","followers_url":"https://api.github.com/users/TrustWallet/followers","following_url":"https://api.github.com/users/TrustWallet/following{/other_user}","gists_url":"https://api.github.com/users/TrustWallet/gists{/gist_id}","starred_url":"https://api.github.com/users/TrustWallet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrustWallet/subscriptions","organizations_url":"https://api.github.com/users/TrustWallet/orgs","repos_url":"https://api.github.com/users/TrustWallet/repos","events_url":"https://api.github.com/users/TrustWallet/events{/privacy}","received_events_url":"https://api.github.com/users/TrustWallet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TrustWallet/trust-wallet-ios","description":":iphone: Trust - Ethereum Wallet and Web3 DApp Browser for iOS","fork":false,"url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios","forks_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/forks","keys_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/teams","hooks_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/hooks","issue_events_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/issues/events{/number}","events_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/events","assignees_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/assignees{/user}","branches_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/branches{/branch}","tags_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/tags","blobs_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/languages","stargazers_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/stargazers","contributors_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/contributors","subscribers_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/subscribers","subscription_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/subscription","commits_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/contents/{+path}","compare_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/merges","archive_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/downloads","issues_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/issues{/number}","pulls_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/labels{/name}","releases_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/releases{/id}","deployments_url":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/deployments","created_at":"2017-09-21T21:40:02Z","updated_at":"2018-04-22T15:28:42Z","pushed_at":"2018-04-22T17:35:12Z","git_url":"git://github.com/TrustWallet/trust-wallet-ios.git","ssh_url":"git@github.com:TrustWallet/trust-wallet-ios.git","clone_url":"https://github.com/TrustWallet/trust-wallet-ios.git","svn_url":"https://github.com/TrustWallet/trust-wallet-ios","homepage":"https://trustwalletapp.com","size":11414,"stargazers_count":552,"watchers_count":552,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":137,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":137,"open_issues":35,"watchers":552,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/pulls/659"},"html":{"href":"https://github.com/TrustWallet/trust-wallet-ios/pull/659"},"issue":{"href":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/issues/659"},"comments":{"href":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/issues/659/comments"},"review_comments":{"href":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/pulls/659/comments"},"review_comment":{"href":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/pulls/659/commits"},"statuses":{"href":"https://api.github.com/repos/TrustWallet/trust-wallet-ios/statuses/ae68197b55fe1f6f1532d8dfd8d9da01f5ecd971"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"vikmeup"}}