{"action":"created","comment":{"url":"https://api.github.com/repos/excaliburjs/sample-shootemup/pulls/comments/244808926","pull_request_review_id":188771097,"id":244808926,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDgwODkyNg==","diff_hunk":"@@ -0,0 +1,42 @@\n+import * as ex from \"excalibur\";\n+\n+interface AnimationNode {\n+    pos: ex.Vector,\n+    anim: ex.Animation\n+}\n+\n+export class AnimationManager extends ex.Actor {\n+    private animations: AnimationNode[] = [];\n+    constructor() {\n+        super({\n+            x: 0, \n+            y: 0, \n+            width: 0,\n+            height: 0,\n+            collisionType: ex.CollisionType.PreventCollision,\n+        });\n+        this.traits.length = 0;\n+    }\n+    \n+    play(animation: ex.Animation, pos: ex.Vector){\n+        this.animations.push({\n+            anim: animation,\n+            pos: pos.clone()\n+        });\n+    }\n+\n+    onPostUpdate() {\n+        this.animations = this.animations.filter(a => !a.anim.isDone());\n+    }\n+\n+    onPostDraw(ctx: CanvasRenderingContext2D, delta: number) {","path":"src/actors/AnimationManager.ts","position":32,"original_position":32,"commit_id":"c418b6fcf6b5189dae27155cf895c338357c43d2","original_commit_id":"c418b6fcf6b5189dae27155cf895c338357c43d2","user":{"login":"code0wl","id":765701,"node_id":"MDQ6VXNlcjc2NTcwMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/765701?v=4","gravatar_id":"","url":"https://api.github.com/users/code0wl","html_url":"https://github.com/code0wl","followers_url":"https://api.github.com/users/code0wl/followers","following_url":"https://api.github.com/users/code0wl/following{/other_user}","gists_url":"https://api.github.com/users/code0wl/gists{/gist_id}","starred_url":"https://api.github.com/users/code0wl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/code0wl/subscriptions","organizations_url":"https://api.github.com/users/code0wl/orgs","repos_url":"https://api.github.com/users/code0wl/repos","events_url":"https://api.github.com/users/code0wl/events{/privacy}","received_events_url":"https://api.github.com/users/code0wl/received_events","type":"User","site_admin":false},"body":"Can omit delta?","created_at":"2019-01-02T18:10:37Z","updated_at":"2019-01-02T18:10:37Z","html_url":"https://github.com/excaliburjs/sample-shootemup/pull/1#discussion_r244808926","pull_request_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/excaliburjs/sample-shootemup/pulls/comments/244808926"},"html":{"href":"https://github.com/excaliburjs/sample-shootemup/pull/1#discussion_r244808926"},"pull_request":{"href":"https://api.github.com/repos/excaliburjs/sample-shootemup/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/excaliburjs/sample-shootemup/pulls/1","id":209362430,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MzYyNDMw","html_url":"https://github.com/excaliburjs/sample-shootemup/pull/1","diff_url":"https://github.com/excaliburjs/sample-shootemup/pull/1.diff","patch_url":"https://github.com/excaliburjs/sample-shootemup/pull/1.patch","issue_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/issues/1","number":1,"state":"open","locked":false,"title":"[chore] Upgrade excalibur and sample","user":{"login":"eonarheim","id":612071,"node_id":"MDQ6VXNlcjYxMjA3MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/612071?v=4","gravatar_id":"","url":"https://api.github.com/users/eonarheim","html_url":"https://github.com/eonarheim","followers_url":"https://api.github.com/users/eonarheim/followers","following_url":"https://api.github.com/users/eonarheim/following{/other_user}","gists_url":"https://api.github.com/users/eonarheim/gists{/gist_id}","starred_url":"https://api.github.com/users/eonarheim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eonarheim/subscriptions","organizations_url":"https://api.github.com/users/eonarheim/orgs","repos_url":"https://api.github.com/users/eonarheim/repos","events_url":"https://api.github.com/users/eonarheim/events{/privacy}","received_events_url":"https://api.github.com/users/eonarheim/received_events","type":"User","site_admin":false},"body":"This PR upgrades the old shoot-em-up example to use modern excalibur and patterns.\r\n\r\nTODOS:\r\n- [ ] Add scene based level instead of having a bunch of code in main\r\n- [x] Fix game over screen","created_at":"2018-08-19T14:20:39Z","updated_at":"2019-01-02T18:10:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bba4317031216ba0ea70d7eed03c4cf4f9b54e91","assignee":null,"assignees":[],"requested_reviewers":[{"login":"kamranayub","id":563819,"node_id":"MDQ6VXNlcjU2MzgxOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/563819?v=4","gravatar_id":"","url":"https://api.github.com/users/kamranayub","html_url":"https://github.com/kamranayub","followers_url":"https://api.github.com/users/kamranayub/followers","following_url":"https://api.github.com/users/kamranayub/following{/other_user}","gists_url":"https://api.github.com/users/kamranayub/gists{/gist_id}","starred_url":"https://api.github.com/users/kamranayub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamranayub/subscriptions","organizations_url":"https://api.github.com/users/kamranayub/orgs","repos_url":"https://api.github.com/users/kamranayub/repos","events_url":"https://api.github.com/users/kamranayub/events{/privacy}","received_events_url":"https://api.github.com/users/kamranayub/received_events","type":"User","site_admin":false},{"login":"jedeen","id":675840,"node_id":"MDQ6VXNlcjY3NTg0MA==","avatar_url":"https://avatars0.githubusercontent.com/u/675840?v=4","gravatar_id":"","url":"https://api.github.com/users/jedeen","html_url":"https://github.com/jedeen","followers_url":"https://api.github.com/users/jedeen/followers","following_url":"https://api.github.com/users/jedeen/following{/other_user}","gists_url":"https://api.github.com/users/jedeen/gists{/gist_id}","starred_url":"https://api.github.com/users/jedeen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jedeen/subscriptions","organizations_url":"https://api.github.com/users/jedeen/orgs","repos_url":"https://api.github.com/users/jedeen/repos","events_url":"https://api.github.com/users/jedeen/events{/privacy}","received_events_url":"https://api.github.com/users/jedeen/received_events","type":"User","site_admin":false},{"login":"alanag13","id":5409649,"node_id":"MDQ6VXNlcjU0MDk2NDk=","avatar_url":"https://avatars1.githubusercontent.com/u/5409649?v=4","gravatar_id":"","url":"https://api.github.com/users/alanag13","html_url":"https://github.com/alanag13","followers_url":"https://api.github.com/users/alanag13/followers","following_url":"https://api.github.com/users/alanag13/following{/other_user}","gists_url":"https://api.github.com/users/alanag13/gists{/gist_id}","starred_url":"https://api.github.com/users/alanag13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alanag13/subscriptions","organizations_url":"https://api.github.com/users/alanag13/orgs","repos_url":"https://api.github.com/users/alanag13/repos","events_url":"https://api.github.com/users/alanag13/events{/privacy}","received_events_url":"https://api.github.com/users/alanag13/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1028792515,"node_id":"MDU6TGFiZWwxMDI4NzkyNTE1","url":"https://api.github.com/repos/excaliburjs/sample-shootemup/labels/Work%20In%20Progress","name":"Work In Progress","color":"ad293d","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/pulls/1/commits","review_comments_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/pulls/1/comments","review_comment_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/pulls/comments{/number}","comments_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/issues/1/comments","statuses_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/statuses/c418b6fcf6b5189dae27155cf895c338357c43d2","head":{"label":"excaliburjs:upgrade-excalibur","ref":"upgrade-excalibur","sha":"c418b6fcf6b5189dae27155cf895c338357c43d2","user":{"login":"excaliburjs","id":6165683,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNjU2ODM=","avatar_url":"https://avatars3.githubusercontent.com/u/6165683?v=4","gravatar_id":"","url":"https://api.github.com/users/excaliburjs","html_url":"https://github.com/excaliburjs","followers_url":"https://api.github.com/users/excaliburjs/followers","following_url":"https://api.github.com/users/excaliburjs/following{/other_user}","gists_url":"https://api.github.com/users/excaliburjs/gists{/gist_id}","starred_url":"https://api.github.com/users/excaliburjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/excaliburjs/subscriptions","organizations_url":"https://api.github.com/users/excaliburjs/orgs","repos_url":"https://api.github.com/users/excaliburjs/repos","events_url":"https://api.github.com/users/excaliburjs/events{/privacy}","received_events_url":"https://api.github.com/users/excaliburjs/received_events","type":"Organization","site_admin":false},"repo":{"id":144221943,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQyMjE5NDM=","name":"sample-shootemup","full_name":"excaliburjs/sample-shootemup","private":false,"owner":{"login":"excaliburjs","id":6165683,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNjU2ODM=","avatar_url":"https://avatars3.githubusercontent.com/u/6165683?v=4","gravatar_id":"","url":"https://api.github.com/users/excaliburjs","html_url":"https://github.com/excaliburjs","followers_url":"https://api.github.com/users/excaliburjs/followers","following_url":"https://api.github.com/users/excaliburjs/following{/other_user}","gists_url":"https://api.github.com/users/excaliburjs/gists{/gist_id}","starred_url":"https://api.github.com/users/excaliburjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/excaliburjs/subscriptions","organizations_url":"https://api.github.com/users/excaliburjs/orgs","repos_url":"https://api.github.com/users/excaliburjs/repos","events_url":"https://api.github.com/users/excaliburjs/events{/privacy}","received_events_url":"https://api.github.com/users/excaliburjs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/excaliburjs/sample-shootemup","description":"Example Shoot-em Up Style Game Built with Excalibur","fork":true,"url":"https://api.github.com/repos/excaliburjs/sample-shootemup","forks_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/forks","keys_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/teams","hooks_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/hooks","issue_events_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/issues/events{/number}","events_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/events","assignees_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/assignees{/user}","branches_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/branches{/branch}","tags_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/tags","blobs_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/git/refs{/sha}","trees_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/statuses/{sha}","languages_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/languages","stargazers_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/stargazers","contributors_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/contributors","subscribers_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/subscribers","subscription_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/subscription","commits_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/commits{/sha}","git_commits_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/git/commits{/sha}","comments_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/comments{/number}","issue_comment_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/issues/comments{/number}","contents_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/contents/{+path}","compare_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/merges","archive_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/downloads","issues_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/issues{/number}","pulls_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/pulls{/number}","milestones_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/milestones{/number}","notifications_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/labels{/name}","releases_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/releases{/id}","deployments_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/deployments","created_at":"2018-08-10T01:36:36Z","updated_at":"2018-08-10T01:45:51Z","pushed_at":"2018-10-23T02:54:29Z","git_url":"git://github.com/excaliburjs/sample-shootemup.git","ssh_url":"git@github.com:excaliburjs/sample-shootemup.git","clone_url":"https://github.com/excaliburjs/sample-shootemup.git","svn_url":"https://github.com/excaliburjs/sample-shootemup","homepage":"https://excaliburjs.com/sample-shootemup","size":10167,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"excaliburjs:master","ref":"master","sha":"66d10e42df1d8fa0fd84efe023388c936c0d8318","user":{"login":"excaliburjs","id":6165683,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNjU2ODM=","avatar_url":"https://avatars3.githubusercontent.com/u/6165683?v=4","gravatar_id":"","url":"https://api.github.com/users/excaliburjs","html_url":"https://github.com/excaliburjs","followers_url":"https://api.github.com/users/excaliburjs/followers","following_url":"https://api.github.com/users/excaliburjs/following{/other_user}","gists_url":"https://api.github.com/users/excaliburjs/gists{/gist_id}","starred_url":"https://api.github.com/users/excaliburjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/excaliburjs/subscriptions","organizations_url":"https://api.github.com/users/excaliburjs/orgs","repos_url":"https://api.github.com/users/excaliburjs/repos","events_url":"https://api.github.com/users/excaliburjs/events{/privacy}","received_events_url":"https://api.github.com/users/excaliburjs/received_events","type":"Organization","site_admin":false},"repo":{"id":144221943,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQyMjE5NDM=","name":"sample-shootemup","full_name":"excaliburjs/sample-shootemup","private":false,"owner":{"login":"excaliburjs","id":6165683,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNjU2ODM=","avatar_url":"https://avatars3.githubusercontent.com/u/6165683?v=4","gravatar_id":"","url":"https://api.github.com/users/excaliburjs","html_url":"https://github.com/excaliburjs","followers_url":"https://api.github.com/users/excaliburjs/followers","following_url":"https://api.github.com/users/excaliburjs/following{/other_user}","gists_url":"https://api.github.com/users/excaliburjs/gists{/gist_id}","starred_url":"https://api.github.com/users/excaliburjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/excaliburjs/subscriptions","organizations_url":"https://api.github.com/users/excaliburjs/orgs","repos_url":"https://api.github.com/users/excaliburjs/repos","events_url":"https://api.github.com/users/excaliburjs/events{/privacy}","received_events_url":"https://api.github.com/users/excaliburjs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/excaliburjs/sample-shootemup","description":"Example Shoot-em Up Style Game Built with Excalibur","fork":true,"url":"https://api.github.com/repos/excaliburjs/sample-shootemup","forks_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/forks","keys_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/keys{/key_id}","collaborators_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/teams","hooks_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/hooks","issue_events_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/issues/events{/number}","events_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/events","assignees_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/assignees{/user}","branches_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/branches{/branch}","tags_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/tags","blobs_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/git/refs{/sha}","trees_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/git/trees{/sha}","statuses_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/statuses/{sha}","languages_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/languages","stargazers_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/stargazers","contributors_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/contributors","subscribers_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/subscribers","subscription_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/subscription","commits_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/commits{/sha}","git_commits_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/git/commits{/sha}","comments_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/comments{/number}","issue_comment_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/issues/comments{/number}","contents_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/contents/{+path}","compare_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/compare/{base}...{head}","merges_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/merges","archive_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/downloads","issues_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/issues{/number}","pulls_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/pulls{/number}","milestones_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/milestones{/number}","notifications_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/labels{/name}","releases_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/releases{/id}","deployments_url":"https://api.github.com/repos/excaliburjs/sample-shootemup/deployments","created_at":"2018-08-10T01:36:36Z","updated_at":"2018-08-10T01:45:51Z","pushed_at":"2018-10-23T02:54:29Z","git_url":"git://github.com/excaliburjs/sample-shootemup.git","ssh_url":"git@github.com:excaliburjs/sample-shootemup.git","clone_url":"https://github.com/excaliburjs/sample-shootemup.git","svn_url":"https://github.com/excaliburjs/sample-shootemup","homepage":"https://excaliburjs.com/sample-shootemup","size":10167,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/excaliburjs/sample-shootemup/pulls/1"},"html":{"href":"https://github.com/excaliburjs/sample-shootemup/pull/1"},"issue":{"href":"https://api.github.com/repos/excaliburjs/sample-shootemup/issues/1"},"comments":{"href":"https://api.github.com/repos/excaliburjs/sample-shootemup/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/excaliburjs/sample-shootemup/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/excaliburjs/sample-shootemup/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/excaliburjs/sample-shootemup/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/excaliburjs/sample-shootemup/statuses/c418b6fcf6b5189dae27155cf895c338357c43d2"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"code0wl"}}