{"action":"created","comment":{"url":"https://api.github.com/repos/OCA/operating-unit/pulls/comments/225449690","pull_request_review_id":165047902,"id":225449690,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTQ0OTY5MA==","diff_hunk":"@@ -0,0 +1,146 @@\n+# © 2016-17 Eficent Business and IT Consulting Services S.L.\n+# © 2016 Serpent Consulting Services Pvt. Ltd.\n+# License LGPL-3.0 or later (https://www.gnu.org/licenses/lgpl.html).\n+\n+from odoo import api, fields, models, _\n+from odoo.exceptions import UserError\n+\n+\n+class AccountMoveLine(models.Model):\n+    _inherit = \"account.move.line\"\n+\n+    operating_unit_id = fields.Many2one('operating.unit', 'Operating Unit',\n+                                        default=lambda self:\n+                                        self.env['res.users'].\n+                                        operating_unit_default_get(self._uid))","path":"account_operating_unit/models/account_move.py","position":15,"original_position":15,"commit_id":"7e0f3b4ccaae323c0c3afe5443bdebb22e2ae2bd","original_commit_id":"7e0f3b4ccaae323c0c3afe5443bdebb22e2ae2bd","user":{"login":"aheficent","id":19620251,"node_id":"MDQ6VXNlcjE5NjIwMjUx","avatar_url":"https://avatars1.githubusercontent.com/u/19620251?v=4","gravatar_id":"","url":"https://api.github.com/users/aheficent","html_url":"https://github.com/aheficent","followers_url":"https://api.github.com/users/aheficent/followers","following_url":"https://api.github.com/users/aheficent/following{/other_user}","gists_url":"https://api.github.com/users/aheficent/gists{/gist_id}","starred_url":"https://api.github.com/users/aheficent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aheficent/subscriptions","organizations_url":"https://api.github.com/users/aheficent/orgs","repos_url":"https://api.github.com/users/aheficent/repos","events_url":"https://api.github.com/users/aheficent/events{/privacy}","received_events_url":"https://api.github.com/users/aheficent/received_events","type":"User","site_admin":false},"body":"Correct. The default value in the journal items should be the one in the journal entry for manual journal entries. It is a bug.","created_at":"2018-10-16T08:48:00Z","updated_at":"2018-10-16T08:48:01Z","html_url":"https://github.com/OCA/operating-unit/pull/140#discussion_r225449690","pull_request_url":"https://api.github.com/repos/OCA/operating-unit/pulls/140","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/OCA/operating-unit/pulls/comments/225449690"},"html":{"href":"https://github.com/OCA/operating-unit/pull/140#discussion_r225449690"},"pull_request":{"href":"https://api.github.com/repos/OCA/operating-unit/pulls/140"}},"in_reply_to_id":224494451},"pull_request":{"url":"https://api.github.com/repos/OCA/operating-unit/pulls/140","id":220034690,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwMDM0Njkw","html_url":"https://github.com/OCA/operating-unit/pull/140","diff_url":"https://github.com/OCA/operating-unit/pull/140.diff","patch_url":"https://github.com/OCA/operating-unit/pull/140.patch","issue_url":"https://api.github.com/repos/OCA/operating-unit/issues/140","number":140,"state":"open","locked":false,"title":"[11.0][MIG] account_operating_unit : Migration to v11.0","user":{"login":"grindtildeath","id":778828,"node_id":"MDQ6VXNlcjc3ODgyOA==","avatar_url":"https://avatars3.githubusercontent.com/u/778828?v=4","gravatar_id":"","url":"https://api.github.com/users/grindtildeath","html_url":"https://github.com/grindtildeath","followers_url":"https://api.github.com/users/grindtildeath/followers","following_url":"https://api.github.com/users/grindtildeath/following{/other_user}","gists_url":"https://api.github.com/users/grindtildeath/gists{/gist_id}","starred_url":"https://api.github.com/users/grindtildeath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grindtildeath/subscriptions","organizations_url":"https://api.github.com/users/grindtildeath/orgs","repos_url":"https://api.github.com/users/grindtildeath/repos","events_url":"https://api.github.com/users/grindtildeath/events{/privacy}","received_events_url":"https://api.github.com/users/grindtildeath/received_events","type":"User","site_admin":false},"body":"Supersedes : #114 and #137 \r\n\r\n - I did remove the first commits on #114 (adding both account_operating_unit and analytic_operating unit) which are reverted further in the PR, to keep a clean commit history.\r\n - I did extract the change explained by @richard-willdooit in a separated commit and did copy his comment from https://github.com/OCA/operating-unit/commit/fd2fc49de45f64774bf14f7cb7df026d5006f24a to have a better explanation of the change on the commit itself, so it can be backported if needed.\r\n - I finally did the changes asked by @nikul-serpentcs on #114 in a separated commit.\r\n\r\n@michael-villamar @meigallodixital Since it seems both of you did the job, I hope this is ok for you, and thank you BTW.\r\n","created_at":"2018-10-03T13:21:39Z","updated_at":"2018-10-16T08:48:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"319540ad18b42e1b4f3b7e13019d939ad6b5e7ef","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/OCA/operating-unit/pulls/140/commits","review_comments_url":"https://api.github.com/repos/OCA/operating-unit/pulls/140/comments","review_comment_url":"https://api.github.com/repos/OCA/operating-unit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/OCA/operating-unit/issues/140/comments","statuses_url":"https://api.github.com/repos/OCA/operating-unit/statuses/7e0f3b4ccaae323c0c3afe5443bdebb22e2ae2bd","head":{"label":"grindtildeath:11.0-mig-account_operating_unit","ref":"11.0-mig-account_operating_unit","sha":"7e0f3b4ccaae323c0c3afe5443bdebb22e2ae2bd","user":{"login":"grindtildeath","id":778828,"node_id":"MDQ6VXNlcjc3ODgyOA==","avatar_url":"https://avatars3.githubusercontent.com/u/778828?v=4","gravatar_id":"","url":"https://api.github.com/users/grindtildeath","html_url":"https://github.com/grindtildeath","followers_url":"https://api.github.com/users/grindtildeath/followers","following_url":"https://api.github.com/users/grindtildeath/following{/other_user}","gists_url":"https://api.github.com/users/grindtildeath/gists{/gist_id}","starred_url":"https://api.github.com/users/grindtildeath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grindtildeath/subscriptions","organizations_url":"https://api.github.com/users/grindtildeath/orgs","repos_url":"https://api.github.com/users/grindtildeath/repos","events_url":"https://api.github.com/users/grindtildeath/events{/privacy}","received_events_url":"https://api.github.com/users/grindtildeath/received_events","type":"User","site_admin":false},"repo":{"id":151414245,"node_id":"MDEwOlJlcG9zaXRvcnkxNTE0MTQyNDU=","name":"operating-unit","full_name":"grindtildeath/operating-unit","private":false,"owner":{"login":"grindtildeath","id":778828,"node_id":"MDQ6VXNlcjc3ODgyOA==","avatar_url":"https://avatars3.githubusercontent.com/u/778828?v=4","gravatar_id":"","url":"https://api.github.com/users/grindtildeath","html_url":"https://github.com/grindtildeath","followers_url":"https://api.github.com/users/grindtildeath/followers","following_url":"https://api.github.com/users/grindtildeath/following{/other_user}","gists_url":"https://api.github.com/users/grindtildeath/gists{/gist_id}","starred_url":"https://api.github.com/users/grindtildeath/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grindtildeath/subscriptions","organizations_url":"https://api.github.com/users/grindtildeath/orgs","repos_url":"https://api.github.com/users/grindtildeath/repos","events_url":"https://api.github.com/users/grindtildeath/events{/privacy}","received_events_url":"https://api.github.com/users/grindtildeath/received_events","type":"User","site_admin":false},"html_url":"https://github.com/grindtildeath/operating-unit","description":"Manage Operating Units in Odoo","fork":true,"url":"https://api.github.com/repos/grindtildeath/operating-unit","forks_url":"https://api.github.com/repos/grindtildeath/operating-unit/forks","keys_url":"https://api.github.com/repos/grindtildeath/operating-unit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/grindtildeath/operating-unit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/grindtildeath/operating-unit/teams","hooks_url":"https://api.github.com/repos/grindtildeath/operating-unit/hooks","issue_events_url":"https://api.github.com/repos/grindtildeath/operating-unit/issues/events{/number}","events_url":"https://api.github.com/repos/grindtildeath/operating-unit/events","assignees_url":"https://api.github.com/repos/grindtildeath/operating-unit/assignees{/user}","branches_url":"https://api.github.com/repos/grindtildeath/operating-unit/branches{/branch}","tags_url":"https://api.github.com/repos/grindtildeath/operating-unit/tags","blobs_url":"https://api.github.com/repos/grindtildeath/operating-unit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/grindtildeath/operating-unit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/grindtildeath/operating-unit/git/refs{/sha}","trees_url":"https://api.github.com/repos/grindtildeath/operating-unit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/grindtildeath/operating-unit/statuses/{sha}","languages_url":"https://api.github.com/repos/grindtildeath/operating-unit/languages","stargazers_url":"https://api.github.com/repos/grindtildeath/operating-unit/stargazers","contributors_url":"https://api.github.com/repos/grindtildeath/operating-unit/contributors","subscribers_url":"https://api.github.com/repos/grindtildeath/operating-unit/subscribers","subscription_url":"https://api.github.com/repos/grindtildeath/operating-unit/subscription","commits_url":"https://api.github.com/repos/grindtildeath/operating-unit/commits{/sha}","git_commits_url":"https://api.github.com/repos/grindtildeath/operating-unit/git/commits{/sha}","comments_url":"https://api.github.com/repos/grindtildeath/operating-unit/comments{/number}","issue_comment_url":"https://api.github.com/repos/grindtildeath/operating-unit/issues/comments{/number}","contents_url":"https://api.github.com/repos/grindtildeath/operating-unit/contents/{+path}","compare_url":"https://api.github.com/repos/grindtildeath/operating-unit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/grindtildeath/operating-unit/merges","archive_url":"https://api.github.com/repos/grindtildeath/operating-unit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/grindtildeath/operating-unit/downloads","issues_url":"https://api.github.com/repos/grindtildeath/operating-unit/issues{/number}","pulls_url":"https://api.github.com/repos/grindtildeath/operating-unit/pulls{/number}","milestones_url":"https://api.github.com/repos/grindtildeath/operating-unit/milestones{/number}","notifications_url":"https://api.github.com/repos/grindtildeath/operating-unit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/grindtildeath/operating-unit/labels{/name}","releases_url":"https://api.github.com/repos/grindtildeath/operating-unit/releases{/id}","deployments_url":"https://api.github.com/repos/grindtildeath/operating-unit/deployments","created_at":"2018-10-03T13:08:34Z","updated_at":"2018-10-03T13:08:36Z","pushed_at":"2018-10-09T10:23:20Z","git_url":"git://github.com/grindtildeath/operating-unit.git","ssh_url":"git@github.com:grindtildeath/operating-unit.git","clone_url":"https://github.com/grindtildeath/operating-unit.git","svn_url":"https://github.com/grindtildeath/operating-unit","homepage":null,"size":544,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"11.0"}},"base":{"label":"OCA:11.0","ref":"11.0","sha":"13ab9ae4939caad7a822f9b2deb58c756ae41159","user":{"login":"OCA","id":7600578,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MDA1Nzg=","avatar_url":"https://avatars1.githubusercontent.com/u/7600578?v=4","gravatar_id":"","url":"https://api.github.com/users/OCA","html_url":"https://github.com/OCA","followers_url":"https://api.github.com/users/OCA/followers","following_url":"https://api.github.com/users/OCA/following{/other_user}","gists_url":"https://api.github.com/users/OCA/gists{/gist_id}","starred_url":"https://api.github.com/users/OCA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OCA/subscriptions","organizations_url":"https://api.github.com/users/OCA/orgs","repos_url":"https://api.github.com/users/OCA/repos","events_url":"https://api.github.com/users/OCA/events{/privacy}","received_events_url":"https://api.github.com/users/OCA/received_events","type":"Organization","site_admin":false},"repo":{"id":47409892,"node_id":"MDEwOlJlcG9zaXRvcnk0NzQwOTg5Mg==","name":"operating-unit","full_name":"OCA/operating-unit","private":false,"owner":{"login":"OCA","id":7600578,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MDA1Nzg=","avatar_url":"https://avatars1.githubusercontent.com/u/7600578?v=4","gravatar_id":"","url":"https://api.github.com/users/OCA","html_url":"https://github.com/OCA","followers_url":"https://api.github.com/users/OCA/followers","following_url":"https://api.github.com/users/OCA/following{/other_user}","gists_url":"https://api.github.com/users/OCA/gists{/gist_id}","starred_url":"https://api.github.com/users/OCA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/OCA/subscriptions","organizations_url":"https://api.github.com/users/OCA/orgs","repos_url":"https://api.github.com/users/OCA/repos","events_url":"https://api.github.com/users/OCA/events{/privacy}","received_events_url":"https://api.github.com/users/OCA/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/OCA/operating-unit","description":"Manage Operating Units in Odoo","fork":false,"url":"https://api.github.com/repos/OCA/operating-unit","forks_url":"https://api.github.com/repos/OCA/operating-unit/forks","keys_url":"https://api.github.com/repos/OCA/operating-unit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/OCA/operating-unit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/OCA/operating-unit/teams","hooks_url":"https://api.github.com/repos/OCA/operating-unit/hooks","issue_events_url":"https://api.github.com/repos/OCA/operating-unit/issues/events{/number}","events_url":"https://api.github.com/repos/OCA/operating-unit/events","assignees_url":"https://api.github.com/repos/OCA/operating-unit/assignees{/user}","branches_url":"https://api.github.com/repos/OCA/operating-unit/branches{/branch}","tags_url":"https://api.github.com/repos/OCA/operating-unit/tags","blobs_url":"https://api.github.com/repos/OCA/operating-unit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/OCA/operating-unit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/OCA/operating-unit/git/refs{/sha}","trees_url":"https://api.github.com/repos/OCA/operating-unit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/OCA/operating-unit/statuses/{sha}","languages_url":"https://api.github.com/repos/OCA/operating-unit/languages","stargazers_url":"https://api.github.com/repos/OCA/operating-unit/stargazers","contributors_url":"https://api.github.com/repos/OCA/operating-unit/contributors","subscribers_url":"https://api.github.com/repos/OCA/operating-unit/subscribers","subscription_url":"https://api.github.com/repos/OCA/operating-unit/subscription","commits_url":"https://api.github.com/repos/OCA/operating-unit/commits{/sha}","git_commits_url":"https://api.github.com/repos/OCA/operating-unit/git/commits{/sha}","comments_url":"https://api.github.com/repos/OCA/operating-unit/comments{/number}","issue_comment_url":"https://api.github.com/repos/OCA/operating-unit/issues/comments{/number}","contents_url":"https://api.github.com/repos/OCA/operating-unit/contents/{+path}","compare_url":"https://api.github.com/repos/OCA/operating-unit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/OCA/operating-unit/merges","archive_url":"https://api.github.com/repos/OCA/operating-unit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/OCA/operating-unit/downloads","issues_url":"https://api.github.com/repos/OCA/operating-unit/issues{/number}","pulls_url":"https://api.github.com/repos/OCA/operating-unit/pulls{/number}","milestones_url":"https://api.github.com/repos/OCA/operating-unit/milestones{/number}","notifications_url":"https://api.github.com/repos/OCA/operating-unit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/OCA/operating-unit/labels{/name}","releases_url":"https://api.github.com/repos/OCA/operating-unit/releases{/id}","deployments_url":"https://api.github.com/repos/OCA/operating-unit/deployments","created_at":"2015-12-04T14:51:11Z","updated_at":"2018-09-27T00:22:48Z","pushed_at":"2018-10-09T10:23:21Z","git_url":"git://github.com/OCA/operating-unit.git","ssh_url":"git@github.com:OCA/operating-unit.git","clone_url":"https://github.com/OCA/operating-unit.git","svn_url":"https://github.com/OCA/operating-unit","homepage":null,"size":523,"stargazers_count":9,"watchers_count":9,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":68,"mirror_url":null,"archived":false,"open_issues_count":42,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":68,"open_issues":42,"watchers":9,"default_branch":"11.0"}},"_links":{"self":{"href":"https://api.github.com/repos/OCA/operating-unit/pulls/140"},"html":{"href":"https://github.com/OCA/operating-unit/pull/140"},"issue":{"href":"https://api.github.com/repos/OCA/operating-unit/issues/140"},"comments":{"href":"https://api.github.com/repos/OCA/operating-unit/issues/140/comments"},"review_comments":{"href":"https://api.github.com/repos/OCA/operating-unit/pulls/140/comments"},"review_comment":{"href":"https://api.github.com/repos/OCA/operating-unit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/OCA/operating-unit/pulls/140/commits"},"statuses":{"href":"https://api.github.com/repos/OCA/operating-unit/statuses/7e0f3b4ccaae323c0c3afe5443bdebb22e2ae2bd"}},"author_association":"NONE"}}
{"actor":{"display_login":"aheficent"}}