{"action":"created","issue":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/8838","repository_url":"https://api.github.com/repos/RIOT-OS/RIOT","labels_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/8838/labels{/name}","comments_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/8838/comments","events_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/8838/events","html_url":"https://github.com/RIOT-OS/RIOT/pull/8838","id":308966540,"number":8838,"title":"Makefiles: add support to generate both `.hex` and `.bin` file and add FLASHFILE variable","user":{"login":"cladmi","id":241401,"avatar_url":"https://avatars3.githubusercontent.com/u/241401?v=4","gravatar_id":"","url":"https://api.github.com/users/cladmi","html_url":"https://github.com/cladmi","followers_url":"https://api.github.com/users/cladmi/followers","following_url":"https://api.github.com/users/cladmi/following{/other_user}","gists_url":"https://api.github.com/users/cladmi/gists{/gist_id}","starred_url":"https://api.github.com/users/cladmi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cladmi/subscriptions","organizations_url":"https://api.github.com/users/cladmi/orgs","repos_url":"https://api.github.com/users/cladmi/repos","events_url":"https://api.github.com/users/cladmi/events{/privacy}","received_events_url":"https://api.github.com/users/cladmi/received_events","type":"User","site_admin":false},"labels":[{"id":872251341,"url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/CI:%20run%20tests","name":"CI: run tests","color":"8cd633","default":false},{"id":214816571,"url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/Ready%20for%20CI%20build","name":"Ready for CI build","color":"bfdadc","default":false},{"id":122032371,"url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/cleanup","name":"cleanup","color":"FF7c7c","default":false},{"id":97338598,"url":"https://api.github.com/repos/RIOT-OS/RIOT/labels/make","name":"make","color":"fad8c7","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":14,"created_at":"2018-03-27T13:22:25Z","updated_at":"2018-05-07T14:05:55Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/pulls/8838","html_url":"https://github.com/RIOT-OS/RIOT/pull/8838","diff_url":"https://github.com/RIOT-OS/RIOT/pull/8838.diff","patch_url":"https://github.com/RIOT-OS/RIOT/pull/8838.patch"},"body":"### Contribution description\r\n\r\nI need to be able to generate a `.bin` file to flash nucleo boards by drag-and-dropping the firmware.\r\nThe main goal of this PR main is to add a target for the bin file. This would allow asking for building the bin file from the command line but not creating it for every build.\r\n\r\n* Remove the `HEXFILE = $(ELFFILE:.elf=.bin)` hack\r\n* Add a `FLASHFILE` variable which fixes the hack in https://github.com/RIOT-OS/RIOT/pull/8801\r\n* Change flasher script that where getting the flashfile from environment variable.\r\n\r\n#### Integrated in sub PRs:\r\n\r\nWhile looking into this I tried fixing other problems to not propagate hack somewhere else:\r\n* [x] Put `ELFFILE` in its own target and generally break link in sub file targets\r\n    * ~~https://github.com/RIOT-OS/RIOT/pull/8844~~ separate target\r\n    * ~~https://github.com/RIOT-OS/RIOT/pull/8845~~ .hex and .bin targets\r\n* [x] Fix boards generating a binary `.hex` file  ~~https://github.com/RIOT-OS/RIOT/pull/8840~~\r\n* [x] Random refactoring ~~https://github.com/RIOT-OS/RIOT/pull/8839~~\r\n\r\n\r\nIt has the side effect to not generate the '.hex' or '.bin' file if not required for the flasher, which I think is better\r\n\r\nThis ended up in a big PR that I will split.\r\n\r\n\r\n#### Verifying after rebase:\r\n\r\nThings I should look into after rebasing the PR in case new boards where added:\r\n\r\n    git grep FFLAGS | grep -v FLASHFILE\r\n    git grep OFLAGS |  grep -e '-O'\r\n    git grep HEXFILE | grep -v FLASHFILE\r\n\r\n### Issues/PRs references\r\n\r\n* Its re-introducing https://github.com/RIOT-OS/RIOT/pull/1098 (reverted by https://github.com/RIOT-OS/RIOT/pull/1198)\r\n* Will remove the hack for https://github.com/RIOT-OS/RIOT/pull/8801/files\r\n* ~~It will need rebase after https://github.com/RIOT-OS/RIOT/pull/8822 is merged~~"},"comment":{"url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/comments/387075631","html_url":"https://github.com/RIOT-OS/RIOT/pull/8838#issuecomment-387075631","issue_url":"https://api.github.com/repos/RIOT-OS/RIOT/issues/8838","id":387075631,"user":{"login":"kaspar030","id":4679640,"avatar_url":"https://avatars0.githubusercontent.com/u/4679640?v=4","gravatar_id":"","url":"https://api.github.com/users/kaspar030","html_url":"https://github.com/kaspar030","followers_url":"https://api.github.com/users/kaspar030/followers","following_url":"https://api.github.com/users/kaspar030/following{/other_user}","gists_url":"https://api.github.com/users/kaspar030/gists{/gist_id}","starred_url":"https://api.github.com/users/kaspar030/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kaspar030/subscriptions","organizations_url":"https://api.github.com/users/kaspar030/orgs","repos_url":"https://api.github.com/users/kaspar030/repos","events_url":"https://api.github.com/users/kaspar030/events{/privacy}","received_events_url":"https://api.github.com/users/kaspar030/received_events","type":"User","site_admin":false},"created_at":"2018-05-07T14:05:55Z","updated_at":"2018-05-07T14:05:55Z","author_association":"CONTRIBUTOR","body":"only seeeduino_arch-pro left?\r\nI'd say, please squash!"}}
{"actor":{"display_login":"kaspar030"}}