{"action":"created","issue":{"url":"https://api.github.com/repos/pauldendulk/Mapsui/issues/373","repository_url":"https://api.github.com/repos/pauldendulk/Mapsui","labels_url":"https://api.github.com/repos/pauldendulk/Mapsui/issues/373/labels{/name}","comments_url":"https://api.github.com/repos/pauldendulk/Mapsui/issues/373/comments","events_url":"https://api.github.com/repos/pauldendulk/Mapsui/issues/373/events","html_url":"https://github.com/pauldendulk/Mapsui/issues/373","id":313197774,"number":373,"title":"IThemeStyle.GetStyle(IFeature) doesn't provide zoom level","user":{"login":"charlenni","id":4381223,"avatar_url":"https://avatars2.githubusercontent.com/u/4381223?v=4","gravatar_id":"","url":"https://api.github.com/users/charlenni","html_url":"https://github.com/charlenni","followers_url":"https://api.github.com/users/charlenni/followers","following_url":"https://api.github.com/users/charlenni/following{/other_user}","gists_url":"https://api.github.com/users/charlenni/gists{/gist_id}","starred_url":"https://api.github.com/users/charlenni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlenni/subscriptions","organizations_url":"https://api.github.com/users/charlenni/orgs","repos_url":"https://api.github.com/users/charlenni/repos","events_url":"https://api.github.com/users/charlenni/events{/privacy}","received_events_url":"https://api.github.com/users/charlenni/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-04-11T07:06:08Z","updated_at":"2018-04-11T18:55:08Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"IThemeStyle.GetStyle(IFeature) doesn't provide zoom level. But this is obligatory for modern theme styling."},"comment":{"url":"https://api.github.com/repos/pauldendulk/Mapsui/issues/comments/380559150","html_url":"https://github.com/pauldendulk/Mapsui/issues/373#issuecomment-380559150","issue_url":"https://api.github.com/repos/pauldendulk/Mapsui/issues/373","id":380559150,"user":{"login":"charlenni","id":4381223,"avatar_url":"https://avatars2.githubusercontent.com/u/4381223?v=4","gravatar_id":"","url":"https://api.github.com/users/charlenni","html_url":"https://github.com/charlenni","followers_url":"https://api.github.com/users/charlenni/followers","following_url":"https://api.github.com/users/charlenni/following{/other_user}","gists_url":"https://api.github.com/users/charlenni/gists{/gist_id}","starred_url":"https://api.github.com/users/charlenni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charlenni/subscriptions","organizations_url":"https://api.github.com/users/charlenni/orgs","repos_url":"https://api.github.com/users/charlenni/repos","events_url":"https://api.github.com/users/charlenni/events{/privacy}","received_events_url":"https://api.github.com/users/charlenni/received_events","type":"User","site_admin":false},"created_at":"2018-04-11T18:55:08Z","updated_at":"2018-04-11T18:55:08Z","author_association":"CONTRIBUTOR","body":"StyleCollection is usefull for POIs. They have a SymbolStyle and a LabelStyle. So I need a StyleCollection or something else. I'm fine with StyleCollection. It could be implemented without any API changes, because it is only a render thing.\r\n\r\nTo set style on layer isn't possible, because style depends on tags of each feature and zoom level/resolution. So I should create the style each time the feature is rendered.\r\n\r\nRegarding resolution and zoom level: You suggest, that we should use all over the library resolution instead of zoom level. Would be possible, but we have to look into HttpTileSource and MbTilesTileSource, which uses zoom level and theme files should be parsed while loading to replace all occurences of zoom levels.\r\n\r\nYes, I implemented GetStyle this way as you suggested, but only in my test environment. If you like, I could try to make a PR in the next days."}}
{"actor":{"display_login":"charlenni"}}