{"action":"created","comment":{"url":"https://api.github.com/repos/apple/swift/pulls/comments/194908419","pull_request_review_id":128172549,"id":194908419,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDkwODQxOQ==","diff_hunk":"@@ -65,8 +65,8 @@ public func testScalar(f: Float) { // expected-warning {{'f' implicitly copied t\n // CHECK-NEXT:   %3 = integer_literal $Builtin.Int32, 1\n // CHECK:        [[CONST:%.*]] = builtin \"__tfop_Const,dtype$dtype,value$tensor,device\"(%3 : $Builtin.Int32, %2 : $Builtin.FPIEEE32, {{.*}}) : $TensorHandle<Builtin.FPIEEE32>\n // CHECK-NEXT:   [[CAST:%.*]] = unchecked_ref_cast [[CONST]] : $TensorHandle<Builtin.FPIEEE32> to $TensorHandle<Float>\n-// CHECK:        [[ADD1:%.*]] = builtin \"__tfop_Add,$in,$in,device\"(%1 : $TensorHandle<Float>, [[CAST]] : $TensorHandle<Float>, {{.*}}) : $TensorHandle<Float>\n-// CHECK:        [[ADD2:%.*]] = builtin \"__tfop_Add,$in,$in,device\"([[ADD1]] : $TensorHandle<Float>, [[ADD1:%.*]] : $TensorHandle<Float>, {{.*}}) : $TensorHandle<Float>\n+// CHECK:        [[ADD1:%.*]] = builtin \"__tfop_Add,$in,$in,T,device\"(%1 : $TensorHandle<Float>, [[CAST]] : $TensorHandle<Float>, {{.*}}) : $TensorHandle<Float>","path":"test/TensorFlow/integration.swift","position":42,"original_position":42,"commit_id":"e489c9b9006d57437d9c132f4b8cd5ec683cd9b2","original_commit_id":"a3dc27cd46ecda4b2cd75857800135bfe11349da","user":{"login":"LaurentMazare","id":1041292,"node_id":"MDQ6VXNlcjEwNDEyOTI=","avatar_url":"https://avatars0.githubusercontent.com/u/1041292?v=4","gravatar_id":"","url":"https://api.github.com/users/LaurentMazare","html_url":"https://github.com/LaurentMazare","followers_url":"https://api.github.com/users/LaurentMazare/followers","following_url":"https://api.github.com/users/LaurentMazare/following{/other_user}","gists_url":"https://api.github.com/users/LaurentMazare/gists{/gist_id}","starred_url":"https://api.github.com/users/LaurentMazare/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LaurentMazare/subscriptions","organizations_url":"https://api.github.com/users/LaurentMazare/orgs","repos_url":"https://api.github.com/users/LaurentMazare/repos","events_url":"https://api.github.com/users/LaurentMazare/events{/privacy}","received_events_url":"https://api.github.com/users/LaurentMazare/received_events","type":"User","site_admin":false},"body":"@mhong, that's a good point, in the generated wrappers, we always specify this \"T\" attr explicitly as I don't think there is an easy way to tell from the [ops descriptions](https://github.com/tensorflow/tensorflow/blob/master/tensorflow/core/ops/ops.pbtxt) whether it could be inferred or not.\r\nWe could have some heuristics about removing all the \"T\" attributes, not sure how robust this would be though.","created_at":"2018-06-12T22:30:39Z","updated_at":"2018-06-12T22:30:39Z","html_url":"https://github.com/apple/swift/pull/17135#discussion_r194908419","pull_request_url":"https://api.github.com/repos/apple/swift/pulls/17135","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/comments/194908419"},"html":{"href":"https://github.com/apple/swift/pull/17135#discussion_r194908419"},"pull_request":{"href":"https://api.github.com/repos/apple/swift/pulls/17135"}},"in_reply_to_id":194786883},"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/17135","id":194172102,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0MTcyMTAy","html_url":"https://github.com/apple/swift/pull/17135","diff_url":"https://github.com/apple/swift/pull/17135.diff","patch_url":"https://github.com/apple/swift/pull/17135.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/17135","number":17135,"state":"closed","locked":false,"title":"fix Piper test failures","user":{"login":"marcrasi","id":5945760,"node_id":"MDQ6VXNlcjU5NDU3NjA=","avatar_url":"https://avatars0.githubusercontent.com/u/5945760?v=4","gravatar_id":"","url":"https://api.github.com/users/marcrasi","html_url":"https://github.com/marcrasi","followers_url":"https://api.github.com/users/marcrasi/followers","following_url":"https://api.github.com/users/marcrasi/following{/other_user}","gists_url":"https://api.github.com/users/marcrasi/gists{/gist_id}","starred_url":"https://api.github.com/users/marcrasi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcrasi/subscriptions","organizations_url":"https://api.github.com/users/marcrasi/orgs","repos_url":"https://api.github.com/users/marcrasi/repos","events_url":"https://api.github.com/users/marcrasi/events{/privacy}","received_events_url":"https://api.github.com/users/marcrasi/received_events","type":"User","site_admin":false},"body":"I encountered some test failures while exporting to Piper.\r\n\r\n1. A change to `Ops.swift` accidentally removed the `Tensor<Float>()`. This breaks GPU tests, which we do not run in our external builds yet.\r\n2. The SIL in `test/TensorFlow/integration.swift` changed a bit. We did not notice because `test/TensorFlow/integration.swift` does not run in our external builds.\r\n3. `test/TensorFlow/deabstraction_finished.swift` fails on Piper, because Piper builds `stdlib/public/TensorFlow` with optimizations turned off, and constexpr folding can't deal with all the non-optimized stuff yet.\r\n\r\nI fixed 1 & 2 and ignored 3 (since @lattner's changes will probably repair that soon).\r\n\r\nI also turned off optimizations in `stdlib/public/TensorFlow`, and enabled a few new tests in external, so that differences between external and piper and less likely to bite us in the future.","created_at":"2018-06-12T05:48:57Z","updated_at":"2018-06-12T22:30:39Z","closed_at":"2018-06-12T19:32:33Z","merged_at":"2018-06-12T19:32:33Z","merge_commit_sha":"2a28089be5edab4e50b683a6526734422a9068ee","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":955546636,"node_id":"MDU6TGFiZWw5NTU1NDY2MzY=","url":"https://api.github.com/repos/apple/swift/labels/tensorflow","name":"tensorflow","color":"EF6C00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/17135/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/17135/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/17135/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/e489c9b9006d57437d9c132f4b8cd5ec683cd9b2","head":{"label":"marcrasi:fix-integration-swift-test","ref":"fix-integration-swift-test","sha":"e489c9b9006d57437d9c132f4b8cd5ec683cd9b2","user":{"login":"marcrasi","id":5945760,"node_id":"MDQ6VXNlcjU5NDU3NjA=","avatar_url":"https://avatars0.githubusercontent.com/u/5945760?v=4","gravatar_id":"","url":"https://api.github.com/users/marcrasi","html_url":"https://github.com/marcrasi","followers_url":"https://api.github.com/users/marcrasi/followers","following_url":"https://api.github.com/users/marcrasi/following{/other_user}","gists_url":"https://api.github.com/users/marcrasi/gists{/gist_id}","starred_url":"https://api.github.com/users/marcrasi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcrasi/subscriptions","organizations_url":"https://api.github.com/users/marcrasi/orgs","repos_url":"https://api.github.com/users/marcrasi/repos","events_url":"https://api.github.com/users/marcrasi/events{/privacy}","received_events_url":"https://api.github.com/users/marcrasi/received_events","type":"User","site_admin":false},"repo":{"id":135738994,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU3Mzg5OTQ=","name":"swift","full_name":"marcrasi/swift","owner":{"login":"marcrasi","id":5945760,"node_id":"MDQ6VXNlcjU5NDU3NjA=","avatar_url":"https://avatars0.githubusercontent.com/u/5945760?v=4","gravatar_id":"","url":"https://api.github.com/users/marcrasi","html_url":"https://github.com/marcrasi","followers_url":"https://api.github.com/users/marcrasi/followers","following_url":"https://api.github.com/users/marcrasi/following{/other_user}","gists_url":"https://api.github.com/users/marcrasi/gists{/gist_id}","starred_url":"https://api.github.com/users/marcrasi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcrasi/subscriptions","organizations_url":"https://api.github.com/users/marcrasi/orgs","repos_url":"https://api.github.com/users/marcrasi/repos","events_url":"https://api.github.com/users/marcrasi/events{/privacy}","received_events_url":"https://api.github.com/users/marcrasi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/marcrasi/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/marcrasi/swift","forks_url":"https://api.github.com/repos/marcrasi/swift/forks","keys_url":"https://api.github.com/repos/marcrasi/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/marcrasi/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/marcrasi/swift/teams","hooks_url":"https://api.github.com/repos/marcrasi/swift/hooks","issue_events_url":"https://api.github.com/repos/marcrasi/swift/issues/events{/number}","events_url":"https://api.github.com/repos/marcrasi/swift/events","assignees_url":"https://api.github.com/repos/marcrasi/swift/assignees{/user}","branches_url":"https://api.github.com/repos/marcrasi/swift/branches{/branch}","tags_url":"https://api.github.com/repos/marcrasi/swift/tags","blobs_url":"https://api.github.com/repos/marcrasi/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/marcrasi/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/marcrasi/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/marcrasi/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/marcrasi/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/marcrasi/swift/languages","stargazers_url":"https://api.github.com/repos/marcrasi/swift/stargazers","contributors_url":"https://api.github.com/repos/marcrasi/swift/contributors","subscribers_url":"https://api.github.com/repos/marcrasi/swift/subscribers","subscription_url":"https://api.github.com/repos/marcrasi/swift/subscription","commits_url":"https://api.github.com/repos/marcrasi/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/marcrasi/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/marcrasi/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/marcrasi/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/marcrasi/swift/contents/{+path}","compare_url":"https://api.github.com/repos/marcrasi/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/marcrasi/swift/merges","archive_url":"https://api.github.com/repos/marcrasi/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/marcrasi/swift/downloads","issues_url":"https://api.github.com/repos/marcrasi/swift/issues{/number}","pulls_url":"https://api.github.com/repos/marcrasi/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/marcrasi/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/marcrasi/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/marcrasi/swift/labels{/name}","releases_url":"https://api.github.com/repos/marcrasi/swift/releases{/id}","deployments_url":"https://api.github.com/repos/marcrasi/swift/deployments","created_at":"2018-06-01T16:13:26Z","updated_at":"2018-06-01T16:13:59Z","pushed_at":"2018-06-12T18:30:23Z","git_url":"git://github.com/marcrasi/swift.git","ssh_url":"git@github.com:marcrasi/swift.git","clone_url":"https://github.com/marcrasi/swift.git","svn_url":"https://github.com/marcrasi/swift","homepage":"https://swift.org/","size":297432,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apple:tensorflow","ref":"tensorflow","sha":"551fac3093e559f4925e963a3dda8cee425fe508","user":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"node_id":"MDEwOlJlcG9zaXRvcnk0NDgzODk0OQ==","name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2018-06-12T21:29:59Z","pushed_at":"2018-06-12T22:30:14Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":299470,"stargazers_count":44155,"watchers_count":44155,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":6958,"mirror_url":null,"archived":false,"open_issues_count":364,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":6958,"open_issues":364,"watchers":44155,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/17135"},"html":{"href":"https://github.com/apple/swift/pull/17135"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/17135"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/17135/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/17135/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/17135/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/e489c9b9006d57437d9c132f4b8cd5ec683cd9b2"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"LaurentMazare"}}