{"action":"created","issue":{"url":"https://api.github.com/repos/root-project/root/issues/1821","repository_url":"https://api.github.com/repos/root-project/root","labels_url":"https://api.github.com/repos/root-project/root/issues/1821/labels{/name}","comments_url":"https://api.github.com/repos/root-project/root/issues/1821/comments","events_url":"https://api.github.com/repos/root-project/root/issues/1821/events","html_url":"https://github.com/root-project/root/pull/1821","id":311534977,"number":1821,"title":"Use GetMethodAny instead of GetListOfGlobalFunctions","user":{"login":"yamaguchi1024","id":12247908,"avatar_url":"https://avatars0.githubusercontent.com/u/12247908?v=4","gravatar_id":"","url":"https://api.github.com/users/yamaguchi1024","html_url":"https://github.com/yamaguchi1024","followers_url":"https://api.github.com/users/yamaguchi1024/followers","following_url":"https://api.github.com/users/yamaguchi1024/following{/other_user}","gists_url":"https://api.github.com/users/yamaguchi1024/gists{/gist_id}","starred_url":"https://api.github.com/users/yamaguchi1024/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yamaguchi1024/subscriptions","organizations_url":"https://api.github.com/users/yamaguchi1024/orgs","repos_url":"https://api.github.com/users/yamaguchi1024/repos","events_url":"https://api.github.com/users/yamaguchi1024/events{/privacy}","received_events_url":"https://api.github.com/users/yamaguchi1024/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"vgvassilev","id":6516307,"avatar_url":"https://avatars1.githubusercontent.com/u/6516307?v=4","gravatar_id":"","url":"https://api.github.com/users/vgvassilev","html_url":"https://github.com/vgvassilev","followers_url":"https://api.github.com/users/vgvassilev/followers","following_url":"https://api.github.com/users/vgvassilev/following{/other_user}","gists_url":"https://api.github.com/users/vgvassilev/gists{/gist_id}","starred_url":"https://api.github.com/users/vgvassilev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vgvassilev/subscriptions","organizations_url":"https://api.github.com/users/vgvassilev/orgs","repos_url":"https://api.github.com/users/vgvassilev/repos","events_url":"https://api.github.com/users/vgvassilev/events{/privacy}","received_events_url":"https://api.github.com/users/vgvassilev/received_events","type":"User","site_admin":false},"assignees":[{"login":"vgvassilev","id":6516307,"avatar_url":"https://avatars1.githubusercontent.com/u/6516307?v=4","gravatar_id":"","url":"https://api.github.com/users/vgvassilev","html_url":"https://github.com/vgvassilev","followers_url":"https://api.github.com/users/vgvassilev/followers","following_url":"https://api.github.com/users/vgvassilev/following{/other_user}","gists_url":"https://api.github.com/users/vgvassilev/gists{/gist_id}","starred_url":"https://api.github.com/users/vgvassilev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vgvassilev/subscriptions","organizations_url":"https://api.github.com/users/vgvassilev/orgs","repos_url":"https://api.github.com/users/vgvassilev/repos","events_url":"https://api.github.com/users/vgvassilev/events{/privacy}","received_events_url":"https://api.github.com/users/vgvassilev/received_events","type":"User","site_admin":false}],"milestone":null,"comments":22,"created_at":"2018-04-05T09:25:32Z","updated_at":"2018-04-17T18:31:27Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/root-project/root/pulls/1821","html_url":"https://github.com/root-project/root/pull/1821","diff_url":"https://github.com/root-project/root/pull/1821.diff","patch_url":"https://github.com/root-project/root/pull/1821.patch"},"body":"**Edit**: This patch fixes cxxmodule tests failure\r\nGetListOfGlobalFunctions were fine, what failing modules test was GetListOfAllPublicMethods. Let's use GetMethodAny instead.\r\n\r\nPerformance benchmark:\r\n`rootbench-build/root/hist/hist/HistBenchmarks`\r\nRelease build, without modules, without this patch:\r\n```\r\n---------------------------------------------------------------\r\nBenchmark                        Time           CPU Iterations \r\n---------------------------------------------------------------                                   \r\nBM_TFormula_CreateEmpty          0 ns          0 ns 1000000000                                    \r\nBM_TFormula_Math_Sin        221061 ns     220326 ns       3118\r\nBM_TFormula_Pow              19896 ns      19843 ns      34679                                                        \r\nBM_TFormula_Std_Pow         262071 ns     261083 ns       2592   \r\n```\r\nRelease build, without modules, with this patch:\r\n```\r\n---------------------------------------------------------------\r\nBenchmark                        Time           CPU Iterations\r\n---------------------------------------------------------------\r\nBM_TFormula_CreateEmpty          0 ns          0 ns 1000000000\r\nBM_TFormula_Math_Sin        197420 ns     196728 ns       3384\r\nBM_TFormula_Pow              20003 ns      19949 ns      34502\r\nBM_TFormula_Std_Pow          27867 ns      27778 ns      25631\r\n```\r\nMemory benchmark:\r\n`/usr/bin/time -v test/TFormulaTests 2>&1 | grep resident`\r\nRelease build, without modules, without this patch:\r\n```\r\n        Maximum resident set size (kbytes): 208144\r\n```\r\nRelease build, without modules, with this patch:\r\n```\r\n        Maximum resident set size (kbytes): 178772\r\n```"},"comment":{"url":"https://api.github.com/repos/root-project/root/issues/comments/382096013","html_url":"https://github.com/root-project/root/pull/1821#issuecomment-382096013","issue_url":"https://api.github.com/repos/root-project/root/issues/1821","id":382096013,"user":{"login":"phsft-bot","id":25639015,"avatar_url":"https://avatars1.githubusercontent.com/u/25639015?v=4","gravatar_id":"","url":"https://api.github.com/users/phsft-bot","html_url":"https://github.com/phsft-bot","followers_url":"https://api.github.com/users/phsft-bot/followers","following_url":"https://api.github.com/users/phsft-bot/following{/other_user}","gists_url":"https://api.github.com/users/phsft-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/phsft-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phsft-bot/subscriptions","organizations_url":"https://api.github.com/users/phsft-bot/orgs","repos_url":"https://api.github.com/users/phsft-bot/repos","events_url":"https://api.github.com/users/phsft-bot/events{/privacy}","received_events_url":"https://api.github.com/users/phsft-bot/received_events","type":"User","site_admin":false},"created_at":"2018-04-17T18:31:27Z","updated_at":"2018-04-17T18:31:27Z","author_association":"COLLABORATOR","body":"Build failed on ubuntu16/native.\n[See console output](https://epsft-jenkins.cern.ch/job/root-pullrequests-build/22228/console).\n### Failing tests:\n- [projectroot.roottest.root.dataframe.roottest_root_dataframe_test_snapshot](https://epsft-jenkins.cern.ch/job/root-pullrequests-build/22228/testReport/projectroot.roottest.root/dataframe/roottest_root_dataframe_test_snapshot/)\n- [projectroot.roottest.root.dataframe.roottest_root_dataframe_test_snapshotNFiles](https://epsft-jenkins.cern.ch/job/root-pullrequests-build/22228/testReport/projectroot.roottest.root/dataframe/roottest_root_dataframe_test_snapshotNFiles/)\n"}}
{"actor":{"display_login":"phsft-bot"}}