{"action":"created","issue":{"url":"https://api.github.com/repos/electron/electron/issues/14823","repository_url":"https://api.github.com/repos/electron/electron","labels_url":"https://api.github.com/repos/electron/electron/issues/14823/labels{/name}","comments_url":"https://api.github.com/repos/electron/electron/issues/14823/comments","events_url":"https://api.github.com/repos/electron/electron/issues/14823/events","html_url":"https://github.com/electron/electron/pull/14823","id":364206878,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4NDUxMDM2","number":14823,"title":"docs: correct key code reqs for accelerator doc","user":{"login":"codebytere","id":2036040,"node_id":"MDQ6VXNlcjIwMzYwNDA=","avatar_url":"https://avatars2.githubusercontent.com/u/2036040?v=4","gravatar_id":"","url":"https://api.github.com/users/codebytere","html_url":"https://github.com/codebytere","followers_url":"https://api.github.com/users/codebytere/followers","following_url":"https://api.github.com/users/codebytere/following{/other_user}","gists_url":"https://api.github.com/users/codebytere/gists{/gist_id}","starred_url":"https://api.github.com/users/codebytere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codebytere/subscriptions","organizations_url":"https://api.github.com/users/codebytere/orgs","repos_url":"https://api.github.com/users/codebytere/repos","events_url":"https://api.github.com/users/codebytere/events{/privacy}","received_events_url":"https://api.github.com/users/codebytere/received_events","type":"User","site_admin":true},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-26T20:52:11Z","updated_at":"2018-09-26T22:03:50Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/electron/electron/pulls/14823","html_url":"https://github.com/electron/electron/pull/14823","diff_url":"https://github.com/electron/electron/pull/14823.diff","patch_url":"https://github.com/electron/electron/pull/14823.patch"},"body":"##### Description of Change\r\n\r\nResolves https://github.com/electron/electron/issues/14818.\r\n\r\nClarifies that global accelerator registration can accept multiple modifiers but only **one** key code.\r\n\r\n/cc @ckerr \r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] PR description included and stakeholders cc'd\r\n- [x] `npm test` passes\r\n- [x] relevant documentation is changed or added\r\n- [x] PR title follows semantic [commit guidelines](https://github.com/electron/electron/blob/master/docs/development/pull-requests.md#commit-message-guidelines)\r\n\r\n##### Release Notes\r\n\r\nNotes: correct key code allowance for accelerator doc"},"comment":{"url":"https://api.github.com/repos/electron/electron/issues/comments/424884838","html_url":"https://github.com/electron/electron/pull/14823#issuecomment-424884838","issue_url":"https://api.github.com/repos/electron/electron/issues/14823","id":424884838,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNDg4NDgzOA==","user":{"login":"codebytere","id":2036040,"node_id":"MDQ6VXNlcjIwMzYwNDA=","avatar_url":"https://avatars2.githubusercontent.com/u/2036040?v=4","gravatar_id":"","url":"https://api.github.com/users/codebytere","html_url":"https://github.com/codebytere","followers_url":"https://api.github.com/users/codebytere/followers","following_url":"https://api.github.com/users/codebytere/following{/other_user}","gists_url":"https://api.github.com/users/codebytere/gists{/gist_id}","starred_url":"https://api.github.com/users/codebytere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codebytere/subscriptions","organizations_url":"https://api.github.com/users/codebytere/orgs","repos_url":"https://api.github.com/users/codebytere/repos","events_url":"https://api.github.com/users/codebytere/events{/privacy}","received_events_url":"https://api.github.com/users/codebytere/received_events","type":"User","site_admin":true},"created_at":"2018-09-26T22:03:50Z","updated_at":"2018-09-26T22:03:50Z","author_association":"MEMBER","body":"Unrelated test failures, merging since this is just a docs PR."}}
{"actor":{"display_login":"codebytere"}}