{"action":"created","issue":{"url":"https://api.github.com/repos/openebs/maya/issues/866","repository_url":"https://api.github.com/repos/openebs/maya","labels_url":"https://api.github.com/repos/openebs/maya/issues/866/labels{/name}","comments_url":"https://api.github.com/repos/openebs/maya/issues/866/comments","events_url":"https://api.github.com/repos/openebs/maya/issues/866/events","html_url":"https://github.com/openebs/maya/pull/866","id":390072132,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3OTE3OTM3","number":866,"title":"fix(exporter): add check for nil metrics after unmarshalling","user":{"login":"utkarshmani1997","id":19219723,"node_id":"MDQ6VXNlcjE5MjE5NzIz","avatar_url":"https://avatars2.githubusercontent.com/u/19219723?v=4","gravatar_id":"","url":"https://api.github.com/users/utkarshmani1997","html_url":"https://github.com/utkarshmani1997","followers_url":"https://api.github.com/users/utkarshmani1997/followers","following_url":"https://api.github.com/users/utkarshmani1997/following{/other_user}","gists_url":"https://api.github.com/users/utkarshmani1997/gists{/gist_id}","starred_url":"https://api.github.com/users/utkarshmani1997/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/utkarshmani1997/subscriptions","organizations_url":"https://api.github.com/users/utkarshmani1997/orgs","repos_url":"https://api.github.com/users/utkarshmani1997/repos","events_url":"https://api.github.com/users/utkarshmani1997/events{/privacy}","received_events_url":"https://api.github.com/users/utkarshmani1997/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-12T05:36:40Z","updated_at":"2018-12-12T05:54:56Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/openebs/maya/pulls/866","html_url":"https://github.com/openebs/maya/pull/866","diff_url":"https://github.com/openebs/maya/pull/866.diff","patch_url":"https://github.com/openebs/maya/pull/866.patch"},"body":"It fixes the issue due to error in unmarshalling, which therefore\r\npanic exporter due to nil metrics.\r\n\r\nSigned-off-by: Utkarsh Mani Tripathi <utkarsh.tripathi@mayadata.io>\r\n\r\n<!--  Thanks for sending a pull request!  Here are some tips for you -->\r\n\r\n**What this PR does / why we need it**:\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #\r\n\r\n**Special notes for your reviewer**:\r\n"},"comment":{"url":"https://api.github.com/repos/openebs/maya/issues/comments/446471718","html_url":"https://github.com/openebs/maya/pull/866#issuecomment-446471718","issue_url":"https://api.github.com/repos/openebs/maya/issues/866","id":446471718,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NjQ3MTcxOA==","user":{"login":"codecov[bot]","id":22429695,"node_id":"MDM6Qm90MjI0Mjk2OTU=","avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-12-12T05:54:56Z","updated_at":"2018-12-12T05:54:56Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/openebs/maya/pull/866?src=pr&el=h1) Report\n> Merging [#866](https://codecov.io/gh/openebs/maya/pull/866?src=pr&el=desc) into [master](https://codecov.io/gh/openebs/maya/commit/da6d41493f99149a97d32dfbdbb2c705e27148c8?src=pr&el=desc) will **decrease** coverage by `<.01%`.\n> The diff coverage is `60%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/openebs/maya/pull/866/graphs/tree.svg?width=650&token=nDwloue1T5&height=150&src=pr)](https://codecov.io/gh/openebs/maya/pull/866?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master     #866      +/-   ##\n==========================================\n- Coverage   42.27%   42.26%   -0.01%     \n==========================================\n  Files         141      141              \n  Lines        9380     9382       +2     \n==========================================\n  Hits         3965     3965              \n- Misses       5149     5150       +1     \n- Partials      266      267       +1\n```\n\n\n| [Impacted Files](https://codecov.io/gh/openebs/maya/pull/866?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [cmd/maya-exporter/app/collector/metrics.go](https://codecov.io/gh/openebs/maya/pull/866/diff?src=pr&el=tree#diff-Y21kL21heWEtZXhwb3J0ZXIvYXBwL2NvbGxlY3Rvci9tZXRyaWNzLmdv) | `96.38% <ø> (ø)` | :arrow_up: |\n| [cmd/maya-exporter/app/collector/cstorcollector.go](https://codecov.io/gh/openebs/maya/pull/866/diff?src=pr&el=tree#diff-Y21kL21heWEtZXhwb3J0ZXIvYXBwL2NvbGxlY3Rvci9jc3RvcmNvbGxlY3Rvci5nbw==) | `88.48% <60%> (-1.09%)` | :arrow_down: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/openebs/maya/pull/866?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/openebs/maya/pull/866?src=pr&el=footer). Last update [da6d414...a52de7d](https://codecov.io/gh/openebs/maya/pull/866?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}