{"action":"created","comment":{"url":"https://api.github.com/repos/okonet/ejs-loader/pulls/comments/168916486","pull_request_review_id":97368945,"id":168916486,"diff_hunk":"@@ -6,43 +6,55 @@ If you are looking for the loader which uses [EJS templating engine](https://git\n \n ## Installation\n \n-`npm install ejs-loader`\n+`npm install ejs-loader --save-dev`\n \n ## Usage\n \n-[Documentation: Using loaders](http://webpack.github.io/docs/using-loaders.html)\n+[Documentation: Using loaders](https://webpack.js.org/concepts/loaders/)\n \n ``` javascript\n-var template = require(\"ejs!./file.ejs\");\n+var template = require(\"./file.ejs\");\n // => returns the template function compiled with undesrcore (lodash) templating engine.\n \n // And then use it somewhere in your code\n template(data) // Pass object with data\n ```\n \n-You also should provide a global `_` variable with the lodash/underscore runtime. You can do it with the following webpack plugin: https://github.com/webpack/docs/wiki/list-of-plugins#provideplugin\n+You also should provide a global `_` variable with the lodash/underscore runtime. You can do it with the following webpack plugin: https://webpack.js.org/plugins/provide-plugin/\n \n ```\n plugins: [\n     new webpack.ProvidePlugin({\n-        _: \"underscore\"\n+        _: \"lodash\"\n     })\n ]\n ```\n \n ### Options\n-[Underscore](http://underscorejs.org/#template)/[Lodash](https://lodash.com/docs#template) options can be passed in using the querystring or adding an ```esjLoader``` options block to your configuration.\n+[Underscore](http://underscorejs.org/#template)/[Lodash](https://lodash.com/docs#template) options can be passed in using the querystring or adding or a JSON object to your configuration.\n \n Config example using a querystring:\n ``` js\n module.exports = {\n   module: {\n-    loaders: [\n-      { test: /\\.ejs$/, loader: 'ejs-loader?variable=data' },\n+    rules: [\n+      { test: /\\.ejs$/, use: [{loader: 'ejs-loader?variable=data'}] },","path":"README.md","position":44,"original_position":44,"commit_id":"445c51f092a5bfb1ed06123f1cd360a6b0347767","original_commit_id":"445c51f092a5bfb1ed06123f1cd360a6b0347767","user":{"login":"okonet","id":11071,"avatar_url":"https://avatars3.githubusercontent.com/u/11071?v=4","gravatar_id":"","url":"https://api.github.com/users/okonet","html_url":"https://github.com/okonet","followers_url":"https://api.github.com/users/okonet/followers","following_url":"https://api.github.com/users/okonet/following{/other_user}","gists_url":"https://api.github.com/users/okonet/gists{/gist_id}","starred_url":"https://api.github.com/users/okonet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okonet/subscriptions","organizations_url":"https://api.github.com/users/okonet/orgs","repos_url":"https://api.github.com/users/okonet/repos","events_url":"https://api.github.com/users/okonet/events{/privacy}","received_events_url":"https://api.github.com/users/okonet/received_events","type":"User","site_admin":false},"body":"Let's remove this example completely","created_at":"2018-02-17T08:35:27Z","updated_at":"2018-02-17T08:37:23Z","html_url":"https://github.com/okonet/ejs-loader/pull/23#discussion_r168916486","pull_request_url":"https://api.github.com/repos/okonet/ejs-loader/pulls/23","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/okonet/ejs-loader/pulls/comments/168916486"},"html":{"href":"https://github.com/okonet/ejs-loader/pull/23#discussion_r168916486"},"pull_request":{"href":"https://api.github.com/repos/okonet/ejs-loader/pulls/23"}},"in_reply_to_id":168916482},"pull_request":{"url":"https://api.github.com/repos/okonet/ejs-loader/pulls/23","id":155438603,"html_url":"https://github.com/okonet/ejs-loader/pull/23","diff_url":"https://github.com/okonet/ejs-loader/pull/23.diff","patch_url":"https://github.com/okonet/ejs-loader/pull/23.patch","issue_url":"https://api.github.com/repos/okonet/ejs-loader/issues/23","number":23,"state":"open","locked":false,"title":"Make it compatible with Webpack 3.0 and update dependencies","user":{"login":"vlucendo","id":11018451,"avatar_url":"https://avatars1.githubusercontent.com/u/11018451?v=4","gravatar_id":"","url":"https://api.github.com/users/vlucendo","html_url":"https://github.com/vlucendo","followers_url":"https://api.github.com/users/vlucendo/followers","following_url":"https://api.github.com/users/vlucendo/following{/other_user}","gists_url":"https://api.github.com/users/vlucendo/gists{/gist_id}","starred_url":"https://api.github.com/users/vlucendo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vlucendo/subscriptions","organizations_url":"https://api.github.com/users/vlucendo/orgs","repos_url":"https://api.github.com/users/vlucendo/repos","events_url":"https://api.github.com/users/vlucendo/events{/privacy}","received_events_url":"https://api.github.com/users/vlucendo/received_events","type":"User","site_admin":false},"body":"When used with the latest Webpack it shows:\r\n\r\n> DeprecationWarning: loaderUtils.parseQuery() received a non-string value which can be problematic, see https://github.com/webpack/loader-utils/issues/56 parseQuery() will be replaced with getOptions() in the next major version of loader-utils.\r\n\r\nI've updated dependencies, documentation and made some changes to make it work properly.","created_at":"2017-11-29T20:02:30Z","updated_at":"2018-02-17T08:37:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e09a8f5f376466d71e8aa9f33cdd7440771775d4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/okonet/ejs-loader/pulls/23/commits","review_comments_url":"https://api.github.com/repos/okonet/ejs-loader/pulls/23/comments","review_comment_url":"https://api.github.com/repos/okonet/ejs-loader/pulls/comments{/number}","comments_url":"https://api.github.com/repos/okonet/ejs-loader/issues/23/comments","statuses_url":"https://api.github.com/repos/okonet/ejs-loader/statuses/445c51f092a5bfb1ed06123f1cd360a6b0347767","head":{"label":"vlucendo:master","ref":"master","sha":"445c51f092a5bfb1ed06123f1cd360a6b0347767","user":{"login":"vlucendo","id":11018451,"avatar_url":"https://avatars1.githubusercontent.com/u/11018451?v=4","gravatar_id":"","url":"https://api.github.com/users/vlucendo","html_url":"https://github.com/vlucendo","followers_url":"https://api.github.com/users/vlucendo/followers","following_url":"https://api.github.com/users/vlucendo/following{/other_user}","gists_url":"https://api.github.com/users/vlucendo/gists{/gist_id}","starred_url":"https://api.github.com/users/vlucendo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vlucendo/subscriptions","organizations_url":"https://api.github.com/users/vlucendo/orgs","repos_url":"https://api.github.com/users/vlucendo/repos","events_url":"https://api.github.com/users/vlucendo/events{/privacy}","received_events_url":"https://api.github.com/users/vlucendo/received_events","type":"User","site_admin":false},"repo":{"id":112520262,"name":"ejs-loader-forked","full_name":"vlucendo/ejs-loader-forked","owner":{"login":"vlucendo","id":11018451,"avatar_url":"https://avatars1.githubusercontent.com/u/11018451?v=4","gravatar_id":"","url":"https://api.github.com/users/vlucendo","html_url":"https://github.com/vlucendo","followers_url":"https://api.github.com/users/vlucendo/followers","following_url":"https://api.github.com/users/vlucendo/following{/other_user}","gists_url":"https://api.github.com/users/vlucendo/gists{/gist_id}","starred_url":"https://api.github.com/users/vlucendo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vlucendo/subscriptions","organizations_url":"https://api.github.com/users/vlucendo/orgs","repos_url":"https://api.github.com/users/vlucendo/repos","events_url":"https://api.github.com/users/vlucendo/events{/privacy}","received_events_url":"https://api.github.com/users/vlucendo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vlucendo/ejs-loader-forked","description":"EJS (Underscore/LoDash Templates) loader for webpack","fork":true,"url":"https://api.github.com/repos/vlucendo/ejs-loader-forked","forks_url":"https://api.github.com/repos/vlucendo/ejs-loader-forked/forks","keys_url":"https://api.github.com/repos/vlucendo/ejs-loader-forked/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vlucendo/ejs-loader-forked/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vlucendo/ejs-loader-forked/teams","hooks_url":"https://api.github.com/repos/vlucendo/ejs-loader-forked/hooks","issue_events_url":"https://api.github.com/repos/vlucendo/ejs-loader-forked/issues/events{/number}","events_url":"https://api.github.com/repos/vlucendo/ejs-loader-forked/events","assignees_url":"https://api.github.com/repos/vlucendo/ejs-loader-forked/assignees{/user}","branches_url":"https://api.github.com/repos/vlucendo/ejs-loader-forked/branches{/branch}","tags_url":"https://api.github.com/repos/vlucendo/ejs-loader-forked/tags","blobs_url":"https://api.github.com/repos/vlucendo/ejs-loader-forked/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vlucendo/ejs-loader-forked/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vlucendo/ejs-loader-forked/git/refs{/sha}","trees_url":"https://api.github.com/repos/vlucendo/ejs-loader-forked/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vlucendo/ejs-loader-forked/statuses/{sha}","languages_url":"https://api.github.com/repos/vlucendo/ejs-loader-forked/languages","stargazers_url":"https://api.github.com/repos/vlucendo/ejs-loader-forked/stargazers","contributors_url":"https://api.github.com/repos/vlucendo/ejs-loader-forked/contributors","subscribers_url":"https://api.github.com/repos/vlucendo/ejs-loader-forked/subscribers","subscription_url":"https://api.github.com/repos/vlucendo/ejs-loader-forked/subscription","commits_url":"https://api.github.com/repos/vlucendo/ejs-loader-forked/commits{/sha}","git_commits_url":"https://api.github.com/repos/vlucendo/ejs-loader-forked/git/commits{/sha}","comments_url":"https://api.github.com/repos/vlucendo/ejs-loader-forked/comments{/number}","issue_comment_url":"https://api.github.com/repos/vlucendo/ejs-loader-forked/issues/comments{/number}","contents_url":"https://api.github.com/repos/vlucendo/ejs-loader-forked/contents/{+path}","compare_url":"https://api.github.com/repos/vlucendo/ejs-loader-forked/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vlucendo/ejs-loader-forked/merges","archive_url":"https://api.github.com/repos/vlucendo/ejs-loader-forked/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vlucendo/ejs-loader-forked/downloads","issues_url":"https://api.github.com/repos/vlucendo/ejs-loader-forked/issues{/number}","pulls_url":"https://api.github.com/repos/vlucendo/ejs-loader-forked/pulls{/number}","milestones_url":"https://api.github.com/repos/vlucendo/ejs-loader-forked/milestones{/number}","notifications_url":"https://api.github.com/repos/vlucendo/ejs-loader-forked/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vlucendo/ejs-loader-forked/labels{/name}","releases_url":"https://api.github.com/repos/vlucendo/ejs-loader-forked/releases{/id}","deployments_url":"https://api.github.com/repos/vlucendo/ejs-loader-forked/deployments","created_at":"2017-11-29T19:46:24Z","updated_at":"2017-12-01T12:20:37Z","pushed_at":"2017-12-01T11:53:02Z","git_url":"git://github.com/vlucendo/ejs-loader-forked.git","ssh_url":"git@github.com:vlucendo/ejs-loader-forked.git","clone_url":"https://github.com/vlucendo/ejs-loader-forked.git","svn_url":"https://github.com/vlucendo/ejs-loader-forked","homepage":null,"size":16,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"okonet:master","ref":"master","sha":"39046c0246775ae371f7dda63bfa5dbea89c890e","user":{"login":"okonet","id":11071,"avatar_url":"https://avatars3.githubusercontent.com/u/11071?v=4","gravatar_id":"","url":"https://api.github.com/users/okonet","html_url":"https://github.com/okonet","followers_url":"https://api.github.com/users/okonet/followers","following_url":"https://api.github.com/users/okonet/following{/other_user}","gists_url":"https://api.github.com/users/okonet/gists{/gist_id}","starred_url":"https://api.github.com/users/okonet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okonet/subscriptions","organizations_url":"https://api.github.com/users/okonet/orgs","repos_url":"https://api.github.com/users/okonet/repos","events_url":"https://api.github.com/users/okonet/events{/privacy}","received_events_url":"https://api.github.com/users/okonet/received_events","type":"User","site_admin":false},"repo":{"id":19983044,"name":"ejs-loader","full_name":"okonet/ejs-loader","owner":{"login":"okonet","id":11071,"avatar_url":"https://avatars3.githubusercontent.com/u/11071?v=4","gravatar_id":"","url":"https://api.github.com/users/okonet","html_url":"https://github.com/okonet","followers_url":"https://api.github.com/users/okonet/followers","following_url":"https://api.github.com/users/okonet/following{/other_user}","gists_url":"https://api.github.com/users/okonet/gists{/gist_id}","starred_url":"https://api.github.com/users/okonet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okonet/subscriptions","organizations_url":"https://api.github.com/users/okonet/orgs","repos_url":"https://api.github.com/users/okonet/repos","events_url":"https://api.github.com/users/okonet/events{/privacy}","received_events_url":"https://api.github.com/users/okonet/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/okonet/ejs-loader","description":"EJS (Underscore/LoDash Templates) loader for webpack","fork":false,"url":"https://api.github.com/repos/okonet/ejs-loader","forks_url":"https://api.github.com/repos/okonet/ejs-loader/forks","keys_url":"https://api.github.com/repos/okonet/ejs-loader/keys{/key_id}","collaborators_url":"https://api.github.com/repos/okonet/ejs-loader/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/okonet/ejs-loader/teams","hooks_url":"https://api.github.com/repos/okonet/ejs-loader/hooks","issue_events_url":"https://api.github.com/repos/okonet/ejs-loader/issues/events{/number}","events_url":"https://api.github.com/repos/okonet/ejs-loader/events","assignees_url":"https://api.github.com/repos/okonet/ejs-loader/assignees{/user}","branches_url":"https://api.github.com/repos/okonet/ejs-loader/branches{/branch}","tags_url":"https://api.github.com/repos/okonet/ejs-loader/tags","blobs_url":"https://api.github.com/repos/okonet/ejs-loader/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/okonet/ejs-loader/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/okonet/ejs-loader/git/refs{/sha}","trees_url":"https://api.github.com/repos/okonet/ejs-loader/git/trees{/sha}","statuses_url":"https://api.github.com/repos/okonet/ejs-loader/statuses/{sha}","languages_url":"https://api.github.com/repos/okonet/ejs-loader/languages","stargazers_url":"https://api.github.com/repos/okonet/ejs-loader/stargazers","contributors_url":"https://api.github.com/repos/okonet/ejs-loader/contributors","subscribers_url":"https://api.github.com/repos/okonet/ejs-loader/subscribers","subscription_url":"https://api.github.com/repos/okonet/ejs-loader/subscription","commits_url":"https://api.github.com/repos/okonet/ejs-loader/commits{/sha}","git_commits_url":"https://api.github.com/repos/okonet/ejs-loader/git/commits{/sha}","comments_url":"https://api.github.com/repos/okonet/ejs-loader/comments{/number}","issue_comment_url":"https://api.github.com/repos/okonet/ejs-loader/issues/comments{/number}","contents_url":"https://api.github.com/repos/okonet/ejs-loader/contents/{+path}","compare_url":"https://api.github.com/repos/okonet/ejs-loader/compare/{base}...{head}","merges_url":"https://api.github.com/repos/okonet/ejs-loader/merges","archive_url":"https://api.github.com/repos/okonet/ejs-loader/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/okonet/ejs-loader/downloads","issues_url":"https://api.github.com/repos/okonet/ejs-loader/issues{/number}","pulls_url":"https://api.github.com/repos/okonet/ejs-loader/pulls{/number}","milestones_url":"https://api.github.com/repos/okonet/ejs-loader/milestones{/number}","notifications_url":"https://api.github.com/repos/okonet/ejs-loader/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/okonet/ejs-loader/labels{/name}","releases_url":"https://api.github.com/repos/okonet/ejs-loader/releases{/id}","deployments_url":"https://api.github.com/repos/okonet/ejs-loader/deployments","created_at":"2014-05-20T13:59:54Z","updated_at":"2018-01-24T08:13:04Z","pushed_at":"2017-12-01T11:53:04Z","git_url":"git://github.com/okonet/ejs-loader.git","ssh_url":"git@github.com:okonet/ejs-loader.git","clone_url":"https://github.com/okonet/ejs-loader.git","svn_url":"https://github.com/okonet/ejs-loader","homepage":null,"size":12,"stargazers_count":75,"watchers_count":75,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":14,"open_issues":9,"watchers":75,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/okonet/ejs-loader/pulls/23"},"html":{"href":"https://github.com/okonet/ejs-loader/pull/23"},"issue":{"href":"https://api.github.com/repos/okonet/ejs-loader/issues/23"},"comments":{"href":"https://api.github.com/repos/okonet/ejs-loader/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/okonet/ejs-loader/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/okonet/ejs-loader/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/okonet/ejs-loader/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/okonet/ejs-loader/statuses/445c51f092a5bfb1ed06123f1cd360a6b0347767"}},"author_association":"NONE"}}
{"actor":{"display_login":"okonet"}}