{"action":"created","comment":{"url":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments/189733722","pull_request_review_id":121970496,"id":189733722,"diff_hunk":"@@ -85,6 +85,12 @@ int mrail_get_core_info(uint32_t version, const char *node, const char *service,\n \tif (!core_hints)\n \t\treturn -FI_ENOMEM;\n \n+\tif (!hints) {\n+\t\tcore_hints->mode = ~0ULL;","path":"prov/mrail/src/mrail_init.c","position":5,"original_position":5,"commit_id":"8386da18c5bc6413b2803f227e2d27e15faa2347","original_commit_id":"8386da18c5bc6413b2803f227e2d27e15faa2347","user":{"login":"shefty","id":3967608,"avatar_url":"https://avatars0.githubusercontent.com/u/3967608?v=4","gravatar_id":"","url":"https://api.github.com/users/shefty","html_url":"https://github.com/shefty","followers_url":"https://api.github.com/users/shefty/followers","following_url":"https://api.github.com/users/shefty/following{/other_user}","gists_url":"https://api.github.com/users/shefty/gists{/gist_id}","starred_url":"https://api.github.com/users/shefty/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shefty/subscriptions","organizations_url":"https://api.github.com/users/shefty/orgs","repos_url":"https://api.github.com/users/shefty/repos","events_url":"https://api.github.com/users/shefty/events{/privacy}","received_events_url":"https://api.github.com/users/shefty/received_events","type":"User","site_admin":false},"body":"But that could return an fi_info that mrail can't actually support.","created_at":"2018-05-21T22:41:38Z","updated_at":"2018-05-21T22:41:38Z","html_url":"https://github.com/ofiwg/libfabric/pull/4113#discussion_r189733722","pull_request_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/4113","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments/189733722"},"html":{"href":"https://github.com/ofiwg/libfabric/pull/4113#discussion_r189733722"},"pull_request":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/4113"}},"in_reply_to_id":189723412},"pull_request":{"url":"https://api.github.com/repos/ofiwg/libfabric/pulls/4113","id":189444925,"html_url":"https://github.com/ofiwg/libfabric/pull/4113","diff_url":"https://github.com/ofiwg/libfabric/pull/4113.diff","patch_url":"https://github.com/ofiwg/libfabric/pull/4113.patch","issue_url":"https://api.github.com/repos/ofiwg/libfabric/issues/4113","number":4113,"state":"open","locked":false,"title":"prov/mrail: set all modes when calling fi_getinfo for underlying provider","user":{"login":"a-ilango","id":8547674,"avatar_url":"https://avatars1.githubusercontent.com/u/8547674?v=4","gravatar_id":"","url":"https://api.github.com/users/a-ilango","html_url":"https://github.com/a-ilango","followers_url":"https://api.github.com/users/a-ilango/followers","following_url":"https://api.github.com/users/a-ilango/following{/other_user}","gists_url":"https://api.github.com/users/a-ilango/gists{/gist_id}","starred_url":"https://api.github.com/users/a-ilango/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-ilango/subscriptions","organizations_url":"https://api.github.com/users/a-ilango/orgs","repos_url":"https://api.github.com/users/a-ilango/repos","events_url":"https://api.github.com/users/a-ilango/events{/privacy}","received_events_url":"https://api.github.com/users/a-ilango/received_events","type":"User","site_admin":false},"body":"Also use the OFI prefix macro for provider name.","created_at":"2018-05-21T17:49:45Z","updated_at":"2018-05-21T22:41:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"02ea17fa08b954e6f47de7d18ba4534ef8394f21","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/4113/commits","review_comments_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/4113/comments","review_comment_url":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ofiwg/libfabric/issues/4113/comments","statuses_url":"https://api.github.com/repos/ofiwg/libfabric/statuses/8386da18c5bc6413b2803f227e2d27e15faa2347","head":{"label":"a-ilango:mrail","ref":"mrail","sha":"8386da18c5bc6413b2803f227e2d27e15faa2347","user":{"login":"a-ilango","id":8547674,"avatar_url":"https://avatars1.githubusercontent.com/u/8547674?v=4","gravatar_id":"","url":"https://api.github.com/users/a-ilango","html_url":"https://github.com/a-ilango","followers_url":"https://api.github.com/users/a-ilango/followers","following_url":"https://api.github.com/users/a-ilango/following{/other_user}","gists_url":"https://api.github.com/users/a-ilango/gists{/gist_id}","starred_url":"https://api.github.com/users/a-ilango/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-ilango/subscriptions","organizations_url":"https://api.github.com/users/a-ilango/orgs","repos_url":"https://api.github.com/users/a-ilango/repos","events_url":"https://api.github.com/users/a-ilango/events{/privacy}","received_events_url":"https://api.github.com/users/a-ilango/received_events","type":"User","site_admin":false},"repo":{"id":24616163,"name":"libfabric","full_name":"a-ilango/libfabric","owner":{"login":"a-ilango","id":8547674,"avatar_url":"https://avatars1.githubusercontent.com/u/8547674?v=4","gravatar_id":"","url":"https://api.github.com/users/a-ilango","html_url":"https://github.com/a-ilango","followers_url":"https://api.github.com/users/a-ilango/followers","following_url":"https://api.github.com/users/a-ilango/following{/other_user}","gists_url":"https://api.github.com/users/a-ilango/gists{/gist_id}","starred_url":"https://api.github.com/users/a-ilango/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-ilango/subscriptions","organizations_url":"https://api.github.com/users/a-ilango/orgs","repos_url":"https://api.github.com/users/a-ilango/repos","events_url":"https://api.github.com/users/a-ilango/events{/privacy}","received_events_url":"https://api.github.com/users/a-ilango/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/a-ilango/libfabric","description":"Open Fabric Interfaces","fork":true,"url":"https://api.github.com/repos/a-ilango/libfabric","forks_url":"https://api.github.com/repos/a-ilango/libfabric/forks","keys_url":"https://api.github.com/repos/a-ilango/libfabric/keys{/key_id}","collaborators_url":"https://api.github.com/repos/a-ilango/libfabric/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/a-ilango/libfabric/teams","hooks_url":"https://api.github.com/repos/a-ilango/libfabric/hooks","issue_events_url":"https://api.github.com/repos/a-ilango/libfabric/issues/events{/number}","events_url":"https://api.github.com/repos/a-ilango/libfabric/events","assignees_url":"https://api.github.com/repos/a-ilango/libfabric/assignees{/user}","branches_url":"https://api.github.com/repos/a-ilango/libfabric/branches{/branch}","tags_url":"https://api.github.com/repos/a-ilango/libfabric/tags","blobs_url":"https://api.github.com/repos/a-ilango/libfabric/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/a-ilango/libfabric/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/a-ilango/libfabric/git/refs{/sha}","trees_url":"https://api.github.com/repos/a-ilango/libfabric/git/trees{/sha}","statuses_url":"https://api.github.com/repos/a-ilango/libfabric/statuses/{sha}","languages_url":"https://api.github.com/repos/a-ilango/libfabric/languages","stargazers_url":"https://api.github.com/repos/a-ilango/libfabric/stargazers","contributors_url":"https://api.github.com/repos/a-ilango/libfabric/contributors","subscribers_url":"https://api.github.com/repos/a-ilango/libfabric/subscribers","subscription_url":"https://api.github.com/repos/a-ilango/libfabric/subscription","commits_url":"https://api.github.com/repos/a-ilango/libfabric/commits{/sha}","git_commits_url":"https://api.github.com/repos/a-ilango/libfabric/git/commits{/sha}","comments_url":"https://api.github.com/repos/a-ilango/libfabric/comments{/number}","issue_comment_url":"https://api.github.com/repos/a-ilango/libfabric/issues/comments{/number}","contents_url":"https://api.github.com/repos/a-ilango/libfabric/contents/{+path}","compare_url":"https://api.github.com/repos/a-ilango/libfabric/compare/{base}...{head}","merges_url":"https://api.github.com/repos/a-ilango/libfabric/merges","archive_url":"https://api.github.com/repos/a-ilango/libfabric/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/a-ilango/libfabric/downloads","issues_url":"https://api.github.com/repos/a-ilango/libfabric/issues{/number}","pulls_url":"https://api.github.com/repos/a-ilango/libfabric/pulls{/number}","milestones_url":"https://api.github.com/repos/a-ilango/libfabric/milestones{/number}","notifications_url":"https://api.github.com/repos/a-ilango/libfabric/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/a-ilango/libfabric/labels{/name}","releases_url":"https://api.github.com/repos/a-ilango/libfabric/releases{/id}","deployments_url":"https://api.github.com/repos/a-ilango/libfabric/deployments","created_at":"2014-09-29T22:57:04Z","updated_at":"2016-02-23T18:28:22Z","pushed_at":"2018-05-21T21:51:40Z","git_url":"git://github.com/a-ilango/libfabric.git","ssh_url":"git@github.com:a-ilango/libfabric.git","clone_url":"https://github.com/a-ilango/libfabric.git","svn_url":"https://github.com/a-ilango/libfabric","homepage":null,"size":17050,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ofiwg:master","ref":"master","sha":"dc22529c20f5d0ac38328f2ee97b558a5a1ed060","user":{"login":"ofiwg","id":8459445,"avatar_url":"https://avatars1.githubusercontent.com/u/8459445?v=4","gravatar_id":"","url":"https://api.github.com/users/ofiwg","html_url":"https://github.com/ofiwg","followers_url":"https://api.github.com/users/ofiwg/followers","following_url":"https://api.github.com/users/ofiwg/following{/other_user}","gists_url":"https://api.github.com/users/ofiwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ofiwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofiwg/subscriptions","organizations_url":"https://api.github.com/users/ofiwg/orgs","repos_url":"https://api.github.com/users/ofiwg/repos","events_url":"https://api.github.com/users/ofiwg/events{/privacy}","received_events_url":"https://api.github.com/users/ofiwg/received_events","type":"Organization","site_admin":false},"repo":{"id":22996097,"name":"libfabric","full_name":"ofiwg/libfabric","owner":{"login":"ofiwg","id":8459445,"avatar_url":"https://avatars1.githubusercontent.com/u/8459445?v=4","gravatar_id":"","url":"https://api.github.com/users/ofiwg","html_url":"https://github.com/ofiwg","followers_url":"https://api.github.com/users/ofiwg/followers","following_url":"https://api.github.com/users/ofiwg/following{/other_user}","gists_url":"https://api.github.com/users/ofiwg/gists{/gist_id}","starred_url":"https://api.github.com/users/ofiwg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ofiwg/subscriptions","organizations_url":"https://api.github.com/users/ofiwg/orgs","repos_url":"https://api.github.com/users/ofiwg/repos","events_url":"https://api.github.com/users/ofiwg/events{/privacy}","received_events_url":"https://api.github.com/users/ofiwg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ofiwg/libfabric","description":"Open Fabric Interfaces","fork":false,"url":"https://api.github.com/repos/ofiwg/libfabric","forks_url":"https://api.github.com/repos/ofiwg/libfabric/forks","keys_url":"https://api.github.com/repos/ofiwg/libfabric/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ofiwg/libfabric/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ofiwg/libfabric/teams","hooks_url":"https://api.github.com/repos/ofiwg/libfabric/hooks","issue_events_url":"https://api.github.com/repos/ofiwg/libfabric/issues/events{/number}","events_url":"https://api.github.com/repos/ofiwg/libfabric/events","assignees_url":"https://api.github.com/repos/ofiwg/libfabric/assignees{/user}","branches_url":"https://api.github.com/repos/ofiwg/libfabric/branches{/branch}","tags_url":"https://api.github.com/repos/ofiwg/libfabric/tags","blobs_url":"https://api.github.com/repos/ofiwg/libfabric/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ofiwg/libfabric/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ofiwg/libfabric/git/refs{/sha}","trees_url":"https://api.github.com/repos/ofiwg/libfabric/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ofiwg/libfabric/statuses/{sha}","languages_url":"https://api.github.com/repos/ofiwg/libfabric/languages","stargazers_url":"https://api.github.com/repos/ofiwg/libfabric/stargazers","contributors_url":"https://api.github.com/repos/ofiwg/libfabric/contributors","subscribers_url":"https://api.github.com/repos/ofiwg/libfabric/subscribers","subscription_url":"https://api.github.com/repos/ofiwg/libfabric/subscription","commits_url":"https://api.github.com/repos/ofiwg/libfabric/commits{/sha}","git_commits_url":"https://api.github.com/repos/ofiwg/libfabric/git/commits{/sha}","comments_url":"https://api.github.com/repos/ofiwg/libfabric/comments{/number}","issue_comment_url":"https://api.github.com/repos/ofiwg/libfabric/issues/comments{/number}","contents_url":"https://api.github.com/repos/ofiwg/libfabric/contents/{+path}","compare_url":"https://api.github.com/repos/ofiwg/libfabric/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ofiwg/libfabric/merges","archive_url":"https://api.github.com/repos/ofiwg/libfabric/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ofiwg/libfabric/downloads","issues_url":"https://api.github.com/repos/ofiwg/libfabric/issues{/number}","pulls_url":"https://api.github.com/repos/ofiwg/libfabric/pulls{/number}","milestones_url":"https://api.github.com/repos/ofiwg/libfabric/milestones{/number}","notifications_url":"https://api.github.com/repos/ofiwg/libfabric/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ofiwg/libfabric/labels{/name}","releases_url":"https://api.github.com/repos/ofiwg/libfabric/releases{/id}","deployments_url":"https://api.github.com/repos/ofiwg/libfabric/deployments","created_at":"2014-08-15T16:45:53Z","updated_at":"2018-05-21T17:13:40Z","pushed_at":"2018-05-21T21:51:41Z","git_url":"git://github.com/ofiwg/libfabric.git","ssh_url":"git@github.com:ofiwg/libfabric.git","clone_url":"https://github.com/ofiwg/libfabric.git","svn_url":"https://github.com/ofiwg/libfabric","homepage":"http://libfabric.org/","size":18247,"stargazers_count":147,"watchers_count":147,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":134,"mirror_url":null,"archived":false,"open_issues_count":112,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":134,"open_issues":112,"watchers":147,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/4113"},"html":{"href":"https://github.com/ofiwg/libfabric/pull/4113"},"issue":{"href":"https://api.github.com/repos/ofiwg/libfabric/issues/4113"},"comments":{"href":"https://api.github.com/repos/ofiwg/libfabric/issues/4113/comments"},"review_comments":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/4113/comments"},"review_comment":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ofiwg/libfabric/pulls/4113/commits"},"statuses":{"href":"https://api.github.com/repos/ofiwg/libfabric/statuses/8386da18c5bc6413b2803f227e2d27e15faa2347"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"shefty"}}