{"action":"opened","number":4519,"pull_request":{"url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/4519","id":178334928,"html_url":"https://github.com/FreeRDP/FreeRDP/pull/4519","diff_url":"https://github.com/FreeRDP/FreeRDP/pull/4519.diff","patch_url":"https://github.com/FreeRDP/FreeRDP/pull/4519.patch","issue_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/4519","number":4519,"state":"open","locked":false,"title":"cssp: Fix handling of nonce","user":{"login":"mfleisz","id":669070,"avatar_url":"https://avatars1.githubusercontent.com/u/669070?v=4","gravatar_id":"","url":"https://api.github.com/users/mfleisz","html_url":"https://github.com/mfleisz","followers_url":"https://api.github.com/users/mfleisz/followers","following_url":"https://api.github.com/users/mfleisz/following{/other_user}","gists_url":"https://api.github.com/users/mfleisz/gists{/gist_id}","starred_url":"https://api.github.com/users/mfleisz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfleisz/subscriptions","organizations_url":"https://api.github.com/users/mfleisz/orgs","repos_url":"https://api.github.com/users/mfleisz/repos","events_url":"https://api.github.com/users/mfleisz/events{/privacy}","received_events_url":"https://api.github.com/users/mfleisz/received_events","type":"User","site_admin":false},"body":"The nonce must not change during the message exchange.\r\nCurrently the nonce would be newly generated (and leaking memory) if the authentication is performed in more than 1 step.","created_at":"2018-03-29T13:51:27Z","updated_at":"2018-03-29T13:51:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/4519/commits","review_comments_url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/4519/comments","review_comment_url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/4519/comments","statuses_url":"https://api.github.com/repos/FreeRDP/FreeRDP/statuses/7c563a9a106b1f2290b77735c2eb29f6a41a009d","head":{"label":"mfleisz:cssp_nonce_fix","ref":"cssp_nonce_fix","sha":"7c563a9a106b1f2290b77735c2eb29f6a41a009d","user":{"login":"mfleisz","id":669070,"avatar_url":"https://avatars1.githubusercontent.com/u/669070?v=4","gravatar_id":"","url":"https://api.github.com/users/mfleisz","html_url":"https://github.com/mfleisz","followers_url":"https://api.github.com/users/mfleisz/followers","following_url":"https://api.github.com/users/mfleisz/following{/other_user}","gists_url":"https://api.github.com/users/mfleisz/gists{/gist_id}","starred_url":"https://api.github.com/users/mfleisz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfleisz/subscriptions","organizations_url":"https://api.github.com/users/mfleisz/orgs","repos_url":"https://api.github.com/users/mfleisz/repos","events_url":"https://api.github.com/users/mfleisz/events{/privacy}","received_events_url":"https://api.github.com/users/mfleisz/received_events","type":"User","site_admin":false},"repo":{"id":2262047,"name":"FreeRDP","full_name":"mfleisz/FreeRDP","owner":{"login":"mfleisz","id":669070,"avatar_url":"https://avatars1.githubusercontent.com/u/669070?v=4","gravatar_id":"","url":"https://api.github.com/users/mfleisz","html_url":"https://github.com/mfleisz","followers_url":"https://api.github.com/users/mfleisz/followers","following_url":"https://api.github.com/users/mfleisz/following{/other_user}","gists_url":"https://api.github.com/users/mfleisz/gists{/gist_id}","starred_url":"https://api.github.com/users/mfleisz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mfleisz/subscriptions","organizations_url":"https://api.github.com/users/mfleisz/orgs","repos_url":"https://api.github.com/users/mfleisz/repos","events_url":"https://api.github.com/users/mfleisz/events{/privacy}","received_events_url":"https://api.github.com/users/mfleisz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mfleisz/FreeRDP","description":"FreeRDP 1.0","fork":true,"url":"https://api.github.com/repos/mfleisz/FreeRDP","forks_url":"https://api.github.com/repos/mfleisz/FreeRDP/forks","keys_url":"https://api.github.com/repos/mfleisz/FreeRDP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mfleisz/FreeRDP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mfleisz/FreeRDP/teams","hooks_url":"https://api.github.com/repos/mfleisz/FreeRDP/hooks","issue_events_url":"https://api.github.com/repos/mfleisz/FreeRDP/issues/events{/number}","events_url":"https://api.github.com/repos/mfleisz/FreeRDP/events","assignees_url":"https://api.github.com/repos/mfleisz/FreeRDP/assignees{/user}","branches_url":"https://api.github.com/repos/mfleisz/FreeRDP/branches{/branch}","tags_url":"https://api.github.com/repos/mfleisz/FreeRDP/tags","blobs_url":"https://api.github.com/repos/mfleisz/FreeRDP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mfleisz/FreeRDP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mfleisz/FreeRDP/git/refs{/sha}","trees_url":"https://api.github.com/repos/mfleisz/FreeRDP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mfleisz/FreeRDP/statuses/{sha}","languages_url":"https://api.github.com/repos/mfleisz/FreeRDP/languages","stargazers_url":"https://api.github.com/repos/mfleisz/FreeRDP/stargazers","contributors_url":"https://api.github.com/repos/mfleisz/FreeRDP/contributors","subscribers_url":"https://api.github.com/repos/mfleisz/FreeRDP/subscribers","subscription_url":"https://api.github.com/repos/mfleisz/FreeRDP/subscription","commits_url":"https://api.github.com/repos/mfleisz/FreeRDP/commits{/sha}","git_commits_url":"https://api.github.com/repos/mfleisz/FreeRDP/git/commits{/sha}","comments_url":"https://api.github.com/repos/mfleisz/FreeRDP/comments{/number}","issue_comment_url":"https://api.github.com/repos/mfleisz/FreeRDP/issues/comments{/number}","contents_url":"https://api.github.com/repos/mfleisz/FreeRDP/contents/{+path}","compare_url":"https://api.github.com/repos/mfleisz/FreeRDP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mfleisz/FreeRDP/merges","archive_url":"https://api.github.com/repos/mfleisz/FreeRDP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mfleisz/FreeRDP/downloads","issues_url":"https://api.github.com/repos/mfleisz/FreeRDP/issues{/number}","pulls_url":"https://api.github.com/repos/mfleisz/FreeRDP/pulls{/number}","milestones_url":"https://api.github.com/repos/mfleisz/FreeRDP/milestones{/number}","notifications_url":"https://api.github.com/repos/mfleisz/FreeRDP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mfleisz/FreeRDP/labels{/name}","releases_url":"https://api.github.com/repos/mfleisz/FreeRDP/releases{/id}","deployments_url":"https://api.github.com/repos/mfleisz/FreeRDP/deployments","created_at":"2011-08-24T14:28:01Z","updated_at":"2016-10-17T07:32:40Z","pushed_at":"2018-03-29T13:50:29Z","git_url":"git://github.com/mfleisz/FreeRDP.git","ssh_url":"git@github.com:mfleisz/FreeRDP.git","clone_url":"https://github.com/mfleisz/FreeRDP.git","svn_url":"https://github.com/mfleisz/FreeRDP","homepage":"http://www.freerdp.com/","size":34090,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"FreeRDP:master","ref":"master","sha":"a42f6d6aa1baddc393ea49cf01fce0c6bbd44dbd","user":{"login":"FreeRDP","id":663376,"avatar_url":"https://avatars0.githubusercontent.com/u/663376?v=4","gravatar_id":"","url":"https://api.github.com/users/FreeRDP","html_url":"https://github.com/FreeRDP","followers_url":"https://api.github.com/users/FreeRDP/followers","following_url":"https://api.github.com/users/FreeRDP/following{/other_user}","gists_url":"https://api.github.com/users/FreeRDP/gists{/gist_id}","starred_url":"https://api.github.com/users/FreeRDP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreeRDP/subscriptions","organizations_url":"https://api.github.com/users/FreeRDP/orgs","repos_url":"https://api.github.com/users/FreeRDP/repos","events_url":"https://api.github.com/users/FreeRDP/events{/privacy}","received_events_url":"https://api.github.com/users/FreeRDP/received_events","type":"Organization","site_admin":false},"repo":{"id":1979797,"name":"FreeRDP","full_name":"FreeRDP/FreeRDP","owner":{"login":"FreeRDP","id":663376,"avatar_url":"https://avatars0.githubusercontent.com/u/663376?v=4","gravatar_id":"","url":"https://api.github.com/users/FreeRDP","html_url":"https://github.com/FreeRDP","followers_url":"https://api.github.com/users/FreeRDP/followers","following_url":"https://api.github.com/users/FreeRDP/following{/other_user}","gists_url":"https://api.github.com/users/FreeRDP/gists{/gist_id}","starred_url":"https://api.github.com/users/FreeRDP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FreeRDP/subscriptions","organizations_url":"https://api.github.com/users/FreeRDP/orgs","repos_url":"https://api.github.com/users/FreeRDP/repos","events_url":"https://api.github.com/users/FreeRDP/events{/privacy}","received_events_url":"https://api.github.com/users/FreeRDP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FreeRDP/FreeRDP","description":"FreeRDP is a free remote desktop protocol library and clients","fork":false,"url":"https://api.github.com/repos/FreeRDP/FreeRDP","forks_url":"https://api.github.com/repos/FreeRDP/FreeRDP/forks","keys_url":"https://api.github.com/repos/FreeRDP/FreeRDP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FreeRDP/FreeRDP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FreeRDP/FreeRDP/teams","hooks_url":"https://api.github.com/repos/FreeRDP/FreeRDP/hooks","issue_events_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/events{/number}","events_url":"https://api.github.com/repos/FreeRDP/FreeRDP/events","assignees_url":"https://api.github.com/repos/FreeRDP/FreeRDP/assignees{/user}","branches_url":"https://api.github.com/repos/FreeRDP/FreeRDP/branches{/branch}","tags_url":"https://api.github.com/repos/FreeRDP/FreeRDP/tags","blobs_url":"https://api.github.com/repos/FreeRDP/FreeRDP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FreeRDP/FreeRDP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FreeRDP/FreeRDP/git/refs{/sha}","trees_url":"https://api.github.com/repos/FreeRDP/FreeRDP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FreeRDP/FreeRDP/statuses/{sha}","languages_url":"https://api.github.com/repos/FreeRDP/FreeRDP/languages","stargazers_url":"https://api.github.com/repos/FreeRDP/FreeRDP/stargazers","contributors_url":"https://api.github.com/repos/FreeRDP/FreeRDP/contributors","subscribers_url":"https://api.github.com/repos/FreeRDP/FreeRDP/subscribers","subscription_url":"https://api.github.com/repos/FreeRDP/FreeRDP/subscription","commits_url":"https://api.github.com/repos/FreeRDP/FreeRDP/commits{/sha}","git_commits_url":"https://api.github.com/repos/FreeRDP/FreeRDP/git/commits{/sha}","comments_url":"https://api.github.com/repos/FreeRDP/FreeRDP/comments{/number}","issue_comment_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/comments{/number}","contents_url":"https://api.github.com/repos/FreeRDP/FreeRDP/contents/{+path}","compare_url":"https://api.github.com/repos/FreeRDP/FreeRDP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FreeRDP/FreeRDP/merges","archive_url":"https://api.github.com/repos/FreeRDP/FreeRDP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FreeRDP/FreeRDP/downloads","issues_url":"https://api.github.com/repos/FreeRDP/FreeRDP/issues{/number}","pulls_url":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls{/number}","milestones_url":"https://api.github.com/repos/FreeRDP/FreeRDP/milestones{/number}","notifications_url":"https://api.github.com/repos/FreeRDP/FreeRDP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FreeRDP/FreeRDP/labels{/name}","releases_url":"https://api.github.com/repos/FreeRDP/FreeRDP/releases{/id}","deployments_url":"https://api.github.com/repos/FreeRDP/FreeRDP/deployments","created_at":"2011-06-30T19:14:15Z","updated_at":"2018-03-28T07:21:33Z","pushed_at":"2018-03-29T07:13:52Z","git_url":"git://github.com/FreeRDP/FreeRDP.git","ssh_url":"git@github.com:FreeRDP/FreeRDP.git","clone_url":"https://github.com/FreeRDP/FreeRDP.git","svn_url":"https://github.com/FreeRDP/FreeRDP","homepage":"http://www.freerdp.com/","size":34426,"stargazers_count":2279,"watchers_count":2279,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1091,"mirror_url":null,"archived":false,"open_issues_count":495,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1091,"open_issues":495,"watchers":2279,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/4519"},"html":{"href":"https://github.com/FreeRDP/FreeRDP/pull/4519"},"issue":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/4519"},"comments":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/issues/4519/comments"},"review_comments":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/4519/comments"},"review_comment":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/pulls/4519/commits"},"statuses":{"href":"https://api.github.com/repos/FreeRDP/FreeRDP/statuses/7c563a9a106b1f2290b77735c2eb29f6a41a009d"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":17,"deletions":13,"changed_files":1}}
{"actor":{"display_login":"mfleisz"}}