{"action":"created","comment":{"url":"https://api.github.com/repos/heavenshell/vim-jsdoc/pulls/comments/186255234","pull_request_review_id":117806920,"id":186255234,"diff_hunk":"@@ -459,7 +459,11 @@ function! jsdoc#insert() abort\n         if l:arg['type'] != ''\n           let s:candidate_type = l:arg['type']\n         endif\n-        let l:argType = input('Argument \"' . l:arg['val'] . '\" type: ', '', 'custom,jsdoc#listDataTypes')\n+        if s:candidate_type == ''\n+            let l:argType = input('Argument \"' . l:arg['val'] . '\" type: ', '', 'custom,jsdoc#listDataTypes')","path":"autoload/jsdoc.vim","position":6,"original_position":6,"commit_id":"b56c733f355bafb8e6cbf6b2ab39f60dc3dba8e7","original_commit_id":"b56c733f355bafb8e6cbf6b2ab39f60dc3dba8e7","user":{"login":"Edo78","id":3602209,"avatar_url":"https://avatars0.githubusercontent.com/u/3602209?v=4","gravatar_id":"","url":"https://api.github.com/users/Edo78","html_url":"https://github.com/Edo78","followers_url":"https://api.github.com/users/Edo78/followers","following_url":"https://api.github.com/users/Edo78/following{/other_user}","gists_url":"https://api.github.com/users/Edo78/gists{/gist_id}","starred_url":"https://api.github.com/users/Edo78/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Edo78/subscriptions","organizations_url":"https://api.github.com/users/Edo78/orgs","repos_url":"https://api.github.com/users/Edo78/repos","events_url":"https://api.github.com/users/Edo78/events{/privacy}","received_events_url":"https://api.github.com/users/Edo78/received_events","type":"User","site_admin":false},"body":"First things first. This is my first time doing a PR on a vim plugin so I may be wrong.\r\n\r\nMy understanding of my proposal is that the type isn't asked to the user __only__ if it's already provided in the code itself otherwise the plugin __should keep asking__ for the type.\r\n\r\nI can't came up with a scenario where the user write a code defining a type then in the documentation he want to specify a different type. It doesn't make sense to me based on my experience.\r\nI'm not pretending that my use case should be the only one but as far as I'm concerned it's the right one.\r\n\r\nIf my PR doesn't follow this flow then I've done a mistake otherwise it's the right modification to me and I'm using it since I've written it.\r\n\r\nP.S. don't worry and take your time we're not on the clock ;)","created_at":"2018-05-05T07:25:06Z","updated_at":"2018-05-05T07:25:06Z","html_url":"https://github.com/heavenshell/vim-jsdoc/pull/75#discussion_r186255234","pull_request_url":"https://api.github.com/repos/heavenshell/vim-jsdoc/pulls/75","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/heavenshell/vim-jsdoc/pulls/comments/186255234"},"html":{"href":"https://github.com/heavenshell/vim-jsdoc/pull/75#discussion_r186255234"},"pull_request":{"href":"https://api.github.com/repos/heavenshell/vim-jsdoc/pulls/75"}},"in_reply_to_id":186254771},"pull_request":{"url":"https://api.github.com/repos/heavenshell/vim-jsdoc/pulls/75","id":184828043,"html_url":"https://github.com/heavenshell/vim-jsdoc/pull/75","diff_url":"https://github.com/heavenshell/vim-jsdoc/pull/75.diff","patch_url":"https://github.com/heavenshell/vim-jsdoc/pull/75.patch","issue_url":"https://api.github.com/repos/heavenshell/vim-jsdoc/issues/75","number":75,"state":"open","locked":false,"title":"Update jsdoc.vim","user":{"login":"Edo78","id":3602209,"avatar_url":"https://avatars0.githubusercontent.com/u/3602209?v=4","gravatar_id":"","url":"https://api.github.com/users/Edo78","html_url":"https://github.com/Edo78","followers_url":"https://api.github.com/users/Edo78/followers","following_url":"https://api.github.com/users/Edo78/following{/other_user}","gists_url":"https://api.github.com/users/Edo78/gists{/gist_id}","starred_url":"https://api.github.com/users/Edo78/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Edo78/subscriptions","organizations_url":"https://api.github.com/users/Edo78/orgs","repos_url":"https://api.github.com/users/Edo78/repos","events_url":"https://api.github.com/users/Edo78/events{/privacy}","received_events_url":"https://api.github.com/users/Edo78/received_events","type":"User","site_admin":false},"body":"If 's:candidate_type' isn't empty then use it and don't ask the user for the type","created_at":"2018-04-29T10:28:28Z","updated_at":"2018-05-05T07:25:06Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5093a6bc7f4b9bfce9fe7b8df2bfc706d68f3f19","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/heavenshell/vim-jsdoc/pulls/75/commits","review_comments_url":"https://api.github.com/repos/heavenshell/vim-jsdoc/pulls/75/comments","review_comment_url":"https://api.github.com/repos/heavenshell/vim-jsdoc/pulls/comments{/number}","comments_url":"https://api.github.com/repos/heavenshell/vim-jsdoc/issues/75/comments","statuses_url":"https://api.github.com/repos/heavenshell/vim-jsdoc/statuses/b56c733f355bafb8e6cbf6b2ab39f60dc3dba8e7","head":{"label":"Edo78:patch-1","ref":"patch-1","sha":"b56c733f355bafb8e6cbf6b2ab39f60dc3dba8e7","user":{"login":"Edo78","id":3602209,"avatar_url":"https://avatars0.githubusercontent.com/u/3602209?v=4","gravatar_id":"","url":"https://api.github.com/users/Edo78","html_url":"https://github.com/Edo78","followers_url":"https://api.github.com/users/Edo78/followers","following_url":"https://api.github.com/users/Edo78/following{/other_user}","gists_url":"https://api.github.com/users/Edo78/gists{/gist_id}","starred_url":"https://api.github.com/users/Edo78/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Edo78/subscriptions","organizations_url":"https://api.github.com/users/Edo78/orgs","repos_url":"https://api.github.com/users/Edo78/repos","events_url":"https://api.github.com/users/Edo78/events{/privacy}","received_events_url":"https://api.github.com/users/Edo78/received_events","type":"User","site_admin":false},"repo":{"id":131485009,"name":"vim-jsdoc","full_name":"Edo78/vim-jsdoc","owner":{"login":"Edo78","id":3602209,"avatar_url":"https://avatars0.githubusercontent.com/u/3602209?v=4","gravatar_id":"","url":"https://api.github.com/users/Edo78","html_url":"https://github.com/Edo78","followers_url":"https://api.github.com/users/Edo78/followers","following_url":"https://api.github.com/users/Edo78/following{/other_user}","gists_url":"https://api.github.com/users/Edo78/gists{/gist_id}","starred_url":"https://api.github.com/users/Edo78/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Edo78/subscriptions","organizations_url":"https://api.github.com/users/Edo78/orgs","repos_url":"https://api.github.com/users/Edo78/repos","events_url":"https://api.github.com/users/Edo78/events{/privacy}","received_events_url":"https://api.github.com/users/Edo78/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Edo78/vim-jsdoc","description":"Generate JSDoc to your JavaScript code.","fork":true,"url":"https://api.github.com/repos/Edo78/vim-jsdoc","forks_url":"https://api.github.com/repos/Edo78/vim-jsdoc/forks","keys_url":"https://api.github.com/repos/Edo78/vim-jsdoc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Edo78/vim-jsdoc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Edo78/vim-jsdoc/teams","hooks_url":"https://api.github.com/repos/Edo78/vim-jsdoc/hooks","issue_events_url":"https://api.github.com/repos/Edo78/vim-jsdoc/issues/events{/number}","events_url":"https://api.github.com/repos/Edo78/vim-jsdoc/events","assignees_url":"https://api.github.com/repos/Edo78/vim-jsdoc/assignees{/user}","branches_url":"https://api.github.com/repos/Edo78/vim-jsdoc/branches{/branch}","tags_url":"https://api.github.com/repos/Edo78/vim-jsdoc/tags","blobs_url":"https://api.github.com/repos/Edo78/vim-jsdoc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Edo78/vim-jsdoc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Edo78/vim-jsdoc/git/refs{/sha}","trees_url":"https://api.github.com/repos/Edo78/vim-jsdoc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Edo78/vim-jsdoc/statuses/{sha}","languages_url":"https://api.github.com/repos/Edo78/vim-jsdoc/languages","stargazers_url":"https://api.github.com/repos/Edo78/vim-jsdoc/stargazers","contributors_url":"https://api.github.com/repos/Edo78/vim-jsdoc/contributors","subscribers_url":"https://api.github.com/repos/Edo78/vim-jsdoc/subscribers","subscription_url":"https://api.github.com/repos/Edo78/vim-jsdoc/subscription","commits_url":"https://api.github.com/repos/Edo78/vim-jsdoc/commits{/sha}","git_commits_url":"https://api.github.com/repos/Edo78/vim-jsdoc/git/commits{/sha}","comments_url":"https://api.github.com/repos/Edo78/vim-jsdoc/comments{/number}","issue_comment_url":"https://api.github.com/repos/Edo78/vim-jsdoc/issues/comments{/number}","contents_url":"https://api.github.com/repos/Edo78/vim-jsdoc/contents/{+path}","compare_url":"https://api.github.com/repos/Edo78/vim-jsdoc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Edo78/vim-jsdoc/merges","archive_url":"https://api.github.com/repos/Edo78/vim-jsdoc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Edo78/vim-jsdoc/downloads","issues_url":"https://api.github.com/repos/Edo78/vim-jsdoc/issues{/number}","pulls_url":"https://api.github.com/repos/Edo78/vim-jsdoc/pulls{/number}","milestones_url":"https://api.github.com/repos/Edo78/vim-jsdoc/milestones{/number}","notifications_url":"https://api.github.com/repos/Edo78/vim-jsdoc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Edo78/vim-jsdoc/labels{/name}","releases_url":"https://api.github.com/repos/Edo78/vim-jsdoc/releases{/id}","deployments_url":"https://api.github.com/repos/Edo78/vim-jsdoc/deployments","created_at":"2018-04-29T10:25:34Z","updated_at":"2018-04-29T10:25:36Z","pushed_at":"2018-04-29T10:28:06Z","git_url":"git://github.com/Edo78/vim-jsdoc.git","ssh_url":"git@github.com:Edo78/vim-jsdoc.git","clone_url":"https://github.com/Edo78/vim-jsdoc.git","svn_url":"https://github.com/Edo78/vim-jsdoc","homepage":"","size":542,"stargazers_count":0,"watchers_count":0,"language":"Vim script","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"heavenshell:master","ref":"master","sha":"a164cb4c14b9063e82b6ccba96b4bc8b3a6d8f73","user":{"login":"heavenshell","id":56591,"avatar_url":"https://avatars1.githubusercontent.com/u/56591?v=4","gravatar_id":"","url":"https://api.github.com/users/heavenshell","html_url":"https://github.com/heavenshell","followers_url":"https://api.github.com/users/heavenshell/followers","following_url":"https://api.github.com/users/heavenshell/following{/other_user}","gists_url":"https://api.github.com/users/heavenshell/gists{/gist_id}","starred_url":"https://api.github.com/users/heavenshell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heavenshell/subscriptions","organizations_url":"https://api.github.com/users/heavenshell/orgs","repos_url":"https://api.github.com/users/heavenshell/repos","events_url":"https://api.github.com/users/heavenshell/events{/privacy}","received_events_url":"https://api.github.com/users/heavenshell/received_events","type":"User","site_admin":false},"repo":{"id":7668051,"name":"vim-jsdoc","full_name":"heavenshell/vim-jsdoc","owner":{"login":"heavenshell","id":56591,"avatar_url":"https://avatars1.githubusercontent.com/u/56591?v=4","gravatar_id":"","url":"https://api.github.com/users/heavenshell","html_url":"https://github.com/heavenshell","followers_url":"https://api.github.com/users/heavenshell/followers","following_url":"https://api.github.com/users/heavenshell/following{/other_user}","gists_url":"https://api.github.com/users/heavenshell/gists{/gist_id}","starred_url":"https://api.github.com/users/heavenshell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/heavenshell/subscriptions","organizations_url":"https://api.github.com/users/heavenshell/orgs","repos_url":"https://api.github.com/users/heavenshell/repos","events_url":"https://api.github.com/users/heavenshell/events{/privacy}","received_events_url":"https://api.github.com/users/heavenshell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/heavenshell/vim-jsdoc","description":"Generate JSDoc to your JavaScript code.","fork":false,"url":"https://api.github.com/repos/heavenshell/vim-jsdoc","forks_url":"https://api.github.com/repos/heavenshell/vim-jsdoc/forks","keys_url":"https://api.github.com/repos/heavenshell/vim-jsdoc/keys{/key_id}","collaborators_url":"https://api.github.com/repos/heavenshell/vim-jsdoc/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/heavenshell/vim-jsdoc/teams","hooks_url":"https://api.github.com/repos/heavenshell/vim-jsdoc/hooks","issue_events_url":"https://api.github.com/repos/heavenshell/vim-jsdoc/issues/events{/number}","events_url":"https://api.github.com/repos/heavenshell/vim-jsdoc/events","assignees_url":"https://api.github.com/repos/heavenshell/vim-jsdoc/assignees{/user}","branches_url":"https://api.github.com/repos/heavenshell/vim-jsdoc/branches{/branch}","tags_url":"https://api.github.com/repos/heavenshell/vim-jsdoc/tags","blobs_url":"https://api.github.com/repos/heavenshell/vim-jsdoc/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/heavenshell/vim-jsdoc/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/heavenshell/vim-jsdoc/git/refs{/sha}","trees_url":"https://api.github.com/repos/heavenshell/vim-jsdoc/git/trees{/sha}","statuses_url":"https://api.github.com/repos/heavenshell/vim-jsdoc/statuses/{sha}","languages_url":"https://api.github.com/repos/heavenshell/vim-jsdoc/languages","stargazers_url":"https://api.github.com/repos/heavenshell/vim-jsdoc/stargazers","contributors_url":"https://api.github.com/repos/heavenshell/vim-jsdoc/contributors","subscribers_url":"https://api.github.com/repos/heavenshell/vim-jsdoc/subscribers","subscription_url":"https://api.github.com/repos/heavenshell/vim-jsdoc/subscription","commits_url":"https://api.github.com/repos/heavenshell/vim-jsdoc/commits{/sha}","git_commits_url":"https://api.github.com/repos/heavenshell/vim-jsdoc/git/commits{/sha}","comments_url":"https://api.github.com/repos/heavenshell/vim-jsdoc/comments{/number}","issue_comment_url":"https://api.github.com/repos/heavenshell/vim-jsdoc/issues/comments{/number}","contents_url":"https://api.github.com/repos/heavenshell/vim-jsdoc/contents/{+path}","compare_url":"https://api.github.com/repos/heavenshell/vim-jsdoc/compare/{base}...{head}","merges_url":"https://api.github.com/repos/heavenshell/vim-jsdoc/merges","archive_url":"https://api.github.com/repos/heavenshell/vim-jsdoc/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/heavenshell/vim-jsdoc/downloads","issues_url":"https://api.github.com/repos/heavenshell/vim-jsdoc/issues{/number}","pulls_url":"https://api.github.com/repos/heavenshell/vim-jsdoc/pulls{/number}","milestones_url":"https://api.github.com/repos/heavenshell/vim-jsdoc/milestones{/number}","notifications_url":"https://api.github.com/repos/heavenshell/vim-jsdoc/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/heavenshell/vim-jsdoc/labels{/name}","releases_url":"https://api.github.com/repos/heavenshell/vim-jsdoc/releases{/id}","deployments_url":"https://api.github.com/repos/heavenshell/vim-jsdoc/deployments","created_at":"2013-01-17T14:55:33Z","updated_at":"2018-05-05T06:59:01Z","pushed_at":"2018-05-05T06:58:59Z","git_url":"git://github.com/heavenshell/vim-jsdoc.git","ssh_url":"git@github.com:heavenshell/vim-jsdoc.git","clone_url":"https://github.com/heavenshell/vim-jsdoc.git","svn_url":"https://github.com/heavenshell/vim-jsdoc","homepage":"","size":531,"stargazers_count":294,"watchers_count":294,"language":"Vim script","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":37,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":37,"open_issues":4,"watchers":294,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/heavenshell/vim-jsdoc/pulls/75"},"html":{"href":"https://github.com/heavenshell/vim-jsdoc/pull/75"},"issue":{"href":"https://api.github.com/repos/heavenshell/vim-jsdoc/issues/75"},"comments":{"href":"https://api.github.com/repos/heavenshell/vim-jsdoc/issues/75/comments"},"review_comments":{"href":"https://api.github.com/repos/heavenshell/vim-jsdoc/pulls/75/comments"},"review_comment":{"href":"https://api.github.com/repos/heavenshell/vim-jsdoc/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/heavenshell/vim-jsdoc/pulls/75/commits"},"statuses":{"href":"https://api.github.com/repos/heavenshell/vim-jsdoc/statuses/b56c733f355bafb8e6cbf6b2ab39f60dc3dba8e7"}},"author_association":"NONE"}}
{"actor":{"display_login":"Edo78"}}