{"action":"created","issue":{"url":"https://api.github.com/repos/ankane/strong_migrations/issues/53","repository_url":"https://api.github.com/repos/ankane/strong_migrations","labels_url":"https://api.github.com/repos/ankane/strong_migrations/issues/53/labels{/name}","comments_url":"https://api.github.com/repos/ankane/strong_migrations/issues/53/comments","events_url":"https://api.github.com/repos/ankane/strong_migrations/issues/53/events","html_url":"https://github.com/ankane/strong_migrations/issues/53","id":371536565,"node_id":"MDU6SXNzdWUzNzE1MzY1NjU=","number":53,"title":"[Idea] drop_table as a dangerous operation?","user":{"login":"aldesantis","id":395073,"node_id":"MDQ6VXNlcjM5NTA3Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/395073?v=4","gravatar_id":"","url":"https://api.github.com/users/aldesantis","html_url":"https://github.com/aldesantis","followers_url":"https://api.github.com/users/aldesantis/followers","following_url":"https://api.github.com/users/aldesantis/following{/other_user}","gists_url":"https://api.github.com/users/aldesantis/gists{/gist_id}","starred_url":"https://api.github.com/users/aldesantis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aldesantis/subscriptions","organizations_url":"https://api.github.com/users/aldesantis/orgs","repos_url":"https://api.github.com/users/aldesantis/repos","events_url":"https://api.github.com/users/aldesantis/events{/privacy}","received_events_url":"https://api.github.com/users/aldesantis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-18T13:41:35Z","updated_at":"2018-10-18T18:07:39Z","closed_at":null,"author_association":"NONE","body":"I know this was also mentioned briefly in #49, but I think `drop_table` should be included in the list of dangerous operations. When a `drop_table` call is detected, we could recommend that the user first removes any code that uses the table and then  deploys the migration separately.\r\n\r\nI've just been bit by this (I dropped a table that was still used by the rest of the servers and the load balancer kicked them all out) and it would have been really useful to have strong_migrations warn me about it."},"comment":{"url":"https://api.github.com/repos/ankane/strong_migrations/issues/comments/431107625","html_url":"https://github.com/ankane/strong_migrations/issues/53#issuecomment-431107625","issue_url":"https://api.github.com/repos/ankane/strong_migrations/issues/53","id":431107625,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMTEwNzYyNQ==","user":{"login":"ankane","id":220358,"node_id":"MDQ6VXNlcjIyMDM1OA==","avatar_url":"https://avatars3.githubusercontent.com/u/220358?v=4","gravatar_id":"","url":"https://api.github.com/users/ankane","html_url":"https://github.com/ankane","followers_url":"https://api.github.com/users/ankane/followers","following_url":"https://api.github.com/users/ankane/following{/other_user}","gists_url":"https://api.github.com/users/ankane/gists{/gist_id}","starred_url":"https://api.github.com/users/ankane/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ankane/subscriptions","organizations_url":"https://api.github.com/users/ankane/orgs","repos_url":"https://api.github.com/users/ankane/repos","events_url":"https://api.github.com/users/ankane/events{/privacy}","received_events_url":"https://api.github.com/users/ankane/received_events","type":"User","site_admin":false},"created_at":"2018-10-18T18:07:39Z","updated_at":"2018-10-18T18:07:39Z","author_association":"OWNER","body":"Hey @aldesantis, thanks for the suggestion, but still have the same thoughts as in #49. `remove_column` is dangerous because even if you don't have app code that depends on it, it'll cause issues. You use custom checks to implement this yourself if desired."}}
{"actor":{"display_login":"ankane"}}