{"action":"closed","number":5492,"pull_request":{"url":"https://api.github.com/repos/ipfs/go-ipfs/pulls/5492","id":216786392,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2Nzg2Mzky","html_url":"https://github.com/ipfs/go-ipfs/pull/5492","diff_url":"https://github.com/ipfs/go-ipfs/pull/5492.diff","patch_url":"https://github.com/ipfs/go-ipfs/pull/5492.patch","issue_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/5492","number":5492,"state":"closed","locked":false,"title":"Cleanup instances of manual resolver construction","user":{"login":"magik6k","id":3867941,"node_id":"MDQ6VXNlcjM4Njc5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/3867941?v=4","gravatar_id":"","url":"https://api.github.com/users/magik6k","html_url":"https://github.com/magik6k","followers_url":"https://api.github.com/users/magik6k/followers","following_url":"https://api.github.com/users/magik6k/following{/other_user}","gists_url":"https://api.github.com/users/magik6k/gists{/gist_id}","starred_url":"https://api.github.com/users/magik6k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magik6k/subscriptions","organizations_url":"https://api.github.com/users/magik6k/orgs","repos_url":"https://api.github.com/users/magik6k/repos","events_url":"https://api.github.com/users/magik6k/events{/privacy}","received_events_url":"https://api.github.com/users/magik6k/received_events","type":"User","site_admin":false},"body":"Part of https://github.com/ipfs/go-ipfs/issues/5491\r\n\r\nGiven how messy and all-over-the-place this PR is, I'd rather keep it small. This only cleans up places which constructed their own resolver. I'll take care of the other parts, which use `node.Resolver` in next PR","created_at":"2018-09-19T21:45:49Z","updated_at":"2018-10-02T17:08:59Z","closed_at":"2018-10-02T17:08:59Z","merged_at":"2018-10-02T17:08:59Z","merge_commit_sha":"49bb9fba2ae9333b39ac14d2b73ab7b8d04b4126","assignee":{"login":"magik6k","id":3867941,"node_id":"MDQ6VXNlcjM4Njc5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/3867941?v=4","gravatar_id":"","url":"https://api.github.com/users/magik6k","html_url":"https://github.com/magik6k","followers_url":"https://api.github.com/users/magik6k/followers","following_url":"https://api.github.com/users/magik6k/following{/other_user}","gists_url":"https://api.github.com/users/magik6k/gists{/gist_id}","starred_url":"https://api.github.com/users/magik6k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magik6k/subscriptions","organizations_url":"https://api.github.com/users/magik6k/orgs","repos_url":"https://api.github.com/users/magik6k/repos","events_url":"https://api.github.com/users/magik6k/events{/privacy}","received_events_url":"https://api.github.com/users/magik6k/received_events","type":"User","site_admin":false},"assignees":[{"login":"magik6k","id":3867941,"node_id":"MDQ6VXNlcjM4Njc5NDE=","avatar_url":"https://avatars0.githubusercontent.com/u/3867941?v=4","gravatar_id":"","url":"https://api.github.com/users/magik6k","html_url":"https://github.com/magik6k","followers_url":"https://api.github.com/users/magik6k/followers","following_url":"https://api.github.com/users/magik6k/following{/other_user}","gists_url":"https://api.github.com/users/magik6k/gists{/gist_id}","starred_url":"https://api.github.com/users/magik6k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magik6k/subscriptions","organizations_url":"https://api.github.com/users/magik6k/orgs","repos_url":"https://api.github.com/users/magik6k/repos","events_url":"https://api.github.com/users/magik6k/events{/privacy}","received_events_url":"https://api.github.com/users/magik6k/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"Kubuxu","id":2259282,"node_id":"MDQ6VXNlcjIyNTkyODI=","avatar_url":"https://avatars3.githubusercontent.com/u/2259282?v=4","gravatar_id":"","url":"https://api.github.com/users/Kubuxu","html_url":"https://github.com/Kubuxu","followers_url":"https://api.github.com/users/Kubuxu/followers","following_url":"https://api.github.com/users/Kubuxu/following{/other_user}","gists_url":"https://api.github.com/users/Kubuxu/gists{/gist_id}","starred_url":"https://api.github.com/users/Kubuxu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kubuxu/subscriptions","organizations_url":"https://api.github.com/users/Kubuxu/orgs","repos_url":"https://api.github.com/users/Kubuxu/repos","events_url":"https://api.github.com/users/Kubuxu/events{/privacy}","received_events_url":"https://api.github.com/users/Kubuxu/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":435210197,"node_id":"MDU6TGFiZWw0MzUyMTAxOTc=","url":"https://api.github.com/repos/ipfs/go-ipfs/labels/core-api","name":"core-api","color":"1d76db","default":false},{"id":129070658,"node_id":"MDU6TGFiZWwxMjkwNzA2NTg=","url":"https://api.github.com/repos/ipfs/go-ipfs/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ipfs/go-ipfs/pulls/5492/commits","review_comments_url":"https://api.github.com/repos/ipfs/go-ipfs/pulls/5492/comments","review_comment_url":"https://api.github.com/repos/ipfs/go-ipfs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/5492/comments","statuses_url":"https://api.github.com/repos/ipfs/go-ipfs/statuses/1ed555b87f3d933bd3e234d083168254bf6f309d","head":{"label":"ipfs:feat/unify-resolving","ref":"feat/unify-resolving","sha":"1ed555b87f3d933bd3e234d083168254bf6f309d","user":{"login":"ipfs","id":10536621,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTM2NjIx","avatar_url":"https://avatars0.githubusercontent.com/u/10536621?v=4","gravatar_id":"","url":"https://api.github.com/users/ipfs","html_url":"https://github.com/ipfs","followers_url":"https://api.github.com/users/ipfs/followers","following_url":"https://api.github.com/users/ipfs/following{/other_user}","gists_url":"https://api.github.com/users/ipfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ipfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipfs/subscriptions","organizations_url":"https://api.github.com/users/ipfs/orgs","repos_url":"https://api.github.com/users/ipfs/repos","events_url":"https://api.github.com/users/ipfs/events{/privacy}","received_events_url":"https://api.github.com/users/ipfs/received_events","type":"Organization","site_admin":false},"repo":{"id":21233191,"node_id":"MDEwOlJlcG9zaXRvcnkyMTIzMzE5MQ==","name":"go-ipfs","full_name":"ipfs/go-ipfs","private":false,"owner":{"login":"ipfs","id":10536621,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTM2NjIx","avatar_url":"https://avatars0.githubusercontent.com/u/10536621?v=4","gravatar_id":"","url":"https://api.github.com/users/ipfs","html_url":"https://github.com/ipfs","followers_url":"https://api.github.com/users/ipfs/followers","following_url":"https://api.github.com/users/ipfs/following{/other_user}","gists_url":"https://api.github.com/users/ipfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ipfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipfs/subscriptions","organizations_url":"https://api.github.com/users/ipfs/orgs","repos_url":"https://api.github.com/users/ipfs/repos","events_url":"https://api.github.com/users/ipfs/events{/privacy}","received_events_url":"https://api.github.com/users/ipfs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ipfs/go-ipfs","description":"IPFS implementation in Go","fork":false,"url":"https://api.github.com/repos/ipfs/go-ipfs","forks_url":"https://api.github.com/repos/ipfs/go-ipfs/forks","keys_url":"https://api.github.com/repos/ipfs/go-ipfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ipfs/go-ipfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ipfs/go-ipfs/teams","hooks_url":"https://api.github.com/repos/ipfs/go-ipfs/hooks","issue_events_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/events{/number}","events_url":"https://api.github.com/repos/ipfs/go-ipfs/events","assignees_url":"https://api.github.com/repos/ipfs/go-ipfs/assignees{/user}","branches_url":"https://api.github.com/repos/ipfs/go-ipfs/branches{/branch}","tags_url":"https://api.github.com/repos/ipfs/go-ipfs/tags","blobs_url":"https://api.github.com/repos/ipfs/go-ipfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ipfs/go-ipfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ipfs/go-ipfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ipfs/go-ipfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ipfs/go-ipfs/statuses/{sha}","languages_url":"https://api.github.com/repos/ipfs/go-ipfs/languages","stargazers_url":"https://api.github.com/repos/ipfs/go-ipfs/stargazers","contributors_url":"https://api.github.com/repos/ipfs/go-ipfs/contributors","subscribers_url":"https://api.github.com/repos/ipfs/go-ipfs/subscribers","subscription_url":"https://api.github.com/repos/ipfs/go-ipfs/subscription","commits_url":"https://api.github.com/repos/ipfs/go-ipfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ipfs/go-ipfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ipfs/go-ipfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ipfs/go-ipfs/contents/{+path}","compare_url":"https://api.github.com/repos/ipfs/go-ipfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ipfs/go-ipfs/merges","archive_url":"https://api.github.com/repos/ipfs/go-ipfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ipfs/go-ipfs/downloads","issues_url":"https://api.github.com/repos/ipfs/go-ipfs/issues{/number}","pulls_url":"https://api.github.com/repos/ipfs/go-ipfs/pulls{/number}","milestones_url":"https://api.github.com/repos/ipfs/go-ipfs/milestones{/number}","notifications_url":"https://api.github.com/repos/ipfs/go-ipfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ipfs/go-ipfs/labels{/name}","releases_url":"https://api.github.com/repos/ipfs/go-ipfs/releases{/id}","deployments_url":"https://api.github.com/repos/ipfs/go-ipfs/deployments","created_at":"2014-06-26T08:14:34Z","updated_at":"2018-10-02T14:18:33Z","pushed_at":"2018-10-02T17:08:59Z","git_url":"git://github.com/ipfs/go-ipfs.git","ssh_url":"git@github.com:ipfs/go-ipfs.git","clone_url":"https://github.com/ipfs/go-ipfs.git","svn_url":"https://github.com/ipfs/go-ipfs","homepage":"https://ipfs.io","size":33064,"stargazers_count":6724,"watchers_count":6724,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1207,"mirror_url":null,"archived":false,"open_issues_count":1060,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1207,"open_issues":1060,"watchers":6724,"default_branch":"master"}},"base":{"label":"ipfs:master","ref":"master","sha":"e93aa25e9746894700886ce4213d5ac423f85758","user":{"login":"ipfs","id":10536621,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTM2NjIx","avatar_url":"https://avatars0.githubusercontent.com/u/10536621?v=4","gravatar_id":"","url":"https://api.github.com/users/ipfs","html_url":"https://github.com/ipfs","followers_url":"https://api.github.com/users/ipfs/followers","following_url":"https://api.github.com/users/ipfs/following{/other_user}","gists_url":"https://api.github.com/users/ipfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ipfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipfs/subscriptions","organizations_url":"https://api.github.com/users/ipfs/orgs","repos_url":"https://api.github.com/users/ipfs/repos","events_url":"https://api.github.com/users/ipfs/events{/privacy}","received_events_url":"https://api.github.com/users/ipfs/received_events","type":"Organization","site_admin":false},"repo":{"id":21233191,"node_id":"MDEwOlJlcG9zaXRvcnkyMTIzMzE5MQ==","name":"go-ipfs","full_name":"ipfs/go-ipfs","private":false,"owner":{"login":"ipfs","id":10536621,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTM2NjIx","avatar_url":"https://avatars0.githubusercontent.com/u/10536621?v=4","gravatar_id":"","url":"https://api.github.com/users/ipfs","html_url":"https://github.com/ipfs","followers_url":"https://api.github.com/users/ipfs/followers","following_url":"https://api.github.com/users/ipfs/following{/other_user}","gists_url":"https://api.github.com/users/ipfs/gists{/gist_id}","starred_url":"https://api.github.com/users/ipfs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ipfs/subscriptions","organizations_url":"https://api.github.com/users/ipfs/orgs","repos_url":"https://api.github.com/users/ipfs/repos","events_url":"https://api.github.com/users/ipfs/events{/privacy}","received_events_url":"https://api.github.com/users/ipfs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ipfs/go-ipfs","description":"IPFS implementation in Go","fork":false,"url":"https://api.github.com/repos/ipfs/go-ipfs","forks_url":"https://api.github.com/repos/ipfs/go-ipfs/forks","keys_url":"https://api.github.com/repos/ipfs/go-ipfs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ipfs/go-ipfs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ipfs/go-ipfs/teams","hooks_url":"https://api.github.com/repos/ipfs/go-ipfs/hooks","issue_events_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/events{/number}","events_url":"https://api.github.com/repos/ipfs/go-ipfs/events","assignees_url":"https://api.github.com/repos/ipfs/go-ipfs/assignees{/user}","branches_url":"https://api.github.com/repos/ipfs/go-ipfs/branches{/branch}","tags_url":"https://api.github.com/repos/ipfs/go-ipfs/tags","blobs_url":"https://api.github.com/repos/ipfs/go-ipfs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ipfs/go-ipfs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ipfs/go-ipfs/git/refs{/sha}","trees_url":"https://api.github.com/repos/ipfs/go-ipfs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ipfs/go-ipfs/statuses/{sha}","languages_url":"https://api.github.com/repos/ipfs/go-ipfs/languages","stargazers_url":"https://api.github.com/repos/ipfs/go-ipfs/stargazers","contributors_url":"https://api.github.com/repos/ipfs/go-ipfs/contributors","subscribers_url":"https://api.github.com/repos/ipfs/go-ipfs/subscribers","subscription_url":"https://api.github.com/repos/ipfs/go-ipfs/subscription","commits_url":"https://api.github.com/repos/ipfs/go-ipfs/commits{/sha}","git_commits_url":"https://api.github.com/repos/ipfs/go-ipfs/git/commits{/sha}","comments_url":"https://api.github.com/repos/ipfs/go-ipfs/comments{/number}","issue_comment_url":"https://api.github.com/repos/ipfs/go-ipfs/issues/comments{/number}","contents_url":"https://api.github.com/repos/ipfs/go-ipfs/contents/{+path}","compare_url":"https://api.github.com/repos/ipfs/go-ipfs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ipfs/go-ipfs/merges","archive_url":"https://api.github.com/repos/ipfs/go-ipfs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ipfs/go-ipfs/downloads","issues_url":"https://api.github.com/repos/ipfs/go-ipfs/issues{/number}","pulls_url":"https://api.github.com/repos/ipfs/go-ipfs/pulls{/number}","milestones_url":"https://api.github.com/repos/ipfs/go-ipfs/milestones{/number}","notifications_url":"https://api.github.com/repos/ipfs/go-ipfs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ipfs/go-ipfs/labels{/name}","releases_url":"https://api.github.com/repos/ipfs/go-ipfs/releases{/id}","deployments_url":"https://api.github.com/repos/ipfs/go-ipfs/deployments","created_at":"2014-06-26T08:14:34Z","updated_at":"2018-10-02T14:18:33Z","pushed_at":"2018-10-02T17:08:59Z","git_url":"git://github.com/ipfs/go-ipfs.git","ssh_url":"git@github.com:ipfs/go-ipfs.git","clone_url":"https://github.com/ipfs/go-ipfs.git","svn_url":"https://github.com/ipfs/go-ipfs","homepage":"https://ipfs.io","size":33064,"stargazers_count":6724,"watchers_count":6724,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1207,"mirror_url":null,"archived":false,"open_issues_count":1060,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1207,"open_issues":1060,"watchers":6724,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ipfs/go-ipfs/pulls/5492"},"html":{"href":"https://github.com/ipfs/go-ipfs/pull/5492"},"issue":{"href":"https://api.github.com/repos/ipfs/go-ipfs/issues/5492"},"comments":{"href":"https://api.github.com/repos/ipfs/go-ipfs/issues/5492/comments"},"review_comments":{"href":"https://api.github.com/repos/ipfs/go-ipfs/pulls/5492/comments"},"review_comment":{"href":"https://api.github.com/repos/ipfs/go-ipfs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ipfs/go-ipfs/pulls/5492/commits"},"statuses":{"href":"https://api.github.com/repos/ipfs/go-ipfs/statuses/1ed555b87f3d933bd3e234d083168254bf6f309d"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"Stebalien","id":310393,"node_id":"MDQ6VXNlcjMxMDM5Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/310393?v=4","gravatar_id":"","url":"https://api.github.com/users/Stebalien","html_url":"https://github.com/Stebalien","followers_url":"https://api.github.com/users/Stebalien/followers","following_url":"https://api.github.com/users/Stebalien/following{/other_user}","gists_url":"https://api.github.com/users/Stebalien/gists{/gist_id}","starred_url":"https://api.github.com/users/Stebalien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Stebalien/subscriptions","organizations_url":"https://api.github.com/users/Stebalien/orgs","repos_url":"https://api.github.com/users/Stebalien/repos","events_url":"https://api.github.com/users/Stebalien/events{/privacy}","received_events_url":"https://api.github.com/users/Stebalien/received_events","type":"User","site_admin":false},"comments":2,"review_comments":2,"maintainer_can_modify":false,"commits":1,"additions":170,"deletions":190,"changed_files":14}}
{"actor":{"display_login":"Stebalien"}}