{"action":"created","comment":{"url":"https://api.github.com/repos/mozilla/release-services/pulls/comments/213238329","pull_request_review_id":150031043,"id":213238329,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzIzODMyOQ==","diff_hunk":"@@ -74,7 +74,6 @@ in gecko.overrideDerivation (old: {\n     # Build custom mozconfig\n     mozconfig=$out/conf/mozconfig\n     echo > $mozconfig \"\n-    ac_add_options --enable-clang-plugin\n     ac_add_options --enable-debug\n     ac_add_options --with-clang-path=${clang_4}/bin/clang\n     ac_add_options --with-libclang-path=${llvmPackages_4.libclang}/lib","path":"nix/gecko_env.nix","position":7,"original_position":7,"commit_id":"2676f8e817b5f9d1a8be288d4b59243af4d52f55","original_commit_id":"2676f8e817b5f9d1a8be288d4b59243af4d52f55","user":{"login":"marco-c","id":1616846,"node_id":"MDQ6VXNlcjE2MTY4NDY=","avatar_url":"https://avatars1.githubusercontent.com/u/1616846?v=4","gravatar_id":"","url":"https://api.github.com/users/marco-c","html_url":"https://github.com/marco-c","followers_url":"https://api.github.com/users/marco-c/followers","following_url":"https://api.github.com/users/marco-c/following{/other_user}","gists_url":"https://api.github.com/users/marco-c/gists{/gist_id}","starred_url":"https://api.github.com/users/marco-c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marco-c/subscriptions","organizations_url":"https://api.github.com/users/marco-c/orgs","repos_url":"https://api.github.com/users/marco-c/repos","events_url":"https://api.github.com/users/marco-c/events{/privacy}","received_events_url":"https://api.github.com/users/marco-c/received_events","type":"User","site_admin":false},"body":"Yes, separate PR is better!","created_at":"2018-08-28T09:12:26Z","updated_at":"2018-08-28T09:12:26Z","html_url":"https://github.com/mozilla/release-services/pull/1434#discussion_r213238329","pull_request_url":"https://api.github.com/repos/mozilla/release-services/pulls/1434","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mozilla/release-services/pulls/comments/213238329"},"html":{"href":"https://github.com/mozilla/release-services/pull/1434#discussion_r213238329"},"pull_request":{"href":"https://api.github.com/repos/mozilla/release-services/pulls/1434"}},"in_reply_to_id":213235336},"pull_request":{"url":"https://api.github.com/repos/mozilla/release-services/pulls/1434","id":211349533,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMzQ5NTMz","html_url":"https://github.com/mozilla/release-services/pull/1434","diff_url":"https://github.com/mozilla/release-services/pull/1434.diff","patch_url":"https://github.com/mozilla/release-services/pull/1434.patch","issue_url":"https://api.github.com/repos/mozilla/release-services/issues/1434","number":1434,"state":"open","locked":false,"title":"Don't enable clang-plugin in static-analysis environment.","user":{"login":"abpostelnicu","id":11473159,"node_id":"MDQ6VXNlcjExNDczMTU5","avatar_url":"https://avatars1.githubusercontent.com/u/11473159?v=4","gravatar_id":"","url":"https://api.github.com/users/abpostelnicu","html_url":"https://github.com/abpostelnicu","followers_url":"https://api.github.com/users/abpostelnicu/followers","following_url":"https://api.github.com/users/abpostelnicu/following{/other_user}","gists_url":"https://api.github.com/users/abpostelnicu/gists{/gist_id}","starred_url":"https://api.github.com/users/abpostelnicu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abpostelnicu/subscriptions","organizations_url":"https://api.github.com/users/abpostelnicu/orgs","repos_url":"https://api.github.com/users/abpostelnicu/repos","events_url":"https://api.github.com/users/abpostelnicu/events{/privacy}","received_events_url":"https://api.github.com/users/abpostelnicu/received_events","type":"User","site_admin":false},"body":"We don’t need to enable clang-plugin in our environment, having it\nenabled creates extra work for the configuration process and builds\nclang-plugin .so that is not used since we don’t perform an actual\nbuild.","created_at":"2018-08-28T09:01:10Z","updated_at":"2018-08-28T09:12:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f249dbb472d818d77d205a4588698fe1df5ec62","assignee":null,"assignees":[],"requested_reviewers":[{"login":"garbas","id":20208,"node_id":"MDQ6VXNlcjIwMjA4","avatar_url":"https://avatars0.githubusercontent.com/u/20208?v=4","gravatar_id":"","url":"https://api.github.com/users/garbas","html_url":"https://github.com/garbas","followers_url":"https://api.github.com/users/garbas/followers","following_url":"https://api.github.com/users/garbas/following{/other_user}","gists_url":"https://api.github.com/users/garbas/gists{/gist_id}","starred_url":"https://api.github.com/users/garbas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garbas/subscriptions","organizations_url":"https://api.github.com/users/garbas/orgs","repos_url":"https://api.github.com/users/garbas/repos","events_url":"https://api.github.com/users/garbas/events{/privacy}","received_events_url":"https://api.github.com/users/garbas/received_events","type":"User","site_admin":false},{"login":"La0","id":101004,"node_id":"MDQ6VXNlcjEwMTAwNA==","avatar_url":"https://avatars3.githubusercontent.com/u/101004?v=4","gravatar_id":"","url":"https://api.github.com/users/La0","html_url":"https://github.com/La0","followers_url":"https://api.github.com/users/La0/followers","following_url":"https://api.github.com/users/La0/following{/other_user}","gists_url":"https://api.github.com/users/La0/gists{/gist_id}","starred_url":"https://api.github.com/users/La0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/La0/subscriptions","organizations_url":"https://api.github.com/users/La0/orgs","repos_url":"https://api.github.com/users/La0/repos","events_url":"https://api.github.com/users/La0/events{/privacy}","received_events_url":"https://api.github.com/users/La0/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mozilla/release-services/pulls/1434/commits","review_comments_url":"https://api.github.com/repos/mozilla/release-services/pulls/1434/comments","review_comment_url":"https://api.github.com/repos/mozilla/release-services/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mozilla/release-services/issues/1434/comments","statuses_url":"https://api.github.com/repos/mozilla/release-services/statuses/2676f8e817b5f9d1a8be288d4b59243af4d52f55","head":{"label":"abpostelnicu:master","ref":"master","sha":"2676f8e817b5f9d1a8be288d4b59243af4d52f55","user":{"login":"abpostelnicu","id":11473159,"node_id":"MDQ6VXNlcjExNDczMTU5","avatar_url":"https://avatars1.githubusercontent.com/u/11473159?v=4","gravatar_id":"","url":"https://api.github.com/users/abpostelnicu","html_url":"https://github.com/abpostelnicu","followers_url":"https://api.github.com/users/abpostelnicu/followers","following_url":"https://api.github.com/users/abpostelnicu/following{/other_user}","gists_url":"https://api.github.com/users/abpostelnicu/gists{/gist_id}","starred_url":"https://api.github.com/users/abpostelnicu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abpostelnicu/subscriptions","organizations_url":"https://api.github.com/users/abpostelnicu/orgs","repos_url":"https://api.github.com/users/abpostelnicu/repos","events_url":"https://api.github.com/users/abpostelnicu/events{/privacy}","received_events_url":"https://api.github.com/users/abpostelnicu/received_events","type":"User","site_admin":false},"repo":{"id":146414994,"node_id":"MDEwOlJlcG9zaXRvcnkxNDY0MTQ5OTQ=","name":"release-services","full_name":"abpostelnicu/release-services","owner":{"login":"abpostelnicu","id":11473159,"node_id":"MDQ6VXNlcjExNDczMTU5","avatar_url":"https://avatars1.githubusercontent.com/u/11473159?v=4","gravatar_id":"","url":"https://api.github.com/users/abpostelnicu","html_url":"https://github.com/abpostelnicu","followers_url":"https://api.github.com/users/abpostelnicu/followers","following_url":"https://api.github.com/users/abpostelnicu/following{/other_user}","gists_url":"https://api.github.com/users/abpostelnicu/gists{/gist_id}","starred_url":"https://api.github.com/users/abpostelnicu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abpostelnicu/subscriptions","organizations_url":"https://api.github.com/users/abpostelnicu/orgs","repos_url":"https://api.github.com/users/abpostelnicu/repos","events_url":"https://api.github.com/users/abpostelnicu/events{/privacy}","received_events_url":"https://api.github.com/users/abpostelnicu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/abpostelnicu/release-services","description":"Mozilla Release Engineering Services","fork":true,"url":"https://api.github.com/repos/abpostelnicu/release-services","forks_url":"https://api.github.com/repos/abpostelnicu/release-services/forks","keys_url":"https://api.github.com/repos/abpostelnicu/release-services/keys{/key_id}","collaborators_url":"https://api.github.com/repos/abpostelnicu/release-services/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/abpostelnicu/release-services/teams","hooks_url":"https://api.github.com/repos/abpostelnicu/release-services/hooks","issue_events_url":"https://api.github.com/repos/abpostelnicu/release-services/issues/events{/number}","events_url":"https://api.github.com/repos/abpostelnicu/release-services/events","assignees_url":"https://api.github.com/repos/abpostelnicu/release-services/assignees{/user}","branches_url":"https://api.github.com/repos/abpostelnicu/release-services/branches{/branch}","tags_url":"https://api.github.com/repos/abpostelnicu/release-services/tags","blobs_url":"https://api.github.com/repos/abpostelnicu/release-services/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/abpostelnicu/release-services/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/abpostelnicu/release-services/git/refs{/sha}","trees_url":"https://api.github.com/repos/abpostelnicu/release-services/git/trees{/sha}","statuses_url":"https://api.github.com/repos/abpostelnicu/release-services/statuses/{sha}","languages_url":"https://api.github.com/repos/abpostelnicu/release-services/languages","stargazers_url":"https://api.github.com/repos/abpostelnicu/release-services/stargazers","contributors_url":"https://api.github.com/repos/abpostelnicu/release-services/contributors","subscribers_url":"https://api.github.com/repos/abpostelnicu/release-services/subscribers","subscription_url":"https://api.github.com/repos/abpostelnicu/release-services/subscription","commits_url":"https://api.github.com/repos/abpostelnicu/release-services/commits{/sha}","git_commits_url":"https://api.github.com/repos/abpostelnicu/release-services/git/commits{/sha}","comments_url":"https://api.github.com/repos/abpostelnicu/release-services/comments{/number}","issue_comment_url":"https://api.github.com/repos/abpostelnicu/release-services/issues/comments{/number}","contents_url":"https://api.github.com/repos/abpostelnicu/release-services/contents/{+path}","compare_url":"https://api.github.com/repos/abpostelnicu/release-services/compare/{base}...{head}","merges_url":"https://api.github.com/repos/abpostelnicu/release-services/merges","archive_url":"https://api.github.com/repos/abpostelnicu/release-services/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/abpostelnicu/release-services/downloads","issues_url":"https://api.github.com/repos/abpostelnicu/release-services/issues{/number}","pulls_url":"https://api.github.com/repos/abpostelnicu/release-services/pulls{/number}","milestones_url":"https://api.github.com/repos/abpostelnicu/release-services/milestones{/number}","notifications_url":"https://api.github.com/repos/abpostelnicu/release-services/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/abpostelnicu/release-services/labels{/name}","releases_url":"https://api.github.com/repos/abpostelnicu/release-services/releases{/id}","deployments_url":"https://api.github.com/repos/abpostelnicu/release-services/deployments","created_at":"2018-08-28T08:18:19Z","updated_at":"2018-08-28T09:01:11Z","pushed_at":"2018-08-28T09:01:09Z","git_url":"git://github.com/abpostelnicu/release-services.git","ssh_url":"git@github.com:abpostelnicu/release-services.git","clone_url":"https://github.com/abpostelnicu/release-services.git","svn_url":"https://github.com/abpostelnicu/release-services","homepage":"https://mozilla-releng.net","size":60170,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mozilla:master","ref":"master","sha":"8a60547f6607a2a52121a7a28292364c35308120","user":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"repo":{"id":51109207,"node_id":"MDEwOlJlcG9zaXRvcnk1MTEwOTIwNw==","name":"release-services","full_name":"mozilla/release-services","owner":{"login":"mozilla","id":131524,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMTUyNA==","avatar_url":"https://avatars2.githubusercontent.com/u/131524?v=4","gravatar_id":"","url":"https://api.github.com/users/mozilla","html_url":"https://github.com/mozilla","followers_url":"https://api.github.com/users/mozilla/followers","following_url":"https://api.github.com/users/mozilla/following{/other_user}","gists_url":"https://api.github.com/users/mozilla/gists{/gist_id}","starred_url":"https://api.github.com/users/mozilla/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mozilla/subscriptions","organizations_url":"https://api.github.com/users/mozilla/orgs","repos_url":"https://api.github.com/users/mozilla/repos","events_url":"https://api.github.com/users/mozilla/events{/privacy}","received_events_url":"https://api.github.com/users/mozilla/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mozilla/release-services","description":"Mozilla Release Engineering Services","fork":false,"url":"https://api.github.com/repos/mozilla/release-services","forks_url":"https://api.github.com/repos/mozilla/release-services/forks","keys_url":"https://api.github.com/repos/mozilla/release-services/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mozilla/release-services/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mozilla/release-services/teams","hooks_url":"https://api.github.com/repos/mozilla/release-services/hooks","issue_events_url":"https://api.github.com/repos/mozilla/release-services/issues/events{/number}","events_url":"https://api.github.com/repos/mozilla/release-services/events","assignees_url":"https://api.github.com/repos/mozilla/release-services/assignees{/user}","branches_url":"https://api.github.com/repos/mozilla/release-services/branches{/branch}","tags_url":"https://api.github.com/repos/mozilla/release-services/tags","blobs_url":"https://api.github.com/repos/mozilla/release-services/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mozilla/release-services/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mozilla/release-services/git/refs{/sha}","trees_url":"https://api.github.com/repos/mozilla/release-services/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mozilla/release-services/statuses/{sha}","languages_url":"https://api.github.com/repos/mozilla/release-services/languages","stargazers_url":"https://api.github.com/repos/mozilla/release-services/stargazers","contributors_url":"https://api.github.com/repos/mozilla/release-services/contributors","subscribers_url":"https://api.github.com/repos/mozilla/release-services/subscribers","subscription_url":"https://api.github.com/repos/mozilla/release-services/subscription","commits_url":"https://api.github.com/repos/mozilla/release-services/commits{/sha}","git_commits_url":"https://api.github.com/repos/mozilla/release-services/git/commits{/sha}","comments_url":"https://api.github.com/repos/mozilla/release-services/comments{/number}","issue_comment_url":"https://api.github.com/repos/mozilla/release-services/issues/comments{/number}","contents_url":"https://api.github.com/repos/mozilla/release-services/contents/{+path}","compare_url":"https://api.github.com/repos/mozilla/release-services/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mozilla/release-services/merges","archive_url":"https://api.github.com/repos/mozilla/release-services/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mozilla/release-services/downloads","issues_url":"https://api.github.com/repos/mozilla/release-services/issues{/number}","pulls_url":"https://api.github.com/repos/mozilla/release-services/pulls{/number}","milestones_url":"https://api.github.com/repos/mozilla/release-services/milestones{/number}","notifications_url":"https://api.github.com/repos/mozilla/release-services/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mozilla/release-services/labels{/name}","releases_url":"https://api.github.com/repos/mozilla/release-services/releases{/id}","deployments_url":"https://api.github.com/repos/mozilla/release-services/deployments","created_at":"2016-02-04T22:07:22Z","updated_at":"2018-08-28T08:48:49Z","pushed_at":"2018-08-28T09:01:11Z","git_url":"git://github.com/mozilla/release-services.git","ssh_url":"git@github.com:mozilla/release-services.git","clone_url":"https://github.com/mozilla/release-services.git","svn_url":"https://github.com/mozilla/release-services","homepage":"https://mozilla-releng.net","size":60170,"stargazers_count":22,"watchers_count":22,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":70,"mirror_url":null,"archived":false,"open_issues_count":259,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":70,"open_issues":259,"watchers":22,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mozilla/release-services/pulls/1434"},"html":{"href":"https://github.com/mozilla/release-services/pull/1434"},"issue":{"href":"https://api.github.com/repos/mozilla/release-services/issues/1434"},"comments":{"href":"https://api.github.com/repos/mozilla/release-services/issues/1434/comments"},"review_comments":{"href":"https://api.github.com/repos/mozilla/release-services/pulls/1434/comments"},"review_comment":{"href":"https://api.github.com/repos/mozilla/release-services/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mozilla/release-services/pulls/1434/commits"},"statuses":{"href":"https://api.github.com/repos/mozilla/release-services/statuses/2676f8e817b5f9d1a8be288d4b59243af4d52f55"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"marco-c"}}