{"action":"created","comment":{"url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/pulls/comments/210873464","pull_request_review_id":147180570,"id":210873464,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMDg3MzQ2NA==","diff_hunk":"@@ -5,19 +5,23 @@\n     \"email\": \"roger@bufferoverflow.ch\"\n   },\n   \"scripts\": {\n-    \"build\": \"babel src/ --out-dir lib/ --copy-files --ignore ___tests___ --source-maps\",\n-    \"build:docker\": \"docker build -t verdaccio-gitlab . --no-cache\",\n-    \"flow\": \"flow\",\n+    \"flow\": \"flow check\",\n     \"commitmsg\": \"commitlint -e $GIT_PARAMS\",\n     \"license\": \"license-checker --onlyAllow 'Apache-2.0; Apache License, Version 2.0; BSD; BSD-2-Clause; BSD-3-Clause; ISC; MIT; Unlicense; WTFPL; CC-BY-3.0; CC0-1.0' --production\",\n-    \"lint\": \"flow && eslint . && eclint check $(git ls-files) && markdownlint README.md\",\n-    \"prepublish\": \"in-publish && yarn lint && yarn build || not-in-publish\",\n+    \"lint\": \"yarn flow && eslint . && eclint check $(git ls-files) && markdownlint README.md\",\n+    \"prepublish\": \"in-publish && yarn lint && yarn code:build || not-in-publish\",\n     \"release:major\": \"changelog -M && git commit -a -m 'docs: updated CHANGELOG.md' && yarn version major && git push origin && git push origin --tags\",\n     \"release:minor\": \"changelog -m && git commit -a -m 'docs: updated CHANGELOG.md' && yarn version minor && git push origin && git push origin --tags\",\n     \"release:patch\": \"changelog -p && git commit -a -m 'docs: updated CHANGELOG.md' && yarn version patch && git push origin && git push origin --tags\",\n-    \"start\": \"yarn build && NODE_PATH=$NODE_PATH:.. node lib/verdaccio.js\"\n+    \"start\": \"yarn code:build && cross-env NODE_PATH=$NODE_PATH:.. BABEL_ENV=registry babel-node build/verdaccio.js\",\n+    \"code:build\": \"cross-env BABEL_ENV=registry babel src/ --out-dir build/ --copy-files --ignore ___tests___ --source-maps\",\n+    \"code:docker-build\": \"cross-env BABEL_ENV=registry-docker babel src/ --out-dir build/ --copy-files --ignore ___tests___ --source-maps\",\n+    \"build:docker\": \"docker build -t verdaccio-gitlab . --no-cache\",","path":"package.json","position":21,"original_position":21,"commit_id":"1e515c0d5547b2c80ea9a324f93c814d867c85dd","original_commit_id":"1e515c0d5547b2c80ea9a324f93c814d867c85dd","user":{"login":"dlouzan","id":223870,"node_id":"MDQ6VXNlcjIyMzg3MA==","avatar_url":"https://avatars0.githubusercontent.com/u/223870?v=4","gravatar_id":"","url":"https://api.github.com/users/dlouzan","html_url":"https://github.com/dlouzan","followers_url":"https://api.github.com/users/dlouzan/followers","following_url":"https://api.github.com/users/dlouzan/following{/other_user}","gists_url":"https://api.github.com/users/dlouzan/gists{/gist_id}","starred_url":"https://api.github.com/users/dlouzan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlouzan/subscriptions","organizations_url":"https://api.github.com/users/dlouzan/orgs","repos_url":"https://api.github.com/users/dlouzan/repos","events_url":"https://api.github.com/users/dlouzan/events{/privacy}","received_events_url":"https://api.github.com/users/dlouzan/received_events","type":"User","site_admin":false},"body":"It's basically safeguarding: it ensures consistent builds everywhere. In my experience the docker cache is a source of problems, specially in development, since the `RUN` directives need to change to actually trigger a rebuild of the layer, and you sometimes need it :-)\r\n\r\nI actually do myself the manual `docker build ...` command lots of times to make it faster. If you see the need, we can add an additional command without it. But in practice the main use is the CI, since now @bufferoverflow has enabled auto-building in the docker hub.\r\n\r\nIt's also used in verdaccio itself (before my refactor).","created_at":"2018-08-17T10:50:53Z","updated_at":"2018-08-17T10:50:53Z","html_url":"https://github.com/bufferoverflow/verdaccio-gitlab/pull/45#discussion_r210873464","pull_request_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/pulls/45","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/pulls/comments/210873464"},"html":{"href":"https://github.com/bufferoverflow/verdaccio-gitlab/pull/45#discussion_r210873464"},"pull_request":{"href":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/pulls/45"}},"in_reply_to_id":210868614},"pull_request":{"url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/pulls/45","id":209101692,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MTAxNjky","html_url":"https://github.com/bufferoverflow/verdaccio-gitlab/pull/45","diff_url":"https://github.com/bufferoverflow/verdaccio-gitlab/pull/45.diff","patch_url":"https://github.com/bufferoverflow/verdaccio-gitlab/pull/45.patch","issue_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/issues/45","number":45,"state":"open","locked":false,"title":"chore: build refactor and jest testing support","user":{"login":"dlouzan","id":223870,"node_id":"MDQ6VXNlcjIyMzg3MA==","avatar_url":"https://avatars0.githubusercontent.com/u/223870?v=4","gravatar_id":"","url":"https://api.github.com/users/dlouzan","html_url":"https://github.com/dlouzan","followers_url":"https://api.github.com/users/dlouzan/followers","following_url":"https://api.github.com/users/dlouzan/following{/other_user}","gists_url":"https://api.github.com/users/dlouzan/gists{/gist_id}","starred_url":"https://api.github.com/users/dlouzan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlouzan/subscriptions","organizations_url":"https://api.github.com/users/dlouzan/orgs","repos_url":"https://api.github.com/users/dlouzan/repos","events_url":"https://api.github.com/users/dlouzan/events{/privacy}","received_events_url":"https://api.github.com/users/dlouzan/received_events","type":"User","site_admin":false},"body":"- bring build closer to upstream verdaccio model\r\n- move build from lib/ to build/\r\n- add support for adding jest tests","created_at":"2018-08-17T10:02:52Z","updated_at":"2018-08-17T10:50:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f597000b02ad068f86db1acca6f296ab33603b0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/pulls/45/commits","review_comments_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/pulls/45/comments","review_comment_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/issues/45/comments","statuses_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/statuses/1e515c0d5547b2c80ea9a324f93c814d867c85dd","head":{"label":"bufferoverflow:chore/build-refactor","ref":"chore/build-refactor","sha":"1e515c0d5547b2c80ea9a324f93c814d867c85dd","user":{"login":"bufferoverflow","id":378909,"node_id":"MDQ6VXNlcjM3ODkwOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/378909?v=4","gravatar_id":"","url":"https://api.github.com/users/bufferoverflow","html_url":"https://github.com/bufferoverflow","followers_url":"https://api.github.com/users/bufferoverflow/followers","following_url":"https://api.github.com/users/bufferoverflow/following{/other_user}","gists_url":"https://api.github.com/users/bufferoverflow/gists{/gist_id}","starred_url":"https://api.github.com/users/bufferoverflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bufferoverflow/subscriptions","organizations_url":"https://api.github.com/users/bufferoverflow/orgs","repos_url":"https://api.github.com/users/bufferoverflow/repos","events_url":"https://api.github.com/users/bufferoverflow/events{/privacy}","received_events_url":"https://api.github.com/users/bufferoverflow/received_events","type":"User","site_admin":false},"repo":{"id":116526762,"node_id":"MDEwOlJlcG9zaXRvcnkxMTY1MjY3NjI=","name":"verdaccio-gitlab","full_name":"bufferoverflow/verdaccio-gitlab","owner":{"login":"bufferoverflow","id":378909,"node_id":"MDQ6VXNlcjM3ODkwOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/378909?v=4","gravatar_id":"","url":"https://api.github.com/users/bufferoverflow","html_url":"https://github.com/bufferoverflow","followers_url":"https://api.github.com/users/bufferoverflow/followers","following_url":"https://api.github.com/users/bufferoverflow/following{/other_user}","gists_url":"https://api.github.com/users/bufferoverflow/gists{/gist_id}","starred_url":"https://api.github.com/users/bufferoverflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bufferoverflow/subscriptions","organizations_url":"https://api.github.com/users/bufferoverflow/orgs","repos_url":"https://api.github.com/users/bufferoverflow/repos","events_url":"https://api.github.com/users/bufferoverflow/events{/privacy}","received_events_url":"https://api.github.com/users/bufferoverflow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bufferoverflow/verdaccio-gitlab","description":"private npm registry (Verdaccio) using gitlab-ce as authentication and authorization provider","fork":false,"url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab","forks_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/forks","keys_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/teams","hooks_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/hooks","issue_events_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/issues/events{/number}","events_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/events","assignees_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/assignees{/user}","branches_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/branches{/branch}","tags_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/tags","blobs_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/git/refs{/sha}","trees_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/statuses/{sha}","languages_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/languages","stargazers_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/stargazers","contributors_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/contributors","subscribers_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/subscribers","subscription_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/subscription","commits_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/commits{/sha}","git_commits_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/git/commits{/sha}","comments_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/comments{/number}","issue_comment_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/issues/comments{/number}","contents_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/contents/{+path}","compare_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/merges","archive_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/downloads","issues_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/issues{/number}","pulls_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/pulls{/number}","milestones_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/milestones{/number}","notifications_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/labels{/name}","releases_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/releases{/id}","deployments_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/deployments","created_at":"2018-01-07T00:52:50Z","updated_at":"2018-08-16T19:14:50Z","pushed_at":"2018-08-17T10:29:25Z","git_url":"git://github.com/bufferoverflow/verdaccio-gitlab.git","ssh_url":"git@github.com:bufferoverflow/verdaccio-gitlab.git","clone_url":"https://github.com/bufferoverflow/verdaccio-gitlab.git","svn_url":"https://github.com/bufferoverflow/verdaccio-gitlab","homepage":"","size":434,"stargazers_count":26,"watchers_count":26,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11,"open_issues":12,"watchers":26,"default_branch":"master"}},"base":{"label":"bufferoverflow:master","ref":"master","sha":"22860792d8e44a40b46ca26823236895684cc124","user":{"login":"bufferoverflow","id":378909,"node_id":"MDQ6VXNlcjM3ODkwOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/378909?v=4","gravatar_id":"","url":"https://api.github.com/users/bufferoverflow","html_url":"https://github.com/bufferoverflow","followers_url":"https://api.github.com/users/bufferoverflow/followers","following_url":"https://api.github.com/users/bufferoverflow/following{/other_user}","gists_url":"https://api.github.com/users/bufferoverflow/gists{/gist_id}","starred_url":"https://api.github.com/users/bufferoverflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bufferoverflow/subscriptions","organizations_url":"https://api.github.com/users/bufferoverflow/orgs","repos_url":"https://api.github.com/users/bufferoverflow/repos","events_url":"https://api.github.com/users/bufferoverflow/events{/privacy}","received_events_url":"https://api.github.com/users/bufferoverflow/received_events","type":"User","site_admin":false},"repo":{"id":116526762,"node_id":"MDEwOlJlcG9zaXRvcnkxMTY1MjY3NjI=","name":"verdaccio-gitlab","full_name":"bufferoverflow/verdaccio-gitlab","owner":{"login":"bufferoverflow","id":378909,"node_id":"MDQ6VXNlcjM3ODkwOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/378909?v=4","gravatar_id":"","url":"https://api.github.com/users/bufferoverflow","html_url":"https://github.com/bufferoverflow","followers_url":"https://api.github.com/users/bufferoverflow/followers","following_url":"https://api.github.com/users/bufferoverflow/following{/other_user}","gists_url":"https://api.github.com/users/bufferoverflow/gists{/gist_id}","starred_url":"https://api.github.com/users/bufferoverflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bufferoverflow/subscriptions","organizations_url":"https://api.github.com/users/bufferoverflow/orgs","repos_url":"https://api.github.com/users/bufferoverflow/repos","events_url":"https://api.github.com/users/bufferoverflow/events{/privacy}","received_events_url":"https://api.github.com/users/bufferoverflow/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bufferoverflow/verdaccio-gitlab","description":"private npm registry (Verdaccio) using gitlab-ce as authentication and authorization provider","fork":false,"url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab","forks_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/forks","keys_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/teams","hooks_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/hooks","issue_events_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/issues/events{/number}","events_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/events","assignees_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/assignees{/user}","branches_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/branches{/branch}","tags_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/tags","blobs_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/git/refs{/sha}","trees_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/statuses/{sha}","languages_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/languages","stargazers_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/stargazers","contributors_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/contributors","subscribers_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/subscribers","subscription_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/subscription","commits_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/commits{/sha}","git_commits_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/git/commits{/sha}","comments_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/comments{/number}","issue_comment_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/issues/comments{/number}","contents_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/contents/{+path}","compare_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/merges","archive_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/downloads","issues_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/issues{/number}","pulls_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/pulls{/number}","milestones_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/milestones{/number}","notifications_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/labels{/name}","releases_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/releases{/id}","deployments_url":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/deployments","created_at":"2018-01-07T00:52:50Z","updated_at":"2018-08-16T19:14:50Z","pushed_at":"2018-08-17T10:29:25Z","git_url":"git://github.com/bufferoverflow/verdaccio-gitlab.git","ssh_url":"git@github.com:bufferoverflow/verdaccio-gitlab.git","clone_url":"https://github.com/bufferoverflow/verdaccio-gitlab.git","svn_url":"https://github.com/bufferoverflow/verdaccio-gitlab","homepage":"","size":434,"stargazers_count":26,"watchers_count":26,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11,"open_issues":12,"watchers":26,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/pulls/45"},"html":{"href":"https://github.com/bufferoverflow/verdaccio-gitlab/pull/45"},"issue":{"href":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/issues/45"},"comments":{"href":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/issues/45/comments"},"review_comments":{"href":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/pulls/45/comments"},"review_comment":{"href":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/pulls/45/commits"},"statuses":{"href":"https://api.github.com/repos/bufferoverflow/verdaccio-gitlab/statuses/1e515c0d5547b2c80ea9a324f93c814d867c85dd"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"dlouzan"}}