{"action":"closed","number":8712,"pull_request":{"url":"https://api.github.com/repos/HippieStation/HippieStation/pulls/8712","id":210017857,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwMDE3ODU3","html_url":"https://github.com/HippieStation/HippieStation/pull/8712","diff_url":"https://github.com/HippieStation/HippieStation/pull/8712.diff","patch_url":"https://github.com/HippieStation/HippieStation/pull/8712.patch","issue_url":"https://api.github.com/repos/HippieStation/HippieStation/issues/8712","number":8712,"state":"closed","locked":false,"title":"Sound options - voice, scream and main","user":{"login":"nalarmg","id":7481072,"node_id":"MDQ6VXNlcjc0ODEwNzI=","avatar_url":"https://avatars0.githubusercontent.com/u/7481072?v=4","gravatar_id":"","url":"https://api.github.com/users/nalarmg","html_url":"https://github.com/nalarmg","followers_url":"https://api.github.com/users/nalarmg/followers","following_url":"https://api.github.com/users/nalarmg/following{/other_user}","gists_url":"https://api.github.com/users/nalarmg/gists{/gist_id}","starred_url":"https://api.github.com/users/nalarmg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nalarmg/subscriptions","organizations_url":"https://api.github.com/users/nalarmg/orgs","repos_url":"https://api.github.com/users/nalarmg/repos","events_url":"https://api.github.com/users/nalarmg/events{/privacy}","received_events_url":"https://api.github.com/users/nalarmg/received_events","type":"User","site_admin":false},"body":"Adds new sound options in the OOC preferences tab on character setup. I'll probably make further PRs with new options and tweaks to avoid one overly huge PR with hundreds of file changes. \r\n\r\nAllows players to set their own sound volume for voices (things said ingame), screaming sounds, and anything that isn't the previous two things.\r\n\r\nDoes not affect adminhelps or mentorhelps, as due to being relatively ancient code they use a different proc entirely to playsound, which was modified to allow these new options to happen. They'll need to be adjusted in the future if sound options are desired for those. Also does not affect anything that does not use the playsound proc, such as round-end or round-start sounds. \r\n\r\n![screenshot_1](https://user-images.githubusercontent.com/7481072/44442953-0248bc00-a5cd-11e8-9fd2-494237fdbf12.png)\r\n\r\n\r\n","created_at":"2018-08-22T04:34:42Z","updated_at":"2018-09-25T17:03:42Z","closed_at":"2018-09-25T17:03:42Z","merged_at":null,"merge_commit_sha":"20c971c20ef68476fc938508945d1a53793d2de4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/HippieStation/HippieStation/pulls/8712/commits","review_comments_url":"https://api.github.com/repos/HippieStation/HippieStation/pulls/8712/comments","review_comment_url":"https://api.github.com/repos/HippieStation/HippieStation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HippieStation/HippieStation/issues/8712/comments","statuses_url":"https://api.github.com/repos/HippieStation/HippieStation/statuses/e8aa2d671893b7fbf2f7cc111d304580b9e9a257","head":{"label":"nalarmg:nalar-sound-p1","ref":"nalar-sound-p1","sha":"e8aa2d671893b7fbf2f7cc111d304580b9e9a257","user":{"login":"nalarmg","id":7481072,"node_id":"MDQ6VXNlcjc0ODEwNzI=","avatar_url":"https://avatars0.githubusercontent.com/u/7481072?v=4","gravatar_id":"","url":"https://api.github.com/users/nalarmg","html_url":"https://github.com/nalarmg","followers_url":"https://api.github.com/users/nalarmg/followers","following_url":"https://api.github.com/users/nalarmg/following{/other_user}","gists_url":"https://api.github.com/users/nalarmg/gists{/gist_id}","starred_url":"https://api.github.com/users/nalarmg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nalarmg/subscriptions","organizations_url":"https://api.github.com/users/nalarmg/orgs","repos_url":"https://api.github.com/users/nalarmg/repos","events_url":"https://api.github.com/users/nalarmg/events{/privacy}","received_events_url":"https://api.github.com/users/nalarmg/received_events","type":"User","site_admin":false},"repo":{"id":145635374,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU2MzUzNzQ=","name":"HippieStation","full_name":"nalarmg/HippieStation","private":false,"owner":{"login":"nalarmg","id":7481072,"node_id":"MDQ6VXNlcjc0ODEwNzI=","avatar_url":"https://avatars0.githubusercontent.com/u/7481072?v=4","gravatar_id":"","url":"https://api.github.com/users/nalarmg","html_url":"https://github.com/nalarmg","followers_url":"https://api.github.com/users/nalarmg/followers","following_url":"https://api.github.com/users/nalarmg/following{/other_user}","gists_url":"https://api.github.com/users/nalarmg/gists{/gist_id}","starred_url":"https://api.github.com/users/nalarmg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nalarmg/subscriptions","organizations_url":"https://api.github.com/users/nalarmg/orgs","repos_url":"https://api.github.com/users/nalarmg/repos","events_url":"https://api.github.com/users/nalarmg/events{/privacy}","received_events_url":"https://api.github.com/users/nalarmg/received_events","type":"User","site_admin":false},"html_url":"https://github.com/nalarmg/HippieStation","description":"The Hippie Station branch of SS13","fork":true,"url":"https://api.github.com/repos/nalarmg/HippieStation","forks_url":"https://api.github.com/repos/nalarmg/HippieStation/forks","keys_url":"https://api.github.com/repos/nalarmg/HippieStation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nalarmg/HippieStation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nalarmg/HippieStation/teams","hooks_url":"https://api.github.com/repos/nalarmg/HippieStation/hooks","issue_events_url":"https://api.github.com/repos/nalarmg/HippieStation/issues/events{/number}","events_url":"https://api.github.com/repos/nalarmg/HippieStation/events","assignees_url":"https://api.github.com/repos/nalarmg/HippieStation/assignees{/user}","branches_url":"https://api.github.com/repos/nalarmg/HippieStation/branches{/branch}","tags_url":"https://api.github.com/repos/nalarmg/HippieStation/tags","blobs_url":"https://api.github.com/repos/nalarmg/HippieStation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nalarmg/HippieStation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nalarmg/HippieStation/git/refs{/sha}","trees_url":"https://api.github.com/repos/nalarmg/HippieStation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nalarmg/HippieStation/statuses/{sha}","languages_url":"https://api.github.com/repos/nalarmg/HippieStation/languages","stargazers_url":"https://api.github.com/repos/nalarmg/HippieStation/stargazers","contributors_url":"https://api.github.com/repos/nalarmg/HippieStation/contributors","subscribers_url":"https://api.github.com/repos/nalarmg/HippieStation/subscribers","subscription_url":"https://api.github.com/repos/nalarmg/HippieStation/subscription","commits_url":"https://api.github.com/repos/nalarmg/HippieStation/commits{/sha}","git_commits_url":"https://api.github.com/repos/nalarmg/HippieStation/git/commits{/sha}","comments_url":"https://api.github.com/repos/nalarmg/HippieStation/comments{/number}","issue_comment_url":"https://api.github.com/repos/nalarmg/HippieStation/issues/comments{/number}","contents_url":"https://api.github.com/repos/nalarmg/HippieStation/contents/{+path}","compare_url":"https://api.github.com/repos/nalarmg/HippieStation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nalarmg/HippieStation/merges","archive_url":"https://api.github.com/repos/nalarmg/HippieStation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nalarmg/HippieStation/downloads","issues_url":"https://api.github.com/repos/nalarmg/HippieStation/issues{/number}","pulls_url":"https://api.github.com/repos/nalarmg/HippieStation/pulls{/number}","milestones_url":"https://api.github.com/repos/nalarmg/HippieStation/milestones{/number}","notifications_url":"https://api.github.com/repos/nalarmg/HippieStation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nalarmg/HippieStation/labels{/name}","releases_url":"https://api.github.com/repos/nalarmg/HippieStation/releases{/id}","deployments_url":"https://api.github.com/repos/nalarmg/HippieStation/deployments","created_at":"2018-08-22T00:41:55Z","updated_at":"2018-08-22T00:42:26Z","pushed_at":"2018-08-23T02:32:39Z","git_url":"git://github.com/nalarmg/HippieStation.git","ssh_url":"git@github.com:nalarmg/HippieStation.git","clone_url":"https://github.com/nalarmg/HippieStation.git","svn_url":"https://github.com/nalarmg/HippieStation","homepage":"https://hippiestation.com/","size":2208307,"stargazers_count":0,"watchers_count":0,"language":"DM","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"HippieStation:master","ref":"master","sha":"09e237c5ef3f99ec34f003af639b4e7f7d18e667","user":{"login":"HippieStation","id":25507626,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NTA3NjI2","avatar_url":"https://avatars1.githubusercontent.com/u/25507626?v=4","gravatar_id":"","url":"https://api.github.com/users/HippieStation","html_url":"https://github.com/HippieStation","followers_url":"https://api.github.com/users/HippieStation/followers","following_url":"https://api.github.com/users/HippieStation/following{/other_user}","gists_url":"https://api.github.com/users/HippieStation/gists{/gist_id}","starred_url":"https://api.github.com/users/HippieStation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HippieStation/subscriptions","organizations_url":"https://api.github.com/users/HippieStation/orgs","repos_url":"https://api.github.com/users/HippieStation/repos","events_url":"https://api.github.com/users/HippieStation/events{/privacy}","received_events_url":"https://api.github.com/users/HippieStation/received_events","type":"Organization","site_admin":false},"repo":{"id":84665083,"node_id":"MDEwOlJlcG9zaXRvcnk4NDY2NTA4Mw==","name":"HippieStation","full_name":"HippieStation/HippieStation","private":false,"owner":{"login":"HippieStation","id":25507626,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1NTA3NjI2","avatar_url":"https://avatars1.githubusercontent.com/u/25507626?v=4","gravatar_id":"","url":"https://api.github.com/users/HippieStation","html_url":"https://github.com/HippieStation","followers_url":"https://api.github.com/users/HippieStation/followers","following_url":"https://api.github.com/users/HippieStation/following{/other_user}","gists_url":"https://api.github.com/users/HippieStation/gists{/gist_id}","starred_url":"https://api.github.com/users/HippieStation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HippieStation/subscriptions","organizations_url":"https://api.github.com/users/HippieStation/orgs","repos_url":"https://api.github.com/users/HippieStation/repos","events_url":"https://api.github.com/users/HippieStation/events{/privacy}","received_events_url":"https://api.github.com/users/HippieStation/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/HippieStation/HippieStation","description":"The Hippie Station branch of SS13","fork":true,"url":"https://api.github.com/repos/HippieStation/HippieStation","forks_url":"https://api.github.com/repos/HippieStation/HippieStation/forks","keys_url":"https://api.github.com/repos/HippieStation/HippieStation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HippieStation/HippieStation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HippieStation/HippieStation/teams","hooks_url":"https://api.github.com/repos/HippieStation/HippieStation/hooks","issue_events_url":"https://api.github.com/repos/HippieStation/HippieStation/issues/events{/number}","events_url":"https://api.github.com/repos/HippieStation/HippieStation/events","assignees_url":"https://api.github.com/repos/HippieStation/HippieStation/assignees{/user}","branches_url":"https://api.github.com/repos/HippieStation/HippieStation/branches{/branch}","tags_url":"https://api.github.com/repos/HippieStation/HippieStation/tags","blobs_url":"https://api.github.com/repos/HippieStation/HippieStation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HippieStation/HippieStation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HippieStation/HippieStation/git/refs{/sha}","trees_url":"https://api.github.com/repos/HippieStation/HippieStation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HippieStation/HippieStation/statuses/{sha}","languages_url":"https://api.github.com/repos/HippieStation/HippieStation/languages","stargazers_url":"https://api.github.com/repos/HippieStation/HippieStation/stargazers","contributors_url":"https://api.github.com/repos/HippieStation/HippieStation/contributors","subscribers_url":"https://api.github.com/repos/HippieStation/HippieStation/subscribers","subscription_url":"https://api.github.com/repos/HippieStation/HippieStation/subscription","commits_url":"https://api.github.com/repos/HippieStation/HippieStation/commits{/sha}","git_commits_url":"https://api.github.com/repos/HippieStation/HippieStation/git/commits{/sha}","comments_url":"https://api.github.com/repos/HippieStation/HippieStation/comments{/number}","issue_comment_url":"https://api.github.com/repos/HippieStation/HippieStation/issues/comments{/number}","contents_url":"https://api.github.com/repos/HippieStation/HippieStation/contents/{+path}","compare_url":"https://api.github.com/repos/HippieStation/HippieStation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HippieStation/HippieStation/merges","archive_url":"https://api.github.com/repos/HippieStation/HippieStation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HippieStation/HippieStation/downloads","issues_url":"https://api.github.com/repos/HippieStation/HippieStation/issues{/number}","pulls_url":"https://api.github.com/repos/HippieStation/HippieStation/pulls{/number}","milestones_url":"https://api.github.com/repos/HippieStation/HippieStation/milestones{/number}","notifications_url":"https://api.github.com/repos/HippieStation/HippieStation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HippieStation/HippieStation/labels{/name}","releases_url":"https://api.github.com/repos/HippieStation/HippieStation/releases{/id}","deployments_url":"https://api.github.com/repos/HippieStation/HippieStation/deployments","created_at":"2017-03-11T16:47:28Z","updated_at":"2018-09-25T16:59:20Z","pushed_at":"2018-09-25T16:59:58Z","git_url":"git://github.com/HippieStation/HippieStation.git","ssh_url":"git@github.com:HippieStation/HippieStation.git","clone_url":"https://github.com/HippieStation/HippieStation.git","svn_url":"https://github.com/HippieStation/HippieStation","homepage":"https://hippiestation.com/","size":2229966,"stargazers_count":19,"watchers_count":19,"language":"DM","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":69,"mirror_url":null,"archived":false,"open_issues_count":178,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":69,"open_issues":178,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/HippieStation/HippieStation/pulls/8712"},"html":{"href":"https://github.com/HippieStation/HippieStation/pull/8712"},"issue":{"href":"https://api.github.com/repos/HippieStation/HippieStation/issues/8712"},"comments":{"href":"https://api.github.com/repos/HippieStation/HippieStation/issues/8712/comments"},"review_comments":{"href":"https://api.github.com/repos/HippieStation/HippieStation/pulls/8712/comments"},"review_comment":{"href":"https://api.github.com/repos/HippieStation/HippieStation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HippieStation/HippieStation/pulls/8712/commits"},"statuses":{"href":"https://api.github.com/repos/HippieStation/HippieStation/statuses/e8aa2d671893b7fbf2f7cc111d304580b9e9a257"}},"author_association":"NONE","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":6,"review_comments":34,"maintainer_can_modify":false,"commits":3,"additions":96,"deletions":57,"changed_files":29}}
{"actor":{"display_login":"Carbonhell"}}