{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/console-operator/pulls/comments/245420696","pull_request_review_id":189528653,"id":245420696,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTQyMDY5Ng==","diff_hunk":"@@ -178,11 +178,13 @@ func consoleContainer(cr *v1alpha1.Console) corev1.Container {\n \t\tTerminationMessagePolicy: corev1.TerminationMessagePolicy(\"File\"),\n \t\tResources: corev1.ResourceRequirements{\n \t\t\tLimits: map[corev1.ResourceName]resource.Quantity{\n-\t\t\t\t// TODO: fill these out\n-\t\t\t\t//\t\"cpu\": int64(100),\n-\t\t\t\t//\t\"memory\": int64(100)\n+\t\t\t\tcorev1.ResourceCPU:    resource.MustParse(\"100Mi\"),","path":"pkg/console/subresource/deployment/deployment.go","position":7,"original_position":7,"commit_id":"fea9947adc92a79e57cff9f8d0fa2d43a7bec6a3","original_commit_id":"6a4ba2b7fb773ae088eacd85a97c321c88973ca3","user":{"login":"spadgett","id":1167259,"node_id":"MDQ6VXNlcjExNjcyNTk=","avatar_url":"https://avatars1.githubusercontent.com/u/1167259?v=4","gravatar_id":"","url":"https://api.github.com/users/spadgett","html_url":"https://github.com/spadgett","followers_url":"https://api.github.com/users/spadgett/followers","following_url":"https://api.github.com/users/spadgett/following{/other_user}","gists_url":"https://api.github.com/users/spadgett/gists{/gist_id}","starred_url":"https://api.github.com/users/spadgett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spadgett/subscriptions","organizations_url":"https://api.github.com/users/spadgett/orgs","repos_url":"https://api.github.com/users/spadgett/repos","events_url":"https://api.github.com/users/spadgett/events{/privacy}","received_events_url":"https://api.github.com/users/spadgett/received_events","type":"User","site_admin":false},"body":"I spoke to @derekwaynecarr, and he recommended we set only request for both the operator and console. Let's do that.","created_at":"2019-01-04T21:06:56Z","updated_at":"2019-01-04T21:06:57Z","html_url":"https://github.com/openshift/console-operator/pull/88#discussion_r245420696","pull_request_url":"https://api.github.com/repos/openshift/console-operator/pulls/88","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openshift/console-operator/pulls/comments/245420696"},"html":{"href":"https://github.com/openshift/console-operator/pull/88#discussion_r245420696"},"pull_request":{"href":"https://api.github.com/repos/openshift/console-operator/pulls/88"}},"in_reply_to_id":239898588},"pull_request":{"url":"https://api.github.com/repos/openshift/console-operator/pulls/88","id":236906393,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2OTA2Mzkz","html_url":"https://github.com/openshift/console-operator/pull/88","diff_url":"https://github.com/openshift/console-operator/pull/88.diff","patch_url":"https://github.com/openshift/console-operator/pull/88.patch","issue_url":"https://api.github.com/repos/openshift/console-operator/issues/88","number":88,"state":"open","locked":false,"title":"Add Resource Limits to Deployment","user":{"login":"jhadvig","id":1668218,"node_id":"MDQ6VXNlcjE2NjgyMTg=","avatar_url":"https://avatars2.githubusercontent.com/u/1668218?v=4","gravatar_id":"","url":"https://api.github.com/users/jhadvig","html_url":"https://github.com/jhadvig","followers_url":"https://api.github.com/users/jhadvig/followers","following_url":"https://api.github.com/users/jhadvig/following{/other_user}","gists_url":"https://api.github.com/users/jhadvig/gists{/gist_id}","starred_url":"https://api.github.com/users/jhadvig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhadvig/subscriptions","organizations_url":"https://api.github.com/users/jhadvig/orgs","repos_url":"https://api.github.com/users/jhadvig/repos","events_url":"https://api.github.com/users/jhadvig/events{/privacy}","received_events_url":"https://api.github.com/users/jhadvig/received_events","type":"User","site_admin":false},"body":"Story: https://jira.coreos.com/browse/CONSOLE-960\r\n\r\n@benjaminapetersen pointed out old [HELM operator](https://github.com/benjaminapetersen/console-helm-operator/blob/master/helm/output/console/templates/deployment-console.yaml#L56-L62) so I'm not sure the resource limits I've set in this PR are proper.\r\n\r\n@spadgett PTAL ","created_at":"2018-12-07T15:36:12Z","updated_at":"2019-01-04T21:06:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e2c9577c85978cc722c9da6cfe03f944683aa3d6","assignee":{"login":"benjaminapetersen","id":280512,"node_id":"MDQ6VXNlcjI4MDUxMg==","avatar_url":"https://avatars0.githubusercontent.com/u/280512?v=4","gravatar_id":"","url":"https://api.github.com/users/benjaminapetersen","html_url":"https://github.com/benjaminapetersen","followers_url":"https://api.github.com/users/benjaminapetersen/followers","following_url":"https://api.github.com/users/benjaminapetersen/following{/other_user}","gists_url":"https://api.github.com/users/benjaminapetersen/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminapetersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminapetersen/subscriptions","organizations_url":"https://api.github.com/users/benjaminapetersen/orgs","repos_url":"https://api.github.com/users/benjaminapetersen/repos","events_url":"https://api.github.com/users/benjaminapetersen/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminapetersen/received_events","type":"User","site_admin":false},"assignees":[{"login":"benjaminapetersen","id":280512,"node_id":"MDQ6VXNlcjI4MDUxMg==","avatar_url":"https://avatars0.githubusercontent.com/u/280512?v=4","gravatar_id":"","url":"https://api.github.com/users/benjaminapetersen","html_url":"https://github.com/benjaminapetersen","followers_url":"https://api.github.com/users/benjaminapetersen/followers","following_url":"https://api.github.com/users/benjaminapetersen/following{/other_user}","gists_url":"https://api.github.com/users/benjaminapetersen/gists{/gist_id}","starred_url":"https://api.github.com/users/benjaminapetersen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benjaminapetersen/subscriptions","organizations_url":"https://api.github.com/users/benjaminapetersen/orgs","repos_url":"https://api.github.com/users/benjaminapetersen/repos","events_url":"https://api.github.com/users/benjaminapetersen/events{/privacy}","received_events_url":"https://api.github.com/users/benjaminapetersen/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"enj","id":7001223,"node_id":"MDQ6VXNlcjcwMDEyMjM=","avatar_url":"https://avatars0.githubusercontent.com/u/7001223?v=4","gravatar_id":"","url":"https://api.github.com/users/enj","html_url":"https://github.com/enj","followers_url":"https://api.github.com/users/enj/followers","following_url":"https://api.github.com/users/enj/following{/other_user}","gists_url":"https://api.github.com/users/enj/gists{/gist_id}","starred_url":"https://api.github.com/users/enj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enj/subscriptions","organizations_url":"https://api.github.com/users/enj/orgs","repos_url":"https://api.github.com/users/enj/repos","events_url":"https://api.github.com/users/enj/events{/privacy}","received_events_url":"https://api.github.com/users/enj/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1069461458,"node_id":"MDU6TGFiZWwxMDY5NDYxNDU4","url":"https://api.github.com/repos/openshift/console-operator/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":1067640390,"node_id":"MDU6TGFiZWwxMDY3NjQwMzkw","url":"https://api.github.com/repos/openshift/console-operator/labels/lgtm","name":"lgtm","color":"15dd18","default":false},{"id":1074742870,"node_id":"MDU6TGFiZWwxMDc0NzQyODcw","url":"https://api.github.com/repos/openshift/console-operator/labels/size/S","name":"size/S","color":"77bb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/console-operator/pulls/88/commits","review_comments_url":"https://api.github.com/repos/openshift/console-operator/pulls/88/comments","review_comment_url":"https://api.github.com/repos/openshift/console-operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/console-operator/issues/88/comments","statuses_url":"https://api.github.com/repos/openshift/console-operator/statuses/fea9947adc92a79e57cff9f8d0fa2d43a7bec6a3","head":{"label":"jhadvig:dep_limit","ref":"dep_limit","sha":"fea9947adc92a79e57cff9f8d0fa2d43a7bec6a3","user":{"login":"jhadvig","id":1668218,"node_id":"MDQ6VXNlcjE2NjgyMTg=","avatar_url":"https://avatars2.githubusercontent.com/u/1668218?v=4","gravatar_id":"","url":"https://api.github.com/users/jhadvig","html_url":"https://github.com/jhadvig","followers_url":"https://api.github.com/users/jhadvig/followers","following_url":"https://api.github.com/users/jhadvig/following{/other_user}","gists_url":"https://api.github.com/users/jhadvig/gists{/gist_id}","starred_url":"https://api.github.com/users/jhadvig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhadvig/subscriptions","organizations_url":"https://api.github.com/users/jhadvig/orgs","repos_url":"https://api.github.com/users/jhadvig/repos","events_url":"https://api.github.com/users/jhadvig/events{/privacy}","received_events_url":"https://api.github.com/users/jhadvig/received_events","type":"User","site_admin":false},"repo":{"id":154319814,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQzMTk4MTQ=","name":"console-operator","full_name":"jhadvig/console-operator","private":false,"owner":{"login":"jhadvig","id":1668218,"node_id":"MDQ6VXNlcjE2NjgyMTg=","avatar_url":"https://avatars2.githubusercontent.com/u/1668218?v=4","gravatar_id":"","url":"https://api.github.com/users/jhadvig","html_url":"https://github.com/jhadvig","followers_url":"https://api.github.com/users/jhadvig/followers","following_url":"https://api.github.com/users/jhadvig/following{/other_user}","gists_url":"https://api.github.com/users/jhadvig/gists{/gist_id}","starred_url":"https://api.github.com/users/jhadvig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhadvig/subscriptions","organizations_url":"https://api.github.com/users/jhadvig/orgs","repos_url":"https://api.github.com/users/jhadvig/repos","events_url":"https://api.github.com/users/jhadvig/events{/privacy}","received_events_url":"https://api.github.com/users/jhadvig/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jhadvig/console-operator","description":"The console operator installs and maintains the web console on a cluster","fork":true,"url":"https://api.github.com/repos/jhadvig/console-operator","forks_url":"https://api.github.com/repos/jhadvig/console-operator/forks","keys_url":"https://api.github.com/repos/jhadvig/console-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jhadvig/console-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jhadvig/console-operator/teams","hooks_url":"https://api.github.com/repos/jhadvig/console-operator/hooks","issue_events_url":"https://api.github.com/repos/jhadvig/console-operator/issues/events{/number}","events_url":"https://api.github.com/repos/jhadvig/console-operator/events","assignees_url":"https://api.github.com/repos/jhadvig/console-operator/assignees{/user}","branches_url":"https://api.github.com/repos/jhadvig/console-operator/branches{/branch}","tags_url":"https://api.github.com/repos/jhadvig/console-operator/tags","blobs_url":"https://api.github.com/repos/jhadvig/console-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jhadvig/console-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jhadvig/console-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/jhadvig/console-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jhadvig/console-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/jhadvig/console-operator/languages","stargazers_url":"https://api.github.com/repos/jhadvig/console-operator/stargazers","contributors_url":"https://api.github.com/repos/jhadvig/console-operator/contributors","subscribers_url":"https://api.github.com/repos/jhadvig/console-operator/subscribers","subscription_url":"https://api.github.com/repos/jhadvig/console-operator/subscription","commits_url":"https://api.github.com/repos/jhadvig/console-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/jhadvig/console-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/jhadvig/console-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/jhadvig/console-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/jhadvig/console-operator/contents/{+path}","compare_url":"https://api.github.com/repos/jhadvig/console-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jhadvig/console-operator/merges","archive_url":"https://api.github.com/repos/jhadvig/console-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jhadvig/console-operator/downloads","issues_url":"https://api.github.com/repos/jhadvig/console-operator/issues{/number}","pulls_url":"https://api.github.com/repos/jhadvig/console-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/jhadvig/console-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/jhadvig/console-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jhadvig/console-operator/labels{/name}","releases_url":"https://api.github.com/repos/jhadvig/console-operator/releases{/id}","deployments_url":"https://api.github.com/repos/jhadvig/console-operator/deployments","created_at":"2018-10-23T11:55:24Z","updated_at":"2018-10-23T11:55:26Z","pushed_at":"2019-01-04T16:04:28Z","git_url":"git://github.com/jhadvig/console-operator.git","ssh_url":"git@github.com:jhadvig/console-operator.git","clone_url":"https://github.com/jhadvig/console-operator.git","svn_url":"https://github.com/jhadvig/console-operator","homepage":null,"size":30480,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"87e3c48643ceae706542d4dc4b0a40b9fb275b0a","user":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":148216080,"node_id":"MDEwOlJlcG9zaXRvcnkxNDgyMTYwODA=","name":"console-operator","full_name":"openshift/console-operator","private":false,"owner":{"login":"openshift","id":792337,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MjMzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openshift/console-operator","description":"The console operator installs and maintains the web console on a cluster","fork":false,"url":"https://api.github.com/repos/openshift/console-operator","forks_url":"https://api.github.com/repos/openshift/console-operator/forks","keys_url":"https://api.github.com/repos/openshift/console-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/console-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/console-operator/teams","hooks_url":"https://api.github.com/repos/openshift/console-operator/hooks","issue_events_url":"https://api.github.com/repos/openshift/console-operator/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/console-operator/events","assignees_url":"https://api.github.com/repos/openshift/console-operator/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/console-operator/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/console-operator/tags","blobs_url":"https://api.github.com/repos/openshift/console-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/console-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/console-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/console-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/console-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/console-operator/languages","stargazers_url":"https://api.github.com/repos/openshift/console-operator/stargazers","contributors_url":"https://api.github.com/repos/openshift/console-operator/contributors","subscribers_url":"https://api.github.com/repos/openshift/console-operator/subscribers","subscription_url":"https://api.github.com/repos/openshift/console-operator/subscription","commits_url":"https://api.github.com/repos/openshift/console-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/console-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/console-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/console-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/console-operator/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/console-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/console-operator/merges","archive_url":"https://api.github.com/repos/openshift/console-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/console-operator/downloads","issues_url":"https://api.github.com/repos/openshift/console-operator/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/console-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/console-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/console-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/console-operator/labels{/name}","releases_url":"https://api.github.com/repos/openshift/console-operator/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/console-operator/deployments","created_at":"2018-09-10T20:38:19Z","updated_at":"2019-01-04T20:49:08Z","pushed_at":"2019-01-04T20:49:05Z","git_url":"git://github.com/openshift/console-operator.git","ssh_url":"git@github.com:openshift/console-operator.git","clone_url":"https://github.com/openshift/console-operator.git","svn_url":"https://github.com/openshift/console-operator","homepage":null,"size":25770,"stargazers_count":6,"watchers_count":6,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":10,"open_issues":18,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/console-operator/pulls/88"},"html":{"href":"https://github.com/openshift/console-operator/pull/88"},"issue":{"href":"https://api.github.com/repos/openshift/console-operator/issues/88"},"comments":{"href":"https://api.github.com/repos/openshift/console-operator/issues/88/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/console-operator/pulls/88/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/console-operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/console-operator/pulls/88/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/console-operator/statuses/fea9947adc92a79e57cff9f8d0fa2d43a7bec6a3"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"spadgett"}}