{"action":"created","comment":{"url":"https://api.github.com/repos/fatih/vim-go/pulls/comments/179941672","pull_request_review_id":110281094,"id":179941672,"diff_hunk":"@@ -1,6 +1,17 @@\n function! go#cmd#autowrite() abort\n   if &autowrite == 1 || &autowriteall == 1\n     silent! wall\n+  else\n+    for l:nr in range(0, bufnr('$'))\n+      if buflisted(l:nr) && getbufvar(l:nr, '&modified')\n+        \" Sleep one second to make sure people see the message. Otherwise it is\n+        \" often immediacy overwritten by the async messages (which also don't\n+        \" invoke the \"hit ENTER\" prompt).\n+        call go#util#EchoWarning('[No write since last change]')\n+        sleep 1","path":"autoload/go/cmd.vim","position":11,"original_position":11,"commit_id":"dd28a570eabb3f7c7f5f4414b9961ea23cea4d85","original_commit_id":"dd28a570eabb3f7c7f5f4414b9961ea23cea4d85","user":{"login":"fatih","id":438920,"avatar_url":"https://avatars1.githubusercontent.com/u/438920?v=4","gravatar_id":"","url":"https://api.github.com/users/fatih","html_url":"https://github.com/fatih","followers_url":"https://api.github.com/users/fatih/followers","following_url":"https://api.github.com/users/fatih/following{/other_user}","gists_url":"https://api.github.com/users/fatih/gists{/gist_id}","starred_url":"https://api.github.com/users/fatih/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fatih/subscriptions","organizations_url":"https://api.github.com/users/fatih/orgs","repos_url":"https://api.github.com/users/fatih/repos","events_url":"https://api.github.com/users/fatih/events{/privacy}","received_events_url":"https://api.github.com/users/fatih/received_events","type":"User","site_admin":false},"body":"Will sleep block any other running async calls? Seems like a dangerous thing to add in that case. ","created_at":"2018-04-08T09:31:13Z","updated_at":"2018-04-08T09:31:13Z","html_url":"https://github.com/fatih/vim-go/pull/1754#discussion_r179941672","pull_request_url":"https://api.github.com/repos/fatih/vim-go/pulls/1754","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/fatih/vim-go/pulls/comments/179941672"},"html":{"href":"https://github.com/fatih/vim-go/pull/1754#discussion_r179941672"},"pull_request":{"href":"https://api.github.com/repos/fatih/vim-go/pulls/1754"}}},"pull_request":{"url":"https://api.github.com/repos/fatih/vim-go/pulls/1754","id":179485354,"html_url":"https://github.com/fatih/vim-go/pull/1754","diff_url":"https://github.com/fatih/vim-go/pull/1754.diff","patch_url":"https://github.com/fatih/vim-go/pull/1754.patch","issue_url":"https://api.github.com/repos/fatih/vim-go/issues/1754","number":1754,"state":"closed","locked":false,"title":"Warn when running go#cmd#autowrite() without autowrite enabled","user":{"login":"Carpetsmoker","id":1032692,"avatar_url":"https://avatars1.githubusercontent.com/u/1032692?v=4","gravatar_id":"","url":"https://api.github.com/users/Carpetsmoker","html_url":"https://github.com/Carpetsmoker","followers_url":"https://api.github.com/users/Carpetsmoker/followers","following_url":"https://api.github.com/users/Carpetsmoker/following{/other_user}","gists_url":"https://api.github.com/users/Carpetsmoker/gists{/gist_id}","starred_url":"https://api.github.com/users/Carpetsmoker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Carpetsmoker/subscriptions","organizations_url":"https://api.github.com/users/Carpetsmoker/orgs","repos_url":"https://api.github.com/users/Carpetsmoker/repos","events_url":"https://api.github.com/users/Carpetsmoker/events{/privacy}","received_events_url":"https://api.github.com/users/Carpetsmoker/received_events","type":"User","site_admin":false},"body":"The `go#cmd#autowrite()` will write buffers to disk for commands that\r\noperate on files (rather than buffers). This is useful, but if you\r\n*don't* have this option enabled you never get an error message.\r\n\r\nThis changed that to show a non-fatal warning. This is the same\r\nbehaviour as the `:make` command.\r\n\r\nRight now this doesn't work very well because the various status\r\nmessages from the jobs push the error away, making it hard to see (I\r\ndon't get the expected \"hit enter\" prompt), so we need a better solution\r\nfor that first.","created_at":"2018-04-04T19:12:59Z","updated_at":"2018-04-08T09:31:13Z","closed_at":"2018-04-08T00:23:26Z","merged_at":"2018-04-08T00:23:26Z","merge_commit_sha":"83796513c573ebc3513f20a602bfb9830357acb5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fatih/vim-go/pulls/1754/commits","review_comments_url":"https://api.github.com/repos/fatih/vim-go/pulls/1754/comments","review_comment_url":"https://api.github.com/repos/fatih/vim-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fatih/vim-go/issues/1754/comments","statuses_url":"https://api.github.com/repos/fatih/vim-go/statuses/dd28a570eabb3f7c7f5f4414b9961ea23cea4d85","head":{"label":"Carpetsmoker:warn-unsaved","ref":"warn-unsaved","sha":"dd28a570eabb3f7c7f5f4414b9961ea23cea4d85","user":{"login":"Carpetsmoker","id":1032692,"avatar_url":"https://avatars1.githubusercontent.com/u/1032692?v=4","gravatar_id":"","url":"https://api.github.com/users/Carpetsmoker","html_url":"https://github.com/Carpetsmoker","followers_url":"https://api.github.com/users/Carpetsmoker/followers","following_url":"https://api.github.com/users/Carpetsmoker/following{/other_user}","gists_url":"https://api.github.com/users/Carpetsmoker/gists{/gist_id}","starred_url":"https://api.github.com/users/Carpetsmoker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Carpetsmoker/subscriptions","organizations_url":"https://api.github.com/users/Carpetsmoker/orgs","repos_url":"https://api.github.com/users/Carpetsmoker/repos","events_url":"https://api.github.com/users/Carpetsmoker/events{/privacy}","received_events_url":"https://api.github.com/users/Carpetsmoker/received_events","type":"User","site_admin":false},"repo":{"id":90394825,"name":"vim-go","full_name":"Carpetsmoker/vim-go","owner":{"login":"Carpetsmoker","id":1032692,"avatar_url":"https://avatars1.githubusercontent.com/u/1032692?v=4","gravatar_id":"","url":"https://api.github.com/users/Carpetsmoker","html_url":"https://github.com/Carpetsmoker","followers_url":"https://api.github.com/users/Carpetsmoker/followers","following_url":"https://api.github.com/users/Carpetsmoker/following{/other_user}","gists_url":"https://api.github.com/users/Carpetsmoker/gists{/gist_id}","starred_url":"https://api.github.com/users/Carpetsmoker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Carpetsmoker/subscriptions","organizations_url":"https://api.github.com/users/Carpetsmoker/orgs","repos_url":"https://api.github.com/users/Carpetsmoker/repos","events_url":"https://api.github.com/users/Carpetsmoker/events{/privacy}","received_events_url":"https://api.github.com/users/Carpetsmoker/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Carpetsmoker/vim-go","description":"Go development plugin for Vim","fork":true,"url":"https://api.github.com/repos/Carpetsmoker/vim-go","forks_url":"https://api.github.com/repos/Carpetsmoker/vim-go/forks","keys_url":"https://api.github.com/repos/Carpetsmoker/vim-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Carpetsmoker/vim-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Carpetsmoker/vim-go/teams","hooks_url":"https://api.github.com/repos/Carpetsmoker/vim-go/hooks","issue_events_url":"https://api.github.com/repos/Carpetsmoker/vim-go/issues/events{/number}","events_url":"https://api.github.com/repos/Carpetsmoker/vim-go/events","assignees_url":"https://api.github.com/repos/Carpetsmoker/vim-go/assignees{/user}","branches_url":"https://api.github.com/repos/Carpetsmoker/vim-go/branches{/branch}","tags_url":"https://api.github.com/repos/Carpetsmoker/vim-go/tags","blobs_url":"https://api.github.com/repos/Carpetsmoker/vim-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Carpetsmoker/vim-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Carpetsmoker/vim-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/Carpetsmoker/vim-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Carpetsmoker/vim-go/statuses/{sha}","languages_url":"https://api.github.com/repos/Carpetsmoker/vim-go/languages","stargazers_url":"https://api.github.com/repos/Carpetsmoker/vim-go/stargazers","contributors_url":"https://api.github.com/repos/Carpetsmoker/vim-go/contributors","subscribers_url":"https://api.github.com/repos/Carpetsmoker/vim-go/subscribers","subscription_url":"https://api.github.com/repos/Carpetsmoker/vim-go/subscription","commits_url":"https://api.github.com/repos/Carpetsmoker/vim-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/Carpetsmoker/vim-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/Carpetsmoker/vim-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/Carpetsmoker/vim-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/Carpetsmoker/vim-go/contents/{+path}","compare_url":"https://api.github.com/repos/Carpetsmoker/vim-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Carpetsmoker/vim-go/merges","archive_url":"https://api.github.com/repos/Carpetsmoker/vim-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Carpetsmoker/vim-go/downloads","issues_url":"https://api.github.com/repos/Carpetsmoker/vim-go/issues{/number}","pulls_url":"https://api.github.com/repos/Carpetsmoker/vim-go/pulls{/number}","milestones_url":"https://api.github.com/repos/Carpetsmoker/vim-go/milestones{/number}","notifications_url":"https://api.github.com/repos/Carpetsmoker/vim-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Carpetsmoker/vim-go/labels{/name}","releases_url":"https://api.github.com/repos/Carpetsmoker/vim-go/releases{/id}","deployments_url":"https://api.github.com/repos/Carpetsmoker/vim-go/deployments","created_at":"2017-05-05T16:15:10Z","updated_at":"2018-04-07T20:07:59Z","pushed_at":"2018-04-08T02:12:47Z","git_url":"git://github.com/Carpetsmoker/vim-go.git","ssh_url":"git@github.com:Carpetsmoker/vim-go.git","clone_url":"https://github.com/Carpetsmoker/vim-go.git","svn_url":"https://github.com/Carpetsmoker/vim-go","homepage":"","size":3629,"stargazers_count":0,"watchers_count":0,"language":"Vim script","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fatih:master","ref":"master","sha":"32ae8640716530bd55062379177da51efb37dfd2","user":{"login":"fatih","id":438920,"avatar_url":"https://avatars1.githubusercontent.com/u/438920?v=4","gravatar_id":"","url":"https://api.github.com/users/fatih","html_url":"https://github.com/fatih","followers_url":"https://api.github.com/users/fatih/followers","following_url":"https://api.github.com/users/fatih/following{/other_user}","gists_url":"https://api.github.com/users/fatih/gists{/gist_id}","starred_url":"https://api.github.com/users/fatih/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fatih/subscriptions","organizations_url":"https://api.github.com/users/fatih/orgs","repos_url":"https://api.github.com/users/fatih/repos","events_url":"https://api.github.com/users/fatih/events{/privacy}","received_events_url":"https://api.github.com/users/fatih/received_events","type":"User","site_admin":false},"repo":{"id":18062944,"name":"vim-go","full_name":"fatih/vim-go","owner":{"login":"fatih","id":438920,"avatar_url":"https://avatars1.githubusercontent.com/u/438920?v=4","gravatar_id":"","url":"https://api.github.com/users/fatih","html_url":"https://github.com/fatih","followers_url":"https://api.github.com/users/fatih/followers","following_url":"https://api.github.com/users/fatih/following{/other_user}","gists_url":"https://api.github.com/users/fatih/gists{/gist_id}","starred_url":"https://api.github.com/users/fatih/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fatih/subscriptions","organizations_url":"https://api.github.com/users/fatih/orgs","repos_url":"https://api.github.com/users/fatih/repos","events_url":"https://api.github.com/users/fatih/events{/privacy}","received_events_url":"https://api.github.com/users/fatih/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fatih/vim-go","description":"Go development plugin for Vim","fork":false,"url":"https://api.github.com/repos/fatih/vim-go","forks_url":"https://api.github.com/repos/fatih/vim-go/forks","keys_url":"https://api.github.com/repos/fatih/vim-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fatih/vim-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fatih/vim-go/teams","hooks_url":"https://api.github.com/repos/fatih/vim-go/hooks","issue_events_url":"https://api.github.com/repos/fatih/vim-go/issues/events{/number}","events_url":"https://api.github.com/repos/fatih/vim-go/events","assignees_url":"https://api.github.com/repos/fatih/vim-go/assignees{/user}","branches_url":"https://api.github.com/repos/fatih/vim-go/branches{/branch}","tags_url":"https://api.github.com/repos/fatih/vim-go/tags","blobs_url":"https://api.github.com/repos/fatih/vim-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fatih/vim-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fatih/vim-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/fatih/vim-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fatih/vim-go/statuses/{sha}","languages_url":"https://api.github.com/repos/fatih/vim-go/languages","stargazers_url":"https://api.github.com/repos/fatih/vim-go/stargazers","contributors_url":"https://api.github.com/repos/fatih/vim-go/contributors","subscribers_url":"https://api.github.com/repos/fatih/vim-go/subscribers","subscription_url":"https://api.github.com/repos/fatih/vim-go/subscription","commits_url":"https://api.github.com/repos/fatih/vim-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/fatih/vim-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/fatih/vim-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/fatih/vim-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/fatih/vim-go/contents/{+path}","compare_url":"https://api.github.com/repos/fatih/vim-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fatih/vim-go/merges","archive_url":"https://api.github.com/repos/fatih/vim-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fatih/vim-go/downloads","issues_url":"https://api.github.com/repos/fatih/vim-go/issues{/number}","pulls_url":"https://api.github.com/repos/fatih/vim-go/pulls{/number}","milestones_url":"https://api.github.com/repos/fatih/vim-go/milestones{/number}","notifications_url":"https://api.github.com/repos/fatih/vim-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fatih/vim-go/labels{/name}","releases_url":"https://api.github.com/repos/fatih/vim-go/releases{/id}","deployments_url":"https://api.github.com/repos/fatih/vim-go/deployments","created_at":"2014-03-24T13:12:26Z","updated_at":"2018-04-08T07:05:57Z","pushed_at":"2018-04-08T02:45:41Z","git_url":"git://github.com/fatih/vim-go.git","ssh_url":"git@github.com:fatih/vim-go.git","clone_url":"https://github.com/fatih/vim-go.git","svn_url":"https://github.com/fatih/vim-go","homepage":"https://patreon.com/fatih","size":3565,"stargazers_count":8262,"watchers_count":8262,"language":"Vim script","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":846,"mirror_url":null,"archived":false,"open_issues_count":48,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":846,"open_issues":48,"watchers":8262,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fatih/vim-go/pulls/1754"},"html":{"href":"https://github.com/fatih/vim-go/pull/1754"},"issue":{"href":"https://api.github.com/repos/fatih/vim-go/issues/1754"},"comments":{"href":"https://api.github.com/repos/fatih/vim-go/issues/1754/comments"},"review_comments":{"href":"https://api.github.com/repos/fatih/vim-go/pulls/1754/comments"},"review_comment":{"href":"https://api.github.com/repos/fatih/vim-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fatih/vim-go/pulls/1754/commits"},"statuses":{"href":"https://api.github.com/repos/fatih/vim-go/statuses/dd28a570eabb3f7c7f5f4414b9961ea23cea4d85"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"fatih"}}