{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/170406272","pull_request_review_id":99097185,"id":170406272,"diff_hunk":"@@ -4008,6 +4008,23 @@ void OSD::load_pgs()\n     // read pg state, log\n     pg->read_state(store);\n \n+    if (pg->dne())  {\n+      dout(10) << \"load_pgs \" << *it << \" deleting dne\" << dendl;\n+      pg->ch = nullptr;\n+      service.pg_remove_epoch(pg->pg_id);\n+      pg->unlock();\n+      // Delete pg\n+      RWLock::WLocker l(pg_map_lock);","path":"src/osd/OSD.cc","position":10,"original_position":10,"commit_id":"cb898dd2a93f00cdb204519ba3f990dabec89b0e","original_commit_id":"cb898dd2a93f00cdb204519ba3f990dabec89b0e","user":{"login":"gregsfortytwo","id":908479,"avatar_url":"https://avatars2.githubusercontent.com/u/908479?v=4","gravatar_id":"","url":"https://api.github.com/users/gregsfortytwo","html_url":"https://github.com/gregsfortytwo","followers_url":"https://api.github.com/users/gregsfortytwo/followers","following_url":"https://api.github.com/users/gregsfortytwo/following{/other_user}","gists_url":"https://api.github.com/users/gregsfortytwo/gists{/gist_id}","starred_url":"https://api.github.com/users/gregsfortytwo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregsfortytwo/subscriptions","organizations_url":"https://api.github.com/users/gregsfortytwo/orgs","repos_url":"https://api.github.com/users/gregsfortytwo/repos","events_url":"https://api.github.com/users/gregsfortytwo/events{/privacy}","received_events_url":"https://api.github.com/users/gregsfortytwo/received_events","type":"User","site_admin":false},"body":"I'm not sure it matters at this point in the boot process, but we need to drop this before invoking recursive_remove_collection() since that prompts disk accesses. I'd just put a block around the pg_map modifying bits.","created_at":"2018-02-24T01:54:56Z","updated_at":"2018-02-24T01:55:12Z","html_url":"https://github.com/ceph/ceph/pull/20571#discussion_r170406272","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/20571","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/170406272"},"html":{"href":"https://github.com/ceph/ceph/pull/20571#discussion_r170406272"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/20571"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/20571","id":171106085,"html_url":"https://github.com/ceph/ceph/pull/20571","diff_url":"https://github.com/ceph/ceph/pull/20571.diff","patch_url":"https://github.com/ceph/ceph/pull/20571.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/20571","number":20571,"state":"open","locked":false,"title":"\"FAILED assert(p.same_interval_since)\", without importing PG?","user":{"login":"dzafman","id":2467610,"avatar_url":"https://avatars0.githubusercontent.com/u/2467610?v=4","gravatar_id":"","url":"https://api.github.com/users/dzafman","html_url":"https://github.com/dzafman","followers_url":"https://api.github.com/users/dzafman/followers","following_url":"https://api.github.com/users/dzafman/following{/other_user}","gists_url":"https://api.github.com/users/dzafman/gists{/gist_id}","starred_url":"https://api.github.com/users/dzafman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzafman/subscriptions","organizations_url":"https://api.github.com/users/dzafman/orgs","repos_url":"https://api.github.com/users/dzafman/repos","events_url":"https://api.github.com/users/dzafman/events{/privacy}","received_events_url":"https://api.github.com/users/dzafman/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-23T20:13:51Z","updated_at":"2018-02-24T01:55:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a3a189be7a7e6774f38af59f7486a973789e5374","assignee":null,"assignees":[],"requested_reviewers":[{"login":"liewegas","id":433031,"avatar_url":"https://avatars1.githubusercontent.com/u/433031?v=4","gravatar_id":"","url":"https://api.github.com/users/liewegas","html_url":"https://github.com/liewegas","followers_url":"https://api.github.com/users/liewegas/followers","following_url":"https://api.github.com/users/liewegas/following{/other_user}","gists_url":"https://api.github.com/users/liewegas/gists{/gist_id}","starred_url":"https://api.github.com/users/liewegas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liewegas/subscriptions","organizations_url":"https://api.github.com/users/liewegas/orgs","repos_url":"https://api.github.com/users/liewegas/repos","events_url":"https://api.github.com/users/liewegas/events{/privacy}","received_events_url":"https://api.github.com/users/liewegas/received_events","type":"User","site_admin":false},{"login":"jdurgin","id":1022584,"avatar_url":"https://avatars2.githubusercontent.com/u/1022584?v=4","gravatar_id":"","url":"https://api.github.com/users/jdurgin","html_url":"https://github.com/jdurgin","followers_url":"https://api.github.com/users/jdurgin/followers","following_url":"https://api.github.com/users/jdurgin/following{/other_user}","gists_url":"https://api.github.com/users/jdurgin/gists{/gist_id}","starred_url":"https://api.github.com/users/jdurgin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jdurgin/subscriptions","organizations_url":"https://api.github.com/users/jdurgin/orgs","repos_url":"https://api.github.com/users/jdurgin/repos","events_url":"https://api.github.com/users/jdurgin/events{/privacy}","received_events_url":"https://api.github.com/users/jdurgin/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":134774049,"url":"https://api.github.com/repos/ceph/ceph/labels/bug%20fix","name":"bug fix","color":"ac0000","default":false},{"id":144329561,"url":"https://api.github.com/repos/ceph/ceph/labels/core","name":"core","color":"0041a2","default":false},{"id":148431321,"url":"https://api.github.com/repos/ceph/ceph/labels/needs-qa","name":"needs-qa","color":"fad8c7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/20571/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/20571/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/20571/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/cb898dd2a93f00cdb204519ba3f990dabec89b0e","head":{"label":"dzafman:wip-21833-2","ref":"wip-21833-2","sha":"cb898dd2a93f00cdb204519ba3f990dabec89b0e","user":{"login":"dzafman","id":2467610,"avatar_url":"https://avatars0.githubusercontent.com/u/2467610?v=4","gravatar_id":"","url":"https://api.github.com/users/dzafman","html_url":"https://github.com/dzafman","followers_url":"https://api.github.com/users/dzafman/followers","following_url":"https://api.github.com/users/dzafman/following{/other_user}","gists_url":"https://api.github.com/users/dzafman/gists{/gist_id}","starred_url":"https://api.github.com/users/dzafman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzafman/subscriptions","organizations_url":"https://api.github.com/users/dzafman/orgs","repos_url":"https://api.github.com/users/dzafman/repos","events_url":"https://api.github.com/users/dzafman/events{/privacy}","received_events_url":"https://api.github.com/users/dzafman/received_events","type":"User","site_admin":false},"repo":{"id":7757983,"name":"ceph","full_name":"dzafman/ceph","owner":{"login":"dzafman","id":2467610,"avatar_url":"https://avatars0.githubusercontent.com/u/2467610?v=4","gravatar_id":"","url":"https://api.github.com/users/dzafman","html_url":"https://github.com/dzafman","followers_url":"https://api.github.com/users/dzafman/followers","following_url":"https://api.github.com/users/dzafman/following{/other_user}","gists_url":"https://api.github.com/users/dzafman/gists{/gist_id}","starred_url":"https://api.github.com/users/dzafman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dzafman/subscriptions","organizations_url":"https://api.github.com/users/dzafman/orgs","repos_url":"https://api.github.com/users/dzafman/repos","events_url":"https://api.github.com/users/dzafman/events{/privacy}","received_events_url":"https://api.github.com/users/dzafman/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dzafman/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/dzafman/ceph","forks_url":"https://api.github.com/repos/dzafman/ceph/forks","keys_url":"https://api.github.com/repos/dzafman/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dzafman/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dzafman/ceph/teams","hooks_url":"https://api.github.com/repos/dzafman/ceph/hooks","issue_events_url":"https://api.github.com/repos/dzafman/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/dzafman/ceph/events","assignees_url":"https://api.github.com/repos/dzafman/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/dzafman/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/dzafman/ceph/tags","blobs_url":"https://api.github.com/repos/dzafman/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dzafman/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dzafman/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/dzafman/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dzafman/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/dzafman/ceph/languages","stargazers_url":"https://api.github.com/repos/dzafman/ceph/stargazers","contributors_url":"https://api.github.com/repos/dzafman/ceph/contributors","subscribers_url":"https://api.github.com/repos/dzafman/ceph/subscribers","subscription_url":"https://api.github.com/repos/dzafman/ceph/subscription","commits_url":"https://api.github.com/repos/dzafman/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/dzafman/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/dzafman/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/dzafman/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/dzafman/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/dzafman/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dzafman/ceph/merges","archive_url":"https://api.github.com/repos/dzafman/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dzafman/ceph/downloads","issues_url":"https://api.github.com/repos/dzafman/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/dzafman/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/dzafman/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/dzafman/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dzafman/ceph/labels{/name}","releases_url":"https://api.github.com/repos/dzafman/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/dzafman/ceph/deployments","created_at":"2013-01-22T18:07:43Z","updated_at":"2014-06-25T02:23:55Z","pushed_at":"2018-02-23T20:07:56Z","git_url":"git://github.com/dzafman/ceph.git","ssh_url":"git@github.com:dzafman/ceph.git","clone_url":"https://github.com/dzafman/ceph.git","svn_url":"https://github.com/dzafman/ceph","homepage":"http://ceph.com","size":265944,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"15e537e418e1e58c5d3f1e0629dad6baf1214510","user":{"login":"ceph","id":1015767,"avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2018-02-24T01:51:44Z","pushed_at":"2018-02-24T00:59:11Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":269610,"stargazers_count":4145,"watchers_count":4145,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2322,"mirror_url":null,"archived":false,"open_issues_count":643,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2322,"open_issues":643,"watchers":4145,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/20571"},"html":{"href":"https://github.com/ceph/ceph/pull/20571"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/20571"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/20571/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/20571/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/20571/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/cb898dd2a93f00cdb204519ba3f990dabec89b0e"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"gregsfortytwo"}}