{"action":"created","issue":{"url":"https://api.github.com/repos/TEAMMATES/teammates/issues/8833","repository_url":"https://api.github.com/repos/TEAMMATES/teammates","labels_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/8833/labels{/name}","comments_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/8833/comments","events_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/8833/events","html_url":"https://github.com/TEAMMATES/teammates/pull/8833","id":323905491,"number":8833,"title":"Spreadsheet Interface for Student Data UI: Initial upgrade for instructorCourseEnrollPage #8832","user":{"login":"tanhengyeow","id":25320782,"avatar_url":"https://avatars3.githubusercontent.com/u/25320782?v=4","gravatar_id":"","url":"https://api.github.com/users/tanhengyeow","html_url":"https://github.com/tanhengyeow","followers_url":"https://api.github.com/users/tanhengyeow/followers","following_url":"https://api.github.com/users/tanhengyeow/following{/other_user}","gists_url":"https://api.github.com/users/tanhengyeow/gists{/gist_id}","starred_url":"https://api.github.com/users/tanhengyeow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tanhengyeow/subscriptions","organizations_url":"https://api.github.com/users/tanhengyeow/orgs","repos_url":"https://api.github.com/users/tanhengyeow/repos","events_url":"https://api.github.com/users/tanhengyeow/events{/privacy}","received_events_url":"https://api.github.com/users/tanhengyeow/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-05-17T07:38:21Z","updated_at":"2018-05-24T15:04:02Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/TEAMMATES/teammates/pulls/8833","html_url":"https://github.com/TEAMMATES/teammates/pull/8833","diff_url":"https://github.com/TEAMMATES/teammates/pull/8833.diff","patch_url":"https://github.com/TEAMMATES/teammates/pull/8833.patch"},"body":"Fixes #8832\r\n\r\n**New changes on top of #7568 :**\r\n1. Updated proposed changes according to reviews\r\n    1. Ported over `Handsontable` code to `instructorCourseEnroll.js`\r\n    2. Minimized use of global variables when not needed\r\n    3. Improved code quality (constraints from ESLint considered)\r\n2. Tweaked UI\r\n3. Fixed existing issues:\r\n    1. Set maxRows to `100` to prevent misuse of creating large number of rows\r\n    2. Updated CSS to prevent horizontal overflow instead of using [proposed implementation](https://github.com/TEAMMATES/teammates/pull/7568/files#diff-152945d20bd61d24b1f830250b3493d7R86)\r\n4. Refactored code to further improve code quality and testability\r\n    1. Added `instructorCourseEnrollHelper.js` to serve helper functions for `instructorCourseEnrollPage.js`\r\n5. Added QUnit tests to test helper functions in `instructorCourseEnrollHelper.js`\r\n\r\n**Current UI/Walkthrough**:\r\n\r\n![image](https://user-images.githubusercontent.com/25320782/40162114-70faaa0c-59e5-11e8-91cc-112eb9e962e1.png)\r\n![image](https://user-images.githubusercontent.com/25320782/40162136-83be063e-59e5-11e8-8bfa-19a56405e014.png)\r\n\r\n![ssv1 0](https://user-images.githubusercontent.com/25320782/40161459-648cfee8-59e3-11e8-936f-b2551ec15fd0.gif)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/TEAMMATES/teammates/issues/comments/391748250","html_url":"https://github.com/TEAMMATES/teammates/pull/8833#issuecomment-391748250","issue_url":"https://api.github.com/repos/TEAMMATES/teammates/issues/8833","id":391748250,"user":{"login":"tanhengyeow","id":25320782,"avatar_url":"https://avatars3.githubusercontent.com/u/25320782?v=4","gravatar_id":"","url":"https://api.github.com/users/tanhengyeow","html_url":"https://github.com/tanhengyeow","followers_url":"https://api.github.com/users/tanhengyeow/followers","following_url":"https://api.github.com/users/tanhengyeow/following{/other_user}","gists_url":"https://api.github.com/users/tanhengyeow/gists{/gist_id}","starred_url":"https://api.github.com/users/tanhengyeow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tanhengyeow/subscriptions","organizations_url":"https://api.github.com/users/tanhengyeow/orgs","repos_url":"https://api.github.com/users/tanhengyeow/repos","events_url":"https://api.github.com/users/tanhengyeow/events{/privacy}","received_events_url":"https://api.github.com/users/tanhengyeow/received_events","type":"User","site_admin":false},"created_at":"2018-05-24T15:04:02Z","updated_at":"2018-05-24T15:04:02Z","author_association":"MEMBER","body":"Ready for review @damithc @wkurniawan07 @tran-tien-dat "}}
{"actor":{"display_login":"tanhengyeow"}}