{"action":"closed","number":104,"pull_request":{"url":"https://api.github.com/repos/facebookresearch/pytext/pulls/104","id":238610522,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4NjEwNTIy","html_url":"https://github.com/facebookresearch/pytext/pull/104","diff_url":"https://github.com/facebookresearch/pytext/pull/104.diff","patch_url":"https://github.com/facebookresearch/pytext/pull/104.patch","issue_url":"https://api.github.com/repos/facebookresearch/pytext/issues/104","number":104,"state":"closed","locked":false,"title":"Fix Config in atis tutorial","user":{"login":"m3rlin45","id":2054801,"node_id":"MDQ6VXNlcjIwNTQ4MDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2054801?v=4","gravatar_id":"","url":"https://api.github.com/users/m3rlin45","html_url":"https://github.com/m3rlin45","followers_url":"https://api.github.com/users/m3rlin45/followers","following_url":"https://api.github.com/users/m3rlin45/following{/other_user}","gists_url":"https://api.github.com/users/m3rlin45/gists{/gist_id}","starred_url":"https://api.github.com/users/m3rlin45/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3rlin45/subscriptions","organizations_url":"https://api.github.com/users/m3rlin45/orgs","repos_url":"https://api.github.com/users/m3rlin45/repos","events_url":"https://api.github.com/users/m3rlin45/events{/privacy}","received_events_url":"https://api.github.com/users/m3rlin45/received_events","type":"User","site_admin":false},"body":"Summary:\r\nThe config example we give in the docs doesn't actually work, this fixes it\r\nTest Plan:\r\n\r\n\r\n## Motivation and Context\r\n\r\nTutorial config is wrong\r\n\r\n## How Has This Been Tested\r\nI ran atis training using this config\r\n\r\n## Types of changes\r\n\r\n- [x ] Docs change / refactoring / dependency upgrade\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist\r\n\r\n- [ x] My code follows the code style of this project.\r\n- [ x] My change requires a change to the documentation.\r\n- [ x] I have updated the documentation accordingly.\r\n- [ x] I have read the **CONTRIBUTING** document.\r\n- [ x] I have completed my CLA (see **CONTRIBUTING**)\r\n- [x ] I have added tests to cover my changes.\r\n- [x ] All new and existing tests passed.\r\n","created_at":"2018-12-14T04:53:01Z","updated_at":"2018-12-14T05:59:27Z","closed_at":"2018-12-14T05:59:27Z","merged_at":null,"merge_commit_sha":"f5c50bf44f40b379e21917e39e51b29a0d26295f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1010851268,"node_id":"MDU6TGFiZWwxMDEwODUxMjY4","url":"https://api.github.com/repos/facebookresearch/pytext/labels/CLA%20Signed","name":"CLA Signed","color":"009900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/facebookresearch/pytext/pulls/104/commits","review_comments_url":"https://api.github.com/repos/facebookresearch/pytext/pulls/104/comments","review_comment_url":"https://api.github.com/repos/facebookresearch/pytext/pulls/comments{/number}","comments_url":"https://api.github.com/repos/facebookresearch/pytext/issues/104/comments","statuses_url":"https://api.github.com/repos/facebookresearch/pytext/statuses/60ba7c0a2731364055f0f05b60d6ce40760ae113","head":{"label":"m3rlin45:fix_atis","ref":"fix_atis","sha":"60ba7c0a2731364055f0f05b60d6ce40760ae113","user":{"login":"m3rlin45","id":2054801,"node_id":"MDQ6VXNlcjIwNTQ4MDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2054801?v=4","gravatar_id":"","url":"https://api.github.com/users/m3rlin45","html_url":"https://github.com/m3rlin45","followers_url":"https://api.github.com/users/m3rlin45/followers","following_url":"https://api.github.com/users/m3rlin45/following{/other_user}","gists_url":"https://api.github.com/users/m3rlin45/gists{/gist_id}","starred_url":"https://api.github.com/users/m3rlin45/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3rlin45/subscriptions","organizations_url":"https://api.github.com/users/m3rlin45/orgs","repos_url":"https://api.github.com/users/m3rlin45/repos","events_url":"https://api.github.com/users/m3rlin45/events{/privacy}","received_events_url":"https://api.github.com/users/m3rlin45/received_events","type":"User","site_admin":false},"repo":{"id":161732963,"node_id":"MDEwOlJlcG9zaXRvcnkxNjE3MzI5NjM=","name":"pytext-1","full_name":"m3rlin45/pytext-1","private":false,"owner":{"login":"m3rlin45","id":2054801,"node_id":"MDQ6VXNlcjIwNTQ4MDE=","avatar_url":"https://avatars0.githubusercontent.com/u/2054801?v=4","gravatar_id":"","url":"https://api.github.com/users/m3rlin45","html_url":"https://github.com/m3rlin45","followers_url":"https://api.github.com/users/m3rlin45/followers","following_url":"https://api.github.com/users/m3rlin45/following{/other_user}","gists_url":"https://api.github.com/users/m3rlin45/gists{/gist_id}","starred_url":"https://api.github.com/users/m3rlin45/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m3rlin45/subscriptions","organizations_url":"https://api.github.com/users/m3rlin45/orgs","repos_url":"https://api.github.com/users/m3rlin45/repos","events_url":"https://api.github.com/users/m3rlin45/events{/privacy}","received_events_url":"https://api.github.com/users/m3rlin45/received_events","type":"User","site_admin":false},"html_url":"https://github.com/m3rlin45/pytext-1","description":"A natural language modeling framework based on PyTorch","fork":true,"url":"https://api.github.com/repos/m3rlin45/pytext-1","forks_url":"https://api.github.com/repos/m3rlin45/pytext-1/forks","keys_url":"https://api.github.com/repos/m3rlin45/pytext-1/keys{/key_id}","collaborators_url":"https://api.github.com/repos/m3rlin45/pytext-1/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/m3rlin45/pytext-1/teams","hooks_url":"https://api.github.com/repos/m3rlin45/pytext-1/hooks","issue_events_url":"https://api.github.com/repos/m3rlin45/pytext-1/issues/events{/number}","events_url":"https://api.github.com/repos/m3rlin45/pytext-1/events","assignees_url":"https://api.github.com/repos/m3rlin45/pytext-1/assignees{/user}","branches_url":"https://api.github.com/repos/m3rlin45/pytext-1/branches{/branch}","tags_url":"https://api.github.com/repos/m3rlin45/pytext-1/tags","blobs_url":"https://api.github.com/repos/m3rlin45/pytext-1/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/m3rlin45/pytext-1/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/m3rlin45/pytext-1/git/refs{/sha}","trees_url":"https://api.github.com/repos/m3rlin45/pytext-1/git/trees{/sha}","statuses_url":"https://api.github.com/repos/m3rlin45/pytext-1/statuses/{sha}","languages_url":"https://api.github.com/repos/m3rlin45/pytext-1/languages","stargazers_url":"https://api.github.com/repos/m3rlin45/pytext-1/stargazers","contributors_url":"https://api.github.com/repos/m3rlin45/pytext-1/contributors","subscribers_url":"https://api.github.com/repos/m3rlin45/pytext-1/subscribers","subscription_url":"https://api.github.com/repos/m3rlin45/pytext-1/subscription","commits_url":"https://api.github.com/repos/m3rlin45/pytext-1/commits{/sha}","git_commits_url":"https://api.github.com/repos/m3rlin45/pytext-1/git/commits{/sha}","comments_url":"https://api.github.com/repos/m3rlin45/pytext-1/comments{/number}","issue_comment_url":"https://api.github.com/repos/m3rlin45/pytext-1/issues/comments{/number}","contents_url":"https://api.github.com/repos/m3rlin45/pytext-1/contents/{+path}","compare_url":"https://api.github.com/repos/m3rlin45/pytext-1/compare/{base}...{head}","merges_url":"https://api.github.com/repos/m3rlin45/pytext-1/merges","archive_url":"https://api.github.com/repos/m3rlin45/pytext-1/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/m3rlin45/pytext-1/downloads","issues_url":"https://api.github.com/repos/m3rlin45/pytext-1/issues{/number}","pulls_url":"https://api.github.com/repos/m3rlin45/pytext-1/pulls{/number}","milestones_url":"https://api.github.com/repos/m3rlin45/pytext-1/milestones{/number}","notifications_url":"https://api.github.com/repos/m3rlin45/pytext-1/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/m3rlin45/pytext-1/labels{/name}","releases_url":"https://api.github.com/repos/m3rlin45/pytext-1/releases{/id}","deployments_url":"https://api.github.com/repos/m3rlin45/pytext-1/deployments","created_at":"2018-12-14T04:49:34Z","updated_at":"2018-12-14T04:49:36Z","pushed_at":"2018-12-14T04:51:51Z","git_url":"git://github.com/m3rlin45/pytext-1.git","ssh_url":"git@github.com:m3rlin45/pytext-1.git","clone_url":"https://github.com/m3rlin45/pytext-1.git","svn_url":"https://github.com/m3rlin45/pytext-1","homepage":null,"size":564,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"facebookresearch:master","ref":"master","sha":"4f3042ca087d0b630e8b169d5e20af8065bc57b8","user":{"login":"facebookresearch","id":16943930,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2OTQzOTMw","avatar_url":"https://avatars0.githubusercontent.com/u/16943930?v=4","gravatar_id":"","url":"https://api.github.com/users/facebookresearch","html_url":"https://github.com/facebookresearch","followers_url":"https://api.github.com/users/facebookresearch/followers","following_url":"https://api.github.com/users/facebookresearch/following{/other_user}","gists_url":"https://api.github.com/users/facebookresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/facebookresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebookresearch/subscriptions","organizations_url":"https://api.github.com/users/facebookresearch/orgs","repos_url":"https://api.github.com/users/facebookresearch/repos","events_url":"https://api.github.com/users/facebookresearch/events{/privacy}","received_events_url":"https://api.github.com/users/facebookresearch/received_events","type":"Organization","site_admin":false},"repo":{"id":143080897,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMwODA4OTc=","name":"pytext","full_name":"facebookresearch/pytext","private":false,"owner":{"login":"facebookresearch","id":16943930,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2OTQzOTMw","avatar_url":"https://avatars0.githubusercontent.com/u/16943930?v=4","gravatar_id":"","url":"https://api.github.com/users/facebookresearch","html_url":"https://github.com/facebookresearch","followers_url":"https://api.github.com/users/facebookresearch/followers","following_url":"https://api.github.com/users/facebookresearch/following{/other_user}","gists_url":"https://api.github.com/users/facebookresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/facebookresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facebookresearch/subscriptions","organizations_url":"https://api.github.com/users/facebookresearch/orgs","repos_url":"https://api.github.com/users/facebookresearch/repos","events_url":"https://api.github.com/users/facebookresearch/events{/privacy}","received_events_url":"https://api.github.com/users/facebookresearch/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/facebookresearch/pytext","description":"A natural language modeling framework based on PyTorch","fork":false,"url":"https://api.github.com/repos/facebookresearch/pytext","forks_url":"https://api.github.com/repos/facebookresearch/pytext/forks","keys_url":"https://api.github.com/repos/facebookresearch/pytext/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facebookresearch/pytext/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facebookresearch/pytext/teams","hooks_url":"https://api.github.com/repos/facebookresearch/pytext/hooks","issue_events_url":"https://api.github.com/repos/facebookresearch/pytext/issues/events{/number}","events_url":"https://api.github.com/repos/facebookresearch/pytext/events","assignees_url":"https://api.github.com/repos/facebookresearch/pytext/assignees{/user}","branches_url":"https://api.github.com/repos/facebookresearch/pytext/branches{/branch}","tags_url":"https://api.github.com/repos/facebookresearch/pytext/tags","blobs_url":"https://api.github.com/repos/facebookresearch/pytext/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facebookresearch/pytext/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facebookresearch/pytext/git/refs{/sha}","trees_url":"https://api.github.com/repos/facebookresearch/pytext/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facebookresearch/pytext/statuses/{sha}","languages_url":"https://api.github.com/repos/facebookresearch/pytext/languages","stargazers_url":"https://api.github.com/repos/facebookresearch/pytext/stargazers","contributors_url":"https://api.github.com/repos/facebookresearch/pytext/contributors","subscribers_url":"https://api.github.com/repos/facebookresearch/pytext/subscribers","subscription_url":"https://api.github.com/repos/facebookresearch/pytext/subscription","commits_url":"https://api.github.com/repos/facebookresearch/pytext/commits{/sha}","git_commits_url":"https://api.github.com/repos/facebookresearch/pytext/git/commits{/sha}","comments_url":"https://api.github.com/repos/facebookresearch/pytext/comments{/number}","issue_comment_url":"https://api.github.com/repos/facebookresearch/pytext/issues/comments{/number}","contents_url":"https://api.github.com/repos/facebookresearch/pytext/contents/{+path}","compare_url":"https://api.github.com/repos/facebookresearch/pytext/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facebookresearch/pytext/merges","archive_url":"https://api.github.com/repos/facebookresearch/pytext/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facebookresearch/pytext/downloads","issues_url":"https://api.github.com/repos/facebookresearch/pytext/issues{/number}","pulls_url":"https://api.github.com/repos/facebookresearch/pytext/pulls{/number}","milestones_url":"https://api.github.com/repos/facebookresearch/pytext/milestones{/number}","notifications_url":"https://api.github.com/repos/facebookresearch/pytext/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facebookresearch/pytext/labels{/name}","releases_url":"https://api.github.com/repos/facebookresearch/pytext/releases{/id}","deployments_url":"https://api.github.com/repos/facebookresearch/pytext/deployments","created_at":"2018-07-31T23:40:46Z","updated_at":"2018-12-14T05:57:51Z","pushed_at":"2018-12-14T05:59:22Z","git_url":"git://github.com/facebookresearch/pytext.git","ssh_url":"git@github.com:facebookresearch/pytext.git","clone_url":"https://github.com/facebookresearch/pytext.git","svn_url":"https://github.com/facebookresearch/pytext","homepage":null,"size":560,"stargazers_count":130,"watchers_count":130,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":14,"open_issues":5,"watchers":130,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/facebookresearch/pytext/pulls/104"},"html":{"href":"https://github.com/facebookresearch/pytext/pull/104"},"issue":{"href":"https://api.github.com/repos/facebookresearch/pytext/issues/104"},"comments":{"href":"https://api.github.com/repos/facebookresearch/pytext/issues/104/comments"},"review_comments":{"href":"https://api.github.com/repos/facebookresearch/pytext/pulls/104/comments"},"review_comment":{"href":"https://api.github.com/repos/facebookresearch/pytext/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/facebookresearch/pytext/pulls/104/commits"},"statuses":{"href":"https://api.github.com/repos/facebookresearch/pytext/statuses/60ba7c0a2731364055f0f05b60d6ce40760ae113"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":12,"deletions":4,"changed_files":1}}
{"actor":{"display_login":"facebook-github-bot"}}