{"action":"created","comment":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/172949436","pull_request_review_id":102055296,"id":172949436,"diff_hunk":"@@ -588,6 +588,12 @@ public ProcedureSignature signature()\n                             numberOfDeclaredArguments, input.length );\n                 }\n \n+                // Some input fields are not supported by Cypher and need to be mapped\n+                for ( int i = 0; i < input.length; i++ )\n+                {\n+                    input[i] = signature.inputSignature().get( i ).map( input[i] );","path":"community/kernel/src/main/java/org/neo4j/kernel/impl/proc/ReflectiveProcedureCompiler.java","position":7,"original_position":7,"commit_id":"7aa6ea28f357026ff28fdbd32a40c5d3874b47a9","original_commit_id":"7aa6ea28f357026ff28fdbd32a40c5d3874b47a9","user":{"login":"craigtaverner","id":114451,"avatar_url":"https://avatars0.githubusercontent.com/u/114451?v=4","gravatar_id":"","url":"https://api.github.com/users/craigtaverner","html_url":"https://github.com/craigtaverner","followers_url":"https://api.github.com/users/craigtaverner/followers","following_url":"https://api.github.com/users/craigtaverner/following{/other_user}","gists_url":"https://api.github.com/users/craigtaverner/gists{/gist_id}","starred_url":"https://api.github.com/users/craigtaverner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craigtaverner/subscriptions","organizations_url":"https://api.github.com/users/craigtaverner/orgs","repos_url":"https://api.github.com/users/craigtaverner/repos","events_url":"https://api.github.com/users/craigtaverner/events{/privacy}","received_events_url":"https://api.github.com/users/craigtaverner/received_events","type":"User","site_admin":false},"body":"I have written an extra test to verify that the values passed in are not modified. I see your concern that this is not safe against future usages of this system, but I thought that should be caught by tests. I'm hoping to minimize object creation, which will happen on every single call if we do not do this. Now we only take a cost on byte[] processing, not all other types.","created_at":"2018-03-07T19:00:28Z","updated_at":"2018-03-07T19:00:28Z","html_url":"https://github.com/neo4j/neo4j/pull/11182#discussion_r172949436","pull_request_url":"https://api.github.com/repos/neo4j/neo4j/pulls/11182","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments/172949436"},"html":{"href":"https://github.com/neo4j/neo4j/pull/11182#discussion_r172949436"},"pull_request":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/11182"}},"in_reply_to_id":172782813},"pull_request":{"url":"https://api.github.com/repos/neo4j/neo4j/pulls/11182","id":173300667,"html_url":"https://github.com/neo4j/neo4j/pull/11182","diff_url":"https://github.com/neo4j/neo4j/pull/11182.diff","patch_url":"https://github.com/neo4j/neo4j/pull/11182.patch","issue_url":"https://api.github.com/repos/neo4j/neo4j/issues/11182","number":11182,"state":"open","locked":false,"title":"Support byte[] as input and output for procedures","user":{"login":"craigtaverner","id":114451,"avatar_url":"https://avatars0.githubusercontent.com/u/114451?v=4","gravatar_id":"","url":"https://api.github.com/users/craigtaverner","html_url":"https://github.com/craigtaverner","followers_url":"https://api.github.com/users/craigtaverner/followers","following_url":"https://api.github.com/users/craigtaverner/following{/other_user}","gists_url":"https://api.github.com/users/craigtaverner/gists{/gist_id}","starred_url":"https://api.github.com/users/craigtaverner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craigtaverner/subscriptions","organizations_url":"https://api.github.com/users/craigtaverner/orgs","repos_url":"https://api.github.com/users/craigtaverner/repos","events_url":"https://api.github.com/users/craigtaverner/events{/privacy}","received_events_url":"https://api.github.com/users/craigtaverner/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-06T22:29:52Z","updated_at":"2018-03-07T19:00:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d0e1f151e97362c01b1a8b8cc8b8b61c555d3b56","assignee":{"login":"pontusmelke","id":88000,"avatar_url":"https://avatars3.githubusercontent.com/u/88000?v=4","gravatar_id":"","url":"https://api.github.com/users/pontusmelke","html_url":"https://github.com/pontusmelke","followers_url":"https://api.github.com/users/pontusmelke/followers","following_url":"https://api.github.com/users/pontusmelke/following{/other_user}","gists_url":"https://api.github.com/users/pontusmelke/gists{/gist_id}","starred_url":"https://api.github.com/users/pontusmelke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pontusmelke/subscriptions","organizations_url":"https://api.github.com/users/pontusmelke/orgs","repos_url":"https://api.github.com/users/pontusmelke/repos","events_url":"https://api.github.com/users/pontusmelke/events{/privacy}","received_events_url":"https://api.github.com/users/pontusmelke/received_events","type":"User","site_admin":false},"assignees":[{"login":"pontusmelke","id":88000,"avatar_url":"https://avatars3.githubusercontent.com/u/88000?v=4","gravatar_id":"","url":"https://api.github.com/users/pontusmelke","html_url":"https://github.com/pontusmelke","followers_url":"https://api.github.com/users/pontusmelke/followers","following_url":"https://api.github.com/users/pontusmelke/following{/other_user}","gists_url":"https://api.github.com/users/pontusmelke/gists{/gist_id}","starred_url":"https://api.github.com/users/pontusmelke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pontusmelke/subscriptions","organizations_url":"https://api.github.com/users/pontusmelke/orgs","repos_url":"https://api.github.com/users/pontusmelke/repos","events_url":"https://api.github.com/users/pontusmelke/events{/privacy}","received_events_url":"https://api.github.com/users/pontusmelke/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":556879276,"url":"https://api.github.com/repos/neo4j/neo4j/labels/3.3","name":"3.3","color":"FF7256","default":false},{"id":19053963,"url":"https://api.github.com/repos/neo4j/neo4j/labels/bug","name":"bug","color":"fc2929","default":true},{"id":318003412,"url":"https://api.github.com/repos/neo4j/neo4j/labels/changelog","name":"changelog","color":"006b75","default":false},{"id":19073042,"url":"https://api.github.com/repos/neo4j/neo4j/labels/cypher","name":"cypher","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/neo4j/neo4j/pulls/11182/commits","review_comments_url":"https://api.github.com/repos/neo4j/neo4j/pulls/11182/comments","review_comment_url":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}","comments_url":"https://api.github.com/repos/neo4j/neo4j/issues/11182/comments","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/7aa6ea28f357026ff28fdbd32a40c5d3874b47a9","head":{"label":"craigtaverner:3.3-proc-bytearray","ref":"3.3-proc-bytearray","sha":"7aa6ea28f357026ff28fdbd32a40c5d3874b47a9","user":{"login":"craigtaverner","id":114451,"avatar_url":"https://avatars0.githubusercontent.com/u/114451?v=4","gravatar_id":"","url":"https://api.github.com/users/craigtaverner","html_url":"https://github.com/craigtaverner","followers_url":"https://api.github.com/users/craigtaverner/followers","following_url":"https://api.github.com/users/craigtaverner/following{/other_user}","gists_url":"https://api.github.com/users/craigtaverner/gists{/gist_id}","starred_url":"https://api.github.com/users/craigtaverner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craigtaverner/subscriptions","organizations_url":"https://api.github.com/users/craigtaverner/orgs","repos_url":"https://api.github.com/users/craigtaverner/repos","events_url":"https://api.github.com/users/craigtaverner/events{/privacy}","received_events_url":"https://api.github.com/users/craigtaverner/received_events","type":"User","site_admin":false},"repo":{"id":17599080,"name":"neo4j","full_name":"craigtaverner/neo4j","owner":{"login":"craigtaverner","id":114451,"avatar_url":"https://avatars0.githubusercontent.com/u/114451?v=4","gravatar_id":"","url":"https://api.github.com/users/craigtaverner","html_url":"https://github.com/craigtaverner","followers_url":"https://api.github.com/users/craigtaverner/followers","following_url":"https://api.github.com/users/craigtaverner/following{/other_user}","gists_url":"https://api.github.com/users/craigtaverner/gists{/gist_id}","starred_url":"https://api.github.com/users/craigtaverner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/craigtaverner/subscriptions","organizations_url":"https://api.github.com/users/craigtaverner/orgs","repos_url":"https://api.github.com/users/craigtaverner/repos","events_url":"https://api.github.com/users/craigtaverner/events{/privacy}","received_events_url":"https://api.github.com/users/craigtaverner/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/craigtaverner/neo4j","description":"The World's Leading Graph Database","fork":true,"url":"https://api.github.com/repos/craigtaverner/neo4j","forks_url":"https://api.github.com/repos/craigtaverner/neo4j/forks","keys_url":"https://api.github.com/repos/craigtaverner/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/craigtaverner/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/craigtaverner/neo4j/teams","hooks_url":"https://api.github.com/repos/craigtaverner/neo4j/hooks","issue_events_url":"https://api.github.com/repos/craigtaverner/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/craigtaverner/neo4j/events","assignees_url":"https://api.github.com/repos/craigtaverner/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/craigtaverner/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/craigtaverner/neo4j/tags","blobs_url":"https://api.github.com/repos/craigtaverner/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/craigtaverner/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/craigtaverner/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/craigtaverner/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/craigtaverner/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/craigtaverner/neo4j/languages","stargazers_url":"https://api.github.com/repos/craigtaverner/neo4j/stargazers","contributors_url":"https://api.github.com/repos/craigtaverner/neo4j/contributors","subscribers_url":"https://api.github.com/repos/craigtaverner/neo4j/subscribers","subscription_url":"https://api.github.com/repos/craigtaverner/neo4j/subscription","commits_url":"https://api.github.com/repos/craigtaverner/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/craigtaverner/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/craigtaverner/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/craigtaverner/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/craigtaverner/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/craigtaverner/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/craigtaverner/neo4j/merges","archive_url":"https://api.github.com/repos/craigtaverner/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/craigtaverner/neo4j/downloads","issues_url":"https://api.github.com/repos/craigtaverner/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/craigtaverner/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/craigtaverner/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/craigtaverner/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/craigtaverner/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/craigtaverner/neo4j/releases{/id}","deployments_url":"https://api.github.com/repos/craigtaverner/neo4j/deployments","created_at":"2014-03-10T16:12:05Z","updated_at":"2015-03-14T12:35:18Z","pushed_at":"2018-03-07T15:28:13Z","git_url":"git://github.com/craigtaverner/neo4j.git","ssh_url":"git@github.com:craigtaverner/neo4j.git","clone_url":"https://github.com/craigtaverner/neo4j.git","svn_url":"https://github.com/craigtaverner/neo4j","homepage":"http://neo4j.org","size":391466,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"3.4"}},"base":{"label":"neo4j:3.3","ref":"3.3","sha":"6a217808adfe9ee860ad68f5df744e02a41038e6","user":{"login":"neo4j","id":201120,"avatar_url":"https://avatars3.githubusercontent.com/u/201120?v=4","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"repo":{"id":6650539,"name":"neo4j","full_name":"neo4j/neo4j","owner":{"login":"neo4j","id":201120,"avatar_url":"https://avatars3.githubusercontent.com/u/201120?v=4","gravatar_id":"","url":"https://api.github.com/users/neo4j","html_url":"https://github.com/neo4j","followers_url":"https://api.github.com/users/neo4j/followers","following_url":"https://api.github.com/users/neo4j/following{/other_user}","gists_url":"https://api.github.com/users/neo4j/gists{/gist_id}","starred_url":"https://api.github.com/users/neo4j/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neo4j/subscriptions","organizations_url":"https://api.github.com/users/neo4j/orgs","repos_url":"https://api.github.com/users/neo4j/repos","events_url":"https://api.github.com/users/neo4j/events{/privacy}","received_events_url":"https://api.github.com/users/neo4j/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/neo4j/neo4j","description":"Graphs for Everyone","fork":false,"url":"https://api.github.com/repos/neo4j/neo4j","forks_url":"https://api.github.com/repos/neo4j/neo4j/forks","keys_url":"https://api.github.com/repos/neo4j/neo4j/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neo4j/neo4j/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neo4j/neo4j/teams","hooks_url":"https://api.github.com/repos/neo4j/neo4j/hooks","issue_events_url":"https://api.github.com/repos/neo4j/neo4j/issues/events{/number}","events_url":"https://api.github.com/repos/neo4j/neo4j/events","assignees_url":"https://api.github.com/repos/neo4j/neo4j/assignees{/user}","branches_url":"https://api.github.com/repos/neo4j/neo4j/branches{/branch}","tags_url":"https://api.github.com/repos/neo4j/neo4j/tags","blobs_url":"https://api.github.com/repos/neo4j/neo4j/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neo4j/neo4j/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neo4j/neo4j/git/refs{/sha}","trees_url":"https://api.github.com/repos/neo4j/neo4j/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neo4j/neo4j/statuses/{sha}","languages_url":"https://api.github.com/repos/neo4j/neo4j/languages","stargazers_url":"https://api.github.com/repos/neo4j/neo4j/stargazers","contributors_url":"https://api.github.com/repos/neo4j/neo4j/contributors","subscribers_url":"https://api.github.com/repos/neo4j/neo4j/subscribers","subscription_url":"https://api.github.com/repos/neo4j/neo4j/subscription","commits_url":"https://api.github.com/repos/neo4j/neo4j/commits{/sha}","git_commits_url":"https://api.github.com/repos/neo4j/neo4j/git/commits{/sha}","comments_url":"https://api.github.com/repos/neo4j/neo4j/comments{/number}","issue_comment_url":"https://api.github.com/repos/neo4j/neo4j/issues/comments{/number}","contents_url":"https://api.github.com/repos/neo4j/neo4j/contents/{+path}","compare_url":"https://api.github.com/repos/neo4j/neo4j/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neo4j/neo4j/merges","archive_url":"https://api.github.com/repos/neo4j/neo4j/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neo4j/neo4j/downloads","issues_url":"https://api.github.com/repos/neo4j/neo4j/issues{/number}","pulls_url":"https://api.github.com/repos/neo4j/neo4j/pulls{/number}","milestones_url":"https://api.github.com/repos/neo4j/neo4j/milestones{/number}","notifications_url":"https://api.github.com/repos/neo4j/neo4j/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neo4j/neo4j/labels{/name}","releases_url":"https://api.github.com/repos/neo4j/neo4j/releases{/id}","deployments_url":"https://api.github.com/repos/neo4j/neo4j/deployments","created_at":"2012-11-12T08:46:15Z","updated_at":"2018-03-07T14:44:20Z","pushed_at":"2018-03-07T18:53:24Z","git_url":"git://github.com/neo4j/neo4j.git","ssh_url":"git@github.com:neo4j/neo4j.git","clone_url":"https://github.com/neo4j/neo4j.git","svn_url":"https://github.com/neo4j/neo4j","homepage":"http://neo4j.com","size":392688,"stargazers_count":4788,"watchers_count":4788,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1293,"mirror_url":null,"archived":false,"open_issues_count":340,"license":null,"forks":1293,"open_issues":340,"watchers":4788,"default_branch":"3.4"}},"_links":{"self":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/11182"},"html":{"href":"https://github.com/neo4j/neo4j/pull/11182"},"issue":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/11182"},"comments":{"href":"https://api.github.com/repos/neo4j/neo4j/issues/11182/comments"},"review_comments":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/11182/comments"},"review_comment":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/neo4j/neo4j/pulls/11182/commits"},"statuses":{"href":"https://api.github.com/repos/neo4j/neo4j/statuses/7aa6ea28f357026ff28fdbd32a40c5d3874b47a9"}},"author_association":"OWNER"}}
{"actor":{"display_login":"craigtaverner"}}