{"action":"created","issue":{"url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/11343","repository_url":"https://api.github.com/repos/PrestaShop/PrestaShop","labels_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/11343/labels{/name}","comments_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/11343/comments","events_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/11343/events","html_url":"https://github.com/PrestaShop/PrestaShop/issues/11343","id":379233383,"node_id":"MDU6SXNzdWUzNzkyMzMzODM=","number":11343,"title":"modifierWsLinkRewrite ... it can't work !","user":{"login":"grabelle","id":5048627,"node_id":"MDQ6VXNlcjUwNDg2Mjc=","avatar_url":"https://avatars1.githubusercontent.com/u/5048627?v=4","gravatar_id":"","url":"https://api.github.com/users/grabelle","html_url":"https://github.com/grabelle","followers_url":"https://api.github.com/users/grabelle/followers","following_url":"https://api.github.com/users/grabelle/following{/other_user}","gists_url":"https://api.github.com/users/grabelle/gists{/gist_id}","starred_url":"https://api.github.com/users/grabelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grabelle/subscriptions","organizations_url":"https://api.github.com/users/grabelle/orgs","repos_url":"https://api.github.com/users/grabelle/repos","events_url":"https://api.github.com/users/grabelle/events{/privacy}","received_events_url":"https://api.github.com/users/grabelle/received_events","type":"User","site_admin":false},"labels":[{"id":1111129977,"node_id":"MDU6TGFiZWwxMTExMTI5OTc3","url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels/1.7.4.4","name":"1.7.4.4","color":"8cffda","default":false},{"id":984878719,"node_id":"MDU6TGFiZWw5ODQ4Nzg3MTk=","url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels/CO","name":"CO","color":"444444","default":false},{"id":1026163987,"node_id":"MDU6TGFiZWwxMDI2MTYzOTg3","url":"https://api.github.com/repos/PrestaShop/PrestaShop/labels/No%20change%20required","name":"No change required","color":"cecece","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-11-09T16:34:49Z","updated_at":"2018-11-09T17:28:57Z","closed_at":"2018-11-09T17:09:37Z","author_association":"NONE","body":"Hi,\r\nPrestashop 1.7.4.4\r\nIn classes/Product.php\r\n\r\n**$this->link_rewrite is a string** ... could you explain what will do this code ??? Very strange and couldn't have been tested. Is prestashop 1.7 for production or is it better to wait ? It's just a question ...\r\n\r\n\r\n    public function modifierWsLinkRewrite()\r\n    {\r\n        foreach ($this->name as $id_lang => $name) {\r\n            if (empty($this->link_rewrite[$id_lang])) {\r\n                $this->link_rewrite[$id_lang] = Tools::link_rewrite($name);\r\n            } elseif (!Validate::isLinkRewrite($this->link_rewrite[$id_lang])) {\r\n                $this->link_rewrite[$id_lang] = Tools::link_rewrite($this->link_rewrite[$id_lang]);\r\n            }\r\n        }\r\n\r\n        return true;\r\n    }\r\n\r\n\r\nthx"},"comment":{"url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/comments/437433695","html_url":"https://github.com/PrestaShop/PrestaShop/issues/11343#issuecomment-437433695","issue_url":"https://api.github.com/repos/PrestaShop/PrestaShop/issues/11343","id":437433695,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzQzMzY5NQ==","user":{"login":"grabelle","id":5048627,"node_id":"MDQ6VXNlcjUwNDg2Mjc=","avatar_url":"https://avatars1.githubusercontent.com/u/5048627?v=4","gravatar_id":"","url":"https://api.github.com/users/grabelle","html_url":"https://github.com/grabelle","followers_url":"https://api.github.com/users/grabelle/followers","following_url":"https://api.github.com/users/grabelle/following{/other_user}","gists_url":"https://api.github.com/users/grabelle/gists{/gist_id}","starred_url":"https://api.github.com/users/grabelle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grabelle/subscriptions","organizations_url":"https://api.github.com/users/grabelle/orgs","repos_url":"https://api.github.com/users/grabelle/repos","events_url":"https://api.github.com/users/grabelle/events{/privacy}","received_events_url":"https://api.github.com/users/grabelle/received_events","type":"User","site_admin":false},"created_at":"2018-11-09T17:28:57Z","updated_at":"2018-11-09T17:28:57Z","author_association":"NONE","body":"@eternoendless : Thanks a lot for your explanation and your work."}}
{"actor":{"display_login":"grabelle"}}