{"action":"created","comment":{"url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/pulls/comments/223226789","pull_request_review_id":162303585,"id":223226789,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzIyNjc4OQ==","diff_hunk":"@@ -15,27 +15,29 @@ TEST_CASE( \"Initialization: WrongParameters\")\n     CHECK_THROWS_AS( BaseBP::create_bp( \"saturating_two_bits\", 100, 20), BPInvalidMode);\n }\n \n-//TEST_CASE( \"Static, all branches not taken\")\n-//{\n-//    auto bp = BaseBP::create_bp( \"always_not_taken\", 128, 16);\n-//\n-//    Addr PC = 28;\n-//    Addr target = 12;\n-//    \n-//    CHECK_FALSE( bp->is_taken(PC) );\n-//    CHECK( bp->get_target(PC) == target);\n-//}\n-\n-//TEST_CASE( \"Static, all branches taken\")\n-//{\n-//    auto bp = BaseBP::create_bp( \"always_taken\", 128, 16);\n-//\n-//    Addr PC = 28;\n-//    Addr target = 12;\n-//    \n-//    CHECK( bp->is_taken(PC) );\n-//    CHECK( bp->get_target(PC) == target);\n-//}\n+TEST_CASE( \"Static, all branches not taken\")\n+{\n+    auto bp = BaseBP::create_bp( \"always_not_taken\", 128, 16);\n+\n+    Addr PC = 28;\n+    Addr target = 12;\n+\n+    bp->update( BPInterface( PC, false, target));","path":"simulator/modules/fetch/bpu/t/unit_test.cpp","position":9,"original_position":32,"commit_id":"86a12a72d11a51d9dc894a3c3ad1428ad181accb","original_commit_id":"86a12a72d11a51d9dc894a3c3ad1428ad181accb","user":{"login":"YanLo","id":25749522,"node_id":"MDQ6VXNlcjI1NzQ5NTIy","avatar_url":"https://avatars3.githubusercontent.com/u/25749522?v=4","gravatar_id":"","url":"https://api.github.com/users/YanLo","html_url":"https://github.com/YanLo","followers_url":"https://api.github.com/users/YanLo/followers","following_url":"https://api.github.com/users/YanLo/following{/other_user}","gists_url":"https://api.github.com/users/YanLo/gists{/gist_id}","starred_url":"https://api.github.com/users/YanLo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YanLo/subscriptions","organizations_url":"https://api.github.com/users/YanLo/orgs","repos_url":"https://api.github.com/users/YanLo/repos","events_url":"https://api.github.com/users/YanLo/events{/privacy}","received_events_url":"https://api.github.com/users/YanLo/received_events","type":"User","site_admin":false},"body":"Am I right putting ``` false ``` because it is \"not taken\" ?","created_at":"2018-10-07T20:32:13Z","updated_at":"2018-10-07T20:32:19Z","html_url":"https://github.com/MIPT-ILab/mipt-mips/pull/611#discussion_r223226789","pull_request_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/pulls/611","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/MIPT-ILab/mipt-mips/pulls/comments/223226789"},"html":{"href":"https://github.com/MIPT-ILab/mipt-mips/pull/611#discussion_r223226789"},"pull_request":{"href":"https://api.github.com/repos/MIPT-ILab/mipt-mips/pulls/611"}}},"pull_request":{"url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/pulls/611","id":220967134,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwOTY3MTM0","html_url":"https://github.com/MIPT-ILab/mipt-mips/pull/611","diff_url":"https://github.com/MIPT-ILab/mipt-mips/pull/611.diff","patch_url":"https://github.com/MIPT-ILab/mipt-mips/pull/611.patch","issue_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/issues/611","number":611,"state":"open","locked":false,"title":"add tests  for static predictors and one bit predictor","user":{"login":"YanLo","id":25749522,"node_id":"MDQ6VXNlcjI1NzQ5NTIy","avatar_url":"https://avatars3.githubusercontent.com/u/25749522?v=4","gravatar_id":"","url":"https://api.github.com/users/YanLo","html_url":"https://github.com/YanLo","followers_url":"https://api.github.com/users/YanLo/followers","following_url":"https://api.github.com/users/YanLo/following{/other_user}","gists_url":"https://api.github.com/users/YanLo/gists{/gist_id}","starred_url":"https://api.github.com/users/YanLo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YanLo/subscriptions","organizations_url":"https://api.github.com/users/YanLo/orgs","repos_url":"https://api.github.com/users/YanLo/repos","events_url":"https://api.github.com/users/YanLo/events{/privacy}","received_events_url":"https://api.github.com/users/YanLo/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-07T19:17:26Z","updated_at":"2018-10-07T20:32:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8e221b832490637c77e9e9b907f205decdc9237d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/pulls/611/commits","review_comments_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/pulls/611/comments","review_comment_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/pulls/comments{/number}","comments_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/issues/611/comments","statuses_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/statuses/86a12a72d11a51d9dc894a3c3ad1428ad181accb","head":{"label":"YanLo:master","ref":"master","sha":"86a12a72d11a51d9dc894a3c3ad1428ad181accb","user":{"login":"YanLo","id":25749522,"node_id":"MDQ6VXNlcjI1NzQ5NTIy","avatar_url":"https://avatars3.githubusercontent.com/u/25749522?v=4","gravatar_id":"","url":"https://api.github.com/users/YanLo","html_url":"https://github.com/YanLo","followers_url":"https://api.github.com/users/YanLo/followers","following_url":"https://api.github.com/users/YanLo/following{/other_user}","gists_url":"https://api.github.com/users/YanLo/gists{/gist_id}","starred_url":"https://api.github.com/users/YanLo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YanLo/subscriptions","organizations_url":"https://api.github.com/users/YanLo/orgs","repos_url":"https://api.github.com/users/YanLo/repos","events_url":"https://api.github.com/users/YanLo/events{/privacy}","received_events_url":"https://api.github.com/users/YanLo/received_events","type":"User","site_admin":false},"repo":{"id":145817407,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU4MTc0MDc=","name":"mipt-mips","full_name":"YanLo/mipt-mips","private":false,"owner":{"login":"YanLo","id":25749522,"node_id":"MDQ6VXNlcjI1NzQ5NTIy","avatar_url":"https://avatars3.githubusercontent.com/u/25749522?v=4","gravatar_id":"","url":"https://api.github.com/users/YanLo","html_url":"https://github.com/YanLo","followers_url":"https://api.github.com/users/YanLo/followers","following_url":"https://api.github.com/users/YanLo/following{/other_user}","gists_url":"https://api.github.com/users/YanLo/gists{/gist_id}","starred_url":"https://api.github.com/users/YanLo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/YanLo/subscriptions","organizations_url":"https://api.github.com/users/YanLo/orgs","repos_url":"https://api.github.com/users/YanLo/repos","events_url":"https://api.github.com/users/YanLo/events{/privacy}","received_events_url":"https://api.github.com/users/YanLo/received_events","type":"User","site_admin":false},"html_url":"https://github.com/YanLo/mipt-mips","description":"Cycle-accurate pre-silicon simulator of MIPS CPU","fork":true,"url":"https://api.github.com/repos/YanLo/mipt-mips","forks_url":"https://api.github.com/repos/YanLo/mipt-mips/forks","keys_url":"https://api.github.com/repos/YanLo/mipt-mips/keys{/key_id}","collaborators_url":"https://api.github.com/repos/YanLo/mipt-mips/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/YanLo/mipt-mips/teams","hooks_url":"https://api.github.com/repos/YanLo/mipt-mips/hooks","issue_events_url":"https://api.github.com/repos/YanLo/mipt-mips/issues/events{/number}","events_url":"https://api.github.com/repos/YanLo/mipt-mips/events","assignees_url":"https://api.github.com/repos/YanLo/mipt-mips/assignees{/user}","branches_url":"https://api.github.com/repos/YanLo/mipt-mips/branches{/branch}","tags_url":"https://api.github.com/repos/YanLo/mipt-mips/tags","blobs_url":"https://api.github.com/repos/YanLo/mipt-mips/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/YanLo/mipt-mips/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/YanLo/mipt-mips/git/refs{/sha}","trees_url":"https://api.github.com/repos/YanLo/mipt-mips/git/trees{/sha}","statuses_url":"https://api.github.com/repos/YanLo/mipt-mips/statuses/{sha}","languages_url":"https://api.github.com/repos/YanLo/mipt-mips/languages","stargazers_url":"https://api.github.com/repos/YanLo/mipt-mips/stargazers","contributors_url":"https://api.github.com/repos/YanLo/mipt-mips/contributors","subscribers_url":"https://api.github.com/repos/YanLo/mipt-mips/subscribers","subscription_url":"https://api.github.com/repos/YanLo/mipt-mips/subscription","commits_url":"https://api.github.com/repos/YanLo/mipt-mips/commits{/sha}","git_commits_url":"https://api.github.com/repos/YanLo/mipt-mips/git/commits{/sha}","comments_url":"https://api.github.com/repos/YanLo/mipt-mips/comments{/number}","issue_comment_url":"https://api.github.com/repos/YanLo/mipt-mips/issues/comments{/number}","contents_url":"https://api.github.com/repos/YanLo/mipt-mips/contents/{+path}","compare_url":"https://api.github.com/repos/YanLo/mipt-mips/compare/{base}...{head}","merges_url":"https://api.github.com/repos/YanLo/mipt-mips/merges","archive_url":"https://api.github.com/repos/YanLo/mipt-mips/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/YanLo/mipt-mips/downloads","issues_url":"https://api.github.com/repos/YanLo/mipt-mips/issues{/number}","pulls_url":"https://api.github.com/repos/YanLo/mipt-mips/pulls{/number}","milestones_url":"https://api.github.com/repos/YanLo/mipt-mips/milestones{/number}","notifications_url":"https://api.github.com/repos/YanLo/mipt-mips/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/YanLo/mipt-mips/labels{/name}","releases_url":"https://api.github.com/repos/YanLo/mipt-mips/releases{/id}","deployments_url":"https://api.github.com/repos/YanLo/mipt-mips/deployments","created_at":"2018-08-23T07:29:02Z","updated_at":"2018-10-07T20:30:33Z","pushed_at":"2018-10-07T20:30:31Z","git_url":"git://github.com/YanLo/mipt-mips.git","ssh_url":"git@github.com:YanLo/mipt-mips.git","clone_url":"https://github.com/YanLo/mipt-mips.git","svn_url":"https://github.com/YanLo/mipt-mips","homepage":"http://mipt-ilab.github.io/mipt-mips/","size":10744,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"MIPT-ILab:master","ref":"master","sha":"837d58eb992d7ed5175ee0e639c2916f057cf779","user":{"login":"MIPT-ILab","id":13999586,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTk5NTg2","avatar_url":"https://avatars2.githubusercontent.com/u/13999586?v=4","gravatar_id":"","url":"https://api.github.com/users/MIPT-ILab","html_url":"https://github.com/MIPT-ILab","followers_url":"https://api.github.com/users/MIPT-ILab/followers","following_url":"https://api.github.com/users/MIPT-ILab/following{/other_user}","gists_url":"https://api.github.com/users/MIPT-ILab/gists{/gist_id}","starred_url":"https://api.github.com/users/MIPT-ILab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MIPT-ILab/subscriptions","organizations_url":"https://api.github.com/users/MIPT-ILab/orgs","repos_url":"https://api.github.com/users/MIPT-ILab/repos","events_url":"https://api.github.com/users/MIPT-ILab/events{/privacy}","received_events_url":"https://api.github.com/users/MIPT-ILab/received_events","type":"Organization","site_admin":false},"repo":{"id":42990634,"node_id":"MDEwOlJlcG9zaXRvcnk0Mjk5MDYzNA==","name":"mipt-mips","full_name":"MIPT-ILab/mipt-mips","private":false,"owner":{"login":"MIPT-ILab","id":13999586,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTk5NTg2","avatar_url":"https://avatars2.githubusercontent.com/u/13999586?v=4","gravatar_id":"","url":"https://api.github.com/users/MIPT-ILab","html_url":"https://github.com/MIPT-ILab","followers_url":"https://api.github.com/users/MIPT-ILab/followers","following_url":"https://api.github.com/users/MIPT-ILab/following{/other_user}","gists_url":"https://api.github.com/users/MIPT-ILab/gists{/gist_id}","starred_url":"https://api.github.com/users/MIPT-ILab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MIPT-ILab/subscriptions","organizations_url":"https://api.github.com/users/MIPT-ILab/orgs","repos_url":"https://api.github.com/users/MIPT-ILab/repos","events_url":"https://api.github.com/users/MIPT-ILab/events{/privacy}","received_events_url":"https://api.github.com/users/MIPT-ILab/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/MIPT-ILab/mipt-mips","description":"Cycle-accurate pre-silicon simulator of MIPS CPU","fork":false,"url":"https://api.github.com/repos/MIPT-ILab/mipt-mips","forks_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/forks","keys_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/keys{/key_id}","collaborators_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/teams","hooks_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/hooks","issue_events_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/issues/events{/number}","events_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/events","assignees_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/assignees{/user}","branches_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/branches{/branch}","tags_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/tags","blobs_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/git/refs{/sha}","trees_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/git/trees{/sha}","statuses_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/statuses/{sha}","languages_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/languages","stargazers_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/stargazers","contributors_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/contributors","subscribers_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/subscribers","subscription_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/subscription","commits_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/commits{/sha}","git_commits_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/git/commits{/sha}","comments_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/comments{/number}","issue_comment_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/issues/comments{/number}","contents_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/contents/{+path}","compare_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/compare/{base}...{head}","merges_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/merges","archive_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/downloads","issues_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/issues{/number}","pulls_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/pulls{/number}","milestones_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/milestones{/number}","notifications_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/labels{/name}","releases_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/releases{/id}","deployments_url":"https://api.github.com/repos/MIPT-ILab/mipt-mips/deployments","created_at":"2015-09-23T09:12:26Z","updated_at":"2018-10-07T19:49:14Z","pushed_at":"2018-10-07T20:30:32Z","git_url":"git://github.com/MIPT-ILab/mipt-mips.git","ssh_url":"git@github.com:MIPT-ILab/mipt-mips.git","clone_url":"https://github.com/MIPT-ILab/mipt-mips.git","svn_url":"https://github.com/MIPT-ILab/mipt-mips","homepage":"http://mipt-ilab.github.io/mipt-mips/","size":115789,"stargazers_count":69,"watchers_count":69,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":73,"mirror_url":null,"archived":false,"open_issues_count":55,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":73,"open_issues":55,"watchers":69,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/MIPT-ILab/mipt-mips/pulls/611"},"html":{"href":"https://github.com/MIPT-ILab/mipt-mips/pull/611"},"issue":{"href":"https://api.github.com/repos/MIPT-ILab/mipt-mips/issues/611"},"comments":{"href":"https://api.github.com/repos/MIPT-ILab/mipt-mips/issues/611/comments"},"review_comments":{"href":"https://api.github.com/repos/MIPT-ILab/mipt-mips/pulls/611/comments"},"review_comment":{"href":"https://api.github.com/repos/MIPT-ILab/mipt-mips/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/MIPT-ILab/mipt-mips/pulls/611/commits"},"statuses":{"href":"https://api.github.com/repos/MIPT-ILab/mipt-mips/statuses/86a12a72d11a51d9dc894a3c3ad1428ad181accb"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"YanLo"}}