{"action":"created","comment":{"url":"https://api.github.com/repos/sailfishos/sailfish-qtcreator/pulls/comments/242455796","pull_request_review_id":185948258,"id":242455796,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjQ1NTc5Ng==","diff_hunk":"@@ -72,14 +76,31 @@ MerEmulatorDeviceWidget::~MerEmulatorDeviceWidget()\n     delete m_ui;\n }\n \n+void MerEmulatorDeviceWidget::onDeviceModelEdited()\n+{\n+    MerSettings::populateWithDeviceModels(m_ui->deviceModelComboBox);","path":"src/plugins/mer/meremulatordevicewidget.cpp","position":24,"original_position":24,"commit_id":"97a20cb6e5de28a1f79ee97b5d7e0039c8c1a858","original_commit_id":"97a20cb6e5de28a1f79ee97b5d7e0039c8c1a858","user":{"login":"martyone","id":182428,"node_id":"MDQ6VXNlcjE4MjQyOA==","avatar_url":"https://avatars1.githubusercontent.com/u/182428?v=4","gravatar_id":"","url":"https://api.github.com/users/martyone","html_url":"https://github.com/martyone","followers_url":"https://api.github.com/users/martyone/followers","following_url":"https://api.github.com/users/martyone/following{/other_user}","gists_url":"https://api.github.com/users/martyone/gists{/gist_id}","starred_url":"https://api.github.com/users/martyone/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martyone/subscriptions","organizations_url":"https://api.github.com/users/martyone/orgs","repos_url":"https://api.github.com/users/martyone/repos","events_url":"https://api.github.com/users/martyone/events{/privacy}","received_events_url":"https://api.github.com/users/martyone/received_events","type":"User","site_admin":false},"body":"I would consider encapsulating the related code into class MerDeviceModelComboBox.","created_at":"2018-12-18T09:13:53Z","updated_at":"2018-12-18T09:32:54Z","html_url":"https://github.com/sailfishos/sailfish-qtcreator/pull/141#discussion_r242455796","pull_request_url":"https://api.github.com/repos/sailfishos/sailfish-qtcreator/pulls/141","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/sailfishos/sailfish-qtcreator/pulls/comments/242455796"},"html":{"href":"https://github.com/sailfishos/sailfish-qtcreator/pull/141#discussion_r242455796"},"pull_request":{"href":"https://api.github.com/repos/sailfishos/sailfish-qtcreator/pulls/141"}}},"pull_request":{"url":"https://api.github.com/repos/sailfishos/sailfish-qtcreator/pulls/141","id":219283500,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5MjgzNTAw","html_url":"https://github.com/sailfishos/sailfish-qtcreator/pull/141","diff_url":"https://github.com/sailfishos/sailfish-qtcreator/pull/141.diff","patch_url":"https://github.com/sailfishos/sailfish-qtcreator/pull/141.patch","issue_url":"https://api.github.com/repos/sailfishos/sailfish-qtcreator/issues/141","number":141,"state":"open","locked":false,"title":"EMU-5 Control over screen resolution","user":{"login":"sergey-levin","id":43573179,"node_id":"MDQ6VXNlcjQzNTczMTc5","avatar_url":"https://avatars1.githubusercontent.com/u/43573179?v=4","gravatar_id":"","url":"https://api.github.com/users/sergey-levin","html_url":"https://github.com/sergey-levin","followers_url":"https://api.github.com/users/sergey-levin/followers","following_url":"https://api.github.com/users/sergey-levin/following{/other_user}","gists_url":"https://api.github.com/users/sergey-levin/gists{/gist_id}","starred_url":"https://api.github.com/users/sergey-levin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergey-levin/subscriptions","organizations_url":"https://api.github.com/users/sergey-levin/orgs","repos_url":"https://api.github.com/users/sergey-levin/repos","events_url":"https://api.github.com/users/sergey-levin/events{/privacy}","received_events_url":"https://api.github.com/users/sergey-levin/received_events","type":"User","site_admin":false},"body":"Added \"Custom\" emulator device model to the window titled \"Change Emulator Mode\" from \"Tools->Sailfish OS->Emulator mode...\" menu.\r\nCustom emulator device is automatically added to emulator device list.\r\nThe user is able to change the screen resolution of the Custom emulator device.","created_at":"2018-10-01T07:36:30Z","updated_at":"2018-12-18T09:32:54Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4a78dda253d063c8c03e3dc11929d8aa1b4639d8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sailfishos/sailfish-qtcreator/pulls/141/commits","review_comments_url":"https://api.github.com/repos/sailfishos/sailfish-qtcreator/pulls/141/comments","review_comment_url":"https://api.github.com/repos/sailfishos/sailfish-qtcreator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sailfishos/sailfish-qtcreator/issues/141/comments","statuses_url":"https://api.github.com/repos/sailfishos/sailfish-qtcreator/statuses/97a20cb6e5de28a1f79ee97b5d7e0039c8c1a858","head":{"label":"sergey-levin:emu-5_scr_res","ref":"emu-5_scr_res","sha":"97a20cb6e5de28a1f79ee97b5d7e0039c8c1a858","user":{"login":"sergey-levin","id":43573179,"node_id":"MDQ6VXNlcjQzNTczMTc5","avatar_url":"https://avatars1.githubusercontent.com/u/43573179?v=4","gravatar_id":"","url":"https://api.github.com/users/sergey-levin","html_url":"https://github.com/sergey-levin","followers_url":"https://api.github.com/users/sergey-levin/followers","following_url":"https://api.github.com/users/sergey-levin/following{/other_user}","gists_url":"https://api.github.com/users/sergey-levin/gists{/gist_id}","starred_url":"https://api.github.com/users/sergey-levin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergey-levin/subscriptions","organizations_url":"https://api.github.com/users/sergey-levin/orgs","repos_url":"https://api.github.com/users/sergey-levin/repos","events_url":"https://api.github.com/users/sergey-levin/events{/privacy}","received_events_url":"https://api.github.com/users/sergey-levin/received_events","type":"User","site_admin":false},"repo":{"id":150556343,"node_id":"MDEwOlJlcG9zaXRvcnkxNTA1NTYzNDM=","name":"sailfish-qtcreator","full_name":"sergey-levin/sailfish-qtcreator","private":false,"owner":{"login":"sergey-levin","id":43573179,"node_id":"MDQ6VXNlcjQzNTczMTc5","avatar_url":"https://avatars1.githubusercontent.com/u/43573179?v=4","gravatar_id":"","url":"https://api.github.com/users/sergey-levin","html_url":"https://github.com/sergey-levin","followers_url":"https://api.github.com/users/sergey-levin/followers","following_url":"https://api.github.com/users/sergey-levin/following{/other_user}","gists_url":"https://api.github.com/users/sergey-levin/gists{/gist_id}","starred_url":"https://api.github.com/users/sergey-levin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sergey-levin/subscriptions","organizations_url":"https://api.github.com/users/sergey-levin/orgs","repos_url":"https://api.github.com/users/sergey-levin/repos","events_url":"https://api.github.com/users/sergey-levin/events{/privacy}","received_events_url":"https://api.github.com/users/sergey-levin/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sergey-levin/sailfish-qtcreator","description":"SDK IDE for SailfishOS application development.","fork":true,"url":"https://api.github.com/repos/sergey-levin/sailfish-qtcreator","forks_url":"https://api.github.com/repos/sergey-levin/sailfish-qtcreator/forks","keys_url":"https://api.github.com/repos/sergey-levin/sailfish-qtcreator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sergey-levin/sailfish-qtcreator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sergey-levin/sailfish-qtcreator/teams","hooks_url":"https://api.github.com/repos/sergey-levin/sailfish-qtcreator/hooks","issue_events_url":"https://api.github.com/repos/sergey-levin/sailfish-qtcreator/issues/events{/number}","events_url":"https://api.github.com/repos/sergey-levin/sailfish-qtcreator/events","assignees_url":"https://api.github.com/repos/sergey-levin/sailfish-qtcreator/assignees{/user}","branches_url":"https://api.github.com/repos/sergey-levin/sailfish-qtcreator/branches{/branch}","tags_url":"https://api.github.com/repos/sergey-levin/sailfish-qtcreator/tags","blobs_url":"https://api.github.com/repos/sergey-levin/sailfish-qtcreator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sergey-levin/sailfish-qtcreator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sergey-levin/sailfish-qtcreator/git/refs{/sha}","trees_url":"https://api.github.com/repos/sergey-levin/sailfish-qtcreator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sergey-levin/sailfish-qtcreator/statuses/{sha}","languages_url":"https://api.github.com/repos/sergey-levin/sailfish-qtcreator/languages","stargazers_url":"https://api.github.com/repos/sergey-levin/sailfish-qtcreator/stargazers","contributors_url":"https://api.github.com/repos/sergey-levin/sailfish-qtcreator/contributors","subscribers_url":"https://api.github.com/repos/sergey-levin/sailfish-qtcreator/subscribers","subscription_url":"https://api.github.com/repos/sergey-levin/sailfish-qtcreator/subscription","commits_url":"https://api.github.com/repos/sergey-levin/sailfish-qtcreator/commits{/sha}","git_commits_url":"https://api.github.com/repos/sergey-levin/sailfish-qtcreator/git/commits{/sha}","comments_url":"https://api.github.com/repos/sergey-levin/sailfish-qtcreator/comments{/number}","issue_comment_url":"https://api.github.com/repos/sergey-levin/sailfish-qtcreator/issues/comments{/number}","contents_url":"https://api.github.com/repos/sergey-levin/sailfish-qtcreator/contents/{+path}","compare_url":"https://api.github.com/repos/sergey-levin/sailfish-qtcreator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sergey-levin/sailfish-qtcreator/merges","archive_url":"https://api.github.com/repos/sergey-levin/sailfish-qtcreator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sergey-levin/sailfish-qtcreator/downloads","issues_url":"https://api.github.com/repos/sergey-levin/sailfish-qtcreator/issues{/number}","pulls_url":"https://api.github.com/repos/sergey-levin/sailfish-qtcreator/pulls{/number}","milestones_url":"https://api.github.com/repos/sergey-levin/sailfish-qtcreator/milestones{/number}","notifications_url":"https://api.github.com/repos/sergey-levin/sailfish-qtcreator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sergey-levin/sailfish-qtcreator/labels{/name}","releases_url":"https://api.github.com/repos/sergey-levin/sailfish-qtcreator/releases{/id}","deployments_url":"https://api.github.com/repos/sergey-levin/sailfish-qtcreator/deployments","created_at":"2018-09-27T08:45:10Z","updated_at":"2018-09-27T08:45:40Z","pushed_at":"2018-12-18T06:45:04Z","git_url":"git://github.com/sergey-levin/sailfish-qtcreator.git","ssh_url":"git@github.com:sergey-levin/sailfish-qtcreator.git","clone_url":"https://github.com/sergey-levin/sailfish-qtcreator.git","svn_url":"https://github.com/sergey-levin/sailfish-qtcreator","homepage":null,"size":260333,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sailfishos:master","ref":"master","sha":"4c5e495445e7150fafb68d390b2254cbca4005c7","user":{"login":"sailfishos","id":6198659,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxOTg2NTk=","avatar_url":"https://avatars0.githubusercontent.com/u/6198659?v=4","gravatar_id":"","url":"https://api.github.com/users/sailfishos","html_url":"https://github.com/sailfishos","followers_url":"https://api.github.com/users/sailfishos/followers","following_url":"https://api.github.com/users/sailfishos/following{/other_user}","gists_url":"https://api.github.com/users/sailfishos/gists{/gist_id}","starred_url":"https://api.github.com/users/sailfishos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sailfishos/subscriptions","organizations_url":"https://api.github.com/users/sailfishos/orgs","repos_url":"https://api.github.com/users/sailfishos/repos","events_url":"https://api.github.com/users/sailfishos/events{/privacy}","received_events_url":"https://api.github.com/users/sailfishos/received_events","type":"Organization","site_admin":false},"repo":{"id":17949007,"node_id":"MDEwOlJlcG9zaXRvcnkxNzk0OTAwNw==","name":"sailfish-qtcreator","full_name":"sailfishos/sailfish-qtcreator","private":false,"owner":{"login":"sailfishos","id":6198659,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxOTg2NTk=","avatar_url":"https://avatars0.githubusercontent.com/u/6198659?v=4","gravatar_id":"","url":"https://api.github.com/users/sailfishos","html_url":"https://github.com/sailfishos","followers_url":"https://api.github.com/users/sailfishos/followers","following_url":"https://api.github.com/users/sailfishos/following{/other_user}","gists_url":"https://api.github.com/users/sailfishos/gists{/gist_id}","starred_url":"https://api.github.com/users/sailfishos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sailfishos/subscriptions","organizations_url":"https://api.github.com/users/sailfishos/orgs","repos_url":"https://api.github.com/users/sailfishos/repos","events_url":"https://api.github.com/users/sailfishos/events{/privacy}","received_events_url":"https://api.github.com/users/sailfishos/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/sailfishos/sailfish-qtcreator","description":"SDK IDE for SailfishOS application development.","fork":false,"url":"https://api.github.com/repos/sailfishos/sailfish-qtcreator","forks_url":"https://api.github.com/repos/sailfishos/sailfish-qtcreator/forks","keys_url":"https://api.github.com/repos/sailfishos/sailfish-qtcreator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sailfishos/sailfish-qtcreator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sailfishos/sailfish-qtcreator/teams","hooks_url":"https://api.github.com/repos/sailfishos/sailfish-qtcreator/hooks","issue_events_url":"https://api.github.com/repos/sailfishos/sailfish-qtcreator/issues/events{/number}","events_url":"https://api.github.com/repos/sailfishos/sailfish-qtcreator/events","assignees_url":"https://api.github.com/repos/sailfishos/sailfish-qtcreator/assignees{/user}","branches_url":"https://api.github.com/repos/sailfishos/sailfish-qtcreator/branches{/branch}","tags_url":"https://api.github.com/repos/sailfishos/sailfish-qtcreator/tags","blobs_url":"https://api.github.com/repos/sailfishos/sailfish-qtcreator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sailfishos/sailfish-qtcreator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sailfishos/sailfish-qtcreator/git/refs{/sha}","trees_url":"https://api.github.com/repos/sailfishos/sailfish-qtcreator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sailfishos/sailfish-qtcreator/statuses/{sha}","languages_url":"https://api.github.com/repos/sailfishos/sailfish-qtcreator/languages","stargazers_url":"https://api.github.com/repos/sailfishos/sailfish-qtcreator/stargazers","contributors_url":"https://api.github.com/repos/sailfishos/sailfish-qtcreator/contributors","subscribers_url":"https://api.github.com/repos/sailfishos/sailfish-qtcreator/subscribers","subscription_url":"https://api.github.com/repos/sailfishos/sailfish-qtcreator/subscription","commits_url":"https://api.github.com/repos/sailfishos/sailfish-qtcreator/commits{/sha}","git_commits_url":"https://api.github.com/repos/sailfishos/sailfish-qtcreator/git/commits{/sha}","comments_url":"https://api.github.com/repos/sailfishos/sailfish-qtcreator/comments{/number}","issue_comment_url":"https://api.github.com/repos/sailfishos/sailfish-qtcreator/issues/comments{/number}","contents_url":"https://api.github.com/repos/sailfishos/sailfish-qtcreator/contents/{+path}","compare_url":"https://api.github.com/repos/sailfishos/sailfish-qtcreator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sailfishos/sailfish-qtcreator/merges","archive_url":"https://api.github.com/repos/sailfishos/sailfish-qtcreator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sailfishos/sailfish-qtcreator/downloads","issues_url":"https://api.github.com/repos/sailfishos/sailfish-qtcreator/issues{/number}","pulls_url":"https://api.github.com/repos/sailfishos/sailfish-qtcreator/pulls{/number}","milestones_url":"https://api.github.com/repos/sailfishos/sailfish-qtcreator/milestones{/number}","notifications_url":"https://api.github.com/repos/sailfishos/sailfish-qtcreator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sailfishos/sailfish-qtcreator/labels{/name}","releases_url":"https://api.github.com/repos/sailfishos/sailfish-qtcreator/releases{/id}","deployments_url":"https://api.github.com/repos/sailfishos/sailfish-qtcreator/deployments","created_at":"2014-03-20T16:05:36Z","updated_at":"2018-12-04T08:59:53Z","pushed_at":"2018-12-18T06:45:07Z","git_url":"git://github.com/sailfishos/sailfish-qtcreator.git","ssh_url":"git@github.com:sailfishos/sailfish-qtcreator.git","clone_url":"https://github.com/sailfishos/sailfish-qtcreator.git","svn_url":"https://github.com/sailfishos/sailfish-qtcreator","homepage":null,"size":265876,"stargazers_count":21,"watchers_count":21,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":13,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":17,"open_issues":13,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sailfishos/sailfish-qtcreator/pulls/141"},"html":{"href":"https://github.com/sailfishos/sailfish-qtcreator/pull/141"},"issue":{"href":"https://api.github.com/repos/sailfishos/sailfish-qtcreator/issues/141"},"comments":{"href":"https://api.github.com/repos/sailfishos/sailfish-qtcreator/issues/141/comments"},"review_comments":{"href":"https://api.github.com/repos/sailfishos/sailfish-qtcreator/pulls/141/comments"},"review_comment":{"href":"https://api.github.com/repos/sailfishos/sailfish-qtcreator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sailfishos/sailfish-qtcreator/pulls/141/commits"},"statuses":{"href":"https://api.github.com/repos/sailfishos/sailfish-qtcreator/statuses/97a20cb6e5de28a1f79ee97b5d7e0039c8c1a858"}},"author_association":"NONE"}}
{"actor":{"display_login":"martyone"}}