{"action":"created","comment":{"url":"https://api.github.com/repos/apache/mynewt-core/pulls/comments/231991008","pull_request_review_id":173060476,"id":231991008,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTk5MTAwOA==","diff_hunk":"@@ -0,0 +1,125 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one\n+ * or more contributor license agreements.  See the NOTICE file\n+ * distributed with this work for additional information\n+ * regarding copyright ownership.  The ASF licenses this file\n+ * to you under the Apache License, Version 2.0 (the\n+ * \"License\"); you may not use this file except in compliance\n+ * with the License.  You may obtain a copy of the License at\n+ *\n+ *  http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing,\n+ * software distributed under the License is distributed on an\n+ * \"AS IS\" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY\n+ * KIND, either express or implied.  See the License for the\n+ * specific language governing permissions and limitations\n+ * under the License.\n+ */\n+#include <stddef.h>\n+\n+#include \"fcb/fcb.h\"\n+#include \"fcb_priv.h\"\n+\n+int\n+fcb_getnext_in_area(struct fcb *fcb, struct fcb_entry *loc)\n+{\n+    int rc = FCB_ERR_CRC;\n+    int off;\n+    int len;\n+\n+    while (rc == FCB_ERR_CRC) {\n+        len = loc->fe_data_len;\n+        off = loc->fe_data_off;\n+        loc->fe_data_len = 0;\n+        loc->fe_entry_num++;\n+        rc = fcb_elem_info(loc);\n+        if (len) {\n+            loc->fe_data_off = off + fcb_len_in_flash(loc->fe_range, len) +\n+                + fcb_len_in_flash(loc->fe_range, 2);","path":"fs/fcb2/src/fcb_getnext.c","position":39,"original_position":39,"commit_id":"abb8f4f521659c6397aeb501004e9374eb069c50","original_commit_id":"abb8f4f521659c6397aeb501004e9374eb069c50","user":{"login":"mkiiskila","id":2256374,"node_id":"MDQ6VXNlcjIyNTYzNzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2256374?v=4","gravatar_id":"","url":"https://api.github.com/users/mkiiskila","html_url":"https://github.com/mkiiskila","followers_url":"https://api.github.com/users/mkiiskila/followers","following_url":"https://api.github.com/users/mkiiskila/following{/other_user}","gists_url":"https://api.github.com/users/mkiiskila/gists{/gist_id}","starred_url":"https://api.github.com/users/mkiiskila/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkiiskila/subscriptions","organizations_url":"https://api.github.com/users/mkiiskila/orgs","repos_url":"https://api.github.com/users/mkiiskila/repos","events_url":"https://api.github.com/users/mkiiskila/events{/privacy}","received_events_url":"https://api.github.com/users/mkiiskila/received_events","type":"User","site_admin":false},"body":"There's an extraneous plus symbol on line 39.","created_at":"2018-11-08T17:29:56Z","updated_at":"2018-11-08T17:41:10Z","html_url":"https://github.com/apache/mynewt-core/pull/1498#discussion_r231991008","pull_request_url":"https://api.github.com/repos/apache/mynewt-core/pulls/1498","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/mynewt-core/pulls/comments/231991008"},"html":{"href":"https://github.com/apache/mynewt-core/pull/1498#discussion_r231991008"},"pull_request":{"href":"https://api.github.com/repos/apache/mynewt-core/pulls/1498"}}},"pull_request":{"url":"https://api.github.com/repos/apache/mynewt-core/pulls/1498","id":227278147,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3Mjc4MTQ3","html_url":"https://github.com/apache/mynewt-core/pull/1498","diff_url":"https://github.com/apache/mynewt-core/pull/1498.diff","patch_url":"https://github.com/apache/mynewt-core/pull/1498.patch","issue_url":"https://api.github.com/repos/apache/mynewt-core/issues/1498","number":1498,"state":"open","locked":false,"title":"fcb2: second generation of fcb","user":{"login":"kasjer","id":23063648,"node_id":"MDQ6VXNlcjIzMDYzNjQ4","avatar_url":"https://avatars2.githubusercontent.com/u/23063648?v=4","gravatar_id":"","url":"https://api.github.com/users/kasjer","html_url":"https://github.com/kasjer","followers_url":"https://api.github.com/users/kasjer/followers","following_url":"https://api.github.com/users/kasjer/following{/other_user}","gists_url":"https://api.github.com/users/kasjer/gists{/gist_id}","starred_url":"https://api.github.com/users/kasjer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kasjer/subscriptions","organizations_url":"https://api.github.com/users/kasjer/orgs","repos_url":"https://api.github.com/users/kasjer/repos","events_url":"https://api.github.com/users/kasjer/events{/privacy}","received_events_url":"https://api.github.com/users/kasjer/received_events","type":"User","site_admin":false},"body":"This fcb has smaller RAM footprint (no table describing all sector)\r\nIt is more failure resistant.\r\nIt adds fcb_read and fcb_write functions that detach\r\nuser from underlying flash access functions.","created_at":"2018-10-31T13:06:18Z","updated_at":"2018-11-08T17:41:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"fad7618b6fdf1625f9028ed3c3e1baa59cbec118","assignee":null,"assignees":[],"requested_reviewers":[{"login":"andrzej-kaczmarek","id":9692685,"node_id":"MDQ6VXNlcjk2OTI2ODU=","avatar_url":"https://avatars0.githubusercontent.com/u/9692685?v=4","gravatar_id":"","url":"https://api.github.com/users/andrzej-kaczmarek","html_url":"https://github.com/andrzej-kaczmarek","followers_url":"https://api.github.com/users/andrzej-kaczmarek/followers","following_url":"https://api.github.com/users/andrzej-kaczmarek/following{/other_user}","gists_url":"https://api.github.com/users/andrzej-kaczmarek/gists{/gist_id}","starred_url":"https://api.github.com/users/andrzej-kaczmarek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andrzej-kaczmarek/subscriptions","organizations_url":"https://api.github.com/users/andrzej-kaczmarek/orgs","repos_url":"https://api.github.com/users/andrzej-kaczmarek/repos","events_url":"https://api.github.com/users/andrzej-kaczmarek/events{/privacy}","received_events_url":"https://api.github.com/users/andrzej-kaczmarek/received_events","type":"User","site_admin":false},{"login":"ccollins476ad","id":13006531,"node_id":"MDQ6VXNlcjEzMDA2NTMx","avatar_url":"https://avatars0.githubusercontent.com/u/13006531?v=4","gravatar_id":"","url":"https://api.github.com/users/ccollins476ad","html_url":"https://github.com/ccollins476ad","followers_url":"https://api.github.com/users/ccollins476ad/followers","following_url":"https://api.github.com/users/ccollins476ad/following{/other_user}","gists_url":"https://api.github.com/users/ccollins476ad/gists{/gist_id}","starred_url":"https://api.github.com/users/ccollins476ad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ccollins476ad/subscriptions","organizations_url":"https://api.github.com/users/ccollins476ad/orgs","repos_url":"https://api.github.com/users/ccollins476ad/repos","events_url":"https://api.github.com/users/ccollins476ad/events{/privacy}","received_events_url":"https://api.github.com/users/ccollins476ad/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/mynewt-core/pulls/1498/commits","review_comments_url":"https://api.github.com/repos/apache/mynewt-core/pulls/1498/comments","review_comment_url":"https://api.github.com/repos/apache/mynewt-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/mynewt-core/issues/1498/comments","statuses_url":"https://api.github.com/repos/apache/mynewt-core/statuses/abb8f4f521659c6397aeb501004e9374eb069c50","head":{"label":"kasjer:fcb2","ref":"fcb2","sha":"abb8f4f521659c6397aeb501004e9374eb069c50","user":{"login":"kasjer","id":23063648,"node_id":"MDQ6VXNlcjIzMDYzNjQ4","avatar_url":"https://avatars2.githubusercontent.com/u/23063648?v=4","gravatar_id":"","url":"https://api.github.com/users/kasjer","html_url":"https://github.com/kasjer","followers_url":"https://api.github.com/users/kasjer/followers","following_url":"https://api.github.com/users/kasjer/following{/other_user}","gists_url":"https://api.github.com/users/kasjer/gists{/gist_id}","starred_url":"https://api.github.com/users/kasjer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kasjer/subscriptions","organizations_url":"https://api.github.com/users/kasjer/orgs","repos_url":"https://api.github.com/users/kasjer/repos","events_url":"https://api.github.com/users/kasjer/events{/privacy}","received_events_url":"https://api.github.com/users/kasjer/received_events","type":"User","site_admin":false},"repo":{"id":93192086,"node_id":"MDEwOlJlcG9zaXRvcnk5MzE5MjA4Ng==","name":"incubator-mynewt-core","full_name":"kasjer/incubator-mynewt-core","private":false,"owner":{"login":"kasjer","id":23063648,"node_id":"MDQ6VXNlcjIzMDYzNjQ4","avatar_url":"https://avatars2.githubusercontent.com/u/23063648?v=4","gravatar_id":"","url":"https://api.github.com/users/kasjer","html_url":"https://github.com/kasjer","followers_url":"https://api.github.com/users/kasjer/followers","following_url":"https://api.github.com/users/kasjer/following{/other_user}","gists_url":"https://api.github.com/users/kasjer/gists{/gist_id}","starred_url":"https://api.github.com/users/kasjer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kasjer/subscriptions","organizations_url":"https://api.github.com/users/kasjer/orgs","repos_url":"https://api.github.com/users/kasjer/repos","events_url":"https://api.github.com/users/kasjer/events{/privacy}","received_events_url":"https://api.github.com/users/kasjer/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kasjer/incubator-mynewt-core","description":null,"fork":true,"url":"https://api.github.com/repos/kasjer/incubator-mynewt-core","forks_url":"https://api.github.com/repos/kasjer/incubator-mynewt-core/forks","keys_url":"https://api.github.com/repos/kasjer/incubator-mynewt-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kasjer/incubator-mynewt-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kasjer/incubator-mynewt-core/teams","hooks_url":"https://api.github.com/repos/kasjer/incubator-mynewt-core/hooks","issue_events_url":"https://api.github.com/repos/kasjer/incubator-mynewt-core/issues/events{/number}","events_url":"https://api.github.com/repos/kasjer/incubator-mynewt-core/events","assignees_url":"https://api.github.com/repos/kasjer/incubator-mynewt-core/assignees{/user}","branches_url":"https://api.github.com/repos/kasjer/incubator-mynewt-core/branches{/branch}","tags_url":"https://api.github.com/repos/kasjer/incubator-mynewt-core/tags","blobs_url":"https://api.github.com/repos/kasjer/incubator-mynewt-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kasjer/incubator-mynewt-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kasjer/incubator-mynewt-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/kasjer/incubator-mynewt-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kasjer/incubator-mynewt-core/statuses/{sha}","languages_url":"https://api.github.com/repos/kasjer/incubator-mynewt-core/languages","stargazers_url":"https://api.github.com/repos/kasjer/incubator-mynewt-core/stargazers","contributors_url":"https://api.github.com/repos/kasjer/incubator-mynewt-core/contributors","subscribers_url":"https://api.github.com/repos/kasjer/incubator-mynewt-core/subscribers","subscription_url":"https://api.github.com/repos/kasjer/incubator-mynewt-core/subscription","commits_url":"https://api.github.com/repos/kasjer/incubator-mynewt-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/kasjer/incubator-mynewt-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/kasjer/incubator-mynewt-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/kasjer/incubator-mynewt-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/kasjer/incubator-mynewt-core/contents/{+path}","compare_url":"https://api.github.com/repos/kasjer/incubator-mynewt-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kasjer/incubator-mynewt-core/merges","archive_url":"https://api.github.com/repos/kasjer/incubator-mynewt-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kasjer/incubator-mynewt-core/downloads","issues_url":"https://api.github.com/repos/kasjer/incubator-mynewt-core/issues{/number}","pulls_url":"https://api.github.com/repos/kasjer/incubator-mynewt-core/pulls{/number}","milestones_url":"https://api.github.com/repos/kasjer/incubator-mynewt-core/milestones{/number}","notifications_url":"https://api.github.com/repos/kasjer/incubator-mynewt-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kasjer/incubator-mynewt-core/labels{/name}","releases_url":"https://api.github.com/repos/kasjer/incubator-mynewt-core/releases{/id}","deployments_url":"https://api.github.com/repos/kasjer/incubator-mynewt-core/deployments","created_at":"2017-06-02T18:10:26Z","updated_at":"2017-06-02T20:30:32Z","pushed_at":"2018-11-08T11:18:38Z","git_url":"git://github.com/kasjer/incubator-mynewt-core.git","ssh_url":"git@github.com:kasjer/incubator-mynewt-core.git","clone_url":"https://github.com/kasjer/incubator-mynewt-core.git","svn_url":"https://github.com/kasjer/incubator-mynewt-core","homepage":"","size":158659,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"3a6b1395fc437c4f277f0e62ecd4c8bcb3c6916d","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":45165993,"node_id":"MDEwOlJlcG9zaXRvcnk0NTE2NTk5Mw==","name":"mynewt-core","full_name":"apache/mynewt-core","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/mynewt-core","description":"An OS to build, deploy and securely manage billions of devices","fork":false,"url":"https://api.github.com/repos/apache/mynewt-core","forks_url":"https://api.github.com/repos/apache/mynewt-core/forks","keys_url":"https://api.github.com/repos/apache/mynewt-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/mynewt-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/mynewt-core/teams","hooks_url":"https://api.github.com/repos/apache/mynewt-core/hooks","issue_events_url":"https://api.github.com/repos/apache/mynewt-core/issues/events{/number}","events_url":"https://api.github.com/repos/apache/mynewt-core/events","assignees_url":"https://api.github.com/repos/apache/mynewt-core/assignees{/user}","branches_url":"https://api.github.com/repos/apache/mynewt-core/branches{/branch}","tags_url":"https://api.github.com/repos/apache/mynewt-core/tags","blobs_url":"https://api.github.com/repos/apache/mynewt-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/mynewt-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/mynewt-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/mynewt-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/mynewt-core/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/mynewt-core/languages","stargazers_url":"https://api.github.com/repos/apache/mynewt-core/stargazers","contributors_url":"https://api.github.com/repos/apache/mynewt-core/contributors","subscribers_url":"https://api.github.com/repos/apache/mynewt-core/subscribers","subscription_url":"https://api.github.com/repos/apache/mynewt-core/subscription","commits_url":"https://api.github.com/repos/apache/mynewt-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/mynewt-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/mynewt-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/mynewt-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/mynewt-core/contents/{+path}","compare_url":"https://api.github.com/repos/apache/mynewt-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/mynewt-core/merges","archive_url":"https://api.github.com/repos/apache/mynewt-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/mynewt-core/downloads","issues_url":"https://api.github.com/repos/apache/mynewt-core/issues{/number}","pulls_url":"https://api.github.com/repos/apache/mynewt-core/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/mynewt-core/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/mynewt-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/mynewt-core/labels{/name}","releases_url":"https://api.github.com/repos/apache/mynewt-core/releases{/id}","deployments_url":"https://api.github.com/repos/apache/mynewt-core/deployments","created_at":"2015-10-29T07:00:07Z","updated_at":"2018-11-08T15:00:43Z","pushed_at":"2018-11-08T17:21:01Z","git_url":"git://github.com/apache/mynewt-core.git","ssh_url":"git@github.com:apache/mynewt-core.git","clone_url":"https://github.com/apache/mynewt-core.git","svn_url":"https://github.com/apache/mynewt-core","homepage":"https://mynewt.apache.org/","size":158621,"stargazers_count":384,"watchers_count":384,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":198,"mirror_url":null,"archived":false,"open_issues_count":60,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":198,"open_issues":60,"watchers":384,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/mynewt-core/pulls/1498"},"html":{"href":"https://github.com/apache/mynewt-core/pull/1498"},"issue":{"href":"https://api.github.com/repos/apache/mynewt-core/issues/1498"},"comments":{"href":"https://api.github.com/repos/apache/mynewt-core/issues/1498/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/mynewt-core/pulls/1498/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/mynewt-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/mynewt-core/pulls/1498/commits"},"statuses":{"href":"https://api.github.com/repos/apache/mynewt-core/statuses/abb8f4f521659c6397aeb501004e9374eb069c50"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mkiiskila"}}