{"action":"created","comment":{"url":"https://api.github.com/repos/fission/fission/pulls/comments/180004539","pull_request_review_id":110348046,"id":180004539,"diff_hunk":"@@ -0,0 +1,131 @@\n+#!/bin/bash\n+\n+set -euo pipefail\n+\n+# To be uncommented before merge, right now for testing can't be cron\n+\n+#if [[ \"$TRAVIS_EVENT_TYPE\" -ne \"cron\" ]]\n+#then\n+#    exit 0\n+#fi\n+\n+if [ ! -f ${HOME}/.kube/config ]\n+then\n+    echo \"Skipping end to end tests, no cluster credentials\"\n+    exit 0\n+fi\n+\n+ROOT_RELPATH=$(dirname $0)/../..\n+pushd $ROOT_RELPATH\n+ROOT=$(pwd)\n+popd\n+\n+# This will change for every new release\n+CURRENT_VERSION=0.6.0\n+\n+source $ROOT/test/test_utils.sh\n+source $(dirname $0)/fixture_tests.sh\n+\n+id=$(generate_test_id)\n+ns=f-$id\n+fns=f-func-$id\n+controllerNodeport=31234\n+routerNodeport=31235\n+pruneInterval=1\n+routerServiceType=ClusterIP\n+\n+helmVars=functionNamespace=$fns,controllerPort=$controllerNodeport,routerPort=$routerNodeport,pullPolicy=Always,analytics=false,pruneInterval=$pruneInterval,routerServiceType=$routerServiceType\n+\n+#serviceType=NodePort\n+\n+dump_system_info\n+\n+timeout 30 bash -c \"helm_setup\"\n+\n+echo \"Deleting old releases\"\n+helm list -q|xargs -I@ bash -c \"helm_uninstall_fission @\"\n+\n+# deleting ns does take a while after command is issued\n+while kubectl get ns| grep \"fission-builder\"\n+do\n+    sleep 5\n+done\n+\n+helm install \\\n+--name $id \\\n+--wait \\\n+--timeout 540 \\\n+--set $helmVars \\\n+--namespace $ns \\\n+https://github.com/fission/fission/releases/download/${CURRENT_VERSION}/fission-all-${CURRENT_VERSION}.tgz\n+\n+mkdir temp && cd temp && curl -Lo fission https://github.com/fission/fission/releases/download/${CURRENT_VERSION}/fission-cli-linux && chmod +x fission && sudo mv fission /usr/local/bin/ && cd .. && rm -rf temp\n+\n+port_forward_services $id $routerNodeport","path":"test/upgrade/fission_upgrade_test.sh","position":64,"original_position":64,"commit_id":"2c9e60cbe34f5bc388be738b85d122c18ac68339","original_commit_id":"2c9e60cbe34f5bc388be738b85d122c18ac68339","user":{"login":"vishal-biyani","id":1167948,"avatar_url":"https://avatars2.githubusercontent.com/u/1167948?v=4","gravatar_id":"","url":"https://api.github.com/users/vishal-biyani","html_url":"https://github.com/vishal-biyani","followers_url":"https://api.github.com/users/vishal-biyani/followers","following_url":"https://api.github.com/users/vishal-biyani/following{/other_user}","gists_url":"https://api.github.com/users/vishal-biyani/gists{/gist_id}","starred_url":"https://api.github.com/users/vishal-biyani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishal-biyani/subscriptions","organizations_url":"https://api.github.com/users/vishal-biyani/orgs","repos_url":"https://api.github.com/users/vishal-biyani/repos","events_url":"https://api.github.com/users/vishal-biyani/events{/privacy}","received_events_url":"https://api.github.com/users/vishal-biyani/received_events","type":"User","site_admin":false},"body":"Yes I noticed change from Smruthi, will switch to load balancers too","created_at":"2018-04-09T07:11:30Z","updated_at":"2018-04-09T07:11:30Z","html_url":"https://github.com/fission/fission/pull/605#discussion_r180004539","pull_request_url":"https://api.github.com/repos/fission/fission/pulls/605","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/fission/fission/pulls/comments/180004539"},"html":{"href":"https://github.com/fission/fission/pull/605#discussion_r180004539"},"pull_request":{"href":"https://api.github.com/repos/fission/fission/pulls/605"}},"in_reply_to_id":179968510},"pull_request":{"url":"https://api.github.com/repos/fission/fission/pulls/605","id":179359953,"html_url":"https://github.com/fission/fission/pull/605","diff_url":"https://github.com/fission/fission/pull/605.diff","patch_url":"https://github.com/fission/fission/pull/605.patch","issue_url":"https://api.github.com/repos/fission/fission/issues/605","number":605,"state":"open","locked":false,"title":"Fission upgrade tests","user":{"login":"vishal-biyani","id":1167948,"avatar_url":"https://avatars2.githubusercontent.com/u/1167948?v=4","gravatar_id":"","url":"https://api.github.com/users/vishal-biyani","html_url":"https://github.com/vishal-biyani","followers_url":"https://api.github.com/users/vishal-biyani/followers","following_url":"https://api.github.com/users/vishal-biyani/following{/other_user}","gists_url":"https://api.github.com/users/vishal-biyani/gists{/gist_id}","starred_url":"https://api.github.com/users/vishal-biyani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vishal-biyani/subscriptions","organizations_url":"https://api.github.com/users/vishal-biyani/orgs","repos_url":"https://api.github.com/users/vishal-biyani/repos","events_url":"https://api.github.com/users/vishal-biyani/events{/privacy}","received_events_url":"https://api.github.com/users/vishal-biyani/received_events","type":"User","site_admin":false},"body":"This PR aims to create a simple upgrade framework in which we can add more tests later.\r\nRelated to #530\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/fission/fission/605)\n<!-- Reviewable:end -->\n","created_at":"2018-04-04T11:26:27Z","updated_at":"2018-04-09T07:11:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"899fc2514de9278becd7a048af38cc4815d4d84e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/fission/fission/milestones/9","html_url":"https://github.com/fission/fission/milestone/9","labels_url":"https://api.github.com/repos/fission/fission/milestones/9/labels","id":3219370,"number":9,"title":"0.8.0","description":"","creator":{"login":"soamvasani","id":16418446,"avatar_url":"https://avatars1.githubusercontent.com/u/16418446?v=4","gravatar_id":"","url":"https://api.github.com/users/soamvasani","html_url":"https://github.com/soamvasani","followers_url":"https://api.github.com/users/soamvasani/followers","following_url":"https://api.github.com/users/soamvasani/following{/other_user}","gists_url":"https://api.github.com/users/soamvasani/gists{/gist_id}","starred_url":"https://api.github.com/users/soamvasani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soamvasani/subscriptions","organizations_url":"https://api.github.com/users/soamvasani/orgs","repos_url":"https://api.github.com/users/soamvasani/repos","events_url":"https://api.github.com/users/soamvasani/events{/privacy}","received_events_url":"https://api.github.com/users/soamvasani/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":0,"state":"open","created_at":"2018-03-26T19:32:00Z","updated_at":"2018-04-09T00:55:47Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/fission/fission/pulls/605/commits","review_comments_url":"https://api.github.com/repos/fission/fission/pulls/605/comments","review_comment_url":"https://api.github.com/repos/fission/fission/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fission/fission/issues/605/comments","statuses_url":"https://api.github.com/repos/fission/fission/statuses/2c9e60cbe34f5bc388be738b85d122c18ac68339","head":{"label":"fission:upgrade_test_ci","ref":"upgrade_test_ci","sha":"2c9e60cbe34f5bc388be738b85d122c18ac68339","user":{"login":"fission","id":24659215,"avatar_url":"https://avatars2.githubusercontent.com/u/24659215?v=4","gravatar_id":"","url":"https://api.github.com/users/fission","html_url":"https://github.com/fission","followers_url":"https://api.github.com/users/fission/followers","following_url":"https://api.github.com/users/fission/following{/other_user}","gists_url":"https://api.github.com/users/fission/gists{/gist_id}","starred_url":"https://api.github.com/users/fission/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fission/subscriptions","organizations_url":"https://api.github.com/users/fission/orgs","repos_url":"https://api.github.com/users/fission/repos","events_url":"https://api.github.com/users/fission/events{/privacy}","received_events_url":"https://api.github.com/users/fission/received_events","type":"Organization","site_admin":false},"repo":{"id":66050533,"name":"fission","full_name":"fission/fission","owner":{"login":"fission","id":24659215,"avatar_url":"https://avatars2.githubusercontent.com/u/24659215?v=4","gravatar_id":"","url":"https://api.github.com/users/fission","html_url":"https://github.com/fission","followers_url":"https://api.github.com/users/fission/followers","following_url":"https://api.github.com/users/fission/following{/other_user}","gists_url":"https://api.github.com/users/fission/gists{/gist_id}","starred_url":"https://api.github.com/users/fission/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fission/subscriptions","organizations_url":"https://api.github.com/users/fission/orgs","repos_url":"https://api.github.com/users/fission/repos","events_url":"https://api.github.com/users/fission/events{/privacy}","received_events_url":"https://api.github.com/users/fission/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fission/fission","description":"Fast Serverless Functions for Kubernetes","fork":false,"url":"https://api.github.com/repos/fission/fission","forks_url":"https://api.github.com/repos/fission/fission/forks","keys_url":"https://api.github.com/repos/fission/fission/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fission/fission/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fission/fission/teams","hooks_url":"https://api.github.com/repos/fission/fission/hooks","issue_events_url":"https://api.github.com/repos/fission/fission/issues/events{/number}","events_url":"https://api.github.com/repos/fission/fission/events","assignees_url":"https://api.github.com/repos/fission/fission/assignees{/user}","branches_url":"https://api.github.com/repos/fission/fission/branches{/branch}","tags_url":"https://api.github.com/repos/fission/fission/tags","blobs_url":"https://api.github.com/repos/fission/fission/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fission/fission/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fission/fission/git/refs{/sha}","trees_url":"https://api.github.com/repos/fission/fission/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fission/fission/statuses/{sha}","languages_url":"https://api.github.com/repos/fission/fission/languages","stargazers_url":"https://api.github.com/repos/fission/fission/stargazers","contributors_url":"https://api.github.com/repos/fission/fission/contributors","subscribers_url":"https://api.github.com/repos/fission/fission/subscribers","subscription_url":"https://api.github.com/repos/fission/fission/subscription","commits_url":"https://api.github.com/repos/fission/fission/commits{/sha}","git_commits_url":"https://api.github.com/repos/fission/fission/git/commits{/sha}","comments_url":"https://api.github.com/repos/fission/fission/comments{/number}","issue_comment_url":"https://api.github.com/repos/fission/fission/issues/comments{/number}","contents_url":"https://api.github.com/repos/fission/fission/contents/{+path}","compare_url":"https://api.github.com/repos/fission/fission/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fission/fission/merges","archive_url":"https://api.github.com/repos/fission/fission/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fission/fission/downloads","issues_url":"https://api.github.com/repos/fission/fission/issues{/number}","pulls_url":"https://api.github.com/repos/fission/fission/pulls{/number}","milestones_url":"https://api.github.com/repos/fission/fission/milestones{/number}","notifications_url":"https://api.github.com/repos/fission/fission/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fission/fission/labels{/name}","releases_url":"https://api.github.com/repos/fission/fission/releases{/id}","deployments_url":"https://api.github.com/repos/fission/fission/deployments","created_at":"2016-08-19T03:43:56Z","updated_at":"2018-04-09T01:47:45Z","pushed_at":"2018-04-07T16:56:25Z","git_url":"git://github.com/fission/fission.git","ssh_url":"git@github.com:fission/fission.git","clone_url":"https://github.com/fission/fission.git","svn_url":"https://github.com/fission/fission","homepage":"http://fission.io","size":16886,"stargazers_count":3180,"watchers_count":3180,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":255,"mirror_url":null,"archived":false,"open_issues_count":134,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":255,"open_issues":134,"watchers":3180,"default_branch":"master"}},"base":{"label":"fission:master","ref":"master","sha":"1dbf8f92439cf823acf7fe47132c41b5a48f0f17","user":{"login":"fission","id":24659215,"avatar_url":"https://avatars2.githubusercontent.com/u/24659215?v=4","gravatar_id":"","url":"https://api.github.com/users/fission","html_url":"https://github.com/fission","followers_url":"https://api.github.com/users/fission/followers","following_url":"https://api.github.com/users/fission/following{/other_user}","gists_url":"https://api.github.com/users/fission/gists{/gist_id}","starred_url":"https://api.github.com/users/fission/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fission/subscriptions","organizations_url":"https://api.github.com/users/fission/orgs","repos_url":"https://api.github.com/users/fission/repos","events_url":"https://api.github.com/users/fission/events{/privacy}","received_events_url":"https://api.github.com/users/fission/received_events","type":"Organization","site_admin":false},"repo":{"id":66050533,"name":"fission","full_name":"fission/fission","owner":{"login":"fission","id":24659215,"avatar_url":"https://avatars2.githubusercontent.com/u/24659215?v=4","gravatar_id":"","url":"https://api.github.com/users/fission","html_url":"https://github.com/fission","followers_url":"https://api.github.com/users/fission/followers","following_url":"https://api.github.com/users/fission/following{/other_user}","gists_url":"https://api.github.com/users/fission/gists{/gist_id}","starred_url":"https://api.github.com/users/fission/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fission/subscriptions","organizations_url":"https://api.github.com/users/fission/orgs","repos_url":"https://api.github.com/users/fission/repos","events_url":"https://api.github.com/users/fission/events{/privacy}","received_events_url":"https://api.github.com/users/fission/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fission/fission","description":"Fast Serverless Functions for Kubernetes","fork":false,"url":"https://api.github.com/repos/fission/fission","forks_url":"https://api.github.com/repos/fission/fission/forks","keys_url":"https://api.github.com/repos/fission/fission/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fission/fission/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fission/fission/teams","hooks_url":"https://api.github.com/repos/fission/fission/hooks","issue_events_url":"https://api.github.com/repos/fission/fission/issues/events{/number}","events_url":"https://api.github.com/repos/fission/fission/events","assignees_url":"https://api.github.com/repos/fission/fission/assignees{/user}","branches_url":"https://api.github.com/repos/fission/fission/branches{/branch}","tags_url":"https://api.github.com/repos/fission/fission/tags","blobs_url":"https://api.github.com/repos/fission/fission/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fission/fission/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fission/fission/git/refs{/sha}","trees_url":"https://api.github.com/repos/fission/fission/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fission/fission/statuses/{sha}","languages_url":"https://api.github.com/repos/fission/fission/languages","stargazers_url":"https://api.github.com/repos/fission/fission/stargazers","contributors_url":"https://api.github.com/repos/fission/fission/contributors","subscribers_url":"https://api.github.com/repos/fission/fission/subscribers","subscription_url":"https://api.github.com/repos/fission/fission/subscription","commits_url":"https://api.github.com/repos/fission/fission/commits{/sha}","git_commits_url":"https://api.github.com/repos/fission/fission/git/commits{/sha}","comments_url":"https://api.github.com/repos/fission/fission/comments{/number}","issue_comment_url":"https://api.github.com/repos/fission/fission/issues/comments{/number}","contents_url":"https://api.github.com/repos/fission/fission/contents/{+path}","compare_url":"https://api.github.com/repos/fission/fission/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fission/fission/merges","archive_url":"https://api.github.com/repos/fission/fission/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fission/fission/downloads","issues_url":"https://api.github.com/repos/fission/fission/issues{/number}","pulls_url":"https://api.github.com/repos/fission/fission/pulls{/number}","milestones_url":"https://api.github.com/repos/fission/fission/milestones{/number}","notifications_url":"https://api.github.com/repos/fission/fission/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fission/fission/labels{/name}","releases_url":"https://api.github.com/repos/fission/fission/releases{/id}","deployments_url":"https://api.github.com/repos/fission/fission/deployments","created_at":"2016-08-19T03:43:56Z","updated_at":"2018-04-09T01:47:45Z","pushed_at":"2018-04-07T16:56:25Z","git_url":"git://github.com/fission/fission.git","ssh_url":"git@github.com:fission/fission.git","clone_url":"https://github.com/fission/fission.git","svn_url":"https://github.com/fission/fission","homepage":"http://fission.io","size":16886,"stargazers_count":3180,"watchers_count":3180,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":255,"mirror_url":null,"archived":false,"open_issues_count":134,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":255,"open_issues":134,"watchers":3180,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fission/fission/pulls/605"},"html":{"href":"https://github.com/fission/fission/pull/605"},"issue":{"href":"https://api.github.com/repos/fission/fission/issues/605"},"comments":{"href":"https://api.github.com/repos/fission/fission/issues/605/comments"},"review_comments":{"href":"https://api.github.com/repos/fission/fission/pulls/605/comments"},"review_comment":{"href":"https://api.github.com/repos/fission/fission/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fission/fission/pulls/605/commits"},"statuses":{"href":"https://api.github.com/repos/fission/fission/statuses/2c9e60cbe34f5bc388be738b85d122c18ac68339"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"vishal-biyani"}}