{"action":"created","comment":{"url":"https://api.github.com/repos/knative/serving/pulls/comments/236044790","pull_request_review_id":178053129,"id":236044790,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjA0NDc5MA==","diff_hunk":"@@ -126,6 +126,25 @@ func isProbe(r *http.Request) bool {\n \treturn strings.HasPrefix(r.Header.Get(\"User-Agent\"), \"kube-probe/\")\n }\n \n+func timeoutHandler(h http.Handler, d time.Duration) http.Handler {\n+\treturn http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {\n+\t\tdone := make(chan bool)\n+\n+\t\tgo func() {\n+\t\t\th.ServeHTTP(w, r)\n+\n+\t\t\tdone <- true\n+\t\t}()\n+\n+\t\tselect {\n+\t\tcase <-done:\n+\t\t\treturn\n+\t\tcase <-time.After(d):\n+\t\t\tpanic(http.ErrAbortHandler)","path":"cmd/queue/main.go","position":18,"original_position":18,"commit_id":"ea292f7b0e283ac1b04df2ee896555ecb6eeefb6","original_commit_id":"ea292f7b0e283ac1b04df2ee896555ecb6eeefb6","user":{"login":"mattmoor","id":2442466,"node_id":"MDQ6VXNlcjI0NDI0NjY=","avatar_url":"https://avatars3.githubusercontent.com/u/2442466?v=4","gravatar_id":"","url":"https://api.github.com/users/mattmoor","html_url":"https://github.com/mattmoor","followers_url":"https://api.github.com/users/mattmoor/followers","following_url":"https://api.github.com/users/mattmoor/following{/other_user}","gists_url":"https://api.github.com/users/mattmoor/gists{/gist_id}","starred_url":"https://api.github.com/users/mattmoor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattmoor/subscriptions","organizations_url":"https://api.github.com/users/mattmoor/orgs","repos_url":"https://api.github.com/users/mattmoor/repos","events_url":"https://api.github.com/users/mattmoor/events{/privacy}","received_events_url":"https://api.github.com/users/mattmoor/received_events","type":"User","site_admin":false},"body":"This custom reimplementation concerns me a bit.  cc @k4leung4 ","created_at":"2018-11-24T14:55:29Z","updated_at":"2018-11-24T14:55:29Z","html_url":"https://github.com/knative/serving/pull/2539#discussion_r236044790","pull_request_url":"https://api.github.com/repos/knative/serving/pulls/2539","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/knative/serving/pulls/comments/236044790"},"html":{"href":"https://github.com/knative/serving/pull/2539#discussion_r236044790"},"pull_request":{"href":"https://api.github.com/repos/knative/serving/pulls/2539"}}},"pull_request":{"url":"https://api.github.com/repos/knative/serving/pulls/2539","id":233293556,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMjkzNTU2","html_url":"https://github.com/knative/serving/pull/2539","diff_url":"https://github.com/knative/serving/pull/2539.diff","patch_url":"https://github.com/knative/serving/pull/2539.patch","issue_url":"https://api.github.com/repos/knative/serving/issues/2539","number":2539,"state":"open","locked":false,"title":"HTTP2 and gRPC support","user":{"login":"tanzeeb","id":8570,"node_id":"MDQ6VXNlcjg1NzA=","avatar_url":"https://avatars3.githubusercontent.com/u/8570?v=4","gravatar_id":"","url":"https://api.github.com/users/tanzeeb","html_url":"https://github.com/tanzeeb","followers_url":"https://api.github.com/users/tanzeeb/followers","following_url":"https://api.github.com/users/tanzeeb/following{/other_user}","gists_url":"https://api.github.com/users/tanzeeb/gists{/gist_id}","starred_url":"https://api.github.com/users/tanzeeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tanzeeb/subscriptions","organizations_url":"https://api.github.com/users/tanzeeb/orgs","repos_url":"https://api.github.com/users/tanzeeb/repos","events_url":"https://api.github.com/users/tanzeeb/events{/privacy}","received_events_url":"https://api.github.com/users/tanzeeb/received_events","type":"User","site_admin":false},"body":"<!--\r\nRequest Prow to automatically lint any go code in this PR:\r\n\r\n/lint\r\n-->\r\n\r\nThis PR adds support for HTTP/2 and gRPC services.\r\n\r\nFixes #813 \r\nFixes #706 \r\nFixes #707 \r\n\r\n**Release Note**\r\n<!-- Enter your extended release note in the below block. If the PR requires\r\nadditional action from users switching to the new release, include the string\r\n\"action required\". If no release note is required, write \"NONE\". -->\r\n```release-note\r\n* Support gRPC and HTTP/2 requests\r\n```\r\n","created_at":"2018-11-24T00:58:59Z","updated_at":"2018-11-24T14:55:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"070b899a551bb5b7e233b95f848a7960962b49ee","assignee":null,"assignees":[],"requested_reviewers":[{"login":"josephburnett","id":1103629,"node_id":"MDQ6VXNlcjExMDM2Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/1103629?v=4","gravatar_id":"","url":"https://api.github.com/users/josephburnett","html_url":"https://github.com/josephburnett","followers_url":"https://api.github.com/users/josephburnett/followers","following_url":"https://api.github.com/users/josephburnett/following{/other_user}","gists_url":"https://api.github.com/users/josephburnett/gists{/gist_id}","starred_url":"https://api.github.com/users/josephburnett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/josephburnett/subscriptions","organizations_url":"https://api.github.com/users/josephburnett/orgs","repos_url":"https://api.github.com/users/josephburnett/repos","events_url":"https://api.github.com/users/josephburnett/events{/privacy}","received_events_url":"https://api.github.com/users/josephburnett/received_events","type":"User","site_admin":false},{"login":"markusthoemmes","id":1289147,"node_id":"MDQ6VXNlcjEyODkxNDc=","avatar_url":"https://avatars3.githubusercontent.com/u/1289147?v=4","gravatar_id":"","url":"https://api.github.com/users/markusthoemmes","html_url":"https://github.com/markusthoemmes","followers_url":"https://api.github.com/users/markusthoemmes/followers","following_url":"https://api.github.com/users/markusthoemmes/following{/other_user}","gists_url":"https://api.github.com/users/markusthoemmes/gists{/gist_id}","starred_url":"https://api.github.com/users/markusthoemmes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markusthoemmes/subscriptions","organizations_url":"https://api.github.com/users/markusthoemmes/orgs","repos_url":"https://api.github.com/users/markusthoemmes/repos","events_url":"https://api.github.com/users/markusthoemmes/events{/privacy}","received_events_url":"https://api.github.com/users/markusthoemmes/received_events","type":"User","site_admin":false},{"login":"lichuqiang","id":12265352,"node_id":"MDQ6VXNlcjEyMjY1MzUy","avatar_url":"https://avatars3.githubusercontent.com/u/12265352?v=4","gravatar_id":"","url":"https://api.github.com/users/lichuqiang","html_url":"https://github.com/lichuqiang","followers_url":"https://api.github.com/users/lichuqiang/followers","following_url":"https://api.github.com/users/lichuqiang/following{/other_user}","gists_url":"https://api.github.com/users/lichuqiang/gists{/gist_id}","starred_url":"https://api.github.com/users/lichuqiang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lichuqiang/subscriptions","organizations_url":"https://api.github.com/users/lichuqiang/orgs","repos_url":"https://api.github.com/users/lichuqiang/repos","events_url":"https://api.github.com/users/lichuqiang/events{/privacy}","received_events_url":"https://api.github.com/users/lichuqiang/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":859757660,"node_id":"MDU6TGFiZWw4NTk3NTc2NjA=","url":"https://api.github.com/repos/knative/serving/labels/size/L","name":"size/L","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/knative/serving/pulls/2539/commits","review_comments_url":"https://api.github.com/repos/knative/serving/pulls/2539/comments","review_comment_url":"https://api.github.com/repos/knative/serving/pulls/comments{/number}","comments_url":"https://api.github.com/repos/knative/serving/issues/2539/comments","statuses_url":"https://api.github.com/repos/knative/serving/statuses/ea292f7b0e283ac1b04df2ee896555ecb6eeefb6","head":{"label":"tanzeeb:http2-and-grpc-support","ref":"http2-and-grpc-support","sha":"ea292f7b0e283ac1b04df2ee896555ecb6eeefb6","user":{"login":"tanzeeb","id":8570,"node_id":"MDQ6VXNlcjg1NzA=","avatar_url":"https://avatars3.githubusercontent.com/u/8570?v=4","gravatar_id":"","url":"https://api.github.com/users/tanzeeb","html_url":"https://github.com/tanzeeb","followers_url":"https://api.github.com/users/tanzeeb/followers","following_url":"https://api.github.com/users/tanzeeb/following{/other_user}","gists_url":"https://api.github.com/users/tanzeeb/gists{/gist_id}","starred_url":"https://api.github.com/users/tanzeeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tanzeeb/subscriptions","organizations_url":"https://api.github.com/users/tanzeeb/orgs","repos_url":"https://api.github.com/users/tanzeeb/repos","events_url":"https://api.github.com/users/tanzeeb/events{/privacy}","received_events_url":"https://api.github.com/users/tanzeeb/received_events","type":"User","site_admin":false},"repo":{"id":142336028,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIzMzYwMjg=","name":"serving","full_name":"tanzeeb/serving","private":false,"owner":{"login":"tanzeeb","id":8570,"node_id":"MDQ6VXNlcjg1NzA=","avatar_url":"https://avatars3.githubusercontent.com/u/8570?v=4","gravatar_id":"","url":"https://api.github.com/users/tanzeeb","html_url":"https://github.com/tanzeeb","followers_url":"https://api.github.com/users/tanzeeb/followers","following_url":"https://api.github.com/users/tanzeeb/following{/other_user}","gists_url":"https://api.github.com/users/tanzeeb/gists{/gist_id}","starred_url":"https://api.github.com/users/tanzeeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tanzeeb/subscriptions","organizations_url":"https://api.github.com/users/tanzeeb/orgs","repos_url":"https://api.github.com/users/tanzeeb/repos","events_url":"https://api.github.com/users/tanzeeb/events{/privacy}","received_events_url":"https://api.github.com/users/tanzeeb/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tanzeeb/serving","description":"Kubernetes-based, scale-to-zero, request-driven compute","fork":true,"url":"https://api.github.com/repos/tanzeeb/serving","forks_url":"https://api.github.com/repos/tanzeeb/serving/forks","keys_url":"https://api.github.com/repos/tanzeeb/serving/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tanzeeb/serving/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tanzeeb/serving/teams","hooks_url":"https://api.github.com/repos/tanzeeb/serving/hooks","issue_events_url":"https://api.github.com/repos/tanzeeb/serving/issues/events{/number}","events_url":"https://api.github.com/repos/tanzeeb/serving/events","assignees_url":"https://api.github.com/repos/tanzeeb/serving/assignees{/user}","branches_url":"https://api.github.com/repos/tanzeeb/serving/branches{/branch}","tags_url":"https://api.github.com/repos/tanzeeb/serving/tags","blobs_url":"https://api.github.com/repos/tanzeeb/serving/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tanzeeb/serving/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tanzeeb/serving/git/refs{/sha}","trees_url":"https://api.github.com/repos/tanzeeb/serving/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tanzeeb/serving/statuses/{sha}","languages_url":"https://api.github.com/repos/tanzeeb/serving/languages","stargazers_url":"https://api.github.com/repos/tanzeeb/serving/stargazers","contributors_url":"https://api.github.com/repos/tanzeeb/serving/contributors","subscribers_url":"https://api.github.com/repos/tanzeeb/serving/subscribers","subscription_url":"https://api.github.com/repos/tanzeeb/serving/subscription","commits_url":"https://api.github.com/repos/tanzeeb/serving/commits{/sha}","git_commits_url":"https://api.github.com/repos/tanzeeb/serving/git/commits{/sha}","comments_url":"https://api.github.com/repos/tanzeeb/serving/comments{/number}","issue_comment_url":"https://api.github.com/repos/tanzeeb/serving/issues/comments{/number}","contents_url":"https://api.github.com/repos/tanzeeb/serving/contents/{+path}","compare_url":"https://api.github.com/repos/tanzeeb/serving/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tanzeeb/serving/merges","archive_url":"https://api.github.com/repos/tanzeeb/serving/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tanzeeb/serving/downloads","issues_url":"https://api.github.com/repos/tanzeeb/serving/issues{/number}","pulls_url":"https://api.github.com/repos/tanzeeb/serving/pulls{/number}","milestones_url":"https://api.github.com/repos/tanzeeb/serving/milestones{/number}","notifications_url":"https://api.github.com/repos/tanzeeb/serving/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tanzeeb/serving/labels{/name}","releases_url":"https://api.github.com/repos/tanzeeb/serving/releases{/id}","deployments_url":"https://api.github.com/repos/tanzeeb/serving/deployments","created_at":"2018-07-25T18:01:16Z","updated_at":"2018-07-25T18:01:19Z","pushed_at":"2018-11-24T00:44:23Z","git_url":"git://github.com/tanzeeb/serving.git","ssh_url":"git@github.com:tanzeeb/serving.git","clone_url":"https://github.com/tanzeeb/serving.git","svn_url":"https://github.com/tanzeeb/serving","homepage":"","size":29499,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"knative:master","ref":"master","sha":"05e56db78401a7a51cba6338d735f7fe590a5583","user":{"login":"knative","id":35583233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NTgzMjMz","avatar_url":"https://avatars2.githubusercontent.com/u/35583233?v=4","gravatar_id":"","url":"https://api.github.com/users/knative","html_url":"https://github.com/knative","followers_url":"https://api.github.com/users/knative/followers","following_url":"https://api.github.com/users/knative/following{/other_user}","gists_url":"https://api.github.com/users/knative/gists{/gist_id}","starred_url":"https://api.github.com/users/knative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knative/subscriptions","organizations_url":"https://api.github.com/users/knative/orgs","repos_url":"https://api.github.com/users/knative/repos","events_url":"https://api.github.com/users/knative/events{/privacy}","received_events_url":"https://api.github.com/users/knative/received_events","type":"Organization","site_admin":false},"repo":{"id":118828329,"node_id":"MDEwOlJlcG9zaXRvcnkxMTg4MjgzMjk=","name":"serving","full_name":"knative/serving","private":false,"owner":{"login":"knative","id":35583233,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NTgzMjMz","avatar_url":"https://avatars2.githubusercontent.com/u/35583233?v=4","gravatar_id":"","url":"https://api.github.com/users/knative","html_url":"https://github.com/knative","followers_url":"https://api.github.com/users/knative/followers","following_url":"https://api.github.com/users/knative/following{/other_user}","gists_url":"https://api.github.com/users/knative/gists{/gist_id}","starred_url":"https://api.github.com/users/knative/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/knative/subscriptions","organizations_url":"https://api.github.com/users/knative/orgs","repos_url":"https://api.github.com/users/knative/repos","events_url":"https://api.github.com/users/knative/events{/privacy}","received_events_url":"https://api.github.com/users/knative/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/knative/serving","description":"Kubernetes-based, scale-to-zero, request-driven compute","fork":false,"url":"https://api.github.com/repos/knative/serving","forks_url":"https://api.github.com/repos/knative/serving/forks","keys_url":"https://api.github.com/repos/knative/serving/keys{/key_id}","collaborators_url":"https://api.github.com/repos/knative/serving/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/knative/serving/teams","hooks_url":"https://api.github.com/repos/knative/serving/hooks","issue_events_url":"https://api.github.com/repos/knative/serving/issues/events{/number}","events_url":"https://api.github.com/repos/knative/serving/events","assignees_url":"https://api.github.com/repos/knative/serving/assignees{/user}","branches_url":"https://api.github.com/repos/knative/serving/branches{/branch}","tags_url":"https://api.github.com/repos/knative/serving/tags","blobs_url":"https://api.github.com/repos/knative/serving/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/knative/serving/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/knative/serving/git/refs{/sha}","trees_url":"https://api.github.com/repos/knative/serving/git/trees{/sha}","statuses_url":"https://api.github.com/repos/knative/serving/statuses/{sha}","languages_url":"https://api.github.com/repos/knative/serving/languages","stargazers_url":"https://api.github.com/repos/knative/serving/stargazers","contributors_url":"https://api.github.com/repos/knative/serving/contributors","subscribers_url":"https://api.github.com/repos/knative/serving/subscribers","subscription_url":"https://api.github.com/repos/knative/serving/subscription","commits_url":"https://api.github.com/repos/knative/serving/commits{/sha}","git_commits_url":"https://api.github.com/repos/knative/serving/git/commits{/sha}","comments_url":"https://api.github.com/repos/knative/serving/comments{/number}","issue_comment_url":"https://api.github.com/repos/knative/serving/issues/comments{/number}","contents_url":"https://api.github.com/repos/knative/serving/contents/{+path}","compare_url":"https://api.github.com/repos/knative/serving/compare/{base}...{head}","merges_url":"https://api.github.com/repos/knative/serving/merges","archive_url":"https://api.github.com/repos/knative/serving/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/knative/serving/downloads","issues_url":"https://api.github.com/repos/knative/serving/issues{/number}","pulls_url":"https://api.github.com/repos/knative/serving/pulls{/number}","milestones_url":"https://api.github.com/repos/knative/serving/milestones{/number}","notifications_url":"https://api.github.com/repos/knative/serving/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/knative/serving/labels{/name}","releases_url":"https://api.github.com/repos/knative/serving/releases{/id}","deployments_url":"https://api.github.com/repos/knative/serving/deployments","created_at":"2018-01-24T22:07:44Z","updated_at":"2018-11-24T05:05:06Z","pushed_at":"2018-11-24T04:41:23Z","git_url":"git://github.com/knative/serving.git","ssh_url":"git@github.com:knative/serving.git","clone_url":"https://github.com/knative/serving.git","svn_url":"https://github.com/knative/serving","homepage":"","size":29485,"stargazers_count":874,"watchers_count":874,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":178,"mirror_url":null,"archived":false,"open_issues_count":316,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":178,"open_issues":316,"watchers":874,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/knative/serving/pulls/2539"},"html":{"href":"https://github.com/knative/serving/pull/2539"},"issue":{"href":"https://api.github.com/repos/knative/serving/issues/2539"},"comments":{"href":"https://api.github.com/repos/knative/serving/issues/2539/comments"},"review_comments":{"href":"https://api.github.com/repos/knative/serving/pulls/2539/comments"},"review_comment":{"href":"https://api.github.com/repos/knative/serving/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/knative/serving/pulls/2539/commits"},"statuses":{"href":"https://api.github.com/repos/knative/serving/statuses/ea292f7b0e283ac1b04df2ee896555ecb6eeefb6"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mattmoor"}}