{"action":"created","issue":{"url":"https://api.github.com/repos/keymanapp/keyboards/issues/266","repository_url":"https://api.github.com/repos/keymanapp/keyboards","labels_url":"https://api.github.com/repos/keymanapp/keyboards/issues/266/labels{/name}","comments_url":"https://api.github.com/repos/keymanapp/keyboards/issues/266/comments","events_url":"https://api.github.com/repos/keymanapp/keyboards/issues/266/events","html_url":"https://github.com/keymanapp/keyboards/pull/266","id":321957678,"number":266,"title":"[balochi_urdu] New Balochi keyboard based on the Urdu layout.","user":{"login":"rmlockwood","id":7088137,"avatar_url":"https://avatars3.githubusercontent.com/u/7088137?v=4","gravatar_id":"","url":"https://api.github.com/users/rmlockwood","html_url":"https://github.com/rmlockwood","followers_url":"https://api.github.com/users/rmlockwood/followers","following_url":"https://api.github.com/users/rmlockwood/following{/other_user}","gists_url":"https://api.github.com/users/rmlockwood/gists{/gist_id}","starred_url":"https://api.github.com/users/rmlockwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmlockwood/subscriptions","organizations_url":"https://api.github.com/users/rmlockwood/orgs","repos_url":"https://api.github.com/users/rmlockwood/repos","events_url":"https://api.github.com/users/rmlockwood/events{/privacy}","received_events_url":"https://api.github.com/users/rmlockwood/received_events","type":"User","site_admin":false},"labels":[{"id":636485513,"url":"https://api.github.com/repos/keymanapp/keyboards/labels/keyboard","name":"keyboard","color":"0e8a16","default":false},{"id":847589239,"url":"https://api.github.com/repos/keymanapp/keyboards/labels/new","name":"new","color":"c2e0c6","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-05-10T14:43:47Z","updated_at":"2018-05-17T11:42:02Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/keymanapp/keyboards/pulls/266","html_url":"https://github.com/keymanapp/keyboards/pull/266","diff_url":"https://github.com/keymanapp/keyboards/pull/266.diff","patch_url":"https://github.com/keymanapp/keyboards/pull/266.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/keymanapp/keyboards/issues/comments/389837771","html_url":"https://github.com/keymanapp/keyboards/pull/266#issuecomment-389837771","issue_url":"https://api.github.com/repos/keymanapp/keyboards/issues/266","id":389837771,"user":{"login":"rmlockwood","id":7088137,"avatar_url":"https://avatars3.githubusercontent.com/u/7088137?v=4","gravatar_id":"","url":"https://api.github.com/users/rmlockwood","html_url":"https://github.com/rmlockwood","followers_url":"https://api.github.com/users/rmlockwood/followers","following_url":"https://api.github.com/users/rmlockwood/following{/other_user}","gists_url":"https://api.github.com/users/rmlockwood/gists{/gist_id}","starred_url":"https://api.github.com/users/rmlockwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmlockwood/subscriptions","organizations_url":"https://api.github.com/users/rmlockwood/orgs","repos_url":"https://api.github.com/users/rmlockwood/repos","events_url":"https://api.github.com/users/rmlockwood/events{/privacy}","received_events_url":"https://api.github.com/users/rmlockwood/received_events","type":"User","site_admin":false},"created_at":"2018-05-17T11:42:02Z","updated_at":"2018-05-17T11:42:02Z","author_association":"CONTRIBUTOR","body":"The FBA7 is the image I want. In its isolated form it looks exactly like the other heh so I wanted to distinguish it.\n\n \n\nThe SHIFT+CTRL ` is just what was already on the Urdu keyboard and I was trying to keep things the same. I think I’ll delete it though. I don’t know why they would want a presentation form outputted.\n\n \n\nI do have the main diacritics on the touch layouts. For phone they are long-press on the K_P key. For tablet, damma, kasra, fatha and sukun are on the right side on the default layer. There’s a couple more on the shift layer.\n\n \n\nFor phone:\n\n*\tU+06D9 – now on long press of K_P\n*\tU+064B – on long press of K_P\n*\tU+064C – now on long press of K_P\n*\tU+064D – now on long press of K_P\n*\tU+06E2 – now on long press of K_P\n*\tU+0625 –  on long press of K_J\n\nFor tablet:\n\n*\tU+06D9 – now on long press of K_LBRKT\n*\tU+064B – now on long press of K_ LBRKT\n*\tU+064C – now on long press of K_ LBRKT\n*\tU+064D – now on long press of K_ LBRKT\n*\tU+06E2 – now on long press of K_ LBRKT\n*\tU+0625 –  on long press of K_J\n\nThe vav behavior is what I want. We want the composed character outputted. I changed 0658 to 0654. Thanks for catching that.\n\n \n\nI’ve committed the changes.\n\n \n\nThanks,\n\nRon\n\n \n\n \n\nFrom: Lorna Evans <notifications@github.com> \nSent: Tuesday, May 15, 2018 9:11 PM\nTo: keymanapp/keyboards <keyboards@noreply.github.com>\nCc: R Lockwood <rlbooks@web.de>; Author <author@noreply.github.com>\nSubject: Re: [keymanapp/keyboards] [balochi_urdu] New Balochi keyboard based on the Urdu layout. (#266)\n\n \n\nThanks!\n\nI'm wondering about the shift \\ key that outputs U+06C1. The On screen keyboard has U+FBA7 on the keycap. Could that be changed? Then the OSK graphic needs regenerating for the welcome file.\n\nAlso, on SHIFT+CTRL ` you are outputting U+FEF2. I'm just wondering why. You're already outputting U+064A on the \"L\" key.\n\n*\tIt looks like none of the characters from the desktop CTRL+SHIFT layer are on the touch layouts. I don't know how important that is, because the following characters are on both the default and the CTRL+SHIFT layer \n\n*\tdamma U+064F\n*\tfatha U+064E\n*\tkasra U+0650\n*\tsukun U+0652\n*\talef hamza U+0623\n\n*\tSo the characters on the desktop CTRL+SHIFT layer that aren't on the tablet/phone layouts are (consider adding them to a longpress): \n\n*\tU+FEF2 (which I asked above about)\n*\tU+06D9\n*\tU+064B\n*\tU+064C\n*\tU+064D\n*\tU+06E2\n*\tU+0625\n\n*\tOn the phone layout I noticed that the default / top row / far right key outputs U+06C6 and U+0648 which are also output somewhere else (default / middle row / 2nd from left key). You could make the top far right key a diacritic longpress instead of having the waws there (and then include the above diacritics). (Maybe use the fatha U+064E on the keycap and as the default output.) \n\n*\ton that same default / top row /far right key, there is a thing in the longpress that has the glyph of U+0654, but it is outputting U+0658. I think you want U+0654 instead of U+0658.\n\nI'm sorry I didn't actually test the touch layouts yesterday.\n\nIt would also be good to open the .kps file and on the Keyboards tab add the BCP-47 tags for the 4 languages. I think that will make it so people can find the mobile keyboards by language name and not just tag.\n\n—\nYou are receiving this because you authored the thread.\nReply to this email directly,  <https://github.com/keymanapp/keyboards/pull/266#issuecomment-389280350> view it on GitHub, or  <https://github.com/notifications/unsubscribe-auth/AGwoCbvH-X_zAko0eE6f77eWbf_fPy3xks5tyyhMgaJpZM4T6Ad1> mute the thread.\n\n"}}
{"actor":{"display_login":"rmlockwood"}}