{"action":"opened","number":18101,"pull_request":{"url":"https://api.github.com/repos/apple/swift/pulls/18101","id":202738804,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyNzM4ODA0","html_url":"https://github.com/apple/swift/pull/18101","diff_url":"https://github.com/apple/swift/pull/18101.diff","patch_url":"https://github.com/apple/swift/pull/18101.patch","issue_url":"https://api.github.com/repos/apple/swift/issues/18101","number":18101,"state":"open","locked":false,"title":"[Type checker] Move forcing of overridden/@objc/dynamic into finalizeType().","user":{"login":"DougGregor","id":989428,"node_id":"MDQ6VXNlcjk4OTQyOA==","avatar_url":"https://avatars3.githubusercontent.com/u/989428?v=4","gravatar_id":"","url":"https://api.github.com/users/DougGregor","html_url":"https://github.com/DougGregor","followers_url":"https://api.github.com/users/DougGregor/followers","following_url":"https://api.github.com/users/DougGregor/following{/other_user}","gists_url":"https://api.github.com/users/DougGregor/gists{/gist_id}","starred_url":"https://api.github.com/users/DougGregor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DougGregor/subscriptions","organizations_url":"https://api.github.com/users/DougGregor/orgs","repos_url":"https://api.github.com/users/DougGregor/repos","events_url":"https://api.github.com/users/DougGregor/events{/privacy}","received_events_url":"https://api.github.com/users/DougGregor/received_events","type":"User","site_admin":false},"body":"As part of factoring overridden decls/@objc/dynamic computation into\r\nrequests for the request-evaluator, I forced computation of this\r\ninformation as part of requestMemberLayout. This is incorrect:\r\nrequestMemberLayout() is meant only to trigger finalization of the\r\nenclosing class, which is responsible for making sure the type can be\r\nproperly laid out. Move the newly-introduced forcing logic into\r\nfinalizeType() where it belongs.\r\n\r\nThanks to @slavapestov for describing the intent here.\r\n","created_at":"2018-07-20T03:42:21Z","updated_at":"2018-07-20T03:42:21Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apple/swift/pulls/18101/commits","review_comments_url":"https://api.github.com/repos/apple/swift/pulls/18101/comments","review_comment_url":"https://api.github.com/repos/apple/swift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apple/swift/issues/18101/comments","statuses_url":"https://api.github.com/repos/apple/swift/statuses/926e9c26aea0a156978317fce332db320c7a6d4f","head":{"label":"DougGregor:finalize-type-force-layout","ref":"finalize-type-force-layout","sha":"926e9c26aea0a156978317fce332db320c7a6d4f","user":{"login":"DougGregor","id":989428,"node_id":"MDQ6VXNlcjk4OTQyOA==","avatar_url":"https://avatars3.githubusercontent.com/u/989428?v=4","gravatar_id":"","url":"https://api.github.com/users/DougGregor","html_url":"https://github.com/DougGregor","followers_url":"https://api.github.com/users/DougGregor/followers","following_url":"https://api.github.com/users/DougGregor/following{/other_user}","gists_url":"https://api.github.com/users/DougGregor/gists{/gist_id}","starred_url":"https://api.github.com/users/DougGregor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DougGregor/subscriptions","organizations_url":"https://api.github.com/users/DougGregor/orgs","repos_url":"https://api.github.com/users/DougGregor/repos","events_url":"https://api.github.com/users/DougGregor/events{/privacy}","received_events_url":"https://api.github.com/users/DougGregor/received_events","type":"User","site_admin":false},"repo":{"id":50400732,"node_id":"MDEwOlJlcG9zaXRvcnk1MDQwMDczMg==","name":"swift","full_name":"DougGregor/swift","owner":{"login":"DougGregor","id":989428,"node_id":"MDQ6VXNlcjk4OTQyOA==","avatar_url":"https://avatars3.githubusercontent.com/u/989428?v=4","gravatar_id":"","url":"https://api.github.com/users/DougGregor","html_url":"https://github.com/DougGregor","followers_url":"https://api.github.com/users/DougGregor/followers","following_url":"https://api.github.com/users/DougGregor/following{/other_user}","gists_url":"https://api.github.com/users/DougGregor/gists{/gist_id}","starred_url":"https://api.github.com/users/DougGregor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DougGregor/subscriptions","organizations_url":"https://api.github.com/users/DougGregor/orgs","repos_url":"https://api.github.com/users/DougGregor/repos","events_url":"https://api.github.com/users/DougGregor/events{/privacy}","received_events_url":"https://api.github.com/users/DougGregor/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DougGregor/swift","description":"The Swift Programming Language","fork":true,"url":"https://api.github.com/repos/DougGregor/swift","forks_url":"https://api.github.com/repos/DougGregor/swift/forks","keys_url":"https://api.github.com/repos/DougGregor/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DougGregor/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DougGregor/swift/teams","hooks_url":"https://api.github.com/repos/DougGregor/swift/hooks","issue_events_url":"https://api.github.com/repos/DougGregor/swift/issues/events{/number}","events_url":"https://api.github.com/repos/DougGregor/swift/events","assignees_url":"https://api.github.com/repos/DougGregor/swift/assignees{/user}","branches_url":"https://api.github.com/repos/DougGregor/swift/branches{/branch}","tags_url":"https://api.github.com/repos/DougGregor/swift/tags","blobs_url":"https://api.github.com/repos/DougGregor/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DougGregor/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DougGregor/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/DougGregor/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DougGregor/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/DougGregor/swift/languages","stargazers_url":"https://api.github.com/repos/DougGregor/swift/stargazers","contributors_url":"https://api.github.com/repos/DougGregor/swift/contributors","subscribers_url":"https://api.github.com/repos/DougGregor/swift/subscribers","subscription_url":"https://api.github.com/repos/DougGregor/swift/subscription","commits_url":"https://api.github.com/repos/DougGregor/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/DougGregor/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/DougGregor/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/DougGregor/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/DougGregor/swift/contents/{+path}","compare_url":"https://api.github.com/repos/DougGregor/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DougGregor/swift/merges","archive_url":"https://api.github.com/repos/DougGregor/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DougGregor/swift/downloads","issues_url":"https://api.github.com/repos/DougGregor/swift/issues{/number}","pulls_url":"https://api.github.com/repos/DougGregor/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/DougGregor/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/DougGregor/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DougGregor/swift/labels{/name}","releases_url":"https://api.github.com/repos/DougGregor/swift/releases{/id}","deployments_url":"https://api.github.com/repos/DougGregor/swift/deployments","created_at":"2016-01-26T03:34:10Z","updated_at":"2017-09-11T08:07:10Z","pushed_at":"2018-07-20T03:41:50Z","git_url":"git://github.com/DougGregor/swift.git","ssh_url":"git@github.com:DougGregor/swift.git","clone_url":"https://github.com/DougGregor/swift.git","svn_url":"https://github.com/DougGregor/swift","homepage":"https://swift.org/","size":291111,"stargazers_count":6,"watchers_count":6,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":6,"default_branch":"master"}},"base":{"label":"apple:master","ref":"master","sha":"5980c4c9169b5d3fef125f8cf6d020feba1e9aa2","user":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"repo":{"id":44838949,"node_id":"MDEwOlJlcG9zaXRvcnk0NDgzODk0OQ==","name":"swift","full_name":"apple/swift","owner":{"login":"apple","id":10639145,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjM5MTQ1","avatar_url":"https://avatars0.githubusercontent.com/u/10639145?v=4","gravatar_id":"","url":"https://api.github.com/users/apple","html_url":"https://github.com/apple","followers_url":"https://api.github.com/users/apple/followers","following_url":"https://api.github.com/users/apple/following{/other_user}","gists_url":"https://api.github.com/users/apple/gists{/gist_id}","starred_url":"https://api.github.com/users/apple/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apple/subscriptions","organizations_url":"https://api.github.com/users/apple/orgs","repos_url":"https://api.github.com/users/apple/repos","events_url":"https://api.github.com/users/apple/events{/privacy}","received_events_url":"https://api.github.com/users/apple/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apple/swift","description":"The Swift Programming Language","fork":false,"url":"https://api.github.com/repos/apple/swift","forks_url":"https://api.github.com/repos/apple/swift/forks","keys_url":"https://api.github.com/repos/apple/swift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apple/swift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apple/swift/teams","hooks_url":"https://api.github.com/repos/apple/swift/hooks","issue_events_url":"https://api.github.com/repos/apple/swift/issues/events{/number}","events_url":"https://api.github.com/repos/apple/swift/events","assignees_url":"https://api.github.com/repos/apple/swift/assignees{/user}","branches_url":"https://api.github.com/repos/apple/swift/branches{/branch}","tags_url":"https://api.github.com/repos/apple/swift/tags","blobs_url":"https://api.github.com/repos/apple/swift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apple/swift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apple/swift/git/refs{/sha}","trees_url":"https://api.github.com/repos/apple/swift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apple/swift/statuses/{sha}","languages_url":"https://api.github.com/repos/apple/swift/languages","stargazers_url":"https://api.github.com/repos/apple/swift/stargazers","contributors_url":"https://api.github.com/repos/apple/swift/contributors","subscribers_url":"https://api.github.com/repos/apple/swift/subscribers","subscription_url":"https://api.github.com/repos/apple/swift/subscription","commits_url":"https://api.github.com/repos/apple/swift/commits{/sha}","git_commits_url":"https://api.github.com/repos/apple/swift/git/commits{/sha}","comments_url":"https://api.github.com/repos/apple/swift/comments{/number}","issue_comment_url":"https://api.github.com/repos/apple/swift/issues/comments{/number}","contents_url":"https://api.github.com/repos/apple/swift/contents/{+path}","compare_url":"https://api.github.com/repos/apple/swift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apple/swift/merges","archive_url":"https://api.github.com/repos/apple/swift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apple/swift/downloads","issues_url":"https://api.github.com/repos/apple/swift/issues{/number}","pulls_url":"https://api.github.com/repos/apple/swift/pulls{/number}","milestones_url":"https://api.github.com/repos/apple/swift/milestones{/number}","notifications_url":"https://api.github.com/repos/apple/swift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apple/swift/labels{/name}","releases_url":"https://api.github.com/repos/apple/swift/releases{/id}","deployments_url":"https://api.github.com/repos/apple/swift/deployments","created_at":"2015-10-23T21:15:07Z","updated_at":"2018-07-20T03:36:13Z","pushed_at":"2018-07-20T02:46:05Z","git_url":"git://github.com/apple/swift.git","ssh_url":"git@github.com:apple/swift.git","clone_url":"https://github.com/apple/swift.git","svn_url":"https://github.com/apple/swift","homepage":"https://swift.org/","size":313418,"stargazers_count":44589,"watchers_count":44589,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7036,"mirror_url":null,"archived":false,"open_issues_count":364,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7036,"open_issues":364,"watchers":44589,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apple/swift/pulls/18101"},"html":{"href":"https://github.com/apple/swift/pull/18101"},"issue":{"href":"https://api.github.com/repos/apple/swift/issues/18101"},"comments":{"href":"https://api.github.com/repos/apple/swift/issues/18101/comments"},"review_comments":{"href":"https://api.github.com/repos/apple/swift/pulls/18101/comments"},"review_comment":{"href":"https://api.github.com/repos/apple/swift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apple/swift/pulls/18101/commits"},"statuses":{"href":"https://api.github.com/repos/apple/swift/statuses/926e9c26aea0a156978317fce332db320c7a6d4f"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":17,"deletions":21,"changed_files":1}}
{"actor":{"display_login":"DougGregor"}}