{"action":"created","issue":{"url":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/issues/1227","repository_url":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng","labels_url":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/issues/1227/labels{/name}","comments_url":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/issues/1227/comments","events_url":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/issues/1227/events","html_url":"https://github.com/cloudfoundry/cloud_controller_ng/pull/1227","id":366576744,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwMjE2NTE3","number":1227,"title":"Check for nil entries in bulk sync call","user":{"login":"KauzClay","id":20053083,"node_id":"MDQ6VXNlcjIwMDUzMDgz","avatar_url":"https://avatars2.githubusercontent.com/u/20053083?v=4","gravatar_id":"","url":"https://api.github.com/users/KauzClay","html_url":"https://github.com/KauzClay","followers_url":"https://api.github.com/users/KauzClay/followers","following_url":"https://api.github.com/users/KauzClay/following{/other_user}","gists_url":"https://api.github.com/users/KauzClay/gists{/gist_id}","starred_url":"https://api.github.com/users/KauzClay/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/KauzClay/subscriptions","organizations_url":"https://api.github.com/users/KauzClay/orgs","repos_url":"https://api.github.com/users/KauzClay/repos","events_url":"https://api.github.com/users/KauzClay/events{/privacy}","received_events_url":"https://api.github.com/users/KauzClay/received_events","type":"User","site_admin":false},"labels":[{"id":240264792,"node_id":"MDU6TGFiZWwyNDAyNjQ3OTI=","url":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/labels/unscheduled","name":"unscheduled","color":"D9D9D9","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-10-04T00:16:49Z","updated_at":"2018-10-09T18:12:08Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/pulls/1227","html_url":"https://github.com/cloudfoundry/cloud_controller_ng/pull/1227","diff_url":"https://github.com/cloudfoundry/cloud_controller_ng/pull/1227.diff","patch_url":"https://github.com/cloudfoundry/cloud_controller_ng/pull/1227.patch"},"body":"[#160866520]\r\n\r\nThanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:\r\n\r\n* A short explanation of the proposed change:\r\nhttps://www.pivotaltracker.com/story/show/160866520\r\nAs noted in the above story, we observed a problem with route_syncer when a route was being deleted at the same time a bulk_sync was occurring. Basically, the bulk_sync would try to 'sync' a route that had already been deleted, causing some nil error.\r\n\r\nTo fix this, we added checks to remove any nil objects that were deleted before making the bulk_sync call on the copilot client.\r\n\r\n* An explanation of the use cases your change solves\r\n\r\n* Links to any other associated PRs\r\n\r\n* [X] I have reviewed the [contributing guide](https://github.com/cloudfoundry/cloud_controller_ng/blob/master/CONTRIBUTING.md)\r\n\r\n* [X] I have viewed, signed, and submitted the Contributor License Agreement\r\n\r\n* [X] I have made this pull request to the `master` branch\r\n\r\n* [X] I have run all the unit tests using `bundle exec rake`\r\n\r\n* [ ] I have run [CF Acceptance Tests](https://github.com/cloudfoundry/cloud_controller_ng#cf-acceptance-tests-cats)\r\n"},"comment":{"url":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/issues/comments/428294258","html_url":"https://github.com/cloudfoundry/cloud_controller_ng/pull/1227#issuecomment-428294258","issue_url":"https://api.github.com/repos/cloudfoundry/cloud_controller_ng/issues/1227","id":428294258,"node_id":"MDEyOklzc3VlQ29tbWVudDQyODI5NDI1OA==","user":{"login":"monamohebbi","id":8052677,"node_id":"MDQ6VXNlcjgwNTI2Nzc=","avatar_url":"https://avatars2.githubusercontent.com/u/8052677?v=4","gravatar_id":"","url":"https://api.github.com/users/monamohebbi","html_url":"https://github.com/monamohebbi","followers_url":"https://api.github.com/users/monamohebbi/followers","following_url":"https://api.github.com/users/monamohebbi/following{/other_user}","gists_url":"https://api.github.com/users/monamohebbi/gists{/gist_id}","starred_url":"https://api.github.com/users/monamohebbi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/monamohebbi/subscriptions","organizations_url":"https://api.github.com/users/monamohebbi/orgs","repos_url":"https://api.github.com/users/monamohebbi/repos","events_url":"https://api.github.com/users/monamohebbi/events{/privacy}","received_events_url":"https://api.github.com/users/monamohebbi/received_events","type":"User","site_admin":false},"created_at":"2018-10-09T18:12:08Z","updated_at":"2018-10-09T18:12:08Z","author_association":"NONE","body":"Hello @KauzClay \r\n\r\nThanks for nailing down the problem.\r\n\r\nCould you make the suggested change to the loop to reject nil values up front?\r\n\r\nAlso, TravisCI is failing, but most likely if you rebase your PR against master that will fix the problem.\r\n\r\nThanks,\r\n@monamohebbi and @ericpromislow,  your CAPI Community Pair\r\n"}}
{"actor":{"display_login":"monamohebbi"}}