{"action":"created","comment":{"url":"https://api.github.com/repos/pcdshub/happi/pulls/comments/226790661","pull_request_review_id":166706829,"id":226790661,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjc5MDY2MQ==","diff_hunk":"@@ -155,11 +155,5 @@ def test_qs_find(mockqsbackend):\n def test_qsbackend_with_client(mockqsbackend):\n     c = Client(database=mockqsbackend)\n     assert len(c.all_devices) == 6\n-    assert all([d.device_class == 'pcdsdevices.epics_motor.IMS'\n+    assert all([d.device_class == 'pcdsdevices.device_types.Motor'","path":"happi/tests/test_backends.py","position":5,"original_position":5,"commit_id":"f6ffc0234e47e16a21fbefe1c407791f357598a5","original_commit_id":"f6ffc0234e47e16a21fbefe1c407791f357598a5","user":{"login":"ZLLentz","id":10647860,"node_id":"MDQ6VXNlcjEwNjQ3ODYw","avatar_url":"https://avatars3.githubusercontent.com/u/10647860?v=4","gravatar_id":"","url":"https://api.github.com/users/ZLLentz","html_url":"https://github.com/ZLLentz","followers_url":"https://api.github.com/users/ZLLentz/followers","following_url":"https://api.github.com/users/ZLLentz/following{/other_user}","gists_url":"https://api.github.com/users/ZLLentz/gists{/gist_id}","starred_url":"https://api.github.com/users/ZLLentz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZLLentz/subscriptions","organizations_url":"https://api.github.com/users/ZLLentz/orgs","repos_url":"https://api.github.com/users/ZLLentz/repos","events_url":"https://api.github.com/users/ZLLentz/events{/privacy}","received_events_url":"https://api.github.com/users/ZLLentz/received_events","type":"User","site_admin":false},"body":"It's confusing what you're testing in here because `Motor` isn't really a class","created_at":"2018-10-19T21:49:16Z","updated_at":"2018-10-19T21:49:17Z","html_url":"https://github.com/pcdshub/happi/pull/76#discussion_r226790661","pull_request_url":"https://api.github.com/repos/pcdshub/happi/pulls/76","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pcdshub/happi/pulls/comments/226790661"},"html":{"href":"https://github.com/pcdshub/happi/pull/76#discussion_r226790661"},"pull_request":{"href":"https://api.github.com/repos/pcdshub/happi/pulls/76"}}},"pull_request":{"url":"https://api.github.com/repos/pcdshub/happi/pulls/76","id":224416566,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NDE2NTY2","html_url":"https://github.com/pcdshub/happi/pull/76","diff_url":"https://github.com/pcdshub/happi/pull/76.diff","patch_url":"https://github.com/pcdshub/happi/pull/76.patch","issue_url":"https://api.github.com/repos/pcdshub/happi/issues/76","number":76,"state":"open","locked":false,"title":"Motor","user":{"login":"teddyrendahl","id":25753048,"node_id":"MDQ6VXNlcjI1NzUzMDQ4","avatar_url":"https://avatars3.githubusercontent.com/u/25753048?v=4","gravatar_id":"","url":"https://api.github.com/users/teddyrendahl","html_url":"https://github.com/teddyrendahl","followers_url":"https://api.github.com/users/teddyrendahl/followers","following_url":"https://api.github.com/users/teddyrendahl/following{/other_user}","gists_url":"https://api.github.com/users/teddyrendahl/gists{/gist_id}","starred_url":"https://api.github.com/users/teddyrendahl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teddyrendahl/subscriptions","organizations_url":"https://api.github.com/users/teddyrendahl/orgs","repos_url":"https://api.github.com/users/teddyrendahl/repos","events_url":"https://api.github.com/users/teddyrendahl/events{/privacy}","received_events_url":"https://api.github.com/users/teddyrendahl/received_events","type":"User","site_admin":false},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n## Description\r\n<!--- Describe your changes in detail -->\r\nAdd a generic `Motor` container. By default this points to the factory created in https://github.com/pcdshub/pcdsdevices/pull/306. \r\n\r\nThere was also some code that in the Questionnaire Backend that essentially had the same logic as the factory. This is obviously the wrong place to put this as if we scramble around our motor classes we need to remember the \r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue here. -->\r\nCloses #57 \r\n\r\n## Where Has This Been Documented?\r\n<!--  Include where the changes made have been documented. -->\r\n<!--  This can simply be  a comment in the code or updating a docstring -->\r\nAdded to autosummary","created_at":"2018-10-19T21:36:50Z","updated_at":"2018-10-19T21:49:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3756a3caa1c91ac62580748adf1b8a950ee7455e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pcdshub/happi/pulls/76/commits","review_comments_url":"https://api.github.com/repos/pcdshub/happi/pulls/76/comments","review_comment_url":"https://api.github.com/repos/pcdshub/happi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pcdshub/happi/issues/76/comments","statuses_url":"https://api.github.com/repos/pcdshub/happi/statuses/f6ffc0234e47e16a21fbefe1c407791f357598a5","head":{"label":"teddyrendahl:motor","ref":"motor","sha":"f6ffc0234e47e16a21fbefe1c407791f357598a5","user":{"login":"teddyrendahl","id":25753048,"node_id":"MDQ6VXNlcjI1NzUzMDQ4","avatar_url":"https://avatars3.githubusercontent.com/u/25753048?v=4","gravatar_id":"","url":"https://api.github.com/users/teddyrendahl","html_url":"https://github.com/teddyrendahl","followers_url":"https://api.github.com/users/teddyrendahl/followers","following_url":"https://api.github.com/users/teddyrendahl/following{/other_user}","gists_url":"https://api.github.com/users/teddyrendahl/gists{/gist_id}","starred_url":"https://api.github.com/users/teddyrendahl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teddyrendahl/subscriptions","organizations_url":"https://api.github.com/users/teddyrendahl/orgs","repos_url":"https://api.github.com/users/teddyrendahl/repos","events_url":"https://api.github.com/users/teddyrendahl/events{/privacy}","received_events_url":"https://api.github.com/users/teddyrendahl/received_events","type":"User","site_admin":false},"repo":{"id":121307186,"node_id":"MDEwOlJlcG9zaXRvcnkxMjEzMDcxODY=","name":"happi","full_name":"teddyrendahl/happi","private":false,"owner":{"login":"teddyrendahl","id":25753048,"node_id":"MDQ6VXNlcjI1NzUzMDQ4","avatar_url":"https://avatars3.githubusercontent.com/u/25753048?v=4","gravatar_id":"","url":"https://api.github.com/users/teddyrendahl","html_url":"https://github.com/teddyrendahl","followers_url":"https://api.github.com/users/teddyrendahl/followers","following_url":"https://api.github.com/users/teddyrendahl/following{/other_user}","gists_url":"https://api.github.com/users/teddyrendahl/gists{/gist_id}","starred_url":"https://api.github.com/users/teddyrendahl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/teddyrendahl/subscriptions","organizations_url":"https://api.github.com/users/teddyrendahl/orgs","repos_url":"https://api.github.com/users/teddyrendahl/repos","events_url":"https://api.github.com/users/teddyrendahl/events{/privacy}","received_events_url":"https://api.github.com/users/teddyrendahl/received_events","type":"User","site_admin":false},"html_url":"https://github.com/teddyrendahl/happi","description":"Heuristic Access to Positions of Photon Instruments","fork":true,"url":"https://api.github.com/repos/teddyrendahl/happi","forks_url":"https://api.github.com/repos/teddyrendahl/happi/forks","keys_url":"https://api.github.com/repos/teddyrendahl/happi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/teddyrendahl/happi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/teddyrendahl/happi/teams","hooks_url":"https://api.github.com/repos/teddyrendahl/happi/hooks","issue_events_url":"https://api.github.com/repos/teddyrendahl/happi/issues/events{/number}","events_url":"https://api.github.com/repos/teddyrendahl/happi/events","assignees_url":"https://api.github.com/repos/teddyrendahl/happi/assignees{/user}","branches_url":"https://api.github.com/repos/teddyrendahl/happi/branches{/branch}","tags_url":"https://api.github.com/repos/teddyrendahl/happi/tags","blobs_url":"https://api.github.com/repos/teddyrendahl/happi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/teddyrendahl/happi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/teddyrendahl/happi/git/refs{/sha}","trees_url":"https://api.github.com/repos/teddyrendahl/happi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/teddyrendahl/happi/statuses/{sha}","languages_url":"https://api.github.com/repos/teddyrendahl/happi/languages","stargazers_url":"https://api.github.com/repos/teddyrendahl/happi/stargazers","contributors_url":"https://api.github.com/repos/teddyrendahl/happi/contributors","subscribers_url":"https://api.github.com/repos/teddyrendahl/happi/subscribers","subscription_url":"https://api.github.com/repos/teddyrendahl/happi/subscription","commits_url":"https://api.github.com/repos/teddyrendahl/happi/commits{/sha}","git_commits_url":"https://api.github.com/repos/teddyrendahl/happi/git/commits{/sha}","comments_url":"https://api.github.com/repos/teddyrendahl/happi/comments{/number}","issue_comment_url":"https://api.github.com/repos/teddyrendahl/happi/issues/comments{/number}","contents_url":"https://api.github.com/repos/teddyrendahl/happi/contents/{+path}","compare_url":"https://api.github.com/repos/teddyrendahl/happi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/teddyrendahl/happi/merges","archive_url":"https://api.github.com/repos/teddyrendahl/happi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/teddyrendahl/happi/downloads","issues_url":"https://api.github.com/repos/teddyrendahl/happi/issues{/number}","pulls_url":"https://api.github.com/repos/teddyrendahl/happi/pulls{/number}","milestones_url":"https://api.github.com/repos/teddyrendahl/happi/milestones{/number}","notifications_url":"https://api.github.com/repos/teddyrendahl/happi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/teddyrendahl/happi/labels{/name}","releases_url":"https://api.github.com/repos/teddyrendahl/happi/releases{/id}","deployments_url":"https://api.github.com/repos/teddyrendahl/happi/deployments","created_at":"2018-02-12T21:57:37Z","updated_at":"2018-10-17T21:27:00Z","pushed_at":"2018-10-19T21:24:08Z","git_url":"git://github.com/teddyrendahl/happi.git","ssh_url":"git@github.com:teddyrendahl/happi.git","clone_url":"https://github.com/teddyrendahl/happi.git","svn_url":"https://github.com/teddyrendahl/happi","homepage":"https://pswww.slac.stanford.edu/swdoc/releases/skywalker/happi","size":256,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pcdshub:master","ref":"master","sha":"d461ab6e5bbddbe48008d881f07b9f68a7618bee","user":{"login":"pcdshub","id":31903189,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTAzMTg5","avatar_url":"https://avatars1.githubusercontent.com/u/31903189?v=4","gravatar_id":"","url":"https://api.github.com/users/pcdshub","html_url":"https://github.com/pcdshub","followers_url":"https://api.github.com/users/pcdshub/followers","following_url":"https://api.github.com/users/pcdshub/following{/other_user}","gists_url":"https://api.github.com/users/pcdshub/gists{/gist_id}","starred_url":"https://api.github.com/users/pcdshub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcdshub/subscriptions","organizations_url":"https://api.github.com/users/pcdshub/orgs","repos_url":"https://api.github.com/users/pcdshub/repos","events_url":"https://api.github.com/users/pcdshub/events{/privacy}","received_events_url":"https://api.github.com/users/pcdshub/received_events","type":"Organization","site_admin":false},"repo":{"id":82219847,"node_id":"MDEwOlJlcG9zaXRvcnk4MjIxOTg0Nw==","name":"happi","full_name":"pcdshub/happi","private":false,"owner":{"login":"pcdshub","id":31903189,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMxOTAzMTg5","avatar_url":"https://avatars1.githubusercontent.com/u/31903189?v=4","gravatar_id":"","url":"https://api.github.com/users/pcdshub","html_url":"https://github.com/pcdshub","followers_url":"https://api.github.com/users/pcdshub/followers","following_url":"https://api.github.com/users/pcdshub/following{/other_user}","gists_url":"https://api.github.com/users/pcdshub/gists{/gist_id}","starred_url":"https://api.github.com/users/pcdshub/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pcdshub/subscriptions","organizations_url":"https://api.github.com/users/pcdshub/orgs","repos_url":"https://api.github.com/users/pcdshub/repos","events_url":"https://api.github.com/users/pcdshub/events{/privacy}","received_events_url":"https://api.github.com/users/pcdshub/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pcdshub/happi","description":"Heuristic Access to Positions of Photon Instruments","fork":false,"url":"https://api.github.com/repos/pcdshub/happi","forks_url":"https://api.github.com/repos/pcdshub/happi/forks","keys_url":"https://api.github.com/repos/pcdshub/happi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pcdshub/happi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pcdshub/happi/teams","hooks_url":"https://api.github.com/repos/pcdshub/happi/hooks","issue_events_url":"https://api.github.com/repos/pcdshub/happi/issues/events{/number}","events_url":"https://api.github.com/repos/pcdshub/happi/events","assignees_url":"https://api.github.com/repos/pcdshub/happi/assignees{/user}","branches_url":"https://api.github.com/repos/pcdshub/happi/branches{/branch}","tags_url":"https://api.github.com/repos/pcdshub/happi/tags","blobs_url":"https://api.github.com/repos/pcdshub/happi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pcdshub/happi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pcdshub/happi/git/refs{/sha}","trees_url":"https://api.github.com/repos/pcdshub/happi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pcdshub/happi/statuses/{sha}","languages_url":"https://api.github.com/repos/pcdshub/happi/languages","stargazers_url":"https://api.github.com/repos/pcdshub/happi/stargazers","contributors_url":"https://api.github.com/repos/pcdshub/happi/contributors","subscribers_url":"https://api.github.com/repos/pcdshub/happi/subscribers","subscription_url":"https://api.github.com/repos/pcdshub/happi/subscription","commits_url":"https://api.github.com/repos/pcdshub/happi/commits{/sha}","git_commits_url":"https://api.github.com/repos/pcdshub/happi/git/commits{/sha}","comments_url":"https://api.github.com/repos/pcdshub/happi/comments{/number}","issue_comment_url":"https://api.github.com/repos/pcdshub/happi/issues/comments{/number}","contents_url":"https://api.github.com/repos/pcdshub/happi/contents/{+path}","compare_url":"https://api.github.com/repos/pcdshub/happi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pcdshub/happi/merges","archive_url":"https://api.github.com/repos/pcdshub/happi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pcdshub/happi/downloads","issues_url":"https://api.github.com/repos/pcdshub/happi/issues{/number}","pulls_url":"https://api.github.com/repos/pcdshub/happi/pulls{/number}","milestones_url":"https://api.github.com/repos/pcdshub/happi/milestones{/number}","notifications_url":"https://api.github.com/repos/pcdshub/happi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pcdshub/happi/labels{/name}","releases_url":"https://api.github.com/repos/pcdshub/happi/releases{/id}","deployments_url":"https://api.github.com/repos/pcdshub/happi/deployments","created_at":"2017-02-16T19:50:35Z","updated_at":"2018-10-18T23:16:02Z","pushed_at":"2018-10-19T21:36:51Z","git_url":"git://github.com/pcdshub/happi.git","ssh_url":"git@github.com:pcdshub/happi.git","clone_url":"https://github.com/pcdshub/happi.git","svn_url":"https://github.com/pcdshub/happi","homepage":"https://pcdshub.github.io/happi","size":7493,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":19,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":9,"open_issues":19,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pcdshub/happi/pulls/76"},"html":{"href":"https://github.com/pcdshub/happi/pull/76"},"issue":{"href":"https://api.github.com/repos/pcdshub/happi/issues/76"},"comments":{"href":"https://api.github.com/repos/pcdshub/happi/issues/76/comments"},"review_comments":{"href":"https://api.github.com/repos/pcdshub/happi/pulls/76/comments"},"review_comment":{"href":"https://api.github.com/repos/pcdshub/happi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pcdshub/happi/pulls/76/commits"},"statuses":{"href":"https://api.github.com/repos/pcdshub/happi/statuses/f6ffc0234e47e16a21fbefe1c407791f357598a5"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"ZLLentz"}}