{"action":"created","issue":{"url":"https://api.github.com/repos/Calinou/godot-sponza/issues/70","repository_url":"https://api.github.com/repos/Calinou/godot-sponza","labels_url":"https://api.github.com/repos/Calinou/godot-sponza/issues/70/labels{/name}","comments_url":"https://api.github.com/repos/Calinou/godot-sponza/issues/70/comments","events_url":"https://api.github.com/repos/Calinou/godot-sponza/issues/70/events","html_url":"https://github.com/Calinou/godot-sponza/issues/70","id":300861093,"number":70,"title":"Finer control over resolution and rendering options?","user":{"login":"cfcohen","id":2515512,"avatar_url":"https://avatars3.githubusercontent.com/u/2515512?v=4","gravatar_id":"","url":"https://api.github.com/users/cfcohen","html_url":"https://github.com/cfcohen","followers_url":"https://api.github.com/users/cfcohen/followers","following_url":"https://api.github.com/users/cfcohen/following{/other_user}","gists_url":"https://api.github.com/users/cfcohen/gists{/gist_id}","starred_url":"https://api.github.com/users/cfcohen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfcohen/subscriptions","organizations_url":"https://api.github.com/users/cfcohen/orgs","repos_url":"https://api.github.com/users/cfcohen/repos","events_url":"https://api.github.com/users/cfcohen/events{/privacy}","received_events_url":"https://api.github.com/users/cfcohen/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-02-28T01:52:06Z","updated_at":"2018-03-01T03:42:10Z","closed_at":null,"author_association":"NONE","body":"This demo was an excellent introduction to the new Godot 3.0 rendering engine.  Thank you for providing it! This \"issue\" is really just a new feature suggestion.\r\n\r\nOn my dual 4K monitors with a GTX970 I initially had a very low frame rate (~3 FPS).  I know, it's shocking!  But seriously, I had some trouble understanding how to control the resolution, the rendering quality and the fullscreen options because of the way that the options were inter-related.  Being able to control the resolution independently of the fullscreen option would be particularly useful.   Also, I was interested in toggling each of the advanced rendering options independently to compare appearance and frame rates.  I was able address most of these issues by loading the project in the Godot editor and adjusting the settings manually, but this demo would be greatly improved by making them more configurable at run time.\r\n\r\nAlso I noticed that that the model at http://www.crytek.com/cryengine/cryengine3/downloads was slightly different, containing some foliage and other features missing from the Godot demo.  Was this just because it was built with an older version of the model or was there a specific decision to exclude portions of the asset?\r\n\r\nThanks again for a great demo!"},"comment":{"url":"https://api.github.com/repos/Calinou/godot-sponza/issues/comments/369464817","html_url":"https://github.com/Calinou/godot-sponza/issues/70#issuecomment-369464817","issue_url":"https://api.github.com/repos/Calinou/godot-sponza/issues/70","id":369464817,"user":{"login":"cfcohen","id":2515512,"avatar_url":"https://avatars3.githubusercontent.com/u/2515512?v=4","gravatar_id":"","url":"https://api.github.com/users/cfcohen","html_url":"https://github.com/cfcohen","followers_url":"https://api.github.com/users/cfcohen/followers","following_url":"https://api.github.com/users/cfcohen/following{/other_user}","gists_url":"https://api.github.com/users/cfcohen/gists{/gist_id}","starred_url":"https://api.github.com/users/cfcohen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cfcohen/subscriptions","organizations_url":"https://api.github.com/users/cfcohen/orgs","repos_url":"https://api.github.com/users/cfcohen/repos","events_url":"https://api.github.com/users/cfcohen/events{/privacy}","received_events_url":"https://api.github.com/users/cfcohen/received_events","type":"User","site_admin":false},"created_at":"2018-03-01T03:42:10Z","updated_at":"2018-03-01T03:42:10Z","author_association":"NONE","body":"Thank you for taking the time to respond to my comments.  You wrote:\r\n\r\n> The viewport scaling mode affects everything (including the GUI) and uses nearest-neighbor filtering, making it unsuitable for this.\r\n\r\nI changed the width and hieght of the window in the project settings, then I set the stretch mode to viewport.  After re-exporting, the fullscreen choice appeared to run at the window resolution that I exported (or at least the visual appearance and frame rates varied as expected).  I did not find the scaling of the GUI objectionable.  I had presumed that you could control all of those settings during the execution, but I opened an issue rather than submitting a pull request because I don't really know.  \r\n\r\nI guess your point here was that this wasn't really the correct way to have handled that, but at least it allowed me to view the demo in fullscreen and have a double digit frame rate, which certainly improved my experience,even if it wasn't optimal. ;-)\r\n\r\n> I haven't got transparency to work on the foliage since the original textures seem to use a solid color to indicate transparency, which Godot doesn't support as far as I know.\r\n\r\nI noticed the same thing when I loaded the Crytek model into blender, and I wondered if that was a bug in the model.  I asked about it partially because I was curious to see how Godot handled the transparency.  Now that you've told me that it was there, I was able to disable the transparency in the project and see the foliage, but as expected it looks strange because of the texture color problems.  At least I understand better now.\r\n\r\nThanks again for making this available.  Godot 3 is so new that there aren't as many demos showcasing the 3D render's capabilities as I would like so I keep reopening this project to experiment with things (like using the debugger to monitor vertex counts).  I was initially surprised to see that the vertex count was constant, but then I realized that the entire scene was a single mesh instance. Have you tried exporting the scene with multiple geometries, and if you did would view frustrum culling happen?\r\n\r\nSorry to ask some many newbie questions, but the demo is great learning tool."}}
{"actor":{"display_login":"cfcohen"}}